profile
viewpoint

dungeonfog/cef 22

Safe Wrapper Around the Chromium Embedded Framework (WIP)

dungeonfog/cef-sys 21

My own attempt at bringing the Chromium Embedded Framework to Rust via its C API

Osspial/derin 18

A Derive-Based GUI Library for Rust

Osspial/glyphydog 5

Glyphier Glyphs

Osspial/gullery 2

Safe, low-level OpenGL wrapper with GLSL type checking and compressed texture support

Osspial/android-ndk-rs 0

Rust bindings to the Android NDK

Osspial/android-rs-glue 0

Glue between Rust and Android

Osspial/arrayvec 0

A vector with a fixed capacity. (Rust)

Osspial/cargo-make 0

Rust task runner and build tool.

startedMaxx53/NoCableLauncher

started time in a month

pull request commentrust-windowing/winit

Add custom cursor icon support on Windows

This change removes the Send trait from winit::window::CursorIcon for Windows, which is kinda a big deal. Is there a way to get it back?

Yep! That was just an oversight - the implementation was written with Send and Sync in mind, but I forgot to mark the relevant types with those traits. That's fixed now.

Osspial

comment created time in a month

push eventOsspial/winit

Osspial

commit sha 9b7ea98158f74304b21302f15fa0c8cfb44bd6f3

Implement both send and sync for RaiiIcon

view details

push time in a month

push eventOsspial/winit

Christian Duerr

commit sha 55dff53a98097824db0460d9d7083a842f923783

Fix Window platform support documentation This resolves various problems with the documentation about platform support on the Window struct. It also completely removes pointless runtime errors in favor of consistent no-ops on all platforms that do not support a certain features.

view details

Christian Duerr

commit sha 40232d48ba3c80ba076ea1dc1fbb7d1c6fc80aac

Use `PhysicalPosition` in `PixelDelta` event This removes the `LogicalPosition` from the `PixelDelta`, since all other APIs have been switched to use `PhysicalPosition` instead. Fixes #1406.

view details

Christian Duerr

commit sha 7a49c88200fe2a9559c8cc9098f38e209567f691

Fix with_fullscreen signature

view details

josh65536

commit sha 05fdcb5b270062b4bc85d3433ed12551f8a6741d

Web: Use mouse events instead of pointer events if the latter isn't supported (#1630) * Fixed Safari not getting mouse events * Edited changelog * Addressed compiler warnings Co-authored-by: Ryan G <ryanisaacg@users.noreply.github.com>

view details

msiglreith

commit sha 68100102be588aea3dd42cb64647e1f8624615b2

android: fix event loop polling (#1638) * android: poll looper for ControlFlow::Poll and don't exit when no new event received * Add Android ControlFlow:Poll fix to CHANGELOG

view details

TakWolf

commit sha 514ab043f21447ec1fd6f5cc09ee9b5e65663517

[macos] add NSWindow.hasShadow support (#1637) * [macos] add NSWindow.hasShadow * change log * cargo fmt * Update CHANGELOG.md * Update src/platform_impl/macos/window.rs * Update src/platform/macos.rs * set_has_shadow() with cuter format * adjust code * cargo fmt * changelog

view details

simlay

commit sha 412bd94ea473c7b175f94a190d66f4be3e92aaab

Renamed NSString to NSStringRust to support Debug View Heirarchy in Xcode (#1631) * Renamed NSString to NSStringRust to support Debug View Heirarchy * Updated from comments * Update CHANGELOG.md

view details

Michael Kirk

commit sha 9c72cc2a983401ad96f40555751bbfa1335259b6

Fix HiDPI vs. set_cursor_icon for web (#1652) PhysicalSize is recorded as canvas.size, whereas LogicalSize is stored as canvas.style.size. The previous cursor behavior on stdweb clobbered all style - thus losing the LogicalSize.

view details

Christian Duerr

commit sha 89d4c06decf95bfcc0c11d86bb8eb0f9f634cb36

Fix crash on NetBSD The `_lwp_self` function cannot be used to reliably determine the main thread, see https://github.com/alacritty/alacritty/issues/2631#issuecomment-676723289. It might always be equal to the PID, but it's certainly not always 1 when the thread is the main thread. However, Rust's built in `Thread::id` and `Thread::name` function will always return `ThreadId(1)` and `Some("main")`. Since converting the thread's ID to a number is not supported on stable Rust, checking that the thread is labeled `Some("main")` seems like the most reliable option. It should also be a good fallback in general.

view details

alvinhochun

commit sha 6ba583d19896172f5eca9d8551119906e4eff2b2

Fix vertical scroll being inverted on web targets (#1665)

view details

alvinhochun

commit sha 0f7c82d38fbe52831a51d5b2523e838d1da02407

Send CursorMove before mouse press event and note that touch is unimplemented on web target (#1668) * Change to send CursorMove before mouse press event on web target * Fix feature matrix to indicate touch being unimplemented on web

view details

alvinhochun

commit sha bea60930b685641756d441fc83d06e4730d332b2

Use send_events instead of send_event in web backend (#1681)

view details

alvinhochun

commit sha 02a34a167ab281d7cca9908f67928b659d428b39

Impl. mouse capturing on web target (#1672) * Impl. mouse capturing for web-sys with PointerEvent * Impl. mouse capturing for web-sys with MouseEvent by manual tracking * Reorganize web-sys backend mouse and pointer handling code * Impl. mouse capturing for stdweb with PointerEvent * Add mouse capturing for web target to changelog

view details

Christian Duerr

commit sha a2db4c0a320aafc10d240c432fe5ef4e4d84629d

Unify Minus/Subtract virtual keycodes On all platforms other than Linux/X11, the Subtract key was uniformly used only for the Numpad. To make this cross-platform compatible, the `-` key will now map to `Minus` on X11 instead of `Subtract`. Since people have been confused about the difference between `Minus` and `Subtract` in the past, the `Subtract` key has also been renamed to `NumpadSubtract`. This is a breaking change that might be annoying to downstream since there's no direct improvement, but it should help new users in the future. Alternatively this could just be documented, rather than explicitly mentioning the Numpad in the name.

view details

alvinhochun

commit sha 658a9a4ea8b50c5279042aa2a23f27fc583bb878

Handle scale factor change on web-sys backend (#1690) * Change web backend `event_handler` to without 'static lifetime * Refactor web runner and fix ControlFlow::Exit not being sticky * Impl. scaling change event for web-sys backend * Improve `dpi` docs regarding the web backend * Add changes to changelog * Update features.md

view details

Michael Kirk

commit sha e2cf2a5754f6ee51a37fbe6e1f8b5ff8bd98da49

Fix inverted horizontal scroll on macOS In winit the swipe from left to right on touchpad should generate positive horizontal delta change, however on macOS it was the other way around without natural scrolling. This commit inverses the horizontal scrolling delta in 'MouseScrollDelta' events to match other platforms. Fixes #1695.

view details

Kirill Chibisov

commit sha cac627ed05588ef6cbbce7a1e837a0b4016e61fe

Make 'current_monitor' return 'Option<MonitorHandle>' On certain platforms window couldn't be on any monitor resulting in failures of 'current_monitor' function. Such issue was happening on Wayland, since the window isn't on any monitor, unless the user has drawn something into it. Returning 'Option<MonitorHandle>' will give an ability to handle such situations gracefully by properly indicating that there's no current monitor. Fixes #793.

view details

Kirill Chibisov

commit sha d103dc263104c4ceb8607dc3f8d150f80f915a4e

Make 'primary_monitor' return 'Option<MonitorHandle>' Certain platforms like Wayland don't have a concept of primary Monitor in particular. To indicate that 'primary_monitor' will return 'None' as well as in cases where the primary monitor can't be detected. Fixes #1683.

view details

Josh Groves

commit sha 21f9aefc7ed4a564f20985dcac032d504cc7ce3b

Update macOS dependencies Fixes #1658.

view details

Logan Magee

commit sha c66489dbb111ed5a4d27265edbcd5d965382ac94

Bump parking_lot to 0.11 Fixes #1657.

view details

push time in a month

push eventOsspial/winit

Osspial

commit sha 058fcd7a1039ecba4d4656be76608b74248af87b

Format

view details

push time in 2 months

push eventOsspial/winit

Osspial

commit sha a030c6c74346096d0ba23d4341a6e0b886261b8b

Attempt again

view details

push time in 2 months

push eventOsspial/winit

Osspial

commit sha 186c03baff964a5e42a8ecc4a88e8dc6a06b9946

Try to fix macos build

view details

push time in 2 months

push eventdungeonfog/cef

Osspial

commit sha cbed60a50c47230e8bf7ccd4e5aa127e0f899cdd

Implement DPI scaling for custom cursors

view details

push time in 2 months

push eventdungeonfog/cef

Osspial

commit sha 42745cb06e3f63d037d947ea053411fefe139e75

Implement DPI scaling for custom cursors

view details

push time in 2 months

push eventdungeonfog/cef

Osspial

commit sha f805f3fc1e89fb45521f9e1c684f6f3cfd6224aa

Update Winit custom cursor to newest API

view details

push time in 2 months

push eventrust-windowing/raw-window-handle

Lokathor

commit sha 73a41ea28907b0f261816136b1b3f39cfdd791f3

Remove the dependency on libc (#51)

view details

push time in 3 months

PR merged rust-windowing/raw-window-handle

Remove the dependency on libc

This PR completely removes the dependency on libc.

It was used to get a c_void type, but core::ffi::c_void is sufficient.

It was also used to get c_ulong, but we can simply define the type ourselves in the one location that requires it.

Closes https://github.com/rust-windowing/raw-window-handle/issues/3

+10 -8

4 comments

6 changed files

Lokathor

pr closed time in 3 months

issue closedrust-windowing/raw-window-handle

Prefer `core::ffi::c_void` type over `libc::c_void`

All c_void are in some sense similar since you can always just cast between them, however, since core offers a c_void type we should at least use that common point of communication as much as possible.

closed time in 3 months

Lokathor

pull request commentrust-windowing/raw-window-handle

Remove the dependency on libc

So, it turns out that this change isn't actually breaking, since libc's c_void type is just a re-export of core's c_void type. I'll go ahead and publish this, and if it turns out to break code we can just yank the release.

Lokathor

comment created time in 3 months

push eventOsspial/raw-window-handle

Osspial

commit sha 1947c8e25a57d7c624ac27ffae3d5f0df1fc82a7

Disable default features properly in libc

view details

push time in 3 months

push eventrust-windowing/raw-window-handle

Lokathor

commit sha 99fc6e63efa35e26fdace6f593a0896b6fa88a79

Add Apache-2.0 and Zlib license options. (#50)

view details

push time in 3 months

PR merged rust-windowing/raw-window-handle

Add Apache-2.0 and Zlib license options.

This PR adds the "rust standard" Apache-2.0 license as a license option, as well as the Zlib license because it's even more permissive than the MIT license. The MIT license is of course also still an option.

Being a change in license, this will need the following folks to agree:

  • [x] Osspial
  • [x] Didgy74
  • [x] ryanisaacg
  • [x] repi
  • [x] msiglreith
  • [x] dxenonb
  • [x] aloucks
  • [ ] LeshaInc
  • [x] Dispersia

Closes https://github.com/rust-windowing/raw-window-handle/issues/41

+189 -1

6 comments

4 changed files

Lokathor

pr closed time in 3 months

issue closedrust-windowing/raw-window-handle

Additional Licenses

It's traditional for core Rust projects to be MIT OR Apache-2.0. Personally I also like to see the Zlib license as an option as well.

Could we get additional license options for Apache-2.0 at least, and possibly Zlib as well?

This would need a sign off from all those who have added code (I'll list them here without pings and we can ping them if people generally agree with this issue at all).

  • Osspial (lead)
  • LeshaInc marked stuff as "derive Hash" but I don't think that's significant.
  • aloucks similarly put the initial derives on the enum
  • dxenonb added readme stuff but not code
  • msiglreith renamed a field and added some docs lines
  • repi helped fix the last license thing actually, but no code changes.
  • ryanisaacg added the web handle
  • Didgy74 added XCB and Android.

closed time in 3 months

Lokathor

issue commentalacritty/alacritty

Broken App bar (font size tiny on 4k)

Winit calls EnableNonClientDpiScaling as suggested by the linked stackoverflow post (here), so it's not entirely clear what's going on here. I'm also not able to reproduce this issue - whenever I run Alacritty 5 with the Windows scale factor set to 125%, the titlebar looks like this:

image

With these logs:

[2020-08-06 14:49:55.391562000] [DEBUG] Estimated DPR: 1.25
[2020-08-06 14:49:55.391562000] [DEBUG] Estimated Cell Size: 9 x 19
[2020-08-06 14:49:55.391562000] [DEBUG] Estimated Dimensions: None
[2020-08-06 14:49:55.733558800] [INFO] Device pixel ratio: 1.25
[2020-08-06 14:49:55.737558600] [INFO] Initializing glyph cache...
[2020-08-06 14:49:55.738559800] [INFO] ... finished initializing glyph cache in 0.0008623s
[2020-08-06 14:49:55.738559800] [INFO] Cell Size: 9 x 19
[2020-08-06 14:49:55.738559800] [INFO] Padding: 0 x 0
[2020-08-06 14:49:55.738559800] [INFO] Width: 1024, Height: 768
[2020-08-06 14:49:55.777561000] [INFO] PTY dimensions: Line(40) x Column(113)
[2020-08-06 14:49:55.781563200] [INFO] Using ConPTY backend
[2020-08-06 14:49:55.781563200] [INFO] Initialisation complete
[2020-08-06 14:49:55.783560600] [DEBUG] New num_cols is 113 and num_lines is 38
[2020-08-06 14:49:55.783560600] [INFO] Width: 1024, Height: 768

What version of Windows 10 are you on?

desmap

comment created time in 3 months

push eventdungeonfog/cef

Osspial

commit sha f713f83dc54f3c06a769399fa649c1959df78928

Upgrade to CEF 84

view details

push time in 3 months

push eventdungeonfog/cef-sys

Osspial

commit sha a3d43fc9a624dc00e5a5cea90eebf88fd6c4aa5c

Update to CEF 84

view details

push time in 3 months

issue openeddungeonfog/cef-sys

Build script should be rerun when input environment variables are changed

We used to do this, but that behavior was disabled in 942d8535fdf623399910a5c07f86a85f175bdd2b because it doesn't play well with setting environment variables in cargo make and trying to use rust-analyzer at the same time. cargo make would set the environment variables and do a successful build, but when rust-analyzer would run cargo check it would force cef-sys and all dependencies to be rebuilt since it didn't have the environment variables set.

Relevant issues: https://github.com/rust-lang/cargo/issues/6834 https://github.com/rust-lang/cargo/issues/4001

created time in 3 months

push eventdungeonfog/cef

Osspial

commit sha e823f17b4bc0abb06916d17faf77883a399bdd11

Switch to a cef version that ignores environment variable changes

view details

push time in 3 months

push eventdungeonfog/cef-sys

Osspial

commit sha 942d8535fdf623399910a5c07f86a85f175bdd2b

Remove rereun-if-env-changed from build script

view details

push time in 3 months

Pull request review commentrust-windowing/winit

Add custom cursor icon support on Windows

 pub(crate) struct Pixel {  pub(crate) const PIXEL_SIZE: usize = mem::size_of::<Pixel>(); -#[derive(Debug)]-/// An error produced when using `Icon::from_rgba` with invalid arguments.-pub enum BadIcon {-    /// Produced when the length of the `rgba` argument isn't divisible by 4, thus `rgba` can't be-    /// safely interpreted as 32bpp RGBA pixels.-    ByteCountNotDivisibleBy4 { byte_count: usize },-    /// Produced when the number of pixels (`rgba.len() / 4`) isn't equal to `width * height`.-    /// At least one of your arguments is incorrect.-    DimensionsVsPixelCount {-        width: u32,-        height: u32,-        width_x_height: usize,-        pixel_count: usize,-    },-    /// Produced when underlying OS functionality failed to create the icon-    OsError(io::Error),-}--impl fmt::Display for BadIcon {-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {-        match self {-            BadIcon::ByteCountNotDivisibleBy4 { byte_count } => write!(f,-                "The length of the `rgba` argument ({:?}) isn't divisible by 4, making it impossible to interpret as 32bpp RGBA pixels.",-                byte_count,-            ),-            BadIcon::DimensionsVsPixelCount {-                width,-                height,-                width_x_height,-                pixel_count,-            } => write!(f,-                "The specified dimensions ({:?}x{:?}) don't match the number of pixels supplied by the `rgba` argument ({:?}). For those dimensions, the expected pixel count is {:?}.",-                width, height, pixel_count, width_x_height,-            ),-            BadIcon::OsError(e) => write!(f, "OS error when instantiating the icon: {:?}", e),-        }-    }-}--impl Error for BadIcon {-    fn source(&self) -> Option<&(dyn Error + 'static)> {-        Some(self)-    }-}--#[derive(Debug, Clone, PartialEq, Eq)]-pub(crate) struct RgbaIcon {-    pub(crate) rgba: Vec<u8>,-    pub(crate) width: u32,-    pub(crate) height: u32,+#[derive(Clone, PartialEq, Eq, Hash)]+pub struct RgbaIcon<I: Deref<Target = [u8]>> {+    pub(crate) rgba: I,+    pub(crate) size: PhysicalSize<u32>,+    pub(crate) hot_spot: PhysicalPosition<u32>,

That's a decent point. I've updated the API to split the custom window type and custom cursor type into two parts, though it's not documented yet. Could you take a look at it?

Osspial

comment created time in 3 months

Pull request review commentrust-windowing/winit

Add custom cursor icon support on Windows

 impl fmt::Debug for Icon { impl Icon {     /// Creates an `Icon` from 32bpp RGBA data.     ///-    /// The length of `rgba` must be divisible by 4, and `width * height` must equal-    /// `rgba.len() / 4`. Otherwise, this will return a `BadIcon` error.-    pub fn from_rgba(rgba: Vec<u8>, width: u32, height: u32) -> Result<Self, BadIcon> {+    /// ## Panics+    /// Panics if the length of `rgba` must be divisible by 4, or if `width * height` doesn't equal+    /// `rgba.len() / 4`.+    pub fn from_rgba(rgba: &[u8], size: PhysicalSize<u32>) -> Result<Self, io::Error> {+        Ok(Icon {+            inner: PlatformIcon::from_rgba(rgba.into(), size)?,+        })+    }++    /// Creates an `Icon` from 32bpp RGBA data, with a defined cursor hot spot. The hot spot is+    /// the exact pixel in the icon image where the cursor clicking point is, and is ignored when+    /// the icon is used as a window icon.+    ///+    /// ## Panics+    /// Panics if the length of `rgba` must be divisible by 4, or if `width * height` doesn't equal+    /// `rgba.len() / 4`.+    pub fn from_rgba_with_hot_spot(+        rgba: &[u8],+        size: PhysicalSize<u32>,+        hot_spot: PhysicalPosition<u32>,+    ) -> Result<Self, io::Error> {+        Ok(Icon {+            inner: PlatformIcon::from_rgba_with_hot_spot(rgba.into(), size, hot_spot)?,+        })+    }++    /// Lazily create an icon from several scaled source images.+    ///+    /// `get_icon` will be lazily called for a particular icon size whenever the window manager+    /// needs an icon of that size. The `PhysicalSize<u32>` parameter specifies the window manager's+    /// suggested icon size for a particular scale factor, and will always be a square. The `f64`+    /// parameter specifies the scale factor that the window manager is requesting the icon with.+    /// `get_icon` will only be called once for any given suggested icon size.+    ///+    /// If `get_icon` returns `Err(e)` for a given size, Winit will invoke `warn!` on the returned+    /// error and will try to retrieve a differently-sized icon from `get_icon`.+    pub fn from_rgba_fn<F, B>(mut get_icon: F) -> Result<Self, std::io::Error>

io::Error is used as the standard OS error type in Rust, even in cases where the error isn't directly related to IO (see io::Error::last_os_error()). Still, it's not relevant for this function since get_icon is supposed to be called lazily, so I've changed the function to return Self instead of a Result.

Osspial

comment created time in 3 months

push eventOsspial/winit

Osspial

commit sha 4bea10263f24c3a1f030376d438fa3ed7018ff33

Redesign cursor API and implement on Windows

view details

Osspial

commit sha b21a92e0c92facda80518d5988c164c489487f02

Make this compile on Linux

view details

push time in 3 months

issue commentalacritty/alacritty

Can't place window on secondary monitor since 0.5.0

This looks like an Alacritty bug, not a Winit bug. Alacritty's set_outer_position wrapper takes a PhysicalPosition<u32> instead of a PhysicalPosition<i32>, which discards any negative coordinates:

https://github.com/alacritty/alacritty/blob/9167461eb35687872a7670b2e7105a56244f7a48/alacritty/src/window.rs#L337-L339

Winit's set_outer_position function is generic over the position type, so if Alacritty passes it a type with negative numbers it should handle them fine.

darsain

comment created time in 3 months

issue commentrust-windowing/winit

On Windows, `with_position` does not accept negative coordinates anymore

Could you provide more details? WindowBuilder doesn't have a with_position method, and the following example properly sets the window position to (-200, -200) on my system:

use winit::{
    event::{Event, WindowEvent},
    event_loop::{ControlFlow, EventLoop},
    window::WindowBuilder,
};

fn main() {
    simple_logger::init().unwrap();
    let event_loop = EventLoop::new();

    let window = WindowBuilder::new()
        .with_title("A fantastic window!")
        .with_inner_size(winit::dpi::LogicalSize::new(500.0, 500.0))
        .build(&event_loop)
        .unwrap();
    window.set_outer_position(winit::dpi::PhysicalPosition::new(-200, -200));

    event_loop.run(move |event, _, control_flow| {
        *control_flow = ControlFlow::Wait;
        // println!("{:?}", event);

        match event {
            Event::WindowEvent {
                event: WindowEvent::CloseRequested,
                window_id,
            } if window_id == window.id() => *control_flow = ControlFlow::Exit,
            Event::MainEventsCleared => {
                println!("{:?}", window.outer_position());
                window.request_redraw();
            }
            _ => (),
        }
    });
}
chrisduerr

comment created time in 3 months

pull request commentrust-windowing/raw-window-handle

Remove the dependency on libc

If you can figure out a good solution to the c_ulong issue, I'd be fine with holding this PR open for whenever the next breaking release happens. Also, we could do a 1.0 release without having it break anything with the semver trick.

Lokathor

comment created time in 3 months

push eventrust-windowing/raw-window-handle

Lokathor

commit sha 3300b7b3ec9e49923f1e20114cfd8846d7f0f784

add TrustedHandle type (#52)

view details

push time in 3 months

PR merged rust-windowing/raw-window-handle

add TrustedHandle type

Add a wrapper to mark when a specific raw window handle is to be trusted.

Closes https://github.com/rust-windowing/raw-window-handle/issues/49

+28 -0

0 comment

1 changed file

Lokathor

pr closed time in 3 months

issue closedrust-windowing/raw-window-handle

Implement HasRawWindowHandle for RawWindowHandle

Currently, there is only one way to go from winit::Window to RawWindowHandle. Once you get a raw window handle, everything at the lower level has to work with it directly. This is an unfortunate limitation.

For example, gfx-backend-vulkan::Instance::create_surface expects HasRawWindowHandle. That means we can't get RawWindowHandle at any layer above it, but sometimes we really want that, e.g. when we construct RawWindowHandle manually on the client side.

closed time in 3 months

kvark

pull request commentrust-windowing/raw-window-handle

Remove the dependency on libc

I'm not particularly happy with having this crate export its own c_ulong type. On top of that, merging this PR would require us to release a breaking release, and I don't think dropping the libc dependency is enough of an improvement to justify that, especially when most of the higher-level windowing libraries that depend on this pull in libc anyway.

Lokathor

comment created time in 3 months

issue closeddungeonfog/cef

cefsimple does not compile on Windows

I'm using nightly-x86_64-pc-windows-msvc 1.47.0-nightly

warning: variable does not need to be mutable
  --> examples\cefsimple\main.rs:84:9
   |
84 |     let mut logger_builder = Logger::builder();
   |         ----^^^^^^^^^^^^^^
   |         |
   |         help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

error[E0382]: use of moved value: `logger_builder`
   --> examples\cefsimple\main.rs:86:27
    |
84  |     let mut logger_builder = Logger::builder();
    |         ------------------ move occurs because `logger_builder` has type `cef::logging::LoggerBuilder`, which does not implement the `Copy` trait
85  |     logger_builder.level(log::LevelFilter::Info);
    |                    ----------------------------- `logger_builder` moved due to this method call
86  |     let logger = Box::new(logger_builder.build());
    |                           ^^^^^^^^^^^^^^ value used here after move
    |
note: this function consumes the receiver `self` by taking ownership of it, which moves `logger_builder`
   --> D:\Darmok\Documents\Projects\cef\src\logging.rs:114:22
    |
114 |     pub fn level(mut self, level: log::LevelFilter) -> Self {
    |                      ^^^^

error: aborting due to previous error; 1 warning emitted

For more information about this error, try `rustc --explain E0382`.
error: could not compile `cef`.

To learn more, run the command again with --verbose.

closed time in 3 months

Altenius

issue commentdungeonfog/cef

cefsimple does not compile on Windows

Should be fixed on the latest master. Thanks for the bug report!

Altenius

comment created time in 3 months

push eventdungeonfog/cef

Osspial

commit sha 51991e09df99c40532a2c2664910fd5d582d927b

Fix cefsimple build

view details

push time in 3 months

Pull request review commentrust-windowing/winit

Add custom cursor icon support on Windows

 use crate::window::CursorIcon;+use std::mem;  use super::*;  impl XConnection {     pub fn set_cursor_icon(&self, window: ffi::Window, cursor: Option<CursorIcon>) {+        // ignore custom cursors for now+        let cursor = match cursor {+            Some(CursorIcon::Custom(_)) => Some(CursorIcon::default()),

Good point. That's been corrected.

Osspial

comment created time in 3 months

push eventOsspial/winit

Osspial

commit sha 9ee8a78be6f087b5c0d5abea5c7a50f1e966f89d

Improve code quality of X11 custom cursor ignore

view details

push time in 3 months

push eventOsspial/winit

Osspial

commit sha 5409114833831a3afa6ac0d686218ee793d1fc50

Update src/icon.rs Co-authored-by: Kirill Chibisov <contact@kchibisov.com>

view details

push time in 3 months

push eventOsspial/winit

Osspial

commit sha da43221678eda4b147173cbe3e0c9ef75a3fafe0

Update src/icon.rs Co-authored-by: Kirill Chibisov <contact@kchibisov.com>

view details

push time in 3 months

push eventOsspial/winit

Osspial

commit sha 17d6f2e698d9ac4f96a1fc6c6f46bd867db8930b

Update src/icon.rs Co-authored-by: Kirill Chibisov <contact@kchibisov.com>

view details

push time in 3 months

push eventOsspial/winit

Osspial

commit sha b402c2da95397639932f2e0cc1bd43c1c250be8b

Update CHANGELOG.md Co-authored-by: Kirill Chibisov <contact@kchibisov.com>

view details

push time in 3 months

push eventOsspial/winit

Osspial

commit sha 3c61b2afd8576b64bdd4e36884bd3608e0ddfc69

Update src/icon.rs Co-authored-by: Kirill Chibisov <contact@kchibisov.com>

view details

push time in 3 months

more