profile
viewpoint

http-rs/surf 866

Fast and friendly HTTP client framework for async Rust

Lokathor/tinyvec 192

Just, really the littlest Vec you could need. So smol.

Nemo157/async-compression 113

Adaptors between compression crates and Rust's async IO types

mycorrhiza/bs58-rs 18

Another Rust Base58 codec implementation

mycorrhiza/varmint-rs 5

A Rust implementation of the varint codec as used in Google's Protocol Buffers.

mycorrhiza/ipfsdc-rs 2

An IPFS (ipfs.io) daemon command line client

PullRequestReviewEvent

delete branch Nemo157/docs.rs

delete branch : update-index-map

delete time in 2 days

issue openedlaunchbadge/sqlx

Bad conversion from non-UTC timestamptz with postgres

This comment here is incorrect:

https://github.com/launchbadge/sqlx/blob/2e1658e08b053f66102b5beabc7fdd4ac28e3a48/sqlx-core/src/postgres/types/chrono/datetime.rs#L79-L81

If you have a connection set to use a non-UTC timezone you will get a response with timestamps in that timezone. After overriding the executor to use PgValueFormat::Text for responses and adding some extra debugging code, running the following code:

let date = Utc.ymd(2020, 1, 1).and_hms(1, 1, 1);
let mut conn = pool.acquire().await?;
sqlx::query("SET TIME ZONE 'Europe/Berlin'")
    .fetch_optional(&mut conn).await?;
let row: (DateTime<Utc>,) = sqlx::query_as("SELECT $1::timestamptz")
    .bind(&date)
    .fetch_one(&mut conn).await?;

assert_eq!(row.0, date);

The assertion failed because the timezone on the response was not taken into account

[/tmp/tmp.ErEoBwofoQ/sqlx-core-0.4.0-beta.1/src/postgres/types/chrono/datetime.rs:79] ("decode", s) = (
    "decode", "2020-01-01 01:01:01+01",
)
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `2020-01-01T02:01:01Z`,
 right: `2020-01-01T01:01:01Z`', src/main.rs:19:5

I can't see any way to trigger this behaviour from outside sqlx-core since it always uses the binary format for responses, but it seems like a potential footgun to leave around in case this does someday become configurable.

created time in 2 days

issue commentrust-lang/docs.rs

Convert all timestamps to TIMESTAMP WITH TIMEZONE

It looks like sqlx should be fine with converting between timestamp without timezone and DateTime<Utc>, it literally does the same Naive conversion when encoding and decoding as we do manually.

jyn514

comment created time in 2 days

pull request commentrust-lang/docs.rs

Update index map

https://github.com/bluss/indexmap/pull/131, sounds like it's a large benefit.

Nemo157

comment created time in 2 days

issue commentrust-lang/docs.rs

Convert all timestamps to TIMESTAMP WITH TIMEZONE

Yep, because we're explicitly storing UTC timestamps in the database. Using timestamp with timezone doesn't get you any advantage over that (other than confusion when you have a connection with a non-UTC timezone on it).

jyn514

comment created time in 2 days

PR opened rust-lang/docs.rs

Update index map

Avoids rebuilding every time (https://github.com/bluss/indexmap/issues/123)

+9 -2

0 comment

1 changed file

pr created time in 2 days

create barnchNemo157/docs.rs

branch : update-index-map

created branch time in 2 days

issue commentrust-lang/docs.rs

Convert all timestamps to TIMESTAMP WITH TIMEZONE

timestamp without timezone is easier to work with. Postgres doesn’t actually store timezones, it just converts between UTC and the connections timezone when reading.

jyn514

comment created time in 3 days

issue commentrust-lang/docs.rs

Switch to sqlx for compile-time checked queries

(compare link: https://github.com/rust-lang/docs.rs/compare/master...jyn514:sqlx)

jyn514

comment created time in 3 days

issue commentrust-lang/futures-rs

Question: What happened to `futures-tls`?

It appears that futures-tls was split out to tokio-tls before 0.1.1 was released (which is the oldest tagged version, and 0.1.0 is yanked). See https://github.com/rust-lang/futures-rs/commit/b6936a1282a5a5ccb9cfcb032f09062fc19c2453

xpepermint

comment created time in 3 days

push eventNemo157/dotfiles

Wim Looman

commit sha 9e89d416f1586da9b6357654b0bf3e56fe6b3c8f

Update delta config

view details

push time in 6 days

push eventNemo157/dotfiles

Wim Looman

commit sha 386af3fecaf7fc35563d8da5f07546e0a25e9dbb

add Yggdroot/indentLine for indent lines

view details

push time in 6 days

issue commentNemo157/async-compression

Panic (slice indexes) when encoding with brotli

Looks most likely to be a bug in brotli, it appears to be reading past the end of the input buffer we pass it. By the looks of it hyper is giving 8kB blocks as input, so I tried compressing both random and uniform data in 8kB blocks and neither reproduced the error, so I think to track it down we need either some actual erroring data, or maybe setting up a proper fuzzer setup and getting lucky (I gave a quick test of configuring the proptest tests to use up to 5 * 8kB blocks, but didn't manage to produce any errors).

jeromegn

comment created time in 6 days

issue commentrust-lang/rust

Rustdoc files have naming collisions on case-insensitive file systems

One worry I just had after non-ascii was just brought up is Unicode normalization in file systems, luckily it looks like rustc already does normalization when comparing identifiers, so as long as the compiler and file system do the same normalization then file systems that support Unicode but normalize it should work fine:

error[E0428]: the name `Foó` is defined multiple times
 --> src/lib.rs:3:1
  |
2 | pub struct Foó; // "Fo\u{f3}"
  | --------------- previous definition of the type `Foó` here
3 | pub struct Foó ; // "Foo\u{301}"
  | ^^^^^^^^^^^^^^^ `Foó` redefined here
  |
  = note: `Foó` must be defined only once in the type namespace of this module
jyn514

comment created time in 8 days

Pull request review commentjyn514/rfcs

Rustdoc stable urls

+- Feature Name: `stable_rustdoc_urls`+- Start Date: 2020-09-18+<!-- TODO -->+- RFC PR: [rust-lang/rfcs#0000](https://github.com/rust-lang/rfcs/pull/0000)+<!-- TODO -->+- Rust Issue: [rust-lang/rust#0000](https://github.com/rust-lang/rust/issues/0000)++# Summary+[summary]: #summary++Make the URLs that rustdoc generates stable relative to the docs being generated,+not just relative to the rustdoc version.++# Motivation+[motivation]: #motivation++[Rustdoc] generates a separate HTML page for each [item] in a crate.+The URL for this page currently stable relative to rustdoc; in other words,+Rustdoc guarantees that updating `rustdoc` without changing the source code will not change the URL generated.+This is a 'de facto' guarantee - it's not documented, but there's been no breaking change to the format since pre-1.0.++However, Rustdoc does _not_ currently guarantee that making a semver-compatible change to your code will preserve the same URL.+This means that, for instance, making a type an `enum` instead of a `struct` will change the URL,+even if your change is in every other way semver-compatible. After this change, Rustdoc will guarantee that the URL would stay the same.++<!-->+From a user-facing perspective, very little would change:+links within Rustdoc documentation would still work, as would existing links+and copying the URL from the address bar. However, the new format has the benefit+that it works regardless of how the name ends up in the namespace:+re-exports, different kinds of types, and any other semver-compatible changes+would not affect the URL.+-->++The primary motivation for this feature is to allow linking to a semantic version+of the docs, rather than an exact version. This has several applications:++- [docs.rs] could link to `/package/0.2/path` instead of `/package/0.2.5/path`, making the documentation users see more up-to-date ([rust-lang/docs.rs#1055])+- blogs could link to exact URLs without fear of the URL breaking ([rust-lang/rust#55160 (comment)][55160-blog])+- URLs in the standard library documentation would change less often ([rust-lang/rust#55160][55160])++Note that this is a different, but related, use case than [intra-doc links].+Intra-doc links allow linking consistently in the presence of re-exports for _relative_ links.+This is intended to be used for _absolute_ links. Additionally, this would allow linking consistently+outside of Rust code.++<!--- It avoids needlessly breaking links when an 'internal' change happens ([rust-lang/rust#55160][55160])-->++[Rustdoc]: https://doc.rust-lang.org/rustdoc/+[item]: https://doc.rust-lang.org/reference/items.html+[docs.rs]: https://docs.rs/+[could link]: https://github.com/rust-lang/docs.rs/issues/1055+[55160]: https://github.com/rust-lang/rust/issues/55160+[55160-blog]: https://github.com/rust-lang/rust/issues/55160#issuecomment-680751534+[intra-doc links]: https://github.com/rust-lang/rfcs/blob/master/text/1946-intra-rustdoc-links.md+[rust-lang/docs.rs#1055]: https://github.com/rust-lang/docs.rs/issues/1055++# Guide-level explanation+[guide-level-explanation]: #guide-level-explanation++Rustdoc will make the following changes to URL structure:++- Item pages will be dependent only on the namespace, not the type of the item.++	Consider the struct `std::process::Command`.+	Currently, the URL for it looks like `std/process/struct.Command.html`.+	This RFC proposes to change the URL to `std/process/Command.t.html`.+	Pages named `kind.name.html` would still be generated (to avoid breaking existing links),+	but would immediately redirect to the new URL.++- Re-exports will generate a page pointing to the canonical version of the documentation.++	Consider the following Rust code:+	+	```rust+	pub struct Foo;+	```+	+	Rustdoc currently generates a page for this at `struct.Foo.html`.+	Now, consider what happens when you move the struct to a different module and re-export it+	(which is a semver-compatible change):++	```rust+	pub mod foo { pub struct Foo; }+	pub use foo::Foo;+	```++	This generates a page at `foo/struct.Foo.html`, but _not_ at `struct.Foo.html`.+	After this change, rustdoc will generate a page at the top level which redirects+	to the version nested in the module.++<!--+Explain the proposal as if it was already included in the language and you were teaching it to another Rust programmer. That generally means:++- Introducing new named concepts.+- Explaining the feature largely in terms of examples.+- Explaining how Rust programmers should *think* about the feature, and how it should impact the way they use Rust. It should explain the impact as concretely as possible.+- If applicable, provide sample error messages, deprecation warnings, or migration guidance.+- If applicable, describe the differences between teaching this to existing Rust programmers and new Rust programmers.++For implementation-oriented RFCs (e.g. for compiler internals), this section should focus on how compiler contributors should think about the change, and give examples of its concrete impact. For policy RFCs, this section should provide an example-driven introduction to the policy, and explain its impact in concrete terms.+-->++# Reference-level explanation+[reference-level-explanation]: #reference-level-explanation++## Item pages will be dependent only on the namespace++Rust has three namespaces. For simplicity, this will only consider items that can be at the module level,+since function locals cannot be documented.++1. The value namespace. This includes `fn`, `const`, and `static`.+2. The type namespace. This includes `mod`, `struct`, `union`, `enum`, `trait`, `type`, struct fields, and enum variants.+3. The macro namespace. This includes `macro_rules!`, attribute macros, and derive macros.++Rust does not permit there to be overlaps within a namespace,+except for overlaps caused by globbing, where there must be a clear 'primary' import.

There are no overlaps, globbed imports are shadowed and blocked by non-glob imports and so don't actually exist (e.g. in https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=548f2f5e08600d4ad732c407ab3dd59f the trait is not imported).

jyn514

comment created time in 9 days

Pull request review commentjyn514/rfcs

Rustdoc stable urls

+- Feature Name: `stable_rustdoc_urls`+- Start Date: 2020-09-18+<!-- TODO -->+- RFC PR: [rust-lang/rfcs#0000](https://github.com/rust-lang/rfcs/pull/0000)+<!-- TODO -->+- Rust Issue: [rust-lang/rust#0000](https://github.com/rust-lang/rust/issues/0000)++# Summary+[summary]: #summary++Make the URLs that rustdoc generates stable relative to the docs being generated,+not just relative to the rustdoc version.++# Motivation+[motivation]: #motivation++[Rustdoc] generates a separate HTML page for each [item] in a crate.+The URL for this page currently stable relative to rustdoc; in other words,
The URL for this page is currently stable relative to rustdoc; in other words,
jyn514

comment created time in 9 days

Pull request review commentjyn514/rfcs

Rustdoc stable urls

+- Feature Name: `stable_rustdoc_urls`+- Start Date: 2020-09-18+<!-- TODO -->+- RFC PR: [rust-lang/rfcs#0000](https://github.com/rust-lang/rfcs/pull/0000)+<!-- TODO -->+- Rust Issue: [rust-lang/rust#0000](https://github.com/rust-lang/rust/issues/0000)++# Summary+[summary]: #summary++Make the URLs that rustdoc generates stable relative to the docs being generated,+not just relative to the rustdoc version.++# Motivation+[motivation]: #motivation++[Rustdoc] generates a separate HTML page for each [item] in a crate.+The URL for this page currently stable relative to rustdoc; in other words,+Rustdoc guarantees that updating `rustdoc` without changing the source code will not change the URL generated.+This is a 'de facto' guarantee - it's not documented, but there's been no breaking change to the format since pre-1.0.++However, Rustdoc does _not_ currently guarantee that making a semver-compatible change to your code will preserve the same URL.+This means that, for instance, making a type an `enum` instead of a `struct` will change the URL,+even if your change is in every other way semver-compatible. After this change, Rustdoc will guarantee that the URL would stay the same.++<!-->+From a user-facing perspective, very little would change:+links within Rustdoc documentation would still work, as would existing links+and copying the URL from the address bar. However, the new format has the benefit+that it works regardless of how the name ends up in the namespace:+re-exports, different kinds of types, and any other semver-compatible changes+would not affect the URL.+-->++The primary motivation for this feature is to allow linking to a semantic version+of the docs, rather than an exact version. This has several applications:++- [docs.rs] could link to `/package/0.2/path` instead of `/package/0.2.5/path`, making the documentation users see more up-to-date ([rust-lang/docs.rs#1055])+- blogs could link to exact URLs without fear of the URL breaking ([rust-lang/rust#55160 (comment)][55160-blog])+- URLs in the standard library documentation would change less often ([rust-lang/rust#55160][55160])++Note that this is a different, but related, use case than [intra-doc links].+Intra-doc links allow linking consistently in the presence of re-exports for _relative_ links.+This is intended to be used for _absolute_ links. Additionally, this would allow linking consistently+outside of Rust code.++<!--- It avoids needlessly breaking links when an 'internal' change happens ([rust-lang/rust#55160][55160])-->++[Rustdoc]: https://doc.rust-lang.org/rustdoc/+[item]: https://doc.rust-lang.org/reference/items.html+[docs.rs]: https://docs.rs/+[could link]: https://github.com/rust-lang/docs.rs/issues/1055+[55160]: https://github.com/rust-lang/rust/issues/55160+[55160-blog]: https://github.com/rust-lang/rust/issues/55160#issuecomment-680751534+[intra-doc links]: https://github.com/rust-lang/rfcs/blob/master/text/1946-intra-rustdoc-links.md+[rust-lang/docs.rs#1055]: https://github.com/rust-lang/docs.rs/issues/1055++# Guide-level explanation+[guide-level-explanation]: #guide-level-explanation++Rustdoc will make the following changes to URL structure:++- Item pages will be dependent only on the namespace, not the type of the item.++	Consider the struct `std::process::Command`.+	Currently, the URL for it looks like `std/process/struct.Command.html`.+	This RFC proposes to change the URL to `std/process/Command.t.html`.+	Pages named `kind.name.html` would still be generated (to avoid breaking existing links),+	but would immediately redirect to the new URL.++- Re-exports will generate a page pointing to the canonical version of the documentation.++	Consider the following Rust code:+	+	```rust+	pub struct Foo;+	```+	+	Rustdoc currently generates a page for this at `struct.Foo.html`.+	Now, consider what happens when you move the struct to a different module and re-export it+	(which is a semver-compatible change):++	```rust+	pub mod foo { pub struct Foo; }+	pub use foo::Foo;+	```++	This generates a page at `foo/struct.Foo.html`, but _not_ at `struct.Foo.html`.+	After this change, rustdoc will generate a page at the top level which redirects+	to the version nested in the module.++<!--+Explain the proposal as if it was already included in the language and you were teaching it to another Rust programmer. That generally means:++- Introducing new named concepts.+- Explaining the feature largely in terms of examples.+- Explaining how Rust programmers should *think* about the feature, and how it should impact the way they use Rust. It should explain the impact as concretely as possible.+- If applicable, provide sample error messages, deprecation warnings, or migration guidance.+- If applicable, describe the differences between teaching this to existing Rust programmers and new Rust programmers.++For implementation-oriented RFCs (e.g. for compiler internals), this section should focus on how compiler contributors should think about the change, and give examples of its concrete impact. For policy RFCs, this section should provide an example-driven introduction to the policy, and explain its impact in concrete terms.+-->++# Reference-level explanation+[reference-level-explanation]: #reference-level-explanation++## Item pages will be dependent only on the namespace++Rust has three namespaces. For simplicity, this will only consider items that can be at the module level,+since function locals cannot be documented.++1. The value namespace. This includes `fn`, `const`, and `static`.+2. The type namespace. This includes `mod`, `struct`, `union`, `enum`, `trait`, `type`, struct fields, and enum variants.
2. The type namespace. This includes `struct`, `union`, `enum`, `trait`, and `type`.
  • struct fields are not at the module level
  • doc(inline) on enum variant re-exports does not work
  • mods have folders rather than files (this one I'm 50/50 on including in the list)
jyn514

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedrust-lang/docs.rs

Use semver compatible links to dependencies

Currently when we build documentation we pass a flag like --extern-html-root-url foobar=https://docs.rs/foobar/1.0.0 for each dependency with the exact version of the dependency used. This means if the dependency releases a new version compatible with the version constraint, all the links to it from the dependent crate will still go to the old version.

To avoid this we could pass semver-constraint urls like --extern-html-root-url foobar=https://docs.rs/foobar/^1.0.0 (based on the actual constraint specified), then links will automatically go to the latest compatible version of the docs.

The biggest blocker to doing so is getting guarantees from Rustdoc that intra-doc-links generated for one version of a crate will still be valid in all semver-compatible later versions of the crate. A couple of issues currently cause this to not be true:

  1. The exact kind of a type is part of the url, so while e.g. changing a struct to an enum is a non-breaking change to code, it will result in a link to the item becoming a 404 (https://github.com/rust-lang/rust/issues/55160)
  2. Re-exports don't exist in the file tree, as an example consider these two versions of a crate:
// Version 1.0.0
pub struct Foo;
// Version 1.0.1 - A semver compatible change to move the canonical location and leave a re-export behind
pub mod foo { pub struct Foo; }
pub use foo::Foo;

Looking at the filetree of the built docs we can see that a link to the old canonical location of foo/struct.Foo.html will be a 404 in the new version:

target/doc/foo
├── all.html
├── index.html
├── sidebar-items.js
└── struct.Foo.html

target/doc/foo
├── all.html
├── foo
│   ├── index.html
│   ├── sidebar-items.js
│   └── struct.Foo.html
├── index.html
└── sidebar-items.js

(There may be more issues, these are just what was linked to me by @jyn514 and the first thought I had of what might go wrong. The first step of actually working on this if it's worth it would be identifying all the potential issues and working out whether it's possible/worthwhile trying to get this guarantee out of Rustdoc).

created time in 9 days

issue openedrust-lang/rust-clippy

Lint default numeric type fallback

What it does

Lint any integer or floating point constants that have their type determined by the default fallback rather than inference

Categories (optional)

  • Kind: pedantic

What is the advantage of the recommended code over the original code

Avoids unintended use of the numeric default types, forcing the author to think about what type is appropriate.

Drawbacks

Forcing the author to think about what type is appropriate.

Example

let (x, y) = (5, 6.0);

Could be written as:

let (x, y): (i32, f32) = (5, 6.0);
let (x, y) = (5i32, 6.0f32);

created time in 9 days

push eventNemo157/bs58-rs

Wim Looman

commit sha fb3b83dc6b699bfc3f8df653e5384f11a23b47f8

Go back to unsafe, blocked on 1.47

view details

push time in 10 days

push eventNemo157/bs58-rs

Wim Looman

commit sha 3845dc6af150a3732c2caca8bc638d052e2a6f8c

Avoid nightly-only array debug impl

view details

push time in 10 days

pull request commentLokathor/tinyvec

Implement `[value; N]` syntax support for `array_vec!`

The first form works for both, so if it's possible (/easy enough) it seems good to have the second form for both.

slightlyoutofphase

comment created time in 11 days

push eventNemo157/bs58-rs

Wim Looman

commit sha 4476117bf6d76d8473cc23219202f71f133c95c4

Implement Debug for Alphabet

view details

Wim Looman

commit sha 0380d6c76f2b7473fb5f239ab0f58f0f6567c32d

Update CLI to use 0.4 API

view details

Wim Looman

commit sha 10004813e4778a11abd6b34a77a42542bb53df20

Replace unwrap by ? in examples

view details

Wim Looman

commit sha 8c0123e1d8f2c4513748a255136332903a260df1

Use ? for encoding errors too

view details

Wim Looman

commit sha 88457c2a0e9fa8b4156ffcadb5620a3cf89eab73

Use intra doc links

view details

push time in 11 days

PR closed mycorrhiza/bs58-rs

Use new support for loops in const fn
+8 -69

2 comments

1 changed file

Nemo157

pr closed time in 11 days

pull request commentmycorrhiza/bs58-rs

Use new support for loops in const fn

Replaced by #55

Nemo157

comment created time in 11 days

PR opened mycorrhiza/bs58-rs

Prepare for 0.4

Remove non-prepared alphabet support and use new compiler features.

+102 -215

0 comment

7 changed files

pr created time in 11 days

push eventNemo157/bs58-rs

Wim Looman

commit sha e11b29bdb5186e69781d3804345958b0bef5e642

Implement Debug for Alphabet

view details

Wim Looman

commit sha 219d2ba91a094a6900867a7d25907d3e4c1f0bfa

Update CLI to use 0.4 API

view details

push time in 11 days

push eventNemo157/bs58-rs

Wim Looman

commit sha 20236d5fb611bdf79345c634ccb7566798589903

Use new support for loops in const fn

view details

Wim Looman

commit sha 1e6becde3f8c637af31e618999124d809cc6d132

Update to use prepared Alphabet instances only

view details

Wim Looman

commit sha 87335d9f9636e8c37b3148c65ca73ec05c52c2b8

Use non_exhaustive for errors

view details

Wim Looman

commit sha 1a74cc8b55680011b73ac3bc5c0835769f4423f6

Bump version to 0.4.0

view details

push time in 11 days

create barnchNemo157/bs58-rs

branch : prepare-0.4

created branch time in 11 days

push eventNemo157/docs.rs

Guillaume Gomez

commit sha 9c58ff54d5b040137fca9f2307e8df8c5ea9aa7e

Fix readme typo

view details

Pietro Albini

commit sha 97d895f5df2c70bd8226ea32559860603a3cb136

ignore rustwide from Cargo's workspace

view details

Pietro Albini

commit sha f52b1609b28f284c2f23c3ea30a41e659deff474

Update Cargo.toml Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Guillaume Gomez

commit sha 85a7756759db8460b3496eaac23913d15fe13ad7

Add missing build command

view details

Guillaume Gomez

commit sha 4ba7c1c52cad60e403e567af0418a56c7707bf96

Fix js content indent

view details

Guillaume Gomez

commit sha 2add38e2377afde41e35c06ccc2e0d35ae25d01e

Add more instructions to get auto-update for templates

view details

Guillaume Gomez

commit sha b5b85918f6e17ee374a8ee260fb36edfab493552

Commands consistence Co-authored-by: Joshua Nelson <jyn514@gmail.com>

view details

Guillaume Gomez

commit sha 60525c2b79dfd2e24a66b044c9ac8b9ae3d0759e

Unify crate pages rendering

view details

Guillaume Gomez

commit sha 14c279f90c8fee6d8628124c42af553c0a793e59

Fix menu titles display for mobile

view details

Joshua Nelson

commit sha 2ce85ce97f313b8d3940e833b9fdf62469bfcc52

Revert "Fix menu titles display for mobile" This reverts commit 14c279f90c8fee6d8628124c42af553c0a793e59.

view details

Joshua Nelson

commit sha 49099068e383bacb67f775537d3e61a3f58919e0

Revert "Unify crate pages rendering" This reverts commit 60525c2b79dfd2e24a66b044c9ac8b9ae3d0759e.

view details

Pietro Albini

commit sha 6e863916bb18328aad3a7f2fd99a672ab1498059

about: fix styling of the about page header

view details

Joshua Nelson

commit sha bfa6adaabd3081be8e5d0f93d498b93d167469b9

Don't crash if trying to move directories for a target that failed Previously, if there was a build with - a non-default target - that failed to build docs.rs would crash: ``` [DEBUG] cratesfyi::docbuilder::rustwide_builder: rename /home/cratesfyi/workspace/builds/stm32h7xx-hal-0.7.0/target/thumbv7em-none-eabihf/doc to /home/cratesfyi/workspace/builds/stm32h7xx-hal-0.7.0/target/doc 2020/09/03 20:15:49 [ERROR] cratesfyi::build_queue: Failed to build package stm32h7xx-hal-0.7.0 from queue: No such file or directory (os error 2) Backtrace: 0: failure::backtrace::internal::InternalBacktrace::new 1: <failure::backtrace::Backtrace as core::default::Default>::default 2: cratesfyi::docbuilder::rustwide_builder::RustwideBuilder::execute_build 3: rustwide::build::BuildBuilder::run 4: cratesfyi::docbuilder::rustwide_builder::RustwideBuilder::build_package 5: cratesfyi::build_queue::BuildQueue::process_next_crate 6: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once 7: cratesfyi::utils::queue_builder::queue_builder 8: std::sys_common::backtrace::__rust_begin_short_backtrace 9: core::ops::function::FnOnce::call_once{{vtable.shim}} 10: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/liballoc/boxed.rs:1076 <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/liballoc/boxed.rs:1076 std::sys::unix::thread::Thread::new::thread_start at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/sys/unix/thread.rs:87 11: start_thread 12: __clone ``` The issue is it was trying to rename a directory that didn't exist, because the build failed. This no longer tries to rename the directory unless the build succeeded.

view details

Camelid

commit sha 50e3852c42ed1198573b889eeeb29fad62cfc639

Update author metadata Added "The Rust Project Developers" to the end of the "author" field in the `Cargo.toml` metadata for each crate that makes up docs.rs.

view details

Camelid

commit sha 52e12453fb708f7b4a7fe92b258e47b94d210e8e

Update root crate name cratesfyi -> docs-rs I did not change the name of the binary because of @jyn514's concerns about having to change all the scripts in production to use the new name.

view details

Camelid

commit sha 28c75a9b787c3f17a5f948ddf9f702d3e99127b7

Update some docs to use "docs.rs"

view details

Camelid

commit sha c129c4ef57db530e9972ea5a4d9f0110b5979e97

Update Dockerfile

view details

Camelid

commit sha 0070527981590b71d1857553f99f82a5288237cc

Update doc comment Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Camelid

commit sha 3b7f26cf5339e7d9157865fcd8b77107a596a4bb

Update `.env.sample` to use new crate name

view details

Joshua Nelson

commit sha c40619388e3dc4d3ab5902d85c72dfee1ae0a1f7

Re-enable per-crate search now that rustdoc bugs are fixed Follow up to https://github.com/rust-lang/docs.rs/pull/497, https://github.com/rust-lang/rust/pull/76052

view details

push time in 11 days

pull request commentLokathor/tinyvec

Implement `[value; N]` syntax support for `array_vec!`

// Given that this works:
let vec: TinyVec<[f32; 4]> = tiny_vec!(1.1, 1.1, 1.1);

// Should this work:
let vec: TinyVec<[f32; 4]> = tiny_vec![1.1; 3];
slightlyoutofphase

comment created time in 12 days

pull request commentLokathor/tinyvec

Implement `[value; N]` syntax support for `array_vec!`

Implementation looks fine, but it seems weird to support this syntax for array_vec! and not tiny_vec!.

slightlyoutofphase

comment created time in 13 days

push eventNemo157/dotfiles

Wim Looman

commit sha 966e06d2745348a1f8884be8b8f13de7ebac9c10

Pretend to be docs.rs harder

view details

Wim Looman

commit sha 68258fda5e7a255a43ac28cfdc9edb3dc34f286d

Update cargo-rubber Add support for a --manifest-path flag (before the subcommand) to allow running from a different directory. Log when relocking dependencies from invalid lock file. Ensure even if the manifest path is under a tmpfs that it is bind-mounted in (TODO: This should be using the workspace root).

view details

push time in 13 days

push eventNemo157/dotfiles

Wim Looman

commit sha f277fefab26bd1800fabd6fbbb8ec47325a508a6

Use any battery

view details

push time in 14 days

push eventNemo157/dotfiles

Wim Looman

commit sha b6fc7ff93419c141ae51b2a620f048a5fed2dbe3

Improve memory stats

view details

push time in 14 days

issue openedrust-lang/futures-rs

Bug in impl FusedFuture for futures::future::Map

It doesn't correctly propagate the termination of the underlying future

use futures::future::FusedFuture;
use futures::future::FutureExt;

fn main() {
    assert!(futures::future::pending::<()>().is_terminated());
    assert!(futures::future::pending::<()>().map(|()| ()).is_terminated());
}
> cargo run
thread 'main' panicked at 'assertion failed: futures::future::pending::<()>().map(|()| ()).is_terminated()', src/main.rs:6:5

This should be delegating through to the inner future:

https://github.com/rust-lang/futures-rs/blob/32d970edd7281908cd4af05915bdc9136eaa8533/futures-util/src/future/future/map.rs#L34

created time in 14 days

PullRequestReviewEvent

Pull request review commentrust-lang/docs.rs

Add metrics tracking number of recently loaded crates/versions/platforms

 impl RecentlyAccessedReleases {     }      pub(crate) fn record(&self, krate: i32, version: i32, target: &str) {-        self.crates.insert(krate, Instant::now());-        self.versions.insert(version, Instant::now());+        if self.platforms.len() > 100_000 {+            // Avoid filling the maps _too_ much, we should never get anywhere near this limit

We will see it capping out on the metrics, I think it would be a waste to spam a message per-request to the logs too.

Nemo157

comment created time in 14 days

PullRequestReviewEvent

pull request commentNemo157/cbor-diag-rs

Update dependencies

bors r+

Satelles157

comment created time in 14 days

issue commentrust-lang/docs.rs

docs.rs/std/<path>?<args> should redirect path and args to doc.rust-lang

It's fixed in the underlying library the router uses, but afaik iron's router itself hasn't updated that library.

tinaun

comment created time in 15 days

issue commentrust-lang/docs.rs

docs.rs/std/<path>?<args> should redirect path and args to doc.rust-lang

It may still be a bug in the router, maybe related to https://github.com/http-rs/route-recognizer/issues/20 causing the priorities between the different routes to be wrong (I'm actually surprised that docs.rs has not hit this yet, on my other iron using project I encountered it almost straight away).

tinaun

comment created time in 15 days

issue commentrust-lang/docs.rs

Don't show 'Go to latest version' on pre-releases

I think the link/warning should still be displayed, but changed wording to something like "Go to stable version".

Kixiron

comment created time in 15 days

push eventNemo157/docs.rs

Wim Looman

commit sha 710e8fa65fd2d14674d615692af2ae82ac9fa02e

Review nits

view details

Wim Looman

commit sha 6ef4f1f55210641afa577c3cdd509ca11dea0f10

Add an upper limit to number of recently accessed releases that will be tracked

view details

push time in 16 days

issue openedNemo157/cargo-docs2ipfs

Multiple targets

Somehow fit the list of targets in 🤷

created time in 16 days

issue openedNemo157/roaring-rs

Revert order of modules and disable rustfmt for them

https://github.com/Nemo157/roaring-rs/blob/bc97c1400d11b75ff92f61040e21772de8c8f8c3/src/bitmap/mod.rs#L6-L12

These shouldn't have been reordered with rustfmt since they affect the documentation rendering.

created time in 16 days

issue openedrust-lang/cargo

Building with a registry that hosts packages with mismatching names fails with an internal error

Problem I have published a registry that had a different name in the Cargo.toml of the downloaded package than what was used in the registry (the registry has a package ~github:1234|something which when downloaded contains a Cargo.toml with package.name = "bs58"). Trying to build with a dependency on this package results in a cargo internal error:

Steps

Create a new project and add a dependency:

[dependencies]
bs58.version = "0.3.1"
bs58.package = "~github:1234|something"
bs58.registry-index = "https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7"

Try building it (using git-cli for the non-smart git protocol):

> CARGO_LOG=trace cargo build --config net.git-fetch-with-cli=true -Z unstable-options
[...]
  Downloaded ~github:1234|something v0.3.1 (registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`)
[2020-09-11T13:19:26Z TRACE cargo::ops::cargo_read_manifest] read_package; path=/Users/nemo157/.cargo/registry/src/ipfs.io-8e9b5ce4ef400cdd/~github:1234|something-0.3.1/Cargo.toml; source-id=registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`
[2020-09-11T13:19:26Z TRACE cargo::util::toml] read_manifest; path=/Users/nemo157/.cargo/registry/src/ipfs.io-8e9b5ce4ef400cdd/~github:1234|something-0.3.1/Cargo.toml; source-id=registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`
[2020-09-11T13:19:26Z TRACE cargo::sources::path] getting packages; id=~github:1234|something v0.3.1 (registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`)
[2020-09-11T13:19:26Z WARN  cargo::util::rustc] failed to update rustc info cache: failed to write `/private/var/folders/0p/5yvmrvhj5w3_vy1y8x7dvk7m0000gn/T/tmp.uY44qvVp/foo/target/.rustc_info.json`
[2020-09-11T13:19:26Z DEBUG cargo] exit_with_error; err=CliError { error: Some(failed to find ~github:1234|something v0.3.1 (registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`) in path source), exit_code: 101 }
[2020-09-11T13:19:26Z DEBUG cargo] display_error; err=failed to find ~github:1234|something v0.3.1 (registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`) in path source
error: failed to find ~github:1234|something v0.3.1 (registry `https://ipfs.io/ipfs/Qmeuz3m8QWdRahB8Vvgk9R5kvASEvrnNZGaFyy3WNJqSz7`) in path source
note: this is an unexpected cargo internal error
note: we would appreciate a bug report: https://github.com/rust-lang/cargo/issues/
note: cargo 1.48.0-nightly (875e01232 2020-09-08)

created time in 16 days

issue openedNixOS/nixpkgs

cjdns: Not possible to bind on multiple interfaces

Describe the bug The cjdns.UDPInterface configuration only allows specifying a single interface on which to bind and connect to peers; this is then feed into the array of interfaces that the configuration supports. It should be possible to specify multiple UDP interfaces to bind on like the underlying config supports, e.g. for binding on both IPv6 and IPv4.

Notify maintainers @ehmry

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

created time in 16 days

issue commentNemo157/roaring-rs

Remove documentation link

AFAIK crates.io defaults to docs.rs when it’s not specified.

Nemo157

comment created time in 17 days

issue commenttime-rs/time

build script does not declare dependency on COMPILING_UNDER_CARGO_WEB

The default is to only rerun if any file changes, it doesn't track environment variables at all. A new release that prints the rerun-if line should work.

Nemo157

comment created time in 17 days

issue openedNemo157/roaring-rs

Remove documentation link

https://github.com/Nemo157/roaring-rs/blob/master/Cargo.toml#L7

It's not being auto-published anymore, and docs.rs is better anyway.

created time in 17 days

pull request commentNemo157/roaring-rs

Bug fix for serialization bug

:tada: 0.6.1 published

lemire

comment created time in 17 days

created tagNemo157/roaring-rs

tag0.6.1

Roaring bitmap implementation for Rust

created time in 17 days

delete branch Nemo157/roaring-rs

delete branch : update

delete time in 17 days

pull request commentNemo157/roaring-rs

Update to 0.6.1

bors r+

Nemo157

comment created time in 17 days

PR opened Nemo157/roaring-rs

Update to 0.6.1
+16 -2

0 comment

2 changed files

pr created time in 17 days

push eventNemo157/roaring-rs

bors[bot]

commit sha 8daebcf2201b10dd1f305c3697056294037995c3

Merge #48 48: Bump version to 0.6.0 r=Nemo157 a=Nemo157 bors r+ Co-authored-by: Wim Looman <wim@nemo157.com>

view details

Pen Tree

commit sha 01228cb500aaeffb0309afe4f8d26566b006ecf0

Remove unnecessary lifetime bound

view details

bors[bot]

commit sha f65cdc0969106289460b536c2fa880e800707357

Merge #49 49: Remove unnecessary lifetime bound r=Nemo157 a=zyctree The lifetime bound seems unnecessary Co-authored-by: Pen Tree <appletree2479@outlook.com>

view details

Nassor Paulino da Silva

commit sha 6c581eed9f1104b336056af5290eb9195ab66a0d

Removing deprecated `try!` in favor of `?`

view details

Nassor Paulino da Silva

commit sha 26399e490932dacb2a84ce77df22cedb38e81f33

2018 edition modules

view details

Nassor Paulino da Silva

commit sha 42ec354b8381683a5ac11385ec1f5a0b2250c2fa

better benchmarks using criterion crate

view details

Nassor Paulino da Silva

commit sha b2e19c0478fb18a3970fa4caac3a088e63563576

fix clippy complain

view details

bors[bot]

commit sha f8e462c9d1a7fe9b91fb079720699023a7aa5417

Merge #51 51: Updated to 2018 edition r=Nemo157 a=nassor - replaced deprecated `try!` in favor of `?` - updated modules imports - improved benchmarks using criterion crate. Co-authored-by: Nassor Paulino da Silva <nassor@gmail.com>

view details

Joseph Glanville

commit sha 880403ccb318add6715ecd7c863a7d187d7142fb

Run clippy against all targets Additional since clippy was stabilized switch to `rustup component add clippy` vs `clippy-preview`. Fixes #52

view details

bors[bot]

commit sha 5bed058e8feeaca8b5f5ea64cae667e26803b184

Merge #53 53: Run clippy against all targets r=Nemo157 a=josephglanville Additional since clippy was stabilized switch to `rustup component add clippy` vs `clippy-preview`. Fixes #52 Co-authored-by: Joseph Glanville <jpg@jpg.id.au>

view details

Joseph Glanville

commit sha 94bb5e2933564ab205d0db9d2c1b58b536457186

Run cargo fmt

view details

Joseph Glanville

commit sha 0d99530d21e437b69f4911209eac51bb0974db5e

Run cargo fmt --check in CI

view details

bors[bot]

commit sha 96b15a9966ef6e3a6b31326afb9ade4b2651c9c9

Merge #55 55: Format code using cargo fmt r=Nemo157 a=josephglanville This PR formats the existing code with `cargo fmt` and then enables a check in CI to ensure it remains formatted. Co-authored-by: Joseph Glanville <jpg@jpg.id.au>

view details

Joseph Glanville

commit sha 9c8d669e5b1ab04c31d4c7ed471974ff55da9501

Add additional benchmarks Incorporate benchmarks from https://github.com/saulius/croaring-rs/blob/master/benches Closes #8

view details

bors[bot]

commit sha adc8824d6537addbfb584c0eaaabe3f696499529

Merge #54 54: Add additional benchmarks r=josephglanville a=josephglanville Incorporate benchmarks from https://github.com/saulius/croaring-rs/blob/master/benches Closes #8 Co-authored-by: Joseph Glanville <jpg@jpg.id.au>

view details

Kerollmops

commit sha 6c1b644d5981d165dfd92f875df19ed9119abd61

Introduce a test that highlight a serialization bug

view details

Daniel Lemire

commit sha 0e1218cb7cedf545eac45952ac4f60fb6a9f3b80

Bug fix.

view details

Daniel Lemire

commit sha a3df9a128a844cdad4fa37701c764f874e9288dd

cargo fmt

view details

bors[bot]

commit sha 5bc2b7c23e87bef32d738cffad772328b9a706fa

Merge #62 62: Bug fix for serialization bug r=Nemo157 a=lemire See https://github.com/Nemo157/roaring-rs/pull/61 Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Daniel Lemire <lemire@gmail.com>

view details

Wim Looman

commit sha c5298652dca01ca79b67fb30cc10c61ada0eea05

Add tests for both sides of container type boundary conditions

view details

push time in 17 days

pull request commentrust-lang/docs.rs

Update crate metadata

There's a single log line in it:

https://github.com/rust-lang/docs.rs/blob/b478d4d93d865f4dc05e802677538b5d8b908074/src/bin/cratesfyi.rs#L125

camelid

comment created time in 17 days

pull request commentrust-lang/docs.rs

Rename crates to be in the same top-level crates/ directory

If it helps, it's the same number of nesting as normal because there's no src/ directory (I don't like those at all in shared crates).

Another thing I find really weird about this setup, and breaks my muscle memory for editing files from sibling crates :grin:; but I don't have any major issues with this setup, most workspaced projects seem to grow some weird unique setup eventually.

jyn514

comment created time in 17 days

pull request commentNemo157/roaring-rs

Bug fix for serialization bug

I'll publish a new version when I'm home tonight, we'll see if I get round to adding tests beforehand or not :grin:

lemire

comment created time in 17 days

pull request commentNemo157/roaring-rs

Bug fix for serialization bug

Nice, thanks for the quick debugging. I should probably make sure there are boundary tests everywhere...

bors r+

lemire

comment created time in 18 days

pull request commentrust-lang/docs.rs

Rename crates to be in the same top-level crates/ directory

Whats wrong with having them at the root? Outside rust-lang/rust (because of its ridiculously high number of crates) adding in an extra level of nesting is uncommon.

jyn514

comment created time in 18 days

pull request commentrust-lang/docs.rs

Update crate metadata

Mmm, would that rather be DOCSRS_LOG=cratesfyi,docs_rs,rustwide=info to catch logs from the binary too?

camelid

comment created time in 18 days

create barnchNemo157/docs.rs

branch : dont-serve-arbitrary-source-files

created branch time in 18 days

issue commentrust-lang/futures-rs

futures-core 1.0 release

I think to make it a forward-compatible update the build script must detect std::?::Stream from v1.0.0 and either re-export or fail to compile with it. Having a local Stream and making a future version start re-exporting it from std would be a breaking change (even if there is a patch release doing the re-exporting before std::?::Stream is stable).

Alternatively this could be a documented "unchecked" future-incompatibility so that it's not compiler checked like that, but users are told that simultaneously implementing futures-core::Stream and std::?::Stream is consider invalid.

taiki-e

comment created time in 18 days

issue openedtime-rs/time

build script does not declare dependency on COMPILING_UNDER_CARGO_WEB

> COMPILING_UNDER_CARGO_WEB=1 cargo build --target wasm32-unknown-unknown
[...]
error[E0433]: failed to resolve: use of undeclared type or module `wasm_bindgen`
[...]

> cargo build --target wasm32-unknown-unknown
[...]
error[E0433]: failed to resolve: use of undeclared type or module `wasm_bindgen`
[...]

> cargo clean

> cargo build --target wasm32-unknown-unknown
[...]
    Finished dev [unoptimized + debuginfo] target(s) in 41.81s

Build scripts must use cargo:rerun-if-env-changed to declare the environment variables they depend on, otherwise Cargo will use the previously cached run.

From discussion on the community discord https://discord.com/channels/273534239310479360/274215136414400513/753183573145681940

created time in 19 days

issue commentrust-lang/rust

#[link_section] is unsound on Harvard architectures

See also https://github.com/rust-lang/rust/issues/28179 and https://github.com/rust-lang/rust/pull/72209, maybe this attribute could also be pulled under the unsafe_code lint (even on non-Harvard architectures it seems plausible that there's some way to cause unsoundness with it depending on the default linker scripts?).

H2CO3

comment created time in 19 days

issue openedNemo157/cargo-docs2ipfs

Publish std docs and link into them

created time in 19 days

issue closedNemo157/cargo-docs2ipfs

Cleanup artifacts

Runs out of disk space real easy cause /run/user is very limited.

closed time in 19 days

Nemo157

issue commentNemo157/cargo-docs2ipfs

Cleanup artifacts

Done (other than failures)

Nemo157

comment created time in 19 days

issue closedNemo157/cargo-docs2ipfs

Store index of all generated docs

/<crate>/<version>

Store hash in long-term storage, update on each build (and unpin previous version and pin new version).

closed time in 19 days

Nemo157

issue commentNemo157/cargo-docs2ipfs

Store index of all generated docs

Done

Nemo157

comment created time in 19 days

push eventNemo157/cargo-docs2ipfs

Wim Looman

commit sha ca5658d936bb485483ca522e264dcf86d8f0be83

Cleanup tmp directories

view details

Wim Looman

commit sha 888483e8f22b2f408a54e05f73c94c19950b2dcc

Build up an index of all built crates documentation

view details

push time in 19 days

issue openedNemo157/cbor.nemo157.com

Use # instead of ? url parameters

They're clientside only, no need to send to the server.

created time in 19 days

Pull request review commentrust-lang/docs.rs

Transform "documentation" tab into button

 div.cratesfyi-package-container {     border-bottom: 1px solid $color-border;     margin-bottom: 20px; -    h1 {-        margin: 0;-        padding: 15px 0 0 14px;+    .container {+        display: flex;+        align-items: center; -        &.no-description {-            padding-bottom: 15px;-        }-    }+        .description-container {+            flex-grow: 3;

An example of a longer description: https://docs.rs/crate/tokio/0.2.22

GuillaumeGomez

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentrust-lang/futures-rs

Add AsyncRead::poll_read_buf based on RFC 2930

Also poll_read_buf_vectored, and a bunch of utilities (and update a bunch of the existing utilities to use it where possible).

Personally I think this should wait for an unstable ReadBuf available in std, and definitely done as an unstable feature (I doubt the viability of exposing this stably now with a local ReadBuf and updating to use std's ReadBuf in the future without breaking changes).

Here's an existing, very quick, probably buggy, implementation from a while ago (so has an out-of-date ReadBuf API).

taiki-e

comment created time in 19 days

issue openedNemo157/cargo-docs2ipfs

Use fixed toolchain for each crate

Check publish date of crate (probably last modification of the Cargo.toml) and use nightly toolchain from that date.

Probably should use a private rustup install for it.

created time in 19 days

issue openedNemo157/cargo-docs2ipfs

Cleanup artifacts

Runs out of disk space real easy cause /run/user is very limited.

created time in 19 days

issue openedNemo157/cargo-docs2ipfs

Store index of all generated docs

/<crate>/<version>

Store hash in long-term storage, update on each build (and unpin previous version and pin new version).

created time in 19 days

pull request commentNemo157/cbor-diag-rs

Update dependencies

bors r+

Satelles157

comment created time in 20 days

issue commentrust-lang/rust

rustdoc: source view appended newlines

Oh, I meant for the source files, you might need to reconfigure git before checking out the source (and that's likely just a workaround, this seems likely to be a bug in rustdoc's handling of \r\n in source files).

lzutao

comment created time in 20 days

pull request commentrust-lang/docs.rs

Update crate metadata

It was previously relying on the fact that the "default" binary at src/main.rs was also called cratesfyi, and using that to prebuild all the dependencies before copying the source in and building the actual binary, so that changing the source code and rebuilding the image doesn't need to rebuild all the dependencies (for local testing in docker).

camelid

comment created time in 20 days

pull request commentrust-lang/docs.rs

Update crate metadata

Oh, stick a mkdir src/bin && just before the echo

camelid

comment created time in 20 days

pull request commentrust-lang/docs.rs

Update crate metadata

Hmm, the Docker build failed, even though I didn't update the binary's name.

Try changing

https://github.com/rust-lang/docs.rs/blob/bfa6adaabd3081be8e5d0f93d498b93d167469b9/dockerfiles/Dockerfile#L35

to

RUN echo "fn main() {}" > src/bin/cratesfyi.rs && \ 
camelid

comment created time in 20 days

push eventNemo157/cargo-docs2ipfs

Wim Looman

commit sha 984b55d071905ec1a610580fcd0b31f40b6a93db

I built the wrong version :sigh:

view details

push time in 20 days

push eventNemo157/cargo-docs2ipfs

Wim Looman

commit sha 27b5bf50cef3b428ced340389374bcbacb67f027

Fix include sed backup files

view details

push time in 20 days

issue commentrust-lang/docs.rs

Whitespace in `rustdoc-args` isn't correctly handled

There's a new config-cli feature in cargo that we could use instead of the environment variables, just serialize to TOML and pass the arrays in as arguments:

cargo run --config build.rustflags='["--cfg", "test=\"foo bar\""]' -Z unstable-options

(probably best to check on stability with the cargo team first, so that we know there's no major planned changes to this in the near future).

Nemo157

comment created time in 20 days

create barnchNemo157/cargo-docs2ipfs

branch : prīmum

created branch time in 20 days

created repositoryNemo157/cargo-docs2ipfs

created time in 20 days

issue commentrust-lang/docs.rs

Whitespace in `rustdoc-args` isn't correctly handled

(This likely also impacts RUSTFLAGS, but that's used less and I don't know if there's a way to fix it as it must be passed as an environment variable).

Nemo157

comment created time in 20 days

issue openedrust-lang/docs.rs

Whitespace in `rustdoc-args` isn't correctly handled

Specifying this should not work:

[package.metadata.docs.rs]
rustdoc-args = ["--cfg docsrs"]

As you can see from this build log --cfg docsrs as a single argument is invalid (it must be either ["--cfg=docsrs"] or ["--cfg", "docsrs"]: https://docs.rs/crate/async-compression/0.1.0-alpha.2/builds/179189, but recently a build with that configuration did successfully build: https://docs.rs/crate/adler/0.2.3/builds/269923; implying that whitespace inside arguments is getting interpreted as argument separators, which would break any arguments that actually have internal whitespace.

Seems to have broken between 2019-08-16 and 2020-07-10 at some point. Could be related to rustwide as passing whitespace inside environment variables into docker may be difficult (though we can probably swap from using RUSTDOCFLAGS environment variable to running cargo rustdoc -- $rustdoc_args instead).

created time in 20 days

issue commentrust-lang/rust

rustdoc: source view appended newlines

Could be related to \r\n normalization depending on the git checkout settings of the runner.

lzutao

comment created time in 23 days

PullRequestReviewEvent
more