profile
viewpoint
Morten Bjerg Gregersen MortenGregersen @Bankdata / MoGee Silkeborg, Denmark http://mogee.dk

FluxorOrg/Fluxor 72

Unidirectional Data Flow in Swift 🚀 based on Combine 🚜

FluxorOrg/FluxorExplorer 9

A macOS and iPadOS app for debugging apps using Fluxor

MortenGregersen/MattsWorldTour 3

Matt's World Tour

MortenGregersen/NSTimer-Blocks 1

Simple category on NSTimer to give it blocks capability.

FluxorOrg/FluxorExplorerInterceptor 0

Intercepting actions and state changes and sending them to FluxorExplorer

FluxorOrg/FluxorExplorerSnapshot 0

A struct to be used when communicating between FluxorExplorerInterceptor and FluxorExplorer

MortenGregersen/Accio 0

A dependency manager driven by SwiftPM that works for iOS/tvOS/watchOS/macOS projects.

PR opened FluxorOrg/Fluxor

Selector with input
+620 -189

0 comment

6 changed files

pr created time in 7 days

issue commentAvdLee/appstoreconnect-swift-sdk

Modify Provisioning Profiles

As per documentation it is only possible to create and delete profiles: https://developer.apple.com/documentation/appstoreconnectapi/profiles

Sanzenbacher

comment created time in 16 days

startednalexn/ViewInspector

started time in 22 days

pull request commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

Errors are gone, except the formatting one. Also looks like the coverage is quite low.

I might also help with that in upcoming days (probably Tue), unless you're a bit more available to finish up @MortenGregersen

Fantastic! Thank you for the help.

I don't have the time to do any work on this the following weeks.

MortenGregersen

comment created time in 24 days

push eventMortenGregersen/appstoreconnect-swift-sdk

Dawid Cieslak

commit sha f6e5ed0dc5841d6443ebcb33923ad808c4f16943

- Add new files to the main target dependencies - Sort files in the project file by the name

view details

Dawid Cieslak

commit sha 606e65bb7f81c876bb25d0386fc08abbbf7049f6

Update expected URLs in GetApp & ListApps tests

view details

Morten Bjerg Gregersen

commit sha 7fdd9a9109e1ae9151b6f9f7a4b9cabadc8274d6

Merge pull request #1 from cieslakdawid/app-info-add-sourcefiles Add new files to the main target dependencies & update exected

view details

push time in 24 days

PR merged MortenGregersen/appstoreconnect-swift-sdk

Add new files to the main target dependencies & update exected

Hey @MortenGregersen , as discussed yesterday I've:

  • added new files to the project
  • sorted files by the name (to keep the right order and avoid a mess)
  • update the expected URL in failing tests
+117 -49

0 comment

3 changed files

cieslakdawid

pr closed time in 24 days

pull request commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

I don't have the time to look at this right now. It would be awesome if you would try and add the files 👍

MortenGregersen

comment created time in 24 days

pull request commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

@MortenGregersen I'm referring to AppStoreConnect-Swift-SDK.xcodeproj/project.pbxproj file. Got it. Didn't see the .xcodeproj in Githubs file list as it was shown as a folder... :) Maybe you are right.

MortenGregersen

comment created time in 24 days

pull request commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

Looking at the diff I don't see new files being added to the project file - looks like the reason for the errors above. @MortenGregersen Any chance that something makes the project file being ignored from changes?

I don't see any project file. Where should they be added?

MortenGregersen

comment created time in 24 days

issue commentAvdLee/appstoreconnect-swift-sdk

Question: How to download Profiles?

It has been some time since I took a quick look at the property. Isn't the content base64 encoded?

victorBaro

comment created time in a month

startediamadamdev/bypass-paywalls-chrome

started time in a month

delete branch MortenGregersen/capacitor-site

delete branch : patch-1

delete time in a month

startedmickeyl/LTSupportAutomotive

started time in a month

startedefaerber/LTSupportAutomotive

started time in a month

startedPisinO/LTSupportAutomotive

started time in a month

pull request commentionic-team/capacitor-site

Gems should never be installed as sudo

Maybe I was to fast 😊 I took a look at CocoaPods's docs. They also recommend the system ruby, but also write about using a sudo-less approach: https://guides.cocoapods.org/using/getting-started.html#getting-started

MortenGregersen

comment created time in a month

push eventMortenGregersen/capacitor-site

Morten Bjerg Gregersen

commit sha e04747e1940549bc95fd894796515fa3090ab8c5

Gems should never be installed as sudo

view details

push time in a month

startedrealm/SwiftLint

started time in 2 months

startedrealm/SwiftLint

started time in 2 months

startedTokamakUI/Tokamak

started time in 2 months

startedstencilproject/Stencil

started time in 2 months

create barnchMortenGregersen/appstoreconnect-swift-sdk

branch : bundleid-profile

created branch time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha 1eda42a35d4e2ccbd3890a30a7212fdc643ba1a8

Update AppStoreVersion.swift

view details

Morten Bjerg Gregersen

commit sha 4261d7c608b2e759e2dcf140b3b282c5b137d43c

Update AppStoreVersionRelationship.swift

view details

Morten Bjerg Gregersen

commit sha 61add803dfc1d960a783967162df22f1b79f5b55

Update ListAppStoreVersionsForApp.swift

view details

push time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha abc76b94dcb820c53903c8873373b76a0f3a1fdd

Update ListAppStoreVersionsForApp.swift

view details

push time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha 5a1d0e639b8445a05f64f7ddec1c3ea242d18fd6

Update GetApp.swift

view details

Morten Bjerg Gregersen

commit sha 53a7ee5a0238280364ee426de7bcfc2574720bb2

Merge branch 'app-info' of https://github.com/MortenGregersen/appstoreconnect-swift-sdk into app-info

view details

Morten Bjerg Gregersen

commit sha f15701ae0a24b25a9291cd490c83e326cb84e064

Create ListAppStoreVersionsForApp.swift

view details

Morten Bjerg Gregersen

commit sha 614cba5bf88489e9ec85078154b2780d3bc926e9

Update ListAppStoreVersionsForApp.swift

view details

push time in 2 months

pull request commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

Regarding the errors, do you have them after doing a clean build locally? It builds fine on my machine when I do a clean build in both Xcode 11.7 and Xcode 12 beta 6. In Xcode 12 I get 158 warnings saying "Immutable property will not be decoded because it is declared with an initial value which cannot be overwritten" for the let type property on all the models.

MortenGregersen

comment created time in 2 months

Pull request review commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

 public enum ListApps {         case id([String])         case name([String])         case sku([String])+        case appStoreVersions([AppStoreVersion])+        case appStoreVersionsPlatform([Platform])+        case appStoreVersionsAppStoreState([AppStoreVersionState])

@AvdLee I don't understand the errors reported. AppStoreVersionState is declared here: https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/116/files#diff-1296794fa717ed0daf233b30e30b3d5eR10

MortenGregersen

comment created time in 2 months

PullRequestReviewEvent

push eventMortenGregersen/appstoreconnect-swift-sdk

Antoine van der Lee

commit sha 03694c951a5c3b056ab5742d1fb62f6b93ea5426

Update stale.yml

view details

Morten Bjerg Gregersen

commit sha 4ca040a848371647ce2ebe07c3df71dee8c80cfa

Merge branch 'master' into app-info

view details

push time in 2 months

pull request commentAvdLee/appstoreconnect-swift-sdk

App Info and App Store Version

I don't understand why the build fails. It doesn't look like the build has started on Bitrise.

MortenGregersen

comment created time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha 7bc50b4163f1e66619e2078a059d6e1fb78d0f0c

Update AppInfo.swift

view details

push time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha 1ca0989e6b22a627c1b23b4e8d4c64524dc89a07

Update AppInfo.swift

view details

push time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha a9a766632c2361a506603e8cac3be1010e0b6c38

Clean

view details

push time in 2 months

push eventMortenGregersen/appstoreconnect-swift-sdk

Morten Bjerg Gregersen

commit sha 66acb33daf0fe6dc6ca7dde87ec58bcc7d181845

Update ListAppInfosFoApp.swift

view details

Morten Bjerg Gregersen

commit sha 283d957ea53de1141c1337178f065893043ef4ab

Update ListAppInfosFoApp.swift

view details

Morten Bjerg Gregersen

commit sha a8786cb6297385482fc44dab1d598b17a05c5381

Move around

view details

Morten Bjerg Gregersen

commit sha c1d869731f3501c2574adb3a23fdbff9959fb27e

Update ListAppInfosForApp.swift

view details

Morten Bjerg Gregersen

commit sha 293215218169287aff46b5db760537d4b7c73306

ReadAppInfoOfApp

view details

Morten Bjerg Gregersen

commit sha d9e01502fb340d92b81703d9164ab5f8a2d88d45

Update ListApps.swift

view details

Morten Bjerg Gregersen

commit sha 2a9bf924628939ab317d4597e73e5471664060e6

Update ListApps.swift

view details

Morten Bjerg Gregersen

commit sha 138f1db438c0497b2bcb3ba9121888ff0bef8a1b

Update AppRelationship.swift

view details

Morten Bjerg Gregersen

commit sha 3e8da2c70780f3118aeca6330ac192ba3f38e6d2

Update AppInfo.swift

view details

Morten Bjerg Gregersen

commit sha a053259a30f6d913470688138e77698a6465dd6a

AppStoreVersion

view details

Morten Bjerg Gregersen

commit sha 82ba9055568937fb9ab1f7fa07ff463a351a21a2

Update AppStoreVersionState.swift

view details

Morten Bjerg Gregersen

commit sha bd5ef32ab700b29269c4c74c76d23935549fb580

Update ListApps.swift

view details

Morten Bjerg Gregersen

commit sha d551f54d3601cf237cd3e5f20e63745bd6c3e976

Update ListApps.swift

view details

push time in 2 months

PR opened kirbydesign/designsystem

Clean up NativeScript remains

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] cookbook application / infrastructure changes
  • [X] Other... Please describe: Cleaning 🧹

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+0 -15

0 comment

3 changed files

pr created time in 2 months

create barnchkirbydesign/designsystem

branch : nativescript-cleanup

created branch time in 2 months

create barnchMortenGregersen/appstoreconnect-swift-sdk

branch : app-info

created branch time in 2 months

fork MortenGregersen/appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.

fork in 2 months

startedAvdLee/appstoreconnect-swift-sdk

started time in 2 months

issue commentAvdLee/appstoreconnect-swift-sdk

Replace hand crafted code with code generated from OpenAPI Spec

I think this is a good idea, but I have tried the Swagger code generators and for Swift they all use Alamofire. The good thing about this project, is that it uses URLSession. But when the Swagger code generators use URLSession, I think this should be considered, as it would help keep the models up to date.

orj

comment created time in 2 months

PR opened kirbydesign/designsystem

Correct card text colors

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] cookbook application / infrastructure changes
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Other information

+3 -3

0 comment

1 changed file

pr created time in 2 months

create barnchkirbydesign/designsystem

branch : card-text-colors

created branch time in 2 months

starteddempseyatgithub/BuildSettingExtractor

started time in 2 months

delete branch MortenGregersen/appstoreconnect-swift-sdk

delete branch : catalyst-profiles

delete time in 2 months

create barnchMortenGregersen/appstoreconnect-swift-sdk

branch : catalyst-profiles

created branch time in 2 months

fork MortenGregersen/appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.

fork in 2 months

GollumEvent

push eventFluxorOrg/Fluxor

MortenGregersen

commit sha 19e1c622b4f7763ad1b0703666bff6cb2342a910

Deploy to GitHub pages

view details

push time in 3 months

GollumEvent

push eventFluxorOrg/Fluxor

Morten Bjerg Gregersen

commit sha f15306d661b26a568651a179e583c0e8f6033add

Make the Store able to subscribe to Action publishers (#85)

view details

push time in 3 months

delete branch FluxorOrg/Fluxor

delete branch : store-subscriber

delete time in 3 months

PR merged FluxorOrg/Fluxor

Make the Store a Subscriber
+33 -14

0 comment

2 changed files

MortenGregersen

pr closed time in 3 months

push eventFluxorOrg/Fluxor

MortenGregersen

commit sha 3059755b7f0c8dee122b2503fddd2de62a013558

Deploy to GitHub pages

view details

push time in 3 months

push eventFluxorOrg/Fluxor

Morten Bjerg Gregersen

commit sha c88d6660b42c7c5780416f58ed0533e4fbaa43d3

Make tests less flaky (#86)

view details

push time in 3 months

delete branch FluxorOrg/Fluxor

delete branch : minimize-flakiness

delete time in 3 months

PR merged FluxorOrg/Fluxor

Make tests less flaky
+16 -13

0 comment

4 changed files

MortenGregersen

pr closed time in 3 months

PR opened FluxorOrg/Fluxor

Make tests less flaky
+16 -13

0 comment

4 changed files

pr created time in 3 months

create barnchFluxorOrg/Fluxor

branch : minimize-flakiness

created branch time in 3 months

PR opened FluxorOrg/Fluxor

Make the Store a Subscriber
+33 -14

0 comment

2 changed files

pr created time in 3 months

create barnchFluxorOrg/Fluxor

branch : store-subscriber

created branch time in 3 months

issue commentkirbydesign/designsystem

[BUG] Title in page not fitting on one line when actions are present

is this also happening when u have a button with only an icon @MortenGregersen ? :)

Yes

Screenshot 2020-07-31 at 12 45 17

MortenGregersen

comment created time in 3 months

push eventkirbydesign/designsystem

sorenfruergaard

commit sha 311f75892d42dd86a8ad154ceb675e12b7385353

fix z-index on reorder card (#1086)

view details

Travis CI User

commit sha e54012864061dbdfaf50af9a2fa018a15cc89714

:bookmark: Bumping version to 1.2.47

view details

Morten Bjerg Gregersen

commit sha eaa26b49602acca5c670f23e82f8ebcecf36d4ad

Make back buttons on Page bigger (#1057) * Make back buttons on Page bigger * Update page.component.scss * Variables * Update page.component.scss * Update page.component.scss * 💄 Fix fat finger size for all toolbar buttons * 💄 Remove title padding * ✅ Add toolbar button size tests Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>

view details

Travis CI User

commit sha 35865b9896a02a21cf832fbce3e2890b8f9aa0dc

:bookmark: Bumping version to 1.2.48

view details

Morten Bjerg Gregersen

commit sha 12c9a1b0a7cc5a0e0405551ad12b5e2121d2bdd9

Disable analytics in angular.json (#1084) Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>

view details

Travis CI User

commit sha 9b847fc94a135e9cdc2f38a59ba6b0eb48898d2c

:bookmark: Bumping version to 1.2.49

view details

ckibsen

commit sha a3e249eb1cf1937453074759056c5282bed7ce21

Feature/kirby flag (#1088) * Added Flag Component * ✅ Add Flag Component tests * Fixed styling to please tests * 📝 Update flag examples * 💄 📝 Fix showcase-properties inputValues formatting * 💄 📝 Add wrapping to avatar color examples * 💄 Add `xxxxs` size * 💄 Replace hardcoded px values with tokens * 📝 Use flag component in item examples * 💄 Refactor styling * ♻️ Replace size directive with HostBinding * ✅ Update tests * ⏪ Revert * 🎨 Clean up Co-authored-by: Christian K. Ibsen <jb7612@jyskebank.dk> Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>

view details

Travis CI User

commit sha 70bdb2c08e992d002da25c6a32618405ffff1a8e

:bookmark: Bumping version to 1.2.50

view details

nicolainormann

commit sha f3695562536b17026f4cd7f390122f61b00e1685

Enhance/tabs (#1091) * Enhancements to tabs * Added white background to tabs * Move icon tab bar on tablet size

view details

Travis CI User

commit sha 02c4f7cb8aa2100c99982914146316b922a36445

:bookmark: Bumping version to 1.2.51

view details

Peter Larsen

commit sha cfe273d3e95e721c8a8e18f92d7fd10f88a3211f

Styling of tab bar (#1092)

view details

Travis CI User

commit sha 584d60490ed7c9138647f2c70e812a7b9a90f394

:bookmark: Bumping version to 1.2.52

view details

Peter Lindholm

commit sha 2dfd428067d9444ae263aa13100ed2b8bbea1d98

:art: Removing max-width for ion-header and ion-toolbar on tablet (#1093)

view details

Travis CI User

commit sha 89e9bc09e19dda6b00c496000ce4af5f113c5915

:bookmark: Bumping version to 1.2.53

view details

Morten Bjerg Gregersen

commit sha 4018086a56b124cbfa9f577a8e351349472e23ea

Merge branch 'master' into list-on-demand

view details

push time in 3 months

issue commentkirbydesign/designsystem

[Enhancement] Backdrop of FAB Sheet should be covering the whole viewport

Is this different from #756?

hafstad

comment created time in 3 months

issue openedkirbydesign/designsystem

[BUG] Title in page not fitting on one line when actions are present

Describe the bug When a non-breakable title is used in a page with titleMaxLines set to 1 and actions present, the title isn't fitting/scaled down on small screen sizes like the iPhone 5s/SE (5-inch).

In "Investment" in DRB we have a long non-breakable title and a wide button as action, so it isn't looking great on the small screens.

To Reproduce Steps to reproduce the behavior:

Create a page like the following. The easiest is to use the PageFitHeadingExampleComponent in the Cookbook and change the title and add the actions.

<kirby-page title="Loremipsumbum" titleMaxLines="1">
  <kirby-page-actions *kirbyPageActions="{ sticky: false }">
    <button kirby-button>Get bacon</button>
  </kirby-page-actions>
  <kirby-page-content>
    <div>Some content</div>
  </kirby-page-content>
</kirby-page>

Kirby version

  • 1.2.53

Expected behavior I would expect the title to scale down

Screenshots Screenshot 2020-07-28 at 11 12 52

Please complete the following information:

  • OS: Doesn't matter
  • Browser: Doesn't matter
  • Browser version: Doesn't matter

Tasks:

  • [ ] Move issue from "Ready to do" -> "in progress" on our project board
  • [ ] Create Fix Branch
  • [ ] Create test reproducing the error
  • [ ] Fix
  • [ ] If relevant Update Examples and Showcase
  • [ ] Push commits to GitHub
  • [ ] Open a pull request (remember to add closes #issueno to the description) and ask @kirbydesign/kirby-guild for review
  • [ ] Merge to master and delete branch

created time in 3 months

more