profile
viewpoint
Maxim Mazurok Maxim-Mazurok Mobline Odessa, Ukraine https://maxim.mazurok.com Web Developer

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 74cc47b29a2c82ec6f7fded24a2c3b8e3275b16b

transaction form, transaction types

view details

push time in 9 hours

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 4d2cfae961b9eca49c7f93b8747133fbd3b0f7d8

update sheets typings

view details

Maxim Mazurok

commit sha 61d0de6d825822500b73b82b1b9a0f9b37b2e1c5

operation form tsx

view details

Maxim Mazurok

commit sha 8d475f3e8c6e1f4c7e75b76fa0219206ad4156ad

all tsx!

view details

Maxim Mazurok

commit sha 84c9db9803ae0aece106be8723c23fe0b19ec609

menu index fix

view details

Maxim Mazurok

commit sha e531906ab9b5156102001c73e9058a4197fad900

beautify

view details

Maxim Mazurok

commit sha fdbad814fcec4329934350eb7c3499d0f0dc3c16

load expenses, a lot of refactoring, redux

view details

push time in 11 hours

pull request commentFyrd/caniuse

MediaQueryList.addEventListener Safari and IE bug

Created PR https://github.com/Fyrd/caniuse/pull/5055 Closing this one

Maxim-Mazurok

comment created time in 2 days

PR closed Fyrd/caniuse

MediaQueryList.addEventListener Safari and IE bug

MediaQueryList.addEventListener doesn't work in Safari and IE

Related discussions: https://github.com/microsoft/TypeScript/issues/32210, https://github.com/ReactTraining/react-media/pull/135, https://github.com/mdn/browser-compat-data/pull/3674

+3 -1

3 comments

1 changed file

Maxim-Mazurok

pr closed time in 2 days

PR opened Fyrd/caniuse

MediaQueryList.addEventListener Safari and IE bug

MediaQueryList.addEventListener doesn't work in Safari and IE

Related discussions: https://github.com/microsoft/TypeScript/issues/32210, https://github.com/ReactTraining/react-media/pull/135, https://github.com/mdn/browser-compat-data/pull/3674

+3 -1

0 comment

1 changed file

pr created time in 2 days

push eventMaxim-Mazurok/caniuse

Maxim Mazurok

commit sha 81444a5436e097ebac78541b67b50818b6b49682

MediaQueryList.addEventListener Safari and IE bug

view details

push time in 2 days

push eventMaxim-Mazurok/DefinitelyTyped

Maxim Mazurok

commit sha 5ded0ccbf22209a243416cd313b6518318ce415d

Fix bugs

view details

push time in 2 days

push eventMaxim-Mazurok/DefinitelyTyped

Maxim Mazurok

commit sha efaf4f5e5caaf01ce7d878f96a75423f8bf65cd5

Update tests for gapi.client.sheets

view details

push time in 2 days

push eventMaxim-Mazurok/DefinitelyTyped

Maxim Mazurok

commit sha 68eda202bb282d5d4eee60634ce11091cd45eea9

Update tests for gapi.client.sheets

view details

push time in 2 days

PR opened DefinitelyTyped/DefinitelyTyped

[gapi.client.sheets] Update Google Sheets API with fixes

Updated typings for Google Sheets, generated using https://github.com/Maxim-Mazurok/google-api-typings-generator/tree/patch-1

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Bolisov/google-api-typings-generator/pull/8
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+448 -106

0 comment

1 changed file

pr created time in 2 days

push eventMaxim-Mazurok/DefinitelyTyped

Maxim Mazurok

commit sha fd670e28dd13af5486bdef5faaeffa2ce86bb745

Update Google Sheets API with fixes Updated typings for Google Sheets, generated using https://github.com/Maxim-Mazurok/google-api-typings-generator/tree/patch-1

view details

push time in 2 days

fork Maxim-Mazurok/DefinitelyTyped

The repository for high quality TypeScript type definitions.

http://definitelytyped.org/

fork in 2 days

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 35ecdfe3ceda47c7b69f968864b4979e079560d0

js -> ts, refactoring

view details

push time in 2 days

pull request commentBolisov/google-api-typings-generator

Take into account `repeated` flag for types

@declanvong it seems like you might have the most active fork, I'll be happy to contribute this change to your fork.

Maxim-Mazurok

comment created time in 2 days

PR opened Bolisov/google-api-typings-generator

Take into account `repeated` flag for types

For example, gapi.client.sheets.spreadsheets.values.batchGet accepts either string or array of strings. This patch takes that into account.

"ranges": {
  "location": "query",
  "description": "The ranges to retrieve from the spreadsheet.",
  "type": "string",
  "repeated": true
}
+3 -2

0 comment

1 changed file

pr created time in 2 days

push eventMaxim-Mazurok/google-api-typings-generator

Maxim Mazurok

commit sha 48130a20f1521d3c33e4bd2077829539af6ba7e8

Take into account `repeated` flag for types For example, `gapi.client.sheets.spreadsheets.values.batchGet` accepts either string or array of strings. This patch takes that into account. ````JSON "ranges": { "location": "query", "description": "The ranges to retrieve from the spreadsheet.", "type": "string", "repeated": true } ````

view details

push time in 2 days

startedds300/patch-package

started time in 2 days

pull request commentFyrd/caniuse

MediaQueryList.addEventListener Safari and IE bug

Maybe features-json/matchmedia.json is a better place to add this issue?

Maxim-Mazurok

comment created time in 3 days

startedFyrd/caniuse

started time in 3 days

PR opened Fyrd/caniuse

MediaQueryList.addEventListener Safari and IE bug

MediaQueryList.addEventListener doesn't work in Safari and IE

Related discussions: https://github.com/microsoft/TypeScript/issues/32210, https://github.com/ReactTraining/react-media/pull/135, https://github.com/mdn/browser-compat-data/pull/3674

+3 -1

0 comment

1 changed file

pr created time in 3 days

push eventMaxim-Mazurok/caniuse

Maxim Mazurok

commit sha cfd583b88f6b8be87aef9e324d597fe1f74e92c0

MediaQueryList.addEventListener Safari and IE bug

view details

push time in 3 days

push eventMaxim-Mazurok/caniuse

Maxim Mazurok

commit sha 10b23f21a466f09e52d33e8f5e04e4ddde38ecf6

MediaQueryList.addEventListener Safari bug MediaQueryList.addEventListener doesn't work in Safari

view details

push time in 3 days

fork Maxim-Mazurok/caniuse

Raw browser/feature support data from caniuse.com

https://caniuse.com

fork in 3 days

issue commentmicrosoft/TypeScript

MediaQueryList.prototype.addListener & removeListener are marked as deprecated

BTW, the best way to see the browser support for these particular methods is to go to MDN:MediaQueryList#Browser_compatibility and check out MediaQueryList inheriting from EventTarget section of the table. Thanks to https://github.com/mdn/browser-compat-data/pull/3674 for making this contribution.

fabiancook

comment created time in 3 days

issue commentmicrosoft/TypeScript

MediaQueryList.prototype.addListener & removeListener are marked as deprecated

I agree, this change created a bit of trouble here: https://github.com/ReactTraining/react-media/pull/135#issuecomment-523520677 Potentially, breaking compatibility of the popular React library. Luckily, I decided to go with my custom solution and not using this library, and later doing cross-browser testing I've found out that Safari doesn't support addEventListener for MediaQueryList. Even 13.1 (TP).

fabiancook

comment created time in 3 days

pull request commentReactTraining/react-media

deprecated addListener and removeListener update

Yeah, they support addEventListener in general, but not for the MediaQueryList, unfortunately. Here's a relevant issue: https://github.com/microsoft/TypeScript/issues/32210

Maxim-Mazurok

comment created time in 3 days

issue commentalvarotrigo/fullPage.js

Mobile Safari height wrong with address bar and tabs

@MickL I can't find it there :) There are just some typo fixes.

He meant the 4th reply: https://github.com/alvarotrigo/fullPage.js/issues/2414#issuecomment-261716140

MickL

comment created time in 3 days

pull request commentReactTraining/react-media

deprecated addListener and removeListener update

So, I just found out that it's not supported in Safari on Mac OS. I tried 13.0 and 13.1 (TP). Both of them only know addListener for MediaQueryList, unfortunately. It's not working on my iOS devices also (iOS 12.4). You might want to revert this change or make it part of the major release, introducing a breaking change. Sorry about that...

Maxim-Mazurok

comment created time in 4 days

issue commenttypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false negative in for loop

Ok, so should I open an issue in babel-eslint or in eslint repo?

Maxim-Mazurok

comment created time in 4 days

issue commenttypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false negative in for loop

Sorry, it seems that the issue reproduces only with parser: 'babel-eslint' (10.0.2)

Maxim-Mazurok

comment created time in 4 days

startedgoldbergyoni/javascript-testing-best-practices

started time in 5 days

issue openedtypescript-eslint/typescript-eslint

[@typescript-eslint/no-unused-vars] false negative in for loop

<!-- If you have a problem with a specific rule, please begin your issue title with [rulename] to make it easier to search for. I.e. "[no-unused-vars] False positive when fooing the bar"

Please don't ignore this template.

If you ignore it, we're just going to respond asking you to fill it out, which wastes everyone's time. The more relevant information you can include, the faster we can find the issue and fix it without asking you for more info. -->

<!-- Are you opening an issue because the rule you're trying to use is not found? 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

  1. Check the releases log: https://github.com/typescript-eslint/typescript-eslint/releases
    • If the rule isn't listed there, then chances are it hasn't been released to the main npm tag yet.
  2. Try installing the canary tag: npm i @typescript-eslint/eslint-plugin@canary.
    • The canary tag is built for every commit to master, so it contains the bleeding edge build.
  3. If ESLint still can't find the rule, then consider reporting an issue. -->

Repro

{
  "extends": ["plugin:@typescript-eslint/recommended"]
}
for (const property in headers) {
  if (headers.hasOwnProperty(property)) {
    request.setRequestHeader(property, headers[property]);
  }
}

Expected Result

No warnings

Actual Result

warning 'property' is defined but never used @typescript-eslint/no-unused-vars

Additional Info

<!-- Did eslint throw an exception?

Please run your lint again with the --debug flag, and dump the output below. i.e. eslint --ext ".ts,.js" src --debug -->

Versions

package version
@typescript-eslint/eslint-plugin 2.0.0
@typescript-eslint/parser 2.0.0
TypeScript 3.5.3
ESLint 6.2.1
node 10.16.3
npm 6.10.3

created time in 5 days

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 4a139c1a95b65f05a1eed36200aea5751c4c765c

js -> ts, refactoring

view details

push time in 5 days

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 643a94c73e875411b75b665663eac693d0ae955e

custom loader -> linear progress + npm update

view details

push time in 5 days

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha d4ad9c4c716d532f4b729358ee0b07f9e046930d

OperationIcon js -> ts + class -> function, refactoring

view details

push time in 5 days

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha fede43cc029895054da5823e74a2dcfd9eb7fccf

load gapi dynamically, fix tests, npm update

view details

push time in 5 days

startedkolodny/immutability-helper

started time in 5 days

startedomcljs/om

started time in 5 days

startedalicevision/AliceVision

started time in 8 days

delete branch Maxim-Mazurok/jest

delete branch : patch-1

delete time in 9 days

startedfacebook/jest

started time in 9 days

pull request commentfacebook/jest

Updated matchMedia methods

Just missing https://github.com/facebook/jest/blob/master/website/versioned_docs/version-22.x/ManualMocks.md and we're good to go

Actually, this file doesn't have "Mocking methods which are not implemented in JSDOM" section, so there's nothing to fix there.

Sure, sounds good!

Done, in both files :)

Maxim-Mazurok

comment created time in 9 days

push eventMaxim-Mazurok/jest

Maxim Mazurok

commit sha 186c196d342955f3aa9e4a988f01396d7ffee63c

Updated matchMedia methods

view details

push time in 9 days

push eventMaxim-Mazurok/jest

Maxim Mazurok

commit sha ee635520838a4fd3fc92d4d3ca39765082ed697b

Updated matchMedia methods in version-23.x

view details

push time in 9 days

pull request commentfacebook/jest

Updated matchMedia methods

@SimenB done :)

By the way, since MediaQueryList extends EventTarget, there's also removeEventListener method missing. Should I add it in this same PR?

Maxim-Mazurok

comment created time in 9 days

push eventMaxim-Mazurok/jest

Maxim Mazurok

commit sha 51852db200a63733384924c68ebedc9c48fbed6c

Updated matchMedia methods in version-23.x

view details

push time in 9 days

PR opened facebook/jest

Updated matchMedia methods

addListener and removeListener are deprecated in a favor of addEventListener and removeEventListener.

From MediaQueryList/addListener

This (addListener) is basically an alias for EventTarget.addEventListener(), for backwards compatibility purposes.

They are supported by all major browsers: EventTarget/addEventListener

BTW, TSLint is producing the following error when trying to use addListener:

ERROR: /app/Component.tsx:xx:xx - addListener is deprecated.
+4 -2

0 comment

1 changed file

pr created time in 9 days

push eventMaxim-Mazurok/jest

Maxim Mazurok

commit sha 70361d263ddb14121aeeb8cc017bd511736e55f6

Updated matchMedia methods `addListener` and `removeListener` are deprecated in favor of `addEventListener` and `removeEventListener`

view details

push time in 9 days

fork Maxim-Mazurok/jest

Delightful JavaScript Testing.

https://jestjs.io

fork in 9 days

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha d590e5c4be84849c84903f381407fa4e5e773272

npm update, google logo, 2 js -> ts

view details

push time in 10 days

PR opened ReactTraining/react-media

deprecated addListener and removeListener update

addListener and removeListener are deprecated in a favor of addEventListener and removeEventListener.

From MediaQueryList/addListener

This (addListener) is basically an alias for EventTarget.addEventListener(), for backwards compatibility purposes.

They are supported by all major browsers: EventTarget/addEventListener

BTW, TSLint is producing the following error when trying to use addListener:

ERROR: /app/Component.tsx:xx:xx - addListener is deprecated.
+4 -4

0 comment

2 changed files

pr created time in 11 days

push eventMaxim-Mazurok/react-media

Maxim Mazurok

commit sha 63f5ef4a2bce87208221a10461b8b222c66395ee

addListener and removeListener (deprecated) -> addEventListener and removeEventListener

view details

push time in 11 days

fork Maxim-Mazurok/react-media

CSS media queries for React

fork in 11 days

delete branch Maxim-Mazurok/awesome-ci

delete branch : patch-1

delete time in 11 days

delete branch Maxim-Mazurok/json-mindmap

delete branch : dependabot/npm_and_yarn/lodash-4.17.14

delete time in 12 days

push eventMaxim-Mazurok/json-mindmap

dependabot[bot]

commit sha 3e47b9ca61632f2ed5a9f389374e5802dbce6ee1

Bump lodash from 4.17.11 to 4.17.14 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14) Signed-off-by: dependabot[bot] <support@github.com>

view details

Maxim Mazurok

commit sha df8e39e50614e03371e87153fb4b414e5c1735fe

Merge pull request #1 from Maxim-Mazurok/dependabot/npm_and_yarn/lodash-4.17.14 Bump lodash from 4.17.11 to 4.17.14

view details

push time in 12 days

PR merged Maxim-Mazurok/json-mindmap

Bump lodash from 4.17.11 to 4.17.14 dependencies

Bumps lodash from 4.17.11 to 4.17.14. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

pull request commentreact-bootstrap/react-bootstrap

fix(types): make column prop optional for Label

Well, I got it working, but it only works if I define props outside of the component. Here is the typings:

interface FormLabelBaseProps {
  htmlFor?: string;
  innerRef?: React.LegacyRef<this>;
  srOnly?: boolean;
}

export interface FormLabelOwnProps extends FormLabelBaseProps {
  column: false;
}

export interface FormLabelWithColProps extends FormLabelBaseProps, ColProps {
  column: true;
}

export type FormLabelProps = FormLabelWithColProps | FormLabelOwnProps | FormLabelBaseProps;

And here's my code:

const props: FormLabelProps = {
  column: true,
  xs: '1'
};

<Form.Label {...props}>Label</Form.Label>

If I put invalid props into jsx, it will still pass validation:

<Form.Label xs={'1'}>Password:</Form.Label>

I think it might be React or Typescript bug.

Otherwise, all tests are passing: Invalid:

const props: FormLabelProps = {
  column: false,
  xs: '1'
};
const props: FormLabelProps = {
  xs: '1'
};

and valid:

const props: FormLabelProps = {};
const props: FormLabelProps = {
  column: false,
};
const props: FormLabelProps = {
  column: true,
  xs: '1'
};

P.S. Turns out, that swapping FormLabelWithColProps and FormLabelOwnProps removed warning from IDEA.

Maxim-Mazurok

comment created time in 12 days

pull request commentreact-bootstrap/react-bootstrap

fix(types): make column prop optional for Label

Right, I'll try to fix it.

Maxim-Mazurok

comment created time in 12 days

startedtc39/proposal-class-fields

started time in 15 days

pull request commentreact-bootstrap/react-bootstrap

fix(types): make column prop optional for Label

Reported IDEA bug here: https://youtrack.jetbrains.com/issue/IDEA-220380 There's also a similar issue that is not being fixed in three months.

Why won't it hurt typing-wise? It would make the column branch on the union match even when it shouldn't.

Well, currently TS allows me to add ColProps without column: true: <Form.Label xs={'3'}>Email address</Form.Label> And it also allows me to add column={true} without any ColProps: <Form.Label column={true}>Email address</Form.Label>

So, it seems to me that this branching is kind of useless anyway...

Also, with my changes applied, <Form.Label column={false} xs={'1'}>Password</Form.Label> is still invalid (as it should be).

So, I don't see any real issues with it. What do you think?

Maxim-Mazurok

comment created time in 16 days

pull request commentreact-bootstrap/react-bootstrap

fix(types): make column prop optional for Label

I agree, probably, the best way to approach this problem is from both sides: report IDEA bug and apply this fix to react-bootstrap, while we're waiting for the fix from IDEA. It won't hurt typing-wise AFAIK.

Maxim-Mazurok

comment created time in 16 days

PR opened react-bootstrap/react-bootstrap

fix(types): make column prop optional for Label

In IntelliJ IDEA, using <Form.Label>Email address</Form.Label> results in Warning: Element Form.Label doesn't have required attribute column. Making column optional in FormLabelWithColProps fixes it.

+1 -1

0 comment

1 changed file

pr created time in 16 days

push eventMaxim-Mazurok/react-bootstrap

Maxim Mazurok

commit sha 9ea67ad4ab495961771e4b07fd6881070098196c

Make column prop optional for Label

view details

push time in 16 days

startedyodaiken/dolphinsr

started time in 20 days

issue commentsymfony/symfony

[RFC] Add support for Websockets and real-time applications

@javiereguiluz so, is there any progress on WebSockets in Symphony? I'm using enqueue for amqp and they use Symphony async loop. And I want to use both enqueue and websockets in one async event loop. Currently, I can't do it because most WebSocket solutions rely on React's async event loop. And I'm not sure that it's possible to have two async event loops in one script.

javiereguiluz

comment created time in 22 days

starteddunglas/mercure

started time in 22 days

issue commentmui-org/material-ui

ListItem has link ?

Here's my approach, using built-in Mui-selected class:

<ListItem
  button
  component={NavLink}
  activeClassName={"Mui-selected"}
  to={"/some-url"}
  exact
>
  ...
</ListItem>
TonyFrancis

comment created time in 23 days

push eventMaxim-Mazurok/shopify-emons-integration

Maxim Mazurok

commit sha 562febc75d6619aa6d4acf1911eae47b61dd2f07

npm update

view details

Maxim Mazurok

commit sha 8a28db365087825ba44868e93c6644f65ac928e1

npm update

view details

push time in 25 days

starteddeanoemcke/thegreatsuspender

started time in 25 days

startedReactTraining/react-router

started time in a month

startedclbr/radeontop

started time in a month

startedjeffbski/wait-on

started time in a month

delete branch Maxim-Mazurok/deno

delete branch : patch-3

delete time in a month

startedDefinitelyTyped/DefinitelyTyped

started time in a month

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha db8c5aa96261e8772df73afae67590a4f567b745

fab fix

view details

push time in a month

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 70f05880579c7ea0cb06fd0638d8a0f59865d870

selected menu title

view details

push time in a month

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 4759008912a964a1b3f51a2e08f157fbd7acbf3b

menu fix

view details

push time in a month

startedstorybookjs/storybook

started time in a month

startedtesting-library/react-testing-library

started time in a month

CommitCommentEvent

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha 01b2139f4347946d02ddb92123eae0a04cfdb3f6

npm upgrade

view details

push time in a month

push eventMaxim-Mazurok/expenses

Maxim Mazurok

commit sha a0669990a8c554c552067868b11412a77524f164

redux navigation, update, etc.

view details

push time in a month

issue commentadamturcsan/reconnecting-pdo

When server has gone away a long time, will always throw "No PDO connection is set"

Yeah, I agree with @adamturcsan @Moln can you give a valid use-case or real-world situation when such error occurs? From my point of view, it's only possible in case if the server is MySQL server is down, which doesn't seem like a good thing in the first place. You probably want to set up monitoring with alerts on your MySQL server to prevent this. Also, you probably should inform your users that the DB is down. Anyway, I would recommend making PR if you still want to implement this. But please, make this optional. Somebody may not have MySQL alerts in place and will rely on the server log, looking for errors. Thanks!

Moln

comment created time in a month

startedintel/hyperscan

started time in a month

startedcjhutto/vaderSentiment

started time in a month

pull request commentadamturcsan/reconnecting-pdo

Disable PHP Warning

Thanks for your feedback!

I'm using PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION, but it isn't helping. It's a bug in PDO that causes both warning and exception to be triggered. You can find a more detailed explanation here: PDO::ERRMODE_EXCEPTION doesn't suppress warning So, as much as I hate using @, I couldn't find any better solution. Currently, I ended up extending your class and overriding the ping method, which is also not a great solution, because if you will update your ping method - I will have to update my method as well.

Maxim-Mazurok

comment created time in a month

delete branch Maxim-Mazurok/reconnecting-pdo

delete branch : patch-2

delete time in a month

push eventMaxim-Mazurok/linux-monitor

Maxim Mazurok

commit sha 83d72ea5fdd0e8c9d7f0362e858be3232731e35e

cpu freq, refactoring, docs update

view details

push time in a month

push eventMaxim-Mazurok/linux-monitor

Maxim Mazurok

commit sha 59b806ce100ec2db191635c687822b9d0e731ba0

cpu freq

view details

push time in a month

push eventMaxim-Mazurok/linux-monitor

Maxim Mazurok

commit sha bb4fb43de8513fd834da91f5d84b91156d784d8c

swap fix, demo update

view details

push time in 2 months

push eventMaxim-Mazurok/linux-monitor

Maxim Mazurok

commit sha 134276b8a80fa75841086b3ea410c482a76a0ac4

readme

view details

push time in 2 months

create barnchMaxim-Mazurok/linux-monitor

branch : master

created branch time in 2 months

created repositoryMaxim-Mazurok/linux-monitor

Linux Resource Usage Monitor with Web-based GUI and charts

created time in 2 months

push eventMaxim-Mazurok/simple-client

Maxim Mazurok

commit sha 968421c21edaf3c43b7f3566271a69025ef02f56

Allow adding custom consumption extensions

view details

push time in 2 months

push eventMaxim-Mazurok/simple-client

Maxim Mazurok

commit sha 4c041a973cfeafc49baadb3a717cbc7f414f3e8a

Allow adding custom consumption extensions

view details

push time in 2 months

push eventMaxim-Mazurok/simple-client

Maxim Mazurok

commit sha 2ad6334c1257864c31edd4ba262641a33bc2a48c

Allow adding custom consumption extensions

view details

push time in 2 months

push eventMaxim-Mazurok/simple-client

Maxim Mazurok

commit sha f914f32d6e0f487532c289656195e0e19d62b083

Allow adding custom consumption extensions

view details

push time in 2 months

more