profile
viewpoint

MarkTiedemann/cisco-vpn 10

Wrapper around the Cisco AnyConnect VPN client.

MarkTiedemann/deno.mk 4

Cross-platform Makefile for installing and running Deno.

MarkTiedemann/anydo 3

Unofficial Any.do client for Node.js.

angular-hamburg/react.angular.hamburg 2

The old angular.hamburg website for Hamburg's Angular Meetup, written in React.

MarkTiedemann/anydo-cli 1

Unofficial CLI app for Any.do.

MarkTiedemann/device-discovery 1

Discover devices on your local network.

angular-hamburg/api.angular.hamburg 0

The API for angular.hamburg

MarkTiedemann/air.note 0

Simple notepad that works in airplane-mode.

MarkTiedemann/assertion_error 0

Error constructor for test and validation frameworks that implements standardized AssertionError specification.

pull request commentdenoland/deno_install

Trivial installer messaging update on the post install.sh default shell profile filename path

cc @bartlomieju I think this PR is ready to be merged.

jremi

comment created time in 3 hours

PR opened denoland/deno_install

Remove duplicate arch check

Fixes #139

cc @bartlomieju

+0 -5

0 comment

1 changed file

pr created time in 3 hours

create barnchMarkTiedemann/deno_install

branch : fix-139

created branch time in 3 hours

issue commentdenoland/deno_install

Redundant `uname -m` test in installer script

@elibarzilay You are right, thanks for pointing this out! That looks like a merge mistake to me (we had a bunch of PRs being merged in the past few days).

elibarzilay

comment created time in 3 hours

push eventMarkTiedemann/deno.mk

Mark Tiedemann

commit sha 36101b85feb3250f0b00f8a0d7ab39406cfe7ceb

Update MacOS/Linux to 1.0.3

view details

push time in 14 hours

issue commentdenoland/deno

Idiomatic way of managing project's version ?

Hard coding the version in the string doesn't feel right.

From a technical perspective, I don't see a difference between hard-coding the version number in a file called package.json compared to hard-coding it in a file called mod.ts (or whatever name you choose). At the end of the day, it's a version number in a file.

If you already tag your version using git and you don't want to sync it, you could run git describe (or similar git commands, or even read the files in your .git directory) to retrieve your last tag - but that's far more complicated than hard-coding, plus it breaks when the code is being used in another project.

So a third option would be to have a build script that retrieves the last tag from git and replaces your const VERSION = "..."; variable so they are always in sync. But again, that's automation effort that may not be necessary.

KwanJunWen

comment created time in 15 hours

issue commentdenoland/deno_install

Add Install Via Window Package Manager (winget)

duplicate of https://github.com/denoland/deno/issues/5640

ikushaldave

comment created time in 15 hours

push eventMarkTiedemann/deno.mk

Mark Tiedemann

commit sha a29a79adcf378035561b0ca6c6b60cfd17f0b6ac

Update Windows to 1.0.3

view details

push time in a day

issue commentdenoland/deno

Release Builds on WinGet Pkgs

On a related note, I think this issue could be moved to https://github.com/denoland/deno_install.

cc @bartlomieju

ntindle

comment created time in a day

issue commentdenoland/deno

Release Builds on WinGet Pkgs

Just had a look and found a bunch of related upstream issues:

  • https://github.com/microsoft/winget-cli/issues/140
  • https://github.com/microsoft/winget-cli/issues/182
  • https://github.com/microsoft/winget-cli/issues/194

So time to get a coffee and wait for Microsoft to fix this. :)

ntindle

comment created time in a day

push eventMarkTiedemann/deno.mk

Mark Tiedemann

commit sha 03d851ed26c4f411ac52895dff68b265b54fecd3

Update Windows to 1.0.2

view details

push time in a day

push eventMarkTiedemann/marktiedemann.github.io

Mark Tiedemann

commit sha 6156a78829151c3bbb57b86657ca8e9098cbd8ce

Update welcome.ts

view details

push time in a day

push eventMarkTiedemann/deno_install

Scott Hardy

commit sha 2efb5f01b68fa70bee7334d3162057f4ddf154cd

fix: issue with unzip (#122)

view details

Mark Tiedemann

commit sha 7995d4370b3c3d10dcdfd1cddb4ad4c5fcf0934b

Clean-up left-over known issue in readme (#136)

view details

Mark Tiedemann

commit sha a6b3b7de59109dc1dddd8914eddf176a72e8f299

Update specific version from 0.38.0 to 1.0.0 (#135)

view details

Yamboy1

commit sha 6272499aa1037e388dc4e2d9dccd0b9faa3beecc

Add deno-bin (#137)

view details

push time in 2 days

issue commentdenoland/deno_install

Improve install script for WSL

cc @bartlomieju Fixed by #122. This can be closed.

brandonkal

comment created time in 2 days

issue commentdenoland/deno_install

Support i686

cc @bartlomieju Since https://github.com/denoland/deno/issues/3438 is closed now, I think this issue can be closed as well.

vixalien

comment created time in 2 days

issue commentdenoland/deno_install

"replace deno?" EOF or read error

cc @bartlomieju I think #101 fixed this so this issue can be closed.

crabmusket

comment created time in 2 days

issue commentdenoland/deno_install

Install.sh fails in windows with error - Unexpected token 'https://deno.land/x/install/install.ps1' in expression or statement.

Windows 7 was released in 2009. Windows 8 was released in 2012.

Invoke-WebRequest was introduced in PowerShell 3.0, which was released in 2012 with Windows 8.

@charan2009 I'm sorry but the PowerShell installer won't work on Windows 7.


Then again, you don't need the installer. You can install Deno manually. :)

Deno ships as a single executable file that you can download from the releases page (https://github.com/denoland/deno/releases). For more details, please check this comment: https://github.com/denoland/deno/issues/5727#issuecomment-633668916


On yet another note, I don't know whether anyone has tested Deno on Windows 7 yet. It may or may not work...


ref https://github.com/denoland/deno_install/issues/130


cc @bartlomieju, I think this issue can be closed now.

charan2009

comment created time in 2 days

issue commentdenoland/deno_install

Add arch / manjaro install instructions

With both #128 and #137 merged, I think this issue can be closed.

Thanks again, @Yamboy1 and @naueramant!

cc @bartlomieju

Yamboy1

comment created time in 2 days

issue commentdenoland/deno

Release Builds on WinGet Pkgs

For reference, there's a list of supported package managers here: https://github.com/denoland/deno_install#install-via-package-manager

@alexandregv is right. Currently WinGet does not support simply downloading an exe in a zip, but requires an installer. There is a related issue regarding installing curl, which is also distributed as just an exe in a zip (see https://curl.haxx.se/windows/), here: https://github.com/microsoft/winget-pkgs/issues/726.

Might be good to open another upstream issue for allowing binary "installations".

PS: I'd recommend using Scoop to install Deno on Windows. It's always up-to-date, it allows you to install different versions of Deno, and uninstall is just a single command as well.

ntindle

comment created time in 2 days

create barnchMarkTiedemann/deno_install

branch : cleanup-readme

created branch time in 2 days

PR opened denoland/deno_install

Clean-up left-over known issue in readme

cc @bartlomieju

+0 -12

0 comment

1 changed file

pr created time in 2 days

PR opened denoland/deno_install

Update specific version from 0.38.0 to 1.0.0

cc @bartlomieju

+11 -11

0 comment

3 changed files

pr created time in 2 days

create barnchMarkTiedemann/deno_install

branch : update-specific-version

created branch time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 5d62b56e5a5cf99d87cd71e4a41521a8ec356c92

Fix PowerShell usage in CI (#134)

view details

Mark Tiedemann

commit sha 0668841b04662dd042eeb1803646f1521c7a735d

Remove temp file from PS install command; Remove PS linting (#133)

view details

push time in 2 days

pull request commentdenoland/deno_install

Restrict Set-ExecutionPolicy scope

Since #133 has been merged, the known issue "Running scripts is disabled" does not exist anymore. So this PR can be closed.

mattcbaker

comment created time in 2 days

Pull request review commentdenoland/deno_install

[issue-117] Unzip

 scoop reset deno ## Compatibility  - The Shell installer can be used on Windows via the [Windows Subsystem for Linux](https://docs.microsoft.com/en-us/windows/wsl/about).++## Known Issues++### unzip is required++The program [`unzip`](https://linux.die.net/man/1/unzip) is a requirement for the Shell installer.++```sh+$ curl -fsSL https://deno.land/x/install/install.sh | sh+Error: unzip is required to install Deno (see: https://github.com/denoland/deno_install#unzip-is-required).+```++**When does this issue occur?**++During the `install.sh` process, `unzip` is used to extract the zip archive.++**How can this issue be fixed?**++You can install unzip via `brew install unzip` on MacOS or `apt-get install unzip -y` on Linux.++### Running scripts is disabled

@bartlomieju This is no longer a known issue:

### Running scripts is disabled
...

Thanks to https://github.com/denoland/deno_install/pull/133, it is fixed.

#133 removed the temporary file for installing a specific version using the PS installer. Running a temp file could lead to the following issue: File C:\install.ps1 cannot be loaded because running scripts is disabled on this system.

No temp file -> no "running scripts is disabled" anymore. :)

hardy613

comment created time in 2 days

issue closeddenoland/deno_install

Removing temporary file from PowerShell install command

Currently the command looks like this:

iwr https://deno.land/x/install/install.ps1 -useb -outf install.ps1; .\install.ps1 v1.0.0

We save the installer as a temporary file because we have no way of passing the version into the installer while piping, in contrast to the Shell version:

curl -fsSL https://deno.land/x/install/install.sh | sh -s v1.0.0

I propose to add a variable v. If the variable is set, the install.ps1 script will assume it's the Deno version that the user wants to install. If not, the script will work just as it works now.

So this method is similar to the "install latest" command:

iwr https://deno.land/x/install/install.ps1 -useb | iex

Only difference is the added variable assigment beforehand:

$v="v1.0.0"; iwr https://deno.land/x/install/install.ps1 -useb | iex

Example that demonstrates that the variable will be available to the invoked script:

> type v.ps1
write-host v=$v
> $v="v1.0.0"; type v.ps1 | iex
v=v1.0.0

I see two advantages:

  1. The command is shorter.
  2. We don't create a temporary file.

cc @ry

closed time in 2 days

MarkTiedemann

issue commentdenoland/deno_install

Removing temporary file from PowerShell install command

Closed with https://github.com/denoland/deno_install/pull/133.

MarkTiedemann

comment created time in 2 days

issue commentdenoland/deno_install

Removing temporary file from PowerShell install command

@bartlomieju Since https://github.com/denoland/deno_install/pull/133 has been merged, this can be closed.

MarkTiedemann

comment created time in 2 days

pull request commentdenoland/deno_install

[issue-117] Unzip

@bartlomieju This PR currently re-adds the "Running scripts is disabled" known issue, which I think may be a merging error.

I also think that the following check is not necessary since the script was, most likely, already downloaded using curl:

if ! command -v curl >/dev/null; then
	echo "Error: curl is required to install Deno." 1>&2
	exit 1
fi

But I think, if those two issues are fixed, it should be merged, yes.

hardy613

comment created time in 2 days

pull request commentdenoland/deno_install

Added install instructions for Arch Linux

@Yamboy1 Since this PR is already merged, can you maybe create a follow-up PR?

naueramant

comment created time in 2 days

Pull request review commentdenoland/deno_install

Remove temp file from PS install command; Remove PS linting

 curl -fsSL https://deno.land/x/install/install.sh | sh -s v0.38.0 **With PowerShell:**  ```powershell-iwr https://deno.land/x/install/install.ps1 -useb -outf install.ps1; .\install.ps1 v0.38.0+$v="v0.38.0"; iwr https://deno.land/x/install/install.ps1 -useb | iex

Yeah, I was thinking about that, too. However, there are multiple places where 0.38.0 is used, both in the tests and the readme. I think this should be a follow-up PR.

MarkTiedemann

comment created time in 2 days

issue commentdenoland/deno_install

Add installer written in deno

@bartlomieju Wanna close this one? It's solved by deno --upgrade.

ry

comment created time in 2 days

issue commentdenoland/deno_install

colors.ts 404 not found

Not really a deno_install issue any way.

@bartlomieju Wanna move or close?

Fer17

comment created time in 2 days

issue commentdenoland/deno_install

support chocolatey

@bartlomieju This issue can be closed.

ry

comment created time in 2 days

issue commentdenoland/deno_install

Improve install script for WSL

Would be fixed by https://github.com/denoland/deno_install/pull/122.

brandonkal

comment created time in 2 days

pull request commentdenoland/deno_install

Added install instructions for Arch Linux

This PR closes https://github.com/denoland/deno_install/issues/131.

naueramant

comment created time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command; Remove PS linting

@bartlomieju This is ready to be merged now.

Scope has changed a bit - not just removing the temp file and the "Known Issues" section, but also removing the PS linter.

(I think PSScriptAnalyzer may be re-integrated later - similar to how shellcheck was disabled for a while, then re-integrated. In any case, it should be integrated with a fixed version...)

MarkTiedemann

comment created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 1c161dd4faeee0e5207a05cc5092920db1dafb9c

Misc cleanup

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha ed0cf190b3af3612a8357e1457e4725431f89630

Remove exit debugging commands

view details

push time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command (Closes #114)

Well, I figured it out.

PSScriptAnalyzer, the linter, sets the exit code to the number of lint warnings + errors. There were 0 errors, and 1/3/4 warnings.

Not sure why this doesn't properly show up in $LASTEXITCODE.

Not sure why the -ExcludeRule did not work.

I'm considering to drop PSScriptAnalyzer (which I initially added to this repo) - it's showing 2 false positives for 2 short files at the moment anyways...

MarkTiedemann

comment created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 626b0cfb2113c0bd4e90b7ca1e7d081ad81fd030

Remove linting

view details

push time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command (Closes #114)

Now it's exit code 1. Then exit code 3.

DEBUG:   39+  >>>> Write-Host $LASTEXITCODE
0
DEBUG:   40+  >>>> $LASTEXITCODE = 0
DEBUG:   41+  >>>> Write-Host $LASTEXITCODE
0
DEBUG:   42+  >>>> exit $LASTEXITCODE
DEBUG:    3+ if ( >>>> (Test-Path -LiteralPath variable:\LASTEXITCODE)) { exit $LASTEXITCODE }
DEBUG:    3+ if ((Test-Path -LiteralPath variable:\LASTEXITCODE)) {  >>>> exit $LASTEXITCODE }


##[error]Process completed with exit code 3.

None of this makes any sense.

MarkTiedemann

comment created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 8262b664b7a6cfd56c0d4500341c7912bda6f4f0

Going crazy...

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha efdf3dd70977101ed8afe7bcfaa0c84fe734b72f

Debug some more

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 7ff421f030637c8039c9be76a76ef454de625e97

Exit 0 explicitly

view details

push time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command (Closes #114)

After a bit of CI debugging, this seems like another GitHub Actions bug...

https://github.com/denoland/deno_install/pull/133/checks?check_run_id=718693105

DEBUG:   38+  >>>> Write-Host $LASTEXITCODE
0
DEBUG:    3+ if ( >>>> (Test-Path -LiteralPath variable:\LASTEXITCODE)) { exit $LASTEXITCODE }
DEBUG:    3+ if ((Test-Path -LiteralPath variable:\LASTEXITCODE)) {  >>>> exit $LASTEXITCODE }
##[error]Process completed with exit code 4.

$LASTEXITCODE is defined and has a value of 0, as can be seen by the output of the Write-Host $LASTEXITCODE command.

Running Test-Path -LiteralPath variable:\LASTEXITCODE, however, which should return True if the variable $LASTEXITCODE is defined and False if it is undefined, does error out and produces a $LASTEXITCODE of 4 which means "Cannot Access File".

So I think there may be a GitHub Actions issue here where variable:\LASTEXITCODE is checking for the file LASTEXITCODE on the drive variable rather than the existence of the variable $LASTEXITCODE... Or something along those lines.

Not sure why this issue is showing up now, only in this PR, though. This is weird.

MarkTiedemann

comment created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 1f6dce76a1a978a06db8378ae4463450eb8ab396

More CI debugging

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 2721f1994562e450491f73493a4d713566f2511a

Trace CI

view details

push time in 2 days

pull request commentdenoland/deno_install

Added install instructions for Arch Linux

@naueramant @Yamboy1 What about "from source" & "pre-compiled"? Would you still like to add the pre-compiled deno-bin?

+ # From source
yay -S deno
+ # Pre-compiled
+ yay -S deno-bin
naueramant

comment created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha cdd686a579a135560f00d4f4e3d871c0ec8d609c

Re-enable sh lint (#121)

view details

Manu

commit sha e225f8e411f95a7bed1851e595b9f022e535d2af

Update #install_specific_version of README to version 1.0.0 (#119)

view details

Mark Tiedemann

commit sha f9cabf122174340d878546f5a87d2a4d81021b8c

Test both pwsh and powershell (#120)

view details

Jonas Tranberg

commit sha bf88be1faf0a824dd588018f27c60396c4a5da2b

Added install instructions for Arch Linux (#128)

view details

Mark Tiedemann

commit sha 5d62b56e5a5cf99d87cd71e4a41521a8ec356c92

Fix PowerShell usage in CI (#134)

view details

Mark Tiedemann

commit sha aad8b2a35fc544c87b4fc243e8e8f6e7280ee16d

Merge branch 'master' into fix-114

view details

push time in 2 days

issue commentdenoland/deno

jsdom Port for 1.0 (Feature Request)

where will documentation live for https://dev.jspm.io/jsdom

Maybe https://deno.land/x/jsdom?

Don't think this needs to be in std.

David-Else

comment created time in 2 days

PR opened denoland/deno_install

Fix PowerShell usage in CI

As can be seen in the CI log, PowerShell Core was used twice instead of PowerShell and PowerShell Core.

https://github.com/denoland/deno_install/runs/718526050

tests powershell:
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"

 tests powershell core:
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"

This is despite teh GitHub Actions documentation saying that "[PowerShell is the] default shell used on Windows. The Desktop PowerShell. GitHub appends the extension .ps1 to your script name."

https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions

This PR attempts to fix this issue by explicitly specifying shell: powershell.

+1 -0

0 comment

1 changed file

pr created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha de9dbd2dcf3c904e381bebd42bf00987fbdaf55d

Fix PowerShell usage in CI

view details

push time in 2 days

create barnchMarkTiedemann/deno_install

branch : fix-powershell-usage-in-ci

created branch time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 88bb1e57a8e777216c4b6840d325e40ab3136d17

Misc cleanup

view details

Mark Tiedemann

commit sha 79c0e202d04f6b90fe7e68a2eac8a494e5103376

Clean-up install_test.ps1

view details

Bartek Iwańczuk

commit sha 2a6d256e2ca4d00bef3260a9371b91847ee21cdf

Cleanup Windows installation scripts

view details

Mark Tiedemann

commit sha cdd686a579a135560f00d4f4e3d871c0ec8d609c

Re-enable sh lint (#121)

view details

Manu

commit sha e225f8e411f95a7bed1851e595b9f022e535d2af

Update #install_specific_version of README to version 1.0.0 (#119)

view details

Mark Tiedemann

commit sha f9cabf122174340d878546f5a87d2a4d81021b8c

Test both pwsh and powershell (#120)

view details

Jonas Tranberg

commit sha bf88be1faf0a824dd588018f27c60396c4a5da2b

Added install instructions for Arch Linux (#128)

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 88bb1e57a8e777216c4b6840d325e40ab3136d17

Misc cleanup

view details

Mark Tiedemann

commit sha 79c0e202d04f6b90fe7e68a2eac8a494e5103376

Clean-up install_test.ps1

view details

Bartek Iwańczuk

commit sha 2a6d256e2ca4d00bef3260a9371b91847ee21cdf

Cleanup Windows installation scripts

view details

Mark Tiedemann

commit sha cdd686a579a135560f00d4f4e3d871c0ec8d609c

Re-enable sh lint (#121)

view details

Mark Tiedemann

commit sha 543a344d10bb10f3a75f1055ec4a6647e733c8b1

Merge branch 'master' of https://github.com/denoland/deno_install into test-powershell

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 88bb1e57a8e777216c4b6840d325e40ab3136d17

Misc cleanup

view details

Mark Tiedemann

commit sha 79c0e202d04f6b90fe7e68a2eac8a494e5103376

Clean-up install_test.ps1

view details

Bartek Iwańczuk

commit sha 2a6d256e2ca4d00bef3260a9371b91847ee21cdf

Cleanup Windows installation scripts

view details

Mark Tiedemann

commit sha f2d47cd0f5f91d41c19ec04ffa65ba86f143bcca

Merge branch 'master' of https://github.com/denoland/deno_install into fix-114

view details

push time in 2 days

issue commentdenoland/deno

jsdom Port for 1.0 (Feature Request)

Is it okay for the Deno ecosystem to rely that much on the JS one?

Yes. Deno is a JS runtime. It would be sad if it was not compatible with the existing JS ecosystem.

David-Else

comment created time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command (Closes #114)

Linting fails because the cleanup from https://github.com/denoland/deno_install/pull/118/ is not merged yet.

MarkTiedemann

comment created time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha e6fd9cffb275f562953c223256aee011fed9ed32

Fix lint again...

view details

push time in 2 days

push eventMarkTiedemann/deno_install

Mark Tiedemann

commit sha 0c5e9fe56c610678d5d43ae4ee6640a5f366934f

Fix linting

view details

push time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command (Closes #114)

Since this PR removes the "Known Issues" section, it makes the following PR obsolete: https://github.com/denoland/deno_install/pull/105

MarkTiedemann

comment created time in 2 days

pull request commentdenoland/deno_install

Remove temp file from PS install command (Closes #114)

To test that this is working end-to-end, you can run: $v="v1.0.0"; iwr https://raw.githubusercontent.com/MarkTiedemann/deno_install/fix-114/install.ps1 -useb | iex.

MarkTiedemann

comment created time in 2 days

create barnchMarkTiedemann/deno_install

branch : fix-114

created branch time in 2 days

push eventMarkTiedemann/fastlist

Mark Tiedemann

commit sha 56f45ce04057b843a4499f534e27b2d21949365b

Misc changes

view details

push time in 2 days

issue commentdenoland/deno

jsdom Port for 1.0 (Feature Request)

I'm not sure this is needed anymore. The basic jsdom functionality of DOM parsing works for me out of the box now:

import * as jsdom from "https://dev.jspm.io/jsdom";
console.log(
    new jsdom.default.JSDOM("<h1>Hello, World!<h1>", { url: "https://localhost" })
    .window.document.querySelector("h1").textContent
);
David-Else

comment created time in 2 days

issue commentdenoland/deno

await (async () => {})() :: Cannot find name 'await'.ts(2304)

@kitsonk You mentioned this issue before in https://github.com/denoland/deno/issues/471, which is a general issue about top-level await. Might be good to keep this one open just for this specific issue.

teknsl

comment created time in 2 days

issue commentdenoland/deno_install

Make sure deno can be added as a node version in nvm

It is neither a fork of Node, nor is it sold as one. Don't know where you got that info. Please check the official website, https://deno.land, to see how Deno is actually "sold".

Deno is sold as a secure runtime. In comparison to Node, it certainly has a different, more secure architecture. But again, that does not mean it's sold as Node fork. On the contrary, it is a completely different project so it would not make any sense to sell it as a fork of Node.

Again, Deno not being integrated into the Node Version Manager - which, by the way, is a completely separate community project, not an official Node project - should be a deal breaker here. There's plenty of ways to install Deno and manage multiple versions of it. If those don't fit you, please let us know how we can improve the installation process / version management for you.

Then again, if you want Deno to be integrated into nvm, I suggest you open an issue at the nvm repo: https://github.com/nvm-sh/nvm

ruurd

comment created time in 3 days

issue commentdenoland/deno_install

Make sure deno can be added as a node version in nvm

Node and Deno are different projects. I don't think you ever will be able to install Deno using nvm. And if you'd like Deno to be integrated in nvm, I suggest you open an issue at the nvm repo.

If you want an nvm replacement for Deno, there's dvm: https://github.com/axetroy/dvm

ruurd

comment created time in 3 days

issue commentdenoland/deno

Environment Variable in Deno undefined

Note that in my example, I did not need to specify --allow-env, because I was using deno eval. Usually, you are gonna run a script using deno run, in which case you do need to specify --allow-env to access environment variables. Here's an example:

$ # Print the content of the script
$ cat example.js
console.log(Deno.env.get('PORT'))

$ # Set the environment variable
$ export PORT=1234

$ # Run the script
$ deno run --allow-env example.js
1234
rwieruch

comment created time in 3 days

issue commentdenoland/deno

Environment Variable in Deno undefined

This works on my machine:

$ PORT=8000 deno eval "console.log(Deno.env.get('PORT'))"
8000

Do you expect Deno to read .env files by default?

--allow-env allows accessing environment variables via Deno.env.

rwieruch

comment created time in 4 days

issue commentdenoland/deno_install

Add manual installation instructions

I still feel this is not needed.

I think the two linked issues above show that this may be helpful for beginners. Most Windows users have extracted a zip-file and double-clicked an exe. Running Powershell commands, I feel like, is not a very common thing.

AUR packages are more typical in an arch / manjaro system than using shell script installers

There are also multiple package managers for Windows, for example, Scoop, Chocolatey and NuGet, and we already support both Scoop and Choco.

I don't see any reason why we shouldn't have an exe installer.

Me neither. In fact, I have started working on a private C++ project I call "deno-up". Manual install instructions and a setup.exe are not mutually exclusive.

MarkTiedemann

comment created time in 4 days

issue commentdenoland/deno

deno-upgrade: unzipping issue when upgrading to v1.0.1 on Windows/PowerShell

Just installed Powershell Core 7.0.1 using scoop. Expand-Archive works for me.

Maybe you are affected by this issue? https://github.com/PowerShell/Microsoft.PowerShell.Archive/issues/59

In any case, I think this not a Deno issue, but an upstream Powershell Core issue.

LayZeeDK

comment created time in 4 days

issue commentdenoland/deno_install

Add arch / manjaro install instructions

There's a related PR: https://github.com/denoland/deno_install/pull/128

Yamboy1

comment created time in 4 days

issue commentdenoland/deno_install

Add manual installation instructions

@divy-work How is downloading the .zip lazy? That's manual work, whereas if you use the installer, it does the work for you automatically. So I think it's the other way around; the installer script is the "lazy" way to install Deno.

I think a lot of people are not familiar with PowerShell... I think "download a zip, extract the zip, double-click the exe" maybe more familiar.

MarkTiedemann

comment created time in 5 days

issue openeddenoland/deno_install

Add manual installation instructions

As witnessed in https://github.com/denoland/deno/issues/5727 and https://github.com/denoland/deno_install/issues/129, people may not expect Deno to just be an .exe in a .zip.

I think adding manual installation instructions might help.

To reduce installation complexity, it might also help to provide both a .zip and an .exe for download. (cc @ry - Is this something you'd consider?)

On a related note, if you download the .exe and double-click it on Windows, you'll get a warning that "Windows protected your PC", you have to click "More info", and then "Run anyway" to finally enter the REPL. Fixing this, I think, is something that would help make running Deno for the first time more beginner friendly.

created time in 5 days

issue commentdenoland/deno_install

Can't install deno with powershell behind corporate proxy

As a work-around, you can download https://deno.land/x/install/install.ps1, edit the file and set -Proxy (-ProxyCredential / -ProxyUseDefaultCredentials) for all other Invoke-WebRequest invocations, then run .\install.ps1.

Note that you can also manually download Deno. No "installation" is necessary. A release will ship a zip-file: https://github.com/denoland/deno/releases/download/v1.0.2/deno-x86_64-pc-windows-msvc.zip If you download and extract the zip-file, you will find deno.exe in there. (The install.ps1-script does the same: It determines the latest Deno version, then downloads and extracts the zip-file. It also adds Deno to your path - but you could do that manually, too.)

Niyarlatotep

comment created time in 5 days

push eventMarkTiedemann/marktiedemann.github.io

Mark Tiedemann

commit sha 2da644159311ecb099abef1f8b3e3bc6de1f99bc

Misc changes

view details

push time in 5 days

push eventMarkTiedemann/marktiedemann.github.io

Mark Tiedemann

commit sha 3afab4540a2a2f0804709aec6e9bc188d9944d06

Remove unused CSS

view details

push time in 5 days

push eventMarkTiedemann/marktiedemann.github.io

Mark Tiedemann

commit sha 32a40bafae4346920f91efa3ad8314ad64f2e0c3

Update content

view details

push time in 5 days

pull request commentsindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

I don't get this, are you saying you would construct the JSON by hand?

Yeah. I don't think there is a native Windows API for serializing JSON, and I'm kind of hesitant to put a dependency into a nice, clean, minimal 30 line project...

I also think that the pid, ppid and executable name probably don't have to be escaped. So it would be easy to do by hand.

There is also a considerable difference in size for outputting JSON objects (as they are returned by this module) compared to the current structure:

13540   10524   node.exe  // <-- 21 chars
{"pid":13540,"ppid":10524:"name":"node.exe"},  // <-- 45 chars

I don't really see how parsing JSON is simpler than splitting on \n and \t.

MarkTiedemann

comment created time in 5 days

issue commentdenoland/deno

deno-upgrade: unzipping issue when upgrading to v1.0.1 on Windows/PowerShell

PowerShell version: 7.0.1

@LayZeeDK You are running the new cross-platform PowerShell Core (pwsh.exe) rather than the old powershell.exe.

Can you print the output of $PSVersionTable for confirmation?

We used to test PowerShell Core in the installer, but don't do it anymore since it's not used much.

What happens if you run the command suggested in the error messages as a possible fix?

Import-Module Microsoft.PowerShell.Archiv

In any case, I think we should re-consider supporting PowerShell Core.

LayZeeDK

comment created time in 5 days

issue commentdenoland/deno

Please make deno simple(installation) as you download an app( like exe file)

I don't see why they don't make a .exe file as they did for node.js.

I think there's a misunderstanding here.

As it says on the frontpage of the website: "Ships only a single executable file."

A Deno release for Windows is shipped in a .zip file. For example, the version 1.0.2 release (https://github.com/denoland/deno/releases/tag/v1.0.2) lists the following .zip file that can be downloaded on Windows: https://github.com/denoland/deno/releases/download/v1.0.2/deno-x86_64-pc-windows-msvc.zip

If you download the .zip, you can right click it, and choose "Extract All...". Open the extracted folder, and you will find deno.exe. You can double-click deno.exe and you'll be in the Deno read-eval-print-loop, and can start typing and executing JS.

All that the installer command does for you is download the .zip (as you can do manually), extract the .zip (as you can do manually), and put the location of the .zip into your path so you can run deno.exe or just deno from the command line, rather than having to type the full path, e.g. C:\some-path\deno.exe (as you can do manually, too).

So the installer is just for convenience. So you don't have to do those 3 things yourself, but rather the installer will do it for you.

Then again, "installer" is kind of the wrong term on Windows at least. There's no setup.exe or setup.msi or anything like that needed here. It's just an .exe file in a .zip file.

fisforfaheem

comment created time in 5 days

startedminimaxir/big-list-of-naughty-strings

started time in 6 days

issue commentdenoland/deno

Could not install deno with curl (SSL Certificate problem)

@anuraghazra For installing Deno on Windows, please use the PowerShell installer. The Shell installer only installs binaries for MacOS or Linux.

anuraghazra

comment created time in 6 days

Pull request review commentsindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

 const execFile = util.promisify(childProcess.execFile);  const windows = async () => { 	// Source: https://github.com/MarkTiedemann/fastlist-	const bin = path.join(__dirname, 'fastlist.exe');+	let bin;+	switch (process.arch) {+		case 'x64':+			bin = 'fastlist-0.2.1-x64.exe';

Confirmed that this would work using npm publish --dry-run.

MarkTiedemann

comment created time in 6 days

push eventMarkTiedemann/ps-list

Mark Tiedemann

commit sha b936aad67e308187343e774ab8ae112940493c1e

Move fastlist into vendor dir

view details

push time in 6 days

issue closeddenoland/deno

deno watch for web development

Would love to have a better web development experience with Deno out of the box.

  • First, the server should restart whenever I make changes.
  • Second, the website should reload whenever I make changes.

For the server, I'd like to propose a deno watch subcommand or deno run --watch flag that automatically restarts the server in a controlled way, e.g.

deno watch *.ts --run main.ts --allow-net
# or
deno run --watch *.ts --allow-net main.ts

If we also had a Deno.watch API for watching directories or files, we could then implement a simple client refresh via server-sent events (example) or web sockets.

EDIT: It would be nice if the watch subcommand/flag would be able to notify the running code that it will/should be restarted - maybe something via signals (e.g. SIGUSR1), command line flags, some API, or a similar mechanism - so that the server could notify the client that it will be restarted and that the client needs to be reloaded.

closed time in 6 days

MarkTiedemann

issue commentdenoland/deno

deno watch for web development

First of all, I think Deno is fast enough that you don't really need a watcher. Just Ctrl+C, Up, Enter is probably fine for 90% of use cases. It has been working quite fine for me working with Deno on a daily basis for the past one and a half years. You should try it. :)

Then there's two arguments I made when originally opening this issue:

  1. The server should restart whenever I make changes.
  2. The website should reload whenever I make changes.

2, I think, is out of scope anyways. Deno should not have live-reload integration or some hacky server-sent events that trigger in-browser refresh, as I originally proposed. In retrospect, I think that is a dumb idea. If you really need something like that, write it yourself, put it on GitHub - but I don't think this should ever be in core.

1, I think, is doable and could potentially be in core some day. But then again, I don't think deno run --watch app.ts is any better than denon run app.ts, or using the usual general purpose filewatching tools that have long solved this problem (https://github.com/emcrisostomo/fswatch, https://github.com/facebook/watchman, etc.)

If someone wants to open another issue for this, feel free. This one I'd like to keep closed.

MarkTiedemann

comment created time in 6 days

Pull request review commentsindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

 const execFile = util.promisify(childProcess.execFile);  const windows = async () => { 	// Source: https://github.com/MarkTiedemann/fastlist-	const bin = path.join(__dirname, 'fastlist.exe');+	let bin;+	switch (process.arch) {+		case 'x64':+			bin = 'fastlist-0.2.1-x64.exe';

Is the vendor directory uploaded/published automatically? If so, I'd gladly move them there.

MarkTiedemann

comment created time in 6 days

pull request commentsindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

Why make it fragile when you can use something safe like JSON.

Well, the executable name cannot contain \t or \n (see Windows File Naming Conventions) so this is perfectly safe. On the other hand, I'm not sure about safely escaping the output for JSON... It might be safe to not escape the output, it might be more tricky than expected - I don't know.

Performance is not a concern as the spawning part is much slower than any kind of parsing.

Which is why I still consider writing and distributing a pre-built native addon using N-API. (I've started work on that 2 years ago, but never actually finished it.)

I still think some basic benchmarks regarding executing / spawning / parsing might be a good idea. I may add some later on.

On another note, fastlist >0.1.0 does not support unsupported Windows versions anymore: https://github.com/MarkTiedemann/fastlist#compatibility Not sure whether this is a concern here.

On yet another note, I consider adding a fallback to wmic process get name,parentprocessid,processid or tasklist (without /fo csv /nh since CSV output seems much slower than the default text output...) as a fallback for issues, such as, this https://github.com/sindresorhus/ps-list/issues/23.

MarkTiedemann

comment created time in 6 days

push eventMarkTiedemann/fastlist

Mark Tiedemann

commit sha 0c0fad5f01072aecd7f7894673c683e8d1235f4f

Add Compatibility section to readme

view details

push time in 7 days

pull request commentsindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

Since we control the binary, have you considered adding a --json flag? That way we wouldn't have to manually parse the output.

Is your concern here about the maintainability of the parsing code? Or is this about performance?

In any case, I'd be happy to build a fastlist flavor with JSON output (as in, use preprocessor directives and build a second binary that you can download) rather than add runtime flag parsing and conditional output to the existing solution. Though, I don't think JSON parsing is faster than newline-/tab-parsing.

On a related note, I think we're currently reading the entire fastlist output into a string, which is then parsed line by line. I'd be surprised if operating on a raw buffer here, only converting the executable names to strings, would be slower, especially if we spawn rather than exec. I think there's some benchmarks needed here for "What's the fastest way to asynchronously parse fastlist output into a JS structure?". Again, I'd be happy to work on creating such benchmarks and testing different solutions.

Is UPX really worth it in this case? From what I can remember, UPX slows down the binary launch performance, which is more important than size for our use-case.

From my testing done yesterday (I run the benchmark with 100 executions per run about 5 times on two different Windows laptops), UPX actually increased the performance by about 30%. This is part of the reason why I updated the description from "Like tasklist, but 5x faster." to "10x" faster. :)

MarkTiedemann

comment created time in 7 days

Pull request review commentsindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

 const execFile = util.promisify(childProcess.execFile);  const windows = async () => { 	// Source: https://github.com/MarkTiedemann/fastlist-	const bin = path.join(__dirname, 'fastlist.exe');+	let bin;+	switch (process.arch) {+		case 'x64':+			bin = 'fastlist-0.2.1-x64.exe';

I'm not sure that's a good idea. If we mention the version in a comment or a plain version file, we'd have to update those as well, which is, of course, something that could be forgotten as well... Now, we have to update the switch statement inindex.js and the files array in the package.json. I kind of prefer updating these two locations since it's very explicit and fails fast: If any of them is not updated, the module won't work anymore, which I think is a good thing in this case.

That being said, I'd be fine with dropping the version number from the binary names, too. Let me know. :)

MarkTiedemann

comment created time in 7 days

push eventMarkTiedemann/ps-list

Mark Tiedemann

commit sha af954e8f7fc16886cf49a6b8a424f7c7c8b78e21

Update index.js Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

view details

push time in 7 days

push eventMarkTiedemann/fastlist

Mark Tiedemann

commit sha d5ff967bdef4a873460254f4297c11c802ab6268

Update readme

view details

push time in 7 days

PR opened sindresorhus/ps-list

Update fastlist v0.1.0 to v0.2.1

Hi @sindresorhus, long time no see. :)

I just released a new version of fastlist:

  • v0.1.0 was 44 KB in size; v0.2.1 is 9.5 KB (x64) + 9 KB (x86) = 18.5 KB; so despite fastlist shipping binaries for two architectures now, it's 2x smaller
  • proper Unicode support with UTF-8 code pages (an exe like nødэ.exe will now be printed correctly)
  • v0.2.1 is 2x faster than v0.1.0 (probably because I upgraded from MS VS 2010 to 2019...)
+22 -6

0 comment

6 changed files

pr created time in 7 days

push eventMarkTiedemann/ps-list

Mark Tiedemann

commit sha 7daf820505bf3670fc1bfb64f2473b76f34566d2

Update fastlist v0.1.0 to v0.2.1

view details

push time in 7 days

more