profile
viewpoint

MarcoPolo-PasTonMolo/dino 0

Modern XMPP ("Jabber") Chat Client using GTK+/Vala

MarcoPolo-PasTonMolo/profanity 0

Ncurses based XMPP client

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha da3a6d87437ce14215acbb5f1740cb81066df39d

Move declaration and definition of win_get_last_sent_message to the correct place

view details

push time in a month

PullRequestReviewEvent

Pull request review commentprofanity-im/profanity

Add /correct-editor command

 void cmd_ac_add_form_fields(DataForm* form); void cmd_ac_remove_form_fields(DataForm* form);  char* cmd_ac_complete_filepath(const char* const input, char* const startstr, gboolean previous);+char* _get_last_message(ProfWin* window);

I'm using this function in the cmd_correct_editor function so I need to export it. Should I just remove the _?

MarcoPolo-PasTonMolo

comment created time in a month

pull request commentprofanity-im/profanity

Add /correct-editor command

@MarcoPolo-PasTonMolo nice! I'll take a closer look later. Two things: Can you resolve/comment the conversation/review here on this PR that don't apply anymore? So we can later know what we did. And can you do a git commit --amend git push -f and add a little bit of info to the body of the last commit message? So that we later understand why you remove the autocomplete :)

I'm a very forgetful person and just some text why we do things later on helps me and new contributors too :)

Done

MarcoPolo-PasTonMolo

comment created time in a month

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha 6b0f15a1c90116a01463a8c9e26c32f4112810e7

Remove autocomplete for /correct-editor We decided that it was better to remove autocomplete for this command, since adding it only introduced problems and the command can still function perfectly without autocomplete.

view details

push time in a month

Pull request review commentprofanity-im/profanity

Add /correct-editor command

 cmd_change_password(ProfWin* window, const char* const command, gchar** args)     return TRUE; } +// Returns true if any error occured

It actually returns true if an error occured

MarcoPolo-PasTonMolo

comment created time in a month

PullRequestReviewEvent

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha 03a0d0c001865ec140f5a321d77850bedcfade37

Remove autocomplete for /correct-editor

view details

push time in a month

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha cd16264d2bfb8ffb7afd9bd42a39e06c019f5915

Export common code to helper functions

view details

push time in a month

pull request commentprofanity-im/profanity

Add /correct-editor command

@jubalh I'm sorry, I suddenly got very busy I don't know when I'll come back to this

MarcoPolo-PasTonMolo

comment created time in 2 months

pull request commentprofanity-im/profanity

Add /correct-editor command

Great! Quick superficial review: I would suggest to compare cmd_editor cmd_correct and your new cmd_correct_editor. You should add helper functions (starting with _, see other helper functions in that file) so that you don't add lots of duplicate code but rather call the corresponding functions. Do you know what I mean?

Yes, I'll update the pull request when I'm done.

BTW this time you started working on master, this could lead to problems in case upstream master changes. I would advise to always work on a branch (like you did last time when you fixed the timezone issue), like feature/issuenr-somename. But no problem for now :) If you need any help or more details feel free to ask here or contact me.

Oops I thought I was working on another branch seems like I missed that.

MarcoPolo-PasTonMolo

comment created time in 2 months

PR opened profanity-im/profanity

Add /correct-editor command

Fixes: #1596

+153 -1

0 comment

4 changed files

pr created time in 2 months

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha 09f5cadf1a2052f07f31611dc4ba986b3db0ec27

Add /correct-editor command

view details

push time in 2 months

push eventMarcoPolo-PasTonMolo/profanity

Michael Vetter

commit sha 16df5d825537c0f624f2b8528b5f72179d3feb55

Add makefile target for spell checking and all tests

view details

Michael Vetter

commit sha ce5bf721cad03ce660b1c365e0d96d58c90dcf51

Mention make spell and doublecheck in contributing.md

view details

MarcoPolo-PasTonMolo

commit sha 97551aa1318fd294c38ceb4339c23a7f2a590915

Fix history timestamp Fixes https://github.com/profanity-im/profanity/issues/1423 Oldest stanza is fetched like before but now the timestamp is generated by creating date_time_from_iso8601 and then to_local, instead of trusting that the timestamp is in utc. The procedure previously was stamp = time_val_from_iso8601() then date_time = date_time_from_utc(stamp) then local_date_time = to_local(date_time)

view details

Michael Vetter

commit sha 7e8cf4a3d680ef5b8f056021846818fb526635d9

Merge pull request #1600 from MarcoPolo-PasTonMolo/fix/history-timestamp Fix history timestamp

view details

Michael Vetter

commit sha f21595597f4fa872b77d7f76ae04916f4aae732e

Format code correctly

view details

push time in 2 months

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha 50b760f2f4cf6d7efc9bb48c33e943ec33ebfee7

Revert "Rename oldest to newest" This reverts commit 858f3a9b079b1ca9df5729228811b19294850522.

view details

MarcoPolo-PasTonMolo

commit sha df097c72c7b5998677376e662f18b169675a138d

Revert "Fix wrong timestamp in history" This reverts commit 7e998865dcc3cc3a5d78d5d013655471bad91b8d.

view details

MarcoPolo-PasTonMolo

commit sha 9a68d845e756db10e54d9df204f17696fe9be434

Fix history timestamp

view details

push time in 2 months

issue commentprofanity-im/profanity

Messages from MUC history show wrong time stamp

Ok never mind just found out the real issue, I'll have the pull request updated in a bit

mdosch

comment created time in 2 months

issue commentprofanity-im/profanity

Messages from MUC history show wrong time stamp

I am not entirely sure myself either. What I noticed is that when I used the xep0091 delay in some chats the timestamp would be wrong and that the code for getting both delays was identical with the exception that we are getting information from different attributes/elements(I don't know the correct name). The procedure to get both delay was to get time_value_from_iso8601 then get date_time_new_from_timeval_utc and then date_time_to_local

mdosch

comment created time in 2 months

PR opened profanity-im/profanity

Fix/history timestamp

The fix was to get the newest stanza delay instead of the oldest. This might reintroduce #1254

+16 -16

0 comment

3 changed files

pr created time in 2 months

push eventMarcoPolo-PasTonMolo/profanity

MarcoPolo-PasTonMolo

commit sha 858f3a9b079b1ca9df5729228811b19294850522

Rename oldest to newest

view details

push time in 2 months

issue commentprofanity-im/profanity

Messages from MUC history show wrong time stamp

I found that I can fix this by instead of picking the oldest delay in stanza_get_oldest_delay, to pick the newest one. The delay from xep0091 seems to be wrong sometimes. This however might reintroduce #1254.

mdosch

comment created time in 2 months

create barnchMarcoPolo-PasTonMolo/profanity

branch : fix/history-timestamp

created branch time in 2 months

issue commentprofanity-im/profanity

Messages from MUC history show wrong time stamp

I want to try to solve this, where should I look?

mdosch

comment created time in 2 months

issue openedprofanity-im/profanity

Feature request: /quote command with autocomplete

Have a /quote command with autocomplete that allows you to quote a message and respond to it. Copy and pasting isn't that ergonomic especially if the message wraps and you end up copying names of occupants.

This command should probably open the editor because you would probably enter a newline after the quoted text to reply

created time in 2 months

issue openedajbura/cinny

Search for text

Is your feature request related to a problem? Please describe.

Searching for text in a room, all rooms, or all rooms in a space.

Describe the solution you'd like

A search bar in the upper right corner where you can search for text. Preferrably with the abilty to search by user as well with a "from: @abc:user.com" Pretty much whan discord already has

created time in 3 months

issue commentiv-org/invidious

[Bug] Invidious starts playing audio instead of video without js on Chromium

Thanks, can confirm that now yewtu.be works

MarcoPolo-PasTonMolo

comment created time in 3 months

more