profile
viewpoint
LeSeulArtichaut France LeSeulArtichaut.github.io Full-time Rust enthusiast. A beautiful artichoke the rest of the time.

LeSeulArtichaut/alloc-cortex-m 0

A heap allocator for Cortex-M processors

LeSeulArtichaut/arm-dcc 0

Debug Communication Channel (DCC) API

LeSeulArtichaut/awesome-embedded-rust 0

Curated list of resources for Embedded and Low-level development in the Rust programming language

LeSeulArtichaut/bare-metal 0

Abstractions common to microcontrollers

LeSeulArtichaut/blog 0

The Rust Embedded WG Blog

LeSeulArtichaut/book 0

The Rust Programming Language

LeSeulArtichaut/book-1 0

Documentation on how to use the Rust Programming Language to develop firmware for bare metal (microcontroller) devices

LeSeulArtichaut/cargo 0

The Rust package manager

LeSeulArtichaut/cargo-binutils 0

Cargo subcommands to invoke the LLVM tools shipped with the Rust toolchain

pull request commentrust-lang/rustc-dev-guide

Recommend setting up `check_line_lengths` as a pre-commit script

@jyn514 did you solve the "does this work on Windows" question?

jyn514

comment created time in 12 hours

push eventrust-lang/rustc-dev-guide

Santiago Pastorino

commit sha 5ee9d96c07b1ca9c9e3f888f7b6f4050bb61aee4

--verbose is useful when not compiling and when compiling (#901)

view details

push time in 12 hours

PR merged rust-lang/rustc-dev-guide

--verbose is useful when not compiling and when compiling

For instance https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir/src/util/pretty.rs#L333

+2 -2

0 comment

1 changed file

spastorino

pr closed time in 12 hours

PullRequestReviewEvent

PR opened rust-lang/rust

Remove outdated line from `publish_toolstate` hook

We no longer add I-nominated to toolstate failure issues since T-compiler changed its meeting preparation workflow.

+0 -2

0 comment

1 changed file

pr created time in a day

create barnchLeSeulArtichaut/rust

branch : toolstate-msg

created branch time in a day

pull request commentrust-lang/rustc-dev-guide

Hir map

I think I have not been able to re-run CI, which is weird. @jyn514 mind trying yourself? :)

spastorino

comment created time in a day

pull request commentrust-lang/rust

Link to "Contributing to Rust" rather than "Getting Started".

r? @spastorino maybe?

follower

comment created time in a day

PullRequestReviewEvent

Pull request review commentrust-lang/rust

Add regression test for issue #76042

+// run-pass

I don't think --target i686-unknown-linux-gnu (or rather only-i686-unknown-linux-gnu) isn't useful here, this test should pass for every target. I'll add compile-flags: -Coverflow-checks=off -Ccodegen-units=1 -Copt-level=0 which I didn't think were needed for the repro. My bad

LeSeulArtichaut

comment created time in a day

PullRequestReviewEvent

pull request commentrust-lang/rust

Add regression test for issue #76042

Oops, sorry, I didn’t even notice. I just used GitHub UI to create the commit and forgot I had write access :)

LeSeulArtichaut

comment created time in 2 days

push eventLeSeulArtichaut/epsilon

LeSeulArtichaut

commit sha 4b1b50f37b6b814943573fe7bf7d0bddc0f77296

*Just* encourage people to learn their multiplication tables

view details

LeSeulArtichaut

commit sha 8146b4fa34661f28e0da8a99f87c58f55dfdf4cc

Who doesn't like children games?

view details

LeSeulArtichaut

commit sha 0ea00c4d06b414acd97df5fb70948bacb243f673

Change `8-2` a *little* bit

view details

push time in 2 days

push eventLeSeulArtichaut/epsilon

Gabriel Ozouf

commit sha 34ebf1e6e0a67df47191a3a4db7c880d3756fe92

[python/kandinsky] Remove additional interrupt Additional checks for interruptions were making the kandinsky module slower. /!\ Some scripts are now very difficult to interrupt Change-Id: I4c18273d8895deaac68084411a52556c8459d52b

view details

Gabriel Ozouf

commit sha 7dcf1662b0912a15354c3b267ec9867ee254f0df

[python/helpers] Change interrupt check delay Keyboard interruption used to be checked once every 20000 calls to micropython_port_vm_hook_loop. However, if costly functions were executed in between calls to this method, the delay for activating interruptions would increase. Now, keyboard interruption is checked after a fixed amount of time has passed. This way, if the process waits a long time between two calls to micropython_port_vm_hook_loop, it is still interrupted in a timely manner. Change-Id: I37ca3bd4a996fa086078f504340dd857526e356a

view details

Gabriel Ozouf

commit sha b7c76957075b5a9dac528314cb117bb8bbf11bb1

[apps/code] Remove interruption check A check for interruption in ConsoleController::printText caused script to immediately stop when launched after an interrupted script. This check was used to break out of infinite print loop, but now becomes redundant with how micropython_port_vm_hook_loop was changed. Change-Id: Ifa8d415e1b2c2406ad67300eb14ce46889af296f

view details

Émilie Feral

commit sha 4c41b1699d56ce6eafc4adfeb0ef699c4149b88b

[docs] Add/remove dependencies in windows SDK

view details

LeSeulArtichaut

commit sha 1f4ebc6cfeed0510c41829d5a8b0958ecb8a1907

Create fools settings

view details

LeSeulArtichaut

commit sha 022103e280115cb0971b6b3c930ec25f4dd5374e

Propagate fools setting in reduction context

view details

LeSeulArtichaut

commit sha af3fc7cb6c4c0f43a91f2a5b5cb1944f8c7a0018

Change `x/0` a *little* bit

view details

LeSeulArtichaut

commit sha bd61fcb91839885a2a3d0bd6efa955d6ad2f5b3f

Change `0^(-x)` a *little* bit

view details

LeSeulArtichaut

commit sha 660c9ce5fa2d04d3d237c92e7d288f6ad136a9a8

Change `1+1` and `2+2` a *little* bit

view details

LeSeulArtichaut

commit sha a9043f84e52482ad102b3b026008b80f6315ac4e

*Just* encourage people to learn their multiplication tables

view details

LeSeulArtichaut

commit sha 4de2d8f1372501a1a5e542105bc27044d60830ce

Who doesn't like children games?

view details

LeSeulArtichaut

commit sha 140fcfdde23a0e957a47712c36b3e40ce85b48e6

Change `8-2` a *little* bit

view details

push time in 2 days

issue commentrust-lang/rust

Could CONTRIBUTING.md be improved?

cc @rust-lang/wg-rustc-dev-guide

mightyiam

comment created time in 3 days

issue commentrust-lang/rust

ICE on `if let Some() = ...` expression in loop with variable shadowing and missing let keyword

Regression in d824b2351449714dc685d90e298c9d630ad6c437

Regressed in #75931

cc @estebank

zdenek-crha

comment created time in 3 days

issue commentrust-lang/rust

[docs] `core::global_allocator` should link to `std::alloc::GlobalAlloc`

Feel free to use the @rustbot claim command to assign the issue to yourself and show you're working on it

yoshuawuyts

comment created time in 4 days

pull request commentrust-lang/team

Add tamuhey to icebreakers and wg-prioritization

@pietroalbini Sorry to bother you again :D

tamuhey

comment created time in 5 days

issue commentrust-lang/rust

Build hang on Linux with nightly and beta toolchains

I couldn't reproduce this issue with my MacOS laptop (x86_64-apple-darwin). I tried compiling with stable (1.46.0), nightly-2020-09-18 and latest nightly (nightly-2020-09-23), resulting in a successful compilation in less than 15 minutes. Unless I missed something, I guess this probably means this is a Linux-only issue? @ehuss Did you also use a Linux machine for your previous bisection?

It would be great if other people could take a look and eventually find an MCVE which would be very helpful to resolve this bug. @rustbot ping cleanup

danieldeankon

comment created time in 5 days

PR opened rust-lang/rust

Add regression test for issue #76042

Originally posted in https://github.com/rust-lang/rust/issues/76042#issuecomment-683272710. r? @pnkfelix

+15 -0

0 comment

1 changed file

pr created time in 5 days

create barnchrust-lang/rust

branch : LeSeulArtichaut-patch-1

created branch time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentrust-lang/rustc-dev-guide

Recommend setting up `check_line_lengths` as a pre-commit script

Maybe we could also suggest setting up the editor to do the formatting?

jyn514

comment created time in 6 days

issue commentrust-lang/rust

incorrect code generation for i686 release build for 1.47 beta and nightly

Letting this issue open to track a beta backport of #77063. Also, it might be good to have add a test in the suite for this issue. @tspiteri Would you have time to file a PR with your reproduction? Otherwise I can do it myself.

tspiteri

comment created time in 6 days

pull request commentrust-lang/rust

Stabilize intra-doc links

This is awesome! Thanks to everyone who worked on this ❤️

Manishearth

comment created time in 6 days

delete branch rust-lang/rustc-dev-guide

delete branch : jyn514-patch-1

delete time in 6 days

pull request commentrust-lang/rust

Gracefully handle mistyping -> as => in function return type

return types are denoted using ->

Would also be cool to emit this upon encountering

fn foo(_arg: i32): i32 {
    ...
}

which is how you'd define the return type in Scala and Kotlin.

Opened #77115 as a separate issue for this

mibac138

comment created time in 6 days

issue openedrust-lang/rust

Better diagnostics for `:` instead of `->` in return type

Follow-up to #77019

Originally posted by @bugaevc in https://github.com/rust-lang/rust/pull/77035#issuecomment-697308477:

Would also be cool to emit this upon encountering

fn foo(_arg: i32): i32 {
    ...
}

which is how you'd define the return type in Scala and Kotlin.

created time in 6 days

issue commentrust-lang/rust

Cargo freezes at Building stage with version 1.46.0

@octave99 Can you provide the code used to reproduce this issue?

octave99

comment created time in 6 days

pull request commentrust-lang/rustc-dev-guide

`ConstEvalResult` is now `EvalToConstValueResult`

Yeah, it was due to 429 Too Many Requests to some sites. Is there any way to ignore 429 and related errors, and if so should we?

I know there's been discussions about this in the past, not sure if we ever took a decision or not. I also know that we removed the rustc-dev-guide from toolstate because of these too

camelid

comment created time in 7 days

push eventrust-lang/rustc-dev-guide

Camelid

commit sha 2a09b06365bdd2785e87d57d53a33ee208a2796f

`ConstEvalResult` is now `EvalToConstValueResult` (#885) Also fixed typo.

view details

push time in 7 days

PR merged rust-lang/rustc-dev-guide

`ConstEvalResult` is now `EvalToConstValueResult`

I believe this was changed in rust-lang/rust#74949, so r? @oli-obk

+2 -2

2 comments

1 changed file

camelid

pr closed time in 7 days

PullRequestReviewEvent

pull request commentrust-lang/rustc-dev-guide

`ConstEvalResult` is now `EvalToConstValueResult`

CI failure seems spurious, I just re-ran the checks

camelid

comment created time in 7 days

delete branch LeSeulArtichaut/team

delete branch : wg-prio

delete time in 8 days

pull request commentrust-lang/team

Add people to the Prioritization WG

Rebased, CI should pass now

LeSeulArtichaut

comment created time in 8 days

push eventLeSeulArtichaut/team

Justus K

commit sha 27a87a7a1dbda7077b56ea4158fb4c4f8a970fed

Add self to the icebreaker cleanup crew

view details

JamesPatrickGill

commit sha 965bed9cd163d8c1e2353ee61c28599fc268a2b3

add JamesPatrickGill to cleanup crew

view details

LeSeulArtichaut

commit sha 1a38b30cc3487d17c9328832257d8e3c51d3a0d5

Fix wrong Zulip stream for Prioritization WG

view details

Mark Rousskov

commit sha 8f7cb603e552c6da97ecfd2e61c0fcc61fdd81c8

Merge pull request #433 from LeSeulArtichaut/patch-1 Fix wrong Zulip stream for Prioritization WG

view details

Stu

commit sha af9519970f7b2f358fa511ae6de758aef85bcd78

Add zulip-id Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>

view details

James Gill

commit sha 27b0e7a3ef4571b215935b676a034fce911a662c

Update people/JamesPatrickGill.toml Thanks for adding this Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>

view details

Pietro Albini

commit sha ce58fe2643928c242a5cf4113b2c3873c2b206e2

Merge pull request #431 from Stupremee/add-self-to-cleanup Add self to the icebreaker cleanup crew

view details

Pietro Albini

commit sha 965cd294e562c65695036a76a0593c62e5037037

Merge branch 'master' into add-cleanupcrew-JamesPatrickGill

view details

Pietro Albini

commit sha 5d4aa8a258436c21e6513d997daa0912abeeb311

Merge pull request #432 from JamesPatrickGill/add-cleanupcrew-JamesPatrickGill Add JamesPatrickGill to cleanup crew

view details

LeSeulArtichaut

commit sha e10f71bf2f4125c8a18ebb1785b0859fbc3a12a2

Add people to the Prioritization WG

view details

LeSeulArtichaut

commit sha 22062666e2f4bbb575a4e988278f1dc120abdea5

Add more people to the Prioritization WG

view details

push time in 8 days

push eventLeSeulArtichaut/team

LeSeulArtichaut

commit sha 5536da91243d0af1f2fe318957f42ece2bf64026

Add more people to the Prioritization WG

view details

push time in 8 days

issue commentrust-lang/rust

Build hang on Linux with nightly and beta toolchains

@rustbot ping llvm

danieldeankon

comment created time in 9 days

issue commentrust-lang/rust

Build hang on Linux with nightly and beta toolchains

Adding them back now, and I’ll mark this conversation as resolved to limit the noise

danieldeankon

comment created time in 9 days

issue commentrust-lang/rust

Build hang on Linux with nightly and beta toolchains

@cuviper Did you remove I-hang and T-compiler labels intentionally or was it conflicting with the fact that I just added them?

danieldeankon

comment created time in 9 days

startedyewstack/yew

started time in 10 days

Pull request review commentrust-lang/team

Add people to the Prioritization WG

+name = 'DJ Carpenter'+github = 'djcarpe'+github-id = 59489977+zulip-id = 59489977

Yeah, that’s definitely a copy-paste mistake. Good catch!

LeSeulArtichaut

comment created time in 10 days

PullRequestReviewEvent

pull request commentrust-lang/team

Add people to the Prioritization WG

I think this is now ready for merging, modulo blocking PRs #431 and #432. @spastorino Please check my last commit, I added 3 more people including @hameerabbasi who asked to join this morning (👋)

Could someone from the Core team merge #431 and #432 (adds people to Cleanup Crew)? Maybe cc @pietroalbini

LeSeulArtichaut

comment created time in 11 days

push eventLeSeulArtichaut/team

LeSeulArtichaut

commit sha 4796736e7a1de3af993c3bc224e3300b3ea57a03

Add more people to the Prioritization WG

view details

push time in 11 days

pull request commentrust-lang/team

Add people to the Prioritization WG

Depends on #431 and #432 for user files.

:)

LeSeulArtichaut

comment created time in 11 days

push eventLeSeulArtichaut/team

LeSeulArtichaut

commit sha cfec8e534257d499fd1cc6b62bdcc9679e4ddd3b

Add people to the Prioritization WG

view details

push time in 11 days

push eventLeSeulArtichaut/team

LeSeulArtichaut

commit sha f9e38cf167b1bc7b3461b52bcf8f439a68e5292f

Add people to the Prioritization WG

view details

push time in 11 days

create barnchLeSeulArtichaut/team

branch : wg-prio

created branch time in 11 days

PR opened rust-lang/team

Add people to the Prioritization WG

Welcome @mstallmo @Stupremee @Camelid @jechasteen @frxstrem @bawerd @JamesPatrickGill :tada:

cc @spastorino Depends on #431 and #432 for user files.

+23 -0

0 comment

5 changed files

pr created time in 11 days

issue commentrust-lang/www.rust-lang.org

Wrong display for escaped characters

@rustbot modify labels: +P-Team

LeSeulArtichaut

comment created time in 11 days

delete branch LeSeulArtichaut/team

delete branch : patch-1

delete time in 11 days

issue openedrust-lang/www.rust-lang.org

Wrong display for escaped characters

What needs to be fixed?

URL-escaped characters, e.g. /, are displayed as their escaped counterpart in Zulip stream names.

Page(s) Affected

All /governance teams/WGs who have attached Zulip streams containing an escaped character. For example, see all WGs that are subteams of T-compiler.

Suggested Improvement

The website should probably use the raw data from rust-lang/team. #1235 might be reworked to store both displayable strings and escaped strings to create the links.

created time in 11 days

PR opened rust-lang/team

Fix wrong Zulip stream for Prioritization WG

😁

r? @Mark-Simulacrum cc @spastorino

+1 -1

0 comment

1 changed file

pr created time in 11 days

push eventLeSeulArtichaut/team

LeSeulArtichaut

commit sha 1a38b30cc3487d17c9328832257d8e3c51d3a0d5

Fix wrong Zulip stream for Prioritization WG

view details

push time in 11 days

Pull request review commentrust-lang/team

Add self to the icebreaker cleanup crew

+name = 'Stu'+github = 'Stupremee'+github-id = 39732259
github-id = 39732259
zulip-id = 230287
Stupremee

comment created time in 11 days

PullRequestReviewEvent

Pull request review commentrust-lang/team

Add JamesPatrickGill to cleanup crew

+name = 'James Gill'+github = 'JamesPatrickGill'+github-id = 44863195

You might want to add your Zulip ID here. I believe it's not used yet but it might be in the future

JamesPatrickGill

comment created time in 11 days

PullRequestReviewEvent

PR closed FrenchMasterSword/RTFMbot

Reviewers
Add Rust documentation

More documentations and references to come

Alright, let's do just that!

Add support for the official stable Rust documentation through the List of all items page.

+37 -1

4 comments

3 changed files

LeSeulArtichaut

pr closed time in 12 days

issue commentrust-lang/rust

`==` expression with unsafe block on left-hand side fails to parse

Related to #54482/#7909?

jmagnuson

comment created time in 12 days

pull request commentrust-lang/rust

Improve diagnostics for functions in `struct` definitions

@jyn514 pushed the test

LeSeulArtichaut

comment created time in 12 days

push eventLeSeulArtichaut/rust

LeSeulArtichaut

commit sha 8892a2c42706063ecb8edcbcb7031ec9e7d476af

Add basic test

view details

push time in 12 days

issue commentrust-lang/rust

Removing FatalErrors from StringReader

  1. there still seems to be a small bug still where the "Some errors have detailed explanations" message is being hidden.

There are still a few bugs, I also noticed that ICEs don’t emit all the notes that say "please file an issue" etc... I haven’t fixed them yet because it was only an experiment, but if you want me to dig into it, I’m up, though I’ll obviously need guidance.

matklad

comment created time in 13 days

PR opened rust-lang/rust

Improve diagnostics for functions in `struct` definitions

Tries to implement #76421. This is probably going to need unit tests, but I wanted to hear from review all the cases tests should cover.

I'd like to follow up with the "mechanically applicable suggestion here that adds an impl block" step, but I'd need guidance. My idea for now would be to try to parse a function, and if that succeeds, create a dummy ast::Item impl block to then format it using pprust. Would that be a viable approach? Is there a better alternative?

r? @matklad cc @estebank

+42 -19

0 comment

2 changed files

pr created time in 13 days

create barnchLeSeulArtichaut/rust

branch : diagnose-functions-struct

created branch time in 13 days

issue commentrust-lang/rust

wasi-sdk/bin/wasm-ld regression in 1.46.0

@TjeuKayim is your issue fixed on the latest nightly?

TjeuKayim

comment created time in 14 days

delete branch LeSeulArtichaut/rustc-guide

delete branch : rustc-ids

delete time in 15 days

delete branch LeSeulArtichaut/this-week-in-rust

delete branch : patch-1

delete time in 15 days

issue commentrust-lang/rust

Give a better error message for functions in `struct { ... }`

I’d like to try to do the first step of changing the current diagnostic

jyn514

comment created time in 16 days

issue commentrust-lang/rust

Removing FatalErrors from StringReader

Yes, it was a silly mistake on my part. I simply forgot to handle the failure-note properly, which meant that when rustc was aborting, it didn't emit the "For more information about this error" messages. Hopefully it was easy to realize just by looking at the diff

matklad

comment created time in 16 days

issue commentrust-lang/rust

Removing FatalErrors from StringReader

My gut feeling is that Handler::emit_error should set a flag if a Fatal diagnostic is ever emitted, and drop all subsequent diagnostics on the floor.

@matklad here would be the results of such a change. It changes 10 UI files (sounds more reasonable than 4367 🙄). I've skimmed through the diff and find it is an improvement overall, I'd like to know what you think. Also maybe cc @estebank

matklad

comment created time in 16 days

push eventLeSeulArtichaut/rust

LeSeulArtichaut

commit sha 984d25225baaa15e3b67b1827b325e6a60ed96ea

Experiment: do not emit diagnostics after a fatal error

view details

LeSeulArtichaut

commit sha 15856f10db3ef5006e419dbe3c32553d21b81cf6

Bless tests

view details

push time in 17 days

push eventLeSeulArtichaut/rust

LeSeulArtichaut

commit sha 92e002e59e408b06fa0773b763dd777b1f29869e

Bless tests

view details

push time in 17 days

create barnchLeSeulArtichaut/rust

branch : no-err-after-fatal

created branch time in 17 days

issue commentrust-lang/rust

Removing FatalErrors from StringReader

My gut feeling is that Handler::emit_error should set a flag if a Fatal diagnostic is ever emitted, and drop all subsequent diagnostics on the floor.

I tried that as an experiment then ran the UI tests:

test result: FAILED. 6337 passed; 4367 failed; 76 ignored; 0 measured; 0 filtered out

I haven't looked in detail in the failures, but 4367 seems a lot to me.

matklad

comment created time in 17 days

push eventLeSeulArtichaut/rust

LeSeulArtichaut

commit sha a04a2fa1c2f479e6ed4eb880754d839653cc3b9d

Deny unsafe ops in unsafe fns in `std::sys_common`

view details

push time in 17 days

pull request commentrust-lang/rust

Deny unsafe ops in unsafe fns in `std::sys_common`

Resolved the conflicts, and CI should pass now.

LeSeulArtichaut

comment created time in 17 days

push eventLeSeulArtichaut/rust

LeSeulArtichaut

commit sha 20e0f1285ad9f3bb75b1e7b459fcd34694e3effe

Deny unsafe ops in unsafe fns in `std::sys_common`

view details

push time in 17 days

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha c58eec88f7ebfddaed939c8c5010bb5101b32a12

Fix typo Co-authored-by: Who? Me?! <mark-i-m@users.noreply.github.com>

view details

push time in 17 days

push eventLeSeulArtichaut/rust

bors

commit sha 332369110919ac27c8a0bc0b21bf9d2f9fd9829d

Auto merge of #75747 - cuviper:rollup-icke90l, r=cuviper Rollup of 8 pull requests Successful merges: - #75672 (Move to intra-doc links for task.rs and vec.rs) - #75702 (Clean up E0759 explanation) - #75703 (Enable stack-overflow detection on musl for non-main threads) - #75710 (Fix bad printing of const-eval queries) - #75716 (Upgrade Emscripten on CI to 1.39.20 ) - #75731 (Suppress ty::Float in MIR comments of ty::Const) - #75733 (Remove duplicated alloc vec bench push_all_move) - #75743 (Rename rustc_lexer::TokenKind::Not to Bang) Failed merges: r? @ghost

view details

Matthew Jasper

commit sha 67fb5839df4c737911556f3c9967d632ae530a7c

Don't immediately error for cycles during normalization

view details

Guillaume Gomez

commit sha 631c80659dab1e6f0b335cd7862eddc341eff0ac

Remove "total" columns in --show-coverage output

view details

Guillaume Gomez

commit sha 9c254c18d6d32a15879cc7f57e3039b66a481340

Update how doc examples are counted

view details

Guillaume Gomez

commit sha d108bd53866aef2a3b76164352c095e898fe92db

Add documentation for --show-coverage option

view details

Guillaume Gomez

commit sha 5e9cc4e31920b72fe4f1c4a44d1a6e250e36f254

fmt

view details

Camelid

commit sha 5a307cf4bbf3cb6065b43472ab99c1dd4fdc72e5

Fix intra-doc links One of the original links was linking to the wrong thing as well. Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

Alexis Bourget

commit sha fb3f9271311cedcc75ec45c385305e3e66f8959e

Move to intra doc links for std::thread documentation

view details

bors

commit sha e15510ca33ea15c893b78710101c962b11459963

Auto merge of #75494 - matthewjasper:defer-recursive-projection-error, r=nikomatsakis Don't immediately error for cycles during normalization #73452 meant some normalization cycles could be detected earlier, breaking some code. This PR makes defers errors for normalization cycles to fulfillment, fixing said code. Fixes #74868 r? @nikomatsakis

view details

bors

commit sha 410461191393e2339e79b33fa8baf4650b905db0

Auto merge of #5928 - mikerite:fix-5924, r=ebroto Fix false positive in `PRECEDENCE` lint Extend the lint to handle chains of methods combined with unary negation. Closes #5924 changelog: Fix false negative in `PRECEDENCE` lint

view details

LeSeulArtichaut

commit sha 1ababd87942dd3f62d6abc5fa1833fce2d5b88eb

Use intra-doc-links in `alloc`

view details

Dr. Koutheir Attouchi

commit sha 6fca004ba9645b2c1d4a51ddbbac0c89dd2133d5

Another motivation for CFG: return-oriented programming

view details

bors

commit sha d9d4d39612aae0b8398340bd83d592cafad8e4ec

Auto merge of #73565 - matthewjasper:core-min-spec, r=nagisa Use min_specialization in libcore Getting `TrustedRandomAccess` to work is the main interesting thing here. - `get_unchecked` is now an unstable, hidden method on `Iterator` - The contract for `TrustedRandomAccess` is made clearer in documentation - Fixed a bug where `Debug` would create aliasing references when using the specialized zip impl - Added tests for the side effects of `next_back` and `nth`. closes #68536

view details

Josh Triplett

commit sha 574f6bed62a205c743737c6b13e925a04a3de6bb

Switch to Snappy compression for metadata

view details

Tomasz Miąsko

commit sha 3b995ccc3f3b8e13af53f4bfc7bff072ee77169a

Extend normalization in const-eval-query-stack test Builds with debuginfo have additional information in backtrace.

view details

Lzu Tao

commit sha c4c017a18487145cd5fdcfda741acc6a2a00bef7

Suppress "const" prefix of FnDef in MIR dump

view details

bors

commit sha ff5e0f1dc8c5534406169903b3b9da029d3bada5

Auto merge of #74846 - Aaron1011:fix/pat-token-capture, r=petrochenkov Capture tokens for Pat used in macro_rules! argument This extends PR #73293 to handle patterns (Pat). Unlike expressions, patterns do not support custom attributes, so we only need to capture tokens during macro_rules! argument parsing.

view details

Michael Wright

commit sha 11efd75aeb8637bd5444104a57f1051b86c0d62b

Fix false negative in `option_as_ref_deref`

view details

bors

commit sha b51651ae9d0161967617be930415705b2e4d5faf

Auto merge of #75642 - matklad:lexer-comments, r=petrochenkov Move doc comment parsing to rustc_lexer Plain comments are trivia, while doc comments are not, so it feels like this belongs to the rustc_lexer. The specific reason to do this is the desire to use rustc_lexer in rustdoc for syntax highlighting, without duplicating "is this a doc comment?" logic there. r? @ghost

view details

Dr. Koutheir Attouchi

commit sha 5673b0e49219291acfb1c52f0c3119d266ef5ce9

Switched ROP link to Desktop layout instead of mobile layout

view details

push time in 17 days

delete branch LeSeulArtichaut/rustc-guide

delete branch : rustbot-relabeling

delete time in 17 days

pull request commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

Fixed x)

LeSeulArtichaut

comment created time in 17 days

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha 45632247aa0caa4306b8b1cc5d39cae42c517b70

Fix typo

view details

push time in 17 days

pull request commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

Wait. I made a typo in the message of a commit fixing a typo...

LeSeulArtichaut

comment created time in 17 days

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha 434745da7964bf0d31abb522ab9aeb7871b12bad

Fix type Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

push time in 17 days

pull request commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

Resolved all the reviews, this should be ready for merging now :)

LeSeulArtichaut

comment created time in 17 days

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha 861b0c250c10b5aff2e0049713ef8f5426ca7945

Hide `@rustdoc` implementation details

view details

push time in 17 days

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha 91b2a4c70360a8341f8b97a44b49b87f60529170

Apply suggestions from code review Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com> Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

push time in 18 days

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

+# Mastering @rustbot++`@rustbot` (also known as `triagebot`) is a utility robot that is mostly used to+allow any contributor to achieve certain tasks that would normally require GitHub+membership to the `rust-lang` organization. Its most interesting features for+contributors to `rustc` are isssue claiming and relabeling.++## Issue claiming++`@rustbot` exposes a command that allows anyone to assign an issue to themselves.+If you see an issue you want to work on, you can send the following message as a+comment on the issue at hand:++    @rustbot claim++If you are a member of the `rust-lang` organization, `@rustbot` will assign the+issue to you. Otherwise, `@rustbot` will assign itself as a placeholder and edit+the top comment to reflect the fact that the issue is now assigned to you.

Thanks for the clarification! I think you’re right, just saying that you might be assigned indirectly is the best way of presenting things indeed

LeSeulArtichaut

comment created time in 18 days

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

+# Mastering @rustbot++`@rustbot` (also known as `triagebot`) is a utility robot that is mostly used to+allow any contributor to achieve certain tasks that would normally require GitHub+membership to the `rust-lang` organization. Its most interesting features for+contributors to `rustc` are isssue claiming and relabeling.++## Issue claiming++`@rustbot` exposes a command that allows anyone to assign an issue to themselves.+If you see an issue you want to work on, you can send the following message as a+comment on the issue at hand:++    @rustbot claim++If you are a member of the `rust-lang` organization, `@rustbot` will assign the+issue to you. Otherwise, `@rustbot` will assign itself as a placeholder and edit+the top comment to reflect the fact that the issue is now assigned to you.

They are now :P Btw they were member or the Prioritization WG which is "enough" to be part or the GitHub org

LeSeulArtichaut

comment created time in 18 days

PullRequestReviewEvent

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha a9d06b8b955cd49de515bd795dd85187ec85ab1e

Add a chapter on useful `@rustbot` commands

view details

push time in 18 days

PR opened rust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

Closes #855 (cc @jyn514)

+76 -4

0 comment

3 changed files

pr created time in 18 days

create barnchLeSeulArtichaut/rustc-guide

branch : rustbot-relabeling

created branch time in 18 days

pull request commentrust-lang/rust

Deny unsafe ops in unsafe fns in `std::sys_common`

Sorry for being so slow to respond. I'm currently rebasing this PR, I should push soon.

LeSeulArtichaut

comment created time in 18 days

push eventLeSeulArtichaut/rustc-guide

LeSeulArtichaut

commit sha c56ac824a95267ffade49dce0ea050c1de41e499

Make the HIR chapter point to the new chapter on IDs

view details

push time in 18 days

more