profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/KrzysFR/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Christophe Chevalier KrzysFR Doxense Lille, France

KrzysFR/SignalR 1

Async library for .NET to help build real-time, multi-user interactive web applications.

KrzysFR/zstd 1

Zstandard - Fast real-time compression algorithm

Doxense/fdb-build-support 0

FoundationDB build and development resources

Doxense/foundationdb 0

FoundationDB - the open source, distributed, transactional key-value store

KrzysFR/Balzor.Extensions.SignalR 0

SignalR Core support for Microsoft ASP.NET Core Blazor

KrzysFR/FiniteStateEntropy 0

New generation entropy codecs : Finite State Entropy and Huff0

KrzysFR/foundationdb 0

FoundationDB - the open source, distributed, transactional key-value store

KrzysFR/frqsspslt 0

Test Test 1 2 3... Is this thing on ?

KrzysFR/gitextensions 0

GitExtensions is a shell extension, a Visual Studio 2008/2010/2012/2013 plugin and a standalone Git repository tool.

MemberEvent
MemberEvent
MemberEvent
MemberEvent

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 62f465946d4e0fa67145cd48a9ab97c98e52e662

Update main.yml Update default github repo

view details

push time in 13 days

Pull request review commentapple/foundationdb

Fix build with DISABLE_TLS=ON

 std::string BackupContainerS3BlobStore::getURLFormat() {  Future<Reference<IAsyncFile>> BackupContainerS3BlobStore::readFile(const std::string& path) { 	Reference<IAsyncFile> f = makeReference<AsyncFileS3BlobStoreRead>(m_bstore, m_bucket, dataPath(path));+#if ENCRYPTED_ENABLED

Shouldn't this be ENCRYPTION_ENABLED instead of ENCRYPT*ED*_ENABLED ?

sfc-gh-tclinkenbeard

comment created time in 14 days

Pull request review commentapple/foundationdb

Fix build with DISABLE_TLS=ON

 class BackupContainerAzureBlobStoreImpl { 			    return Void(); 		    })); 		auto f = makeReference<WriteFile>(self->asyncTaskThread, self->containerName, fileName, self->client.get());+#if ENCRYPTED_ENABLED

Shouldn't this be ENCRYPTION_ENABLED instead of ENCRYPT*ED*_ENABLED ?

sfc-gh-tclinkenbeard

comment created time in 14 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 2e7671e0b216a9ba1f1c5a715322c63316b1a19a

Update main.yml

view details

push time in 16 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 13c943416c2d2c31abe8ceebc55b14cc62ed440c

Update build.yml

view details

push time in 16 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 4e1c9a48599476aa178ad0fe3697a0c567c196a0

Update README.md

view details

push time in 16 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 48ce616519e16f71a9fc5fddaaa302b5b11c1848

Update README.md

view details

push time in 16 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 900979b22b66a951c74cb7e79b53e21c51edefe2

Update build.yml Add a second artifact only for the MSI

view details

push time in 16 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 2b833c62e33d398574104550562158e9c7ca0b20

Update build.yml Fix artifacts path

view details

push time in 16 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 17c36e864357a6ec124ce7c0516de6c16b426c1e

Update build.yml Try to fix capture of artifacts

view details

push time in 16 days

pull request commentapple/foundationdb

Fix Windows build and add Docker build image (7.0)

I have opened a PR against master which is identical (sorry for the mess!). Let me know if I need to close this one (against 7.0) or not!

KrzysFR

comment created time in 17 days

PR opened apple/foundationdb

Windows docker build master

This PR continues from the great work or @mpilman in https://github.com/apple/foundationdb/pull/4257, but retargeted on the master branch.

Notes:

  • There is another PR on the release-7.0 branch (#5136). I'm unsure if both (master and 7.0) PR need to be done?
  • A similar PR for the 6.3 release branch is #5137
  • I don't seem to be able to add labels to this PR. I think it should have the "RFC" label ?

Adds:

  • Retarget the windows build on using clang and LLVM, instead of MSVC. This allows using any C++11 or C++17 syntax without worrying about support from msvc.
  • Dockerfile.windows : this is the main dockerfile that generate a docker image that contains all the windows build tools necessary to produce the MSI installer and various other tools. Note: this image has already been build and updated on the CI servers. It is the foundationdb/foundationdb-build-windows:0.1.0 which we already worked on a few months ago.
    • This image can be rebuilt, if required, via github actions using this repository: https://github.com/Doxense/foundationdb-windows-build
  • Dockerfile.windows.devel : this is another dockerfile that adds other tools (currently only git) that would be needed to build a "developer friendly" environment, meant to work on the source, build and test on Windows (using Visual Studio).
  • build.ps1 : this is the main script that uses the Dockerfile.windows.devel image to run cmake and invoke msbuild. This script produces all the release artefacts.

Fixes:

  • fixed an issue with <memory.h> not being imported properly when building for windows, by adding a test for _MSC_VER
  • bumped minimum cmake version from 3.12 to 3.15 on windows, required to support specifying CMAKE_MSVC_RUNTIME_LIBRARY. We left it to 3.13 for non-Windows in order to not change anything.
  • disabled building the documentation on Windows, because "sphinx" is linux only, and the main documentation is already built and published already.
  • Removed deprecated @Action attribute in the WIX projects (which build the MSI installer). There are a few other deprecated attributes that produces warnings during the build, and that we will try to remove in a later PR.

Tests performed:

  • using this PR, simply checkout the code, and run "build.ps1" in the .\build folder will produce a usable build.
  • The initial build time is very dependent on the number of cpu cores and available memory, but will range between 6 minutes on a very fast server, to 10 minutes on a good desktop and up to 20 to 40 minutes on a consumer-grade laptop.
  • There is currently a minium pre-requisite on the available physical + virtual memory size of about 1.5 GB per CPU cores used. With less memory, the build will fail with out of memory issues. We are working on tuning the heuristic in the build script to account for this.

Not addressed by this PR:

  • Documentation: as described above, I don't think there is a point in being able to build the documentation on Windows: the same files can be produced on linux, and they are published on the main site.
  • Test suite: currently disabled on Windows. This suite has never run on Windows before. Bringing it to a usable level will be one of our next tasks.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
+151 -6

0 comment

8 changed files

pr created time in 17 days

create barnchKrzysFR/foundationdb

branch : windows-docker-build-master

created branch time in 17 days

issue commentapple/foundationdb

Officially discontinue the Windows build

I have opened two PR #5136 (7.0) and #5137 (6.3) that fix the build on Windows. Let me know if we need to create a PR for the master branch also (it's ready to go).

I have also added a GitHub action that can run these builds here: (currently only the 7.0 branch is hooked up, I will try to add the 6.3 shortly)

7.0: https://github.com/Doxense/foundationdb-windows-build/actions/workflows/build.yml

sfc-gh-almiller

comment created time in 17 days

PR opened apple/foundationdb

Fix Windows build and add Docker build image (6.3)

_This PR is a mirror of #5136 which does the same work, but on the release-6.3 branch. and is a finalized version of the similar PR in #4257 _

Notes:

  • This PR is targeting the 6.3 branch because it can be used to be able to build the Windows MSI package for 6.3 (which has not been updated since 6.3.12).
  • I don't seem to be able to add labels to this PR. I think it should have the "RFC" label ?

Adds:

  • Retarget the windows build on using clang and LLVM, instead of MSVC. This allows using any C++11 or C++17 syntax without worrying about support from msvc.
  • Dockerfile.windows : this is the main dockerfile that generate a docker image that contains all the windows build tools necessary to produce the MSI installer and various other tools. Note: this image has already been build and updated on the CI servers. It is the foundationdb/foundationdb-build-windows:0.1.0 which we already worked on a few months ago.
    • This image can be rebuilt, if required, via github actions using this repository: https://github.com/Doxense/foundationdb-windows-build
  • Dockerfile.windows.devel : this is another dockerfile that adds other tools (currently only git) that would be needed to build a "developer friendly" environment, meant to work on the source, build and test on Windows (using Visual Studio).
  • build.ps1 : this is the main script that uses the Dockerfile.windows.devel image to run cmake and invoke msbuild. This script produces all the release artefacts.

Fixes:

  • fixed an issue with <memory.h> not being imported properly when building for windows, by adding a test for _MSC_VER
  • bumped minimum cmake version from 3.12 to 3.15 on windows, required to support specifying CMAKE_MSVC_RUNTIME_LIBRARY. We left it to 3.13 for non-Windows in order to not change anything.
  • disabled building the documentation on Windows, because "sphinx" is linux only, and the main documentation is already built and published already.
  • Removed deprecated @Action attribute in the WIX projects (which build the MSI installer). There are a few other deprecated attributes that produces warnings during the build, and that we will try to remove in a later PR.

Tests performed:

  • using this PR, simply checkout the code, and run "build.ps1" in the .\build folder will produce a usable build.
  • The initial build time is very dependent on the number of cpu cores and available memory, but will range between 6 minutes on a very fast server, to 10 minutes on a good desktop and up to 20 to 40 minutes on a consumer-grade laptop.
  • There is currently a minium pre-requisite on the available physical + virtual memory size of about 1.5 GB per CPU cores used. With less memory, the build will fail with out of memory issues. We are working on tuning the heuristic in the build script to account for this.

Not addressed by this PR:

  • Documentation: as described above, I don't think there is a point in being able to build the documentation on Windows: the same files can be produced on linux, and they are published on the main site.
  • Test suite: currently disabled on Windows. This suite has never run on Windows before. Bringing it to a usable level will be one of our next tasks.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
+151 -6

0 comment

8 changed files

pr created time in 17 days

create barnchKrzysFR/foundationdb

branch : windows-docker-build-6.3

created branch time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 2a1c35680359f8c5dbe7015a0f5a0e20335a7410

Update build.yml Add support for uploading the build artifacts

view details

push time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 2302c9190a383958586c8ae3435b789189544c05

Update build.yml Use `powershell` instead of `pwsh` (not recognized on default self-hosted runner)

view details

push time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 7234c38db2b5ef513de5a5f85a6aebe377b597bc

Update build.yml Use self-hosted build runner

view details

push time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 4c3731e1b25717d5f023ed3bb49ba1507dd3848f

Update build.yml Add input variable "cpus" and "memory" to the github action

view details

push time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha f1260eccbf54ef42238922c5328723215960556f

Update build.yml Create artefact output folder before starting the build

view details

push time in 17 days

push eventKrzysFR/foundationdb

Christophe Chevalier

commit sha 478a31723f11d2480bde8728b3051413746815ae

Fix windows build.ps1 for compatibility with GitHub CI - Replace deprecated `Get-WmiObject` with `Get-CimInstance` to get the cpu count and memory size

view details

push time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 96c94b20d046ded113db0bf3bdeec550126b1782

Update build.yml Remove unneeded docker tag field

view details

push time in 17 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 1c82f450688b5117509a445b8f436ff54d25d179

Create build action First attempt at running the windows build

view details

push time in 17 days