profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/KrzysFR/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Christophe Chevalier KrzysFR Doxense Lille, France

KrzysFR/SignalR 1

Async library for .NET to help build real-time, multi-user interactive web applications.

KrzysFR/zstd 1

Zstandard - Fast real-time compression algorithm

Doxense/fdb-build-support 0

FoundationDB build and development resources

Doxense/foundationdb 0

FoundationDB - the open source, distributed, transactional key-value store

KrzysFR/Balzor.Extensions.SignalR 0

SignalR Core support for Microsoft ASP.NET Core Blazor

KrzysFR/fdb-build-support 0

FoundationDB build and development resources

KrzysFR/FiniteStateEntropy 0

New generation entropy codecs : Finite State Entropy and Huff0

KrzysFR/foundationdb 0

FoundationDB - the open source, distributed, transactional key-value store

KrzysFR/frqsspslt 0

Test Test 1 2 3... Is this thing on ?

KrzysFR/gitextensions 0

GitExtensions is a shell extension, a Visual Studio 2008/2010/2012/2013 plugin and a standalone Git repository tool.

startedyosshin4004/portable_mdx

started time in 8 days

startednicollasricas/streamdeckvs

started time in 10 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 340efbcc1859eeed8214749241215d848d725001

Update build-7.0.yaml

view details

push time in 21 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 968345060835e5b8997829ffa94bd519ce8bbc52

Update build-6.3.yaml

view details

push time in 21 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 9440c9a80b14c36491ae6d6abf82f4e26b6c5d21

Create build-7.0.yaml

view details

push time in 21 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha f33c7db64246761521b623d0c325ffb2a80ea631

Update build.yml

view details

push time in 21 days

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 687e8c471936daa3da4b9f6d7f874dd514a82fd4

Create build-6.3.yaml

view details

push time in 21 days

startedOpenMacroBoard/StreamDeckSharp

started time in a month

MemberEvent

push eventDoxense/foundationdb

Andrew Noyes

commit sha b3d83e1b2e7eda0bb1c330ad504d873ebde20e2f

Use custom memcmp impl on Arm

view details

Andrew Noyes

commit sha 16e05fad9dd3ffab349db8b37bf2b7529582b987

Add custom memcpy for aarch64

view details

Lukas Joswiak

commit sha 805c4200ce7a8f2e76b6feccf6f350f1ec83f8c2

Add collector to get running actor name

view details

Lukas Joswiak

commit sha 2d248a5926d230430408fca61ba1b816e83a7002

Collect actors waiting on disk and network

view details

Lukas Joswiak

commit sha 65e3ead37e745e50ae642e6f9d58b7e9f9f8469e

Cleanup

view details

Andrew Noyes

commit sha af0f286e17bacffb1b0302dbabfb79cbac063238

Fix a few instances of UB Member access to address which does not point to correct type

view details

Andrew Noyes

commit sha 0e9eabdb189f520441cb0a0161df9ca3881f89b1

Cherry-pick UBSAN fix from https://github.com/Tencent/rapidjson/commit/16872af88915176f49e389defb167f899e2c230a

view details

Andrew Noyes

commit sha c9b06839fc6c76a4ab1e0d3295d26179957c5817

Halt on error in ubsan for ctest tests

view details

Andrew Noyes

commit sha 2c19940a42f8f0adf03a22e370c18e0f88706f69

Make hidden options exist Otherwise we can't set EXTERNAL_CLIENT without invoking UB

view details

Andrew Noyes

commit sha 7f35a663831e307b8ebd0ed93f97bc096af1e13e

Fix the types of dl functions in the multi-version client This fixes undefined behavior of invoking a function pointer with the wrong type.

view details

Fuheng Zhao

commit sha 5f9d48b2ff0b10cf393c6b49836c5dbebdaa7e91

initial draft on RedWoodMetrics changes

view details

Andrew Noyes

commit sha d69fda1d2ec866f9d27b84596794e59e0ce3d7be

Remove preinitializeOnForeignThread

view details

Fuheng Zhao

commit sha ed2f8c928224c7940bbeb2c2e6407b3214f23882

add percentage unit to histogram class

view details

Fuheng Zhao

commit sha 109cb652ab1c6aefd9197d9469b693c863e3507b

add recordCounter in histogram to track data from small ranges

view details

Fuheng Zhao

commit sha acde8134f31caf74809163fa82c40d9171d0a1c8

change histogram class static member variable to non-static

view details

Fuheng Zhao

commit sha ac01e48353eeb2480f6cdcbbf52e8ed150a0f6fa

add drawHistogram method in histogram class

view details

Fuheng Zhao

commit sha c0b539c49546567ae57fc4c3a22c9ae9ed73d6cd

initialize fields in redWoodMetrics struct explicitly

view details

Fuheng Zhao

commit sha 7b84b8fae6983eecf5eb89c8b805e7315778a946

add redWoodMetrics::Level struct constructor

view details

Fuheng Zhao

commit sha 9c945253f65cb6896172c6448ad962f896489c52

update redwoodmetrics structure; need to fix bug

view details

Fuheng Zhao

commit sha 60f1a0a08fc2852d01789b863e80782d557a03ee

fix minor error

view details

push time in a month

push eventDoxense/fdb-build-support

Christophe Chevalier

commit sha 3d775165daf4dd66581af3d5b259a9926d72816a

Update build.ps1 fix path to devel Dockerfile

view details

push time in 2 months

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 0fe0c7b4dbdd231d377e0576bf0d907aeae815ae

Update build.yml Update env var name again

view details

push time in 2 months

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 4ad398f44375aa4cc836642b941483d08ef62b45

Update build.yml fix env variable name

view details

push time in 2 months

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha c2f5844ff4ec5b166a8593849130f9c4238a47bf

Update build.yml add login to docker step

view details

push time in 2 months

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha df31424ffb47f96adfe52f6d73d8dfe272c72e13

Update ci.yaml fix docker env variable names

view details

push time in 2 months

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 6b63d7da6f3d7aee033a0a5e715bd7053b47805c

Update ci.yaml Perform a docker login before running the build script - required or else the docker pull fails with "unauthorized: incorrect username or password"

view details

push time in 2 months

push eventDoxense/fdb-build-support

Christophe Chevalier

commit sha fb113425d190e6ba6a4083ec0a1fadfb28437d43

Update build.ps1 Add $ErrorActionPreference = 'Stop'

view details

push time in 2 months

pull request commentapple/foundationdb

Added dockerfile for Windows build

This original PR is outdated since the move of the build/ folder to the new the https://github.com/FoundationDB/fdb-build-support/ repository, and should probably be closed.

@moulmahdi is in the process of creating a PR to be able to run a CI build as well (build + test).

mpilman

comment created time in 2 months

PR closed apple/foundationdb

Reviewers
Fix Windows build and add Docker build image (7.0)

This PR continues from the great work or @mpilman in https://github.com/apple/foundationdb/pull/4257, but retargeted on the latest 7.0 branch.

Notes:

  • I'm unsure if this PR should be against 7.0 or master. The goal of this PR is to be able to build a 7.0 release build for Windows. If we first need to submit this PR against master, let me know!
  • A similar PR for the 6.3 release branch will follow shortly.
  • I don't seem to be able to add labels to this PR. I think it should have the "RFC" label ?

Adds:

  • Retarget the windows build on using clang and LLVM, instead of MSVC. This allows using any C++11 or C++17 syntax without worrying about support from msvc.
  • Dockerfile.windows : this is the main dockerfile that generate a docker image that contains all the windows build tools necessary to produce the MSI installer and various other tools. Note: this image has already been build and updated on the CI servers. It is the foundationdb/foundationdb-build-windows:0.1.0 which we already worked on a few months ago.
    • This image can be rebuilt, if required, via github actions using this repository: https://github.com/Doxense/foundationdb-windows-build
  • Dockerfile.windows.devel : this is another dockerfile that adds other tools (currently only git) that would be needed to build a "developer friendly" environment, meant to work on the source, build and test on Windows (using Visual Studio).
  • build.ps1 : this is the main script that uses the Dockerfile.windows.devel image to run cmake and invoke msbuild. This script produces all the release artefacts.

Fixes:

  • fixed an issue with <memory.h> not being imported properly when building for windows, by adding a test for _MSC_VER
  • bumped minimum cmake version from 3.12 to 3.15 on windows, required to support specifying CMAKE_MSVC_RUNTIME_LIBRARY. We left it to 3.13 for non-Windows in order to not change anything.
  • disabled building the documentation on Windows, because "sphinx" is linux only, and the main documentation is already built and published already.
  • Removed deprecated @Action attribute in the WIX projects (which build the MSI installer). There are a few other deprecated attributes that produces warnings during the build, and that we will try to remove in a later PR.

Tests performed:

  • using this PR, simply checkout the code, and run "build.ps1" in the .\build folder will produce a usable build.
  • The initial build time is very dependent on the number of cpu cores and available memory, but will range between 6 minutes on a very fast server, to 10 minutes on a good desktop and up to 20 to 40 minutes on a consumer-grade laptop.
  • There is currently a minium pre-requisite on the available physical + virtual memory size of about 1.5 GB per CPU cores used. With less memory, the build will fail with out of memory issues. We are working on tuning the heuristic in the build script to account for this.

Not addressed by this PR:

  • Documentation: as described above, I don't think there is a point in being able to build the documentation on Windows: the same files can be produced on linux, and they are published on the main site.
  • Test suite: currently disabled on Windows. This suite has never run on Windows before. Bringing it to a usable level will be one of our next tasks.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
+152 -7

4 comments

9 changed files

KrzysFR

pr closed time in 2 months

pull request commentapple/foundationdb

Fix Windows build and add Docker build image (7.0)

This PR is outdated. Scripts have already been moved to the https://github.com/FoundationDB/fdb-build-support/ repo

KrzysFR

comment created time in 2 months

PR closed apple/foundationdb

Reviewers
Fix Windows build and add Docker build image (6.3)

_This PR is a mirror of #5136 which does the same work, but on the release-6.3 branch. and is a finalized version of the similar PR in #4257 _

Notes:

  • This PR is targeting the 6.3 branch because it can be used to be able to build the Windows MSI package for 6.3 (which has not been updated since 6.3.12).
  • I don't seem to be able to add labels to this PR. I think it should have the "RFC" label ?

Adds:

  • Retarget the windows build on using clang and LLVM, instead of MSVC. This allows using any C++11 or C++17 syntax without worrying about support from msvc.
  • Dockerfile.windows : this is the main dockerfile that generate a docker image that contains all the windows build tools necessary to produce the MSI installer and various other tools. Note: this image has already been build and updated on the CI servers. It is the foundationdb/foundationdb-build-windows:0.1.0 which we already worked on a few months ago.
    • This image can be rebuilt, if required, via github actions using this repository: https://github.com/Doxense/foundationdb-windows-build
  • Dockerfile.windows.devel : this is another dockerfile that adds other tools (currently only git) that would be needed to build a "developer friendly" environment, meant to work on the source, build and test on Windows (using Visual Studio).
  • build.ps1 : this is the main script that uses the Dockerfile.windows.devel image to run cmake and invoke msbuild. This script produces all the release artefacts.

Fixes:

  • fixed an issue with <memory.h> not being imported properly when building for windows, by adding a test for _MSC_VER
  • bumped minimum cmake version from 3.12 to 3.15 on windows, required to support specifying CMAKE_MSVC_RUNTIME_LIBRARY. We left it to 3.13 for non-Windows in order to not change anything.
  • disabled building the documentation on Windows, because "sphinx" is linux only, and the main documentation is already built and published already.
  • Removed deprecated @Action attribute in the WIX projects (which build the MSI installer). There are a few other deprecated attributes that produces warnings during the build, and that we will try to remove in a later PR.

Tests performed:

  • using this PR, simply checkout the code, and run "build.ps1" in the .\build folder will produce a usable build.
  • The initial build time is very dependent on the number of cpu cores and available memory, but will range between 6 minutes on a very fast server, to 10 minutes on a good desktop and up to 20 to 40 minutes on a consumer-grade laptop.
  • There is currently a minium pre-requisite on the available physical + virtual memory size of about 1.5 GB per CPU cores used. With less memory, the build will fail with out of memory issues. We are working on tuning the heuristic in the build script to account for this.

Not addressed by this PR:

  • Documentation: as described above, I don't think there is a point in being able to build the documentation on Windows: the same files can be produced on linux, and they are published on the main site.
  • Test suite: currently disabled on Windows. This suite has never run on Windows before. Bringing it to a usable level will be one of our next tasks.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
+151 -6

3 comments

8 changed files

KrzysFR

pr closed time in 2 months

pull request commentapple/foundationdb

Fix Windows build and add Docker build image (6.3)

This PR is outdated. Scripts have already been moved to the https://github.com/FoundationDB/fdb-build-support/ repo

KrzysFR

comment created time in 2 months

Pull request review commentapple/foundationdb

Fix Windows build and add Docker build image (6.3)

+# escape=`

This PR was created before the move and is outdated. The fdb-build-support repo already contains the same files. @moulmahdi is working on improving them to be able to run a CI build (build + tests) on top the the currently existing release build (installers, ...)

KrzysFR

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentapple/foundationdb

Fix Windows build and add Docker build image (6.3)

 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.-cmake_minimum_required(VERSION 3.13)+if(WIN32)+  cmake_minimum_required(VERSION 3.15)+else()+  cmake_minimum_required(VERSION 3.13)

The windows build require 3.15 minimum for some new VS specific feature, but we are using 3.19 in the docker build.

I think the linux build docker image has CMake 3.13 installed so updating it for linux as well would require upgrading the linux CI image.

KrzysFR

comment created time in 2 months

PullRequestReviewEvent

issue commentdotnet/runtime

Regression in StreamPipeReader.CopyToAsync() causes part of already consumed content to be copied again

That was fast! 👍

If I understand the PR correctly, the fix will be included in 6.0-rc1 ?

KrzysFR

comment created time in 2 months

push eventDoxense/fdb-build-support

Christophe Chevalier

commit sha 25fd680e6f684d89dfb6c299102616fe86a98a46

Update build.ps1 Stop execution if docker failed to build the devel image

view details

push time in 2 months

push eventDoxense/foundationdb-windows-build

Christophe Chevalier

commit sha 8ff2a5f8bccdeee98c6bfafbd50727623f4adc54

Update ci.yaml Fix action name

view details

push time in 2 months

push eventDoxense/fdb-build-support

Christophe Chevalier

commit sha 87aa5be94c805912dea34109b5530608b1eb1fa0

Update Dockerfile Use temporary windows build image (0.2.0)

view details

push time in 2 months