profile
viewpoint

KrisChambers/Chip-8 1

Learning Rust by implementing a Chip-8 emulator.

KrisChambers/deno-result 1

Trying out some rust like Result types for typescript.

KrisChambers/ntt 1

An Entity Component System built in typescript using some recursive typing ideas.

KrisChambers/app-extension-typescript 0

[WORK IN PROGRESS] Add typescript to your Quasar 1.0 project

KrisChambers/boa 0

Javascript engine written in Rust

KrisChambers/deno 0

A secure JavaScript and TypeScript runtime

KrisChambers/MSSqlDocker 0

DockerFile for setting up MSSQL running on a docker container with an initialized database.

KrisChambers/quasar-testing 0

Testing Harness App Extensions for the Quasar Framework 1.0+

KrisChambers/Truth-Tree-Assistant 0

A little tool to help build truth trees.

startedemilsekerinski/softwaredesign

started time in a month

push eventKrisChambers/deno

Paul Thompson

commit sha eed77aa0208e603dac908a240dd66ece422e9dd7

feat(web): FileReader API (#6673)

view details

Marcus Weiner

commit sha f425b51419da496011424f6259dad5ac11d433cd

core: memory limits & callbacks (#6914)

view details

Marcus Weiner

commit sha 58f86e063ab4d3e022b94f8f3c6a6a796ee9f749

Remove previous heap limit callback when registering (#7025)

view details

Nayeem Rahman

commit sha 81ce4499e7da7baf421b85b4a188d1a63569cab4

fix: Make std work with isolatedModules (#7016)

view details

Prabhanjan

commit sha b344a7f81fa00d1611212cac82b631f9d1dffdf0

fix: URLSearchParams.toString() behaviour is different from browsers (#7017)

view details

Alberto Ricart

commit sha 91ff91093dba45c9696d71e74323487cfa4ce406

feat(std): added TLS serve abilities to file_server (#6962)

view details

Nayeem Rahman

commit sha fed70c9903e616702241725e82a7d633f2a9b05d

feat: deno info --reload (#7009)

view details

Divy Srivastava

commit sha 6706eb551532ee6c84ad013377ac2cd91681424a

feat: add "--ignore" to deno lint (#6934)

view details

Ryan Dahl

commit sha f5a4f1fdc04b24cdfbef83842b9c42b5032c4059

Undo JsonOpDispatcher and OpDispatcher traits (#7023) This reverts commit f83d672ffad7afb1473bd4f9b9c645539064c620. This reverts commit d51972377c1325076704d9faec2eee6f0e024496.

view details

Jarrett Helton

commit sha c4edd09816b3cc6ab992f85602388f2f344fcf0e

feat(bundle): add support for --reload flag (#6996)

view details

木杉

commit sha 988790834e9611b45663e48a7bea49219da7511f

feat(std/http): add --no-dir-listing flag to file_server (#6808)

view details

Bert Belder

commit sha 3d70a2b94eac4d4032b8b11039efe6d070fa114f

upgrade: Rust crates The following crates were _not_ upgraded to avoid having multiple versions of the same crate in the dependency tree: * tokio-tungstenite v0.10.1 -> v0.11.0 * swc_common v0. 8.0 -> v0. 9.1 * swc_ecmascript v0. 1.0 -> v0. 3.0 * webpki-roots v0.19.0 -> v0.20.0 * nix v0.17.0 -> v0.18.0

view details

Benjamin Lupton

commit sha 452693256ce7b607fa0b9454b22c57748f616742

feat(std/node): add util.inspect (#6833)

view details

Nayeem Rahman

commit sha 18ec1290afcd78c61933ecb52e3ad97cf644f0d5

feat: Support file URLs in Deno.run for executable (#6994)

view details

Jarrett Helton

commit sha de4e1fbdf0d013893516479aa6e15b15d6319e38

feat: add support for --no-check flag in Deno install (#6948)

view details

Ryan Dahl

commit sha c4d9c6aa4baed5c9f4844dd5f28475e9ef2d87b0

upgrade: TypeScript to 3.9.7 (#7036)

view details

Divy Srivastava

commit sha ad4af23aba39e904ba9e2c284b6d06436b7b4f77

unify path normalization utility (#6865)

view details

Jarrett Helton

commit sha 514cbc2808754369f52c9f4baef97c16345d654b

fix: remove @ts-expect-error directives (#7024)

view details

Bartek Iwańczuk

commit sha 08ab4d46ca1860da16b5250fe3872cefbe682637

upgrade: swc, deno_lint, dprint (#7040)

view details

souldzin

commit sha d6cee706955f300086f41f9318d23631f64f036b

feat: Add "--json" flag to deno lint (#6940) Co-authored-by: JackSkylark <jdslaughter44@gmail.com>

view details

push time in a month

delete branch KrisChambers/deno

delete branch : origin/feature_add_dep_count_and_sizes_to_deno_info

delete time in a month

delete branch KrisChambers/deno

delete branch : feature_add_dep_count_and_sizes_to_deno_info__json_fixes

delete time in a month

delete branch KrisChambers/deno

delete branch : Issue#6685-ts

delete time in a month

delete branch KrisChambers/deno

delete branch : Issue#6685

delete time in a month

push eventKrisChambers/deno

Marcus Weiner

commit sha f425b51419da496011424f6259dad5ac11d433cd

core: memory limits & callbacks (#6914)

view details

Marcus Weiner

commit sha 58f86e063ab4d3e022b94f8f3c6a6a796ee9f749

Remove previous heap limit callback when registering (#7025)

view details

Nayeem Rahman

commit sha 81ce4499e7da7baf421b85b4a188d1a63569cab4

fix: Make std work with isolatedModules (#7016)

view details

Prabhanjan

commit sha b344a7f81fa00d1611212cac82b631f9d1dffdf0

fix: URLSearchParams.toString() behaviour is different from browsers (#7017)

view details

Alberto Ricart

commit sha 91ff91093dba45c9696d71e74323487cfa4ce406

feat(std): added TLS serve abilities to file_server (#6962)

view details

Nayeem Rahman

commit sha fed70c9903e616702241725e82a7d633f2a9b05d

feat: deno info --reload (#7009)

view details

Divy Srivastava

commit sha 6706eb551532ee6c84ad013377ac2cd91681424a

feat: add "--ignore" to deno lint (#6934)

view details

Ryan Dahl

commit sha f5a4f1fdc04b24cdfbef83842b9c42b5032c4059

Undo JsonOpDispatcher and OpDispatcher traits (#7023) This reverts commit f83d672ffad7afb1473bd4f9b9c645539064c620. This reverts commit d51972377c1325076704d9faec2eee6f0e024496.

view details

Jarrett Helton

commit sha c4edd09816b3cc6ab992f85602388f2f344fcf0e

feat(bundle): add support for --reload flag (#6996)

view details

木杉

commit sha 988790834e9611b45663e48a7bea49219da7511f

feat(std/http): add --no-dir-listing flag to file_server (#6808)

view details

Bert Belder

commit sha 3d70a2b94eac4d4032b8b11039efe6d070fa114f

upgrade: Rust crates The following crates were _not_ upgraded to avoid having multiple versions of the same crate in the dependency tree: * tokio-tungstenite v0.10.1 -> v0.11.0 * swc_common v0. 8.0 -> v0. 9.1 * swc_ecmascript v0. 1.0 -> v0. 3.0 * webpki-roots v0.19.0 -> v0.20.0 * nix v0.17.0 -> v0.18.0

view details

Benjamin Lupton

commit sha 452693256ce7b607fa0b9454b22c57748f616742

feat(std/node): add util.inspect (#6833)

view details

Nayeem Rahman

commit sha 18ec1290afcd78c61933ecb52e3ad97cf644f0d5

feat: Support file URLs in Deno.run for executable (#6994)

view details

Jarrett Helton

commit sha de4e1fbdf0d013893516479aa6e15b15d6319e38

feat: add support for --no-check flag in Deno install (#6948)

view details

Ryan Dahl

commit sha c4d9c6aa4baed5c9f4844dd5f28475e9ef2d87b0

upgrade: TypeScript to 3.9.7 (#7036)

view details

Divy Srivastava

commit sha ad4af23aba39e904ba9e2c284b6d06436b7b4f77

unify path normalization utility (#6865)

view details

Jarrett Helton

commit sha 514cbc2808754369f52c9f4baef97c16345d654b

fix: remove @ts-expect-error directives (#7024)

view details

Bartek Iwańczuk

commit sha 08ab4d46ca1860da16b5250fe3872cefbe682637

upgrade: swc, deno_lint, dprint (#7040)

view details

souldzin

commit sha d6cee706955f300086f41f9318d23631f64f036b

feat: Add "--json" flag to deno lint (#6940) Co-authored-by: JackSkylark <jdslaughter44@gmail.com>

view details

Bartek Iwańczuk

commit sha b38c3132768e0f5132763db9c8fdc2a4a9490bde

v1.3.0

view details

push time in a month

pull request commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

Looks like there is a small problem with the versioning. Specifying the version (https://deno.land/std@0.63.0/http/file_server.ts) looks like it works. I will try and get this fixed tomorrow.

KrisChambers

comment created time in a month

Pull request review commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

 fn print_cache_info(state: &GlobalState, json: bool) -> Result<(), ErrBox> {   } } -struct FileInfoOutput<'a> {-  local: &'a str,-  file_type: &'a str,-  compiled: Option<String>,-  map: Option<String>,-  deps: Option<Deps>,+/// A dependency tree of the basic module information.+///+/// Constructed from a `ModuleGraph` and `ModuleSpecifier` that+/// acts as the root of the tree.+struct FileInfoDepTree {

Sounds good.

KrisChambers

comment created time in a month

push eventKrisChambers/deno

Bartek Iwańczuk

commit sha 315efbc0e86d9d848efa4b889aefbc665508598a

fix: downcast from SwcDiagnosticBuffer to OpError (#6909)

view details

Bartek Iwańczuk

commit sha c6917133942c791480cd2aec7297b2a2ee623059

refactor: Use SWC to strip types for "--no-check" flag (#6895)

view details

Luca Casonato

commit sha 1b60840f286bc0203a3bd2900f67557a8ff2c3f6

feat(std/async): add pooledMap utility (#6898)

view details

Nayeem Rahman

commit sha 6afe7bbd395eb34febd25bda48c5cd82f0a4f8b3

fix(std/path): Percent-decode in fromFileUrl() (#6913)

view details

Kid

commit sha 391088c6ff531ac6714e9076eb62f2294793ccdd

docs(std/encoding): Fix TOML docs (#6912)

view details

zfx

commit sha 95597fc6e2ed9975c26eae77ba68ae42ca2c331a

fix(std/tar): directory type bug (#6905)

view details

Divy Srivastava

commit sha 0da4779b178a0c97925c1ef5589d0f24a37f4501

feat(unstable): add "--ignore" flag to deno fmt (#6890)

view details

Nayeem Rahman

commit sha 6e7208bec2911ac0d1729f334fc90bc50b8f9203

fix(cli/rt): Fix file URL to path conversion on Windows (#6920)

view details

Luca Casonato

commit sha 4afb4b6e46de2ed536a3c9828d70d7799b5b6d03

feat: add $STD_VERSION replacement variable in docs (#6922)

view details

Bartek Iwańczuk

commit sha b718e6ff53156a0aae486e570ce7c9cb8a3b822a

upgrade: deno_lint, dprint, swc (#6928) This commit upgrades: deno_lint 0.1.20 dprint-plugin-typescript 0.25.0 swc_ecmascript 0.1.0 SWC is no longer reexported from dprint nor deno_lint.

view details

Ryan Dahl

commit sha 7446230e6b39a0d3ce70b8fffbed3ebc63e8c762

v1.2.2

view details

Bartek Iwańczuk

commit sha d54d4d21bddf0fe80a6f534ec945c655595c5f71

upgrade: swc_ecmascript (#6943)

view details

Luca Casonato

commit sha 9d50c5c1a6fbe6895b6a63dadcba7bacaf9dd578

feat: hash file names in gen cache (#6911)

view details

Ben Stolovitz

commit sha 39693094f14ecba128c8fe9c6a1b8c0aba82fdec

Fix grammatical error in Linter documentation (#6939)

view details

Chayim Refael Friedman

commit sha e9d713c007afd31e22c9edf2b256197ed12336f2

typo (#6937)

view details

Jarrett Helton

commit sha d615ebefe2e306f2877afb40dc603f71263407d6

fix(std/toml): parser error with inline comments (#6942)

view details

Maayan Hanin

commit sha 5fc5e7b54a9fba421dfc473016625a4f592403ed

fix(cli): add support for non-UTF8 source files (#6789) Fixes: #5542

view details

Rauf Islam

commit sha 40ead6cc98ab1d02c8ca0587d24c218e81aa47b7

fix(std/encoding/toml): Add boolean support to stringify (#6941)

view details

Arseny Kruglikov

commit sha bda9f619728d2b795d5a449f5a4feb9a1e0ed14c

docs: fix some grammar mistakes in permissions.md (#6949)

view details

josephrocca

commit sha 8bacd710dbf8976c41d230b9f65c466b9fb3a488

docs: Removed unnecessary `await` (#6951)

view details

push time in a month

Pull request review commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

 fn print_cache_info(state: &GlobalState, json: bool) -> Result<(), ErrBox> {   } } -struct FileInfoOutput<'a> {-  local: &'a str,-  file_type: &'a str,-  compiled: Option<String>,-  map: Option<String>,-  deps: Option<Deps>,+/// A dependency tree of the basic module information.+///+/// Constructed from a `ModuleGraph` and `ModuleSpecifier` that+/// acts as the root of the tree.+struct FileInfoDepTree {+  name: String,+  size: usize,+  total_size: Option<usize>,+  deps: Vec<FileInfoDepTree>, } -// TODO(bartlomieju): this function de facto repeats-// whole compilation stack. Can this be done better somehow?+impl serde::Serialize for FileInfoDepTree {+  fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>+  where+    S: serde::Serializer,+  {+    let mut state = serializer.serialize_struct("FileInfoDepTree", 4)?;++    state.serialize_field("name", &self.name)?;+    if let Some(total_size) = self.total_size {+      state.serialize_field("size", &self.size)?;+      state.serialize_field("total_size", &total_size)?;+    }+    state.serialize_field("deps", &self.deps)?;+    state.end()+  }+}++impl FileInfoDepTree {+  /// Create a `FileInfoDepTree` tree from a `ModuleGraph` and the root `ModuleSpecifier`.+  pub fn new(+    module_graph: &ModuleGraph,+    root_specifier: &ModuleSpecifier,+  ) -> Self {+    let mut seen = HashSet::new();+    let mut total_sizes = HashMap::new();++    Self::cstr_helper(&mut seen, &mut total_sizes, module_graph, root_specifier)+  }++  fn cstr_helper(+    seen: &mut HashSet<String>,+    total_sizes: &mut HashMap<String, usize>,+    graph: &ModuleGraph,+    root: &ModuleSpecifier,+  ) -> Self {+    let name = root.to_string();+    let never_seen = seen.insert(name.clone());+    let file = graph.get(&name).unwrap();+    let size = file.size();+    let deps = if never_seen {+      file+        .imports+        .iter()+        .map(|import| import.resolved_specifier.clone())+        .map(|spec| Self::cstr_helper(seen, total_sizes, graph, &spec))+        .collect::<Vec<_>>()+    } else {+      vec![]+    };++    let total_size = if never_seen {+      if let Some(total_size) = total_sizes.get(&name) {+        Some(total_size.to_owned())+      } else {

Sounds good. Thanks for the review.

KrisChambers

comment created time in a month

Pull request review commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

 fn print_cache_info(state: &GlobalState, json: bool) -> Result<(), ErrBox> {   } } -struct FileInfoOutput<'a> {-  local: &'a str,-  file_type: &'a str,-  compiled: Option<String>,-  map: Option<String>,-  deps: Option<Deps>,+/// A dependency tree of the basic module information.+///+/// Constructed from a `ModuleGraph` and `ModuleSpecifier` that+/// acts as the root of the tree.+struct FileInfoDepTree {

This was the original implementation. It was pointed out that there is a fair amount of redundancies in the JSON output that was removed in the console output. So I opted to remove these in a custom implementation of the serialize trait.

Alternatively, assuming the JSON is to be consumed by something else, it was suggested to just output the adjacency list from the graph with node metadata containing sizes and letting consumers choose how they want to use that size data.

Here is the comment: https://github.com/denoland/deno/pull/6786#issuecomment-663913828_

KrisChambers

comment created time in a month

Pull request review commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

 fn print_cache_info(state: &GlobalState, json: bool) -> Result<(), ErrBox> {   } } -struct FileInfoOutput<'a> {-  local: &'a str,-  file_type: &'a str,-  compiled: Option<String>,-  map: Option<String>,-  deps: Option<Deps>,+/// A dependency tree of the basic module information.+///+/// Constructed from a `ModuleGraph` and `ModuleSpecifier` that+/// acts as the root of the tree.+struct FileInfoDepTree {+  name: String,+  size: usize,+  total_size: Option<usize>,+  deps: Vec<FileInfoDepTree>, } -// TODO(bartlomieju): this function de facto repeats-// whole compilation stack. Can this be done better somehow?+impl serde::Serialize for FileInfoDepTree {+  fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>+  where+    S: serde::Serializer,+  {+    let mut state = serializer.serialize_struct("FileInfoDepTree", 4)?;++    state.serialize_field("name", &self.name)?;+    if let Some(total_size) = self.total_size {+      state.serialize_field("size", &self.size)?;+      state.serialize_field("total_size", &total_size)?;+    }+    state.serialize_field("deps", &self.deps)?;+    state.end()+  }+}++impl FileInfoDepTree {+  /// Create a `FileInfoDepTree` tree from a `ModuleGraph` and the root `ModuleSpecifier`.+  pub fn new(+    module_graph: &ModuleGraph,+    root_specifier: &ModuleSpecifier,+  ) -> Self {+    let mut seen = HashSet::new();+    let mut total_sizes = HashMap::new();++    Self::cstr_helper(&mut seen, &mut total_sizes, module_graph, root_specifier)+  }++  fn cstr_helper(+    seen: &mut HashSet<String>,+    total_sizes: &mut HashMap<String, usize>,+    graph: &ModuleGraph,+    root: &ModuleSpecifier,+  ) -> Self {+    let name = root.to_string();+    let never_seen = seen.insert(name.clone());+    let file = graph.get(&name).unwrap();+    let size = file.size();+    let deps = if never_seen {+      file+        .imports+        .iter()+        .map(|import| import.resolved_specifier.clone())+        .map(|spec| Self::cstr_helper(seen, total_sizes, graph, &spec))+        .collect::<Vec<_>>()+    } else {+      vec![]+    };++    let total_size = if never_seen {+      if let Some(total_size) = total_sizes.get(&name) {+        Some(total_size.to_owned())+      } else {+        let total: usize = deps+          .iter()+          .map(|dep| {+            if let Some(total_size) = dep.total_size {+              total_size+            } else {+              0+            }+          })+          .sum();+        let total = size + total;++        total_sizes.insert(name.clone(), total);++        Some(total)+      }+    } else {+      None+    };++    Self {+      name,+      size,+      total_size,+      deps,+    }+  }+}++/// Prints the provided `ModuleSpecifier` file info. async fn print_file_info(   worker: &MainWorker,   module_specifier: ModuleSpecifier,   json: bool, ) -> Result<(), ErrBox> {   let global_state = worker.state.borrow().global_state.clone();--  let out = global_state-    .file_fetcher+  let ts_compiler = &global_state.ts_compiler;+  let file_fetcher = &global_state.file_fetcher;+  let out = file_fetcher     .fetch_source_file(&module_specifier, None, Permissions::allow_all())     .await?;--  let mut output = FileInfoOutput {-    local: out.filename.to_str().unwrap(),-    file_type: msg::enum_name_media_type(out.media_type),-    compiled: None,-    map: None,-    deps: None,-  };--  let module_specifier_ = module_specifier.clone();--  global_state-    .prepare_module_load(-      module_specifier_.clone(),-      None,-      TargetLib::Main,-      Permissions::allow_all(),-      false,-      global_state.maybe_import_map.clone(),-    )-    .await?;-  global_state-    .clone()-    .fetch_compiled_module(module_specifier_, None)-    .await?;--  if out.media_type == msg::MediaType::TypeScript-    || (out.media_type == msg::MediaType::JavaScript-      && global_state.ts_compiler.compile_js)-  {-    let compiled_source_file = global_state-      .ts_compiler-      .get_compiled_source_file(&out.url)-      .unwrap();-    output.compiled =-      compiled_source_file.filename.to_str().map(|s| s.to_owned());-  }--  if let Ok(source_map) = global_state-    .clone()-    .ts_compiler+  let local = out.filename.to_str().unwrap();+  let file_type = msg::enum_name_media_type(out.media_type);+  let compiled: Option<String> = ts_compiler+    .get_compiled_source_file(&out.url)+    .ok()+    .and_then(get_source_filename);

Ahh ok. I will add a test for this case and fix it.

KrisChambers

comment created time in a month

Pull request review commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

 fn print_cache_info(state: &GlobalState, json: bool) -> Result<(), ErrBox> {   } } -struct FileInfoOutput<'a> {-  local: &'a str,-  file_type: &'a str,-  compiled: Option<String>,-  map: Option<String>,-  deps: Option<Deps>,+/// A dependency tree of the basic module information.+///+/// Constructed from a `ModuleGraph` and `ModuleSpecifier` that+/// acts as the root of the tree.+struct FileInfoDepTree {+  name: String,+  size: usize,+  total_size: Option<usize>,+  deps: Vec<FileInfoDepTree>, } -// TODO(bartlomieju): this function de facto repeats-// whole compilation stack. Can this be done better somehow?+impl serde::Serialize for FileInfoDepTree {+  fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>+  where+    S: serde::Serializer,+  {+    let mut state = serializer.serialize_struct("FileInfoDepTree", 4)?;++    state.serialize_field("name", &self.name)?;+    if let Some(total_size) = self.total_size {+      state.serialize_field("size", &self.size)?;+      state.serialize_field("total_size", &total_size)?;+    }+    state.serialize_field("deps", &self.deps)?;+    state.end()+  }+}++impl FileInfoDepTree {+  /// Create a `FileInfoDepTree` tree from a `ModuleGraph` and the root `ModuleSpecifier`.+  pub fn new(+    module_graph: &ModuleGraph,+    root_specifier: &ModuleSpecifier,+  ) -> Self {+    let mut seen = HashSet::new();+    let mut total_sizes = HashMap::new();++    Self::cstr_helper(&mut seen, &mut total_sizes, module_graph, root_specifier)+  }++  fn cstr_helper(+    seen: &mut HashSet<String>,+    total_sizes: &mut HashMap<String, usize>,+    graph: &ModuleGraph,+    root: &ModuleSpecifier,+  ) -> Self {+    let name = root.to_string();+    let never_seen = seen.insert(name.clone());+    let file = graph.get(&name).unwrap();+    let size = file.size();+    let deps = if never_seen {+      file+        .imports+        .iter()+        .map(|import| import.resolved_specifier.clone())+        .map(|spec| Self::cstr_helper(seen, total_sizes, graph, &spec))+        .collect::<Vec<_>>()+    } else {+      vec![]+    };++    let total_size = if never_seen {+      if let Some(total_size) = total_sizes.get(&name) {+        Some(total_size.to_owned())+      } else {+        let total: usize = deps+          .iter()+          .map(|dep| {+            if let Some(total_size) = dep.total_size {+              total_size+            } else {+              0+            }+          })+          .sum();+        let total = size + total;++        total_sizes.insert(name.clone(), total);++        Some(total)+      }+    } else {+      None+    };++    Self {+      name,+      size,+      total_size,+      deps,+    }+  }+}++/// Prints the provided `ModuleSpecifier` file info. async fn print_file_info(   worker: &MainWorker,   module_specifier: ModuleSpecifier,   json: bool, ) -> Result<(), ErrBox> {   let global_state = worker.state.borrow().global_state.clone();--  let out = global_state-    .file_fetcher+  let ts_compiler = &global_state.ts_compiler;+  let file_fetcher = &global_state.file_fetcher;+  let out = file_fetcher     .fetch_source_file(&module_specifier, None, Permissions::allow_all())     .await?;--  let mut output = FileInfoOutput {-    local: out.filename.to_str().unwrap(),-    file_type: msg::enum_name_media_type(out.media_type),-    compiled: None,-    map: None,-    deps: None,-  };--  let module_specifier_ = module_specifier.clone();--  global_state-    .prepare_module_load(-      module_specifier_.clone(),-      None,-      TargetLib::Main,-      Permissions::allow_all(),-      false,-      global_state.maybe_import_map.clone(),-    )-    .await?;-  global_state-    .clone()-    .fetch_compiled_module(module_specifier_, None)-    .await?;--  if out.media_type == msg::MediaType::TypeScript-    || (out.media_type == msg::MediaType::JavaScript-      && global_state.ts_compiler.compile_js)-  {-    let compiled_source_file = global_state-      .ts_compiler-      .get_compiled_source_file(&out.url)-      .unwrap();-    output.compiled =-      compiled_source_file.filename.to_str().map(|s| s.to_owned());-  }--  if let Ok(source_map) = global_state-    .clone()-    .ts_compiler+  let local = out.filename.to_str().unwrap();+  let file_type = msg::enum_name_media_type(out.media_type);+  let compiled: Option<String> = ts_compiler+    .get_compiled_source_file(&out.url)+    .ok()+    .and_then(get_source_filename);+  let map: Option<String> = ts_compiler     .get_source_map_file(&module_specifier)-  {-    output.map = source_map.filename.to_str().map(|s| s.to_owned());-  }-  let es_state_rc = EsIsolate::state(&worker.isolate);-  let es_state = es_state_rc.borrow();--  if let Some(deps) = es_state.modules.deps(&module_specifier) {-    output.deps = Some(deps);-  }+    .ok()+    .and_then(get_source_filename);+  let module_graph = get_module_graph(&global_state, &module_specifier).await?;+  let file_info = FileInfoDepTree::new(&module_graph, &module_specifier);    if json {     let output = json!({-      "local": output.local,-      "fileType": output.file_type,-      "compiled": output.compiled,-      "map": output.map,-      "deps": output.deps.map(|x| x.to_json())+      "local": local,+      "fileType": file_type,+      "compiled": compiled,+      "map": map,+      "deps": file_info     });     write_json_to_stdout(&output)   } else {-    println!("{} {}", colors::bold("local:"), output.local);-    println!("{} {}", colors::bold("type:"), output.file_type);-    if let Some(compiled) = output.compiled {+    println!("{} {}", colors::bold("local:"), local);+    println!("{} {}", colors::bold("type:"), file_type);+    if let Some(compiled) = compiled {       println!("{} {}", colors::bold("compiled:"), compiled);     }-    if let Some(map) = output.map {+    if let Some(map) = map {       println!("{} {}", colors::bold("map:"), map);     }-    if let Some(deps) = output.deps {-      println!("{}{}", colors::bold("deps:\n"), deps.name);-      if let Some(ref depsdeps) = deps.deps {-        for d in depsdeps {-          println!("{}", d);-        }-      }-    } else {-      println!(-        "{} cannot retrieve full dependency graph",-        colors::bold("deps:"),-      );++    println!(+      "{} {} unique",+      colors::bold("deps:"),+      &module_graph.len() - 1+    );+    println!(+      "{} ({}, total = {})",+      file_info.name,+      human_size(file_info.size as f64),+      human_size(file_info.total_size.unwrap() as f64)+    );++    for (idx, dep) in file_info.deps.iter().enumerate() {+      print_file_dep_info(&dep, "  ", idx == file_info.deps.len() - 1);     }+     Ok(())   } } +/// Prints the `FileInfoDepTree` tree to stdout.+fn print_file_dep_info(info: &FileInfoDepTree, prefix: &str, is_last: bool) {+  print_dep(prefix, is_last, info);++  let prefix = &get_new_prefix(prefix, is_last);+  let child_count = info.deps.len();+  for (idx, dep) in info.deps.iter().enumerate() {+    print_file_dep_info(dep, prefix, idx == child_count - 1);+  }+}++/// Prints a single `FileInfoDepTree` to stdout.+fn print_dep(prefix: &str, is_last: bool, info: &FileInfoDepTree) {+  let has_children = !info.deps.is_empty();++  println!(+    "{}{}─{} {}{}",+    prefix,+    get_sibling_connector(is_last),+    get_child_connector(has_children),+    info.name,+    get_formatted_totals(info)+  );+}++/// Gets the formatted totals for the provided `FileInfoDepTree`.+///+/// If the total size is reported as 0 then an empty string is returned.+fn get_formatted_totals(info: &FileInfoDepTree) -> String {+  if let Some(total_size) = info.total_size {+    format!(+      " ({}, total = {})",+      human_size(info.size as f64),+      human_size(total_size as f64)+    )+  } else {+    "".to_string()+  }+}++/// Gets the sibling portion of the tree branch.+fn get_sibling_connector(is_last: bool) -> char {+  if is_last {+    '└'+  } else {+    '├'+  }+}++/// Gets the child connector for the branch.+fn get_child_connector(has_children: bool) -> char {+  if has_children {+    '┬'+  } else {+    '─'+  }+}++/// Creates a new prefix for a dependency tree item.+fn get_new_prefix(prefix: &str, is_last: bool) -> String {+  let mut prefix = prefix.to_string();+  if is_last {+    prefix.push(' ');+  } else {+    prefix.push('│');+  }++  prefix.push(' ');+  prefix+}

Yes. I used Deps as a reference for the printing of the readable tree.

KrisChambers

comment created time in a month

starteddotnet/roslyn

started time in 2 months

pull request commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

No problem, @bartlomieju. Let me know if you have any thoughts regarding the json format.

KrisChambers

comment created time in 2 months

push eventKrisChambers/deno

Trivikram Kamat

commit sha 017aa1ca1b63f08bd251ef3bd0fc6b540d2b5fdd

chore: remove TODO about manual JSON parsing (#6878)

view details

Mark Tiedemann

commit sha 9f3ab4dca7ed5c810352b67fce24aa800defc5a6

Shorten Windows file description (#6881)

view details

Trivikram Kamat

commit sha 35a1421fb1b8407a13e33081ad2dbc05460e7452

chore: use ts-expect-error instead of ts-ignore (#6876)

view details

Jordan Cannon

commit sha 3b7fdd6734c4f1dbc34b0971296464395dc173bf

Fix typo (#6872)

view details

Marcin Puc

commit sha 7326e1ab490aab2220b139460165be0bfbf04f36

fix(std/json): Add newline at the end of json files (#6885)

view details

Trivikram Kamat

commit sha c8fc679329f45f50c061a67400e572f356b7890f

test(std): remove unstable from multiple tests (#6882)

view details

Trivikram Kamat

commit sha ccd0d0eb79db6ad33095ca06e9d491a27379b87a

chore(ci): update actions to run on macos-10.15 (#6884)

view details

Kitson Kelly

commit sha 076547fbbb52b1df9d6db36dd72353bffa9e4a8b

chore: use matches macro for bool matches (#6904)

view details

Ryan Dahl

commit sha b7942bf0f6f151e172db9b1e08cf4436e8365e8b

Change release build flags to optimize for size (#6907)

view details

Kris Chambers

commit sha d03a45f8de349153fcb631517932bc0a11a48fba

Add function for getting size in bytes.

view details

Kris Chambers

commit sha a84c8341df62057a66e4c9fef850f04aa57040db

Modify print_file_info to output file sizes

view details

Kris Chambers

commit sha 2ef22e6b75e9c6ec63a45dd32d1c405d1fde9ccf

Refactor into a graph transformation for better readability

view details

Kris Chambers

commit sha f6cefa5195c9c881762b644aca4ae89755bba854

Fix naming and add comments

view details

Kris Chambers

commit sha 2a23cb002bc7baab3c17f0cd1305bd4886a96b87

Add size as a property of ModuleGraphFile

view details

Kris Chambers

commit sha 6c30a22dc9808404aad2c36b18cf89b95fee2a47

Add output for --json flag

view details

Kris Chambers

commit sha bbf01e180b7a079dec0bea09cf3e9a02d6ae3d8b

Replace size property with associated function

view details

Kris Chambers

commit sha 09be0c354173060a0d7e48a154c852c006a19ba8

Clean up and fmt

view details

Kris Chambers

commit sha 74f05a1a3809de9ccaeddbb77b78ff2e98b45153

Add function for formatting totals

view details

Kris Chambers

commit sha 275687217c3ef968801c58d6aa424b2386dd5b57

Clean up and Format.

view details

Kris Chambers

commit sha a611d38d263fd50b4bd078296a187818dc1b47b2

Fix failing tests.

view details

push time in 2 months

push eventKrisChambers/deno

Nayeem Rahman

commit sha b61347b2552cb7159ee3e82c5e9ca5a76e73c3f8

fix(cli/js/ops/fs_events): Ignore polling errors caused by return() (#6785)

view details

Nayeem Rahman

commit sha a8f74aa381c99e9c3c3d8fdfde02919966a3a824

fix: Improve URL compatibility (#6807) - Fix protocol regex. - Truncate repeated leading slashes in file paths. - Make drive letter support platform-independent. - Drop the hostname if a drive letter is parsed. - Fix drive letter normalization and basing. - Allow basing over the host. - Fix same-protocol basing. - Remove Windows UNC path support. - Reverts #6418. This is non-standard. Wouldn't be too much of a problem but it makes other parts of the spec hard to realize.

view details

迷渡

commit sha 836ce3a9a6e050cae50593de65f17772af01b65d

chore: mark typescript.js and type definitions as vendored (#6863)

view details

Ryan Dahl

commit sha 25a0ad3e16e767d58b1315e9d12a236ea36c5998

v1.2.1

view details

Ryan Dahl

commit sha f162ced76aa475a20a17411510d185c994a25425

Remove deno_typescript references from ci (#6866)

view details

Bartek Iwańczuk

commit sha b45f9a7357fad1d13c2fbffa5e419e064a3aa89f

fix: deno-types directive should have higher precedence than X-TypeScript-Types header (#6761)

view details

Bartek Iwańczuk

commit sha 69552b1defcd77748de87fc4c9311b1baec1361d

upgrade: deno_lint v0.1.17 (#6869)

view details

Trivikram Kamat

commit sha 017aa1ca1b63f08bd251ef3bd0fc6b540d2b5fdd

chore: remove TODO about manual JSON parsing (#6878)

view details

Mark Tiedemann

commit sha 9f3ab4dca7ed5c810352b67fce24aa800defc5a6

Shorten Windows file description (#6881)

view details

Trivikram Kamat

commit sha 35a1421fb1b8407a13e33081ad2dbc05460e7452

chore: use ts-expect-error instead of ts-ignore (#6876)

view details

Jordan Cannon

commit sha 3b7fdd6734c4f1dbc34b0971296464395dc173bf

Fix typo (#6872)

view details

Marcin Puc

commit sha 7326e1ab490aab2220b139460165be0bfbf04f36

fix(std/json): Add newline at the end of json files (#6885)

view details

Trivikram Kamat

commit sha c8fc679329f45f50c061a67400e572f356b7890f

test(std): remove unstable from multiple tests (#6882)

view details

Trivikram Kamat

commit sha ccd0d0eb79db6ad33095ca06e9d491a27379b87a

chore(ci): update actions to run on macos-10.15 (#6884)

view details

Kitson Kelly

commit sha 076547fbbb52b1df9d6db36dd72353bffa9e4a8b

chore: use matches macro for bool matches (#6904)

view details

Ryan Dahl

commit sha b7942bf0f6f151e172db9b1e08cf4436e8365e8b

Change release build flags to optimize for size (#6907)

view details

push time in 2 months

issue openedmicrosoft/vscode

--inspect-brk not being passed to the command.

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.47.1
  • OS Version: Manjaro Lysia 20.0.3

Steps to Reproduce:

I outlined the problems here: https://github.com/denoland/deno/issues/6855#issuecomment-663355253

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

I know this isn't a node specific issue, but Deno uses the node launch configuration in vscode. I have not checked that this is an issue when not using "deno" as the runtime executable, but I will do a little test later to confirm that.

As I state in the linked issue. It looks like --inspect-brk is being eaten up somewhere when launched.

created time in 2 months

pull request commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

I agree there is a bunch of duplicated information here. A recent push has some of it removed similar to what is going on in the standard deno info output.

I like your idea. Instead of using the tree structure we could just provide the adjacency list of the ModuleGraph. So it would end up looking something like:

{
...
"deps": {
    "self": ["mod1", "mod2"],
    "mod1": ["mod3", "mod4"],
    "mod2": ["mod4"],
    "mod3: [],
    "mod4": ["mod2"]
},

"metadata": {
   "self": {
       "size": ...
    } ,
   ...
}
}

If we wanted to go a bit further down the rabbit hole, we could use numeric ids and even put name in the metadata.

{
...
"adjlist": {
    0: [1, 2],
    1: [3, 4],
    2: [4],
    3: [],
    4: [2]
},

"metadata": {
   0: {
       "name": "self",
       "size": ...
    } ,
   1: { ... },
   ...
}
}
KrisChambers

comment created time in 2 months

push eventKrisChambers/deno

Nayeem Rahman

commit sha b61347b2552cb7159ee3e82c5e9ca5a76e73c3f8

fix(cli/js/ops/fs_events): Ignore polling errors caused by return() (#6785)

view details

Nayeem Rahman

commit sha a8f74aa381c99e9c3c3d8fdfde02919966a3a824

fix: Improve URL compatibility (#6807) - Fix protocol regex. - Truncate repeated leading slashes in file paths. - Make drive letter support platform-independent. - Drop the hostname if a drive letter is parsed. - Fix drive letter normalization and basing. - Allow basing over the host. - Fix same-protocol basing. - Remove Windows UNC path support. - Reverts #6418. This is non-standard. Wouldn't be too much of a problem but it makes other parts of the spec hard to realize.

view details

迷渡

commit sha 836ce3a9a6e050cae50593de65f17772af01b65d

chore: mark typescript.js and type definitions as vendored (#6863)

view details

Ryan Dahl

commit sha 25a0ad3e16e767d58b1315e9d12a236ea36c5998

v1.2.1

view details

Ryan Dahl

commit sha f162ced76aa475a20a17411510d185c994a25425

Remove deno_typescript references from ci (#6866)

view details

Bartek Iwańczuk

commit sha b45f9a7357fad1d13c2fbffa5e419e064a3aa89f

fix: deno-types directive should have higher precedence than X-TypeScript-Types header (#6761)

view details

Bartek Iwańczuk

commit sha 69552b1defcd77748de87fc4c9311b1baec1361d

upgrade: deno_lint v0.1.17 (#6869)

view details

Kris Chambers

commit sha 3330a0b126604baf1193f6672064699e99b46b95

Add function for getting size in bytes.

view details

Kris Chambers

commit sha 0df6985e9018e4118033657f00eeca749f87f8de

Modify print_file_info to output file sizes

view details

Kris Chambers

commit sha f0599896c2db09a6953b23f5c25d7f5416676bba

Refactor into a graph transformation for better readability

view details

Kris Chambers

commit sha 1348621b2464139d025741187dc49b13579e9335

Fix naming and add comments

view details

Kris Chambers

commit sha 7d2432a036370d70c142056f8ea9c8093912d079

Add size as a property of ModuleGraphFile

view details

Kris Chambers

commit sha 1d73ec63fd8fdece5f7041333225d9edf4bd433d

Add output for --json flag

view details

Kris Chambers

commit sha cc69c2905a5397b803218547644bffabb4e27857

Replace size property with associated function

view details

Kris Chambers

commit sha 439d9ee965691fd2bdf53493c5719df2374ad39b

Clean up and fmt

view details

Kris Chambers

commit sha 3fbaf2e71f8771b6674d228f0695716ce58e4374

Add function for formatting totals

view details

Kris Chambers

commit sha ae2a85a69c7e7ff0079ec2b66ea3945d1e722e84

Clean up and Format.

view details

Kris Chambers

commit sha c02a02668264737ec38f2db251296eab1557f263

Fix failing tests.

view details

Kris Chambers

commit sha 2315543fa70dfcb57adb3bd8d59b568f1b400874

Add recursive module example.

view details

Kris Chambers

commit sha 3da80e5d3311e581d31a4aa67680f498f6398d2a

Add integration test for when dependencies are repeated.

view details

push time in 2 months

issue commentdenoland/deno

--inspect-brk Always get Outbound Breakpoint Result

Can confirm this is happening on my end as well.

Small test case

main.ts:

function A() {
   console.log("Hello, World")
}
A();

launch.json:

{
    "version": "0.2.0",
    "configurations": [
      {
        "name": "Deno",
        "type": "node",
        "request": "launch",
        "cwd": "${workspaceFolder}",
        "runtimeExecutable": "deno",
        "runtimeArgs": ["run", "--inspect-brk", "${workspaceFolder}/main.ts"],
        "port": 9229,
        "console": "integratedTerminal"
      }
    ]
  }

The --inspect-brk flag is not present in the command when launched from vscode (seen in the above photo). If --inspect-brk is replaced with just --inspect then the --inspect flag is present and the debugger appears to activate as indicated by a "Debugger listening on ws://...." message.

Dropping a break point on line 4, executing deno run --inspect-brk main.ts in the shell, and opening chrome://inspect breaks the program as expected.

Disabling vscode_deno extension doesn't fix anything.

Possibly a VSCode issue. There are a few bugs regarding the debugging situation since the most recent update: https://github.com/microsoft/vscode/issues/103205#issue-664781193

Looks like the --inspect-brk flag might be getting eaten up by something...

gungunfebrianza

comment created time in 2 months

pull request commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

To summarize the changes in this pull request:

  1. Switched the implementation to be based off ModuleGraph in the deno.cli instead of Deps in deno.core. Left Deps untouched.
  2. The standard output looks as follows:
local: /home/k/Code/deno/cli/tests/info_recursive_imports_test.ts
type: TypeScript
compiled: /home/k/.cache/deno/gen/file/home/k/Code/deno/cli/tests/info_recursive_imports_test.ts.js
deps: 4 unique
file:///home/k/Code/deno/cli/tests/info_recursive_imports_test.ts (87 Bytes, total = 481 Bytes)
  └─┬ file:///home/k/Code/deno/cli/tests/recursive_imports/A.ts (114 Bytes, total = 394 Bytes)
    ├─┬ file:///home/k/Code/deno/cli/tests/recursive_imports/B.ts (114 Bytes, total = 280 Bytes)
    │ ├─┬ file:///home/k/Code/deno/cli/tests/recursive_imports/C.ts (132 Bytes, total = 166 Bytes)
    │ │ ├── file:///home/k/Code/deno/cli/tests/recursive_imports/A.ts
    │ │ └── file:///home/k/Code/deno/cli/tests/recursive_imports/common.ts (34 Bytes, total = 34 Bytes)
    │ └── file:///home/k/Code/deno/cli/tests/recursive_imports/common.ts
    └── file:///home/k/Code/deno/cli/tests/recursive_imports/common.ts

Where lines without totals reported are duplicates that occur earlier in the tree.

  1. To accommodate values in the json output the schema is modified to look like the following:
{
  "local": "/home/k/Code/deno/cli/tests/info_recursive_imports_test.ts",
  "fileType": "TypeScript",
  "compiled": "/home/k/.cache/deno/gen/file/home/k/Code/deno/cli/tests/info_recursive_imports_test.ts.js",
  "map": null,
  "deps": {
    "name": "file:///home/k/Code/deno/cli/tests/info_recursive_imports_test.ts",
    "size": 87,
    "total_size": 481,
    "deps": [
      {
        "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/A.ts",
        "size": 114,
        "total_size": 394,
        "deps": [
          {
            "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/B.ts",
            "size": 114,
            "total_size": 280,
            "deps": [
              {
                "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/C.ts",
                "size": 132,
                "total_size": 166,
                "deps": [
                  {
                    "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/A.ts",
                    "size": 114,
                    "total_size": 0,
                    "deps": []
                  },
                  {
                    "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/common.ts",
                    "size": 34,
                    "total_size": 34,
                    "deps": []
                  }
                ]
              },
              {
                "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/common.ts",
                "size": 34,
                "total_size": 0,
                "deps": []
              }
            ]
          },
          {
            "name": "file:///home/k/Code/deno/cli/tests/recursive_imports/common.ts",
            "size": 34,
            "total_size": 0,
            "deps": []
          }
        ]
      }
    ]
  }
}
KrisChambers

comment created time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha 7681609347fd0e0fc97666d8dfb0ecb74e60852c

Fix lint error

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha 72c934893ef900ac8345040a3942524a977bdfef

Fix linting issues.

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha 0abc047ee3cec37ffaf8c75f79784f2b754c0e0c

Fix test for windows paths

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha fd083ddba4d16872e595de1912da2cefcb1b2d67

Fix lint problems.

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha 0b9a4ca757e81cb3ce10328df811bd2ef39ac305

Fix typescript linting issues.

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha c4c1a4cffb8da51434536b3f35583d309eeaa187

Fix lint issues.

view details

push time in 2 months

push eventKrisChambers/deno

Bartek Iwańczuk

commit sha da48fa42d309e32684210a8d30ec3fc7ef7079df

chore: update Rust to 1.45.0 (#6791)

view details

Luca Casonato

commit sha 071a6e284aaaa26d40300b82d9f4cbb15a4dd6f5

Share reqwest client between fetch calls (#6792)

view details

sonota88

commit sha aebea6bd24dc1788c6db2f58204177af1c5d2dd6

doc(std/bytes): Fix wrong import in the example code (copyBytes) (#6787)

view details

Bert Belder

commit sha faa64edaf409757549a7df85812f6ea4f368051c

Upgrade to rusty_v8 0.7.0 (#6801)

view details

Jason Miller

commit sha c587450cd458514d8ae17d1fb649b1d36bb4649e

typo (#6800)

view details

木杉

commit sha 53adde866dd399aa2509d14508642fce37afb8f5

refactor(std/path): enrich the types in parse_format_test (#6803)

view details

Bartek Iwańczuk

commit sha fa61956f03491101b6ef64423ea2f1f73af26a73

Port internal TS code to JS (#6793) Co-authored-by: Ryan Dahl <ry@tinyclouds.org>

view details

Ryan Dahl

commit sha 628c10b55259f9d2b215b4203c2228062da189dc

fix benchmark_test (#6814)

view details

crowlKats

commit sha 903d28f872b90a800c64339dea058806cde0be67

Remove duplicate code and allow filename overwrite for DomFile (#6817)

view details

Ryan Dahl

commit sha 2460689b1a9582ef6ab8c5fa429e281c88bc14d1

Remove deno_typescript (#6813)

view details

木杉

commit sha f34a441a7d3e3e5c1517207a1ee2ed2a0eaee0c9

fix(tools/lint): don't exceed max command line length on windows (#6804)

view details

crowlKats

commit sha 9d13b539b5dfc96e2b5a0e89fc8e0312d6500fff

Fix lastModified for DomFile in FormData (#6830)

view details

Ryan Dahl

commit sha bf9930066d3a5d26baad22fb1766de26be49c2ae

Reduce size of TypeScript Compiler snapshot (#6809) This PR is intentionally ugly. It duplicates all of the code in cli/js2/ into cli/tsc/ ... because it's very important that we all understand that this code is unnecessarily duplicated in our binary. I hope this ugliness provides the motivation to clean it up. The typescript git submodule is removed, because it's a very large repo and contains all sorts of stuff we don't need. Instead the necessary files are copied directly into the deno repo. Hence +200k lines. COMPILER_SNAPSHOT.bin size ``` master 3448139 this branch 3320972 ``` Fixes #6812

view details

David Sherret

commit sha a28e153a12a1c78a0a048b290b82b92a1a971cd1

Use incremental formatting internally for dprint (#6815)

view details

Ryan Dahl

commit sha 69706331a590edceb49eae58835abd54b39878c2

clean up set_binary_metadata (#6811)

view details

Ryan Dahl

commit sha f8695b493dff3c4daee6e9f6b948a55810d2d0fa

Add web APIs to cli/js2/README.md (#6842)

view details

Casper Beyer

commit sha 587eefe7736efe70532124ca4ac93899f4ffbb8c

test(cli/unit): remove rogue console.log statement (#6846)

view details

Bartek Iwańczuk

commit sha b573bbe4471c3872f96e1d7b9d1d1a2b39ff4cf1

upgrade: tokio 0.2.22 (#6838)

view details

Casper Beyer

commit sha 843b54549c04337f18c62d1daf159a79865de6b7

BREAKING(std/fs): remove writeFileStr and writeFileStrSync (#6847) This removes the writeFileStr and writeFileStrSync functions which are effectivly duplicates of Deno.writeTextFile and Deno.writeTextFileSync.

view details

Casper Beyer

commit sha fd900cfe215e919392941b39b57a16b4a9976eec

BREAKING(std/fs): remove readFileStr and readFileStrSync (#6848) This removes the readFileStr and readFileStrSync functions which are effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.

view details

push time in 2 months

push eventKrisChambers/deno

Bartek Iwańczuk

commit sha da48fa42d309e32684210a8d30ec3fc7ef7079df

chore: update Rust to 1.45.0 (#6791)

view details

Luca Casonato

commit sha 071a6e284aaaa26d40300b82d9f4cbb15a4dd6f5

Share reqwest client between fetch calls (#6792)

view details

sonota88

commit sha aebea6bd24dc1788c6db2f58204177af1c5d2dd6

doc(std/bytes): Fix wrong import in the example code (copyBytes) (#6787)

view details

Bert Belder

commit sha faa64edaf409757549a7df85812f6ea4f368051c

Upgrade to rusty_v8 0.7.0 (#6801)

view details

Jason Miller

commit sha c587450cd458514d8ae17d1fb649b1d36bb4649e

typo (#6800)

view details

木杉

commit sha 53adde866dd399aa2509d14508642fce37afb8f5

refactor(std/path): enrich the types in parse_format_test (#6803)

view details

Bartek Iwańczuk

commit sha fa61956f03491101b6ef64423ea2f1f73af26a73

Port internal TS code to JS (#6793) Co-authored-by: Ryan Dahl <ry@tinyclouds.org>

view details

Ryan Dahl

commit sha 628c10b55259f9d2b215b4203c2228062da189dc

fix benchmark_test (#6814)

view details

crowlKats

commit sha 903d28f872b90a800c64339dea058806cde0be67

Remove duplicate code and allow filename overwrite for DomFile (#6817)

view details

Ryan Dahl

commit sha 2460689b1a9582ef6ab8c5fa429e281c88bc14d1

Remove deno_typescript (#6813)

view details

木杉

commit sha f34a441a7d3e3e5c1517207a1ee2ed2a0eaee0c9

fix(tools/lint): don't exceed max command line length on windows (#6804)

view details

crowlKats

commit sha 9d13b539b5dfc96e2b5a0e89fc8e0312d6500fff

Fix lastModified for DomFile in FormData (#6830)

view details

Ryan Dahl

commit sha bf9930066d3a5d26baad22fb1766de26be49c2ae

Reduce size of TypeScript Compiler snapshot (#6809) This PR is intentionally ugly. It duplicates all of the code in cli/js2/ into cli/tsc/ ... because it's very important that we all understand that this code is unnecessarily duplicated in our binary. I hope this ugliness provides the motivation to clean it up. The typescript git submodule is removed, because it's a very large repo and contains all sorts of stuff we don't need. Instead the necessary files are copied directly into the deno repo. Hence +200k lines. COMPILER_SNAPSHOT.bin size ``` master 3448139 this branch 3320972 ``` Fixes #6812

view details

David Sherret

commit sha a28e153a12a1c78a0a048b290b82b92a1a971cd1

Use incremental formatting internally for dprint (#6815)

view details

Ryan Dahl

commit sha 69706331a590edceb49eae58835abd54b39878c2

clean up set_binary_metadata (#6811)

view details

Ryan Dahl

commit sha f8695b493dff3c4daee6e9f6b948a55810d2d0fa

Add web APIs to cli/js2/README.md (#6842)

view details

Casper Beyer

commit sha 587eefe7736efe70532124ca4ac93899f4ffbb8c

test(cli/unit): remove rogue console.log statement (#6846)

view details

Bartek Iwańczuk

commit sha b573bbe4471c3872f96e1d7b9d1d1a2b39ff4cf1

upgrade: tokio 0.2.22 (#6838)

view details

Casper Beyer

commit sha 843b54549c04337f18c62d1daf159a79865de6b7

BREAKING(std/fs): remove writeFileStr and writeFileStrSync (#6847) This removes the writeFileStr and writeFileStrSync functions which are effectivly duplicates of Deno.writeTextFile and Deno.writeTextFileSync.

view details

Casper Beyer

commit sha fd900cfe215e919392941b39b57a16b4a9976eec

BREAKING(std/fs): remove readFileStr and readFileStrSync (#6848) This removes the readFileStr and readFileStrSync functions which are effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.

view details

push time in 2 months

PublicEvent

push eventKrisChambers/deno

Kris Chambers

commit sha c01b69072e167f29783ab8d1c4262f52eacbbcfd

Add function for formatting totals

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha 6a326da365dad976f1f7a4d4f78fc3f529e9600d

Add function to handle formatting totals

view details

push time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha a43376246f8ac673aab00521f66f541ee51e8763

Replace size property with associated function

view details

Kris Chambers

commit sha 26d240b33aebaa3fe27ec587e92ead574bb1eefa

Clean up and fmt

view details

push time in 2 months

startedKrisChambers/deno-result

started time in 2 months

startedKrisChambers/Chip-8

started time in 2 months

pull request commentdenoland/deno

Feature: Dependency count and module sizes for `deno info`. Feedback wanted.

Thanks for your feedback @cknight. I like the idea of putting some indicator on the end. I think you are right though, and for now I might just bold the ones that are contributing to the size just for a little extra pop.

Do you have any suggestion / idea regarding the JSON output?

KrisChambers

comment created time in 2 months

push eventKrisChambers/deno-result

Kris Chambers

commit sha 7dae52c70f52cbf486f5532c39c76d8201968258

Fix match function

view details

push time in 2 months

push eventKrisChambers/deno-result

Kris Chambers

commit sha a9497e3e367d739a5b39e1b15aacec121ed27b16

Fix issue with typing Ok and Err

view details

push time in 2 months

create barnchKrisChambers/deno-result

branch : master

created branch time in 2 months

created repositoryKrisChambers/deno-result

Trying out some rust like Result types for typescript.

created time in 2 months

PullRequestEvent

PR closed denoland/deno

Feature: Dependency count and module sizes for `deno info`.

This pr addresses issue #6468. Adding counts and size reporting for the modules.

Just looking for some feedback on a few things.

I have noticed the following:

  1. deno info currently doesn't include any files with specifiers starting with "file://". Is this a bug or as intended?
  2. The output format of the current json felt a bit weird with adding the extra informaton so here is a possible alternative schema with the extra information included.
  3. The output of the pr follows the format suggested in #6468 by @cknight. Generally this is great, but I think there could be a source of confusion about what is meant when we say total.

For 1: The implementation in the pr uses ModuleGraph instead of Deps which contains modules with "file://" as their specifier. This is different from the output I was getting on the live version of deno info command.

For 2: We are generating a tree from ModuleGraph which derives serde::Serialize. This gives a json formatting for free.

Here is some example output:

{
  "local": "/home/k/Code/deno/my_test/server.ts",
  "fileType": "TypeScript",
  "compiled": "/home/k/.cache/deno/gen/file/home/k/Code/deno/my_test/server.ts.js",
  "map": null,
  "deps": {
    "name": "file:///home/k/Code/deno/my_test/server.ts",
    "size": 127,
    "total_size": 63462,
    "deps": [
      {
        "name": "https://deno.land/std/http/server.ts",
        "size": 10438,
        "total_size": 63123,
        "deps": [
          {
            "name": "https://deno.land/std/encoding/utf8.ts",
            "size": 433,
            "total_size": 433,
            "deps": []
          },
          {
            "name": "https://deno.land/std/io/bufio.ts",
            "size": 21652,
            "total_size": 26505,
            "deps": [
              {
                "name": "https://deno.land/std/bytes/mod.ts",
                "size": 4448,
                "total_size": 4448,
                "deps": []
              },
              {
                "name": "https://deno.land/std/_util/assert.ts",
                "size": 405,
                "total_size": 405,
                "deps": []
              }
            ]
          },
          {
            "name": "https://deno.land/std/_util/assert.ts",
            "size": 405,
            "total_size": 0,
            "deps": []
          },
...

It was brought up in the pr #6372 to make the flag unstable due to possible iterations on the schema. Any suggestions would be great. Personally, I think the above works a bit better and is more easily extensible. I am also assuming that the intention of the json flag is to have it's output piped into something else, so maybe this would also be easier to consume.

For 3: The current state of the pr outputs something like this:

file:///home/k/Code/deno/my_test/server.ts (127 Bytes, total = 61.97 KB)
├─┬ https://deno.land/std/http/server.ts (10.19 KB, total = 61.64 KB)
│ ├── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 433 Bytes)
│ ├─┬ https://deno.land/std/io/bufio.ts (21.14 KB, total = 25.88 KB)
│ │ ├── https://deno.land/std/bytes/mod.ts (4.34 KB, total = 4.34 KB)
│ │ └── https://deno.land/std/_util/assert.ts (405 Bytes, total = 405 Bytes)
│ ├── https://deno.land/std/_util/assert.ts (405 Bytes, total = 0 Bytes)
│ ├─┬ https://deno.land/std/async/mod.ts (175 Bytes, total = 3.46 KB)
│ │ ├── https://deno.land/std/async/deferred.ts (1.03 KB, total = 1.03 KB)
│ │ ├── https://deno.land/std/async/delay.ts (279 Bytes, total = 279 Bytes)
│ │ └─┬ https://deno.land/std/async/mux_async_iterator.ts (1.98 KB, total = 1.98 KB)
│ │   └── https://deno.land/std/async/deferred.ts (1.03 KB, total = 0 Bytes)
│ └─┬ https://deno.land/std/http/_io.ts (11.24 KB, total = 21.68 KB)
│   ├── https://deno.land/std/io/bufio.ts (21.14 KB, total = 0 Bytes)
│   ├─┬ https://deno.land/std/textproto/mod.ts (4.51 KB, total = 4.51 KB)
│   │ ├── https://deno.land/std/io/bufio.ts (21.14 KB, total = 0 Bytes)
│   │ ├── https://deno.land/std/bytes/mod.ts (4.34 KB, total = 0 Bytes)
│   │ └── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 0 Bytes)
│   ├── https://deno.land/std/_util/assert.ts (405 Bytes, total = 0 Bytes)
│   ├── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 0 Bytes)
│   ├── https://deno.land/std/http/server.ts (10.19 KB, total = 0 Bytes)
│   └── https://deno.land/std/http/http_status.ts (5.93 KB, total = 5.93 KB)
└─┬ file:///home/k/Code/deno/my_test/a.ts (52 Bytes, total = 212 Bytes)
  └─┬ file:///home/k/Code/deno/my_test/b.ts (52 Bytes, total = 160 Bytes)
    └─┬ file:///home/k/Code/deno/my_test/c.ts (52 Bytes, total = 108 Bytes)
      └─┬ file:///home/k/Code/deno/my_test/d.ts (56 Bytes, total = 56 Bytes)
        └── file:///home/k/Code/deno/my_test/a.ts (52 Bytes, total = 0 Bytes)

Currently, if we already know the size of something, I am just returning a 0 total size. As in, "this reference is contributing 0 to the total size". I don't know if this is all that intuitive to the end user just by looking at this output or if this is the intended use of "total".

Setting things to 0 is mainly being used to get around circular references.

So here are some options.

  1. Use the above formatting.

  2. Report the sizes once on the tree: This might give a clearer indication that we are calculating the total size of the module based on it's dependencies.

The output would look something like this:

file:///home/k/Code/deno/my_test/server.ts (127 Bytes, total = 61.97 KB)
├─┬ https://deno.land/std/http/server.ts (10.19 KB, total = 61.64 KB)
│ ├── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 433 Bytes)
│ ├─┬ https://deno.land/std/io/bufio.ts (21.14 KB, total = 25.88 KB)
│ │ ├── https://deno.land/std/bytes/mod.ts (4.34 KB, total = 4.34 KB)
│ │ └── https://deno.land/std/_util/assert.ts (405 Bytes, total = 405 Bytes)
│ ├── https://deno.land/std/_util/assert.ts
│ ├─┬ https://deno.land/std/async/mod.ts (175 Bytes, total = 3.46 KB)
│ │ ├── https://deno.land/std/async/deferred.ts (1.03 KB, total = 1.03 KB)
│ │ ├── https://deno.land/std/async/delay.ts (279 Bytes, total = 279 Bytes)
│ │ └─┬ https://deno.land/std/async/mux_async_iterator.ts (1.98 KB, total = 1.98 KB)
│ │   └── https://deno.land/std/async/deferred.ts
│ └─┬ https://deno.land/std/http/_io.ts (11.24 KB, total = 21.68 KB)
│   ├── https://deno.land/std/io/bufio.ts
│   ├─┬ https://deno.land/std/textproto/mod.ts (4.51 KB, total = 4.51 KB)
│   │ ├── https://deno.land/std/io/bufio.ts
│   │ ├── https://deno.land/std/bytes/mod.ts
│   │ └── https://deno.land/std/encoding/utf8.ts
│   ├── https://deno.land/std/_util/assert.ts
│   ├── https://deno.land/std/encoding/utf8.ts
│   ├── https://deno.land/std/http/server.ts
│   └── https://deno.land/std/http/http_status.ts (5.93 KB, total = 5.93 KB)
└─┬ file:///home/k/Code/deno/my_test/a.ts (52 Bytes, total = 212 Bytes)
  └─┬ file:///home/k/Code/deno/my_test/b.ts (52 Bytes, total = 160 Bytes)
    └─┬ file:///home/k/Code/deno/my_test/c.ts (52 Bytes, total = 108 Bytes)
      └─┬ file:///home/k/Code/deno/my_test/d.ts (56 Bytes, total = 56 Bytes)
        └── file:///home/k/Code/deno/my_test/a.ts
  1. Print the size of each node in the tree as if deno info <module_name> was run on it: This gives you sizes of each submodule as they are individually, but no indication to how they contribute to the overall module's size.

Personally, I think I lean more to 2 since I think my intention with using something like deno info foo.ts means I want info regarding the module foo.ts. So seeing a bunch of totals not really connected to the total of the module being talked about seems like more info than is needed.

We could also report just the total on the root module and nothing on the nodes of the tree.

Any thoughts on this would be great!

+216 -83

0 comment

2 changed files

KrisChambers

pr closed time in 2 months

startedid-Software/DOOM

started time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha a8fa6c34b606b1412ef83f5f256c2207c4846d72

Add output for --json flag

view details

push time in 2 months

PR opened denoland/deno

Feature: Dependency count and module sizes for `deno info`.

This pr addresses issue #6468. Adding counts and size reporting for the modules.

Just looking for some feedback on a few things.

I have noticed the following:

  1. deno info currently doesn't include any files with specifiers starting with "file://". Is this a bug or as intended?
  2. The output format of the current json felt a bit weird with adding the extra informaton so here is a possible alternative schema with the extra information included.
  3. The output of the pr follows the format suggested in #6468 by @cknight. Generally this is great, but I think there could be a source of confusion about what is meant when we say total.

For 1: The implementation in the pr uses ModuleGraph instead of Deps which contains modules with "file://" as their specifier. This is different from the output I was getting on the live version of deno info command.

For 2: We are generating a tree from ModuleGraph which derives serde::Serialize. This gives a json formatting for free.

Here is some example output:

{
  "local": "/home/k/Code/deno/my_test/server.ts",
  "fileType": "TypeScript",
  "compiled": "/home/k/.cache/deno/gen/file/home/k/Code/deno/my_test/server.ts.js",
  "map": null,
  "deps": {
    "name": "file:///home/k/Code/deno/my_test/server.ts",
    "size": 127,
    "total_size": 63462,
    "deps": [
      {
        "name": "https://deno.land/std/http/server.ts",
        "size": 10438,
        "total_size": 63123,
        "deps": [
          {
            "name": "https://deno.land/std/encoding/utf8.ts",
            "size": 433,
            "total_size": 433,
            "deps": []
          },
          {
            "name": "https://deno.land/std/io/bufio.ts",
            "size": 21652,
            "total_size": 26505,
            "deps": [
              {
                "name": "https://deno.land/std/bytes/mod.ts",
                "size": 4448,
                "total_size": 4448,
                "deps": []
              },
              {
                "name": "https://deno.land/std/_util/assert.ts",
                "size": 405,
                "total_size": 405,
                "deps": []
              }
            ]
          },
          {
            "name": "https://deno.land/std/_util/assert.ts",
            "size": 405,
            "total_size": 0,
            "deps": []
          },
...

It was brought up in the pr #6372 to make the flag unstable due to possible iterations on the schema. Any suggestions would be great. Personally, I think the above works a bit better and is more easily extensible. I am also assuming that the intention of the json flag is to have it's output piped into something else, so maybe this would also be easier to consume.

For 3: The current state of the pr outputs something like this:

file:///home/k/Code/deno/my_test/server.ts (127 Bytes, total = 61.97 KB)
├─┬ https://deno.land/std/http/server.ts (10.19 KB, total = 61.64 KB)
│ ├── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 433 Bytes)
│ ├─┬ https://deno.land/std/io/bufio.ts (21.14 KB, total = 25.88 KB)
│ │ ├── https://deno.land/std/bytes/mod.ts (4.34 KB, total = 4.34 KB)
│ │ └── https://deno.land/std/_util/assert.ts (405 Bytes, total = 405 Bytes)
│ ├── https://deno.land/std/_util/assert.ts (405 Bytes, total = 0 Bytes)
│ ├─┬ https://deno.land/std/async/mod.ts (175 Bytes, total = 3.46 KB)
│ │ ├── https://deno.land/std/async/deferred.ts (1.03 KB, total = 1.03 KB)
│ │ ├── https://deno.land/std/async/delay.ts (279 Bytes, total = 279 Bytes)
│ │ └─┬ https://deno.land/std/async/mux_async_iterator.ts (1.98 KB, total = 1.98 KB)
│ │   └── https://deno.land/std/async/deferred.ts (1.03 KB, total = 0 Bytes)
│ └─┬ https://deno.land/std/http/_io.ts (11.24 KB, total = 21.68 KB)
│   ├── https://deno.land/std/io/bufio.ts (21.14 KB, total = 0 Bytes)
│   ├─┬ https://deno.land/std/textproto/mod.ts (4.51 KB, total = 4.51 KB)
│   │ ├── https://deno.land/std/io/bufio.ts (21.14 KB, total = 0 Bytes)
│   │ ├── https://deno.land/std/bytes/mod.ts (4.34 KB, total = 0 Bytes)
│   │ └── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 0 Bytes)
│   ├── https://deno.land/std/_util/assert.ts (405 Bytes, total = 0 Bytes)
│   ├── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 0 Bytes)
│   ├── https://deno.land/std/http/server.ts (10.19 KB, total = 0 Bytes)
│   └── https://deno.land/std/http/http_status.ts (5.93 KB, total = 5.93 KB)
└─┬ file:///home/k/Code/deno/my_test/a.ts (52 Bytes, total = 212 Bytes)
  └─┬ file:///home/k/Code/deno/my_test/b.ts (52 Bytes, total = 160 Bytes)
    └─┬ file:///home/k/Code/deno/my_test/c.ts (52 Bytes, total = 108 Bytes)
      └─┬ file:///home/k/Code/deno/my_test/d.ts (56 Bytes, total = 56 Bytes)
        └── file:///home/k/Code/deno/my_test/a.ts (52 Bytes, total = 0 Bytes)

Currently, if we already know the size of something, I am just returning a 0 total size. As in, "this reference is contributing 0 to the total size". I don't know if this is all that intuitive to the end user just by looking at this output or if this is the intended use of "total".

Setting things to 0 is mainly being used to get around circular references.

So here are some options.

  1. Use the above formatting.

  2. Report the sizes once on the tree: This might give a clearer indication that we are calculating the total size of the module based on it's dependencies.

The output would look something like this:

file:///home/k/Code/deno/my_test/server.ts (127 Bytes, total = 61.97 KB)
├─┬ https://deno.land/std/http/server.ts (10.19 KB, total = 61.64 KB)
│ ├── https://deno.land/std/encoding/utf8.ts (433 Bytes, total = 433 Bytes)
│ ├─┬ https://deno.land/std/io/bufio.ts (21.14 KB, total = 25.88 KB)
│ │ ├── https://deno.land/std/bytes/mod.ts (4.34 KB, total = 4.34 KB)
│ │ └── https://deno.land/std/_util/assert.ts (405 Bytes, total = 405 Bytes)
│ ├── https://deno.land/std/_util/assert.ts
│ ├─┬ https://deno.land/std/async/mod.ts (175 Bytes, total = 3.46 KB)
│ │ ├── https://deno.land/std/async/deferred.ts (1.03 KB, total = 1.03 KB)
│ │ ├── https://deno.land/std/async/delay.ts (279 Bytes, total = 279 Bytes)
│ │ └─┬ https://deno.land/std/async/mux_async_iterator.ts (1.98 KB, total = 1.98 KB)
│ │   └── https://deno.land/std/async/deferred.ts
│ └─┬ https://deno.land/std/http/_io.ts (11.24 KB, total = 21.68 KB)
│   ├── https://deno.land/std/io/bufio.ts
│   ├─┬ https://deno.land/std/textproto/mod.ts (4.51 KB, total = 4.51 KB)
│   │ ├── https://deno.land/std/io/bufio.ts
│   │ ├── https://deno.land/std/bytes/mod.ts
│   │ └── https://deno.land/std/encoding/utf8.ts
│   ├── https://deno.land/std/_util/assert.ts
│   ├── https://deno.land/std/encoding/utf8.ts
│   ├── https://deno.land/std/http/server.ts
│   └── https://deno.land/std/http/http_status.ts (5.93 KB, total = 5.93 KB)
└─┬ file:///home/k/Code/deno/my_test/a.ts (52 Bytes, total = 212 Bytes)
  └─┬ file:///home/k/Code/deno/my_test/b.ts (52 Bytes, total = 160 Bytes)
    └─┬ file:///home/k/Code/deno/my_test/c.ts (52 Bytes, total = 108 Bytes)
      └─┬ file:///home/k/Code/deno/my_test/d.ts (56 Bytes, total = 56 Bytes)
        └── file:///home/k/Code/deno/my_test/a.ts
  1. Print the size of each node in the tree as if deno info <module_name> was run on it: This gives you sizes of each submodule as they are individually, but no indication to how they contribute to the overall module's size.

Personally, I think I lean more to 2 since I think my intention with using something like deno info foo.ts means I want info regarding the module foo.ts. So seeing a bunch of totals not really connected to the total of the module being talked about seems like more info than is needed.

We could also report just the total on the root module and nothing on the nodes of the tree.

Any thoughts on this would be great!

+217 -82

0 comment

2 changed files

pr created time in 2 months

create barnchKrisChambers/deno

branch : feature_add_dep_count_and_sizes_to_deno_info

created branch time in 2 months

push eventKrisChambers/deno

David Sherret

commit sha cde4dbb35132848ffece59ef9cfaccff32347124

Use dprint for internal formatting (#6682)

view details

Bartek Iwańczuk

commit sha 73a90360894267c69365d97f535a3573861e4ace

fix: panic for runtime error in TS compiler (#6758)

view details

Maayan Hanin

commit sha b0f2bd4a2d1a75d7c8e4643a4b5b9478c1935668

fix(cli): add icon and metadata to deno.exe on Windows (#6693) Co-authored-by: Mark Tiedemann <www.marktiedemann@gmail.com> Co-authored-by: Luca Casonato <lucacasonato@yahoo.com> Co-authored-by: Bert Belder <bertbelder@gmail.com>

view details

Bartek Iwańczuk

commit sha 98e0ed54db5bbd8befcb5afbb1d63f2b80677f51

fix: ModuleSpecifier removes relative path parts (#6762)

view details

Ryan Dahl

commit sha 6c637f04bf70b631c363ef9c87303e7d7dcdc633

refactor(cli): Remove dead code (#6765)

view details

Casper Beyer

commit sha de3416689175214f33b226d4c510da63737c0db9

fix(std/wasi): remove number overload from rights in path_open (#6768)

view details

JohannLai

commit sha d60f9c2549c7dfb0fbd6c9c8984c215f5dd75e76

fix(cli/js/web): IPv6 hostname should be compressed (#6772)

view details

David Sherret

commit sha 2d58fee8071987567a25f26b14e29cdcca9cb5ab

Update dprint. Also ignore gh-pages dir. (#6778)

view details

uki00a

commit sha 121eaa4efcaa5c8a4cab25eed15de07642e0407d

fix(std/encoding/toml): could not parse strings with apostrophes/semicolons (#6781)

view details

Bartek Iwańczuk

commit sha 6e34f6a7cca11ba245f0b55c3b956b59948b37b7

fix: providing empty source code for missing compiled files (#6760) This commit adds a fallback mechanism for absent compiled source file. Because imported type declaration files are not emitted by TS compiler and their imports are not elided users often hit "No such file or directory" error. With this commit in such situation an empty source file will be provided to V8 with a warning to the user suggesting using "import type"/ "export type" syntax instead.

view details

push time in 2 months

push eventKrisChambers/deno

Sebastien Filion

commit sha 1bcc35b84a78fb052b8092b7ed57c2ce763f5d4b

feat(unstable): add Deno.consoleSize (#6520)

view details

Marcos Casagrande

commit sha 39dba12a061e464fb06bc6a763c84b36b5d1a915

fix(cli/buffer): allow Buffer to store MAX_SIZE bytes (#6570)

view details

Nayeem Rahman

commit sha 69e0886362623e1998f192dda72567b4e66b4117

fix(URL): Implement spec-compliant host parsing (#6689)

view details

KrisChambers

commit sha d01eb6d9c506eef765fde8e40f9b90619b2ec83c

Fix for issue #6685: --allow-net=:8080 broken (#6698)

view details

Kitson Kelly

commit sha 40d081d3d9f64bcd2524da86fb78808ac1d7b888

feat: add performance user timing APIs (#6421)

view details

Nayeem Rahman

commit sha 5ec41cbcc2778a80b6ee91f0c391fc2edec0a8e0

feat(Deno.inspect): Add sorted, trailingComma, compact and iterableLimit to InspectOptions (#6591)

view details

Bartek Iwańczuk

commit sha 98f6a5a47d6b47b1ac7f09a2923d6051de7aca70

chore: upgrade deno_lint, remove direct dprint dep (#6679) This PR removes direct dependency on dprint-plugin-typescript and swc_ecma_visit. Both of these dependencies have been pushed out to deno_lint crate. This should make it a bit easier to do the upgrades and prevent having conflicting crate requirements.

view details

Bartek Iwańczuk

commit sha a26b4a9f1eaed65e801a1de0ed73b4da76d37e63

chore: reenable ignored integration tests (#6703)

view details

Bartek Iwańczuk

commit sha 871f9255e37b4d2e63439c84da8e9bed6b388034

fix: harden pragma and reference parsing in module analysis (#6702)

view details

Valentin Anger

commit sha 3374c73fba3a96df22d0c04e6c17078ca8cce45b

feat(doc): Improve terminal printer (#6594) - Add more support for generics - Add the --private flag - displays documentation for not exported and private nodes - Display more attributes like abstract, static and readonly - Display type aliases - Refactor module to use the Display trait - Use a bit more color

view details

simwipado

commit sha e1d814055281ee2781dfda93cf8b2637b8d65800

feat(install): add --config flag (#6204) This commits adds support for "--config" flag in "deno install" subcommand. Specified configuration file is copied alongside source code to installation directory.

view details

Oscar Linde

commit sha 3be2064803b127c1aaa4af4aa3f060bcc8e88049

feat(cli): add DENO_CERT environment variable (#6370)

view details

Kitson Kelly

commit sha dd59bf5fc3daa4f0553a9f105af912f7de46c41a

fix: more tolerant performance.measure unit tests (#6726) Fixes #6725

view details

Luca Casonato

commit sha ac000341db0c90012a6330f66bd7bebe44c9c872

--no-check docs (#6714)

view details

Marcos Casagrande

commit sha 4aeac64ecd82d5953bdb92916248f5f7352be4f4

fix(cli/fetch): fix relative redirect (#6715)

view details

Nayeem Rahman

commit sha 63edeb1c36bfcea278c248e8be92f7dbb75f7671

fix(cli/js/web/url): Implement IPv4 hostname parsing (#6707)

view details

Marcos Casagrande

commit sha 1a96a96e101140a2c39114710f93ab21c98fca01

feat(cli): add copy argument to Buffer.bytes (#6697)

view details

uki00a

commit sha 4731f4800c1bd62cb77112ef8c9f553ae9164395

fix(Deno.ppid): improve error message when --unstable is missing (#6717)

view details

Marcos Casagrande

commit sha 44187c81f4a09dbec0ca83b91e5f378590c93cff

test: ignore max buffer tests (#6732)

view details

Bartek Iwańczuk

commit sha 11560387bb056098c55049db22c63550358c953a

Revert "feat: move unstable Deno.permissions to navigator.permissions… (#6729) * Revert "feat: move unstable Deno.permissions to navigator.permissions (#6244)" This reverts commit 202e7fa6ad366ee56a6d070e94eaecb6dbc745bf.

view details

push time in 2 months

issue commentdenoland/deno

Feature request: Add size and count of unique deps to Deno info

Thanks for the reply @bartlomieju. I agree, this is probably the most straight forward way to approach it using the ModuleGraph.

I will leave Deps untouched for now and take a look at it once @piscisaureus has finished the module system refactor.

cknight

comment created time in 2 months

issue commentdenoland/deno

Feature request: Add size and count of unique deps to Deno info

I noticed a todo left by @bartlomieju. They mention that the print_file_info function is a repeat of the whole compilation stack.

One thing I am a bit confused by was the Deps in deno.core and ModuleGraph in deno.cli. They both seem to be generating a dependency graph, except Deps seems a bit more specialized to generating it for deno info. I was curious if it would be alright to try and turn this code into some traversals of the ModuleGraph or if I am missing something subtle here.

I think this will do a few things:

  1. Removes the need to construct a second dependency tree.
  2. Removes some code from deno.core. As far as I can tell Deps is only used for this one purpose.
  3. Addresses the todo by only using the one part of the compilation stack we really need (the dependency tree).

Any feedback / insight would be appreciated. This is my first feature.

cknight

comment created time in 2 months

issue commentdenoland/deno

Feature request: Add size and count of unique deps to Deno info

I wouldn't mind trying to tackle this.

cknight

comment created time in 2 months

push eventKrisChambers/deno

Kris Chambers

commit sha 7f456c68cc9c804806b3eea37dea86d625f250f3

Fix formatting

view details

push time in 2 months

push eventKrisChambers/deno

Sebastien Filion

commit sha 1bcc35b84a78fb052b8092b7ed57c2ce763f5d4b

feat(unstable): add Deno.consoleSize (#6520)

view details

Marcos Casagrande

commit sha 39dba12a061e464fb06bc6a763c84b36b5d1a915

fix(cli/buffer): allow Buffer to store MAX_SIZE bytes (#6570)

view details

Nayeem Rahman

commit sha 69e0886362623e1998f192dda72567b4e66b4117

fix(URL): Implement spec-compliant host parsing (#6689)

view details

Kris Chambers

commit sha e96e47dd00162ae9da63a15002c537038e26c52c

Fix issue #6685: hostname not being set to default 0.0.0.0

view details

push time in 2 months

PR opened denoland/deno

Fix for issue #6685: --allow-net=:8080 broken

We were not setting the default hostname (0.0.0.0) when parsing the address from a string.

+2 -1

0 comment

2 changed files

pr created time in 2 months

create barnchKrisChambers/deno

branch : Issue#6685-ts

created branch time in 2 months

create barnchKrisChambers/deno

branch : Issue#6685

created branch time in 2 months

delete branch KrisChambers/v

delete branch : Issue#5585

delete time in 2 months

fork KrisChambers/deno

A secure JavaScript and TypeScript runtime

https://deno.land

fork in 3 months

issue commentdenoland/deno

--allow-net=:8080 broken

I would like to take a stab at this one.

brandonkal

comment created time in 3 months

startedmicrosoft/BosqueLanguage

started time in 3 months

issue openedvlang/v

Mutating values behind references without specifying mutability.

According to the documentation on References, to mutate a struct you must use the mut keyword (ex: mut foo Foo) and not pass it by reference (i.e not mut foo &Foo).

V version: V 0.1.28 33c5f6a OS: Manjaro Lysia 20.0.3

What did you do?

fn main() {
	thing := Thing {
		x: 0
	}
	println("$thing.x")
	
	foo(thing)

	println("$thing.x")
}

struct Thing {
mut:
	x int	= 0
}

fn foo(thing &Thing) {
	(*thing).x++
}

What did you expect to see? Expected an error relating to the mutability of the parameter thing in the method foo. Similar to how pointer arithmetic needs to be wrapped in an unsafe block.

What did you see instead? printed to screen:

0
1

created time in 3 months

PR opened vlang/v

Fix v/parser: Failure to parse structs with fields typed as anonymous functions returning having an optional void (`?`) return type.

Fixes #5585. Where fields of a struct defined as anonymous function types with return type ? where not parsing properly.

I also created a new function for parsing the (possible) language token and moved that code out of parse_type function.

+92 -13

0 comment

3 changed files

pr created time in 3 months

push eventKrisChambers/v

Kris Chambers

commit sha 4285a6745939a4dbc20e767ed2a40cd3b354727a

Fix test for structs containing anon fn with optional void return types

view details

push time in 3 months

push eventKrisChambers/v

Enzo

commit sha 7778cbe9f5e512b13553940f1e73bdbe8223e0dc

all: make `os` global in scripts (#5669)

view details

Alexander Medvednikov

commit sha 188bad4f382c3c016fa98a7daa58ff260959fc5a

vfmt: handle string attrs

view details

Delyan Angelov

commit sha 770ffa1ebd03cd619aeef7c3a1e76b3c0a34782f

crypto.rand: fix linux/solaris rand.read() compilation

view details

Delyan Angelov

commit sha b525553b5305b12b9b13096da4f39dc83dff15d8

examples: add a simplified mini (v)pwgen program

view details

Delyan Angelov

commit sha 0fb28eb42e4d64f0cd56c7e3859b0719ebd0aeac

contributing.md: add link to the Github Handbook's flow section

view details

yuyi

commit sha cda924063222ce09efb3c2e7833893d653892630

cgen: add unsafe block braces and comments in generated code (#5674)

view details

yuyi

commit sha 34a24eaa4ed339c27dc1b5a33688c164febd5786

checker: validate loop var names (#5677)

view details

joe-conigliaro

commit sha 9d7f1a236a205311b0b41ec2898717801ef87d4a

checker/gen: fix nested sumtype matching

view details

yuyi

commit sha 96bd4e8794e4fd45aebba690518e63a8ea8eff5f

parser: fix type detection in `match` (#5679)

view details

Alexander Medvednikov

commit sha 36183660e6048f0b4791b7dd087401e6a8ea65de

remove oldgg, gl, glfw, freetype from vlib now that we have the new sokol based `gg`

view details

Alexander Medvednikov

commit sha 1505f3e22cd422bc1978932bd68d1d56657a2c4f

vweb: fix an example

view details

joe-conigliaro

commit sha 4e66728477f3b1049d17bc8ae6a3701077e05f49

checker/table: rearrange sumtype check fns

view details

Alexander Medvednikov

commit sha 271786b186387b5a9f6b730305cb57a8a8760013

ci: skip some ui examples for now

view details

Delyan Angelov

commit sha 1416c70e73d73daaa64e9309b82498d0ca58fa89

net.websocket: fix building client.v

view details

push time in 3 months

push eventKrisChambers/v

Enzo

commit sha 7778cbe9f5e512b13553940f1e73bdbe8223e0dc

all: make `os` global in scripts (#5669)

view details

Alexander Medvednikov

commit sha 188bad4f382c3c016fa98a7daa58ff260959fc5a

vfmt: handle string attrs

view details

Delyan Angelov

commit sha 770ffa1ebd03cd619aeef7c3a1e76b3c0a34782f

crypto.rand: fix linux/solaris rand.read() compilation

view details

Delyan Angelov

commit sha b525553b5305b12b9b13096da4f39dc83dff15d8

examples: add a simplified mini (v)pwgen program

view details

Delyan Angelov

commit sha 0fb28eb42e4d64f0cd56c7e3859b0719ebd0aeac

contributing.md: add link to the Github Handbook's flow section

view details

yuyi

commit sha cda924063222ce09efb3c2e7833893d653892630

cgen: add unsafe block braces and comments in generated code (#5674)

view details

yuyi

commit sha 34a24eaa4ed339c27dc1b5a33688c164febd5786

checker: validate loop var names (#5677)

view details

joe-conigliaro

commit sha 9d7f1a236a205311b0b41ec2898717801ef87d4a

checker/gen: fix nested sumtype matching

view details

yuyi

commit sha 96bd4e8794e4fd45aebba690518e63a8ea8eff5f

parser: fix type detection in `match` (#5679)

view details

Alexander Medvednikov

commit sha 36183660e6048f0b4791b7dd087401e6a8ea65de

remove oldgg, gl, glfw, freetype from vlib now that we have the new sokol based `gg`

view details

Alexander Medvednikov

commit sha 1505f3e22cd422bc1978932bd68d1d56657a2c4f

vweb: fix an example

view details

joe-conigliaro

commit sha 4e66728477f3b1049d17bc8ae6a3701077e05f49

checker/table: rearrange sumtype check fns

view details

Alexander Medvednikov

commit sha 271786b186387b5a9f6b730305cb57a8a8760013

ci: skip some ui examples for now

view details

Delyan Angelov

commit sha 1416c70e73d73daaa64e9309b82498d0ca58fa89

net.websocket: fix building client.v

view details

Kris Chambers

commit sha 03547c2748da4787f687018c86c8a41f2f1306b5

Handle optional void return type in function types in struct fields.

view details

Kris Chambers

commit sha a7a7403f1f27458b46d91a5336d69ff96de5211f

Add more testing for optional return types in struct fields.

view details

Kris Chambers

commit sha 43c102e8561a6d9c4678de8de861b868babf7ca5

Move language parsing into it's own function

view details

Kris Chambers

commit sha aa59dc533a8b1a18f9fb32ee1a05b1fc5ff5ca6b

Fix issue caused by not setting typ.

view details

push time in 3 months

push eventKrisChambers/v

yuyi

commit sha 31104d73b95d8aa5f1b324911b0a94bfe87cddc4

vrepl: minor optimization (#5633)

view details

yuyi

commit sha 1efbb830608cdec642edca2e5690aadbf77ec8dd

cgen: add space before `else` in match (#5632)

view details

yuyi

commit sha f03688e443b2519299706e7b3dc2ecfad07c412d

parser: advanced division by zero check (#5629)

view details

Alexander Medvednikov

commit sha b7175b54ebd932ec30c4100ada39c89418a0762f

vweb: ['/:arg1/:arg2/action'] attribute

view details

Delyan Angelov

commit sha df2749dd50a4a815d90035da3530003cf12a6c70

vfmt: fix indent level of commented match branches

view details

yuyi

commit sha dff385cb37cd32ab3b2caf65a27e0e7c324dbfb1

cgen: fix map_in mut (#5638)

view details

Delyan Angelov

commit sha 652380c5fdf3043fcf2bbd96650161d90214c8a8

cgen: fix `-printfn main`

view details

Delyan Angelov

commit sha 8adaf4efd42907af12e085844c8a51de10ebd38c

cgen: allow `-printfn main` for _test.v files too

view details

Tom Leen

commit sha 51410fdb6dcf78dade0546f260265f9a601afbe2

vweb: add .txt and .md mime types (#5641)

view details

Alexander Medvednikov

commit sha 2281163efdabd418e234d9318a2eecd0e335d60a

vweb: fix a routing bug

view details

yuyi

commit sha 9e949622d3e2477ab57c2440f96f3946d42c3a85

vrepl: pre-imported common modules (#5643)

view details

Ruofan XU

commit sha a2395ff3e87adccd5fcca310be7ad6893be50e09

cgen: fix mut map with relation op in fn (#5642)

view details

Nick Treleaven

commit sha 0b49e4db1c575d2d135d3083746dc65f54ce5327

v/checker.v: disallow pointer arithmetic for InfixExpr outside unsafe {} (#5640)

view details

yuyi

commit sha 61213263cddd560dec0e9cc2949c6b1c9e60abb8

cgen: remove extra `\n` in map.get (#5630)

view details

yuyi

commit sha 67e85fa9ddfcd75c72f46b70d9dc61d445b19069

cgen: fix indent in `for_in_string` (#5631)

view details

Alexander Medvednikov

commit sha 244d61f8d066cffb8d8d2e5118648fff80a51048

vweb: fix a route matching bug

view details

Alexander Medvednikov

commit sha e9e437ce0502a4c39532fa25dbbb4dc3d66d05cc

repl: show short version

view details

Alexander Medvednikov

commit sha 3d3549d65a0c2e0330c1dd53ff2791eddfb78bd5

Revert "parser: advanced division by zero check (#5629)" This reverts commit f03688e443b2519299706e7b3dc2ecfad07c412d.

view details

Ruofan XU

commit sha 37f31da6c9971889045c4d1e0577992c47af42ec

parser: minor simplification (#5645)

view details

div72

commit sha 95696559b778463d1edddf57327d25a8ee28af8b

os: fix early termination when saving binary (#5646)

view details

push time in 3 months

push eventKrisChambers/v

yuyi

commit sha 31104d73b95d8aa5f1b324911b0a94bfe87cddc4

vrepl: minor optimization (#5633)

view details

yuyi

commit sha 1efbb830608cdec642edca2e5690aadbf77ec8dd

cgen: add space before `else` in match (#5632)

view details

yuyi

commit sha f03688e443b2519299706e7b3dc2ecfad07c412d

parser: advanced division by zero check (#5629)

view details

Alexander Medvednikov

commit sha b7175b54ebd932ec30c4100ada39c89418a0762f

vweb: ['/:arg1/:arg2/action'] attribute

view details

Delyan Angelov

commit sha df2749dd50a4a815d90035da3530003cf12a6c70

vfmt: fix indent level of commented match branches

view details

yuyi

commit sha dff385cb37cd32ab3b2caf65a27e0e7c324dbfb1

cgen: fix map_in mut (#5638)

view details

Delyan Angelov

commit sha 652380c5fdf3043fcf2bbd96650161d90214c8a8

cgen: fix `-printfn main`

view details

Delyan Angelov

commit sha 8adaf4efd42907af12e085844c8a51de10ebd38c

cgen: allow `-printfn main` for _test.v files too

view details

Tom Leen

commit sha 51410fdb6dcf78dade0546f260265f9a601afbe2

vweb: add .txt and .md mime types (#5641)

view details

Alexander Medvednikov

commit sha 2281163efdabd418e234d9318a2eecd0e335d60a

vweb: fix a routing bug

view details

yuyi

commit sha 9e949622d3e2477ab57c2440f96f3946d42c3a85

vrepl: pre-imported common modules (#5643)

view details

Ruofan XU

commit sha a2395ff3e87adccd5fcca310be7ad6893be50e09

cgen: fix mut map with relation op in fn (#5642)

view details

Nick Treleaven

commit sha 0b49e4db1c575d2d135d3083746dc65f54ce5327

v/checker.v: disallow pointer arithmetic for InfixExpr outside unsafe {} (#5640)

view details

yuyi

commit sha 61213263cddd560dec0e9cc2949c6b1c9e60abb8

cgen: remove extra `\n` in map.get (#5630)

view details

yuyi

commit sha 67e85fa9ddfcd75c72f46b70d9dc61d445b19069

cgen: fix indent in `for_in_string` (#5631)

view details

Alexander Medvednikov

commit sha 244d61f8d066cffb8d8d2e5118648fff80a51048

vweb: fix a route matching bug

view details

Alexander Medvednikov

commit sha e9e437ce0502a4c39532fa25dbbb4dc3d66d05cc

repl: show short version

view details

Alexander Medvednikov

commit sha 3d3549d65a0c2e0330c1dd53ff2791eddfb78bd5

Revert "parser: advanced division by zero check (#5629)" This reverts commit f03688e443b2519299706e7b3dc2ecfad07c412d.

view details

Ruofan XU

commit sha 37f31da6c9971889045c4d1e0577992c47af42ec

parser: minor simplification (#5645)

view details

div72

commit sha 95696559b778463d1edddf57327d25a8ee28af8b

os: fix early termination when saving binary (#5646)

view details

push time in 3 months

create barnchKrisChambers/v

branch : Issue#5585

created branch time in 3 months

push eventKrisChambers/v

joe-conigliaro

commit sha 73da3c9e4c6d1246452d0d95a1ea37e9a7a90215

generic structs: better naming & comments

view details

joe-conigliaro

commit sha a3086a2ef3ffd57b3b7424fe5f39ca8f99f66f1e

cgen: optimize generic struct name replacement (temp solution)

view details

Alexander Medvednikov

commit sha a45ad478410a74659b74b06891017fd066afd009

ci: testing building gitly with -autofree

view details

yuyi

commit sha 628f13f1c863874a9ff26ef51315a812da88daf0

cgen: minor optimization of `index_expr()`

view details

yuyi

commit sha 61b8c0b699275c28a7ae1e278e6b4fe68e41ad54

cgen: change `i++` to `++i` in `for`

view details

Alexander Medvednikov

commit sha 8d7eccb8e1af00837c8661760a52fbc600b35b8b

ci: fix gitly test

view details

Uwe Krüger

commit sha 8a4691172594c9fecbe8bae6c5bcd55e14ce4aa6

checker: check if mut function arg is declared as mut (#5579)

view details

Nick Treleaven

commit sha d091f4e5b27faea410c4005189d81f73e3b056f9

doc: general tweaks (#5566)

view details

Louis Schmieder

commit sha f3010cbfb2420fa2e9f5c76c8980fc670df3b0ee

http: add post function with json as payload (#5580)

view details

Nick Treleaven

commit sha 55989b3c2c5da7563c8103d229d4f9727bdc806c

doc: split array example & some tweaks (#5564)

view details

Delyan Angelov

commit sha af56b01a412a4d39af020330518cca10544a4af8

cgen: parametrize g_str_buf size by V_STRBUF_MB; free in _vcleanup()

view details

nyaascii

commit sha f10d2bb75f5d88d86c355c0ca0a556d8552d6d03

string: fix trim_prefix and trim_suffix methods (#5572)

view details

Delyan Angelov

commit sha 2fd960f12c986baa10d4663e5f54c1ce929b5c2b

builtin: implement a double free detection for v strings

view details

Delyan Angelov

commit sha 3fed6ca050b01903eec5724e51c474ca70cb75ee

cgen: comment out g_str_buf for now

view details

spaceface777

commit sha 7ea77a0047e2197c36519772f23a0ba9b5cc11ae

vschannel: fix net segfault on Windows (#5587)

view details

Alexander Medvednikov

commit sha ba38c94a403b72222508a857046ddeb979038de7

readme: stability guarantee

view details

Alexander Medvednikov

commit sha a11e242bb2296869b095bf24ce73f96332a6e058

readme: link to gitly, clarify compilation speed claims

view details

Alexander Medvednikov

commit sha 7df6984261d8692033b2d6990ce0ba3b0667f714

roadmap: ios/android

view details

Alexander Medvednikov

commit sha 34ddc9240e791bf8e6bfabbe2f601968c6c9bbeb

tutorials: web blog fixes

view details

Lukas Neubert

commit sha d40334fe9d81f39715ebaaf8bc7f5a1b655e0391

vpm: replace `-` in author names with `_` (#5583)

view details

push time in 3 months

issue commentvlang/v

fails to compile anonymous function returning error in struct definition

Unless anyone else is working on this. I will take a look at it.

timbasel

comment created time in 3 months

issue commentvlang/v

Generic structs don't work

This would be my first contribution to V. Anyone mind if I take a stab at fixing this bug?

StunxFS

comment created time in 3 months

fork KrisChambers/v

Simple, fast, safe, compiled language for developing maintainable software. Compiles itself in <1s with zero library dependencies. https://vlang.io

fork in 3 months

more