profile
viewpoint
Jan Klass Kissaki Germany https://kcode.de/ B.Sc. in Applied Computer Science. Working as a Software Engineer since 2011. Server admin, FOSS contributor.

Kissaki/MumPI 88

[Not actively maintained anymore] MumPI is your Webinterface in PHP for Mumble talking to your Mumble Server (“Murmur”) via the Ice-Middleware.

Kissaki/KCode-Jetpack-Scripts--GTranslate 2

[Dropped] Firefox Jetpack Addons / Scripts – For everyone!

Kissaki/mumble 2

Mumble VoIP Client/Server

Kissaki/com_downloads 1

[Inactive] Joomla Component for Downloads (J1.6)

Kissaki/Enemy-Territory 1

Wolfenstein: Enemy Territory GPL Source Release

Kissaki/go-xmpp 1

go xmpp library (russ cox written original)

Kissaki/gomongo 1

Go driver for MongoDB

Kissaki/grumble 1

Alternative Mumble server

Kissaki/KCode-Jetpack-Scripts--CSS-Refresh 1

Firefox Jetpack Addons / Scripts – For everyone!

issue commentmumble-voip/mumble-www

Provide download link for latest AppImage

See also the commit (and description) that removed the download link 7a94ce2c4359368c7d377a13b9deb33c3bc103f8

Lvaskz

comment created time in 13 hours

issue commentmumble-voip/mumble-www

Blog Feed not found

It is fixed now. Thank you for reporting it.

w1n5l0w

comment created time in a day

push eventmumble-voip/mumble-www

Jan Klass

commit sha a397d642af020a231728cfa0e2b003b75d736892

Fix baseURL Fixes #102

view details

push time in a day

issue closedmumble-voip/mumble-www

Blog Feed not found

The Blog provides a link to a RSS Feed with URL https://mumble.info/blog/index.xml which doesn't seem to exist. Would be nice to have the feed functioning/available behind the link.

closed time in a day

w1n5l0w

issue commentmumble-voip/mumble-www

Blog Feed not found

That should link should point to https://www.mumble.info/blog/index.xml, which works.

w1n5l0w

comment created time in a day

push eventmumble-voip/mumble-www

Robert Adam

commit sha 56acaa2ba13dbdc970a91778742d43e08feedb31

RELEASE: 1.3.2 This commit updates the respective release information and also creates a new blog entry for it.

view details

Jan Klass

commit sha 1c54f9fed11b5a891dedaa66c7b230d08bf9da2a

Merge PR #101: RELEASE: 1.3.2

view details

push time in 2 days

PR merged mumble-voip/mumble-www

RELEASE: 1.3.2

This commit updates the respective release information and also creates a new blog entry for it.

+39 -8

0 comment

3 changed files

Krzmbrzl

pr closed time in 2 days

startedmartindevans/MumbleSharp

started time in 2 days

issue commenttfedor/AugmentedSteam

Failed to initialize Currency

Reinstalling what? The addon? Reinstalling the addon the issue is still there.

KamiYamabushi

comment created time in 2 days

pull request commentmumble-voip/mumble

MAINT(readme): Rework READMEs

I can’t approve this any more since it is already merged but as I’m an assigned reviewer I’ll still leave this LGTM here as I looked through it now.

Krzmbrzl

comment created time in 2 days

pull request commentmumble-voip/mumble-www

WIP: Implement public server list

Sure, we can improve the UI if this is something we want to implement and publish.

Kissaki

comment created time in 2 days

issue commentmumble-voip/mumble

No .msi for new version 1.3.2

I agree. Tags should be persistent. The next version number should be assigned for a different commit.

TalkLounge

comment created time in 2 days

Pull request review commentmumble-voip/mumble-www

RELEASE: 1.3.2

+---
+title: Mumble 1.3.2 Release Announcement
+author: Robert Adam
+date: 2020-07-09
+categories:
+  - News
+  - Release
+  - Security
+---
+The Mumble team has released [**version 1.3.2**](https://github.com/mumble-voip/mumble/releases/tag/1.3.2) of the Mumble VoIP application. This is a
+**bugfix and security release** of the current and stable 1.3 series.

Second reference to it being a security release.

Krzmbrzl

comment created time in 2 days

Pull request review commentmumble-voip/mumble-www

RELEASE: 1.3.2

+---
+title: Mumble 1.3.2 Release Announcement
+author: Robert Adam
+date: 2020-07-09
+categories:
+  - News
+  - Release
+  - Security

What makes this a security release? I think that’s wrong?

Krzmbrzl

comment created time in 2 days

Pull request review commentmumble-voip/mumble

MAINT(readme): Rework READMEs

 ![Mumble screenshot](screenshots/Mumble.png) -Mumble - A voice chat utility for gamers-=======================================+# Mumble - OpenSource voice-chat software 

We talked about this in our team meeting last week. Open Source seems to be the most common and our agreed upon writing style. We also use that on our website and repository description.

Krzmbrzl

comment created time in 5 days

push eventmumble-voip/mumble-www

Jan Klass

commit sha 7a94ce2c4359368c7d377a13b9deb33c3bc103f8

Downloads: Drop AppImage We decided to not advertise the AppImage at this moment as in some configurations/in some systems with incompatible OpenSSH or Qt it does not work correctly. These issues have to be fixed before we publicly and prominently advertise the AppImage.

view details

push time in 7 days

starteda327ex/BYTEPATH

started time in 8 days

push eventKissaki/smite-resources

Jan Klass

commit sha 9313cdd3d95c408b4ffd2fd1487609402d848f57

Data update

view details

push time in 10 days

pull request commentmumble-voip/MumbleTransifexBot

Fix missing backslash in RegEx

Given that we just had a PR on this which seemingly was incomplete maybe put in some documentation what the regex is supposed to do specifically?

Maybe document what the text content (format) actually is so it can be verified against the regex?

Maybe document some working test case(s) in this PR? So that we can verify and/or point at missing cases?

Krzmbrzl

comment created time in 15 days

issue closedmumble-voip/mumble-ubuntu-ppa

Missing 20.04 PPA repo

When adding the PPA repository on Ubuntu 20.04 (the latest LTS version, Focal Fossa) an error occurs because the correct published index/metadata is missing from the PPA for Focal Fossa. It can be worked around by forcing the PPA to use the Eoan codename instead of Focal but I'm hoping this can be an easy ask to get it updated.

Thanks for the hard work on a good service.

closed time in 15 days

gnomed

issue commentmumble-voip/mumble-ubuntu-ppa

Missing 20.04 PPA repo

Duplicate of #11

It’s not that it is more complicated than before, but that an MR was merged with no context information of whether it intends to implement it, does implement it or partially implement it. And the effort is considerable enough that I will not put in that effort if it may already be fixed. But I did not receive an answer on #11 about that state or intention.

There is a chance the next release (version 1.3.2) will provide it. If not I may look into it again.

gnomed

comment created time in 15 days

issue commenttfedor/AugmentedSteam

Failed to initialize Currency

I have had this issue for months and it never resolved itself.

Error: "UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code."
    message moz-extension://<id>/js/core.js:30
    common.js:601:35
Failed to initialize Currency common.js:863:25
Error: "UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code."
    message moz-extension://<id>/js/core.js:30
KamiYamabushi

comment created time in 15 days

push eventKissaki/smite-resources

Jan Klass

commit sha 887bd598105288bd9bdc6e18000f9451fc839092

Data update

view details

Jan Klass

commit sha 476a7333471f0608f299518e758bb213151d22ea

Data update; new god Baba Yaga

view details

Jan Klass

commit sha c3731f5087209ba3ce393bed88e12258ba2872c4

Data update

view details

Jan Klass

commit sha e91e6742b0140febad01edf09450724db4fefc8e

Data update

view details

Jan Klass

commit sha 861000d6bd605beb8164b7f11f7a32e150055254

Data update

view details

Jan Klass

commit sha c7df534a2f9d6f8eac722ae55ca6945573451ae3

Data update

view details

Jan Klass

commit sha 2f82146159e02f7d7e196bb71ae95a8a0357d2b5

Data update

view details

Jan Klass

commit sha b910712dd4161bd36aa415fe25ebaf9c58de2d4b

Data update; new god Cthulhu

view details

Jan Klass

commit sha 46416f36b79a34ad824406d5c127eb73c2ee40f7

Fix JS for pantheon with spaces (Great Old Ones)

view details

Jan Klass

commit sha e04c5677fd7e6a2e45964bb9ca2c8ae5d78e389b

Add missing pantheon icons as local files

view details

Jan Klass

commit sha 65e13f80b4a62b56cca294719f56e730642173eb

Categorize skin themes

view details

push time in 18 days

startednxrighthere/UnrealCLR

started time in 18 days

startedstride3d/stride

started time in 18 days

starteddabreegster/abstreet

started time in 19 days

startedgithub/super-linter

started time in 23 days

issue commentmumble-voip/mumble

Add help icons/buttons

Windows shows the help action button at the top right

image

I’m sure in the past SHIFT+F1 also worked to activate this cursor. But it doesn’t work for me right now.

Anyway, once you activated this help cursor you can click on controls and it will show extended information/help text if available.

I’m not sure how KDE or Gnome/Qt on those provide this functionality.

toby63

comment created time in a month

issue commentmumble-voip/mumble

Add help icons/buttons

You seem to ignore what I already said. This is intended to further explain functionality, like what echo cancel option to use.

You never made a concrete example to show the need for more help functionality. You only suggest that it could be added without providing the context of why we need it.

A concrete example can help discuss concrete needs and limitations. Without context of what we would want to add talking about how to add it is kinda… missing substance.

toby63

comment created time in a month

issue commentmumble-voip/mumble

Add help icons/buttons

Out extended tooltips already are more than one line.

For example image

toby63

comment created time in a month

issue commentmumble-voip/mumble

Add help icons/buttons

We have control, label, hover tooltip, and help action extended tooltip. And this suggestion suggests adding yet another?

I think adding a help icon button mainly duplicates the extended help text that can already be shown with the help action.

Generally I there is also reasonable opportunity to add some intro and description texts that provides context without hiding it behind actions or hover.

I think making the help action the default tooltip would also be feasible and preferable to help buttons.

If help buttons were to be introduced I would want them to shoe the same help text as the already existing help action. We should not duplicate the help text (a third time with varying detail).

toby63

comment created time in a month

push eventmumble-voip/mumble

Robert Adam

commit sha cfe1f6b5d5fbd4806d77655dd2db56a71e5ac39d

FIX(overlay): Make overlay work again In aac3214d4be2ba31c852619bc8d3666391dcd02a Overlay::createPipe() has been introduced in order to only create the pipe when needed (instead of in the constructor of the Overlay class). This new function was never called though which caused the Overlay to stop working. This commit makes sure the respective function is called when activating the overlay. Fixes #4281

view details

Robert Adam

commit sha fda80a67670ed2f7a9ff1f3f280f84a5e76eb7c2

FIX(overlay): Initialize only when activated In the old implementation the overlay was initialized as soon as Overlay::setActive got called regardless of whether it was asked to actually activate. This commit makes sure to only initialize the Overlay if it is actually asked to be activated via Overlay::setActive(true).

view details

Robert Adam

commit sha 18da1a0ba720b73b21a177ce7ecb94710793c9d9

REFAC(overlay): Move init in own function The initialization code is now moved into its own function (instead of also living inside the setActive function body). This is done in order to better separate initialization and activation.

view details

Jan Klass

commit sha d73465e3a26f398f2ccb0736280403583114dbf0

Merge PR #4282: Fix overlay not showing This PR makes the overlay work again (got broken in aac3214) and furthermore makes sure that it really only is initialized if needed.

view details

push time in a month

PR merged mumble-voip/mumble

Fix overlay bug client overlay

This PR makes the overlay work again (got broken in https://github.com/mumble-voip/mumble/commit/aac3214d4be2ba31c852619bc8d3666391dcd02a) and furthermore makes sure that it really only is initialized if needed.


I have not tested the changes to actually work yet. Would be great if someone could do so :)

+16 -1

3 comments

2 changed files

Krzmbrzl

pr closed time in a month

issue closedmumble-voip/mumble

Overlay does not work anymore in 1.3.1

The Overlay does not work anymore in 1.3.1.

Desktop:

  • OS: Windows 10 (should be an issue for all)
  • Version: Mumble 1.3.1

PR #4041 disabled the overlay by default. It includes commit aac3214d4be2ba31c852619bc8d3666391dcd02a which improves the code base, but introduces a regression. In introduces the createPipe method, moves initialization code there but never calls it. https://github.com/mumble-voip/mumble/pull/4041/commits/aac3214d4be2ba31c852619bc8d3666391dcd02a#diff-bd43cc370108609b2ea02c12eae197c4R226

closed time in a month

Kissaki

issue commentmumble-voip/mumble-ubuntu-ppa

Ubuntu PPA: builds for 20.04 Focal Fossa

@davidebeatrici PR #9 added this? So what’s the status of that? Was that your intention? Or what was that PR for if not for adding focal??

timvisee

comment created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay

 Overlay::~Overlay() { }  void Overlay::setActive(bool act) {+	if (!act && !m_initialized.load()) {+		// Disabling when the Overlay hasn't been initialized yet, doesn't make much sense+		return;+	}

Your call.

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble

Introduce CMake as build system

"C:\Program Files\CMake\bin\cmake.exe" ^
  -G "Ninja" ^
  "-DVCPKG_TARGET_TRIPLET=x64-windows-static-md" ^
  "-Dstatic=ON" ^
  "-DCMAKE_TOOLCHAIN_FILE=C:/dev/mumble-ecosystem/mumble/buildenv/win64-static-1.4.x-2020-05-27-ecb3c64-1151/scripts/buildsystems/vcpkg.cmake" ^
  "-DIce_HOME=C:\dev\mumble-ecosystem\mumble\buildenv\win64-static-1.4.x-2020-05-27-ecb3c64-1151\installed\x64-windows-static-md" ^
  ..
davidebeatrici

comment created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay

 Overlay::~Overlay() { }  void Overlay::setActive(bool act) {+	if (!act && !m_initialized.load()) {+		// Disabling when the Overlay hasn't been initialized yet, doesn't make much sense+		return;+	}

I generally prefer early returns as well. But with the overall state and stuff it was difficult for me to wrap my head around here. It was harder instead of easier to interpret the function.

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble

Introduce CMake as build system

I am using static on. I am using the same parameters I added in VS.

davidebeatrici

comment created time in a month

pull request commentmumble-voip/mumble

Introduce CMake as build system

Win msvc build with prepared static env.

  • [ ] from VS, release mumble.exe works but murmur.exe launches a console window and does not minimize to tray as expected; it seems to not launch correctly
  • [ ] cli cmake generate fails for generators default, ninja and nmake; fails to find sndfile
  • [ ] from VS debug builds launch with an immediate assertion error on both mumble.exe and murmur.exe
davidebeatrici

comment created time in a month

pull request commentmumble-voip/mumble

MAINT: Create commit guidelines

Having seen the TYPE prefix on commits now I like them.

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay

 Overlay::~Overlay() { }  void Overlay::setActive(bool act) {+	if (!act && !m_initialized.load()) {+		// Disabling when the Overlay hasn't been initialized yet, doesn't make much sense+		return;+	}+ 	if (!m_initialized.load()) {+		qDebug() << "Overlay init";

Squashing the change into the actual commit would be better anyway… Applying the suggestion will produce an additional commit.

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay

 Overlay::~Overlay() { }  void Overlay::setActive(bool act) {+	if (!act && !m_initialized.load()) {+		// Disabling when the Overlay hasn't been initialized yet, doesn't make much sense+		return;+	}+ 	if (!m_initialized.load()) {+		qDebug() << "Overlay init";

issue: We use a Overlay: prefix by convention in this file to make the debug messages consistent and clearer/scannable.

		qDebug() << "Overlay: Initializing...";

(Does applying GitHub suggestions work without line ending changes being produced? I had bad experiences with GitLab concerning that. Looks like the file is LF [already].)

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay

 Overlay::~Overlay() { }  void Overlay::setActive(bool act) {+	if (!act && !m_initialized.load()) {+		// Disabling when the Overlay hasn't been initialized yet, doesn't make much sense+		return;+	}

suggestion: Personally I think I would make the init if (act && !m_initialized) instead. This block introduces another condition, negated and combined, that was difficult for me to wrap my head around. I think "init if necessary" would be clearer than this "special special" condition.

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay

 Overlay::~Overlay() {  void Overlay::setActive(bool act) { 	if (!m_initialized.load()) {+		createPipe();

question: Before aac3214 the createPipe logic was executed after platformInit and forceSettings instead of before. Is there a reason for this change?

Personally I like to keep stuff as close to the previous logic as possible unless there is a reason for a change, and/or the consequences can be interpreted or verified. Because of possible unforeseen consequences.

From what I can see createPipe creates the qlsServer. forceSettings will call reset and update on any connected clients. Effectively this change may now call reset and update on "new" clients (that may not have received or shown data before). I do not know if that makes a difference. Maybe it is just unnecessary clearing of state. Or maybe such a case is not handled cleanly on the other end.

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy+- **Each change goes into its own commit**. If you want to summarize what you did with this commit (in the commit message)+and you start using the word "and", you probably want to split the commit up into 2 or more individual commits.+- **Each commit should compile** (try to make each commit self-contained so that it is possible to compile the code at+each commit)+- **Don't be lazy** when composing the commit message. In order to have a good git-history the commit messages are essential.+Also if you put effort into the commit-message, you'll save work when creating a PR as the description is already available.++# Commit message+Commit messages should follow the scheme+```+TYPE(Scope): Summary++Message Body++Footer+```++The blank lines in between are mandatory. A commit **must** include a `TYPE` and a `Summary` and **may**+additionally contain any of the other components listed here.++## Subject line+The first line ("Subject line") should not exceed 50-70 characters. This is what gets displayed on GitHub at first glance, so it+should contain the most important information. In order for it to be as short and precise as possible, there is the `TYPE` and+optionally a `Scope`. With these it should already be clear what this commit is about in general. The short summary should+then include further information that is important to understand the general idea of this commit at a glance.++### TYPE+The `TYPE` is one of the following:+| **TYPE** | **Description** | **Example** |+| -------- | --------------- | ----------- |+| BREAK    | A breaking change - not backwards-compatible. | A change in protocol (e.g. change UDP message format) |+| FEAT     | Introduction of a new feature (or extension of an existing one) | |+| FIX      | A bug fix | |+| FORMAT   | Change of formatting - does not influence how the code works | Change indentation of a line; Add braces around `if` body |+| DOCS     | Changes to the documentation (either in-source or out-of-source) | Add a Doxygen comment to a function |+| TEST     | Adds, changes or removes a test-case | |+| MAINT    | Maintenance - Change of non-code files | Change of the README |+| CI       | Changed something for the CI (continous integration) | Update TravisCI to use newer ubuntu version |+| REFAC   | Code refactoring | Renamed variable `x` to `y` |++The `TYPE` has to be in **all-uppercase** in order for it to stand out.++If you feel like you need to use 2 or more types for a single commit but *can't split it* into multiple commits, you can+combine types with `/`: `FEAT/CI: <Summary>`++### Scope+What area is the change about. For now we don't have fixed scope keywords. A scope could be something like `ui`, `client`,+`server`, `ice`, `grpc`, ...+++### Summary+The summary is the heart of the subject line. It should contain a **very brief** summary of what you did in that commit.+In order to make this as short as possible, you may use grammatically incorrect sentences+("Add ability" instead of "add the ability")++In general the summary should answer the question "Applying this commit will ..." where "..." is your summary.++If your summary contains "and", you should probably split your commit up.++Note: Issue references (such as #2305) **must not** be used in the summary!+++## Message Body+Here you give more details about the commit. Why is it necessary and what are the details of the change. You can use+multiple paragraphs for this and be as verbose as you want.++The message body should reference issues that are related to this change, but also provide a short summary of what that+issue is about (so that it can be understood without having to open that issue).++The message body should contain enough information for someone to be able to look at this commit at some point in the+future and know exactly what it does and why it was needed.++## Footer+the footer contains a list of issue references prefixed by a keyword like `Closes`, `Fixes` or `Implements`.+If you only referenced an issue without implementing or fixing it, use `Ref.`

If it’s related I would still want to know how it is related (without following and reading up on the referenced thing).

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy

Paragraphs being separated by empty lines I guess? So it also makes sense for headlines, list blocks and code blocks? Makes sense to me at least.

You would have to check the linter reasoning. I became familiar with it through the vs code addon for markdown linting.

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble

Fix overlay

Tested on Win 10 x64 with TF2 (original issue report). With these changes it works again.

I plan to take a look at the code changes as well though, including those from the previous PR.

Krzmbrzl

comment created time in a month

issue openedmumble-voip/mumble

Overlay does not work anymore in 1.3.1

The Overlay does not work anymore in 1.3.1.

Desktop:

  • OS: Windows 10 (should be an issue for all)
  • Version: Mumble 1.3.1

PR #4041 disabled the overlay by default. It includes commit aac3214d4be2ba31c852619bc8d3666391dcd02a which improves the code base, but introduces a regression. In introduces the createPipe method, moves initialization code there but never calls it.

created time in a month

Pull request review commentmumble-voip/mumble

Fix overlay start

 QRectF OverlayGroup::boundingRect() const { }  Overlay::Overlay() : QObject() {-	d = NULL;+	d = nullptr; -	platformInit();-	forceSettings();+	m_initialized.store(false); +	qlsServer = nullptr;++	QMetaObject::connectSlotsByName(this);+}++Overlay::~Overlay() {+	setActive(false);+	if (d) {+		delete d;+	}++	// Need to be deleted first, since destructor references lingering QLocalSockets+	foreach(OverlayClient *oc, qlClients)+	{+		// As we're the one closing the connection, we do not need to be+		// notified of disconnects. This is important because on disconnect we+		// also remove (and 'delete') the overlay client.+		disconnect(oc->qlsSocket, SIGNAL(disconnected()), this, SLOT(disconnected()));+		disconnect(oc->qlsSocket, SIGNAL(error(QLocalSocket::LocalSocketError)), this, SLOT(error(QLocalSocket::LocalSocketError)));+		delete oc;+	}+}++void Overlay::setActive(bool act) {+	if (!m_initialized.load()) {+		platformInit();+		forceSettings();+	+		m_initialized.store(true);+	}++	setActiveInternal(act);+}++void Overlay::createPipe() {

Regression: createPipe() is introduced but never called.

Krzmbrzl

comment created time in a month

issue commentmumble-voip/mumble-www

Travis CI: Fastly 503 first byte timeout when accessing MXE mirror

So we can close it? Did you want to leave it open for something? Is there something left to check or verify?

mkrautz

comment created time in a month

startedwixtoolset/wix3

started time in a month

push eventmumble-voip/mumble-releng-vcpkg

Jan Klass

commit sha dbd627108ca75604b0c35edc7bad48aa2cd0a864

README: Update and extend installer documentation

view details

push time in a month

issue closedmumble-voip/mumble

Provide better download UX on landing page

Ideally we would like the main page to present the user with an obvious way to download the current mumble stable and snapshot release. The current stable should be emphasized. Still there should be an obvious way to download the snapshot as well as versions for other platforms (and maybe even legacy versions).

Here a basic mockup of what I have in mind:

image (this is what a Windows user with 64bit architecture would see)

Imho the sanest way to implement this would be using some JavaScript which detects client platform and architecture and replaces the old table accordingly (providing proper fallback if something fails). The old table could also be displayed when the user asks for other platforms.

closed time in a month

hacst

issue commentmumble-voip/mumble

Provide better download UX on landing page

Implemented through the new website and mumble-www repo.

A suggested-by-os version is planned to improve it further.

hacst

comment created time in a month

issue closedmumble-voip/mumble

Roadmap update?

Citing https://wiki.mumble.info/wiki/1.3.0, aside from that roadmap page, I can't find any discussion on the progress towards 1.3.0. It's really hard to justify mumble over discord when mumble hasn't provided any news since "Progress Report: April 2017".

I'm sure it's not been an easy task, but relying on people to look at github commits to see that the project is still active isn't the way to go.

closed time in a month

nja0087

issue commentmumble-voip/mumble

Roadmap update?

1.3.0 has been released last year. We are migrating away from the Wiki. The extensive 1.3.0 changelog can be seen in our announcement on the website. The roadmap in the wiki is deprecated and will migrate or disappear in the mid- to long-term.

nja0087

comment created time in a month

issue closedmumble-voip/mumble-www

Link third party Mumla on Google Play Store

You may add https://play.google.com/store/apps/details?id=se.lublin.mumla and/or https://play.google.com/store/apps/details?id=se.lublin.mumla.donation

closed time in a month

quite

push eventmumble-voip/mumble-www

Jan Klass

commit sha d133116170fca06501941603f2f2768ad189b461

Downloads: Link play store version of third party Mumla (Android) Resolves #99

view details

push time in a month

issue closedmumble-voip/mumble-www

Provide download link for latest AppImage

See the title above

closed time in a month

Lvaskz

issue commentmumble-voip/mumble-www

Provide download link for latest AppImage

08734d6ccd3b13e18664a5c47a6287a2c67f51f0

Lvaskz

comment created time in a month

push eventmumble-voip/mumble-www

Davide Beatrici

commit sha 1bbd70b064ca0ad7be42ded0e8cbff096d0a0d71

Add icon for AppImage Based on https://github.com/AppImage/AppImageKit/blob/master/resources/appimagetool.svg. I only kept the rounded square, the arrow, the gear and the circle in it. - The colors are changed (pure black for the square and circle, pure white for everything else). - The document size is changed to match the other icons' resolution (448x512). - The square size is increased as much as possible (448x448). - The arrow and gear are aligned and resized.

view details

Davide Beatrici

commit sha b8bab81f97d44b8e6277bcf0915d8772d9d1b92e

Content: add download links for AppImage

view details

Jan Klass

commit sha a606e6902b57ecab74bad8c8242af32ec22cd23f

Implement stable appimage download link

view details

Jan Klass

commit sha 6e71518a95e9bc4b555e164db8614834874ebbb0

Drop AppImage snapshot These files are in the dl snapshot subfolder. Hence a simple adding of the regex is not enough.

view details

Jan Klass

commit sha 08734d6ccd3b13e18664a5c47a6287a2c67f51f0

Merge PR #71: Add AppImage stable download Closes #71

view details

push time in a month

PR closed mumble-voip/mumble-www

Reviewers
Add download links for AppImage

Fixes #64.


The icon is based on https://github.com/AppImage/AppImageKit/blob/master/resources/appimagetool.svg.

I only kept the rounded square, the arrow, the gear and the circle in it.

  • The colors are changed (pure black for the square and circle, pure white for everything else).
  • The document size is changed to match the other icons' resolution (448x512).
  • The square size is increased as much as possible (448x448).
  • The arrow and gear are aligned and resized.

mumble-www-appimage


This should be merged after #70.

+21 -0

1 comment

3 changed files

davidebeatrici

pr closed time in a month

push eventmumble-voip/mumble-releng-vcpkg

Jan Klass

commit sha bad67b35c537e16e4d64cbd1e7052893cb17e9ca

README: Fix typo

view details

Jan Klass

commit sha 19e7a0589ba7e12f4620e57929d63450147551d7

README: Add done prebuilt win package to roadmap

view details

Jan Klass

commit sha b566403f242218fcd53cc120ae2af573e465c5f7

README: Improve build instructions and documentation (CLI + VS) Improve linux vs windows information, fix Windows default build instructions, fix subfolder build instructions - be more explicit and follow through on the recommendation, document options, format in tables, add actionable numbered actions

view details

push time in a month

issue commentmumble-voip/mumble

murmur: each connection to the server is counted as a "user"

Yeah, user count should reflect accepted Mumble connections count. Not TCP connection count.

botanegg

comment created time in a month

issue closedmumble-voip/mumble-theme

Help Icon

We maybe want to add a help icon in the configuration options, to show additional information (e.g. regarding echo-cancel etc.). For a first concept see: https://github.com/mumble-voip/mumble/issues/4127#issuecomment-637568229

Maybe someone could provide a good looking icon that is also consistent with the overall theme.

closed time in a month

toby63

issue commentmumble-voip/mumble-theme

Help Icon

I don’t think this ticket is actionable then. It’s unclear what for, and who would do this. As it is an icon could be created or chosen and then not be used. We can do that once the idea and commitment to it being used is stronger.

toby63

comment created time in a month

startedmre/tinysearch

started time in a month

issue commentmumble-voip/mumble

Ubuntu PPA: builds for 20.04 Focal Fossa

Are there any plans for this to be added?

Yes

We have not gotten to it yet.

timvisee

comment created time in a month

issue commentmumble-voip/mumble-theme

Help Icon

This ticket is not specific or actionable.

What specifically do you want this ticket to represent? What specifically are you asking for or suggesting here in the mumble-theme context?

toby63

comment created time in a month

issue commentmumble-voip/mumble-www

Opening `https://mumble.info/` asks for a user certificate

This is an issue despite redirects.

Kissaki

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy+- **Each change goes into its own commit**. If you want to summarize what you did with this commit (in the commit message)+and you start using the word "and", you probably want to split the commit up into 2 or more individual commits.+- **Each commit should compile** (try to make each commit self-contained so that it is possible to compile the code at+each commit)+- **Don't be lazy** when composing the commit message. In order to have a good git-history the commit messages are essential.+Also if you put effort into the commit-message, you'll save work when creating a PR as the description is already available.++# Commit message+Commit messages should follow the scheme+```+TYPE(Scope): Summary++Message Body++Footer+```++The blank lines in between are mandatory. A commit **must** include a `TYPE` and a `Summary` and **may**+additionally contain any of the other components listed here.++## Subject line+The first line ("Subject line") should not exceed 50-70 characters. This is what gets displayed on GitHub at first glance, so it+should contain the most important information. In order for it to be as short and precise as possible, there is the `TYPE` and+optionally a `Scope`. With these it should already be clear what this commit is about in general. The short summary should+then include further information that is important to understand the general idea of this commit at a glance.++### TYPE+The `TYPE` is one of the following:+| **TYPE** | **Description** | **Example** |+| -------- | --------------- | ----------- |+| BREAK    | A breaking change - not backwards-compatible. | A change in protocol (e.g. change UDP message format) |+| FEAT     | Introduction of a new feature (or extension of an existing one) | |+| FIX      | A bug fix | |+| FORMAT   | Change of formatting - does not influence how the code works | Change indentation of a line; Add braces around `if` body |+| DOCS     | Changes to the documentation (either in-source or out-of-source) | Add a Doxygen comment to a function |+| TEST     | Adds, changes or removes a test-case | |+| MAINT    | Maintenance - Change of non-code files | Change of the README |+| CI       | Changed something for the CI (continous integration) | Update TravisCI to use newer ubuntu version |+| REFAC   | Code refactoring | Renamed variable `x` to `y` |++The `TYPE` has to be in **all-uppercase** in order for it to stand out.++If you feel like you need to use 2 or more types for a single commit but *can't split it* into multiple commits, you can+combine types with `/`: `FEAT/CI: <Summary>`++### Scope+What area is the change about. For now we don't have fixed scope keywords. A scope could be something like `ui`, `client`,+`server`, `ice`, `grpc`, ...+++### Summary+The summary is the heart of the subject line. It should contain a **very brief** summary of what you did in that commit.+In order to make this as short as possible, you may use grammatically incorrect sentences+("Add ability" instead of "add the ability")++In general the summary should answer the question "Applying this commit will ..." where "..." is your summary.++If your summary contains "and", you should probably split your commit up.++Note: Issue references (such as #2305) **must not** be used in the summary!+++## Message Body+Here you give more details about the commit. Why is it necessary and what are the details of the change. You can use+multiple paragraphs for this and be as verbose as you want.++The message body should reference issues that are related to this change, but also provide a short summary of what that+issue is about (so that it can be understood without having to open that issue).++The message body should contain enough information for someone to be able to look at this commit at some point in the+future and know exactly what it does and why it was needed.++## Footer+the footer contains a list of issue references prefixed by a keyword like `Closes`, `Fixes` or `Implements`.+If you only referenced an issue without implementing or fixing it, use `Ref.`

I do not think there are any good reasons to use Ref. Or do you intent to duplicate references from earlier in the commit message? Because that is not written here.

Simple references should be described within the commit message. A simple reference is non-telling, not informative. Because the question would be: What kind of reference? Why does it reference it?

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble

MAINT: Create commit guidelines

Missing secondary footer (functionality) like

Co-Authored-By: Author <author@example.com>

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble

MAINT: Create commit guidelines

I think it is worth establishing context and goals as in describe how features will have multiple commits and then a PR and (equal) merge commit with summarizing the changes as a whole.

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy+- **Each change goes into its own commit**. If you want to summarize what you did with this commit (in the commit message)+and you start using the word "and", you probably want to split the commit up into 2 or more individual commits.+- **Each commit should compile** (try to make each commit self-contained so that it is possible to compile the code at+each commit)+- **Don't be lazy** when composing the commit message. In order to have a good git-history the commit messages are essential.+Also if you put effort into the commit-message, you'll save work when creating a PR as the description is already available.++# Commit message+Commit messages should follow the scheme

maybe better must follow or just follow

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy+- **Each change goes into its own commit**. If you want to summarize what you did with this commit (in the commit message)+and you start using the word "and", you probably want to split the commit up into 2 or more individual commits.+- **Each commit should compile** (try to make each commit self-contained so that it is possible to compile the code at+each commit)+- **Don't be lazy** when composing the commit message. In order to have a good git-history the commit messages are essential.+Also if you put effort into the commit-message, you'll save work when creating a PR as the description is already available.++# Commit message+Commit messages should follow the scheme+```+TYPE(Scope): Summary++Message Body++Footer+```++The blank lines in between are mandatory. A commit **must** include a `TYPE` and a `Summary` and **may**+additionally contain any of the other components listed here.

missing word contain

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy+- **Each change goes into its own commit**. If you want to summarize what you did with this commit (in the commit message)+and you start using the word "and", you probably want to split the commit up into 2 or more individual commits.+- **Each commit should compile** (try to make each commit self-contained so that it is possible to compile the code at+each commit)+- **Don't be lazy** when composing the commit message. In order to have a good git-history the commit messages are essential.

I agree. It should be forumlated positively. And 'don't be lazy' is not a good general philosophy. I feel like this is too specific, not abstract enough for a general philosophy.

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble

MAINT: Create commit guidelines

We will probably have more guidelines, so I would rather put them into a subfolder for that?

docs/contribution-guidelines/? docs/project-guidelines?

Krzmbrzl

comment created time in a month

Pull request review commentmumble-voip/mumble

MAINT: Create commit guidelines

+# General philosophy

I would follow markdownlint recommendations and put empty lines after newlines.

Krzmbrzl

comment created time in a month

pull request commentmumble-voip/mumble-www

WIP: Implement public server list

This was ready. And worked. But the fastly configuration changed and cross site loading didn't work anymore, unclear to me what or who changed it.

I presented it when it worked but did receive little response. That’s why it’s still sitting here like this.

Kissaki

comment created time in a month

issue commentmumble-voip/mumble-theme

Help Icon

I would much rather have a descriptive label or intro text in the groubbox than a help button that needs an entire row of space anyway.

I would also prefer a ticket to be self-sufficient. If you want to reference issues why not link them directly?

toby63

comment created time in a month

issue commentmumble-voip/mumble-theme

Help Icon

This should be in the mumble repository, no? The theme only visually styles stuff. It does not introduce or remove controls.

toby63

comment created time in a month

push eventmumble-voip/mumble-www

Jan Klass

commit sha b79879e7a9f80f5fa3e80f870f2366f006dfafc1

Downloads: Add reference to source code on GitHub

view details

push time in a month

pull request commentmumble-voip/mumble-www

Restructured downloads.md

Yeah I left the double ubuntu and PPA for now. They are separate but they each do a slightly different thing. And they present differently; with an icon and command line. For now I will leave it like this until the next iteration of improvements. Because I don't want to move the icon down as-is, as the big icon it is.

Yeah I guess a Repository and source link would be good.

toby63

comment created time in a month

issue closedmumble-voip/mumble-www

[Request] Changes for index.html

I would like to suggest some changes to the main site of mumble.info:

Additions:

  • mumble is server-based This could maybe be stated more prominently. Also that users are of course able to create their own servers.

Changes:

Extendible through Ice and GRPC protocols

gRPC is not auto-enabled/-implemented yet. And it is also buggy.

but finds good use in many different environments as well.

I don't think everyone understands what that exactly means. My suggestion, use the word "usecases" instead of environments.

Administrators appreciate Mumble for being able to own their and their users data.

This is not such a good formulation. It would be better like this: You can setup your own server, which will manage all the user data. (Not perfect this way, an addition would be to say that no third party is necessary or gets the data)

Discussible changes:

  • Ice or better most software for it is outdated, so the mentions of that should maybe be reduced or clarified
  • In-game Overlay: I am no expert at this, because I don't use it, but the issues indicate numerous problems with it, so maybe you could at least add something like: partial support for or many games support
  • always encrypted communication: while it is true, it creates the impression that End-to-End-encryption is implemented, which is not the case, so I would add always encrypted communication between server and client (user)

closed time in a month

toby63

issue commentmumble-voip/mumble-www

[Request] Changes for index.html

c19de714f3a7473278c661982fc326356973ecab 84b79a2f78202174e4db39d1b4e3d4b489b89fad f8b5400abc6d340e06b3671232badd672fa2b5f5

toby63

comment created time in a month

push eventmumble-voip/mumble-www

Jan Klass

commit sha c19de714f3a7473278c661982fc326356973ecab

Drop mentions of gRPC from homepage As it is not included in default and official builds, and it still has some unfixed issues. https://github.com/mumble-voip/mumble/issues?q=is%3Aopen+is%3Aissue+label%3AgRPC https://github.com/mumble-voip/mumble/issues/4197

view details

Jan Klass

commit sha 84b79a2f78202174e4db39d1b4e3d4b489b89fad

Improve intro text

view details

Jan Klass

commit sha f8b5400abc6d340e06b3671232badd672fa2b5f5

Improve wording on data security

view details

push time in a month

issue closedmumble-voip/mumble-www

Set up a form on the website to report issues

<agris> I do not have a Microsoft/Github account as I do not accept the privacy policy and terms of service. Is there another way to open a ticket?
<davidebeatrici> I understand. Would you like me to open an issue for you?
<agris> If there is no other way, I would appreciate that. However if that is so, would you mind opening another ticket about having a way to contribute without a Microsoft account?

closed time in a month

davidebeatrici

delete branch mumble-voip/mumble-www

delete branch : f/downloads-shortcodes

delete time in a month

push eventmumble-voip/mumble-www

Jan Klass

commit sha fdff690c7482e3af9b6baa67061edd7a4078b20f

Fix link to third party Mumblefy

view details

Jan Klass

commit sha f7f7736216bd6f525c2e77464be0f2c7f3f78196

Drop third party Mumblefy iOS app which has 1.7 star rating

view details

Jan Klass

commit sha d51e26ce8fd4271a033aad2c2b52272c012c313b

Downloads: Add more downloads, information and categories Closes #92 Co-authored-by: Tobias Gerold <tobias@g3ro.eu>

view details

Jan Klass

commit sha cef67104a3cc8fa2a78545c7b45e0ab83316c2f6

Downloads: Use shortcodes instead of HTML in markdown

view details

Jan Klass

commit sha aaa34e2adc586c8b2b4bdc4954e52a2737e462de

Downloads: Add macOS install warning notice information Resolves #97

view details

Jan Klass

commit sha 505cf6bac7d90a51c0e52aa531b923c2b75aa1cf

Style: Add missing em and i styles

view details

Jan Klass

commit sha 77bd8f93c57fb8ac8a6885552968bc8c78e83353

WIP Downloads: Implement suggested download; add more downloads and categories

view details

push time in a month

issue closedmumble-voip/mumble-www

add download as snap link

under "Download Mumble" section add link to the snap store https://snapcraft.io/mumble

1.3.0 is already in the snap store

closed time in a month

pixelr0

issue commentmumble-voip/mumble-www

add download as snap link

This was implemented in d51e26ce8fd4271a033aad2c2b52272c012c313b

pixelr0

comment created time in a month

issue commentmumble-voip/mumble-www

Add an About page

The homepage has the main section “About Mumble”.

toby63

comment created time in a month

push eventmumble-voip/mumble-www

Jan Klass

commit sha aaa34e2adc586c8b2b4bdc4954e52a2737e462de

Downloads: Add macOS install warning notice information Resolves #97

view details

Jan Klass

commit sha 505cf6bac7d90a51c0e52aa531b923c2b75aa1cf

Style: Add missing em and i styles

view details

push time in a month

issue closedmumble-voip/mumble-www

Add macOS download notice about installation warning (non-signed app)

As raised and discussed in https://github.com/mumble-voip/mumble/issues/4263 we should add a notice to the downloads page to prepare users for the expected warning.

closed time in a month

Kissaki

issue commentmumble-voip/mumble-theme

Theme variants using FontAwesome

I feel like Mumble/the UI is getting way too complex. Who’s supposed to understand all that? 🤔

xpoke

comment created time in a month

push eventmumble-voip/mumble-www

Jan Klass

commit sha cef67104a3cc8fa2a78545c7b45e0ab83316c2f6

Downloads: Use shortcodes instead of HTML in markdown

view details

push time in a month

delete branch mumble-voip/mumble-www

delete branch : f/downloads-extend

delete time in a month

pull request commentmumble-voip/mumble-www

Restructured downloads.md

I credited you as a co-author in the commit.

toby63

comment created time in a month

pull request commentmumble-voip/mumble-www

Restructured downloads.md

Thank you for your suggestions and inspiration.

I tried a few things but ultimately ended up in a categorisation half-way to yours. I did not add them where not necessary though in order not to unnecessarily bloat the page and its vertical space use.

You added a link to the install wiki page. But I decided to integrate the useful information from there on in the content instead.

I also added some more information about various things.

toby63

comment created time in a month

more