profile
viewpoint
Jan Klass Kissaki Germany https://kcode.de/ B.Sc. in Applied Computer Science. Working as a Software Engineer since 2011. Doing some server administration as well. FOSS contributor.

startedmdibaiee/awesome-lite-websites

started time in 2 days

issue commentmumble-voip/mumble

The command setting superuser password returns exit code 1 even if successful.

How do you read out the superuser password?

The log says it set it for (virtual) server 1. Is that the one you are checking or possibly a different one?

nekatak

comment created time in 4 days

issue commentmumble-voip/mumble

Setting superuser password with mumble-server user fails silently

From the log you posted the significant line here that shows the issue is

<W>2019-12-05 12:33:32.768 Initializing settings from /var/lib/mumble-server/.murmurd/murmur.ini (basepath /var/lib/mumble-server/.murmurd)

As you can see it does not use the configuration file in /etc/mumble-server.ini that you provided as an argument but /var/lib/mumble-server/.murmurd/murmur.ini.

Obviously it should throw an error here IMO if it can not read the provided path. But looks like it just falls back to a default path.

nekatak

comment created time in 4 days

issue commentmumble-voip/mumble

Mumble breaks Bluetooth Driver when using Wireless headset

Related to the overlay, we should take a look.

So with the Overlay disabled entirely, and Mumble restarted, does the issue occur?

I would also suggest increasing the Jitter-Buffer in the Audio Output settings. We had users report issues with USB headsets and their drivers faulty handling of it breaking in some way.

racabu

comment created time in 4 days

push eventKissaki/smite-resources

Jan Klass

commit sha 69f94b0c14ae5f8aa663ef3df0cb00ff3330bf49

Data update but keep Zhong Kui which was removed from the API data (probably disabled temporarily) Two Scylla skins removed? Terror of the Deep and Godscylla?

view details

push time in 6 days

pull request commentmumble-voip/mumble

Shutdown and drain gRPC completion queue on exit

The commit message of 1d2e5b090af1a02e7bbdf8bf3bbf679635834645 was not fixed.

McKayJT

comment created time in 10 days

issue commentmumble-voip/mumble

Make Mumble client not overwrite the Mumble.conf file when run

AFAIK we make use of Qt functionality for transparent configuration handling so this may not be easy to do from our consumer side of that. So the first step would be checking on that, how we use the Qt functionality and what options the API provides in that regard.

asheeshr

comment created time in 10 days

issue commentmumble-voip/mumble

No new snapshot since March 2019

If our buildenv is able to release 1.4.0/master snapshots (with little effort) I think it would still be worthwhile to do so. As was pointed out master already contains some changes that are worth to be tested (or used). We don’t lose anything by doing so, and (from my limited view) I am not confident in the buildenv working in the (very) short term but only mid term - in a few weeks time rather than few days.

I think build env progress information would be better fit in a corresponding ticket on the build env. Although if it is a blocker to a snapshot release I guess updates on that are helpful here as well.

Either way this ticket should be renamed to either a feature request or a task. As we do plan to release one eventually I think it should be a task rather than a feature request.

trudnorx

comment created time in 10 days

issue commentmumble-voip/mumble

Is there a way to generate the client certificate via the command line in Linux?

No, I am not aware of any such functionality.

You can pass -h or --help to list the available CLI arguments.

The argument code for the Mumble client is at main.cpp#L144-L255. Nothing of the sort there.

To be honest I would expect this to be one of the easier tasks to implement, even if not trivial. But it is rather localized and touches only two distinct components (cert gen and cli arguments).

If this setting is left empty there is no generating of the cert? No wizard is shown? You could instruct users to run the certificate wizard on first use.

asheeshr

comment created time in 10 days

startedbaowenbo/DAIN

started time in 11 days

issue commentmumble-voip/mumble

Make Superuser remain accessible even through bans

We may want to provide a configuration setting to disable that though. But maybe in those cases simply disabling the account (unsetting the password) would be preferable and acceptable. That would save us the configuration setting and its implementation.

Stefan-comkmits

comment created time in 11 days

issue commentmumble-voip/mumble

Superuser Banned

I was thinking that root access (or a provided web access by a hoster) where you would also set or disable the superuser would be acceptable, or possibly preferably.

But I agree now that we should probably also allow a workflow where that access is not available. In that case the superuser password is set and the login needs to remain accessible in all cases as the fallback.

Stefan-comkmits

comment created time in 11 days

pull request commentmumble-voip/mumble

shudown and drain gRPC completion queue on exit

Typo in commit message title “shudown”

McKayJT

comment created time in 11 days

issue commentmumble-voip/mumble

No new snapshot since March 2019

@davidebeatrici Any ETA? Or where one would be able to track progress to stay up to date on what is still open?

trudnorx

comment created time in 13 days

issue commentmumble-voip/mumble

Superuser Banned

That is assuming authentication is valid and non-destructive. Supposed your superuser password got leaked, for one reason or another, but the user or malicious participants ip network is banned, then disregarding bans on superuser authentication would be a big problem.

Another thing to consider is that banning could be an effective counter-measure for specific types of DoS attacks; if the aggressor were spamming authentication requests. Again, disregarding bans on superuser authentication would open that door again.

Stefan-comkmits

comment created time in 13 days

issue commentmumble-voip/mumble

TTS Speech Language stuck on English

The Windows 10 speech settings do not actually have a setting to define the TTS output language.

It does have a list of installed, supported voice languages though.

image

So it must be Mumble telling Windows 10 the desired language / Win10 expecting Mumble to do so.

Changing the Mumble UI display language does not change the TTS language.

BOUSILLOR

comment created time in 15 days

issue commentmumble-voip/mumble

Superuser Banned

Would you want or expect user certificate bans to be ignored on SuperUser logins as well?

Feel free to create a feature request for that with your reasoning.

I think this ticket is a bit too unspecific. It was useful to find a common understanding, but probably did its job now and can be closed?

You also said

I think there is more Information needed, about Ban status to the User

which was not specified yet. Where do you want more information? The login deny explicitly states that it is a global ban that denies it.

Stefan-comkmits

comment created time in 15 days

issue commentmumble-voip/mumble

No new snapshot since March 2019

Yes it is. I am not sure about the state of changes, or if we want to release one in the current state though.

@davidebeatrici Your thoughts?

trudnorx

comment created time in 15 days

issue commentmumble-voip/mumble

ACL question; mumble automatically adds a write ACL rule

@wjtk4444 Do you have new information regarding this?

wjtk4444

comment created time in 16 days

issue commentmumble-voip/mumble

tts stuck on win10

I don’t understand what you are trying to say.

There is no TTS selection in the Mumble installer.

BOUSILLOR

comment created time in 16 days

issue commentmumble-voip/mumble

Multisent when Packet Loss.

The communication happens over two channels: The control channel uses TCP and the voice data channel UDP.

TCP makes sure transmission never loses information.

Voice data is time-critical, and once a critical time has passed delivering them late is of no use because that (buffer) time has passed.

Can you elaborate where you would want this? If the client notices packet loss on the UDP channel it should flood the network in hopes that if 30% gets lost pushing every packet twice will decrease it to 0.3 * 0.3 = 0.09?

That’s a lot of assumptions on the behavior of the networking. The percentages are not necessarily consistent with rate/data-width.

If the packet loss is because of network overload it could make the situation worse instead of better.

Do you experience regular packet loss? I feel like, at least where I am, this is not worth the effort at all. Not on the implementation side, nor performance side, nor the wasteful network usage.

Stefan-comkmits

comment created time in 16 days

issue commentmumble-voip/mumble

No new snapshot since March 2019

What do you want a new snapshot for?

trudnorx

comment created time in 16 days

issue commentmumble-voip/mumble

No new snapshot since March 2019

Currently no plans for 1.3.1. The 1.3.1 milestone hast just one bug to be fixed.

Generally the patch releases are for bug and security fixes, not feature releases. Adding more features could introduce new issues reducing stability of the release.

The focus should be 1.4.0 instead. I feel like we already have too many big changes in the pipeline, but those are necessary (tech upgrades for future maintainability).

trudnorx

comment created time in 16 days

issue commentmumble-voip/mumble

No new snapshot since March 2019

1.4.0 was released in August.

trudnorx

comment created time in 16 days

issue commentmumble-voip/mumble

[Discussion]: Get rid of global member variables

I’m not reading the full text now, but from the topic: Getting rid of the global state/variable has always been a wish and goal, at least ever since I have been here, so at least 10 years.

It is not a question of desire or acceptance but of effort, time resource and priority.

Krzmbrzl

comment created time in 16 days

issue commentmumble-voip/mumble

Superuser Banned

@Stefan-comkmits So what you are saying is an ip-banned user should be able to log in to the superuser account?

I don’t think I agree with that. A ban is a ban, and for a reason.

Stefan-comkmits

comment created time in 16 days

issue commentmumble-voip/mumble

Superuser Banned

The bans can contain any one or multiple of:

  • IP address (individual or ranges)
  • username/nickname
  • certificate hash = user identification (a registered user will always be this, but it also works if the user is not registered as long as they keep their user certificate)

From the ban list / ban editor:

image

Doesn’t the add ban dialog already provide choices for this? I can't test here without users.

Stefan-comkmits

comment created time in 16 days

startedzauonlok/renderer

started time in 17 days

create barnchKissaki/mumble-ping

branch : f/debug-packets

created branch time in 17 days

created tagKissaki/mumble-ping

tagv0.1.0

created time in 17 days

push eventKissaki/mumble-ping

Jan Klass

commit sha 6731b06225e32d147fe76ba6580e0c0ce6ab31d9

Add README.md

view details

Jan Klass

commit sha 4f9d9d9c8cda428e6ead88c4cfc2262d6d5e42f5

Add publish and package bat scripts

view details

push time in 17 days

create barnchKissaki/mumble-ping

branch : master

created branch time in 18 days

created repositoryKissaki/mumble-ping

created time in 18 days

startedthomaspark/gridgarden

started time in 18 days

starteddylanaraps/pywal

started time in 25 days

starteddylanaraps/fff

started time in 25 days

starteddylanaraps/pure-bash-bible

started time in 25 days

startedkoalaman/shellcheck

started time in 25 days

issue commentmumble-voip/mumble

ACL question; mumble automatically adds a write ACL rule

Yes, the ACL server will make sure users do not lock themselves completely out from access.

There is also a bit of a UI issue in that the editor will accept and save ACL permissions as seen, but on saving add the additional ACL rule that prevents lockout.

I won't test anything today, so maybe you can confirm this yourself: Is this indeed only after another moderator edited the ACL, or is this perhaps before, after the ACL has been saved (and you can already see it upon reopening the ACL editor).

What confuses me a bit is why the new rule would be added if you do not deny edit ACL. I guess it gets added when enter is denied? That seems… unnecessary. Because with edit ACL the user could still give themselves permission again.

wjtk4444

comment created time in a month

pull request commentmumble-voip/mumble

README.md: add Shield.io badges

I think it doesn't hurt to have it in the Readme as well

Not only does it not hurt, I consider it an absolute must. The GitHub website is not the only interface that is used for the code repository. The readme is more than just a configuration for this website.

I see it has been added again, so all good. I just wanted to point this out.

davidebeatrici

comment created time in a month

issue commentdotnet/dotnet-api-docs

Use https instead of http for links whenever possible

A lot of example code uses pseudo-company and domain names like www.contoso.com and others (already saw two others in this repo’s content, but there are many more MS apparently uses).

Those domains redirect to microsoft.com on http, but do not respond on https. Any chance to make https work on those? Then we could update those as well.

(I don’t get why example.com or example.org is not used though. That would make it easier as they are reserved invalid. A branding thing on example code?)

mairaw

comment created time in a month

issue commentdotnet/dotnet-api-docs

Use https instead of http for links whenever possible

There are a few links to go2.microsoft.com. The link IDs seem to work with go.microsoft.com as well.

Is there any guidelines on what should be used? And should this be adjusted to be consistent?

Only 5 links use go2. 3645 use go.

I would guess it would make sense to use go everywhere?

(This is not specifically for this ticket, but I noticed it when working on this.)

mairaw

comment created time in a month

PR opened dotnet/dotnet-api-docs

Reviewers
Upgrade links to https and fix msdn link captions

Contributes to #1200

+905 -905

0 comment

563 changed files

pr created time in a month

create barnchKissaki/dotnet-api-docs

branch : https-links2

created branch time in a month

PR opened dotnet/dotnet-api-docs

Reviewers
Upgrade go.microsoft.com links to https

Contributes to #1200

+791 -791

0 comment

508 changed files

pr created time in a month

create barnchKissaki/dotnet-api-docs

branch : https-links

created branch time in a month

fork Kissaki/dotnet-api-docs

.NET API reference documentation (.NET Framework, .NET Core, .NET Standard and Xamarin)

https://docs.microsoft.com/dotnet/api/

fork in a month

PR opened mumble-voip/mumble-www

Reviewers
Style: Add W indicator to links to our wiki enhancement

Fixes #77

image

image

+7 -0

0 comment

1 changed file

pr created time in a month

create barnchmumble-voip/mumble-www

branch : f/wiki-link-style

created branch time in a month

pull request commentmumble-voip/mumble-www

Docs: Add documentation section and migrate Ice documentation

Please make sure to include the PR description in the Merge commit if you merge.

Kissaki

comment created time in a month

PR opened mumble-voip/mumble-www

Reviewers
Docs: Add documentation section and migrate Ice documentation docs
  • Add a landing page for documentation
  • Add a scripting page
  • Migrate Ice wiki documentation
    • Split into subpages
    • Adjust formatting to markdown
    • Drop very obsolete block (also removed from wiki)
    • Fix various errors, various improvements
    • More consistent and throughout use of markup

This change migrates the Ice documentation. It does not yet improve the layout for documentation, but will allow us to do so with some content and subpages.

For now an aside license and wiki link footer is added. This can probably be improved in the future by adding front matter and rendering it in the layout.

+642 -1

0 comment

9 changed files

pr created time in a month

create barnchmumble-voip/mumble-www

branch : f/docs-ice

created branch time in a month

PR opened mumble-voip/mumble-www

Reviewers
Slice: Add generated slice HTML documentation 1.2.0, 1.2.7, 1.3.0 docs

Up to now we host our slice documentation on http://mumble.sourceforge.net/slice/.

However, having this additional host and service separately makes no sense other than for historic reasons; keeping the old URLs in tact.

With more documentation moving to the website, it makes sense to integrate the slice documentation into the website as well.

1.2.19 still has the same slice definition as 1.2.7, so no generating necessary for that. The old site on mumble.sf.net also hosts the generated HTML for 1.2.0, 1.2.7 and (snapshot) 1.3.0. The 1.3.0 content added here is definitely of stable version 1.3.0.

Fixes #60

This documentation is generated with slice2html from Ice 3.6. Ice 3.7 no longer provides this binary, and instead refers to doxygen which generates complexer HTML. This means we will have to evaluate and decide on how we want to handle this in the future. See #75.

+17030 -0

0 comment

95 changed files

pr created time in a month

create barnchmumble-voip/mumble-www

branch : f/docs-slice

created branch time in a month

issue openedmumble-voip/mumble-www

Figure out how to generate slice documentation in the future

Our generated slice documentation has always been a very simple html file structure.

Ice 3.6 still contains the slice2html executable. Ice 3.7 does not and tells you to use doxygen, which supports slice.

See v3.6-Usingslice2html and v3.7 Using Doxygen for Slice Documentation.

The doxygen generated HTML documentation is a lot more complex and IMHO overkill, and reduces readability and discoverability instead of improving it.

We should explore and decide on how we want to handle this in the future. Possibly establish a (documented or automated) generation workflow.

Ice has moved from slice file and dynamic type usage to generated code for more languages (namely PHP as well). Arguably, the generated types are enough with a decent IDE. Although being able to link to types and read them without generated code available would be very useful at times.

This issue became apparent in #60.

created time in a month

issue commentmumble-voip/mumble-www

Implement documentation page

I think I will make this a multi part and partial process.

Migrate some content, then establish frontend tech like the page navigation, then menu navigation, and only then more content.

Seeing some of the content, I want to also improve the structure. Adding a hierarchical structure to our shitty wiki structure should yield a great improvement IMO.

Kissaki

comment created time in a month

startedalicevision/meshroom

started time in a month

issue commentmumble-voip/mumble-www

Migrate slice docs into this project

Ice 3.6 still contains the slice2html executable. Ice 3.7 does not and tells you to use doxygen, which supports slice.

  • https://doc.zeroc.com/ice/3.6/the-slice-language/generating-slice-documentation#id-.GeneratingSliceDocumentationv3.6-Usingslice2html
  • https://doc.zeroc.com/ice/3.7/the-slice-language/generating-slice-documentation#id-.GeneratingSliceDocumentationv3.7-doxygenUsingDoxygenforSliceDocumentation
Kissaki

comment created time in 2 months

issue commentmumble-voip/mumble-www

Implement documentation page

Mandatory Requirements

  • Figure out if and how to take over existing content (content history and copyright/author naming), maybe for each page individually

Wishes

  • Edit page link to allow easy submitting of PRs

General References of good documentation pages

  • docs.microsoft.com ** GitHub integration ** Page and in-page navigation and index ** Edit page via PR ** GitHub issues displayed and linked on pages
Kissaki

comment created time in 2 months

issue commentmumble-voip/mumble-www

Implement documentation page

  • [ ] Collect some requirements - mandatory and optional/wishes
  • [ ] Add a docs landing page
  • [ ] Migrate slice docs
  • [ ] Migrate server setup guide
  • [ ] Map out migration order (ACL, features, translation, FAQ, scripting, theming, development)
  • [ ] Figure out if and how to integrate (or just link) protocol documentation
Kissaki

comment created time in 2 months

issue commentmumble-voip/mumble

Mumble 1.3.0 release overlay crashes Black Ops II on Windows

Placing a file named debugoverlay next to the game executable will produce more debug output. Running DebugView alongside will provide some useful log information. In case you/someone wants to provide some more information without going the more complex debugger and symbols route. It could still allow us to get a better idea of when/where it happens.

If it’s a first run issue it should be reproducible as such. Personally I do not own the game, so no way to test.

ADAMPOKE111

comment created time in 2 months

issue commentmumble-voip/mumble

Update Qt version to 5.6.3 for Mumble 1.3

Changelog https://code.qt.io/cgit/qt/qtbase.git/plain/dist/changes-5.6.3?h=5.6

Anything that concerns us?

wildxthing

comment created time in 2 months

issue commentmumble-voip/mumble

TestPacketDataStream fails on ARM64

Added reference to missing make check mentioned in #3846; should be enabled once this is fixed.

davidebeatrici

comment created time in 2 months

push eventmumble-voip/mumble

Davide Beatrici

commit sha 9e1a5604d23a91ac15b1d8dba5138c536bb007f5

Remove CELT 0.11.0 CELT 0.11.0 provides better quality in comparison to CELT 0.7.0, but the two versions of the codecs are not compatible, which is why we provided both of them. Opus was introduced in Mumble 1.2.4 (7586a61226a5477ff1f6418f51acdab65fe093f4), thus we expect that most (if not all) users are using it. By removing CELT 0.11.0 we don't break backwards compatibility, because it's provided by CELT 0.7.0. The main reason for removing the codec is the fact that its discontinued (in favor of Opus). Also, CELT 0.11.0 was removed from the Debian package back in 2012: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682010

view details

Jan Klass

commit sha 856eefa9ba6deb79bf1da1e0a7379e7fb88ae187

Merge PR #2045: Remove CELT 0.11.0

view details

push time in 2 months

PR merged mumble-voip/mumble

Reviewers
Remove CELT 0.11.0 audio code

CELT 0.11.0 provides better quality in comparison to CELT 0.7.0, but the two versions of the codecs are not compatible, which is why we provided both of them.

Opus was introduced in Mumble 1.2.4 (7586a61226a5477ff1f6418f51acdab65fe093f4), thus we expect that most (if not all) users are using it.

By removing CELT 0.11.0 we don't break backwards compatibility, because it's provided by CELT 0.7.0.

The main reason for removing the codec is the fact that its discontinued (in favor of Opus).

Also, CELT 0.11.0 was removed from the Debian package back in 2012: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682010


Discussion at #1999.

+3 -550

1 comment

15 changed files

mkrautz

pr closed time in 2 months

pull request commentmumble-voip/mumble

Remove CELT 0.11.0

I see the CELTCodec011 class extends CELTCodec.

CELTCodecSBCELT does as well. Is that the 0.7.0 code? What does SB mean in this context?

Maybe it makes sense to unify them now? I haven’t looked at the code/separation.

mkrautz

comment created time in 2 months

issue closedmumble-voip/mumble

Change Coding Guidelines for commenting

In the Coding guidelines that can be found on https://wiki.mumble.info/wiki/Coding_Guidelines#Comments it states

Try to use comments in a sensible way. Don't comment the obvious (e.g. no setBla() "Sets bla") and don't feel obligated to comment every single parameter and function if the variable naming and types already make the behavior obvious.

Given that there are big parts of Mumble that aren't documented whatsoever, I think this is a really bad thing to tell new developers.

I'd suggest stating that everything should be documented. That means that each and every function should get a function header stating what that function does. Even if the functions is ? setBlaand the header for it isThis sets bla`. Remember that this is the only way for the function to be documented by e.g. Doxygen. This also means that the code itself should contain comments about what is going on at this particular point so that someone else looking at the code can see right away what the intention of that code section is.

I firmly believe that the legendary laziness of programmers will prevent a massive amount of unneeded comments in the source code - we don't explicitly need to tell them that they shouldn't comment everything.

And even if we get a bunch of unneeded comments, I'd say that this would still be better than having too few comments. After all I can skip comments I'm not interested in, but I can't magically create some that aren't there.

closed time in 2 months

Krzmbrzl

issue commentmumble-voip/mumble

Change Coding Guidelines for commenting

Given that no additional comments have been made from other people, I am closing this.

I am strongly against commenting everything as that only adds redundancy. At least in such a generic requirement being formulated. If it is meant weaker then it is not much different from the current guidelines anyway - which basically says comment where it makes sense. There is no formulation that will fit all cases, so that’s the best one to use.

Krzmbrzl

comment created time in 2 months

issue commentmumble-voip/mumble

Show Mute Status

You created the ticket on the wrong repository. The mumble-www repository is for the website. Davide moved it here to the correct place, the mumble repository which is for the application.

There are different kinds of muting. Speak deny as per server ACL permission, or a user acting as a moderator muting you for everyone on the server, or local muting by users only muting you on their end. I presume you mean local muting?

Local muting is an entirely client side muting state. Neither the server nor other clients know of it.

And I don’t really see why it should be announced to others.

Stefan-comkmits

comment created time in 2 months

startedPavelDoGreat/WebGL-Fluid-Simulation

started time in 2 months

push eventKissaki/smite-resources

Jan Klass

commit sha ef1110aa7e297cfb041075aa715cfa7407b6ec3a

Data update; new god Yemoja

view details

push time in 2 months

pull request commentmumble-voip/mumble

Add setting to toggle 24-hour time format for the chat

The OS has and provides information of regional and formatting settings. We should use that instead of duplicating those settings.

When was this issue introduced? 1.3.0? Or afterwards in the snapshots?

davidebeatrici

comment created time in 2 months

PR opened xunit/xunit.github.io

Update MSBuild Reference link

Update from outdated msdn link to current docs.microsoft.com link.

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventKissaki/xunit.github.io

Jan Klass

commit sha b4bf4a6eb9b36831b6290fab50163d86334f721d

Update MSBuild Reference link Update from outdated msdn link to current docs.microsoft.com link.

view details

push time in 2 months

fork Kissaki/xunit.github.io

Public site (please open issues in https://github.com/xunit/xunit)

https://xunit.net/

fork in 2 months

push eventKissaki/smite-resources

Jan Klass

commit sha 206851fafbcf2af7321f4fc6c93bab427e861734

Data update

view details

push time in 2 months

created tagKissaki/videocutter

tagv2.0.2

A Windows program for previewing, marking and cutting video

created time in 2 months

push eventKissaki/videocutter

Jan Klass

commit sha 172b3dd0ba2b3a04728115c069435ab490f7c22e

Code: Drop launchSettings.json

view details

Jan Klass

commit sha da025ef97569d5fecc1ec4233bbc9651f8bbafcc

Increment to version 2.0.2

view details

push time in 2 months

push eventKissaki/videocutter

Jan Klass

commit sha 2e93886e4efce1dfa03a8d5c019d62cc25b38895

GUI: On Marking play button click play if not playing

view details

Jan Klass

commit sha a4dff1d8076169eac13186d3d81544fa7abddf8e

Code: Fix formatting

view details

Jan Klass

commit sha 335eeb8a0d25b45557a44744c5c4f641f6aa94a6

Code: Fix play click method name

view details

Jan Klass

commit sha 0e52d67b32263bb4a5043ae40fe83949fe6105db

Code: Use of new JsonSerializer API

view details

Jan Klass

commit sha cd3b4c0e964e317f48badd968a9505897cd49d2b

Code: Add GitHub repo reference to project information

view details

Jan Klass

commit sha 90fb66f1a793200939dcc94b7365b723e4e875b6

Code: Add FxCopAnalyzers

view details

Jan Klass

commit sha 3251e586d8d1d05e90b06b751dcc3b925df06b0e

Code: Add AssemblyInfo.cs

view details

Jan Klass

commit sha 3f18e4852181799350e4961d0388a87d32f1f212

GUI: Add app icon

view details

Jan Klass

commit sha d0520517ed52c11953dc216c981e29f6592b8a57

Code: Remove PackageLicenseExpression from project file

view details

Jan Klass

commit sha b0c1f617d0ef83aa77c82d68ba65c014bc741dab

Code: Fix solution project reference

view details

Jan Klass

commit sha 37cef50dd907a304d3b71d0cd257d8ab37ac3a48

Code: Add editorconfig

view details

Jan Klass

commit sha 4ff683f9663650881facbcc019d38012e0b109f8

Code: Fix FxcopAnalyzers and Roslyn messages

view details

Jan Klass

commit sha 69716823115a23a1ed6613aa7d3d3eb13a7e93c0

Fix UI update on close exception

view details

push time in 2 months

issue openedMicrosoftDocs/visualstudio-docs

Use of const directly contradicts documentation on C# const keyword

This 'use const' rule takes a practical approach with focus on performance.

However, it directly contradicts the documentation on the C# const keyword.

From the const keyword documentation:

> Don’t create a constant to represent information that you expect to change at any time. For example, don’t use a constant field to store the price of a service, a product version number, or the brand name of a company. These values can change over time, and because compilers propagate constants, other code compiled with your libraries will have to be recompiled to see the changes.

By this definition const should not be used for all static readonly strings in general.

This documentation should at least mention this opposed interest and argue when it makes sense anyway, or when it does not make sense.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

created time in 2 months

issue commentmumble-voip/mumble

Modern Mumble Project Chat Platform

Looks like theirs is only providing an IRC server, not actually an IRC bridge to existing channels.

Krzmbrzl

comment created time in 2 months

issue commentmumble-voip/mumble

Modern Mumble Project Chat Platform

That doesn’t sound good for matrix.

I think we should take a look at Gitter then. See how well the IRC bridge works. As for noteworthy users, I know Jenkins uses it.

Krzmbrzl

comment created time in 2 months

pull request commentmumble-voip/mumble

Remove Speex (audio codec)

We retained support for it for 10 years and we believe all active servers are currently using Opus.

I’m not sure about that. We don’t track that.

Our base-line backwards compatibility is CELT 0.7.x, so I’m fine with removing Speex, which was used before that (only?). Why do we still have Speex if our base-line is CELT 0.7.x? Was it still used on specific bitrates?

davidebeatrici

comment created time in 2 months

issue commentmumble-voip/mumble

Mumble Discord

The post lists these candidates with my or their additional info added

  • Rocket.Chat has a limited free tier
  • Matrix/Riot.im is free, can bridge IRC
  • Zulip has free tier, two-way bridge with IRC and Matrix possible
  • Gitter free, has IRC bridge
  • Spectrum ? free, has communities and sub-channels, profile posts
  • Slack commercial
  • Mattermost costs unless self hosted
  • Discord discarded for their terms
  • Telegram discarded; good for conversations, impractical for work
  • IRCv3; not sufficiently evolved as a protocol and client adoption
Krzmbrzl

comment created time in 2 months

issue commentmumble-voip/mumble

Mumble Discord

On December 1st, assuming we can gather that support, we will stand up the new service.

so that will be a while until they announce and release

Krzmbrzl

comment created time in 2 months

issue commentmumble-voip/mumble

Mumble Discord

Yes, that’s it, thank you very much! I guess I discarded it waiting for later decisions and preferably announcements from Mozilla directly and not just a persons blog.

Krzmbrzl

comment created time in 2 months

issue commentmumble-voip/mumble

Mumble Discord

It has not been discussed internally specifically. I do see value in using and promoting a friendlier platform than just IRC though. Some people already use Matrix with its IRC bridge, which gives them a modern and persistent chat while it still connected with out IRC channel and its messages.

I am currently trying to find a news article about a big FOSS project or organization working towards a new chat platform and deciding against Discord, with a few options left. The article was a few days ago, and I thought I had it left open or saved it for later review/reference. But I can not find it right now. Anyone familiar? Could have been GNOME, Mozilla, GNU or something…

With what @Mikaela wrote/referenced, and the weight of what I referenced I don’t see us going the Discord route. As I said the Matrix route is already an option, and we should see what the other big projects reasons, and promote something similar as well - either bridged with IRC, which would be neat, or another adequate platform.

Krzmbrzl

comment created time in 2 months

issue commentmumble-voip/mumble

Feature Request: Split chat and audio functionality

How would that work technically? The client would connect to two servers/services at the same time and send packages to one or the other?

For now I consider an implementation of that very unlikely. We have other, more important tasks and features with more impact for effort. So I don’t see this happening any time soon.

wabash1

comment created time in 3 months

delete branch Kissaki/mumble

delete branch : f/1.4.0

delete time in 3 months

push eventmumble-voip/mumble

Jan Klass

commit sha 19b57021683144590f46dc4b6b59076740e6b360

Bump version to 1.4.0 1.3.0 has been released. master now represents the current state of development towards the next feature release 1.4.0. Bugfixes for 1.3 will happen in the 1.3.x branch. Compared to earlier version bumps we bump a lot more files because of we produce more artifacts; overlay process, dll and exe split, etc. This should have happened right after the 1.3.x branch was split off.

view details

Jan Klass

commit sha 413951ce0c58a54aff652412dac1cb5496477691

Merge PR #3799: Bump version to 1.4.0 1.3.0 has been released. master now represents the current state of development towards the next feature release 1.4.0. Bugfixes for 1.3 will happen in the 1.3.x branch. Compared to earlier version bumps we bump a lot more files because of we produce more artifacts; overlay process, dll and exe split, etc. This should have happened right after the 1.3.x branch was split off. Fixes #3761 Waiting on response from xPoke in that ticket concerning theme version. That will have to be landed first, and then this PR updated with the landed commit in mumble-theme. Feel free to already review independent of xPoke response. As the mumble-theme commit did not land yet checking out this PR will not work (for others than me who has the commit locally).

view details

push time in 3 months

PR merged mumble-voip/mumble

Bump version to 1.4.0 build

1.3.0 has been released. master now represents the current state of development towards the next feature release 1.4.0.

Bugfixes for 1.3 will happen in the 1.3.x branch.

Compared to earlier version bumps we bump a lot more files because of we produce more artifacts; overlay process, dll and exe split, etc.

This should have happened right after the 1.3.x branch was split off.

Fixes #3761

Waiting on response from xPoke in that ticket concerning theme version. That will have to be landed first, and then this PR updated with the landed commit in mumble-theme.

Feel free to already review independent of xPoke response.

As the mumble-theme commit did not land yet checking out this PR will not work (for others than me who has the commit locally).

+42 -42

0 comment

18 changed files

Kissaki

pr closed time in 3 months

issue closedmumble-voip/mumble

Increment versions to 1.4.0

The version bump should have happened in master before any other changes that are for 1.4.0 but not for 1.3.0.

The version number must be increased.

Note: We have multiple produced assemblies with version numbers.

closed time in 3 months

Kissaki

issue openedmumble-voip/mumble-theme

Drop version definition in `overlay.mumblelay`

The file overlay.mumblelay contains a version string at https://github.com/mumble-voip/mumble-theme/blob/9c68c1453837b82f69e93d7df2dbdd086d96f27d/overlay.mumblelay#L2.

This may be a technical necessity, but it is very bad architecture because now the Mumble version depends on the themes layout file.

If at all possible the theme must not contain version specific code like this.

@xPoke Is the assumption correct that this is a layout file replacing the existing one for layout changes. And the version number being in there is a side effect because we override the entire file?

So the way to fix this would then to look for a way in Mumble itself to clear it from the layout file? (What is the file used for and how?)

created time in 3 months

push eventKissaki/mumble

Jan Klass

commit sha 19b57021683144590f46dc4b6b59076740e6b360

Bump version to 1.4.0 1.3.0 has been released. master now represents the current state of development towards the next feature release 1.4.0. Bugfixes for 1.3 will happen in the 1.3.x branch. Compared to earlier version bumps we bump a lot more files because of we produce more artifacts; overlay process, dll and exe split, etc. This should have happened right after the 1.3.x branch was split off.

view details

push time in 3 months

delete branch Kissaki/mumble-theme

delete branch : f/1.4.0

delete time in 3 months

push eventmumble-voip/mumble-theme

Jan Klass

commit sha d6849f3d751ce670d8370bc5a7f5d7a4866b7600

Bump Mumble version to 1.4.0 The overlay.mumblelay file is a macOS settins form layout file. The theme replaces this layout (file). The settings form contains the version number for a overlay version comparison/check. This leaves us with the unfortunate result of a version number in this theme overwriting layout file.

view details

Jan Klass

commit sha 9c68c1453837b82f69e93d7df2dbdd086d96f27d

Merge: Bump Mumble version to 1.4.0 The overlay.mumblelay file is a macOS settins form layout file. The theme replaces this layout (file). The settings form contains the version number for a overlay version comparison/check. This leaves us with the unfortunate result of a version number in this theme overwriting layout file.

view details

push time in 3 months

issue commentmumble-voip/mumble

Increment versions to 1.4.0

No reply yet so I’m gonna assume my assumption is correct, create a ticket in the theme repository for resolving this very unfortunate state, and then merge. @xPoke @davidebeatrici

@xPoke please still reply after the fact

Kissaki

comment created time in 3 months

Pull request review commentmumble-voip/mumble-www

Add release redirects based on the info in version.json

 package main
 
 import (
+	"log"
+	"os"
+	"sync"
+	"encoding/json"
+	"io/ioutil"
 	"net/http"
-	"time"
+	"github.com/fsnotify/fsnotify"
 )
 
-func setupDownloadsStable(mux *http.ServeMux) {
-	stable := map[string]string{
-		"windows-32":          "https://github.com/mumble-voip/mumble/releases/download/1.3.0/mumble-1.3.0.msi",
-		"windows-64":          "https://github.com/mumble-voip/mumble/releases/download/1.3.0/mumble-1.3.0.winx64.msi",
-		"osx":                 "https://github.com/mumble-voip/mumble/releases/download/1.3.0/Mumble-1.3.0.dmg",
-		"osx-universal":       "https://github.com/mumble-voip/mumble/releases/download/1.2.10/Mumble-Universal-1.2.10.dmg",
-		"ios":                 "http://itunes.apple.com/us/app/mumble/id443472808?ls=1&mt=8",
-		"ubuntu":              "https://launchpad.net/~mumble/+archive/release",
-		"linux-static-server": "https://github.com/mumble-voip/mumble/releases/download/1.3.0/murmur-static_x86-1.3.0.tar.bz2",
-		"osx-static-server":   "https://github.com/mumble-voip/mumble/releases/download/1.3.0/Murmur-OSX-Static-1.3.0.tar.bz2",
+var mutex sync.RWMutex
+var redirectMap = make(map[string]string)
+
+type Release struct {
+	Version string `json:"version"`
+	Url string `json:"url"`
+	SigUrl string  `json:"sigUrl"`
+}
+
+func setupDownloads(mux *http.ServeMux, jsonPath string) {
+	mux.HandleFunc("/downloads/", downloadsHandler)
+	refreshDownloads(jsonPath)
+	go fileWatcher(jsonPath)
+}
+
+func refreshDownloads(jsonPath string) {
+	mutex.Lock()
+
+	redirectMap = make(map[string]string)
+
+	jsonFile, err := os.Open(jsonPath)
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	defer jsonFile.Close()
+
+	jsonBytes, err := ioutil.ReadAll(jsonFile)
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	var jsonMap map[string]map[string]Release
+	err = json.Unmarshal(jsonBytes, &jsonMap)
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	if value, ok := jsonMap["stable"]; ok {
+		setupDownloadsStable(value)
+	}
+
+	if value, ok := jsonMap["snapshot"]; ok {
+		setupDownloadsSnapshot(value)
+	}
+
+	for key, value := range redirectMap {
+		log.Println("downloads/" + key + " -> " + value)
+	}
+
+	mutex.Unlock()
+}
+
+func setupDownloadsStable(jsonMap map[string]Release) {
+	redirectMap["ubuntu"] = "https://launchpad.net/~mumble/+archive/release"
+	redirectMap["ios"] = "https://apps.apple.com/app/mumble/id443472808"
+
+	for key, value := range jsonMap {
+		redirectMap[key] = value.Url
 	}
+}
 
-	for source, target := range stable {
-		mux.Handle("/downloads/"+source, http.RedirectHandler(target, http.StatusTemporaryRedirect))
+func setupDownloadsSnapshot(jsonMap map[string]Release) {
+	redirectMap["ubuntu/snapshot"] = "https://launchpad.net/~mumble/+archive/snapshot"
+
+	for key, value := range jsonMap {
+		redirectMap[key + "/snapshot"] = value.Url
 	}
 }
 
-func setupDownloadsSnapshot(mux *http.ServeMux) {
-	snapshotCache := NewSnapshotCache(time.Hour)
-	for source := range snapshotRegexps {
-		mux.Handle("/downloads/"+source+"/snapshot", snapshotCache.Handle(source))
+func downloadsHandler(w http.ResponseWriter, r *http.Request) {
+	// Get the part after "/downloads/"
+	path := r.URL.Path[len("/downloads/"):]
+
+	mutex.RLock()
+
+	value, ok := redirectMap[path]
+
+	mutex.RUnlock()
+
+	if !ok {
+		http.NotFound(w, r)
+		return
 	}
-	mux.Handle(
-		"/downloads/ubuntu/snapshot",
-		http.RedirectHandler("https://launchpad.net/~mumble/+archive/snapshot", http.StatusTemporaryRedirect),
-	)
+
+	http.Redirect(w, r, value, http.StatusTemporaryRedirect)
+}
+
+func fileWatcher(filePath string) {
+	watcher, err := fsnotify.NewWatcher()
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	defer watcher.Close()
+
+	done := make(chan bool)
+
+	go func() {
+		for {
+			select {
+				case event, ok := <-watcher.Events:
+					if !ok {
+						return
+					}
+
+					log.Println(event)
+
+					if event.Op&fsnotify.Write == fsnotify.Write {
+						refreshDownloads(filePath)
+					}
+				case err, ok := <-watcher.Errors:
+					if !ok {
+						return

So this will exit the file watching but not the webserver without any error or warning or notifications to us?

What kind of errors can happen here?

Should probably be a continue!?

davidebeatrici

comment created time in 3 months

more