profile
viewpoint
Joseph Ngugi Kachulio1 Kenya, Nairobi

AgileVentures/sfn-client 10

Front end for sing for needs

AgileVentures/av-dashboard 5

An internal dashboard for Agile Ventures analytics

AgileVentures/agile-ventures-website-react-front-end 3

React Front End for the AgileVentures site

championer-org/championer_one 1

Project repo for championer.org website

AgileVentures/AgileVenturesDeployScripts 0

Repo for managing deployments across AgileVentures' projects

amutava/Website 0

This is the website of the MentorBot application

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v4

Task/accessibility ci

+import * as Axe from 'axe-core';+import { convertAxeToSarif } from 'axe-sarif-converter';+import AxeBuilder from 'axe-webdriverjs';+import chromeDriver from 'chromedriver';+import webdriver, { By, ThenableWebDriver, until } from 'selenium-webdriver';+import chrome from 'selenium-webdriver/chrome';++const TEST_TIMEOUT_MS = 300000;++describe('Graph Explorer', () => {+  let driver: ThenableWebDriver;++  beforeAll(async () => {+    chrome.setDefaultService(new chrome.ServiceBuilder(chromeDriver.path).build());++    driver = new webdriver+    .Builder()+    .withCapabilities(webdriver.Capabilities.chrome())+    .build();+  }, TEST_TIMEOUT_MS);++  afterAll(async() => {+    return driver && driver.quit();+  }, TEST_TIMEOUT_MS);++  beforeEach(async() => {+    await driver.get('https://developer.microsoft.com/en-us/graph/graph-explorer/preview');+    await driver.wait(until.elementLocated(By.css('p')));+  }, TEST_TIMEOUT_MS);++  it('checks for accessibility violations', async() => {+    // @ts-ignore+    const accessibilityScanResults = await AxeBuilder(driver)+      .analyze();+    expect(accessibilityScanResults.violations).toStrictEqual([]);+  });+});

For historical reason add a newline

jobala

comment created time in 2 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v4

add remove all history

 export const removeHistoryData = async (historyItem: IHistoryItem) => {   return true; }; -export const bulkRemoveHistoryData = async (listOfKeys: string[]) => {+export const bulkRemoveHistoryData = async (listOfKeys: string[], all?: boolean) => {

I decided to reuse this function to clear all history, but there's another option, import localForage in src/app/services/actions/auth-action-creators.ts and run the localForage.clear function and then update the state with an empty array dispatch({ type: REMOVE_ALL_HISTORY_ITEMS_SUCCESS, response: [], }); and return an empty array in src/app/services/reducers/request-history-reducers.ts

if we don't want to iterate through all the key see below 👇

Kachulio1

comment created time in a month

PR opened microsoftgraph/microsoft-graph-explorer-v4

add remove all history

Overview

Clears the history on logout

FInishes #524

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output
+30 -23

0 comment

3 changed files

pr created time in a month

issue commentmicrosoftgraph/microsoft-graph-explorer-v4

Clear history upon successful sign out

@MIchaelMainer @bettirosengugi @jobala should we clear the history on login? because the current behavior is, when you run some queries with the sample account and later sign in, you still see the history of the sample account

MIchaelMainer

comment created time in a month

push eventKachulio1/microsoft-graph-explorer-v4

Joseph Ngugi

commit sha 479ea555543e8b7c0c1a305d3667abbc566a1e96

delete tslint file

view details

Joseph Ngugi

commit sha d4e9c3de365510cb930e4ec7d571c905633c0129

remove unused tslint dependencies

view details

push time in a month

push eventKachulio1/microsoft-graph-explorer-v4

kachulio1

commit sha 21592d3861a99afbb5281fc12422ab6fac144f4a

add eslintignore

view details

kachulio1

commit sha f18e44742ed1aeb1804e5de58947ee35f8f7d3bd

remove legacy tslint rules

view details

push time in a month

pull request commentmicrosoftgraph/microsoft-graph-explorer-v4

Migrate to eslint

Yes, replace the outdated rules. Not sure what you mean by linting the whole project. Please expound.

I mean running the lint command on all the files to fix spaces, unused var, etc

Kachulio1

comment created time in a month

issue openedmicrosoftgraph/microsoft-graph-explorer-v4

azure pipeline

Is your feature request related to a problem? Please describe. Open source contributors don't have access to view azure builds

Screenshot 2020-07-06 at 00 32 19

Describe the solution you'd like N/A

Describe alternatives you've considered N/A

Additional context N/A

created time in a month

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v4

Fix: screen reader support and focus indication on links

 import { FormattedMessage } from 'react-intl'; export function statusMessages(queryState: any, actions: any) {   return queryState && (   <MessageBar messageBarType={queryState.messageType}-  isMultiline={false} onDismiss={actions.clearQueryStatus}>+  isMultiline={false}

I think we should add a pre-commit hook that runs prettier no? 🤔

ElinorW

comment created time in a month

pull request commentmicrosoftgraph/microsoft-graph-explorer-v4

Migrate to eslint

should I lint the whole project and create a follow-up PR, or should we just adopt the new rules gradually

Kachulio1

comment created time in a month

pull request commentmicrosoftgraph/microsoft-graph-explorer-v4

Migrate to eslint

@jobala the eslintrc.js is the auto-generated from tslint-to-eslint-config and has some old tslint rules, was wondering if I should replace that with these rules instead ```module.exports = { env: { browser: true, es6: true, node: true, }, extends: [ "eslint:recommended", "plugin:react/recommended", "plugin:@typescript-eslint/eslint-recommended", ], globals: { Atomics: "readonly", SharedArrayBuffer: "readonly", }, parser: "@typescript-eslint/parser", parserOptions: { ecmaFeatures: { jsx: true, }, ecmaVersion: 2018, project: "tsconfig.json", sourceType: "module", }, plugins: ["react", "@typescript-eslint", "jsx-a11y"], rules: { "@typescript-eslint/adjacent-overload-signatures": "error", "@typescript-eslint/array-type": "warn", "@typescript-eslint/ban-types": "error", "@typescript-eslint/class-name-casing": "error", "@typescript-eslint/consistent-type-assertions": "error", "@typescript-eslint/consistent-type-definitions": "error", "@typescript-eslint/explicit-member-accessibility": [ "off", { accessibility: "explicit", }, ], "@typescript-eslint/indent": "off", "@typescript-eslint/interface-name-prefix": "off", "@typescript-eslint/member-delimiter-style": [ "off", { multiline: { delimiter: "none", requireLast: true, }, singleline: { delimiter: "semi", requireLast: false, }, }, ], "@typescript-eslint/member-ordering": "off", "@typescript-eslint/no-empty-function": "error", "@typescript-eslint/no-empty-interface": "error", "@typescript-eslint/no-explicit-any": "off", "@typescript-eslint/no-misused-new": "error", "@typescript-eslint/no-namespace": "off", "@typescript-eslint/no-parameter-properties": "off", "@typescript-eslint/no-unused-expressions": [ "error", { allowShortCircuit: true, }, ], "@typescript-eslint/no-unused-vars": [ "warn", { args: "after-used", argsIgnorePattern: "^_", ignoreRestSiblings: false, vars: "all", }, ], "@typescript-eslint/no-use-before-define": "off", "@typescript-eslint/no-var-requires": "off", "@typescript-eslint/prefer-for-of": "error", "@typescript-eslint/prefer-function-type": "error", "@typescript-eslint/prefer-namespace-keyword": "error", "@typescript-eslint/quotes": "off", "@typescript-eslint/semi": ["off", null], "@typescript-eslint/space-within-parens": ["off", "never"], "@typescript-eslint/triple-slash-reference": "error", "@typescript-eslint/type-annotation-spacing": "off", "@typescript-eslint/unified-signatures": "error", "arrow-body-style": "off", "arrow-parens": ["off", "as-needed"], camelcase: "off", "capitalized-comments": "off", "comma-dangle": "off", complexity: "off", "constructor-super": "error", curly: "error", "dot-notation": "error", "eol-last": "off", eqeqeq: ["error", "smart"], "guard-for-in": "error", "id-blacklist": "off", "id-match": "error", "import/order": "off", "linebreak-style": "off", "max-classes-per-file": ["error", 1], "max-len": "off", "new-parens": "off", "newline-per-chained-call": "off", "no-bitwise": "error", "no-caller": "error", "no-case-declarations": 0, "no-cond-assign": "error", "no-console": "warn", "no-debugger": "error", "no-empty": "error", "no-eval": "error", "no-extra-boolean-cast": 0, "no-extra-semi": "off", "no-fallthrough": "off", "no-invalid-this": "off", "no-irregular-whitespace": "off", "no-multiple-empty-lines": "off", "no-new-wrappers": "error", "no-shadow": [ "warn", { hoist: "all", }, ], "no-throw-literal": "error", "no-trailing-spaces": "off", "no-undef-init": "error", "no-underscore-dangle": "off", "no-unsafe-finally": "error", "no-unused-labels": "error", "no-unused-vars": "off", "no-var": "error", "object-shorthand": "error", "one-var": ["error", "never"], "prefer-arrow/prefer-arrow-functions": "off", "prefer-const": "error", "quote-props": "off", radix: "error", "react/no-unescaped-entities": 0, "react/prop-types": 0, "space-before-function-paren": "off", "spaced-comment": "off", "use-isnan": "error", "valid-typeof": "off", }, settings: { react: { version: "detect", }, }, };

Kachulio1

comment created time in a month

PR opened microsoftgraph/microsoft-graph-explorer-v4

Migrate to eslint

Overview

removes tslint and adds eslint

Closes #588

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output
+887 -111

0 comment

3 changed files

pr created time in a month

create barnchKachulio1/microsoft-graph-explorer-v4

branch : migrate-to-eslint

created branch time in a month

issue commentHuman-Connection/Human-Connection

🎉 Community Repository 🎉

@roschaefer ☝️

roschaefer

comment created time in 2 months

issue commentHuman-Connection/Human-Connection

🎉 Community Repository 🎉

this is awesome, you said "We don't know a good name for the software project and its repository", are you/we looking for a great frontend library, like React

roschaefer

comment created time in 2 months

more