Joseph Ngugi Kachulio1 Kenya, Nairobi

issue commentmicrosoftgraph/microsoft-graph-explorer-v2

Sample Request History

Ok, I was on holiday haven't worked on this yet.

jobala

comment created time in 2 days

push eventandela/andela-societies-frontend

Joseph Ngugi

commit sha 0ffa8634f09f59a1d3903b5d0851830453cdd64f

Ft log points validation (#212) * Redux Saga setup * Clean Saga examples * Onboading screen * log points * merge conflicts * Log society activity points * Log points reducer tests * log activity points action tests * log activity points generators and component tests * refactor and implement review feedback * remove evaluation * update branch * add expects blocks to my tests * team feedback implementation * improve test coverage * improve test coverage * improve tests * toast component * Remove unnecessary code * logged activity should be added to the user activity list * Rename file * test componentDidUpdate * add snapshot * toast component * add modal inputs validation * commit * fix failing test * clean branch * fix failing CI build * tests * test * test * fix date format * resolve conflict

view details

push time in 2 days

PR merged andela/andela-societies-frontend

Ft log points validation
What does this PR do?
Description of Task to be completed?
Any background context you want to provide?
What are the relevant Pivotal Tracker stories?
Questions?
Screenshots?

Screenshot 2019-04-18 at 21 19 25 Screenshot 2019-04-18 at 19 40 09

+172 -30

0 comment

10 changed files

Kachulio1

pr closed time in 2 days

push eventandela/andela-societies-frontend

Chris Maina

commit sha bdb1a80519c06e294db28e86ac432c5430dd7f37

feat(approve): Add Approve Budget page (#204) - move SocietyStatsComponent & TabsComponent to common folder - add ApproveActivitiesContainer - add TabsComponent - add ApproveBudgetComponent - add ApproveBudgetContainer tests - add getTabBorderClassname helper - add ApproveBudgetComponent tests - add Approve Budget nav item

view details

Chris Maina

commit sha 782f1bfdb4b79ebe7cb69f4c25be3e3c8dad1e70

feat(redeem): add redeem points dialog (#206) - add createRedemptionRequest and createRedemptionSuccess actions - add createRedemption generator - add dollarsToPointsConverter util - add redemption dialog styles - add RedeemPointsDialogComponent tests - add RedemptionsContainer tests - add action, reducer and saga tests - add money svg image

view details

Alex Mochu

commit sha 52aef7d469472e3981746b2454727e88297379ea

#164397809 Validate Log points Modal inputs (#197) * Redux Saga setup * Clean Saga examples * Onboading screen * log points * merge conflicts * Log society activity points * Log points reducer tests * log activity points action tests * log activity points generators and component tests * refactor and implement review feedback * remove evaluation * update branch * add expects blocks to my tests * team feedback implementation * improve test coverage * improve test coverage * improve tests * toast component * Remove unnecessary code * logged activity should be added to the user activity list * Rename file * test componentDidUpdate * add snapshot * toast component * add modal inputs validation * commit * fix failing test * clean branch * fix failing CI build * tests * test * test * fix date format

view details

Alex Mochu

commit sha 6f6c03eee71219ae2ef036d023feced6947ae6da

add backround opacity by using Material UI Dialog (#208)

view details

kachulio1

commit sha 1aff7d71ec536f51abe48867c5e39595e6f0894a

fix conflicts

view details

push time in 2 days

PR opened andela/andela-societies-frontend

Ft log points validation
What does this PR do?
Description of Task to be completed?
Any background context you want to provide?
What are the relevant Pivotal Tracker stories?
Questions?
Screenshots?
+12410 -21126

0 comment

465 changed files

pr created time in 7 days

create barnchandela/andela-societies-frontend

branch : ft-log-points-validation

created branch time in 7 days

issue commentmicrosoftgraph/microsoft-graph-explorer-v2

Sample Request History

Yeah sure. Question, all requests or are there specific ones?

jobala

comment created time in 7 days

delete branch Kachulio1/microsoft-graph-explorer-v2

delete branch : chore/add-prettier

delete time in 7 days

issue openedmicrosoftgraph/microsoft-graph-explorer-v2

Security vulnerabilities found on npm packages

when you run npm i you get this error Screen Shot 2019-04-16 at 01 07 50

cc @jobala

the suggested fix would be running npm audit fix

created time in 7 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v2

bug: authenticated state lost on page reload

 export class Authentication extends Component<IAuthenticationProps,  IAuthentica     }   }; +  public componentDidMount = () => {+    const authenticatedUser = localStorage.getItem('authenticatedUser');+    const authUser = (authenticatedUser) ? JSON.parse(authenticatedUser) : null;++    if (authenticatedUser && this.props.actions && authUser.status) {

I don't think you need the && authUser.status

thewahome

comment created time in 8 days

pull request commentmicrosoftgraph/microsoft-graph-explorer-v2

fix infinite loading when popup window is closed

@thewahome should I close this PR?

Kachulio1

comment created time in 8 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha 882adbaa791504a9894e21069c392160191f87a7

add jsxSingleQuote

view details

kachulio1

commit sha 12d81c92e7b0ea07b270981021599d6816957150

add prettier command

view details

push time in 8 days

pull request commentmicrosoftgraph/microsoft-graph-explorer-v2

add prettier

@jobala should I open another PR for fixing all the files that are not formatted?

Kachulio1

comment created time in 8 days

delete branch andela/andela-societies-frontend

delete branch : ch-add-background-opacity

delete time in 8 days

push eventandela/andela-societies-frontend

Alex Mochu

commit sha 6f6c03eee71219ae2ef036d023feced6947ae6da

add backround opacity by using Material UI Dialog (#208)

view details

push time in 8 days

PR merged andela/andela-societies-frontend

Reviewers
Log points dark opacity background
What does this PR do?

Adds a dark opacity background to the Log points dialog and success alert/toast message.

Video

Here is the demo Link

Screenshots?

Screenshot 2019-04-11 at 20 48 36

+99 -92

2 comments

4 changed files

alexmochu

pr closed time in 8 days

delete branch andela/andela-societies-frontend

delete branch : ft-log-points-validation

delete time in 8 days

push eventandela/andela-societies-frontend

Alex Mochu

commit sha 52aef7d469472e3981746b2454727e88297379ea

#164397809 Validate Log points Modal inputs (#197) * Redux Saga setup * Clean Saga examples * Onboading screen * log points * merge conflicts * Log society activity points * Log points reducer tests * log activity points action tests * log activity points generators and component tests * refactor and implement review feedback * remove evaluation * update branch * add expects blocks to my tests * team feedback implementation * improve test coverage * improve test coverage * improve tests * toast component * Remove unnecessary code * logged activity should be added to the user activity list * Rename file * test componentDidUpdate * add snapshot * toast component * add modal inputs validation * commit * fix failing test * clean branch * fix failing CI build * tests * test * test * fix date format

view details

push time in 8 days

PR merged andela/andela-societies-frontend

#164397809 Validate Log points Modal inputs
What does this PR do?

As a Fellow, I should be able to see validation errors whenever they occur while I am Login my society points.

Description of Task to be completed?
What are the relevant Pivotal Tracker stories?

#164397809

Screenshots?
  • Here is a demo link
  • Validate Modal Inputs Screenshot 2019-03-21 at 13 51 20
+413 -46

0 comment

18 changed files

alexmochu

pr closed time in 8 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha 39e216d51b82e531c65622977065573f965f3511

remove unused element

view details

push time in 9 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha d301d976a6a276ff24a893ec1ea032704948902b

remove no lambda rule

view details

push time in 9 days

PR opened microsoftgraph/microsoft-graph-explorer-v2

add prettier

Overview

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output
+10 -3

0 comment

3 changed files

pr created time in 9 days

create barnchKachulio1/microsoft-graph-explorer-v2

branch : chore/add-prettier

created branch time in 9 days

push eventKachulio1/microsoft-graph-explorer-v2

jobala

commit sha 07d1220597137fa787a47e65d71530b0bf4c0cb1

Decodes data encoded as a base64 token

view details

jobala

commit sha 4cd0783b030a1c092e7388174f7b6f05a288e165

Adds tests

view details

jobala

commit sha 631b18d3ac1d81e66f9c988ff6600b5885633745

Fixes failing test

view details

jobala

commit sha 7da0307421acf4fb616cfb60f9b5c0edabda29e7

Parses token as a query string

view details

kachulio1

commit sha 9c6dfa6771be586f7af52e1ed1100cb2f464257a

declutter package.json

view details

Japheth Obala

commit sha aed2e8fdfcb1e1b7d893ba2b5af660d80bea963b

Merge branch 'dev' into task/url-token

view details

Japheth Obala

commit sha bfb1544b827d239804b1c0c19e0e5d107f418eef

Fixes merge conflict

view details

Japheth Obala

commit sha 7db7f0daf782b5e8dec9932a38f5eeaa681b6234

Merge pull request #33 from microsoftgraph/task/url-token Decodes data encoded as a base64 token

view details

kachulio1

commit sha f2557ef89c127c8a79484b67a497d6643afac0c8

add missing types

view details

kachulio1

commit sha 35f72aaa5e6d66152de876ffc169411b585dfe90

add new line after import

view details

kachulio1

commit sha 6a21996108653ac522cdb9aea193d4fde28fa9a6

add new line after node_module import

view details

Japheth Obala

commit sha 75f8159d2a0f1120e7fb3e7b1ab74aaecb87928d

Merge pull request #40 from Kachulio1/chore/add-types add missing types

view details

Japheth Obala

commit sha f1ff88abd2155c16f10b7d20903232bd9d63e637

Merge pull request #38 from Kachulio1/chore/declutter-package-json declutter package.json

view details

push time in 9 days

delete branch Kachulio1/microsoft-graph-explorer-v2

delete branch : chore/declutter-package-json

delete time in 10 days

delete branch Kachulio1/microsoft-graph-explorer-v2

delete branch : chore/add-types

delete time in 10 days

issue commentmicrosoftgraph/microsoft-graph-explorer-v2

add code format standard by adding Prettier Configuration

Yeah, I could work on it. Or do you have a high priority task?

Kachulio1

comment created time in 10 days

push eventandela/andela-societies-frontend

Chris Maina

commit sha 782f1bfdb4b79ebe7cb69f4c25be3e3c8dad1e70

feat(redeem): add redeem points dialog (#206) - add createRedemptionRequest and createRedemptionSuccess actions - add createRedemption generator - add dollarsToPointsConverter util - add redemption dialog styles - add RedeemPointsDialogComponent tests - add RedemptionsContainer tests - add action, reducer and saga tests - add money svg image

view details

push time in 10 days

PR merged andela/andela-societies-frontend

Reviewers
#165209740 Submit redemption request
What does this PR do?

Enables a society president to submit a redemption request

What are the relevant Pivotal Tracker stories?

165209740

Screenshots?

Screen Shot 2019-04-09 at 12 34 07 PM

+611 -8

0 comment

21 changed files

Chris-Maina

pr closed time in 10 days

pull request commentmicrosoftgraph/microsoft-graph-explorer-v2

declutter package.json

@jobala you'll need to restart your server if you checked out to this branch while the server was running.

Kachulio1

comment created time in 10 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha 6a21996108653ac522cdb9aea193d4fde28fa9a6

add new line after node_module import

view details

push time in 10 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v2

add missing types

 import React from 'react';+import { IProfileProps } from '../../../../types/profile';

👍

Kachulio1

comment created time in 10 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha 35f72aaa5e6d66152de876ffc169411b585dfe90

add new line after import

view details

push time in 10 days

PR opened microsoftgraph/microsoft-graph-explorer-v2

add missing types

Overview

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output
+20 -13

0 comment

7 changed files

pr created time in 10 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha f2557ef89c127c8a79484b67a497d6643afac0c8

add missing types

view details

push time in 10 days

create barnchKachulio1/microsoft-graph-explorer-v2

branch : chore/add-types

created branch time in 10 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v2

enable request options

 import React from 'react';-import MonacoEditor from 'react-monaco-editor';+import MonacoEditor, { ChangeHandler } from 'react-monaco-editor';  import './monaco.scss';  interface IMonaco {   body: object|undefined;+  onChange?: ChangeHandler | undefined;

gotcha

thewahome

comment created time in 10 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha 028b92d922da6a93d4c82d5e4a4430b4eaab5246

fix linting

view details

push time in 10 days

push eventKachulio1/microsoft-graph-explorer-v2

kachulio1

commit sha a7098a3a3aecda4e880b603106a6938ef934a9d5

fix eslit

view details

push time in 10 days

PR opened microsoftgraph/microsoft-graph-explorer-v2

declutter package.json

Overview

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output
+45 -51

0 comment

3 changed files

pr created time in 10 days

PR opened microsoftgraph/microsoft-graph-explorer-v2

fix infinite loading when popup window is closed

Overview

When the sign in with Microsoft button is clicked and a user closes the signup/sign in popup window the button deosn't go back to the initial state.

Demo

Screen Shot 2019-04-15 at 01 02 58 You get this error in the console. Screen Shot 2019-04-15 at 01 02 35

+10 -1

0 comment

1 changed file

pr created time in 10 days

create barnchKachulio1/microsoft-graph-explorer-v2

branch : bug/sign-in-button

created branch time in 10 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v2

enable request options

 export class QueryRunner extends Component<IQueryRunnerProps, IQueryRunnerState>       ],       selectedVerb: 'GET',       sampleURL: 'https://graph.microsoft.com/v1.0/me/',+      sampleBody: undefined,

can we use null or '' instead of undefined so that it can be easy to debug.

thewahome

comment created time in 10 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v2

enable request options

 import React from 'react';-import MonacoEditor from 'react-monaco-editor';+import MonacoEditor, { ChangeHandler } from 'react-monaco-editor';  import './monaco.scss';  interface IMonaco {   body: object|undefined;+  onChange?: ChangeHandler | undefined;

I don't think this should be optional, no?

thewahome

comment created time in 10 days

issue commentmicrosoftgraph/microsoft-graph-explorer-v2

UpdateUrl Action

But I guess going forward the will have

darrelmiller

comment created time in 10 days

issue commentmicrosoftgraph/microsoft-graph-explorer-v2

UpdateUrl Action

I have noticed that issues don't have descriptions and it's hard to know what to do if you are not part of the core team. 😄

darrelmiller

comment created time in 10 days

pull request commentmicrosoftgraph/microsoft-graph-explorer-v2

Adds support for iframe message passing

@jobala where is this iframe message? I'm new here want to understand the code base better.

jobala

comment created time in 12 days

Pull request review commentmicrosoftgraph/microsoft-graph-explorer-v2

Adds support for iframe message passing

 export class QueryRunner extends Component<IQueryRunnerProps, IQueryRunnerState>         { key: 'DELETE', text: 'DELETE' },       ],       selectedVerb: 'GET',-      sampleURL: 'https://graph.microsoft.com/v1.0/me/',+      sampleUrl: 'https://graph.microsoft.com/v1.0/me/',+      sampleHeaders: {},+      sampleBody: {},     };   } +  public componentDidMount() {+    window.addEventListener('message', this.receiveMessage, false);+  }++  public componentWillUnmount() {+    window.removeEventListener('message', this.receiveMessage);+  }++  private receiveMessage = (event: MessageEvent) => {+    const {+      sampleVerb,+      sampleHeaders,+      sampleUrl,+      sampleBody,+    } = event.data;++    if (event.origin !== 'http://docs.microsoft.com' || event.source === null) {+      return;+    }++    this.setState({+      sampleUrl,+      sampleBody,+      sampleHeaders,+      selectedVerb: sampleVerb,+    });++    // @ts-ignore+    event.source.postMessage('Opened Graph Explorer', event.origin);

Why are we ignoring TypeScript here?

jobala

comment created time in 12 days

Pull request review commentandela/andela-societies-frontend

Filter engineer activities

 export class DashboardContainer extends Component {     this.setState({ user: userInfo });     fetchUserActivites(userInfo.id);     loadCategories();+    document.addEventListener('mousedown', this.hideFilter, false);   }    logPointsModal = () => {     const { logPoints } = this.state;     this.setState({       logPoints: !logPoints,     });-  }+  };++  handleClick = index => (event) => {+    if (event.target.value === 'Select All') {+      const filterBy = this.state.filterBy.map((item) => {+        if (event.target.checked) {+          return (item.checked = true), item;+        }++        return (item.checked = false), item;+      });++      this.setState({ filterBy, filteredUserActivities: null });+    } else {+      const filterBy = this.state.filterBy.slice();+      filterBy[index].checked = !filterBy[index].checked;++      if (!filterBy[index].checked) {+        const filteredUserActivities = (+          this.state.filteredUserActivities || this.props.userActivities

and also this.state. acts like namespace, it helps with readability

Kachulio1

comment created time in 13 days

Pull request review commentandela/andela-societies-frontend

Filter engineer activities

 export class DashboardContainer extends Component {     this.setState({ user: userInfo });     fetchUserActivites(userInfo.id);     loadCategories();+    document.addEventListener('mousedown', this.hideFilter, false);   }    logPointsModal = () => {     const { logPoints } = this.state;     this.setState({       logPoints: !logPoints,     });-  }+  };++  handleClick = index => (event) => {+    if (event.target.value === 'Select All') {+      const filterBy = this.state.filterBy.map((item) => {+        if (event.target.checked) {+          return (item.checked = true), item;+        }++        return (item.checked = false), item;+      });++      this.setState({ filterBy, filteredUserActivities: null });+    } else {+      const filterBy = this.state.filterBy.slice();+      filterBy[index].checked = !filterBy[index].checked;++      if (!filterBy[index].checked) {+        const filteredUserActivities = (+          this.state.filteredUserActivities || this.props.userActivities

Yes, I wanted to but the name would conflict with the variable on line 110

Kachulio1

comment created time in 13 days

delete branch andela/andela-societies-frontend

delete branch : ft-display-activities-awaiting-approval-success-ops

delete time in 13 days

push eventandela/andela-societies-frontend

Chris Maina

commit sha bdb1a80519c06e294db28e86ac432c5430dd7f37

feat(approve): Add Approve Budget page (#204) - move SocietyStatsComponent & TabsComponent to common folder - add ApproveActivitiesContainer - add TabsComponent - add ApproveBudgetComponent - add ApproveBudgetContainer tests - add getTabBorderClassname helper - add ApproveBudgetComponent tests - add Approve Budget nav item

view details

push time in 13 days

PR merged andela/andela-societies-frontend

Reviewers
Display activities awaiting approval success ops
What does this PR do?

Adds approve budget page/screen

Screenshots?

Screen Shot 2019-04-04 at 10 34 11 AM

+522 -177

0 comment

29 changed files

Chris-Maina

pr closed time in 13 days

pull request commentandela/andela-societies-frontend

Log points dack opacity background

@kimani-ndegwa do you want a full blur or this is ok ☝️

alexmochu

comment created time in 13 days

push eventandela/andela-societies-frontend

kachulio1

commit sha db4a7276a45d30c932fa396d25bc4acc650c4979

add test

view details

push time in 16 days

push eventandela/andela-societies-frontend

kachulio1

commit sha c5dd6537000cac16d404674ad60dea886e321921

change select all to lowercase

view details

push time in 16 days

Pull request review commentandela/andela-societies-frontend

Display activities awaiting approval success ops

+import React from 'react';+import PropTypes from 'prop-types';++import { capitalize } from '../../utils';++export const TABS = {+  1: 'redemptions',+  2: 'invictus',+  3: 'phoenix',+  4: 'sparks',+};++export const getTabBorderClassname = (selectedTab) => {+  switch (selectedTab) {+  case TABS[1]:+    return `tab__selected--${TABS[1]}`;+  case TABS[2]:+    return `tab__selected--${TABS[2]}`;+  case TABS[3]:+    return `tab__selected--${TABS[3]}`;+  case TABS[4]:+    return `tab__selected--${TABS[4]}`;+  default:+    return 'tab__selected';+  }+};++const TabsComponent = ({ selectedTab, changeSelectedTab, tabNames }) => {+  const tabBorderClassname = getTabBorderClassname(selectedTab);+  return (+    <div className='tabs'>+      {tabNames+        && tabNames.map((name, index) => (+          <h3+            key={index} // eslint-disable-line react/no-array-index-key+            aria-hidden+            className={selectedTab === name ? 'user-dashboard__title selected__title' : 'user-dashboard__title'}+            onClick={() => changeSelectedTab(name)}+          >+            {capitalize(name)}+          </h3>+        ))}+      <div className='tab--underline' />+      <div className={tabBorderClassname} />+    </div>+  );+};++TabsComponent.defaultProps = {+  tabNames: [],+  changeSelectedTab: null,+  selectedTab: 'activities',

Why is the default prop for selctedTab 'activities'

Chris-Maina

comment created time in 17 days

Pull request review commentandela/andela-societies-frontend

Display activities awaiting approval success ops

+import React from 'react';+import { shallow } from 'enzyme';+import dateFns from 'date-fns';++import ApproveBudgetComponent from '../ApproveBudgetComponent';++import { redemptions, redemption } from '../../../Redemptions/components/tests/fixtures';++describe('<ApproveBudgetComponent />', () => {+  const setUpWrapper = ({ activities = [] } = {}) => {+    const props = {+      activities,+    };+    const shallowWrapper = shallow(<ApproveBudgetComponent {...props} />);+    return {+      shallowWrapper,

Is there a reason for returning this as an object

Chris-Maina

comment created time in 17 days

Pull request review commentandela/andela-societies-frontend

Display activities awaiting approval success ops

+import React, { Component } from 'react';+import { connect } from 'react-redux';+import PropTypes from 'prop-types';++import societyActions from '../../Societies/operations/actions';++import ApproveActivitiesComponent from './ApproveBudgetComponent';+import { ButtonComponent, SocietyStatsComponent, TabsComponent } from '../../common/components';++import ACTIVITY_STATUS from '../../common/constants';++export class ApproveBudgetContainer extends Component {+  static defaultProps = {+    society: {},+    fetchSocietyInfoRequest: null,+    fetchSocietyRedemptionsRequest: null,+  };++  static propTypes = {+    society: PropTypes.shape({}),+    fetchSocietyInfoRequest: PropTypes.func,+    fetchSocietyRedemptionsRequest: PropTypes.func,+  };++  state = {+    selectedSociety: 'istelle',+  };++  componentDidMount() {+    const { selectedSociety } = this.state;+    const { fetchSocietyRedemptionsRequest, fetchSocietyInfoRequest } = this.props;+    fetchSocietyInfoRequest(selectedSociety.toLowerCase());+    fetchSocietyRedemptionsRequest(selectedSociety.toLowerCase());+  }++  componentDidUpdate(prevProps, prevState) {+    const { selectedSociety } = this.state;+    const { fetchSocietyRedemptionsRequest, fetchSocietyInfoRequest } = this.props;++    if (prevState.selectedSociety !== selectedSociety && !prevProps.society[selectedSociety].redemptions.length) {+      fetchSocietyInfoRequest(selectedSociety.toLowerCase());+      fetchSocietyRedemptionsRequest(selectedSociety.toLowerCase());+    }+  }++  changeSelectedSociety = (tabName) => {

this param could be better if it was societyName

Chris-Maina

comment created time in 17 days

Pull request review commentandela/andela-societies-frontend

Filter engineer activities

 export class DashboardContainer extends Component {   state = {     user: {},     logPoints: false,+    filteredUserActivities: null,+    filterBy: [+      { name: 'Select All', checked: false },

Ahh, 😄

Kachulio1

comment created time in 17 days

Pull request review commentandela/andela-societies-frontend

Filter engineer activities

 export class DashboardContainer extends Component {           </div>           <div className='profile-overview col-sm-12'>             <div className='profile-overview__image' />-            <MyStatsComponent points={pointsEarned} activities={activitiesLogged} />-            <SocietyStatsComponent society={society} usedPoints={1508} remainingPoints={326} />+            <MyStatsComponent+              points={pointsEarned}+              activities={activitiesLogged}+            />+            <SocietyStatsComponent+              society={society}+              usedPoints={1508}

@Chris-Maina is working on that on his PR

Kachulio1

comment created time in 17 days

Pull request review commentandela/andela-societies-frontend

Display activities awaiting approval success ops

+import React from 'react';+import PropTypes from 'prop-types';++import { capitalize } from '../../utils';++export const TABS = {+  1: 'redemptions',+  2: 'invictus',+  3: 'phoenix',+  4: 'sparks',+};++export const getTabBorderClassname = (selectedTab) => {+  switch (selectedTab) {+  case TABS[1]:+    return `tab__selected--${TABS[1]}`;+  case TABS[2]:+    return `tab__selected--${TABS[2]}`;+  case TABS[3]:+    return `tab__selected--${TABS[3]}`;+  case TABS[4]:+    return `tab__selected--${TABS[4]}`;+  default:+    return 'tab__selected';+  }+};++const TabsComponent = ({ selectedTab, changeSelectedTab, tabNames }) => {+  const tabBorderClassname = getTabBorderClassname(selectedTab);+  return (+    <div className='tabs'>+      {tabNames+        && tabNames.map((name, index) => (+          <h3+            key={index} // eslint-disable-line react/no-array-index-key

just pass the name here coz tabs are unique

Chris-Maina

comment created time in 17 days

push eventKachulio1/plaunch

kachulio1

commit sha f59928a3b9a6410c3ae480b96bc260b191c0436c

putting back things as they were

view details

push time in 17 days

push eventKachulio1/plaunch

kachulio1

commit sha de172fcbea27ef5b228e66296da5630ecc09b6fc

fixed something

view details

push time in 17 days

push eventKachulio1/plaunch

kachulio1

commit sha b8ace93712617585fb3d655ec030d878fb8838d0

echo something

view details

push time in 17 days

push eventKachulio1/plaunch

kachulio1

commit sha c537b32f7a6b1dc7690f166f3b77028ce68f62c5

made a few changes

view details

push time in 17 days

push eventKachulio1/plaunch

kachulio1

commit sha 352872669fcc145dcb6056cc1452191fd501bc90

add docker runner

view details

push time in 17 days

push eventKachulio1/plaunch

kachulio1

commit sha 659bb2ba3ce9a207033d2513be616e693ef793ab

making a few changes

view details

push time in 17 days

PR opened andela/andela-societies-frontend

Filter engineer activities
What does this PR do?
Description of Task to be completed?
Any background context you want to provide?
What are the relevant Pivotal Tracker stories?
Questions?
Screenshots?
+11290 -21151

0 comment

453 changed files

pr created time in 19 days

create barnchandela/andela-societies-frontend

branch : filter-activity

created branch time in 19 days

push eventandela/andela-societies-frontend

Chris Maina

commit sha ad08442b7f479122d3014e8c6ae801a207c659c5

#164830528 Display redemptions page (#201) * feat: add redemptions screen - add tests * feat: add redemptions nav item - add fetchSocietyInfoRequest request * chore: add SidebarContainer tests

view details

push time in 22 days

PR merged andela/andela-societies-frontend

#164830528 Display redemptions page
What does this PR do?

Add Redemptions page

What are the relevant Pivotal Tracker stories?

164830528

Screenshots?

Screen Shot 2019-03-28 at 1 06 59 PM

+417 -19

0 comment

10 changed files

Chris-Maina

pr closed time in 22 days

delete branch andela/andela-societies-frontend

delete branch : bg-activity-date-table

delete time in 23 days

push eventandela/andela-societies-frontend

Alex Mochu

commit sha be6c257cf0c23c22bad6ebf88cdd223146caec69

Fix the Activity category and Date display (#203) * feat(sidebar): get user id from token * fix activity category and date name formats

view details

push time in 23 days

PR merged andela/andela-societies-frontend

Fix the Activity category and Date display
What does this PR do?
Description of Task to be completed?
Screenshots?
Before

Screenshot 2019-04-01 at 23 01 24

After

Screenshot 2019-04-01 at 23 08 30

+15 -15

0 comment

6 changed files

alexmochu

pr closed time in 23 days

delete branch andela/andela-societies-frontend

delete branch : bg-get-userid-in-sidebar-container

delete time in 23 days

push eventandela/andela-societies-frontend

Chris Maina

commit sha b7a1275041f0b63d7fcf6b054d34b741ef8c0a3e

feat(sidebar): get user id from token (#202)

view details

push time in 23 days

PR merged andela/andela-societies-frontend

Avail userId to fetchUserRole
What does this PR do?

Fixes the bug to avail userId at all times to fetchUserRole.

+6 -6

0 comment

3 changed files

Chris-Maina

pr closed time in 23 days

push eventKachulio1/plaunch

kachulio1

commit sha 950bc7956a3b59f6990398a5265580b441c802ec

fix url for circleci

view details

push time in 24 days

push eventKachulio1/plaunch

kachulio1

commit sha d6e937c724f7eef3e5b878af341b2be6256c1bb0

fix url

view details

push time in 24 days

create barnchKachulio1/plaunch

branch : master

created branch time in 24 days

created repositoryKachulio1/plaunch

A simple CMD line tool to Improve Your Workflow

created time in 24 days

delete branch andela/andela-societies-frontend

delete branch : ft-log-points-toast-message

delete time in a month

PR merged andela/andela-societies-frontend

#164397766 Display Toast message after successfully logging an activity
What does this PR do?

As a Fellow, I should be able to see a Toast message after Login my society activity points.

What are the relevant Pivotal Tracker stories?

#164397766

Screenshots?
  • Here is a demo link
  • Toast message Screenshot 2019-03-27 at 19 58 40
+262 -15

2 comments

13 changed files

alexmochu

pr closed time in a month

push eventandela/andela-societies-frontend

Alex Mochu

commit sha c195106841d3c2f765eb76cb07ad7c9f289ec830

#164397766 Display Toast message after successfully logging an activity (#196) * Redux Saga setup * Clean Saga examples * Onboading screen * log points * merge conflicts * Log society activity points * Log points reducer tests * log activity points action tests * log activity points generators and component tests * refactor and implement review feedback * remove evaluation * update branch * add expects blocks to my tests * team feedback implementation * improve test coverage * improve test coverage * improve tests * toast component * Remove unnecessary code * logged activity should be added to the user activity list * Rename file * test componentDidUpdate * add snapshot * toast component * fix datefns time format error * success toast message * Clean Saga examples * resolve conflicts

view details

push time in a month

delete branch andela/andela-societies-frontend

delete branch : ch-164860619-add-user-D-level

delete time in a month

PR merged andela/andela-societies-frontend

Reviewers
#164860619 Add user's D-level
What does this PR do?

Adds a user's D level

What are the relevant Pivotal Tracker stories?

#164860619

Screenshots?

Screen Shot 2019-03-25 at 1 56 50 PM

+41 -19

0 comment

7 changed files

Chris-Maina

pr closed time in a month

push eventandela/andela-societies-frontend

Chris Maina

commit sha 366a93e15f5033704ff4cf2e707204892ae1c19f

chore(dlevel): add user's dlevel (#199)

view details

push time in a month

delete branch andela/andela-societies-frontend

delete branch : ft-163083300-display-activities-awaiting-verification

delete time in a month

PR merged andela/andela-societies-frontend

#163083300 Display activities awaiting verification by a society secretary
What does this PR do?

Enables a society secretary to view activities awaiting approval

Description of Task to be completed?
  • Add VerifyActivitiesContainer
  • Add VerifyActivitiesComponent
  • Add ActionsComponent
  • Add tests
What are the relevant Pivotal Tracker stories?

163083300

Screenshots?

Screen Shot 2019-03-22 at 12 33 09 PM

+781 -113

0 comment

41 changed files

Chris-Maina

pr closed time in a month

push eventandela/andela-societies-frontend

Chris Maina

commit sha 76a17f154e3d55330243d5e2f0f68bb000365241

#163083300 Display activities awaiting verification by a society secretary (#198) * feat(societyTabs): add TabsComponent - add selectedSocietyTab mixin - add styles for the selected tab title - add fetch society redemptions action types - handle fetch society redemptions actions in reducer - add fetch society redemptions generators - modify container to stateless component ): refactor tabs container * feat(verify): add Sidebar domain - rename SidebarComponent to SidebarContainer - add verify activities nav item - conditionally render an outlined checkmark - add outlined checkmark styles - add fetch user role actions, types, saga - handle actions in reducer - add sidebar initial state - conditionally render verify activities nav item - add VerifyActivities container - add VerifyActivitiesComponent - add tests - add ActionsComponent - add LoaderComponent - add action, reducer and saga tests

view details

push time in a month

push eventandela/andela-societies-frontend

Chris Maina

commit sha 6d80bb067ccada9a63529ead0bc082faaad35567

#164528722 Switch between activities and redemption tabs on any society page (#195) * feat(societyTabs): add TabsComponent - add selectedSocietyTab mixin - add styles for the selected tab title - add fetch society redemptions action types - handle fetch society redemptions actions in reducer - add fetch society redemptions generators - modify container to stateless component ): refactor tabs container * feat(societyTabs): display redemptions table - add selectedTab prop to SocietyActivitiesComponent - conditionally display redemptions table - add pointsToDollarConverter util - modify society initial state - add societyName to fetchSocietyInfoSuccess payload - refactor state returned in FETCH_SOCIETY_INFO_SUCCESS case block - refactor mapStateToProps to add society - add fetch society redemptions tests - add test to handle case FETCH_SOCIETY_REDEMPTIONS_SUCCESS in reducer - add watchFetchSocietyRedemptionsReq and fetchSocietyRedemptions generator tests - add pointsToDollarConverter test - add TabsComponent tests

view details

push time in a month

PR merged andela/andela-societies-frontend

Reviewers
#164528722 Switch between activities and redemption tabs on any society page
What does this PR do?

Enables a user to switch between Activities and Redemptions while on any society page

Description of Task to be completed?
  • Modify society initial state.
  • Add redemptions table
  • Add a component for the Activities and Redemptions tabs
  • Add actions, reducer, saga to fetch a society's redemptions
Any background context you want to provide?
What are the relevant Pivotal Tracker stories?

164528722

Screenshots?

Activities tab

Screen Shot 2019-03-22 at 12 44 41 PM

Redemptions tab

Screen Shot 2019-03-22 at 12 47 09 PM

+490 -91

0 comment

23 changed files

Chris-Maina

pr closed time in a month

delete branch andela/andela-societies-frontend

delete branch : ft-log-points-success

delete time in a month

more