profile
viewpoint
Josh Goldberg JoshuaKGoldberg @Codecademy Brooklyn, NYC http://www.joshuakgoldberg.com web platform @codecademy 💖✨ prev @microsoft (sway) ✨ open source things ✨ @typescript contributor, tslint-to-eslint-config maintainer, side of accessibility

Codecademy/engineering-competencies 24

Evaluation metrics we use for engineering peer feedback.

automutate/automutate 11

Applies waves of mutations provided by other tools, such as linters or codemods.

JoshuaKGoldberg/Bookswap 8

A hub for students to buy & sell textbooks on campus.

Codecademy/console-fail-test 5

Gently fails test runs if the console was used during them. ✅

automutate/autolesshint 4

Automatically fixes Lesshint complaints.

budgielang/HighSchoolHacking 3

High School Hacking is a program for high schoolers to get more involved with programming.

aionate0812/bundle_backend 2

Backend API for bundle.tips - A mobile-first, trip-readiness app

JoshuaKGoldberg/async-await-generators-typescript-and-jquery 2

A brief explaration for SeattleJS into async/await, generators, and hacking TypeScript to like jQuery.

JoshuaKGoldberg/bellevuejs-linting 2

A (JS|TS)Lint BellevueJS talk @ Microsoft.

automutate/automutate-tests 1

Test harness for automutators.

issue openedmicrosoft/TypeScript

Type error emitted for valid type index lookups in variadic tuple types

TypeScript Version: 4.0.0--beta

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: cannot be used to index type tuple partial generic template variadic

Code

type WithOneMore<T extends unknown[]> = [...T, ''];

type LengthPlusOne<T extends unknown[]> = WithOneMore<T>['length'];

type TestNowFour = LengthPlusOne<['a', 'b', 'c']>;

Expected behavior:

There should be no type checker errors. TestNowFour is equal to the literal 4.

Actual behavior:

The following error is emitted for WithOneMore<T>['length']:

ts(2536): Type '"length"' cannot be used to index type '[...T, ""]'.

Interestingly, TestNowFour is computed to be equal to the literal 4.

Playground Link: Playground Link

Related Issues: Nothing particularly close. #5453 tracked the variadic kinds proposal and #39094 implemented them. I am keenly looking at what's coming out of the recursive conditional types mentioned in #40006 though...

created time in 3 hours

push eventCodecademy/client-modules

Neil Daftary

commit sha 9af792beedb0477ce27457793f34721bf61bd73b

Fix "Working with pre-published changes" readme format (#908) 💅

view details

Aaron Robb

commit sha 3db8c74f4f73153ca8409570bb424158495d2ce6

feat(Icons): Update Delete & Check Icons and add contributing guide GM-63 GM-67 (#912) * Update Delete & Check Icons and add contributing guide

view details

Aaron Robb

commit sha 04520b2002c8cb096ad97bf0c39f277fb8a794d4

feat(Overlay): Adds Overlay body scroll lock [GM-26] (#857)

view details

Aaron Robb

commit sha 966ce5542079f90c99d60a8aa85f832b638629bd

chore(release): publish - @codecademy/gamut-icons@3.1.0 - @codecademy/gamut-labs@1.9.0 - @codecademy/gamut@12.3.0 - @codecademy/styleguide@13.3.0

view details

codecademydev

commit sha c6b398f91eab35e857e6f44bc8894b2e66a878d5

chore: update changelogs

view details

Jake Hiller

commit sha 6ef5bb6e1d2223c800c4d3f34905a5bab378c659

chore: update changelogs

view details

Jake Hiller

commit sha 2bb761fa3133b858bcef7ea369f9a7b616b09c42

chore: fix package.json artifacts

view details

Jake Hiller

commit sha 88777373fbf084e5dd610cb967919d33138ce122

chore(deps): update react-use

view details

Jake Hiller

commit sha f6f41e123a5da8fba19e3d170716800fb7253496

chore(release): publish - @codecademy/gamut-labs@1.9.1 - @codecademy/gamut@12.3.1 - @codecademy/styleguide@13.3.1

view details

Jake Hiller

commit sha 00c57a1dab9fbc196f820471729dc5a43445280e

chore: fix git urls

view details

codecademydev

commit sha 6aa4690f3878e4ab783667ff4da6ab6628a22803

chore: update changelogs

view details

Jake Hiller

commit sha 2fbb0093ccb76ea6b200d52c154762d9cff17885

ci: update next branch publish command

view details

codecademydev

commit sha ecfb057bbea0bc36b16eb08cbf9ca46210036dfe

chore(release): publish - @codecademy/gamut-icons@3.1.1 - @codecademy/gamut-labs@1.9.2 - @codecademy/gamut-styles@4.2.4 - @codecademy/gamut@12.3.2 - @codecademy/styleguide@13.3.2

view details

codecademydev

commit sha 8d0c9ad2d69fdbf6b36a03f4c67d8db9d23aaeaf

chore: update changelogs

view details

Josh Goldberg

commit sha 8766e54f314e6c6035c0d4b67eaa79bc8bbae980

Merge branch 'main' into jg-exports-default-to-named

view details

push time in 7 hours

push eventCodecademy/client-modules

Josh Goldberg

commit sha f4dbece0a27a9a26c37a254e2eeba9ee411554c0

...and a renderer option

view details

push time in 10 hours

push eventCodecademy/client-modules

Josh Goldberg

commit sha 8d352d9d2a4d6b058ea6a4c9860508a428192a01

Lol, and no console log

view details

push time in 11 hours

push eventCodecademy/client-modules

Josh Goldberg

commit sha 4984f0de7c39560311cb9981c3695c72f3ab6daa

...and class name

view details

push time in 11 hours

push eventCodecademy/client-modules

Josh Goldberg

commit sha a36787c44d203a1caf6806cd1944d4b3e8ba6b71

Added onClick to Accordion

view details

push time in 11 hours

push eventCodecademy/client-modules

codecademydev

commit sha 8bcd244563c03a8873fa954f5355fd06d4356ee4

chore: update changelogs

view details

abhi gupta

commit sha 5a7b0b1494f56148fffbc241dd81f6f77eaf6889

fix(Toggle): Convert rem to px-rem() (#897) * [Toggle] add onClick, convert rem to px-rem() * [Toggle] remove onClick prop * add px to numbers in px-rem(), update thumb-small sizing

view details

Josh Goldberg

commit sha 1e7303c14b38c6def962259af8a4e938e2760237

fix: MarkdownAnchor should still render children (#909) * fix: MarkdownAnchor should still render children * Added Markdown-test test * Moved inside existing block

view details

codecademydev

commit sha 3387c8b6bd7d37511815356f76ee2fe3b17d5745

chore(release): publish - @codecademy/gamut-labs@1.8.6 - @codecademy/gamut@12.2.5 - @codecademy/styleguide@13.2.5

view details

codecademydev

commit sha bf81f1ebd4d928bfad7b66423afd94eb5b7dc01b

chore: update changelogs

view details

Aaron Robb

commit sha b8ce5a13ce54c543c1839eedc7d8e4c8470b871f

fix(CardShell): Add Cardshell to the sideEffect list (#910) * Add Cardshell to known side effects

view details

codecademydev

commit sha a0fd41c33262d60762167eb5c8489b845bcd9e4c

chore(release): publish - @codecademy/gamut-labs@1.8.7 - @codecademy/gamut@12.2.6 - @codecademy/styleguide@13.2.6

view details

codecademydev

commit sha 89031cd6236f8bfc0cf55dce097f808ea438d2df

chore: update changelogs

view details

Jake Hiller

commit sha 4fc8fb86fbe60b3ba8f95f0fc72fac8d78810f20

chore: remove changelog updates from changelogs (#911)

view details

codecademydev

commit sha 3ba548b685fea588df20ed4956316dd05ac8d868

chore: update changelogs

view details

Neil Daftary

commit sha 9af792beedb0477ce27457793f34721bf61bd73b

Fix "Working with pre-published changes" readme format (#908) 💅

view details

Aaron Robb

commit sha 3db8c74f4f73153ca8409570bb424158495d2ce6

feat(Icons): Update Delete & Check Icons and add contributing guide GM-63 GM-67 (#912) * Update Delete & Check Icons and add contributing guide

view details

Aaron Robb

commit sha 04520b2002c8cb096ad97bf0c39f277fb8a794d4

feat(Overlay): Adds Overlay body scroll lock [GM-26] (#857)

view details

Aaron Robb

commit sha 966ce5542079f90c99d60a8aa85f832b638629bd

chore(release): publish - @codecademy/gamut-icons@3.1.0 - @codecademy/gamut-labs@1.9.0 - @codecademy/gamut@12.3.0 - @codecademy/styleguide@13.3.0

view details

codecademydev

commit sha c6b398f91eab35e857e6f44bc8894b2e66a878d5

chore: update changelogs

view details

Jake Hiller

commit sha 6ef5bb6e1d2223c800c4d3f34905a5bab378c659

chore: update changelogs

view details

Jake Hiller

commit sha 2bb761fa3133b858bcef7ea369f9a7b616b09c42

chore: fix package.json artifacts

view details

Jake Hiller

commit sha 88777373fbf084e5dd610cb967919d33138ce122

chore(deps): update react-use

view details

Jake Hiller

commit sha f6f41e123a5da8fba19e3d170716800fb7253496

chore(release): publish - @codecademy/gamut-labs@1.9.1 - @codecademy/gamut@12.3.1 - @codecademy/styleguide@13.3.1

view details

Jake Hiller

commit sha 00c57a1dab9fbc196f820471729dc5a43445280e

chore: fix git urls

view details

push time in 11 hours

Pull request review commentCodecademy/client-modules

feat(Styles): Port SCSS utilities to TS

 module.exports = {     '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga|md)$':       '<rootDir>/script/jest/fileMock',     '\\.(css|scss)$': '<rootDir>/script/jest/styleMock',+    '^~styleguide/Blocks(.*)$':+      '<rootDir>/packages/styleguide/.storybook/Blocks$1',

@codecaaron Would you mind splitting these changes into a separate PR to keep this one smaller?

codecaaron

comment created time in 17 hours

issue closedmicrosoft/vscode

Cannot open Windows Terminal settings as default JSON file viewer

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.47.0
  • OS Version: 1903

Steps to Reproduce:

  1. Install Windows Terminal
  2. Set VS Code as your default .json file viewer
  3. Open Terminal
  4. Press <kbd>Ctrl</kbd>+<kbd>,</kbd> to open settings

At this point, Terminal will make the Windows error bloop sound and show this error popup for a fraction of a second (I could only get a screenshot using a still from screen recording):

Screenshot of a Visual Studio Code popup with black content instead of text

Switching the default .json file viewer to Notepad++ allows settings to open fine.

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

Moving issue over from https://github.com/microsoft/terminal/issues/6848.

closed time in 18 hours

JoshuaKGoldberg

issue commentmicrosoft/vscode

Cannot open Windows Terminal settings as default JSON file viewer

Huh, I just tried this again and it works now. 🤷 ... Guess it was a one-time thing. Thanks for the response anyway!

For reference, in https://github.com/microsoft/terminal/issues/6848#issuecomment-657597809 I was pointed to post here.

JoshuaKGoldberg

comment created time in 18 hours

create barnchtypescript-eslint/tslint-to-eslint-config

branch : main

created branch time in 2 days

push eventtypescript-eslint/tslint-to-eslint-config

Josh Goldberg

commit sha 02cfbea3fd923ebcce912399cefb824d1ca60ba4

1.3.0

view details

Josh Goldberg

commit sha a93f2678b403c862c33b2de7700eb5e54e7a3878

Switched publish task to main

view details

push time in 2 days

issue commenttypescript-eslint/tslint-to-eslint-config

Switch default branch to 'main'

Ah, incredible timing (seriously, I did not know about this blog post until after filing this issue!: https://blog.mozilla.org/blog/2020/08/11/changing-world-changing-mozilla/

I'll go ahead and make the change now.

JoshuaKGoldberg

comment created time in 2 days

issue closedtypescript-eslint/tslint-to-eslint-config

Missing merger for @typescript-eslint/naming-convention ESLint rule options

<!-- 👋 Hi, thanks for filing an issue on tslint-to-eslint-config! 💖 Please fill out all fields below to ensure your issue is addressed.

If your issue doesn't provide enough info to fully explain or reproduce your bug, it will be closed. 😦 -->

💥 Missing Merger

  • tslint-to-eslint-config version: 1.2.0
  • ESLint version: 7.6.0

CLI Output

❌ 1 error thrown. ❌ Check ./tslint-to-eslint-config.log for details

File Output

Error: multiple output @typescript-eslint/naming-convention ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this. Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md. Thanks!

Reproduction

No reproducing repository or gist is available.

tslint.json is

{
  "extends": ["tslint:latest", "tslint-config-prettier"]
}

tsconfig.json is

{
  "compilerOptions": {
    "allowJs": true,
    "declaration": true,
    "emitDecoratorMetadata": true,
    "esModuleInterop": true,
    "experimentalDecorators": true,
    "forceConsistentCasingInFileNames": true,
    "importHelpers": true,
    "lib": ["es2018"],
    "module": "commonjs",
    "moduleResolution": "node",
    "noEmit": true,
    "noImplicitReturns": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "preserveConstEnums": true,
    "skipLibCheck": true,
    "sourceMap": true,
    "strict": true,
    "suppressExcessPropertyErrors": true,
    "suppressImplicitAnyIndexErrors": true,
    "target": "es2018"
  }
}

package.json dependencies and devDependencies are these

  "dependencies": {
    "@nestjs/common": "^7.4.2",
    "@nestjs/core": "^7.4.2",
    "reflect-metadata": "^0.1.13",
    "rxjs": "^6.6.2",
    "tslib": "^2.0.1"
  },
  "devDependencies": {
    "@types/jest": "^26.0.9",
    "@types/node": "^14.0.27",
    "@types/webpack": "^4.41.21",
    "@types/webpack-node-externals": "^2.5.0",
    "@typescript-eslint/eslint-plugin": "^3.9.0",
    "@typescript-eslint/eslint-plugin-tslint": "^3.9.0",
    "@typescript-eslint/parser": "^3.9.0",
    "eslint": "^7.6.0",
    "eslint-config-prettier": "^6.11.0",
    "eslint-plugin-import": "^2.22.0",
    "eslint-plugin-jsdoc": "^30.2.1",
    "eslint-plugin-prefer-arrow": "^1.2.2",
    "eslint-plugin-react": "7.20.5",
    "jest": "^26.3.0",
    "jest-junit": "^11.1.0",
    "jest-sonar": "^0.2.10",
    "npm-run-all": "^4.1.5",
    "rimraf": "^3.0.2",
    "ts-jest": "^26.1.4",
    "ts-loader": "^8.0.2",
    "tslint": "^6.1.3",
    "tslint-config-prettier": "^1.18.0",
    "typescript": "^3.9.7",
    "webpack": "^4.44.1",
    "webpack-node-externals": "^2.5.1"
  },

closed time in 2 days

dls314

issue commenttypescript-eslint/tslint-to-eslint-config

Missing merger for @typescript-eslint/naming-convention ESLint rule options

Thanks for the report @dls314! This issue is actually a dup of #666, which was resolved in #674 and just now released in package version 1.3.0.

dls314

comment created time in 2 days

created tagtypescript-eslint/tslint-to-eslint-config

tagv1.3.0

Converts your TSLint configuration to the closest possible ESLint equivalent. 🚀

created time in 2 days

release typescript-eslint/tslint-to-eslint-config

v1.3.0

released time in 2 days

push eventtypescript-eslint/tslint-to-eslint-config

Manuel Bojato

commit sha ee52ef7ff1ccf8f6d22a4da11d34213c88b426b8

Add naming-convention merger (#674)

view details

push time in 2 days

PR merged typescript-eslint/tslint-to-eslint-config

Add naming-convention merger status: waiting for reviewer

<!-- 👋 Hi, thanks for sending a PR to tslint-to-eslint-config! 💖 Please fill out all fields below to ensure your PR is reviewed quickly. -->

PR Checklist

Overview

<!-- Brief description of what is changed and how the code change does that. -->

Never had a good experience with mergers but guess this is the way to do it 😆

+107 -0

0 comment

3 changed files

KingDarBoja

pr closed time in 2 days

issue closedtypescript-eslint/tslint-to-eslint-config

Missing Merger for @typescript-eslint/naming-convention

💥 Missing Merger

  • tslint-to-eslint-config version: 1.1.0
  • ESLint version: 7.6.0

CLI Output

✨ 111 rules replaced with their ESLint equivalents. ✨

❗ 8 ESLint rules behave differently from their TSLint counterparts ❗
  Check ./tslint-to-eslint-config.log for details.

❌ 2 errors thrown. ❌
  Check ./tslint-to-eslint-config.log for details.

❓ 6 rules are not known by tslint-to-eslint-config to have ESLint equivalents. ❓
  The "@typescript-eslint/tslint/config" section of ./.eslintrc.js configures eslint-plugin-tslint to run them in TSLint within ESLint.
  Check ./tslint-to-eslint-config.log for details.

☠ Prettier plugins are missing from your configuration. ☠
  We highly recommend running tslint-to-eslint-config --prettier to disable formatting ESLint rules.
  See https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md#should-i-use-prettier.

♻ Consider using --comments to replace TSLint comment directives in your source files. ♻

⚡ 8 new packages are required for this ESLint configuration. ⚡
  npm install @typescript-eslint/eslint-plugin @typescript-eslint/eslint-plugin-tslint @typescript-eslint/parser eslint eslint-plugin-import eslint-plugin-jsdoc eslint-plugin-prefer-arrow eslint-plugin-react --save-dev

✅ All is well! ✅

File Output

8 ESLint rules behave differently from their TSLint counterparts:
  * no-console:
    - Custom console methods, if they exist, will no longer be allowed.
  * no-invalid-this:
    - Functions in methods will no longer be ignored.
  * @typescript-eslint/no-unused-expressions:
    - The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.
  * prefer-arrow/prefer-arrow-functions:
    - ESLint does not support allowing standalone function declarations.
    - ESLint does not support allowing named functions defined with the function keyword.
  * eqeqeq:
    - Option "smart" allows for comparing two literal values, evaluating the value of typeof and null comparisons.
  * no-underscore-dangle:
    - Leading or trailing underscores (_) on identifiers will now be forbidden.
  * no-redeclare:
    - ESLint does not support check-parameters.
  * import/no-unassigned-import:
    - ESLint's import/no-unassigned-import now accepts a glob pattern for ignores; you'll need to manually convert your ignore-module settings.

Error: multiple output @typescript-eslint/naming-convention ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.
Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md. Thanks!

Error: multiple output @typescript-eslint/naming-convention ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.
Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md. Thanks!

6 rules are not known by tslint-to-eslint-config to have ESLint equivalents:
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-no-bind".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-no-lambda".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-no-string-ref".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "jsx-self-close".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "object-literal-sort-keys".
  * tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "prefer-conditional-expression".

Reproduction

  • nothing special, I had to first upgrade tslint to latest version for the tool to work
  • install the migration tool
  • run npx tslint-to-eslint-config
  • NOTE: parameters are ignored completely, if you add e.g. "--prettier" you will still get the CLI output saying it's recommended to use prettier

closed time in 2 days

mKusch

delete branch Codecademy/40Phaser

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 2 days

push eventCodecademy/40Phaser

dependabot[bot]

commit sha ee18d894b4aabe5314cbeffe063d9fb3bf5f0ea2

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Josh Goldberg

commit sha e017b6f5141c89b74f47fdd5824faba2825eb623

Merge pull request #76 from Codecademy/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 2 days

PR merged Codecademy/40Phaser

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -11

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

delete branch Codecademy/40Phaser

delete branch : master

delete time in 2 days

delete branch Codecademy/40Phaser

delete branch : gr-move-dom-element-creation-to-js

delete time in 2 days

delete branch Codecademy/40Phaser

delete branch : gr-40-phaser-pass-score-LTA-3579

delete time in 2 days

delete branch Codecademy/40Phaser

delete branch : jg-prettier-and-package-json

delete time in 2 days

create barnchCodecademy/40Phaser

branch : main

created branch time in 2 days

delete branch Codecademy/codecademy-syntax-theme-vscode

delete branch : master

delete time in 2 days

create barnchCodecademy/codecademy-syntax-theme-vscode

branch : main

created branch time in 2 days

delete branch Codecademy/mock-react-redux

delete branch : master

delete time in 2 days

push eventCodecademy/mock-react-redux

Josh Goldberg

commit sha 6c492a9cc74d1d8bc5d230e0c041720cfcfd38d4

Switched publish to run on main

view details

push time in 2 days

delete branch Codecademy/console-fail-test

delete branch : master

delete time in 2 days

create barnchCodecademy/mock-react-redux

branch : main

created branch time in 2 days

push eventCodecademy/console-fail-test

Josh Goldberg

commit sha 3ec6caf1765f87ae831f60c98476716f263970f4

Set publish to run on main

view details

push time in 2 days

push eventCodecademy/console-fail-test

dependabot[bot]

commit sha f01c6eb8c7a99781f1d14d23500c053b895ead40

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Josh Goldberg

commit sha 131c630c67330722ae219c900c49d0488e26e7f2

Merge pull request #60 from Codecademy/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 2 days

delete branch Codecademy/console-fail-test

delete branch : jg-format-line-arg-stringify

delete time in 2 days

delete branch Codecademy/console-fail-test

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 2 days

push eventCodecademy/console-fail-test

dependabot[bot]

commit sha f01c6eb8c7a99781f1d14d23500c053b895ead40

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Josh Goldberg

commit sha 131c630c67330722ae219c900c49d0488e26e7f2

Merge pull request #60 from Codecademy/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 2 days

PR merged Codecademy/console-fail-test

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

create barnchCodecademy/console-fail-test

branch : main

created branch time in 2 days

PR opened Codecademy/client-modules

chore!: Migrated default exports to named

Overview

PR Checklist

  • ~[ ] Related to Abstract designs:~
  • [x] Related to JIRA ticket: WEB-1018
  • [x] I have run this code to verify it works
  • [x] This PR includes unit tests for the code change

Description

Per the Migration: Default to Named Exports RFC, removes export defaults from the repository and adds in any missing named equivalents.

+206 -567

0 comment

215 changed files

pr created time in 2 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha fc62f980f53c7be661662c3206ad68fa162c87cd

Migrated default exports to named

view details

push time in 2 days

Pull request review commentCodecademy/client-modules

feat(Overlay): Adds Overlay body scroll lock [GM-26]

 export const Overlay: React.FC<OverlayProps> = ({ }) => {   if (!isOpen) return null; +  const body = document.querySelector('body');+  const onOpen = () => body.classList.add(styles.modalOpen);+  const onClose = () => body.classList.remove(styles.modalOpen);+   return (-    <BodyPortal>+    <BodyPortal onMount={onOpen} onDismount={onClose}>

My vote is: yes 😄

codecaaron

comment created time in 2 days

create barnchCodecademy/client-modules

branch : jg-exports-default-to-named

created branch time in 2 days

push eventkaraokenite/karaokenite-react

Josh Goldberg

commit sha 8dc438b08538b0cfb70011ef9a0d868b1d05e18d

About page touchups

view details

push time in 3 days

push eventkaraokenite/karaokenite-react

Josh Goldberg

commit sha 5bc1b736bdaa05d84466ad8478b04158e1224f30

About page too

view details

push time in 3 days

delete branch karaokenite/karaokenite-react

delete branch : master

delete time in 3 days

create barnchkaraokenite/karaokenite-react

branch : main

created branch time in 3 days

delete branch typescript-eslint/tslint-to-eslint-config

delete branch : editor-settings-tslint-config-file

delete time in 3 days

create barnchkaraokenite/karaokenite-react

branch : master

created branch time in 3 days

created repositorykaraokenite/karaokenite-react

Experimental Next.js + React + TypeScript version of Karaoke Nite. 🚀

created time in 3 days

push eventtypescript-eslint/tslint-to-eslint-config

Josh Goldberg

commit sha ba183c90ccb569ba588d189648de95c80c67885c

Added editor settings converter for tslint.configFile, with full settings access (#652) * Ignore all unknown editor settings in conversion * Added editor settings converter for tslint.configFile, with full settings access * Unit test fix * unused variable

view details

push time in 3 days

PR merged typescript-eslint/tslint-to-eslint-config

Added editor settings converter for tslint.configFile, with full settings access

PR Checklist

Overview

The VS Code TSLint extension allow for a custom configuration path other than tslint.json via tslint.configFile. Now, if that exists in the original editor settings and matches the directory name of the output ESLint file path, the new ESLint editor settings will include the output ESLint file path.

This logic necessitated adding settings: TSLintToESLintSettings as an argument to EditorSettingConverters. Otherwise the file diff is actually not that big 😉.

+129 -25

0 comment

12 changed files

JoshuaKGoldberg

pr closed time in 3 days

issue closedtypescript-eslint/tslint-to-eslint-config

Missing VS Code editor setting converter: tslint.configFile

💥 Missing Editor Setting

  • tslint-to-eslint-config version: 1.0.0
  • typescript-eslint version: N/A

tslint.configFile exists in https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin#configuration. Its equivalent in https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint is eslint.options, I think:

{
  "eslint.options": { "configFile": "C:/mydirectory/.eslintrc.json" }
}

closed time in 3 days

JoshuaKGoldberg

startedvercel/next.js

started time in 3 days

created tagtypescript-eslint/tslint-to-eslint-config

tagv1.2.0

Converts your TSLint configuration to the closest possible ESLint equivalent. 🚀

created time in 4 days

release typescript-eslint/tslint-to-eslint-config

v1.2.0

released time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

Josh Goldberg

commit sha ed90d948274d0815abb27f79370af12f226b1ecb

1.2.0

view details

push time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

Josh Goldberg

commit sha 56f2d13b4f244392ce2bdb019a7a4be23ea7bef8

unused variable

view details

push time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

Josh Goldberg

commit sha d72f2b8afec096ce236fd8fcaea3e56ff625b34f

Unit test fix

view details

push time in 4 days

delete branch typescript-eslint/tslint-to-eslint-config

delete branch : ignore-all-unknown-editor-settings

delete time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

renovate[bot]

commit sha f68c0964bd77b62edc9854eac83c7c21141760df

chore(deps): update typescript-eslint monorepo to v3.6.1 (#632) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 98aa3e30eb85d7014d33bbfd2c9b10dc95644df8

chore(deps): update dependency @babel/core to v7.10.5 (#633) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 7e2add3ef48ec571e1f8ea185bdff263a09e50fd

fix(deps): update dependency typescript to v3.9.7 (#634) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

dependabot[bot]

commit sha 9f5b5c9abecb63791f8bef0c97907bb913dcc1f9

Bump lodash from 4.17.15 to 4.17.19 (#635) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

renovate[bot]

commit sha 7670f685b06bd818c47256edeefe17f8a93cbb87

chore(deps): update dependency @types/jest to v26.0.5 (#639) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha e835b1ff07a557ebac2ce39a2c82e7a1b478c1b0

chore(deps): update dependency eslint to v7.5.0 (#640) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha b72288708fb5c4e00ce2f1921b039097e91ae2b2

fix(deps): update dependency commander to v6 (#641) * fix(deps): update dependency commander to v6 * fix: now use command.opts to retrieve version Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: KingDarBoja <stevenbojato04@gmail.com>

view details

Manuel Bojato

commit sha 9425e3dcb5a7d66778ce3f27bac5d6195e400397

chore: add dependencies label on renovatebot PRs (#642)

view details

renovate[bot]

commit sha ab9c262fae5cbc9508b23efd759253baf8ef26d8

chore(deps): update typescript-eslint monorepo to v3.7.0 (#643) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 3882db98c2e33c2b4da13a8e92d0e45b9d85ac0b

chore(deps): update dependency @types/jest to v26.0.6 (#646) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 2639766f245c371b5edff5193b8695710a2f1e40

chore(deps): update dependency @types/jest to v26.0.7 (#649) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Dan Vanderkam

commit sha 485fc032d64f541b21ef0f8166227976d1e744f5

Quote wildcards for shell command (#644)

view details

Manuel Bojato

commit sha 1073733f616db8ad11cea09e7e2837b783dc3470

Added jsx-key converter (#638) * Added jsx-key converter * Remove ruleArguments in jsx-key converter

view details

Manuel Bojato

commit sha 8ffc537f8b43caf151ddf7b5a61a8f3ef3ce9136

fix: do not convert next-line to line for comments (#648) * fix: do not convert next-line to line for comments * fix: check the comment directive

view details

Manuel Bojato

commit sha 95a5f24fbb59457cce3e2d943c23ff4fd4217750

Added jsx-equals-spacing converter (#637) * Added jsx-equals-spacing converter * Split jsx-equals-spacing tests Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>

view details

Manuel Bojato

commit sha 7018689a2576203354d88966fd2265640da283cf

Added jsx-curly-spacing converter (#636) * Added jsx-curly-spacing converter * Split jsx-curly-spacing tests Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>

view details

Manuel Bojato

commit sha a6da0ec7fcc4ef6561f1f29acf2f8dbf0149f145

fix: converters now uses naming-convention (#617) * fix: converters now uses naming-convention * Fix interface-name converter

view details

renovate[bot]

commit sha 63ba9dff2b56f5116a04d4f770f3ee205fef572c

chore(deps): update typescript-eslint monorepo to v3.7.1 (#653) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Josh Goldberg

commit sha 02ac0f7aa3a944665ca7ee94598af21bd7fd5427

Ignore all unknown editor settings in conversion (#650)

view details

Josh Goldberg

commit sha 899c4923ba68cbdaa768e46799a7ea7b9254f144

1.1.0

view details

push time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

Yasar Siddiqui

commit sha a55bbfbc56346b5dc0dc80ec0f6a9621d896c007

Recognize tslint-react as an extended ruleset (#656) * Recognize tslint-react as an extended ruleset * add 'react/recommended' to retriveExtendsValue Co-authored-by: Yasar Siddiqui <mosiddiq@microsoft.com>

view details

push time in 4 days

PR merged typescript-eslint/tslint-to-eslint-config

Recognize tslint-react as an extended ruleset status: waiting for author

<!-- 👋 Hi, thanks for sending a PR to tslint-to-eslint-config! 💖 Please fill out all fields below to ensure your PR is reviewed quickly. -->

PR Checklist

Overview

Recognize tslint-react as a extended ruleset.

Github Issue

If a rule extends from tslint-react , we will now add react/recommended to the configuration.

Recommendation from eslint-plugin-react are present Here. I have left out eslint:recommended not sure if that would be required.

Have added unit tests and verified if the coverage remains at 100%.

<!-- Brief description of what is changed and how the code change does that. -->

+15 -0

2 comments

3 changed files

yasarsid

pr closed time in 4 days

issue closedtypescript-eslint/tslint-to-eslint-config

Recognize tslint-react as an extended ruleset

🚀 Feature Request

If a TSLint configuration extends from tslint-react, we should know to make the output ESLint configuration extend from eslint-plugin-react.

Existing Behavior

The React community plugins are not recognized by collectTSLintRuleset''s native extensions list.

Change Proposal

Add tslint-react -> eslint-plugin-react to that list.

closed time in 4 days

JoshuaKGoldberg

pull request commenttypescript-eslint/tslint-to-eslint-config

Recognize tslint-react as an extended ruleset

So thorough, this is great!

Yes, #666 is filed separately for the missing naming-convention merger. Much appreciated!

yasarsid

comment created time in 4 days

delete branch typescript-eslint/tslint-to-eslint-config

delete branch : commander-opts

delete time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

Josh Goldberg

commit sha 809f46b3ae935ab02397b8e33b72b14f952e442f

Used commander's .opts() to parse raw argv (#672)

view details

push time in 4 days

PR merged typescript-eslint/tslint-to-eslint-config

Used commander's .opts() to parse raw argv status: waiting for reviewer

PR Checklist

Overview

As of either the latest Node version or latest commander version (I haven't checked but suspect commander), member variables such as .prettier aren't being set on the command object. They're now available on .opts().

+1 -1

1 comment

1 changed file

JoshuaKGoldberg

pr closed time in 4 days

issue closedtypescript-eslint/tslint-to-eslint-config

CLI Flags do not work for nodejs 14

🐛 Bug Report

  • tslint-to-eslint-config version: 1.1.0
  • ESLint version: 7.5.0
  • Node version: 14.6.0

Actual Behavior

I just used the recommended command npx tslint-to-eslint-config --prettier to convert the lint config. However, I always get the suggestion in the logging message:

☠ Prettier plugins are missing from your configuration. ☠
  We highly recommend running tslint-to-eslint-config --prettier to disable formatting ESLint rules.
  See https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md#should-i-use-prettier.

Meanwhile, no configurations about prettier would be inserted in the generted .eslintrc.js file.

I wonder what's wrong here. Did I forget some required plugins or install wrong version of those dependencies? I know some more dependencies are requied here for further use together with eslint. I just want to first make sure the convertion of lint configuration is correct. Unfortunately, it doesn't work for me.

Expected Behavior

No more suggestions in the console message. Relevant config values for prettier would be added into the .eslintrc.js

Reproduction

Use nodejs 14.6.0

npm install -g @angular/cli
ng new my-dream-app
cd my-dream-app
npm i --save-dev eslint
npx tslint-to-eslint-config --prettier

closed time in 4 days

kevinprotoss

PR opened typescript-eslint/tslint-to-eslint-config

Used commander's .opts() to parse raw argv

PR Checklist

Overview

As of either the latest Node version or latest commander version (I haven't checked but suspect commander), member variables such as .prettier aren't being set on the command object. They're now available on .opts().

+1 -1

0 comment

1 changed file

pr created time in 4 days

create barnchtypescript-eslint/tslint-to-eslint-config

branch : commander-opts

created branch time in 4 days

issue commenttypescript-eslint/tslint-to-eslint-config

CLI Flags do not work for nodejs 14

Fascinating. It looks like the options getting parsed aren't including prettier in https://github.com/typescript-eslint/tslint-to-eslint-config/blob/b72288708fb5c4e00ce2f1921b039097e91ae2b2/src/cli/runCli.ts#L38 .

Switching to using .opts() fixes it. I'll send a PR.

kevinprotoss

comment created time in 4 days

Pull request review commenttypescript-eslint/tslint-to-eslint-config

Added jsx-ban-elements converter

+import { RuleConverter } from "../../converter";++export const convertJsxBanElements: RuleConverter = (tslintRule) => {+    return {+        rules: [+            {+                ...collectArguments(tslintRule.ruleArguments),+                ruleName: "react/forbid-elements",+            },+        ],+        plugins: ["eslint-plugin-react"],+    };+};++const collectArguments = (ruleArguments: any[]) => {+    if (ruleArguments.length === 0) {+        return undefined;+    }++    const forbidArr: any[] = [];

Indeed, a [string, string][] would be a more accurate type definition.

himgupta72

comment created time in 4 days

Pull request review commenttypescript-eslint/tslint-to-eslint-config

Added jsx-ban-elements converter

+import { RuleConverter } from "../../converter";++export const convertJsxBanElements: RuleConverter = (tslintRule) => {+    return {+        rules: [+            {+                ...collectArguments(tslintRule.ruleArguments),+                ruleName: "react/forbid-elements",+            },+        ],+        plugins: ["eslint-plugin-react"],+    };+};++const collectArguments = (ruleArguments: any[]) => {+    if (ruleArguments.length === 0) {+        return undefined;+    }++    const forbidArr: any[] = [];+    for (const element of ruleArguments) {

Mild style nitpicking here: this for loop has the sole purpose of pushing to an array, so I think it'd be a little cleaner to use a .map instead.

const forbiddenElements = ruleArguments.map((ruleArgument) => {
    return {
        element: element[0],
        ...(element.length === 2 && { message: element[1] })
    };
});

(also, === instead of == please)

himgupta72

comment created time in 4 days

push eventtypescript-eslint/tslint-to-eslint-config

Sakshi Gupta

commit sha 9cd2b70af91701766d286495b68dad48eebf6843

Adding the rule, mapping it and writing the tests (#658) Co-authored-by: Sakshi Gupta <sakgu@microsoft.com>

view details

push time in 4 days

PR merged typescript-eslint/tslint-to-eslint-config

Adding the rule converter for jsx-wrap-multiline

<!-- 👋 Hi, thanks for sending a PR to tslint-to-eslint-config! 💖 Please fill out all fields below to ensure your PR is reviewed quickly. -->

PR Checklist

Overview

<!-- Brief description of what is changed and how the code change does that. -->

  1. Adding a rule converter for tslint rule jsx-wrap-multiline, Equivalent eslint rule is react/jsx-wrap-multilines (https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-wrap-multilines.md) react/jsx-wrap-multilines- "This rule optionally takes a second parameter in the form of an object, containing places to apply the rule. By default, all the syntax listed below will be checked except the conditions out of declaration or assignment, logical expressions and JSX attributes, but these can be explicitly disabled. Any syntax type missing in the object will follow the default behavior displayed below." Since tslint rule jsx-wrap-multiline does not provide any options, I have not provided the second optional argument to the eslint rule react/jsx-wrap-multiline, so it is the default.
  2. Added the required tests.
+32 -0

0 comment

3 changed files

sakshi-gupta95

pr closed time in 4 days

issue closedtypescript-eslint/tslint-to-eslint-config

Missing tslint-react rule: jsx-wrap-multiline

Missing Converter

  • tslint-to-eslint-config version: 1.0.0-beta

  • typescript-eslint version: 2.31.0

TSLint Rule Name

jsx-wrap-multiline

Package Source

tslint-react: https://github.com/palantir/tslint-react (see #rules)

Equivalents for tslint-react rules generally live in eslint-plugin-react. If an ESLint rule equivalent doesn't yet exist, this tslint-to-eslint-config issue can be closed until that equivalent is created.

closed time in 4 days

JoshuaKGoldberg

pull request commentCodecademy/client-modules

docs(Readme): Fix "Working with pre-published changes" format

@neilzo you experienced the joy of Codecov being weird. Don't worry, you'll experience it again.

neilzo

comment created time in 6 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha 1e7303c14b38c6def962259af8a4e938e2760237

fix: MarkdownAnchor should still render children (#909) * fix: MarkdownAnchor should still render children * Added Markdown-test test * Moved inside existing block

view details

push time in 6 days

delete branch Codecademy/client-modules

delete branch : jg-markdown-anchor-kids

delete time in 6 days

PR merged Codecademy/client-modules

fix: MarkdownAnchor should still render children

Overview

PR Checklist

  • [ ] Related to Abstract designs:
  • [ ] Related to JIRA ticket: ABC-123
  • [x] I have run this code to verify it works
  • [x] This PR includes unit tests for the code change

Description

This came from a cleanup I'd done post-checking in #883.

+21 -2

3 comments

3 changed files

JoshuaKGoldberg

pr closed time in 6 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha 58a97966233c52b37913f6ab17aa3e23f97a9ff1

Moved inside existing block

view details

push time in 6 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha 8fa6e902ac3562ceeddc164cdb56fb7e5d16282c

Added Markdown-test test

view details

push time in 6 days

PR opened Codecademy/client-modules

fix: MarkdownAnchor should still render children

Overview

PR Checklist

  • [ ] Related to Abstract designs:
  • [ ] Related to JIRA ticket: ABC-123
  • [x] I have run this code to verify it works
  • [x] This PR includes unit tests for the code change

Description

TIL not passing children to a component overrides a spread prop's children. This came from a cleanup I'd done post-checking in #883.

+13 -2

0 comment

2 changed files

pr created time in 6 days

create barnchCodecademy/client-modules

branch : jg-markdown-anchor-kids

created branch time in 6 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha 49a0630ab57a4f48c37674616d033bcf0a644929

More story content

view details

push time in 6 days

push eventJoshuaKGoldberg/SpeedyPersistentState

Josh Goldberg

commit sha af271deedfe0b711a89b651c99b0121e4a14e272

Mention watch link in README.md

view details

push time in 6 days

push eventJoshuaKGoldberg/SpeedyPersistentState

Josh Goldberg

commit sha 3f362dab1da097d5e62e421c9a1124ca7773e5f7

Informative README.md

view details

push time in 7 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha 17969294b797767a4f5cf96e67a680b542eea9e4

Remove unused act

view details

push time in 7 days

push eventCodecademy/client-modules

Natalie Wee

commit sha d29d92e90caee12ced405a31a8cf5373e6502903

fix(Alert): make alert tabbable for voiceover (#903) * make alert tabbable for voiceover * add aria-live="polite"

view details

codecademydev

commit sha 2c910abcc926e3a32aa8b93ebc94b36e4aa014ac

chore(release): publish - @codecademy/gamut-labs@1.8.4 - @codecademy/gamut@12.2.3 - @codecademy/styleguide@13.2.3

view details

codecademydev

commit sha c2bb19d49d52268be82154bfe9025cfc3bf139b7

chore: update changelogs

view details

Kip Price

commit sha edc7e767227a7aec90084f14e7e08916ccdf4f3f

add in equals sign to _responsive (#901)

view details

codecademydev

commit sha 9d6efbed83a1f1096a0555846ca13f3de2b7058c

chore(release): publish - @codecademy/gamut-labs@1.8.5 - @codecademy/gamut-styles@4.2.3 - @codecademy/gamut@12.2.4 - @codecademy/styleguide@13.2.4

view details

Josh Goldberg

commit sha 075b7c55908a2899c31ab20029aedb291743ca57

Merge branch 'main' into jg-accordion-controlled

view details

push time in 7 days

push eventCodecademy/client-modules

Josh Goldberg

commit sha 68b60943fc699c96650099416dd2bc26eacab588

AccordionArea

view details

push time in 7 days

startedrhysd/remark-emoji

started time in 7 days

startedw3c/resource-timing

started time in 7 days

startedsorbet/sorbet

started time in 7 days

issue closedhelen-dikareva/axe-testcafe

Out-of-date axe-core dependency

This includes axe-core@^2.2.3, but the latest is 3.2.0. Could it be updated, please?

Subset of #3

closed time in 8 days

JoshuaKGoldberg
more