profile
viewpoint

issue commentolifolkerd/tabulator

TypeScript typings

Thanks @angeliski for letting us know the solution!

andreivanea

comment created time in 10 days

pull request commentDefinitelyTyped/DefinitelyTyped

tabulator-tables: add export statement

@hados99 @minyoung You guys might try the solution here https://github.com/olifolkerd/tabulator/issues/86#issuecomment-491462834

Basically add tabulator-types to your types section and then require tabulator like so... const Tabulator = require('tabulator-tables');

This solved the issue in a vue project that was similar to yours.

"types": [ "webpack-env", "jest", "tabulator-tables" ],

hados99

comment created time in 10 days

issue commentolifolkerd/tabulator

TypeScript typings

@angeliski if you try to use the :Tabulator type inside your main.ts file it should work because that is a typescript file. I don't know how it works in .vue files.

andreivanea

comment created time in 10 days

issue commentolifolkerd/tabulator

TypeScript typings

Thanks @angeliski so what did you change to stop the error?

andreivanea

comment created time in 10 days

issue commentaspnet/EntityFramework6

Cannot Add-Migration after moving configuration to use Microsoft.Extensions.Configuration (appsettings.json)

Found out if I change the type to MOVIES.Data this now works. I'm not sure if this an issue with package manager console (I have MOVIES.Data selected as the default project when adding the migration), entity framework, configuration extensions, or my project setup. I would prefer to keep the AppSettingsJsonConfigurationBuilder code inside the MOVIES project. Any ideas?

 <configBuilders>
    <builders>
      <add name="AppSettingsJsonConfigurationBuilder" type="MOVIES.AppSettingsJsonConfigurationBuilder, MOVIES.Data" />
    </builders>
  </configBuilders>
Jojoshua

comment created time in 11 days

issue commentaspnet/EntityFramework6

Cannot Add-Migration after moving configuration to use Microsoft.Extensions.Configuration (appsettings.json)

The main difference is toggling the connection strings. Using xml works and the configBuilder does not.

<!--<connectionStrings configSource="WebConfig\connectionStrings.xml" />--> <connectionStrings configBuilders="AppSettingsJsonConfigurationBuilder"/>

Jojoshua

comment created time in 11 days

issue openedaspnet/EntityFramework6

Cannot Add-Migration after moving configuration to use Microsoft.Extensions.Configuration (appsettings.json)

Describe what is not working as expected.

If you are seeing an exception, include the full exceptions details (message and stack trace).

Exception message:
Stack trace:
System.TypeInitializationException: The type initializer for 'System.Data.Entity.Migrations.DbMigrationsConfiguration`1' threw an exception. ---> System.TypeInitializationException: The type initializer for 'System.Data.Entity.Internal.AppConfig' threw an exception. ---> System.Configuration.ConfigurationErrorsException: An error occurred loading a configuration file: Could not load file or assembly 'MOVIES' or one of its dependencies. The system cannot find the file specified. (C:\Users\UID\Downloads\movies\movies\MOVIES\tmpEB8.tmp line 72) ---> System.IO.FileNotFoundException: Could not load file or assembly 'MOVIES' or one of its dependencies. The system cannot find the file specified.
   at System.Configuration.TypeUtil.GetTypeImpl(String typeString, Boolean throwOnError)
   at System.Configuration.ConfigurationBuildersSection.InstantiateBuilder(ProviderSettings ps)
   at System.Configuration.ConfigurationBuildersSection.GetBuilderFromName(String builderName)
   at System.Configuration.BaseConfigurationRecord.GetConfigBuilderFromName(String builderName)
   at System.Configuration.BaseConfigurationRecord.GetSectionXmlReader(String[] keys, SectionInput input)
   --- End of inner exception stack trace ---
   at System.Configuration.BaseConfigurationRecord.EvaluateOne(String[] keys, SectionInput input, Boolean isTrusted, FactoryRecord factoryRecord, SectionRecord sectionRecord, Object parentResult)
   at System.Configuration.BaseConfigurationRecord.Evaluate(FactoryRecord factoryRecord, SectionRecord sectionRecord, Object parentResult, Boolean getLkg, Boolean getRuntimeObject, Object& result, Object& resultRuntimeObject)
   at System.Configuration.BaseConfigurationRecord.GetSectionRecursive(String configKey, Boolean getLkg, Boolean checkPermission, Boolean getRuntimeObject, Boolean requestIsHere, Object& result, Object& resultRuntimeObject)
   at System.Configuration.BaseConfigurationRecord.GetSectionRecursive(String configKey, Boolean getLkg, Boolean checkPermission, Boolean getRuntimeObject, Boolean requestIsHere, Object& result, Object& resultRuntimeObject)
   at System.Configuration.BaseConfigurationRecord.GetSectionRecursive(String configKey, Boolean getLkg, Boolean checkPermission, Boolean getRuntimeObject, Boolean requestIsHere, Object& result, Object& resultRuntimeObject)
   at System.Configuration.BaseConfigurationRecord.GetSection(String configKey)
   at System.Configuration.ClientConfigurationSystem.System.Configuration.Internal.IInternalConfigSystem.GetSection(String sectionName)
   at System.Configuration.ConfigurationManager.GetSection(String sectionName)
   at System.Configuration.ConfigurationManager.get_ConnectionStrings()
   at System.Data.Entity.Internal.AppConfig..ctor()
   at System.Data.Entity.Internal.AppConfig..cctor()
   --- End of inner exception stack trace ---
   at System.Data.Entity.Infrastructure.DependencyResolution.DbConfigurationManager.EnsureLoadedForAssembly(Assembly assemblyHint, Type contextTypeHint)
   at System.Data.Entity.Infrastructure.DependencyResolution.DbConfigurationManager.EnsureLoadedForContext(Type contextType)
   at System.Data.Entity.Migrations.DbMigrationsConfiguration`1..cctor()
   --- End of inner exception stack trace ---
   at System.Data.Entity.Migrations.DbMigrationsConfiguration`1..ctor()
   at MOVIES.Data.Migrations.Configuration..ctor() in C:\Users\UID\Downloads\movies\movies\MOVIES.Data\Migrations\Configuration.cs:line 12
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Data.Entity.Migrations.Utilities.MigrationsConfigurationFinder.FindMigrationsConfiguration(Type contextType, String configurationTypeName, Func`2 noType, Func`3 multipleTypes, Func`3 noTypeWithName, Func`3 multipleTypesWithName)
   at System.Data.Entity.Migrations.Design.ToolingFacade.BaseRunner.FindConfiguration()
   at System.Data.Entity.Migrations.Design.ToolingFacade.ScaffoldRunner.RunCore()
   at System.Data.Entity.Migrations.Design.ToolingFacade.BaseRunner.Run()
The type initializer for 'System.Data.Entity.Migrations.DbMigrationsConfiguration`1' threw an exception.

Steps to reproduce

I have an ASP.NET MVC 5 application and was using the standard appsettings in the web.config. However, I just moved my configuration to use Microsoft.Extensions.Configuration and followed this article to do so. My code is similar. https://dasmulli.blog/2018/01/21/use-appsettings-json-and-environment-overrides-in-classic-asp-net-apps/

This works as expected in my application ...until I tried to do an Add-Migration. Above is the error. I have my main ASP.NET in project called MOVIES and a MOVIES.Data project as my DAL and is where my migrations sit.

The relevant items in web.config are below. As soon as I revert back to using the xml settings, I don't get the error.

<configuration>
	<configSections>
		<section name="entityFramework" type="System.Data.Entity.Internal.ConfigFile.EntityFrameworkSection, EntityFramework, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" requirePermission="false" />		
    <section name="configBuilders" type="System.Configuration.ConfigurationBuildersSection, System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" restartOnExternalChanges="false" requirePermission="false" />
  <configBuilders>
    <builders>
      <add name="AppSettingsJsonConfigurationBuilder" type="PWM.AppSettingsJsonConfigurationBuilder, PWM" />
    </builders>
  </configBuilders>
  
	<!--<appSettings configSource="WebConfig\appSettings.xml" />-->
  <appSettings configBuilders="AppSettingsJsonConfigurationBuilder" />

  <connectionStrings configBuilders="AppSettingsJsonConfigurationBuilder">
    <clear/>
  </connectionStrings>

Further technical details

EF version: 6.2.0 Database Provider: EntityFramework.SqlServer Operating system: Windows 10 IDE: Visual Studio 2017 15.8.8

created time in 11 days

issue commentolifolkerd/tabulator

TypeScript typings

@angeliski I'm glad you figured it out. I am curious about the explanation but the link you provided didn't take me to a specific explanation. Can you try again?

andreivanea

comment created time in 12 days

issue commentolifolkerd/tabulator

TypeScript typings

"typeRoots": ["node_modules/@types"]

andreivanea

comment created time in 12 days

issue commentolifolkerd/tabulator

TypeScript typings

@angeliski i can't look now but check out my repo. It doesn't look like you have @types setup in your tsconfig

andreivanea

comment created time in 12 days

issue commentolifolkerd/tabulator

TypeScript typings

@angeliski I don't have experience with vue. Why are you explicitly declaring it as a module? Have you tried removing that module declaration altogether?

andreivanea

comment created time in 12 days

push eventJojoshua/TypedTabulator

Jojoshua

commit sha f6844197058762bfe26010452cf9e5c317480830

Init

view details

push time in 12 days

issue commentolifolkerd/tabulator

TypeScript typings

Hey @Jojoshua

Sorry for the delay in getting back to you on this one, Ive had a crazy busy couple of months.

Im preparing the 4.3 release so would love to put togeather some docs on how to use the typings.

Would you be able to put togeather a few paragraphs i could use on a TypeScript Typings doc page?

Cheers

Oli :)

Hey @olifolkerd , for TypeScript users they should download the definition from @types/tabulator-tables and that's pretty much it.

I have created a sample repository for reference here https://github.com/Jojoshua/TypedTabulator . You should be able to test the bounds of the definitions using this sample project.

andreivanea

comment created time in 12 days

issue commentolifolkerd/tabulator

TypeScript typings

Hey @angeliski what was the issue you were having?

andreivanea

comment created time in 12 days

push eventJojoshua/TypedTabulator

Jojoshua

commit sha 7ea120d1d25ce412f1b70161be2448822c21b22e

Init

view details

Jojoshua

commit sha 364479502c70c3d3e5a4c886cdee5be971169cc2

Merge branch 'master' of https://github.com/Jojoshua/TypedTabulator

view details

push time in 12 days

create barnchJojoshua/TypedTabulator

branch : master

created branch time in 12 days

created repositoryJojoshua/TypedTabulator

created time in 12 days

issue commenttinymce/tinymce

Build Customizer Out of Date (using 4.9.2 instead of 5.0.0)

I noticed the build customizer was titled for v4. Any idea when this will be compatible for v5?

Jojoshua

comment created time in 13 days

startedopenaudible/openaudible

started time in 22 days

startedknyzorg/pluralsight-scraper

started time in a month

pull request commentDefinitelyTyped/DefinitelyTyped

tabulator-tables: add export statement

I can't see adding this because it breaks existing users. The issue you are having isn't well defined. Maybe someone from the TS team can help.

hados99

comment created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

[FIX] Updated some type declaration for tabulator-tables

 declare class Tabulator {     browserSlow: boolean;     modules: any;     options: Tabulator.Options;+    element: any;

I gotcha now. I'm good with it.

simusr2

comment created time in a month

pull request commentDefinitelyTyped/DefinitelyTyped

tabulator-tables: add export statement

Are you trying to create a new instance of Tabulator? Try to use it like the tests do. I looked at one of the index.d.ts definitions you were using from jest and it doesn't have an export default in it either.

hados99

comment created time in a month

pull request commentDefinitelyTyped/DefinitelyTyped

tabulator-tables: add export statement

What does your tsconfig look like? You should have it recognize @types using "typeRoots": ["node_modules/@types"],

hados99

comment created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

[FIX] Updated some type declaration for tabulator-tables

 declare namespace Tabulator {         /**  Setting this option to true will cause Tabulator to create a list of page size options, that are multiples of the current page size. In the example below, the list will have the values of 5, 10, 15 and 20.      When using the page size selector like this, if you use the setPageSize function to set the page size to a value not in the list, the list will be regenerated using the new page size as the starting valuer	*/-        paginationSizeSelector?: true | number[];+        paginationSizeSelector?: true | false | number[];

The docs don't say anything about setting this to false. It is default false and redundant to set.

http://tabulator.info/docs/4.2/release#page

simusr2

comment created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

[FIX] Updated some type declaration for tabulator-tables

 colDef.formatterParams = {     huge: true }; // Custom Formatter-colDef.formatter = (cell: Tabulator.CellComponent, formatterParams: {}, onRendered) => {+colDef.formatter = (cell: Tabulator.CellComponent, formatterParams: {}, onRendered: Tabulator.EmptyCallback) => {

Typescript already infers this as Tabulator.EmptyCallback.

simusr2

comment created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

[FIX] Updated some type declaration for tabulator-tables

 You can pass an optional additional property with sorter, sorterParams that shou     type CustomAccessorParams = {} | ((value: any, data: any, type: "data" | "download" | "clipboard", column?: ColumnComponent) => any);     type ColumnCalc = "avg" | "max" | "min" | "sum" | "concat" | "count" | ((values: any[], data: any[], calcParams: {}) => number);     type ColumnCalcParams = (values: any, data: any) => any;-    type Formatter = "plaintext" | "textarea" | "html" | "money" | "image" | "datetime" | "datetimediff" | "link" | "tickCross" | "color" | "star" | "traffic" | "progress" | "lookup" | "buttonTick" | "buttonCross" | "rownum" | "handle" | ((cell: CellComponent, formatterParams: {}, onRendered: EmptyCallback) => string | HTMLElement);+    type Formatter = ((cell: CellComponent, formatterParams: {}, onRendered: EmptyCallback) => string) | string | "plaintext" | "textarea" | "html" | "money" | "image" | "datetime" | "datetimediff" | "link" | "tickCross" | "color" | "star" | "traffic" | "progress" | "lookup" | "buttonTick" | "buttonCross" | "rownum" | "handle" | ((cell: CellComponent, formatterParams: {}, onRendered: EmptyCallback) => string | HTMLElement);

The custom formatter at the end handles the one you copied on the front. The custom formatter should return either a string or html element per the docs.

http://tabulator.info/docs/4.2/format#format-builtin

Also, I don't see where you can add a plain string as a Formatter option. This negates the type benefits as well. I would undo this one too.

simusr2

comment created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

[FIX] Updated some type declaration for tabulator-tables

 declare class Tabulator {     browserSlow: boolean;     modules: any;     options: Tabulator.Options;+    element: any;

element is not part of the Tabulator class. It is a parameter that can be passed in but not saved to this

var Tabulator = function(element, options){

simusr2

comment created time in a month

Pull request review commentDefinitelyTyped/DefinitelyTyped

[FIX] Updated some type declaration for tabulator-tables

 declare namespace Tabulator {     interface ColumnDefinition extends ColumnLayout, CellCallbacks {         // Layout         /** sets the text alignment for this column */-        align?: "left" | "center" | "right"; // Align?+        align?: "left" | "center" | "right" | string; // Align?

Documentation only states left,center,right. http://tabulator.info/docs/4.2/columns#definition

simusr2

comment created time in a month

issue commentolifolkerd/tabulator

Feature Request - Automatically add new Row after tabbing on the last cell

Hey @olifolkerd , what do you think of this kind of feature?

Jojoshua

comment created time in 2 months

issue closedszimek/signature_pad

Attach signature_pad to existing canvas

I was not able to post this on StackOverflow because the signature-pad tag requires 1500 reputation.

I need to dynamically create/save/load canvas data that was created with signature_pad. How can I attach signature_pad to an existing canvas without having to keep them all in global scope? The following code wipes out the data in the existing canvas.

let canvas = document.getElementById("existingCanvas");
let signaturePad = new SignaturePad(canvas);

closed time in 2 months

Jojoshua

issue commentTypeStrong/ts-loader

Regarding new "incremental" flag from TS 3.4

I was just about to open this issue. I also tried specifying compilerOptions: { incremental: true } but no dice.

goenning

comment created time in 2 months

issue openedolifolkerd/tabulator

Select & AutoComplete do not show dropdown options inside a modal

The Select and AutoComplete editors do not show the dropdown options if Tabulator is put inside a bootstrap modal.

A complete JSFiddle to show the issue can be found here. Click the Launch modal button. https://jsfiddle.net/jojoshua/y73egjwo/

Tabulator Info

  • 4.2

  • Browser: Tested with Chrome,Firefox, Edge with same results.

Additional context Looks like the options are being appended to the document and likely underneath the modal.

created time in 2 months

issue commentRealytics/fork-ts-checker-webpack-plugin

types.ts files do not trigger rebuild in webpack-dev-server

Thanks, I'll test it out. I'm thinking that https://github.com/Microsoft/TypeScript/pull/29813 will pan out better than thread loader.

abirmingham

comment created time in 2 months

issue commentRealytics/fork-ts-checker-webpack-plugin

types.ts files do not trigger rebuild in webpack-dev-server

@johnnyreilly What part of my config looks off? I'm using the latest versions which should contain any fixes.

  "devDependencies": {   
    "assets-webpack-plugin": "3.9.10",
    "babel-loader": "8.0.5",
    "cache-loader": "2.0.1",
    "clean-webpack-plugin": "2.0.1",
    "copy-webpack-plugin": "5.0.1",
    "cross-env": "^5.2.0",
    "css-loader": "2.1.1",
    "dart-sass": "1.17.3",
    "expose-loader": "0.7.5",
    "file-loader": "3.0.1",
    "fork-ts-checker-webpack-plugin": "1.0.0",  
    "hard-source-webpack-plugin": "^0.13.1",
    "imports-loader": "0.8.0",
    "mini-css-extract-plugin": "0.5.0",
    "sass-loader": "7.1.0",
    "source-map-loader": "0.2.4",
    "style-loader": "0.23.1",
    "thread-loader": "2.1.2",
    "ts-loader": "5.3.3",
    "tsconfig-paths-webpack-plugin": "3.2.0",
    "tslint": "5.11.0",
    "typescript": "3.4.0-rc",
    "webpack": "4.29.6",
    "webpack-bundle-analyzer": "3.1.0",
    "webpack-cli": "3.3.0",
    "webpack-dev-server": "3.2.1",
    "webpack-merge": "4.2.1",
    "acorn": "6.1.1"
  },

I forgot to mention that I once I replaced that if statement to include all TS files(which started making everything working) and then went back to my old if statement (which excluded non -main.ts files) then everything was STILL working. It's almost as if there was something in cache or alike that got reset. I am still able to edit these helper files and watch is still compiling upon save.

abirmingham

comment created time in 2 months

issue commentRealytics/fork-ts-checker-webpack-plugin

types.ts files do not trigger rebuild in webpack-dev-server

@johnnyreilly Actually I've noticed this behavior on normal .ts files that were not just interfaces. This happens to me on typescript files I use as helper utilities which contain classes and other code which I specifically exclude from being transpiled to javascript. I use webpack split chunks to merge all my helper files into a single file I include manually. Because these excluded files were not "registered" with webpack specifically, they are not being detected as being watched.

To make this more clear. Here is a sample of my webpack config. I am wanting to include TypeScript files that end with "-main.ts". My TypeScript util files will not have the "-main" on them. If I replace the if statement to include all TS files (ignoring .d.ts) then this all works as expected.

Also you can see my TS rules below.


function getFilesFromDir(dir, fileTypes) {
  //var filesToReturn = [];
  function walkDir(currentPath) {
    var files = fs.readdirSync(currentPath);
    for (var i in files) {
      var currFile = path.join(currentPath, files[i]);
	 //----> REPLACE STATEMENT BELOW TO FIX -----if (fs.statSync(currFile).isFile() && currFile.indexOf(".ts") >= 0 && currFile.indexOf(".d.ts") < 0)
      if (fs.statSync(currFile).isFile() && currFile.indexOf("-main.ts") >= 0) {
        var entryName = path.basename(currFile).replace(".ts", "");
        tsEntries[entryName] = path.resolve(currFile);
      } else if (fs.statSync(currFile).isDirectory()) {
        walkDir(currFile);
      }
    }
  }
  walkDir(dir);
}
//Get all files that end in -main.ts noting that they are the main entry points
getFilesFromDir("./src/", [".ts"]);


module.exports = {
  entry: tsEntries,



// Rules...
 module: {
    rules: [
      {
        test: /\.tsx?$/,
        include: path.resolve(__dirname, "src"),
        use: [
          {
            loader: "babel-loader",
            options: babelOptions
          },
          {
            loader: "thread-loader",
            options: {
              // there should be 1 cpu for the fork-ts-checker-webpack-plugin
              workers: require("os").cpus().length - 1
            }
          },
          {
            loader: "ts-loader",
            options: {
              happyPackMode: true,
              transpileOnly: true,
              experimentalWatchApi: true,
            }
          }
        ]
      },

//Plugins
 plugins: [
    new ForkTsCheckerWebpackPlugin({
      checkSyntacticErrors: true,
    })

abirmingham

comment created time in 2 months

issue commentwebpack/webpack

Parsing of `import()` fails in 4.29.0 (Compilation issue, related to dynamic import)

Had this issue as well. @KevinKelchen -- Your solution worked for me too.

Dbuggerx

comment created time in 2 months

issue closedMicrosoft/TypeScript

Feature Request --noAnyProperties

What I would like is a compiler option that throws an error if an object (even if typed as any) tries to access a property. This would allow overriding 3rd party declarations that use the any type to force a more specific type.

$.ajax({ type: "POST",
success: function(response:any) {
let columns: response.columns <==compiler error },
});

closed time in 2 months

Jojoshua

issue commentMicrosoft/TypeScript

Feature Request --noAnyProperties

Thanks @kitsonk , that is what I need.

Jojoshua

comment created time in 2 months

issue commentMicrosoft/TypeScript

Feature Request --noAnyProperties

I want the any type to be possible but I don't want to allow accessing properties from an "any" type. I believe those lint rules deny the any type all together.

Jojoshua

comment created time in 2 months

issue openedMicrosoft/TypeScript

Feature Request --noAnyProperties

What I would like is a compiler option that throws an error if an object (even if typed as any) tries to access a property. This would allow overriding 3rd party declarations that use the any type to force a more specific type.

$.ajax({ type: "POST",
success: function(response:any) {
let columns: response.columns <==compiler error },
});

created time in 2 months

PR opened DefinitelyTyped/DefinitelyTyped

Tabulator tables 4.2 fixes

Please fill in this template.

  • [ X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ X] Test the change in your own code. (Compile and run.)
  • [ X] Add or edit tests to reflect the change. (Run with npm test.)
  • [ X] Follow the advice from the readme.
  • [X ] Avoid common mistakes.
  • [ X] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [X ] Provide a URL to documentation or source code which provides context for the suggested changes: tabulator.info
  • [ X] Increase the version number in the header if appropriate.
  • [ X] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.
+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchJojoshua/DefinitelyTyped

branch : tabulator-tables-4.2-fixes

created branch time in 2 months

issue closedolifolkerd/tabulator

Text Area buggy with table height 100%

Describe the bug The text area editor looses focus when start typing in the editor. Multi line is not working either. This only happens with height:100%

Tabulator Info

  • 4.2

    var tableConfig = { data: [ { id: 1, name: "Oli Bob", location: "United Kingdom", gender: "male", rating: 1, col: "red" }, { id: 2, name: "Mary May", location: "Germany", gender: "female", rating: 2, col: "blue" }, { id: 3, name: "Christine Lobowski", location: "France", gender: "female", rating: 0, col: "green" } ], height: "100%", columns: [{ title: "Name", field: "name", editor: "textarea" }] };

var table = new Tabulator(#table, tableConfig);

Expected behavior I would expect the editor to allow me to keep typing until done.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Win7/10
  • Browser Chrome
  • Version 72

closed time in 2 months

Jojoshua

issue commentolifolkerd/tabulator

Text Area buggy with table height 100%

After adding the formatter: "textarea" as well, this works full height. I thought that because the editor was textarea that also meant it should be shown as a text area.

Jojoshua

comment created time in 2 months

issue openedolifolkerd/tabulator

Text Area buggy with table height 100%

Describe the bug The text area editor looses focus when start typing in the editor. Multi line is not working either. This only happens with height:100%

Tabulator Info

  • 4.2

    var tableConfig = { data: [ { id: 1, name: "Oli Bob", location: "United Kingdom", gender: "male", rating: 1, col: "red" }, { id: 2, name: "Mary May", location: "Germany", gender: "female", rating: 2, col: "blue" }, { id: 3, name: "Christine Lobowski", location: "France", gender: "female", rating: 0, col: "green" } ], height: "100%", columns: [{ title: "Name", field: "name", editor: "textarea" }] };

var table = new Tabulator(#table, tableConfig);

Expected behavior I would expect the editor to allow me to keep typing until done.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Win7/10
  • Browser Chrome
  • Version 72

created time in 2 months

PR opened DefinitelyTyped/DefinitelyTyped

Tabulator-tables 4.2 updates.

Please fill in this template.

  • [ X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X ] Test the change in your own code. (Compile and run.)
  • [ X] Add or edit tests to reflect the change. (Run with npm test.)
  • [X ] Follow the advice from the readme.
  • [ X] Avoid common mistakes.
  • [ X] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: tabulator.info
  • [X ] Increase the version number in the header if appropriate.
  • [ X] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.
+3 -3

0 comment

2 changed files

pr created time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha d055c7714d56c2b1a5a8cc5e47fb9b2335bed1dd

Fix field required. Replace tick with tickCross

view details

push time in 2 months

fork Jojoshua/DefinitelyTyped

The repository for high quality TypeScript type definitions.

http://definitelytyped.org/

fork in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 17755764c5c742a6f948651b64af5e206c705396

Fix optional types

view details

Jojoshua

commit sha 9c78ab61be97af5b8aa33600dffd2435b2f290db

Fix optionals

view details

Jojoshua

commit sha 23922bafd54d6570e585d7e576073e522eabddca

Fix optionals

view details

Jojoshua

commit sha a1ab7c383f0e21c6532eaac61136f57dce113e09

Merge branch 'master' of https://github.com/Jojoshua/DefinitelyTyped

view details

Jojoshua

commit sha 2c9589b6258c165a6b5a1bc90ebcdc6219b2dac9

Fix required type, add editor type

view details

Jojoshua

commit sha a38335f5c30914800deb39cfa608abf8e4f97272

Fix required type, add editor type

view details

Jojoshua

commit sha 4e3d41e4282bcb10aa9624dc74ea1be81f9515b7

Merge branch 'master' of https://github.com/Jojoshua/DefinitelyTyped

view details

Jojoshua

commit sha c482a5f926dfcc354018950b3eb7357adc6fd7f7

Add tickCross editor. Fix field required

view details

Jojoshua

commit sha bd8a7b5c66c4d24fe341c30c6229496ad18de8b2

Merge branch 'master' of https://github.com/Jojoshua/DefinitelyTyped

view details

push time in 2 months

fork Jojoshua/DefinitelyTyped

The repository for high quality TypeScript type definitions.

http://definitelytyped.org/

fork in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha a38335f5c30914800deb39cfa608abf8e4f97272

Fix required type, add editor type

view details

Jojoshua

commit sha 4e3d41e4282bcb10aa9624dc74ea1be81f9515b7

Merge branch 'master' of https://github.com/Jojoshua/DefinitelyTyped

view details

push time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 2c9589b6258c165a6b5a1bc90ebcdc6219b2dac9

Fix required type, add editor type

view details

push time in 2 months

PR opened DefinitelyTyped/DefinitelyTyped

Tabulator-tables - Minor fixes to optional types

Please fill in this template.

  • [X ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ X] Test the change in your own code. (Compile and run.)
  • [X ] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [ X] Avoid common mistakes.
  • [ X] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [ X] Provide a URL to documentation or source code which provides context for the suggested changes: http://tabulator.info/ - These are fixes to my initial definition after more testing.

  • [ ] Increase the version number in the header if appropriate. This is still valid for the current version.

  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

+8 -8

0 comment

1 changed file

pr created time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 23922bafd54d6570e585d7e576073e522eabddca

Fix optionals

view details

Jojoshua

commit sha a1ab7c383f0e21c6532eaac61136f57dce113e09

Merge branch 'master' of https://github.com/Jojoshua/DefinitelyTyped

view details

push time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 9c78ab61be97af5b8aa33600dffd2435b2f290db

Fix optionals

view details

push time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 17755764c5c742a6f948651b64af5e206c705396

Fix optional types

view details

push time in 2 months

issue commentolifolkerd/tabulator

Feature Request/Question - Built in UI Configurator

Agreed @olifolkerd. My particular use case is quite specific and this kind of UI would never please everyone due to all the options and advanced scenarios like custom callbacks. I was hoping to start small and only use some of the most basic functionality akin to what an Excel user would be comfortable with.

I'll see what I can come up with. I don't know what this will end up looking like yet but I will try to make it generic and not too specific to my use. If I can I'll be happy to share.

Thanks for the support!

Jojoshua

comment created time in 2 months

issue commentolifolkerd/tabulator

Feature Request/Question - Built in UI Configurator

Thanks for the info @olifolkerd

I actually was thinking this would be a new code base. It would be a layer on top of the tabulator API, a "Puppeteer" of sorts so it could be reused in different parts of anapplication. It would also create/load this JSON output in order to make revisions to the table definition. It might look like..

let tabulatorUI = new TabulatorUI(targetElement) //Generate all the controls necessary to instantiate a Tabulator onto a div

tabulatorUI.save(); //JSON config tabulatorUI.load(config);//load config to recreate entire table.

I know how difficult it would be considering all the options. Maybe with the typescript definitions it would be possible to auto-generate the UI controls for all of the options, or at least the ones that make sense for a UI.

Jojoshua

comment created time in 2 months

issue openedolifolkerd/tabulator

Feature Request/Question - Built in UI Configurator

Describe the solution you'd like An optional user interface geared towards developers or power users(with instructions) to generate a Tabulator table instance. It would configure basic table options and the ability to add columns with a basic definition. For example you could add a column specifying the name, type of editor along with some editor options, and validators.

Then the entire table definition could be saved as JSON to a database and regenerated for a different set of users to actually fill out the table.

Describe alternatives you've considered Not sure if this request would be the scope of Tabulator itself or a separate project should be created. This would be something I would need to create myself anyway.

Additional context See rough drawing attachment. 20190309_133126

created time in 2 months

issue openedolifolkerd/tabulator

Feature Request - Automatically add new Row after tabbing on the last cell

In some cases I would want to present an empty table(or table with 1 empty row) which the user will fill out. Instead of creating an explicit button to add a new row, I would like to have an option which automatically adds a new empty row when the user presses the Tab key (only when they are in the last row & cell). This is a type of function that is standard behavior in Excel-like tables.

Describe alternatives you've considered Possibly extending the keybindings module.

created time in 2 months

issue commentolifolkerd/tabulator

TypeScript typings

@olifolkerd I didn't see your last question. You can mention that there is typescript support but it's not necessarily to explain how to use it. You can add a badge if you want http://definitelytyped.org/pages/badges.html

Anyone doing typescript knows to just pull the definitions. Check the test file I made along side the definition file. I basically took your code from the website to validate it works. I didn't test everything (there is so much content) so there may be some issues to work out and adjust definitions.

You should try a little typescript and test it out, I think you would like it.

andreivanea

comment created time in 2 months

issue commentolifolkerd/tabulator

TypeScript typings

Yep. Speaking of which it just got merged and published. Here it is to test out. https://www.npmjs.com/package/@types/tabulator-tables

andreivanea

comment created time in 2 months

issue commentolifolkerd/tabulator

Feature Request - Slider Toggle

Great. If possible it would be nice to have text/color association and a formatter for read only mode. Not sure how a tri-state would work with it... Maybe it could be as simple as text on the left and a pill-like shape to the right of the text which upon click cycles through an array of pre-determined text/color array.

Jojoshua

comment created time in 2 months

issue commentolifolkerd/tabulator

TypeScript typings

@olifolkerd I've taken the guidance from the typescript docs here https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

Basically it is the defacto central location that all typescript users can go to find typings; there are thousands of libraries there. If the project itself was written in typescript it can ship the index.d.ts and there is a way in the tsconfig to automatically pick it up that way.

It is typical that the APIs for libraries change and the method that they have at DefinitelyTyped handles that well. Basically you can create a pull request for the definition file I made and push an update to it yourself. Anyone listed in the headers section (http://definitelytyped.org/guides/contributing.html) will be notified and can also review the update. There can be multiple authors noted in the header with version as well.

I also think if you add yourself as an author that their system will recognize your github user as the Author is the Owner of the package and will be merged faster. Check out some more of the details http://definitelytyped.org/ and https://github.com/DefinitelyTyped/DefinitelyTyped

andreivanea

comment created time in 2 months

issue openedolifolkerd/tabulator

Feature Request - Slider Toggle

Create an editor that can take boolean or tri-state values similar to the tick. Something like https://github.com/kevinchappell/kcToggle

created time in 2 months

issue commentolifolkerd/tabulator

TypeScript typings

@olifolkerd I've completed the first revision of the declarations! These need to be on DefinitelyTyped since Tabulator is not built in Typescript. Please review the index.d.ts file from my pending PR https://github.com/DefinitelyTyped/DefinitelyTyped/pull/33652. I think you will find the way I typed this maps pretty well to the overall design/architecture of the working software but having your review would be great to validate things I missed.

@andreivanea @angeliski or anyone else using this library with Typescript -- it would be great if you could test your code against these definitions for further validation.

This was pretty intensive to create and required me to dig though lots of the code/docs. I have compiled notes as I was going through. Some relate directly to types, some relate to documentation on the website. The website docs were very helpful in this process.

--Docs http://tabulator.info/docs/4.2/edit#edit-builtin -autocomplete editor params freetext should probably be cased as freeText

http://tabulator.info/docs/4.2/options -resizableColumns Explore link is broken. -ajaxLoader,ajaxLoaderLoading,ajaxLoaderError could use an Explore button for details The following are missing as available options: autoResize columnHeaderSortMulti clipboardCopyStyled clipboardCopyConfig clipboardCopied clipboardPasted dataTreeRowExpanded dataTreeRowCollapsed selectableRangeMode movableRowsSendingStart movableRowsSentFailed movableRowsSendingStop movableRowsReceivingStart movableRowsReceived movableRowsReceivedFailed movableRowsReceivingStop tableBuilding tableBuilt renderStarted renderComplete rowClick rowDblClick rowContext rowTap rowDblTap rowTapHold rowMouseEnter rowMouseLeave rowMouseOver rowMouseOut rowMouseMove rowAdded rowDeleted rowMoved rowUpdated rowSelectionChanged rowSelected rowDeselected rowResized cellClick cellDblClick cellContext cellTap cellDblTap cellTapHold cellMouseEnter cellMouseLeave cellMouseOver cellMouseOut cellMouseMove cellEditing cellEdited cellEditCancelled columnMoved columnResized columnTitleChanged columnVisibilityChanged htmlImporting htmlImported dataLoading dataLoaded dataEdited ajaxRequesting ajaxResponse ajaxError dataFiltering dataFiltered dataSorting dataSorted dataGrouping dataGrouped groupVisibilityChanged groupClick groupDblClick groupContext groupTap groupDblTap groupTapHold pageLoaded localized validationFailed

http://tabulator.info/docs/4.2/page#manage -previousPage copy/paste error in description

http://tabulator.info/docs/4.2/localize#setup

  • update getLang to account for locale parameter

http://tabulator.info/docs/4.2/columns#visibility -showColumn,hideColumn,toggleColumn docs need to mention that it can take a column loookup rather than just the field name

http://tabulator.info/docs/4.2/columns#get-definition -getColumn should mention it can take a column lookup

http://tabulator.info/docs/4.2/tree#layout-colexp -Can dataTreeElementColumn,dataTreeCollapseElement be boolean? I saw these defaulted to false in the default options

--Missing Documentation toggleSelectRow setMaxPage getGroupedData columnHeaderSortMulti

--Source Code

  • Tabulator.prototype.getGroups - values parameter is not used
  • Tabulator.prototype.getGroupedData - should that function not accept an active param to pass to getData?

-It appears you are already doing the work required to get the full column definition when calling getColumnLayout. If you really wanted to persist column definition to the database you would need the full definition. Consider returning full ColumnDefinition instead of a subset of ColumnDefinition. There is a getColumnDefinition but not a setColumnDefinition. This seems like it could be improved.

-The set of methods updateOrAddRow,updateRow, etc are similar to updateOrAddData,updateData, etc. The only difference seems whether updating a single row objects or multiple. Why not consolidate this into a single method or rename the data type functions to "rows". i.e updateOrAddRows. Furthermore,the use of the word "data" is most associated with ajax type methods.

andreivanea

comment created time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 46d861bb9865a1a17ccc1104a3f95fe72f1c8630

Fix linting

view details

push time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha c79ee7b65f500c19ec2bf6e5dccfa9111efe434f

Update project url

view details

push time in 2 months

PR opened DefinitelyTyped/DefinitelyTyped

Initial definitions for tabulator-tables
  • [X ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X ] Test the change in your own code. (Compile and run.)
  • [ X] Add or edit tests to reflect the change. (Run with npm test.)
  • [ X] Follow the advice from the readme.
  • [X ] Avoid common mistakes.
  • [ X] Run npm run lint package-name (or tsc if no tslint.json is present).

If adding a new definition:

  • [ X] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [X ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ X] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ X] tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+2173 -0

0 comment

4 changed files

pr created time in 2 months

push eventJojoshua/DefinitelyTyped

Jojoshua

commit sha 5c9faedd41649bed7ab58670b8dda60f552947c1

Initial

view details

push time in 2 months

fork Jojoshua/DefinitelyTyped

The repository for high quality TypeScript type definitions.

http://definitelytyped.org/

fork in 2 months

issue commentolifolkerd/tabulator

TypeScript typings

@olifolkerd can you reopen this issue. I've been working on this.

andreivanea

comment created time in 2 months

issue commentMicrosoft/TypeScript

Type inference not producing error

@RyanCavanaugh How did the mouse hover in VSCode get it right? It knew which interface to pull details for.

Jojoshua

comment created time in 2 months

issue openedMicrosoft/TypeScript

Type inference

<!-- Please try to reproduce the issue with typescript@next. It may have already been fixed. --> TypeScript Version: 3.3.3

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> type inference optional properties

Code interface User{ editorParams?: SelectParams | AutoCompleteParams; }

let user: User;

let autoComplete1: AutoCompleteParams = { searchFunc: (term, values) => { //search for exact matches var matches: string[] = []; //return matches; }, listItemFormatter: function(value, title) { //prefix all titles with the work "Mr" return "Mr " + title; }, }; user.editorParams = autoComplete1;

user.editorParams = { searchFunc: (term,values) => { //search for exact matches var matches: string[] = []; //return matches; }, listItemFormatter: function(value, title) { //prefix all titles with the work "Mr" return "Mr " + title; }, };

interface SelectParams { listItemFormatter?: (value: string, text: string) => string; }

interface AutoCompleteParams { listItemFormatter?: (value: string, text: string) => string; searchFunc: (term: string, values: string[]) => string[]; }

Expected behavior: I expected when commenting out the return statement in the inferred usage of searchFunc that a compiler error would occur. The annotated method above does give the compiler error. The playground link shows this as well.

Actual behavior: No compiler error for the inferred usage. Hovering the inferred searchFunc in VSCode shows it as AutoCompleteParams as well.

Playground Link: https://www.typescriptlang.org/play/#src=interface%20User%7B%0D%0A%20%20%20%20editorParams%3F%3A%20SelectParams%20%7C%20AutoCompleteParams%3B%0D%0A%7D%0D%0A%0D%0Alet%20user%3A%20User%3B%0D%0A%0D%0Alet%20autoComplete1%3A%20AutoCompleteParams%20%3D%20%7B%0D%0A%20%20%20%20searchFunc%3A%20(term%2C%20values)%20%3D%3E%20%7B%0D%0A%20%20%20%20%20%20%2F%2Fsearch%20for%20exact%20matches%0D%0A%20%20%20%20%20%20var%20matches%3A%20string%5B%5D%20%3D%20%5B%5D%3B%0D%0A%20%20%20%20%20%20%2F%2Freturn%20matches%3B%0D%0A%20%20%20%20%7D%2C%0D%0A%20%20%20%20listItemFormatter%3A%20function(value%2C%20title)%20%7B%0D%0A%20%20%20%20%20%20%2F%2Fprefix%20all%20titles%20with%20the%20work%20%22Mr%22%0D%0A%20%20%20%20%20%20return%20%22Mr%20%22%20%2B%20title%3B%0D%0A%20%20%20%20%7D%2C%0D%0A%20%20%7D%3B%0D%0A%20%20user.editorParams%20%3D%20autoComplete1%3B%0D%0A%20%20%0D%0A%20%20user.editorParams%20%3D%20%7B%0D%0A%20%20%20%20searchFunc%3A%20(term%2Cvalues)%20%3D%3E%20%7B%0D%0A%20%20%20%20%20%20%2F%2Fsearch%20for%20exact%20matches%0D%0A%20%20%20%20%20%20var%20matches%3A%20string%5B%5D%20%3D%20%5B%5D%3B%0D%0A%20%20%20%20%20%20%2F%2Freturn%20matches%3B%0D%0A%20%20%20%20%7D%2C%0D%0A%20%20%20%20listItemFormatter%3A%20function(value%2C%20title)%20%7B%0D%0A%20%20%20%20%20%20%2F%2Fprefix%20all%20titles%20with%20the%20work%20%22Mr%22%0D%0A%20%20%20%20%20%20return%20%22Mr%20%22%20%2B%20title%3B%0D%0A%20%20%20%20%7D%2C%0D%0A%20%20%7D%3B%0D%0A%0D%0A%20%20interface%20SelectParams%20%7B%0D%0A%20%20%20%20listItemFormatter%3F%3A%20(value%3A%20string%2C%20text%3A%20string)%20%3D%3E%20string%3B%0D%0A%20%20%7D%0D%0A%0D%0A%20%20interface%20AutoCompleteParams%20%7B%0D%0A%20%20%20%20listItemFormatter%3F%3A%20(value%3A%20string%2C%20text%3A%20string)%20%3D%3E%20string%3B%0D%0A%20%20%20%20searchFunc%3A%20(term%3A%20string%2C%20values%3A%20string%5B%5D)%20%3D%3E%20string%5B%5D%3B%0D%0A%20%20%7D

Related Issues: Possibly https://github.com/Microsoft/TypeScript/issues/27704

created time in 3 months

issue commentolifolkerd/tabulator

We need to help Oli!

Im also looking for someone with experience in TypeScript who would be willing to sort out some TypeScript Typings for Tabulator, i dont use it myself so dont really know what it entails. the issue for this one is #86

@olifolkerd -- This would be a massive typescript definition. I'll give it a shot since I am trying to learn this library anyway. Would you expect the definition to be shipped with Tabulator or published to DefinitelyTyped?

Rodbjartson

comment created time in 3 months

issue commentolifolkerd/tabulator

$.widget is not a function - jquery_wrapper

Thanks @olifolkerd

I definitely plan on using the vanilla version but I am trying everything on the website to learn the ropes!

Jojoshua

comment created time in 3 months

issue commentolifolkerd/tabulator

$.widget is not a function - jquery_wrapper

Thanks for the clarification. The install instructions on the website does not mention needing jquery ui, only jquery.

Jojoshua

comment created time in 3 months

startedMicrosoft/TypeScript

started time in 3 months

issue openedolifolkerd/tabulator

$.widget is not a function - jquery_wrapper

Describe the bug When I included the jquery wrapper as shown here, http://tabulator.info/docs/4.2/jquery, I get an error Uncaught TypeError: $.widget is not a function

Tabulator Info

  • 4.2

To Reproduce Steps to reproduce the behavior:

  1. Create html file with only these in the head

    <script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha256-3edrmyuQ0w65f8gfBsqowzjJe2iM6n0nKciPUp8y+7E=" crossorigin="anonymous"></script> <link href="dist/css/tabulator_site.min.css" rel="stylesheet" /> <script type="text/javascript" src="dist/js/tabulator.min.js"></script> <script type="text/javascript" src="dist/js/jquery_wrapper.js"></script>

  2. Observe the error in console

created time in 3 months

issue closedolifolkerd/tabulator

getColumnLayout missing properties

Describe the bug Calling getColumnLayout is not returning all the column properties.

Tabulator Info 4.2

let tableConfig = { data: [ { id: 1, name: "Oli Bob", location: "United Kingdom", gender: "male", rating: 1, col: "red" }, { id: 2, name: "Mary May", location: "Germany", gender: "female", rating: 2, col: "blue" }, { id: 3, name: "Christine Lobowski", location: "France", gender: "female", rating: 0, col: "green" }, { id: 4, name: "Brendon Philips", location: "USA", gender: "male", rating: 1, col: "orange" }, { id: 5, name: "Margret Marmajuke", location: "Canada", gender: "female", rating: 5, col: "yellow" }, { id: 6, name: "Frank Harbours", location: "Russia", gender: "male", rating: 4, col: "red" }, { id: 7, name: "Jamie Newhart", location: "India", gender: "male", rating: 3, col: "green" }, { id: 8, name: "Gemma Jane", location: "China", gender: "female", rating: 0, col: "red" }, { id: 9, name: "Emily Sykes", location: "South Korea", gender: "female", rating: 1, col: "maroon" }, { id: 10, name: "James Newman", location: "Japan", gender: "male", rating: 5, col: "red" } ], height: "100%", layout: "fitColumns", columns: [{ title: "Name", field: "name", editor: "input" }] };

const table = new Tabulator(#table, tableConfig); console.log(table.getColumnLayout());

capture

Expected behavior I was expecting to see the editor property and it was missing.

Desktop (please complete the following information):

  • OS: Win 10
  • Browser:chrome

Additional context I intend to save the entire configuration in the database and reload. There may be other missing properties that I did not test but I would want everything that can be specified when calling "addColumn" to be return via getColumnLayout

closed time in 3 months

Jojoshua

issue commentolifolkerd/tabulator

getColumnLayout missing properties

I found that getColumnDefinitions includes the editor property. It seems this method is more relevant to be part of the Persistent module. I am not sure what the intention of getColumnDefinitions vs getColumnLayout should be.

Jojoshua

comment created time in 3 months

issue openedolifolkerd/tabulator

getColumnLayout missing properties

Describe the bug Calling getColumnLayout is not returning all the column properties.

Tabulator Info 4.2

let tableConfig = { data: [ { id: 1, name: "Oli Bob", location: "United Kingdom", gender: "male", rating: 1, col: "red" }, { id: 2, name: "Mary May", location: "Germany", gender: "female", rating: 2, col: "blue" }, { id: 3, name: "Christine Lobowski", location: "France", gender: "female", rating: 0, col: "green" }, { id: 4, name: "Brendon Philips", location: "USA", gender: "male", rating: 1, col: "orange" }, { id: 5, name: "Margret Marmajuke", location: "Canada", gender: "female", rating: 5, col: "yellow" }, { id: 6, name: "Frank Harbours", location: "Russia", gender: "male", rating: 4, col: "red" }, { id: 7, name: "Jamie Newhart", location: "India", gender: "male", rating: 3, col: "green" }, { id: 8, name: "Gemma Jane", location: "China", gender: "female", rating: 0, col: "red" }, { id: 9, name: "Emily Sykes", location: "South Korea", gender: "female", rating: 1, col: "maroon" }, { id: 10, name: "James Newman", location: "Japan", gender: "male", rating: 5, col: "red" } ], height: "100%", layout: "fitColumns", columns: [{ title: "Name", field: "name", editor: "input" }] };

const table = new Tabulator(#table, tableConfig); console.log(table.getColumnLayout());

capture

Expected behavior I was expecting to see the editor property and it was missing.

Desktop (please complete the following information):

  • OS: Win 10
  • Browser:chrome

Additional context I intend to save the entire configuration in the database and reload. There may be other missing properties that I did not test but I would want everything that can be specified when calling "addColumn" to be return via getColumnLayout

created time in 3 months

more