profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/JohnL17/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

adfinis-sygroup/mate-counter 0

Apprentice project

JohnL17/2119 0

2119 interpretations in other languages

JohnL17/caluma 0

A collaborative form editing service

JohnL17/caluma-demo 0

A demo for caluma

JohnL17/cookiecutter-django-json-api 0

Cookiecutter template for django json api project

JohnL17/customer-center 0

Adfinis SyGroup AG - Customer Center

JohnL17/ember-caluma 0

Ember.js addon for Caluma

JohnL17/freedomvote 0

A tool to represent the views of politicians and parties as a help to the voters.

delete branch freedomvote/freedomvote

delete branch : pyup-update-sqlparse-0.3.0-to-0.4.1

delete time in 8 days

create barnchfreedomvote/freedomvote

branch : pyup-update-sqlparse-0.3.0-to-0.4.2

created branch time in 8 days

push eventfreedomvote/freedomvote

pyup-bot

commit sha 968977cfedc4597e5c128c297ec0ed3c9dcaa0be

Update sqlparse from 0.3.0 to 0.4.2

view details

push time in 8 days

delete branch freedomvote/freedomvote

delete branch : pyup-update-pillow-5.4.1-to-8.3.1

delete time in 16 days

create barnchfreedomvote/freedomvote

branch : pyup-update-pillow-5.4.1-to-8.3.2

created branch time in 16 days

push eventfreedomvote/freedomvote

pyup-bot

commit sha 6ae0c88a06ad018e29b5b0842e3b0cfec2dbacd6

Update pillow from 5.4.1 to 8.3.2

view details

push time in 16 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentadfinis-sygroup/timed-backend

chore(release): v1.2.0

-# v1.2.0 (16 April 2021)+# v1.2.0 (11 August 2021)  ### Feature+* Use assignees with reviewer role instead of reviewers ([`89def71`](https://github.com/adfinis-sygroup/timed-backend/commit/89def71eefc0f18e7989b34f882acd2fd619998d))+* Rewrite permissions and visibilty to use with assignees and external employees ([`159e750`](https://github.com/adfinis-sygroup/timed-backend/commit/159e75033ed4c477d56f2a2817dee82b3066d2a9))+* Add user assignement to customers, projects and tasks ([`6ff4259`](https://github.com/adfinis-sygroup/timed-backend/commit/6ff425941307a0386d835187eaad02e26cc718e3)) * Export metrics with django-prometheus ([`6ed9cab`](https://github.com/adfinis-sygroup/timed-backend/commit/6ed9cabeeefd2e6945a63b83de1ee85018fb56a5))+* Add and enable sentry-sdk for error reporting ([`1e96b78`](https://github.com/adfinis-sygroup/timed-backend/commit/1e96b785206ddd1a871e5b23a9126f50c94c38dc)) * Show not_billable and review attributes for reports in weekly report ([`a02aca4`](https://github.com/adfinis-sygroup/timed-backend/commit/a02aca48ae609f9ac514238be723c056fa60754f)) * Add customer_visible field to project serializer ([`2f12f86`](https://github.com/adfinis-sygroup/timed-backend/commit/2f12f86d6132c1362d7065ad0fd8cf89a4f4f377)) * Add billed flag to project and tracking ([`fe41199`](https://github.com/adfinis-sygroup/timed-backend/commit/fe41199527e5ab37f23c715d844805b7d8944d64))+* **employment:** Add new attribute is_external to employment model ([`e8e6291`](https://github.com/adfinis-sygroup/timed-backend/commit/e8e629193b7aabd592fc9744bc7210577d58c910)) * **projects:** Add currency fields to task and project ([`7266c34`](https://github.com/adfinis-sygroup/timed-backend/commit/7266c346236e9e0d1c83d9f84b99a4e782256ba4))+* **runtime:** Use gunicorn instead of uwsgi ([`e6b1fdf`](https://github.com/adfinis-sygroup/timed-backend/commit/e6b1fdfc5bb2ad5578ed2927ee210b5da2119f9b))+* **redmine:** Update template formatting ([`9b1a6f1`](https://github.com/adfinis-sygroup/timed-backend/commit/9b1a6f164f72c2eae57a1e20cc0cff763c7e535a))  ### Fix+*

Isn't that bullet point redundant?

trowik

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentadfinis-sygroup/timed-backend

feat: use assignees instead of reviewers

Overall looks good to me.

trowik

comment created time in a month

Pull request review commentadfinis-sygroup/timed-backend

feat: use assignees instead of reviewers

 class ProjectFilterSet(FilterSet):     """Filter set for the projects endpoint."""      archived = NumberFilter(field_name="archived")-    reviewer = NumberFilter(field_name="reviewers")+    has_manager = NumberFilter(method="filter_has_manager")+    has_reviewer = NumberFilter(method="filter_has_reviewer")++    def filter_has_manager(self, queryset, name, value):+        if not value:  # pragma: no cover+            return queryset+        return queryset.filter(+            Q(+                pk__in=models.ProjectAssignee.objects.filter(+                    is_manager=True, user_id=value+                ).values("project_id"),+            )+            | Q(+                customer_id__in=models.CustomerAssignee.objects.filter(+                    is_manager=True, user_id=value+                ).values("customer_id"),+            )+        )++    def filter_has_reviewer(self, queryset, name, value):

Ah ok I can see it now :wink:

trowik

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentadfinis-sygroup/timed-backend

feat: use assignees instead of reviewers

 class ProjectFilterSet(FilterSet):     """Filter set for the projects endpoint."""      archived = NumberFilter(field_name="archived")-    reviewer = NumberFilter(field_name="reviewers")+    has_manager = NumberFilter(method="filter_has_manager")+    has_reviewer = NumberFilter(method="filter_has_reviewer")++    def filter_has_manager(self, queryset, name, value):+        if not value:  # pragma: no cover+            return queryset+        return queryset.filter(+            Q(+                pk__in=models.ProjectAssignee.objects.filter(+                    is_manager=True, user_id=value+                ).values("project_id"),+            )+            | Q(+                customer_id__in=models.CustomerAssignee.objects.filter(+                    is_manager=True, user_id=value+                ).values("customer_id"),+            )+        )++    def filter_has_reviewer(self, queryset, name, value):

Isn't the method filter_has_reviewer exactly the same as the method filter_has_manager?

trowik

comment created time in a month

PullRequestReviewEvent

delete branch freedomvote/freedomvote

delete branch : pyup-update-django-colorfield-0.1.15-to-0.4.1

delete time in 2 months

push eventfreedomvote/freedomvote

pyup-bot

commit sha 114967ea7429c1c4fb25731f8aacbb3c9c7804eb

Update django-colorfield from 0.1.15 to 0.4.2

view details

push time in 2 months

delete branch freedomvote/freedomvote

delete branch : pyup-update-pillow-5.4.1-to-8.3.0

delete time in 2 months

create barnchfreedomvote/freedomvote

branch : pyup-update-pillow-5.4.1-to-8.3.1

created branch time in 2 months

push eventfreedomvote/freedomvote

pyup-bot

commit sha 41edf997b66238a1b7fd9a5f88a3da6671b83e78

Update pillow from 5.4.1 to 8.3.1

view details

push time in 2 months

delete branch freedomvote/freedomvote

delete branch : pyup-update-pillow-5.4.1-to-8.2.0

delete time in 3 months

push eventfreedomvote/freedomvote

pyup-bot

commit sha b533328a980716d3cad7fa1ba5869d3c79c3ee2a

Update pillow from 5.4.1 to 8.3.0

view details

push time in 3 months

create barnchfreedomvote/freedomvote

branch : pyup-update-pillow-5.4.1-to-8.3.0

created branch time in 3 months

delete branch freedomvote/freedomvote

delete branch : pyup-update-django-cms-3.6.0-to-3.8.0

delete time in 3 months

push eventfreedomvote/freedomvote

pyup-bot

commit sha 6d1fbc57234a43248f808e1a7823761e56a82754

Update django-cms from 3.6.0 to 3.9.0

view details

push time in 3 months

create barnchfreedomvote/freedomvote

branch : pyup-update-django-cms-3.6.0-to-3.9.0

created branch time in 3 months