Jacse ( Jacob Lauritzen )

commit sha 1d3d5c3517420beba195d901455ce96154a64615

Fix typos

push time in 6 days

Create Custom Bottom Button

My bad! Updated the link.

ramkumarb

comment created time in 13 days

Jordan Davis

commit sha 1d13deaf5b7c1a5ee704d0261ac3f6964817e5ef

Change slide key from number to string (#199)

push time in 17 days

Change slide key from number to string

Change slide key from number to string

Prevents warning -> "Warning: Failed child context type: Invalid child context virtualizedCell.cellKey of type number supplied to CellRenderer, expected string. " from Flatlist data attribute. Avoids the warning for people copying code from the readme :)

+3 -3

1 commit in jorjordandan/react-native-app-intro-slider/tree/jorjordandan-readme-edit Jacse/react-native-app-intro-slider/tree/master

4 comments

1 changed file

jorjordandan

pr closed time in 17 days

pull request commentJacse/react-native-app-intro-slider

Ah of course.

jorjordandan

comment created time in 17 days

pull request commentJacse/react-native-app-intro-slider

Change slide key from number to string

Could you update the examples as well?

jorjordandan

comment created time in 18 days

AamChora

commit sha 78c2adbbb35d6992b13fe7a214a6a05b7d6e26d6

Fixed Typo (#197)

push time in a month

Fixed Typo

+1 -1

1 commit in HemendraKhatik/react-native-app-intro-slider/tree/Error-Fixing Jacse/react-native-app-intro-slider/tree/master

0 comment

1 changed file

HemendraKhatik

pr closed time in a month

kazu

commit sha 49f5633f4800129f82ecc8d89e39d7279741c914

Fix #195

push time in a month

Example links in READ.ME are broken

Example links in READ.ME are broken.

Screen Shot 2020-05-27 at 13 04 14

closed time in a month

kerron

Changed examples URLs from *.js to *.tsx

#195

[x] Changed examples URLs from *.js to *.tsx

+6 -6

1 commit in kazu914/react-native-app-intro-slider/tree/fix-broken-urls-in-readme Jacse/react-native-app-intro-slider/tree/master

0 comment

1 changed file

kazu914

pr closed time in a month

argument type of `renderItem` should be ItemT

Absolutely! Let me know if it looks good on version 4.0.4

pke

comment created time in a month

Getting TS warning: "No overload matches this call"

Please try version 4.0.4 and let me know if it works!

neXorianus

comment created time in a month

release Jacse/react-native-app-intro-slider

v4.0.4

released time in a month

tagv4.0.4

Simple and configurable app introduction slider for react native

created time in a month

tagv4.0.3

Simple and configurable app introduction slider for react native

created time in a month

commit sha e9fe44504583fe4e2f0bef948ecf4938158d2089

4.0.4

push time in a month

commit sha a13893e0cdeb219236a8b10e837f34514acd98cc

Migrate examples to TS

commit sha c6890510c1938a7677f64e788cc861f0c975ca84

Fix #189, fix #191

commit sha f73aa31d06ece4d118dd4c67a893365e72352331

4.0.3

commit sha 7406e1d27d2d37ee93c39f3a9eed5224f7397d8f

Merge branch 'master' of github.com:Jacse/react-native-app-intro-slider

push time in a month

argument type of `renderItem` should be ItemT

This is great library! It has every customisation feature I'd hoped for! Kudos! 🚀

One little question though re the renderItem render function: Its currently defined as: renderItem: (a: any) => React.ReactNode; wouldn't it be possible to define it as renderItem: (a: ItemT) => React.ReactNode;?

closed time in a month

pke

Getting TS warning: "No overload matches this call"

Using "react-native-app-intro-slider": "^4.0.2", and

<AppIntroSlider
  renderItem={this._renderItem}
  data={slides}
  //ref={(ref) => this.slider = ref} } //same with all following commented in
  //onDone={this._onDone}
  //showNextButton={false}
  //showDoneButton={false}
  //dotStyle={styles.dot}
  //activeDotStyle={styles.activeDot}
/>

im getting the following Warning from TS:

(alias) class AppIntroSlider<ItemT>
import AppIntroSlider

No overload matches this call.
  Overload 1 of 2, '(props: Readonly<Props<unknown>>): AppIntroSlider<unknown>', gave the following error.
    Type '{ ref: (ref: AppIntroSlider<unknown>) => AppIntroSlider<unknown>; renderItem: ({ item, index }: { item: any; index: any; }) => Element; data: ISlide[]; onDone: () => void; showNextButton: false; showDoneButton: false; dotStyle: AnyStyle; activeDotStyle: AnyStyle; }' is missing the following properties from type 'Pick<Readonly<Props<unknown>> & Readonly<{ children?: ReactNode; }>, "testID" | "onDone" | "data" | "style" | "children" | "renderItem" | "renderSkipButton" | ... 139 more ... | "nestedScrollEnabled">': showPrevButton, showSkipButton
Overload 2 of 2, '(props: Props<unknown>, context?: any): AppIntroSlider<unknown>', gave the following error.
    Type '{ ref: (ref: AppIntroSlider<unknown>) => AppIntroSlider<unknown>; renderItem: ({ item, index }: { item: any; index: any; }) => Element; data: ISlide[]; onDone: () => void; showNextButton: false; showDoneButton: false; dotStyle: AnyStyle; activeDotStyle: AnyStyle; }' is missing the following properties from type 'Pick<Readonly<Props<unknown>> & Readonly<{ children?: ReactNode; }>, "testID" | "onDone" | "data" | "style" | "children" | "renderItem" | "renderSkipButton" | ... 139 more ... | "nestedScrollEnabled">': showPrevButton, showSkipButton
ts(2769)

I'm guessing, that the types passed in index.d.ts are not reflecting the optional values correctly, or the docu is out of date.

The Component renders without problems. The Error is only in Editor.

System: macOS, Editor: Visual Studio Code

closed time in a month

neXorianus

commit sha 98316e81af8ab7ecfcab945356ac3b8cd750a413

Update README.md

push time in a month

renderNextButton not working, when using renderPagination.

renderPagination covers both the pagination dots and any buttons, so if you want to render buttons you should do so inside the renderPagination-function. I'll make sure to update the README to document this better.

TamerlanG

comment created time in a month

PrevButton and NextButton functionality?

Is there any like onNextButtonPress or onPreviousButtonPress function available... cos i need to do something with that... thanks

closed time in a month

guitorioadar

PrevButton and NextButton functionality?

Will onSlideChange work for you @guitorioadar? I'm going to close this for now, but let me know if I should reopen.

guitorioadar

comment created time in a month

State not managed.

I don't think this is an issue with the component. Is the renderItem-function defined inside your component so it has access to the answers-state?

Saad-Bashar

comment created time in a month

How can i have skip button on the last slide?

You could defined your own pagination component using renderPagination. That would give you full control over which buttons are displayed when.

guitorioadar

comment created time in a month

backgroundColor for slides not working[Android]

Are you sure mainTheme.onBoardingScreen1Color is defined?

erhan355

comment created time in a month

Can't find variable: Image

You need to import the Image-component from react-native

Arpanbhalla

comment created time in a month

issue commentapollographql/react-apollo

Refetch(with different variables) return old values if query variables already in cache

@DerekHung I've looked into this, but haven't been able to reproduce it. Can you take a look at the test in #3434 to see if I'm understanding the problem correctly? If not, would you be able to put together a small runnable reproduction?

I believe this is an issue with the cache. I still experience this using the latest version but not if I specify networkPolicy: 'network-only'. Of course, I'd prefer to be able to use the cache.

DerekHung

comment created time in 2 months

startedfeathericons/feather

started time in 2 months

Cannot read property 'length' of undefined

Are you sure you passed the data-prop?

theromie

comment created time in 2 months

backgroundColor for slides not working[Android]

Hi @erhan355 I think something went wrong when you tried posting the code?

erhan355

comment created time in 2 months

Full screen background image is added an increasing offset on each slide

Hi,

I'm facing a strange issue using this module with RN & expo SDK on android. I have 5 images i set up to be full screen displayed

_renderSlide = ({ item, dimensions }) => {
    return (
      <View>
        <Image source={item.image} style={{...dimensions}}/>
      </View>
    );
  }

The first slide renders with a right offset of about 1px, i can see first image on second slide left side. The second renders with 2px The third with 4px and so on ...

Seems like each slide multiples a tiny offset which becomes bigger and bigger. Did anybody experienced this behaviour ? I did not found anything about this in issues database.

Thanks Regards.

closed time in 2 months

bouchezb

Full screen background image is added an increasing offset on each slide

Closing this for inactivity.

bouchezb

comment created time in 2 months

PrevButton and NextButton functionality?

Did you consider onSlideChange? That will be called every time the user navigates to one of the other slides.

guitorioadar

comment created time in 2 months

How can i have skip button on the last slide?

May I ask why? Normally the skip button just goes to the last page which wouldn't really make sense given that you are already on the last page.

guitorioadar

comment created time in 2 months

startedsapientglobalmarkets/react-querybuilder

started time in 2 months

starteddowjones/react-dropdown-tree-select

started time in 2 months

pull request commentJacse/react-native-app-intro-slider

Fixed custom button link and typo

Good catch, thanks!

JacquesLG

comment created time in 2 months

Jacques Le Gall

commit sha 4661b28036778d2f42063754c620e617573007ff

Fix custom button link and typo (#184)

push time in 2 months

Fixed custom button link and typo

+1 -1

3 commit in JacquesLG/react-native-app-intro-slider/tree/master Jacse/react-native-app-intro-slider/tree/master

0 comment

1 changed file

JacquesLG

pr closed time in 2 months

dist/index.js missing

It looks like I somehow forgot to build the index.js-file before publishing to npm, really sorry! I've updated the scripts so that won't be possible in the future. Please try with the latest version on npm.

RauanBPK

comment created time in 3 months

tagv4.0.2

Simple and configurable app introduction slider for react native

created time in 3 months

commit sha e04d4c8ac3348f207a95d57946a2441e437fd17f

Ensure building before publishing

commit sha 80bc1089ed63df2faffc55f172827ab71637693a

4.0.2

push time in 3 months

release Jacse/react-native-app-intro-slider

v4.0.1

released time in 3 months

tagv4.0.1

Simple and configurable app introduction slider for react native

created time in 3 months

commit sha 6d628d27947db802c5ab2fb0e048ba61954f0b02

4.0.1

push time in 3 months

commit sha f9e804ce6e448012bf22fd91c156258ff93a35d9

Closes #96

commit sha 10c2222ecd19106712b338e7eda97cafffde1134

Fix examples iOS project

commit sha d275ed26756f78574da10ded94dd3ba0a8c702e3

Fix #181

commit sha 0308a9113660744fe1dc40747f3d83d1a345fa1b

Close #138

commit sha a03ced3430a52a701988c1b124ef7796ee45acd4

Remove dist files from git

push time in 3 months

Disable pagination dots click

Hi guys, nice component, tnx!

Would it be possible to prevent navigation by clicking on the pagination dots? (like it is possible to disable swiping using scrollEnabled={false} attribute of the FlatList)

Tnx, Marco

closed time in 3 months

marcolangebeeke

Can't pass extraData to AppIntroSlider

i noticed that your AppIntroSlider can't pass extraData like previous version so can you please add it to your package.

closed time in 3 months

dungphung

TypeScript support

There's some of us that love TS and also find this lib extremely useful. I will look into this in a few weeks to make the contribution myself if you guys support the idea.

closed time in 3 months

dacevedo12

Crash in release variant on Android

I'm going to close this for inactivity for now, let me know if it you still experience this issue.

Metallistener

comment created time in 3 months

Crash in release variant on Android

Hi! The library crashes on Android in release variant, but in debug mode it works properly. RN version is 0.61.4

closed time in 3 months

Metallistener

can not move the dots left side of the screen. and paginationStyle is not working

<AppIntroSlider renderItem={(item) => this.renderItem(item)} slides={slides}
// ref={component => {this.refSlider = component}}
dotColor={StyleConfig.lighter_grey} activeDotColor={StyleConfig.blue_light} paginationStyle={{textAlign:'left'}} renderNextButton={this._renderNextButton} renderDoneButton={this._renderDoneButton}

/>

closed time in 3 months

hiren0412

can not move the dots left side of the screen. and paginationStyle is not working

I'm going to close this for inactivity. Let me know if you stille experience the issue.

hiren0412

comment created time in 3 months

Absolute positioning for intro

Doesn't it work if you simply wrap the component in a View that's absolutely positioned?

summerkiflain

comment created time in 3 months

IssuesEvent

TypeScript support

@Jacse Thank you for the rewrite, but the index.d.ts is not exported, so we can't really use the types.

You make a very good point!

dacevedo12

comment created time in 3 months

startedbashtage/linearmodels

started time in 3 months

Cannot run AppIntroSlider because of TypeError

You too!

smeusling

comment created time in 3 months

AppIntroSlider is not showing inside View tag

Team, If I place AppIntroSlider inside <View> tag I am getting blank screen.

I want to place my signin button and AppIntroSlider in same component. How can I solve this problem?

closed time in 3 months

stardev24

AppIntroSlider is not showing inside View tag

Closing this for now. Please reopen and provide some reproducible code if you still need help

stardev24

comment created time in 3 months

Full screen background image is added an increasing offset on each slide

Do you experience this on the latest version as well?

bouchezb

comment created time in 3 months

Bottom buttons and dots vertical align differently on different iPhone models

First - thanks for publishing this! It's exactly what I needed for my app intro.

Here's a screenshot of the issue - iPhone 11 on the left, iPhone 11 Pro on the right. Screen Shot 2020-01-03 at 4 31 35 PM

Based on my testing, the buttons and dots are higher on the 11 Pro, X, and XS. They are lower (which I think is the ideal alignment) on the 11, XS Max, XR, 8, 8 Plus, and 11 Pro Max.

Here's the Snack I used to create this: https://snack.expo.io/@bcaspar/privileged-pastry

Edit: looks like const isIphoneX may be to blame - not sure it's picking up the appropriate phones. Anyway, by overriding the style by adding paginationStyle={{bottom: 16}} fixes the issue for the phones I identified above, and is included (commented out) in the snack.

closed time in 3 months

bscaspar

Bottom buttons and dots vertical align differently on different iPhone models

I'm going to close this for now. Please reopen if this is still an issue on the latest version.

bscaspar

comment created time in 3 months

Error Data.Length in IntroSlider.JS

Hi,

After updating the Expo version, the following error is returning in the component. Can you help me please?

**TypeError: undefined is not and object (evaluating: 'data.length')

This error is located at: in AppIntroSlider (at IntroSlider.js: 135)**

closed time in 3 months

zapcriativo

Error Data.Length in IntroSlider.JS

Closing this since it seems to be resolved

zapcriativo

comment created time in 3 months

Cannot run AppIntroSlider because of TypeError

I just install react-native-app-intro-slider and I have the following error when running my app : Screenshot 2020-04-10 at 21 49 54

closed time in 3 months

smeusling

Cannot run AppIntroSlider because of TypeError

You need to supply the slides using the data-prop, which was renamed from slides in version 4. You can find the release notes under releases

smeusling

comment created time in 3 months

OnSwipe event

I will like to transition into another screen with react-navigation-transition when a user swipe-left on the last slide.

I couldn't achieve this with the onSlideChange, onDone and onSkip events, unfortunately.

Can we have an onSwipe event?

closed time in 3 months

dipo1

OnSwipe event

Closing this for now. Let me know if you still experience the issue!

dipo1

comment created time in 3 months

Problems with dots and styles in android versions 7.1

When I try the slider in an Android 9 version it works perfectly, but when I try with my phone that is version 7.1 or with some emulator in that same version I have style problems.

For example, when I put a border radius on a View, its background disappears and another thing I notice is that the Dots also disappear.

Attention, this only happens in versions of android 7.1 ... In android 9 IF IT WORKS.

closed time in 3 months

jzambrano12

Problems with dots and styles in android versions 7.1

Closing for inactivity - let me know if this is still an issue!

jzambrano12

comment created time in 3 months

Can no longer customise colour of label text

I'm going to close this since it seems resolved. Let me know if other issues arise!

cameronmurphy

comment created time in 3 months

Can no longer customise colour of label text

With the update to 4.x I can no longer change the Next / Skip / Back / Done label text to black, as we have white slides in our app intro.

Previously we were able to use the buttonTextStyle prop and now this is gone.

Please provide some kind of upgrade guide and information as to how to restore 3.x functionality.

closed time in 3 months

cameronmurphy

Error Data.Length in IntroSlider.JS

But buttonStyle is no longer working, did you change the name of the props?

buttonStyle has been removed in favor of using the renderDoneButton/renderNextButton etc. functions. You can find out more about the release under release notes.

Hope it makes sense!

zapcriativo

comment created time in 3 months