profile
viewpoint
Jonas Devlieghere JDevlieghere @apple San Jose, CA http://jonasdevlieghere.com Software engineer  Working on LLVM, LLDB, Clang & Swift.

JDevlieghere/dotfiles 263

⚙ Dotfiles for Linux &macOS

AlexDenisov/bitcode_retriever 162

Retrieves Bitcode from Mach-O binaries

JDevlieghere/InTeXration 18

TeX Continuous Integration Service

JDevlieghere/Backbone.Marionette-AMD-Modules 3

Backbone.Marionette Example with AMD Modules (RequireJS)

JDevlieghere/Letter-Matrix 3

Word Search / Letter Matrix Solver in Haskell

dennisdegryse/TripleDJSim 1

RinSim is a multi-agent system simulator written in Java. It supports problems in the fields of transportation and logistics, most notably pickup-and-delivery problems (PDP). The simulator is being developed at AgentWise in the DistriNet group at the Department of Computer Science, KU Leuven, Belgium. At KU Leuven RinSim is being used both in research and in education.

JDevlieghere/ArduinoDisplay 1

Arduino Display

JDevlieghere/GoTV 1

Find new TV episodes

JDevlieghere/llvm-project 1

This is the canonical git mirror of the LLVM subversion repository. The repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

JDevlieghere/llvm.vim 1

Mirror of llvm/utils/vim

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 024921a5e165cc2e0fa7c1b3732aff6f3f5df60b

Use LLVM_TOOLCHAIN_UTILITIES to allow utils to be installed in the toolchain Make it possible to specify a list of utilities that should be installed in the toolchain. Differential revision: https://reviews.llvm.org/D89762

view details

push time in 12 hours

push eventllvm/llvm-project

Jonas Devlieghere

commit sha f44fb130253aa5486380604101ce50a62a8d668b

[FileCollector] Move interface into FileCollectorBase (NFC) For the reproducers in LLDB we want to switch to an "immediate mode" FileCollector that writes every file encountered straight to disk so we can generate the actual mapping out-of-process. This patch moves the interface into a separate base class. Differential revision: https://reviews.llvm.org/D89742

view details

push time in 12 hours

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/97b8e2c1f063

delete time in 13 hours

push eventapple/llvm-project

Jonas Devlieghere

commit sha e6aba2ffcc757c682a109bcf1591b8e1a578d08c

[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools For testing purposes I need a way to build and install FileCheck and yaml2obj. I had to choose between making FileCheck an LLVM tool and making obj2yaml and yaml2obj utilities. I think the distinction is rather arbitrary but my understanding is that tools are things meant for the toolchain while utilities are more used for things like testing, which is the case here. The functional difference is that these tools now end up in the ${LLVM_UTILS_INSTALL_DIR}, which defaults to the ${LLVM_TOOLS_INSTALL_DIR}. Unless you specified a different value or you added obj2yaml and yaml2obj to ${LLVM_TOOLCHAIN_TOOLS}, this patch shouldn't change anything. Differential revision: https://reviews.llvm.org/D89357 (cherry picked from commit 97b8e2c1f063529125a8d1604d2745878c016061)

view details

Jonas Devlieghere

commit sha 5ec381467b187c060595442dfb1756e38c6b1d9d

Merge pull request #1998 from JDevlieghere/🍒/bastille/97b8e2c1f063 [llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools

view details

push time in 13 hours

PR merged apple/llvm-project

[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools

For testing purposes I need a way to build and install FileCheck and yaml2obj. I had to choose between making FileCheck an LLVM tool and making obj2yaml and yaml2obj utilities. I think the distinction is rather arbitrary but my understanding is that tools are things meant for the toolchain while utilities are more used for things like testing, which is the case here.

The functional difference is that these tools now end up in the ${LLVM_UTILS_INSTALL_DIR}, which defaults to the ${LLVM_TOOLS_INSTALL_DIR}. Unless you specified a different value or you added obj2yaml and yaml2obj to ${LLVM_TOOLCHAIN_TOOLS}, this patch shouldn't change anything.

Differential revision: https://reviews.llvm.org/D89357

(cherry picked from commit 97b8e2c1f063529125a8d1604d2745878c016061)

+2 -2

1 comment

2 changed files

JDevlieghere

pr closed time in 13 hours

pull request commentapple/llvm-project

[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools

@swift-ci please test macos

JDevlieghere

comment created time in 16 hours

PR opened apple/llvm-project

[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools

For testing purposes I need a way to build and install FileCheck and yaml2obj. I had to choose between making FileCheck an LLVM tool and making obj2yaml and yaml2obj utilities. I think the distinction is rather arbitrary but my understanding is that tools are things meant for the toolchain while utilities are more used for things like testing, which is the case here.

The functional difference is that these tools now end up in the ${LLVM_UTILS_INSTALL_DIR}, which defaults to the ${LLVM_TOOLS_INSTALL_DIR}. Unless you specified a different value or you added obj2yaml and yaml2obj to ${LLVM_TOOLCHAIN_TOOLS}, this patch shouldn't change anything.

Differential revision: https://reviews.llvm.org/D89357

(cherry picked from commit 97b8e2c1f063529125a8d1604d2745878c016061)

+2 -2

0 comment

2 changed files

pr created time in 16 hours

create barnchJDevlieghere/llvm-project

branch : 🍒/bastille/97b8e2c1f063

created branch time in 16 hours

Pull request review commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip

 def skipIfAsan(func):     """Skip this test if the environment is set up to run LLDB *itself* under ASAN."""     return skipTestIfFn(is_running_under_asan)(func) -def _get_bool_config_skip_if_decorator(key):

Thanks, it's more about making sure it doesn't get forgotten than blocking the merge.

Teemperor

comment created time in 21 hours

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip

 def skipIfAsan(func):     """Skip this test if the environment is set up to run LLDB *itself* under ASAN."""     return skipTestIfFn(is_running_under_asan)(func) -def _get_bool_config_skip_if_decorator(key):

Should this part be upstream?

Teemperor

comment created time in a day

PullRequestReviewEvent

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 97b8e2c1f063529125a8d1604d2745878c016061

[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools For testing purposes I need a way to build and install FileCheck and yaml2obj. I had to choose between making FileCheck an LLVM tool and making obj2yaml and yaml2obj utilities. I think the distinction is rather arbitrary but my understanding is that tools are things meant for the toolchain while utilities are more used for things like testing, which is the case here. The functional difference is that these tools now end up in the ${LLVM_UTILS_INSTALL_DIR}, which defaults to the ${LLVM_TOOLS_INSTALL_DIR}. Unless you specified a different value or you added obj2yaml and yaml2obj to ${LLVM_TOOLCHAIN_TOOLS}, this patch shouldn't change anything. Differential revision: https://reviews.llvm.org/D89357

view details

push time in a day

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 bool SwiftASTContext::CacheUserImports(SwiftASTContext &swift_ast_context, bool SwiftASTContext::GetCompileUnitImports(     SwiftASTContext &swift_ast_context, SymbolContext &sc,     lldb::StackFrameWP &stack_frame_wp,-    llvm::SmallVectorImpl<swift::ModuleDecl *> &modules, Status &error) {+    llvm::SmallVectorImpl<swift::AttributedImport<swift::ImportedModule>>+        &modules,+    Status &error) {   // Import the Swift standard library and its dependencies.   SourceModule swift_module;-  swift_module.path.push_back(ConstString("Swift"));+  swift_module.path.emplace_back("Swift");

Like you did here 👍

medismailben

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 bool SwiftUserExpression::Parse(DiagnosticManager &diagnostic_manager,                                  "couldn't start parsing (no target)");     return false;   }++  StackFrame *frame = exe_ctx.GetFramePtr();+  if (!frame) {+    LLDB_LOG(log, "no stack frame");+    return false;+  }++  // Make sure the target's SwiftASTContext has been setup before doing any+  // Swift name lookups.+  llvm::Optional<SwiftASTContextReader> maybe_swift_ast_ctx =+      target->GetScratchSwiftASTContext(err, *frame);+  if (!maybe_swift_ast_ctx) {+    LLDB_LOG(log, "no Swift AST Context");+    return false;+  }++  SwiftASTContext *swift_ast_ctx = maybe_swift_ast_ctx->get();+   if (auto *persistent_state = GetPersistentState(target, exe_ctx)) {-    persistent_state->AddHandLoadedModule(ConstString("Swift"));++    Status error;+    ConstString module_name("Swift");+    SourceModule module_info;+    module_info.path.emplace_back(module_name);

This is a vector of ConstString so the point of the emplace is that you can do module_info.path.emplace_back("Swift");

medismailben

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 bool SwiftASTContext::GetImplicitImports(       sc.target_sp->GetSwiftPersistentExpressionState(exe_scope);    // Get the hand-loaded modules from the SwiftPersistentExpressionState.-  for (ConstString name : persistent_expression_state->GetHandLoadedModules()) {-    SourceModule module_info;-    module_info.path.push_back(name);-    auto *module = LoadOneModule(module_info, swift_ast_context, stack_frame_wp,-                                 error);-    if (!module)-      return false;+  for (auto module_pair : persistent_expression_state->GetHandLoadedModules()) {+    if (!module_pair.second.module.importedModule) {+      SourceModule module_info;+      module_info.path.push_back(module_pair.first);+      auto *module =+          LoadOneModule(module_info, swift_ast_context, stack_frame_wp, error);+      if (!module)+        return false; -    modules.push_back(module);+      modules.push_back(swift::ImportedModule(module));

emplace_back?

medismailben

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 bool SwiftUserExpression::Parse(DiagnosticManager &diagnostic_manager,                                  "couldn't start parsing (no target)");     return false;   }++  StackFrame *frame = exe_ctx.GetFramePtr();+  if (!frame) {+    LLDB_LOG(log, "  [SUE::Parse] Null stack frame");+    return false;+  }++  // Make sure the target's SwiftASTContext has been setup before doing any+  // Swift name lookups.+  llvm::Optional<SwiftASTContextReader> maybe_swift_ast_ctx =+      target->GetScratchSwiftASTContext(err, *frame);+  if (!maybe_swift_ast_ctx) {+    LLDB_LOG(log, "  [SUE::Parse] NULL Swift AST Context");+    return false;+  }++  SwiftASTContext *swift_ast_ctx = maybe_swift_ast_ctx->get();+   if (auto *persistent_state = GetPersistentState(target, exe_ctx)) {-    persistent_state->AddHandLoadedModule(ConstString("Swift"));++    ConstString module_name("Swift");

This code looks very similar to what was added in SwiftExpressionParser.cpp. Any way to factor this out and propagate the error in one case and passing it to LLDB_LOG in the other?

medismailben

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 static llvm::Expected<ParsedExpression> ParseAndImport(    swift::ImplicitImportInfo importInfo;   importInfo.StdlibKind = swift::ImplicitStdlibKind::Stdlib;-  for (auto *module : additional_imports)-    importInfo.AdditionalImports.emplace_back(swift::ImportedModule(module),-                                              swift::ImportOptions());+  for (auto attributed_import : additional_imports) {

Should this be auto&?

medismailben

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 static llvm::Expected<ParsedExpression> ParseAndImport(   if (playground) {     auto *persistent_state =         sc.target_sp->GetSwiftPersistentExpressionState(exe_scope);-    persistent_state->AddHandLoadedModule(ConstString("Swift"));++    lldb::StackFrameSP this_frame_sp(stack_frame_wp.lock());+    if (!this_frame_sp)+      return make_error<StringError>(llvm::inconvertibleErrorCode(),+                                     "[SEP:PAI] No stackframe!");+    lldb::ProcessSP process_sp(this_frame_sp->CalculateProcess());+    if (!process_sp)+      return make_error<StringError>(llvm::inconvertibleErrorCode(),+                                     "[SEP:PAI] No process!");++    ConstString module_name("Swift");+    SourceModule module_info;+    module_info.path.push_back(module_name);++    Status error;+    swift::ModuleDecl *module = swift_ast_context->FindAndLoadModule(+        module_info, *process_sp.get(), error);++    if (error.Fail() || !module)+      return make_error<StringError>(llvm::inconvertibleErrorCode(),

return error.ToError()

medismailben

comment created time in 5 days

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 static llvm::Expected<ParsedExpression> ParseAndImport(   if (playground) {     auto *persistent_state =         sc.target_sp->GetSwiftPersistentExpressionState(exe_scope);-    persistent_state->AddHandLoadedModule(ConstString("Swift"));++    lldb::StackFrameSP this_frame_sp(stack_frame_wp.lock());+    if (!this_frame_sp)+      return make_error<StringError>(llvm::inconvertibleErrorCode(),+                                     "[SEP:PAI] No stackframe!");+    lldb::ProcessSP process_sp(this_frame_sp->CalculateProcess());+    if (!process_sp)+      return make_error<StringError>(llvm::inconvertibleErrorCode(),+                                     "[SEP:PAI] No process!");++    ConstString module_name("Swift");+    SourceModule module_info;+    module_info.path.push_back(module_name);

emplace_back() maybe?

medismailben

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

 static llvm::Expected<ParsedExpression> ParseAndImport(   if (playground) {     auto *persistent_state =         sc.target_sp->GetSwiftPersistentExpressionState(exe_scope);-    persistent_state->AddHandLoadedModule(ConstString("Swift"));++    lldb::StackFrameSP this_frame_sp(stack_frame_wp.lock());+    if (!this_frame_sp)+      return make_error<StringError>(llvm::inconvertibleErrorCode(),+                                     "[SEP:PAI] No stackframe!");

This might be done for consistency but generally errors should not start with capitals or end with punctuation (because they're commonly appended: error: error1: error2.

medismailben

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/f9fb9da36c34d2745b74dc30e6c26f7d3f48466c

delete time in 5 days

push eventapple/llvm-project

Jonas Devlieghere

commit sha 8a243daf2e002223d2882e85f324ca5f0a12a47d

[dsymutil] Fix handling of aliases to private external symbols dsymutil was incorrectly ignoring aliases to private extern symbols in the MachODebugMapParser. This resulted in spurious warnings about not being able to find symbols. rdar://49652389 Differential revision: https://reviews.llvm.org/D89444 (cherry picked from commit f9fb9da36c34d2745b74dc30e6c26f7d3f48466c)

view details

Jonas Devlieghere

commit sha edbe9dad8b25376af133d50193969e5097c3440b

Merge pull request #1970 from JDevlieghere/🍒/bastille/f9fb9da36c34d2745b74dc30e6c26f7d3f48466c [dsymutil] Fix handling of aliases to private external symbols

view details

push time in 5 days

PR merged apple/llvm-project

[dsymutil] Fix handling of aliases to private external symbols

dsymutil was incorrectly ignoring aliases to private extern symbols in the MachODebugMapParser. This resulted in spurious warnings about not being able to find symbols.

rdar://49652389

Differential revision: https://reviews.llvm.org/D89444

(cherry picked from commit f9fb9da36c34d2745b74dc30e6c26f7d3f48466c)

+32 -1

1 comment

5 changed files

JDevlieghere

pr closed time in 5 days

pull request commentapple/llvm-project

[dsymutil] Fix handling of aliases to private external symbols

@swift-ci please test

JDevlieghere

comment created time in 6 days

PR opened apple/llvm-project

[dsymutil] Fix handling of aliases to private external symbols

dsymutil was incorrectly ignoring aliases to private extern symbols in the MachODebugMapParser. This resulted in spurious warnings about not being able to find symbols.

rdar://49652389

Differential revision: https://reviews.llvm.org/D89444

(cherry picked from commit f9fb9da36c34d2745b74dc30e6c26f7d3f48466c)

+32 -1

0 comment

5 changed files

pr created time in 6 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha f9fb9da36c34d2745b74dc30e6c26f7d3f48466c

[dsymutil] Fix handling of aliases to private external symbols dsymutil was incorrectly ignoring aliases to private extern symbols in the MachODebugMapParser. This resulted in spurious warnings about not being able to find symbols. rdar://49652389 Differential revision: https://reviews.llvm.org/D89444

view details

push time in 6 days

create barnchJDevlieghere/llvm-project

branch : D89444

created branch time in 6 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/cdc18163cd1449c3a1c20e65a4d95a35ba3f6c23

delete time in 6 days

PR opened apple/llvm-project

[lldb] Fix typo in disassemble_options_line description

(cherry picked from commit cdc18163cd1449c3a1c20e65a4d95a35ba3f6c23)

+4 -4

0 comment

1 changed file

pr created time in 6 days

push eventJDevlieghere/dotfiles

Jonas Devlieghere

commit sha dad91f4b413a633b4d965d49ed34c9e07624b610

Add bat (cat with wings)

view details

push time in 6 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 1197ee35b84e1fe1c1884b3228b95351719fbb09

[lldb] Unconditionally strip the `.py(c)` extension when loading a module Currently we only strip the Python extension when the file exists on disk because we assumed that if it didn't exist it was a module. However, with the change from D89334 this is no longer the case as we want to be able to import a relative path to a .py as a module. Since we always import a scripting module as a "python module" we should always strip the extension if present. Differential revision: https://reviews.llvm.org/D89352

view details

Jonas Devlieghere

commit sha 3b33b41604784f903c7c5c38665d75da93dbf805

[lldb] Remove lexical block and fix formatting LoadScriptingModule (NFC)

view details

push time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch JDevlieghere/llvm-project

delete branch : 🍒/apple/stable/20200108/VFSYamlWriter

delete time in 7 days

PullRequestReviewEvent

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/7f8dc347c9552f339b4410b679d91bceb2cc456e

delete time in 7 days

push eventapple/llvm-project

Jonas Devlieghere

commit sha 4782156227ab12d1e76db3febce9fec896e9de69

[llvm] Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake so that it can be used from standalone builds of clang and lldb. Currently, there is no way for standalone builds to know whether this option was set which means that it only applies to LLVM. Differential revision: https://reviews.llvm.org/D89282 (cherry picked from commit 7f8dc347c9552f339b4410b679d91bceb2cc456e)

view details

Jonas Devlieghere

commit sha e3ec22dc4b0c5b9789ca2488842a43e4c1869c37

Merge pull request #1944 from JDevlieghere/🍒/bastille/7f8dc347c9552f339b4410b679d91bceb2cc456e [llvm] Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake

view details

push time in 7 days

PR merged apple/llvm-project

[llvm] Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake

Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake so that it can be used from standalone builds of clang and lldb. Currently, there is no way for standalone builds to know whether this option was set which means that it only applies to LLVM.

Differential revision: https://reviews.llvm.org/D89282

(cherry picked from commit 7f8dc347c9552f339b4410b679d91bceb2cc456e)

+2 -0

1 comment

1 changed file

JDevlieghere

pr closed time in 7 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/e465ddac880228b879b5a6549adbb9c8a7f335bf+360ab009e2b95629388cef132ebe639c120ed35e

delete time in 8 days

pull request commentapple/llvm-project

[llvm] Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake

@swift-ci please test

JDevlieghere

comment created time in 8 days

PR opened apple/llvm-project

[llvm] Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake

Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake so that it can be used from standalone builds of clang and lldb. Currently, there is no way for standalone builds to know whether this option was set which means that it only applies to LLVM.

Differential revision: https://reviews.llvm.org/D89282

(cherry picked from commit 7f8dc347c9552f339b4410b679d91bceb2cc456e)

+2 -0

0 comment

1 changed file

pr created time in 8 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 7f8dc347c9552f339b4410b679d91bceb2cc456e

[llvm] Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake Export LLVM_USE_SPLIT_DWARF in LLVMConfig.cmake so that it can be used from standalone builds of clang and lldb. Currently, there is no way for standalone builds to know whether this option was set which means that it only applies to LLVM. Differential revision: https://reviews.llvm.org/D89282

view details

push time in 8 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha e465ddac880228b879b5a6549adbb9c8a7f335bf

[lldb] Alphabetically sort test categories (NFC)

view details

Jonas Devlieghere

commit sha 360ab009e2b95629388cef132ebe639c120ed35e

[lldb] Add instrumentation runtime category

view details

push time in 8 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha ba2dff0159fcd1d2349bc610331914618ca9bc30

Revert "PR47792: Include the type of a pointer or reference non-type template" This reverts commit 849c60541b630ddf8cabf9179fa771b3f4207ec8 because it results in a stage 2 build failure: llvm-project/clang/include/clang/AST/ExternalASTSource.h:409:20: error: definition with same mangled name '_ZN5clang25LazyGenerationalUpdatePtrIPKNS_4DeclEPS1_XadL_ZNS_17ExternalASTSource19CompleteRedeclChainES3_EEE9makeValueERKNS_10ASTContextES4_' as another definition static ValueType makeValue(const ASTContext &Ctx, T Value);

view details

push time in 9 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 5d501096ca1fae74f910411cfeb0491d94c635b7

[lldb] Update docs with new buildbot URLs Buildbot got upgraded and now the (LLDB) builders have different URLs.

view details

push time in 11 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/0fcacefd160494280dc040f4f055db6df695ac12+a68ffb19d392c6d52f6e42925217a77b4cd71cee+9d7b08bd0657688c186b5b3d39512c484e8c37f5

delete time in 11 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 9d7b08bd0657688c186b5b3d39512c484e8c37f5

[lldb] Format remaining signal table (NFC) Restore the signal tables to its original glory and mark it as not to be clang-formatted.

view details

push time in 12 days

delete branch apple/llvm-project

delete branch : merge-bastille-into-main

delete time in 13 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/e1ef7183c6f008fa13cbe273500b020c4fad1252

delete time in 13 days

push eventapple/llvm-project

Jonas Devlieghere

commit sha d626bb872333b901ee6147522a48bfa2be994a7d

[dwarfdump] Warn for tags with DW_CHILDREN_yes but no children. Flag DIEs that have DW_CHILDREN_yes set in their abbreviation but don't actually have any children. rdar://59809554 Differential revision: https://reviews.llvm.org/D88048 (cherry picked from commit e1ef7183c6f008fa13cbe273500b020c4fad1252)

view details

Jonas Devlieghere

commit sha c6c82ad21ddb2064e28b51b71402639a6aa6f90b

[llvm] Remove no-children.yaml test This test relies on functionality in obj2yaml that's not present on the stable branch. I made an attempt at backporting all the necessary changes but quickly realized it was too much churn for this change.

view details

Jonas Devlieghere

commit sha 9ac059cf46a7074589cd11bfb705133dd1de8f3f

Merge pull request #1867 from JDevlieghere/🍒/bastille/e1ef7183c6f008fa13cbe273500b020c4fad1252 [dwarfdump] Warn for tags with DW_CHILDREN_yes but no children.

view details

push time in 13 days

PR merged apple/llvm-project

[dwarfdump] Warn for tags with DW_CHILDREN_yes but no children.

Flag DIEs that have DW_CHILDREN_yes set in their abbreviation but don't actually have any children.

rdar://59809554

Differential revision: https://reviews.llvm.org/D88048

(cherry picked from commit e1ef7183c6f008fa13cbe273500b020c4fad1252)

+14 -2

2 comments

3 changed files

JDevlieghere

pr closed time in 13 days

pull request commentapple/llvm-project

Merge bastille into main

@swift-ci please test

JDevlieghere

comment created time in 13 days

PR opened apple/llvm-project

Merge bastille into main
+1362 -161

0 comment

28 changed files

pr created time in 13 days

create barnchapple/llvm-project

branch : merge-bastille-into-main

created branch time in 13 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha 0fcacefd160494280dc040f4f055db6df695ac12

[lldb] Format unix signal table (NFC) Restore unix signal table to its original glory and mark it as not to be clang-formatted.

view details

push time in 13 days

pull request commentapple/llvm-project

[dwarfdump] Warn for tags with DW_CHILDREN_yes but no children.

@swift-ci please test

JDevlieghere

comment created time in 14 days

push eventJDevlieghere/llvm-project

Jonas Devlieghere

commit sha c6c82ad21ddb2064e28b51b71402639a6aa6f90b

[llvm] Remove no-children.yaml test This test relies on functionality in obj2yaml that's not present on the stable branch. I made an attempt at backporting all the necessary changes but quickly realized it was too much churn for this change.

view details

push time in 14 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/e3b0414b0ea305396a1fcfb2821ad643b0731880

delete time in 14 days

PR opened apple/llvm-project

[lldb] Change the xcrun (fallback) logic in GetXcodeSDK

This changes the logic in GetXcodeSDK to find an SDK with xcrun. The code now executes the following steps:

  1. If DEVELOPER_DIR is set in the environment, it invokes xcrun with the given developer dir. If this fails we stop and don't fall back.
  2. If the shlib dir is set and exists,it invokes xcrun with the developer dir corresponding to the shlib dir. If this fails we fall back to 3.
  3. We run xcrun without a developer dir.

The new behavior introduced in this patch is that we fall back to running xcrun without a developer dir if running it based on the shlib dir failed.

A situation where this matters is when you're running lldb from an Xcode that has no SDKs and that is not xcode-selected. Based on lldb's shlib dir pointing into this Xcode installation, it will do an xcrun with the developer set to the Xcode without any SDKs which will fail. With this patch, when that happens, we'll fall back to trying the xcode-selected Xcode by running xcrun without a developer dir.

Differential revision: https://reviews.llvm.org/D88866

(cherry picked from commit e3b0414b0ea305396a1fcfb2821ad643b0731880)

+34 -14

0 comment

1 changed file

pr created time in 14 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha e3b0414b0ea305396a1fcfb2821ad643b0731880

[lldb] Change the xcrun (fallback) logic in GetXcodeSDK This changes the logic in GetXcodeSDK to find an SDK with xcrun. The code now executes the following steps: 1. If DEVELOPER_DIR is set in the environment, it invokes xcrun with the given developer dir. If this fails we stop and don't fall back. 2. If the shlib dir is set and exists,it invokes xcrun with the developer dir corresponding to the shlib dir. If this fails we fall back to 3. 3. We run xcrun without a developer dir. The new behavior introduced in this patch is that we fall back to running xcrun without a developer dir if running it based on the shlib dir failed. A situation where this matters is when you're running lldb from an Xcode that has no SDKs and that is not xcode-selected. Based on lldb's shlib dir pointing into this Xcode installation, it will do an xcrun with the developer set to the Xcode without any SDKs which will fail. With this patch, when that happens, we'll fall back to trying the xcode-selected Xcode by running xcrun without a developer dir. Differential revision: https://reviews.llvm.org/D88866

view details

push time in 14 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/a58b20e5a4fb

delete time in 14 days

push eventapple/llvm-project

Jonas Devlieghere

commit sha 6f0433b4450fc0879c770bc222182f46289a9a7b

[llvm] Rename DwarfFile to DWARFFile to fix ODR violation (NFC) Rename the DwarfFile class in DWARFLinker to DWARFFile. This is consistent with the other DWARF classes and avoids a ODR violation with the DwarfFile class in AsmPrinter. (cherry picked from commit a58b20e5a4fb64404cb62d2bb6a5e6dc40d22784)

view details

Jonas Devlieghere

commit sha 486e5d9703b6dd773040ed942a1bdc7c16797f4e

Merge pull request #1909 from JDevlieghere/🍒/bastille/a58b20e5a4fb [llvm] Rename DwarfFile to DWARFFile to fix ODR violation (NFC)

view details

push time in 14 days

PR merged apple/llvm-project

[llvm] Rename DwarfFile to DWARFFile to fix ODR violation (NFC)

Rename the DwarfFile class in DWARFLinker to DWARFFile. This is consistent with the other DWARF classes and avoids a ODR violation with the DwarfFile class in AsmPrinter.

(cherry picked from commit a58b20e5a4fb64404cb62d2bb6a5e6dc40d22784)

+56 -56

1 comment

4 changed files

JDevlieghere

pr closed time in 14 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/07c112574a32

delete time in 14 days

PR opened apple/llvm-project

[lldb] Fix bug in fallback logic for finding the resource directory.

Both of the if-clauses modify the raw_path variable and only one of them was resetting the variable for the fallback. Avoid future bugs like that by always resetting the variable.

Differential revision: https://reviews.llvm.org/D88704

(cherry picked from commit 07c112574a324318a02ef29901a0d5aa1fd95144)

+2 -4

0 comment

1 changed file

pr created time in 14 days

create barnchJDevlieghere/llvm-project

branch : 🍒/bastille/07c112574a32

created branch time in 14 days

pull request commentapple/llvm-project

[llvm] Rename DwarfFile to DWARFFile to fix ODR violation (NFC)

@swift-ci please test macos

JDevlieghere

comment created time in 14 days

PR opened apple/llvm-project

[llvm] Rename DwarfFile to DWARFFile to fix ODR violation (NFC)

Rename the DwarfFile class in DWARFLinker to DWARFFile. This is consistent with the other DWARF classes and avoids a ODR violation with the DwarfFile class in AsmPrinter.

(cherry picked from commit a58b20e5a4fb64404cb62d2bb6a5e6dc40d22784)

+56 -56

0 comment

4 changed files

pr created time in 14 days

create barnchJDevlieghere/llvm-project

branch : 🍒/bastille/a58b20e5a4fb

created branch time in 14 days

delete branch JDevlieghere/llvm-project

delete branch : 🍒/bastille/f22496a9f4cabb97e735314b62731fedb2e01e50

delete time in 14 days

PR opened apple/llvm-project

[dotest] Simplify logic to find the Python path

Simplify the logic of parsing the lldb -P output to find the python path. This removes the special handling for the LLDB.framework case and instead of pattern matching known errors focus on finding a directory path that contains an init.py.

Differential revision: https://reviews.llvm.org/D88840

(cherry picked from commit f22496a9f4cabb97e735314b62731fedb2e01e50)

+30 -62

0 comment

1 changed file

pr created time in 14 days

PullRequestReviewEvent

delete branch JDevlieghere/llvm-project

delete branch : test_swift_compiler

delete time in 15 days

push eventllvm/llvm-project

Jonas Devlieghere

commit sha f22496a9f4cabb97e735314b62731fedb2e01e50

[dotest] Simplify logic to find the Python path Simplify the logic of parsing the lldb -P output to find the python path. This removes the special handling for the LLDB.framework case and instead of pattern matching known errors focus on finding a directory path that contains an __init__.py. Differential revision: https://reviews.llvm.org/D88840

view details

push time in 15 days

pull request commentapple/llvm-project

[lldb] Hoist --swift-compiler argument out of LLDB_TEST_COMMON_ARGS

@swift-ci please test

JDevlieghere

comment created time in 15 days

pull request commentapple/llvm-project

[lldb] Hoist --swift-compiler argument out of LLDB_TEST_COMMON_ARGS

@swift-ci please test

JDevlieghere

comment created time in 15 days

create barnchJDevlieghere/llvm-project

branch : test_swift_compiler

created branch time in 15 days

pull request commentapple/llvm-project

[lldb] Hoist --swift-compiler argument out of LLDB_TEST_COMMON_ARGS

@swift-ci please test

JDevlieghere

comment created time in 15 days

pull request commentapple/llvm-project

[lldb] Hoist --swift-compiler argument out of LLDB_TEST_COMMON_ARGS

@swift-ci please test

JDevlieghere

comment created time in 15 days

more