profile
viewpoint

pull request commentangular/angular

fix(compiler-cli): report error when a reference target is missing instead of crashing

Any idea when this fix will be included as part of an update as it's causing major problems trying to debug issues caused by reorganising our modules?

JoostK

comment created time in a few seconds

issue commentangular/angular

angular 10.x loadChild 不加载子模块组件的动态TemplateUrl

我使用asp.net core和angular配合开发,asp.net core提供了TagHelper服务器端标记,我的开发方式是在开发时期使用Angular JIT编译,动态请求TagHelper页面,同时会生成一份静态Html文件。 当我正式发布的时候,采用Angular AOT方式编译,直接访问生成的HTML。 这样可以达到开发时期的高效率,同时在发布时同样具备高性能。 在Angular 8.x,我通过修改@ngtools/webpack中的代码实现了这个功能,升级到Angular 10.x后,Angular代码有重大变化,并且我发现在根模块已经可以直接请求服务端页面,我花了大量精力跟踪调试angular代码,发现在执行platformBrowserDynamic().bootstrapModule(AppModule)时会调用resolveComponentResources请求服务端页面资源,但是采用loadChild延迟加载的子模块,却没有调用resolveComponentResources。 我不清楚这样的设计是一个BUG,还是什么原因导致的,希望Angular团队能够解决这个问题,这对于我的开发方式非常重要。

UtilCore

comment created time in 2 minutes

issue commentangular/angularfire

Angular Ivy 9.0 stable and angularfire RC1 using Firestore have trouble with Universal

All right, this issue has helped me: https://github.com/firebase/firebase-js-sdk/issues/3541

Apparently, you now need to also add @firebase/app to externalDependencies. I'm facing more issues but they see to be unrelated to this anymore.

hiepxanh

comment created time in 8 minutes

issue openedangular/angular

Expose more events from service worker update cycle

🚀 feature request

Relevant Package

This feature request is for @angular/service-worker

Description

We are currently experiencing an issue with a significant percentage of our users using outdated versions of our application. We're not really sure whether they're taking a very long time to update their applications or is it more of a problem with detection of the new version or something else. We don't have enough data to determine whether there is an issue with our service worker implementation, an issue with our application or maybe some edge case in the framework. Currently the service worker exposes only the available and activated events. This gives only a bit of an insight on how does the service worker perform updates on the client side.

Describe the solution you'd like

As mentioned before the service worker currently exposes only two events

  • a new version is available to be activated
  • a new version has been activated Ideally the service would expose some additional events like
  • a new version has been detected to exist (but is not available to use yet)
  • a new version starts downloading
  • a new version finishes downloading

This would allow us to track those events, figure out why is it that some users are taking very long time to get the new version and/or maybe optimise some parts of the flow.

created time in 10 minutes

issue commentangular/angular

angular 10.x loadChild 不加载子模块组件的动态TemplateUrl

在组件TemplateUrl上使用动态地址非常有用,并且在根模块上表现良好。 示例: @Component({ selector: 'app-root', templateUrl: environment.production ? './app.component.html' : 'view/app' }) export class AppComponent { } 在根组件设设置这样的动态URL完全没有问题,能正确加载。 但是如果在延迟加载的子模块中这样使用则无法解析,因为没有触发resolveComponentResources操作。

UtilCore

comment created time in 16 minutes

issue commentangular/angular

Add support for square, and curly brackets in ngClass

This seem extremely confusing for no reason and not that easy to implement. Why don't you simply use a function which returns the correct list of classes? In my opinion, HTML should not hold so much logic

Joshanity17

comment created time in 21 minutes

PR closed ionic-team/ionic-conference-app

tutorial-photos

Change of tutorial with new pictures.

+16979 -60

0 comment

9 changed files

tvarela7

pr closed time in 25 minutes

PR opened ionic-team/ionic-conference-app

tutorial-photos

Change of tutorial with new pictures.

+16979 -60

0 comment

9 changed files

pr created time in 26 minutes

pull request commentangular/angular

fix(animations): replace copy of query selector node-list from "spread" to "for"

Also there are still 2 commits in this PR. Can you squash them into one?

basherr

comment created time in an hour

pull request commentangular/angular

fix(animations): replace copy of query selector node-list from "spread" to "for"

@basherr - it is only the length of "each line" that must be under 120 chars I suspect that you put the whole body in a single line? Try splitting the body into multiple lines like in @AndrewKushnir's example.

basherr

comment created time in an hour

issue commentangular/angular

Extend docs for ng build

@alan-agius4 thanks

eLeontev

comment created time in an hour

pull request commentangular/angular

fix(animations): replace copy of query selector node-list from "spread" to "for"

@AndrewKushnir The build fails due to the commit message body being too long. What about the following only?

`fix(animations): replace copy of query selector node-list from "spread" to "for"

The spread syntax fails to copy a sufficiently large number of Nodelist due to callstack limit being reached. `

basherr

comment created time in an hour

pull request commentangular/angular

build(docs-infra): upgrade cli command docs sources to 70150e3f0

You can preview 23de072 at https://pr39839-23de072.ngbuilds.io/.

gkalpak

comment created time in an hour

issue commentangular/angular

[testing] valueChanges-Event of Control is not executed when dispatching Event for Input-Field

Same issue in Angular 9.1.6.

In my case i call the onChange() function in the custom form control. The (change) and (input) events on my <app-custom-input> are never called but if i use (ngModelChange) it works.

I dont really like this solution since i am now mixing ngModel attributes with the reactiveForm-version "formControlName".

Outside of the test everything is working as expected and it does not matter if i use (input), (change) or (ngModelChange) event on my <app-custom-input>.

choeller

comment created time in an hour

issue commentangular/angularfire

Error in complilation ERROR in node_modules/@angular/fire/firebase.app.module.d.ts:2:10 - error TS2614

though it gives some warning but it will solve the issue, try this npm install firebase@7.24.0 @angular/fire@6.0.3 --save

rogerbobbio

comment created time in an hour

issue commentangular/angular

NavigationExtras when returning URLTree from guard

Similar to other mentioned use cases, we would like to preserve the URL for error pages:

  • 403: Logged in, but is missing permission (should not occur by regular app usage). Manipulating URL or reloading page after permissions are revoked could trigger it. Show a generic ForbiddenComponent with error message (known by guard)
  • 404: For cases where a route matches (e.g. /user/:id), but a resource does not exist (or has been removed. A guard could be used to show a NotFound component

We also use a lot of redirects currently to populate query parameters. It would be great if it was possible to redirect and add missing parameters:

canActivate(route: ActivatedRouteSnapshot): boolean | UrlTree {
  if (route.params.page) return true;
  const queryParams = { page: '1' };
  const urlTree = this.router.createUrlTree(['.'], { relativeTo: route, queryParams });
  return { urlTree, preserveQueryParams: true, queryParamsHandling: 'merge' };
}

So basically, all options from NavigationExtras except relativeTo, queryParams, and fragment (since these are handled by router.createUrlTree) would be great to have IMO. 😀

Did you manage to come up with a solution to this issue? I am trying to implement the same 403 use case you mentioned. Thanks!

Airblader

comment created time in an hour

issue commentangular/components

bug/feature(sidenav) limited customization caused by 'mat-drawer-inner-container' element

Tente esta solução temporária. Isso funcionou para mim:

::ng-deep .mat-drawer-inner-container {
     overflow: visible!important;
}

:: ng-deep was the way I found to change the material's native classes as well.

IlCallo

comment created time in an hour

PR opened angular/angular

build(docs-infra): upgrade cli command docs sources to 70150e3f0

Updating angular#master from cli-builds#master.

Relevant changes in commit range:

Modified

  • help/build.json
  • help/deploy.json
  • help/e2e.json
  • help/extract-i18n.json
  • help/run.json
  • help/serve.json
  • help/test.json
+1 -1

0 comment

1 changed file

pr created time in an hour

pull request commentangular/angular-cli

Fix alphabetize imports

Updated the PR to master, all ci checks pass. I only don't know how to add the PR target label to this PR. Anyone an idea?

timfrijtersppw

comment created time in an hour

issue openedangular/angular

"Component inside a test host" issue with ngc & Ivy

<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅

Oh hi there! 😄

To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates.

🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->

🐞 bug report

Affected Package

<!-- ✍️edit: --> The issue is caused by ngc

Is this a regression?

<!-- Did this behavior use to work in the previous version? --> <!-- ✍️--> Yes, the previous version in which this bug was not present was: non-Ivy

Description

<!-- ✍️--> Testing a component inside a test host, according to: https://angular.io/guide/testing-components-scenarios#component-inside-a-test-host

ngc throws error (but only when Ivy is enabled).

But everything else works just fine (test, build, serve).

Disable Ivy in tsconfig.json, re-run ngc and it will pass successfully.

This problem is also valid for previous Angular 10.

🔬 Minimal Reproduction

https://github.com/wojciechpolak/ng11-test-host-problem

🔥 Exception or Error

<pre>$ npx ngc src/app/foobar/foobar.component.spec.ts:12:14 - error NG8001: 'app-foobar' is not a known element:

  1. If 'app-foobar' is an Angular component, then verify that it is part of this module.
  2. If 'app-foobar' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.

12 template: &lt;app-foobar [abc]="'xyz'">&lt;/app-foobar> ~~~~~~~~~~~~~~~~~~~~~~~~~~ src/app/foobar/foobar.component.spec.ts:12:26 - error NG8002: Can't bind to 'abc' since it isn't a known property of 'app-foobar'.

  1. If 'app-foobar' is an Angular component and it has 'abc' input, then verify that it is part of this module.
  2. If 'app-foobar' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.
  3. To allow any property add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component.

12 template: &lt;app-foobar [abc]="'xyz'">&lt;/app-foobar> ~~~~~~~~~~~~~ </pre>

🌍 Your Environment

Angular Version: <pre><code>$ ng version

Angular CLI: 11.0.2 Node: 14.15.1 OS: linux x64

Angular: 11.0.2 ... animations, cli, common, compiler, compiler-cli, core, forms ... platform-browser, platform-browser-dynamic, router Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.1100.2 @angular-devkit/build-angular 0.1100.2 @angular-devkit/core 11.0.2 @angular-devkit/schematics 11.0.2 @schematics/angular 11.0.2 @schematics/update 0.1100.2 rxjs 6.6.3 typescript 4.0.5 </code></pre>

Anything else relevant?

Run ng test to execute the unit tests. This should pass successfully with or without Ivy. However, ngc fails with Ivy.

created time in an hour

delete branch ionic-team/ionic-conference-app

delete branch : dependabot/npm_and_yarn/types/node-14.14.9

delete time in an hour

PR closed ionic-team/ionic-conference-app

chore(deps-dev): bump @types/node from 12.12.28 to 14.14.9 dependencies

Bumps @types/node from 12.12.28 to 14.14.9. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

1 comment

2 changed files

dependabot-preview[bot]

pr closed time in an hour

PR opened ionic-team/ionic-conference-app

chore(deps-dev): bump @types/node from 12.12.28 to 14.14.10

Bumps @types/node from 12.12.28 to 14.14.10. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

0 comment

2 changed files

pr created time in an hour

issue commentangular/components

feat(mat-selection-list): Toggle on different event that 'click'

@crisbeto @mmalerba May I ask you for your view on this? Have I overlooked something? I can make the PR, this looks easy enough...

Akxe

comment created time in an hour

issue commentangular/angular-cli

Angular.json's fileReplacements no longer accept .html replacements in Angular 11

@dougamos, file replacements on html didn't work since Angular version 9.

I use fileReplacements for several HTML files with angular 10.2.0 currently, which does work. This change prevents me from updating.

Is there another way to exchange template Files for components?

ChristopherHoffman

comment created time in 2 hours

issue commentangular/angularfire

Angular Ivy 9.0 stable and angularfire RC1 using Firestore have trouble with Universal

@jdgamble555 I did update it this way in my login component, so I can call new firebase.auth.GoogleAuthProvider() but for Firestore I only have this in my main module:

import 'firebase/firestore';

Do I need to change it somehow?

@mazlano27 If I do that I'm getting this error when I open route that uses firestore:

[2020-11-25T09:48:03.294Z]  @firebase/firestore: Firestore (8.0.2): INTERNAL UNHANDLED ERROR:  Error: ENOENT: no such file or directory, open 'XXX\server\src\protos\google\firestore\v1\firestore.proto'
hiepxanh

comment created time in 2 hours

Pull request review commentangular/angular-cli

test(@ngtools/webpack): update rebuild E2E with component resource changes

+/**+ * @license+ * Copyright Google Inc. All Rights Reserved.+ *+ * Use of this source code is governed by an MIT-style license that can be+ * found in the LICENSE file at https://angular.io/license+ */+import * as nodePath from 'path';++const normalizationCache = new Map<string, string>();++export function normalizePath(path: string): string {+  let result = normalizationCache.get(path);++  if (result === undefined) {+    result = nodePath.win32.normalize(path).replace(/\\/g, nodePath.posix.sep);

Why not just path.normalize for posix systems?

clydin

comment created time in 2 hours

created tagangular/schematics-update-builds

tag33bd8b717

Build artifacts for @schematics/update

created time in 2 hours

more