profile
viewpoint
Guillaume Gomez GuillaumeGomez Paris https://blog.guillaume-gomez.fr Opensource lover. Rustdoc team leader, member of the rust language tool, documentation and docs.rs teams, GNOME foundation member.

gtk-rs/gtk4 52

GTK 4 bindings and wrappers for Rust (Development)

gtk-rs/webkit2gtk-rs 39

WebKit2 bindings and wrappers for Rust

gtk-rs/gtk-test 21

Testing GTK UI

gtk-rs/sourceview 17

sourceview binding for Rust

gtk-rs/javascriptcore-rs 12

JavaScriptCore bindings and wrappers for Rust

gtk-rs/examples4 10

GTK 4 Rust examples (development)

gtk-rs/pangocairo 7

Bindings for the pangocairo library

gtk-rs/gdk4 6

GDK 4 bindings and wrappers for Rust (Development)

gtk-rs/atk 5

Atk binding in rust

GuillaumeGomez/ban-ssh-ips 5

Little script to read failed auths and ban their IPs

pull request commentrust-lang/rust

Link to corresponding sections for enum variants in rustdoc

This is a good argument.

RDambrosio016

comment created time in a few seconds

pull request commentrust-lang/rust

Link to corresponding sections for enum variants in rustdoc

Which types in codeblocks already have links?

Also, I said I don't like it but if people are in favor, then we'll merge it, don't worry. ;)

RDambrosio016

comment created time in 7 minutes

pull request commentrust-lang/rust

Link to corresponding sections for enum variants in rustdoc

You already have all the links in the sidebar.

RDambrosio016

comment created time in 17 minutes

pull request commentrust-lang/rust

Link to corresponding sections for enum variants in rustdoc

I'm not a big fan of adding link in code blocks nor adding extra colors to the fields description (I don't mind adding colors in the type code block though).

RDambrosio016

comment created time in an hour

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0745

delete time in an hour

pull request commentrust-lang/rust

Fix intra-doc links for cross-crate re-exports of traits

error: cannot find a built-in macro with name `cfg`

A strange error...

jyn514

comment created time in an hour

pull request commentrust-lang/rust

Clean up E0745

@bors: r=pickfire rollup

GuillaumeGomez

comment created time in 18 hours

delete branch GuillaumeGomez/rust

delete branch : true-false-intra-doc-link

delete time in 20 hours

issue commentrust-lang/rust

`--message-format json` doesn't apply to rustdoc coverage output

--message-format isn't the option you're looking for. You want --output-format json.

Nemo157

comment created time in a day

push eventGuillaumeGomez/docs.rs

Guillaume Gomez

commit sha cbfd1972fbde84d756e780e2def85a30f9a4df66

Fix button color for theme picker

view details

Chase Wilson

commit sha 60e7a188f465427b241e42c0d83d825bc9653a95

Added the groundwork for tera

view details

Chase Wilson

commit sha 7b39e474bec21b2c7f6cf549f3da5b2a20a744fc

fixup! Added the groundwork for tera

view details

Chase Wilson

commit sha 3d469fe65ff2c196468cf8cc1039a94675f07ad0

Code review

view details

Chase Wilson

commit sha 1fbcc19a626820adca8e23b1034e08cdd6391123

Added tera-templates dir and made watching good

view details

Chase Wilson

commit sha c869379bf15d611e264d37e142559d651ee9820b

Comment on updater

view details

Chase Wilson

commit sha bdaf33b822247a428e11da64bc17e5699363b22b

Mostly switch to chrono (#781) Most of the stuff can be switched to chrono, but iron-related timeouts require time and won't be able to be removed until iron is.

view details

Chase Wilson

commit sha 10a44bca0a55067e9a76436d1355078ee48e1e56

Updated async dependencies

view details

Joshua Nelson

commit sha 60d73881079159e484096e32e5b0bbbd2b36e658

Revert "Updated async dependencies" This reverts commit 10a44bca0a55067e9a76436d1355078ee48e1e56.

view details

Wim Looman

commit sha e18c9406b13f7f9f1ecc1d43b3d6418a6a6e6146

Add testing of migration downgrades

view details

Chase Wilson

commit sha 3785c7a016963a64a35c5b263619743b8a277f68

Updated Reqwest

view details

Pietro Albini

commit sha 38ce89b2bb6b30d053e55d41938c7f6cb49e6dfe

Revert "Updated Reqwest" This reverts commit 3785c7a016963a64a35c5b263619743b8a277f68.

view details

Joshua Nelson

commit sha d8495cab96186f27ae7a08b8429df242c334dd7f

Print a backtrace for crates which fail to build

view details

Pietro Albini

commit sha 4e761421be20981012b1896af5fcb813972fbe5b

Merge pull request #823 from jyn514/backtrace Print a backtrace for crates which fail to build

view details

Wim Looman

commit sha a6b8db1cc4c7a0a28aa0d9158389b1cd22f16768

Set application specific user agent for crates.io

view details

Mark Rousskov

commit sha 2edd72e2ad317ff8725db1dfe303cb8bc4918255

Migrate to kuchiki

view details

Pietro Albini

commit sha a9794cd389e938d50acfa87dd1527680d6f9cdbb

Merge pull request #819 from Nemo157/set-user-agent Set application specific user agent for crates.io

view details

Chase Wilson

commit sha b58f2daef60f16aa9102f60a334389a72d250166

Updated Reqwest

view details

Joshua Nelson

commit sha 07f7247a3a335efeac4e81c71fb851ae16e6a70e

Add compression for uploaded documentation

view details

Joshua Nelson

commit sha 6ee2d369cb0a37951ea39d1fe97ecd55f800e827

Remove commented-out code

view details

push time in a day

PR opened rust-lang/rust

Clean up E0745

r? @Dylan-DPC

+7 -4

0 comment

1 changed file

pr created time in a day

create barnchGuillaumeGomez/rust

branch : cleanup-e0745

created branch time in a day

pull request commentrust-lang/rust

Remove log alias from librustdoc

Could you please add the link to the PR who made this change originally please? (Maybe @jyn514 has it?)

r=me once CI pass

pickfire

comment created time in a day

push eventGuillaumeGomez/rust

flip1995

commit sha f7acea2683c6124854bfe20e7127e4dfba344d3e

Register redundant_field_names and non_expressive_names as early passes

view details

flip1995

commit sha 485229c4a3d6a2fbe40f5a6976a33144a27497c6

Fix fallout in redundant_field_names

view details

flip1995

commit sha efd3dcff97f67f376e354c047133ce9044c52991

Fix fallout in similar_names

view details

Eduardo Broto

commit sha bb37a0f948b02e6434dbe3ea615960052d37f784

Avoid triggering similar names on code from expansion

view details

Alexis Bourget

commit sha 2853448426ce76926baa7e6e6173c15228e4951a

Document the ref keyword

view details

Stefan Lankes

commit sha 6813c1c69baf870a479c70e23ad0550d1d9aa9be

revise RwLock, which is derived from the wasm implementation - increasing the readability of `Condvar` - simplify the interface to the libos HermitCore

view details

Stefan Lankes

commit sha 3acc3ef10d2099a4b3118e8c705b36f4bbaf6f64

minor changes to pass the format check

view details

Stefan Lankes

commit sha beb1b1fa5b1047c7caf8a1d499725df3c1ad8cad

reorder crates to pass the format check

view details

Stefan Lankes

commit sha f9c609164251abc136eb9bda55c92cb99adb5c86

remove some compiler warnings

view details

Trevor Spiteri

commit sha 6dfe144bdd4413ac55cbb2ad2edfb1daa0c4bf15

stabilize const_nonzero_int_methods

view details

Trevor Spiteri

commit sha 9739b512a892628534e730ffcd9756b3218c8de8

stabilize some const_checked_int_methods

view details

Trevor Spiteri

commit sha c1c674c2dbfe3f6dc47d11368c1b5ee4ab008799

stabilize const_saturating_int_methods

view details

Trevor Spiteri

commit sha 056d925167318636fcf975c8ffb81efebdc9bca3

stabilize const_int_sign

view details

Trevor Spiteri

commit sha 2a84e313df095fd0e81b9348b68bd9b1d1caa551

stabilize const_ascii_ctype_on_intrinsics

view details

Adam Perry

commit sha d275739c09f266479d6db388cbf55ba6ca791b9d

Derive common traits for panic::Location. Add documentation about the host/target behavior of Location::file.

view details

Alexis Bourget

commit sha 837a761b398a6ff6a97f7f61e390dae9efbeab79

Document the where keyword

view details

Andrey Zgarbul

commit sha 7d4a92d4f8dc03409984695d78893fffdd3ff1f9

remove LengthAtMost32 on AsRef/Borrow impl for array

view details

Roman Proskuryakov

commit sha eff62069ad602090e8d27b83cffd9e77479ed4be

Remove the usage of the LengthAtMost32 trait

view details

Roman Proskuryakov

commit sha 4ad40a8737ab4ffaf6352ec4560fd86cb0b4ade8

Remove LengthAtMost32

view details

Roman Proskuryakov

commit sha 44dd95e4d008e9edc112dc1a599eac028889e015

Fix copypaste in test into-iter-impls-length-33 (const generic 32 -> 33)

view details

push time in a day

Pull request review commentrust-lang/rust

Doc alias checks: ensure only items appearing in search index can use it

+#![feature(doc_alias)]++pub struct Bar;+pub trait Foo {+    type X;+    fn foo() -> Self::X;+}++#[doc(alias = "foo")] //~ ERROR+extern {}++#[doc(alias = "bar")] //~ ERROR+impl Bar {+    #[doc(alias = "const")] //~ ERROR+    const A: u32 = 0;+}++#[doc(alias = "foobar")] //~ ERROR+impl Foo for Bar {+    #[doc(alias = "assoc")] //~ ERROR+    type X = i32;

Nevermind, the only result returned is Foo::X. So it should be an error.

GuillaumeGomez

comment created time in a day

Pull request review commentrust-lang/rust

Doc alias checks: ensure only items appearing in search index can use it

+#![feature(doc_alias)]++pub struct Bar;+pub trait Foo {+    type X;+    fn foo() -> Self::X;+}++#[doc(alias = "foo")] //~ ERROR+extern {}++#[doc(alias = "bar")] //~ ERROR+impl Bar {+    #[doc(alias = "const")] //~ ERROR

However this one doesn't appear in the search.

GuillaumeGomez

comment created time in a day

Pull request review commentrust-lang/rust

Doc alias checks: ensure only items appearing in search index can use it

+#![feature(doc_alias)]++pub struct Bar;+pub trait Foo {+    type X;+    fn foo() -> Self::X;+}++#[doc(alias = "foo")] //~ ERROR+extern {}++#[doc(alias = "bar")] //~ ERROR+impl Bar {+    #[doc(alias = "const")] //~ ERROR+    const A: u32 = 0;+}++#[doc(alias = "foobar")] //~ ERROR+impl Foo for Bar {+    #[doc(alias = "assoc")] //~ ERROR+    type X = i32;

Actually this one shouldn't be an error too, it appears in the doc search.

GuillaumeGomez

comment created time in a day

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

I don't have strong feelings here so we can close it if everyone agrees?

GuillaumeGomez

comment created time in a day

issue commentrust-lang/rust

rustdoc shows anonymous elided lifetimes in async fn signature

I think it's the expected behaviour. However we can discuss about removing the elided lifetimes. In this case it's not really useful...

basdebue

comment created time in a day

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

I expect people to use them as soon as the intra-doc links hit stable. For the exact numbers, we'll have to wait for some time.

GuillaumeGomez

comment created time in 2 days

issue commentGuillaumeGomez/sysinfo

Gives negative temperature for CPU

I agree on adding these two if you insist. ;) (You can open a PR with them if you want, please add a comment explaining the temperature of which component they are and that should be good.)

I'll try to check the sp78 conversion in the next days.

mouse07410

comment created time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

Oh I see, well, we can talk about it at a later time if enough people are interested. But currently, not very convinced.

GuillaumeGomez

comment created time in 2 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 53e0357d046bc4c2b6b1337989e4e53784832866

Link to bool primitive type if "true" or "false" is used

view details

Guillaume Gomez

commit sha 66d998f4f2a9218239a5b624272a624441aba844

Add test for true/false intra-doc link

view details

push time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

Updated!

GuillaumeGomez

comment created time in 2 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 21b5ef566685201515428294a655d7ddf8e65f53

Link to bool primitive type if "true" or "false" is used

view details

Guillaume Gomez

commit sha 4d2a53f3ac065da0ff6c0ca3695d2429e3e146b0

Add test for true/false intra-doc link

view details

push time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

Yes we agree, only keywords for true and false. ;)

GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

Honestly I'm not sure it's worth it so let's just keep it simple. I'll update to link to the keyword pages though.

GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Doc alias checks: ensure only items appearing in search index can use it

You can provide one as well if you want. But it was more like a reminder for the actual reviewers. :)

GuillaumeGomez

comment created time in 2 days

Pull request review commentrust-lang/rust

Add support for "true"/"false" intra doc link

+#![deny(broken_intra_doc_links)]+#![crate_name = "foo"]++// ignore-tidy-linelength++// @has foo/index.html+// @has - '//*[@id="main"]//a[@href="https://doc.rust-lang.org/nightly/std/primitive.bool.html"]' 'true'+// @has - '//*[@id="main"]//a[@href="https://doc.rust-lang.org/nightly/std/primitive.bool.html"]' 'false'++//! A `bool` is either [`true`] or [`false`].

It's already tested somewhere else, like all primitive types that we support.

GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

Ok, I'll update the PR with this change.

GuillaumeGomez

comment created time in 2 days

issue commentgtk-rs/gtk

Possible bug with simultaneous work "gtk-rs" and "xlsxwriter-rs" crates

@dgr113 If it doesn't need to be in the same process, you can just spawn another one which will run the excel export.

dgr113

comment created time in 2 days

issue commentgtk-rs/gtk

Possible bug with simultaneous work "gtk-rs" and "xlsxwriter-rs" crates

Welcome to the C world, where non-related codes might collide because of dark magic.

dgr113

comment created time in 2 days

issue commentGuillaumeGomez/sysinfo

Gives negative temperature for CPU

But, frankly, I see no harm in including more. If they're there - why not showing them? And if they're not present - that's fine too.

Problem being that it's not official so it's very likely to break at every macOS update (which is incredibly frustrating). So that'd mean support multiple versions of the OS, which I really can't afford considering I maintain this only on my free time. :-/

mouse07410

comment created time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

Oh I see, we had two different things in mind. Then we could try to do this based on the doc aliases directly, don't you think? Or should we keep a list based on the official keywords and only link using those? The second solution would allow a much simpler fix.

GuillaumeGomez

comment created time in 2 days

issue commentrust-lang/rust

async-std docs no longer build on recent nightlies

I think it might be interesting to ask the compiler team before doing anything in here. They might have a solution we didn't think about. :)

yoshuawuyts

comment created time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

CI failure:

warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/autocfg/1.0.0/download`, got 504
error: failed to download from `https://crates.io/api/v1/crates/libc/0.2.74/download`
GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Add support for "true"/"false" intra doc link

keyword != primitive. In here we use values which are in fact of primitive type. enum, union and trait aren't. Or maybe I missed your point?

GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Doc alias checks: ensure only items appearing in search index can use it

ping @rust-lang/rustdoc

GuillaumeGomez

comment created time in 2 days

pull request commentrust-lang/rust

Don't run `everybody_loops` for rustdoc; instead ignore resolution errors

I'm more in favor of writing a specific pass rather than reverting this, too much benefits came from it and we're getting so close to have the intra-doc links stable! (I'm really excited about this feature!)

jyn514

comment created time in 2 days

PR opened rust-lang/rust

Add support for "true"/"false" intra doc link

Part of https://github.com/rust-lang/rust/issues/74515.

Explanations of what I did here: instead of checking more globally in primitive types, I think that only true and false values should be transformed into a link to bool. Others are either numbers or strings and I don't think we want to link all of them "generally". So in here, in case true and false didn't match anything (maybe a module was here, we don't know?), we then link them to the bool type.

r? @jyn514

cc @rust-lang/rustdoc

+42 -22

0 comment

2 changed files

pr created time in 2 days

create barnchGuillaumeGomez/rust

branch : true-false-intra-doc-link

created branch time in 2 days

issue commentrust-lang/rust

Intra-doc links do not resolve for value keywords

I think that "true" and "false" are the two only cases for primitives where we should check for values.

jyn514

comment created time in 2 days

pull request commentrust-lang/rust

Disable stylesheet objects rather than link elements

Yes, on that point we agree. Thanks for the precision!

Cldfire

comment created time in 2 days

pull request commentrust-lang/rust

Disable stylesheet objects rather than link elements

@Manishearth This is what we do currently but this PR, unless I'm missing something, is removing this mechanism and the disable is added by the JS, not by rustdoc.

Cldfire

comment created time in 2 days

issue commentGuillaumeGomez/sysinfo

Gives negative temperature for CPU

The problem here is that it is possible that the values are negative. I need to check the conversion from sp78 but I'm pretty sure it's valid and that the only issue here is the system providing incorrect values... Also, you provided a lot of values, not sure we want that many since most of them seem not very useful...

mouse07410

comment created time in 2 days

pull request commentrust-lang/rust

Disable stylesheet objects rather than link elements

maybe we could load the theme preference from local storage before loading the CSS?

Isn't it already what we do?

Cldfire

comment created time in 3 days

pull request commentrust-lang/rust

Disable stylesheet objects rather than link elements

This is a good point. Only way would be to just compare I guess. Also, what do you @rust-lang/rustdoc ?

Cldfire

comment created time in 3 days

pull request commentrust-lang/rust

Disable stylesheet objects rather than link elements

On slowest computers, it's gonna be an issue for sure: the browser will have to parse and render multiple styles at once. Definitely not optimal...

Cldfire

comment created time in 3 days

Pull request review commentrust-lang/rust

Disable stylesheet objects rather than link elements

 function getCurrentValue(name) {     return null; } -function switchTheme(styleElem, mainStyleElem, newTheme, saveTheme) {-    var fullBasicCss = "rustdoc" + resourcesSuffix + ".css";-    var fullNewTheme = newTheme + resourcesSuffix + ".css";-    var newHref = mainStyleElem.href.replace(fullBasicCss, fullNewTheme);--    if (styleElem.href === newHref) {-        return;-    }+function switchTheme(newTheme, saveTheme) {+    // The theme file we are switching to+    var newThemeFile = newTheme + resourcesSuffix + ".css";      var found = false;     if (savedHref.length === 0) {         onEachLazy(document.getElementsByTagName("link"), function(el) {             savedHref.push(el.href);         });     }-    onEach(savedHref, function(el) {-        if (el === newHref) {+    onEach(savedHref, function(href) {+        if (href.endsWith(newThemeFile)) {             found = true;             return true;         }     });     if (found === true) {-        styleElem.href = newHref;+        onEach(allThemeNames, function(themeName) {+            // The theme file for this theme name+            var themeFile = themeName + resourcesSuffix + ".css";+            var themeSheet = document.querySelector("[href$='" + themeFile + "']");++            if (themeName === newTheme) {+                themeSheet.disabled = false;+            } else {+                themeSheet.disabled = true;+            }
themeSheet.disabled = themeName !== newTheme;
Cldfire

comment created time in 3 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0733

delete time in 3 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0744

delete time in 3 days

pull request commentrust-lang/rust

Clean up E0744 explanation

@bors: r=pickfire rollup

GuillaumeGomez

comment created time in 3 days

PR opened rust-lang/rust

Clean up E0744 explanation

r? @Dylan-DPC

+5 -3

0 comment

1 changed file

pr created time in 3 days

create barnchGuillaumeGomez/rust

branch : cleanup-e0744

created branch time in 3 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 507f403f952501d9c2c819c5306c0ee4af3183bd

Clean up E0733 explanation

view details

push time in 3 days

pull request commentrust-lang/rust

Clean up E0733 explanation

@jyn514 I assume that it's because of the stack but honestly, I'm not really sure.

GuillaumeGomez

comment created time in 3 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0728

delete time in 3 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0743

delete time in 4 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0741

delete time in 4 days

pull request commentrust-lang/rust

Doc alias checks: ensure only items appearing in search index can use it

Updated! I added the equivalent tests both in test/rustdoc-ui and in test/ui to be sure that the pass is run in rustdoc. I also moved the checks in rustc directly.

GuillaumeGomez

comment created time in 4 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha c0bb98d62ba9c17a695c37841d07092deed350eb

Move #[doc(alias)] attribute checks in rustc

view details

push time in 4 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 17b2e1dbddfabf3e55bfbd2c456cbb8f65885aaf

Move #[doc(alias)] attribute checks in rustc

view details

push time in 4 days

pull request commentrust-lang/rust

Clean up E0743 explanation

@bors: r=pickfire rollup

GuillaumeGomez

comment created time in 4 days

push eventGuillaumeGomez/rust

flip1995

commit sha f7acea2683c6124854bfe20e7127e4dfba344d3e

Register redundant_field_names and non_expressive_names as early passes

view details

flip1995

commit sha 485229c4a3d6a2fbe40f5a6976a33144a27497c6

Fix fallout in redundant_field_names

view details

flip1995

commit sha efd3dcff97f67f376e354c047133ce9044c52991

Fix fallout in similar_names

view details

Eduardo Broto

commit sha bb37a0f948b02e6434dbe3ea615960052d37f784

Avoid triggering similar names on code from expansion

view details

Alexis Bourget

commit sha 2853448426ce76926baa7e6e6173c15228e4951a

Document the ref keyword

view details

Stefan Lankes

commit sha 6813c1c69baf870a479c70e23ad0550d1d9aa9be

revise RwLock, which is derived from the wasm implementation - increasing the readability of `Condvar` - simplify the interface to the libos HermitCore

view details

Stefan Lankes

commit sha 3acc3ef10d2099a4b3118e8c705b36f4bbaf6f64

minor changes to pass the format check

view details

Stefan Lankes

commit sha beb1b1fa5b1047c7caf8a1d499725df3c1ad8cad

reorder crates to pass the format check

view details

Stefan Lankes

commit sha f9c609164251abc136eb9bda55c92cb99adb5c86

remove some compiler warnings

view details

Trevor Spiteri

commit sha 6dfe144bdd4413ac55cbb2ad2edfb1daa0c4bf15

stabilize const_nonzero_int_methods

view details

Trevor Spiteri

commit sha 9739b512a892628534e730ffcd9756b3218c8de8

stabilize some const_checked_int_methods

view details

Trevor Spiteri

commit sha c1c674c2dbfe3f6dc47d11368c1b5ee4ab008799

stabilize const_saturating_int_methods

view details

Trevor Spiteri

commit sha 056d925167318636fcf975c8ffb81efebdc9bca3

stabilize const_int_sign

view details

Trevor Spiteri

commit sha 2a84e313df095fd0e81b9348b68bd9b1d1caa551

stabilize const_ascii_ctype_on_intrinsics

view details

Adam Perry

commit sha d275739c09f266479d6db388cbf55ba6ca791b9d

Derive common traits for panic::Location. Add documentation about the host/target behavior of Location::file.

view details

Alexis Bourget

commit sha 837a761b398a6ff6a97f7f61e390dae9efbeab79

Document the where keyword

view details

Andrey Zgarbul

commit sha 7d4a92d4f8dc03409984695d78893fffdd3ff1f9

remove LengthAtMost32 on AsRef/Borrow impl for array

view details

Roman Proskuryakov

commit sha eff62069ad602090e8d27b83cffd9e77479ed4be

Remove the usage of the LengthAtMost32 trait

view details

Roman Proskuryakov

commit sha 4ad40a8737ab4ffaf6352ec4560fd86cb0b4ade8

Remove LengthAtMost32

view details

Roman Proskuryakov

commit sha 44dd95e4d008e9edc112dc1a599eac028889e015

Fix copypaste in test into-iter-impls-length-33 (const generic 32 -> 33)

view details

push time in 4 days

pull request commentrust-lang/rust

Clean up E0741 error explanation

@bors: r=pickfire rollup

GuillaumeGomez

comment created time in 4 days

issue commentGuillaumeGomez/sysinfo

Gives negative temperature for CPU

I re-checked on my macbook pro and the value is as expected... So I really don't know about this. The biggest issue here being that it's not something official, so maybe the value is fucked up in your mac because the key isn't valid anymore. It's very hard to know unfortunately... :-/

mouse07410

comment created time in 4 days

Pull request review commentrust-lang/rust

Clean up E0741 error explanation

 struct A; struct B<const X: A>; // error! ``` -To fix this example, we derive `PartialEq` and `Eq`.+Only structural-match types (that is, types that derive `PartialEq` and `Eq`)+may be used as the types of const generic parameters.

I *think* the current wording is correct. It's actually hard to phrase it haha.

GuillaumeGomez

comment created time in 4 days

PR opened rust-lang/rust

Clean up E0743 explanation

r? @Dylan-DPC

+5 -6

0 comment

1 changed file

pr created time in 4 days

create barnchGuillaumeGomez/rust

branch : cleanup-e0743

created branch time in 4 days

push eventGuillaumeGomez/rust

flip1995

commit sha f7acea2683c6124854bfe20e7127e4dfba344d3e

Register redundant_field_names and non_expressive_names as early passes

view details

flip1995

commit sha 485229c4a3d6a2fbe40f5a6976a33144a27497c6

Fix fallout in redundant_field_names

view details

flip1995

commit sha efd3dcff97f67f376e354c047133ce9044c52991

Fix fallout in similar_names

view details

Eduardo Broto

commit sha bb37a0f948b02e6434dbe3ea615960052d37f784

Avoid triggering similar names on code from expansion

view details

Alexis Bourget

commit sha 2853448426ce76926baa7e6e6173c15228e4951a

Document the ref keyword

view details

Stefan Lankes

commit sha 6813c1c69baf870a479c70e23ad0550d1d9aa9be

revise RwLock, which is derived from the wasm implementation - increasing the readability of `Condvar` - simplify the interface to the libos HermitCore

view details

Stefan Lankes

commit sha 3acc3ef10d2099a4b3118e8c705b36f4bbaf6f64

minor changes to pass the format check

view details

Stefan Lankes

commit sha beb1b1fa5b1047c7caf8a1d499725df3c1ad8cad

reorder crates to pass the format check

view details

Stefan Lankes

commit sha f9c609164251abc136eb9bda55c92cb99adb5c86

remove some compiler warnings

view details

Trevor Spiteri

commit sha 6dfe144bdd4413ac55cbb2ad2edfb1daa0c4bf15

stabilize const_nonzero_int_methods

view details

Trevor Spiteri

commit sha 9739b512a892628534e730ffcd9756b3218c8de8

stabilize some const_checked_int_methods

view details

Trevor Spiteri

commit sha c1c674c2dbfe3f6dc47d11368c1b5ee4ab008799

stabilize const_saturating_int_methods

view details

Trevor Spiteri

commit sha 056d925167318636fcf975c8ffb81efebdc9bca3

stabilize const_int_sign

view details

Trevor Spiteri

commit sha 2a84e313df095fd0e81b9348b68bd9b1d1caa551

stabilize const_ascii_ctype_on_intrinsics

view details

Adam Perry

commit sha d275739c09f266479d6db388cbf55ba6ca791b9d

Derive common traits for panic::Location. Add documentation about the host/target behavior of Location::file.

view details

Alexis Bourget

commit sha 837a761b398a6ff6a97f7f61e390dae9efbeab79

Document the where keyword

view details

Andrey Zgarbul

commit sha 7d4a92d4f8dc03409984695d78893fffdd3ff1f9

remove LengthAtMost32 on AsRef/Borrow impl for array

view details

Roman Proskuryakov

commit sha eff62069ad602090e8d27b83cffd9e77479ed4be

Remove the usage of the LengthAtMost32 trait

view details

Roman Proskuryakov

commit sha 4ad40a8737ab4ffaf6352ec4560fd86cb0b4ade8

Remove LengthAtMost32

view details

Roman Proskuryakov

commit sha 44dd95e4d008e9edc112dc1a599eac028889e015

Fix copypaste in test into-iter-impls-length-33 (const generic 32 -> 33)

view details

push time in 4 days

pull request commentrust-lang/rust

fix rustdoc generic param order

Looks good to me! It even simplifies the code so that's great. 👍

@bors: r+

lcnr

comment created time in 4 days

issue commentGuillaumeGomez/sysinfo

Gives negative temperature for CPU

You can specifiy a specific version using crate = "=0.13.11" iirc. I wonder what's going on with your sensors though. XD

mouse07410

comment created time in 4 days

pull request commentrust-lang/rust

Fix primitive retrieval in search index generation

I'm completely unable to understand why caching the primitive sooner prevents rustdoc to find primitive types implementations, meaning that for example, it cannot find f32::is_nan. If anyone has an idea...

GuillaumeGomez

comment created time in 4 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 374f9b5c392078c68cafd12530d27564b63c7286

Move primitive_locations build before the crate.clean

view details

push time in 4 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 81cfe2e076197ce9383f4d4028db72c5d2ad8f03

Move primitive_locations build before the crate.clean

view details

push time in 5 days

push eventGuillaumeGomez/rust

flip1995

commit sha f7acea2683c6124854bfe20e7127e4dfba344d3e

Register redundant_field_names and non_expressive_names as early passes

view details

flip1995

commit sha 485229c4a3d6a2fbe40f5a6976a33144a27497c6

Fix fallout in redundant_field_names

view details

flip1995

commit sha efd3dcff97f67f376e354c047133ce9044c52991

Fix fallout in similar_names

view details

Eduardo Broto

commit sha bb37a0f948b02e6434dbe3ea615960052d37f784

Avoid triggering similar names on code from expansion

view details

Alexis Bourget

commit sha 2853448426ce76926baa7e6e6173c15228e4951a

Document the ref keyword

view details

Stefan Lankes

commit sha 6813c1c69baf870a479c70e23ad0550d1d9aa9be

revise RwLock, which is derived from the wasm implementation - increasing the readability of `Condvar` - simplify the interface to the libos HermitCore

view details

Stefan Lankes

commit sha 3acc3ef10d2099a4b3118e8c705b36f4bbaf6f64

minor changes to pass the format check

view details

Stefan Lankes

commit sha beb1b1fa5b1047c7caf8a1d499725df3c1ad8cad

reorder crates to pass the format check

view details

Stefan Lankes

commit sha f9c609164251abc136eb9bda55c92cb99adb5c86

remove some compiler warnings

view details

Trevor Spiteri

commit sha 6dfe144bdd4413ac55cbb2ad2edfb1daa0c4bf15

stabilize const_nonzero_int_methods

view details

Trevor Spiteri

commit sha 9739b512a892628534e730ffcd9756b3218c8de8

stabilize some const_checked_int_methods

view details

Trevor Spiteri

commit sha c1c674c2dbfe3f6dc47d11368c1b5ee4ab008799

stabilize const_saturating_int_methods

view details

Trevor Spiteri

commit sha 056d925167318636fcf975c8ffb81efebdc9bca3

stabilize const_int_sign

view details

Trevor Spiteri

commit sha 2a84e313df095fd0e81b9348b68bd9b1d1caa551

stabilize const_ascii_ctype_on_intrinsics

view details

Adam Perry

commit sha d275739c09f266479d6db388cbf55ba6ca791b9d

Derive common traits for panic::Location. Add documentation about the host/target behavior of Location::file.

view details

Alexis Bourget

commit sha 837a761b398a6ff6a97f7f61e390dae9efbeab79

Document the where keyword

view details

Andrey Zgarbul

commit sha 7d4a92d4f8dc03409984695d78893fffdd3ff1f9

remove LengthAtMost32 on AsRef/Borrow impl for array

view details

Roman Proskuryakov

commit sha eff62069ad602090e8d27b83cffd9e77479ed4be

Remove the usage of the LengthAtMost32 trait

view details

Roman Proskuryakov

commit sha 4ad40a8737ab4ffaf6352ec4560fd86cb0b4ade8

Remove LengthAtMost32

view details

Roman Proskuryakov

commit sha 44dd95e4d008e9edc112dc1a599eac028889e015

Fix copypaste in test into-iter-impls-length-33 (const generic 32 -> 33)

view details

push time in 5 days

pull request commentrust-lang/rust

Some fixes for `plugin.md` in unstable-book

Thanks!

r=me once CI pass

giraffate

comment created time in 5 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 9ceabe12257afaaef6074bca503fe57aa54f29b4

Add missing "is_min_const_fn" calls to prevent "const" to be displayed if the "rustc_const_unstable" attribute is present

view details

push time in 5 days

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 132fb8609ea2a1e54c0a39a01e2c1dfe8a33d201

Add missing "is_min_const_fn" calls to prevent "const" to be displayed if the "rustc_const_unstable" attribute is present

view details

push time in 5 days

PR opened rust-lang/rust

Clean up E0741 error explanation

r? @Dylan-DPC

+8 -4

0 comment

1 changed file

pr created time in 5 days

create barnchGuillaumeGomez/rust

branch : cleanup-e0741

created branch time in 5 days

pull request commentgtk-rs/glib

Clone to proc macro

Yes, let's wait until stable version has it as well. So in four weeks.

GuillaumeGomez

comment created time in 5 days

PR closed georust/geos

Try into

This work follows my effort to standardize mimirsbrunn dependencies on a unique version of geo_types (0.6)

I've noticed the comment // define our own TryInto while the std trait is not stable and felt it was time to move on... So I've removed this comment and the trait definition, and tried to use std::convert::TryFrom instead.

There is one test that's not working... closed_2_points_linear_ring. I don't understand what needs to be tested, and, from the little I read, it seems the diagram did not match what the code was doing.... So this point (pun intended) needs a bit more work.

+477 -343

3 comments

7 changed files

crocme10

pr closed time in 5 days

pull request commentgeorust/geos

Try into

I implemented TryInto, it's now available in the "7.0" version, so we can close this PR now. Thanks a lot for your work anyway!

crocme10

comment created time in 5 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0740

delete time in 5 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0734

delete time in 5 days

delete branch GuillaumeGomez/rust

delete branch : cleanup-e0730

delete time in 5 days

push eventgtk-rs/gtk-rs.github.io

strct

commit sha e869efcdf6787d8da54c65a4ad70e8e7b3819f2f

Fix link to GTK+ documentation

view details

Guillaume Gomez

commit sha bec427da4a4d44837d1919200ea6cf68b7babb16

Merge pull request #164 from strct/patch-1 Fix link to GTK+ documentation

view details

push time in 5 days

pull request commentgtk-rs/gtk-rs.github.io

Fix link to GTK+ documentation

Thanks!

strct

comment created time in 5 days

delete branch GuillaumeGomez/geos

delete branch : deps-and-try

delete time in 6 days

push eventgeorust/geos

Guillaume Gomez

commit sha 7a8441aaac9ccfa539d13c73ca8635a439c73181

Update geo-types and wkt dependencies

view details

Guillaume Gomez

commit sha 1614a49deedc01b2f0cd4de24852105ba9cabe2f

Use TryFrom from std

view details

Guillaume Gomez

commit sha d79ea67e9b20f8fdbf24407fb0779f28250ac6e4

Make TryFrom implementations more flexible

view details

Guillaume Gomez

commit sha da2cf25a907005959769ac2816adc08f96c37698

fmt

view details

Guillaume Gomez

commit sha 11f909a229785eab1bd1396369c733e25430de11

Upgrade crate version to 7.0

view details

Guillaume Gomez

commit sha fb6dc8596f81841dda584e0d3dcdf8b6dd6a7e35

Merge pull request #78 from GuillaumeGomez/deps-and-try Deps and try

view details

push time in 6 days

PR merged georust/geos

Deps and try
+212 -113

1 comment

7 changed files

GuillaumeGomez

pr closed time in 6 days

pull request commentgeorust/geos

Deps and try

Random failure as usual. Merging then!

GuillaumeGomez

comment created time in 6 days

pull request commentrust-lang/rust

Add `--output-format json` for Rustdoc on nightly

Looks good to me, thanks!

r=me once CI passed

P1n3appl3

comment created time in 6 days

pull request commentrust-lang/rust

Don't print "const" keyword on non-nightly build if rustc_const_unstable is used on the item

In the places I added my own check. Great! Just need to update the code I already wrote then. Thanks a lot for the pointer @ollie27 !

GuillaumeGomez

comment created time in 6 days

push eventGuillaumeGomez/geos

Guillaume Gomez

commit sha d79ea67e9b20f8fdbf24407fb0779f28250ac6e4

Make TryFrom implementations more flexible

view details

Guillaume Gomez

commit sha da2cf25a907005959769ac2816adc08f96c37698

fmt

view details

Guillaume Gomez

commit sha 11f909a229785eab1bd1396369c733e25430de11

Upgrade crate version to 7.0

view details

push time in 6 days

push eventGuillaumeGomez/geos

Guillaume Gomez

commit sha 1614a49deedc01b2f0cd4de24852105ba9cabe2f

Use TryFrom from std

view details

Guillaume Gomez

commit sha 38bd56ee65908c7ba66875f19f89217e23c5af63

fmt

view details

Guillaume Gomez

commit sha 916876291673325b7886f31c5180995fbafe61a0

Upgrade crate version to 7.0

view details

push time in 6 days

more