profile
viewpoint
Guillaume Gomez GuillaumeGomez Paris https://blog.guillaume-gomez.fr Opensource lover. Rustdoc team leader, member of the rust language tool, documentation and docs.rs teams, GNOME foundation member.

gtk-rs/gtk4 59

GTK 4 bindings and wrappers for Rust (Development)

gtk-rs/webkit2gtk-rs 46

WebKit2 bindings and wrappers for Rust

gtk-rs/gtk-test 22

Testing GTK UI

gtk-rs/sourceview 18

sourceview binding for Rust

gtk-rs/javascriptcore-rs 14

JavaScriptCore bindings and wrappers for Rust

gtk-rs/examples4 11

GTK 4 Rust examples (development)

gtk-rs/gdk4 7

GDK 4 bindings and wrappers for Rust (Development)

gtk-rs/pangocairo 7

Bindings for the pangocairo library

gtk-rs/atk 5

Atk binding in rust

gtk-rs/gsk4 5

GSK 4 bindings and wrappers for Rust (Development)

issue openedrust-lang/docs.rs

Add a button to change theme on the main page?

Currently, it's only possible to change the theme from the documentation pages. Adding a button on the "main" page (/) would improve this situation.

created time in 4 hours

delete branch GuillaumeGomez/docs.rs

delete branch : full-theming

delete time in 5 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 06fe27866920b3eaf6502f321ccb239cc617db10

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha b4c35368f41c36484cfa7679acb53d40ffbcce35

Add test for doc comments unindent fix

view details

push time in 5 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 6b9d095412866f37bfb74ad5ebe516e6814ee452

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha 0e9d972e094342ce29068abb421f81d39e97cc08

Add test for doc comments unindent fix

view details

push time in 5 hours

Pull request review commentrust-lang/rust

Fix unindent in doc comments

+#![feature(no_core)]++#![crate_name = "foo"]+#![no_std]+#![no_core]

Woups, it was just to have less logs when running my tests. I removed them.

GuillaumeGomez

comment created time in 5 hours

PullRequestReviewEvent

push eventGuillaumeGomez/docs.rs

Guillaume Gomez

commit sha 4a2e7a1fe0a261e9ec279b33943c10bade6c41d9

Add missing rule for builds page

view details

push time in 5 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha b3119542cf8bc3052ddbf98017632dd356351559

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha 8198b6277b7e0e59a14acf5238c8ee9400c4c6ac

Add test for doc comments unindent fix

view details

push time in 6 hours

Pull request review commentrust-lang/rust

Fix unindent in doc comments

 impl clean::Attributes { }  fn unindent_fragments(docs: &mut Vec<DocFragment>) {-    for fragment in docs {-        fragment.doc = unindent(&fragment.doc);-    }-}--fn unindent(s: &str) -> String {-    let lines = s.lines().collect::<Vec<&str>>();     let mut saw_first_line = false;     let mut saw_second_line = false;-    let min_indent = lines.iter().fold(usize::MAX, |min_indent, line| {-        // After we see the first non-whitespace line, look at-        // the line we have. If it is not whitespace, and therefore-        // part of the first paragraph, then ignore the indentation-        // level of the first line-        let ignore_previous_indents =-            saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent };+    if let Some(min_indent) = docs+        .iter()+        .map(|fragment| {+            fragment.doc.lines().fold(usize::MAX, |min_indent, line| {+                // After we see the first non-whitespace line, look at+                // the line we have. If it is not whitespace, and therefore+                // part of the first paragraph, then ignore the indentation+                // level of the first line+                let ignore_previous_indents =+                    saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        if saw_first_line {-            saw_second_line = true;-        }+                let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent }; -        if line.chars().all(|c| c.is_whitespace()) {-            min_indent-        } else {-            saw_first_line = true;-            let mut whitespace = 0;-            line.chars().all(|char| {-                // Compare against either space or tab, ignoring whether they-                // are mixed or not-                if char == ' ' || char == '\t' {-                    whitespace += 1;-                    true+                if saw_first_line {+                    saw_second_line = true;+                }++                if line.chars().all(|c| c.is_whitespace()) {+                    min_indent                 } else {-                    false+                    saw_first_line = true;+                    let mut whitespace = 0;+                    line.chars().all(|char| {+                        // Compare against either space or tab, ignoring whether they+                        // are mixed or not+                        if char == ' ' || char == '\t' {+                            whitespace += 1;+                            true+                        } else {+                            false+                        }+                    });

:+1:

GuillaumeGomez

comment created time in 10 hours

PullRequestReviewEvent

pull request commentrust-lang/rust

Fix unindent in doc comments

Hum, actually I might need to make a small update in the code. :3

GuillaumeGomez

comment created time in 10 hours

pull request commentrust-lang/rust

Fix unindent in doc comments

Well, glad I treated that correctly then. Thanks for the extra information! :)

GuillaumeGomez

comment created time in 10 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 2cafdad3abbe031b06857f923cd12822e49a4c83

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha 13b3187debe7fa436efac2445f1ce1c37d404659

Add test for doc comments unindent fix

view details

push time in 10 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha c852fd7b62dba0ef7059fc82a1b83c610c65bc45

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha 336bab38af907229e7d2b6bc2ed2f5d80acc94da

Add test for doc comments unindent fix

view details

push time in 10 hours

pull request commentrust-lang/docs.rs

Add templates theming to docs.rs

Fixed the input issue.

GuillaumeGomez

comment created time in 10 hours

Pull request review commentrust-lang/rust

Fix unindent in doc comments

 impl clean::Attributes { }  fn unindent_fragments(docs: &mut Vec<DocFragment>) {-    for fragment in docs {-        fragment.doc = unindent(&fragment.doc);-    }-}--fn unindent(s: &str) -> String {-    let lines = s.lines().collect::<Vec<&str>>();     let mut saw_first_line = false;     let mut saw_second_line = false;-    let min_indent = lines.iter().fold(usize::MAX, |min_indent, line| {-        // After we see the first non-whitespace line, look at-        // the line we have. If it is not whitespace, and therefore-        // part of the first paragraph, then ignore the indentation-        // level of the first line-        let ignore_previous_indents =-            saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent };+    if docs.is_empty() {+        return;+    }+    let mut min_indents = docs+        .iter()+        .map(|fragment| {+            fragment.doc.lines().fold(usize::MAX, |min_indent, line| {+                // After we see the first non-whitespace line, look at+                // the line we have. If it is not whitespace, and therefore+                // part of the first paragraph, then ignore the indentation+                // level of the first line+                let ignore_previous_indents =+                    saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        if saw_first_line {-            saw_second_line = true;-        }+                let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent }; -        if line.chars().all(|c| c.is_whitespace()) {-            min_indent-        } else {-            saw_first_line = true;-            let mut whitespace = 0;-            line.chars().all(|char| {-                // Compare against either space or tab, ignoring whether they-                // are mixed or not-                if char == ' ' || char == '\t' {-                    whitespace += 1;-                    true+                if saw_first_line {+                    saw_second_line = true;+                }++                if line.chars().all(|c| c.is_whitespace()) {+                    min_indent                 } else {-                    false+                    saw_first_line = true;+                    let mut whitespace = 0;+                    line.chars().all(|char| {+                        // Compare against either space or tab, ignoring whether they+                        // are mixed or not+                        if char == ' ' || char == '\t' {+                            whitespace += 1;+                            true+                        } else {+                            false+                        }+                    });+                    cmp::min(min_indent, whitespace)                 }-            });-            cmp::min(min_indent, whitespace)-        }-    });+            }) + if fragment.kind == DocFragmentKind::SugaredDoc { 0 } else { 1 }+        })+        .collect::<Vec<_>>();+    min_indents.sort_unstable();+    let min_indent = min_indents[0];

:o That's awesome!

GuillaumeGomez

comment created time in 10 hours

PullRequestReviewEvent

push eventGuillaumeGomez/docs.rs

Guillaume Gomez

commit sha 8092e90f79c496ae6a59936e0d05dabf825944b6

Fix navbar input color

view details

push time in 10 hours

pull request commentrust-lang/docs.rs

Add templates theming to docs.rs

This doesn't update codeblocks, so they look a little blinding in night mode:

If it's on the docs.rs pages, then not directly since it depends on highlight.js and not HTML/CSS only. We discussed about it a few comments ago. ;)

This doesn't update the search bar, so it's a little hard to read:

Nice catch! Taking a look.

GuillaumeGomez

comment created time in 11 hours

pull request commentrust-lang/docs.rs

Add templates theming to docs.rs

How does this behave for docs built before the rustdoc changes? Will they still have the theme switched appropriately?

Based on the script written by @Nemo157, they should get updated as long as the docs has been generated using a rustdoc version than supported themes (so a very old one).

GuillaumeGomez

comment created time in 11 hours

pull request commentrust-lang/rust

Fix unindent in doc comments

@Nemo157 Well, for me it seems like it should work because sugared doc comments should be handled a bit differently than the others (they need to have one extra whitespace after all).

@jyn514 Thanks to your remarks, I greatly improved the code. :)

GuillaumeGomez

comment created time in 11 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha b7ed80ee1a3acef574c5c758ff59f5e94525b200

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha b3da309cdd3251bd64d2e0b60775b3484f7d2c1f

Add test for doc comments unindent fix

view details

push time in 11 hours

pull request commentgtk-rs/glib

translate: take advantage of Rust Option & Result types

I confirm: not happy! :< (but debatable depending on the amount of required code)

fengalin

comment created time in 11 hours

Pull request review commentrust-lang/rust

Fix unindent in doc comments

 impl clean::Attributes { }  fn unindent_fragments(docs: &mut Vec<DocFragment>) {-    for fragment in docs {-        fragment.doc = unindent(&fragment.doc);-    }-}--fn unindent(s: &str) -> String {-    let lines = s.lines().collect::<Vec<&str>>();     let mut saw_first_line = false;     let mut saw_second_line = false;-    let min_indent = lines.iter().fold(usize::MAX, |min_indent, line| {-        // After we see the first non-whitespace line, look at-        // the line we have. If it is not whitespace, and therefore-        // part of the first paragraph, then ignore the indentation-        // level of the first line-        let ignore_previous_indents =-            saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent };+    let mut min_indents = docs+        .iter()+        .map(|fragment| {+            fragment.doc.lines().fold(usize::MAX, |min_indent, line| {+                // After we see the first non-whitespace line, look at+                // the line we have. If it is not whitespace, and therefore+                // part of the first paragraph, then ignore the indentation+                // level of the first line+                let ignore_previous_indents =+                    saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        if saw_first_line {-            saw_second_line = true;-        }+                let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent };++                if saw_first_line {+                    saw_second_line = true;+                } -        if line.chars().all(|c| c.is_whitespace()) {-            min_indent-        } else {-            saw_first_line = true;-            let mut whitespace = 0;-            line.chars().all(|char| {-                // Compare against either space or tab, ignoring whether they-                // are mixed or not-                if char == ' ' || char == '\t' {-                    whitespace += 1;-                    true+                if line.chars().all(|c| c.is_whitespace()) {+                    min_indent                 } else {-                    false+                    saw_first_line = true;+                    let mut whitespace = 0;+                    line.chars().all(|char| {+                        // Compare against either space or tab, ignoring whether they+                        // are mixed or not+                        if char == ' ' || char == '\t' {+                            whitespace += 1;+                            true+                        } else {+                            false+                        }+                    });+                    cmp::min(min_indent, whitespace)                 }-            });-            cmp::min(min_indent, whitespace)-        }-    });+            })+        })+        .collect::<Vec<_>>();+    if min_indents.is_empty() {+        return;+    }+    min_indents.sort_unstable();+    let min_indent = min_indents[0]; -    if !lines.is_empty() {-        let mut unindented = vec![lines[0].trim_start().to_string()];-        unindented.extend_from_slice(-            &lines[1..]-                .iter()-                .map(|&line| {-                    if line.chars().all(|c| c.is_whitespace()) {-                        line.to_string()-                    } else {-                        assert!(line.len() >= min_indent);-                        line[min_indent..].to_string()-                    }-                })-                .collect::<Vec<_>>(),-        );-        unindented.join("\n")-    } else {-        s.to_string()+    for (index, fragment) in docs.iter_mut().enumerate() {+        let lines = fragment.doc.lines().collect::<Vec<&str>>();++        if !lines.is_empty() {+            let mut unindented =+                if index == 0 { vec![lines[0].trim_start().to_string()] } else { vec![] };+            unindented.extend_from_slice(+                &lines[if index == 0 { 1 } else { 0 }..]

Actually, I think that most of this code can be simplified now.

GuillaumeGomez

comment created time in 11 hours

PullRequestReviewEvent

Pull request review commentrust-lang/rust

Fix unindent in doc comments

 LL | | /// [error]    |    = note: the link appears in this line:            -           [error]-            ^^^^^+            [error]+             ^^^^^

Hum... It should definitely take into account the kind of the doc fragment. Good point!

GuillaumeGomez

comment created time in 11 hours

PullRequestReviewEvent

Pull request review commentrust-lang/rust

Fix unindent in doc comments

 impl clean::Attributes { }  fn unindent_fragments(docs: &mut Vec<DocFragment>) {-    for fragment in docs {-        fragment.doc = unindent(&fragment.doc);-    }-}--fn unindent(s: &str) -> String {-    let lines = s.lines().collect::<Vec<&str>>();     let mut saw_first_line = false;     let mut saw_second_line = false;-    let min_indent = lines.iter().fold(usize::MAX, |min_indent, line| {-        // After we see the first non-whitespace line, look at-        // the line we have. If it is not whitespace, and therefore-        // part of the first paragraph, then ignore the indentation-        // level of the first line-        let ignore_previous_indents =-            saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent };+    let mut min_indents = docs.iter().map(|fragment| {+        fragment.doc.lines().fold(usize::MAX, |min_indent, line| {+            // After we see the first non-whitespace line, look at+            // the line we have. If it is not whitespace, and therefore+            // part of the first paragraph, then ignore the indentation+            // level of the first line+            let ignore_previous_indents =+                saw_first_line && !saw_second_line && !line.chars().all(|c| c.is_whitespace()); -        if saw_first_line {-            saw_second_line = true;-        }+            let min_indent = if ignore_previous_indents { usize::MAX } else { min_indent }; -        if line.chars().all(|c| c.is_whitespace()) {-            min_indent-        } else {-            saw_first_line = true;-            let mut whitespace = 0;-            line.chars().all(|char| {-                // Compare against either space or tab, ignoring whether they-                // are mixed or not-                if char == ' ' || char == '\t' {-                    whitespace += 1;-                    true-                } else {-                    false-                }-            });-            cmp::min(min_indent, whitespace)-        }-    });+            if saw_first_line {+                saw_second_line = true;+            } -    if !lines.is_empty() {-        let mut unindented = vec![lines[0].trim_start().to_string()];-        unindented.extend_from_slice(-            &lines[1..]-                .iter()-                .map(|&line| {-                    if line.chars().all(|c| c.is_whitespace()) {-                        line.to_string()+            if line.chars().all(|c| c.is_whitespace()) {+                min_indent+            } else {+                saw_first_line = true;+                let mut whitespace = 0;+                line.chars().all(|char| {+                    // Compare against either space or tab, ignoring whether they+                    // are mixed or not+                    if char == ' ' || char == '\t' {+                        whitespace += 1;+                        true                     } else {-                        assert!(line.len() >= min_indent);-                        line[min_indent..].to_string()+                        false                     }-                })-                .collect::<Vec<_>>(),-        );-        unindented.join("\n")-    } else {-        s.to_string()+                });+                cmp::min(min_indent, whitespace)+            }+        })+    }).collect::<Vec<_>>();+    if min_indents.is_empty() {+        return;+    }+    min_indents.sort_unstable();+    let min_indent = min_indents[0];

I needed to get the min_indent based on all the doc fragments, not just on one.

GuillaumeGomez

comment created time in 11 hours

PullRequestReviewEvent

pull request commentrust-lang/rust

Fix unindent in doc comments

This test only check that there is a title, not that the indent isn't broken as far as I can tell?

GuillaumeGomez

comment created time in 11 hours

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 5cc9d29ad279fe49c29288d4db378cde146359d7

Fix unindent behavior between different doc comments

view details

Guillaume Gomez

commit sha 914640cccd75d5f882e95d7b1b1c1717c7e4a9fe

Add test for doc comments unindent fix

view details

push time in 11 hours

Pull request review commentrust-lang/rust

Render Markdown in search results

 function defocusSearchBar() {         }     }; +    /// Render HTML as plaintext:+    ///+    /// * Replace "<code>foo</code>" with "`code`"+    /// * Strip all other HTML tags+    ///+    /// Note that it just uses a regex to strip the other HTML tags,+    /// so it may not work correctly for cases where there is an angle+    /// bracket inside quotes.+    ///+    /// Used by the dynamic sidebar crate list renderer.+    function renderHTMLAsPlaintext(html) {+        return html.replace('<code>', '`').replace('</code>', '`')+                   .replace(/<[^>]+>/, '');+    }

It's definitely not the right approach. The good approach is to generate the HTML directly from rustdoc into the search index.

camelid

comment created time in 11 hours

PullRequestReviewEvent

PR opened rust-lang/rust

Fix unindent in doc comments

Fixes #70732

r? @jyn514

+73 -55

0 comment

3 changed files

pr created time in 11 hours

create barnchGuillaumeGomez/rust

branch : fix-unindent

created branch time in 11 hours

delete branch GuillaumeGomez/rust

delete branch : sublist-check

delete time in 12 hours

pull request commentrust-lang/rust

Add test to ensure sublist rendering

I think having a test to ensure we don't have regression on rustdoc is good too, but as you prefer! (In any case, we can close the issue even if we don't merge this PR.)

GuillaumeGomez

comment created time in 12 hours

pull request commentgtk-rs/glib

translate: take advantage of Rust Option & Result types

Looks like a nice improvement overall!

fengalin

comment created time in 15 hours

Pull request review commentgtk-rs/glib

translate: take advantage of Rust Option & Result types

 impl FromGlib<glib_sys::gboolean> for bool {     } } -impl FromGlib<u32> for char {+impl FromGlib<i32> for Ordering {     #[inline]-    fn from_glib(val: u32) -> char {-        char::from_u32(val).expect("Valid Unicode character expected")+    fn from_glib(val: i32) -> Ordering {+        val.cmp(&0)     } } -impl FromGlib<i32> for Ordering {+/// Translate from a Glib type which can result in an undefined and/or invalid value.+pub trait TryFromGlib<G>: Sized {+    type Error;+    fn try_from_glib(val: G) -> Result<Self, Self::Error>;+}++/// Error type for `TryFromGlib` when the Glib value can be undefined.+#[derive(Debug, PartialEq, Eq)]+pub struct UndefinedError;++impl fmt::Display for UndefinedError {+    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {+        write!(fmt, "value is undefined")+    }+}++impl std::error::Error for UndefinedError {}++impl<G, T: TryFromGlib<G, Error = UndefinedError>> FromGlib<G> for Option<T> {     #[inline]-    fn from_glib(val: i32) -> Ordering {-        val.cmp(&0)+    fn from_glib(val: G) -> Option<T> {+        T::try_from_glib(val).ok()+    }+}++/// Error type for `TryFromGlib` when the Glib value can be invalid.+#[derive(Debug, PartialEq, Eq)]+pub struct InvalidError;++impl fmt::Display for InvalidError {+    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {+        write!(fmt, "invalid conversion attempted")     } } -impl FromGlib<u32> for Option<char> {+impl std::error::Error for InvalidError {}++impl TryFromGlib<u32> for char {+    type Error = InvalidError;     #[inline]-    fn from_glib(val: u32) -> Option<char> {-        match val {-            0 => None,-            _ => char::from_u32(val),-        }+    fn try_from_glib(val: u32) -> Result<Self, InvalidError> {+        char::from_u32(val).ok_or(InvalidError)     } } -impl FromGlib<i32> for Option<u32> {+impl TryFromGlib<i32> for u32 {+    type Error = InvalidError;     #[inline]-    fn from_glib(val: i32) -> Option<u32> {-        if val >= 0 {-            Some(val as u32)-        } else {-            None-        }+    fn try_from_glib(val: i32) -> Result<Self, InvalidError> {+        u32::try_from(val).map_err(|_| InvalidError)     } } -impl FromGlib<i64> for Option<u64> {+// FIXME should we implement this here?+// Maybe we should force the caller to use try_from_glib instead.+impl FromGlib<u32> for char {

If it can panic, then I think it'd be better to force the usage of try_from_glib as you suggested. Maybe let's wait for @sdroege's opinion too before changing anything.

fengalin

comment created time in 15 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventgtk-rs/gir

Sebastian Dröge

commit sha 3303549443533079b3d9e49b61c6336f5ccdeacb

Add per-crate and per-object configuration to trust return value nullability This has to be used carefully as many libraries forgot to put `nullability` annotations on return values, which then causes a panic if an unexpected `NULL` is returned.

view details

Guillaume Gomez

commit sha 49cfee1eeece1c6b9ae479599fd0704a49cbcbbe

Merge pull request #970 from sdroege/trust_return_value_nullability Add per-crate and per-object configuration to trust return value nullability

view details

push time in 16 hours

PR merged gtk-rs/gir

Add per-crate and per-object configuration to trust return value nullability

This has to be used carefully as many libraries forgot to put nullability annotations on return values, which then causes a panic if an unexpected NULL is returned.


CC @GuillaumeGomez @EPashkin @sophie-h

With this you can check what kind of changes are generated when trusting the gir files, and then report any missing nullable annotations to the C libraries.

+76 -18

17 comments

5 changed files

sdroege

pr closed time in 16 hours

pull request commentgtk-rs/gir

Add per-crate and per-object configuration to trust return value nullability

After a discussion between @sdroege and I, I finally agreed on his position so let's get this in!

sdroege

comment created time in 16 hours

PullRequestReviewEvent

push eventGuillaumeGomez/rust

Guillaume Gomez

commit sha 47a4a7c36c914757c2db4d0ceb59752fd3ee4d67

Add test to ensure sublist rendering

view details

push time in 2 days

PR opened rust-lang/rust

Add test to ensure sublist rendering

Fixes #72566.

r? @jyn514

+13 -0

0 comment

1 changed file

pr created time in 2 days

create barnchGuillaumeGomez/rust

branch : sublist-check

created branch time in 2 days

issue commentrust-lang/rust

Rustdoc doctest attribute splitting is probably too liberal

The handling of ignore will need a small update but otherwise sounds good to me. Also, being able to name a doctest is a good idea.

casey

comment created time in 2 days

pull request commentrust-lang/rust

Make some functions private that don't have to be public

Thanks!

@bors: r+ rollup

jyn514

comment created time in 2 days

Pull request review commentrust-lang/rust

Formally deprecate the constants superseded by RFC 2700

 extern crate reexport_check; // @!has 'foo/index.html' '//code' 'pub use self::i32;' // @has 'foo/index.html' '//tr[@class="module-item"]' 'i32' // @has 'foo/i32/index.html'+#[allow(deprecated, deprecated_in_future)]

I'm fine with it too.

bstrie

comment created time in 2 days

PullRequestReviewEvent

issue commentgtk-rs/gtk

Building gtk-rs runs out of memory on 2GB device, which I think means compiling any basic graphical app won't work there

Neither do I (what kind of people are we for maintaining GUI stuff if we don't do GUIs?! 🤣 ). Do you have any ideas how we could split things @ebassi?

ell1e

comment created time in 2 days

pull request commentrust-lang/rust

rustdoc options to set default theme (and other settings)

Please rebase to fix merge conflicts then ping me and I'll review again (but it seems mostly good already).

ijackson

comment created time in 2 days

issue commentgtk-rs/gtk-rs

Migration

No, no subtree in here.

GuillaumeGomez

comment created time in 2 days

delete branch gtk-rs/gtk-rs

delete branch : resync-glib

delete time in 2 days

push eventgtk-rs/gtk-rs

Ian Douglas Scott

commit sha 164d1b389bbaf6e8523d9332196e551494b924b4

glib: Remove PhantomData from struct created in glib_object_wrapper! I don't believe these any reason to use `PhantomData` in a struct like this that isn't generic. `glib` itself, at least, still compiles and passes tests with this simply removed.

view details

Ian Douglas Scott

commit sha fce75354bc153808378c3fed82710feab31ed13d

glib: Derive PartialOrd, PartialEq, Eq, and Debug in glib_object_wrapper! I believe the derived `Ord` and `Eq` implementations should behave correctly based on how the wrapper `ObjectRef` type sorts. The derived `Debug` changes this to printing as a tuple struct, rather than a struct with an `inner` member. If this is undesired, the struct should just be defined to actually have an `inner` member.

view details

Ian Douglas Scott

commit sha 904abe50d0fa32bd577f6e03df3ac660fe0899e6

glib: Remove PhantomData from Value, and make it #[repr(transparent)]

view details

Sebastian Dröge

commit sha c625ad6d12c2e0750f3d1b2aa4c72545e9c09ec2

glib: Fix PhantomData of InitializingType We don't own a value of type T but just reference the type information. See https://doc.rust-lang.org/nomicon/phantom-data.html#table-of-phantomdata-patterns

view details

Sebastian Dröge

commit sha fabe66ab74c293428c36ad43faa160b868dbb20e

glib: Fix src/auto/versions.txt

view details

Sebastian Dröge

commit sha 94866f09c787b58140affc4dfadafcf57dbc0606

glib: Don't define a MemoryManager type for boxed/shared wrappers These will conflict with other types if multiple wrappers are defined in the same module. Instead simply implement the memory manager trait directly on the wrapper type. Fixes https://github.com/gtk-rs/glib/issues/714

view details

Sebastian Dröge

commit sha f397dee5ba775f23854187296aef2cd63ec8bd53

glib: Don't use lots of internal modules in param specs bindings This is not needed anymore now that it's possible to define multiple shared/boxed wrappers in the same module.

view details

Sebastian Dröge

commit sha e34d0f9ebc4ee259069678a347ae703a01d29c6a

glib: Fix/silence various clippy warnings

view details

Sebastian Dröge

commit sha 067072d1690ca6546d08c668e84c52bd39b27d39

glib: Remove unneeded #[allow(clippy::type_complexity)]

view details

Sebastian Dröge

commit sha 6d4e3648080f19bc008810124821bfe0587cf57a

glib: Use repr(transparent) instead of repr(C) where this is more correct

view details

Guillaume Gomez

commit sha 8abef50334438f927a20f9f67f1e96286247ba8c

Merge pull request #3 from gtk-rs/resync-glib Resync glib

view details

push time in 2 days

PR merged gtk-rs/gtk-rs

Reviewers
Resync glib
+89 -127

0 comment

14 changed files

sdroege

pr closed time in 2 days

PullRequestReviewEvent

pull request commentrust-lang/rust

Link to cargo's `build-std` feature instead of `xargo` in custom target docs

Looks good to me. Just want to have the confirmation from @rust-lang/cargo team first but otherwise looks good.

phil-opp

comment created time in 3 days

MemberEvent
PullRequestReviewEvent

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 937faff89c6d1e95a8c5760a9a66a325288a3565

Add more information into README

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 3566a5865ecb23783a7b5754d6376334fdf4c68b

Unify all crates version to 0.13

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 8e5176800127b082695dacf8b330641a68193f75

Greatly improve generator file

view details

Guillaume Gomez

commit sha 98b705c022d07c5f4d9be5e81647af567cd70ffd

Add gtk tests generated files to gitignore

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha cf2454ddb652b163a9da1110445fa17defa9b73e

Add generator.py to regenerate crates and add information into the global README

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 6657b01355a77d5c9d3abb3f0600acee18556418

Add license and copyright files

view details

Guillaume Gomez

commit sha 43e191af42a35513d62184ea1a62e9d37f12f844

Remove unused files

view details

Guillaume Gomez

commit sha 1da66b3b1d6073277820177d2e87adfa35ff3408

Create Cargo workspace

view details

Guillaume Gomez

commit sha a719038d28b541e87faebaf2fd4649390bbd63b3

Fix examples cargo file

view details

Guillaume Gomez

commit sha 20b3e6bdb47d589422456c86b7b2da124f7c51a4

Ignore more files

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 8d3943d65c322e8e40745e31b9ade4052a9d2779

Rename cairo-sys-rs to sys for consistency

view details

Guillaume Gomez

commit sha 46bb9caf9790b1e06db440565438ce92f4796757

Rename graphene-sys to sys for consistency

view details

Guillaume Gomez

commit sha b59e4ff6011ec39e85f2647757b4767dd9d4454b

Update cargo files to use path instead of git

view details

push time in 3 days

issue commentgtk-rs/gtk

Building gtk-rs runs out of memory on 2GB device, which I think means compiling any basic graphical app won't work there

Cross compilation is pretty common for any embedded development, even in C/C++. So not sure...

ell1e

comment created time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 3e8ed6c5c3c6e1bc1f4fa862ef740e738baaffce

Move gir files into the associated folder and remove unused g*4 versions

view details

Guillaume Gomez

commit sha ad1e23bfb47330988066dd699be4a9831b3ad70f

Move sys crates into their wrappers

view details

Guillaume Gomez

commit sha 7ff33d22a138bfa02d871e2c9c8c3753274004e4

Remove all FUNDING.yml files and move it to top folder

view details

push time in 3 days

issue commentgtk-rs/gtk

Building gtk-rs runs out of memory on 2GB device, which I think means compiling any basic graphical app won't work there

The solution there is cross-compilation. The rust compiler uses a lot of memory when running, which is an issue (my raspberry 3 cannot use rustc directly, I cross-compile to it for example). I show an example on how to cross-compile to raspberry here, I guess it's not very different for the pinephone.

As for the rust compiler using too much memory, well, it's not a known issue but luckily, the cross-compilation is pretty easy to use there.

ell1e

comment created time in 3 days

pull request commentrust-lang/rust

Always store Rustdoc theme when it's changed

@bors: r+ rollup

nasso

comment created time in 3 days

PullRequestReviewEvent

issue commentgtk-rs/gtk-rs

Migration

I'm almost done already. ;) The issue is mostly how the repository should look like in the end.

GuillaumeGomez

comment created time in 3 days

push eventgtk-rs/gtk-rs

Gleb Kozyrev

commit sha dc0d1aecfeef2749ffb1bbe3fd4fc23b197db709

sys: Add gir and gir-files submodules

view details

Gleb Kozyrev

commit sha b62f063f3d215fff77c241cdddd82fe6b1f906f7

sys: Add Makefile

view details

Gleb Kozyrev

commit sha 8c5eaaf71bd6a420a40565ff0a3e38eeb98a6181

sys: Add gir configs for gtk-sys and its dependencies

view details

Gleb Kozyrev

commit sha c10147de8022f38d7e4d22952fcb85a9d554aaa4

sys: Generate the crates for the first time

view details

Gleb Kozyrev

commit sha 84a0024530f21903cf3693127e7fa6ca9bd1b14b

sys: Makefile: update submodules automatically and make the gir target smarter

view details

Gleb Kozyrev

commit sha 9379a1009d22c18aa0f2becb209cc5a805d5b1a3

sys: Update gir

view details

Gleb Kozyrev

commit sha 9847bcecd80503f8b58a5e52e884f233d148e097

sys: Regen

view details

Gleb Kozyrev

commit sha 480c10db963b313d323cb5f766dbdf397c14d2b8

sys: Add gitignore

view details

Gleb Kozyrev

commit sha f49101dc6d8b776b0ebfbd1aa253454625cc4208

sys: Update gir

view details

Gleb Kozyrev

commit sha 940edd6a36a42c5da4ec0f705b127a0dcf2b9811

sys: Regen

view details

Evgenii Pashkin

commit sha ead3ce46f5854c5a65a5893174dbb62fc37c1b4e

sys: Remove sys specific from tomls

view details

Evgenii Pashkin

commit sha 9aa40f2307d76d5fbfbd66808aa134147519cb64

sys: Make absolute output path for gir

view details

Evgenii Pashkin

commit sha 0fd0e7e863310e14bfc6041cd0a68a27bfcfc4f6

sys: Update gir

view details

Evgenii Pashkin

commit sha 9addf7c04c891c734ca9206d0b5e00b68035f436

sys: Remove mkdir

view details

Evgenii Pashkin

commit sha dce178a2c602dbd59655f8d9c0def6a365196b52

sys: Regen

view details

Gleb Kozyrev

commit sha 085003b0e0fd9a88b6269787fddcaf1442bef669

sys: Merge pull request #1 from EPashkin/remove_targetpath_from_gir Remove targetpath from gir

view details

Gleb Kozyrev

commit sha 722a147afddf05d4270e26ef4b856e98f2d3daed

sys: Update gir

view details

Gleb Kozyrev

commit sha c5f099b8899f96f8b4df6fd496af6b6ef265d494

sys: Regen

view details

Gleb Kozyrev

commit sha f409ed3f51cfdfd9e53784f54ecb089c10bb565b

sys: Update gir

view details

Gleb Kozyrev

commit sha d29f424dd9b07ed59e46be89717c1670131e4046

sys: Regen

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha ef8d9fa5d975ec2e5585001f45bfd212691afea7

pangocairo: Initial commit

view details

Guillaume Gomez

commit sha b2a033d5fd0d19af05722a0623528be01c0e725a

pangocairo: First generation

view details

Guillaume Gomez

commit sha 50d0adf54a41469c40f77d5e045bd8d18858f55f

pangocairo: regen

view details

Guillaume Gomez

commit sha a0a8b6e1b17c3cf0fb2356326ab1a7ab5a1b60e8

pangocairo: Merge pull request #1 from GuillaumeGomez/first First generation

view details

Guillaume Gomez

commit sha 0e9cfcbf2f2bb3c7ba093f2ff2b22b1871629094

pangocairo: Fix Cargo.toml information

view details

Guillaume Gomez

commit sha 35b3d7b2414fa4075239d64eae9259eda994d785

pangocairo: Fix badges

view details

Guillaume Gomez

commit sha c98063a0bce263ffcbd1ee45845945295dc730c1

pangocairo: Add missing travis file

view details

Guillaume Gomez

commit sha 189df0cdcb401543bcd98ec5381ae8a1f6306965

pangocairo: Regen more things

view details

Guillaume Gomez

commit sha 44f0d041205d8704886372ccd04a52a5a22d111f

pangocairo: Update version

view details

Guillaume Gomez

commit sha ec8069367cecf69d0e50cc2891280e14fe4221da

pangocairo: Merge pull request #4 from GuillaumeGomez/master Update

view details

Guillaume Gomez

commit sha 93c4fc1835a4dbaeec876932f09367e3bc2e406e

pangocairo: Add doc feature

view details

Guillaume Gomez

commit sha 2cbf3fd68433cbaf571592712a8305e5f7b5bd56

pangocairo: Merge pull request #5 from GuillaumeGomez/master Add doc feature

view details

Guillaume Gomez

commit sha 296f2b882994d0e4d50496ac2e17f95606f659c3

pangocairo: Add build.rs

view details

Guillaume Gomez

commit sha 2c61bc37250af66e77f73032dc428c9f00e1225c

pangocairo: update crate version

view details

Guillaume Gomez

commit sha 18d99dc75294404195a23d9b23b3d561db88e21c

pangocairo: Remove call to check_init_asserts

view details

Guillaume Gomez

commit sha eccd097eb88ec374f95e5c95941af4bf34a1de97

pangocairo: Update versions

view details

Guillaume Gomez

commit sha 22c4289a8e60391a7f98c2fe5aae4fd698e6a05c

pangocairo: Merge pull request #6 from gtk-rs/master-release-update [release] merging master-release-update into master

view details

Guillaume Gomez

commit sha b7929788d4fef354b346a13cda0aef226f3c3d6e

pangocairo: update cargo file

view details

Guillaume Gomez

commit sha 3d5ee19e728da158b6b163a4820758b0f6b688a8

pangocairo: Update gir

view details

Guillaume Gomez

commit sha d2155c11f26afdb1a3aad82f3422aa9185691c2e

pangocairo: regen

view details

push time in 3 days

push eventgtk-rs/gtk-rs

GuillaumeGomez

commit sha 15603ccbe4c78e003b9abb27b38b18ff2f993802

pango: New widget function declaration

view details

GuillaumeGomez

commit sha ad1262a6f5f07bdec5e1c1f0ad7379e7ff619b2a

pango: Deprecated functions have been removed All widget functions are now declared in ffi New widget functions implemented

view details

Jeremy Letang

commit sha f1a9b41f1453946e25149451ea0188bf3e50e045

pango: Merge pull request #45 from GuillaumeGomez/master Widget features

view details

JeremyLetang

commit sha 4bd13d961a60c3a6e3fed73479d59adcb7669ac8

pango: fix to last Rust

view details

GuillaumeGomez

commit sha 01bcad88f60533d448db105353d07c0b5d2c301e

pango: Add new dialog : FontChooserDialog Add new trait : FontChooser I also added function declarations of GtkBuilder in case we would bind it in the future

view details

Jeremy Letang

commit sha 0ac1f1045695106519f541b68b56549b6201139c

pango: Merge pull request #46 from GuillaumeGomez/master Add new dialog : FontChooserDialog

view details

JeremyLetang

commit sha b4c0fea7aec71f7967d8a0341908830a40af6801

pango: remove gtk::Widget, this shouldn't exist, use traits::Widget, this follow my previous commit ( by mistake i've not made a pull request, see commit f985cbf10529666a68a39926521b4b920d58a305)

view details

Jeremy Letang

commit sha 83b64223be4c95f4cc2cbb07d60d24f25b3a1ace

pango: Merge pull request #40 from jeremyletang/rm-widget remove gtk::Widget

view details

EdShaw

commit sha c6802eb870ca50e72fd43f0338815898b92c0cfe

pango: Move cargo bins to examples/, and fix the cargo building.

view details

Jeremy Letang

commit sha 0ae3f4a6f5ed062f8b3a2ee53599eb9aa14d715a

pango: Merge pull request #48 from EdShaw/buildscripts Move cargo bins to examples/, and fix the cargo building.

view details

GuillaumeGomez

commit sha 55ef5856bc012d9d2bbe69d5224c22c33eacc902

pango: New widget : UnixPrintDialog

view details

GuillaumeGomez

commit sha a773d836989fbbc1aae9e62a3166969bf540257f

pango: Add new dialog : PageSetupUnixDialog (you need to uncomment it before using it) Add new widgets : PageSetup, PrintSettings, PaperSize

view details

GuillaumeGomez

commit sha ca72d185f82bca5530906e2b8546fe9c0758edb5

pango: New widget : RecentChooserDialog (and all its subwidgets)

view details

GuillaumeGomez

commit sha f87de42662d3e845adc7706ac408ff3e65d5c139

pango: Update to last rust compiler version

view details

Jeremy Letang

commit sha b4abf9c0e88c9f19d75062d3395d4709bb944d3e

pango: Merge pull request #47 from GuillaumeGomez/master Finalize dialog widget collections + update to last Rust ( str::raw -> string::raw )

view details

GuillaumeGomez

commit sha 4e3b3a9d9b97e45cc3e7c6cd3d72494fe839f40b

pango: update travis script

view details

Guillaume Gomez

commit sha 709463804f7a516056d6d7f7c75e5b2785d3effd

pango: Merge pull request #50 from GuillaumeGomez/master update travis script

view details

JeremyLetang

commit sha 1da26a709d996e5c21ae44204e9fc042379bc9e6

pango: try fix windows build

view details

Jeremy Letang

commit sha 1054c138f888c72e13864183386a19646877c057

pango: Update README.md

view details

JeremyLetang

commit sha 498deb1d62c99911bb343df294edcfab1d35cbc8

pango: fix to last Rust - ::std::slice::Vector is now ::std::slice::Slice

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 910bf8c59ef0ebac18ef7cdf4c3479d53e0f2ea4

examples: Initial commit

view details

Guillaume Gomez

commit sha 975e0337d0113f2596d48c09ca228982021e4f05

examples: First commit

view details

Guillaume Gomez

commit sha 901db083e9e45495669412b55652a28ac16b4fbb

examples: Update README.md

view details

Guillaume Gomez

commit sha 3f72e726f7d38e6329e639ef7972b3742991a3f5

examples: Update to new signals

view details

Gleb Kozyrev

commit sha d28c74ef0f8b59070b0d710781d7823dc37de44b

examples: Avoid using FromPrimitive

view details

Gleb Kozyrev

commit sha e129613f4650785a596bd56b29f4e2ddb73c3946

examples: s/PI_2/PI * 2./

view details

Guillaume Gomez

commit sha e57b73ad832ae032b6faf9a40737cc1042fcbdf0

examples: Merge pull request #1 from gkoz/rust_features Avoid using FromPrimitive and PI_2

view details

oakes

commit sha e395773efc8725ae87f61d0d574e2985fcbf038d

examples: Add a selection test to the treeview example

view details

Guillaume Gomez

commit sha 2c699e00910b341b28e16303a7c49d1b19a47e73

examples: Merge pull request #2 from oakes/signal_crash Add a selection test to the treeview example

view details

Gleb Kozyrev

commit sha 53411778fb02855c311575a5079488a399a1bab2

examples: Travis: build on both nightly and beta

view details

Guillaume Gomez

commit sha f9134b54f2582b03f9af63f5eb71ec0ccf97be40

examples: Merge pull request #3 from gkoz/travis_beta Travis: build on both nightly and beta

view details

Guillaume Gomez

commit sha 2aed6f9b51cb67f5e3ff653a2cbe42d21c877ca5

examples: Update to last gtk version

view details

Gleb Kozyrev

commit sha f9856cee4e7f0ea46808bcce4c364447dd0d4a39

examples: Signal handler fix

view details

Guillaume Gomez

commit sha 831a5f3c3bc198367cb01a0a18228f8b4a9624a3

examples: Merge pull request #5 from gkoz/static_signal_lifetime Signal handler fix

view details

Gleb Kozyrev

commit sha 487cc83811c8eea0e67001cb8ed7cd8e71100999

examples: Add appveyor.yml

view details

Guillaume Gomez

commit sha fa5d45fdaf37ab08cd3ca637dc609149f06f69ba

examples: Merge pull request #6 from gkoz/appveyor Add appveyor.yml

view details

Gleb Kozyrev

commit sha 35f9ae2a69c8e7c83940df5c659f2637496c871e

examples: Restore gtktest

view details

Guillaume Gomez

commit sha 4f7fc073b69857d0b3af12c0787d0eabffa2ec9b

examples: Merge pull request #7 from gkoz/gtktest Restore gtktest

view details

Guillaume Gomez

commit sha 292794b6608ed07d8ca99eff60bcddce42cbbfaa

examples: Add appveyor status badge

view details

Guillaume Gomez

commit sha fd36811aafe354e1de587267c0d8966c7eb3895d

examples: Update README.md

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Xiang Fan

commit sha 13b4ca78f413bb6bd36ee01dc374e1dcd77c6b5c

graphene: Cargo.toml: Initialize for graphene

view details

Xiang Fan

commit sha 5eca3cbcbccd6d8987309fcdec1071407600c411

graphene: Gir.toml: Initialize for graphene

view details

Xiang Fan

commit sha 79b5e6fdc6a27a75fec227dd010a835bf60c2df9

graphene: Cargo.toml: Add graphene-sys as dependency

view details

Xiang Fan

commit sha e892c3a252464a8292d1b8d090debd9f02be7b45

graphene: Gir.toml: Remove source of panic

view details

Xiang Fan

commit sha d384b508a184df17a19128041068602da8bc9fba

graphene: Remove unused files

view details

Xiang Fan

commit sha 66274b01b6e0d862aaa57e9f6ef7804267cbe636

graphene: Gen

view details

Xiang Fan

commit sha dec5bd4d6abfb336881626b2c83b5d3ebb4891e7

graphene: Fix versions and avoid compiling errors

view details

Xiang Fan

commit sha bd8c22fdcd30325c45f6abca9f59511276ae0957

graphene: Raise min version to 1.6

view details

Xiang Fan

commit sha d2401553aceeb20b6aa0bcd43b606cec42497f54

graphene: Makefile: Fix gir file location

view details

Xiang Fan

commit sha eb13d7d1e2e1e465ee067d37586d3be8da6ff76e

graphene: Gir.toml: Ignore Simd4F and Simd4X4F

view details

Xiang Fan

commit sha 0b6357044a9499c9fb57c877d08b08304332c8fb

graphene: Cargo.toml: Fix documentation url

view details

Xiang Fan

commit sha 6b32d8fd3ed0abec6db81ab29e9a2ebd14dbdc26

graphene: Update build.rs

view details

Xiang Fan

commit sha 7c12e438632b05b05ba671f49e444549841091c3

graphene: Gir.toml: Ignore some UB

view details

Xiang Fan

commit sha 861f7b5bc05270762d500c164f147bdc5357e658

graphene: box, euler: Manual new()

view details

Xiang Fan

commit sha b8d59a9015d75a2c549a9b51356c86a16fce1d1b

graphene: Update gir

view details

Xiang Fan

commit sha 54985acea4764bc77e1ef6127a0660abdeb728ce

graphene: Gir.toml: Add none and nullable return

view details

Xiang Fan

commit sha 0cb45bf70bdf2736ea2f2f86a311fc7d96f46f72

graphene: Add new* for each init*

view details

Xiang Fan

commit sha 046b3490933a8000b720e0d8b6f0008cefa4d82b

graphene: box: Add ignored array with size fns

view details

Xiang Fan

commit sha 376d7de29486c9d4a5395b48cfac989b7a7f95db

graphene: sphere: Add array with size fns

view details

Xiang Fan

commit sha e47e7462dfc53d0bb56fde26f1fe49d337504fd1

graphene: Gir.toml: Update comments

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Sebastian Dröge

commit sha c62460a83b75e2a6eba0c2df80c79f3bff771fea

glib: Add PhantomData<*const c_void> to the Value struct This ensures that Value is neither Send nor Sync, which it can't be in general. It is possible to store non-Send/non-Sync values inside the Value, which could then be transferred to different threads. Fixes https://github.com/gtk-rs/glib/issues/253

view details

Sebastian Dröge

commit sha 96eb4a41a511f7e6651fdeda5eb27345e38818ac

glib: Implement SendValue This is a wrapper around Value that ensures that only Send types are stored inside it, and as such also implements Send itself. Value does not implement Send anymore. Fixes https://github.com/gtk-rs/glib/issues/253

view details

Sebastian Dröge

commit sha afaafff5903f32f145c284c3ce5dc39ad93d779f

glib: Mark the IsA<_> trait unsafe Otherwise it is possible, in safe code, to implement IsA<_> between incompatible types and cause all kinds of bugs. Fixes https://github.com/gtk-rs/glib/issues/246

view details

Guillaume Gomez

commit sha c9b0ccfed06e7fa6c7621eba797e68dca13fb69d

glib: Merge pull request #255 from sdroege/deref-mut-value Don't implement DerefMut on TypedValue

view details

Guillaume Gomez

commit sha 75feae235823a2b66656c0cb4e8a8a470cadfcb2

glib: Merge pull request #257 from sdroege/is-a-unsafe Mark the IsA<_> trait unsafe

view details

Guillaume Gomez

commit sha 0c2b3629c7b046acbd836b6742bdf2ac1abb163f

glib: Merge pull request #256 from sdroege/send-value Implement SendValue and make Value not implement Send

view details

Sebastian Dröge

commit sha 4ce9b972e6a8e2898d71bba9837cdcb65138a0b4

glib: Implement AnyValue, a wrapper around std::any::Any This allows to store any Rust type (that is 'static, Clone, Send, Sync, Any) to be stored in GValues and passed around as GValues through C code, while being able to take out the original values in Rust again. Fixes https://github.com/gtk-rs/glib/issues/251

view details

Sebastian Dröge

commit sha cd17c961b8982f0629848eb84853b5903b4c101c

glib: Add TODO comment for "impl !Send for Value" once it's stable

view details

Sebastian Dröge

commit sha e23934ff14adae9abbe9cc75698cb1daffb9f90b

glib: Implement ToGlibPtrMut on SendValue and TypedValue<T> We don't get this for free anymore because DerefMut is not implemented anymore.

view details

Sebastian Dröge

commit sha ecfd36c055ca87987ecdaff8fc69fc0760c15d35

glib: Implement Send for GDate

view details

Guillaume Gomez

commit sha d79ea28c926d29eacdb538a3dcbd1116e6c76a2b

glib: Merge pull request #252 from sdroege/any-value Implement AnyValue, a wrapper around std::any::Any

view details

Sebastian Dröge

commit sha 532624051c6405330ab863b9fb1409b5cbe39569

glib: Implement Debug for AnyValue and AnySendValue

view details

Sebastian Dröge

commit sha d66b9dfd864c85a2e88f6be23b89af3eca4bd1be

glib: Implement AnyValue::downcast() for attempting to extract the contained value

view details

Guillaume Gomez

commit sha 7ff5a3defeb19e0587a20f496dc03e62adf6d8a4

glib: Merge pull request #258 from sdroege/any-value Minor AnyValue improvements

view details

Sebastian Dröge

commit sha b22571e365872dbaa361544ddf86ccd2694dfa25

glib: Add support for storing/retrieving (NULL terminated) String arrays in/from GValues

view details

Guillaume Gomez

commit sha 5764c68b3431ac1c4c62f5fd5f7cb6ee1076e98b

glib: Merge pull request #259 from sdroege/strv Add support for storing/retrieving (NULL terminated) String arrays in…

view details

Sebastian Dröge

commit sha 44982c5ae83ce2988f0ffdb398303d62d37cecaf

glib: types::instance_of() is unsafe, mark it as such

view details

Sebastian Dröge

commit sha f40d41efec72e6489daf7cd15083bb23ac3cccad

glib: Implement FromGlibContainerAsVec and ToGlibContainerFromSlice for Type

view details

Sebastian Dröge

commit sha 0de50f7720f371bb4baa021cbf470e4f9fe13d12

glib: Implement some new API for Type is_a() for checking subtyping relationships, parent() for getting the parent type if any, children() for getting all child types, interfaces() for getting all interfaces implemented by the type and finally interface_prerequisites() for getting all prerequisites of an interface type.

view details

Sebastian Dröge

commit sha da83441d536454595031639c515487490a61e066

glib: Panic if the return value from the closure passed to Object::connect() returns a value of the wrong type Or no value at all if a return value is needed, or a value if no return value is needed. By previously silently ignoring type errors here, hard to debug problems appeared when code didn't get any meaningful return values.

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Gleb Kozyrev

commit sha 1b6d72cf30b0ca224387df00beb7dc2561ee839a

gio: Initial commit

view details

Gleb Kozyrev

commit sha 376beb9834dc58867cd4f6add3ddbb5798c35f41

gio: Regen

view details

Gleb Kozyrev

commit sha 05439e350756c9fcc2f9fdd6829c2e1192abd7c7

gio: Add CI metadata

view details

Guillaume Gomez

commit sha be0fd2c790f34e79a5d13667fb353b9362bf5615

gio: Merge pull request #1 from gkoz/master Making CI work

view details

Guillaume Gomez

commit sha 2e815c136590061ccdb371e7ea2432df461e5371

gio: Fix appveyor badge

view details

Gleb Kozyrev

commit sha 3a31c7741dea2eba54de99d76bced811b8ec1e02

gio: Merge pull request #2 from gtk-rs/fix_appveyor_badge Fix appveyor badge

view details

Gleb Kozyrev

commit sha 0fb829027018b27fba2e4e165c898be532516373

gio: Use 'cargo install' in makefile

view details

Gleb Kozyrev

commit sha 3f7e77ca1882d31174737bdec86b7ce71717539c

gio: Update gir

view details

Gleb Kozyrev

commit sha 456c1a2cc40466274920a2cf42a074ad986648b5

gio: Blacklist signals that need some gir fixes

view details

Gleb Kozyrev

commit sha 5ccdd6def9b411493a531c09d353619379a11763

gio: Define callback_guard and reexport Object

view details

Gleb Kozyrev

commit sha a4aa50b58b10c0d08a53c13140a2bfe96fca4b30

gio: Regen

view details

Guillaume Gomez

commit sha 9a663042c9ccdfb833263b028aa8953e29c99096

gio: Merge pull request #3 from gkoz/update Gir update: generate enums and signals

view details

Gleb Kozyrev

commit sha 57ddcb5ceef4870df772366ad4e8f8715f48c73c

gio: Add prelude

view details

Guillaume Gomez

commit sha 254d77b59188cb98caebbd43e13f882a1959346e

gio: Merge pull request #4 from gkoz/prelude Add prelude

view details

Gleb Kozyrev

commit sha c969e9229060d8933c923a0c4b74d89b8ed90995

gio: Add resources_[un]register

view details

Guillaume Gomez

commit sha 21fc5e06a25040ef80eed1a1cb45c8b60b79e2c8

gio: Merge pull request #5 from gkoz/resources Add resources_[un]register

view details

Gleb Kozyrev

commit sha 040c1a0bf21f294b0054f577b309ef91dd54e8eb

gio: Update gir

view details

Gleb Kozyrev

commit sha c8690798c208c66d80952fb29405cdefbef37073

gio: Make regeneration quieter

view details

Gleb Kozyrev

commit sha 32881594bdf3c0d77cf77ce009ff193316c19257

gio: Stop ignoring signals with cross-crate signatures

view details

Gleb Kozyrev

commit sha 6216d25517b990af7d54118fe77d22a86d270dde

gio: Regen

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 48d8e698848f36f0f06c590eeb74bae101334dd9

gdkx11: Initial commit

view details

Guillaume Gomez

commit sha 6ac487e9e3b524174689cbbf85ba05d70bdf4dc0

gdkx11: start

view details

Guillaume Gomez

commit sha e59720d67e39f6f0bcd89ecf3939ddd3a18cc986

gdkx11: Update gir submodules

view details

Guillaume Gomez

commit sha 825ce333da39bdad3525fc90cbec7573c76e15a4

gdkx11: regen and fix missing bugs

view details

Guillaume Gomez

commit sha a9288afb2853672127cf83894fe3e5fb8146678f

gdkx11: generate more types

view details

Guillaume Gomez

commit sha 30c0fe00e522c1c01d791c924f25b0d7f54fdaaf

gdkx11: Update gir submodule

view details

Guillaume Gomez

commit sha bddd7e430577381f3c2076e2f4cbbbb46f7c3af6

gdkx11: regen

view details

Guillaume Gomez

commit sha bffec788d04223804217638a9d8aebe47382e5d2

gdkx11: Merge pull request #2 from gtk-rs/regen Regen

view details

Guillaume Gomez

commit sha 700b42535d15d2d8f54811f1bb496f6938521ee3

gdkx11: Update crate version

view details

Guillaume Gomez

commit sha 45cf19baf664135987c34ac93223d2e0973290c0

gdkx11: * Remove unused 'fragile' dependency * Set minimum version to 3.14 * Generate correctly global functions

view details

Guillaume Gomez

commit sha 9b4ea14ecf121e40b6adb54c2d7a09694e14f931

gdkx11: Add missing doc rule

view details

Guillaume Gomez

commit sha f60f948c7770440283484a5b03d56db73b5c38cf

gdkx11: Merge pull request #3 from gtk-rs/doc-rule Add missing doc rule

view details

Guillaume Gomez

commit sha f218c58c8b2981e30dfadde7fcfa4c517e469e4b

gdkx11: Replace spaces with tab

view details

Guillaume Gomez

commit sha 695855236ec15e2d07d8f943befa4ffe4bb3a0f9

gdkx11: Fix link to repository

view details

Stefan Schindler

commit sha 26ad21b5784e6f33ff764bb5153a68e69c60e9a2

gdkx11: Use https for all links Hi all This is a followup to https://github.com/gtk-rs/gtk/pull/1054 Cheers, Stefan

view details

Guillaume Gomez

commit sha a4dc41cbbfb97b649d048be574ce07ea6377b590

gdkx11: Merge pull request #4 from dns2utf8/https Use https for all links

view details

Bilal Elmoussaoui

commit sha f9466c32f513d8e0bde3b03137a44547e1b0be0d

gdkx11: groovy update: regenerate

view details

Bilal Elmoussaoui

commit sha ce62324d8b764b0e29ac7f354cdf1015db784931

gdkx11: add missing types & regenerate

view details

Bilal Elmoussaoui

commit sha e6116c77d8d565a3b66f6f0ec9a6588f2ca8c09f

gdkx11: add missing assert_initialized_main_thread

view details

Bilal Elmoussaoui

commit sha 46e1ba6cf19d0ee8d597114d79a46d32f0e79fc8

gdkx11: CI: migrate to github actions As travis was not setup to run, backport the changes from #6

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Guillaume Gomez

commit sha 3b99a651cbb31286e476b4db1a183ad7656fd26f

gdk: Merge pull request #18 from gkoz/travis_beta Travis: build on both nightly and beta

view details

Guillaume Gomez

commit sha 5994073185c75d0515669bf37cab6494f9e901e4

gdk: Add new types : PixbufAnimation, PixbufAnimationIter and PixbufSimpleAnim

view details

Guillaume Gomez

commit sha 13c812500ecddf10dd51f8a93f7fe81158bbd8db

gdk: Merge pull request #19 from GuillaumeGomez/master Add new types : PixbufAnimation, PixbufAnimationIter and PixbufSimpleAnim

view details

Gleb Kozyrev

commit sha e0fbfda0bfcdc7864b2be82499032b3e4b04f75a

gdk: Apply From/ToGlibPtr API changes

view details

Lucas Werkmeister

commit sha 03ab76c1d9ae57c71e9ac73ef1c28cb15910931e

gdk: Publish event members

view details

Gleb Kozyrev

commit sha 3e28f4a85578bc74f05453102fdd82bf77d195a7

gdk: GObject refactoring and some minor cleanups Make all `GObject` descendants use `glib::object`. Convert other pointer types to use `From/ToGlibPtr`. Move everything out of the `widgets` module. Add `prelude` that will reexport any traits defined in the crate.

view details

Guillaume Gomez

commit sha cf4db75d9dbd5505d4dcf252bc5ad1b8286c9c64

gdk: Merge pull request #24 from gkoz/object_reform Object reform

view details

Guillaume Gomez

commit sha 4664166d6110f8cb56a69a88f54d83b732b3858a

gdk: Add missing functions from Pixbuf

view details

Guillaume Gomez

commit sha 51ba5c4ee8d43f0c437dc394ca80f456e445aa50

gdk: Update to last rust-gnome code reform

view details

Guillaume Gomez

commit sha 18ba101ac94a78467be8367c6d37b5d824c1d000

gdk: Merge pull request #23 from GuillaumeGomez/master Add missing functions from Pixbuf

view details

Lucas Werkmeister

commit sha c3646b2b2b7e087600e751d26b110686a1c72d16

gdk: Unpublish some pointer event members

view details

Lucas Werkmeister

commit sha 3f4651e6ea74bee9358336dfa7012550a851cf7e

gdk: Add TODO to events file

view details

Lucas Werkmeister

commit sha c40581e242098326b81666515097cbd0fbcaacba

gdk: Change #[allow(dead_code)] to #[repr(C)]

view details

Guillaume Gomez

commit sha 041adcb2a07d621039f6754935d45f6d94ebb87c

gdk: Merge pull request #21 from lucaswerkmeister/pub_event Publish event members

view details

Gleb Kozyrev

commit sha 9b04539a195e59e263c016f2289db4dafcc15dc9

gdk: Add Pixbuf and Animation new_from_file shims for Windows DLL ABI stability, y'know... https://git.gnome.org/browse/gdk-pixbuf/commit/gdk-pixbuf/gdk-pixbuf-animation.h?id=141506eb

view details

Gleb Kozyrev

commit sha 2a96c6b1e725fb48a81640d1be2340fa172c0f53

gdk: Gate PixbufAnimation::new_from_resource on GDK 3.8

view details

Guillaume Gomez

commit sha 88bc580ca5162d60d3e96d2a9d16bd7ffd582274

gdk: Merge pull request #27 from gkoz/gdk_3_8 Gate PixbufAnimation::new_from_resource on GDK 3.8

view details

Guillaume Gomez

commit sha d46a63622512ff65a063a9815798dce4a987ae81

gdk: Merge pull request #26 from gkoz/win32_shim Add Pixbuf and Animation new_from_file shims for Windows

view details

Gleb Kozyrev

commit sha fb2d738162dded6555dd225393cd65b98dd54093

gdk: Add appveyor.yml

view details

Guillaume Gomez

commit sha d4de908dbd4bec9f9abae65b11aed83a405fe691

gdk: Merge pull request #30 from gkoz/appveyor Add appveyor.yml

view details

push time in 3 days

push eventgtk-rs/gtk-rs

Evgenii Pashkin

commit sha 96322455aa15d96d1e49197679249fd82f038ce0

gtk: Remove callback_guard from manual parts

view details

Evgenii Pashkin

commit sha 29d6cdd050d4dcb3a9e3109192fa9dec3dd21a11

gtk: Regen

view details

Guillaume Gomez

commit sha 1ec1deadc01b5a293fc3dee5dc9a27a4e06b1d23

gtk: Merge pull request #667 from EPashkin/remove_callback_guard Remove callback guard

view details

Evgenii Pashkin

commit sha 6b504ca059c0eee15961e42da97a3b6db68d2006

cairo: Use FontFace and ScaledFont by reference

view details

Evgenii Pashkin

commit sha de622881cf443875e85731b5fb4de7808d018812

cairo: Fix clippy warnings in sys See https://rust-lang-nursery.github.io/rust-clippy/v0.0.209/index.html#trivially_copy_pass_by_ref

view details

Guillaume Gomez

commit sha 554ecbc7fa41dd4842786f6248110cf741c63d92

cairo: Merge pull request #193 from EPashkin/clippy_warnings Clippy warnings

view details

Evgenii Pashkin

commit sha ea71f754a6e67febd7b2f7c4b38f9356e344bb59

gtk: Fix clippy warnings

view details

Guillaume Gomez

commit sha ce51c9f37c27c80181228b68c8f245ac27145707

gtk: Merge pull request #668 from EPashkin/clippy_warnings Fix clippy warnings

view details

Sebastian Dröge

commit sha d6e0f581b9b80cf28a9248bd547882f42414c70f

gtk: Use futures-preview crates instead of futures The futures crates were janked from crates.io and renamed to futures-preview for whatever reason.

view details

Guillaume Gomez

commit sha 26e624d8cdb4d5fe1952a59e2a039677ddffed70

gtk: Merge pull request #669 from sdroege/futures-preview Use futures-preview crates instead of futures

view details

Guillaume Gomez

commit sha e55ca845381ad539e8b9d49d3dc2f49ba6219d87

gtk: Update gir submodule

view details

Guillaume Gomez

commit sha 5c59cc65c4e29f7562efa6ac4d873c07819b7f57

gtk: Rename ListStoreExtManual to GtkListStoreExtManual

view details

Guillaume Gomez

commit sha c692e7ee81ad7ff608c1a255c22a2cd2ec9c1aac

gtk: Merge pull request #670 from GuillaumeGomez/rename-list-store-ext-manual Rename ListStoreExtManual to GtkListStoreExtManual

view details

Guillaume Gomez

commit sha 67882881d2363f7428501accbddb2988a533937c

gtk: Add osx tests

view details

Guillaume Gomez

commit sha 83a457b5690984d488cea89e459c49d760236165

gtk: Merge pull request #671 from GuillaumeGomez/osx-tests Add osx tests

view details

Sebastian Dröge

commit sha b6bb9bd50d4d2bd02e4af35e893a5561d6358afe

gtk: Add ListBox::bind_model() and other functions taking closures

view details

Guillaume Gomez

commit sha 2cea66169596e81ca1d93112607d573abbdaecf2

gtk: Merge pull request #672 from sdroege/listbox Add ListBox::bind_model() and other functions taking closures

view details

Evgenii Pashkin

commit sha 13f5639b7e456c0bfa71a7c3fedd58518f2f5a53

gtk: Test with gtk3.22.30 and gdk3.22

view details

Guillaume Gomez

commit sha bf39b84d900e3ac8c3108c4e792b5972815b222e

gtk: Merge pull request #673 from EPashkin/test_3_22_30_part1 Test with gtk3.22.30 and gdk3.22

view details

Evgenii Pashkin

commit sha 318e45988dac6525fd1caf221ed34cdaf847b1db

gtk: Test with gtk3.22.30 same gdk

view details

push time in 3 days

create barnchgtk-rs/gtk-rs

branch : ongoing

created branch time in 3 days

issue commentgtk-rs/gtk-rs

Migration

We wait for their official stabilization to bring them in. Also, some crates that aren't "core" will remain outside of this repository (like sourceview).

GuillaumeGomez

comment created time in 3 days

delete branch GuillaumeGomez/docs.rs

delete branch : ignore-.workspace

delete time in 4 days

pull request commentgtk-rs/glib

Clone to proc macro

Is it an issue? We need to upgrade the minimum rust version for the next release in any case. Or maybe I missed something?

GuillaumeGomez

comment created time in 4 days

push eventGuillaumeGomez/rust

dylni

commit sha 1ff7da6551a7cdf6ace2a9d00e92bbab550334ee

Move `slice::check_range` to `RangeBounds`

view details

dylni

commit sha 1095dcab96d524e700b11edf366d45a0fd173fa0

Fix links

view details

dylni

commit sha eb63168e007058dad4af758faf1dca449c049777

Fix doctests

view details

dylni

commit sha f055b0bb0847ecf08fe452a270faae8324b55b05

Rename method to `assert_len`

view details

Bastian Kauschke

commit sha fd22e87afc9082522bc7b52e32d25d43c64594e6

fix flag computation for `ExistentialPredicate::Projection`

view details

Bastian Kauschke

commit sha 7652b4b1d9cec0ad22f529a4335d05f7d7792521

guard against `skip_binder` errors during FlagComputation

view details

follower

commit sha a7bd6c449aef07dc8daa889f4ddbdda326593e32

Link to "Contributing to Rust" rather than "Getting Started". Change to link to "Contributing to Rust" chapter of `rustc` Dev Guide, primarily on the basis that the GitHub "first contribution" Issue "pop-up" says "Be sure to review the [contributing guidelines] and [code of conduct]" and links to this file. When/if the guide/"Getting Started" section gets revised to not be `rustc`-specific the linked section can be changed. In the meantime this prevents leading first time contributors into a confusing cul de sac.

view details

Camelid

commit sha 549f861f7d53811521cf929cf58fb6828a2a88d9

Use correct article in help message for conversion or cast Before it always used `an`; now it uses the correct article for the type.

view details

Mara Bos

commit sha 81edbbc2bfacd29558a5020990d49fc07ed80ac7

Implement TryFrom between NonZero types.

view details

Camelid

commit sha 094f14c554c3a1f103a5d6778d4b4e131c297f11

Add article after "to" Also added missing backtick in "you can cast" message.

view details

Camelid

commit sha 8a6831a7fd3fc624643b50f494212e0ceaad3c28

Say "doesn't" instead of "wouldn't" in convert message

view details

Dylan MacKenzie

commit sha 77e6c56ab6f108fdbb8acbd176497be9f074af9a

Unify `&mut` and `&raw mut` const-checking errors

view details

Dylan MacKenzie

commit sha c1494d60dbad39c218e7b0825bfe590cc22bf2fa

Bless tests

view details

Bastian Kauschke

commit sha 9c302f55bd07a04305dfa2bd815d2559deb8468f

normalize in codegen_fulfill_obligations

view details

Bastian Kauschke

commit sha f0487cee7439f3a4b4c7daec0e7f2a0ccc21053c

normalize substs during inlining

view details

Bastian Kauschke

commit sha 32739a2ff1b7b6e5c1b475341b01f4a499830a84

add regression test

view details

Bastian Kauschke

commit sha ac893b8a02788eec6f6fad0cc89de0177b0c0a50

add test for should_inline incorrect param_env

view details

Mara Bos

commit sha 64839ee00ab4076d797901ddea55f2613c5b75b5

Add Pin::new_static.

view details

Mara Bos

commit sha 390883e888c580d054ab4a2584c851aba50865e9

Make Pin::new_static const.

view details

Joshua Nelson

commit sha bd135674814d74ca6fca3ab79d778ecaaeb02cf5

Allow setting up git hooks from other worktrees

view details

push time in 4 days

push eventGuillaumeGomez/rust

LeSeulArtichaut

commit sha 17d3c0a1788c5fc53947109a902869a51d8caa38

Use more intra-doc-links in `core::fmt`

view details

bors

commit sha beb5ae474d2835962ebdf7416bd1c9ad864fe101

Auto merge of #77023 - HeroicKatora:len-missed-optimization, r=Mark-Simulacrum Hint the maximum length permitted by invariant of slices One of the safety invariants of references, and in particular of references to slices, is that they may not cover more than `isize::MAX` bytes. The unsafe `from_raw_parts` constructors of slices explicitly requires the caller to guarantee this fact. Violating it would also be UB with regards to the semantics of generated llvm code. This effectively bounds the length of a (non-ZST) slice from above by a compile time constant. But when the length is loaded from a function argument it appears llvm is not aware of this requirement. The additional value range assertions allow some further elision of code branches, including overflow checks, especially in the presence of artithmetic on the indices. This may have a performance impact, adding more code to a common method but allowing more optimization. I'm not quite sure, is the Rust side of const-prop strong enough to elide the irrelevant match branches? Fixes: #67186

view details

Bastian Kauschke

commit sha 536674fb69ea161f50f68f3fdb65950feffd92a4

cleanup WithOptConstParam queries

view details

Robin Schoonover

commit sha 5ab19676ed25ce52769b06a2fc7319b93d6c64dd

Remove extra indirection in LitKind::ByteStr

view details

Robin Schoonover

commit sha 62f7712a1fd500604f76442f627ea35ce7217177

Change clippy's Constant back to refcount clone byte strings

view details

Robin Schoonover

commit sha f34f4a732714c397c30055feddb2b520b6acd38e

Change clippy's Constant back to refcount clone byte strings

view details

Dylan MacKenzie

commit sha e72e43c730a205237cacb8e9a7928ca0a0746252

Replace `(Body, DefId)` with `Body` where possible A `Body` now contains its `MirSource`, which in turn contains the `DefId` of the item associated with the `Body`.

view details

Dylan MacKenzie

commit sha 52484c59e5f97dddcacbed119f64ea6ec7eccac7

clippy: `(Body, DefId)` -> `Body`

view details

Dylan MacKenzie

commit sha 29d43f63bd41e794162a8118b422eff66b5f47eb

clippy: `(Body, DefId)` -> `Body`

view details

Mingye Wang

commit sha a35a93f09cc111a53d00efc567ad678583dd5ac7

Pass tune-cpu to LLVM I think this is how it should work...

view details

Camelid

commit sha b205436ff66db720cb4b0c503d14ff0a571b14c7

Allow anyone to set regression labels

view details

Dylan MacKenzie

commit sha 2e35cf973bea64f2d5afbe1f321e2b7a15967ab6

Replace `(Body, WithOptConstParam)` with `Body` where possible

view details

Dylan MacKenzie

commit sha fff3b7596af4e8c40dd54be2fb0648327244f097

nll: solve

view details

Dylan MacKenzie

commit sha 04a94abcb9f8029bc16cee974bfe37f0001f17e3

Remove `DefId` from `MirBorrowckCtxt`

view details

Dylan DPC

commit sha 6c9e85726c46254f0bb1b23d781c4c1b8a11e797

Rollup merge of #75853 - LeSeulArtichaut:core-intra-docs-3, r=jyn514 Use more intra-doc-links in `core::fmt` This is a follow-up to #75819, which encountered some broken links due to #75176, so this PR contains the links that are blocked on #75176. r? @jyn514

view details

Dylan DPC

commit sha 5fa978fa1b8377786b3f6bd1ff4eb4b92639fc8c

Rollup merge of #75928 - JulianKnodt:non_utf8, r=estebank Remove trait_selection error message in specific case In the case that a trait is not implemented for an ADT with type errors, cancel the error. Fixes #75627

view details

Dylan DPC

commit sha e6e7ccc28d3a574f87824af0532440d28b17311d

Rollup merge of #76329 - GuillaumeGomez:doc-alias-crate-level, r=matthewjasper Add check for doc alias attribute at crate level Fixes #76298, #64734, #69365. r? @ollie27

view details

Dylan DPC

commit sha 583269d8c5df4456da75ef888913c8760645f046

Rollup merge of #77219 - mightyiam:issue_77100, r=jyn514 core::global_allocator docs link to std::alloc::GlobalAlloc Closes #77100

view details

Dylan DPC

commit sha fe087ece94021ef8bed00f0c32138c0aa52bfc64

Rollup merge of #77395 - ssomers:btree_love_the_leaf_edge_comments, r=Mark-Simulacrum BTreeMap: admit the existence of leaf edges in comments The btree code is ambiguous about leaf edges (i.e., edges within leaf nodes). Iteration relies on them heavily, but some of the comments suggest there are no leaf edges (extracted from #77025) r? @Mark-Simulacrum

view details

Dylan DPC

commit sha fffeaa7b83df07600092ac5b2a3d84e5dc76637b

Rollup merge of #77407 - pietroalbini:less-build-manifest, r=Mark-Simulacrum Improve build-manifest to work with the improved promote-release This PR makes some changes to build-manifest to have it work better with the other improvements I'm making to [promote-release](https://github.com/rust-lang/promote-release). A new way to invoke the tool was added: `./x.py run src/tools/build-manifest`. The new invocation disables the generation of `.sha256` files and the generation of GPG signatures, as those steps are not tied to the Rust version we're building the manifest of: handling them in `promote-release` will improve the maintenability of our release process. Invocations through the old command (`./x.py dist hash-and-sign`) are referred inside the source code as "legacy". The new invocation also enables internal parallelism, disabled on legacy to avoid overloading our old server. Improvements were also made on how the checksums included in the manifest are generated: * The manifest is first generated with placeholder checksums, and then a function walks through the manifes and calculates only the needed hashes. Before this PR, all the hashes were calculated beforehand, including the hashes of unused files. * Calculating the hashes is now done in parallel with rayon, to better utilize all the available disk bandwidth. * The `sha2` crate is now used instead of the `sha256sum` CLI tool: this avoids the overhead of calling another process, but more importantly enables hardware acceleration whenever available (the `sha256sum` CLI tool doesn't support it at all). r? @Mark-Simulacrum This PR is best reviewed commit-by-commit.

view details

push time in 4 days

pull request commentgtk-rs/glib

Clone to proc macro

CI kinda passed.

GuillaumeGomez

comment created time in 4 days

pull request commentgtk-rs/cairo

Re-export cairo-sys as `ffi`.

Without doc(inline) preferably.

derekdreery

comment created time in 4 days

push eventGuillaumeGomez/docs.rs

Guillaume Gomez

commit sha 7bc67c102fb0326ebded59d830c741fde553af1a

Replace .rustwide with .workspace into .gitignore

view details

push time in 4 days

PR opened rust-lang/docs.rs

Add .workspace into .gitignore
+1 -0

0 comment

1 changed file

pr created time in 4 days

create barnchGuillaumeGomez/docs.rs

branch : ignore-.workspace

created branch time in 4 days

pull request commentrust-lang/docs.rs

Add templates theming to docs.rs

And here we are! I improved the input, fixed a few small things and also included improvements for the graphs.

GuillaumeGomez

comment created time in 4 days

push eventGuillaumeGomez/docs.rs

Joshua Nelson

commit sha 65fe5811c3e3ae132db698a62674a799e2ab3677

Update iron -> 0.6 This removes a bunch of duplicate dependencies.

view details

Joshua Nelson

commit sha 0e83b5db13b5adb6f99fafff6d60a6ad49a369ec

Add favicon to essential files This can be tested with `cargo run build add-essential-files && cargo build chrono 0.4.18`.

view details

Joshua Nelson

commit sha 71ac920f2b08b6c2216e27efd12f89621bfd447f

Update prometheus, removing spin dependency Changelog: https://github.com/tikv/rust-prometheus/blob/master/CHANGELOG.md#0100

view details

Guillaume Gomez

commit sha 6e50b428badd2b2874d0941c890b5810b2d0639e

Add missing file in rerun-if-changed

view details

Joshua Nelson

commit sha b05ef6f31aac5dcccfd279927cdc49660600d5a8

Move 'migrate' before 'build crate' in the README Ideally, this would be done automatically, but this part of the caching not well-maintained and it's simpler to just ask people to do it themselves.

view details

Joshua Nelson

commit sha 9c27d800fbeee3654a399d6b12d40c94f2511478

Fix error handling - Return 500, not 400, for internal errors - Return an error for internal errors in search, not 'not found'

view details

Wim Looman

commit sha 81a39f67b0f1ce4034431df1f3c18d9ec9c2dc9e

Add metrics tracking number of recently loaded crates/versions/platforms

view details

Wim Looman

commit sha c0c668930ee0a395db35c37fbfdbc578ec65a293

Use dashmap to record recent release access to avoid locking

view details

Wim Looman

commit sha 3961869d75ec4023f4f33471e639481ecf805c03

Rename recent crate metric

view details

Wim Looman

commit sha a214b468fa4330a93cbe9b2064fa74c94bdc0ff0

Rename recently accessed crate metrics

view details

Wim Looman

commit sha 750061b0619b0f6b12d4bc6ed4ccd47a25b74fc3

Use database ids to identify crates and versions

view details

Wim Looman

commit sha 4308b278ec3b414f350be9de6fb517af97cae54b

Intern known targets

view details

Wim Looman

commit sha e6b7db41b12ad0041fd475dc016a6c922e58ffaa

s/krates/crates

view details

Wim Looman

commit sha e4317b630da9b5bc804a8ace005524f511ed83e3

Rearrange recently accessed crate checks for readability

view details

Wim Looman

commit sha 7476edf8bae326b8f25965f12816a3c860df7da9

Review nits

view details

Wim Looman

commit sha 394e506156e406abea46cdd1a45813f209b8a242

Add an upper limit to number of recently accessed releases that will be tracked

view details

Guillaume Gomez

commit sha f48e17c887443df6ac3e6807404b3561d50eb819

Add templates theming to docs.rs

view details

Jarek Samic

commit sha 58837432ca46b2cdcce117f431e8e0ad25859cc6

A couple tweaks for the new themes

view details

Guillaume Gomez

commit sha 9196477ca01e60cbaed561722f7a617650baf4c7

Improve input rendering

view details

push time in 4 days

push eventGuillaumeGomez/glib

Guillaume Gomez

commit sha 9d276485ffab57b0ee40fc36691cfa047e826d57

Update minimum rust version to 1.46

view details

push time in 4 days

pull request commentrust-lang/docs.rs

Add templates theming to docs.rs

Oh damn.You really did a great job @Cldfire ! I'll cherry-pick your commit and use your css for the graph then. :)

GuillaumeGomez

comment created time in 4 days

more