profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Georift/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Tim Georift Perth, Australia Software Engineer

liamjack/VirtualTrader 10

Virtual stock trading site. Users start off with 200 $ and trade virtual stocks at their real price, the aim of the game is to make the most money. Entirely rebuilt from scratch based on the original VirtualTrader, now in OOP.

Georift/iAuth 8

Open-Source HWID Licencing Software

Georift/angular-cesium 0

JavaScript library for creating map based web apps using Cesium and Angular

Georift/cli 0

The Sequelize CLI

Georift/couchdb-fauxton 0

Apache CouchDB

Georift/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

Georift/degit 0

Straightforward project scaffolding

push eventmagda-io/magda

Jacky Jiang

commit sha cf37e7aa88591ae83f724c927a0f8614f7c087c0

Update docs for a broken link

view details

push time in a day

Pull request review commentmagda-io/magda

Update Ask A Question options

-import React from "react"; import PropTypes from "prop-types";  import MarkdownViewer from "Components/Common/MarkdownViewer"; import MagdaNamespacesConsumer from "Components/i18n/MagdaNamespacesConsumer"; import ToggleButton from "./ToggleButton"; import { gapi } from "analytics/ga"; +import React from "react";

Seems to be an issue with my code-editor's auto-formatting/auto-arranging, have fixed up the spacing now.

yayalu

comment created time in a day

Pull request review commentmagda-io/magda

Update Ask A Question options

 export default class DatasetPageSuggestForm extends React.Component {                 maxHeight: "95vh"             }         };+        let contactPointMatch;+        if (+            this.props?.contactPoint &&+            typeof this.props?.contactPoint === "string"+        ) {+            contactPointMatch = this.props.contactPoint.match(

Looks good! Thanks, fixed.

yayalu

comment created time in a day

Pull request review commentmagda-io/magda

Update Ask A Question options

 export default class DatasetPageSuggestForm extends React.Component {                 maxHeight: "95vh"             }         };+        let contactPointMatch;+        if (+            this.props?.contactPoint &&

Fixed

yayalu

comment created time in a day

push eventmagda-io/magda

yayalu

commit sha 82c09e91eca6e131440fd61a5849c5c118cc6a1b

Fixed import spacing

view details

push time in a day

push eventmagda-io/magda

yayalu

commit sha 8f8b4ea9db4c6acb55146b84ae8024b92ecf0a35

Updated regex in dataset page form and react import

view details

push time in a day

Pull request review commentmagda-io/magda

Update Ask A Question options

 export default class DatasetPageSuggestForm extends React.Component {                 maxHeight: "95vh"             }         };+        let contactPointMatch;+        if (+            this.props?.contactPoint &&+            typeof this.props?.contactPoint === "string"+        ) {+            contactPointMatch = this.props.contactPoint.match(

How about doing this? Current regex missed asd_ssd@dmail.com etc and unnecessarily captured whitespace. Plus, we already used regex no need to manually process the string

const emailRegex = /[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}/ig;
const matches = this.props.contactPoint.match(emailRegex);
contactPointMatch = matches?.length ? matches[0] : this.props.contactPoint;
yayalu

comment created time in 2 days

Pull request review commentmagda-io/magda

Update Ask A Question options

 export default class DatasetPageSuggestForm extends React.Component {                 maxHeight: "95vh"             }         };+        let contactPointMatch;+        if (+            this.props?.contactPoint &&

this.props?.contactPoint will never throw an error (even when contactPoint no exist). So line this.props?.contactPoint && can be dropped.

yayalu

comment created time in 2 days

Pull request review commentmagda-io/magda

Update Ask A Question options

-import React from "react"; import PropTypes from "prop-types";  import MarkdownViewer from "Components/Common/MarkdownViewer"; import MagdaNamespacesConsumer from "Components/i18n/MagdaNamespacesConsumer"; import ToggleButton from "./ToggleButton"; import { gapi } from "analytics/ga"; +import React from "react";

Could we please move the import React from "react"; back to the first line --- its position won't trigger CI errors

yayalu

comment created time in 2 days

Pull request review commentmagda-io/magda

Update Ask A Question options

 export default class DatasetPageSuggestForm extends React.Component {         };         const formProps = {             title: false,+            description:+                "Your question will be sent to the publishers of the data: " ++                this.props.contactPoint,             namePlaceHolder: "Dorothy Hill",             emailPlaceHolder: "dorothyhill@example.com",             textAreaPlaceHolder:                 "Ask a question or report a problem about this dataset.",             textAreaLabel: "What would you like to ask about this dataset?",-            successHeader: "Your request has been submitted!"+            successHeader:+                "Your request has been submitted to: " ++                this.props.contactPoint +

Hey Jacky, The desired functionality is to not send to the default recipient (data@digital.gov.au) when there is no contact email provided.

I believe if we update lines 187-194 in the /public/send/dataset/:datasetId/question endpoint, it would achieve this functionality.

We can use this

                const emails = [contactPointEmail, datasetPublisherEmail].filter(...)

                if (!validEmail) {
                    return res.status(404).json({
                        status: "Failed to send",
                        error:
                            "Could not find a contact email for the publisher"
                    });
                }

                const recipient = emails[0];

I believe the contactPointEmail corresponds to this.props.contactPoint?

yayalu

comment created time in 2 days

issue commentmagda-io/magda

Build and run docs need to add lerna as a prereq

➜  magda git:(master) yarn install
yarn install v1.22.10
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error @magda/acs-cmd@0.0.60-alpha.0: The engine "node" is incompatible with this module. Expected version ">=10.0.0 <13.0.0". Got "15.6.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
brendony

comment created time in 2 days

issue closedmagda-io/magda

Build and run docs need to add lerna as a prereq

Describe the bug I'm following the instructions here: https://magda.io/docs/building-and-running The yarn lerna ... step fails on my macos as I don't have lerna installed.

I'm trying to fix it using brew install lerna

Expected behavior The build should occur without problem when the dev follows instructions.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS 10.15.7

Additional context Add any other context about the problem here.

closed time in 2 days

brendony

issue commentmagda-io/magda

Build and run docs need to add lerna as a prereq

Hmm. Nevermind. This is probably due to me having the wrong version of node. I will fix that, and re-raise this issue if my problems persist.

brendony

comment created time in 2 days

issue openedmagda-io/magda

Build and run docs need to add lerna as a prereq

Describe the bug I'm following the instructions here: https://magda.io/docs/building-and-running The yarn lerna ... step fails on my macos as I don't have lerna installed.

I'm trying to fix it using brew install lerna

Expected behavior The build should occur without problem when the dev follows instructions.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS 10.15.7

Additional context Add any other context about the problem here.

created time in 2 days

push eventmagda-io/magda

yayalu

commit sha 31c0b70ba14bfdbce341af8b30bc228296e313f4

Revert "Fixed build-and-test warnings" This reverts commit c6445866f40c75147f1a1d1a4e813c35960fa850.

view details

yayalu

commit sha 038d334f73a7d0d04d9df345ee58374456a665a7

Update ContactPoint.js

view details

push time in 2 days

push eventmagda-io/magda

yayalu

commit sha c6445866f40c75147f1a1d1a4e813c35960fa850

Fixed build-and-test warnings

view details

push time in 2 days

push eventgregzaal/Texture-Haven

Greg

commit sha f9f0adb8d25a186325522533f350cfb244f27f1c

Move corporate sponsor code to core function

view details

push time in 2 days

startedbatect/batect

started time in 2 days

startedearthly/earthly

started time in 2 days

startednushell/nushell

started time in 2 days

push eventgregzaal/Texture-Haven

Greg

commit sha e80099efed3e998d1c38660763abffbff37329bf

Fix phpmyadmin link

view details

push time in 4 days

push eventgregzaal/Texture-Haven

Greg

commit sha d3484e0eca45e758579bbf1daa97f4c697129325

Remove ad function causing blank space

view details

push time in 4 days

push eventgregzaal/Texture-Haven

Greg

commit sha 10a3c51d74792ad670688aa0ed28fdaea1c8e526

Disable ads

view details

push time in 4 days

startedoliverschwendener/ueli

started time in 6 days

startedclient9/misspell

started time in 6 days

startedstackbit/sourcebit

started time in 9 days

PublicEvent

push eventgregzaal/Texture-Haven

Greg Zaal

commit sha 212cedccd17eb1bc6044783258446cab48cde633

Use unique ad codes from HDRI Haven for analytics

view details

push time in 10 days

push eventgregzaal/Texture-Haven

Greg Zaal

commit sha 75a2a80ca62431436fbc3ba42b794677209b6645

Remove square ad under downloads

view details

push time in 10 days