profile
viewpoint
Francesco Borzì FrancescoBorzi @AzerothCore Netherlands https://www.linkedin.com/in/francesco-borzi/ Live and let live. -- Shin

azerothcore/Keira3 81

Cross-platform Database Editor for AzerothCore

FrancescoBorzi/Bootstrap-image-upload-form 27

Example of image upload form without page refresh using Bootstrap, jQuery AJAX and PHP.

azerothcore/mod-duel-reset 11

Duel reset module for AzerothCore

FrancescoBorzi/ArenaStats 4

AzerothCore/TrinityCore tool to show Arena statistics

FrancescoBorzi/brew 3

Brew theme for my blog

FrancescoBorzi/bootstrap-mail 2

work in progress...

FrancescoBorzi/ckjm 2

Fragm calculation tool

AzerothShard/azerothcore-wotlk 1

AzerothCore - Continuing Sunwell Core Project! Based on Mangos -> TrinityCore -> SunwellCore

pull request commentazerothcore/azerothcore-wotlk

refactor(Core/BG): improvements to the queue system

Error getting analysis status for this pull request.

I can't see what's wrong

FrancescoBorzi

comment created time in 7 hours

MemberEvent

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 15ac57db9fbe160a1cf5293acb5c2487e5d2cbd2

chore(misc): wip

view details

push time in 12 hours

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 6720fc5cfbe010f57ada015ac156ef8061b19a99

chore(misc): wip

view details

push time in 13 hours

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 575afa8feba8bef089f953952d0e296a055441ab

chore: add note

view details

push time in 13 hours

PR opened azerothcore/azerothcore-wotlk

Reviewers
fix(Core/BG): improvements to the queue system Ready to be reviewed Waiting to be tested

<!-- WRITE A RELEVANT TITLE -->

CHANGES PROPOSED:

  • Apply CLang tidy improvements
  • Add additional checks in FillPlayersToBG (thanks @Yehonal )

TESTS PERFORMED:

  • Build run, etc...
  • Tested queuing BG in game

HOW TO TEST THE CHANGES:

  • Try to make BG starts in all possible combination (e.g. all cases described here: https://github.com/azerothcore/azerothcore-wotlk/pull/3082)

Target branch(es):

  • [x] Master

<!-- NOTE: You do not need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

<!-- Do not remove the instructions below about testing, they will help users to test your PR -->

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

+57 -61

0 comment

2 changed files

pr created time in 13 hours

create barnchFrancescoBorzi/azerothcore-wotlk

branch : bg-improvements

created branch time in 13 hours

push eventFrancescoBorzi/azerothcore-wotlk

iThorgrim

commit sha 2e597c06650d16c20492a16419272e24e6b9ea3b

fix(Core/Query): Update GroupMgr query to support MySQL 8.0 (#3068)

view details

push time in 15 hours

push eventazerothcore/azerothcore-wotlk

iThorgrim

commit sha 2e597c06650d16c20492a16419272e24e6b9ea3b

fix(Core/Query): Update GroupMgr query to support MySQL 8.0 (#3068)

view details

push time in 15 hours

PR merged azerothcore/azerothcore-wotlk

Reviewers
fix(Core/Query): Update GroupMgr query to support MySQL 8.0 Priority - High To Be Merged

DELETE GROUP < 1 Members

CHANGES PROPOSED:

TESTS PERFORMED:

  • Builds
  • Starting Server With MySQL 8.0 & MySQL 5.6

HOW TO TEST THE CHANGES:

  • Just start ur server

Target branch(es):

  • [x] Master

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

+4 -4

4 comments

1 changed file

iThorgrim-Hub

pr closed time in 15 hours

push eventFrancescoBorzi/azerothcore-wotlk

h0lysp4nk

commit sha 60b0c4201a7441cb852b318f3bf980d09c1a4461

fix(Core/Script): Felmyst (#2965) Co-authored-by: Barbz <BarbzYHOOL@users.noreply.github.com>

view details

AzerothCoreBot

commit sha d2f4ad6123f09638cc442d7b9d2c688867b25d32

Import pending SQL update file... Referenced commit(s): 60b0c4201a7441cb852b318f3bf980d09c1a4461

view details

push time in 15 hours

pull request commentazerothcore/azerothcore-wotlk

fix(Core/BG): do not start new BGs if there are BGs with free slots

@Yehonal I don't get your point, even if FillPlayersToBG should also be changed, we still don't want to go further down and start a new BG if the players have been invited inside it.

FrancescoBorzi

comment created time in a day

push eventFrancescoBorzi/azerothcore-wotlk

Knindza

commit sha 00ce59d2e99242312d4ff0a7b8dfad29759ac168

fix(DB/Creature): Deadmines (#2970) * Update damage done by several creatures within the dungeon

view details

AzerothCoreBot

commit sha 408a5152e93db3dc2af8e039c341fe7105196d41

Import pending SQL update file... Referenced commit(s): 00ce59d2e99242312d4ff0a7b8dfad29759ac168

view details

Francesco Borzì

commit sha 86f5c91427216d37ba12aa34f49f57ef09973ae3

fix(Core): solve issue with MariaDB (#3084)

view details

push time in a day

CommitCommentEvent

startedazerothcore/telegram-automated-db-backup

started time in 2 days

Pull request review commentazerothcore/azerothcore-wotlk

Update MySQL to Version 8.0

 if( WIN32 )       libmysql     PATHS       ${MYSQL_ADD_LIBRARIES_PATH}+      "C:/Program Files/MySQL/MySQL Server 8.0/lib/opt"       "C:/Program Files/MySQL/MySQL Server 5.7/lib/opt"-      "C:/Program Files/MySQL/MySQL Server 5.6/lib/opt"       "C:/Program Files/MySQL/lib"       "C:/MySQL/lib/debug"+      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\MySQL AB\\MySQL Server 8.0;Location]/lib"+      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\MySQL AB\\MySQL Server 8.0;Location]/lib/opt"       "[HKEY_LOCAL_MACHINE\\SOFTWARE\\MySQL AB\\MySQL Server 5.7;Location]/lib"       "[HKEY_LOCAL_MACHINE\\SOFTWARE\\MySQL AB\\MySQL Server 5.7;Location]/lib/opt"-      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\MySQL AB\\MySQL Server 5.6;Location]/lib"-      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\MySQL AB\\MySQL Server 5.6;Location]/lib/opt"+      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Wow6432Node\\MySQL AB\\MySQL Server 8.0;Location]/lib"+      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Wow6432Node\\MySQL AB\\MySQL Server 8.0;Location]/lib/opt"       "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Wow6432Node\\MySQL AB\\MySQL Server 5.7;Location]/lib"       "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Wow6432Node\\MySQL AB\\MySQL Server 5.7;Location]/lib/opt"-      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Wow6432Node\\MySQL AB\\MySQL Server 5.6;Location]/lib"-      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Wow6432Node\\MySQL AB\\MySQL Server 5.6;Location]/lib/opt"

@Kitzunu do we have this part on master? do we need it? I don't have Windows so I can't tell

Kitzunu

comment created time in 2 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/BG): do not start new BGs if there are BGs with free slots

 void BattlegroundQueue::BattlegroundQueueUpdate(BattlegroundBracketId bracket_id                 for (auto itr : m_SelectionPools[TEAM_ALLIANCE + i].SelectedGroups)                     BattlegroundMgr::InviteGroupToBG(itr, bg, itr->RealTeamID);         }++        if (!bg_template->isArena() && !bgsToCheck.empty()) {

I haven't tested such a scenario, however this should not be affected by my PR

FrancescoBorzi

comment created time in 2 days

Pull request review commentazerothcore/azerothcore-wotlk

wiki(Security): Add a security policy

+# Security Policy++## Supported Versions++We support these versions of AzerothCore:++| AzerothCore Branch | Supported          |+| ------------------ | ------------------ |+| master             | :white_check_mark: |++We support these versions of MySQL:++| MySQL Version | Supported          |+| ------------- | ------------------ |+| 5.6           | :white_check_mark: |+| 5.7           | :white_check_mark: |+| 8.0           | :x:                |

soon will be supported

Kitzunu

comment created time in 2 days

delete branch FrancescoBorzi/ngx-duration-picker

delete branch : renovate/karma-coverage-istanbul-reporter-3.x

delete time in 2 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 3bbc2fb39eb1f0dbf8f8e0208033467e9b732cdb

chore(deps): update dependency karma-coverage-istanbul-reporter to v3.0.3 (#255) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency karma-coverage-istanbul-reporter to v3.0.3

This PR contains the following updates:

Package Type Update Change
karma-coverage-istanbul-reporter devDependencies patch 3.0.2 -> 3.0.3

Release Notes

<details> <summary>mattlewis92/karma-coverage-istanbul-reporter</summary>

v3.0.3

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/BG): do not start new BGs if there are BGs with free slots

 void BattlegroundQueue::BattlegroundQueueUpdate(BattlegroundBracketId bracket_id                 for (auto itr : m_SelectionPools[TEAM_ALLIANCE + i].SelectedGroups)                     BattlegroundMgr::InviteGroupToBG(itr, bg, itr->RealTeamID);         }++        if (!bg_template->isArena() && !bgsToCheck.empty()) {

@Kitzunu sorry I wasn't clear enough:

I check if there are still BGs that are running AND that are NOT full. Under this condition, there is no reason to go further and start new BGs.

New BGs should be started when there are NO non-full BGs (so either when there are no BGs at all or when all the current BGs are full).

I hope it's clear now. If it's not clear yet, please let me know :)

FrancescoBorzi

comment created time in 2 days

pull request commentazerothcore/azerothcore-wotlk

fix(Core): solve issue with MariaDB

thanks all for the test feedback! really appreciated.

let's merge this next please

FrancescoBorzi

comment created time in 2 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/BG): do not start new BGs if there are BGs with free slots

 void BattlegroundQueue::BattlegroundQueueUpdate(BattlegroundBracketId bracket_id                 for (auto itr : m_SelectionPools[TEAM_ALLIANCE + i].SelectedGroups)                     BattlegroundMgr::InviteGroupToBG(itr, bg, itr->RealTeamID);         }++        if (!bg_template->isArena() && !bgsToCheck.empty()) {

It checks if there are non-empty BGs

FrancescoBorzi

comment created time in 2 days

issue commentazerothcore/azerothcore-wotlk

Erro Compile - QueryResult.h

@MagnusDevs please test this and let me know if it solves your issue:

#3084

MagnusDevs

comment created time in 2 days

issue commentazerothcore/azerothcore-wotlk

Fatal error: typedef redefinition with different types ('bool' vs 'char') typedef bool my_bool

@hlainin please test this and let me know if it solves your issue: https://github.com/azerothcore/azerothcore-wotlk/pull/3084

hlainin

comment created time in 2 days

PR opened azerothcore/azerothcore-wotlk

fix(Core): solve issue with MariaDB

ISSUES ADDRESSED:

  • Closes https://github.com/azerothcore/azerothcore-wotlk/issues/3083
  • Closes https://github.com/azerothcore/azerothcore-wotlk/issues/3080

TESTS PERFORMED:

  • Not tested

HOW TO TEST THE CHANGES:

Install AC using MariaDB

Target branch(es):

  • [x] Master

<!-- NOTE: You do not need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

<!-- Do not remove the instructions below about testing, they will help users to test your PR -->

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchFrancescoBorzi/azerothcore-wotlk

branch : fix-maria-db

created branch time in 2 days

issue commentazerothcore/azerothcore-wotlk

Fatal error: typedef redefinition with different types ('bool' vs 'char') typedef bool my_bool

I know the other issue has been reported first, however I'd actually prefer to keep @hlainin since he put more information

hlainin

comment created time in 2 days

IssuesEvent

push eventazerothcore/Keira3

renovate[bot]

commit sha f9f83de9fca5b225a7803d81d8936720a96c0627

fix(deps): update dependency ngx-toastr to v12.1.0 (#729) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

issue closedazerothcore/azerothcore-wotlk

Erro Compile - QueryResult.h

I already tried to do with the repository clean and had the same problem I commented on the change and it worked

https://media.discordapp.net/attachments/284406375495368704/715425421990297610/unknown.png?width=793&height=395

System: Debian 9

Fix commented from line 21 to 25

https://media.discordapp.net/attachments/284406375495368704/715427789293092905/unknown.png?width=265&height=67

closed time in 2 days

MagnusDevs

issue commentazerothcore/azerothcore-wotlk

Erro Compile - QueryResult.h

https://github.com/azerothcore/azerothcore-wotlk/issues/3083

MagnusDevs

comment created time in 2 days

PR merged azerothcore/Keira3

fix(deps): update dependency ngx-toastr to v12.1.0

This PR contains the following updates:

Package Type Update Change
ngx-toastr dependencies minor 12.0.1 -> 12.1.0

Release Notes

<details> <summary>scttcper/ngx-toastr</summary>

v12.1.0

Compare Source

Features
  • allow newestOnTop to be set for each toast and globally closes #​818 (162b64f)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+14 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

delete branch azerothcore/Keira3

delete branch : renovate/karma-coverage-istanbul-reporter-3.x

delete time in 2 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 145f644bce244f25e566fb40491a5a73b88976f1

chore(deps): update dependency karma-coverage-istanbul-reporter to v3.0.3 (#728) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

PR merged azerothcore/Keira3

chore(deps): update dependency karma-coverage-istanbul-reporter to v3.0.3

This PR contains the following updates:

Package Type Update Change
karma-coverage-istanbul-reporter devDependencies patch 3.0.2 -> 3.0.3

Release Notes

<details> <summary>mattlewis92/karma-coverage-istanbul-reporter</summary>

v3.0.3

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 525c4fc0e4fba5e0a27f36e6ca25794d87a4251d

chore(deps): update dependency ts-node to v8.10.2 (#254) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency ts-node to v8.10.2

This PR contains the following updates:

Package Type Update Change
ts-node devDependencies patch 8.10.1 -> 8.10.2

Release Notes

<details> <summary>TypeStrong/ts-node</summary>

v8.10.2

Compare Source

Fixed

Fixes #​1037: source maps broken on Windows. (#​1038)

Misc

Fix failing tests on node 6 (#​1035) Push coverage from Github Actions; remove TravisCI (#​1034) Run tests e2e against an npm pack && npm installed ts-node (#​1032) Run CI tests on Windows (#​1041) Run CI only once per commit on pull requests and master (#​1042)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 635e669827625135928187ac68a4a8629aa677f6

chore(deps): update dependency karma-jasmine to v3.3.0 (#727) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

PR merged azerothcore/Keira3

chore(deps): update dependency karma-jasmine to v3.3.0

This PR contains the following updates:

Package Type Update Change
karma-jasmine devDependencies minor 3.2.0 -> 3.3.0

Release Notes

<details> <summary>karma-runner/karma-jasmine</summary>

v3.3.0

Compare Source

Features
  • reporter: emit info events for suiteStarted/suiteDone (#​269) (7b73ce0)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 92231f4164e5959e35d49d504e53db19176b4fe3

chore(deps): update dependency karma-jasmine to v3.3.0 (#253) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency karma-jasmine to v3.3.0

This PR contains the following updates:

Package Type Update Change
karma-jasmine devDependencies minor 3.2.0 -> 3.3.0

Release Notes

<details> <summary>karma-runner/karma-jasmine</summary>

v3.3.0

Compare Source

Features
  • reporter: emit info events for suiteStarted/suiteDone (#​269) (7b73ce0)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

issue commentazerothcore/mod-cfbg

Joining an existing BG [$10]

I've updated the original issue with basically what IceNet said, which was the main problem here:

Confirmed Sometimes a new BG is opening. So we have 2 open BG with 4-5 players inside.

(the issue I've originally described, which I thought was just the root cause of the main problem, I was no longer able to reproduce, so maybe it was just my mistake back then).

I've realised that the main problem was a core issue, here's the fix:

https://github.com/azerothcore/azerothcore-wotlk/pull/3082

@IceNet can you please test it and let us know?

FrancescoBorzi

comment created time in 2 days

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha ab8faa6db5bcbd3a74d80cdd0e24f2c20bd97cad

fix(Core/BG): do not start new BGs if there are BGs with free slots This reverts commit 8612ffe0903272044add4a0fe4159e441ff1e2d1.

view details

push time in 2 days

PR opened azerothcore/azerothcore-wotlk

Reviewers
fix(Core/BG): do not start new BGs if there are BGs with free slots

CHANGES PROPOSED:

  • Prevent new Battlegrounds to start if there are already other Battlegrounds that have free slots
  • Happened mostly when a lot of players queued at the same time (for example when a BG just finished)

ISSUES ADDRESSED:

  • Closes https://github.com/azerothcore/mod-cfbg/issues/11

TESTS PERFORMED:

  • Build, run, etc... (OK)
  • Tried to reproduce the issue before the fix (OK)
  • Tried to reproduce the issue after the fix (OK)
  • Also tried to make a BG start when the current BG running is full (OK)
  • Also tried BG with bracket <80 (OK)

HOW TO TEST THE CHANGES:

For testing purposes, you can:

UPDATE battleground_template SET MinPlayersPerTeam = 1
UPDATE battleground_template SET MaxPlayersPerTeam = 2

This will make a BG start with 1 player per team, and will consider a BG as "full" when there are 2 players per team inside the BG.

Then in order to test it:

  1. Try to start a BG
  2. Try to add players to it until it's full
  3. Try to make another BG start

Also you can try to reproduce the original issue:

  • Try to make multiple players join BG at the same time, only 1 BG should start until it's full

Target branch(es):

  • [x] Master

<!-- NOTE: You do not need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

<!-- Do not remove the instructions below about testing, they will help users to test your PR -->

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

+8 -3

0 comment

2 changed files

pr created time in 2 days

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha d4115c3fdc0da9d2478b643022c998be84f5e6bf

Revert "fix(Core/BG): do not start new BGs if there are BGs with free slots" This reverts commit 8612ffe0903272044add4a0fe4159e441ff1e2d1.

view details

push time in 2 days

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 84446657e488e8e38bb5ea76e2d90fe68ff817eb

fix(Core/BG): do not start new BGs if there are BGs with free slots

view details

push time in 2 days

create barnchFrancescoBorzi/azerothcore-wotlk

branch : fix-multi-bg

created branch time in 2 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/Query): Update GroupMgr query to support MySQL 8.0

 void GroupMgr::LoadGroups()         CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE leaderGuid NOT IN (SELECT guid FROM characters)");          // Delete all groups with less than 2 members (or less than 1 for lfg groups)-        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) > 1)");+        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) >= 1)");

solved in chat

iThorgrim-Hub

comment created time in 2 days

pull request commentazerothcore/azerothcore-wotlk

fix(Core/Query): Update GroupMgr query to support MySQL 8.0

tested on Ubuntu 20.04 with MySQL 8. The server starts normally.

iThorgrim-Hub

comment created time in 2 days

push eventiThorgrim-Hub/azerothcore-wotlk

Francesco Borzì

commit sha 4385919b73eac18b14ce4a3b44a42203310617b6

chore: correction

view details

push time in 2 days

issue commentazerothcore/azerothcore-wotlk

Erro Compile - QueryResult.h

@MagnusDevs please indicate details about your system. MySQL version, AC commit hash, etc...

MagnusDevs

comment created time in 3 days

issue commentazerothcore/azerothcore-wotlk

Dungeon: Blackrock Depths; Golem and Constructs should attack

@r0m1ntik94 why can't you create a PR?

we can help if needed

wackinwallaby

comment created time in 3 days

issue commentazerothcore/forum

[Question] Mob Fanning

moved to forum

markvetwow

comment created time in 3 days

push eventFrancescoBorzi/azerothcore-wotlk

AciDCooL

commit sha 72614dd053f02a0d9cb6199560c374537ac37dc4

fix(Docker): Mysql Password (#3061)

view details

Francesco Borzì

commit sha 428133dc5e7a310354f51ac78222b4ecaead9625

fix(Core/Mysql): my_bool type conflict (#3060)

view details

Stefano Borzì

commit sha 3c5bb73f29f213050b98511367ef0773105561c1

fix(Core/ChatHandler): Prevent messages > 255 characters (#3063)

view details

lineagedr

commit sha 2743874e5da893c18f6ae19f88dcf944cf4cfc8b

fix(Core/Script): Trial of the Crusader (#2888) * The floor will remain broken after a wipe * Anub'arak will respawn correctly after wiping

view details

Kitzunu

commit sha 027c42fdec66de82aac036d5071aacaf707d3312

refactor(Core/Command): tele to teleport (#2956)

view details

AzerothCoreBot

commit sha d1e83f6e3d6255802e123845f3377685d9b78695

Import pending SQL update file... Referenced commit(s): 027c42fdec66de82aac036d5071aacaf707d3312

view details

push time in 3 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/Query): Update GroupMgr query to support MySQL 8.0

 void GroupMgr::LoadGroups()         CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE leaderGuid NOT IN (SELECT guid FROM characters)");          // Delete all groups with less than 2 members (or less than 1 for lfg groups)-        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) > 1)");+        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) >= 1)");

PS: in TC it's HAVING COUNT(guid) > 1) why should it be different for us?

iThorgrim-Hub

comment created time in 3 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/Query): Update GroupMgr query to support MySQL 8.0

 void GroupMgr::LoadGroups()         CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE leaderGuid NOT IN (SELECT guid FROM characters)");          // Delete all groups with less than 2 members (or less than 1 for lfg groups)-        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) > 1)");+        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) >= 1)");

also where is this condition applied (or less than 1 for lfg groups) ?

iThorgrim-Hub

comment created time in 3 days

Pull request review commentazerothcore/azerothcore-wotlk

fix(Core/Query): Update GroupMgr query to support MySQL 8.0

 void GroupMgr::LoadGroups()         CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE leaderGuid NOT IN (SELECT guid FROM characters)");          // Delete all groups with less than 2 members (or less than 1 for lfg groups)-        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) > 1)");+        CharacterDatabase.DirectExecute("DELETE FROM `groups` WHERE guid NOT IN (SELECT guid FROM group_member GROUP BY guid HAVING COUNT(guid) >= 1)");

@iThorgrim-Hub @Kitzunu why this change?

iThorgrim-Hub

comment created time in 3 days

delete branch azerothcore/Keira3

delete branch : renovate/serialize-javascript-3.x

delete time in 3 days

push eventazerothcore/Keira3

renovate[bot]

commit sha b1b60633d0eed542f899081d2eff362287d1047b

fix(deps): update dependency serialize-javascript to v3.1.0 (#725) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 3 days

PR merged azerothcore/Keira3

fix(deps): update dependency serialize-javascript to v3.1.0

This PR contains the following updates:

Package Type Update Change
serialize-javascript dependencies minor 3.0.0 -> 3.1.0

Release Notes

<details> <summary>yahoo/serialize-javascript</summary>

v3.1.0

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+7 -5

0 comment

2 changed files

renovate[bot]

pr closed time in 3 days

delete branch FrancescoBorzi/ngx-duration-picker

delete branch : renovate/karma-jasmine-3.x

delete time in 3 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 9965ece958804e72f37519181300c9d141ca90b3

chore(deps): update dependency karma-jasmine to v3.2.0 (#252) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 3 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency karma-jasmine to v3.2.0

This PR contains the following updates:

Package Type Update Change
karma-jasmine devDependencies minor 3.1.1 -> 3.2.0

Release Notes

<details> <summary>karma-runner/karma-jasmine</summary>

v3.2.0

Compare Source

Features
  • results: forward passedExpectations and properties (#​268) (ad1d7dd)

3.1.1 (2020-02-11)

Bug Fixes

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 3 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 6894225cc4db3adc9800fe672729608d8d6c9c38

chore(deps): update dependency electron-builder to v22.7.0 (#724) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 3 days

PR merged azerothcore/Keira3

chore(deps): update dependency electron-builder to v22.7.0

This PR contains the following updates:

Package Type Update Change
electron-builder devDependencies minor 22.6.1 -> 22.7.0

Release Notes

<details> <summary>electron-userland/electron-builder</summary>

v22.7.0

Compare Source

Bug Fixes
Features

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+88 -70

0 comment

2 changed files

renovate[bot]

pr closed time in 3 days

pull request commentazerothcore/azerothcore-wotlk

fix(Core/Query): Update GroupMgr query to support MySQL 8.0

HOW TO TEST THE CHANGES: Just start ur server

eemh no, we need to test when actually the query is called:

// Delete all groups with less than 2 members (or less than 1 for lfg groups)

and make sure that everything is ok

iThorgrim-Hub

comment created time in 4 days

delete branch azerothcore/Keira3

delete branch : renovate/mysql-2.x

delete time in 4 days

push eventazerothcore/Keira3

renovate[bot]

commit sha b58d38f224578bba75f03a0b10dd46ed2e982d0b

chore(deps): update dependency @types/mysql to v2.15.13 (#722) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 4 days

PR merged azerothcore/Keira3

chore(deps): update dependency @types/mysql to v2.15.13

This PR contains the following updates:

Package Type Update Change
@types/mysql devDependencies patch 2.15.12 -> 2.15.13

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 4 days

delete branch azerothcore/Keira3

delete branch : renovate/karma-jasmine-3.x

delete time in 4 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 7c23c47f3604ef79af98f4de375eac17727c8dfc

chore(deps): update dependency karma-jasmine to v3.2.0 (#723) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 4 days

PR merged azerothcore/Keira3

chore(deps): update dependency karma-jasmine to v3.2.0

This PR contains the following updates:

Package Type Update Change
karma-jasmine devDependencies minor 3.1.1 -> 3.2.0

Release Notes

<details> <summary>karma-runner/karma-jasmine</summary>

v3.2.0

Compare Source

Features
  • results: forward passedExpectations and properties (#​268) (ad1d7dd)

3.1.1 (2020-02-11)

Bug Fixes

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 4 days

issue commentazerothcore/azerothcore-wotlk

Some Vector Error

OPERATING SYSTEM: Ubuntu 20.04

I'm afraid this is related with clang 10 (which we should fix asap)

iThorgrim-Hub

comment created time in 4 days

issue commentazerothcore/azerothcore-wotlk

Unknow type name 'my_bool'

@iThorgrim-Hub thanks a lot for your feedbac, just 2 notes:

  • we should not close the issue until it's solved on master
  • better to leave the test results in the PR discussion (not in the issue)
iThorgrim-Hub

comment created time in 4 days

IssuesEvent

Pull request review commentazerothcore/Keira3

Remove useless toolbar

 function createWindow() {     },     icon: 'src/assets/img/ac.png',   });-+  win.setMenuBarVisibility(false)

it would be nicer to add an alternative toolbar instead of just hiding the current one. In the new toolbar we need the same shortcuts we currently have (e.g. ctrl + shift + i to open the developer console)

Hidoyatmz

comment created time in 5 days

Pull request review commentazerothcore/Keira3

Remove useless toolbar

 {   "name": "Keira3",-  "version": "3.0.0-beta.4",+  "version": "3.0.0-rc.0",

these changes aren't related with the PR's title

Hidoyatmz

comment created time in 5 days

Pull request review commentazerothcore/Keira3

Remove useless toolbar

 export const CONDITION_DISTANCE_TO_CV3: Option[] = [   { value: 1,	name: 'Distance must be higher than ConditionValue2' },   { value: 2,	name: 'Distance must be lower than ConditionValue2' },   { value: 3,	name: 'distance must be equal to or higher than ConditionValue2' },-  { value: 3,	name: 'distance must be equal to or lower than ConditionValue2' },+  { value: 4,	name: 'distance must be equal to or lower than ConditionValue2' },

these changes aren't related with the PR's title

Hidoyatmz

comment created time in 5 days

Pull request review commentazerothcore/Keira3

fix some codacy stuff

  .ngx-datatable.bootstrap {   background-color: $content-block-bg-color;-   box-shadow: none;   font-size: 13px;+   .datatable-header {     height: unset !important;     background-color: $content-block-bg-color;+     .datatable-header-cell {       vertical-align: bottom;       padding: 0.75rem;       border-left: 1px solid #e7e7e7;       line-height: 1;+       .datatable-header-cell-label {         line-height: 24px;         font-weight: 600;       }     }+     .datatable-header-cell:first-child {       border-left: 0;     }   }+   .datatable-body {     border-collapse: collapse;+     .datatable-body-row {       vertical-align: top;       border-top: 1px solid #e7e7e7;       background-color: #f7f7f7;+       &.datatable-row-even {         background-color: $content-block-bg-color;       }+       &:hover {         background-color: #eee;       }-      &.active {+      // &.active {         //background-color: blue;         //font-weight: 600;-      }+      // }

ah ok ok

Kitzunu

comment created time in 5 days

Pull request review commentazerothcore/Keira3

fix some codacy stuff

 $secondary-color-green: #b7e2ad;       bottom: 10px;       left: 50%;       transform: translateX(-50%);-      a, a:hover {++      a::before,+      a:hover::before {

ok I need to have a look at that, everything else is good

Kitzunu

comment created time in 5 days

pull request commentazerothcore/azerothcore-wotlk

fix(Core/Mysql): my_bool type conflict

@Kitzunu let's merge this tonight or tomorrow. Then you can update your mysql8 PR with the latest master and possibly it will be ready to go.

FrancescoBorzi

comment created time in 5 days

pull request commentazerothcore/azerothcore-wotlk

[Zone] Ashenvale

@merdlin thanks, did you test all creatures from the PR?

Knindzagxg

comment created time in 5 days

pull request commentazerothcore/azerothcore-wotlk

mysqladmin use the right credentials

thanks a lot @AciDCooL and @h0lysp4nk !

AciDCooL

comment created time in 5 days

Pull request review commentazerothcore/azerothcore-wotlk

Update MySQL to Version 8.0

 class PreparedResultSet         MYSQL_STMT* m_stmt;         MYSQL_RES* m_res; -        my_bool* m_isNull;+        bool* m_isNull;

@Kitzunu try to revert this change + apply this PR:

https://github.com/azerothcore/azerothcore-wotlk/pull/3060

Kitzunu

comment created time in 5 days

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 31737138565805d6f5f5a8d25b420176a077ffc7

Revert "fix(Core/Mysql): my_bool type conflict" This reverts commit 414612e253efdc2db02c9d20ca93ae4ae870305a.

view details

FrancescoBorzi

commit sha ea060dc8fd42cb5e5ede59696f3570dda578be89

chore(misc): wip

view details

push time in 5 days

PR opened azerothcore/azerothcore-wotlk

fix(Core/Mysql): my_bool type conflict

CHANGES PROPOSED:

  • Attempt to fix the my_bool type issu

ISSUES ADDRESSED:

TODO

TESTS PERFORMED:

  • build
  • TODO: more tests

HOW TO TEST THE CHANGES:

Please try to build and run this using MariaDB and/or Windows

Target branch(es):

  • [x] Master

<!-- NOTE: You do not need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

<!-- Do not remove the instructions below about testing, they will help users to test your PR -->

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

+14 -1

0 comment

3 changed files

pr created time in 5 days

create barnchFrancescoBorzi/azerothcore-wotlk

branch : fix-my-bool

created branch time in 5 days

push eventFrancescoBorzi/azerothcore-wotlk

Arthas Wow

commit sha 6780dcfbb3166d77d7fc1c1c1c839e981d614a2c

fix(DB/Quest): More locations to complete Patching Up (#2853) * Added gameobjects to more Geysers so you can complete the quest at more spots Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

view details

AzerothCoreBot

commit sha 5d38d69c01cc998cfce04c66f5fa324f854c7235

Import pending SQL update file... Referenced commit(s): 6780dcfbb3166d77d7fc1c1c1c839e981d614a2c

view details

Kitzunu

commit sha fe1815d48b1ba899560b0715aa159752cdc95bac

Fix(DB/Dungeon): The Nexus (#2914) Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>

view details

AzerothCoreBot

commit sha 49cff4ab9ec2a5a84a767c6fd6a597eb430ab721

Import pending SQL update file... Referenced commit(s): fe1815d48b1ba899560b0715aa159752cdc95bac

view details

Unkacco

commit sha f14f750639a86d788cad46a84ce72eb38e9447de

fix(DB/SAI): Grizzly Hills transport (#2765) * Alliance and Horde transports going towards the two bases in Venture Bay has been added

view details

AzerothCoreBot

commit sha cdf518aba1d16e6a45d363859aa073e0c0170edf

Import pending SQL update file... Referenced commit(s): f14f750639a86d788cad46a84ce72eb38e9447de

view details

Kitzunu

commit sha e37c11458d49c3eeaea260661dc1652021107c5f

fix(DB/Item): Tome of Tranquilizing Shot Deprecated (#2768)

view details

AzerothCoreBot

commit sha e4b0a54b8225e48e76833e653cd47340473b9818

Import pending SQL update file... Referenced commit(s): e37c11458d49c3eeaea260661dc1652021107c5f

view details

Dresmyr

commit sha f1b44029c85b9e25318ba84a099b4103e0d98f4e

feat(Core/Config): Configurable buy/sell rates (#2763)

view details

Kitzunu

commit sha d3805051063edfa54df5778192ae0e70138d8806

fix(DB/Item): Chest of Spoils loot (#2769) * Gold will now be dropped from Chest of Spoils

view details

AzerothCoreBot

commit sha 4947ba67b0ebd3240ea8f0daecf74b611486f92c

Import pending SQL update file... Referenced commit(s): d3805051063edfa54df5778192ae0e70138d8806

view details

Kitzunu

commit sha 8014aee8308177514dc9d1e9a621b5b74a2bc0de

fix(DB/Quest): Shoot 'Em Down (#2915) * You will no longer get stuck in combat with Jotunheim Proto-Drake * Health of Jotunheim Proto-Drake has been corrected

view details

AzerothCoreBot

commit sha 03a7becfb133c4178ad705c55056b84b14df9e24

Import pending SQL update file... Referenced commit(s): 8014aee8308177514dc9d1e9a621b5b74a2bc0de

view details

Kitzunu

commit sha fedd6577f1c530affff4acf29c41ff7f0694e662

fix(DB/Creature): Stinky aura (#2860)

view details

AzerothCoreBot

commit sha b429b7331d5d0eabd1835c39e0afa2ce86834ced

Import pending SQL update file... Referenced commit(s): fedd6577f1c530affff4acf29c41ff7f0694e662

view details

LukasVolgger

commit sha 75d4fb3dff42ad79f727fde86dfae5da62ba414e

fix(DB/reputation): Kurenai and Mag'har reputation amount rewarded (#2783) Correct reputation amount

view details

AzerothCoreBot

commit sha 909b05bbf988f854c103f5694f1fec3bef36802e

Import pending SQL update file... Referenced commit(s): 75d4fb3dff42ad79f727fde86dfae5da62ba414e

view details

Barbz

commit sha f4e1155302d62e297b7143946df6d5861fac3f89

feat(CORE/command): .account onlinelist orders accounts by IP (#2934) * Accounts will now be grouped by IP for easier detection of multiboxers

view details

IntelligentQuantum

commit sha fd4b35be8c37d5c5456abca7fe8060a4f2fafa92

feat(Core/commands): Display reason for muting player (#2780)

view details

LukasVolgger

commit sha 3655cdae766f5a57f82c0b7b4730074af1ba10ce

feat(DB): Import german quest_request_items texts from GTDB (Part 4/4) (#2787) Co-authored-by: Endeffect93 <55922592+Endeffect93@users.noreply.github.com>

view details

push time in 5 days

issue openedazerothcore/forum

[TOOL] Creating video tutorials for Keira3

Now that all major features of Keira3 are available, it would be nice if someone could create videos about it.

Some ideas for videos could be:

  • A general introduction to Keira3
  • Tutorial: how to create/edit a Creature using Keira3
  • Tutorial: how to create/edit a Quest using Keira3
  • Tutorial: how to create/edit a Gameobject using Keira3
  • Tutorial: how to create/edit an Item using Keira3
  • Tutorial: how to work with Gossips using Keira3
  • Tutorial: how to work with Conditions using Keira3
  • Tutorial: how to work with Loots using Keira3
  • Tutorial: how to work with SmartAI using Keira3

any of the above would be nice to have. Also showing the result of the work in-game would be very nice.

I have no experience in making videos and I don't have much time for it, so I'm looking for volunteers that could create some videos about this topic.

I feel like Keira3 has great potential and many people just don't know it yet!

created time in 5 days

pull request commentazerothcore/Keira3

fix some codacy stuff

mostly it looks good, just a couple of comments

but please test it well before merging

Kitzunu

comment created time in 6 days

Pull request review commentazerothcore/Keira3

fix some codacy stuff

  .ngx-datatable.bootstrap {   background-color: $content-block-bg-color;-   box-shadow: none;   font-size: 13px;+   .datatable-header {     height: unset !important;     background-color: $content-block-bg-color;+     .datatable-header-cell {       vertical-align: bottom;       padding: 0.75rem;       border-left: 1px solid #e7e7e7;       line-height: 1;+       .datatable-header-cell-label {         line-height: 24px;         font-weight: 600;       }     }+     .datatable-header-cell:first-child {       border-left: 0;     }   }+   .datatable-body {     border-collapse: collapse;+     .datatable-body-row {       vertical-align: top;       border-top: 1px solid #e7e7e7;       background-color: #f7f7f7;+       &.datatable-row-even {         background-color: $content-block-bg-color;       }+       &:hover {         background-color: #eee;       }-      &.active {+      // &.active {         //background-color: blue;         //font-weight: 600;-      }+      // }

?

Kitzunu

comment created time in 6 days

Pull request review commentazerothcore/Keira3

fix some codacy stuff

 $secondary-color-green: #b7e2ad;       bottom: 10px;       left: 50%;       transform: translateX(-50%);-      a, a:hover {++      a::before,+      a:hover::before {

shouldn't it be:

a,
a:hover {

I don't see why we should add ::before

Kitzunu

comment created time in 6 days

pull request commentazerothcore/Keira3

fix some codacy stuff

@Kitzunu did you test this? I mean, by having a look around the app and check that all the UI is fine

Kitzunu

comment created time in 6 days

issue closedazerothcore/forum

[TOOL] Keira3 Beta

After 6 months of development, we are glad to announce the first Beta release of Keira3, the DB editor for AzerothCore.

This means that all the major features that we've planned for version 3.0.0 have been implemented. More improvements, bug fixes, and small features will be added in the upcoming Beta releases.

You can find the changelog and download of all releases here: https://github.com/azerothcore/Keira3/releases

SmartAI Editor

In the scope of this release we've implemented the SAI Editor, one of the most requested feature:

image

The SAI Editor features tooltips and dynamic names for all the Events/Actions/Targets and their parameters.

You can search for existing SAI scripts or select an entity:

image

Alternatively, you can use the Creature or Gameobject editor and use the new SmartAI tab:

image

You can easily change the event's phase and flags:

image

image

Other features

We've also implemented other features that were requested by our users, such as the Logout and the Notifications

image

Feedback

You can give us your feedback by opening issues to report bugs or feature requests.

Support us

As we work on Keira3 in our free time, you can support us with a donation.

-- Shin && @Helias

closed time in 6 days

FrancescoBorzi

issue commentazerothcore/forum

[TOOL] Keira3 Beta

Keira3 has now reached its first Release candidate:

https://github.com/azerothcore/Keira3/releases

all major features planned for 3.0.0 have been implemented.

FrancescoBorzi

comment created time in 6 days

created tagazerothcore/Keira3

tagv3.0.0-rc.0

Cross-platform Database Editor for AzerothCore

created time in 6 days

more