Francesco Borzì FrancescoBorzi Netherlands https://www.linkedin.com/in/francesco-borzi/ Live and let live. -- Shin

Pull request review commentazerothcore/azerothcore-wotlk

fix(DB/Creature): Coilskar defender

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1555929516205604900');++-- Coilskar defender updated flag to Only Swim+UPDATE `creature_template` SET `unit_flags`='32768' WHERE `entry`=19762;+-- Coilskar defender remove extra flag+UPDATE `creature_template` SET `flags_extra`='0' WHERE `entry`=19762;

it's fine, I will write a tutorial about how to better deal with flags. But this can be merged already.

poszer

comment created time in 9 hours

pull request commentazerothcore/azerothcore-wotlk

Bloodmyst Isle missing SAI

Don't forget about http://www.azerothcore.org/wiki/Dealing-with-SQL-files#write-compact-code

Knindzagxg

comment created time in 12 hours

Pull request review commentazerothcore/azerothcore-wotlk

[Hunter] Exotic pets, talents and Stables

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1555648621681705600');++INSERT INTO spell_script_names VALUES

please, always use DELETE before INSERT

Pondaveia

comment created time in 12 hours

Pull request review commentazerothcore/azerothcore-wotlk

fix(DB/Creature): NPC Ethereum guardian

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1555926066020418100');++-- Remove UNIT_FLAG_IMMUNE_TO_PC from NPC 'Ethereum guardian'+UPDATE `creature_template` SET `unit_flags`='0' WHERE `entry`=20854;

just a note: this is not the best way to deal with flags, but it's OK to merge this since it has already been tested and approved.

However I've created a TODO in the wiki so we don't forget to do this: https://github.com/azerothcore/wiki/issues/39

poszer

comment created time in 12 hours

Pull request review commentazerothcore/azerothcore-wotlk

fix(DB/Creature): Coilskar defender

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1555929516205604900');++-- Coilskar defender updated flag to Only Swim+UPDATE `creature_template` SET `unit_flags`='32768' WHERE `entry`=19762;+-- Coilskar defender remove extra flag+UPDATE `creature_template` SET `flags_extra`='0' WHERE `entry`=19762;

ideally we should:

  1. use a single UPDATE statement
  2. just use numbers (and not strings) for numeric values
UPDATE `creature_template` SET `unit_flags`=32768, `flags_extra`=0 WHERE `entry`=19762;
  1. ...and also, it is a good practice to properly remove/add flags using bitwise operators (but I don't know exactly which flags you are adding/removing here)
poszer

comment created time in 12 hours

Pull request review commentazerothcore/azerothcore-wotlk

fix(DB/Creature): Dalaran creatures speech

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1556034383320746900');++DELETE FROM `creature_text` WHERE `CreatureID`=32718 AND `GroupID`=0 AND `ID`=0;+INSERT INTO `creature_text` (`CreatureID`, `GroupID`, `ID`, `Text`, `Type`, `Language`, `Probability`, `Emote`, `Duration`, `Sound`, `BroadcastTextId`, `TextRange`, `comment`) VALUES (32718, 0, 0, 'Be well champion.', 12, 0, 50, 0, 0, 0, 0, 0, 'Dalaran shamy');++DELETE FROM `creature_text` WHERE `CreatureID`=32714 AND `GroupID`=0 AND `ID`=0;+INSERT INTO `creature_text` (`CreatureID`, `GroupID`, `ID`, `Text`, `Type`, `Language`, `Probability`, `Emote`, `Duration`, `Sound`, `BroadcastTextId`, `TextRange`, `comment`) VALUES (32714, 0, 0, 'Elune bless you champion.', 12, 0, 100, 0, 0, 0, 0, 0, 'Dalaran priest');++DELETE FROM `creature_text` WHERE `CreatureID`=32720 AND `GroupID`=0 AND `ID`=0;+INSERT INTO `creature_text` (`CreatureID`, `GroupID`, `ID`, `Text`, `Type`, `Language`, `Probability`, `Emote`, `Duration`, `Sound`, `BroadcastTextId`, `TextRange`, `comment`) VALUES (32720, 0, 0, 'Good to see you champion.', 12, 0, 50, 0, 0, 0, 0, 0, 'Dalaran mage');

please always use compact SQL code: http://www.azerothcore.org/wiki/Dealing-with-SQL-files#write-compact-code

you can change the above code by using only one DELETE and one INSERT

Knindzagxg

comment created time in 12 hours

pull request commentazerothcore/azerothcore-wotlk

feat(SmartAI): import SMART_EVENT_FLAG_WHILE_CHARMED from TC

@poszer thanks for the feedback. What about the 2 quests pointed by @comix1988 (in bold) that appear to be broken by this PR ?

Maybe @wetbrownsauce can also help here, since this is a big change

FrancescoBorzi

comment created time in 12 hours

Pull request review commentazerothcore/wiki

Alternative cmake command for linux users.

 At this point, you must be in your "build/" directory. cmake ../ -DCMAKE_INSTALL_PREFIX=$HOME/azeroth-server/ -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DTOOLS=0 -DSCRIPTS=1 ``` +**Alternative cmake command for linux users**+You can add your azerothcore source path after cmake, like so+```+cmake ../azerothcore-wotlk -DCMAKE_INSTALL_PREFIX=$HOME/azeroth-server/ -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DTOOLS=0 -DSCRIPTS=1

I don't get this. If you follow this guide, you will currently located at:

.../azerothcore/build

mindsear

comment created time in 14 hours

issue commentazerothcore/forum

[GENERAL] at a high level, how does AC work?

Thanks a lot @Frichetten for your interest in AzerothCore! I reopen the question because I think it's worth answering it.

I stood up an AC server earlier today, and frankly I'm stunned. A few Docker commands and a few tweaks and suddenly I'm playing Wotlk circa 2009. From what little I've played it appears like everything is working pretty flawlessly.

I'm really glad to hear it, thanks for sharing your experience!

I'm aware this is a dumb question, but how is this all working? As in, was this made entirely by monitoring the network traffic between the client and server and then building a server to mimic that traffic? A better question, in this recreation, how does it know where to put NPCs? Did someone meticulously examine the retail version and recreate all of their paths and where they stand?

The work behind this project has been HUGE and it's the outcome of years of development within different projects (MaNGOS, TrinityCore, SunwellCore, AzerothCore) from hundreds of contributions. I find it to be one of the best example of what can be achieved with open source and international collaboration. I believe even the best developers couldn't do this job alone. All small details, all the single NPCs where added by volunteers with time.

See: https://github.com/azerothcore/azerothcore-wotlk#authors--contributors

Frichetten

comment created time in 17 hours

IssuesEvent

push eventopencollective/azerothcore-wotlk

Francesco Borzì

commit sha 6b0cf72076b78d234b557504bc977cb646cc5ac7

Update README.md

view details

push time in 2 days

pull request commentazerothcore/mod-npc-gambler

Port Styx's latest code to AC

good job @gtao725 and @milestorme

gtao725

comment created time in 5 days

push eventazerothcore/mod-npc-gambler

ColdFusion

commit sha 4727f5531efe80b62be05903ae8e273dd5a9ed86

Merge pull request #3 from gtao725

view details

push time in 5 days

PR merged azerothcore/mod-npc-gambler

Port Styx's latest code to AC

All improvements and bug fixes to date from Styx are included.

+449 -166

5 comments

4 changed files

gtao725

pr closed time in 5 days

pull request commentFrancescoBorzi/ngx-duration-picker

Preview format

@superdyzio feel free to add a new instance of the ngx-duration-picker in the e2e tests ;)

superdyzio

comment created time in 5 days

push eventazerothcore/azerothcore-wotlk

Nefertumm

commit sha fe17a0ecccb99ef96b901cdb0b4e16088c32eff6

fix(Core/DB): Hardcoded text - Eastern Kingdoms (#1640)

view details

push time in 5 days

PR merged azerothcore/azerothcore-wotlk

Fix(Core/DB): Hardcoded text - Eastern Kingdoms To Be Merged

<!-- First of all, THANK YOU for your contribution. Please fill this template unless your PR is very simple/straightforward. Do not forget to have a look at our Pull Request tutorial: http://www.azerothcore.org/wiki/Contribute#how-to-create-a-pull-request -->

<!-- WRITE A RELEVANT TITLE -->

CHANGES PROPOSED:
  • Use db data in order to allow translations with gossips and texts
  • Moved Kharan Mighthammer to DB
  • Added some overrides and some NULL to nullptr
TESTS PERFORMED:

<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed -->

Build and tested some of them.

HOW TO TEST THE CHANGES:

<!-- We need to confirm the changes first, so try to make the work easy for testers, please:

  • Which commands to use? Which NPC to teleport to?
  • Do we need to enable debug flags on Cmake?
  • Do we need to look at the console? etc...
  • Other steps -->

Check if all the changed gossips are working as before. Check (if possible with locale != us) if all the changed monster yells are working as before.

KNOWN ISSUES AND TODO LIST:

<!-- This is a TODO list with checkboxes to tick -->

  • [ ] There are some other gossips to change.
Target branch(es):

Master

<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

+287 -349

8 comments

11 changed files

Nefertumm

pr closed time in 5 days

push eventazerothcore/azerothcore-wotlk

Stoabrogga

commit sha a89f2f16264c58b444c6de2bad7d85bf203de3d8

Fix(DB/Core): Dragonmaw Peon AI (#1722)

view details

AzerothCoreBot

commit sha 7eb703e70892c010eab483bbc1648154be4fcef8

Import pending SQL update file... Referenced commit(s): 3763792d70ac5c00aed3176d132528019859ddc9 a89f2f16264c58b444c6de2bad7d85bf203de3d8

view details

FrancescoBorzi

commit sha bcc26e0c3929cd2400159a3d7f3c0744a77e5d99

Merge branch 'master' into staging

view details

push time in 6 days

push eventFrancescoBorzi/azerothcore-wotlk

Francesco Borzì

commit sha 97e7e2228e9b66e15d307f97c1b05160dd612aaa

fix(Docker): allow to use modules (#1558)

view details

Pondaveia

commit sha edec48f1797f94b41a92d1138c11f9865dfd52a8

Fix(DB/SAI): Desolace AI for centaurs (#1682)

view details

AzerothCoreBot

commit sha 1d8b3ec1ff15c127bafbd2c27580fe42ecf6cf04

Import pending SQL update file... Referenced commit(s): edec48f1797f94b41a92d1138c11f9865dfd52a8

view details

TheHighlord

commit sha 2ce10cf609238872e157eacf8602f4e45ec01e59

Fix(Core/Spells): Fix parry aura spells (#1694)

view details

Barbz

commit sha b72b4a45bca4779d082ea0236494c29bdb4db2ea

chore(git): Add a commit template & introduce new guidelines (#1044) * chore(git): Add a commit template & introduce new guidelines Introduce new guidelines for commit titles and descriptions: - More useful and unique commit titles - Useful descriptions - Maybe the use of automated changelogs in the future (see link) https://www.conventionalcommits.org/en/v1.0.0-beta.2/ * chore(git): Improve title examples * Update .git_commit_template.txt

view details

Stoabrogga

commit sha 0614bdf9432f2f720a270c07ea2bc0d1f29b747c

fix(DB/SAI): Shadowlord Deathwail (#1705)

view details

AzerothCoreBot

commit sha 135b4470ce85860968f6f47cf0f77ed00c659ebf

Import pending SQL update file... Referenced commit(s): 0614bdf9432f2f720a270c07ea2bc0d1f29b747c

view details

Pondaveia

commit sha c1ebc70b58454a651629327ea9f30373348b1a3c

feat(core): Increased limit of realms (#1664)

view details

AzerothCoreBot

commit sha a0cb2c0b7c665069e3afb3565e049e8be9093b09

Import pending SQL update file... Referenced commit(s): c1ebc70b58454a651629327ea9f30373348b1a3c

view details

Pondaveia

commit sha a1114b37353b18a1a32304aa76188c380a70aa27

fix(DB): Training the Beast quest reward text (#1714)

view details

AzerothCoreBot

commit sha 6aeab39af30d6a9e296a73820b9a7d9adde15c1d

Import pending SQL update file... Referenced commit(s): a1114b37353b18a1a32304aa76188c380a70aa27

view details

Poszer

commit sha 5480c1a11273cb4242b108e5bef613b5f7f0442e

DB/Creature: Grom'tor, Son of Oronok (#1716)

view details

AzerothCoreBot

commit sha 4ded62ba653f9f24392eb12fc5f899e9d8652373

Import pending SQL update file... Referenced commit(s): 5480c1a11273cb4242b108e5bef613b5f7f0442e

view details

Pondaveia

commit sha 28bd4ce9ac35be9ff58e2a529e7bf5e4ee4eeab8

changes to loot from Trinitycore (#1715)

view details

AzerothCoreBot

commit sha 9ba2e55448a52c8f45e72d44f5ec23f66eacd31b

Import pending SQL update file... Referenced commit(s): 28bd4ce9ac35be9ff58e2a529e7bf5e4ee4eeab8

view details

Kargatum

commit sha 6150b4b9480b054ca3df6fc4939d119b882ff9f1

feat(Cmake/MYSQL): Correct support MariaDB for windows (#1674) * Delete CMake option MARIADB * Delete definitions (-DMARIADB) * Replace macro MariaDB support 10.2+

view details

Stoabrogga

commit sha 9d0d464addb090aed947154423f93697e6ffc063

Fix(DB/SAI): Creature text for "Battle for the Undercity" (#1720)

view details

Stoabrogga

commit sha 0b0382e60ea36414d000cbf843e5914f55d46092

fix(DB/SAI): battle beneath the dark portal (#1719) * fix(DB/SAI): battle beneath the dark portal * adjust random wait interval

view details

Falstring

commit sha 3763792d70ac5c00aed3176d132528019859ddc9

Fix(DB/Gameobject): Neferian head spawntime updated to 2 hours (#1711)

view details

AzerothCoreBot

commit sha 8b0ad176e9b87da7a8130785acd7b8be4031f32d

Import pending SQL update file... Referenced commit(s): 0b0382e60ea36414d000cbf843e5914f55d46092 9d0d464addb090aed947154423f93697e6ffc063

view details

push time in 6 days

startedMicrosoft/BosqueLanguage

started time in 7 days

pull request commentFrancescoBorzi/ngx-duration-picker

Preview format

good job @superdyzio !

shall we add also an e2e test for this ?

superdyzio

comment created time in 7 days

starteddenoland/registry

started time in 8 days

push eventazerothcore/mod-npc-all-mounts

ColdFusion

commit sha 6e58ccb911d4070f49009bead732882aad3f7a59

Port from Styx's Latest Version. (#1)

view details

push time in 8 days

PR merged azerothcore/mod-npc-all-mounts

Port from Styx's Latest Version.

Includes all Styx's improvements and bug fixes to date.

+508 -571

1 comment

4 changed files

gtao725

pr closed time in 8 days

pull request commentazerothcore/azerothcore-wotlk

fix(DB/SAI): fix creature text for "Battle for the Undercity"

good job @Stoabrogga and thanks @Nefertumm / @Pondaveia for code review / testing

Stoabrogga

comment created time in 8 days

push eventazerothcore/wiki

Stoabrogga

commit sha 92100af85c3c97e2fdfdc57bd92e07478eed6e65

Documentation for the new script command SCRIPT_COMMAND_MOVEMENT (35) (#36)

view details

push time in 8 days

PR merged azerothcore/wiki

Documentation for the new script command SCRIPT_COMMAND_MOVEMENT (35)
  • Add documentation for the new script command SCRIPT_COMMAND_MOVEMENT (35) (see https://github.com/azerothcore/azerothcore-wotlk/pull/1721)
  • Add "scripts"-link to "database-world.md" as this seems to be missing
+9 -0

8 comments

2 changed files

Stoabrogga

pr closed time in 8 days

issue commentazerothcore/wiki

Redirection

http://www.azerothcore.org/ -> info -> wiki

BarbzYHOOL

comment created time in 8 days

push eventazerothcore/wiki

Stoabrogga

commit sha 1eeb327c2ee4620cf90fc88c3cdd4307e53f496a

A few updates to the smart scripts documentation (#35)

view details

push time in 9 days

PR merged azerothcore/wiki

A few updates to the smart scripts documentation

Updated the documentation of the following smart actions in order to reflect their implementation in AC:

  • SMART_ACTION_SET_EVENT_PHASE (22)
  • SMART_ACTION_FORCE_DESPAWN (41)
  • renamed SMART_ACTION_ENABLE_TEMP_GOBJ to SMART_ACTION_RESPAWN_TARGET (70)
  • SMART_ACTION_SET_HOME_POS (101)
+10 -9

0 comment

1 changed file

Stoabrogga

pr closed time in 9 days

delete branch FrancescoBorzi/angular-electron

delete branch : e2e-test-mocha-type

delete time in 9 days

delete branch FrancescoBorzi/angular-electron

delete branch : update-travis

delete time in 9 days

started996icu/996.ICU

started time in 9 days

startedViste/Outlandcore

started time in 9 days

issue commentazerothcore/azerothcore-wotlk

Rewrite Threading system

I'm not against Boost. My opinion is just to use standard modern C++ wherever possible instead of other libs. I understand this is not always easy or possible so in some cases we might still need Boost and/or another lib to replace ACE.

Yehonal

comment created time in 10 days

issue commentazerothcore/forum

the blood bar display is too low

?

zhouxinqio

comment created time in 10 days

startedazouaoui-med/angular-pro-sidebar

started time in 10 days

startedNagRock/ts-mockito

started time in 10 days

issue commentmysqljs/mysql

Supporting Observables

Observables work already fine with this library. Check my answer here:

https://stackoverflow.com/questions/36639493/how-to-use-rxhs-mysql-and-nodejs/55677063#55677063

HassanAzzam

comment created time in 10 days

startedmysqljs/mysql

started time in 10 days

push eventazerothcore/azerothcore-wotlk

Pondaveia

commit sha a1114b37353b18a1a32304aa76188c380a70aa27

fix(DB): Training the Beast quest reward text (#1714)

view details

push time in 10 days

PR merged azerothcore/azerothcore-wotlk

[Quest] Tauren Hunter - Training the Beast To Be Merged

<!-- First of all, THANK YOU for your contribution. Please fill this template unless your PR is very simple/straightforward. Do not forget to have a look at our Pull Request tutorial: http://www.azerothcore.org/wiki/Contribute#how-to-create-a-pull-request -->

<!-- WRITE A RELEVANT TITLE -->

Fixed Training the Beast quest reward text

CHANGES PROPOSED:
  • Added the missing text

A young hunter, I see. Yes, I can bestow you with the skills you need to train and guide your pet. Not only will you be able to teach your pet new abilities, you will now be able to feed your pet, as well as revive it, should it fall in battle.

Now, go forth. May the Earthmother guide you on your path. We shall speak again, at a later date.

TESTS PERFORMED:

<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed -->

Tested

HOW TO TEST THE CHANGES:

<!-- We need to confirm the changes first, so try to make the work easy for testers, please:

  • Which commands to use? Which NPC to teleport to?

  • Do we need to enable debug flags on Cmake?

  • Do we need to look at the console? etc...

  • Other steps -->

  • Create tauren

  • .character level 10

  • .quest add 6089

  • .quest complete 6089

  • .go c 26756

  • Complete quest

Target branch(es):

Master

<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

+5 -0

1 comment

1 changed file

Pondaveia

pr closed time in 10 days

PR opened maximegris/angular-electron

feat(CI): update Ubuntu and Node versions in Travis
  • Update Node.js to version 10 (being this the latest LTS version available)
  • Update Ubuntu to version 16.04 (because 18.04 is not yet available in travis)
+5 -3

0 comment

1 changed file

pr created time in 11 days

create barnchFrancescoBorzi/angular-electron

branch : update-travis

created branch time in 11 days

push eventFrancescoBorzi/angular-electron

FrancescoBorzi

commit sha a2971bf203d6337663418b13c9fa93f94ed08d15

fix: type conflicts

view details

push time in 11 days

PR opened maximegris/angular-electron

fix(e2e): add mocha types

IntelliJ is not recognizing functions like beforeEachin the e2e tests.

This PR solves this issue by adding the mocha types.


Before:

image

After:

image

+5 -2

0 comment

2 changed files

pr created time in 11 days

create barnchFrancescoBorzi/angular-electron

branch : e2e-test-mocha-type

created branch time in 11 days

fork FrancescoBorzi/angular-electron

Ultra-fast bootstrapping with Angular 7 and Electron 4 (Typescript + SASS + Hot Reload) :speedboat:

fork in 11 days

push eventHelias/Keira2

Francesco Borzì

commit sha 419a6ae2a959492cd496161af75bcc70bb9cb7bc

Announcing Keira3

view details

push time in 11 days

issue openedazerothcore/forum

[DEV] Keira3: the future DB editor for AzerothCore

Introduction

We've already been mentioning and discussing this topic here and there, however I wanted to open this thread and make it official:

I and my brother Helias are planning to create a new DB editor application for WoW 3.3.5a, fully compatible with AzerothCore.

It will be of course inspired by its precedessor Keira2 that we previously created:

Keira allows the user to edit the database via GUI and generates automatically the SQL code for him/her. It is inspired by the old Quice/Truice database editor, originally developed by indomit, and by the Discover-'s SAI Editor.

Keira3 features and differences with Keira2

Keira3 will be built using web technologies (more details below), but it will be a cross-platform Desktop Application. We already felt that this would be better for our user base, and a poll on Discord confirmed it:

image

The initial version of Keira3 will have the same basic features of Keira2, that include:

  • Editor for SmartAI
  • Editors for Quest, Creature, Game Object, Item, etc...

In addition:

  • Execute SQL directly from the editor
  • No dependency on web APIs (the app installation procedure will be much simpler compared to the current Keira2)

Then we plan to introduce more features, but those will be part of later 3.x releases.

Technical details

We plan to create Keira3 using the Electron open-source framework, a tool written in C++ that allows you to build cross-platform desktop applications using web languages (HTML+CSS+JavaScript). Many modern desktop applications are built using this framework, including Discord, Visual Studio Code, Atom, Slack, Skype, etc...

Keira3 will be entirely written in TypeScript, a superset of JavaScript that allows you to build software using modern OOP techniques, and using the new Angular framework from Google (not to be confused with the old AngularJS framework).

Why not just updating Keira2 instead of creating a new app?

We created Keira2 in 2015 as web application using the old AngularJS framework which is no longer actively developed by Google. So that should be upgraded. The same can be said for other dependencies. Also Keira2 relies on a web API that I've created for TrinityCore just as a proof of concept, and it should be properly refactored and updated. It's just too much work and it's not worth it.

In addition, we want it to be an independent desktop application, not a simple web app. For these reasons a full rewrite is the best way to go. We will however benefit of our experience and some algorithms from Keira2.

When will Keira3 be released?

We plan to start the development soon, however we can't predict how much time we will take. We will work on Keira3 during our free time, just like any AzerothCore-related activity. But we are also busy in our RL with studies and jobs to maintain ourselves. If you want to support us, you can help with a donation.

The more donations we get, the more time we can invest on Keira3 development.

created time in 11 days

push eventazerothcore/azerothcore-wotlk

Pondaveia

commit sha c1ebc70b58454a651629327ea9f30373348b1a3c

feat(core): Increased limit of realms (#1664)

view details

push time in 11 days

PR merged azerothcore/azerothcore-wotlk

[Worldserver] Increased limit of realms To Be Merged

<!-- First of all, THANK YOU for your contribution. Please fill this template unless your PR is very simple/straightforward. Do not forget to have a look at our Pull Request tutorial: http://www.azerothcore.org/wiki/Contribute#how-to-create-a-pull-request -->

<!-- WRITE A RELEVANT TITLE -->

More than 8 realms available

Thanks @Rochet2 for all the help

CHANGES PROPOSED:
  • Altered the DB and the core to allow more than 8 realms. With these changes the core will support until 255 available realms. Due to the client only reading a package with a size of 8 bits, the core can't allow more realms to be added since any higher values won't be updated in the database. Otherwise, the server could behave abnormally because we won't be storing the current realm onto which a player is logged on.
ISSUES ADDRESSED:

<!-- If the issue doesn't exist, describe it and how to reproduce it, please. If the issue already exists, just paste the link to the issue you close, like this: Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 -->

Closes #1403

TESTS PERFORMED:

<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed -->

I tested this on windows and it works.

HOW TO TEST THE CHANGES:

<!-- We need to confirm the changes first, so try to make the work easy for testers, please:

  • Which commands to use? Which NPC to teleport to?
  • Do we need to enable debug flags on Cmake?
  • Do we need to look at the console? etc...
  • Other steps -->
  1. Add a new realm on Auth Database -> Realmlist with ID 9 or higher (Also need diferent name)
  2. Change the realm id on worldserver.conf to the new value that you added on the database
  3. Launch worldserver and log onto the realm
  4. Check worldserver for no query errors
  5. On the auth database at accounts.online you will see the number of the realmID to which the player is connected to, in this case it should display 9.
Target branch(es):

Master

<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

+18 -5

8 comments

4 changed files

Pondaveia

pr closed time in 11 days

issue closedazerothcore/azerothcore-wotlk

Can't set realmID > 8 (in worldserver.conf)

<!-- IF YOU DO NOT FILL THIS TEMPLATE OUT, WE WILL CLOSE YOUR ISSUE! -->

<!-- This template is for problem reports, for feature suggestion etc... feel free to edit it. If this is a crash report, upload the crashlog on https://gist.github.com/ For issues containing a fix, please create a Pull Request following this tutorial: https://github.com/azerothcore/azerothcore-wotlk/wiki/Contribute#how-to-create-a-pull-request -->

<!-- WRITE A RELEVANT TITLE -->

SMALL DESCRIPTION:

<!-- Add a one line description of the bug -->

We can't put a realmid above 8 in the worldserver.conf, else it returns "Realm ID not defined in configuration file"

EXPECTED BLIZZLIKE BEHAVIOUR:

<!-- Describe how it should be working without the bug. -->

We should be able to put realmid above 8, imagine if we have tons of realms or simply to sort them easily (dev realms on 10-20 IDs, testing realms on 20-30 etc...)

STEPS TO REPRODUCE THE PROBLEM:

<!-- Describe precisely how to reproduce the bug so we can fix it or confirm its existence:

  • Which commands to use? Which NPC to teleport to?
  • Do we need to have debug flags on Cmake?
  • Do we need to look at the console while the bug happens?
  • Other steps -->
  1. Change realmid to 9 in worldserver.conf
  2. Can't launch worldserver
  3. Cry
EXTRA NOTES:

<!-- Any information that can help the developers to identify and fix the issue should be put here. Examples:

  • was this bug always present in AzerothCore? if it was introduced after a change, please mention it
  • the code line(s) that cause the issue
  • does this feature work in other server appplications (e.g. CMaNGOS, TrinityCore, etc...) ? -->

This part is responsible (thanks @Rochet2 for finding it in 10 sec) https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/worldserver/Master.cpp#L472

This is related to the auth.account.online column. In that column, the realmid is put when you are online on that realmid. However it uses a flag, which doesn't seem to make much sense (since you can't be online on several realms at the same time with the same account).

Rochet suggests to either change this to a flat number. :

simply scrapping the mask would already allow 255 realms or something

Or to change to uint 32 :

And by searching realmID in the source code you can find where the mask is used For example there is this line of code LoginDatabase.DirectPExecute("UPDATE account SET online = online & ~(1<<(%u-1)) WHERE online & (1<<(%u-1))", realmID, realmID);

BRANCH(ES):

<!-- Specify the branch(es) affected by this issue: master, 0.x, 1.x, or another branch. -->

master

AC HASH/COMMIT:

<!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! NEVER WRITE "LATEST", ALWAYS PUT THE ACTUAL VALUE INSTEAD. Find the commit hash (unique identifier) by running "git log" on your own clone of AzerothCore or by looking at here https://github.com/azerothcore/azerothcore-wotlk/commits/master -->

264dd0c65afc33e9613e42dee656697d088d8a74

closed time in 11 days

BarbzYHOOL

push eventazerothcore/mod-npc-buffer

Micrah

commit sha 355899cbdc81ef1409d18127d05bb323729572db

fix: Update npc_buffer.cpp fix build errors (#5)

view details

push time in 12 days

PR merged azerothcore/mod-npc-buffer

Update npc_buffer.cpp fix build errors

will build on latest revision of azerothcore

+232 -2

1 comment

4 changed files

milestorme

pr closed time in 12 days

delete branch azerothcore/wiki

delete branch : Helias-patch-1

delete time in 14 days

push eventazerothcore/wiki

Stefano Borzì

commit sha c4f651c1152568d1eb3829ae5004db953191755d

Update creature_template.md (#33)

view details

push time in 14 days

PR merged azerothcore/wiki

Update creature_template.md

Description

Fixing creature_template markdown tables

Related Issue

Table bad formatted (example: npcflag). Related to #11

+315 -814

3 comments

1 changed file

Helias

pr closed time in 14 days

pull request commentazerothcore/wiki

Update creature_template.md

@BarbzYHOOL we can always revert :)

Helias

comment created time in 14 days

delete branch azerothcore/azerothcore-wotlk

delete branch : commit_template

delete time in 14 days

pull request commentazerothcore/azerothcore-wotlk

Fix parry aura spells

@barbz Bountysource takes a small percentage of the bounty. So actually doing like this you don't earn any additional money but loose a little bit of it actually :)

TheHighlord

comment created time in 15 days

issue commentazerothcore/azerothcore-wotlk

[EPIC] Align DB structure to TrinityCore

All the most important changes have been imported. There are still a few ones left but AFAIK no one is working on them. This can be left open and visible to whoever wants to import more changes.

FrancescoBorzi

comment created time in 15 days

issue commentazerothcore/azerothcore-wotlk

Mac OS X Debug build broken

We need to test on a recent AC version to check if the issue is still there. There is a good chance that it's still broken...

FrancescoBorzi

comment created time in 15 days

issue commentazerothcore/azerothcore-wotlk

worldserver.exe Error logging

@boom8866 can you open a PR with that?

boom8866

comment created time in 15 days

startedpangolp/npc_promocion

started time in 16 days

startedsindresorhus/awesome-electron

started time in 16 days

Pull request review commentazerothcore/mod-1v1-arena

Update mod-1v1-arena

+DELETE FROM `creature_template` WHERE `entry` = 999990;
+DELETE FROM `creature_template` WHERE `entry` = 999991;

those two lines can be combined:

http://www.azerothcore.org/wiki/Dealing-with-SQL-files#write-compact-code

everything else looks good

milestorme

comment created time in 16 days

push eventFrancescoBorzi/azerothcore-wotlk

Stoabrogga

commit sha 68c89e8af9685a0c778c33cc5030ea57accdfd66

fix(CI): fix paths for dry-run check (#1697)

view details

push time in 16 days

push eventazerothcore/azerothcore-wotlk

Francesco Borzì

commit sha 97e7e2228e9b66e15d307f97c1b05160dd612aaa

fix(Docker): allow to use modules (#1558)

view details

push time in 16 days

delete branch FrancescoBorzi/azerothcore-wotlk

delete branch : fix-modules-in-docker

delete time in 16 days

PR merged azerothcore/azerothcore-wotlk

fix(Docker): allow to use modules Priority - High To Be Merged
CHANGES PROPOSED:
  • Include modules in Docker build
TESTS PERFORMED:

Not yet tested.

HOW TO TEST THE CHANGES:

Include a module in your sources as you would normally do in a traditional setup. Then run the docker setup and see if the module is correctly included.

Target branch(es):

Master

+1 -1

5 comments

2 changed files

FrancescoBorzi

pr closed time in 16 days

pull request commentazerothcore/azerothcore-wotlk

fix(Docker): allow to use modules

many thanks @koffeine !

FrancescoBorzi

comment created time in 16 days

push eventFrancescoBorzi/azerothcore-wotlk

Stoabrogga

commit sha 6380500b332d0e146dfcd79614a0b5c9fb900fab

fix(DB/Core): quest chain leading to "Battle for the Undercity" (#1629)

view details

AzerothCoreBot

commit sha 4193898ccdfedf9531686ae188cf212551fb38a1

Import pending SQL update file... Referenced commit(s): 6380500b332d0e146dfcd79614a0b5c9fb900fab

view details

Stoabrogga

commit sha 18d52687876a17b79eae752f46116ce5f69db131

fix(DB): Fezzix "jumping" through the air (#1634)

view details

AzerothCoreBot

commit sha 5849d5cc42e7ee62c810bddebc04caec6c6a2c2f

Import pending SQL update file... Referenced commit(s): 18d52687876a17b79eae752f46116ce5f69db131

view details

Stoabrogga

commit sha 5b594fec4de01b76f26958d5e28ff213f0c9f174

fix(DB/SAI): despawn Jenny when quest "Load'er Up!" is complete (#1641)

view details

AzerothCoreBot

commit sha 6a05b0402c5bfa554a9663403f3c24eecd936f49

Import pending SQL update file... Referenced commit(s): 5b594fec4de01b76f26958d5e28ff213f0c9f174

view details

Viste

commit sha 801847b718815c5f1dea0d49d651828c511106ec

Feat(Core/Item): Proper way to add item signature (#1623) Co-authored-by: PolarCookie <PolarCookie@users.noreply.github.com>

view details

Poszer

commit sha 57a5f26eb1767325afcae1915e3054ff1105d3f3

Fix(Core/Scripts): NPC Iruk gossip from DB (#1632)

view details

Poszer

commit sha 6ccab63e7dbd5bbdc44ae7a7ff8d3c155c655521

Fix(DB/Quest): Data Rescue (#1645)

view details

Francesco Borzì

commit sha c638ae859a316c643cd38e98fd9b0c90b3abcbb0

chore(Docker): add comments to explain the building steps (#1638)

view details

AzerothCoreBot

commit sha dfd034332e7032677302abe76c4cad4486062125

Import pending SQL update file... Referenced commit(s): 6ccab63e7dbd5bbdc44ae7a7ff8d3c155c655521

view details

Poszer

commit sha b4a89be4cd733324ea2ef7ba76f7f9e65eca01c1

fix(Core/Commands): Learn spell for GM lvl 3 (#1651) - Allow Learn spell from spell_script_names. - To learn spells you need to have GM level 3 (SEC_ADMINISTRATOR) instead of GM level 4 ( SEC_CONSOLE)

view details

WiZZy

commit sha 812a90568e3af009006a6f393d2457f335b96a99

DB/Core: Heroes of old Blizzlike and Fix (#1646)

view details

Poszer

commit sha e8d0027b95f88b160add9ce062e0a80cbfb9388c

Fix(Core/Player: On first login cinematics (#1617) - If the player create character, usually the cinematics is played in the zone, but if he's summoned by gm on the first login, the cinematics shouldn't be played. Since he will be summoned in the other zone / map.

view details

AzerothCoreBot

commit sha 0f174eff0142c60d3c631c23b5348d3f43fd444b

Import pending SQL update file... Referenced commit(s): 812a90568e3af009006a6f393d2457f335b96a99

view details

Kargatum

commit sha eae9affec99181cec14fa4fd0449bb9f8e02565f

feat(Cmake): Rewrite build and use inherited dependencies (#1652)

view details

Pondaveia

commit sha baab75e285be2ba2791bdae404730c8914f1bdba

DB: Shattered sun marksman SAI (#1038) * Sheath bow on reset * Dummy target pick and spell swap * Add new line * Changed quotes

view details

AzerothCoreBot

commit sha 2bd998bd4f75e22f174d928c3fe9558ba748a51a

Import pending SQL update file... Referenced commit(s): baab75e285be2ba2791bdae404730c8914f1bdba

view details

Kargatum

commit sha ba0ec5875a52b175dfb7d0eaf82cd353ba98f797

feat(Cmake): Add new hook AFTER_LOAD_CMAKE_MODULES (#1670)

view details

Stoabrogga

commit sha 994dc23833bdca21aa9ef5837f56522d5d99ed0d

fix(Core): fix a few issues with "Battle for the Undercity" (#1648)

view details

push time in 16 days

push eventFrancescoBorzi/azerothcore-wotlk

Francesco Borzì

commit sha 4fbba95b9caab1e8db29e508bd1248a09136372c

Update .dockerignore

view details

push time in 16 days

Pull request review commentazerothcore/azerothcore-wotlk

Core/Spells: Change to the way the spell effect SPELL_EFFECT_JUMP work.

+theme: jekyll-theme-slate

?

Viste

comment created time in 16 days

pull request commentazerothcore/azerothcore-wotlk

Fix db_assembler on macOS

Thanks for this contribution. This needs to be tested on Windows and Linux, to avoid regression.

btw @koffeine have you managed to run AC on macOS ? Because last time I've tried, it didn't work for me.

koffeine

comment created time in 16 days

pull request commentazerothcore/azerothcore-wotlk

[QUEST] fix Fire At Will!(TEST)

@grimgravy good job!

please check my comments and the codacy results:

https://app.codacy.com/app/FrancescoBorzi/azerothcore-wotlk/pullRequest?prid=3400707

grimgravy

comment created time in 16 days

Pull request review commentazerothcore/azerothcore-wotlk

[QUEST] fix Fire At Will!(TEST)

 class npc_deahts_door_wrap_gate : public CreatureScript      struct npc_deahts_door_wrap_gateAI : public ScriptedAI     {-        npc_deahts_door_wrap_gateAI(Creature *c) : ScriptedAI(c)+        npc_deahts_door_wrap_gateAI(Creature* creature) : ScriptedAI(creature) { }++        bool PartyTime;++        uint64 PlayerGUID;+        uint64 CannonGUID;+        uint32 PartyTimer;+        uint8 count;+        float x, y, z, o;++        void Reset()         {+            PartyTime = false;+            PlayerGUID = 0;+            CannonGUID = 0;+            PartyTimer = 0;+            count = 0;+            o = me->GetOrientation();+            me->GetPosition(x, y, z);+            x = x + 1.0f;         } -        uint8 count;-        uint32 timer;-        void Reset() { count = 0; timer = 0;}-        void SpellHit(Unit* caster, SpellInfo const* spellInfo)+        void SpellHit(Unit* caster, SpellInfo const* spell)         {-            if (spellInfo->Id == SPELL_ARTILLERY_ON_THE_WRAP_GATE)+            if (spell->Id == SPELL_ARTILLERY_ON_THE_WRAP_GATE)             {-                Player* plr = caster->GetCharmerOrOwnerPlayerOrPlayerItself();-                if (!plr)-                    return;--                timer = 1;                 count++; +                if (count >= 1)+                {+                    if (Player* player = caster->GetCharmerOrOwnerPlayerOrPlayerItself())+                        PlayerGUID = player->GetGUID();++                    CannonGUID = caster->GetGUID();+                    PartyTime = true;+                    PartyTimer = 3000;+                }++                if (count >= 3)+                    me->SummonGameObject(GO_FIRE, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ(), 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 130);+                 if (count >= 6)                 {-                    if (me->GetEntry() == NPC_SOUTH_GATE)-                        plr->KilledMonsterCredit(NPC_SOUTH_GATE_CREDIT, 0);-                    else-                        plr->KilledMonsterCredit(NPC_NORTH_GATE_CREDIT, 0);+                    if (Player* player = ObjectAccessor::GetPlayer(*me, PlayerGUID))+                    {+                        if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_SOUTH_GATE, 200.0f))+                            player->KilledMonsterCredit(NPC_SOUTH_GATE_CREDIT, TRIGGERED_NONE);+                        else+                        {+                            if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_NORTH_GATE, 200.0f))+                                player->KilledMonsterCredit(NPC_NORTH_GATE_CREDIT, TRIGGERED_NONE);+                        }+                        // complete quest part+                        if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_EXPLOSION_BUNNY, 200.0f))+                            bunny->CastSpell(nullptr, SPELL_EXPLOSION, TRIGGERED_NONE);+                    } +                    me->SummonGameObject(GO_BIG_FIRE, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ(), 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 60);                     Reset();                 }             }++            return;+        }++        void JustSummoned(Creature* summoned)+        {+            if (summoned->GetEntry() == NPC_FEL_IMP)+                summoned->CastSpell(summoned, SPELL_IMP_AURA, true);+            else+            {+                if (summoned->GetEntry() == NPC_HOUND)+                    summoned->CastSpell(summoned, SPELL_HOUND_AURA, true);+            }++            summoned->UpdateGroundPositionZ(x, y, z);++            if (Creature* cannon = ObjectAccessor::GetCreature(*me, CannonGUID))+                summoned->AI()->AttackStart(cannon);         }          void UpdateAI(uint32 diff)         {-            if (timer)+            if (PartyTime)             {-                timer += diff;-                if (timer < 10000 || (timer >= 20000 && timer < 30000))+                if (PartyTimer <= diff)                 {-                    for (uint8 i = 0; i < 3; ++i)-                        if (Creature* cr = me->SummonCreature((roll_chance_i(50) ? 22474 : 22500), me->GetPositionX(), me->GetPositionY(), me->GetPositionZ(), 0.0f, TEMPSUMMON_TIMED_DESPAWN_OUT_OF_COMBAT, 30000))-                            if (Unit* target = cr->SelectNearbyTarget(NULL, 50.0f))-                                cr->AI()->AttackStart(target);--                    timer += 10000;-                    if (timer >= 30000)-                        timer = 0;+                    if (Creature* cannon = ObjectAccessor::GetCreature(*me, CannonGUID))+                    {+                        if (cannon->isDead())

those 2 ifs can be combined into:

if (Creature* cannon = ObjectAccessor::GetCreature(*me, CannonGUID)) && cannon->isDead())
grimgravy

comment created time in 16 days

Pull request review commentazerothcore/azerothcore-wotlk

[QUEST] fix Fire At Will!(TEST)

 class npc_deahts_door_wrap_gate : public CreatureScript      struct npc_deahts_door_wrap_gateAI : public ScriptedAI     {-        npc_deahts_door_wrap_gateAI(Creature *c) : ScriptedAI(c)+        npc_deahts_door_wrap_gateAI(Creature* creature) : ScriptedAI(creature) { }++        bool PartyTime;++        uint64 PlayerGUID;+        uint64 CannonGUID;+        uint32 PartyTimer;+        uint8 count;+        float x, y, z, o;++        void Reset()         {+            PartyTime = false;+            PlayerGUID = 0;+            CannonGUID = 0;+            PartyTimer = 0;+            count = 0;+            o = me->GetOrientation();+            me->GetPosition(x, y, z);+            x = x + 1.0f;         } -        uint8 count;-        uint32 timer;-        void Reset() { count = 0; timer = 0;}-        void SpellHit(Unit* caster, SpellInfo const* spellInfo)+        void SpellHit(Unit* caster, SpellInfo const* spell)         {-            if (spellInfo->Id == SPELL_ARTILLERY_ON_THE_WRAP_GATE)+            if (spell->Id == SPELL_ARTILLERY_ON_THE_WRAP_GATE)             {-                Player* plr = caster->GetCharmerOrOwnerPlayerOrPlayerItself();-                if (!plr)-                    return;--                timer = 1;                 count++; +                if (count >= 1)+                {+                    if (Player* player = caster->GetCharmerOrOwnerPlayerOrPlayerItself())+                        PlayerGUID = player->GetGUID();++                    CannonGUID = caster->GetGUID();+                    PartyTime = true;+                    PartyTimer = 3000;+                }++                if (count >= 3)+                    me->SummonGameObject(GO_FIRE, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ(), 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 130);+                 if (count >= 6)                 {-                    if (me->GetEntry() == NPC_SOUTH_GATE)-                        plr->KilledMonsterCredit(NPC_SOUTH_GATE_CREDIT, 0);-                    else-                        plr->KilledMonsterCredit(NPC_NORTH_GATE_CREDIT, 0);+                    if (Player* player = ObjectAccessor::GetPlayer(*me, PlayerGUID))+                    {+                        if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_SOUTH_GATE, 200.0f))+                            player->KilledMonsterCredit(NPC_SOUTH_GATE_CREDIT, TRIGGERED_NONE);+                        else+                        {+                            if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_NORTH_GATE, 200.0f))+                                player->KilledMonsterCredit(NPC_NORTH_GATE_CREDIT, TRIGGERED_NONE);+                        }+                        // complete quest part+                        if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_EXPLOSION_BUNNY, 200.0f))+                            bunny->CastSpell(nullptr, SPELL_EXPLOSION, TRIGGERED_NONE);+                    } +                    me->SummonGameObject(GO_BIG_FIRE, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ(), 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 60);                     Reset();                 }             }++            return;+        }++        void JustSummoned(Creature* summoned)+        {+            if (summoned->GetEntry() == NPC_FEL_IMP)+                summoned->CastSpell(summoned, SPELL_IMP_AURA, true);+            else+            {+                if (summoned->GetEntry() == NPC_HOUND)+                    summoned->CastSpell(summoned, SPELL_HOUND_AURA, true);+            }

this else with inner if can be combined into:

else if (summoned->GetEntry() == NPC_HOUND)
grimgravy

comment created time in 16 days

Pull request review commentazerothcore/azerothcore-wotlk

[QUEST] fix Fire At Will!(TEST)

 class npc_deahts_door_wrap_gate : public CreatureScript      struct npc_deahts_door_wrap_gateAI : public ScriptedAI     {-        npc_deahts_door_wrap_gateAI(Creature *c) : ScriptedAI(c)+        npc_deahts_door_wrap_gateAI(Creature* creature) : ScriptedAI(creature) { }++        bool PartyTime;++        uint64 PlayerGUID;+        uint64 CannonGUID;+        uint32 PartyTimer;+        uint8 count;+        float x, y, z, o;++        void Reset()         {+            PartyTime = false;+            PlayerGUID = 0;+            CannonGUID = 0;+            PartyTimer = 0;+            count = 0;+            o = me->GetOrientation();+            me->GetPosition(x, y, z);+            x = x + 1.0f;         } -        uint8 count;-        uint32 timer;-        void Reset() { count = 0; timer = 0;}-        void SpellHit(Unit* caster, SpellInfo const* spellInfo)+        void SpellHit(Unit* caster, SpellInfo const* spell)         {-            if (spellInfo->Id == SPELL_ARTILLERY_ON_THE_WRAP_GATE)+            if (spell->Id == SPELL_ARTILLERY_ON_THE_WRAP_GATE)             {-                Player* plr = caster->GetCharmerOrOwnerPlayerOrPlayerItself();-                if (!plr)-                    return;--                timer = 1;                 count++; +                if (count >= 1)+                {+                    if (Player* player = caster->GetCharmerOrOwnerPlayerOrPlayerItself())+                        PlayerGUID = player->GetGUID();++                    CannonGUID = caster->GetGUID();+                    PartyTime = true;+                    PartyTimer = 3000;+                }++                if (count >= 3)+                    me->SummonGameObject(GO_FIRE, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ(), 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 130);+                 if (count >= 6)                 {-                    if (me->GetEntry() == NPC_SOUTH_GATE)-                        plr->KilledMonsterCredit(NPC_SOUTH_GATE_CREDIT, 0);-                    else-                        plr->KilledMonsterCredit(NPC_NORTH_GATE_CREDIT, 0);+                    if (Player* player = ObjectAccessor::GetPlayer(*me, PlayerGUID))+                    {+                        if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_SOUTH_GATE, 200.0f))+                            player->KilledMonsterCredit(NPC_SOUTH_GATE_CREDIT, TRIGGERED_NONE);+                        else+                        {+                            if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_NORTH_GATE, 200.0f))

this else with inner if can be combined into:

else if (Creature* bunny = GetClosestCreatureWithEntry(me, NPC_NORTH_GATE, 200.0f))
grimgravy

comment created time in 16 days

push eventFrancescoBorzi/azerothcore-wotlk

Francesco Borzì

commit sha 06a513e8d6ac766c921e89d821175d42f9252ca3

Update BattlegroundAV.h

view details

push time in 17 days

push eventFrancescoBorzi/azerothcore-wotlk

Francesco Borzì

commit sha fe71ccf2d969e4e4c5469b46121ef4d1a1a97a50

Update Battleground.h

view details

push time in 17 days

PR opened azerothcore/azerothcore-wotlk

refactor(Core/BG/AV): code cleanup Waiting to be tested
CHANGES PROPOSED:
  • Fixed some Codacity warnings
  • Fixed some clang-tidy warnings
  • Other code cleanup
TESTS PERFORMED:

None

HOW TO TEST THE CHANGES:
  • Make sure Battlground Alterac Vally is not broken and there is not regression
Target branch(es):

Master

+45 -51

0 comment

3 changed files

pr created time in 17 days

create barnchFrancescoBorzi/azerothcore-wotlk

branch : battleground-av-code-cleanup

created branch time in 17 days

push eventFrancescoBorzi/azerothcore-wotlk

Viste(Кирилл)

commit sha 2e65c0afb7bb7caaacae3c684a9f6eed3c976165

Fix(Scripts/Spells): Check range to fire totem when casting Fire Nova. (#1566) * Fix(Scripts/Spells): Check range to fire totem when casting Fire Nova.

view details

Ercules76

commit sha 2d1e45919730e46dfc759bdf1213a3706c981c47

fix(Core/WorldSession): change how to storing data in account_tutorial (#1563) * Core/Misc Created handler for character creation * fix(Core/DB): Error message when the password is longer than 16 char when creating an account * Update rev_1551539925032805900.sql * Update AccountMgr.cpp * fix(Core/DB): account_tutorial now storing data * clean

view details

Stoabrogga

commit sha 9874e52681601ff48367ce519d90c7d0a32d0917

fix(DB): Malmortis creature text (#1572)

view details

AzerothCoreBot

commit sha d04ba0f86081495785a05984ca38433a2889cdc4

Import pending SQL update file... Referenced commit(s): 9874e52681601ff48367ce519d90c7d0a32d0917

view details

Alan

commit sha cd9e8716d804c78cf5d075e09fbe17b891c3ea04

Fix(Scripts/Instances/Oculus): improvements (#1498) * I removed the blank * I made some changes to correct Travis's error. * Update oculus.cpp * Removed the unused method parameter Renamed Unit::SetSpeed to SetSpeedRate * added an improvement * Correct Drakes flight error * duplicate removed * Travis Error Fixing

view details

AzerothCoreBot

commit sha cbc0c93d06676edcf76f8cb8f0f7c57a62ed4dc8

Import pending SQL update file... Referenced commit(s): cd9e8716d804c78cf5d075e09fbe17b891c3ea04

view details

Stoabrogga

commit sha e2f196580e9d187e7b2745a7d6cf1877c6235ff4

feat(CI): improve Travis build time (#1573) * feat(CI): improve Travis build time

view details

Ercules76

commit sha 8b7d067abcb08f34c86c15b4c4e98eedd104fc29

Fix(Core): GM command not working while GM mode is on (#1581)

view details

Stoabrogga

commit sha e243c572e5f4ebdf35c05b8d602b27b03fb7bfd2

fix(DB): zeppelin master - remove gossip option "Where is the zeppelin now?" (#1578)

view details

AzerothCoreBot

commit sha 9c646da416b43ee29c6ae4d32ae0015997c1a764

Import pending SQL update file... Referenced commit(s): e243c572e5f4ebdf35c05b8d602b27b03fb7bfd2

view details

Stoabrogga

commit sha 1aec039daf2dc12db98b9ff278f1fc2fff1ab84f

fix(DB): a few improvements to the giant wandering outdoor creatures (#1579)

view details

AzerothCoreBot

commit sha 306615e71a6ec8710b3763c1573b413fcddf08d1

Import pending SQL update file... Referenced commit(s): 1aec039daf2dc12db98b9ff278f1fc2fff1ab84f

view details

Stoabrogga

commit sha 54b23ce209b9c12019494b3edfab83f31db2eca1

fix(DB/Core): play event after quest "Hero of the Mag'har"; extend SAI to play music (#1570)

view details

AzerothCoreBot

commit sha a7b4c909f3f27c729633983b7cee8ad30b058863

Import pending SQL update file... Referenced commit(s): 54b23ce209b9c12019494b3edfab83f31db2eca1

view details

Stoabrogga

commit sha a4fcf926feceb46f7ab949259eb6371abb346da2

fix(DB): Fjord Hawk, Fjord Turkey (#1584) * fix(DB): Fjord Hawk, Fjord Turkey * add delete statement

view details

AzerothCoreBot

commit sha b72454847b09b5b7b9c030ea7bc5e6f022e38bef

Import pending SQL update file... Referenced commit(s): a4fcf926feceb46f7ab949259eb6371abb346da2

view details

Viste(Кирилл)

commit sha 2af5893d52709d076db45aef545ba55cb5b8f2ab

feat(Core/Chat): Add config option to allow use LFG anywhere not only in city (#1586)

view details

Viste(Кирилл)

commit sha 5cbced320d6ce0c56e535c41b399ca4dc8434c46

Fix(Core/Ticket System): Ticket comment visual output bug (#1567) * Fix(Core/Ticket System): Ticket comment visual output bug * fix build * rewrite

view details

Micrah

commit sha 15667774c21f77ac34bbded7a43d3517e6221545

Fix(Core/Common): Added header <unordered_map> in file DBCStore.h (#1592) * To allow the use of latest eluna-module, stuffed up the PR merge redoing

view details

Francesco Borzì

commit sha 6fd03cfd0500c39a728984e79f6973fbf35c2075

Feat:Update README.md (#1594)

view details

push time in 17 days

Pull request review commentazerothcore/azerothcore-wotlk

Cmake: Rewrite modules system

+#+# Copyright (C) 2016+     AzerothCore <www.azerothcore.org>, released under GNU AGPL3 v3 license: https://github.com/azerothcore/azerothcore-wotlk/blob/master/LICENSE-AGPL3+#++# Collect source files not disable modules+CU_SUBDIRLIST(sub_DIRS  "${CMAKE_SOURCE_DIR}/modules" FALSE FALSE)+FOREACH(subdir ${sub_DIRS})+  get_filename_component(MODULENAME ${subdir} NAME)+    +  if (";${DISABLED_AC_MODULES};" MATCHES ";${MODULENAME};")+    continue()+  endif()++  STRING(REGEX REPLACE "^${CMAKE_SOURCE_DIR}/" "" subdir_rel ${subdir}) +  CollectSourceFiles(+    ${CMAKE_SOURCE_DIR}/${subdir_rel}/+    PRIVATE_SOURCES)++  set(MODULES_STAT_SRCS+    ${MODULES_STAT_SRCS}+    ${PRIVATE_SOURCES})+ENDFOREACH()++# Группировка сорцов

english please :)

Winfidonarleyan

comment created time in 18 days

issue openedazerothcore/forum

[GENERAL] AzerothCore on LinkedIn

Software Development companies often look at open source contributions when they want to check a candidate's skills. It's always good to have references of open source projects in your own LinkedIn profile.

For this reason we decided to create an AzerothCore page (as a No-profit Company) on LinkedIn. So you can add AzerothCore between your LinkedIn working experiences:

https://www.linkedin.com/company/azerothcore

You don't necessarily have to be a developer to add such experience. You can add your experience as Tester, Technical Writer (wiki), Supporter, Server Administrator, Game Master, etc... too.

Below you can find some examples of how the AC experience can look like on your LinkedIn profile. There are many ways to use AzerothCore and those examples are just meant to give some ideas about how to list your experience. Feel free to write down whatever you are doing with our awesome project!

image

image

image

image

image

image

created time in 18 days

pull request commentazerothcore/azerothcore-wotlk

Core/Battlegrounds: Fix log errors about creatures not found

good job @grimgravy and @poszer

grimgravy

comment created time in 18 days

push eventazerothcore/azerothcore-wotlk

Alan

commit sha 3b82a3d903e108c2b105bcb0e5a723d19a1d8bf0

fix(Core/Battlegrounds): log errors about creatures not found (#1587)

view details

push time in 18 days

PR merged azerothcore/azerothcore-wotlk

Core/Battlegrounds: Fix log errors about creatures not found To Be Merged

<!-- First of all, THANK YOU for your contribution. Please fill this template unless your PR is very simple/straightforward. Do not forget to have a look at our Pull Request tutorial: http://www.azerothcore.org/wiki/Contribute#how-to-create-a-pull-request -->

<!-- WRITE A RELEVANT TITLE -->

CHANGES PROPOSED:
  • Move "Battleground::GetBGCreature: creature not found for BG" error log to "GetBgMap" level when the caller expects no creatures to be found, like on Battleground startup.
  • remove wrong DB errors. It is normal to have events applicable only to certain instance difficulties.
ISSUES ADDRESSED:

I also saw the problem not only in the alterac valley, also on the island of conquest, but able to fix the repair based on trinitycore

Closes #1496

TESTS PERFORMED:

windows 7 operating system

Target branch(develop):

<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->

<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->

+11 -14

9 comments

3 changed files

grimgravy

pr closed time in 18 days

issue closedazerothcore/azerothcore-wotlk

Alterac DB errors

SMALL DESCRIPTION:

Alterac Data Base errors

STEPS TO REPRODUCE THE PROBLEM:
  1. Enter to Alterac
  2. See DBErrors.log and Server.log
BRANCH(ES):

AzerothCore rev. 23d78ce6bc75 2019-02-18 18:22:36 +0700 (master branch) (Win64, Release)

EXTRA NOTES:
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 302, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 303, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 304, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 306, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 307, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 308, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 309, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 310, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 311, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 312, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 313, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 314, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 315, GUID: 0) not found for BG (map: 30, instance id: 1)!
2019-02-19 13:49:34 ERROR: Battleground::GetBGCreature: creature (type: 316, GUID: 0) not found for BG (map: 30, instance id: 1)!

DB.txt
2019-02-19 13:49:34 SmartScript: Entry 11675 has events but no events added to list because of instance flags.
2019-02-19 13:49:34 SmartScript: Entry 11675 has events but no events added to list because of instance flags.
2019-02-19 13:49:34 SmartScript: Entry 11675 has events but no events added to list because of instance flags.
2019-02-19 13:49:34 SmartScript: Entry 11675 has events but no events added to list because of instance flags.
2019-02-19 13:49:34 SmartScript: Entry 11675 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11600 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11657 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.
2019-02-19 13:51:34 SmartScript: Entry 11604 has events but no events added to list because of instance flags.

closed time in 18 days

Mitradis

Pull request review commentazerothcore/azerothcore-wotlk

Reworked Archimonde

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1554524766481187700');++DELETE FROM `spell_script_names` WHERE `ScriptName` = 'spell_red_sky_effect';+INSERT INTO `spell_script_names` VALUES+(32111, 'spell_red_sky_effect');++DELETE FROM `spell_script_names` WHERE `ScriptName` = 'spell_finger_of_death';+INSERT INTO `spell_script_names` VALUES+(31984, 'spell_finger_of_death');++DELETE FROM `spell_script_names` WHERE `ScriptName` = 'spell_hand_of_death';+INSERT INTO `spell_script_names` VALUES+(35354, 'spell_hand_of_death');

please use compact SQL code

Pondaveia

comment created time in 18 days

issue commentazerothcore/azerothcore-wotlk

Code review reports(performance, warnings, security, code style)

@Viste good job, but why are you using my fork instead of the main repo ?

Viste

comment created time in 18 days

push eventazerothcore/forum

Francesco Borzì

commit sha a72e8003bd008c4926a26e6c7b5eed36338378e0

Create job-offer.md

view details

push time in 18 days

startedazerothcore/forum

started time in 18 days

pull request commentTrinityCore/TC-Home-page

fix broken URL

I think we should remove that line entirely, because changing it like that will make the link duplicated

hernanrenteria

comment created time in 19 days

Pull request review commentazerothcore/azerothcore-wotlk

DB/Quest/Gameobject: Adding Despawn time

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1554472237843824900');++DELETE FROM `smart_scripts` WHERE `entryorguid`=1439200 AND `source_type`=9 AND `id`=12 AND `link`=0;+INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES (1439200, 9, 12, 0, 1, 0, 100, 0, 30000, 30000, 0, 0, 0, 41, 7200000, 0, 0, 0, 0, 0, 14, 0, 179881, 0, 0, 0, 0, 0, 0, 'Despawn gameobject In 7200000 ms');

Missing new line at the end of file

poszer

comment created time in 19 days

Pull request review commentazerothcore/azerothcore-wotlk

[QUEST] Let Them Eat Crow

+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1554387633805928700');++DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId` IN (13, 17) AND `SourceEntry` IN (42767, 42788);+INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorType`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES+(13, 2, 42788, 0, 0, 31, 0, 3, 23943, 0, 0, 0, 0, "", "Spell 'Feed Plaguehound' targets NPC 'Hungry Plaguehound'"),+(17, 0, 42788, 0, 0, 29, 0, 23943, 10, 0, 0, 0, 0, "", "Spell 'Feed Plaguehound' requires NPC 'Hungry Plaguehound' within 10 yards"),+(13, 1, 42767, 0, 0, 31, 0, 3, 23945, 0, 0, 0, 0, "", "Spell 'Sic'em' targets NPC 'Fjord Crow'");

like @Pondaveia said, please change the double quotes to single quotes

wizzymore

comment created time in 20 days

issue commentazerothcore/azerothcore-wotlk

ByteBuffer byte order

Can you put your AC commit hash?

rdcentermrzhi

comment created time in 21 days

more