profile
viewpoint
Francesco Borzì FrancescoBorzi @AzerothCore Netherlands https://www.linkedin.com/in/francesco-borzi/ Live and let live. -- Shin

push eventazerothcore/wiki

Stoabrogga

commit sha 650e9deb8575c220f5c0f98a2184d71c7b274747

doc: fix parameters for SMART_ACTION_SET_INGAME_PHASE_MASK (#116)

view details

push time in 6 hours

PR merged azerothcore/wiki

Fix parameters for SMART_ACTION_SET_INGAME_PHASE_MASK

The action only has 1 parameter, so delete the second.

+2 -1

0 comment

1 changed file

Stoabrogga

pr closed time in 6 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 244f65e0ccc38489032cf78d741dc5a0330c1014

wip

view details

push time in 6 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha b345bfcb41a700c795e94d6d1ca67d0d9415be48

wip

view details

FrancescoBorzi

commit sha 51ae895c51329f2e01fba57b93c6337bfeabc337

wip

view details

FrancescoBorzi

commit sha 78a3b603a22198780aac62c4f823ec37a2c0b4ac

wip

view details

push time in 7 hours

issue commentazerothcore/Keira3

Suggestion: Message after Execute

@crotin1111 the query is always successful, if it's not you will see an error.

Also after it executes the query, it reloads the entity (so you will see the new data).

So you can assume: no error = everything worked fine.

crotin1111

comment created time in 7 hours

issue openedelectron-userland/electron-builder

Pacman linux target is broken

<!-- Which version of electron-builder are you using? --> <!-- Please always try to use latest version before report. -->

  • Version: 21.2.0

My app is available here: https://github.com/azerothcore/Keira3

<!-- What target are you building for? -->

  • Target: Linux
  "linux": {
    "icon": "dist",
    "category": "Development",
    "target": [
      "AppImage",
      "deb",
      "snap",
      "pacman",
      "rpm"
    ]
  }

As soon as I add "pacman" to the list of linux targets, the build fails:

  • packaging       platform=linux arch=x64 electron=6.0.4 appOutDir=release/linux-unpacked
  • building        target=AppImage arch=x64 file=release/Keira3-3.0.0-alpha.1.AppImage
  • building        target=snap arch=x64 file=release/Keira3_3.0.0-alpha.1_amd64.snap
  • building        target=deb arch=x64 file=release/Keira3_3.0.0-alpha.1_amd64.deb
  • building        target=pacman arch=x64 file=release/Keira3-3.0.0-alpha.1.pacman
  ⨯ cannot execute  cause=exit status 1
                    out={:timestamp=>"2019-08-24T23:29:17.375971+0200", :message=>"Process failed: /usr/bin/zsh failed (exit code 127). Full command was:[\"/usr/bin/zsh\", \"-c\", \"LANG=C bsdtar -czf .MTREE --format=mtree --options='!all,use-set,type,uid,gid,mode,time,size,md5,sha256,link' opt .INSTALL usr .PKGINFO\"]", :level=>:error}
    
                    command=/home/shin/.cache/electron-builder/fpm/fpm-1.9.3-2.3.1-linux-x86_64/fpm -s dir --force -t pacman -d c-ares -d ffmpeg -d gtk3 -d http-parser -d libevent -d libvpx -d libxslt -d libxss -d minizip -d nss -d re2 -d snappy -d libnotify -d libappindicator-gtk3 -d libappindicator-sharp --pacman-compression xz --architecture amd64 --name Keira3 --after-install /tmp/t-NVFlgz/4-after-install --after-remove /tmp/t-NVFlgz/2-after-remove --description '
     Database Editor for AzerothCore' --version 3.0.0-alpha.1 --package /home/shin/sources/Keira3/release/Keira3-3.0.0-alpha.1.pacman --maintainer 'Francesco Borzi'"'"' <borzifrancesco@gmail.com>' --url https://github.com/AzerothCore/Keira3 --vendor 'Francesco Borzi'"'"' <borzifrancesco@gmail.com>' /home/shin/sources/Keira3/release/linux-unpacked/=/opt/Keira3 /home/shin/sources/Keira3/dist/favicon.256x256.png=/usr/share/icons/hicolor/256x256/apps/keira3.png /home/shin/sources/Keira3/dist/favicon.512x512.png=/usr/share/icons/hicolor/512x512/apps/keira3.png /tmp/t-NVFlgz/7-Keira3.desktop=/usr/share/applications/keira3.desktop
                    workingDir=
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! Keira3@3.0.0-alpha.1 electron:linux: `npm run build:prod && electron-builder build --linux`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the Keira3@3.0.0-alpha.1 electron:linux script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/shin/.npm/_logs/2019-08-24T21_29_17_452Z-debug.log

Without pacman, the other targets work fine.

created time in 7 hours

startedelectron-userland/electron-builder

started time in 7 hours

issue commentazerothcore/forum

[DEV] clang version support

@Yehonal why not? as I said:

In ubuntu packages, the latest version that you can install in 16.04 (without adding extra repositories) looks like to be clang 6

See:

  • https://packages.ubuntu.com/search?keywords=clang
  • https://packages.ubuntu.com/xenial-updates/clang-6.0
FrancescoBorzi

comment created time in 11 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 2781d0d459a74ec8bf4d925a6cbbbc04f09284ba

test: add some integration test cases

view details

push time in 11 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 82e0525cc4b386e46679d3f4e5d7177e9ed6cee1

wip

view details

push time in 12 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha e413d7cfa4444959f4086740b49ef8db18b17be2

wip

view details

FrancescoBorzi

commit sha c9cf37aa3ff09ef5c6095fa5be99dd359a7d0e11

wip

view details

FrancescoBorzi

commit sha fe3dd56c4a569961d7b6bec934e65ac86df45ce5

wip

view details

push time in 12 hours

pull request commentazerothcore/azerothcore-wotlk

Core/Misc: Rewrite name handling functions that use raw buffers

good job @Viste and @pklloveyou

Viste

comment created time in 13 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha b6c4c343490eec67b15633bf4aff25eb5b5c985c

wip

view details

push time in 13 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 2fe00c70c2098de46af6fcdbae4daef9c2786180

wip

view details

push time in 14 hours

create barnchazerothcore/Keira3

branch : item-template

created branch time in 14 hours

issue commentazerothcore/forum

[DEV] clang version support

I've opened a PR here where I change the min version of clang from 3.8 to 6.0:

https://github.com/azerothcore/azerothcore-wotlk/pull/2232

if you agree with this, just approve that PR, otherwise let's discuss it here

FrancescoBorzi

comment created time in 15 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha f822ddadb8192b0e3cc388eb3d0bbb9953c9da25

chore: change sidebar menu order

view details

push time in 16 hours

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha fa7c43aca4fc1fc21b0f3ad5d112a169cd6a1dc6

fix: build

view details

push time in 16 hours

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 300072c552020f3891fb7e8dd429af29b475d0e6

fix: build

view details

push time in 16 hours

push eventFrancescoBorzi/TrinityCore

Giacomo Pozzoni

commit sha 6ea161a71118e888c8f3e532ee9ae5e9f60a6e2c

CI/Travis: Upgrade to GCC 6

view details

Sorikoff

commit sha 996d4f7cc49041d57ab6152961dd645784b909a7

Scripts/Spells: Port Part of Druid Scripts to New Script Registration (#23691)

view details

Sorikoff

commit sha 382f563571d39f9ec02a0df899dbdaaf1745af83

Scripts/Spells: Runic Healing Injector (#23690) * Scripts/Spells: Runic Healing Injector * Rename 9999_99_99_99_world.sql to 2019_08_08_00_world.sql

view details

Keader

commit sha 31b4b897e4938b3f04d53c584b02ab4402132864

DB/Spells: Fixed proc of Remorseless Fix a case that Remorseless Attacks proc, but Remorseless is consumed by the same spell Closes #23649

view details

Treeston

commit sha 464b0b059b5ccb7db6d2f282937711032005b5c3

Core/Channels: Fix a bug that would cause channel settings to disappear in certain settings. Fix a bug that would cause channels to not be saved on .server shutdown without delay. Closes #23699.

view details

Keader

commit sha 3d356b97d4cc4c7ec4c641487241eae6dcc0558e

DB/Spells: Fixed Prayer of Mending proc with AOE Spells Fix proc with spells like: Professor Putricide AOE Abomination damage, Sindragosa Frost Damage, Blood Queen Damage.

view details

Treeston

commit sha 4211645834c467a03c60248e80818d3607be9ea7

[3.3.5] Core/Authserver: TOTP rewrite: (PR #23633) - Proper management commands (.account 2fa) - Secrets can now be encrypted (set TOTPTokenSecret in .conf) - Secret now stored in binary - Argon2 and AES primitives - Base32/64 support

view details

Treeston

commit sha 0f7e070ed4cd01ffb4c5384b74d7b7b01d758c0d

Common/Crypto: Make C++14 compilers happy.

view details

Treeston

commit sha fcce90508d899641494d7c281a0e08e411a0d5ab

Core/Creature: Fix an issue that sometimes prevented spellcast focus targets from being reacquired.

view details

Treeston

commit sha 1c2b1cbba82fcd523ccd0cceafe532f35d71dcc1

Entities/Player: ReacquireSpellFocusTarget is now private. It should've been private all along.

view details

Treeston

commit sha 31b5632c0006cf74f83d5cece5e0e40579d27501

Common/Utilities: Explicit tail recursion to keep the compilers happy.

view details

Treeston

commit sha 7378bcb4182cea04d00b74393ba73ce9cb7ea49e

ugh. compilers. 31b5632 follow-up.

view details

Treeston

commit sha 0a40252c29437672f7d200e347ff6e9d805c3bcf

i am so done with compilers for today , WHY IS STD::SWAP NOT A CONSTEXPR ASDFOWQWDO (31b5632 7378bcb follow-up grml)

view details

Treeston

commit sha 3750c1cad90365d1059edb760a55425291767a12

I actually changed compilers in godbolt this time. This does it. Really. (31b5632 7378bcb 0a40252)

view details

Aokromes

commit sha 028db8432eb220de198123871741fd8c36c52ebe

Core/Spells: Survey Sinkholes will now have a bigger range to be able… … to hit all trigger npcs By Ovahlord

view details

Treeston

commit sha 6590a0bfcefe7b8e5f87c82ba5ab4df2c72be418

Entities/Creature: Fix an edge case assertion failure with pets dying in specific situations while casting spells.

view details

Gildor

commit sha af874a211c0f064bd685cddeded3ca7d6d690e8f

DB/Spells: Mage - Icy Veins stack

view details

Keader

commit sha 95284b23d1e48883fe738ecf5a12c4253566894e

Core/Spells: Fixed SPELL_EFFECT_DISPEL when target has 2 spells with same ID (#23710) Ty sirikfoll for all help :)

view details

Keader

commit sha fec48caabea79cb02a3563421b0516a0bf1fa8a4

Core/Spells: Drain Soul need be affected by Death's Embrace Make Warlock Affliction great again !

view details

Sorikoff

commit sha f7793e78000389315d53b22fb4e117d512c5a4d6

Scripts/Spells: Port druid scripts to new script registration syntax (3 of 3) (#23714)

view details

push time in 16 hours

PR opened azerothcore/azerothcore-wotlk

feat(CI/Travis): use Ubuntu 18.04 + update min clang version

See: https://github.com/azerothcore/forum/issues/48

+5 -11

0 comment

3 changed files

pr created time in 16 hours

create barnchFrancescoBorzi/azerothcore-wotlk

branch : update-travis

created branch time in 16 hours

push eventFrancescoBorzi/azerothcore-wotlk

Francesco Borzì

commit sha cde07f89b9be04625e87f3286968bc0956b0450a

fix: revert unwanted Spell changes (#2222) - Partially reverts https://github.com/azerothcore/azerothcore-wotlk/commit/7954a2a07ed1af2eb050f9252d3d2c3d7dab7e1f

view details

Kargatum

commit sha b1d102e04b480ff2791d6167ca7891a314dbbcdd

feat(Core/BG): rewrite invite in bg (#2137) Co-authored-by: mik1893 <michele.roscelli@gmail.com>

view details

Stoabrogga

commit sha c7cd2a3cb73a1b4887b73ddf76d38f5389d7bda3

fix(DB/SAI): Stoneskin Gargoyle (Naxxramas) (#2169)

view details

AzerothCoreBot

commit sha f3957dc2932f9d581aa5105a44923c5e491818a2

Import pending SQL update file... Referenced commit(s): c7cd2a3cb73a1b4887b73ddf76d38f5389d7bda3

view details

Francesco Borzì

commit sha c300bf8158d7b53d679302a9172d4cdbcd0ca2f1

fix(db-assembler): error 'cant find any matching row in the user table' (#2202)

view details

Francesco Borzì

commit sha 2f74802d03d52d735f8f2b06dee0151f2dde47c1

chore(authserver): improve startup console logs (#2227)

view details

push time in 17 hours

pull request commentazerothcore/azerothcore-wotlk

Core/Misc: Rewrite name handling functions that use raw buffers

@pklloveyou have you tried this already?

Viste

comment created time in 18 hours

issue openedazerothcore/forum

[DEV] clang version support

Currently, in the AC travis build we run 2 pipelines:

  • one with clang 7
  • one with clang 3.8

also we target C++14. There have been discussions about dropping the 3.8 version. Not worrying of such an old version of the compiler would bring several benefits.

We should decide what would be then the minimum version of clang that we want to support.

In my opinion we should try to make it at least version 5 so we can target C++17:

image

(more info here)

In ubuntu packages, the latest version that you can install in 16.04 (without adding extra repositories) looks like to be clang 6, so I think it is safe enough to support at least version 6

created time in 18 hours

pull request commentazerothcore/azerothcore-wotlk

Core/Misc: Rewrite name handling functions that use raw buffers

@Viste please tell what this can potentially affect so @pklloveyou can test it

Viste

comment created time in 18 hours

delete branch FrancescoBorzi/azerothcore-wotlk

delete branch : authserver-console-log

delete time in a day

push eventazerothcore/Keira3

renovate[bot]

commit sha e647d0e72f07e0fb31498557becfe6713af0604b

chore(deps): update dependency electron to v6.0.4 (#77)

view details

push time in a day

PR merged azerothcore/Keira3

chore(deps): update dependency electron to v6.0.4

This PR contains the following updates:

Package Type Update Change
electron devDependencies patch 6.0.3 -> 6.0.4

Release Notes

<details> <summary>electron/electron</summary>

v6.0.4

Compare Source

Release Notes for v6.0.4

Fixes

  • Fixed an issue where a call to child_process.fork() would set ELECTRON_RUN_AS_NODE in the main process. #​19845
  • Fixed web page displayed with offset when using native tab on macOS. #​19888
  • Fixed white flash after restoring an app from the background. #​19900

Other Changes

  • Updated Chromium to 76.0.3809.131. #​19909

Documentation

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+7 -7

0 comment

2 changed files

renovate[bot]

pr closed time in a day

delete branch azerothcore/Keira3

delete branch : renovate/ngx-clipboard-12.x

delete time in 2 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 252a7d20f5bfce9ad314291f8ba69c56bffa28f6

chore(deps): update dependency ngx-clipboard to v12.2.1 (#76)

view details

push time in 2 days

PR merged azerothcore/Keira3

chore(deps): update dependency ngx-clipboard to v12.2.1

This PR contains the following updates:

Package Type Update Change
ngx-clipboard devDependencies patch 12.2.0 -> 12.2.1

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

delete branch FrancescoBorzi/ngx-duration-picker

delete branch : renovate/tsickle-0.x

delete time in 2 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha e1f8e4955aa414b4f2b00553288b4c10d4482a69

chore(deps): update dependency tsickle to v0.37.0 (#50)

view details

push time in 2 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency tsickle to v0.37.0

This PR contains the following updates:

Package Type Update Change
tsickle devDependencies minor 0.36.0 -> 0.37.0

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

startedwulkano/kap

started time in 2 days

delete branch azerothcore/Keira3

delete branch : go-loot

delete time in 2 days

delete branch azerothcore/Keira3

delete branch : coverage-100

delete time in 2 days

push eventazerothcore/Keira3

Francesco Borzì

commit sha 21ab83ae5005e1df4be526595b56b32b5689c263

test: set the coverage thresholds to 100 (#73)

view details

push time in 2 days

PR merged azerothcore/Keira3

Reviewers
test: set the coverage thresholds to 100
+34 -4

0 comment

2 changed files

FrancescoBorzi

pr closed time in 2 days

delete branch FrancescoBorzi/azerothcore-wotlk

delete branch : fix-db-assembler-issue

delete time in 2 days

PR opened azerothcore/azerothcore-wotlk

chore(authserver): improve startup console logs To Be Merged

Changes:

  • improved the error shown when the authserver port is invalid (showing the name of the parameter and the actual invalid value)
  • showing the bind ip address and the port that the authserver is listening to

There is no need to test since these are cosmetic changes that just add some logs, there is no way they break anything (and I have tested them locally).

+3 -1

0 comment

1 changed file

pr created time in 2 days

push eventFrancescoBorzi/azerothcore-wotlk

FrancescoBorzi

commit sha 4ba6b127862d42b3edde4f8c8008778279ffa584

chore: add ip

view details

push time in 2 days

create barnchFrancescoBorzi/azerothcore-wotlk

branch : authserver-console-log

created branch time in 2 days

issue commentazerothcore/azerothcore-wotlk

Taming The Beast Quest line

it would be nice to understand which commit fucked it up so we can fix it

Halokillerman7

comment created time in 2 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 88ebcac5951af13fc3b36a968c04038b265440a8

chore(deps): update dependency @fortawesome/fontawesome-free to v5.10.2 (#75)

view details

push time in 2 days

PR merged azerothcore/Keira3

chore(deps): update dependency @fortawesome/fontawesome-free to v5.10.2

This PR contains the following updates:

Package Type Update Change
@fortawesome/fontawesome-free (source) devDependencies patch 5.10.1 -> 5.10.2

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 132a2b83cb87ce636b93ec51778ea79c3017ecc3

chore(deps): update angularcli monorepo (#49)

view details

push time in 2 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update angularcli monorepo

This PR contains the following updates:

Package Type Update Change
@angular-devkit/build-angular devDependencies minor 0.802.2 -> 0.803.0
@angular-devkit/build-ng-packagr devDependencies minor 0.802.2 -> 0.803.0
@angular/cli devDependencies minor 8.2.2 -> 8.3.0

Release Notes

<details> <summary>angular/angular-cli</summary>

v8.3.0

Compare Source

Commits

<table> <tbody>

<tr><td colspan=3><h3>@​schematics/angular (8.3.0)</h3></td></tr> <tr> <td><b>Commit</b> <td><b>Description</b> <td><b>Notes</b> </tr>

<tr>

<td> <a href="https://togithub.com/angular/angular-cli/commit/237119c364241f8a089324f0faf92e7f62fe560a"><img align="top" title="Bug Fix" src="https://img.shields.io/badge/237119c-fix-green.svg" /> </a> </td>

<td>add twitter link icon (#​15385)</td>

<td> </td> </tr> <tr>

<td> <a href="https://togithub.com/angular/angular-cli/commit/1bb8c9a5c82f790ac7af9663203573da0bd2aef9"><img align="top" title="Bug Fix" src="https://img.shields.io/badge/1bb8c9a-fix-green.svg" /> </a> </td>

<td>default interface for guard</td>

<td> </td> </tr>

</tbody> </table>



Special Thanks

Judy Bogart, Keen Yee Liau, Stefanie Fluin, Charles Lyding, Alan Agius, Cédric Exbrayat

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+1480 -457

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 7e258d640c1929419de61e7da12163ec52913f5c

chore(deps): update angularcli monorepo (#74)

view details

push time in 2 days

PR merged azerothcore/Keira3

chore(deps): update angularcli monorepo

This PR contains the following updates:

Package Type Update Change
@angular-devkit/build-angular devDependencies minor 0.802.2 -> 0.803.0
@angular/cli devDependencies minor 8.2.2 -> 8.3.0

Release Notes

<details> <summary>angular/angular-cli</summary>

v8.3.0

Compare Source

Commits

<table> <tbody>

<tr><td colspan=3><h3>@​schematics/angular (8.3.0)</h3></td></tr> <tr> <td><b>Commit</b> <td><b>Description</b> <td><b>Notes</b> </tr>

<tr>

<td> <a href="https://togithub.com/angular/angular-cli/commit/237119c364241f8a089324f0faf92e7f62fe560a"><img align="top" title="Bug Fix" src="https://img.shields.io/badge/237119c-fix-green.svg" /> </a> </td>

<td>add twitter link icon (#​15385)</td>

<td> </td> </tr> <tr>

<td> <a href="https://togithub.com/angular/angular-cli/commit/1bb8c9a5c82f790ac7af9663203573da0bd2aef9"><img align="top" title="Bug Fix" src="https://img.shields.io/badge/1bb8c9a-fix-green.svg" /> </a> </td>

<td>default interface for guard</td>

<td> </td> </tr>

</tbody> </table>



Special Thanks

Judy Bogart, Keen Yee Liau, Stefanie Fluin, Charles Lyding, Alan Agius, Cédric Exbrayat

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+1360 -360

0 comment

2 changed files

renovate[bot]

pr closed time in 2 days

issue commentazerothcore/azerothcore-wotlk

Vmap not loaded for some maps

@LichKing255 there is something wrong in your local setup, we can try to help you and figure out where the problem is, but this doesn't look like a bug in the core so the report can be closed

LichKing255

comment created time in 2 days

IssuesEvent

PR opened azerothcore/Keira3

Reviewers
test: set the coverage thresholds to 100
+34 -4

0 comment

2 changed files

pr created time in 3 days

create barnchazerothcore/Keira3

branch : coverage-100

created branch time in 3 days

pull request commentazerothcore/azerothcore-wotlk

Fix(Core/Spells): some corrections to spell attributes

Please solve the discussion so this PR can be merged

Viste

comment created time in 3 days

delete branch azerothcore/Keira3

delete branch : item-2

delete time in 3 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 5f4e06e441ac7e8d8e69c6ff9e43ba1750405bd6

fix(deps): update angular monorepo to v8.2.3 (#48)

view details

push time in 3 days

PR merged azerothcore/Keira3

chore(deps): update angular monorepo to v8.2.3

This PR contains the following updates:

Package Type Update Change
@angular/animations devDependencies patch 8.2.2 -> 8.2.3
@angular/common devDependencies patch 8.2.2 -> 8.2.3
@angular/compiler devDependencies patch 8.2.2 -> 8.2.3
@angular/compiler-cli devDependencies patch 8.2.2 -> 8.2.3
@angular/core devDependencies patch 8.2.2 -> 8.2.3
@angular/forms devDependencies patch 8.2.2 -> 8.2.3
@angular/platform-browser devDependencies patch 8.2.2 -> 8.2.3
@angular/platform-browser-dynamic devDependencies patch 8.2.2 -> 8.2.3
@angular/router devDependencies patch 8.2.2 -> 8.2.3

Release Notes

<details> <summary>angular/angular</summary>

v8.2.3

Compare Source

Bug Fixes
  • bazel: pin [@microsoft](https://togithub.com/microsoft)/api-extractor (#​32187) (a7b9478)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+39 -39

0 comment

2 changed files

renovate[bot]

pr closed time in 3 days

push eventazerothcore/wiki

MaloW

commit sha c5c91975856c2778e9758788731078fbf9d73e55

Update Requirements.md (#115) Clarified MySQL Server version requirement.

view details

push time in 3 days

PR merged azerothcore/wiki

Update Requirements.md

Clarified MySQL Server version requirement.

Motivation and Context

Some people are getting it wrong and installs version 8.0, "5.6 or higher" technically includes 8.0.

+1 -1

0 comment

1 changed file

Malow

pr closed time in 3 days

issue commentazerothcore/azerothcore-wotlk

[CRASH] Custom Channel JOIN/LEAVE/LIST with unk name exploit

any update on this?

might be related with: https://github.com/TrinityCore/TrinityCore/issues/23215

MeGoEA

comment created time in 4 days

issue commentazerothcore/azerothcore-wotlk

[Feature Request] Cross-Faction Dungeon Finder [$30]

A module for crossfaction dungeon finder, a module for crossfaction battlegrounds, a module for crossfaction ICC, what else??

When we enable crossfaction, we want all these things in ONE. All in one. Imo it should be in the core or all in one big module. In the core there is already crossfaction chat, grouping etc...........................

you got a point, what I don't want is to break/complicate/alter the current behaviour when introducing such extra features

@Ali-Khazaee @BarbzYHOOL I don't mind if it's in the core, as long as when:

AllowTwoSide.DungeonFinder = 0

it has NO side effects at all

andoys

comment created time in 4 days

delete branch FrancescoBorzi/ngx-duration-picker

delete branch : renovate/tslint-5.x

delete time in 4 days

delete branch azerothcore/Keira3

delete branch : renovate/tslint-5.x

delete time in 4 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 09e33c3d03101aa9c0bfb84ea298ad09e59fac48

chore(deps): update dependency tslint to v5.19.0 (#70)

view details

push time in 4 days

PR merged azerothcore/Keira3

chore(deps): update dependency tslint to v5.19.0

This PR contains the following updates:

Package Type Update Change
tslint (source) devDependencies minor 5.18.0 -> 5.19.0

Release Notes

<details> <summary>palantir/tslint</summary>

v5.19.0

Compare Source

Thanks to our contributors!

  • Josh Pike
  • Tanmoy Bhowmik
  • Michael Withagen
  • Evgeniy Timokhov
  • Vitalij Krotov
  • Josh Goldberg
  • Veda
  • Guido
  • Robert Fink
  • Max Sysoev

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+7 -7

0 comment

2 changed files

renovate[bot]

pr closed time in 4 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 53e4281c5036d42b422387beda46ea39128b316b

chore(deps): update dependency tslint to v5.19.0 (#47)

view details

push time in 4 days

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency tslint to v5.19.0

This PR contains the following updates:

Package Type Update Change
tslint (source) devDependencies minor 5.18.0 -> 5.19.0

Release Notes

<details> <summary>palantir/tslint</summary>

v5.19.0

Compare Source

Thanks to our contributors!

  • Josh Pike
  • Tanmoy Bhowmik
  • Michael Withagen
  • Evgeniy Timokhov
  • Vitalij Krotov
  • Josh Goldberg
  • Veda
  • Guido
  • Robert Fink
  • Max Sysoev

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 4 days

issue openedmaximegris/angular-electron

Use Cypress to e2e test Angular Electron applications

Cypress is currently working on adding the support for Electron and there is already a demo available:

https://github.com/cypress-io/cypress-example-electron

it would be nice if we can configure Cypress as e2e test framework in this repo

created time in 4 days

issue commentazerothcore/azerothcore-wotlk

[Feature Request] Cross-Faction Dungeon Finder [$30]

@Ali-Khazaee that's fine, you can add the hooks to the core when needed

andoys

comment created time in 4 days

issue commentazerothcore/azerothcore-wotlk

Crash worldserver

@blackdev01 that's a hack and only works with standard latin characters

Undead02

comment created time in 4 days

issue closedazerothcore/azerothcore-wotlk

Elwynn Forest and Durotar is neutral zones

Elwynn Forest and Durotar must be frendly zones. Now they neutral zones for fractions.

https://i5.imageban.ru/out/2019/08/19/f32df548770e0bd5de8ff6a56db7d172.jpg https://i4.imageban.ru/out/2019/08/19/f6c568819519b8838498c75173ca3920.jpg https://i2.imageban.ru/out/2019/08/19/85a72f1e60fb7696463e01531bd0f27c.jpg https://i2.imageban.ru/out/2019/08/19/ceeade3b575e72d7e4550fdfa0ab4f0f.jpg

Must be: https://i5.imageban.ru/out/2019/08/19/81feb53d239c56ee806a23e0c556fd89.jpg

<bountysource-plugin>


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

closed time in 4 days

Mitradis

delete branch azerothcore/Keira3

delete branch : renovate/highlight.js-9.x

delete time in 4 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 94e717a68b32bdf789a2249ab1ae45b10f42db3d

chore(deps): update dependency highlight.js to v9.15.10 (#69)

view details

push time in 4 days

PR merged azerothcore/Keira3

chore(deps): update dependency highlight.js to v9.15.10

This PR contains the following updates:

Package Type Update Change
highlight.js (source) devDependencies patch 9.15.9 -> 9.15.10

Release Notes

<details> <summary>highlightjs/highlight.js</summary>

v9.15.10

Compare Source

New languages: none. New styles: none. Improvements:

  • support for ruby's squiggly heredoc (#​2049)
  • support css custom properties (#​2082)
  • fix(PureBASIC): update to 5.60 (#​1508)
  • fix(Kotlin): parenthesized types in function declaration (#​2107)
  • fix(Kotlin): nested comment (#​2104)
  • fix(isbl): contains key typo (#​2103)
  • fix(github-gist.css): match Github styles (#​2100)
  • fix(elm): update to latest elm syntax (#​2088)
  • fix: Support highlighting inline HTML and CSS tagged template strings in JS and TS (#​2105)
  • feat(YAML): add YAML to common languages (#​1952)
  • feat(xml): Add support for Windows Script File (.wsf), inline VBScript in XML script tags (#​1690)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 4 days

issue commentazerothcore/azerothcore-wotlk

[Feature Request] Cross-Faction Dungeon Finder [$30]

@Ali-Khazaee can you make it as an addition to the CFBG module?

we should avoid patching the core directly

andoys

comment created time in 5 days

delete branch azerothcore/Keira3

delete branch : renovate/electron-6.x

delete time in 5 days

PR merged azerothcore/Keira3

chore(deps): update dependency electron to v6.0.3

This PR contains the following updates:

Package Type Update Change
electron devDependencies patch 6.0.2 -> 6.0.3

Release Notes

<details> <summary>electron/electron</summary>

v6.0.3

Compare Source

Release Notes for v6.0.3

Fixes

  • Correctly internationalize i18n in GTK-based Linux dialogs. #​19760
  • Fixed a bug where you couldn't navigate the menu bar with the keyboard if you used the mouse to focus it. #​19764
  • Fixed bug where inputs would lose focus when opening the menu bar, preventing many menu items (Edit/Copy/Paste/etc.) to be unusable on Windows and Linux. #​19708
  • Fixed occasional crashes while selecting text. #​19808
  • Normalized out-of-bound value behavior for the setOpacity() API in BrowserWindow. #​19723
  • Removed the possibility of a preload script being executed twice for the same process in quickly succeeding navigations in the same frame. #​19826

Other Changes

Documentation

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 5 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 121e870fe5255970f8afceb4d62104b509531744

chore(deps): update dependency electron to v6.0.3 (#68)

view details

push time in 5 days

PR opened azerothcore/Keira3

Reviewers
feat: Item Select & skeleton for Item Template editor
+469 -4

0 comment

17 changed files

pr created time in 5 days

create barnchazerothcore/Keira3

branch : item-2

created branch time in 5 days

push eventazerothcore/Keira3

Francesco Borzì

commit sha b74ea2007c185eeaacca9981c2ef1bdd2a0ff1ac

Update README.md

view details

push time in 5 days

issue openedazerothcore/Keira3

3.0.0 release progress tracking

Feature editors planned for 3.0.0 release

  • [ ] Creature
  • [ ] Quest
  • [ ] Gameobject
  • [ ] Item
  • [ ] Gossip
  • [ ] Conditions
  • [ ] SmartAI

created time in 5 days

push eventazerothcore/wiki

Francesco Borzì

commit sha 488cb0ff7a2b193cc124e4d2fdd5e1de98ab9a78

Update How-to-ask-for-help.md

view details

push time in 5 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 36a66a9eb7404cbe4a893a51b864a7c8e2f88ea3

chore(deps): update dependency @types/mysql to v2.15.7 (#65)

view details

push time in 5 days

PR merged azerothcore/Keira3

chore(deps): update dependency @types/mysql to v2.15.7

This PR contains the following updates:

Package Type Update Change
@types/mysql devDependencies patch 2.15.6 -> 2.15.7

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 5 days

startedhomebots/alfred

started time in 6 days

Pull request review commentazerothcore/wiki

add linux user create instructions

 Alternatively, it is also possible to [use AzerothCore with Docker](Install-with  For macOS users: the build on mac is currently broken (see [this issue](https://github.com/azerothcore/azerothcore-wotlk/issues/122)), but you can still use AzerothCore on macOS with Docker. -## 1) Installing the requirements+## 1) Creating a user to work with on Linux

Shall we mark this as an optional step? On local development environments you don't really need it

milestorme

comment created time in 6 days

push eventazerothcore/Keira3

FrancescoBorzi

commit sha dc8ab0f92042d4bcaa101d16ca674c2fba3cce3f

services

view details

push time in 6 days

PR opened azerothcore/Keira3

chore: prepare to implement Item editors
+77 -1

0 comment

9 changed files

pr created time in 6 days

push eventazerothcore/Keira3

FrancescoBorzi

commit sha ce51989b6d175cb58e34442a6b54784b677ee7ef

add types

view details

push time in 6 days

CommitCommentEvent

pull request commentazerothcore/azerothcore-wotlk

Ice Tomb

good job @Ali-Khazaee and thanks a lot @Knindzagxg and @disclosurez for testing this!

Ali-Khazaee

comment created time in 6 days

create barnchazerothcore/Keira3

branch : item-1

created branch time in 6 days

issue commentFrancescoBorzi/ngx-duration-picker

Output format

@SpeCT you can give us a Star if you like it :)

and good job @superdyzio

superdyzio

comment created time in 6 days

issue commentFrancescoBorzi/ngx-duration-picker

Output format

@SpeCT done: 3.2.0

superdyzio

comment created time in 6 days

created tagFrancescoBorzi/ngx-duration-picker

tag3.2.0

Angular component for ISO_8601 durations

created time in 6 days

release FrancescoBorzi/ngx-duration-picker

3.2.0

released time in 6 days

push eventFrancescoBorzi/ngx-duration-picker

FrancescoBorzi

commit sha c86bf6293467594551c3406ae36fc35e467f6bf5

release: 3.2.0

view details

push time in 6 days

more