profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/FinalAngel/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Angelo Dini FinalAngel Divio AG Zurich https://angelo.dini.dev Full-Stack developer @divio. Passionate Instructor @hsr_rapperswil and core developer of @djangocms. Now studying @FHNW for fun.

FinalAngel/classjs 57

Class.js is a JavaScript library for building class based object-oriented programms using JavaScript's prototypal inheritance. It strives to mimic classical class inheritance provided by other languages such as Python, Java or PHP. Its syntax is heavily inspired by MooTools's class implementation.

ella/django-appdata 27

extendable field for use in Django Models

FinalAngel/classjs-plugins 7

Class.js plugins are aimed for professionals with extensive JavaScript knowledge. Each plugin follows a simplistic and a modular approach. All plugins have demos, tests and documentation regarding their options, methods, events and callbacks.

FinalAngel/django-cms-toolbar 6

new new django toolbar for 2.4

digi604/django-cms 1

An Advanced Django CMS.

FinalAngel/cmsplugin-filer 1

django-filer cms plugins for django-cms

FinalAngel/django 1

Official clone of the Subversion repository.

FinalAngel/django-filer 1

File and Image Management Application for django. IMPORTANT: starting with version 0.8.0 we are using easy-thumbnails instead of sorl.thumbnail! See the wiki for information on the legacy support branch for sorl.thumbnail.

FinalAngel/django-hvad 1

Painless translations in django, integrates easily into existing projects. Project originates from django-nani.

FinalAngel/django-shop 1

A Django based shop system

startedant-design/ant-design

started time in an hour

pull request commentdjango-cms/django-cms

adding django CMS release script (will be used starting 3.9.0 release)

@FinalAngel @NicolaiRidani for visibility (I'll merge this before starting 3.9 as this is the actual process used to create the release :) )

This file may change during the release cycle (debugging/improvement as I use it), but that's fine as it is standalone.

goutnet

comment created time in 6 hours

PR opened django-cms/django-cms

adding django CMS release script (will be used starting 3.9.0 release)

Description

This PR adds an script to automate the release process. This will be used for 3.9.0 and onward (will auto-merge this before starting the actual release cycle)

Checklist

  • [x ] I have opened this pull request against develop
  • [x] I have updated the CHANGELOG.rst
  • [x] I have added or modified the tests when changing logic
  • [x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.
+349 -0

0 comment

2 changed files

pr created time in 6 hours

pull request commentdjango-cms/django-cms

Add support for Django 3.2

@FinalAngel @macolo can you have a look?

vinitkumar

comment created time in a day

issue closeddjango-cms/django-cms

Permission signals don't work when user model is customized

Description

Permission signals don't work when the user model is customized by AUTH_USER_MODEL settings.

Steps to reproduce

Steps to reproduce the behavior:

  1. Start with a fresh django-cms installation.
  2. Customize the default user model by setting AUTH_USER_MODEL to your own user model.
  3. Migrate and start the development server.
  4. Login to CMS and create a new user.

Expected behaviour

A post_save_user signal should create a PageUser model instance for the user created.

Actual behaviour

The PageUser model instance is not created.

closed time in 2 days

monim67

push eventdjango-cms/django-cms

Munim Munna

commit sha c38fde3bd084f29dd5762b40ab406c8a367b5262

Fix hard-coded primary key of PageUser (#7034) Co-authored-by: Mark Walker <theshow@gmail.com>

view details

push time in 2 days

PR merged django-cms/django-cms

Fix hard-coded primary key of PageUser

Description

This PR fixes the issue #7030 for cases where the user model is named other than User.

The post_save_user signal is using a hard-coded value of primary key user_ptr_id while creating PageUser instance. So if the user model is named anything other than User e.g Admin then the database column name becomes admin_ptr_id which raises an error while executing the signal.

This PR uses pk to assign primary key field.

+1 -1

0 comment

1 changed file

monim67

pr closed time in 2 days

issue commentdjango-cms/django-cms

Garbled text shows up after saving plug-in instances on 3.5.3 and 3.6

So here is my screen recording. It took some time to capture it, as this bug only occurs every now and then, not every time, but often enough to bother the editing users. So I can’t reliably reproduce it in the sense that you see it every time after doing certain actions.

https://user-images.githubusercontent.com/9460962/118189692-63caac00-b442-11eb-9025-546b49241d9f.mp4

I agree, it seems to be JavaScript related, and as mentioned, it didn’t occur until 3.5.2. I use mainly Firefox on Linux. I’m going to check out if I can reproduce it also on Chromium and Chrome. My colleagues have also encountered this bug. I’m going to ask what they used on their Windows systems.

MacLake

comment created time in 2 days

Pull request review commentdjango-cms/django-cms

Fixed #3734 -- Automated check that PlaceholderFields use Placeholder…

 def get_class(method_name, model):                                    'https://django-cms.readthedocs.io/en/latest/extending_cms/extending_page_title.html#handling-relations.')  # noqa  +@define_check+def check_placeholder_fields(output):+    """+    ModelAdmin instances that are using PlaceholderField fields+    should be also a subclass of PlaceholderAdminMixin+    """+    from django.contrib.admin import site+    from cms.models.fields import PlaceholderField+    from cms.admin.placeholderadmin import PlaceholderAdminMixin++    with output.section("PlaceholderField") as section:+        for model, model_admin in site._registry.items():+            ph_fields = [field for field in model._meta.get_fields() if isinstance(field, PlaceholderField)]+            if len(ph_fields) == 0:

you can do if not ph_fields instead

vaquer

comment created time in 2 days

push eventdjango-cms/django-cms

Vytis Banaitis

commit sha 1dc047821c16a5143afbbc8977d7ff3b08b95963

Improved performance of 'cms list plugins'. (#6718) Co-authored-by: Vinit Kumar <mail@vinitkumar.me>

view details

push time in 2 days

PR merged django-cms/django-cms

Reviewers
Improved performance of 'cms list plugins'. needs expert opinion

Summary

Avoid calculating plugin_report() twice.

General checklist

  • [X] I have updated the CHANGELOG.txt
  • [ ] I have created backports if necessary
  • [ ] I have updated the documentation and/or amended the upgrade section if necessary
+9 -3

4 comments

3 changed files

vytisb

pr closed time in 2 days

PR opened django-cms/django-cms

allow retrieving page attributes from other sites

Basically pulled the branch and resolved conflicts for this PR, so that the Author's contribution go to the codebase and at the same time, we are not blocked for the Author to resolve their conflicts. (Old PR, they might have forgotten about the PR itself)

  • PR Link: https://github.com/django-cms/django-cms/pull/6674
  • Author: https://github.com/ianare
+4 -2

0 comment

2 changed files

pr created time in 2 days

pull request commentdjango-cms/django-cms

Fixed #3734 -- Automated check that PlaceholderFields use Placeholder…

@czpython Do you think this is merge ready?

vaquer

comment created time in 2 days

PR opened django-cms/django-cms

Fix hard-coded primary key of PageUser

Description

This PR fixes the issue #7030 for cases where the user model is named other than User.

The post_save_user signal is using a hard-coded value of primary key user_ptr_id while creating PageUser instance. So if the user model is named anything other than User e.g Admin then the database column name becomes admin_ptr_id which raises an error while executing the signal.

This PR uses pk to assign primary key field.

+1 -1

0 comment

1 changed file

pr created time in 2 days

pull request commentdjango-cms/django-cms

Fixed an issue where the wrong page title was returned

@mekanics @goutnet You guys can also ask our dedicated PR review group on Slack #workgroup-pr-review to review the PR. See also our PR review process: https://github.com/django-cms/django-cms/blob/develop/CONTRIBUTING.rst

mekanics

comment created time in 2 days

pull request commentdjango-cms/django-cms

Fixed an issue where the wrong page title was returned

@FinalAngel could I ask your wisedom on this maybe :) ?

mekanics

comment created time in 2 days

pull request commentdjango-cms/django-cms

Fixed an issue where the wrong page title was returned

@goutnet I just rebased my branch onto develop. The conflicts has been resolved.

Now, we just need someone to review and merge the branch 🙂

mekanics

comment created time in 2 days

issue openeddjango-cms/django-cms

[BUG] management command "cms check" doesn't work

Description

When running the command python manage.py cms check on the develop branch there is an issue with the argument parsing of the custom management command.

I am aware that this happens on a development branch. This issue is mainly to raise awareness and coordinate any efforts to fix this issue.

Steps to reproduce

Run the command python manage.py cms check and the following output is logged:

Traceback (most recent call last): File "/home/michael/projects/django-cms-demo/myproject/manage.py", line 22, in <module> main() File "/home/michael/projects/django-cms-demo/myproject/manage.py", line 18, in main execute_from_command_line(sys.argv) File "/home/michael/projects/django-cms-demo/venv/lib/python3.9/site-packages/django/core/management/init.py", line 419, in execute_from_command_line utility.execute() File "/home/michael/projects/django-cms-demo/venv/lib/python3.9/site-packages/django/core/management/init.py", line 413, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/home/michael/projects/django-cms-demo/venv/lib/python3.9/site-packages/django/core/management/base.py", line 355, in run_from_argv self.execute(*args, **cmd_options) File "/home/michael/projects/django-cms-demo/venv/lib/python3.9/site-packages/django/core/management/base.py", line 391, in execute if self.requires_system_checks and not options['skip_checks']: KeyError: 'skip_checks'

Expected behaviour

CMS checks are performed without error.

Actual behaviour

The parsing of the management command fails with an error on parsing the arguments passed to the management command.

Additional information (CMS/Python/Django versions)

Regular management commands (for example manage.py check) work without issue.

  • Django CMS: develop branch
  • Python 3.9
  • Installed packages:

asgiref==3.3.4 Django==3.2.2 django-classy-tags==1.0.0 django-cms @ file:///home/michael/projects/django-cms django-formtools==2.2 django-sekizai==2.0.0 django-treebeard==4.3.1 djangocms-admin-style==2.0.2 pytz==2021.1 six==1.16.0 sqlparse==0.4.1

created time in 3 days

pull request commentdjango-cms/django-cms

Added fix to migrations to handle multi database routing

@goutnet @Aiky30 I've rebased the branch on the latest develop branch and added an entry to the CHANGELOG file.

MichaelAnckaert

comment created time in 3 days

issue commentdjango-cms/django-cms

Garbled text shows up after saving plug-in instances on 3.5.3 and 3.6

@MacLake thanks for the additional info.

As a side note, I'm also running a multisite setup in multiple languages using 1 database as well 👍 This system is currently on python 3.7 or 3.8, Django 2.2 and cms 3.7 I believe.

Initially what this looks like to me is an issue related to javascript, so browser details would also be helpful.

MacLake

comment created time in 4 days

issue commentdjango-cms/django-cms

Garbled text shows up after saving plug-in instances on 3.5.3 and 3.6

@marksweb Thanks for taking care of this! One more thing: Our setup is a multi-site and multilingual instance. We have used the same database for all these sites. Recently we have added another site. Since we have external editors for this EU project, I use a new separate database for this new site in order to have a better separation, but still the same virtualenv. In this new site I haven’t seen this garbled text.

MacLake

comment created time in 4 days

issue commentdjango-cms/django-cms

Garbled text shows up after saving plug-in instances on 3.5.3 and 3.6

@MacLake Can you reliably reproduce the error? If so, can you please be kind enough to do a screen-recording and share it with us? It will greatly help us reproduce and possibly also fix it.

MacLake

comment created time in 4 days

issue commentdjango-cms/django-cms

The slugs of child pages are built incorrectly and return a 404 error when a user adds a custom slug for another language of the parent page

ok, thanks. With that said we aim to close the merge window this weekend :)

victor-yunenko

comment created time in 4 days

issue commentdjango-cms/django-cms

Garbled text shows up after saving plug-in instances on 3.5.3 and 3.6

@MacLake Thanks for the feedback. I'll try to gather the thoughts of other maintainers to see if we can get to the bottom of this one.

MacLake

comment created time in 4 days

issue commentdjango-cms/django-cms

Garbled text shows up after saving plug-in instances on 3.5.3 and 3.6

HI @marksweb , no, we never resolved this, and this issue is still getting on our nerves, in the meantime with djangoCMS 3.8.0 and Django 3.1.10. Well, you can live with it, since it doesn’t affect the readers, only the editors, but it’s not nice, and also for the acceptance within our company it would be better that my colleagues don’t get the impression of a buggy CMS.

MacLake

comment created time in 4 days

pull request commentdjango-cms/django-cms

Issue 4646 refactor details view

@philippze since the coming release will likely be the last feature release on 3.x, and the merging window is closing this saturday, I am not sure if this would be a helpful merge addition to 3.x.

After this release, the focus will go on the 4.x serie. So if you want to help us, working on the 4.x code cleaning would be more useful :)

philippze

comment created time in 4 days

issue commentdjango-cms/django-cms

The slugs of child pages are built incorrectly and return a 404 error when a user adds a custom slug for another language of the parent page

@benzkji we aim to have this merged in 3.8.1 (which is likely going to be a 3.9.0).

Could you help us testing last develop branch?

victor-yunenko

comment created time in 4 days

pull request commentdjango-cms/django-cms

Issue 4646 refactor details view

Well it definitely is, here are some evidences:

  • @NicolaiRidani is doing a great job into steering a new association driving the project forward
  • working on next release 3.8.1 (hopefully in the next 2~3 weeks)
  • 4.x is also progressing

So… definitely alive :)

philippze

comment created time in 4 days