profile
viewpoint
Philippe Rivière Fil Visionscarto.net Le Gué du Loir https://visionscarto.net/ Vocateur

d3/d3-geo-projection 883

Extended geographic projections for d3-geo.

d3/d3-geo 687

Geographic projections, spherical shapes and spherical trigonometry.

d3/d3-geo-polygon 81

Clipping and geometric operations for spherical polygons.

d3/versor 22

a home for Mike Bostock's versor.js

Fil/attitude 21

Attitude: orientation of an object in space.

Cerdic/textwheel 7

proposal for an interoperability layer for text engines

Fil/archivage-militant 5

Archivage militant

archiloque/dredd 3

Let me judge your mails, tool to survey mailing lists health

Fil/batch-image-transform 3

batch apply an image filter

Fil/content-experiment.github.com 1

my fork of Paul Hammant's poetry git-book

startedgarrettj403/SciencePlots

started time in an hour

startedroyalosyin/SciencePlots

started time in 3 hours

pull request commentseenthis/seenthis_squelettes

dans les chaine de langue remplacement de "auteur" par "personne"

Ha tiens, comme le faisait justement remarquer valk ici https://seenthis.net/messages/896860#message897363 ça serait pas mal de remplacer ami(s) par contact(s), tu peux ajouter ça dans le paquet @cy-altern ?

bonne idée ! => c'est fait

cy-altern

comment created time in 3 hours

pull request commentseenthis/seenthis_squelettes

dans les chaine de langue remplacement de "auteur" par "personne"

Ha tiens, comme le faisait justement remarquer valk ici https://seenthis.net/messages/896860#message897363 ça serait pas mal de remplacer ami(s) par contact(s), tu peux ajouter ça dans le paquet @cy-altern ?

/me mode yeux de chat botté

cy-altern

comment created time in 4 hours

startedparallaxsecond/parsec

started time in 4 hours

startedpetar-dambovaliev/darpi

started time in 6 hours

issue openedd3/d3-scale-chromatic

Calculate color with two variables (t1, t2)?

We'd like to calculate the color value on a 2-dimensional matrix with 4 colors: farbverläufe

Is that possible with d3js-scale-chromatic? It appears all functions provide only one variable t.

Any ideas? :)

Thank you & Best regards, Johannes

created time in 7 hours

fork axel584/TranslationFiles

[READ-ONLY] This repo contains all the necessary files to generate translation packs for PrestaShop 1.6 and 1.7. It's updated automatically.

fork in 8 hours

issue closedd3/d3-geo

FitSize to fit an array of objects

Is it possible to have projection.fitSize fit an array of objects? I have a map of only a few countries, and would like the map to nicely position them.

something like:

const projection = geoEquirectangular().fitSize(
    [width, height],
    [object, object]
  );

I have tried this. Is there possibly another way to achieve this?

closed time in 10 hours

SirCameron

issue commentd3/d3-geo

FitSize to fit an array of objects

You can pass a geometry collection or feature collection to fiSize.

SirCameron

comment created time in 10 hours

issue commentd3/d3-geo

FitSize to fit an array of objects

I suppose you could compute the bounding box for the objects, then pass that into fitSize.

Turf has a utility for this https://turfjs.org/docs/#bbox

SirCameron

comment created time in 10 hours

issue commentd3/d3-color

More exports.

So named could be exported, maybe as namedColors or something https://github.com/d3/d3-color/blob/master/src/color.js#L19

nkint

comment created time in 10 hours

Pull request review commentd3/d3-sankey

Add support for additional Sankey diagram orientations

 If *iterations* is specified, sets the number of relaxation iterations when [gen  See [*sankey*.nodeAlign](#sankey_nodeAlign). -<a name="sankeyLeft" href="#sankeyLeft">#</a> d3.<b>sankeyLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignLeft" href="#sankeyAlignLeft">#</a> d3.<b>sankeyAlignLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="left" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-left.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=left)  Returns *node*.depth. -<a name="sankeyRight" href="#sankeyRight">#</a> d3.<b>sankeyRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignRight" href="#sankeyAlignRight">#</a> d3.<b>sankeyAlignRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="right" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-right.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=right)  Returns *n* - 1 - *node*.height. -<a name="sankeyCenter" href="#sankeyCenter">#</a> d3.<b>sankeyCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignCenter" href="#sankeyAlignCenter">#</a> d3.<b>sankeyAlignCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="center" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-center.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=center) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any incoming links are moved as right as possible.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any incoming links are moved as right as possible. -<a name="sankeyJustify" href="#sankeyJustify">#</a> d3.<b>sankeyJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignJustify" href="#sankeyAlignJustify">#</a> d3.<b>sankeyAlignJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="justify" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/energy.png" width="480">](https://observablehq.com/@d3/sankey-diagram) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any outgoing links are moved to the far right.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any outgoing links are moved to the far right.  ### Links -<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLinkHorizontal.js "Source")+<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLink.js "Source") -Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram. The [source accessor](https://github.com/d3/d3-shape/blob/master/README.md#link_source) is defined as:+Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram rendered in a horizontal orientation. -```js-function source(d) {

Thanks @curran - yep; I've considered publishing this as a forked package. It's hard to tell whether that approach would lead to longer-term value to users; there are certainly tradeoffs involved either way.

Regarding a d3-sankey-vertical submodule; that could make sense if there's potential for re-use of the code changes suggested here in other modules (as with d3-selection-multi, for example).

jayaddison

comment created time in 11 hours

issue openedd3/d3-geo

FitSize to fit an array of objects

Is it possible to have projection.fitSize fit an array of objects? I have a map of only a few countries, and would like the map to nicely position them.

something like:

const projection = geoEquirectangular().fitSize(
    [width, height],
    [object, object]
  );

I have tried this. Is there possibly another way to achieve this?

created time in 11 hours

Pull request review commentd3/d3-sankey

Add support for additional Sankey diagram orientations

 If *iterations* is specified, sets the number of relaxation iterations when [gen  See [*sankey*.nodeAlign](#sankey_nodeAlign). -<a name="sankeyLeft" href="#sankeyLeft">#</a> d3.<b>sankeyLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignLeft" href="#sankeyAlignLeft">#</a> d3.<b>sankeyAlignLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="left" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-left.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=left)  Returns *node*.depth. -<a name="sankeyRight" href="#sankeyRight">#</a> d3.<b>sankeyRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignRight" href="#sankeyAlignRight">#</a> d3.<b>sankeyAlignRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="right" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-right.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=right)  Returns *n* - 1 - *node*.height. -<a name="sankeyCenter" href="#sankeyCenter">#</a> d3.<b>sankeyCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignCenter" href="#sankeyAlignCenter">#</a> d3.<b>sankeyAlignCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="center" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-center.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=center) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any incoming links are moved as right as possible.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any incoming links are moved as right as possible. -<a name="sankeyJustify" href="#sankeyJustify">#</a> d3.<b>sankeyJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignJustify" href="#sankeyAlignJustify">#</a> d3.<b>sankeyAlignJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="justify" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/energy.png" width="480">](https://observablehq.com/@d3/sankey-diagram) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any outgoing links are moved to the far right.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any outgoing links are moved to the far right.  ### Links -<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLinkHorizontal.js "Source")+<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLink.js "Source") -Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram. The [source accessor](https://github.com/d3/d3-shape/blob/master/README.md#link_source) is defined as:+Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram rendered in a horizontal orientation. -```js-function source(d) {

The d3-sankey-vertical is what I was thinking. But the alternative of something like @jayaddison/d3-sankey could also work - a fork of the entire package. I'm just spitballing ways to maybe get this work to see the light of day, in the case it's never accepted into this particular repository. For me at least, having it usable via NPM would be great.

This PR reminds me of what happened with this other PR: https://github.com/d3/d3-array/pull/151

jayaddison

comment created time in 11 hours

Pull request review commentd3/d3-sankey

Add support for additional Sankey diagram orientations

 If *iterations* is specified, sets the number of relaxation iterations when [gen  See [*sankey*.nodeAlign](#sankey_nodeAlign). -<a name="sankeyLeft" href="#sankeyLeft">#</a> d3.<b>sankeyLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignLeft" href="#sankeyAlignLeft">#</a> d3.<b>sankeyAlignLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="left" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-left.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=left)  Returns *node*.depth. -<a name="sankeyRight" href="#sankeyRight">#</a> d3.<b>sankeyRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignRight" href="#sankeyAlignRight">#</a> d3.<b>sankeyAlignRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="right" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-right.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=right)  Returns *n* - 1 - *node*.height. -<a name="sankeyCenter" href="#sankeyCenter">#</a> d3.<b>sankeyCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignCenter" href="#sankeyAlignCenter">#</a> d3.<b>sankeyAlignCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="center" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-center.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=center) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any incoming links are moved as right as possible.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any incoming links are moved as right as possible. -<a name="sankeyJustify" href="#sankeyJustify">#</a> d3.<b>sankeyJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignJustify" href="#sankeyAlignJustify">#</a> d3.<b>sankeyAlignJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="justify" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/energy.png" width="480">](https://observablehq.com/@d3/sankey-diagram) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any outgoing links are moved to the far right.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any outgoing links are moved to the far right.  ### Links -<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLinkHorizontal.js "Source")+<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLink.js "Source") -Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram. The [source accessor](https://github.com/d3/d3-shape/blob/master/README.md#link_source) is defined as:+Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram rendered in a horizontal orientation. -```js-function source(d) {

@curran To make sure I answer correctly, are you asking about whether I've considered: 1) publishing this as a separate sub-module of d3-sankey -- d3-sankey-vertical, for example, or 2) publishing this as a d3-sankey module in a separate namespace/environment? (or some other interpretation?)

jayaddison

comment created time in 11 hours

Pull request review commentd3/d3-sankey

Add support for additional Sankey diagram orientations

 If *iterations* is specified, sets the number of relaxation iterations when [gen  See [*sankey*.nodeAlign](#sankey_nodeAlign). -<a name="sankeyLeft" href="#sankeyLeft">#</a> d3.<b>sankeyLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignLeft" href="#sankeyAlignLeft">#</a> d3.<b>sankeyAlignLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="left" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-left.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=left)  Returns *node*.depth. -<a name="sankeyRight" href="#sankeyRight">#</a> d3.<b>sankeyRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignRight" href="#sankeyAlignRight">#</a> d3.<b>sankeyAlignRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="right" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-right.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=right)  Returns *n* - 1 - *node*.height. -<a name="sankeyCenter" href="#sankeyCenter">#</a> d3.<b>sankeyCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignCenter" href="#sankeyAlignCenter">#</a> d3.<b>sankeyAlignCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="center" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-center.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=center) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any incoming links are moved as right as possible.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any incoming links are moved as right as possible. -<a name="sankeyJustify" href="#sankeyJustify">#</a> d3.<b>sankeyJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignJustify" href="#sankeyAlignJustify">#</a> d3.<b>sankeyAlignJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="justify" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/energy.png" width="480">](https://observablehq.com/@d3/sankey-diagram) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any outgoing links are moved to the far right.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any outgoing links are moved to the far right.  ### Links -<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLinkHorizontal.js "Source")+<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLink.js "Source") -Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram. The [source accessor](https://github.com/d3/d3-shape/blob/master/README.md#link_source) is defined as:+Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram rendered in a horizontal orientation. -```js-function source(d) {

@jayaddison Have you considered an implementation that could be published as a separate standalone package, not tightly coupled to this Sankey module? That could be another potential direction.

jayaddison

comment created time in 11 hours

issue commentd3/d3-color

More exports.

Which variables in particular do you propose to export?

nkint

comment created time in 12 hours

issue openedd3/d3-color

More exports.

Hi! I love this library, thanks 🎨 🌈.

I'd like to use some internal things in this library like css color names or color format validation regex.

Can something more be exported from d3-color?

Is only a matter of add some export and I would love to provide a PR, if it has any interested. IMHO it can be a huge added value.

created time in 12 hours

Pull request review commentd3/d3-sankey

Add support for additional Sankey diagram orientations

 If *iterations* is specified, sets the number of relaxation iterations when [gen  See [*sankey*.nodeAlign](#sankey_nodeAlign). -<a name="sankeyLeft" href="#sankeyLeft">#</a> d3.<b>sankeyLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignLeft" href="#sankeyAlignLeft">#</a> d3.<b>sankeyAlignLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="left" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-left.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=left)  Returns *node*.depth. -<a name="sankeyRight" href="#sankeyRight">#</a> d3.<b>sankeyRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignRight" href="#sankeyAlignRight">#</a> d3.<b>sankeyAlignRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="right" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-right.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=right)  Returns *n* - 1 - *node*.height. -<a name="sankeyCenter" href="#sankeyCenter">#</a> d3.<b>sankeyCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignCenter" href="#sankeyAlignCenter">#</a> d3.<b>sankeyAlignCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="center" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-center.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=center) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any incoming links are moved as right as possible.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any incoming links are moved as right as possible. -<a name="sankeyJustify" href="#sankeyJustify">#</a> d3.<b>sankeyJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignJustify" href="#sankeyAlignJustify">#</a> d3.<b>sankeyAlignJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="justify" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/energy.png" width="480">](https://observablehq.com/@d3/sankey-diagram) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any outgoing links are moved to the far right.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any outgoing links are moved to the far right.  ### Links -<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLinkHorizontal.js "Source")+<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLink.js "Source") -Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram. The [source accessor](https://github.com/d3/d3-shape/blob/master/README.md#link_source) is defined as:+Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram rendered in a horizontal orientation. -```js-function source(d) {

Agree.

As this PR has been open for a year now, and is pretty much sound and all feedback has been addressed as far as I can tell, it feels ready for merge to me.

Any thoughts on how we might approach getting this merged @mbostock @Fil ?

jayaddison

comment created time in 13 hours

Pull request review commentd3/d3-sankey

Add support for additional Sankey diagram orientations

 If *iterations* is specified, sets the number of relaxation iterations when [gen  See [*sankey*.nodeAlign](#sankey_nodeAlign). -<a name="sankeyLeft" href="#sankeyLeft">#</a> d3.<b>sankeyLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignLeft" href="#sankeyAlignLeft">#</a> d3.<b>sankeyAlignLeft</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="left" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-left.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=left)  Returns *node*.depth. -<a name="sankeyRight" href="#sankeyRight">#</a> d3.<b>sankeyRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignRight" href="#sankeyAlignRight">#</a> d3.<b>sankeyAlignRight</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="right" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-right.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=right)  Returns *n* - 1 - *node*.height. -<a name="sankeyCenter" href="#sankeyCenter">#</a> d3.<b>sankeyCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignCenter" href="#sankeyAlignCenter">#</a> d3.<b>sankeyAlignCenter</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="center" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/align-center.png" width="480">](https://observablehq.com/@d3/sankey-diagram?align=center) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any incoming links are moved as right as possible.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any incoming links are moved as right as possible. -<a name="sankeyJustify" href="#sankeyJustify">#</a> d3.<b>sankeyJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankey/blob/master/src/align.js "Source")+<a name="sankeyAlignJustify" href="#sankeyAlignJustify">#</a> d3.<b>sankeyAlignJustify</b>(<i>node</i>, <i>n</i>) [<>](https://github.com/d3/d3-sankeyAlign/blob/master/src/align.js "Source")  [<img alt="justify" src="https://raw.githubusercontent.com/d3/d3-sankey/master/img/energy.png" width="480">](https://observablehq.com/@d3/sankey-diagram) -Like [d3.sankeyLeft](#sankeyLeft), except that nodes without any outgoing links are moved to the far right.+Like [d3.sankeyAlignLeft](#sankeyAlignLeft), except that nodes without any outgoing links are moved to the far right.  ### Links -<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLinkHorizontal.js "Source")+<a name="sankeyLinkHorizontal" href="#sankeyLinkHorizontal">#</a> d3.<b>sankeyLinkHorizontal</b>() [<>](https://github.com/d3/d3-sankey/blob/master/src/sankeyLink.js "Source") -Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram. The [source accessor](https://github.com/d3/d3-shape/blob/master/README.md#link_source) is defined as:+Returns a [horizontal link shape](https://github.com/d3/d3-shape/blob/master/README.md#linkHorizontal) suitable for a Sankey diagram rendered in a horizontal orientation. -```js-function source(d) {

On the whole I think it's preferable to include (ideally, versioned) links to source code from documentation rather than duplicate the source itself.

It can be challenging to use versioned links because it can often require a commit of the code to be followed by a commit of the documentation. There could be a way to use relative hyperlinks to ensure that the documentation for a versioned codebase always links to the corresponding version of the source code.

Smart user agents could also preview or open the source code in a manner that doesn't necessarily require the user to click through in order to inspect some of the details.

I'm aware that some of the links in this pull request don't use versioned source code references; that's not ideal, but I think consistency is a good initial goal, as long as continuous improvement (towards things like corresponding-versioned documentation links) is always taking place as well.

jayaddison

comment created time in 13 hours

created repositorydcoeurjo/displayPts

created time in 13 hours

fork dcoeurjo/neptune-examples

Examples of using Neptune to keep track of your experiments.

https://neptune.ai

fork in 13 hours

starteddanielstjules/jsinspect

started time in 15 hours

fork micahstubbs/polis

:milky_way: Open Source AI for large scale open ended feedback

fork in 15 hours

startedseemoo-lab/openwifipass

started time in 20 hours

created repositoryjkunimune15/blog

a place to put all of the textual trash I generate

created time in 21 hours

startedm8r0wn/nullinux

started time in a day

startedm8r0wn/pymeta

started time in a day

startedm8r0wn/enumdb

started time in a day

more