profile
viewpoint
Alicia Drummond FalseLobster Microsoft Working on UX

microsoft/fluentui 9851

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.

stardust-ui/react-old 27

MOVED TO: http://github.com/stardust-ui/react

FalseLobster/ConcaveHullGenerator 0

Concave hull for C# (Comes with a Unity demo)

FalseLobster/fluentui-react-native 0

A react-native control library aligned with office-ui-fabric-react

FalseLobster/github-actions-issue-to-work-item 0

GitHub Action that creates a Azure DevOps work item when an Issue is created

FalseLobster/office-ui-fabric-react 0

React components for building experiences for Office and Office 365.

FalseLobster/react-native-windows 0

A framework for building native Windows apps with React.

FalseLobster/yaml-cpp 0

A YAML parser and emitter in C++

pull request commentmicrosoft/fluentui

DO NOT MERGE - Virtualized Tree with Sticky header Prototype

<!-- 0 failure: 1 warning: There are no upda...

DangerID: danger-id-default; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.</td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 5a137b02e7e93f4aedda5a51f7955f21b1692da6 </p>

YuanboXue-Amber

comment created time in 18 minutes

pull request commentmicrosoft/fluentui

feat(Tree): useVirtualTree hook + rewrite virtualizedTreePrototype using hook and react-window

Perf Analysis

<p>No significant results to display.</p><details><summary>All results</summary><p> <table> <tr> <th>Scenario</th> <th>Render type</th> <th> <a href="https://github.com/microsoft/fluentui/wiki/Perf-Testing#why-are-results-listed-in-ticks-instead-of-time-units">Master Ticks</a> </th> <th> <a href="https://github.com/microsoft/fluentui/wiki/Perf-Testing#why-are-results-listed-in-ticks-instead-of-time-units">PR Ticks</a> </th> <th>Iterations</th> <th>Status</th> </tr><tr> <td>Avatar</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Avatar-mount_base.html">828</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Avatar-mount.html">846</a></td> <td>5000</td> <td></td> </tr> <tr> <td>BaseButtonCompat</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/BaseButtonCompat-mount_base.html">939</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/BaseButtonCompat-mount.html">961</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Breadcrumb</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Breadcrumb-mount_base.html">40045</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Breadcrumb-mount.html">41343</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Checkbox</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Checkbox-mount_base.html">1575</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Checkbox-mount.html">1499</a></td> <td>5000</td> <td></td> </tr> <tr> <td>CheckboxBase</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/CheckboxBase-mount_base.html">1284</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/CheckboxBase-mount.html">1297</a></td> <td>5000</td> <td></td> </tr> <tr> <td>ChoiceGroup</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ChoiceGroup-mount_base.html">4748</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ChoiceGroup-mount.html">4849</a></td> <td>5000</td> <td></td> </tr> <tr> <td>ComboBox</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ComboBox-mount_base.html">959</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ComboBox-mount.html">956</a></td> <td>1000</td> <td></td> </tr> <tr> <td>CommandBar</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/CommandBar-mount_base.html">9658</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/CommandBar-mount.html">9735</a></td> <td>1000</td> <td></td> </tr> <tr> <td>ContextualMenu</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ContextualMenu-mount_base.html">6011</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ContextualMenu-mount.html">5907</a></td> <td>1000</td> <td></td> </tr> <tr> <td>DefaultButtonCompat</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DefaultButtonCompat-mount_base.html">1141</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DefaultButtonCompat-mount.html">1146</a></td> <td>5000</td> <td></td> </tr> <tr> <td>DetailsRow</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DetailsRow-mount_base.html">3701</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DetailsRow-mount.html">3673</a></td> <td>5000</td> <td></td> </tr> <tr> <td>DetailsRowFast</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DetailsRowFast-mount_base.html">3628</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DetailsRowFast-mount.html">3704</a></td> <td>5000</td> <td></td> </tr> <tr> <td>DetailsRowNoStyles</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DetailsRowNoStyles-mount_base.html">3463</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DetailsRowNoStyles-mount.html">3585</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Dialog</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Dialog-mount_base.html">1435</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Dialog-mount.html">1458</a></td> <td>1000</td> <td></td> </tr> <tr> <td>DocumentCardTitle</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DocumentCardTitle-mount_base.html">1734</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/DocumentCardTitle-mount.html">1714</a></td> <td>1000</td> <td></td> </tr> <tr> <td>Dropdown</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Dropdown-mount_base.html">3344</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Dropdown-mount.html">3337</a></td> <td>5000</td> <td></td> </tr> <tr> <td>FocusTrapZone</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/FocusTrapZone-mount_base.html">1824</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/FocusTrapZone-mount.html">1750</a></td> <td>5000</td> <td></td> </tr> <tr> <td>FocusZone</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/FocusZone-mount_base.html">1790</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/FocusZone-mount.html">1811</a></td> <td>5000</td> <td></td> </tr> <tr> <td>IconButtonCompat</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/IconButtonCompat-mount_base.html">1797</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/IconButtonCompat-mount.html">1810</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Label</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Label-mount_base.html">331</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Label-mount.html">338</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Layer</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Layer-mount_base.html">1781</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Layer-mount.html">1785</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Link</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Link-mount_base.html">464</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Link-mount.html">474</a></td> <td>5000</td> <td></td> </tr> <tr> <td>MenuButtonCompat</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/MenuButtonCompat-mount_base.html">1470</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/MenuButtonCompat-mount.html">1529</a></td> <td>5000</td> <td></td> </tr> <tr> <td>MessageBar</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/MessageBar-mount_base.html">1931</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/MessageBar-mount.html">1992</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Nav</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Nav-mount_base.html">3291</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Nav-mount.html">3246</a></td> <td>1000</td> <td></td> </tr> <tr> <td>OverflowSet</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/OverflowSet-mount_base.html">994</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/OverflowSet-mount.html">1020</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Panel</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Panel-mount_base.html">1388</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Panel-mount.html">1408</a></td> <td>1000</td> <td></td> </tr> <tr> <td>Persona</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Persona-mount_base.html">851</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Persona-mount.html">849</a></td> <td>1000</td> <td></td> </tr> <tr> <td>Pivot</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Pivot-mount_base.html">1365</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Pivot-mount.html">1397</a></td> <td>1000</td> <td></td> </tr> <tr> <td>PrimaryButtonCompat</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/PrimaryButtonCompat-mount_base.html">1268</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/PrimaryButtonCompat-mount.html">1294</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Rating</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Rating-mount_base.html">7628</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Rating-mount.html">7591</a></td> <td>5000</td> <td></td> </tr> <tr> <td>SearchBox</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SearchBox-mount_base.html">1371</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SearchBox-mount.html">1364</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Shimmer</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Shimmer-mount_base.html">2553</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Shimmer-mount.html">2588</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Slider</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Slider-mount_base.html">1947</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Slider-mount.html">1935</a></td> <td>5000</td> <td></td> </tr> <tr> <td>SpinButton</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SpinButton-mount_base.html">4999</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SpinButton-mount.html">5014</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Spinner</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Spinner-mount_base.html">409</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Spinner-mount.html">405</a></td> <td>5000</td> <td></td> </tr> <tr> <td>SplitButtonCompat</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SplitButtonCompat-mount_base.html">3169</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SplitButtonCompat-mount.html">3174</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Stack</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Stack-mount_base.html">502</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Stack-mount.html">505</a></td> <td>5000</td> <td></td> </tr> <tr> <td>StackWithIntrinsicChildren</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/StackWithIntrinsicChildren-mount_base.html">1487</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/StackWithIntrinsicChildren-mount.html">1524</a></td> <td>5000</td> <td></td> </tr> <tr> <td>StackWithTextChildren</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/StackWithTextChildren-mount_base.html">4578</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/StackWithTextChildren-mount.html">4651</a></td> <td>5000</td> <td></td> </tr> <tr> <td>SwatchColorPicker</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SwatchColorPicker-mount_base.html">10088</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/SwatchColorPicker-mount.html">10117</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Tabs</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Tabs-mount_base.html">1375</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Tabs-mount.html">1388</a></td> <td>1000</td> <td></td> </tr> <tr> <td>TagPicker</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/TagPicker-mount_base.html">2743</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/TagPicker-mount.html">2837</a></td> <td>5000</td> <td></td> </tr> <tr> <td>TeachingBubble</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/TeachingBubble-mount_base.html">11242</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/TeachingBubble-mount.html">11220</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Text</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Text-mount_base.html">417</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Text-mount.html">430</a></td> <td>5000</td> <td></td> </tr> <tr> <td>TextField</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/TextField-mount_base.html">1381</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/TextField-mount.html">1413</a></td> <td>5000</td> <td></td> </tr> <tr> <td>ThemeProvider</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ThemeProvider-mount_base.html">2090</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ThemeProvider-mount.html">2043</a></td> <td>5000</td> <td></td> </tr> <tr> <td>ThemeProvider</td> <td>virtual-rerender</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ThemeProvider-virtual-rerender_base.html">616</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/ThemeProvider-virtual-rerender.html">635</a></td> <td>5000</td> <td></td> </tr> <tr> <td>Toggle</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Toggle-mount_base.html">785</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/Toggle-mount.html">807</a></td> <td>5000</td> <td></td> </tr> <tr> <td>button</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/button-mount_base.html">679</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/button-mount.html">683</a></td> <td>5000</td> <td></td> </tr> <tr> <td>buttonNative</td> <td>mount</td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/buttonNative-mount_base.html">101</a></td> <td><a href="http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/16080/merge/perf-test/buttonNative-mount.html">111</a></td> <td>5000</td> <td></td> </tr></table></p></details>

Perf Analysis (Fluent)

<details><summary>Perf comparison</summary>

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.49 0.52 0.94:1 2000 982
🦄 Button.Fluent 0.13 0.24 0.54:1 5000 649
🔧 Checkbox.Fluent 0.66 0.37 1.78:1 1000 664
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 850
🔧 Dropdown.Fluent 3.01 0.44 6.84:1 1000 3008
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 799
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 427
🔧 Slider.Fluent 1.64 0.47 3.49:1 1000 1641
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 410
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 586

🔧 Needs work     🎯 On target     🦄 Amazing

</details> <details><summary>Perf tests with no regressions</summary>

Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 198 174 1.14:1
PortalMinimalPerf.default 176 162 1.09:1
RefMinimalPerf.default 255 234 1.09:1
MenuButtonMinimalPerf.default 1812 1674 1.08:1
DatepickerMinimalPerf.default 54278 50596 1.07:1
LabelMinimalPerf.default 526 492 1.07:1
EmbedMinimalPerf.default 4454 4220 1.06:1
FormMinimalPerf.default 514 483 1.06:1
SkeletonMinimalPerf.default 501 471 1.06:1
TreeWith60ListItems.default 233 219 1.06:1
Button.Fluent 649 611 1.06:1
AccordionMinimalPerf.default 181 173 1.05:1
ChatDuplicateMessagesPerf.default 463 441 1.05:1
HeaderMinimalPerf.default 430 411 1.05:1
LayoutMinimalPerf.default 482 461 1.05:1
LoaderMinimalPerf.default 853 809 1.05:1
CardMinimalPerf.default 677 648 1.04:1
PopupMinimalPerf.default 756 724 1.04:1
TooltipMinimalPerf.default 912 875 1.04:1
VideoMinimalPerf.default 717 692 1.04:1
Checkbox.Fluent 664 641 1.04:1
ButtonMinimalPerf.default 199 193 1.03:1
CarouselMinimalPerf.default 516 503 1.03:1
ChatWithPopoverPerf.default 539 522 1.03:1
DropdownMinimalPerf.default 3475 3372 1.03:1
ListCommonPerf.default 794 770 1.03:1
Avatar.Fluent 982 957 1.03:1
Slider.Fluent 1641 1588 1.03:1
BoxMinimalPerf.default 411 403 1.02:1
GridMinimalPerf.default 399 391 1.02:1
HeaderSlotsPerf.default 896 878 1.02:1
InputMinimalPerf.default 1412 1391 1.02:1
MenuMinimalPerf.default 1041 1024 1.02:1
SplitButtonMinimalPerf.default 4068 4002 1.02:1
IconMinimalPerf.default 743 731 1.02:1
Dropdown.Fluent 3008 2961 1.02:1
AttachmentSlotsPerf.default 1225 1214 1.01:1
DividerMinimalPerf.default 464 458 1.01:1
ListNestedPerf.default 682 677 1.01:1
ListWith60ListItems.default 1130 1117 1.01:1
ReactionMinimalPerf.default 454 450 1.01:1
SegmentMinimalPerf.default 412 408 1.01:1
SliderMinimalPerf.default 1584 1576 1.01:1
TableManyItemsPerf.default 2428 2395 1.01:1
TableMinimalPerf.default 475 468 1.01:1
TextAreaMinimalPerf.default 564 556 1.01:1
CustomToolbarPrototype.default 3898 3853 1.01:1
ToolbarMinimalPerf.default 1027 1013 1.01:1
Dialog.Fluent 850 841 1.01:1
Icon.Fluent 799 790 1.01:1
Image.Fluent 427 422 1.01:1
Tooltip.Fluent 586 583 1.01:1
AlertMinimalPerf.default 332 333 1:1
AnimationMinimalPerf.default 428 427 1:1
ButtonOverridesMissPerf.default 1733 1732 1:1
ButtonUseCssPerf.default 918 914 1:1
ButtonUseCssNestingPerf.default 1205 1206 1:1
CheckboxMinimalPerf.default 3208 3202 1:1
FlexMinimalPerf.default 336 336 1:1
ListMinimalPerf.default 586 588 1:1
TreeMinimalPerf.default 851 850 1:1
Text.Fluent 410 411 1:1
AvatarMinimalPerf.default 530 534 0.99:1
ButtonSlotsPerf.default 674 679 0.99:1
RadioGroupMinimalPerf.default 492 496 0.99:1
ChatMinimalPerf.default 719 730 0.98:1
DialogMinimalPerf.default 908 926 0.98:1
ImageMinimalPerf.default 447 458 0.98:1
ItemLayoutMinimalPerf.default 1464 1497 0.98:1
ProviderMinimalPerf.default 1020 1044 0.98:1
StatusMinimalPerf.default 803 816 0.98:1
TextMinimalPerf.default 393 403 0.98:1
ProviderMergeThemesPerf.default 2013 2068 0.97:1
DropdownManyItemsPerf.default 884 923 0.96:1

</details><div id="perfComment9423"/>

YuanboXue-Amber

comment created time in an hour

pull request commentmicrosoft/fluentui

feat(Tree): useVirtualTree hook + rewrite virtualizedTreePrototype using hook and react-window

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1925a8c0493ca19b1d756f75755e61d43f77913d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration
YuanboXue-Amber

comment created time in an hour

pull request commentmicrosoft/fluentui

feat(Tree): useVirtualTree hook + rewrite virtualizedTreePrototype using hook and react-window

<!-- 0 failure: 1 warning: There are no upda...

DangerID: danger-id-default; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.</td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 1925a8c0493ca19b1d756f75755e61d43f77913d </p>

YuanboXue-Amber

comment created time in an hour

PR opened microsoft/fluentui

feat(Tree): useVirtualTree hook

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • [ ] Include a change request file using $ yarn change

Description of changes

  • create useVirtualTree hook
  • update existing virtualizedTree prototype with useVirtualTree hook and react-window

Focus areas to test

(optional)

+396 -98

0 comment

8 changed files

pr created time in an hour

push eventmicrosoft/fluentui

Amber

commit sha 16c858186809363a9e58a11e217353010116dd37

refactor(Tree): BREAKING CHANGE - rework tree as hook (#15831) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes ## Description of the re-work ideas: The key is to create a **flattened tree** (see `flattenTree.ts`). The flattened tree is an object, with key being the id of each tree item, and value being the information of the corresponding tree item: its parent/child, was it selected, ..., etc. Initially the flattened tree is created thru Tree's `props.items`. Then it gets re-created every time when state changes. Meaning every time users select/unselect, expand/collapse a tree node, there will be O(n) time spent on re-creating flattened tree, where n being number of tree items. Why flatten tree: - provides a convenient way of navigating up/down tree. - being the single source of truth for the state (expanded/collapsed, selected) of the tree - together with `getItemById`, provides a context for tree items to access tree information. The flattened tree is then used in `useTree` hook. This hook is a building block for `Tree` component, and a `useVirtualTree` hook (not in this PR yet) for virtualized tree component. ## Breaking changes: - The following props are removed from `TreeItem`: ```ts /** A state of selection indicator. */ selected?: boolean; /** Whether or not tree item is part of the selectable parent. */ selectableParent?: boolean; indeterminate?: boolean; ``` Reason for removal: 1. These props are not in 0.47 version. 2. `selected` and `indeterminate` can be accessed from the flattened tree. (In fact, if possible, I'd like to remove all props that can be accessed from the flattened tree, for example `parent`, `index`, ..., .etc). `selectableParent` is useless in my opinion. - Tree does not create and pass `contentRef` prop to each TreeItem anymore. Originally Tree creates and keeps a map of refs to each tree items, and assigned it to tree item's `contentRef` prop. The new re-worked tree does not do this anymore. But `contentRef` is still kept as a prop for TreeItem. #### Focus areas to test (optional)

view details

push time in 2 hours

PR merged microsoft/fluentui

Reviewers
refactor(Tree): BREAKING CHANGE - rework tree as hook AutoMerge Fluent UI react-northstar

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • [ ] Include a change request file using $ yarn change

Description of changes

Description of the re-work ideas:

The key is to create a flattened tree (see flattenTree.ts). The flattened tree is an object, with key being the id of each tree item, and value being the information of the corresponding tree item: its parent/child, was it selected, ..., etc.

Initially the flattened tree is created thru Tree's props.items. Then it gets re-created every time when state changes. Meaning every time users select/unselect, expand/collapse a tree node, there will be O(n) time spent on re-creating flattened tree, where n being number of tree items.

Why flatten tree:

  • provides a convenient way of navigating up/down tree.
  • being the single source of truth for the state (expanded/collapsed, selected) of the tree
  • together with getItemById, provides a context for tree items to access tree information.

The flattened tree is then used in useTree hook. This hook is a building block for Tree component, and a useVirtualTree hook (not in this PR yet) for virtualized tree component.

Breaking changes:

  • The following props are removed from TreeItem:

      /** A state of selection indicator. */
      selected?: boolean;
    
      /** Whether or not tree item is part of the selectable parent. */
      selectableParent?: boolean;
    
      indeterminate?: boolean;
    

    Reason for removal:

    1. These props are not in 0.47 version.
    2. selected and indeterminate can be accessed from the flattened tree. (In fact, if possible, I'd like to remove all props that can be accessed from the flattened tree, for example parent, index, ..., .etc). selectableParent is useless in my opinion.
  • Tree does not create and pass contentRef prop to each TreeItem anymore. Originally Tree creates and keeps a map of refs to each tree items, and assigned it to tree item's contentRef prop. The new re-worked tree does not do this anymore. But contentRef is still kept as a prop for TreeItem.

Focus areas to test

(optional)

+563 -483

5 comments

10 changed files

YuanboXue-Amber

pr closed time in 2 hours

pull request commentmicrosoft/fluentui

refactor(Tree): BREAKING CHANGE - rework tree as hook

<!--[AutoMerge]--> Hello @YuanboXue-Amber!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.
YuanboXue-Amber

comment created time in 2 hours

issue closedmicrosoft/react-native-windows

Split UIManager into a separate VS project

The UIManager module is currently built along with the rest of RNWCPP. This task is tracking separating this module into a separate project so we can build other solutions that just bring this component in.

closed time in 3 hours

harinikmsft

issue closedmicrosoft/react-native-windows

Bundled images assets in appxs aren't found

Right now, we hardcode ReactUWP to expect packaged bundles to be in ms-appx://Bundle/{filename}.bundle

The developer passes in {filename}.

So if you run react-native bundle --platform uwp--entry-file index.js --bundle-output Bundle\index.uwp.bundle --assets-dest Bundle to get:

Bundle\
- index.uwp.bundle
  assets\
    - asset1.png
    - asset2.png

However, when loading images, we translate the path file://assets/asset1.png to ms-appx:///assets/asset1.png

closed time in 3 hours

jonthysell

issue closedmicrosoft/react-native-windows

RNW CLI assumes App.windows.js entry point, ignoring existing code

Environment

  1. react-native -v:
react-native-cli: 2.0.1
react-native: 0.59.8
  1. npm ls rnpm-plugin-windows:
`-- rnpm-plugin-windows@0.2.11
  1. npm ls react-native-windows:
`-- react-native-windows@0.59.0-vnext.95
  1. node -v:
v10.15.3
  1. npm -v:
6.10.1

Then, specify:

  • Target Platform Version(s): 10.0.18362

  • Target Device(s): Desktop

  • Visual Studio Version: 2017

  • Build Configuration: Debug

Steps to Reproduce

I reprored with when using the expo-cli but it should be a problem with any existing app. I want add a RNW vnext target using rnpm-plugin-windows.

  1. expo eject
  2. Select "plain" RN project
  3. As per #2808 , I add the missing "name" entry
  4. react-native windows --template vnext
  5. react-native run-windows

Expected Behavior

The new project builds and launches my existing app. It should be smart enough to identify (and refer) any existing entry point:

  • The "main" key in package.json
  • The "entryPoint" key in app.json

Actual Behavior

The generated project both creates an App.windows.js and hardcodes the entry-point to it in the native code.

closed time in 3 hours

jonthysell

issue closedmicrosoft/react-native-windows

Playground app crashes on re-load

  • Native Animation example
  • click on any animation and quickly click the Load button to reload we crash because:
  • we destroy the native module list
  • but then callbacks from javascript come in and are processed. these callbacks have one of their arguments bound to a native module that got destroyed. Arguably at the point where the callbacks bind the module, they should be using a smart pointer to make sure that either the module stays in memory or better yet when it goes away, we know and don't do anything when the callback is triggered.

closed time in 3 hours

asklar

issue closedmicrosoft/react-native-windows

How to handle bundled assets

In the bundle command, there is –bundle-output and also –asserts-dest parameters. Even if I redirect –asserts-dest to Asserts folder, it may still has problem to access the resource. Because the link is file://assets/abc in the bundled file, and the app expect it to be msappx://Assets/abc.

Andrew suggested It's possible to fork the logic in AssetSourceResolver to have it generate the right urls.

I also found an internal commit on this topic: https://github.com/Microsoft/react-native-windows/commit/2812a4506322917709fc6f27ac82f053c2414c4b

closed time in 3 hours

licanhua

issue closedmicrosoft/react-native-windows

Work out how to use XAML codegen in MS.RN

Currently there are a couple of places where we are using XAML markup in MS.RN. In particular the devmenu and redbox. In both these cases we are using markup in a string and calling XamlReader::Load. It would be great if we could use a more normal XAML dev experience with markup, x:Bind etc. However, the normal winrt dev experience requires the XAML file have an idl file, which would add the control to the public interface of the dll. We dont want to add these to the public interface.

closed time in 3 hours

acoates-ms

issue closedmicrosoft/react-native-windows

Re-write Effects.idl using modern IDL

@marlenecota You don't have to do it in this PR, but it looks like Effects.idl is the last file to still use the old IDL style (with HRESULTS, property get / set methods, etc.) which is a pain to parse. Please open an issue to track re-writing the file with modern idl (which of course will mean some changes to the code-behind).

Originally posted by @jonthysell in https://github.com/microsoft/react-native-windows/pull/5521#issuecomment-658964307

closed time in 3 hours

marlenecota

issue closedmicrosoft/react-native-windows

metro complains about missing msedge but msedge is there

image

Edge launches after dismissing the error message

closed time in 3 hours

asklar

pull request commentmicrosoft/react-native-windows

Adding support for politeFocus

@samuelfreiberg looks like a bad merge (1077 changed files / 284 commits) - can you please rebase/resolve?

samuelfreiberg

comment created time in 4 hours

issue openedmicrosoft/fluentui

Focus boundary rectangle on dropdown menu items not visible from side

<!-- Before submitting an accessibility issue please ensure the following are true:

  1. Search for dupes! Please make sure the issue is not already present in our issue tracker.
  2. This issue is caused by a Fluent UI React control.
  3. You can reproduce this bug in a CodePen.
  4. There is documentation or best practice that supports your expected behavior (review https://www.w3.org/TR/wai-aria-1.1/ for accessibility guidance.)

PLEASE NOTE:

Do not link to, screenshot or reference a Microsoft product in this description.

Our screen reader support is limited to Edge + Narrator. Please check ARIA component examples to ensure it is not a screen reader or browser issue. Issues that do not reproduce in Edge + Narrator, and aren't caused by obvious invalid aria values, should be filed with the respective screen reading software, not the Fluent UI repo.

Issues that do not meet these guidelines will be closed. -->

Environment Information

  • Package version(s): "office-ui-fabric-react": "7.148.0"
  • Browser and OS versions: Chrome - 87.0.4280.66, Win 10 Enterprise

Describe the issue:

On trying to navigate a multi-select dropdown through keyboard, the focus boundary rectangle on the menu items has missing sides.

Please provide a reproduction of the issue in a codepen:

https://codepen.io/pen/?&prefill_data_id=efbb0b29-92da-4ae0-bd92-6d8c0409229b Same codepen as in official fabric website, can repro there as well.

<!-- Providing an isolated reproduction of the issue in a codepen makes it much easier for us to help you. Here are some ways to get started:

  • Go to https://aka.ms/fluentpen for a starter codepen
  • You can also use the "Export to Codepen" feature for the various components in our documentation site.
  • See http://codepen.io/dzearing/pens/public/?grid_type=list for a variety of examples

Alternatively, you can also use https://aka.ms/fluentdemo to get permanent repro links if the repro occurs with an example. (A permanent link is preferable to "use the website" as the website can change.) -->

Actual behavior:

Focus boundary rectangle has missing sides

Expected behavior:

Focus boundary rectangle should be visible clearly

Documentation describing expected behavior

<!-- fill this out -->

created time in 4 hours

issue commentOfficeDev/office-js

window.open from Windows Outlook using WebView1 returns null window

Further odd behaviour is that after the window is opened if I then try to use the displayDialogAsync method of office-js back on the caller I'm seeing an odd (looks like an overflow error code) Internal Error returned in the displayDialogAsync result.

{
"status":"failed",
"error":{
  "name":"Internal Error",
  "message":"An internal error has occurred.",
  "code": -2147467259
}
}
westconference

comment created time in 4 hours

issue commentmicrosoft/fluentui

LineChart tickValues not working

@luckyrass ,

Issue fixed and version released @fluentui/react-charting@v5.0.0-beta.18. Can you please confirm and close work item?

luckyrass

comment created time in 4 hours

push eventmicrosoft/VerifiableCredential-SDK-Android

beejones

commit sha 52f56536b17eec1caddde06998b741a48527ff9b

Test performance of sign/verify primitives - reference data EllipticCurveSubtleCryptoPerformanceTest TokenSignerPerformanceTest 0 End sign 16182 End verify 89218 End sign 699976 1 End sign 2824 End verify 13399 End sign 594409 2 End sign 3182 End verify 11185 End sign 598249 3 End sign 3827 End verify 12607 End sign 579835 4 End sign 2387 End verify 7474 End sign 525478 5 End sign 2908 End verify 9780 End sign 579169 6 End sign 2721 End verify 7205 End sign 547622 7 End sign 2204 End verify 6016 End sign 531888 8 End sign 1833 End verify 6166 End sign 537859 9 End sign 991 End verify 5266 End sign 568293

view details

push time in 5 hours

issue commentOfficeDev/office-js

Several properties are missing from window.Office.context.mailbox on "New Outlook" for Mac

Apologies. It is mistake from our side to notify. Fix is rolling out slowly. We will update you once fix is available to all users world-wide. Thanks for your patience.

modestfake

comment created time in 7 hours

issue commentOfficeDev/office-js

Not able to detect the difference between the deleted content control and remaining normal content control having text when the Track changes are ON using OfficeJS API in Word add-in.

Thanks for the reply @MandytMSFT .

I already raise feature request on UserVoice page. Below is the UserVoice link for this issue: https://officespdev.uservoice.com/forums/224641-feature-requests-and-feedback/suggestions/42053035-not-able-to-detect-the-difference-between-the-dele

c-suraj

comment created time in 7 hours

issue commentOfficeDev/office-js

Outlook Online Reporting Incorrect Dialog API Support

Thanks for confirming.

jak-hammond

comment created time in 7 hours

issue commentOfficeDev/office-js

Office.context.ui.addHandlerAsync is not a function

Apologies. It is a mistake from our end. Fix is not yet available fully world-wide. We will update you once fix is available in December sometime. Thanks for your patience.

jak-hammond

comment created time in 7 hours

issue commentOfficeDev/office-js

Not able to detect the difference between the deleted content control and remaining normal content control having text when the Track changes are ON using OfficeJS API in Word add-in.

@c-suraj thanks for reaching us. Unfortunately, currently we have no way to detect this. We track Office Add-in feature requests on our UserVoice page Please add your request there. Feature requests on user-voice are considered when we go through our planning process.

c-suraj

comment created time in 7 hours

issue commentmicrosoft/fluentui

Dropdown option does not show ellipsis in option

Hello @xugao , I am also not able to view the ellipsis. When I added the following CSS (shown in the image) in the class="ms-Button-flexContainer flexContainer-323" in the browser's Inspect Element for the option which was having longer text, it came. Can you help in which element we need to add the CSS to make the ellipsis work? image

shrallap

comment created time in 8 hours

pull request commentmicrosoft/fluentui

Fix ComboBox onBlur when relatedTarget is an ancestor to menu

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ComboBox 233.51 kB 233.623 kB ExceedsBaseline     113 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 91ae1fdd90eb0386147b55de80e774ef7f1ef0cb (build)

marwankhalili

comment created time in 15 hours

push eventmicrosoft/react-native-windows

Ryan Fowler

commit sha 7baf74ec48b7d8d7ab78d9349f95a13272311eb2

Fix second oncreate (#6099) * Don't reload the ReactNativeHost multiple times When OnActivate is called on an already-running instance, the Host should not be reloaded so we don't lose the native modules. * Change files

view details

dependabot-preview[bot]

commit sha 8b851927f5109533d7051aea238d94fe3a260f16

Bump @types/react-native from 0.63.20 to 0.63.22 (#6105) Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.63.20 to 0.63.22. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Nick Gerleman

commit sha f2794dc80cdaf4a83ed782d4d10ec1aad4c05c9e

Rethread After Resuming Timeout Coroutine (#6109) * Rethread After Resuming Timeout Coroutine Fixes #6108 We added thread checks to TestHostHarness which has UI thread affinity. This led to crashes on test timeout instead of a graceful error message, stemmed from our timeout coroutine being resumed on a different thread. The semantics around awaiting a cppwinrt timespan doing a thread jump aren't currently documented. Filed https://github.com/microsoft/cppwinrt/issues/754 since this seems like a sharp edge * Slightly more legible * Do it the cppwinrt way

view details

Nick Gerleman

commit sha 31563b93287b3a5849f956cce73019a36ee4a1e6

Reduce Microsoft.ReactNative PCH By 155MB-260MB (#6114) * Reduce Microsoft.ReactNative PCH By 155MB-260MB We see frequent OOM issues compiling our PCH due to its size. This change removes some of the heavier headers that are included in the PCH to get around XAML codegen issues and instead injects forced header inclusion into the CLCompile items used by XAML codegen. This is quite dirty, but should significantly reduce the increased OOM issues seen since adding these headers. Goes from 1024MB to 869MB for normal builds Goes from 1006 to 740MB for WinUI3 builds * Change files * Remove test code * Remove message * typo

view details

Nick Gerleman

commit sha e18989e41d5daa4fa4cce0e595f79c0526aeb8aa

Free Up Some Memory for react-native-init CI Jobs (#6111) * Free Up Some Memory for react-native-init CI Jobs For the integration test job I discovered we get more reliable builds if we do build-work when daemons are not active. For react-native-init tests, we don't need Verdaccio by the time we're ready to build, so we can kill it to reclaim a bit of memory. Testing locally, Verdaccio without any packages seems to use ~50MB while idle, which is enough to be worth reclaiming, but less than I had hoped for. Not sure if the number would be different when packages are present. * Reconcile with later task

view details

Nick Gerleman

commit sha 89b37d236af1c9d5db7af2d28c2d14d1c3189992

Fix run-windows Warnings Using Node 14 (#6116) * Fix run-windows Warnings Using Node 14 run-windows prints out a large number of warnings on Node 14: ``` $ react-native run-windows √ Auto-linking... Success: No auto-linking changes necessary. (181ms) (node:10936) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency (Use `node --trace-warnings ...` to show where the warning was created) (node:10936) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency (node:10936) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency ``` These come from shelljs, and are fixed in [shelljs 0.8.4](https://github.com/shelljs/shelljs/releases/tag/v0.8.4) * Change files

view details

Nick Gerleman

commit sha 3a41737a788f7ded7e4675d4539ebf619e500156

Remove Special UI When Debugger Attached (#6112) * Remove Special UI When Debugger Attached When discussed internally, we thought this was confusing. These were carryovers from legacy, with the back button espcially odd since we had it before we have a BackHandler. Removing both the debugger only back button, and debugger only frame counter that are automatically added. * Change files

view details

Julio César Rocha

commit sha c10720bde2f53ba3ed50ab93048a585a8377e46b

Use MakeJSQueueThread() for tests. (#6119) * Move Threading types into Shared project. * Use MessageDispatchQueue in DesktopTestRunner. * Remove TestMessageQueueThread. * clang format * Change files * Remove using statements for std:: methods * yarn format * Revert namespace decoration.

view details

React-Native-Windows Bot

commit sha adea129d9420d56902c1a599386fa30615bde0fb

applying package updates ***NO_CI***

view details

dannyvv

commit sha df4cb47be1fcec7b5dc23ec032c0a75b19907d7f

Add integration test for C# Interop (#6118)

view details

dependabot-preview[bot]

commit sha 29d0333424a3e7e174b38e07b4c14fcefd5f845f

Bump @types/react-native from 0.63.22 to 0.63.23 (#6123)

view details

dependabot-preview[bot]

commit sha 192f5353761952005fdadbd98f0a5d76b9350539

Bump beachball from 1.36.1 to 1.36.2 (#6121)

view details

dependabot-preview[bot]

commit sha c5196d191e42d93e01a3a2b5cef069e95e1e2920

Bump @types/ws from 7.2.6 to 7.2.7 (#6122)

view details

Igor Klemenski

commit sha eb13b4761acb4df37b02d75f4296b8a8033db2ec

Integrate RN 7/7 nightly build. (#6120) * integrate RN 7/7 build * Change files Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

Vladimir Morozov

commit sha c2001a2f1caec259a5bcdd81cffa1e524e121f92

Simplify react::uwp::IReactInstance (#5373) * Simplify react::uwp::IReactInstance * Change files * Fix Desktop build break * Format files * Fix RN for Desktop compilation * Fix crash at startup

view details

Vladimir Morozov

commit sha b377a77f3eac4baaa20e738d3f7f80653ddf06ea

Initial ABI-safe JSI implementation (#5461) * Initial ABI-safe JSI implementation * Change files * Format code * Implement strongly typed approach for JSI values * Use strongly type JSI ABI types * Rename IJsiBuffer and JsiDataHandler to IJsiByteBuffer and JsiByteArrayUser * Enable JSI unit tests (most of them fail) * Pass all JSI unit tests * Fix ReactWindows-Desktop.sln compilation * Fix sample project compilation * Fix compilation warnings * Make jsi.cpp not use precompiled header * Fix Microsoft.ReactNative.Cxx project * Fix Playground compilation issues * Fix Microsoft.ReactNative.Cxx compilation in new projects * Remove unnecessary changes * Reduce PCH size to try to avoid out of heap issue * Address PR feedback and update DLL-based deployment * Format code * Fix build breaks after merge

view details

Nick Gerleman

commit sha 64c111f645e82bb4d867d16254c3f6cf48e6dcc1

Add macOS Support to react-native-platform-override (#6117) * Get tests passing * Platform Insensitive Filename Hashing * Allow arbitrary platform extensions in manifest generation script * macOS Tests? * Change files * Add macos-tests-job * Revert rename * Try adding extra indent * Alternate variable syntax * Fix paths * Fix another path * Remove space from name * Add test colors * Print scratch repository info * AZP doesn't like env vars in working directories * Add status logging * Set autocrlf input * Normalize line endings on compare and work around rate limiting * Address feedback and allow token as CLI param * Fix typo

view details

React-Native-Windows Bot

commit sha 2ea78adf523023bb24abaf18653f0d599385bc3e

applying package updates ***NO_CI***

view details

Andrew Coates

commit sha ebb3e4f5c93fd08fd02b7051de8f302d77df5003

Fix issues that cause fast refresh issues in playground app (#6127)

view details

dependabot-preview[bot]

commit sha 1f3ba53c87b68876767a0051e09d023665f4ad0b

Bump @microsoft/api-documenter from 7.8.56 to 7.9.0 (#6133)

view details

push time in 15 hours

push eventmicrosoft/react-native-windows

push time in 15 hours

more