profile
viewpoint

Digitalbrainstem/ejs-grammar 50

EJS Grammar for VSCode

EB-Archive/app-menu 11

A WebExtension which adds the Application menu to the Firefox titlebar.

EB-Archive/about-button 4

A WebExtension which adds the 'about:about' button to the Firefox toolbar.

EB-Archive/view-image-in-new-tab 1

A WebExtension which adds the 'View Image in New Tab' context menu item to the Firefox Context Menu.

EB-Forks/debugger.html 1

The Firefox debugger that works anywhere :boom:

EB-Forks/decentraleyes 1

Decentraleyes - Local emulation of Content Delivery Networks.

EB-Archive/reload-in-urlbar 0

A WebExtension which adds the reload button to the Firefox Location bar.

EB-Forks/1.1.1.1 0

Cloudflare DNS Resolver Landing Page

EB-Forks/asar 0

(Now) official repository of the SNES assembler Asar, originally created by Alcaro

EB-Forks/awesome-pnpm 0

Awesome pnpm resources

Pull request review commentnodejs/node

util: remove instance check on empty object

 function getConstructorName(obj, ctx, recurseTimes, protoProps) {     const descriptor = ObjectGetOwnPropertyDescriptor(obj, 'constructor');     if (descriptor !== undefined &&         typeof descriptor.value === 'function' &&-        descriptor.value.name !== '' &&-        tmp instanceof descriptor.value) {+        descriptor.value.name !== '') {

This change broke tests inspecting the prototype object, which is not an instance of its constructor.

baylesa-dev

comment created time in 6 hours

PullRequestReviewEvent

pull request commentnodejs/node

doc: document changes for `*/promises` alias modules

The GitHub CI tests have now finished, although test‑macOS/test‑macOS‑with‑quic has timed out.

ExE-Boss

comment created time in 6 hours

pull request commentnodejs/node

doc: document changes for `*/promises` alias modules

@aduh95 There’s a good to fair chance that the commit queue might fail because the latest commit is slightly newer than your latest review, since I added information about https://github.com/nodejs/node/pull/33991.

ExE-Boss

comment created time in 18 hours

push eventExE-Boss/node

ExE Boss

commit sha ae296f9bbc712f8966c2e4f0caa9502705d10097

doc: document changes for `*/promises` alias modules Fixes: https://github.com/nodejs/node/issues/35740 Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/33991 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com>

view details

push time in 18 hours

issue commentnodejs/node

Can’t import stream promises API with ECMAScript Modules

I can’t reproduce this on v15.0.1, which also supports stream/promises: https://github.com/nodejs/node/pull/33991.

userpixel

comment created time in 18 hours

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-10-22

I’d like to request the addition of https://github.com/nodejs/node/issues/35788 to the tsc agenda for the next meeting.

mhdawson

comment created time in 18 hours

issue openednodejs/node

Backporting `util/types`, `path/unix` and `path/win32` to v15 proposal

<!-- Thank you for suggesting an idea to make Node.js better.

Please fill in as much of the template below as you're able. -->

Is your feature request related to a problem? Please describe. Please describe the problem you are trying to solve.

Describe the solution you'd like Please describe the desired behavior.

Describe alternatives you've considered Please describe alternative solutions or features you have considered.

created time in 18 hours

issue commentguybedford/es-module-shims

Compile to SystemJS on the fly

Well, if the object that’s passed to the with statement has a null prototype and is sealed, then engines might be able to somewhat optimise it.

Jamesernator

comment created time in 2 days

issue commentWebAssembly/esm-integration

ESM isn't suited for importing objects containing non-JavaScript identifiers

You can already do, which is what I’d presume transpilers might do:

import * as _module_wasm from "./module.wasm";

And then instead of add, you’d use _module_wasm["+"].

00ff0000red

comment created time in 2 days

issue commentmicrosoft/TypeScript

Support “Arbitrary module namespace identifier names”

Note that Babel now has support for this: https://github.com/babel/babel/pull/12091

ExE-Boss

comment created time in 2 days

pull request commentmicrosoft/TypeScript

New definition for omit that should ensure the name Omit is preserved…

@weswigham Looks like tests/cases/conformance/types/literal/templateLiteralTypes1.ts is failing because the errors baseline has changed: https://github.com/microsoft/TypeScript/pull/37608/checks?check_run_id=1295283520#step:7:99

weswigham

comment created time in 2 days

issue commentLiCybora/NanoDefenderFirefox

Consider changing name to something like "uBlock Defender"

I’m personally in favour of PicoDefender.

sbstn87

comment created time in 3 days

push eventExE-Boss/node

ExE Boss

commit sha 20b1462664019214ffeaacfa43d0cd5cc39c1d36

doc: document changes for `*/promises` alias modules Fixes: https://github.com/nodejs/node/issues/35740 Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com>

view details

push time in 3 days

push eventExE-Boss/node

Rich Trott

commit sha 6c4239bea786a3e231943c283fe236832987939d

doc: use kbd element in readline doc PR-URL: https://github.com/nodejs/node/pull/35698 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Antoine du Hamel

commit sha a987a3256c6e5553af58fd4adcdc6aed2417e8ce

build: use make functions instead of echo PR-URL: https://github.com/nodejs/node/pull/35707 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Daniel Bevenius

commit sha 610c68c4587db1ed47a074f28a527cc24223c7a6

src: mark/pop OpenSSL errors in NewRootCertStore This commit sets the OpenSSL error mark before calling X509_STORE_load_locations and pops the error mark afterwards. The motivation for this is that it is possible that X509_STORE_load_locations can produce errors if the configuration option --openssl-system-ca-path file does not exist. Later if a different function is called which calls an OpenSSL function it could fail because these errors might still be on the OpenSSL error stack. Currently, all functions that call NewRootCertStore clear the OpenSSL error queue upon returning, but this was not the case for example in v12.18.0. PR-URL: https://github.com/nodejs/node/pull/35514 Fixes: https://github.com/nodejs/node/issues/35456 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Michaël Zasso

commit sha 66ab2bdcc963331841e2a009c9b3831a9d85a5d0

deps: V8: set correct V8 version patch number The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils. PR-URL: https://github.com/nodejs/node/pull/35732 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

view details

Ruy Adorno

commit sha d5088d8dbbcf1cdc32e15a37e132a43e95dece2f

deps: upgrade npm to 7.0.3 PR-URL: https://github.com/nodejs/node/pull/35724 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha d2a3078460095bef0db0772eb94a0b5d3232ec84

src: add --heapsnapshot-near-heap-limit option This patch adds a --heapsnapshot-near-heap-limit CLI option that takes heap snapshots when the V8 heap is approaching the heap size limit. It will try to write the snapshots to disk before the program crashes due to OOM. PR-URL: https://github.com/nodejs/node/pull/33010 Refs: https://github.com/nodejs/node/issues/27552 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Beth Griggs

commit sha 4d16554bfa8594879195d06e56a998940ef2f2fa

2020-10-21, Version 15.0.1 (Current) Notable changes: - **crypto**: fix regression on randomFillSync (James M Snell) (https://github.com/nodejs/node/pull/35723) - This fixes issue https://github.com/nodejs/node/issues/35722. - **deps**: upgrade npm to 7.0.3 (Ruy Adorno) (https://github.com/nodejs/node/pull/35724) - **doc**: add release key for Danielle Adams (Danielle Adams) (https://github.com/nodejs/node/pull/35545) PR-URL: https://github.com/nodejs/node/pull/35736

view details

Brian 'bdougie' Douglas

commit sha db4ce85cb7213c48384e371f4c53862f0af1022d

deps: V8: backport 4263f8a5e8e0 Original commit message: parser: better error message for await+tla Bug: v8:9344, v8:6513 Change-Id: I1854e483515e7da99192367b6764a0ec7c8b41d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2411687 Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Gus Caplan <snek@chromium.org> Cr-Commit-Position: refs/heads/master@{#70099} Refs: https://github.com/v8/v8/commit/4263f8a5e8e04a766aeb7cde0081da3ac6c12a9e PR-URL: https://github.com/nodejs/node/pull/35650 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Benjamin Coe

commit sha 7657f62b1810b94acbe7db68089b608213b34749

test: add windows and C++ coverage Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: https://github.com/nodejs/node/pull/35670 Fixes: https://github.com/nodejs/node/issues/35696 Refs: https://github.com/nodejs/node/pull/35653 Refs: https://github.com/nodejs/node/issues/35646 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

Joyee Cheung

commit sha fc5636e1eb45949e764f3b1ffbd63e39b2ca30a9

v8: implement v8.takeCoverage() Add an v8.takeCoverage() API that allows the user to write the coverage started by NODE_V8_COVERAGE to disk on demand. The coverage can be written multiple times during the lifetime of the process, each time the execution counter will be reset. When the process is about to exit, one last coverage will still be written to disk. Also refactors the internal profiler connection code so that we use the inspector response id to identify the profile response instead of using an ad-hoc flag in C++. PR-URL: https://github.com/nodejs/node/pull/33807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>

view details

Joyee Cheung

commit sha 7945a2cdc34623234037dfaccef56c257da68d13

v8: implement v8.stopCoverage() Add a v8.stopCoverage() API to stop the coverage collection started by NODE_V8_COVERAGE - this would be useful in conjunction with v8.takeCoverage() if the user don't want to emit the coverage at the process exit but still want to collect it on demand at some point. PR-URL: https://github.com/nodejs/node/pull/33807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>

view details

Tierney Cyren

commit sha 8f47e697a19995e0d532326f270bd70ed097f29a

build: add license-builder GitHub Action PR-URL: https://github.com/nodejs/node/pull/35712 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

Pooja D.P

commit sha 1ba932b183f71c87626be7079a459f80c732bfa5

doc: add Installing Node.js header in BUILDING.md PR-URL: https://github.com/nodejs/node/pull/35710 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Antoine du Hamel

commit sha 3f4ec9c30b74f7fd4d8c8ab66090d6edee85300b

doc,esm: document experimental warning removal PR-URL: https://github.com/nodejs/node/pull/35750 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

view details

ExE Boss

commit sha ec89183de154099e2b17387d946f662c7444ae78

doc: document changes for `*/promises` alias modules Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com>

view details

push time in 3 days

push eventExE-Boss/node

ExE Boss

commit sha 054a52f4ab3f45bf2e3cf08cbcb92ed21452aeb7

fixup! doc: Document changes for `*/promises` alias modules Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

view details

push time in 3 days

push eventExE-Boss/node

ExE Boss

commit sha 4552b27449343f1526ed4fd57e72df6ba1707821

fixup! doc: Document changes for `*/promises` alias modules Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

view details

push time in 3 days

startedLiCybora/NanoBuild

started time in 4 days

delete branch EB-Forks/DefinitelyTyped

delete branch : types/node/zlib/fix-unified-signatures

delete time in 4 days

pull request commentDefinitelyTyped/DefinitelyTyped

fix(node/zlib): Unify signatures and fix comments

Ready to merge

ExE-Boss

comment created time in 4 days

push eventEB-Forks/csswg-drafts

fantasai

commit sha 5b4d06c04e9f2e01d67426ba7749814e9900a40a

[css-inline-3] Export line box

view details

Tab Atkins-Bittner

commit sha 2a3abc11144471b264a9052e61e9db3b92e408a6

[css-position-3] More link fixups

view details

Tab Atkins-Bittner

commit sha 225899d43b66ef0912646c56452da4cb9c9997dd

[css-position-3] Remove the reference to sections we're no longer replacing.

view details

Tab Atkins-Bittner

commit sha d0660d49b65b1c310c344d7909d37dae18fdb634

[css-position-3][editorial] Remove comments.

view details

fantasai

commit sha d2bfe843cfec2c8feee8cb014b0843249b0ab295

[css-position-3] Refactor list.

view details

fantasai

commit sha 6ee348414bb207afea34dd760df9dabf68b89404

[css-position-3] Fix markup

view details

fantasai

commit sha d0b1d6eb8476795b3327ae5127663db94db2f4ee

[css-position-3] Specify that auto margins are treated as zero for calculating static position. #665

view details

fantasai

commit sha b6efcd7ad894c59285eac83a51e574f86fa0697d

[css-align-3] Fix capitalization

view details

Tab Atkins-Bittner

commit sha 5a8ed5b0c57ab1749ff69ab9c9ec4d5595e68950

[css-position-3] Define that stickypos elements are at their initial position when a scrolling operation tries to target them. #1459

view details

Rachel Andrew

commit sha b323b150dbd79d2bcbcb9a3c0509a0ac2dfa09e4

[css-multicol] disposition of comments

view details

fantasai

commit sha fb0ab297dd502d42227b309b0982efbb7bcdbd7d

[css-text-3] Drop questionable characters from space-discarding set for now. Add new open issue.

view details

fantasai

commit sha d682cc566694fd9855c67455b9ac389a95370304

[css-text-3] Markup fix

view details

fantasai

commit sha 8f6002966061c9190d6b732be47a31895ca45cf4

[css-position-3] Parallel notes wrt properties that create containing blocks. <https://lists.w3.org/Archives/Public/www-style/2020Apr/0021.html>

view details

fantasai

commit sha bd5124bf989339f0aa76ba41b29ac546dfe1e060

[css-position-3] Clarify that value may become negative. <https://lists.w3.org/Archives/Public/www-style/2020Apr/0021.html>

view details

Cameron McCormack

commit sha 452e6732c6229501380bc04d896340c92ab1f96d

[css-grid-2] Add masonry layout explainer.

view details

Cameron McCormack

commit sha c20d46487d55de0d10cb46d4106a8f8ceb27dcbd

[css-grid-2] Fix example in masonry explainer.

view details

Florian Rivoal

commit sha c11da77a4b7a7c4b0e43011dc4b11e00e0213f6e

[css-contain-2] Use terminology newly established by css-poition-3

view details

Florian Rivoal

commit sha d712962f9e4271e33627c41f0e6db7a090c1d6e2

[css-overflow-3] Fixup bibliography

view details

Florian Rivoal

commit sha f2e24e66c9eb77de99f10058d19ea6627c2ce39a

[css-overflow-3] Export definition

view details

Florian Rivoal

commit sha f3e5bddc5cccf3771f0db0ec97efdc2a2592ff9d

[css-position-3] Fix cross-ref

view details

push time in 4 days

push eventExE-Boss/node

ExE Boss

commit sha e1f62576d7af31f83bc767761b17536f1c26c040

doc: Document changes for `*/promises` alias modules Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>

view details

push time in 4 days

push eventExE-Boss/node

Rich Trott

commit sha 79eb529c3e448ebe99508d4f1e07f4823c2326a9

doc: changed "considered experimental" to "experimental" in cli.md Change "no longer considered experimental" to "no longer experimental" in cli.md. PR-URL: https://github.com/nodejs/node/pull/34128 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha f06df175b453e397317f32a7785a7b49198f6f06

doc: change "considered experimental" to "experimental" in n-api.md This changes "considered" experimental" to "experimental" in the n-api.md file and introduces some additional brevity. PR-URL: https://github.com/nodejs/node/pull/34129 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha 1aa847f7438407b78cc0d1f9eab96adcfe9ff9df

doc: move sam-github to TSC Emeriti I don't have enough time to remain active in the TSC, so I will step down. PR-URL: https://github.com/nodejs/node/pull/34095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Derek Lewis

commit sha 1dc837ed9a139eaf86d7929e9bee6f0021fc5a3d

doc: add http highlight grammar Prior to this commit, http request message code blocks in Markdown files were not being highlighted correctly. This has been corrected by adding the new grammar to the bundle, removing the CRLFs (`\r\n`) from these code samples, adding a reminder to re-add them, and tuning the syntax theme to support attribute highlighting. PR-URL: https://github.com/nodejs/node/pull/33785 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Rich Trott

commit sha dfeeb3c275cbc2576974d8ca5e89961df2a45944

doc: simplify and clarify ReferenceError material in errors.md "should always be considered" -> "indicate" PR-URL: https://github.com/nodejs/node/pull/34151 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Rich Trott

commit sha 829f521fda0f5add192b10002ce73142655c16a5

doc: remove "considered" in errors.md "would be considered a `TypeError`" -> "would be a `TypeError`". Using "considered" introduces unnecessary ambiguity. Is is not actually a TypeError but merely "considered" one? Why is that? We don't say. Simplify to "is a TypeError". PR-URL: https://github.com/nodejs/node/pull/34152 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Richard Lau

commit sha d08334a489cbd29e4876a0031603ab8b5fef6f89

test: report actual error code on failure Add a custom message to parallel/test-dgram-error-message-address so that the actual error code that doesn't match the allowed errors is output on assertion failure. PR-URL: https://github.com/nodejs/node/pull/34134 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Rich Trott

commit sha 9b8d317d9916dd44b2b3678df05f9daf6eb14c90

test: fix flaky test-http2-invalidheaderfield Separate test cases to avoid side effects and race conditions. Fixes: https://github.com/nodejs/node/issues/34172 PR-URL: https://github.com/nodejs/node/pull/34173 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Anna Henningsen

commit sha 1d7be3253f12c9eafaf0ecec378a657893b30852

crypto: move typechecking for timingSafeEqual into C++ This makes the function more robust against V8 inlining. Fixes: https://github.com/nodejs/node/issues/34073 PR-URL: https://github.com/nodejs/node/pull/34141 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Xu Meng

commit sha 07bbadb2c7f4f7fca41d01839b122a6e2cbb16e2

test: skip some IBM i unsupported test cases Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program. This leads to timing issues and ECONNRESET failures in some test cases. Refs: https://github.com/libuv/libuv/pull/2782 PR-URL: https://github.com/nodejs/node/pull/34118 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 907829b1a47f86dff9d81168fc1c867540638a4a

doc: simply dns.ADDRCONFIG language PR-URL: https://github.com/nodejs/node/pull/34155 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 2110fadecdd6c97054dcdcbd1208818c185944ff

doc: improve triaging text in issues.md Remove a double negative and many superfluous sentences. The sentiment in the removed material is good, but we already tell people that discussion should be focused, helpful, and professional. Having two extra paragraphs greatly reduces the likelihood that people will read the material. PR-URL: https://github.com/nodejs/node/pull/34164 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha 7f2cf0f8da83d67eac47cf3cb1b8c0a98b518831

doc: add streams to the pipeline function signature PR-URL: https://github.com/nodejs/node/pull/34153 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

rickyes

commit sha a7c6806adc5591ba782cb7c520fb983bc0e25ec1

doc: Add maxTotalSockets option to agent constructor PR-URL: https://github.com/nodejs/node/pull/34013 Refs: https://github.com/nodejs/node/pull/33617 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Derek Lewis

commit sha db3b209e7df254794873be5ac91345dee034e130

doc: clarify esm conditional exports prose This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: https://github.com/nodejs/node/pull/33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha ee3243fe3f29f317e910a2424eabd279dec2eb00

src: remove unused fields from IsolateData PR-URL: https://github.com/nodejs/node/pull/34139 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Denys Otrishko

commit sha b4fe76d656d51ead949f2a35c13a221616f78c4c

doc: improve async_hooks asynchronous context example * use writeFile(1) everywhere to log * prettify execution id graph * add clearer explanation for TickObject presence * add causation graph via triggerAsyncId PR-URL: https://github.com/nodejs/node/pull/33730 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Rodion Abdurakhimov

commit sha d853145277f3070053ed89cbaa91ad9218f3e1ac

doc: fix source link margin to sub-header mark Prior to this commit, [src] link overlapped sharped (#) sub-header link PR-URL: https://github.com/nodejs/node/pull/33664 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Gabriel Schulhof

commit sha cfa3d8fec5d9f6469c8d4ef077b53e0d9007dab9

doc: fix entry for `napi_create_external_buffer` Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: https://github.com/nodejs/node/issues/33471 PR-URL: https://github.com/nodejs/node/pull/34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anentropic

commit sha 7c9df66485e63c5b03f6344a658f8e0018a928fb

doc: clarify how to read process.stdin document more clearly that stdin will emit multiple readable events PR-URL: https://github.com/nodejs/node/pull/27350 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 4 days

delete branch ExE-Boss/node

delete branch : lib/util/add-util-types-alias-module

delete time in 4 days

Pull request review commentmicrosoft/TypeScript

New definition for omit that should ensure the name Omit is preserved…

 type Extract<T, U> = T extends U ? T : never; /**
  * Construct a type with the properties of T except for those in type K.
  */
-type Omit<T, K extends keyof any> = Pick<T, Exclude<keyof T, K>>;
+type Omit<T, K extends keyof any, Keys extends keyof T = Exclude<keyof T, K>> = {
+    [P in Keys]: T[P];
+};

This can be implemented using mapped types now:

type Omit<T, K extends keyof any> = {
    [P in keyof T as P extends K ? never : P]: T[P];
};
weswigham

comment created time in 4 days

PullRequestReviewEvent

issue commenttc39/ecma262

How should other specs indicate that they create built-in functions that support [[Construct]]?

and built-in functions have the [[Call]] from 9.3.1, not 9.2.1.

That’s only if they’re not implemented using self‑hosted JS, like what SpiderMonkey does for some of its implementation.

domenic

comment created time in 4 days

Pull request review commentDefinitelyTyped/DefinitelyTyped

[node] Refactor 'globals.d.ts'

 declare module "buffer" {     };      export { BuffType as Buffer };++    global {+        namespace NodeJS {+            interface Global {+                Buffer: typeof Buffer;+            }+        }+    }+}++// Buffer class+type BufferEncoding = "ascii" | "utf8" | "utf-8" | "utf16le" | "ucs2" | "ucs-2" | "base64" | "latin1" | "binary" | "hex";++/**+ * Raw data is stored in instances of the Buffer class.+ * A Buffer is similar to an array of integers but corresponds to a raw memory allocation outside the V8 heap.  A Buffer cannot be resized.+ * Valid string encodings: 'ascii'|'utf8'|'utf16le'|'ucs2'(alias of 'utf16le')|'base64'|'binary'(deprecated)|'hex'+ */+declare class Buffer extends Uint8Array {+    /**+     * Allocates a new buffer containing the given {str}.+     *+     * @param str String to store in buffer.+     * @param encoding encoding to use, optional.  Default is 'utf8'+     * @deprecated since v10.0.0 - Use `Buffer.from(string[, encoding])` instead.+     */+    constructor(str: string, encoding?: BufferEncoding);+    /**+     * Allocates a new buffer of {size} octets.+     *+     * @param size count of octets to allocate.+     * @deprecated since v10.0.0 - Use `Buffer.alloc()` instead (also see `Buffer.allocUnsafe()`).+     */+    constructor(size: number);+    /**+     * Allocates a new buffer containing the given {array} of octets.+     *+     * @param array The octets to store.+     * @deprecated since v10.0.0 - Use `Buffer.from(array)` instead.+     */+    constructor(array: Uint8Array);+    /**+     * Produces a Buffer backed by the same allocated memory as+     * the given {ArrayBuffer}/{SharedArrayBuffer}.+     *+     *+     * @param arrayBuffer The ArrayBuffer with which to share memory.+     * @deprecated since v10.0.0 - Use `Buffer.from(arrayBuffer[, byteOffset[, length]])` instead.+     */+    constructor(arrayBuffer: ArrayBuffer | SharedArrayBuffer);+    /**+     * Allocates a new buffer containing the given {array} of octets.+     *+     * @param array The octets to store.+     * @deprecated since v10.0.0 - Use `Buffer.from(array)` instead.+     */+    constructor(array: ReadonlyArray<any>);+    /**+     * Copies the passed {buffer} data onto a new {Buffer} instance.+     *+     * @param buffer The buffer to copy.+     * @deprecated since v10.0.0 - Use `Buffer.from(buffer)` instead.+     */+    constructor(buffer: Buffer);+    /**+     * When passed a reference to the .buffer property of a TypedArray instance,+     * the newly created Buffer will share the same allocated memory as the TypedArray.+     * The optional {byteOffset} and {length} arguments specify a memory range+     * within the {arrayBuffer} that will be shared by the Buffer.+     *+     * @param arrayBuffer The .buffer property of any TypedArray or a new ArrayBuffer()+     */+    static from(arrayBuffer: ArrayBuffer | SharedArrayBuffer, byteOffset?: number, length?: number): Buffer;+    /**+     * Creates a new Buffer using the passed {data}+     * @param data data to create a new Buffer+     */+    static from(data: ReadonlyArray<number>): Buffer;+    static from(data: Uint8Array): Buffer;+    /**+     * Creates a new buffer containing the coerced value of an object+     * A `TypeError` will be thrown if {obj} has not mentioned methods or is not of other type appropriate for `Buffer.from()` variants.+     * @param obj An object supporting `Symbol.toPrimitive` or `valueOf()`.+     */+    static from(obj: { valueOf(): string | object } | { [Symbol.toPrimitive](hint: 'string'): string }, byteOffset?: number, length?: number): Buffer;+    /**+     * Creates a new Buffer containing the given JavaScript string {str}.+     * If provided, the {encoding} parameter identifies the character encoding.+     * If not provided, {encoding} defaults to 'utf8'.+     */+    static from(str: string, encoding?: BufferEncoding): Buffer;+    /**+     * Creates a new Buffer using the passed {data}+     * @param values to create a new Buffer+     */+    static of(...items: number[]): Buffer;+    /**+     * Returns true if {obj} is a Buffer+     *+     * @param obj object to test.+     */+    static isBuffer(obj: any): obj is Buffer;+    /**+     * Returns true if {encoding} is a valid encoding argument.+     * Valid string encodings in Node 0.12: 'ascii'|'utf8'|'utf16le'|'ucs2'(alias of 'utf16le')|'base64'|'binary'(deprecated)|'hex'+     *+     * @param encoding string to test.+     */+    static isEncoding(encoding: string): encoding is BufferEncoding;+    /**+     * Gives the actual byte length of a string. encoding defaults to 'utf8'.+     * This is not the same as String.prototype.length since that returns the number of characters in a string.+     *+     * @param string string to test.+     * @param encoding encoding used to evaluate (defaults to 'utf8')+     */+    static byteLength(+        string: string | NodeJS.ArrayBufferView | ArrayBuffer | SharedArrayBuffer,+        encoding?: BufferEncoding+    ): number;+    /**+     * Returns a buffer which is the result of concatenating all the buffers in the list together.+     *+     * If the list has no items, or if the totalLength is 0, then it returns a zero-length buffer.+     * If the list has exactly one item, then the first item of the list is returned.+     * If the list has more than one item, then a new Buffer is created.+     *+     * @param list An array of Buffer objects to concatenate+     * @param totalLength Total length of the buffers when concatenated.+     *   If totalLength is not provided, it is read from the buffers in the list. However, this adds an additional loop to the function, so it is faster to provide the length explicitly.+     */+    static concat(list: ReadonlyArray<Uint8Array>, totalLength?: number): Buffer;+    /**+     * The same as buf1.compare(buf2).+     */+    static compare(buf1: Uint8Array, buf2: Uint8Array): number;+    /**+     * Allocates a new buffer of {size} octets.+     *+     * @param size count of octets to allocate.+     * @param fill if specified, buffer will be initialized by calling buf.fill(fill).+     *    If parameter is omitted, buffer will be filled with zeros.+     * @param encoding encoding used for call to buf.fill while initalizing+     */+    static alloc(size: number, fill?: string | Buffer | number, encoding?: BufferEncoding): Buffer;+    /**+     * Allocates a new buffer of {size} octets, leaving memory not initialized, so the contents+     * of the newly created Buffer are unknown and may contain sensitive data.+     *+     * @param size count of octets to allocate+     */+    static allocUnsafe(size: number): Buffer;+    /**+     * Allocates a new non-pooled buffer of {size} octets, leaving memory not initialized, so the contents+     * of the newly created Buffer are unknown and may contain sensitive data.+     *+     * @param size count of octets to allocate+     */+    static allocUnsafeSlow(size: number): Buffer;+    /**+     * This is the number of bytes used to determine the size of pre-allocated, internal Buffer instances used for pooling. This value may be modified.+     */+    static poolSize: number;++    write(string: string, encoding?: BufferEncoding): number;+    write(string: string, offset: number, encoding?: BufferEncoding): number;+    write(string: string, offset: number, length: number, encoding?: BufferEncoding): number;+    toString(encoding?: BufferEncoding, start?: number, end?: number): string;+    toJSON(): { type: 'Buffer'; data: number[] };+    equals(otherBuffer: Uint8Array): boolean;+    compare(+        otherBuffer: Uint8Array,+        targetStart?: number,+        targetEnd?: number,+        sourceStart?: number,+        sourceEnd?: number+    ): number;+    copy(targetBuffer: Uint8Array, targetStart?: number, sourceStart?: number, sourceEnd?: number): number;+    /**+     * Returns a new `Buffer` that references **the same memory as the original**, but offset and cropped by the start and end indices.+     *+     * This method is incompatible with `Uint8Array#slice()`, which returns a copy of the original memory.+     *+     * @param begin Where the new `Buffer` will start. Default: `0`.+     * @param end Where the new `Buffer` will end (not inclusive). Default: `buf.length`.+     */+    slice(begin?: number, end?: number): Buffer;+    /**+     * Returns a new `Buffer` that references **the same memory as the original**, but offset and cropped by the start and end indices.+     *+     * This method is compatible with `Uint8Array#subarray()`.+     *+     * @param begin Where the new `Buffer` will start. Default: `0`.+     * @param end Where the new `Buffer` will end (not inclusive). Default: `buf.length`.+     */+    subarray(begin?: number, end?: number): Buffer;+    writeBigInt64BE(value: bigint, offset?: number): number;+    writeBigInt64LE(value: bigint, offset?: number): number;+    writeBigUInt64BE(value: bigint, offset?: number): number;+    writeBigUInt64LE(value: bigint, offset?: number): number;+    writeUIntLE(value: number, offset: number, byteLength: number): number;+    writeUIntBE(value: number, offset: number, byteLength: number): number;+    writeIntLE(value: number, offset: number, byteLength: number): number;+    writeIntBE(value: number, offset: number, byteLength: number): number;+    readBigUInt64BE(offset?: number): bigint;+    readBigUInt64LE(offset?: number): bigint;+    readBigInt64BE(offset?: number): bigint;+    readBigInt64LE(offset?: number): bigint;+    readUIntLE(offset: number, byteLength: number): number;+    readUIntBE(offset: number, byteLength: number): number;+    readIntLE(offset: number, byteLength: number): number;+    readIntBE(offset: number, byteLength: number): number;+    readUInt8(offset?: number): number;+    readUInt16LE(offset?: number): number;+    readUInt16BE(offset?: number): number;+    readUInt32LE(offset?: number): number;+    readUInt32BE(offset?: number): number;+    readInt8(offset?: number): number;+    readInt16LE(offset?: number): number;+    readInt16BE(offset?: number): number;+    readInt32LE(offset?: number): number;+    readInt32BE(offset?: number): number;+    readFloatLE(offset?: number): number;+    readFloatBE(offset?: number): number;+    readDoubleLE(offset?: number): number;+    readDoubleBE(offset?: number): number;+    reverse(): this;+    swap16(): Buffer;+    swap32(): Buffer;+    swap64(): Buffer;+    writeUInt8(value: number, offset?: number): number;+    writeUInt16LE(value: number, offset?: number): number;+    writeUInt16BE(value: number, offset?: number): number;+    writeUInt32LE(value: number, offset?: number): number;+    writeUInt32BE(value: number, offset?: number): number;+    writeInt8(value: number, offset?: number): number;+    writeInt16LE(value: number, offset?: number): number;+    writeInt16BE(value: number, offset?: number): number;+    writeInt32LE(value: number, offset?: number): number;+    writeInt32BE(value: number, offset?: number): number;+    writeFloatLE(value: number, offset?: number): number;+    writeFloatBE(value: number, offset?: number): number;+    writeDoubleLE(value: number, offset?: number): number;+    writeDoubleBE(value: number, offset?: number): number;++    fill(value: string | Uint8Array | number, offset?: number, end?: number, encoding?: BufferEncoding): this;++    indexOf(value: string | number | Uint8Array, byteOffset?: number, encoding?: BufferEncoding): number;+    lastIndexOf(value: string | number | Uint8Array, byteOffset?: number, encoding?: BufferEncoding): number;+    entries(): IterableIterator<[number, number]>;+    includes(value: string | number | Buffer, byteOffset?: number, encoding?: BufferEncoding): boolean;+    keys(): IterableIterator<number>;+    values(): IterableIterator<number>;

This should be moved into the global block inside module "buffer", like in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45845.

Semigradsky

comment created time in 4 days

Pull request review commentDefinitelyTyped/DefinitelyTyped

[node] Refactor 'globals.d.ts'

 declare module "timers" {         function __promisify__<T>(value: T): Promise<T>;     }     function clearImmediate(immediateId: NodeJS.Immediate): void;++    global {+        namespace NodeJS {+            interface Global {+                clearImmediate: (immediateId: Immediate) => void;+                clearInterval: (intervalId: Timeout) => void;+                clearTimeout: (timeoutId: Timeout) => void;++                setImmediate: (callback: (...args: any[]) => void, ...args: any[]) => Immediate;+                setInterval: (callback: (...args: any[]) => void, ms: number, ...args: any[]) => Timeout;+                setTimeout: (callback: (...args: any[]) => void, ms: number, ...args: any[]) => Timeout;+            }++            interface RefCounted {+                ref(): this;+                unref(): this;+            }++            // compatibility with older typings+            interface Timer extends RefCounted {+                hasRef(): boolean;+                refresh(): this;+            }++            interface Immediate extends RefCounted {+                hasRef(): boolean;+                _onImmediate: Function; // to distinguish it from the Timeout class+            }++            interface Timeout extends Timer {+                hasRef(): boolean;+                refresh(): this;+            }+        }+    }+}++declare function setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): NodeJS.Timeout;+declare namespace setTimeout {+    function __promisify__(ms: number): Promise<void>;+    function __promisify__<T>(ms: number, value: T): Promise<T>;+}+declare function clearTimeout(timeoutId: NodeJS.Timeout): void;+declare function setInterval(callback: (...args: any[]) => void, ms: number, ...args: any[]): NodeJS.Timeout;+declare function clearInterval(intervalId: NodeJS.Timeout): void;+declare function setImmediate(callback: (...args: any[]) => void, ...args: any[]): NodeJS.Immediate;+declare namespace setImmediate {+    function __promisify__(): Promise<void>;+    function __promisify__<T>(value: T): Promise<T>; }+declare function clearImmediate(immediateId: NodeJS.Immediate): void;

This should be moved into the global block inside module "timers".

Semigradsky

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentDefinitelyTyped/DefinitelyTyped

[node] Refactor 'globals.d.ts'

+// Declare "static" methods in Error+interface ErrorConstructor {+    /** Create .stack property on a target object */+    captureStackTrace(targetObject: object, constructorOpt?: Function): void;++    /**+     * Optional override for formatting stack traces+     *+     * @see https://github.com/v8/v8/wiki/Stack%20Trace%20API#customizing-stack-traces+     */+    prepareStackTrace?: (err: Error, stackTraces: NodeJS.CallSite[]) => any;++    stackTraceLimit: number;+}++declare namespace NodeJS {+    interface CallSite {+        /**+         * Value of "this"+         */+        getThis(): any;++        /**+         * Type of "this" as a string.+         * This is the name of the function stored in the constructor field of+         * "this", if available.  Otherwise the object's [[Class]] internal+         * property.+         */+        getTypeName(): string | null;++        /**+         * Current function+         */+        getFunction(): Function | undefined;++        /**+         * Name of the current function, typically its name property.+         * If a name property is not available an attempt will be made to try+         * to infer a name from the function's context.+         */+        getFunctionName(): string | null;++        /**+         * Name of the property [of "this" or one of its prototypes] that holds+         * the current function+         */+        getMethodName(): string | null;++        /**+         * Name of the script [if this function was defined in a script]+         */+        getFileName(): string | null;++        /**+         * Current line number [if this function was defined in a script]+         */+        getLineNumber(): number | null;++        /**+         * Current column number [if this function was defined in a script]+         */+        getColumnNumber(): number | null;++        /**+         * A call site object representing the location where eval was called+         * [if this function was created using a call to eval]+         */+        getEvalOrigin(): string | undefined;++        /**+         * Is this a toplevel invocation, that is, is "this" the global object?+         */+        isToplevel(): boolean;++        /**+         * Does this call take place in code defined by a call to eval?+         */+        isEval(): boolean;++        /**+         * Is this call in native V8 code?+         */+        isNative(): boolean;++        /**+         * Is this a constructor call?+         */+        isConstructor(): boolean;+    }++    interface ErrnoException extends Error {+        /**+         * If present, the address to which a network connection failed+         */+        address?: string;+        /**+         * The system-provided error number+         */+        errno?: number;+        /**+         * The string error code+         */+        code?: string;+        /**+         * If present, extra details about the error condition+         */+        info?: object;+        /**+         * If present, the file path when reporting a file system error+         */+        path?: string;+        /**+         * If present, the network connection port that is not available+         */+        port?: number;+        /**+         * The name of the system call that triggered the error+         */+        syscall?: string;+        stack?: string;+    }++    interface Global {+        Error: typeof Error;+        EvalError: typeof EvalError;+        RangeError: typeof RangeError;+        ReferenceError: typeof ReferenceError;+        SyntaxError: typeof SyntaxError;+        TypeError: typeof TypeError;+        URIError: typeof URIError;+    }+}

There is no built‑in "errors" module in NodeJS, so this should either be kept in globals.d.ts, or renamed to globals.errors.d.ts.

Semigradsky

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

startednodejs/nodejs.org

started time in 4 days

delete branch ExE-Boss/node

delete branch : lib/path/add-path-posix-win-alias-modules

delete time in 4 days

pull request commentnodejs/node

path: add `path/posix` and `path/win32` alias modules

@Flarna This needs re‑approving because of the last fixup! commit.

ExE-Boss

comment created time in 5 days

push eventEB-Forks/engine262

ExE Boss

commit sha 48e131acf029f8493d968794d004bba611eabce7

Use spec enums for `ToPrimitive` and `OrdinaryToPrimitive`

view details

push time in 5 days

create barnchEB-Forks/engine262

branch : fix/to-primitive/hint-enums

created branch time in 5 days

pull request commentnodejs/node

2020-10-20, Version 15.0.0 (Current)

BethGriggs

comment created time in 5 days

push eventEB-Forks/engine262

Gus Caplan

commit sha 46a44086f7d425eb5e05ec77bc4552796137006e

some small cleanup

view details

ExE Boss

commit sha 414018d22355558c642d6d79128c508c659f2f59

Value: Convert `Value` constructor to class syntax

view details

ExE Boss

commit sha 3da6755b232f2c66f205e10307ed5ce16e493f2b

CompletePropertyDescriptor: Fix init of `like`

view details

ExE Boss

commit sha e9917b42dc9e34ea985d1dd0f0ed723386b1d841

FunctionEnvironmentRecord: Fix `ThisBindingStatus` internal slot name

view details

Gus Caplan

commit sha b6914dbe868c1df6fb17f49c28e8ca036540befd

fix build

view details

ExE Boss

commit sha 2b21fb9d9aa991d66417e714b581e4c14774c8c2

Rename `Generator` intrinsics

view details

Gus Caplan

commit sha f005ad30dd92f4000778feae2a05d423ed7c2470

update test262

view details

ExE Boss

commit sha 51224629b6fb8d3e7300d1ca7f465ea27aaaa90c

Parser: Add missing `BIGINT` token

view details

Gus Caplan

commit sha 6ea3dd9565ba495a22087665e56e298768e02d95

implement item methods

view details

Gus Caplan

commit sha 1fcf348882a61c8c7f76e2d611c3ea17bbc358f4

regex unicode property escape support

view details

Gus Caplan

commit sha f297980638aafc5721149d4237e300a7a848a879

cut regex data

view details

Gus Caplan

commit sha 39787377a7b8715c87fd67e1ccca09b1512e313e

export unicode sets for boost

view details

Jake Champion

commit sha 597da6c1cb7fb0390a3ae8e216c71c884f9c1c76

Fix spelling of Enumerable property throughout Promise module

view details

Gus Caplan

commit sha 02518492c33b559fe67513b184e4fd7f381c8767

update test262

view details

Gus Caplan

commit sha b3d792a0afd95f737f8663ff7f11ca234f00feaa

rewrite test262 processing

view details

Gus Caplan

commit sha ebd8b5609e190f4cdfb92d694bebbed1dfee11ee

update test262

view details

Gus Caplan

commit sha 6094f3b3749fd608b899c7e3a1821e4d0b346bae

some refactoring

view details

Gus Caplan

commit sha 58dbb18eaee66398d038de6a95a99956a5fc97fd

fix parsing bug

view details

ExE Boss

commit sha dd818de86e604e58ec19f2b3b8cb3e7e14bd7f0c

ESLint: use private scoped package for `eslint‑plugin‑engine262`

view details

Gus Caplan

commit sha 4c628bd6fa14b3b6b6ec3728462bbe07886b1972

fix lint

view details

push time in 5 days

PullRequestReviewEvent

push eventEB-Forks/web-platform-tests

ExE Boss

commit sha 0964780866b54087b63dc546cef2a170f751080c

Add Symbol.unscopables lexical scope test of compiled event handlers

view details

push time in 6 days

push eventEB-Forks/web-platform-tests

Phu Le

commit sha aeb10e75dcfe88cac2c5c9e390991f355637c7dc

Enable "Immersive-AR" session for OpenXR runtime The OpenXR runtime on Windows supports both "opaque" (WMR VR devices) and "additive" (Hololens). This change simply turns on support for Immersive-AR session according to the WebXR AR-module spec. The majority of the change is to let the runtime to decide about the blend_mode and interaction_mode instead of the current guessing logic at at the renderer layer. Bug: 1069350, 944936 Change-Id: Ie5f1b56857f9ca5357dbd1dde6585687773d0b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432759 Commit-Queue: Phu Le <phle@microsoft.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#816352}

view details

François Beaufort

commit sha 5a1a6bdae201c066aa9ea19ef3ac7028d5779ead

Improve code readibility

view details

François Beaufort

commit sha fa66ac17075eb2ec9586795e97cd3707804a8809

Update mock-imagecapture.js

view details

Joey Arhar

commit sha 7df82c491d82782e175e156b6afc3998cf7c0607

Ensure :active is removed on keyup for radios Bug: 693907 Change-Id: I33fd612193420e463c34693f875d8c7e0f25431e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466297 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816364}

view details

Sam Sneddon

commit sha c5d9edf492a3f13ec2eca3287c2db7cf5b452057

Clarify what version of Opera we're talking about here

view details

Sam Sneddon

commit sha cbbc48732b24557ed2b291c2de83e81790f35042

Use func.toString as the test name as a first fallback

view details

Philip Jägenstedt

commit sha 646c6ef06393905a9b33addb458792acbb25af06

Avoid harness error in font-face-range-order.html (#26089) There's current a harness error + timeout in Edge and Safari: https://wpt.fyi/results/css/css-fonts/font-face-range-order.html?run_id=703650002&run_id=695420001&run_id=717940003&run_id=710590002 With this change, the error will instead fail the test.

view details

Blink WPT Bot

commit sha b1a9ac15fef710b2388deee7c39ba848fb162469

Revert "Enable "Immersive-AR" session for OpenXR runtime" (#26092) This reverts commit 04ee981eb70e65020bbb0ab09c0f075946697269. Reason for revert: Breaking win-chrome See: https://ci.chromium.org/p/chrome/builders/ci/win-chrome/15856 Original change's description: > Enable "Immersive-AR" session for OpenXR runtime > > The OpenXR runtime on Windows supports both "opaque" (WMR VR devices) and "additive" (Hololens). This change simply turns on support for Immersive-AR session according to the WebXR AR-module spec. The majority of the change is to let the runtime to decide about the blend_mode and interaction_mode instead of the current guessing logic at at the renderer layer. > > Bug: 1069350, 944936 > Change-Id: Ie5f1b56857f9ca5357dbd1dde6585687773d0b56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432759 > Commit-Queue: Phu Le <phle@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816352} TBR=dcheng@chromium.org,bajones@chromium.org,rafael.cintron@microsoft.com,klausw@chromium.org,alcooper@chromium.org,phle@microsoft.com Change-Id: I0882e685902eb584ee2e417369a16697d21d1dfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069350 Bug: 944936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466997 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816382} Co-authored-by: Moe Ahmadi <mahmadi@chromium.org>

view details

Anders Hartvoll Ruud

commit sha c73950ec677680f896d022f498181ad17e54d944

[:is/:where] Drop pseudo_id when matching nested complex selectors If the pseudo_id is set, the SelectorChecker::MatchSelector call for each subselector will fail completely because the dynamic_pseudo of the inner result will not match context.pseudo_id. This check does not make sense to perform for nested complex selectors, since pseudo elements are not valid in nested complex selectors. Hence, we can just set the pseudo_id to kPseudoIdNone at the :is/:where boundary. This fixes a bug where selectors such as ":is(.a .b)::before" would never match. This CL also adds a basic test for pseudo classes. (Not related to the fix). Bug: 568705 Change-Id: I119265836ac0f1b77868537c7685690300c265fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466278 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#816500}

view details

Rob Buis

commit sha 9df1f873a7d7739579642b6826955cb981181330

[mathml] Fix mo-form.html The codepoint U+266D was used in this test and part of the MathML3 operator dictionary, however it is not part anymore of the MathML Core operator dictionary. Therefore pick a postfix operator that is part of the MathML Core operator dictionary. Bug: 6606 Change-Id: I253909a13a3d1ce34ca597342a706c05d35d3d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466243 Reviewed-by: Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#816531}

view details

Sam Sneddon

commit sha ef6faf67e9e84bf20bd24b8bd2570c6f0b68dcd7

Handle empty arrow functions when determining name in testharness.js (#26100)

view details

Ian Kilpatrick

commit sha 4aa1136cec103dff3c716c93b8418e43a48697fd

[layout] Fix -webkit-line-clamp with text-overflow: ellipsis Previously we'd apply line truncation when either -webkit-line-clamp was active, *or* if "text-overflow: ellipsis" was active. This patch disables the "text-overflow: ellipsis" branch when we are within a -webkit-line-clamp context. Bug: 1134483 Change-Id: I5ceb40732bd512e5eb8dc59365e10c4fdd4cf15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447610 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816554}

view details

Ian Kilpatrick

commit sha c808aa3d15a42648d8b25a838024813990959e37

[layout] Fix self-collapsing end-margins contributing to overflow. Previously we just took the end margin-strut, and used this for the scrollable-overflow. This was incorrect. As the end margin-strut is used for positioning self-collapsing blocks we ended up "double counting" these margins. This patch uses the "final" margin-strut, and subtracts the self-collapsing end margin-strut to correctly determine the block-end margin which contributes to scrollable-overflow. Bug: 1136403 Change-Id: I7d0d0fe801948c3ce818719f28f1a7c795a7ec56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466379 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816586}

view details

Oriol Brufau

commit sha 5b6e508729caf23ab70c4db695315aef951c3d50

Avoid DCHECK failure when reusing space and newline with white-space:pre Consider this code: <style>i { white-space: pre-line }</style> X<i> </i><i>&#10;</i> The first time that NGInlineNode::CollectInlines runs, the text data will be "X", then "X ", and then AppendForcedBreakCollapseWhitespace will remove the trailing whitespace before inserting the forced break, so we get "X\n". But if some text is appended dynamically, CollectInlines will run again, and this time it will try to reuse existing items in AppendTextReusing. Before this patch, this would produce "X \n", which would trigger a DCHECK failure in ComputeOffsetMapping because it's a different string. Therefore, this patch prevents AppendTextReusing from reusing existing items if the last item to collapse with ends with collapsible spaces and the first item to reuse has 'white-space:pre' and begins with a newline. Bug: 1136688 TEST=external/wpt/css/css-text/white-space/pre-line-with-space-and-newline.html Change-Id: I0ff71b125b66256ec3b5c263605c3c116f9ac55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466279 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#816641}

view details

Nicolás Peña Moreno

commit sha 0cf5a3325b226f57b14bcbd3043ff3d343b9c39b

[Longtasks] Fix buffering before observer When we shipped longtasks with buffered flag, we forgot to remove a check that would prevent longtask creation when there's no observer. This CL fixes this and adds a test for this case. It also moves the UseCounter to the observe() method. Bug: 1131385 Change-Id: I2911b9ab044db7394bcf64f64b1e599959cbdc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463594 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#816664}

view details

Xianzhu Wang

commit sha 455dbf51d13331ae38944103fe65b68684f03a0f

Don't paint outline in composited foreground layer Previously when there is composited foreground layer, the outline was painted on both the main graphics layer and the foreground layer. Change-Id: I9c0bcf14ce4acb1f41a732e480b9c1a4126f69bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466620 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816669}

view details

Brandon Jones

commit sha abe80e0da5e73e41b65a6987eac3daa9081ed168

Reland "Use a single, consistent path to update stage parameters." This is a reland of e94960c9ac81f36bfeba2bdebe2c2714933a92da Original change's description: > Use a single, consistent path to update stage parameters. > > Removes stage_parameters from VRDisplayInfo and updates the XR frame > request loop to exchange an stage_parameters_id to indicate what version > of the parameters the session has so that only updates need to be sent. > > Part of an ongoing process to remove VRDisplayInfo entirely. > > Bug: 998146 > Change-Id: I6f41dc2426b529694903d1e46cdadc16841b2b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460976 > Commit-Queue: Brandon Jones <bajones@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815903} Bug: 998146 Change-Id: I433914ca4db3adfa939032946a2095e03c13eed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466932 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816699}

view details

Phu Le

commit sha 304bef15849c6bc8fbaf8aabb83f6ef78186f7bf

Enable "Immersive-AR" session for OpenXR runtime The OpenXR runtime on Windows supports both "opaque" (WMR VR devices) and "additive" (Hololens). This change simply turns on support for Immersive-AR session according to the WebXR AR-module spec. The majority of the change is to let the runtime to decide about the blend_mode and interaction_mode instead of the current guessing logic at at the renderer layer. Bug: 1069350, 944936 Change-Id: I26bfd02c17405299b2880045326d23fc880ea069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468358 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Phu Le <phle@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816790}

view details

Chris Dumez

commit sha 5fcc1c2184a256ba8f684f4b12c6ec5543e62313

Fix duplicate test name in webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-constructor-options.https.html (#26107) Fix a copy/paste error that led to a duplicate test name. Co-authored-by: Chris Dumez <cdumez@apple.com>

view details

Majid Valipour

commit sha 1b0f824f9ef09f035d2549ab4f6c92131ba62c0f

Rename Sms{Service,Receiver} to WebOTPService The old name does not reflect the changes made to the feature name and specification. No change in functionality is expected. The following changes were made using grep & sed. - rename files - [^_]+sms_service->webotp_service - [^_]+sms_receiver->webotp_service - {SMS,Sms}Receiver->WebOTPService - SmsService->WebOTPService - SMS Service->WebOTP Service The only manual change were: - update some outdated documentation in webotp_service.mojom - SMSReceiver -> WebOTP for flags ## Aside Getting a pre-submit warning which seems incorrect as we have not changes the UMA histogram name and it exists :-? ``` ** Presubmit Warnings ** Some UMA_HISTOGRAM lines have been modified and the associated histogram name has no match in either tools/metrics/histograms/histograms.xml or the modifications of it: [components/browser_ui/sms/android/java/src/org/chromium/components/browser_ui/sms/WebOTPServiceUma.java:35] Blink.Sms.Receive.TimeCancelOnKeyboardDismissal ``` Bug:1117238 Change-Id: I369f8631450b0a539b3c2afbf8d4ed87ce853a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424707 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Sam Goto <goto@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816889}

view details

push time in 6 days

pull request commentwhatwg/html

Set withEnvironment of event handler scopes correctly

Note that the scopes are nested and the outermost object scope has to extend from the global environment scope.

annevk

comment created time in 6 days

push eventExE-Boss/node

ExE Boss

commit sha c980bd82a1b39207436723f8618cb46fa4d6457f

fixup! path: add `path/posix` and `path/win32` alias modules Co-authored-by: Rich Trott <rtrott@gmail.com>

view details

push time in 6 days

push eventEB-Forks/node

ExE Boss

commit sha 81d2bed976a5f14cf69bc6face736b7c5c6ddc43

fixup! util: add `util/types` alias module Co-authored-by: Rich Trott <rtrott@gmail.com>

view details

push time in 6 days

push eventEB-Forks/node

ExE Boss

commit sha 4635b04b93c8534424f656bdbb63f82c2882a7e8

fixup! path: add `path/posix` and `path/win32` alias modules Co-authored-by: Rich Trott <rtrott@gmail.com>

view details

push time in 6 days

push eventEB-Forks/engine262

ExE Boss

commit sha a806b4a40721f56bcb2ea0daa52d28579145cab9

Convert built–in iterators to use abstract closures

view details

push time in 6 days

Pull request review commentnodejs/node

deps: Experiments with Corepack

+# Corepack++<!-- introduced_in=REPLACEME -->+<!-- type=misc -->++> Stability: 1 - Experimental

This needs an extra newline, otherwise the following paragraph gets merged into the blockquote.

> Stability: 1 - Experimental

arcanis

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Properties of Map Instances</h1>       <h1>Map Iterator Objects</h1>       <p>A Map Iterator is an object, that represents a specific iteration over some specific Map instance object. There is not a named constructor for Map Iterator objects. Instead, map iterator objects are created by calling certain methods of Map instance objects.</p> -      <emu-clause id="sec-createmapiterator" aoid="CreateMapIterator">+      <emu-clause id="sec-createmapiterator" aoid="CreateMapIterator" oldids="sec-properties-of-map-iterator-instances,table-50,table-internal-slots-of-map-iterator-instances">         <h1>CreateMapIterator ( _map_, _kind_ )</h1>         <p>The abstract operation CreateMapIterator takes arguments _map_ and _kind_. This operation is used to create iterator objects for Map methods that return such iterators. It performs the following steps when called:</p>         <emu-alg>           1. Perform ? RequireInternalSlot(_map_, [[MapData]]).
          1. Assert: _kind_ is ~key+value~, ~key~, or ~value~.
          1. Perform ? RequireInternalSlot(_map_, [[MapData]]).
Jack-Works

comment created time in 6 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Properties of Set Instances</h1>       <h1>Set Iterator Objects</h1>       <p>A Set Iterator is an ordinary object, with the structure defined below, that represents a specific iteration over some specific Set instance object. There is not a named constructor for Set Iterator objects. Instead, set iterator objects are created by calling certain methods of Set instance objects.</p> -      <emu-clause id="sec-createsetiterator" aoid="CreateSetIterator">+      <emu-clause id="sec-createsetiterator" aoid="CreateSetIterator" oldids="sec-properties-of-set-iterator-instances,table-51,table-internal-slots-of-set-iterator-instances">         <h1>CreateSetIterator ( _set_, _kind_ )</h1>         <p>The abstract operation CreateSetIterator takes arguments _set_ and _kind_. This operation is used to create iterator objects for Set methods that return such iterators. It performs the following steps when called:</p>         <emu-alg>           1. Perform ? RequireInternalSlot(_set_, [[SetData]]).
          1. Assert: _kind_ is ~key+value~, ~key~, or ~value~.
          1. Perform ? RequireInternalSlot(_set_, [[SetData]]).
Jack-Works

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentnodejs/node

path: add `path/posix` and `path/win32` alias modules

@jasnell @MylesBorins @Trott @targos @BridgeAR

It’s only a few days left until v15.0.0 ships, and I’d like to get this merged before then.

ExE-Boss

comment created time in 6 days

pull request commentnodejs/node

util: add `util/types` alias module

@jasnell @MylesBorins @Trott @targos @BridgeAR

It’s only a few days left until v15.0.0 ships, and I’d like to get this merged before then.

ExE-Boss

comment created time in 6 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>CreateIterResultObject ( _value_, _done_ )</h1>       </emu-alg>     </emu-clause> -    <emu-clause id="sec-createlistiteratorRecord" oldids="sec-createlistiterator" aoid="CreateListIteratorRecord">+    <emu-clause id="sec-createlistiteratorRecord" oldids="sec-createlistiterator,sec-listiteratornext-functions,sec-listiterator-next" aoid="CreateListIteratorRecord">       <h1>CreateListIteratorRecord ( _list_ )</h1>       <p>The abstract operation CreateListIteratorRecord takes argument _list_. It creates an Iterator (<emu-xref href="#sec-iterator-interface"></emu-xref>) object record whose next method returns the successive elements of _list_. It performs the following steps when called:</p>       <emu-alg>-        1. Let _iterator_ be ! OrdinaryObjectCreate(%IteratorPrototype%, &laquo; [[IteratedList]], [[ListNextIndex]] &raquo;).-        1. Set _iterator_.[[IteratedList]] to _list_.-        1. Set _iterator_.[[ListNextIndex]] to 0.-        1. Let _steps_ be the algorithm steps defined in <emu-xref href="#sec-listiteratornext-functions" title></emu-xref>.-        1. Let _next_ be ! CreateBuiltinFunction(_steps_, &laquo; &raquo;).-        1. Return Record { [[Iterator]]: _iterator_, [[NextMethod]]: _next_, [[Done]]: *false* }.+        1. Let _closure_ be a new Abstract Closure with no parameters that captures _list_ and performs the following steps when called:+          1. For each element _E_ of _list_, do+            1. Perform ? Yield(_E_).+          1. Return *undefined*.+        1. Let _iterator_ be ! CreateIteratorFromClosure(_closure_, ~empty~, %IteratorPrototype%).+        1. Return Record { [[Iterator]]: _iterator_, [[NextMethod]]: %Generator.prototype.next%, [[Done]]: *false* }.

The generator intrinsics were renamed in https://github.com/tc39/ecma262/pull/2065:

        1. Return Record { [[Iterator]]: _iterator_, [[NextMethod]]: %GeneratorFunction.prototype.prototype.next%, [[Done]]: *false* }.
Jack-Works

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened engine262/engine262

Implement “Yield” and “Create(Async)IteratorFromClosure”

Spec: https://github.com/tc39/ecma262/pull/2045

To do:

  • [ ] Convert built‑in iterators to use CreateIteratorFromClosure and CreateAsyncIteratorFromClosure.
+170 -47

0 comment

6 changed files

pr created time in 7 days

create barnchEB-Forks/engine262

branch : feat/implement-abstract-closure-iterators

created branch time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>               1. Let _done_ be ? IteratorComplete(_innerResult_).               1. If _done_ is *true*, then                 1. Return ? IteratorValue(_innerResult_).-              1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-              1. Else, set _received_ to GeneratorYield(_innerResult_).+              1. If _generatorKind_ is ~async~, then set _received_ to ? AsyncGeneratorYield(? IteratorValue(_innerResult_)).+              1. Else, set _received_ to ? GeneratorYield(_innerResult_).
              1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).
              1. Else, set _received_ to GeneratorYield(_innerResult_).
Jack-Works

comment created time in 7 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. If _done_ is *true*, then               1. Let _value_ be ? IteratorValue(_innerReturnResult_).               1. Return Completion { [[Type]]: ~return~, [[Value]]: _value_, [[Target]]: ~empty~ }.-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).-            1. Else, set _received_ to GeneratorYield(_innerReturnResult_).+            1. If _generatorKind_ is ~async~, then set _received_ to ? AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).+            1. Else, set _received_ to ? GeneratorYield(_innerReturnResult_).
            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).
            1. Else, set _received_ to GeneratorYield(_innerReturnResult_).
Jack-Works

comment created time in 7 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. Let _done_ be ? IteratorComplete(_innerResult_).             1. If _done_ is *true*, then               1. Return ? IteratorValue(_innerResult_).-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-            1. Else, set _received_ to GeneratorYield(_innerResult_).+            1. If _generatorKind_ is ~async~, then set _received_ to ? AsyncGeneratorYield(? IteratorValue(_innerResult_)).+            1. Else, set _received_ to ? GeneratorYield(_innerResult_).
            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).
            1. Else, set _received_ to GeneratorYield(_innerResult_).
Jack-Works

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventEB-Forks/engine262

Rick Waldron

commit sha 03d8ded05f90eb963c1df1c9f0214dd1cb8a689f

Typo: Throe => Throw

view details

Gus Caplan

commit sha 819ffd93d310e4102b8c3b102f15c84a6d6f4fb6

update test262, add __proto__ stuff

view details

Gus Caplan

commit sha 8f4fbaa992e4d3a49c926f70fc042cea0d3ebded

fix package name

view details

Gus Caplan

commit sha d81af93eabdd99ae85e7598401bb54b4f05759c0

update test262

view details

push time in 7 days

push eventEB-Forks/DefinitelyTyped

Google API Typings Generator

commit sha 22350b19bd19eb3d4e8f0a52f156a33530291a66

🤖 Merge PR #48656 [gapi.client.drive] automatic update by @google-api-typings-generator Co-authored-by: Maxim Mazurok <maxim@mazurok.com>

view details

nikithauc

commit sha 2d3abfdffeec9abf81fd0f0fdaef85c2dcc3db21

🤖 Merge PR #48636 Microsoft Graph- Version 1.23 by @nikithauc * Adding updates for version 1.20 * microsoftgraph updating for v 1.21 * Updating microsoft-graph version 1.22 * Version 1.23

view details

Google API Typings Generator

commit sha 9d8affaae2a728663a937996c49f5d868a84036c

🤖 Merge PR #48577 [gapi.client.analytics] automatic update by @google-api-typings-generator Co-authored-by: Maxim Mazurok <maxim@mazurok.com>

view details

Gaurav Sharma

commit sha 18c167ca7a558ef1eee8b940c47dbfc533a3a464

🤖 Merge PR #48584 update project link of expressjs/cors by @gtpan77

view details

Shinigami

commit sha a212c2779365d4d8e951811884398fedc7d0ae38

🤖 Merge PR #47626 [@types/prettier] Rework Plugin.options by @Shinigami92 * Start defining updated option declarations * Remove old definitions * Improve * Add parentParser and embeddedInHtml

view details

Mark Hughes

commit sha b8837fa59a2bcce168d3d455f61a993ac09bee31

🤖 Merge PR #48474 fix(@wordpress/components): add missing clientId edit prop by @markhughes This is critical for more complex blocks that need to reference its parent(s) and children.

view details

Jeremy Hull

commit sha 628ac2e4e2b5d6800992d1472e5bde810c55f084

🤖 Merge PR #47480 [koa-joi-router] Add router to Router interface by @sourrust * Add router to Router interface * Add test for adding OPTIONS method to routes * Update author list in file definition

view details

Christian Alfoni

commit sha 01259eb42a4357b4586f6c922d254d26ef9c977c

[Styled-Components] Increase PERF 10x (#46510) * Increase PERF 10x Working on an improvement experience of typing with "stitches" I noticed that typing `keyof JSX.IntrinsicElements` is insanely costly. By rather using `string` through the typing and rather `extend` at the very and we gain an insane performance boost. The only downside to this is that the "as" prop is now typed as a string. But, I would argue that we do not need to type it as anything else. Since we `extend` it at the end you will get an error if using an invalid HTML element anyways. And the performance boost is such a huge improvement. * Fix missing check * Try to improve memory consumption * Missing semicolon Co-authored-by: Orta <git@orta.io>

view details

Dave Beshero

commit sha 07adc80e19049f61598e36e1d6e96d4b6b01fa2d

🤖 Merge PR #48596 [carbon-components-react] add missing light property to Search by @hankthewhale

view details

Ingvar Stepanyan

commit sha a05333cadcc62b79123e62eb1b2b75370053ee72

🤖 Merge PR #48618 Minor DX improvements to wicg-file-system-access typings by @RReverser * Minor DX improvements to FS Access typings - Mark Chromium <=85 properties and APIs as @deprecated with hints on what to switch to (this looks particularly nicely in VSCode after recent updates). - Hide BaseFileSystemHandle helper from users (this is an internal typings implementation detail). - Expose FileSystemHandle as a `const` instead. This allows it to be simultaneously a type union as well as a proper global class (fixes an error for polyfills, where previously TS would complain that a type is accessed as a variable). * Revert version change Technically, this is just a patch update as no API changes are here.

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 6a1c6a5567fa177396fa802b2367ec34e1028eea

🤖 Merge PR #47139 update(imagemin-webp): v6 update and minor tweaks by @peterblazejewicz - remove 'buffer' options, is not an option - it's just reference in the README about the outcome input argument type (Buffer) - JSDoc comments - tests amended - v6 bump - maintainer added https://github.com/imagemin/imagemin-webp/compare/v5.1.0...v6.0.0 Thanks!

view details

Tim Roediger

commit sha b8e687a1a1ea0ddaf3b809a988983b913cbe2599

🤖 Merge PR #48565 Update express-ntlm by @superdweebie * Update express-ntlm Change `domaincontroller` to match docs. See: `https://github.com/einfallstoll/express-ntlm` * Update express-ntlm domaincontroler option updated to union type, using ReadonlyArray<string>

view details

Flaryer

commit sha a4c0f44d4c78c8d718d38444ba867146a51f9595

🤖 Merge PR #48409 Update ioredis, add bzpopmin/max and hstrlen by @Flaryer * Update index.d.ts Add bzpopmin, bzpopmax, hstrlen, optimize the interface of the function with promise return value in the overload interfaces. * Update ioredis-tests.ts update test.ts * Update index.d.ts remove some repeated lines. * Update index.d.ts update version * Update index.d.ts * Update index.d.ts update version * Update index.d.ts oops, the version was changed incorrectly

view details

nico-bellante

commit sha a9e7ca81697abaff687dcfd8f775ea01a1f2b0f2

🤖 Merge PR #48321 Fixes typo in comment by @nico-bellante

view details

Max Belsky

commit sha 397e42c380fa85f93e9ba0dd2f95de36396b7542

[react] Mark script's charSet attribute as deprecated (#48581)

view details

Emil Gedda

commit sha 21bf6be21a1a0471c382bd7965e349b9c55ce3a3

🤖 Merge PR #48691 [leaflet] Add typing for constant CRS.EPSG900913 by @EmilGedda

view details

Jozef Sovcik

commit sha 79cefce6c3f92f09bd20bbdc8838a83793b74cbb

🤖 Merge PR #48098 Definitions for Mongoose SchemaType properties by @sovcik * adding definitions for public SchemaType properties #48094 * Adding tests #48094 * fixing trailing spaces

view details

Sam Welek

commit sha 3e84560ca20e6ddc7e86d6841eba317aeddf1aa7

🤖 Merge PR #48693 [vis] Updating EdgeOptions to match current documentation, reusing Locales interface, Linting by @tiberiushunter * Updating EdgeOptions, Locales and Configure types -Transferring changes from Documentation and vis-network Types * Adding tests and linting

view details

Tiger Oakes

commit sha 6070090e9c20a30c6629e8fbebf67bb85ef65d68

🤖 Merge PR #48603 fs-extra: Add extra allowed types by @NotWoods * Use PathLike type in fs-extra Allows for URLs to be passed to methods. PathLike is exported by fs in Node v10 * Use Mode type in fs-extra * Add TypedArray/DataView parameters to read/write * Add withFileTypes to readdir * Add to fs-extra authors * Fix lint issues

view details

Skyler Kehren

commit sha 7f005fddc26f940dda2aa25663412d6a90ddc6e6

🤖 Merge PR #48142 [screeps] Add *visuals import and export, fixes by @pyrodogg * typed-screeps release 3.2.1 New game content and community corrections - Adds `import` and `export` to `RoomVisual` and `MapVisual` - Adds `RESOURCE_ENERGY` to `COMMODITIES` record. - Fixes signature of `RoomPosition.findClosestByPath()` * Add InterShardResourceConstant, fix MarketResourceConstant

view details

push time in 7 days

issue openedwhatwg/html

Web Reality: The spec requires that unscopable properties be included in the compiled event handler lexical scope, but browsers omit them

Discovered while implementing https://github.com/web-platform-tests/wpt/pull/26091:

Step 9 of get the current value of the event handler initialises the ObjectEnvironment records without setting the withEnvironment flag to true, which is required to make the ObjectEnvironment respect Symbol.unscopables.

As such, inline event handlers are required to include unscopable properties.

See also:


/cc @zcorpan @foolip @domenic @annevk

created time in 7 days

push eventEB-Forks/DefinitelyTyped

Piotr Błażejewicz (Peter Blazejewicz)

commit sha f03fd4b23110cbacb79c6e14c57d51262222b45e

feat(vegas): new definition (#47552) Definition file for Vegas jQuery plugin: - definition file - tests https://github.com/jaysalvat/vegas http://vegas.jaysalvat.com/documentation/setup/ Thanks!

view details

Linn Dahlgren

commit sha 35d8a9f149de4fdb321120ae101d4608e12f3672

New definitions for nat-upnp (#47551) * Add nat-upnp typings * Fixed index.d.ts header * Removed accidental docstring meant to be source comment * Apply suggestions from code review Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com> * Add test cases for nat-upnp optional callbacks missing * Fix linter errors Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 8f51ec40ba30f3ae44d4d899f2c805a7abaa04ee

feat(image-to-base64): new definition (#47581) Small util to convert url/path based images to bas64 strings - definition - tests https://github.com/renanbastos93/image-to-base64 Thanks!

view details

Lukas Planz

commit sha 89c78c18e456e62317e0a326a48b6cae211b42de

[nodes7] Add type definitions (#47564) * Added type definitions for nodes7 * Fix error

view details

czgu

commit sha ba87a83b35b6f4b9e28e82ae8b1dd652bdbea385

[gestalt-datepicker] Add type definitions (#47570) * [gestalt-datepicker] Add type definitions * Change export to default to match * update project url

view details

Anton Ratnikov

commit sha 8eb86bfad44ce65114023548c25563e0ee54d23e

fix: add static methods for Airtable (#46723)

view details

Gavin Rehkemper

commit sha 337878ad524b4208f4394f37aa63749e9a532501

🤖 Merge PR #47555 add types for @terraformer/arcgis by @gavinr * add @terraformer/arcgis types * fix tslint * Update types/terraformer__arcgis/index.d.ts Co-authored-by: Linn Dahlgren <admin@opposite.biz> * Update index.d.ts Co-authored-by: Linn Dahlgren <admin@opposite.biz>

view details

Rick Kirkham

commit sha a65f7cba4823a1c4bf30f56c55e3dde51be33237

office-js, office-js-preview, fix link (#47587)

view details

Seržants

commit sha 7aadebe6bf410f589adec161e05f847568e574ae

🤖 Merge PR #47566 Added preventsDisplaySleepDuringVideoPlayback to react-native-video p… by @Serzhs * Added preventsDisplaySleepDuringVideoPlayback to react-native-video props * Added preventsDisplaySleepDuringVideoPlayback to react-native-video test

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 71edd1752d07111dff93a2c81deb2a4c41dccb0e

🤖 Merge PR #47518 update(terser-webpack-plugin): `minimizerOptions` option by @peterblazejewicz - `minimizerOptions` added - test amended - cleanup https://github.com/webpack-contrib/terser-webpack-plugin/pull/311 Thanks!

view details

Jeff King

commit sha 4413f5e64588bb5937d1f40dd7957de84a3fcc75

Upgrade sarif to 2.1.0-rtm.5 (#47593)

view details

Jack Bates

commit sha e30322120f46a0735f049e9687742acb420efe6f

[es6-promisify] Remove superfluous /// <reference types="node" /> (#46738)

view details

Alex Jerabek

commit sha 20cc822b0cad5f8c2c89c4c98b592a746e2ccec9

[office-js, office-js-preview] ExcelAPI 1.12 Updates (#47572) * Excel release * Excel release * Excel preview * Feedback

view details

Oliver Salzburg

commit sha 404f9ce1f90633489715c8fd5708ac5df2ce6ca5

Fix integration with koa-passport (#46718)

view details

Nathan Shively-Sanders

commit sha 38c8574c828cc2ee807e6610426dd12835a9015c

Add ts3.6 references to node v10 (#47601) * Add ts3.6 references to node v10 This may need to be added to other node versions as well. Fixes #47239 * add test case

view details

sejoong_de_jang

commit sha d9cb54e3c93d8a73c1af616a9737e2cb0ba9c6c4

Add the 'tizen-tv-webapis' module (#45812) * Add the tizen-tv-webapis * Remove the comment in package.json * Add the files * Resolve the file names * Refine indendation with the prettier * Set tslint exception rule in each files * Convert the @deprecated tag to @note * Resolve the 'no-redundant-jsdoc-2' * Modify the package name and version * Modify the version * Remove the orinazation * Modify the npm package name * Register the npm-name: false rule * Remove the tab * Remove the useless package * Move files to the project root * Remove delcare in each files, replace to export * Change the npm path * Remove the 'npm-naming' rule

view details

Jack Bates

commit sha ef49ffb4c80e2b4dc1eb84d6faba47478cd6f3b1

[node] Put newest versions of files in the root (#47576)

view details

Google API Typings Generator

commit sha 4e302d63e9bcb3f041cc05c8f228a66731dc2d0e

🤖 Merge PR #47604 [gapi.client.classroom] automatic update by @google-api-typings-generator Co-authored-by: Maxim Mazurok <maxim@mazurok.com>

view details

Nathan Shively-Sanders

commit sha 3a947ccb1bbbab9dc909130db46ace0e876266b7

Restore deleted jsdom tests (#47600) * Restore deleted jsdom tests Deleted by mistake in the move in #47200 * use approved directory structure

view details

Nathan Shively-Sanders

commit sha 7994d590c308a6c414ab34bc34f902760f3c3534

web-animations-js: remove ts3.1 support (#47608) TS 3.1 is no longer supported on Definitely Typed.

view details

push time in 7 days

startedLiCybora/NanoCore2

started time in 8 days

pull request commenttc39/ecma262

Normative: Re-resolve unresolvable references on the global in PutValue.

I’d rather if this were Annex B‑only.

syg

comment created time in 9 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 node_modules/ out/ test*.js +# Error logs+npm-debug.log

This should be done in its own PR.

Jack-Works

comment created time in 9 days

PullRequestReviewEvent

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. Let _done_ be ? IteratorComplete(_innerResult_).             1. If _done_ is *true*, then               1. Return ? IteratorValue(_innerResult_).-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-            1. Else, set _received_ to GeneratorYield(_innerResult_).+            1. NOTE: Do not use Yield here cause Yield will wrap _innerResult_ by IteratorValue
            1. NOTE: Do not use Yield here because Yield will wrap _innerResult_ using CreateIteratorResultObject.
Jack-Works

comment created time in 9 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>               1. Let _done_ be ? IteratorComplete(_innerResult_).               1. If _done_ is *true*, then                 1. Return ? IteratorValue(_innerResult_).-              1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-              1. Else, set _received_ to GeneratorYield(_innerResult_).+              1. NOTE: Do not use Yield here cause Yield will wrap _innerResult_ by IteratorValue
              1. NOTE: Do not use Yield here because Yield will wrap _innerResult_ using CreateIteratorResultObject.
Jack-Works

comment created time in 9 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. If _done_ is *true*, then               1. Let _value_ be ? IteratorValue(_innerReturnResult_).               1. Return Completion { [[Type]]: ~return~, [[Value]]: _value_, [[Target]]: ~empty~ }.-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).-            1. Else, set _received_ to GeneratorYield(_innerReturnResult_).+            1. NOTE: Do not use Yield here cause Yield will wrap _innerResult_ by IteratorValue
            1. NOTE: Do not use Yield here because Yield will wrap _innerResult_ using CreateIteratorResultObject.
Jack-Works

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. Let _done_ be ? IteratorComplete(_innerResult_).             1. If _done_ is *true*, then               1. Return ? IteratorValue(_innerResult_).-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-            1. Else, set _received_ to GeneratorYield(_innerResult_).+            1. If _generatorKind_ is ~async~, then set _received_ to ? Yield(? IteratorValue(_innerResult_)).+            1. Else, set _received_ to ? Yield(_innerResult_).
            1. If _generatorKind_ is ~async~, then set _received_ to ? AsyncGeneratorYield(? IteratorValue(_innerResult_)).
            1. Else, set _received_ to ? GeneratorYield(_innerResult_).
Jack-Works

comment created time in 9 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. If _done_ is *true*, then               1. Let _value_ be ? IteratorValue(_innerReturnResult_).               1. Return Completion { [[Type]]: ~return~, [[Value]]: _value_, [[Target]]: ~empty~ }.-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).-            1. Else, set _received_ to GeneratorYield(_innerReturnResult_).+            1. If _generatorKind_ is ~async~, then set _received_ to ? Yield(? IteratorValue(_innerReturnResult_)).+            1. Else, set _received_ to ? Yield(_innerReturnResult_).
            1. If _generatorKind_ is ~async~, then set _received_ to ? AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).
            1. Else, set _received_ to ? GeneratorYield(_innerReturnResult_).
Jack-Works

comment created time in 9 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>               1. Let _done_ be ? IteratorComplete(_innerResult_).               1. If _done_ is *true*, then                 1. Return ? IteratorValue(_innerResult_).-              1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-              1. Else, set _received_ to GeneratorYield(_innerResult_).+              1. If _generatorKind_ is ~async~, then set _received_ to ? Yield(? IteratorValue(_innerResult_)).+              1. Else, set _received_ to ? Yield(_innerResult_).
              1. If _generatorKind_ is ~async~, then set _received_ to ? AsyncGeneratorYield(? IteratorValue(_innerResult_)).
              1. Else, set _received_ to ? GeneratorYield(_innerResult_).
Jack-Works

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentbabel/babel

[RFC] Improve flow typing

MichaReiser

comment created time in 9 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>               1. Let _done_ be ? IteratorComplete(_innerResult_).               1. If _done_ is *true*, then                 1. Return ? IteratorValue(_innerResult_).-              1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-              1. Else, set _received_ to GeneratorYield(_innerResult_).+              1. Set _received_ to ? Yield(IteratorValue(_innerResult_)).

ditto

Jack-Works

comment created time in 10 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. Let _done_ be ? IteratorComplete(_innerResult_).             1. If _done_ is *true*, then               1. Return ? IteratorValue(_innerResult_).-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerResult_)).-            1. Else, set _received_ to GeneratorYield(_innerResult_).+            1. Set _received_ to ? Yield(IteratorValue(_innerResult_)).

This change causes the yielded inner result to no longer be passed through with synchronous generators:

const result = {
	done: false,
	value: 'foo',
};

const iterable = {
	[Symbol.iterator]() {
		return iterable;
	},
	next() {
		return result;
	},
};

const gen = (function* () {
	return yield* iterable;
})();

assert.sameValue(gen.next(), result);
Jack-Works

comment created time in 10 days

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>Runtime Semantics: Evaluation</h1>             1. If _done_ is *true*, then               1. Let _value_ be ? IteratorValue(_innerReturnResult_).               1. Return Completion { [[Type]]: ~return~, [[Value]]: _value_, [[Target]]: ~empty~ }.-            1. If _generatorKind_ is ~async~, then set _received_ to AsyncGeneratorYield(? IteratorValue(_innerReturnResult_)).-            1. Else, set _received_ to GeneratorYield(_innerReturnResult_).+            1. Set _received_ to ? Yield(IteratorValue(_innerReturnResult_)).

ditto

Jack-Works

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttc39/ecma262

Editorial: Add Yield, CreateIteratorFromClosure, CreateAsyncIteratorFromClosure abs op.

 <h1>GeneratorStart ( _generator_, _generatorBody_ )</h1>       </emu-clause>        <emu-clause id="sec-generatorvalidate" aoid="GeneratorValidate">-        <h1>GeneratorValidate ( _generator_ )</h1>-        <p>The abstract operation GeneratorValidate takes argument _generator_. It performs the following steps when called:</p>+        <h1>GeneratorValidate ( _generator_, _generatorBrand_ )</h1>+        <p>The abstract operation GeneratorValidate takes arguments _generator_ and _generatorBrand_. It performs the following steps when called:</p>         <emu-alg>           1. Perform ? RequireInternalSlot(_generator_, [[GeneratorState]]).+          1. Perform ? RequireInternalSlot(_generator_, [[GeneratorBrand]]).+          1. If _generator_.[[GeneratorBrand]] is not equal to _generatorBrand_, throw a *TypeError* exception.
          1. If ! SameValue(_generator_.[[GeneratorBrand]], _generatorBrand_) is *false*, throw a *TypeError* exception.
Jack-Works

comment created time in 10 days

more