profile
viewpoint
Erwan de Lépinau ErwanDL Feedly Paris ML Engineer at Feedly and CS student at CentraleSupélec. Interested by anything and everything in the software engineering world :)

ErwanDL/YATDA 2

A simple and effective productivity tool

Salto-Alto/vuourt 2

An application that allows you to easily sue your friends !

DeciusAntiochus/ad-covia 1

Ce projet a pour but d'établir des autodiagnostics du Covid-19 par intelligence artificielle.

ErwanDL/cpp-raytracer 1

Implementation of a raytracing renderer in C++

ErwanDL/music-genre-classification 1

Automatic Music Genre Classification using Machine Learning

ErwanDL/aoc2019 0

My solutions for the 2019 Advent of Code

ErwanDL/icospace 0

Procedural planet generation with Unity

ErwanDL/mypy 0

Optional static typing for Python 3 and 2 (PEP 484)

ErwanDL/rift-fighters 0

League Fighters is a versus-fighting, fan-made game based on the League of Legends universe and characters. It uses Unity3d as the game engine.

ErwanDL/sacrebleu 0

Reference BLEU implementation that auto-downloads test sets and reports a version string to facilitate cross-lab comparisons

issue commentmicrosoft/pylance-release

Sort imports is severely bugged with Pylance language server

That would be great ! Do you think this will be a hotfix or should we wait the next planned release ?

ErwanDL

comment created time in 5 days

issue commentmicrosoft/pylance-release

Sort imports is severely bugged with Pylance language server

I have not seen any setting or bullet point in Pylance's features list about the import sorter ; maybe it could be helpful clarifying that it exists, and also adding an option to enable/disable it and use the Python extension's one instead ? 😃 That would be awesome !

ErwanDL

comment created time in 5 days

issue commentmicrosoft/pylance-release

Sort imports is severely bugged with Pylance language server

@jakebailey Yes I have isort activated in the Python extension (it's the default import sorter used by the extension I believe). Does Pylance do its own import sorting as well ? Because in the logs I pasted, it's only isort being called twice :

This is the command being called twice at a time in the logs :

> ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
cwd: ~/Documents/dev/other_test
> ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
cwd: ~/Documents/dev/other_test

And this is the sortImports.py file that is called, which in turns calls isort :

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

import io
import os
import os.path
import sys

isort_path = os.path.join(os.path.dirname(__file__), "lib", "python")
sys.path.insert(0, isort_path)

# Work around stdin buffering issues on windows (https://bugs.python.org/issue40540)
# caused in part by isort seeking within the stdin stream by replacing the
# stream with something which is definitely seekable.
try:
    # python 3
    stdin = sys.stdin.buffer
except AttributeError:
    # python 2
    stdin = sys.stdin

sys.stdin = io.BytesIO(stdin.read())
# End workaround

import isort.main

isort.main.main()
ErwanDL

comment created time in 5 days

issue openedmicrosoft/pylance-release

Sort imports is severely bugged with Pylance language server

Environment data

  • VS Code version: 1.46.1
  • Extension version (available under the Extensions sidebar): 2020.6.91350
  • OS and version: macOS 10.14.6
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7
  • Relevant/affected Python-related VS Code extensions and their versions: Pylance 2020.6.1
  • Value of the python.languageServer setting: "Pylance"

Expected behaviour

"Sort imports on save" functionality works correctly.

Actual behaviour

When using the new Pylance language server (which is, apart from this bug, absolutely incredible, thanks a lot !), the "sort imports" functionality is bugged, doesn't respect the sortImports settings of VSCode, and produces invalid Python code. I have looked at other similar issues (ex : https://github.com/microsoft/vscode/issues/83586), but an important difference is that the issue I describe here is present even when there is no formatter (other than the import sorter) activated for Python code.

Steps to reproduce:

Open a new folder, create a Python file, write the following code in it :

import os
import logging

print(os.path.pathsep)
logging.info("hello world")

Activate the "source.organizeImports" functionality on save, without any additional args, deactivate any other formatter, linter, etc. Activate the Pylance language server.

Save the current file. The imports should be transformed to

import logging
import os

but what actually happens is

import logging
import logging

2020-07-01 12 05 08

If you disable Pylance and use Jedi instead, the imports are sorted correctly.

The bug can become much more severe with more complex imports if you save several times in a row, generating completely incorrect code with no obvious pattern : 2020-07-01 12 12 07

Logs

<details>

<summary>Output for <code>Python</code> in the <code>Output</code> panel (<code>View</code>→<code>Output</code>, change the drop-down the upper-right of the <code>Output</code> panel to <code>Python</code>) </summary>

<p>

> python3.7 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3.6 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python2 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> ~/Library/Caches/pypoetry/virtualenvs/covia-py3.6/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import jupyter"
> ~/Library/Caches/pypoetry/virtualenvs/covia-py3.6/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import notebook"
> ~/Library/Caches/pypoetry/virtualenvs/covia-py3.6/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py jupyter kernelspec --version
Starting Pylance language server.
Python interpreter path: ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python
> conda --version
> ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
cwd: ~/Documents/dev/other_test
> ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
cwd: ~/Documents/dev/other_test

</p> </details>

<br />

<details>

<summary> Output from <code>Console</code> under the <code>Developer Tools</code> panel (toggle Developer Tools on under <code>Help</code>; turn on source maps to make any tracebacks be useful by running <code>Enable source map support for extension debugging</code>) </summary>

<p>

[Extension Host] Info Python Extension: 2020-07-01 12:09:21: > ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
console.ts:137 [Extension Host] Info Python Extension: 2020-07-01 12:09:21: cwd: ~/Documents/dev/other_test
console.ts:137 [Extension Host] Info Python Extension: 2020-07-01 12:09:21: > ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
console.ts:137 [Extension Host] Info Python Extension: 2020-07-01 12:09:21: cwd: ~/Documents/dev/other_test

</p> </details>

The logs seem to indicate that sortImports.py is actually called twice at a time for some reason, maybe the two executions conflict with one another ?

created time in 6 days

issue openedmicrosoft/vscode-python

Sort imports is severly bugged with Pylance language server

Environment data

  • VS Code version: 1.46.1
  • Extension version (available under the Extensions sidebar): 2020.6.91350
  • OS and version: macOS 10.14.6
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7
  • Relevant/affected Python-related VS Code extensions and their versions: Pylance 2020.6.1
  • Value of the python.languageServer setting: "Pylance"

Expected behaviour

"Sort imports on save" functionality works correctly.

Actual behaviour

When using the new Pylance language server (which is, apart from this bug, absolutely incredible, thanks a lot !), the "sort imports" functionality is bugged, doesn't respect the sortImports settings of VSCode, and produces invalid Python code. I have looked at other similar issues (ex : https://github.com/microsoft/vscode/issues/83586), but an important difference is that the issue I describe here is present even when there is no formatter (other than the import sorter) activated for Python code.

Steps to reproduce:

Open a new folder, create a Python file, write the following code in it :

import os
import logging

print(os.path.pathsep)
logging.info("hello world")

Activate the "source.organizeImports" functionality on save, without any additional args, deactivate any other formatter, linter, etc. Activate the Pylance language server.

Save the current file. The imports should be transformed to

import logging
import os

but what actually happens is

import logging
import logging

2020-07-01 12 05 08

If you disable Pylance and use Jedi instead, the imports are sorted correctly.

The bug can become much more severe with more complex imports if you save several times in a row, generating completely incorrect code with no obvious pattern : 2020-07-01 12 12 07

Logs

<details>

<summary>Output for <code>Python</code> in the <code>Output</code> panel (<code>View</code>→<code>Output</code>, change the drop-down the upper-right of the <code>Output</code> panel to <code>Python</code>) </summary>

<p>

> python3.7 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3.6 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python2 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3 ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> ~/Library/Caches/pypoetry/virtualenvs/covia-py3.6/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import jupyter"
> ~/Library/Caches/pypoetry/virtualenvs/covia-py3.6/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py -c "import notebook"
> ~/Library/Caches/pypoetry/virtualenvs/covia-py3.6/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py jupyter kernelspec --version
Starting Pylance language server.
Python interpreter path: ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python
> conda --version
> ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
cwd: ~/Documents/dev/other_test
> ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
cwd: ~/Documents/dev/other_test

</p> </details>

<br />

<details>

<summary> Output from <code>Console</code> under the <code>Developer Tools</code> panel (toggle Developer Tools on under <code>Help</code>; turn on source maps to make any tracebacks be useful by running <code>Enable source map support for extension debugging</code>) </summary>

<p>

[Extension Host] Info Python Extension: 2020-07-01 12:09:21: > ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
console.ts:137 [Extension Host] Info Python Extension: 2020-07-01 12:09:21: cwd: ~/Documents/dev/other_test
console.ts:137 [Extension Host] Info Python Extension: 2020-07-01 12:09:21: > ~/.pyenv/versions/3.7.2/Python.framework/Versions/3.7/bin/python ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.6.91350/pythonFiles/sortImports.py - --diff
console.ts:137 [Extension Host] Info Python Extension: 2020-07-01 12:09:21: cwd: ~/Documents/dev/other_test

</p> </details>

The logs seem to indicate that sortImports.py is actually called twice at a time for some reason, maybe the two execution conflict with one another ?

created time in 6 days

create barnchErwanDL/icospace

branch : master

created branch time in 19 days

created repositoryErwanDL/icospace

Procedural planet generation with Unity

created time in 19 days

issue commentmicrosoft/vscode-java-debug

Support set extra classpath with maven project

I would also very much like to see this feature implemented, I need to add extra classpath entries to a Maven project without overriding the project's default ones. This feature would help a ton 😃

jopbrown

comment created time in a month

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 3b76488b77895787ec3ee869ec98eb0d9a20efae

add back-end CD

view details

Erwan de Lépinau

commit sha 9ceda3c5bd19012bb2f6cce57c52be795b47a89b

change default icon

view details

Erwan de Lépinau

commit sha 853cb69be09efef09ded2ba8104d9aa5ff7c7d14

add delete confirmation dialog

view details

Erwan de Lépinau

commit sha 1452d02f9b40f3c1adc67c204ccd6c652b634296

add localStorage unregistered behaviour and information snackbar

view details

Erwan de Lépinau

commit sha a4e5952e9d79a7193df814b8c8d51a11227aaba8

improve duration form input validation

view details

Erwan de Lépinau

commit sha d04782f08ca512529b873cf8843b18bc6ef1c087

first draft of drag n drop for subtasks

view details

push time in 2 months

issue commentmicrosoft/vscode-python

Language server caching over-disposes LS instances, breaks on interpreter change

Are there any advancements on this bug ? This is actually a major painpoint for me, as it prevents me from being able to use MLPS on my main Python project at work (which uses multi-root workspaces).

Unless you deem this is a really advanced bugfix, I would love to help on it. Any guidance on where to start working ? 😃

jakebailey

comment created time in 2 months

startedtiangolo/fastapi

started time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha c5e4c6f244a9ca054d827ff0b6a079ed54ec4452

improve duration form input validation

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha d5740d7eb1ac27eb4520d56cfa5fc5803e1671c5

add localStorage unregistered behaviour and information snackbar

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 2b366da3a37bd26b93eff0512718ca7e6606c02d

add delete confirmation dialog

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha ec1960f735b4ca7f28983c9c521b97d1a4b8346a

change default icon

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 97f9f30de9142e6ff17aba5513a35442716d9ba5

c

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 3d7f6a8c0d346e7c70326ad1b74d1344f668ef4f

b

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 04dbde3ddf5c23aec711c5db69cbe9a95c64f4f9

tighten subtasks

view details

Erwan de Lépinau

commit sha d6adb483303991529d456ecd5f73074cf249f6f7

add back-end CD

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 877a11477f1c0bb3be190106d6f64542e3ef1f52

add shadow to screenshot

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 4c2e3f7afaac27def4cef08fdc541609569ec8ab

add shadow to screenshot

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha da724b4b58598e8b5945e18617447af3f22f4611

add README and screenshot

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 01bf2e0b0e65524468b731847a6f7a5500300a2c

responsive

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 5930c6b1246d850c017aa144d1f0784fe6e6fb6e

remove default title

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha b9838018bee8dc90ce202f011577d730dddf21c6

auto-focus title/description on add item

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha dbd2bb4a27c8a4da7e06dd5c576d6747830db40c

fix layout and restrict text inputs length

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha c75bd2ba5ba6bc9f27b724c001b2ec41ffb02b98

increase card size

view details

push time in 2 months

issue commentpython/mypy

NewType context on literal

@hauntsaninja you are very right ! I wasn't aware of the difference in behaviour between NewType and type aliases with =. I think this solves the problem then.

ErwanDL

comment created time in 2 months

issue closedpython/mypy

NewType context on literal

I am not sure if this is a bug or an expected behaviour, but I am wondering if it possible to achieve structural typing when defining type aliases with mypy.

Here is an example :

from typing import List, NewType

UserId = NewType("UserId", int)

a: List[UserId] = [5]    # (mypy) error: List item 0 has incompatible type "int"; expected "UserId"

This code triggers a mypy error, but I would actually want it not to. In this use case, I want to use the type alias UserId more as documentation than as a type-checking information, and thus I would expect it not to trigger an error (I think Typescript for example would produce the behaviour I expect).

Is there a way to achieve the behaviour I describe here ?

This is with Python 3.7.2 and mypy 0.770.

closed time in 2 months

ErwanDL

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha bcbbd39de187454e2a83c21e30151f2b4acc992c

remove table layout in favor of flex to fix strikethrough bug on chrome

view details

push time in 2 months

issue openedpython/mypy

Structural typing for type aliases

I am not sure if this is a bug or an expected behaviour, but I am wondering if it possible to achieve structural typing when defining type aliases with mypy.

Here is an example :

from typing import List, NewType

UserId = NewType("UserId", int)

a: List[UserId] = [5]    # (mypy) error: List item 0 has incompatible type "int"; expected "UserId"

This code triggers a mypy error, but I would actually want it not to. In this use case, I want to use the type alias UserId more as documentation than as a type-checking information, and thus I would expect it not to trigger an error (I think Typescript for example would produce the behaviour I expect).

Is there a way to achieve the behaviour I describe here ?

This is with Python 3.7.2 and mypy 0.770.

created time in 2 months

pull request commentmjpost/sacrebleu

Conditionally install typing dependency only for python < 3.5

I changed to 1.4.10. For the f-strings, maybe moving directly to Python 3.6 is a bit aggressive, but the decision is up to you anyway 😃 !

I think this is ready to merge, thank you !

ErwanDL

comment created time in 2 months

push eventErwanDL/sacrebleu

Erwan de Lépinau

commit sha a4c1626fe67e17c663ce0111adad9dc09d16c566

bump to 1.4.10 instead of 1.5.0 in CHANGELOG

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 9411af02da7e15a5e181d83c7f45c22c99bc3a75

reformat and fix deploy.yml

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha a1bc1f9d465fe43484703c151743ec86a3aabca7

j

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 27c998a364c4deba1fd7b3d531a0da75853184aa

i

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 1a6d83ef7b118f79e1382ce86a7fd211d0a06029

h

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha a05737fe4892cf57308837f084f60b1adc0b4080

g

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 0919ad0c56b0f24010ee5d94a16cf1370540ac0e

f

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha fb4675e7a0b8362d03bf2f71f0d04aa695f2ed91

e

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 516eac5f4b76b1e29af59128f416baa40d0b3344

d

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 1ea5570aabe61e7e131f0580f2264006b1044532

c

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 57a520532a3c01cda756931fa45748635f3dab3e

b

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 6a9b8cf6f444c2460a05677e527093fe2ef232c4

test

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha a59b37be0bd1916e52bd0f1ab7c6bbd971e3e322

reformat deploy.yml

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 2f71a4ac0bb0e1ab5b32c67d029aa2083ff26360

Create GitHub Actions front CD

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 9afeb57919d4e28123e46fdb028ce492b1af07a9

add whitespace

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 3a5490ffcac5381dc13922bd50604b94ad9c90ee

update .env.template

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 2b05e2fdcb1098592a3a235d89de10c00d2d5a4b

move config in .env file

view details

Erwan de Lépinau

commit sha a15cff796e4dd8d9ff6bd934c1ef73316af817fa

remove excess .db at the end of shelve db file

view details

Erwan de Lépinau

commit sha 2643684225f02f436800ed4a76fe7169ac04a412

use API url from .env file

view details

push time in 2 months

PR opened mjpost/sacrebleu

Conditionally install typing dependency only for python < 3.5

For #77.

I kept the dependency to typing for python < 3.5 instead of removing it altogether as it was easy to do, so that the package will not break for users on old python versions. Consequently, shoud I change the version to 1.4.10 instead of 1.5.0 ?

+5 -1

0 comment

2 changed files

pr created time in 2 months

push eventErwanDL/sacrebleu

Erwan de Lépinau

commit sha 675a169df04bdab94d68c7607dcd8c03a35b2f92

conditionally install typing dep only for python < 3.5

view details

push time in 2 months

create barnchErwanDL/sacrebleu

branch : remove-typing-dep-for-new-python-versions

created branch time in 2 months

fork ErwanDL/sacrebleu

Reference BLEU implementation that auto-downloads test sets and reports a version string to facilitate cross-lab comparisons

fork in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha e5eda347bc23d8488a784a4290642fa932a76477

add frontend config template

view details

Erwan de Lépinau

commit sha cce03c05d8fc6e2345ddc3ee7de4b4e524065f11

update on blur only for card title

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 3e14a56b2bc97d934983e739bfa43806c3c74a5e

add frontend config template

view details

Erwan de Lépinau

commit sha beeb88f70324b85ee2c7e81090804ace60b58d48

update on blur only for card title

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha de0bdc93f83a94474e3403a7178750114b0a3618

create config.ts file

view details

push time in 2 months

push eventErwanDL/YATDA

ErwanDL

commit sha 9b11329dfb400b49090a2381851ca84ca6017bb4

update dev and prod start scripts

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 306b5e2e9509dac073fb15b4499db54c1a3ff2e4

add wsgi.py file

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha ec1248946c0843723ea1d814303868f9dc9cfb82

add gunicorn

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 26820bea7bf6dd4b51b448de874cb063009a232e

use username from url

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha b8ebc3c62e829ba874efe0b118e949bcba311b31

add cors to flask app

view details

Erwan de Lépinau

commit sha 28ffdf135a8a04348b562a524640236254c25e0f

add back-end communication services

view details

Erwan de Lépinau

commit sha 474f7799869adf1f33cdb75e6a2a680686332e45

connect front to API

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 44095608ccdd824f8653bf6a03cc577532fbe66f

update back config

view details

Erwan de Lépinau

commit sha bd3d9c06c53ee1fa81c871eeaf1a501ec95e6f99

implement back REST API

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 81a5372e636b6845df843e31e2bba675b81dca0d

create python project

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 1456dc705e80830ac61b27058d9e38bc386f199a

data flow and layout

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha d7c64d92ae0e909ad1352d921c9519fa2fd612ea

work on card layout and components

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 7334be165eaed0f8aa601427ad6396e2d455a2c7

move vue app in front dir

view details

push time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha 2d7ba782a40c0222e8d7266f5f5827fa870eb924

move vue app in front dir

view details

push time in 2 months

issue commentmjpost/sacrebleu

Remove typing module from dependencies

So should I remove this dependency and post a PR ?

ErwanDL

comment created time in 2 months

push eventErwanDL/YATDA

Erwan de Lépinau

commit sha c3a86c286c896c96f73d0328f852a3cc3c3edac7

initial commit and project setup (reuse Vuourt's base components)

view details

push time in 2 months

pull request commentmicrosoft/vscode-python

Add status bar item with icon during installs

@karthiknadig done ! 😃

ErwanDL

comment created time in 2 months

create barnchErwanDL/YATDA

branch : master

created branch time in 2 months

created repositoryErwanDL/YATDA

Yet Another To-Do App

created time in 2 months

push eventErwanDL/vscode-python

Kartik Raj

commit sha 56051b87b9b4896f49bdc19cbf5c4787c4b52296

Do a one-off transfer of existing values for `python.pythonPath` setting to new Interpreter storage if in DeprecatePythonPath experiment (#11053) * Added functionality * Added tests to interpreter path service * Added tests for activation manager * News entry * Fix bug * Correct activation manager tests * Add tests for the new API method * Update unit tests

view details

Rich Chiodo

commit sha 3a292930e39cbfffb69e5b4530b60181d87b2781

Fixes for UI issues (#11130)

view details

Jake Bailey

commit sha f00e21b0bb90e014d1a1c3821d94471409443319

Set python.pythonPath in workspace/configuration LSP call (#11084) * Set python.pythonPath in workspace/configuration LSP call * Add news * Check for undefined in isThenable * PR feedback * Grammar * Grammar2

view details

Don Jayamanne

commit sha 612bf1c92569c5376aaa3be997e1830f48f40646

Added tests for k3d widget (#11133) For #10799, #11096

view details

Don Jayamanne

commit sha b55642347d4d44ac8a1a53b9d4b80026ac39b76d

Fix failing ipywidget tests (#11132) For #11099

view details

Karthik Nadig

commit sha 1dc3374a6e0f016e9ea6e8b69062708f19ff4bb9

Updating some packages (#11135)

view details

Karthik Nadig

commit sha deaeb45ce18041f1b89f9972de68e20da2d84d18

Activate extension if workspace has mspythonconfig (#10906)

view details

Rich Chiodo

commit sha eab579ffea967d2dad63c4ac5df9abce85800c56

Fix code lens perf for interactive window (#11142) * Eliminate first level of redundancy * Working with a cache * Add test to verify no more generating cell ranges * Add news entry * Clean up on closing * Make sure close and reopen works * Fix sonar errors * Fix restart * Fix wrong IDisposable type * Rename restartedKernel to onKernelRestarted * Recompute when changing settings * Clear out document close event when document closes

view details

Ian Huff

commit sha 070021e57d13e4bbeffff556f24594f86f8cfedc

current interface and type (#10667)

view details

Ian Huff

commit sha df0554c9b6bddc42c5cac1ff9827e1223511040a

Testable Kernel and Future (#10679)

view details

Rich Chiodo

commit sha 686c5719aeb9752da0308c088f1c9780a62680ee

Add preliminary support for zeromq v6 (#10682) * Preliminary idea building * Get test to actually start a kernel * Socket event emitter * Send working * Fix result messages * Add another comment to make sure to fix the potential stack issue * Fix hygiene and some code review comments. * resolve promise stack * Fix functional tests * More review feedback * Fix linter

view details

Ian Huff

commit sha 0f732ca185134bcd6689f132ebe674f833884c40

Add status, fix message ordering, added full executeRequest unit test (#10698)

view details

Rich Chiodo

commit sha 752063d7e04e6f6f1f98b723c72c921298daa88d

More tests for enchannel rewrite (#10716) * Preliminary idea building * Get test to actually start a kernel * Socket event emitter * Send working * Fix result messages * Add another comment to make sure to fix the potential stack issue * Fix hygiene and some code review comments. * resolve promise stack * Some more test infrastructure * Add more tests * More tests * Fix up after merge

view details

Ian Huff

commit sha 6b9fc7f08b8d3c83e198c9def2f940565cfa874f

requestInspect + requestComplete + tests for both (#10723)

view details

Ian Huff

commit sha 927f75d3319033f231355b007941432540315121

send inputreply expectreply and tests (#10737)

view details

Ian Huff

commit sha 9158a2a11453da496114187c29599ab563735023

RawSession added, BaseJupyterSession class with raw and server versions (#10764)

view details

Ian Huff

commit sha 69860b3384b9e00a5f6f081b36ea2481551322ea

add channel onto returned JupyterMessage from ZMQ (#10788)

view details

Ian Huff

commit sha af72e88b8f42e3d8338ba3deb7936f63d81c824b

Add display_id handling for messages (#10812)

view details

Ian Huff

commit sha a2c5a6f1727ba29c519d66077164fe8202de1d92

add kernel experiment (#10820) Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>

view details

Rich Chiodo

commit sha f0691a7307c47c16f17e2339e3b1e44d2cc99fb8

Instead of showing interpreter path, show session path for existing kernels. (#11152)

view details

push time in 2 months

push eventErwanDL/vscode-python

Erwan de Lépinau

commit sha 87bf07d48f748783efc8b93c5b05d955ff5dec80

add credit in news item Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>

view details

push time in 2 months

issue openedmjpost/sacrebleu

Remove typing module from dependencies

The external typing module (which is useless now since typing has been integrated in the standard library in Python3.5) is being installed with sacrebleu, which causes conflicts with the typing module from the std library on recent python versions.

Here is an example of a conflict caused in one of my projects by this :

    File "/root/.cache/pypoetry/virtualenvs/feedly.ml-summarization-py3.7/li  
b/python3.7/site-packages/typing.py", line 1357, in <module>                  
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta)  
:                                                                             
    File "/root/.cache/pypoetry/virtualenvs/feedly.ml-summarization-py3.7/li  
b/python3.7/site-packages/typing.py", line 1005, in __new__                   
      self._abc_registry = extra._abc_registry                                
  AttributeError: type object 'Callable' has no attribute '_abc_registry'     

This dependency is listed in the project's dependencies here : https://github.com/mjpost/sacrebleu/blob/f54908ac00879f666c92f4174367bcd3a8723197/setup.py#L110

I believe the possible solutions are :

  • conditionally installing the external typing module for users with Python < 3.5 only
  • removing this dependency altogether, if you do not plan to support Python < 3.5 anyway

Cheers !

created time in 2 months

pull request commentmicrosoft/vscode-python

Add status bar item with icon during installs

Hello @karthiknadig, is there anything else I should do before one of the maintainers can review this PR (if you are busy I fully understand !) ? 😃

ErwanDL

comment created time in 2 months

issue commentavli/clojureVSCode

Error when start nREPL on new lein project

Having the exact same problem as lucasteles, Leiningen 2.9.3 on Java 13.0.2 Java HotSpot(TM) 64-Bit Server VM. I can start the nrepl from the command line by typing lein repl, but in VSCode the Starting nREPL... icon appears and after a moment I get an error notification nREPL exited with code 1.

<details> <summary>Output panel logs :</summary>

Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Error loading cider.nrepl: Syntax error compiling at (cider/nrepl.clj:1:1).
Syntax error compiling var at (/private/var/folders/88/26xg7d096x7gztffx44yb9f80000gp/T/form-init6989802207003301932.clj:1:9089).
Unable to resolve var: cider.nrepl/wrap-apropos in this context

Full report at:
/var/folders/88/26xg7d096x7gztffx44yb9f80000gp/T/clojure-4814943021023505629.edn
Subprocess failed (exit code: 1)
nREPL exited with code 1

</details>

lucasteles

comment created time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha 9d2319a09e643d5e508ae8b66c25d2a02e05d766

update example

view details

push time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha ed0b7b076b4703a35c808326ac517d4c94ee3b60

optimize glossy reflections

view details

Erwan de Lépinau

commit sha f8ebaf3796c4daca08672a9cdf7d65385b3c5e4f

declutter renderer file

view details

push time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha 060117767b7ffe310b9426e599243e1d7067cfc6

fix specular light negative dotproduct bug

view details

Erwan de Lépinau

commit sha 2e1db3aba33b42b8866a4358c1fd182860d13b80

add glossy reflections

view details

push time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha 130b7efc23b3883a17395cf5e92e4847aa7bd4e6

implement spherical rotation for Vector3

view details

push time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha 92dc2e6f14993599dc1c28956362484d6fe0d611

create UniformIntervalRNG

view details

push time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha 6285cecd09f24ba9a9f70551eeb2731b4966d2b1

add progress bar and percentage in stdout

view details

push time in 3 months

pull request commentnotskm/vscode-clang-tidy

Add "progress" notification when linting/fixing

I mean "singleton" in the sense of the Singleton Pattern : a class that is only instantiated once. I think it makes sense as there should always be only one instance of clang-tidy running (it's really not hard to implement the singleton pattern in TS).

I can start working on figuring out what tests are needed and submit PRs that you can review when you have time.

For the file modification problem, I also think that it can wait for a bit.

ErwanDL

comment created time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha 0cb42dfc0e643e316b68431d4b9f9eea773a433f

add options in run-dev.sh

view details

push time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha c3a6048799a1ad898bf7123a95002846b6aaf178

fix run-dev.sh script

view details

push time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha 69344a2f46c379f850d473680bbe668e8f26cef2

add gunicorn and wsgi.py

view details

push time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha ced367c435d948b34fd31376f8d455ceff32ddf5

add hello world blueprint to setup prod

view details

push time in 3 months

push eventErwanDL/cpp-raytracer

Erwan de Lépinau

commit sha 5d386cd4a43d071255f392d7485c441eac7dd998

add stochastic supersampling

view details

push time in 3 months

PR opened microsoft/vscode-python

Add status bar item with icon during installs

For #10495.

We created a withProgressCustomIcon helper in #10687 and used it to display custom icons in the status bar while downloading Insiders/MLPS. As suggested by @kimadeline, this also adds a status bar item with a custom icon when installing packages (Insiders build and Stable build). From what I've seen, MLPS is never installed (just downloaded), so I don't think there is something to display there.

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • ~[ ] Appropriate comments and documentation strings in the code.~
  • ~[ ] Has sufficient logging.~
  • ~[ ] Has telemetry for enhancements.~
  • [x] Unit tests & system/integration tests are added/updated.
  • ~[ ] Test plan is updated as appropriate.~
  • ~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).~
  • ~[ ] The wiki is updated with any design decisions/details.~
+42 -10

0 comment

3 changed files

pr created time in 3 months

push eventErwanDL/vscode-python

Erwan de Lépinau

commit sha 2e23d38ffc68cca2e15f43a47f7de58fcd9f2aa0

add news entry

view details

push time in 3 months

push eventErwanDL/vscode-python

Erwan de Lépinau

commit sha c84b1af00028c93ec043ef3cc8712cccca4cecef

update extensionBuildInstaller tests

view details

push time in 3 months

create barnchErwanDL/vscode-python

branch : statusbar-item-when-installing-pkg

created branch time in 3 months

push eventErwanDL/vscode-python

Don Jayamanne

commit sha f8f9b86508d5fe8c034bb210dc99fc74e4d165ae

Revert "Remove ipywidgets (#9253)" (#9751) This reverts commit 43d30fddc2ea6e65513898e551d427967c3282b1. For #3429

view details

Don Jayamanne

commit sha 164727a4e989d2f53778338ce04f55f5fad9ecec

Add support for ipywidgets (#10606) * Widgets * Fixes * Misc * Crap * Include requirejs

view details

Don Jayamanne

commit sha d4c3132475805a0cd4104200c6a2d9a08460faff

Add ipywidget deps to main package.json and update builds(#10615)

view details

Don Jayamanne

commit sha 6141edb50d8e6c3e8a47e5fc814e8b684902950c

Fixes a few linter and compiler issues (#10616)

view details

Don Jayamanne

commit sha 3c6f0091f41befcf57c2a72f6c277262c8de578d

Hide raw text if output is an ipywidget (#10620)

view details

Don Jayamanne

commit sha 40e0bda93861e900a88c942a635f804b849dff58

Merge branch 'master' into ds/ipyWidgets * master: Fix merge issue Move redux logging to a different file (#10605) Disable custom editor API (#10604) Ensure local host only if connection not available (#10600) Delegate management of notebooks (creation and disposing) to I… (#10568) Refactor to accommodate upstream VSCode API changes (#10569) Use a single notebook beetween multiple native editors (#10514) Add support for synchronising edits between two nb editors of… (#10189) Fix tests in ds/custom_editor branch (#10512) Fix linter Reimplement custom editor using new API

view details

Don Jayamanne

commit sha 265cb61f98efed5fc896816366b3b01a59506349

Add support for moving/collapsing cells with ipywidget output (#10624) * Support collpasing/moving ipywidget output cells * Fix

view details

Don Jayamanne

commit sha 739f8c0c73c735bb4726b368aa6adc0913eee8ac

Remove post office methods from root state (#10627)

view details

Don Jayamanne

commit sha d95970f52b22d670b30d6a7a0794584c70e5fd3d

Ensure functional tests run even without ipywidgets (#10628)

view details

Rich Chiodo

commit sha fd8fab29879b6be3f55b5bc00c7acc9a4f5879f6

Rework notebook startup to be in the INotebookProvider (#10642) * Initial concept building * Disable UI for progress too * Fix functional tests * Fix hygiene * Review feedback * Fix hygiene * Fix unit tests * Fix sonar bug

view details

Rich Chiodo

commit sha 3eedc2137037b21a22f34baa10e46dcb47fbef35

Get ipywidgets working everywhere (#10653)

view details

Rich Chiodo

commit sha e725dd8977f2e7b823338af78eff73bb36c085c6

Fix save on old editor (#10665)

view details

Don Jayamanne

commit sha b248deb4e1181910f77f9d990cce4b0c639b416d

Add ability to DS notebook tests within a headless browser (#10657) * Add ability to launch DS ui in browser in tests * Address code review comments * Dump screenshots in temp dir * Ignore windows * Additional launch config * Added comments

view details

Ian Huff

commit sha 7384b40087b66fc0ec12b9a3d947498f16260ec3

update mockito and minor test updates (#10671)

view details

Kim-Adeline Miguel

commit sha ed53377d6c0ab8a323945f2dfbafb84c7423b030

Disable blank issues (#10678)

view details

Luciana Abud

commit sha 790cd6dc3aee0cb6fc428b4e0bf8e0d823e65cdb

Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674)

view details

Don Jayamanne

commit sha aaae5ca80d29f09512d95d8505131478d002d961

Merge branch 'master' into ds/ipyWidgets * master: Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674) Disable blank issues (#10678) update mockito and minor test updates (#10671) Fix save on old editor (#10665) Job names were invalid (#10646) Telemetry updates (#10631) Remote session shutdownAll is killing all sessions (#10621)

view details

Don Jayamanne

commit sha 9fd67d3bed3fb40e6d604fa4e18adaf8c5c0bb31

Add basic UI tests for notebook (with ipywidgets) (#10675) * Added some basic UI tests for notebook * Added a simple widget test * News * Rename * Oops * More tests

view details

Jim Griesmer

commit sha 68d7acb56aa0f8fc195fa01741a650fea6bc569c

Send telemetry when gather survey link is clicked. (#10683) * Sending gather quality report (works - not pretty) * Actually open the gather survey And whitelist the command that does so. We don't necessarily want to open the door of being able to execute arbitrary commands to notebooks. Yet. * Fixup for PR submit * Tweak to work correctly with surveymonkey

view details

Don Jayamanne

commit sha 702c8ce2b45e46beb4947c95cdab6b7c6511cfda

Ensure ipywidgets are synced between editors (#10717) * Ensure ipywidgets are synced between editors * Address code review comments * Refactor

view details

push time in 3 months

PR opened notskm/vscode-clang-tidy

Add "progress" notification when linting/fixing

As suggested on #19, I added a progress notification in the window when clang-tidy is linting/fixing the current file :

2020-04-11 13 42 09

The message displayed is "Linting current file..." or "Linting and fixing current file (do not modify it in the meanwhile)...", depending on whether it should just lint or also fix the file.

Concerns/suggestions :

  • Since clang-tidy directly modifies the file on disk when fixing, you must not modify the file while it is being fixed by clang-tidy (if you do, the next time you save, you get an error message saying The content of this file on disk is newer. Please compare or overwrite the changes). I wrote that explicitly in the progress message, but this is clearly not enough. I think the ESLint extension has implemented a workaround for this, since they probably had the same problem at some point, I could investigate later how they handle it.

  • The way I had to wrap the ChildProcess within a Promise is kind of ugly, and also the fact that we rely on a global variable clangTidyProcess to store info about the process status is not really sexy either. I think the whole tidy.ts module could be refactored to expose a ClangTidy singleton class, with run, kill, getArgs methods and a processStatus attribute, and we could also certainly write our own small wrapper around 'execFile()` to Promisify it.

I am willing to work on that refactoring, but before I do that I think we need to write some tests to ensure I don't break some functionality along the way. I would need your help on this, since I'm new to the extension and I do not really what the full extent of the features is. It would help if you could write down in a document the use cases that you would want to be covered by the tests, so that we can then code the corresponding test cases, or at least know what cases we should manually check.

Cheers !

+14 -7

0 comment

1 changed file

pr created time in 3 months

create barnchErwanDL/vscode-clang-tidy

branch : progress-while-linting

created branch time in 3 months

startednodejs/node

started time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha 38ef314ae71bd11d32ce987bb59285bc233c0aef

fix config.py.template

view details

push time in 3 months

PR opened DeciusAntiochus/ad-covia

Reviewers
WIP: Reboot Flask api

This aims at clarifying and better organizing the project structure for the Python/Flask project, switching to SQLite3, and adding a comprehensive README file for development setup.

TODO :

  • Configure production environment (with Gunicorn)
+129 -163

0 comment

17 changed files

pr created time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha 032d65aa8c5c63926eeaf48b56477251e6421a43

add flake8 ignore on false positive

view details

push time in 3 months

push eventDeciusAntiochus/ad-covia

Erwan de Lépinau

commit sha fe6e05c3f9a5ece26013e82024e10ef149ebc608

add README for dev

view details

push time in 3 months

more