profile
viewpoint
VICTOR HUGO SÁNCHEZ GRACIDA Enterprises-Gracida-Veracruz Facebook http://business.google.com/www.business.facebook.com/me/m.me/enterprises-gracida-veracruz/ https://developers.facebook.com/docs/commerce-platform/platforms/distribution/MPApprovalAPI/@enterprises-gracida-veracruz marketplace_approval_requested | Explorador de la API Graph - Facebook para desarrolladores

issue commentfacebook/react-native

'React/RCTBridgeDelegate.h' file not found

@luism3861 Hi Luis, error solved, the version of the Podfile did not match the version we had selected in Xcode, the podfile had version 11.0 and xcode had version 10 selected. When we changed it in Xcode immediately the error did not appear anymore, a lot of thanks!

omer-to

comment created time in 17 minutes

push eventfacebook/react-native

David Vacca

commit sha ec7b2085d895d0bf29e494c868e2c2362b859d80

Refactor StaticViewConfigsPaperUIManager to avoid loading NativeUIManager.js Summary: This diff refactors the StaticViewConfigsPaperUIManager to avoid loading NativeUIManager. This is part of a experiment to prevent loading UIManagerModule class in native. changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D25630215 fbshipit-source-id: 40d6f3b36ad4c3377820b1dcf0bd949db063d899

view details

David Vacca

commit sha e68cf7cee9d36271a1d3899fecff817304bb8bdc

Avoid the call to getViewManagerConfig on deprecatedPropType method Summary: This diff removes the call to UIManager.getViewManagerConfig into the deprecatedPropType method when static view configs are enabled This was necessary to avoid innecessary calls to UIManager.getViewManagerConfig and to avoid loading UIManagerModule classes when static view configs are enabled changelog: [internal] internal Reviewed By: fkgozali, yungsters Differential Revision: D26040855 fbshipit-source-id: 82cad9f4abe9898e781fd989ebaa03497dad926b

view details

David Vacca

commit sha 4cdafd997a08d808331d54be93ba5b9e2e6d4bc7

Add supoprt for Text Input view configs Summary: This diff adds TextInput in the list of components that support static view configs changelog: [internal] Reviewed By: yungsters Differential Revision: D26040854 fbshipit-source-id: d6b5d3a78ef4657acf3f2c4ebe527ad4ca40bcb5

view details

David Vacca

commit sha 3dd312311396bd1e0af9e6f137abbb3e2fce73fc

Avoid retrieving view configs on Text component Summary: This diff avoids retrieving view configs on Text component when static view configs are enabled changelog: [interrnal] Reviewed By: JoshuaGross, sammy-SC Differential Revision: D25577278 fbshipit-source-id: 674b8067cea13d284848e35dabaf26cd1bea4e27

view details

push time in 41 minutes

push eventNativeScript/NativeScript

AkshatChhapolia

commit sha c47b974edeb17470a2567a89754de52178c98cb0

chore: readme grammer (#9174)

view details

push time in an hour

PR merged NativeScript/NativeScript

tried improving, I am a first time contributor so happy to start with NativeScript. Thanks. cla: yes

<!-- We, the rest of the NativeScript community, thank you for your contribution! To help the rest of the community review your change, please follow the instructions in the template. -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

PR Checklist

  • [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • [ ] You have signed the CLA.
  • [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
  • [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

What is the new behavior?

<!-- Describe the changes. -->

Fixes/Implements/Closes #[Issue Number].

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

<!-- BREAKING CHANGES:

[Describe the impact of the changes here.]

Migration steps: [Provide a migration path for existing applications.] -->

+6 -6

5 comments

2 changed files

AkshatChhapolia

pr closed time in an hour

pull request commentNativeScript/NativeScript

tried improving, I am a first time contributor so happy to start with NativeScript. Thanks.

Actually the readme changes are quite nice! 🤗 thank you.

AkshatChhapolia

comment created time in an hour

PullRequestEvent

PR closed NativeScript/NativeScript

tried improving, I am a first time contributor so happy to start with NativeScript. Thanks. cla: yes

<!-- We, the rest of the NativeScript community, thank you for your contribution! To help the rest of the community review your change, please follow the instructions in the template. -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

PR Checklist

  • [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • [ ] You have signed the CLA.
  • [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
  • [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

What is the new behavior?

<!-- Describe the changes. -->

Fixes/Implements/Closes #[Issue Number].

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

<!-- BREAKING CHANGES:

[Describe the impact of the changes here.]

Migration steps: [Provide a migration path for existing applications.] -->

+6 -6

4 comments

2 changed files

AkshatChhapolia

pr closed time in an hour

pull request commentNativeScript/NativeScript

tried improving, I am a first time contributor so happy to start with NativeScript. Thanks.

Hey! Thanks so much for opening a pull request!

The change you've proposed is not going to be accepted because this change doesn't meaningfully improve docs, fix a bug, or otherwise improve functionality.

We absolutely want to have you as a contributor, so please take a look at our open issues for ideas, and please reach out to us on Twitter at @NativeScript with questions.

Thanks again, and we look forward to seeing more PRs from you in the future! ❤️

AkshatChhapolia

comment created time in an hour

Pull request review commentNativeScript/NativeScript

feat: setSelection method for editable text components

 export abstract class EditableTextBase extends EditableTextBaseCommon {  		this.nativeTextViewProtected.autocorrectionType = newValue; 	}+	public setSelection(start: number, stop?: number) {+		const view = this.nativeTextViewProtected;+		if (stop !== undefined) {

Might be good to wrap all this in conditional to protect against view (android side does it already but always best to be careful with ios as well):

if (view) {
farfromrefug

comment created time in an hour

push eventNativeScript/NativeScript

Martin Guillon

commit sha c31bab1bf73af7f90ff3c5c90a22b86a682137ea

fix(ios): textfield resizing (auto width) on text change (#9176)

view details

push time in an hour

PR merged NativeScript/NativeScript

fix: ios textfield resizing (auto width) on text change

This fixes iOS behavior to correctly resize on text change. Was already working on Android

+4 -1

0 comment

1 changed file

farfromrefug

pr closed time in an hour

delete branch NativeScript/NativeScript

delete branch : fix/ios-save-image

delete time in an hour

push eventNativeScript/NativeScript

Osei Fortune

commit sha e002d72d41b7a006788fcd38feb51a7b3c1ef870

fix(ios): force release of nsdata after saving image (#9177) gc isn't cleaning up this fast enough when used in a loop e.g https://github.com/NativeScript/plugins/issues/71

view details

push time in an hour

PR merged NativeScript/NativeScript

fix(ios): force release of nsdata after saving image cla: yes

Looks like the gc isn't cleaning up this fast enough when used in a loop e.g NativeScript/plugins#71

+5 -2

0 comment

1 changed file

triniwiz

pr closed time in an hour

PR opened NativeScript/NativeScript

fix(ios): force release of nsdata after saving image

Looks like the gc isn't cleaning up this fast enough when used in a loop e.g NativeScript/plugins#71

+5 -2

0 comment

1 changed file

pr created time in 2 hours

create barnchNativeScript/NativeScript

branch : fix/ios-save-image

created branch time in 2 hours

issue commentfacebook/react-native

'React/RCTBridgeDelegate.h' file not found

@luism3861 The app works fine in debug mode, the problem its when we try to run archive with xcode to send to testflight.

omer-to

comment created time in 2 hours

issue commentfacebook/react-native

'React/RCTBridgeDelegate.h' file not found

last option manage schemes select react, select react and then run command + b , return you app base clean project and build project.

That's don't work man :(

@Darkiring be sure delete app in simulator, delete node_modules, clean cache project

omer-to

comment created time in 2 hours

pull request commentfacebook/react-native

Fixes in react-native inspector to build on Windows universal environment

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,898,796 -606
android hermes armeabi-v7a 8,402,744 -625
android hermes x86 9,387,457 -620
android hermes x86_64 9,331,471 -638
android jsc arm64-v8a 10,350,608 -70
android jsc armeabi-v7a 9,837,656 -86
android jsc x86 10,400,784 -91
android jsc x86_64 10,985,047 -89

Base commit: 505f9fc74929326ea246eb4aeb700f97820c702f

mganandraj

comment created time in 2 hours

pull request commentfacebook/react-native

Fixes in react-native inspector to build on Windows universal environment

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 505f9fc74929326ea246eb4aeb700f97820c702f

mganandraj

comment created time in 3 hours

pull request commentfacebook/react-native

Fixes in react-native inspector to build on Windows universal environment

<!-- 0 failure: 0 warning: 1 messages

DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Messages</th> </tr> </thead> <tbody><tr> <td>:book:</td> <td>

:clipboard: Verify Changelog Format - <i>A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

<details>CATEGORY may be:

  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.</details></i> </td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against b4b92b68a7c8d2da0276cd762fccc3e5eb3a5b88 </p>

mganandraj

comment created time in 3 hours

issue closedNativeScript/NativeScript

[BUG] - Connectivity.ios.ts problem - cDict.takeUnretainedValue is not a function

Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: 7.0.4 Cross-platform modules: 6.5.15 Android Runtime: 6.5.3 iOS Runtime: 7.0.0-beta.3-v8-2020-07-01-222820-05 NativeScript-Angular: 8.21 Angular: 8.1

Describe the bug Hi guys,

on my app I use "tns-core-modules/connectivity" and using last runtime and last NS core version (6.5.10), I've this error:

cDict.takeUnretainedValue is not a function

I've seen that connectivity.ios.ts has been modified recently:

https://github.com/NativeScript/NativeScript/commit/635f31f81f7826112142c707aff2a66c2b480b0e#diff-e04e55bc1acfe6688983450e6a16735d

I've this error on app:

#Screenshot of app log

I've created and issue here: https://github.com/NativeScript/ns-v8ios-runtime/issues/54

closed time in 3 hours

mapo80

issue commentfacebook/react-native

Bold custom font not apply on Android 11

I'm also running into this issue. Also breaks icons.

seosd97

comment created time in 3 hours

issue openedfacebook/react-native

NSException * "Could not load NIB in bundle: 'NSBundle <path to app> (loaded)' with name 'LaunchScreen'"

Please provide all the information requested. Issues that do not follow this format are likely to stall.

Description

My app is building from running react-native android just fine, however iOS is building, but crashing on the launchscreen with the following error Exception NSException * "Could not load NIB in bundle: 'NSBundle <path to app> (loaded)' with name 'LaunchScreen" I just upgraded from 0.62.2 to 0.63.4, using the upgrade helper tool, since the automatic tool didn't work.

React Native version:

System: OS: macOS 11.1 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Memory: 132.11 MB / 16.00 GB Shell: 3.0.0 - /usr/local/bin/fish Binaries: Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node Yarn: 1.12.3 - /usr/local/bin/yarn npm: 6.14.8 - ~/.nvm/versions/node/v14.15.1/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Managers: CocoaPods: 1.10.1 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2 Android SDK: API Levels: 23, 25, 26, 27, 28, 29 Build Tools: 26.0.3, 28.0.3, 29.0.2 System Images: android-23 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: 3.2 AI-181.5540.7.32.5056338 Xcode: 12.3/12C33 - /usr/bin/xcodebuild Languages: Java: 1.8.0_191 - /usr/bin/javac Python: 2.7.16 - /usr/bin/python npmPackages: @react-native-community/cli: Not Found react: 16.13.1 => 16.13.1 react-native: 0.63.4 => 0.63.4 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

  1. upgrade from 0.62.2 to 0.62.4 (must not automatically upgrade using npx react-native upgrade)
  2. use react native upgrade tool helper to manually copy merge code.

Expected Results

The app should start up, as it works fine on android.

Snack, code example, screenshot, or link to a repository:

image image

created time in 3 hours

PR opened facebook/react-native

Fixes in react-native inspector to build on Windows universal environment

Summary

We are working on bringing up React native inspector with Hermes on React Native For Windows. This PR has some minor fixups required to build the code under UWP build environment. Essentially, _WINDOWS macro is not available but _MSC_VER is always guaranteed to be present when building for WIndows.

Another change is due to the fact the GLOG APIs are stubbed out using preprocessor macros in RNW, which can't marked as "noreturn", hence forcing us to have return statements after the fatal error log statements.

Here is the link to the corresponding PR in React-Native-Windows repo for reference: https://github.com/microsoft/react-native-windows/pull/6964

Changelog

We are working on bringing up React native inspector with Hermes on React Native For Windows. This PR has some minor fixups required to build the code under UWP build environment. Essentially, _WINDOWS macro is not available but _MSC_VER is always guaranteed to be present when building for WIndows.

Another change is due to the fact the GLOG APIs are stubbed out using preprocessor macros in RNW, which can't marked as "noreturn", hence forcing us to have return statements after the fatal error log statements.

[CATEGORY] [TYPE] - Message

Test Plan

The change only affect windows builds.

+8 -2

0 comment

4 changed files

pr created time in 3 hours

issue commentfacebook/react-native

- [ ] [!] Invalid `Podfile` file: undefined method `[]' for nil:NilClass when pod install

I fixed this issue changing: use_react_native!(:path => config["reactNativePath"]) to use_react_native!

in my Podfile.

Then I deleted Podfile.lock.

ThinkSalat

comment created time in 3 hours

issue closedfacebook/react-native

- [ ] [!] Invalid `Podfile` file: undefined method `[]' for nil:NilClass when pod install

Environment

System: OS: macOS 11.1 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Memory: 467.06 MB / 16.00 GB Shell: 3.0.0 - /usr/local/bin/fish Binaries: Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node Yarn: 1.12.3 - /usr/local/bin/yarn npm: 6.14.8 - ~/.nvm/versions/node/v14.15.1/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Managers: CocoaPods: 1.9.3 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2 Android SDK: API Levels: 23, 25, 26, 27, 28, 29 Build Tools: 26.0.3, 28.0.3 System Images: android-23 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: 3.2 AI-181.5540.7.32.5056338 Xcode: 12.3/12C33 - /usr/bin/xcodebuild Languages: Java: 1.8.0_191 - /usr/bin/javac Python: 2.7.16 - /usr/bin/python npmPackages: @react-native-community/cli: Not Found react: 16.13.1 => 16.13.1 react-native: 0.63.4 => 0.63.4 react-native-macos: Not Found npmGlobalPackages: react-native: Not Found

Things I’ve done to figure out my issue

Upgrading version

0.63.4

Description

I just upgraded to 0.63.4 and the following is happening

When running the upgrade, hardly any of the files actually worked. And for some reason, there's a lot of mismatching stuff in the project.pbxproj file. I am using this god forsaken tool to manually go through and update these files (how is it that react native has gotten harder to update than before?), and for a lot of the lines in "before" version of the file, I can't delete the line because the number doesn't match.

How is this app actually working if this file already doesn't have the right stuff in it? Like, it is very different from the before version in the upgrader, and I just upgraded to 0.62.2. How do I appraoch this ridiculous task? I've been at it for hours now.

closed time in 3 hours

ThinkSalat

PR opened octocat/Spoon-Knife

add one line to readme
+2 -0

0 comment

1 changed file

pr created time in 3 hours

startedpkrumins/bithacks.h

started time in 4 hours

issue commentfacebook/react-native

Type annotations can only be used in TypeScript files.ts(8010) on React-Native CLI Startup

My issue was node_module files had Typescript code in .js files. The error squiggles were getting annoying. This was my solution. I made VS Code associate all .js and .ts extensions as TS / React ( I didn't have to change any other settings ):

By adding this to the settings.json:

"files.associations": {
    "*.js": "typescriptreact",
    "*.jsx": "typescriptreact",
    "*.tsx": "typescriptreact",
    "*.ts": "typescriptreact"
}, 
KelvnPere

comment created time in 4 hours

more