profile
viewpoint
Evgenii Pashkin EPashkin Russia, Moscow

EPashkin/gamenumber 2

simple game in haskell using free-game (also has version on gloss)

EPashkin/free-game 1

Create something graphical with free monads

EPashkin/atk 0

Atk binding in rust

EPashkin/cabal-uninstall 0

Very simple Haskell script to uninstall cabal packages

EPashkin/cairo 0

Cairo bindings for Rust

EPashkin/cargo 0

The Rust package manager

EPashkin/dirconcat 0

Simply utility for concating files from multiply folders

EPashkin/docs 0

The source repo of http://gtk-rs.org/docs/

EPashkin/erlang-task-queue 0

Erlang Task Queue Behaviour

EPashkin/examples 0

gtk-rs examples

Pull request review commentsfackler/rust-postgres

Get for text results when querying

 impl Client {             .await     } +    /// Same as `query` but returns text results instead of binary+    ///+    /// We introduce an additional method rather than parameters not to break all+    /// the conversions and marshalling supplied by `postgres-types` and feature crates and+    /// inasmuch as this allows us to maintain API compatibility with upstream+    pub async fn query_with_text_results<T>(+        &self,+        statement: &T,+        params: &[&(dyn ToSql + Sync)],+    ) -> Result<Vec<Row>, Error>

You right, in your project it used with proxy function, but in general case it need more thoughts.

fn decode_column_value_common<'a, T: postgres::types::FromSql<'a> + std::fmt::Display>(
    row: &'a Row,
    i: usize,
) -> String {
    match row.try_get::<usize, T>(i) {
        Ok(data) => format!("{}", data),
        Err(_) => "<null>".to_string(),
    }
}
EPashkin

comment created time in 5 days

PullRequestReviewEvent

PR opened sfackler/rust-postgres

Get for text results when querying

Fix #389

+127 -6

0 comment

4 changed files

pr created time in 5 days

create barnchEPashkin/rust-postgres

branch : with_text_results

created branch time in 5 days

fork EPashkin/rust-postgres

Native PostgreSQL driver for the Rust programming language

fork in 5 days

issue commentsfackler/rust-postgres

Support the `ltree` data type

Has almost same issue with columns in pg_catalog.pg_type table (and many functions in pg_catalog).

Example

    for row in client.query("select oid, typname, typinput, * from pg_type limit 1", &[])? {
        let oid: Oid = row.get(0);
        let typname: &str = row.get(1);
        let typinput: &str = row.get(2);

        println!("{} {} {:?}", oid, typname, typinput);
    }

@sfackler Is acceptable to add to Client new function query_with_text_results that pass Some(0) to frontend::bind ?

quanbrew

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgtk-rs/examples

Move to edition "2018"

 name = "printing"  [[bin]] name = "gio_async_tls"-required-features = ["async-tls"]-edition = "2018"+required-features = ["async-tls"]

"No newline at end of file"

Hofer-Julian

comment created time in 25 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentgtk-rs/examples

Fix entry_completion quit shortcut

@piegamesde Thanks, 👍

piegamesde

comment created time in 2 months

issue commentgtk-rs/gtk

Rename `get_` methods

I agree that we can remove "property" for properties, Not sure about "get" prefixes: agree with @GuillaumeGomez that we better have same names as C counterparts, but maybe we can make exception for getters.

hyarsan

comment created time in 2 months

pull request commentgtk-rs/gir

Update README.md

This crate is code generator

TopView

comment created time in 3 months

pull request commentgtk-rs/gir

Update README.md

While names are same this crate is not GObjectIntrospection, but code generator that used its results.

TopView

comment created time in 3 months

pull request commentgtk-rs/pango

fixes #193 add constants for PANGO_SCALE_*

👍 Thanks, @emmanueltouzery

emmanueltouzery

comment created time in 3 months

issue commentgtk-rs/gtk

constants GDK_BUTTON_* missing?

Yes it only in gdk sys without safe usage https://docs.rs/gdk-sys/0.10.0/gdk_sys/constant.GDK_BUTTON_PRIMARY.html I almost sure that this function can return 4 or more if mouse has many buttons. So + for constant rexporting, -+ for enum.

emmanueltouzery

comment created time in 3 months

issue commentgtk-rs/pango

need an enum for the PangoScale values

There no PANGO_SCALE_ in Pango-1.0.gir so in need be added manually

emmanueltouzery

comment created time in 3 months

delete branch EPashkin/gtk

delete branch : use_GtkScrollType_in_trampoline

delete time in 3 months

issue commentgtk-rs/gir

Fix or remove config split_build_rs

@sdroege But now we don't needed build_version.rs so IMHO better rename option

EPashkin

comment created time in 3 months

pull request commentgtk-rs/gtk

Use GtkScrollType in trampoline

@GuillaumeGomez we get new error in rustdoc: instead of ignoring it seems add sniped for "WidgetExtManual::fn hide_on_delete" from vendor.md two times

diff --git b/src/widget.rs a/src/widget.rs

index 01ccdca..6bb2cd1 100644

--- b/src/widget.rs
+++ a/src/widget.rs
@@ -64,28 +64,6 @@ pub trait WidgetExtManual: 'static {
     // rustdoc-stripper-ignore-next
     /// Calls `gtk_widget_destroy()` on this widget.
     ///
-    /// Utility function; intended to be connected to the `Widget::delete-event`
-    /// signal on a `Window`. The function calls `WidgetExt::hide` on its
-    /// argument, then returns `true`. If connected to ::delete-event, the
-    /// result is that clicking the close button for a window (on the
-    /// window frame, top right corner usually) will hide but not destroy
-    /// the window. By default, GTK+ destroys windows when ::delete-event
-    /// is received.
-    ///
-    /// # Returns
-    ///
-    /// `true`
-    /// Utility function; intended to be connected to the `Widget::delete-event`
-    /// signal on a `Window`. The function calls `WidgetExt::hide` on its
-    /// argument, then returns `true`. If connected to ::delete-event, the
-    /// result is that clicking the close button for a window (on the
-    /// window frame, top right corner usually) will hide but not destroy
-    /// the window. By default, GTK+ destroys windows when ::delete-event
-    /// is received.
-    ///
-    /// # Returns
-    ///
-    /// `true`
     /// # Safety
     ///
     /// This will not necessarily entirely remove the widget from existence but
EPashkin

comment created time in 3 months

pull request commentgtk-rs/gtk

Use GtkScrollType in trampoline

Nightly compiler nags about it

EPashkin

comment created time in 3 months

PR opened gtk-rs/gtk

Use GtkScrollType in trampoline

@sdroege, @GuillaumeGomez We used not FFI-safe type in trampoline

+3 -3

0 comment

1 changed file

pr created time in 3 months

pull request commentgtk-rs/examples

Update for removal of ObjectImpl::get_type_data()

CI passed

sdroege

comment created time in 3 months

pull request commentgtk-rs/examples

Update for removal of ObjectImpl::get_type_data()

Seems CI need restarted again, Travis still think that it against master

sdroege

comment created time in 3 months

pull request commentgtk-rs/examples

Update for removal of ObjectImpl::get_type_data()

@sdroege Please change target branch to pending

sdroege

comment created time in 3 months

create barnchEPashkin/gtk

branch : use_GtkScrollType_in_trampoline

created branch time in 3 months

pull request commentgtk-rs/examples

Update for removal of ObjectImpl::get_type_data()

Also here one old warning in changed files:

warning: unused import: `glib::subclass::prelude::*`
  --> src\bin\basic_subclass.rs:21:5
   |
21 | use glib::subclass::prelude::*;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: 1 warning emitted
sdroege

comment created time in 3 months

pull request commentgtk-rs/examples

Update for removal of ObjectImpl::get_type_data()

Strange that CI failing, @sdroege something is not merged?

sdroege

comment created time in 3 months

pull request commentgtk-rs/examples

Update for removal of ObjectImpl::get_type_data()

@GuillaumeGomez Please restart CI here

sdroege

comment created time in 3 months

delete branch EPashkin/gir

delete branch : fix_libsecret

delete time in 3 months

push eventgtk-rs/gir

Evgenii Pashkin

commit sha 3dff42f0628aaca5923743eb898054ab9382e5d4

Fix tests for libsecret

view details

Evgenii Pashkin

commit sha a6737c72ae70ee7a17ae4ac7729905f9bb87e4e3

Merge pull request #953 from EPashkin/fix_libsecret Fix tests for libsecret

view details

push time in 3 months

PR merged gtk-rs/gir

Fix tests for libsecret

cc @GuillaumeGomez , @sdroege

+32 -2

1 comment

3 changed files

EPashkin

pr closed time in 3 months

pull request commentgtk-rs/glib

Get rid of ObjectImpl::get_type_data() and glib_object_impl!() macro

@sdroege Thanks 👍 for this and followups

sdroege

comment created time in 3 months

issue openedgtk-rs/gir

Fix or remove config split_build_rs

As it not used with crate system_deps

created time in 3 months

pull request commentgtk-rs/gir

Fix tests for libsecret

Ok, CI passed with some dirty hacks

EPashkin

comment created time in 3 months

push eventEPashkin/gir

Evgenii Pashkin

commit sha 3dff42f0628aaca5923743eb898054ab9382e5d4

Fix tests for libsecret

view details

push time in 3 months

push eventEPashkin/gir

Evgenii Pashkin

commit sha 73d03f65466b8b748c9eddac59bb179172c73d3f

Fix tests for libsecret

view details

push time in 3 months

PR opened gtk-rs/gir

Fix tests for libsecret

cc @GuillaumeGomez , @sdroege

+25 -0

0 comment

3 changed files

pr created time in 3 months

create barnchEPashkin/gir

branch : fix_libsecret

created branch time in 3 months

delete branch EPashkin/gir

delete branch : clippy

delete time in 3 months

push eventgtk-rs/gir

Evgenii Pashkin

commit sha 7aa159dda3e507bafefde308ad8ec0bb67b666b4

Fix clippy warnings

view details

Evgenii Pashkin

commit sha 17b62413421349f8e1a867f01145001dcdf3b998

Merge pull request #952 from EPashkin/clippy Fix clippy warnings

view details

push time in 3 months

PR merged gtk-rs/gir

Fix clippy warnings

cc @sdroege , @GuillaumeGomez

+3 -3

0 comment

1 changed file

EPashkin

pr closed time in 3 months

PR opened gtk-rs/gir

Fix clippy warnings

cc @sdroege , @GuillaumeGomez

+3 -3

0 comment

1 changed file

pr created time in 3 months

create barnchEPashkin/gir

branch : clippy

created branch time in 3 months

push eventEPashkin/gir

Guillaume Gomez

commit sha 23b28411a146feed3275432b6ad8e3609d5ed812

Fix missing parenthesis on return types

view details

Guillaume Gomez

commit sha f88e67280ecc5b24f6d1e9844c4e218a2a6be336

Extend gpointer to void*

view details

Evgenii Pashkin

commit sha f95008f3b3639ec38bb450f8f582eb7a903c2bb3

Merge pull request #860 from GuillaumeGomez/gpointer Extend gpointer to void*

view details

Guillaume Gomez

commit sha 03f218f4da2bbb66cb1645f4b7d93abaf58fe5c5

Correctly generate glib::Error import

view details

Evgenii Pashkin

commit sha 6fc598207fe6ec88e9fa084fc3f2bedd64ec6f1a

Merge pull request #861 from GuillaumeGomez/fix-parenthesis Fix missing parenthesis on return types

view details

Guillaume Gomez

commit sha da4b332c0cf5002a9329390616815aecfc76973f

Add missing from_glib conversion for Pid

view details

Evgenii Pashkin

commit sha 3176c6394023e2fd5e719f626cf432cac1311ac7

Merge pull request #864 from GuillaumeGomez/add-missing-from_glib-pid Add missing from_glib conversion for Pid

view details

Evgenii Pashkin

commit sha 2bb6380ceab50b48653b15b317380e318a7c7613

Merge pull request #863 from GuillaumeGomez/correct-error-import Correctly generate glib::Error import

view details

Sebastian Dröge

commit sha 14e75da2ed54c4e13141114ff9efd37b22ac59b1

Provide the full path to the Inhibit type for signals Otherwise glib::signal::Inhibit needs to be re-exported from the crate root.

view details

Sebastian Dröge

commit sha 5a89e7c9e587101a1d48433976203eb2a1546e72

Update dependencies

view details

Evgenii Pashkin

commit sha d0b94047a85850c475946d82fb1df3d3a9e2a204

Merge pull request #866 from sdroege/inhibit Provide the full path to the Inhibit type for signals

view details

Guillaume Gomez

commit sha 6a7c6a4b17b3a14b911a100217eec640143e9162

Ignore function-macro tag to prevent warnings

view details

Evgenii Pashkin

commit sha 68eb6c55ca8d66771d52e1ccf6c9e59244f65399

Merge pull request #868 from GuillaumeGomez/function-macro Ignore function-macro tag to prevent warnings

view details

Sebastian Dröge

commit sha a14e610993ec5b19f5ce874c41394a76660d3276

Generate pinned box futures and use the stabilized futures

view details

Evgenii Pashkin

commit sha 6c8c7c481da4bb3df5cbf3a277d5c0247f219c85

Merge pull request #869 from sdroege/futures-stable Generate pinned box futures and use the stabilized futures

view details

Evgenii Pashkin

commit sha 98a03741594779945d512440f54a57437bf1813d

Reformat

view details

Evgenii Pashkin

commit sha 7be04d36fb63f4a4e4a4bebd630fd629281c1e0f

Fix gir-files link in .travis.yml

view details

Evgenii Pashkin

commit sha 530c7be80c75692436f7ed6a25c305b50e1b4aa7

Merge pull request #871 from EPashkin/format Format

view details

Wolfgang Silbermayr

commit sha 18121cf4b4d6f1e2920b6369d376719b6d080abe

Migrate to `tempfile` from deprecated `temdir` The `tempdir` crate was deprecated by its authors, and `tempfile` is recommended as a replacement. I assume this is the first time that a dependency needs to be removed from `Cargo.toml` files, because I found no functionality to remove the entry. I created an `unset` function analogous to the `set_string` function found in the `cargo_toml.rs` file. Rationale: I do packaging work for rust crates in Debian, and due to it's deprecation, we decided to not package the `tempdir` crate at all, but to submit patches to the projects that still use it instead.

view details

Evgenii Pashkin

commit sha 1ee9edf52fb1a0bd9e66eff7c1f896fa3cdc30c5

Merge pull request #870 from silwol/master Migrate to `tempfile` from deprecated `temdir`

view details

push time in 3 months

more