profile
viewpoint
Dylan DPC Dylan-DPC Berlin Rustacean

crev-dev/cargo-crev 1102

A cryptographically verifiable code review system for the cargo (Rust) package manager.

AeroRust/Welcome 60

Welcome to the (Unofficial) Rust 🦀 + Aerospace 🚀 working group 🙌

AeroRust/awesome-space 44

List of awesome resources for Aerospace and Rust

AeroRust/WorkingGroup 32

Issues tracker for udeas, ongoing work, looking for mentors, mentors available, everything is in here!

chrispecoraro/mega-make 10

"php artisan make:all" for Laravel 5.5+

Dylan-DPC/cargo-doctor 7

Checks if all links mentioned in cargo docs of a crate are healthy

Dylan-DPC/cargo-caldera 2

Crater for packages that runs the new version on every reverse dependency

Dylan-DPC/clim-rs 2

CLI Menus

Dylan-DPC/acl 0

Dynamically configurable access control for laravel

issue commentrust-lang/rust

async-std docs no longer build on recent nightlies

(nominated so prioritisation discussion not required)

yoshuawuyts

comment created time in a day

delete branch Dylan-DPC/rust

delete branch : refactor/repetitions

delete time in a day

pull request commentrust-lang/rust

rust_ast::ast => rustc_ast

r? @eddyb

JulianKnodt

comment created time in a day

pull request commentrust-lang/rust

rust_ast::ast => rustc_ast

r? @eddyb

JulianKnodt

comment created time in a day

startedRDambrosio016/RSLint

started time in a day

pull request commentrust-lang/rust

Remove (useless) argument of entry_fn query

@marmeladema any updates on this?

marmeladema

comment created time in 2 days

pull request commentrust-lang/rust

fix typos

@bors rollup=always

shengsheng

comment created time in 2 days

pull request commentrust-lang/rust

fix typos

r? @Dylan-DPC

@bors r+

shengsheng

comment created time in 2 days

pull request commentrust-lang/rust

Some fixes for `plugin.md` in unstable-book

@bors r=GuilliameGomez rollup

giraffate

comment created time in 3 days

PR closed rust-lang/rust

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast S-waiting-on-author

Rework of #70621

r? @eddyb

credit to @Lezzz for the original pr :)

+314 -305

16 comments

225 changed files

Dylan-DPC

pr closed time in 3 days

pull request commentrust-lang/rust

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast

Gonna close it as it's not important and rework it some other time.

Dylan-DPC

comment created time in 3 days

PR closed rust-lang/rust

Record lifetime constraints inside generator interior S-waiting-on-author T-compiler

Closes #64552

r? @Aaron1011

+172 -32

27 comments

19 changed files

csmoe

pr closed time in 3 days

pull request commentrust-lang/rust

Record lifetime constraints inside generator interior

Closing this as inactive. Thanks

csmoe

comment created time in 3 days

PR closed rust-lang/rust

Separate unsized fn param from unsized locals S-waiting-on-author

Closes #71694

+270 -122

25 comments

56 changed files

spastorino

pr closed time in 3 days

pull request commentrust-lang/rust

Separate unsized fn param from unsized locals

closing this as it is reworked in #74971

spastorino

comment created time in 3 days

PR closed rust-lang/rust

Document unsafety in `src/libcore/slice/mod.rs` S-waiting-on-author

Helps with #66219. r? @Mark-Simulacrum

+94 -10

5 comments

1 changed file

LeSeulArtichaut

pr closed time in 3 days

pull request commentrust-lang/rust

Document unsafety in `src/libcore/slice/mod.rs`

Closing this after a discussion with the author since they don't have time to commit to this and it is small enough that can be redone later or someone could pick it up if needed. Thanks

LeSeulArtichaut

comment created time in 3 days

delete branch Dylan-DPC/rust

delete branch : rollup-8nyuwm1

delete time in 6 days

pull request commentrust-lang/rust

Clean up E0720 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 7 days

PR closed rust-lang/rust

change offset from u32 to u64 S-waiting-on-author

Changes offset of u32 to u64 Resolves one of eddy's FIXMEs References #71699

r? @eddyb

+15 -17

10 comments

6 changed files

Dylan-DPC

pr closed time in 8 days

pull request commentrust-lang/rust

change offset from u32 to u64

closing in favour of #74848

Dylan-DPC

comment created time in 8 days

pull request commentrust-lang/rust

change offset from u32 to u64

r? @oli-obk (can skip reviewing this for now since it's just the old changes)

cc @eddyb

Dylan-DPC

comment created time in 8 days

PR opened rust-lang/rust

change offset from u32 to u64

Rework of #71696 since it was easier to make a new one and cherry pick commits on top.

This isn't ready for review it yet, marking it as a draft PR. Will ping when this is ready to be reviewed :)

References #71699

+61 -144

0 comment

6 changed files

pr created time in 8 days

create barnchDylan-DPC/rust

branch : refactor/offset-to-u64

created branch time in 8 days

issue commentrust-lang/rust

Initializing a zero-length array leaks the initializer

Marked as p-low as per the discussion

smarnach

comment created time in 8 days

pull request commentrust-lang/rust

Serialize span hygiene data

I think so as well but it's more as a precatuionary measure. that pr has been trying to get merged for a while now so don't want to add more latency.

Aaron1011

comment created time in 9 days

pull request commentrust-lang/rust

mv std libs to library/

(note: you need to retry the other pr that's running in order for this to rub, or you could wait for that to finish)

mark-i-m

comment created time in 9 days

pull request commentrust-lang/rust

Serialize span hygiene data

@bors retry

Aaron1011

comment created time in 9 days

pull request commentrust-lang/rust

mv std libs to library/

Afaik you can't stop a try build. So let's r+ it

@bors r=Mark-Simulacrum

mark-i-m

comment created time in 9 days

pull request commentrust-lang/rust

Serialize span hygiene data

@bors retry yield

Aaron1011

comment created time in 9 days

pull request commentrust-lang/rust

Serialize span hygiene data

yielding to other pr to avoid conflicts

@bors retry

Aaron1011

comment created time in 9 days

pull request commentrust-lang/rust

mv std libs to library/

this seems spurious

@bors retry

mark-i-m

comment created time in 9 days

pull request commentrust-lang/rust

mv std libs to library/

@bors r=Mark-Simulacrum

mark-i-m

comment created time in 10 days

pull request commentrust-lang/rust

Clean up E0719 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 10 days

pull request commentrust-lang/rust

Rollup of 10 pull requests

@bors r+ p=5 rollup=never

Dylan-DPC

comment created time in 11 days

create barnchDylan-DPC/rust

branch : rollup-j7w6cvr

created branch time in 11 days

PR opened rust-lang/rust

Rollup of 10 pull requests

Successful merges:

  • #72954 (revise RwLock for HermitCore)
  • #74367 (Rearrange the pipeline of pow to gain efficiency)
  • #74491 (Optimize away BitAnd and BitOr when possible)
  • #74507 (add visit_operand to const prop)
  • #74639 (Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x)
  • #74661 (Refactor region_name: add RegionNameHighlight)
  • #74681 ( Miri: use extern fn to expose interpreter operations to program; fix leak checker on Windows)
  • #74692 (delay_span_bug instead of silent ignore)
  • #74698 (fixed error reporting for mismatched traits)
  • #74708 (Ensure stack when type checking and building MIR for large if expressions)

Failed merges:

r? @ghost

+11321 -343

0 comment

57 changed files

pr created time in 11 days

push eventDylan-DPC/rust

Kan-Ru Chen

commit sha f64e58cc1d5f9e2831a6ecdacd6133eaa5502bc5

Ensure stack when type checking and building MIR for large if expressions

view details

Dylan DPC

commit sha bc36d69ab8877927a9e232624a3329baf4e144bc

Rollup merge of #74708 - kanru:issue-74564, r=davidtwco Ensure stack when type checking and building MIR for large if expressions Fixes #74564

view details

push time in 11 days

push eventDylan-DPC/rust

Ayrton

commit sha bae1e03109bc6594763be26cfa78270917c0199a

fixed error reporting for mismatched traits mismatched traits were previously referred to as types

view details

Ayrton

commit sha b75ed4f61cb867388eb17280f3acd933fe933f26

added a test case for reporting mismatched traits

view details

Dylan DPC

commit sha a64b544df2e67a628f8d71112c2d07bff7d9b2fc

Rollup merge of #74698 - ayrtonm:handle-traitref-mismatch, r=estebank fixed error reporting for mismatched traits mismatched traits were previously referred to as types closes #72217

view details

push time in 11 days

push eventDylan-DPC/rust

Mark Rousskov

commit sha 5a5846f4c7b4797e3a038cc1107688af8e7919ec

delay_span_bug instead of silent ignore

view details

Dylan DPC

commit sha 7d545ed15c1cbb328550a53526f39bec521dccda

Rollup merge of #74692 - Mark-Simulacrum:delay-bug, r=pnkfelix delay_span_bug instead of silent ignore This is a follow-up to #74557. r? @pnkfelix

view details

push time in 11 days

push eventDylan-DPC/rust

Ralf Jung

commit sha 1b446cdbf03d26f31f6113a4ccb2e011f3a9abf1

replace miri_start_panic intrinsic by 'extern fn'

view details

Ralf Jung

commit sha c8229cdfc1a570b73d826cb92dd2d43db5257e4a

on Windows, use miri_static_root for TLS dtors

view details

Ralf Jung

commit sha 67b4f3b1482971f6eaecec0c5e01f8be467c491a

avoid implicitly returning ()

view details

Dylan DPC

commit sha bd22cc5cc7cebe786beac38bdbf34d9ac7786bd9

Rollup merge of #74681 - RalfJung:miri-extern-fn, r=oli-obk Miri: use extern fn to expose interpreter operations to program; fix leak checker on Windows This PR realizes an idea that @oli-obk has been suggesting for a while: to use Miri-specific `extern` functions to provide some extra capabilities to the program. Initially, we have two of these methods, which libstd itself needs: * `miri_start_panic`, which replaces the intrinsic of the same name (mostly for consistency, to avoid having multiple mechanisms for Miri-specific functionality). * `miri_static_root`, which adds an allocation to a list of static "roots" that Miri considers as not having leaked (including all memory reachable through them). This is needed for https://github.com/rust-lang/miri/issues/1302. We use `extern` functions instead of intrinsics for this so that user code can more easily call these Miri hoolks -- e.g. `miri_static_root` should be useful for https://github.com/rust-lang/miri/issues/1318. The Miri side of this is at https://github.com/rust-lang/miri/pull/1485. r? @oli-obk

view details

push time in 11 days

push eventDylan-DPC/rust

SNCPlay42

commit sha c27633489d038765922d996ebd59ba032007d25c

add RegionName::span

view details

SNCPlay42

commit sha 51af5af6fde92f6a15314310e756b3b2d19f22fa

extract RegionNameHighlight

view details

SNCPlay42

commit sha 601518edcd3d570918bbfebfe71e7905dacd4482

change returns to RegionNameHighlight

view details

SNCPlay42

commit sha 723ea909929498380615f56e652660229adcdfef

rename functions

view details

SNCPlay42

commit sha b56f5b9df5a41fbf3c82310b5c3d901b0b0f78dc

clean up give_name_if_anonymous_region_appears_in_arguments

view details

SNCPlay42

commit sha a7450b7989a5e94ec964a589826a1089d2e7108b

decouple highlight_if_we_cannot_match_hir_ty

view details

SNCPlay42

commit sha ebb4ababfc86bc34b42bae7607adedd28ed05b30

move highlight_if_we_can_match_hir_ty call out of highlight_if_we_can_match_hir_ty_from_argument, which is then renamed

view details

SNCPlay42

commit sha 8a776ee2390cb99f915cda22393ce4e297208396

rename arguments to highlight_if_we_can_match_hir_ty

view details

Dylan DPC

commit sha 4ce6ee5abda62707bcf41219450f967fb89bc2e8

Rollup merge of #74661 - SNCPlay42:lifetime-names-refactor, r=estebank Refactor `region_name`: add `RegionNameHighlight` This PR does not change any diagnostics itself, rather it enables further code changes, but I would like to get approval for the refactoring first before making use of it. In `rustc_mir::borrow_check::diagnostics::region_name`, there is code that allows for, when giving a synthesized name like `'1` to an anonymous lifetime, pointing at e.g. the exact '`&`' that introduces the lifetime. This PR decouples that code from the specific case of arguments, adding a new enum `RegionNameHighlight`, enabling future changes to use it in other places. This allows: * We could change the other `AnonRegionFrom*` variants to use `RegionNameHighlight` to precisely point at where lifetimes are introduced in other locations when they have type annotations, e.g. a closure return `|...| -> &i32`. * Because of how async functions are lowered this affects async functions as well, see #74072 * for #74597, we could add a second, optional `RegionNameHighlight` to the `AnonRegionFromArgument` variant that highlights a lifetime in the return type of a function when, due to elision, this is the same as the argument lifetime. * in https://github.com/rust-lang/rust/issues/74497#issuecomment-6606229707 I noticed that a diagnostic was trying to introduce a lifetime `'2` in the opaque type `impl std::future::Future`. The code for the case of arguments has [code to handle cases like this](https://github.com/rust-lang/rust/blob/bbebe7351fcd29af1eb9a35e315369b15887ea09/src/librustc_mir/borrow_check/diagnostics/region_name.rs#L365) but not the others. This refactoring would allow the same code path to handle this. * It might be appropriate to add another variant of `RegionNameHighlight` to say something like `lifetime '1 appears in the opaque type impl std::future::Future`. These are quite a few changes so I thought I would make sure the refactoring is OK before I start making changes that rely on it. :)

view details

push time in 11 days

push eventDylan-DPC/rust

Martin Sirringhaus

commit sha e46219c169f633466b2e5677a328c6afd2e37118

Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x

view details

Dylan DPC

commit sha 568b989b29283ba88e4f1b968d750808d4e26c5d

Rollup merge of #74639 - msirringhaus:master, r=cuviper Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x As discussed in #73782 I've tested these changes on rust 1.43.0 for all the specified archs and used the resulting binaries to bootstrap building rust 1.43.1. I've also shortly tested these changes on master on ppc64.

view details

push time in 11 days

push eventDylan-DPC/rust

Bastian Kauschke

commit sha c74c6486023899e0e2a1669fa4e32b8f62e1f97f

const prop into operands

view details

Bastian Kauschke

commit sha d257bacfea8a046c41d6841f897d17944f2f0e64

note LLVM in fixme

view details

Bastian Kauschke

commit sha 61a9ab8fe64484458059d630ab3d0938f7f34ccf

slightly adapt const prop

view details

Dylan DPC

commit sha 1279137bebeaa64e1f7d53679cc65d5badb73f70

Rollup merge of #74507 - lcnr:const-prop-into-op, r=oli-obk add `visit_operand` to const prop r? @oli-obk

view details

push time in 11 days

push eventDylan-DPC/rust

Xavier Denis

commit sha 711a6807a7979715d6b2940db56eaf1585d30a71

Optimize away BitAnd and BitOr when possible

view details

Dylan DPC

commit sha 385f64c9223adaf13f746414f66aa030b92fbe12

Rollup merge of #74491 - xldenis:constant-binop-opt, r=oli-obk Optimize away BitAnd and BitOr when possible This PR lets `const_prop` optimize away `a | true == true` , `a & false == false` and `a * 0 = 0`. While I was writing this I've realized that constant propagation misses a lot of opportunities. For example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=2a4b45e772f214210a36749b27223bb0 Constant propagation doesn't seem to... propagate constants, additionally the way constant propagation is currently setup makes it tricky to add cases like `a | false == a`. I tried to organize `eval_rvalue_with_identities` to make the pattern of the optimizations easier to see but it still obscurs what should be a simple peephole optmization. cc @oli-obk

view details

push time in 11 days

push eventDylan-DPC/rust

Neutron3529

commit sha ef74e5084386f82b4285fd7d3630cf1088eebb3f

Rearrange the pipeline of `pow` to gain efficiency The check of the `exp` parameter seems useless if we execute the while-loop more than once. The original implementation of `pow` function using one more comparison if the `exp==0` and may break the pipeline of the cpu, which may generate a slower code. The performance gap between the old and the new implementation may be small, but IMO, at least the newer one looks more beautiful. --- bench prog: ``` extern crate test; ($a:expr)=>{let time=std::time::Instant::now();{$a;}print!("{:?} ",time.elapsed())}; ($a:expr,$b:literal)=>{let time=std::time::Instant::now();let mut a=0;for _ in 0..$b{a^=$a;}print!("{:?} {} ",time.elapsed(),a)} } pub fn pow_rust(x:i64, mut exp: u32) -> i64 { let mut base = x; let mut acc = 1; while exp > 1 { if (exp & 1) == 1 { acc = acc * base; } exp /= 2; base = base * base; } if exp == 1 { acc = acc * base; } acc } pub fn pow_new(x:i64, mut exp: u32) -> i64 { if exp==0{ 1 }else{ let mut base = x; let mut acc = 1; while exp > 1 { if (exp & 1) == 1 { acc = acc * base; } exp >>= 1; base = base * base; } acc * base } } fn main(){ let a=2i64; let b=1_u32; println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); } ``` bench in my laptop: ``` neutron@Neutron:/me/rust$ rc commit.rs rustc commit.rs && ./commit 3.978419716s 0 4.079765171s 0 3.964630622s 0 3.997127013s 0 4.260304804s 0 3.997638211s 0 3.963195544s 0 4.11657718s 0 4.176054164s 0 3.830128579s 0 3.980396122s 0 3.937258567s 0 3.986055948s 0 4.127804162s 0 4.018943411s 0 4.185568857s 0 4.217512517s 0 3.98313603s 0 3.863018225s 0 4.030447988s 0 3.694878237s 0 4.206987927s 0 4.137608047s 0 4.115564664s 0 neutron@Neutron:/me/rust$ rc commit.rs -O rustc commit.rs -O && ./commit 162.111993ms 0 165.107125ms 0 166.26924ms 0 175.20479ms 0 205.062565ms 0 176.278791ms 0 174.408975ms 0 166.526899ms 0 201.857604ms 0 146.190062ms 0 168.592821ms 0 154.61411ms 0 199.678912ms 0 168.411598ms 0 162.129996ms 0 147.420765ms 0 209.759326ms 0 154.807907ms 0 165.507134ms 0 188.476239ms 0 157.351524ms 0 121.320123ms 0 126.401229ms 0 114.86428ms 0 ``` delete an unnecessary semicolon... Sorry for the typo. delete trailing whitespace Sorry, too.. Sorry for the missing... I checked all the implementations, and finally found that there is one function that does not check whether `exp == 0` add extra tests add extra tests. finished adding the extra tests to prevent further typo add pow(2) to negative exp add whitespace. add whitespace add whitespace delete extra line

view details

Dylan DPC

commit sha 9450240ec230a3b069b534e064cf81fc4f2a0313

Rollup merge of #74367 - Neutron3529:patch-1, r=nagisa Rearrange the pipeline of `pow` to gain efficiency The check of the `exp` parameter seems useless if we execute the while-loop more than once. The original implementation of `pow` function using one more comparison if the `exp==0` and may break the pipeline of the cpu, which may generate a slower code. The performance gap between the old and the new implementation may be small, but IMO, at least the newer one looks more beautiful. --- bench prog: ``` #![feature(test)] extern crate test; #[macro_export]macro_rules! timing{ ($a:expr)=>{let time=std::time::Instant::now();{$a;}print!("{:?} ",time.elapsed())}; ($a:expr,$b:literal)=>{let time=std::time::Instant::now();let mut a=0;for _ in 0..$b{a^=$a;}print!("{:?} {} ",time.elapsed(),a)} } #[inline] pub fn pow_rust(x:i64, mut exp: u32) -> i64 { let mut base = x; let mut acc = 1; while exp > 1 { if (exp & 1) == 1 { acc = acc * base; } exp /= 2; base = base * base; } if exp == 1 { acc = acc * base; } acc } #[inline] pub fn pow_new(x:i64, mut exp: u32) -> i64 { if exp==0{ 1 }else{ let mut base = x; let mut acc = 1; while exp > 1 { if (exp & 1) == 1 { acc = acc * base; } exp >>= 1; base = base * base; } acc * base } } fn main(){ let a=2i64; let b=1_u32; println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); timing!(test::black_box(a).pow(test::black_box(b)),100000000); timing!(pow_new(test::black_box(a),test::black_box(b)),100000000); timing!(pow_rust(test::black_box(a),test::black_box(b)),100000000); println!(); } ``` bench in my laptop: ``` neutron@Neutron:/me/rust$ rc commit.rs rustc commit.rs && ./commit 3.978419716s 0 4.079765171s 0 3.964630622s 0 3.997127013s 0 4.260304804s 0 3.997638211s 0 3.963195544s 0 4.11657718s 0 4.176054164s 0 3.830128579s 0 3.980396122s 0 3.937258567s 0 3.986055948s 0 4.127804162s 0 4.018943411s 0 4.185568857s 0 4.217512517s 0 3.98313603s 0 3.863018225s 0 4.030447988s 0 3.694878237s 0 4.206987927s 0 4.137608047s 0 4.115564664s 0 neutron@Neutron:/me/rust$ rc commit.rs -O rustc commit.rs -O && ./commit 162.111993ms 0 165.107125ms 0 166.26924ms 0 175.20479ms 0 205.062565ms 0 176.278791ms 0 174.408975ms 0 166.526899ms 0 201.857604ms 0 146.190062ms 0 168.592821ms 0 154.61411ms 0 199.678912ms 0 168.411598ms 0 162.129996ms 0 147.420765ms 0 209.759326ms 0 154.807907ms 0 165.507134ms 0 188.476239ms 0 157.351524ms 0 121.320123ms 0 126.401229ms 0 114.86428ms 0 ```

view details

push time in 11 days

push eventDylan-DPC/rust

Stefan Lankes

commit sha 6813c1c69baf870a479c70e23ad0550d1d9aa9be

revise RwLock, which is derived from the wasm implementation - increasing the readability of `Condvar` - simplify the interface to the libos HermitCore

view details

Stefan Lankes

commit sha 3acc3ef10d2099a4b3118e8c705b36f4bbaf6f64

minor changes to pass the format check

view details

Stefan Lankes

commit sha beb1b1fa5b1047c7caf8a1d499725df3c1ad8cad

reorder crates to pass the format check

view details

Stefan Lankes

commit sha f9c609164251abc136eb9bda55c92cb99adb5c86

remove some compiler warnings

view details

Stefan Lankes

commit sha 6925ebdd6051b3827c2978b8b285e49743306ccc

use latest version of hermit-abi

view details

Dylan DPC

commit sha 363e4f5eb8c774074b0849b448b16b0de841ac43

Rollup merge of #72954 - hermitcore:rwlock, r=dtolnay revise RwLock for HermitCore - current version is derived from the wasm implementation - increasing the readability of `Condvar` - simplify the interface to the libos

view details

push time in 11 days

PR closed rust-lang/rust

Make lang items private S-waiting-on-author

Implements https://github.com/rust-lang/compiler-team/issues/301

Design is largely as discussed, but I also made an effort to remove require_lang_item. Instead, LangItemRecord has methods require and require_with which take a reference to a MissingLangItemHandler (implemented by TyCtxt). In my opinion this makes the interface a lot cleaner while also reducing the number of imports (it is no longer necessary to import lang_items or specific items in order to require them).

This change also made it possible to unify the item and missing fields of the lang items table. We no longer require the hack in the weak lang items pass for marking eh_personality as missing as all lang items are now assumed missing until found. To make this work, alloc_error_handler is explicitly whitelisted in crates which do not require an allocator.

This is likely to conflict with a lot of open PRs as it touches a lot of code, but my biggest worry is #72559 (which will need to be re-implemented to use the new API although I can't imagine it will be too difficult).

Resolves #72240

r? @oli-obk

cc @ecstatic-morse + @Aaron1011

+553 -455

9 comments

97 changed files

doctorn

pr closed time in 12 days

pull request commentrust-lang/rust

Make lang items private

@doctorn hey :) closing this due to inactivity. If you wish when you have the time to do so, you can submit a new PR with these changes. Thank you for taking the time to contribute :)

doctorn

comment created time in 12 days

PR closed rust-lang/rust

Don't add attribute to allow unused-qualifications to derive impl's S-waiting-on-author

Currently #![forbid(unused_qualifications)] is incompatible with all derive's because we add #[allow(unused_qualifications)] in all generated impl's.

Closes #71898

+41 -10

9 comments

3 changed files

samrat

pr closed time in 12 days

pull request commentrust-lang/rust

Don't add attribute to allow unused-qualifications to derive impl's

@samrat closing this pr due to inactivity. If you have time again, you can open a new pr with these changes. Thanks for taking the time to contribute :)

samrat

comment created time in 12 days

pull request commentrust-lang/rust

Avoid writes without any data in `Write::write_all_vectored`

r? @KodrAus

tmiasko

comment created time in 12 days

pull request commentcontain-rs/linked-hash-map

Fix mem::uninitialized UB warning

@Gankra is there any plan on yanking the older (unsound) versions? This crate has many reverse dependencies yanking the older ones would ensure that they obtain a sound version of this crate instead of bumping the minimum dependency to 0.5.3

SpaceManiac

comment created time in 12 days

issue commentrust-lang/rust

ICE with the `@ ..` binding pattern

here is another one: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=3f27a7faf85be38c646a6427b25b59c9 (assuming related)

r1fl

comment created time in 12 days

pull request commentrust-lang/rust

Clean up E0727 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 12 days

delete branch Dylan-DPC/log4rs-routing-appender

delete branch : patch-1

delete time in 12 days

pull request commentrust-lang/rust

Remove needless unsafety from BTreeMap::drain_filter

r? @KodrAus

ssomers

comment created time in 12 days

pull request commentrust-lang/rust

revise RwLock for HermitCore

r? @dtolnay

stlankes

comment created time in 12 days

PR opened sfackler/log4rs-routing-appender

bump linked_hashmap to 0.5.3

Linked_hashmap is unsound for versions prior to 0.5.3. This can be found in the advisory. This was found from a crater run. Bumping the dependency so that all dependents end up on a sound version of the crate.

+1 -1

0 comment

1 changed file

pr created time in 13 days

push eventDylan-DPC/log4rs-routing-appender

Dylan DPC

commit sha b8488156c8a42bf82a263bc0cd1481cf7c06cfc8

Update Cargo.toml

view details

push time in 13 days

pull request commentsodiumoxide/sodiumoxide

Prepare sodiumoxide for release

@dnaq yeah that's the plan just that none of us have sat to do it

tasn

comment created time in 14 days

issue commentrust-lang/rust

Miri: rename "undef" -> "uninit"

@pnadon sure.. 2 months is a short timeframe in rust's perspective :D

RalfJung

comment created time in 14 days

pull request commentalexheretic/linked-hash-set

bumping to safe minimum dependency

Linked hashmap is unsound for versions 0.5.2 and below as per this advisory. Bumping this to ensure all dependents end up on a sound version.

Dylan-DPC

comment created time in 14 days

fork Dylan-DPC/linked-hash-set

Rust HashSet with insertion ordering

fork in 14 days

push eventDylan-DPC/linked-hash-set

Dylan DPC

commit sha 165d16bb92c2f7ad0f4992af8b60a5aa1c568c01

Update Cargo.toml

view details

push time in 14 days

issue openedbrandonedens/rust-littlefs

unsoundness in code

Hi I found this via a crater run. This crate uses std::mem::unitialized which is both deprecated and unsound. You can refer the linked advisory to know more

created time in 14 days

pull request commentrust-lang/mdBook

Mention removed features in the changelog

Thanks

JohnTitor

comment created time in 16 days

push eventrust-lang/mdBook

Yuki Okushi

commit sha 4e16d96ed50877cb06366a0ef6dc712712838f97

Mention removed features (#1282)

view details

push time in 16 days

PR merged rust-lang/mdBook

Mention removed features in the changelog

I think it's worth mentioning in the changelog since it's one of breaking changes even if it was actually unused.

+2 -0

0 comment

1 changed file

JohnTitor

pr closed time in 16 days

pull request commentrust-lang/rust

Add `Arc::new_with()` function for constructing self-referential data structures

@Diggsey waiting for you to update this PR and then we can get it reviewed again :) thanks

Diggsey

comment created time in 17 days

pull request commentrust-lang/rust

Reduce duplicate in liballoc reserve error handling

@withoutboats this is ready for review

pickfire

comment created time in 17 days

pull request commentrust-lang/rust

Better method call error messages

@estebank the author needs some guidance for this pr. Thanks

Quantumplation

comment created time in 17 days

PR closed rust-lang/rust

Remove Spans from HIR -- 3/N -- hir::Item S-waiting-on-author

Third step in rust-lang/compiler-team#294 Builds on #73094 Split out of #72015

This PR removes the span from hir::Item.

+1536 -1427

5 comments

150 changed files

cjgillot

pr closed time in 17 days

pull request commentrust-lang/rust

Remove Spans from HIR -- 3/N -- hir::Item

closing this due to inactivity. Has a number of conflicts

cjgillot

comment created time in 17 days

pull request commentrust-lang/rust

add test for #62878

@bors r+ rollup

lcnr

comment created time in 18 days

issue openedrealityone/libnetkeeper

unsound dependencies

This crate depends on linked_hashmap 0.3 which is usound (unsoundness issue was fixed in 0.5.3).

Advisory: https://github.com/RustSec/advisory-db/issues/298

created time in 18 days

pull request commentrust-lang/rust

Normalize all opaque types when converting ParamEnv to Reveal::All

@Aaron1011 any updates on this?

Aaron1011

comment created time in 18 days

pull request commentrust-lang/rust

Re-land PR #72388: Recursively expand `TokenKind::Interpolated` in `probably_equal_for_proc_macro`

@Aaron1011 any updates on this?

Aaron1011

comment created time in 18 days

pull request commentrust-lang/rust

Advertise correct stable version for const control flow

@ecstatic-morse if you can get this resolved, we can get this merged before more conflicts arise :)

ecstatic-morse

comment created time in 18 days

pull request commentrust-lang/rust

Linear interpolation (lerp) implementation

@vertexclique any updates?

vertexclique

comment created time in 18 days

pull request commentrust-lang/rust

[perf] Measure Destination Propagation performance

@jonas-schievink any updates?

jonas-schievink

comment created time in 18 days

pull request commentrust-lang/rust

Add checking for no_mangle to unsafe_code lint

@craterbot check

Nemo157

comment created time in 18 days

pull request commentrust-lang/rust

Update stdarch

@craterbot check

jethrogb

comment created time in 18 days

Pull request review commentploteria/ploteria

Improved Grid configuration

 impl Figure {         }         self     }++    /// Configures the major and the minor grid+    pub fn configure_grid<F: FnOnce(&mut GridOptions) -> &mut GridOptions>(

tiny tidbit - would prefer a where style instead of putting the bounds inside the <>

mfep

comment created time in 19 days

Pull request review commentploteria/ploteria

Improved Grid configuration

+//! Grid along major and minor ticks++use crate::{Color, Default, Display, LineType, Script};++/// The sorting layer of the gridlines+#[derive(Clone, Copy)]+pub enum GridLayer {+    /// The gridlines are rendered in front of the plot+    Front,+    /// The gridlines are rendered behind the plot+    Back,+}++/// The appearence of the major or the minor gridlines+#[derive(Clone, Copy)]+pub struct GridStyle {+    line_width: Option<f64>,+    color: Option<Color>,+    line_type: Option<LineType>,+}++/// The common options of the grid of the plot+#[derive(Clone, Copy)]+pub struct GridOptions {+    layer: Option<GridLayer>,+    major_style: GridStyle,+    minor_style: GridStyle,+}++impl Display<&'static str> for GridLayer {+    fn display(&self) -> &'static str {+        match self {+            GridLayer::Front => "front",+            GridLayer::Back => "back",+        }+    }+}++impl GridStyle {+    /// Sets the line width of the grid+    pub fn line_width(&mut self, width: f64) -> &mut Self {+        self.line_width = Some(width);+        self+    }++    /// Sets the color of the grid+    pub fn color(&mut self, color: Color) -> &mut Self {+        self.color = Some(color);+        self+    }++    /// Sets the line type of the grid+    pub fn line_type(&mut self, line_type: LineType) -> &mut Self {+        self.line_type = Some(line_type);+        self+    }+}++impl<'a> Script for &'a GridStyle {+    fn script(&self) -> String {+        let mut script = String::new();+        if let Some(line_width) = self.line_width {+            script.push_str(&format!("lw {} ", line_width));+        }+        if let Some(color) = self.color {+            script.push_str(&format!("lc rgb '{}' ", color.display()));+        }+        if let Some(line_type) = self.line_type {+            script.push_str(&format!("lt {} ", line_type.display()))+        }+        script+    }+}++impl GridOptions {+    /// Sets the sorting layer of both the major and minor gridlines+    pub fn layer(&mut self, layer: GridLayer) -> &mut Self {+        self.layer = Some(layer);+        self+    }++    /// Configure the major gridlines' style+    pub fn configure_major<F: FnOnce(&mut GridStyle) -> &mut GridStyle>(+        &mut self,+        configure: F,+    ) -> &mut Self {+        configure(&mut self.major_style);+        self+    }++    /// Configure the minor gridlines' style+    pub fn configure_minor<F: FnOnce(&mut GridStyle) -> &mut GridStyle>(+        &mut self,+        configure: F,+    ) -> &mut Self {+        configure(&mut self.minor_style);+        self+    }+}++impl Default for GridOptions {

we can derive defaults here

mfep

comment created time in 19 days

Pull request review commentploteria/ploteria

Improved Grid configuration

 pub struct AxisProperties { impl Default for AxisProperties {

since it looks like we are using all the default values, we can derive default instead and get rid of the impl.

mfep

comment created time in 19 days

PR closed rust-lang/rust

rustc: remove unnecessary extern_prelude logic from ty::item_path. S-waiting-on-author

The checks added in 02357e459be7fb2014f57f1a86b38897c2c0816b effectively turned crate::std into std, but they were too general (affecting any crate::foo where foo was in the extern prelude, not just extern crates), and unnecessary, as only the extern crates created by "std injection" need any special-casing.

I've replaced the check for an extern prelude name with not printing the full path to an extern crate if the span inside the middle::cstore::ExternCrate is a dummy one.

Since this only affects the user-facing "relative" mode, it shouldn't have interactions with linking, and the only observable effect should be sometimes-shorter paths in diagnostics.

r? @nikomatsakis cc @davidtwco

+47 -64

19 comments

3 changed files

eddyb

pr closed time in 19 days

pull request commentrust-lang/rust

rustc: remove unnecessary extern_prelude logic from ty::item_path.

Closing this due to inactivity after a discussion with the author.

eddyb

comment created time in 19 days

pull request commentrust-lang/rust

Improve ayu rustdoc theme

@bors r=GuilliameGomez rollup

Aloso

comment created time in 19 days

pull request commentrust-lang/rust

Improve ayu rustdoc theme

r? @GuillaumeGomez

Aloso

comment created time in 19 days

pull request commentrust-lang/rust

Clean up E0723 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 19 days

pull request commentrust-lang/rust

Small cleanup for E0705 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 19 days

pull request commentrust-lang/rust

Clean up E0710 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 19 days

PR opened evestera/json_typegen

Update linked hashmap to 0.5.3

versions 0.5.1 & 0.5.2 are unsound for linked_hashmap. Bumping this will ensure that dependents are always on a sound version.

Advisory: https://github.com/RustSec/advisory-db/issues/298

+1 -1

0 comment

1 changed file

pr created time in 20 days

push eventDylan-DPC/json_typegen

Dylan DPC

commit sha f4c80e523392d81b851aebf194308dca2a2b2038

Update Cargo.toml

view details

push time in 20 days

fork Dylan-DPC/json_typegen

Tools and libraries to create Rust structs from JSON samples

https://typegen.vestera.as

fork in 20 days

pull request commentrust-lang/rust

Clean up E0716 explanation

@bors r+ rollup

GuillaumeGomez

comment created time in 20 days

pull request commentrust-lang/rust

Add margin after doc search results

@bors r+ rollup

GuillaumeGomez

comment created time in 20 days

more