DougGregor ( Doug Gregor )

Concurrency: support draining the main queue in single threaded mode When built in single threaded mode, the runtime does not use dispatch to queue the tasks. As a result, pumping the dispatch main queue will simply wait indefinitely. In the single threaded mode, simply halt execution and drain all pending tasks before returning. This allows forward progress in the single threaded mode.

view details

Saleem Abdulrasool

commit sha 62f90501580f2aede9260b93c4bb41d0ffa08955

Merge pull request #35584 from compnerd/single-threaded-drain Concurrency: support draining the main queue in single threaded mode

view details

swift-ci

commit sha 321b08a64fb40dea589170c03098c829a60cba4d

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 2 hours

pull request commentapple/swift

Concurrency: avoid `CFRunLoopRun` on non-Darwin

@swift-ci please test macOS platform

compnerd

comment created time in 2 hours

Pull request review commentapple/swift

[SILGen] Enable alternative entry point name.

 ASTContext::SILTransformCtors ASTContext::getIRGenSILTransforms() const {   return passes; } +std::string ASTContext::getEntryPointFunctionName() const {+  std::string name;

Minor option for simplification:

  if (auto name = LangOpts.entryPointFunctionName)
    return name.getValue();
  return "main";

nate-chandler

comment created time in 2 hours

push eventapple/swift

Saleem Abdulrasool

commit sha 4f740a4784586484bf16fc69c1d742daa71520f6

Concurrency: support draining the main queue in single threaded mode When built in single threaded mode, the runtime does not use dispatch to queue the tasks. As a result, pumping the dispatch main queue will simply wait indefinitely. In the single threaded mode, simply halt execution and drain all pending tasks before returning. This allows forward progress in the single threaded mode.

view details

Saleem Abdulrasool

commit sha 62f90501580f2aede9260b93c4bb41d0ffa08955

Merge pull request #35584 from compnerd/single-threaded-drain Concurrency: support draining the main queue in single threaded mode

view details

push time in 2 hours

PR merged apple/swift

Concurrency: support draining the main queue in single threaded mode

When built in single threaded mode, the runtime does not use dispatch to queue the tasks. As a result, pumping the dispatch main queue will simply wait indefinitely. In the single threaded mode, simply halt execution and drain all pending tasks before returning. This allows forward progress in the single threaded mode.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+7 -0

1 commit in compnerd/apple-swift/tree/single-threaded-drain apple/swift/tree/main

9 comments

1 changed file

compnerd

pr closed time in 2 hours

pull request commentapple/swift

[SILGen] Enable alternative entry point name.

Build failed Swift Test Linux Platform Git Sha - e552c1521f325208bbe45803068e5e80394539e1

nate-chandler

comment created time in 2 hours

pull request commentapple/swift

[cxx-interop] Re-implement namespaces using enums + extensions.

@swift-ci please smoke test Windows.

zoecarver

comment created time in 2 hours

push eventapple/swift

Meghana Gupta

commit sha c63a1c0bdf5d39d133f2f0b4420e8d2e404a1437

Use erasePhiArgument instead of eraseArgument in DCE Fixes rdar://73500476

view details

Meghana Gupta

commit sha 45e210bc2f55d04a1e6ad766816943cb59d1c617

Merge pull request #35591 from meg-gupta/fixdcebug Use erasePhiArgument instead of eraseArgument in DCE

view details

swift-ci

commit sha 46b618e7af2fda61a2625fc2dc4f329faeeb6a9d

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 2 hours

push eventapple/swift

Meghana Gupta

commit sha c63a1c0bdf5d39d133f2f0b4420e8d2e404a1437

Use erasePhiArgument instead of eraseArgument in DCE Fixes rdar://73500476

view details

Meghana Gupta

commit sha 45e210bc2f55d04a1e6ad766816943cb59d1c617

Merge pull request #35591 from meg-gupta/fixdcebug Use erasePhiArgument instead of eraseArgument in DCE

view details

push time in 2 hours

PR merged apple/swift

Use erasePhiArgument instead of eraseArgument in DCE

Fixes rdar://73500476

There could be iterator invalidation while deleting edge values. Use api erasePhiArgument which correctly deletes phi arguments.

+1 -2

1 commit in meg-gupta/swift/tree/fixdcebug apple/swift/tree/main

3 comments

1 changed file

meg-gupta

pr closed time in 2 hours

pull request commentapple/swift

[build-script] Add swift-disable-dead-stripping option for disabling dead stripping

Couple of Python test failures:

******************** TEST 'Swift(macosx-x86_64) :: Python/build_swift.swift' FAILED ********************
Script:
--
: 'RUN: at line 10';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/build_swift/run_tests.py
--
Exit Code: 1

Command Output (stderr):
--
.....................................................................................................................................................................................................................................................................................................................F.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
======================================================================
FAIL: test_expected_options_exhaustive (tests.build_swift.test_driver_arguments.TestDriverArgumentParser)
Test that we are exhaustively testing all options accepted by the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/build_swift/tests/build_swift/test_driver_arguments.py", line 418, in test_expected_options_exhaustive
    self.fail('non-exhaustive expected options, missing: {}'
AssertionError: non-exhaustive expected options, missing: {'--swift-disable-dead-stripping'}

----------------------------------------------------------------------
Ran 1039 tests in 33.278s

FAILED (failures=1)

--

********************
PASS: Swift(macosx-x86_64) :: Evolution/test_enum_add_cases_trap.swift (7486 of 14077)
PASS: Swift(macosx-x86_64) :: Evolution/test_conformance_reference.swift (7487 of 14077)
PASS: Swift(macosx-x86_64) :: Evolution/test_enum_add_cases.swift (7488 of 14077)
FAIL: Swift(macosx-x86_64) :: Python/python_lint.swift (7489 of 14077)
******************** TEST 'Swift(macosx-x86_64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--
./utils/build-script:603:1: W293 blank line contains whitespace
./utils/build_swift/build_swift/driver_arguments.py:337:1: W293 blank line contains whitespace

--

********************

mininny

comment created time in 2 hours

pull request commentapple/swift

[Sema] Diagnose type error on Clang type mismatch.

@swift-ci please test source compatibility

varungandhi-apple

comment created time in 2 hours

pull request commentapple/swift

[Sema] Diagnose type error on Clang type mismatch.

@swift-ci please test

varungandhi-apple

comment created time in 2 hours

pull request commentapple/swift

[SR-12033] [Sema] Do not allow inferring defaultable closure `() -> $T` for autoclosure arguments result

No really, it shouldn't collide with that work if everything is done in a stateless manner.

Right! I modify the approach to a way where we don't have a state on the binding set. So let me know what you think :)

LucianoPAlmeida

comment created time in 3 hours

push eventapple/swift

Philippe Hausler

commit sha 6e0524042685283682d5196bbef8f9a8df1e6336

AsyncSequence and protocol conformance rethrows (#35224) * Initial draft of async sequences * Adjust AsyncSequence associated type requirements * Add a draft implementation of AsyncSequence and associated functionality * Correct merge damage and rename from GeneratorProtocol to AsyncIteratorProtocol * Add AsyncSequence types to the cmake lists * Add cancellation support * [DRAFT] Implementation of protocol conformance rethrowing * Account for ASTVerifier passes to ensure throwing and by conformance rethrowing verifies appropriately * Remove commented out code * OtherConstructorDeclRefExpr can also be a source of a rethrowing kind function * Re-order the checkApply logic to account for existing throwing calculations better * Extract rethrowing calculation into smaller functions * Allow for closures and protocol conformances to contribute to throwing * Add unit tests for conformance based rethrowing * Restrict rethrowing requirements to only protocols marked with @rethrows * Correct logic for gating of `@rethrows` and adjust the determinates to be based upon throws and not rethrows spelling * Attempt to unify the async sequence features together * Reorder try await to latest syntax * revert back to the inout diagnosis * House mutations in local scope * Revert "House mutations in local scope" This reverts commit d91f1b25b59fff8e4be107c808895ff3f293b394. * Adjust for inout diagnostics and fall back to original mutation strategy * Convert async flag to source locations and add initial try support to for await in syntax * Fix case typo of MinMax.swift * Adjust rethrowing tests to account for changes associated with @rethrows * Allow parsing and diagnostics associated with try applied to for await in syntax * Correct the code-completion for @rethrows * Additional corrections for the code-completion for @rethrows this time for the last in the list * Handle throwing cases of iteration of async sequences * restore building XCTest * First wave of feedback fixes * Rework constraints checking for async sequence for-try-await-in checking * Allow testing of for-await-in parsing and silgen testing and add unit tests for both * Remove async sequence operators for now * Back out cancellation of AsyncIteratorProtocols * Restructure protocol conformance throws checking and cache results * remove some stray whitespaces * Correct some merge damage * Ensure the throwing determinate for applying for-await-in always has a valid value and adjust the for-await-in silgen test to reflect the cancel changes * Squelch the python linter for line length

view details

swift-ci

commit sha 9f29b005b5dca86cf28322a3440cd2cfaebee0b0

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 3 hours

pull request commentapple/swift

[SILGen] Enable alternative entry point name.

@swift-ci please asan test

nate-chandler

comment created time in 3 hours

pull request commentapple/swift

[SILGen] Enable alternative entry point name.

@swift-ci please clean test

nate-chandler

comment created time in 3 hours

pull request commentapple/swift

[ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds.

@swift-ci test macOS platform

gottesmm

comment created time in 3 hours

push eventapple/swift

Philippe Hausler

commit sha 6e0524042685283682d5196bbef8f9a8df1e6336

AsyncSequence and protocol conformance rethrows (#35224) * Initial draft of async sequences * Adjust AsyncSequence associated type requirements * Add a draft implementation of AsyncSequence and associated functionality * Correct merge damage and rename from GeneratorProtocol to AsyncIteratorProtocol * Add AsyncSequence types to the cmake lists * Add cancellation support * [DRAFT] Implementation of protocol conformance rethrowing * Account for ASTVerifier passes to ensure throwing and by conformance rethrowing verifies appropriately * Remove commented out code * OtherConstructorDeclRefExpr can also be a source of a rethrowing kind function * Re-order the checkApply logic to account for existing throwing calculations better * Extract rethrowing calculation into smaller functions * Allow for closures and protocol conformances to contribute to throwing * Add unit tests for conformance based rethrowing * Restrict rethrowing requirements to only protocols marked with @rethrows * Correct logic for gating of `@rethrows` and adjust the determinates to be based upon throws and not rethrows spelling * Attempt to unify the async sequence features together * Reorder try await to latest syntax * revert back to the inout diagnosis * House mutations in local scope * Revert "House mutations in local scope" This reverts commit d91f1b25b59fff8e4be107c808895ff3f293b394. * Adjust for inout diagnostics and fall back to original mutation strategy * Convert async flag to source locations and add initial try support to for await in syntax * Fix case typo of MinMax.swift * Adjust rethrowing tests to account for changes associated with @rethrows * Allow parsing and diagnostics associated with try applied to for await in syntax * Correct the code-completion for @rethrows * Additional corrections for the code-completion for @rethrows this time for the last in the list * Handle throwing cases of iteration of async sequences * restore building XCTest * First wave of feedback fixes * Rework constraints checking for async sequence for-try-await-in checking * Allow testing of for-await-in parsing and silgen testing and add unit tests for both * Remove async sequence operators for now * Back out cancellation of AsyncIteratorProtocols * Restructure protocol conformance throws checking and cache results * remove some stray whitespaces * Correct some merge damage * Ensure the throwing determinate for applying for-await-in always has a valid value and adjust the for-await-in silgen test to reflect the cancel changes * Squelch the python linter for line length

view details

push time in 3 hours

PR merged apple/swift

Reviewers