profile
viewpoint
Don Jayamanne DonJayamanne Software engineer with a soft spot for .NET and Node.js. Loves tinkering with Arduino and Raspberry Pi. Lives in a cave.

starteddodyg/practical-aspnetcore

started time in 18 hours

issue closedmicrosoft/vscode-python

Editor does refresh after Step-Out

<!-- Please search existing issues to avoid creating duplicates. -->

Environment data

  • VS Code version: XXX
  • Extension version (available under the Extensions sidebar): XXX
  • OS and version: XXX
  • Python version (& distribution if applicable, e.g. Anaconda): XXX
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
  • Relevant/affected Python packages and their versions: XXX
  • Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): XXX

Expected behaviour

XXX

Actual behaviour

XXX

Steps to reproduce:

  1. XXX

<!-- Note: If you think a GIF of what is happening would be helpful, consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ . -->

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

XXX

closed time in 2 days

PaulWaldo

issue commentmicrosoft/vscode-python

Editor does refresh after Step-Out

Closing this issue as no information has been provided.

PaulWaldo

comment created time in 2 days

issue closedmicrosoft/vscode-python

the fuction input()

Issue Type: <b>Bug</b>

When I use the function input() with the plug python, it tells me: StdinNotImplementedError: raw_input was called, but this frontend does not support input requests. but it goes well in python terminal.

Extension version: 2019.6.24221 VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z) OS version: Windows_NT x64 10.0.17134

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>oop_rasterization: disabled_off<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_deferred_display_list: disabled_off<br>skia_renderer: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: disabled_off<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 7.86GB (1.44GB free)
Process Argv
Screen Reader no
VM 0%

</details> <!-- generated by issue reporter -->

closed time in 2 days

ronghan9276

issue commentmicrosoft/vscode-python

the fuction input()

Thanks for reporting this issue. Unfortunately input while debugging is only supported when using the terminal. Please consider using a terminal when debugging if you need to capture input

Please go into launch.json and change the setting "console": "integratedTerminal"

More info can be found here https://code.visualstudio.com/docs/python/debugging#_console

ronghan9276

comment created time in 2 days

issue commentmicrosoft/ptvsd

Support input() in debug console

I was testing this because a issue was mentioned on reddit about input() in debug console.

I'd say they need to use terminal. Again this is not specific to python debugger.

karthiknadig

comment created time in 3 days

issue commentmicrosoft/ptvsd

Support input() in debug console

My question world be what's the UX (work flow)? Are we expecting a displayof some VSCode input box for user to input done text? Personally I'd just tell the user to use a terminal,. This is a exactly why we changed the default to terminal in VSCode for debugging.

If users change to something else then they need to understand the implications. I.e. I'm not convinced we need to provide a solution for this scenario.

This applies to all language debuggers in vscode

karthiknadig

comment created time in 3 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha ef69825ac77ee6c30e31542291608a454e883bf8

Fixes

view details

Don Jayamanne

commit sha 645d28dbe6afdbb99f5aeacd826f35adf9fc8954

Tweeks

view details

push time in 4 days

pull request commentmicrosoft/vscode-python

Prompt to install ptvsd when needed

Maybe we should just do that all the time by default

I'd say yes. Generally debugging should work out of the box without the user having to install more stuff.. Unless it's a special case such as remote debugging etc

IanMatthewHuff

comment created time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 398bb932fbc700937c1701c4c51aac22a59269b2

More fixes

view details

Don Jayamanne

commit sha 3e0ea7281e2c593c5009c079e2f21a6c35112e7d

Minor changes

view details

Don Jayamanne

commit sha 408c69b5b0c1036d1e2734b44dae488dc8997622

Fixes

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha aa35ff800f491e438aa2805d2aada342704cf3f8

Exit if failed

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 5ecb750c74266e5cfc2c205e04d11682d2fb146b

Fixes

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 8c78076599dae593db5ff05f537cb7834b24d892

Oops

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha ce200206386ff4a81940192ffde37e79d5260d5e

Fixes

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha c300c83fea13b632aff3339af047a70d9f946813

Revert

view details

Don Jayamanne

commit sha 63669ebeee8729575d43c87b51ea20ac392a5d3d

Testing

view details

Don Jayamanne

commit sha 34cc84a3be570107fbe46b498cfcbd228b3cad1b

Oops

view details

Don Jayamanne

commit sha 02139d5899c01f3dad7833a07cb901725d5ed63a

Fixes

view details

Don Jayamanne

commit sha 4f5b7d8990dbf5a469774ee7aa2934a0452c765a

Fixes

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 34cc84a3be570107fbe46b498cfcbd228b3cad1b

Oops

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 63669ebeee8729575d43c87b51ea20ac392a5d3d

Testing

view details

push time in 4 days

pull request commentmicrosoft/vscode-python

Prompt to install ptvsd when needed

@IanMatthewHuff is this for remote debugging? Any reason we cannot use the version of PTVSD that already ships with the extension?

IanMatthewHuff

comment created time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 380c5ef23a6e5f559fc79909ff242cc54265937d

test

view details

Don Jayamanne

commit sha 16e7fc0183ed80d890bf4fa5da3a7c6d35767021

Added some logging

view details

Don Jayamanne

commit sha 2d15fcd7c2a3edd7f173b1155ceefa3c2af65e47

Increase offset

view details

Don Jayamanne

commit sha 17aba407c07be146e27983c546d667646e061f91

Oops

view details

Don Jayamanne

commit sha 8e695c35b1bca50dd793f845a06f94b604c4aa40

Take screenshots

view details

Don Jayamanne

commit sha c92ae56511486774b706d193af78a64317a9b82c

Click icons by using enter key

view details

Don Jayamanne

commit sha 1a97bc250908f095a97ac5c3a372fda7e4f6aa37

Smaller tests

view details

Don Jayamanne

commit sha 9f1b76a789d5eb48a49cbb6674df27000e43f3cb

Fixes

view details

Don Jayamanne

commit sha c300c83fea13b632aff3339af047a70d9f946813

Revert

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 9f1b76a789d5eb48a49cbb6674df27000e43f3cb

Fixes

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha c92ae56511486774b706d193af78a64317a9b82c

Click icons by using enter key

view details

Don Jayamanne

commit sha 1a97bc250908f095a97ac5c3a372fda7e4f6aa37

Smaller tests

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 2d15fcd7c2a3edd7f173b1155ceefa3c2af65e47

Increase offset

view details

Don Jayamanne

commit sha 17aba407c07be146e27983c546d667646e061f91

Oops

view details

Don Jayamanne

commit sha 8e695c35b1bca50dd793f845a06f94b604c4aa40

Take screenshots

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 16e7fc0183ed80d890bf4fa5da3a7c6d35767021

Added some logging

view details

push time in 4 days

PR opened microsoft/vscode-python

Wip

For #

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [ ] Title summarizes what is changing
  • [ ] Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.
+20909 -595

0 comment

178 changed files

pr created time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 380c5ef23a6e5f559fc79909ff242cc54265937d

test

view details

push time in 4 days

create barnchDonJayamanne/pythonVSCode

branch : wip

created branch time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha d71f1e16f9480bd15e185b02b2ac3bb11df1ddb0

Fixes

view details

push time in 4 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha af8098b934d77d6464d459689355d0ab0fc07c6b

Updates

view details

push time in 5 days

issue closedmicrosoft/vscode-python

Format Document not working (autopep8, python, vscode)

<!-- Please search existing issues to avoid creating duplicates. -->

Environment data

  • VS Code version: 1.36.0
  • Extension version (available under the Extensions sidebar): 2019.6.22090
  • OS and version: macOS, Mojave 10.14.5
  • Python version (& distribution if applicable, e.g. Anaconda): Python 2.7.16
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Relevant/affected Python packages and their versions: autopep8 1.4.4 pycodestyle: 2.5.0
  • Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): Jedi Enabled is "checked" (so, True?)

Expected behaviour

When I run "Format Document", the file is formatted.

Actual behaviour

When I run "Format Document", the file is not formatted.

Steps to reproduce:

  1. Open a Workspace
  2. Open up a Python File in the Workspace
  3. Right Click -> Format Document

Current Settings:

User Settings (showing only Python related settings):

{
    .
    .
    .
    "workbench.statusBar.visible": true,
    "files.autoSave": "afterDelay",
    "editor.formatOnPaste": true,
    "editor.formatOnSave": true,
    "editor.formatOnSaveTimeout": 1500,
    "python.pythonPath": "/usr/local/bin/python",
    "python.formatting.provider": "autopep8",
    "python.formatting.autopep8Path": "/usr/local/lib/python2.7/site-packages/autopep8.py",
    "python.formatting.autopep8Args": [
        "--max-line-length",
        "70",
        "--aggressive",
        "--aggressive",
        "--in-place"
    ],
    "python.linting.pylintArgs": [
        "--init-hook='import sys; sys.path.append(\"/Users/bagursreenivasamurth/OneDrive - F5 Networks/dev/godev/src/gitswarm.f5net.com/proj/tests/libs\")'"
    ]
}

Workspace Settings:

{
	"folders": [
		{
			"path": "."
		},
		{
			"path": "godev"
		}
	],
	"settings": {
		"python.pythonPath": "/usr/local/bin/python",
	}
}

Extensions:

Extensions

What I have already tried:

  1. Ensured autopep8 is installed correctly to py2.7 : pip2 install --upgrade autopep8
  2. The interpreter seems to be correctly pointing to py2.7 too py27
  3. This works: /usr/local/lib/python2.7/site-packages/autopep8.py --max-line-length 60 --in-place --aggressive --aggressive test.py
  4. This works too: python -m autopep8 --max-line-length 60 --in-place --aggressive --aggressive test.py
  5. autopep8 imported in python interpreter is the same as the one pointing in vscode python.formatting.autopep8Path setting:
$ python
Python 2.7.16 (default, Apr 12 2019, 15:32:40) 
[GCC 4.2.1 Compatible Apple LLVM 10.0.1 (clang-1001.0.46.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import autopep8
>>> autopep8.__file__
'/usr/local/lib/python2.7/site-packages/autopep8.pyc


vscode setting:
 "python.formatting.autopep8Path": "/usr/local/lib/python2.7/site-packages/autopep8.py"
  1. Uninstalled all extensions, reloaded. Reinstalled all extensions.
  • When I had uninstalled all extensions, including Python. On "Format Document", I got a prompt asking me to choose formatter.
  • After reinstalling all extensions, including Python. On "Format Document", I get no prompt. I'm guessing it is honoring my user settings. onFormatSave-disabled-extensions

Meanwhile,

$ which python
/usr/local/bin/python

$ python --version
Python 2.7.16

<!-- Note: If you think a GIF of what is happening would be helpful, consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ . -->

Logs

  1. No output in "Output" when I run "Format Document"
  2. Console log on Developer Tools on "Format Document" onFormatDocument

closed time in 5 days

sanathkumarbs

issue commentmicrosoft/vscode-python

Format Document not working (autopep8, python, vscode)

Thanks for getting back. When you use In-place then no response is sent as the output, hence it's assumed that there's nothing to be formatted (i.e. code has already been formatted).

Closing as this issue has been resolved.

sanathkumarbs

comment created time in 5 days

issue commentmicrosoft/vscode-python

Jedi Enabled only works in User Setting, can't work in Workspace Setting or Remote Setting.

Please can you select workspace from the above UI, then disable Jedi, that should work. Please send screenshots when done

messi-yang

comment created time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 469c62268a313bb220acbb3913b99a43d8a91ab8

Fixes

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha c2911c69e886958987ac85756d9f1f6c0f11385d

Yay

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 433651947c049ad550e7453f377d609b4947c23f

Capture times

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha a4115ef09f4739ba6f634c5fe9c0afcb5d354306

Fixes

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 35814b0b23aef7bc002ad84515e90719088f2dce

oops

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 30924e3bdfb6d7619dc1a7967abc0fc85eaeab0c

Test

view details

Don Jayamanne

commit sha 8c31f9e38488a53b9e3b08c096d0c43baf41a6a7

Log name

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha c815e6eb60a27e763cbc83ab6937a1526fb266e5

Log to file

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 7a8413f1da5f7cb05caadd625d2251041bd8ad9e

Initialize shell

view details

push time in 5 days

issue closedmicrosoft/vscode-python

Loading modules in integrated terminal error ?

I'm trying to load binaries and libraries needed by a module so I'm appending the PATH variable inside my workspace settings within terminal.integrated.env.windows setting; then running the code in an interactive python shell although when I do, I get an error that a DLL failed to load ?

closed time in 5 days

SheepDomination

issue commentmicrosoft/vscode-python

Loading modules in integrated terminal error ?

Thanks for filing this issue, it doesn't seem to be an issue with the extension. Not sure what you mean by tell the interpreter to load a python module. It sounds more like a generic python python question (about running code, loading packages, and the like), please file an issue on Stack overflow.

SheepDomination

comment created time in 5 days

issue commentmicrosoft/vscode-python

error running pylint

Every time I open vs code editor I see an error message notification as "Error in running pylint" Source: Python (Extension)

Thanks for reporting this issue, however without the logs I cannot help you. Please take the time to fill in the issue template when filing issues.

devnov26

comment created time in 5 days

issue commentmicrosoft/vscode-python

Format Document not working (autopep8, python, vscode)

"python.formatting.autopep8Path": "/usr/local/lib/python2.7/site-packages/autopep8.py"

Please remove the above setting, and then select the required interpreter from the statusbar or using the command Python: Select Interpreter. (using the approach you have used might not always work as the file is a .py file and not an executable. We expect autopep8Path to be an executable)

Not 100% certain this is the same issue, but I am seeing similar behaviour with the yapf formatter - but only in certain sub-directories of a project.

@coldino Please create a separate issue if it still persists.

sanathkumarbs

comment created time in 5 days

issue commentmicrosoft/vscode-python

Jedi Enabled only works in User Setting, can't work in Workspace Setting or Remote Setting.

Thanks for reporting this issue. However this works for me and others.

Open Setting by click "Command + ,", Switch to Workspace Setting to enable "Jedi Enabled"

Please could you let me where this workspace setting file is located.

messi-yang

comment created time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha f1dfff7fc870f2a574bc97c72020952a9eb8b00b

Fixes

view details

push time in 5 days

issue commentmicrosoft/vscode

Debugger overwrites file contents saved with :w - causes lost work

@weinand VS Code saves the changes made to the file before the debugger starts. I.e. its not the extension that saves changes to the file.

ReggieMarr

comment created time in 5 days

issue closedmicrosoft/vscode-python

Debugger overwrites files ocasionally

This issue was originally tracked here.

Behaviour is as follows: files which are referenced during a debugger session seem to get overwritten to some previous state (usually the state that the file was in when vscode was opened). It also seem to actually be saving the file after doing this as I've noticed that the timestamp changes on the file. I have also tried opening the file after saving with VI to check that it is in fact saved properly (it is) and then I have tried saving it with VI but still the debugger seems to overwrite the file back to the state it was in when vscode was opened some previous state and then save the file, thus overwriting any changes.

closed time in 5 days

ReggieMarr

issue commentmicrosoft/vscode-python

Debugger overwrites files ocasionally

Thanks for reporting this issue, I'm closing this as VS Code automatically saves changes to the file before debugging.

ReggieMarr

comment created time in 5 days

delete branch microsoft/vscode-python

delete branch : dependabot/npm_and_yarn/lodash-4.17.13

delete time in 5 days

push eventmicrosoft/vscode-python

dependabot[bot]

commit sha 360620dd224d9559ef241f8898c3aab1eb1e1842

Bump lodash from 4.17.11 to 4.17.13 (#6540) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.13) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 5 days

PR merged microsoft/vscode-python

Bump lodash from 4.17.11 to 4.17.13 dependencies javascript skip news

Bumps lodash from 4.17.11 to 4.17.13. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+17 -17

0 comment

2 changed files

dependabot[bot]

pr closed time in 5 days

issue commentmicrosoft/vscode-python

Adopt vscode.env.shell

To validate:

  • Use VSC Insiders
Tyriar

comment created time in 5 days

issue closedmicrosoft/vscode-python

Update Pyramid debug template to use `python -m pyramid.scripts.pserve`

Hi there has been an issue reported before where the "Pyramid" debug option tries to find the wrong pserve on some platforms.

https://github.com/Microsoft/vscode-python/pull/530

The fix was submitted here:

https://github.com/Microsoft/vscode-python/pull/530/commits/f22b4510d22a3e7eb01db5509dc81c83b3f12071

And it added this block of code to fix it, which uses pserve.exe on Windows and pserve on everything else: https://github.com/jpfarias/vscode-python/blob/master/src/client/debugger/Main.ts#L217-L224

I don't believe this fix was sufficient as today using VSCode 1.26.1 and vscode-python 2018.7.1 I was getting launch error Unable to locate 'pserve.py' required for debugging Pyramid application

Solution for me was to just not try to use the "program" launch style, but instead use the "module" launch style like the "flask" example. I think you guys should consider changing the default to this as it is simpler to understand ..... and deprecate the custom DebugOption as it is not required nor simpler:

    {
            "name": "Python: Pyramid",
            "type": "python",
            "request": "launch",
            "module": "pyramid.scripts.pserve",
            "args": [
                "${workspaceFolder}/development.ini"
            ],
            "debugOptions": [
                "RedirectOutput",
            ]
        }

closed time in 5 days

JDeuce

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 872a5591a68d30e7a6bfe6293a9607d682fc324c

More stuff

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha b752edc03eeab231cd5550b4de8f9c0d65421e47

Both

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha af40c255594675e1a9380c14c75dd0bb3c2d6640

Run all tests

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 40f2d44c1d81778c263e68f3b72db46d3b28a534

Wait longer

view details

Don Jayamanne

commit sha eea8f97a99f9a0e92bd161839951283a6fc2dbd4

logging

view details

push time in 5 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha ce069252cd9bfbb200b94590cc46d70de602fe74

Oops

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha e33add77bb80839823f8817626e447367cb8f6fc

Fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha f34a55131f6dd63528574ae8d08ee0660da29307

Use logger

view details

Don Jayamanne

commit sha f439f84cfabe35398026498127ffbfc87d907637

Revert

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 9fe5fd44089a26517bf27d28193cdcaced1a8999

Pattern search

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 92d60769cf715fd820925535520e8593ddbfeace

Better open file

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 77de440d4424c2065784709f9340635e28d02cf3

Refresh

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 6d40feeaabc2f37921a333724ef89823bac6648e

Refresh

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 6a7c26bdd55d6404cd67c457ad004e3594249735

Fix logger

view details

Don Jayamanne

commit sha 032ff9340f061bccf853cbe2997fd5f7ef06788d

More logging

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha edfba6c0b209578430dd71989d6962d9a4f9d245

More fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 21cef5e421d7721e314af4817b3d0c6b5becd020

Refresh explorer to ensure file is displayed

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 57222683ce7588edcacfd8ec3e5ab18b4efb4829

Better logging

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha de1bef085097854f856990b8dc2f3e874689c914

Increase timeout

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha af465661e1c0001faba46205c637dfeb1b9a515d

Fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 42a1678972a2ecd2b6936ea3e338a4fe923d8a61

Debugging screenshots

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 3ca8f67dd1b52ccd716c3ce2e9e82b4187b5e912

oops

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha de6360b590faf61361fd74de1a399e9f44a113e4

test wip

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha f1c28ecd52fcd8790639b7cf329379df4b32eaad

Log to file

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 7c85025b335b1bac3116c7c901f40c4abbda5bf6

better logging

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 19e618a6ec0d8c643525d02e0d43a8c5ba400496

Fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 4b1e24a63b674384eb054e5ef094e92442f46c62

Fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 19361dd7e165b79e8f1ce6d44736ff5b511ab2ce

Reduce logging

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha effb2bf6a1bfef930e1a90c7af1a293967926740

Testing

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 16dc3eaee24558be33c1fff735859b4beb62c317

logging

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha fd97b12ab2fea0c04ec901feac3917b36e859162

Run in PR

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha f04614a3bcf976ee4a7042e9088da8fa7b6e786f

Log

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha a55a891a70ecd80457f2945b9b1cc10f9a7c8e52

More logging

view details

Don Jayamanne

commit sha a8a5f4cbbf0a592eea4de27939e4185cc0c95bf1

Merge branch 'fixesToConda' of github.com:DonJayamanne/pythonVSCode into fixesToConda * 'fixesToConda' of github.com:DonJayamanne/pythonVSCode: Fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha c45dc0c9db9c10e02ab9f5bbdccf16a62f383713

Fixes

view details

push time in 6 days

push eventmicrosoft/vscode-python

Don Jayamanne

commit sha 47db2f79df62414afe59e7816a3e4091464d9c08

Detect shell in VSCode using the VSC API (#6403) * Move shell detectors into separate classes * Detect shell using VSC API

view details

push time in 6 days

PR merged microsoft/vscode-python

Detect shell in VSCode using the VSC API

For #6050

Depends on https://github.com/microsoft/vscode-python/pull/6401

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [x] Title summarizes what is changing
  • [x] Has a news entry file (remember to thank yourself!)
  • [x] Appropriate comments and documentation strings in the code
  • [x] Has sufficient logging.
  • [x] Has telemetry for enhancements.
  • [x] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.
+128 -27

0 comment

11 changed files

DonJayamanne

pr closed time in 6 days

PR closed microsoft/vscode-python

Bump lodash.template from 4.4.0 to 4.5.0 dependencies javascript

Bumps lodash.template from 4.4.0 to 4.5.0. <details> <summary>Commits</summary>

  • ab73503 Bump to v4.5.0.
  • a4f7d4c Rebuild lodash and docs.
  • cca5ac6 Fix npm-test by removing the call to test-docs.
  • 9f7f9fc Adjust heading order. [ci skip]
  • 6e2fb92 Remove unused baseArity.
  • 4f702e2 Specify utf8 encoding.
  • b188f90 Add fp tests for iteratee shorthands.
  • 7b93dc9 Ensure clone methods clone expando properties of boolean, number, & string ob...
  • 664d66a Make string tests more consistent.
  • d9dc0e6 Add _.invertBy tests.
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+33 -26

0 comment

1 changed file

dependabot[bot]

pr closed time in 6 days

Pull request review commentmicrosoft/vscode-python

Added ability to auto update Insiders build of extension

+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+'use strict';
+
+import { inject, injectable } from 'inversify';
+import { ConfigurationChangeEvent, ConfigurationTarget, Event, EventEmitter } from 'vscode';
+import { IApplicationEnvironment, IWorkspaceService } from '../application/types';
+import { traceDecorators } from '../logger';
+import { IConfigurationService, IDisposable, IDisposableRegistry, IPersistentState, IPersistentStateFactory, IPythonSettings } from '../types';
+import { ExtensionChannel, ExtensionChannels, IExtensionChannelService } from './types';
+
+export const insidersChannelSetting: keyof IPythonSettings = 'insidersChannel';
+export const isThisFirstSessionStateKey = 'IS_THIS_FIRST_SESSION_KEY';
+
+@injectable()
+export class ExtensionChannelService implements IExtensionChannelService {
+    public readonly isThisFirstSessionState: IPersistentState<boolean>;
+    public _onDidChannelChange: EventEmitter<ExtensionChannels> = new EventEmitter<ExtensionChannels>();
+    constructor(
+        @inject(IApplicationEnvironment) private readonly appEnvironment: IApplicationEnvironment,
+        @inject(IConfigurationService) private readonly configService: IConfigurationService,
+        @inject(IWorkspaceService) private readonly workspaceService: IWorkspaceService,
+        @inject(IPersistentStateFactory) private readonly persistentStateFactory: IPersistentStateFactory,
+        @inject(IDisposableRegistry) disposables: IDisposable[]
+    ) {
+        this.isThisFirstSessionState = this.persistentStateFactory.createGlobalPersistentState(isThisFirstSessionStateKey, true);
+        disposables.push(this.workspaceService.onDidChangeConfiguration(this.onDidChangeConfiguration.bind(this)));
+    }
+    public get channel(): ExtensionChannels {
+        const settings = this.workspaceService.getConfiguration('python').inspect<ExtensionChannels>(insidersChannelSetting);
+        if (!settings) {
+            throw new Error(`WorkspaceConfiguration.inspect returns 'undefined' for setting 'python.${insidersChannelSetting}'`);
+        }
+        if (settings.globalValue === undefined) {
+            const isThisFirstSession = this.isThisFirstSessionState.value;
+            this.isThisFirstSessionState.updateValue(false);

This will not work. If this method channel is called again, the variable isThisFirstSession couild still return true. That's because the update is async, but this is a read only property where things are synchronous. As you are performing such updates, please change this into a method.

karrtikr

comment created time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha f204f51c88b17589d02c2a44b5b812a6b0d17190

Fixes

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 928b2833c29a59a17f6664dd75294c148734de11

Fixes to tests

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha 2b281d20b3c97bb1230e0f504e329f6a257cda24

Fixes

view details

Don Jayamanne

commit sha 468ff2fd774b4fec964dacfe0fc806bd70100893

Merge branch 'fixesToConda' of https://github.com/DonJayamanne/pythonVSCode into fixesToConda

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Don Jayamanne

commit sha f6a18c935313a4ca19f358e71d142c27356b7419

Temp

view details

push time in 6 days

push eventDonJayamanne/pythonVSCode

Kim-Adeline Miguel

commit sha f53a1bee26516fea9a0aa1967ec48e81b60bc2b3

Temporarily disable smoke tests (#6447)

view details

Kim-Adeline Miguel

commit sha 4d5153617b603421eb5a3c24ee960dc4ce14af71

Disable CI smoke tests (#6448)

view details

Kim-Adeline Miguel

commit sha 3695395ad55a47d9dce6ca756ec74516c89ff3a4

Fix multiroot workspace tests caused by logging PR (#6443) * Fix multiroot workspace tests * Formatting (trigger build)

view details

Kim-Adeline Miguel

commit sha c827adde008cdd80bcb36fe486d57e401517aeb2

Unit tests - processFactory.ts (#6418) * News file * Add logging to ProcessService * Undo changes, move to a new class * Fix existing unit tests * Simplify logger * Add logger unit tests * PR comment fixes * More PR changes, prettify command, add unit tests * More test fixes * Test fixes, again * Use nodejs' event emitter instead of vscode's * Remove dead code * PR comment fixes * Shorten cwd copy, add quotes to args with spaces * Don't exclude first arg from being formatted * Prettier-ified logger.ts and logger.unit.test.ts * Address comment * unit tests * refactor processFactory to use ioc * update debugAdapter too * Fix linting functional tests

view details

Rich Chiodo

commit sha 257b970defaecc84ed330c78629a84c5d90218ed

Support break on enter for debugging (#6450) * Support break on enter for debugging * Fix breakpoints not messing up entry breakpoint * Fix problem with multiple files

view details

Kim-Adeline Miguel

commit sha 0619623a0a04fc60c7cce23bf999e769d500ffa2

Disable smoke tests in nightly build (#6455)

view details

Rich Chiodo

commit sha 5dd5a4c71b5e311930f5328eaabc7a48bd1accd9

Add IProcessLogger to the datascience IOC container for nightly runs (#6467) * Fix nightly test failures for datascience * Fix other failure masked by IProcessLogger

view details

Brett Cannon

commit sha 66de533a2a72276f16d82d6d4494cebee47e63bd

Simplify Pyramid debug configuration (#6458)

view details

Rich Chiodo

commit sha 9d48ebcdb9d62d13d24e4f301754ece655e15d4c

Make step over work at the end of a cell. (#6489)

view details

Don Jayamanne

commit sha 0eb059bc8596df8165ac4311d3182233588df0e4

Move shell detectors into separate classes (#6401) * Move shell detectors into separate classes

view details

Kim-Adeline Miguel

commit sha d69efaee6be3e86d75cbc3fdf40b870f00d664e0

Fix indentation after string literals containing escaped characters (#6440) * Update indent regex * Prettier formatting * Add regex tests * Undo prettier changes * Forgot some * One more * Simplify & fix tests * More descriptive comment * Move language config to another file * Remove unneeded tslint disable rule

view details

Min ho Kim

commit sha 8b6953894331a32cff1550b4d55bf9bd72a5fa51

Fix typos (#6470) * Fix typos * Fix typos

view details

Janosh Riebesell

commit sha 16e0af58a58c2f6863cec508693adaa06bb038f1

Add feature flag magicCommandsAsComments (#6408) (#6494) * Add feature flag magicCommandsAsComments (#6408) * Add 6408.md into news/1 Enhancements * Fix regex white space capturing * Shorten magicCommandsAsComments flag description

view details

Rich Chiodo

commit sha eae03ed1f02f57b5c15fcbf88e50ee66cb5d3e8e

Add functional test for debugging jupyter cells (#6510) * Preliminary idea * More logging * Actual responses coming back * Get debugger basic test working Fix all the Promise.race(sleep) code to cancel the timer, as this timer can hang a test * Fix restart problems Add breakpoint test * Add breakpoint in another file test Add functional requirements so can find ptvsd on test machine * Add news entries * Fix logging to a file and a linter issue * Add back logToFile but commented out. * Fix functional tests and rework how waitForPromise behaves

view details

Kim-Adeline Miguel

commit sha a4c6eeda5f075e15346b713f9275afaffe6b92aa

Cherry pick release 2019.6.1 into master (#6519) * Fix experiments hash parsing (#6492) * Simplify & fix crypto.createHash * Add tests * Fix python test in news folder (#6398) * Fix broken python tests in news * Revert changes * Release cherry pick (#6515) * Enable experiment for always displaying the test explorer (#6330) * Add logging * Point release - Updated package.json and CHANGELOG (#6516)

view details

David Kutugata

commit sha 58b5c809bcc0b790a334bc19d1bfca8c4eca59e6

Install jupyter if its not found (#6421) * fixed issue 5682, promt user to install jupyter if its not found * moved the jupyter installation to codewatcher * changed the error handler to be its own separate object * removed serviceContainer from the data science error handler * added jupyter to the productService map * added jupyter to a function in the productInstaller * added the data science productType * excluded jupyter installation from a test * removed jupyter from product installer * added jupyter back to product installer * added a productPath test for dataScience * excluded jupyter from checking if its installed on the product installer * Added DataScienceProductPathService to 3 tests * added done(to two tests) * added a binding of IDataScienceErrorHandler * added IInstallationChannelManager binding * added jupyter as an exception to 'getNamesAndValues' test * added jupyter as an exception to the 'getNamesAndValues' test * localized a new string from productInstaller.ts

view details

Ian Huff

commit sha 11d11454b39325dd3ad1ff533d476bc351b580a0

Fix long run time bug and limit text output lines (#6518)

view details

Don Jayamanne

commit sha aebadfbc87f158fdb9807b2c5319b6ad4b515cfd

Temporarily disable test (#6529)

view details

Brett Cannon

commit sha a16337b8c91fffb0704a7d2ca64cf66b32606bc3

Clean up telemetry (#6500)

view details

Don Jayamanne

commit sha f17218717ad66d2a9ad7526fe295f38825657fa5

Fixes

view details

push time in 6 days

PR opened microsoft/vscode-python

WIP - Fixes

For #

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [ ] Title summarizes what is changing
  • [ ] Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.
+53 -2

0 comment

1 changed file

pr created time in 6 days

create barnchDonJayamanne/pythonVSCode

branch : fixesToConda

created branch time in 6 days

PR opened microsoft/vscode-python

WIP

For #

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [ ] Title summarizes what is changing
  • [ ] Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.
+66 -0

0 comment

1 changed file

pr created time in 6 days

more