DonJayamanne ( Don Jayamanne )

@ST33LDI9ITAL commented on Sun May 19 2019

<!-- Do you have a question instead of a bug report or enhancement request? Please ask it on https://stackoverflow.com/questions/tagged/visual-studio-code+python.

Unable to install a linter or formatter? 'No installers available'? Windows - https://stackoverflow.com/questions/4750806/how-do-i-install-pip-on-windows Linux - https://www.cyberciti.biz/faq/debian-ubuntu-centos-rhel-linux-install-pipclient/ , https://www.tecmint.com/install-pip-in-linux/

Python configuration issues? Please check https://code.visualstudio.com/docs/python/python-tutorial#_prerequisites

Otherwise please fill in the requested details below. "XXX" markers should not be present in the final bug report.

If you think a GIF of what is happening would be helpful, consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ . -->

Environment data

VS Code version: 1.35.0-insider
Extension version (available under the Extensions sidebar): 2019.4.12954
OS and version: Win 10x64 10.0.17763
Python version (& distribution if applicable, e.g. Anaconda): CPython 3.7.3 and WinPy 3.7.2
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: XXX

Expected behaviour

Venv to be detected and activated Debugging to work with venv

Actual behaviour

Doesn't detect or activate venv Debugging doesn't work with venv, no breakpoints trip

Steps to reproduce:

Set python path to "python.pythonPath": "${workspaceFolder}\Scripts\python.exe", Open python venv project folder, open any file, set breakpoints, run debug

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Starting Microsoft Python language server.
##########Linting Output - pylint##########

--------------------------------------------------------------------

Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)



[Info  - 8:03:49 PM] GetCurrentSearchPaths c:\Dev\Python\examples\Scripts\python.exe 
[Info  - 8:03:49 PM] Python search paths:
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64\dlls
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64\lib
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64
[Info  - 8:03:49 PM]     c:\dev\python\examples
[Info  - 8:03:49 PM]     c:\dev\python\examples\lib\site-packages
[Info  - 8:03:49 PM] Configuration search paths:
[Info  - 8:03:53 PM] Microsoft Python Language Server version 0.2.82.0
[Info  - 8:03:53 PM] Initializing for c:\Dev\Python\examples\Scripts\python.exe



---

@webji commented on [Sun May 19 2019](https://github.com/microsoft/vscode-python/issues/5690#issuecomment-493829939)

Same issue:

Version: 1.35.0-insider (system setup)
Commit: 6ac87465f297a9068bf767f45d6f372fc5697de9
Date: 2019-05-17T17:48:07.036Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763



---

@DonJayamanne commented on [Mon May 20 2019](https://github.com/microsoft/vscode-python/issues/5690#issuecomment-494077472)

Issue moved to [microsoft/ptvsd #1439](https://github.com/microsoft/ptvsd/issues/1439) via [**ZenHub**](https://www.zenhub.com/)

created time in 12 hours

issue commentmicrosoft/vscode-python

Issue moved to microsoft/ptvsd #1439 via ZenHub

ST33LDI9ITAL

comment created time in 12 hours

issue closedmicrosoft/vscode-python

<!-- Do you have a question instead of a bug report or enhancement request? Please ask it on https://stackoverflow.com/questions/tagged/visual-studio-code+python.

Unable to install a linter or formatter? 'No installers available'? Windows - https://stackoverflow.com/questions/4750806/how-do-i-install-pip-on-windows Linux - https://www.cyberciti.biz/faq/debian-ubuntu-centos-rhel-linux-install-pipclient/ , https://www.tecmint.com/install-pip-in-linux/

Python configuration issues? Please check https://code.visualstudio.com/docs/python/python-tutorial#_prerequisites

Otherwise please fill in the requested details below. "XXX" markers should not be present in the final bug report.

If you think a GIF of what is happening would be helpful, consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ . -->

Environment data

VS Code version: 1.35.0-insider
Extension version (available under the Extensions sidebar): 2019.4.12954
OS and version: Win 10x64 10.0.17763
Python version (& distribution if applicable, e.g. Anaconda): CPython 3.7.3 and WinPy 3.7.2
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: XXX

Expected behaviour

Venv to be detected and activated Debugging to work with venv

Actual behaviour

Doesn't detect or activate venv Debugging doesn't work with venv, no breakpoints trip

Steps to reproduce:

Set python path to "python.pythonPath": "${workspaceFolder}\Scripts\python.exe", Open python venv project folder, open any file, set breakpoints, run debug

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Starting Microsoft Python language server.
##########Linting Output - pylint##########

--------------------------------------------------------------------

Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)



[Info  - 8:03:49 PM] GetCurrentSearchPaths c:\Dev\Python\examples\Scripts\python.exe 
[Info  - 8:03:49 PM] Python search paths:
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64\dlls
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64\lib
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64
[Info  - 8:03:49 PM]     c:\dev\python\examples
[Info  - 8:03:49 PM]     c:\dev\python\examples\lib\site-packages
[Info  - 8:03:49 PM] Configuration search paths:
[Info  - 8:03:53 PM] Microsoft Python Language Server version 0.2.82.0
[Info  - 8:03:53 PM] Initializing for c:\Dev\Python\examples\Scripts\python.exe

closed time in 12 hours

ST33LDI9ITAL

issue openedmicrosoft/ptvsd

WIP - Added support for A/B testing and staged rollouts of new functionality

@ST33LDI9ITAL commented on Sun May 19 2019

<!-- Do you have a question instead of a bug report or enhancement request? Please ask it on https://stackoverflow.com/questions/tagged/visual-studio-code+python.

Unable to install a linter or formatter? 'No installers available'? Windows - https://stackoverflow.com/questions/4750806/how-do-i-install-pip-on-windows Linux - https://www.cyberciti.biz/faq/debian-ubuntu-centos-rhel-linux-install-pipclient/ , https://www.tecmint.com/install-pip-in-linux/

Python configuration issues? Please check https://code.visualstudio.com/docs/python/python-tutorial#_prerequisites

Otherwise please fill in the requested details below. "XXX" markers should not be present in the final bug report.

If you think a GIF of what is happening would be helpful, consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ . -->

Environment data

VS Code version: 1.35.0-insider
Extension version (available under the Extensions sidebar): 2019.4.12954
OS and version: Win 10x64 10.0.17763
Python version (& distribution if applicable, e.g. Anaconda): CPython 3.7.3 and WinPy 3.7.2
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: XXX

Expected behaviour

Venv to be detected and activated Debugging to work with venv

Actual behaviour

Doesn't detect or activate venv Debugging doesn't work with venv, no breakpoints trip

Steps to reproduce:

Set python path to "python.pythonPath": "${workspaceFolder}\Scripts\python.exe", Open python venv project folder, open any file, set breakpoints, run debug

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Starting Microsoft Python language server.
##########Linting Output - pylint##########

--------------------------------------------------------------------

Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)



[Info  - 8:03:49 PM] GetCurrentSearchPaths c:\Dev\Python\examples\Scripts\python.exe 
[Info  - 8:03:49 PM] Python search paths:
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64\dlls
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64\lib
[Info  - 8:03:49 PM]     c:\python\winpy\python-3.7.2.amd64
[Info  - 8:03:49 PM]     c:\dev\python\examples
[Info  - 8:03:49 PM]     c:\dev\python\examples\lib\site-packages
[Info  - 8:03:49 PM] Configuration search paths:
[Info  - 8:03:53 PM] Microsoft Python Language Server version 0.2.82.0
[Info  - 8:03:53 PM] Initializing for c:\Dev\Python\examples\Scripts\python.exe



---

@webji commented on [Sun May 19 2019](https://github.com/microsoft/vscode-python/issues/5690#issuecomment-493829939)

Same issue:

Version: 1.35.0-insider (system setup)
Commit: 6ac87465f297a9068bf767f45d6f372fc5697de9
Date: 2019-05-17T17:48:07.036Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

created time in 12 hours

issue commentmicrosoft/vscode-python

Matplotlib SIGSEV error

Issue moved to microsoft/ptvsd #1437 via ZenHub

narekmargaryan

comment created time in 13 hours

issue closedmicrosoft/vscode-python

Matplotlib SIGSEV error

Running on Ubuntu 19.04.

All works fine when I launch the terminal (externally, not within the VS Code) and run the .py from there. As soon as I try to debug inside Code or even run the file from the embedded terminal, I receive

"fish: “env PYTHONIOENCODING=UTF-8 PYTH…” terminated by signal SIGSEGV (Address boundary error)"

on the line where I call 'plt' for the first time (i.e. plt.plot([1,2,3]) for example).

When I launch in the external terminal (again, from within Code), I receive:

bash: line 1: 6635 Segmentation fault (core dumped) ''/usr/bin/python3 /home/user/.vscode/extensions/ms-python.python-2019.4.12954/pythonFiles/ptvsd_launcher.py --default --client --host localhost --port 44817 /home/user/Documents/Projects/test.py

closed time in 13 hours

narekmargaryan

issue openedmicrosoft/ptvsd

Matplotlib SIGSEV error

@narekmargaryan commented on Sun May 19 2019

Running on Ubuntu 19.04.

All works fine when I launch the terminal (externally, not within the VS Code) and run the .py from there. As soon as I try to debug inside Code or even run the file from the embedded terminal, I receive

"fish: “env PYTHONIOENCODING=UTF-8 PYTH…” terminated by signal SIGSEGV (Address boundary error)"

on the line where I call 'plt' for the first time (i.e. plt.plot([1,2,3]) for example).

When I launch in the external terminal (again, from within Code), I receive:

bash: line 1: 6635 Segmentation fault (core dumped) ''/usr/bin/python3 /home/user/.vscode/extensions/ms-python.python-2019.4.12954/pythonFiles/ptvsd_launcher.py --default --client --host localhost --port 44817 /home/user/Documents/Projects/test.py

created time in 13 hours

Pull request review commentmicrosoft/vscode-python

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++'use strict';++import { inject, injectable, named } from 'inversify';+import { Uri } from 'vscode';+import { IHttpClient } from '../activation/types';+import { sendTelemetryEvent } from '../telemetry';+import { EventName } from '../telemetry/constants';+import { IApplicationEnvironment, IWorkspaceService } from './application/types';+import { STANDARD_OUTPUT_CHANNEL } from './constants';+import { traceDecorators, traceError } from './logger';+import { ICryptoUtils, IExperimentsManager, IOutputChannel, IPersistentState, IPersistentStateFactory, Resource } from './types';+import { Experiments } from './utils/localize';++const EXPIRY_DURATION_MS = 30 * 60 * 1000;+const experimentStorageKey = 'EXPERIMENT_STORAGE_KEY';+const configUri = 'https://raw.githubusercontent.com/karrtikr/check/master/environments.json';++type AB_Experiments = { name: string; salt: string; min: number; max: number }[];+@injectable()+export class ExperimentsManager implements IExperimentsManager {+    private experimentStorage: IPersistentState<AB_Experiments | undefined>;+    private activatedWorkspaces = new Map<string, boolean>();+    private resource: Resource;+    constructor(+        @inject(IPersistentStateFactory) private readonly persistentStateFactory: IPersistentStateFactory,+        @inject(IWorkspaceService) private readonly workspaceService: IWorkspaceService,+        @inject(IHttpClient) private readonly httpClient: IHttpClient,+        @inject(ICryptoUtils) private readonly crypto: ICryptoUtils,+        @inject(IApplicationEnvironment) private readonly appEnvironment: IApplicationEnvironment,+        @inject(IOutputChannel) @named(STANDARD_OUTPUT_CHANNEL) private readonly output: IOutputChannel+    ) {+        this.experimentStorage = this.persistentStateFactory.createGlobalPersistentState<AB_Experiments | undefined>(experimentStorageKey, undefined, EXPIRY_DURATION_MS);+    }++    public async activate(resource: Uri): Promise<void> {+        if (this.activatedWorkspaces.has(this.getWorkspacePathKey(resource))) {+            return;+        }+        this.activatedWorkspaces.set(this.getWorkspacePathKey(resource), true);+        this.resource = resource;+        this.initializeInBackground().ignoreErrors();+    }++    @traceDecorators.error('Failed to initialize experiments')+    public async initializeInBackground() {+        if (this.isTelemetryDisabled() || this.experimentStorage.value) {+            return;+        }+        const downloadedExperiments = await this.httpClient.getJSONC<AB_Experiments>(configUri);+        await this.experimentStorage.updateValue(downloadedExperiments);+    }++    public inExperiment(experimentName: string): boolean {+        try {+            const experiments = this.experimentStorage.value ? this.experimentStorage.value : [];+            const experiment = experiments.find(exp => exp.name === experimentName);+            if (!experiment) {+                return false;+            }+            const inExp = this.isUserInRange(experiment.min, experiment.max, experiment.salt);+            if (inExp) {+                sendTelemetryEvent(EventName.PYTHON_EXPERIMENTS, undefined, { expName: experimentName });+                // tslint:disable-next-line:messages-must-be-localized+                this.output.appendLine(Experiments.inGroup().format(experimentName));+                return true;+            }+        } catch (ex) {+            traceError('Failed to check if user is in experiment', ex);

            traceError(`Failed to check if user is in experiment '{experimentName}'`, ex);

karrtikr

comment created time in 13 hours

Pull request review commentmicrosoft/vscode-python

WIP - Added support for A/B testing and staged rollouts of new functionality

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++'use strict';++import { inject, injectable, named } from 'inversify';+import { Uri } from 'vscode';+import { IHttpClient } from '../activation/types';+import { sendTelemetryEvent } from '../telemetry';+import { EventName } from '../telemetry/constants';+import { IApplicationEnvironment, IWorkspaceService } from './application/types';+import { STANDARD_OUTPUT_CHANNEL } from './constants';+import { traceDecorators, traceError } from './logger';+import { ICryptoUtils, IExperimentsManager, IOutputChannel, IPersistentState, IPersistentStateFactory, Resource } from './types';+import { Experiments } from './utils/localize';++const EXPIRY_DURATION_MS = 30 * 60 * 1000;+const experimentStorageKey = 'EXPERIMENT_STORAGE_KEY';+const configUri = 'https://raw.githubusercontent.com/karrtikr/check/master/environments.json';++type AB_Experiments = { name: string; salt: string; min: number; max: number }[];+@injectable()+export class ExperimentsManager implements IExperimentsManager {+    private experimentStorage: IPersistentState<AB_Experiments | undefined>;+    private activatedWorkspaces = new Map<string, boolean>();+    private resource: Resource;+    constructor(+        @inject(IPersistentStateFactory) private readonly persistentStateFactory: IPersistentStateFactory,+        @inject(IWorkspaceService) private readonly workspaceService: IWorkspaceService,+        @inject(IHttpClient) private readonly httpClient: IHttpClient,+        @inject(ICryptoUtils) private readonly crypto: ICryptoUtils,+        @inject(IApplicationEnvironment) private readonly appEnvironment: IApplicationEnvironment,+        @inject(IOutputChannel) @named(STANDARD_OUTPUT_CHANNEL) private readonly output: IOutputChannel+    ) {+        this.experimentStorage = this.persistentStateFactory.createGlobalPersistentState<AB_Experiments | undefined>(experimentStorageKey, undefined, EXPIRY_DURATION_MS);

        this.experimentStorage = this.persistentStateFactory.createGlobalPersistentState<ABExperiments | undefined>(experimentStorageKey, undefined, EXPIRY_DURATION_MS);

karrtikr

comment created time in 13 hours

Pull request review commentmicrosoft/vscode-python

WIP - Added support for A/B testing and staged rollouts of new functionality

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++'use strict';++import { inject, injectable, named } from 'inversify';+import { Uri } from 'vscode';+import { IHttpClient } from '../activation/types';+import { sendTelemetryEvent } from '../telemetry';+import { EventName } from '../telemetry/constants';+import { IApplicationEnvironment, IWorkspaceService } from './application/types';+import { STANDARD_OUTPUT_CHANNEL } from './constants';+import { traceDecorators, traceError } from './logger';+import { ICryptoUtils, IExperimentsManager, IOutputChannel, IPersistentState, IPersistentStateFactory, Resource } from './types';+import { Experiments } from './utils/localize';++const EXPIRY_DURATION_MS = 30 * 60 * 1000;+const experimentStorageKey = 'EXPERIMENT_STORAGE_KEY';+const configUri = 'https://raw.githubusercontent.com/karrtikr/check/master/environments.json';++type AB_Experiments = { name: string; salt: string; min: number; max: number }[];+@injectable()+export class ExperimentsManager implements IExperimentsManager {+    private experimentStorage: IPersistentState<AB_Experiments | undefined>;

    private experimentStorage: IPersistentState<ABExperiments | undefined>;

karrtikr

comment created time in 13 hours

Pull request review commentmicrosoft/vscode-python

WIP - Added support for A/B testing and staged rollouts of new functionality

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++'use strict';++import { inject, injectable, named } from 'inversify';+import { Uri } from 'vscode';+import { IHttpClient } from '../activation/types';+import { sendTelemetryEvent } from '../telemetry';+import { EventName } from '../telemetry/constants';+import { IApplicationEnvironment, IWorkspaceService } from './application/types';+import { STANDARD_OUTPUT_CHANNEL } from './constants';+import { traceDecorators, traceError } from './logger';+import { ICryptoUtils, IExperimentsManager, IOutputChannel, IPersistentState, IPersistentStateFactory, Resource } from './types';+import { Experiments } from './utils/localize';++const EXPIRY_DURATION_MS = 30 * 60 * 1000;+const experimentStorageKey = 'EXPERIMENT_STORAGE_KEY';+const configUri = 'https://raw.githubusercontent.com/karrtikr/check/master/environments.json';++type AB_Experiments = { name: string; salt: string; min: number; max: number }[];+@injectable()+export class ExperimentsManager implements IExperimentsManager {+    private experimentStorage: IPersistentState<AB_Experiments | undefined>;+    private activatedWorkspaces = new Map<string, boolean>();+    private resource: Resource;+    constructor(+        @inject(IPersistentStateFactory) private readonly persistentStateFactory: IPersistentStateFactory,+        @inject(IWorkspaceService) private readonly workspaceService: IWorkspaceService,+        @inject(IHttpClient) private readonly httpClient: IHttpClient,+        @inject(ICryptoUtils) private readonly crypto: ICryptoUtils,+        @inject(IApplicationEnvironment) private readonly appEnvironment: IApplicationEnvironment,+        @inject(IOutputChannel) @named(STANDARD_OUTPUT_CHANNEL) private readonly output: IOutputChannel+    ) {+        this.experimentStorage = this.persistentStateFactory.createGlobalPersistentState<AB_Experiments | undefined>(experimentStorageKey, undefined, EXPIRY_DURATION_MS);+    }++    public async activate(resource: Uri): Promise<void> {+        if (this.activatedWorkspaces.has(this.getWorkspacePathKey(resource))) {+            return;+        }+        this.activatedWorkspaces.set(this.getWorkspacePathKey(resource), true);+        this.resource = resource;+        this.initializeInBackground().ignoreErrors();+    }++    @traceDecorators.error('Failed to initialize experiments')+    public async initializeInBackground() {+        if (this.isTelemetryDisabled() || this.experimentStorage.value) {+            return;+        }+        const downloadedExperiments = await this.httpClient.getJSONC<AB_Experiments>(configUri);

Remove _ from typenames (TypeScript doesn't use _ in typenames)

        const downloadedExperiments = await this.httpClient.getJSONC<ABExperiments>(configUri);

karrtikr

comment created time in 13 hours

Pull request review commentmicrosoft/vscode-python

WIP - Added support for A/B testing and staged rollouts of new functionality

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++'use strict';++import { inject, injectable, named } from 'inversify';+import { Uri } from 'vscode';+import { IHttpClient } from '../activation/types';+import { sendTelemetryEvent } from '../telemetry';+import { EventName } from '../telemetry/constants';+import { IApplicationEnvironment, IWorkspaceService } from './application/types';+import { STANDARD_OUTPUT_CHANNEL } from './constants';+import { traceDecorators, traceError } from './logger';+import { ICryptoUtils, IExperimentsManager, IOutputChannel, IPersistentState, IPersistentStateFactory, Resource } from './types';+import { Experiments } from './utils/localize';++const EXPIRY_DURATION_MS = 30 * 60 * 1000;+const experimentStorageKey = 'EXPERIMENT_STORAGE_KEY';+const configUri = 'https://raw.githubusercontent.com/karrtikr/check/master/environments.json';++type AB_Experiments = { name: string; salt: string; min: number; max: number }[];

Please remove the _, TypeScript doesn't use _ in type names.

type ABExperiments = { name: string; salt: string; min: number; max: number }[];

karrtikr

comment created time in 13 hours

push eventmicrosoft/vscode-python

David Lechner

commit sha 928110bbd51564c545e2283cc65f63993e827d1f

fix incorrect argument in pipenv error message (#5254) This adds some additional checks when detecting the python interpreter specified by pipenv. The checks allow us to give more useful error messages to the user. The first check runs pipenv --version just to see if the pipenv command can be found on the system. If not, the user is notified and a suggestion on how to fix the problem is made. The second check tests to see if the virtual environment used by pipenv has been setup yet. If not, it is suggested to the user to set it up manually. The old error message that showed the full output of the failed pipenv command has been removed (it is still loged though).

push time in 13 hours

PR merged microsoft/vscode-python

fix incorrect argument in pipenv error message external contributor

In PipEnvService.invokePipenv(), the argument passed to pipenv is variable. However, the error message always assumed that the argument was --venv. Use the arg parameter in the error message so that it prints exactly the command that was attempted.

For #4866

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[x] ~Has sufficient logging.~
[x] ~Has telemetry for enhancements.~
[x] Unit tests & system/integration tests are added/updated
[x] ~Test plan is updated as appropriate~
[x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed)~
[x] ~The wiki is updated with any design decisions/details.~

+29 -16

1 commit in dlech/vscode-python/tree/issue4866 microsoft/vscode-python/tree/master

3 comments

3 changed files

dlech

pr closed time in 13 hours

push eventmicrosoft/vscode-python

commit sha ec41c73028934f2da6633204d9d1566b06b90924

Added test to ensure path, module name and args of formatters are used (#5483) * Added tests * Update src/test/format/formatter.unit.test.ts

push time in 13 hours

PR merged microsoft/vscode-python

Added test to ensure path, module name and args of formatters are used skip news

For #1621

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[n/a] Has a news entry file (remember to thank yourself!)
[n/a] Appropriate comments and documentation strings in the code
[n/a] Has sufficient logging.
[n/a] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated
[n/a] Test plan is updated as appropriate
[n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[n/a] The wiki is updated with any design decisions/details.

+169 -11

2 commit in DonJayamanne/pythonVSCode/tree/issue1621 microsoft/vscode-python/tree/master

0 comment

3 changed files

DonJayamanne

pr closed time in 13 hours

pull request commentmicrosoft/vscode-python

snippet changes

@fedario Thanks a lot for the PR. We've been busy with PyCon and Build, hence the delay in getting back. As a rule we accept PRs for issues that have been filed in the GitHub issues register. Please could you file an issue for this.

fedario

comment created time in 13 hours

push eventablakey/vscode-python

commit sha 60c986e741fbc36271ac50f42ae70cf84ae76190

Updated readme

Can't switch Python installation with "Remote Development"

push time in 13 hours

issue commentmicrosoft/vscode-python

remotely: Python 2019.4.12954 (locally disabled)

Curious why? Can you try enabling this and letting me know what errors you get?

colesbury

comment created time in 14 hours

issue commentmicrosoft/vscode-python

Python Interactive does not work in Remote - Containers

@isvoboda Hmm, please could you open Developer: Toggle Developer Tools and check if there are any errors in the console window in there

isvoboda

comment created time in a day

issue commentmicrosoft/vscode-python

Tests not Reporting Status if One of the Test Folder are Outside of Workspace Folder

Please could you provide a sample repo so we can replicate this issue.

AngellusMortis

comment created time in a day

issue commentmicrosoft/vscode-python

Python Interactive does not work in Remote - Containers

@isvoboda @tai

Please could you select the command Developer: Open Webview Developer Tools
Go into the console tab
Check if there are any errors in there, if any please paste them here.

Looks like the UI isn't getting rendered for some reason.

Please ensure you select Developer: Open Webview Developer Tools and not Developer: Toggle Developer Tools, they are completely different.

isvoboda

comment created time in a day

issue closedmicrosoft/vscode-python

interpreters won't update

Steps

open vscode
open one *.py file to activate python extension
create a new python virtualenv by pipenv
click select interpreter and unable to see the new interpreter

Actual behaviour

CacheableLocatorService cached interpreters and never update.

Expected behaviour

Do not need to restart vscode to discovery new python interpreter which create by pipenv (or others).

Maybe add a command to update the cache?

closed time in a day

Cologler

issue commentmicrosoft/vscode-python

interpreters won't update

Dup of https://github.com/microsoft/vscode-python/issues/2640

Cologler

comment created time in a day

issue commentmicrosoft/vscode-python

Debugging test with subprocesses does not work

Hi, how's the issue and patch going? I'm debugging a multiprocessing program, and I've tried python3.5, python3.6 and python3.7.

Please could you create a separate issue m this issue is used to track subprocess debugging in tests.

karthiknadig

comment created time in 2 days

issue closedmicrosoft/vscode-python

when debugging python, VSC download C# plugin

<!-- Do you have a question instead of a bug report or enhancement request? Please ask it on https://stackoverflow.com/questions/tagged/visual-studio-code+python.

Unable to install a linter or formatter? 'No installers available'? Windows - https://stackoverflow.com/questions/4750806/how-do-i-install-pip-on-windows Linux - https://www.cyberciti.biz/faq/debian-ubuntu-centos-rhel-linux-install-pipclient/ , https://www.tecmint.com/install-pip-in-linux/

Python configuration issues? Please check https://code.visualstudio.com/docs/python/python-tutorial#_prerequisites

Otherwise please fill in the requested details below. "XXX" markers should not be present in the final bug report.

If you think a GIF of what is happening would be helpful, consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ . -->

Environment data

VS Code version: XXX
Extension version (available under the Extensions sidebar): XXX
OS and version: XXX
Python version (& distribution if applicable, e.g. Anaconda): XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX

Expected behaviour

XXX

Actual behaviour

XXX

Steps to reproduce:

XXX

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

XXX

版本 1.34.0 提交 a622c65b2c713c890fcf4fbf07cf34049d5fe758 日期 2019-05-15T21:55:35.507Z Shell 3.1.8 渲染器 66.0.3359.181 Node 10.2.0 架构 6.6.346.32

When I'm debugging a multi-processing python program, it failed to stop at a break point. Instead, it crashed.

Then, in this opened VSCode windows, I went to menu->file->open new windows, and opened my another python project.

In this new-opened window, when I'm trying to create a debug configuration for my python code, the output region just notices me that it is downloading C# plugin. What the heck it this??

closed time in 2 days

zchrissirhcz

issue commentmicrosoft/vscode-python

when debugging python, VSC download C# plugin

ust notices me that it is downloading C# plugin. What the heck it this

The problem is with the C# extension not python. You have installed the C# extension. Or report the issue on their repo.

zchrissirhcz

comment created time in 2 days

startedghisguth/vscode-monkey-c

started time in 2 days

issue commentmicrosoft/vscode-python

Loading Module into Code ?

python.autoComplete.extraPaths, then using ctrl+space there is no prompt with suggestions with the corresponding documentation of the module ?

Please could you provide a sample github repo with screenshots of the error so we can better understand the problem. Right now you are proofing a solution, that's fine, however if you provided the actual problem with samples we can help you better.

SheepDomination

comment created time in 3 days

commit sha e35daabbec1bc6dc7ab53ac0a78e16896a3676bf

Fix settings

push time in 3 days

PR closed microsoft/vscode-python

WIP

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

+6569 -667

1 commit in DonJayamanne/pythonVSCode/tree/pysmoketemp microsoft/vscode-python/tree/master

0 comment

103 changed files

DonJayamanne

pr closed time in 3 days

commit sha 29367f46ec3a2f5f2df0d2632875157795fb3aa9

Updated tests

push time in 3 days

push eventDonJayamanne/vscode-python-uitests

commit sha a6e296d13fbd435dbe94e1e203c2f716e1dec008

Updated tests

push time in 3 days

push eventDonJayamanne/vscode-python-uitests

commit sha fc087b7124d0d5e04080bbe7a26506dc5f7cfb1a

Update text printed

push time in 3 days

commit sha fc68364d4394c00b4835d0edabe6283c014559e2

Lets try a bigger font size

push time in 3 days

commit sha 8b2387f88694650c13634ffb982d2c3f69971718

Error handler

Write utility scripts in ES6 instead of TypeScript

push time in 3 days

issue openedmicrosoft/vscode-python

JS code used in build pipeline is written in TS and transpiled into JS. Now that our code runs against Node 10, we should be able to use ES6.

Problems:

We have TS and JS code side by side (confusing)
When making changes to TS, the JS MUST be generated and checked into source

Writing plain simple ES6 JS will fix things.

We can still get type checks, etc in JS code (typescript does this well)

created time in 3 days

commit sha eafde6a8632b9c46c50fbb3f08b2bfc3073cdd5a

Update todo

push time in 3 days

commit sha 5a441eb6fd6837826b6f23fc91847bc023641c56

Oops

Debug console: `\n` not shown as new line (NumPy ndarray)

push time in 3 days

issue commentmicrosoft/vscode-python

Issue moved to microsoft/ptvsd #1432 via ZenHub

yzhang-gh

comment created time in 3 days

issue closedmicrosoft/vscode-python

Debug console: `\n` not shown as new line (NumPy ndarray)

Copied from microsoft/vscode#73845

Environment data

VS Code version: 1.34.0
Extension version (available under the Extensions sidebar): 2019.4.12954
OS and version: Windows 10 build18898
Python version (& distribution if applicable, e.g. Anaconda): 3.7.1
Relevant/affected Python packages and their versions: NumPy

Expected behaviour

When evaluating a NumPy ndarray in the debug console, the \n should become a new line.

>>> import numpy as np
>>> a = np.arange(15).reshape(3, 5)
>>> a
array([[ 0,  1,  2,  3,  4],
       [ 5,  6,  7,  8,  9],
       [10, 11, 12, 13, 14]])

Actual behaviour

Steps to reproduce:

Start a debug session
Type import numpy as np
Type np.random.rand(5, 5)

closed time in 3 days

yzhang-gh

issue openedmicrosoft/ptvsd

Debug console: `\n` not shown as new line (NumPy ndarray)

@yzhang-gh commented on Fri May 17 2019

Copied from microsoft/vscode#73845

Environment data

VS Code version: 1.34.0
Extension version (available under the Extensions sidebar): 2019.4.12954
OS and version: Windows 10 build18898
Python version (& distribution if applicable, e.g. Anaconda): 3.7.1
Relevant/affected Python packages and their versions: NumPy

Expected behaviour

When evaluating a NumPy ndarray in the debug console, the \n should become a new line.

>>> import numpy as np
>>> a = np.arange(15).reshape(3, 5)
>>> a
array([[ 0,  1,  2,  3,  4],
       [ 5,  6,  7,  8,  9],
       [10, 11, 12, 13, 14]])

Actual behaviour

Steps to reproduce:

Start a debug session
Type import numpy as np
Type np.random.rand(5, 5)

created time in 3 days

commit sha ee914ca77e19ccec7dff36af8d3ca1ca0da7dda9

Added comments

commit sha 1d6d589a3c805d57f16386a856c77e76da7ec77e

Take screenshots

push time in 3 days

commit sha 4674a7f53b926982c92c9d93db6f9cc53b7b21a5

Change name of log file

commit sha 7f60f8742853116a43f272b99f2e9dc57c8acd30

Ignore conda

commit sha cb90b8464a053cd66b4732c2db6c335d64855a2b

Add data science tests

push time in 3 days

push eventDonJayamanne/vscode-python-uitests

commit sha 88f3d67998ce8542faadbbbd8b71b8b315699797

Misc

push time in 3 days

PR opened microsoft/vscode-python

WIP

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

+6408 -684

5 commit in DonJayamanne/pythonVSCode/tree/pys microsoft/vscode-python/tree/master

0 comment

94 changed files

pr created time in 3 days

commit sha 3d962dc4a8c41c0a535cedce48dcf80e643c9df7

Changes

push time in 3 days

commit sha 627aeb7c3bd0e12722aef647f4378128fc946d57

Oops

push time in 3 days

commit sha e8a53f2b8822a09a52a287017e74ef8856d41651

Pass parent debug session to child debug sessions using new DA API (#5581) * Implemented functionality * Updated tests * News entry * Correctly pass parent session * Code review

commit sha cc4364bbe70f65c88e626e37de09287097495db4

GetRemoteLauncherCommand should wrap path to ptvsd_launcher.py in quotes (#5585) * Corrected bug and added tests * News entry * Updated tests * Code review

commit sha b1eef223b8ba8c9a5f18de36202c597f443c459a

Fix extension causes high cpu load due to synchronous FS Operations (#5570) * Fix Extension causes high cpu load due to synchronous FS Operations * Code review

commit sha df3ed6df19bd142a6c31f50657b80bfcd913ae9b

Corrected analysisOptions.ts bug (#5598) * Changes to analysisOptions.ts * News entry

Rich Chiodo

commit sha f1deef6f3cf083e5608b91fc791d90a1edc1439a

Make sure language is used when picking kernel specs (#5628)

Rich Chiodo

commit sha 2312c3e88d0331cbff1ab32e3540841ad27daa77

First steps in autocomplete (#5601) * Testing codemirror's autocomplete * Remember monacoEditor pieces * New idea for using the language client * Farther along the completion provider idea. * New idea mapped together * Closer. no more errors * Working completion * Sorting * Reverse sort kind * Getting monaco to show context menu and completion * Fix margin width * Add comment about language service * Start of completion provider * Update to use monaco types instead * New IHistoryListener idea * Fix document position * Theme support * Colorization mostly working * Move editor to standalone panel at the bottom * Fix startup of the language server * Input history working again * Fix problem with convertToOffset * Write own react monaco editor to handle update problems * Add unit test for the completion provider * Fix editing for intellisense * Adding hover support * Fix hover to work even when expanding collapsing cells. * Add suggest.css and base64 encoding of icons * Fix completion item kind * Undo less work. Not necessary * Put watermark back * Fix hover css * Fix scrolling after resizing * Add actual table to test state. * Split between jedi and language server * Fix jedi for completion * Fix remove cell and remove all to work * Fix hover to work correctly with big hack * Don't ever remove items from the document as the cells that ran are still there Only remove on restart * Make package createable * Add babel transpile for monaco-editor so tests can run * Input test in history functional working * Get test to not hang on exit * Get all history functional tests to pass * Get tests somewhat working for intellisense * Actual working intellisense test * Fix linter warnings * Fix hover mtk1 css color * Add news entry * Remove react-codemirror * Fix hygiene * Add variable to check remote * Fix default rules to support comment/string beginnings * Fix unnecessary isNull check * Make sure to cleanup after waiting for the suggestion to show up * Fix out of memory error. * Separate out the babel steps as not required for single workspace * Fix color test * Review feedback * Update incorrect block comment

Eric Snow

commit sha 498279fcd421bd05892d7797a2562ac1a8a954b0

Split up pytest.py. (#5638) (for #5458) pythonFiles/testing_tools/adapter/pytest.py has gotten too big, with too many different things implemented there. This change addresses that by adding a "pytest" subpackage and splitting the code from pytest.py up into several modules under that subpackage. Note that this change is almost exclusively moving code around, adding missing docstrings, and removing superfluous comments.

Rich Chiodo

commit sha c9d5c92116e5a0332805b402a6e258c9b847033e

Add support for signature help and fix some issues (#5640) * First steps in signature help * Fix signature help to actually show up by setting trigger chars * Fix CTRL+F and context menu from showing up * Fix colllapsed cells to still be a part of the intellisense * Update unit tests to match new document behavior * Add news entries * Fix functional tests

commit sha be04d16246bdc2fa674bd81f57429483b2c08fb3

Send logging output into a text file (#5639) * Initial commit * Code review fixes

push time in 3 days

commit sha ed77d4def3a0c40e81d4859c3127e130c5dec3f4

Fixes