profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/DimitryAndric/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Dimitry Andric DimitryAndric The Netherlands

llvm/llvm-project 10799

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

DimitryAndric/i7z 2

Thermal and C-state reporting utility for Intel Core CPUs

DimitryAndric/cpython 0

The Python programming language

DimitryAndric/fpinspect 0

Inspect floating point computations

DimitryAndric/freebsd-src 0

FreeBSD src tree (read-only mirror)

DimitryAndric/iterm2-website 0

Website for iTerm2

DimitryAndric/libarchive 0

Multi-format archive and compression library

DimitryAndric/libjpeg-turbo 0

Main libjpeg-turbo repository

push eventDimitryAndric/freebsd-src

Kyle Evans

commit sha 8c22b9f3ba586e008e8e55a6215a1d46eb6830b9

Fix cross-building on Linux/aarch64 Add necessary bits to detect ELF format on Linux/aarch64; note that Linux calls it aarch64 where we would typically call it arm64 (uname -m) Reviewed by: arichardson, emaste, imp Sponsored by: Ampere Computing LLC Sponsored by: Klara Inc. Differential Revision: https://reviews.freebsd.org/D32542

view details

Dimitry Andric

commit sha e18925269dd2dc186e94cc6d711831bf8cdce856

Merge commit '344a3780b2e33f6ca763666c380202b18aab72a3' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/main Which merges: Vendor import of llvm-project main 88e66fa60ae5, the last commit before the upstream release/13.x branch was created.

view details

Dimitry Andric

commit sha 36e5a774beb14f48c49bd9a65cd61360f71d6009

Bump llvm/clang version numbers from 12.0.1 to 13.0.0.

view details

Dimitry Andric

commit sha 831ad4de57eed07a759946e405c422f16581f993

Bump FREEBSD_CC_VERSION for good measure.

view details

Dimitry Andric

commit sha f7bc2099aa416003076ad1c2db08b69f4711a113

Fix up diff for clang/lib/CodeGen/CGCUDANV.cpp.

view details

Dimitry Andric

commit sha 7301875b79a78e02147f8e6567e43f8de650f3ed

Update build glue to build a minimal clang executable.

view details

Dimitry Andric

commit sha b7af8e50eeb19ecf36fe46d82c56d0d272072554

Update lib/clang/headers and corresponding OptionalObsoleteFiles.

view details

Dimitry Andric

commit sha 5bd3c46f681e70ee3502745b456d0f10125a1cbb

Update build glue to build clang with MK_CLANG_FULL=yes.

view details

Dimitry Andric

commit sha f61c846cf1d9bd12e66cd5de1bcbcc90a399179b

Update build glue to clang without TOOLS_PREFIX set.

view details

Dimitry Andric

commit sha bea0dc716b5aac1b8aae81474ef3ddf2f6b0bc49

Update build glue to build clang with MK_CLANG_EXTRAS=yes.

view details

Dimitry Andric

commit sha 1ed8ed6d6e6e0eaf2361652788ddd8a6a5f225fc

Update build glue to build clang with MK_LLD=yes.

view details

Dimitry Andric

commit sha cc7bbc7b00bca2c5c68d6dcfd90925947183bb8f

Regenerate lib/clang/liblldb/LLDBWrapLua.cpp.

view details

Dimitry Andric

commit sha b0bc3b7c0bb28a77a101f3872065655c4177c151

Update build glue to build clang with MK_LLDB=yes.

view details

Dimitry Andric

commit sha b795a093a344d599f6e779560c5ea599fde9b73e

Merge commit 'd545c2ce5ad1891282e8818b47ffe557c76a86b4' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/release-13.x Which merges: * Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc1-97-g23ba3732246a.

view details

Dimitry Andric

commit sha a47642a6228f198a5e629216fcdbe5a381608d23

Update VCSVersion and generated config files for llvmorg-13.0.0-rc1-97-g23ba3732246a.

view details

Dimitry Andric

commit sha 41190e14200b214960e2350d9d4dcdcb26d5f929

Update build glue for libc++.

view details

Dimitry Andric

commit sha 34826758faddca727ca0a9ffd4e6e84e15f283bd

Update libc++ BSD.include.dist entries, and remove tr1 symlinks.

view details

Dimitry Andric

commit sha 5ba1e1daddc9aa88d4365e9350f829e9596c060c

Update libc++ entries in (Optional)?ObsoleteFiles.inc.

view details

Dimitry Andric

commit sha 0d45e368471ba08bbfc2ec90013eaf604f460278

Ensure libc++experimental can find __config_site.

view details

Dimitry Andric

commit sha 0b4ac65e8842a2e75a293c684b6f2600c83a9b9e

Update build glue for libomp.

view details

push time in 4 days

push eventDimitryAndric/freebsd-src

Kyle Evans

commit sha 8c22b9f3ba586e008e8e55a6215a1d46eb6830b9

Fix cross-building on Linux/aarch64 Add necessary bits to detect ELF format on Linux/aarch64; note that Linux calls it aarch64 where we would typically call it arm64 (uname -m) Reviewed by: arichardson, emaste, imp Sponsored by: Ampere Computing LLC Sponsored by: Klara Inc. Differential Revision: https://reviews.freebsd.org/D32542

view details

push time in 4 days

push eventDimitryAndric/freebsd-src

Peter Holm

commit sha 6deacc1b3b7a11eee90815d51fb046f019ecfa6a

stress2: Move test added by mistake Reported by: markj

view details

Mark Johnston

commit sha b0423d0f5eec89bd6c11c32649603031e3dbbfe1

amd64: Zero the PML5 PTI page when initializing a pmap The root page is not zeroed at allocation time since with 4-level tables each entry is copied from a template. However, with 5-level tables only a single entry is filled, so the rest need to be cleared. Reported by: alc Reviewed by: alc, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32525

view details

Mark Johnston

commit sha 36e4dcf47d45bbb87875ee4a9f5cc26a72a9f048

safexcel: Set the context record unconditionally The condition added in commit 5bdb8b273aaf excludes plain SHA transforms, so for such sessions crypto operations would return incorrect results. Fixes: 5bdb8b273aaf ("safexcel: Maintain per-session context records") MFC after: 1 week Sponsored by: The FreeBSD Foundation

view details

Mark Johnston

commit sha 51425cb2107c07ff379639edfbad65c77b55c3b8

bitset: Reimplement BIT_FOREACH_IS(SET|CLR) Eliminate the nested loops and re-implement following a suggestion from rlibby. Add some simple regression tests. Reviewed by: rlibby, kib MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32472

view details

Mark Johnston

commit sha de8554295b47475e758a573ab7418265f21fee7e

cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it This implementation is faster and doesn't modify the cpuset, so it lets us avoid some unnecessary copying as well. No functional change intended. This is a re-application of commit 9068f6ea697b1b28ad1326a4c7a9ba86f08b985e. Reviewed by: cem, kib, jhb MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32029

view details

Mark Johnston

commit sha 81f2e9063d64cc976b47e7ee1e9c35692cda7cb4

signal: Add SIG_FOREACH and refactor issignal() Add a SIG_FOREACH macro that can be used to iterate over a signal set. This is a bit cleaner and more efficient than calling sig_ffs() in a loop. The implementation is based on BIT_FOREACH_ISSET(), except that the bitset limbs are always 32 bits wide, and signal sets are 1-indexed rather than 0-indexed like bitset(9) sets. issignal() cannot really be modified to use SIG_FOREACH() directly. Take this opportunity to split the function into two explicit loops. I've always found this function hard to read and think that this change is an improvement. Remove sig_ffs(), nothing uses it now. Reviewed by: kib MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32473

view details

Mark Johnston

commit sha 06ebadc5f555fd7fa6f869af1e5daf834b1bb04e

x86: Remove some leftover APM support This is obsolete since commit 8c576a279ed5 ("Remove APM BIOS support"). Reviewed by: imp, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32510

view details

Mark Johnston

commit sha 621fd9dcb2d83daab477c130bc99b905f6fc27dc

timecounter: Lock the timecounter list Timecounter registration is dynamic, i.e., there is no requirement that timecounters must be registered during single-threaded boot. Loadable drivers may in principle register timecounters (which can be switched to automatically). Timecounters cannot be unregistered, though this could be implemented. Registered timecounters belong to a global linked list. Add a mutex to synchronize insertions and the traversals done by (mpsafe) sysctl handlers. No functional change intended. Reviewed by: imp, kib MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32511

view details

Mark Johnston

commit sha 77bc75c7abd29de69d3ef35b66c23c7baba95094

bhyve: Fix the WITH_BHYVE_SNAPSHOT build Note, this breaks compatibility with snapshots generated by older builds of bhyve(8). Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough") Reported by: Greg V <greg@unrelenting.technology> Reviewed by: grehan, bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32523

view details

Warner Losh

commit sha 7881db83464759ba783454d2d2eb1b970e352cd3

Remove POWER_PM_TYPE_APM. It's now unused. Sponsored by: Netflix Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D32549

view details

Ed Maste

commit sha 576b58108c1723c85e4dd00355e29bfe301dab11

libssh: correct libssh src file list Link against the ssh-sk-helper client rather than the sk internal implementation. PR: 258384 Tested by: madpilot Fixes: f448c3ed4ae1 ("openssh: Add new source files to libssl") Fixes: 19261079b743 ("openssh: update to OpenSSH v8.7p1") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32529

view details

Dimitry Andric

commit sha a23cbd8cb991207d6257d2162e70a92c828929b7

Merge commit '344a3780b2e33f6ca763666c380202b18aab72a3' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/main Which merges: Vendor import of llvm-project main 88e66fa60ae5, the last commit before the upstream release/13.x branch was created.

view details

Dimitry Andric

commit sha b977c0eed07b02535667524e5e97225b2c210d49

Bump llvm/clang version numbers from 12.0.1 to 13.0.0.

view details

Dimitry Andric

commit sha 157efcdd03ca66f06e3e16ca23ccdf1c08f7d8f8

Bump FREEBSD_CC_VERSION for good measure.

view details

Dimitry Andric

commit sha c4699595b64a5f252f158d689eb7d680ae1ce8e8

Fix up diff for clang/lib/CodeGen/CGCUDANV.cpp.

view details

Dimitry Andric

commit sha e781d430da9b45eb4df87fe75decb1497ba6d375

Update build glue to build a minimal clang executable.

view details

Dimitry Andric

commit sha d6a54ca1eb335d862f29b59eb5dadf88e052f8bd

Update lib/clang/headers and corresponding OptionalObsoleteFiles.

view details

Dimitry Andric

commit sha 079daa663cadee6863bb56e96ffe2981d2073cc0

Update build glue to build clang with MK_CLANG_FULL=yes.

view details

Dimitry Andric

commit sha e3484d529435326f1ebb11fa13bb503b6b29d337

Update build glue to clang without TOOLS_PREFIX set.

view details

Dimitry Andric

commit sha 2803886eb22b45fc0e30d4f3a2139b6e83303f62

Update build glue to build clang with MK_CLANG_EXTRAS=yes.

view details

push time in 4 days

push eventDimitryAndric/freebsd-src

Peter Holm

commit sha 6deacc1b3b7a11eee90815d51fb046f019ecfa6a

stress2: Move test added by mistake Reported by: markj

view details

Mark Johnston

commit sha b0423d0f5eec89bd6c11c32649603031e3dbbfe1

amd64: Zero the PML5 PTI page when initializing a pmap The root page is not zeroed at allocation time since with 4-level tables each entry is copied from a template. However, with 5-level tables only a single entry is filled, so the rest need to be cleared. Reported by: alc Reviewed by: alc, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32525

view details

Mark Johnston

commit sha 36e4dcf47d45bbb87875ee4a9f5cc26a72a9f048

safexcel: Set the context record unconditionally The condition added in commit 5bdb8b273aaf excludes plain SHA transforms, so for such sessions crypto operations would return incorrect results. Fixes: 5bdb8b273aaf ("safexcel: Maintain per-session context records") MFC after: 1 week Sponsored by: The FreeBSD Foundation

view details

Mark Johnston

commit sha 51425cb2107c07ff379639edfbad65c77b55c3b8

bitset: Reimplement BIT_FOREACH_IS(SET|CLR) Eliminate the nested loops and re-implement following a suggestion from rlibby. Add some simple regression tests. Reviewed by: rlibby, kib MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32472

view details

Mark Johnston

commit sha de8554295b47475e758a573ab7418265f21fee7e

cpuset(9): Add CPU_FOREACH_IS(SET|CLR) and modify consumers to use it This implementation is faster and doesn't modify the cpuset, so it lets us avoid some unnecessary copying as well. No functional change intended. This is a re-application of commit 9068f6ea697b1b28ad1326a4c7a9ba86f08b985e. Reviewed by: cem, kib, jhb MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32029

view details

Mark Johnston

commit sha 81f2e9063d64cc976b47e7ee1e9c35692cda7cb4

signal: Add SIG_FOREACH and refactor issignal() Add a SIG_FOREACH macro that can be used to iterate over a signal set. This is a bit cleaner and more efficient than calling sig_ffs() in a loop. The implementation is based on BIT_FOREACH_ISSET(), except that the bitset limbs are always 32 bits wide, and signal sets are 1-indexed rather than 0-indexed like bitset(9) sets. issignal() cannot really be modified to use SIG_FOREACH() directly. Take this opportunity to split the function into two explicit loops. I've always found this function hard to read and think that this change is an improvement. Remove sig_ffs(), nothing uses it now. Reviewed by: kib MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32473

view details

Mark Johnston

commit sha 06ebadc5f555fd7fa6f869af1e5daf834b1bb04e

x86: Remove some leftover APM support This is obsolete since commit 8c576a279ed5 ("Remove APM BIOS support"). Reviewed by: imp, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32510

view details

Mark Johnston

commit sha 621fd9dcb2d83daab477c130bc99b905f6fc27dc

timecounter: Lock the timecounter list Timecounter registration is dynamic, i.e., there is no requirement that timecounters must be registered during single-threaded boot. Loadable drivers may in principle register timecounters (which can be switched to automatically). Timecounters cannot be unregistered, though this could be implemented. Registered timecounters belong to a global linked list. Add a mutex to synchronize insertions and the traversals done by (mpsafe) sysctl handlers. No functional change intended. Reviewed by: imp, kib MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32511

view details

Mark Johnston

commit sha 77bc75c7abd29de69d3ef35b66c23c7baba95094

bhyve: Fix the WITH_BHYVE_SNAPSHOT build Note, this breaks compatibility with snapshots generated by older builds of bhyve(8). Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough") Reported by: Greg V <greg@unrelenting.technology> Reviewed by: grehan, bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32523

view details

Warner Losh

commit sha 7881db83464759ba783454d2d2eb1b970e352cd3

Remove POWER_PM_TYPE_APM. It's now unused. Sponsored by: Netflix Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D32549

view details

Ed Maste

commit sha 576b58108c1723c85e4dd00355e29bfe301dab11

libssh: correct libssh src file list Link against the ssh-sk-helper client rather than the sk internal implementation. PR: 258384 Tested by: madpilot Fixes: f448c3ed4ae1 ("openssh: Add new source files to libssl") Fixes: 19261079b743 ("openssh: update to OpenSSH v8.7p1") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32529

view details

push time in 5 days

push eventDimitryAndric/freebsd-src

Kristof Provost

commit sha 498cca14836da0408841cca8101e481e32151886

pf: selecting pf_map_addr is not an error When a redirection/nat IP address is selected by pf_map_addr it is logged with PF_DEBUG_MISC level. This one according to the manual means "Generate debug messages for various errors". Selecting an IP address is not an error, it's a normal function of pf for route-to, nat and some other operations. Therefore PF_DEBUG_NOISY level should be choosen which is means "Generate debug messages for common conditions". PR: 259184 Submitted by: Kajetan Staszkiewicz <vegeta tuxpowered.net> Sponsored by: InnoGames GmbH

view details

Colin Percival

commit sha 46dd801acb2318c8464b185893bb111f09b71138

Add userland boot profiling to TSLOG On kernels compiled with 'options TSLOG', record for each process ID: * The timestamp of the fork() which creates it and the parent process ID, * The first path passed to execve(), if any, * The first path resolved by namei, if any, and * The timestamp of the exit() which terminates the process. Expose this information via a new sysctl, debug.tslog_user. On kernels lacking 'options TSLOG' (the default), no information is recorded and the sysctl does not exist. Note that recording namei is needed in order to obtain the names of rc.d scripts being launched, as the rc system sources them in a subshell rather than execing the scripts. With this commit it is now possible to generate flamecharts of the entire boot process from the start of the loader to the end of /etc/rc. The code needed to perform this processing is currently found in github: https://github.com/cperciva/freebsd-boot-profiling Reviewed by: mhorne Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D32493

view details

Mateusz Guzik

commit sha 7dd419cabc6bb9e019c56d15f8e6a88ee2f46859

cache: add empty path support This avoids spurious drop offs as EMPTY is passed regardless of the actual path name. Pushign the work inside the lookup instead of just ignorign the flag allows avoid checking for empty pathname for all other lookups.

view details

Dimitry Andric

commit sha 79239b5b47540d64ffd1e1226f0d12d49df339c1

llvm-readobj: Add missed source file In some configurations (e.g. powerpc64) the llvm-readobj tool also needs contrib/llvm-project/llvm/BinaryFormat/MsgPackWriter.cpp, so add it to libllvm. Reported by: Shawn Webb <shawn.webb@hardenedbsd.org> Fixes: 1b85b68da0b2

view details

Rick Macklem

commit sha e2aab5e2d73486aa76bb861d583bbce021661601

nfscl: Move release of the clientID lock into nfscl_doclose() This patch moves release of the shared clientID lock from nfsrpc_close() just after the nfscl_doclose() call to the end of nfscl_doclose() call. This does make the code cleaner, since the shared lock is acquired at the beginning of nfscl_doclose(). The only semantics change is that the code no longer drops and reaquires the NFSCLSTATELOCK() mutex, which I do not believe will have a negative effect on the NFSv4 client. This is being done to prepare the code for a future patch that fixes the case where an NFSv4.1/4.2 server replies NFSERR_DELAY to a Close operation. MFC after: 2 week

view details

Kristof Provost

commit sha 076b3a50fd71d84f47bca71758e7fff3c02582e9

pf: don't drop packets when redirection information comes from a state For some traffic there might be no matching rule in the current ruleset, for example when a state was imported via pfsync from a sytem with a different ruleset checksum. In this case pf_route uses s->rt_addr for routing target instead of r->rpool.cur but r->rpool is checked anyway, resulting in dropped packets. PR: 259183 Submitted by: Kajetan Staszkiewicz <vegeta tuxpowered.net> Sponsored by: InnoGames GmbH

view details

Fangrui Song

commit sha 1cf06333160a9a6a4dabeba19f6d67ab55f0dac2

sys: Add definitions for RELR relative relocation format MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32526

view details

Fangrui Song

commit sha a7d137fcbcac7182d4fcdc97a46b10edc5c7041d

rtld: Support DT_RELR relative relocation format PIE and shared objects usually have many relative relocations. In 2017/2018, a compact relative relocation format RELR was proposed on https://groups.google.com/g/generic-abi/c/bX460iggiKg/m/GxjM0L-PBAAJ ("Proposal for a new section type SHT_RELR") and is a pre-standard. RELR usually takes 3% or smaller space than R_*_RELATIVE relocations. The virtual memory size of a mostly statically linked PIE is typically 5~10% smaller. ld.lld --pack-dyn-relocs=relr emits RELR relocations. DT_RELR has been adopted by Android bionic, Linux kernel's arm64 port, Chrome OS (patched glibc). This patch adds DT_RELR support to FreeBSD rtld-elf. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32524

view details

Mateusz Piotrowski

commit sha a3a82ed84312f76609506a4de909a8ec2ef70c02

mixer.8: Document -h

view details

Mateusz Guzik

commit sha 1045352f150346ba422b3a3ce6344fc694bc3aa4

cache: only assert on flags when dealing with EMPTYPATH Reported by: syzbot+bd48ee0843206a09e6b8@syzkaller.appspotmail.com Fixes: 7dd419cabc6bb9e0 ("cache: add empty path support")

view details

Edward Tomasz Napierala

commit sha 7e7859e7c2b900fd1b1af6e90ed31d51b9b5514d

linux: Partially implement TCSBRK This fixes tcflush(3), unbreaking cheribuild.py under arm64 Focal. Reviewed By: imp Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32291

view details

Edward Tomasz Napierala

commit sha 75a9d95b4d0a043ac0f3f8d1efc0982156337eac

linux: Adjust PTRACE_GET_SYSCALL_INFO buffer size semantics The tests/ptrace_syscall_info test from strace(1) complained about this. Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32368

view details

Edward Tomasz Napierala

commit sha f9246e14848820664539763b72b6fdef408d20e4

linux: Implement some bits of PTRACE_PEEKUSER This makes Linux gdb from Bionic a little less broken. Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32455

view details

Edward Tomasz Napierala

commit sha a03d4d73e4c7c73447263294df6ebd1791ab01f2

linux: Improve debugging for PTRACE_GETREGSET It's triggered by gdb(1). Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32456

view details

Edward Tomasz Napierala

commit sha 99f563ed76f49c541e587a2f81bc43c62c86c0e5

linux: recognize TCP_INFO and ratelimit the warning This ratelimits the "unsupported getsockopt level 6 optname 11" warnings that happen all the time when watching Netflix. Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32454

view details

Edward Tomasz Napierala

commit sha 70774c637b87eac1d9a94bb960e6f5242dad9e43

procfs: Document as deprecated Update the procfs(5) man page to clarify that it's deprecated. Reviewed By: bcr, 0mp (earlier version) Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D22275

view details

Edward Tomasz Napierala

commit sha 0f559a9f097b9eea318e970155fb23e37af07c4e

Make vmdaemon timeout configurable Make vmdaemon timeout configurable, so that one can adjust how often it runs. Here's a trick: set this to 1, then run 'limits -m 0 sh', then run whatever you want with 'ktrace -it XXX', and observe how the working set changes over time. Reviewed By: kib Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D22038

view details

Jessica Clarke

commit sha 682c00a6ce2f3870e9c698b283ee2b2a56c28c0b

riscv: Implement pmap_mapdev_attr This is needed for LinuxKPI's _ioremap_attr. This reuses the generic implementation introduced for aarch64, and itself requires implementing pmap_kenter, which is trivial to do given riscv currently treats all mapping attributes the same due to the Svpbmt extension not yet being ratified and in hardware. Reviewed by: markj, mhorne MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32445

view details

Jessica Clarke

commit sha 60d962e0410340f107d062e8f4389c0d467613a2

LinuxKPI: Implement _ioremap_attr for riscv Now that riscv implements pmap_mapdev_attr we can enable the non-stub implementation for riscv, which is needed for drm-kmod to not fail at run time for drivers that need to map I/O regions. Reviewed by: hselasky, bz MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32446

view details

Jessica Clarke

commit sha 82098c8bb5b303c7c8b48e7537fadfe74b375bd3

LinuxKPI: Support lazy BAR allocation Linux KPIs like pci_resource_start/len assume that BARs have been allocated, but FreeBSD lazily allocates BARs if it cannot allocate the firmware-allocated BARs. Thus using the Linux KPIs must force allocation of the BARs rather than returning 0 for the start and length, which can crash drm-kmod drivers that assume the BARs are valid. This is needed for the AMDGPU driver to be able to attach on SiFive's HiFive Unmatched. Reviewed by: hselasky, jhb, mav MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32447

view details

push time in 5 days

push eventDimitryAndric/freebsd-src

Kristof Provost

commit sha 498cca14836da0408841cca8101e481e32151886

pf: selecting pf_map_addr is not an error When a redirection/nat IP address is selected by pf_map_addr it is logged with PF_DEBUG_MISC level. This one according to the manual means "Generate debug messages for various errors". Selecting an IP address is not an error, it's a normal function of pf for route-to, nat and some other operations. Therefore PF_DEBUG_NOISY level should be choosen which is means "Generate debug messages for common conditions". PR: 259184 Submitted by: Kajetan Staszkiewicz <vegeta tuxpowered.net> Sponsored by: InnoGames GmbH

view details

Colin Percival

commit sha 46dd801acb2318c8464b185893bb111f09b71138

Add userland boot profiling to TSLOG On kernels compiled with 'options TSLOG', record for each process ID: * The timestamp of the fork() which creates it and the parent process ID, * The first path passed to execve(), if any, * The first path resolved by namei, if any, and * The timestamp of the exit() which terminates the process. Expose this information via a new sysctl, debug.tslog_user. On kernels lacking 'options TSLOG' (the default), no information is recorded and the sysctl does not exist. Note that recording namei is needed in order to obtain the names of rc.d scripts being launched, as the rc system sources them in a subshell rather than execing the scripts. With this commit it is now possible to generate flamecharts of the entire boot process from the start of the loader to the end of /etc/rc. The code needed to perform this processing is currently found in github: https://github.com/cperciva/freebsd-boot-profiling Reviewed by: mhorne Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D32493

view details

Mateusz Guzik

commit sha 7dd419cabc6bb9e019c56d15f8e6a88ee2f46859

cache: add empty path support This avoids spurious drop offs as EMPTY is passed regardless of the actual path name. Pushign the work inside the lookup instead of just ignorign the flag allows avoid checking for empty pathname for all other lookups.

view details

Dimitry Andric

commit sha 79239b5b47540d64ffd1e1226f0d12d49df339c1

llvm-readobj: Add missed source file In some configurations (e.g. powerpc64) the llvm-readobj tool also needs contrib/llvm-project/llvm/BinaryFormat/MsgPackWriter.cpp, so add it to libllvm. Reported by: Shawn Webb <shawn.webb@hardenedbsd.org> Fixes: 1b85b68da0b2

view details

Rick Macklem

commit sha e2aab5e2d73486aa76bb861d583bbce021661601

nfscl: Move release of the clientID lock into nfscl_doclose() This patch moves release of the shared clientID lock from nfsrpc_close() just after the nfscl_doclose() call to the end of nfscl_doclose() call. This does make the code cleaner, since the shared lock is acquired at the beginning of nfscl_doclose(). The only semantics change is that the code no longer drops and reaquires the NFSCLSTATELOCK() mutex, which I do not believe will have a negative effect on the NFSv4 client. This is being done to prepare the code for a future patch that fixes the case where an NFSv4.1/4.2 server replies NFSERR_DELAY to a Close operation. MFC after: 2 week

view details

Kristof Provost

commit sha 076b3a50fd71d84f47bca71758e7fff3c02582e9

pf: don't drop packets when redirection information comes from a state For some traffic there might be no matching rule in the current ruleset, for example when a state was imported via pfsync from a sytem with a different ruleset checksum. In this case pf_route uses s->rt_addr for routing target instead of r->rpool.cur but r->rpool is checked anyway, resulting in dropped packets. PR: 259183 Submitted by: Kajetan Staszkiewicz <vegeta tuxpowered.net> Sponsored by: InnoGames GmbH

view details

Fangrui Song

commit sha 1cf06333160a9a6a4dabeba19f6d67ab55f0dac2

sys: Add definitions for RELR relative relocation format MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32526

view details

Fangrui Song

commit sha a7d137fcbcac7182d4fcdc97a46b10edc5c7041d

rtld: Support DT_RELR relative relocation format PIE and shared objects usually have many relative relocations. In 2017/2018, a compact relative relocation format RELR was proposed on https://groups.google.com/g/generic-abi/c/bX460iggiKg/m/GxjM0L-PBAAJ ("Proposal for a new section type SHT_RELR") and is a pre-standard. RELR usually takes 3% or smaller space than R_*_RELATIVE relocations. The virtual memory size of a mostly statically linked PIE is typically 5~10% smaller. ld.lld --pack-dyn-relocs=relr emits RELR relocations. DT_RELR has been adopted by Android bionic, Linux kernel's arm64 port, Chrome OS (patched glibc). This patch adds DT_RELR support to FreeBSD rtld-elf. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32524

view details

Mateusz Piotrowski

commit sha a3a82ed84312f76609506a4de909a8ec2ef70c02

mixer.8: Document -h

view details

Mateusz Guzik

commit sha 1045352f150346ba422b3a3ce6344fc694bc3aa4

cache: only assert on flags when dealing with EMPTYPATH Reported by: syzbot+bd48ee0843206a09e6b8@syzkaller.appspotmail.com Fixes: 7dd419cabc6bb9e0 ("cache: add empty path support")

view details

Edward Tomasz Napierala

commit sha 7e7859e7c2b900fd1b1af6e90ed31d51b9b5514d

linux: Partially implement TCSBRK This fixes tcflush(3), unbreaking cheribuild.py under arm64 Focal. Reviewed By: imp Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32291

view details

Edward Tomasz Napierala

commit sha 75a9d95b4d0a043ac0f3f8d1efc0982156337eac

linux: Adjust PTRACE_GET_SYSCALL_INFO buffer size semantics The tests/ptrace_syscall_info test from strace(1) complained about this. Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32368

view details

Edward Tomasz Napierala

commit sha f9246e14848820664539763b72b6fdef408d20e4

linux: Implement some bits of PTRACE_PEEKUSER This makes Linux gdb from Bionic a little less broken. Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32455

view details

Edward Tomasz Napierala

commit sha a03d4d73e4c7c73447263294df6ebd1791ab01f2

linux: Improve debugging for PTRACE_GETREGSET It's triggered by gdb(1). Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32456

view details

Edward Tomasz Napierala

commit sha 99f563ed76f49c541e587a2f81bc43c62c86c0e5

linux: recognize TCP_INFO and ratelimit the warning This ratelimits the "unsupported getsockopt level 6 optname 11" warnings that happen all the time when watching Netflix. Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D32454

view details

Edward Tomasz Napierala

commit sha 70774c637b87eac1d9a94bb960e6f5242dad9e43

procfs: Document as deprecated Update the procfs(5) man page to clarify that it's deprecated. Reviewed By: bcr, 0mp (earlier version) Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D22275

view details

Edward Tomasz Napierala

commit sha 0f559a9f097b9eea318e970155fb23e37af07c4e

Make vmdaemon timeout configurable Make vmdaemon timeout configurable, so that one can adjust how often it runs. Here's a trick: set this to 1, then run 'limits -m 0 sh', then run whatever you want with 'ktrace -it XXX', and observe how the working set changes over time. Reviewed By: kib Sponsored By: EPSRC Differential Revision: https://reviews.freebsd.org/D22038

view details

Jessica Clarke

commit sha 682c00a6ce2f3870e9c698b283ee2b2a56c28c0b

riscv: Implement pmap_mapdev_attr This is needed for LinuxKPI's _ioremap_attr. This reuses the generic implementation introduced for aarch64, and itself requires implementing pmap_kenter, which is trivial to do given riscv currently treats all mapping attributes the same due to the Svpbmt extension not yet being ratified and in hardware. Reviewed by: markj, mhorne MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32445

view details

Jessica Clarke

commit sha 60d962e0410340f107d062e8f4389c0d467613a2

LinuxKPI: Implement _ioremap_attr for riscv Now that riscv implements pmap_mapdev_attr we can enable the non-stub implementation for riscv, which is needed for drm-kmod to not fail at run time for drivers that need to map I/O regions. Reviewed by: hselasky, bz MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32446

view details

Jessica Clarke

commit sha 82098c8bb5b303c7c8b48e7537fadfe74b375bd3

LinuxKPI: Support lazy BAR allocation Linux KPIs like pci_resource_start/len assume that BARs have been allocated, but FreeBSD lazily allocates BARs if it cannot allocate the firmware-allocated BARs. Thus using the Linux KPIs must force allocation of the BARs rather than returning 0 for the start and length, which can crash drm-kmod drivers that assume the BARs are valid. This is needed for the AMDGPU driver to be able to attach on SiFive's HiFive Unmatched. Reviewed by: hselasky, jhb, mav MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32447

view details

push time in 5 days

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 1adcf6ec24bf247b35310a8b6388ad9cc7da55c8

Generate Opts.inc for newly added llvm-readobj.

view details

push time in 7 days

push eventDimitryAndric/freebsd-src

Rick Macklem

commit sha 77c595ce33a37d321ef35fd840948a2e5fd17c84

nfscl: Add an argument to nfscl_tryclose() This patch adds a new argument to nfscl_tryclose() to indicate whether or not it should loop when a NFSERR_DELAY reply is received from the NFSv4 server. Since this new argument is always passed in as "true" at this time, no semantics change should occur. This is being done to prepare the code for a future patch that fixes the case where an NFSv4.1/4.2 server replies NFSERR_DELAY to a Close operation. MFC after: 2 week

view details

Kristof Provost

commit sha 09c7f2386973f8c36978895a7600320916bc3d07

pfctl: delay label macro expansion until after rule optimisation We used to expand the $nr macro in labels into the rule number prior to the optimisation step. This would occasionally produce incorrect rule numbers in the labels. Delay all macro expansion until after the optimisation step to ensure that we expand the correct values. MFC after: 1 week Reported by: Özkan KIRIK <ozkan.kirik@gmail.com> Differential Revision: https://reviews.freebsd.org/D32488

view details

Kristof Provost

commit sha 914ec9c78dcd5d8f77552fb93d3bc15efe9c0f40

pf tests: ensure that $nr expansion is correct Test the $nr expansion in labels is correct, even if the optimiser reduces the rule count. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32489

view details

Cy Schubert

commit sha 733a832fb515ef9ebf9d584896962fd28e714d0b

ntp: Revert "Disable stack gap for ntpd during build." This reverts commit af949c590bd8a00a5973b5875d7e0fa6832ea64a because 889b56c8cd84c9a9f2d9e3b019c154d6f14d9021 fixes the underlying problem. MFC after: 1 month

view details

Cy Schubert

commit sha fc393054398ea50fb0cee52704e9385afe888b48

ntp: Revert "Disable ntpd stack gap. When ASLR with STACK GAP != 0 ntpd suffers SIGSEGV." This reverts commit 55263180628a386ad38b4b6621919220b137f770 because the underlying problem was fixed by 889b56c8cd84c9a9f2d9e3b019c154d6f14d9021. MFC after: 1 month

view details

Maxim Sobolev

commit sha 461e6f23db3b9794e6af88b381b066a2c0463d1c

Fix fragmented UDP packets handling since rev.360967. Consider IP_MF flag when checking length of the UDP packet to match the declared value. Sponsored by: Sippy Software, Inc. Differential Revision: https://reviews.freebsd.org/D32363 MFC after: 2 weeks

view details

Gordon Bergling

commit sha 899a3b38f5172d70360396caeebb5b694638282e

Fix two typos in source code comments - s/alocated/allocated/ - s/realocated/reallocated/ MFC after: 3 days

view details

Hans Petter Selasky

commit sha aa92785a5b76e02f3a9b95a2a90e73760f78698c

mixer(8): Add -h option to show usage. Differential Revision: https://reviews.freebsd.org/D32508 Submitted by: christos@ Sponsored by: NVIDIA Networking

view details

Dimitry Andric

commit sha 6783331a183f51248a58836fa9311810b4a4464e

Merge commit '344a3780b2e33f6ca763666c380202b18aab72a3' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/main Which merges: Vendor import of llvm-project main 88e66fa60ae5, the last commit before the upstream release/13.x branch was created.

view details

Dimitry Andric

commit sha 4829d881439e1d12529c8daa84692ecc62a6b6a6

Bump llvm/clang version numbers from 12.0.1 to 13.0.0.

view details

Dimitry Andric

commit sha 45c48dedd357fc6d1f5bd3efcbee9d9e46186029

Bump FREEBSD_CC_VERSION for good measure.

view details

Dimitry Andric

commit sha 2110c351b3235cea9ec84bab430ebb3cec6c90a5

Fix up diff for clang/lib/CodeGen/CGCUDANV.cpp.

view details

Dimitry Andric

commit sha 26fce991699cdd2b9334f18d843ddf1aa3aa4a78

Update build glue to build a minimal clang executable.

view details

Dimitry Andric

commit sha 644c60414c6d9e7204e26e48bf38e867a302408c

Update lib/clang/headers and corresponding OptionalObsoleteFiles.

view details

Dimitry Andric

commit sha eb765d15aeb29104ccc2f6be185984540bed58d1

Update build glue to build clang with MK_CLANG_FULL=yes.

view details

Dimitry Andric

commit sha 23bc528f769b11c1fed0d73527f2351147be5351

Update build glue to clang without TOOLS_PREFIX set.

view details

Dimitry Andric

commit sha ddb220e9b5a5c674481b4ac57f36c1e25df3f393

Update build glue to build clang with MK_CLANG_EXTRAS=yes.

view details

Dimitry Andric

commit sha 65b184bd7c36a93b4b54c00b1bd560ef5a9f16e6

Update build glue to build clang with MK_LLD=yes.

view details

Dimitry Andric

commit sha 155b3a2c71002168f02dbf99ab08373f12d2e261

Regenerate lib/clang/liblldb/LLDBWrapLua.cpp.

view details

Dimitry Andric

commit sha e01b9fe50b71c85de178ce1a3751083c68b55650

Update build glue to build clang with MK_LLDB=yes.

view details

push time in 7 days

push eventDimitryAndric/freebsd-src

Rick Macklem

commit sha 77c595ce33a37d321ef35fd840948a2e5fd17c84

nfscl: Add an argument to nfscl_tryclose() This patch adds a new argument to nfscl_tryclose() to indicate whether or not it should loop when a NFSERR_DELAY reply is received from the NFSv4 server. Since this new argument is always passed in as "true" at this time, no semantics change should occur. This is being done to prepare the code for a future patch that fixes the case where an NFSv4.1/4.2 server replies NFSERR_DELAY to a Close operation. MFC after: 2 week

view details

Kristof Provost

commit sha 09c7f2386973f8c36978895a7600320916bc3d07

pfctl: delay label macro expansion until after rule optimisation We used to expand the $nr macro in labels into the rule number prior to the optimisation step. This would occasionally produce incorrect rule numbers in the labels. Delay all macro expansion until after the optimisation step to ensure that we expand the correct values. MFC after: 1 week Reported by: Özkan KIRIK <ozkan.kirik@gmail.com> Differential Revision: https://reviews.freebsd.org/D32488

view details

Kristof Provost

commit sha 914ec9c78dcd5d8f77552fb93d3bc15efe9c0f40

pf tests: ensure that $nr expansion is correct Test the $nr expansion in labels is correct, even if the optimiser reduces the rule count. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32489

view details

Cy Schubert

commit sha 733a832fb515ef9ebf9d584896962fd28e714d0b

ntp: Revert "Disable stack gap for ntpd during build." This reverts commit af949c590bd8a00a5973b5875d7e0fa6832ea64a because 889b56c8cd84c9a9f2d9e3b019c154d6f14d9021 fixes the underlying problem. MFC after: 1 month

view details

Cy Schubert

commit sha fc393054398ea50fb0cee52704e9385afe888b48

ntp: Revert "Disable ntpd stack gap. When ASLR with STACK GAP != 0 ntpd suffers SIGSEGV." This reverts commit 55263180628a386ad38b4b6621919220b137f770 because the underlying problem was fixed by 889b56c8cd84c9a9f2d9e3b019c154d6f14d9021. MFC after: 1 month

view details

Maxim Sobolev

commit sha 461e6f23db3b9794e6af88b381b066a2c0463d1c

Fix fragmented UDP packets handling since rev.360967. Consider IP_MF flag when checking length of the UDP packet to match the declared value. Sponsored by: Sippy Software, Inc. Differential Revision: https://reviews.freebsd.org/D32363 MFC after: 2 weeks

view details

Gordon Bergling

commit sha 899a3b38f5172d70360396caeebb5b694638282e

Fix two typos in source code comments - s/alocated/allocated/ - s/realocated/reallocated/ MFC after: 3 days

view details

Hans Petter Selasky

commit sha aa92785a5b76e02f3a9b95a2a90e73760f78698c

mixer(8): Add -h option to show usage. Differential Revision: https://reviews.freebsd.org/D32508 Submitted by: christos@ Sponsored by: NVIDIA Networking

view details

push time in 7 days

push eventDimitryAndric/freebsd-src

Mariusz Zaborski

commit sha 824bbb9a40820fb62bde0a91c0f13e0b894da149

diff: consider two files with same inodes as identical Obtained from: OpenBSD MFC after: 1 week

view details

Kristof Provost

commit sha 90dedf0fef71d3e3081015525665bf335f9c7ee3

pfctl: Remove unused variable MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate")

view details

Kristof Provost

commit sha 76c2e71c4c65a85279505005716aa43101c47bf7

pf: remove unused field from pf_kanchor The 'match' field is only used in the userspace version of the struct (pf_anchor). MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate")

view details

Mitchell Horne

commit sha 4a9f2f8b07c2d1a1c12f4aabdccd36f56b20cfda

riscv: handle page faults in the unmappable region When handling a kernel page fault, check explicitly that stval resides in either the user or kernel address spaces, and make the page fault fatal if not. Otherwise, a properly crafted address may appear to pmap_fault() as a valid and present page in the kernel map, causing the page fault to be retried continuously. This is mainly due to the fact that the upper bits of virtual addresses are not validated by most of the pmap code. Faults of this nature should only occur due to some kind of bug in the kernel, but it is best to handle them gracefully when they do. Handle user page faults in the same way, sending a SIGSEGV immediately when a malformed address is encountered. Add an assertion to pmap_l1(), which should help catch other bugs of this kind that make it this far. Reviewed by: jrtc27, markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D31208

view details

Mitchell Horne

commit sha 8babb5582eed2250309084d76898798409a2aae0

riscv: fix VM_MAXUSER_ADDRESS checks in asm routines There are two issues with the checks against VM_MAXUSER_ADDRESS. First, the comparison should consider the values as unsigned, otherwise addresses with the high bit set will fail to branch. Second, the value of VM_MAXUSER_ADDRESS is, by convention, one larger than the maximum mappable user address and invalid itself. Thus, use the bgeu instruction for these comparisons. Add a regression test case for copyin(9). PR: 257193 Reported by: Robert Morris <rtm@lcs.mit.edu> Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D31209

view details

Kirk McKusick

commit sha 4313e2ae44ba4e416a7ddaeaccf8ad311902f1c8

Avoid lost buffers in fsck_ffs. The ino_blkatoff() and indir_blkatoff() functions failed to release the buffers holding second and third level indirect blocks. This commit ensures that these buffers are now properly released. MFC after: 1 week Sponsored by: Netflix

view details

Konstantin Belousov

commit sha 4c5bf591522c5449d017b7ea496488c42f847963

i386: move signal delivery code to exec_machdep.c also move ptrace-related helpers to ptrace_machdep.c Apply some style. Use ANSI C function definitions. Remove MPSAFE annotations. Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha b4ae6b166066a789641e4a579020ca6b10b40cfa

arm64: move signal delivery code to exec_machdep.c also move ptrace-related helpers to ptrace_machdep.c. Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha dfaf65023ef0d9f68da856f3795448596751a69d

arm: move signal delivery code to exec_machdep.c Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha aba66031f27cec0bf9f6c6bc5d857e03eaf97d4f

riscv: move signal delivery code to exec_machdep.c Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha dc2d0899bba62d79083daeb83c6fac49abf28c3b

kern_sig.c: Remove unused SIGPROP_CANTMASK Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha 7a9775e9d06f629c5441124204d68d43a9f326dc

sys/proc.h: remove dead prototype Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha 244ab56611c15e737b76cb3950c32e37b67c26fc

Add curproc_sigkilled() Function returns an indicator that the process was killed with SIGKILL Reviewed by: imp, markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha 2ec505d2b863ca03d542a94e8417358e48e2606d

core(5): explicitly mention the core file size limit name Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha b5cadc643e853fa4cb23e5315e6f40bf9979a9c0

Make core dump writes interruptible with SIGKILL This can be disabled by sysctl kern.core_dump_can_intr Reported and tested by: pho Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Robert Wing

commit sha 8ff2b52241400f2b5c2287b91e6e12b97ffd5773

prometheus_sysctl_exporter(8): filter output using a regex Add two options, -i and -e, for filtering prometheus metrics. Each option takes a regular expression as an argument. The provided regex will be tested against the prometheus metric name. The -i option includes metrics matching the given regex. The -e option excludes metrics matching the given regex. Sponsored by: Modirum MDPay Sponsored by: Klara Inc. Reviewed by: 0mp, debdrup Differential Revision: https://reviews.freebsd.org/D32269

view details

Peter Holm

commit sha e6c28c2465d82e3341b589710b6302e35e1eee1c

stress2: exclude known problem test

view details

Peter Holm

commit sha 89ec6dcce03bf2b684acdaf2e62fb4365647c0a8

stress2: Added a regression test

view details

Michal Meloun

commit sha dfb7360222856e7e4f5e0e5564281a25af63319c

dwmmc: Calculate the maximum transaction length correctly. We should reserve two descriptors (not MMC_SECTORS) for potentially unaligned (so bounced) buffer fragments, one for the starting fragment and one for the ending fragment. Submitted by: kjopek@gmail.com MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D30387

view details

Alexander V. Chernikov

commit sha 7e64580b5f477ba4523799f26d1178f611f5d6cb

routing: Use the same index space for both nexthop and nexthop groups. This simplifies userland object handling along with kernel-level nexthop handling in fib algo framework. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32342

view details

push time in 7 days

push eventDimitryAndric/freebsd-src

Mariusz Zaborski

commit sha 824bbb9a40820fb62bde0a91c0f13e0b894da149

diff: consider two files with same inodes as identical Obtained from: OpenBSD MFC after: 1 week

view details

Kristof Provost

commit sha 90dedf0fef71d3e3081015525665bf335f9c7ee3

pfctl: Remove unused variable MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate")

view details

Kristof Provost

commit sha 76c2e71c4c65a85279505005716aa43101c47bf7

pf: remove unused field from pf_kanchor The 'match' field is only used in the userspace version of the struct (pf_anchor). MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate")

view details

Mitchell Horne

commit sha 4a9f2f8b07c2d1a1c12f4aabdccd36f56b20cfda

riscv: handle page faults in the unmappable region When handling a kernel page fault, check explicitly that stval resides in either the user or kernel address spaces, and make the page fault fatal if not. Otherwise, a properly crafted address may appear to pmap_fault() as a valid and present page in the kernel map, causing the page fault to be retried continuously. This is mainly due to the fact that the upper bits of virtual addresses are not validated by most of the pmap code. Faults of this nature should only occur due to some kind of bug in the kernel, but it is best to handle them gracefully when they do. Handle user page faults in the same way, sending a SIGSEGV immediately when a malformed address is encountered. Add an assertion to pmap_l1(), which should help catch other bugs of this kind that make it this far. Reviewed by: jrtc27, markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D31208

view details

Mitchell Horne

commit sha 8babb5582eed2250309084d76898798409a2aae0

riscv: fix VM_MAXUSER_ADDRESS checks in asm routines There are two issues with the checks against VM_MAXUSER_ADDRESS. First, the comparison should consider the values as unsigned, otherwise addresses with the high bit set will fail to branch. Second, the value of VM_MAXUSER_ADDRESS is, by convention, one larger than the maximum mappable user address and invalid itself. Thus, use the bgeu instruction for these comparisons. Add a regression test case for copyin(9). PR: 257193 Reported by: Robert Morris <rtm@lcs.mit.edu> Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D31209

view details

Kirk McKusick

commit sha 4313e2ae44ba4e416a7ddaeaccf8ad311902f1c8

Avoid lost buffers in fsck_ffs. The ino_blkatoff() and indir_blkatoff() functions failed to release the buffers holding second and third level indirect blocks. This commit ensures that these buffers are now properly released. MFC after: 1 week Sponsored by: Netflix

view details

Konstantin Belousov

commit sha 4c5bf591522c5449d017b7ea496488c42f847963

i386: move signal delivery code to exec_machdep.c also move ptrace-related helpers to ptrace_machdep.c Apply some style. Use ANSI C function definitions. Remove MPSAFE annotations. Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha b4ae6b166066a789641e4a579020ca6b10b40cfa

arm64: move signal delivery code to exec_machdep.c also move ptrace-related helpers to ptrace_machdep.c. Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha dfaf65023ef0d9f68da856f3795448596751a69d

arm: move signal delivery code to exec_machdep.c Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha aba66031f27cec0bf9f6c6bc5d857e03eaf97d4f

riscv: move signal delivery code to exec_machdep.c Reviewed by: emaste, imp Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32310

view details

Konstantin Belousov

commit sha dc2d0899bba62d79083daeb83c6fac49abf28c3b

kern_sig.c: Remove unused SIGPROP_CANTMASK Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha 7a9775e9d06f629c5441124204d68d43a9f326dc

sys/proc.h: remove dead prototype Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha 244ab56611c15e737b76cb3950c32e37b67c26fc

Add curproc_sigkilled() Function returns an indicator that the process was killed with SIGKILL Reviewed by: imp, markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha 2ec505d2b863ca03d542a94e8417358e48e2606d

core(5): explicitly mention the core file size limit name Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Konstantin Belousov

commit sha b5cadc643e853fa4cb23e5315e6f40bf9979a9c0

Make core dump writes interruptible with SIGKILL This can be disabled by sysctl kern.core_dump_can_intr Reported and tested by: pho Reviewed by: imp, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D32313

view details

Robert Wing

commit sha 8ff2b52241400f2b5c2287b91e6e12b97ffd5773

prometheus_sysctl_exporter(8): filter output using a regex Add two options, -i and -e, for filtering prometheus metrics. Each option takes a regular expression as an argument. The provided regex will be tested against the prometheus metric name. The -i option includes metrics matching the given regex. The -e option excludes metrics matching the given regex. Sponsored by: Modirum MDPay Sponsored by: Klara Inc. Reviewed by: 0mp, debdrup Differential Revision: https://reviews.freebsd.org/D32269

view details

Peter Holm

commit sha e6c28c2465d82e3341b589710b6302e35e1eee1c

stress2: exclude known problem test

view details

Peter Holm

commit sha 89ec6dcce03bf2b684acdaf2e62fb4365647c0a8

stress2: Added a regression test

view details

Michal Meloun

commit sha dfb7360222856e7e4f5e0e5564281a25af63319c

dwmmc: Calculate the maximum transaction length correctly. We should reserve two descriptors (not MMC_SECTORS) for potentially unaligned (so bounced) buffer fragments, one for the starting fragment and one for the ending fragment. Submitted by: kjopek@gmail.com MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D30387

view details

Alexander V. Chernikov

commit sha 7e64580b5f477ba4523799f26d1178f611f5d6cb

routing: Use the same index space for both nexthop and nexthop groups. This simplifies userland object handling along with kernel-level nexthop handling in fib algo framework. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32342

view details

push time in 7 days

push eventDimitryAndric/freebsd-src

Ed Maste

commit sha 5b2defbd2a1aa991bd0a2855eef8e15107572747

Vendor import of libcbor 0.8.0

view details

Ed Maste

commit sha a58dee945a5da64d0e97f35a508928e0d17c9cc7

Vendor import of libfido2 1.8.0

view details

Alan Somers

commit sha 5d94aaacb5180798b2f698e33937f068386004eb

fusefs: quiet some cache-related warnings If the FUSE server does something that would make our cache incoherent, we should print a warning to the user. However, we previously warned in some situations when we shouldn't, such as if the file's size changed on the server _after_ our own attribute cache had expired. This change suppresses the warning in cases like that. It also moves the warning logic to a single place within the code. PR: 256936 Reported by: Agata <chogata@moosefs.pro> Tested by: Agata <chogata@moosefs.pro>, jSML4ThWwBID69YC@protonmail.com MFC after: 2 weeks

view details

Alan Somers

commit sha 7430017b9978cae054ed99e5160f739e5ca021d5

fusefs: fix a recurse-on-non-recursive lockmgr panic fuse_vnop_bmap needs to know the file's size in order to calculate the optimum amount of readahead. If the file's size is unknown, it must ask the FUSE server. But if the file's data was previously cached and the server reports that its size has shrunk, fusefs must invalidate the cached data. That's not possible during VOP_BMAP because the buffer object is already locked. Fix the panic by not querying the FUSE server for the file's size during VOP_BMAP if we don't need it. That's also a a slight performance optimization. PR: 256937 Reported by: Agata <chogata@moosefs.pro> Tested by: Agata <chogata@moosefs.pro> MFC after: 2 weeks

view details

Alan Somers

commit sha 032a5bd55b3a003d3560435422a95f27f91685fe

fusefs: Fix a bug during VOP_STRATEGY when the server changes file size If the FUSE server tells the kernel that a file's size has changed, then the kernel must invalidate any portion of that file in cache. But the kernel can't do that during VOP_STRATEGY, because the file's buffers are already locked. Instead, proceed with the write. PR: 256937 Reported by: Agata <chogata@moosefs.pro> Tested by: Agata <chogata@moosefs.pro> MFC after: 2 weeks Reviewed by: pfg Differential Revision: https://reviews.freebsd.org/D32332

view details

Mark Johnston

commit sha 880b670c6fdbd1268887869375771e0a74d2c8ac

malloc: Unmark KASAN redzones if the full allocation size was requested Consumers that want the full allocation size will typically access the full buffer, so mark the entire allocation as valid to avoid useless KASAN reports. Sponsored by: The FreeBSD Foundation

view details

Alan Somers

commit sha f44a448709d3b77508fd59ee28201ae1666387c2

fusefs: fix intermittency in the dev_fuse_poll test The DevFusePoll::access/select test would occasionally segfault. The cause was a file descriptor that was shared between two threads. The first thread would kill the second and close the file descriptor. But it was possible that the second would read the file descriptor before it shut down. That did not cause problems for kqueue, poll, or blocking operation, but it triggered segfaults in select's macros. MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D32142

view details

Felix Johnson

commit sha e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25

login.conf.5: Mark passwordtime as implemented login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a section for capabilities not implemented in the base system. However, passwordtime has been implemented in the base for several years now. PR: 246099 Reported by: avg Reviewed by: 0mp MFC after: 3 days

view details

Kevin Bowling

commit sha 28ccd780a96fe49364072955636829cff1589cfb

e1000: Function prototype cleanup Drop arguments of function prototypes since the file is mixed between listing arg names and not. No functional changes Reviewed by: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D32329

view details

John Baldwin

commit sha b4e0a27c5be5090a9db16dd0ad417543b1fb0c4a

cryptodev: Use 'csp' in the handlers for requests. - Retire cse->mode and use csp->csp_mode instead. - Use csp->csp_cipher_algorithm instead of the ivsize when checking for the fixup for the IV length for AES-XTS. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32103

view details

John Baldwin

commit sha cb128893b92994456107d6ca722fdf6e5028eacc

ccp, ccr: Simplify drivers to assume an AES-GCM IV length of 12. While here, use crypto_read_iv() in a few more places in ccr(4) that I missed previously. Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D32104

view details

John Baldwin

commit sha 1833d6042c9a0116e8a1198256fd8fbc99cb11ad

crypto: Permit variable-sized IVs for ciphers with a reinit hook. Add a 'len' argument to the reinit hook in 'struct enc_xform' to permit support for AEAD ciphers such as AES-CCM and Chacha20-Poly1305 which support different nonce lengths. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32105

view details

John Baldwin

commit sha 5ae5ed5b8fd2955378ab67ba127cad8c981678ab

cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM. Rather than copying crp_iv to a local array on the stack that is then passed to xform reinit routines, pass crp_iv directly and remove the local copy. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32106

view details

John Baldwin

commit sha 16676123fc85233334983e0071cb446357abec8d

cryptodev: Permit explicit IV/nonce and MAC/tag lengths. Add 'ivlen' and 'maclen' fields to the structure used for CIOGSESSION2 to specify the explicit IV/nonce and MAC/tag lengths for crypto sessions. If these fields are zero, the default lengths are used. This permits selecting an alternate nonce length for AEAD ciphers such as AES-CCM which support multiple nonce leengths. It also supports truncated MACs as input to AEAD or ETA requests. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32107

view details

John Baldwin

commit sha 70dbebea124236184a66a30175ba307793971f00

cryptodev: Permit CIOCCRYPT for AEAD ciphers. A request without AAD for an AEAD cipher can be submitted via CIOCCRYPT rather than CIOCCRYPTAEAD. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32108

view details

John Baldwin

commit sha a0cbcbb7917b0b8566ec0853425a73d7958ddbed

cryptodev: Allow some CIOCCRYPT operations with an empty payload. If an operation would generate a MAC output (e.g. for digest operation or for an AEAD or EtA operation), then an empty payload buffer is valid. Only reject requests with an empty buffer for "plain" cipher sessions. Some of the AES-CCM NIST KAT vectors use an empty payload. While here, don't advance crp_payload_start for requests that use an empty payload with an inline IV. (*) Reported by: syzbot+d4b94fbd9a44b032f428@syzkaller.appspotmail.com (*) Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32109

view details

John Baldwin

commit sha bcb0fd6accc095295765b08b02f5f3b07ea62536

cryptocheck: Support multiple IV sizes for AES-CCM. By default, the "normal" IV size (12) is used, but it can be overriden via -I. If -I is not specified and -z is specified, issue requests for all possible IV sizes. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32110

view details

John Baldwin

commit sha ae18720d2792287c9ec658404f1a3173014d4979

crypto: Support multiple nonce lengths for AES-CCM. Permit nonces of lengths 7 through 13 in the OCF framework and the cryptosoft driver. A helper function (ccm_max_payload_length) can be used in OCF drivers to reject CCM requests which are too large for the specified nonce length. Reviewed by: sef Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32111

view details

John Baldwin

commit sha 8e6af6adfc2cc3d0ea89c20eaa5914e453c48b49

aesni: Support multiple nonce lengths for AES-CCM. Reviewed by: sef Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32112

view details

John Baldwin

commit sha d718c2d3c805001db0b0ae0cc0c8a811b8a90a95

aesni: Handle requests with an empty payload. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32113

view details

push time in 16 days

push eventDimitryAndric/freebsd-src

Ed Maste

commit sha 5b2defbd2a1aa991bd0a2855eef8e15107572747

Vendor import of libcbor 0.8.0

view details

Ed Maste

commit sha a58dee945a5da64d0e97f35a508928e0d17c9cc7

Vendor import of libfido2 1.8.0

view details

Alan Somers

commit sha 5d94aaacb5180798b2f698e33937f068386004eb

fusefs: quiet some cache-related warnings If the FUSE server does something that would make our cache incoherent, we should print a warning to the user. However, we previously warned in some situations when we shouldn't, such as if the file's size changed on the server _after_ our own attribute cache had expired. This change suppresses the warning in cases like that. It also moves the warning logic to a single place within the code. PR: 256936 Reported by: Agata <chogata@moosefs.pro> Tested by: Agata <chogata@moosefs.pro>, jSML4ThWwBID69YC@protonmail.com MFC after: 2 weeks

view details

Alan Somers

commit sha 7430017b9978cae054ed99e5160f739e5ca021d5

fusefs: fix a recurse-on-non-recursive lockmgr panic fuse_vnop_bmap needs to know the file's size in order to calculate the optimum amount of readahead. If the file's size is unknown, it must ask the FUSE server. But if the file's data was previously cached and the server reports that its size has shrunk, fusefs must invalidate the cached data. That's not possible during VOP_BMAP because the buffer object is already locked. Fix the panic by not querying the FUSE server for the file's size during VOP_BMAP if we don't need it. That's also a a slight performance optimization. PR: 256937 Reported by: Agata <chogata@moosefs.pro> Tested by: Agata <chogata@moosefs.pro> MFC after: 2 weeks

view details

Alan Somers

commit sha 032a5bd55b3a003d3560435422a95f27f91685fe

fusefs: Fix a bug during VOP_STRATEGY when the server changes file size If the FUSE server tells the kernel that a file's size has changed, then the kernel must invalidate any portion of that file in cache. But the kernel can't do that during VOP_STRATEGY, because the file's buffers are already locked. Instead, proceed with the write. PR: 256937 Reported by: Agata <chogata@moosefs.pro> Tested by: Agata <chogata@moosefs.pro> MFC after: 2 weeks Reviewed by: pfg Differential Revision: https://reviews.freebsd.org/D32332

view details

Mark Johnston

commit sha 880b670c6fdbd1268887869375771e0a74d2c8ac

malloc: Unmark KASAN redzones if the full allocation size was requested Consumers that want the full allocation size will typically access the full buffer, so mark the entire allocation as valid to avoid useless KASAN reports. Sponsored by: The FreeBSD Foundation

view details

Alan Somers

commit sha f44a448709d3b77508fd59ee28201ae1666387c2

fusefs: fix intermittency in the dev_fuse_poll test The DevFusePoll::access/select test would occasionally segfault. The cause was a file descriptor that was shared between two threads. The first thread would kill the second and close the file descriptor. But it was possible that the second would read the file descriptor before it shut down. That did not cause problems for kqueue, poll, or blocking operation, but it triggered segfaults in select's macros. MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D32142

view details

Felix Johnson

commit sha e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25

login.conf.5: Mark passwordtime as implemented login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a section for capabilities not implemented in the base system. However, passwordtime has been implemented in the base for several years now. PR: 246099 Reported by: avg Reviewed by: 0mp MFC after: 3 days

view details

Kevin Bowling

commit sha 28ccd780a96fe49364072955636829cff1589cfb

e1000: Function prototype cleanup Drop arguments of function prototypes since the file is mixed between listing arg names and not. No functional changes Reviewed by: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D32329

view details

John Baldwin

commit sha b4e0a27c5be5090a9db16dd0ad417543b1fb0c4a

cryptodev: Use 'csp' in the handlers for requests. - Retire cse->mode and use csp->csp_mode instead. - Use csp->csp_cipher_algorithm instead of the ivsize when checking for the fixup for the IV length for AES-XTS. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32103

view details

John Baldwin

commit sha cb128893b92994456107d6ca722fdf6e5028eacc

ccp, ccr: Simplify drivers to assume an AES-GCM IV length of 12. While here, use crypto_read_iv() in a few more places in ccr(4) that I missed previously. Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D32104

view details

John Baldwin

commit sha 1833d6042c9a0116e8a1198256fd8fbc99cb11ad

crypto: Permit variable-sized IVs for ciphers with a reinit hook. Add a 'len' argument to the reinit hook in 'struct enc_xform' to permit support for AEAD ciphers such as AES-CCM and Chacha20-Poly1305 which support different nonce lengths. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32105

view details

John Baldwin

commit sha 5ae5ed5b8fd2955378ab67ba127cad8c981678ab

cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM. Rather than copying crp_iv to a local array on the stack that is then passed to xform reinit routines, pass crp_iv directly and remove the local copy. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32106

view details

John Baldwin

commit sha 16676123fc85233334983e0071cb446357abec8d

cryptodev: Permit explicit IV/nonce and MAC/tag lengths. Add 'ivlen' and 'maclen' fields to the structure used for CIOGSESSION2 to specify the explicit IV/nonce and MAC/tag lengths for crypto sessions. If these fields are zero, the default lengths are used. This permits selecting an alternate nonce length for AEAD ciphers such as AES-CCM which support multiple nonce leengths. It also supports truncated MACs as input to AEAD or ETA requests. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32107

view details

John Baldwin

commit sha 70dbebea124236184a66a30175ba307793971f00

cryptodev: Permit CIOCCRYPT for AEAD ciphers. A request without AAD for an AEAD cipher can be submitted via CIOCCRYPT rather than CIOCCRYPTAEAD. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32108

view details

John Baldwin

commit sha a0cbcbb7917b0b8566ec0853425a73d7958ddbed

cryptodev: Allow some CIOCCRYPT operations with an empty payload. If an operation would generate a MAC output (e.g. for digest operation or for an AEAD or EtA operation), then an empty payload buffer is valid. Only reject requests with an empty buffer for "plain" cipher sessions. Some of the AES-CCM NIST KAT vectors use an empty payload. While here, don't advance crp_payload_start for requests that use an empty payload with an inline IV. (*) Reported by: syzbot+d4b94fbd9a44b032f428@syzkaller.appspotmail.com (*) Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32109

view details

John Baldwin

commit sha bcb0fd6accc095295765b08b02f5f3b07ea62536

cryptocheck: Support multiple IV sizes for AES-CCM. By default, the "normal" IV size (12) is used, but it can be overriden via -I. If -I is not specified and -z is specified, issue requests for all possible IV sizes. Reviewed by: markj Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32110

view details

John Baldwin

commit sha ae18720d2792287c9ec658404f1a3173014d4979

crypto: Support multiple nonce lengths for AES-CCM. Permit nonces of lengths 7 through 13 in the OCF framework and the cryptosoft driver. A helper function (ccm_max_payload_length) can be used in OCF drivers to reject CCM requests which are too large for the specified nonce length. Reviewed by: sef Sponsored by: Chelsio Communications, The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32111

view details

John Baldwin

commit sha 8e6af6adfc2cc3d0ea89c20eaa5914e453c48b49

aesni: Support multiple nonce lengths for AES-CCM. Reviewed by: sef Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32112

view details

John Baldwin

commit sha d718c2d3c805001db0b0ae0cc0c8a811b8a90a95

aesni: Handle requests with an empty payload. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32113

view details

push time in 16 days

push eventDimitryAndric/freebsd-src

Stefan Eßer

commit sha 3c836917985dd47c057482ee8eb9a9533393b9ce

Remove files that were checked in with wrong .gitattributes These files will be added back in updated form, but are only relevant for the Windows platform, anyway.

view details

Stefan Eßer

commit sha b46baf82c7ba1648082cdcf26f7f4570d919350e

Add back Windows only VCXProj files

view details

Stefan Eßer

commit sha 2f57ecae4b98e76e5d675563785a7e6c59c868c4

vendor/bc: imoport release 5.0.0 This is a new major release with a number of changes and extensions: - Limited the number of temporary numbers and made the space for them static so that allocating more space for them cannot fail. - Allowed integers with non-zero scale to be used with power, places, and shift operators. - Added greatest common divisor and least common multiple to lib2.bc. - Made bc and dc UTF-8 capable. - Added the ability for users to have bc and dc quit on SIGINT. - Added the ability for users to disable prompt and TTY mode by environment variables. - Added the ability for users to redefine keywords. - Added dc's modular exponentiation and divmod to bc. - Added the ability to assign strings to variables and array elements and pass them to functions in bc. - Added dc's asciify command and stream printing to bc. - Added bitwise and, or, xor, left shift, right shift, reverse, left rotate, right rotate, and mod functions to lib2.bc. - Added the functions s2u(x) and s2un(x,n), to lib2.bc.

view details

Stefan Eßer

commit sha a60ef1802a36f2f2a5611564191440ea1c1e2f17

vendor/bc: update to upstream version 5.0.2

view details

Gordon Bergling

commit sha d2e616147db7b688f2b6fa8ec6d545bc4253de92

sctp: Fix a typo in a comment - s/assue/assume/ MFC after: 3 days

view details

Gordon Bergling

commit sha 90d60ca8b7f2483cdc162633f7ea4738dad8fa0e

nfsclient: Fix a typo in a comment - s/derefernce/dereference/ MFC after: 3 days

view details

Gordon Bergling

commit sha 8771ff75384dec8c9f95ce25b6ca9a639c4b208c

jail(9): Fix a typo in a comment - s/erorr/error/ MFC after: 3 days

view details

Vincenzo Maffione

commit sha f7cef43aa9a357582a703c75dafa4a44c1b2f28c

nemtap: lb app: Validate ihl field when hashing packet MFC after: 1 week

view details

Vincenzo Maffione

commit sha 6127ce9d91c81e3025aeb1d832750d827e28314f

netmap: monitor: support offsets in copy mode

view details

Vincenzo Maffione

commit sha 3e3314a8b7e3dd8d19a209ee2988f724e138a0ae

netmap: fix uint32_t overflow in pool size calculation MFC after: 1 week

view details

Alexander Motin

commit sha 08063e9f98a33980a09e3bd465926719b3437122

sched_ule(4): Fix hang with steal_thresh < 2. e745d729be60 caused infinite loop with interrupts disabled in load stealing code if steal_thresh set below 2. Such configuration should not generally be used, but appeared some people are using it to workaround some problems. To fix the problem explicitly pass to sched_highest() minimum number of transferrable threads, supported by the caller, instead of guessing. MFC after: 25 days

view details

Kevin Bowling

commit sha 21ab8c75c940dd15343b4af28b18a66f377e670a

e1000: Fix tabstop width in if_em.h Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D32145

view details

Kevin Bowling

commit sha b1d5caf3c7504a1ece0498ec3f7360ac760577f7

ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc' Rename the 'struct adapter' to 'struct ixgbe_softc' to avoid type ambiguity in things like kgdb. Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32131

view details

Kevin Bowling

commit sha 15d077995bd2c56b7b1742ea2d4e9070ff7e9427

ixgbe: whitespace cleanup pass Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32131

view details

Rick Macklem

commit sha 62c5be4ab4c8b8127185286e148638cb8cdf45f4

nfscl: Add a check for "has acquired a delegation" to nfscl_removedeleg() Commit 5e5ca4c8fc53 added a flag to a NFSv4 mount point that is set when the first delegation is acquired from the NFSv4 server. For a common case where delegations are not being issued by the NFSv4 server, the nfscl_removedeleg() code acquires the mutex lock for open/lock state, finds the delegation list empty, then just unlocks the mutex and returns. This patch adds a check of the flag to avoid the need to acquire the mutex for this common case. This change appears to be performance neutral for a small number of opens, but should reduce lock contention for a large number of opens for the common case where server is not issuing delegations. This commit should not affect the high level semantics of delegation handling. MFC after: 2 weeks

view details

Alan Somers

commit sha a3a1ce3794e85fe27cb5af5e9f48a490a9ef70c2

fusefs: diff reduction in fuse_kernel.h Synchronize formatting and documentation in fuse_kernel.h with upstream sources. MFC after: 2 weeks Reviewed by: pfg Differential Revision: https://reviews.freebsd.org/D32141

view details

Alan Somers

commit sha 7124d2bc3a3bd58f6d3803a0579f2e0fa853b56d

fusefs: implement FUSE_NO_OPEN_SUPPORT and FUSE_NO_OPENDIR_SUPPORT For file systems that allow it, fusefs will skip FUSE_OPEN, FUSE_RELEASE, FUSE_OPENDIR, and FUSE_RELEASEDIR operations, a minor optimization. MFC after: 2 weeks Reviewed by: pfg Differential Revision: https://reviews.freebsd.org/D32141

view details

Piotr Pawel Stefaniak

commit sha 260f26f035af2095a1b55c04439f479c49e4056c

mount: make libxo support more locale-aware "special", "node", and "mounter" are not guaranteed to be encoded with UTF-8. Use the appropriate modifier. Reported by: eugen@

view details

Wojciech Macek

commit sha c27214f0afa526b9545dc7509e409e81978bf873

ipsec: fix typo in comment

view details

Wojciech Macek

commit sha 8deba29c0a63e812c8a30249ea4a004dc85cdd3f

ipsec: fix typo part2

view details

push time in 16 days

push eventDimitryAndric/freebsd-src

Stefan Eßer

commit sha 3c836917985dd47c057482ee8eb9a9533393b9ce

Remove files that were checked in with wrong .gitattributes These files will be added back in updated form, but are only relevant for the Windows platform, anyway.

view details

Stefan Eßer

commit sha b46baf82c7ba1648082cdcf26f7f4570d919350e

Add back Windows only VCXProj files

view details

Stefan Eßer

commit sha 2f57ecae4b98e76e5d675563785a7e6c59c868c4

vendor/bc: imoport release 5.0.0 This is a new major release with a number of changes and extensions: - Limited the number of temporary numbers and made the space for them static so that allocating more space for them cannot fail. - Allowed integers with non-zero scale to be used with power, places, and shift operators. - Added greatest common divisor and least common multiple to lib2.bc. - Made bc and dc UTF-8 capable. - Added the ability for users to have bc and dc quit on SIGINT. - Added the ability for users to disable prompt and TTY mode by environment variables. - Added the ability for users to redefine keywords. - Added dc's modular exponentiation and divmod to bc. - Added the ability to assign strings to variables and array elements and pass them to functions in bc. - Added dc's asciify command and stream printing to bc. - Added bitwise and, or, xor, left shift, right shift, reverse, left rotate, right rotate, and mod functions to lib2.bc. - Added the functions s2u(x) and s2un(x,n), to lib2.bc.

view details

Stefan Eßer

commit sha a60ef1802a36f2f2a5611564191440ea1c1e2f17

vendor/bc: update to upstream version 5.0.2

view details

Gordon Bergling

commit sha d2e616147db7b688f2b6fa8ec6d545bc4253de92

sctp: Fix a typo in a comment - s/assue/assume/ MFC after: 3 days

view details

Gordon Bergling

commit sha 90d60ca8b7f2483cdc162633f7ea4738dad8fa0e

nfsclient: Fix a typo in a comment - s/derefernce/dereference/ MFC after: 3 days

view details

Gordon Bergling

commit sha 8771ff75384dec8c9f95ce25b6ca9a639c4b208c

jail(9): Fix a typo in a comment - s/erorr/error/ MFC after: 3 days

view details

Vincenzo Maffione

commit sha f7cef43aa9a357582a703c75dafa4a44c1b2f28c

nemtap: lb app: Validate ihl field when hashing packet MFC after: 1 week

view details

Vincenzo Maffione

commit sha 6127ce9d91c81e3025aeb1d832750d827e28314f

netmap: monitor: support offsets in copy mode

view details

Vincenzo Maffione

commit sha 3e3314a8b7e3dd8d19a209ee2988f724e138a0ae

netmap: fix uint32_t overflow in pool size calculation MFC after: 1 week

view details

Alexander Motin

commit sha 08063e9f98a33980a09e3bd465926719b3437122

sched_ule(4): Fix hang with steal_thresh < 2. e745d729be60 caused infinite loop with interrupts disabled in load stealing code if steal_thresh set below 2. Such configuration should not generally be used, but appeared some people are using it to workaround some problems. To fix the problem explicitly pass to sched_highest() minimum number of transferrable threads, supported by the caller, instead of guessing. MFC after: 25 days

view details

Kevin Bowling

commit sha 21ab8c75c940dd15343b4af28b18a66f377e670a

e1000: Fix tabstop width in if_em.h Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D32145

view details

Kevin Bowling

commit sha b1d5caf3c7504a1ece0498ec3f7360ac760577f7

ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc' Rename the 'struct adapter' to 'struct ixgbe_softc' to avoid type ambiguity in things like kgdb. Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32131

view details

Kevin Bowling

commit sha 15d077995bd2c56b7b1742ea2d4e9070ff7e9427

ixgbe: whitespace cleanup pass Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32131

view details

Rick Macklem

commit sha 62c5be4ab4c8b8127185286e148638cb8cdf45f4

nfscl: Add a check for "has acquired a delegation" to nfscl_removedeleg() Commit 5e5ca4c8fc53 added a flag to a NFSv4 mount point that is set when the first delegation is acquired from the NFSv4 server. For a common case where delegations are not being issued by the NFSv4 server, the nfscl_removedeleg() code acquires the mutex lock for open/lock state, finds the delegation list empty, then just unlocks the mutex and returns. This patch adds a check of the flag to avoid the need to acquire the mutex for this common case. This change appears to be performance neutral for a small number of opens, but should reduce lock contention for a large number of opens for the common case where server is not issuing delegations. This commit should not affect the high level semantics of delegation handling. MFC after: 2 weeks

view details

Alan Somers

commit sha a3a1ce3794e85fe27cb5af5e9f48a490a9ef70c2

fusefs: diff reduction in fuse_kernel.h Synchronize formatting and documentation in fuse_kernel.h with upstream sources. MFC after: 2 weeks Reviewed by: pfg Differential Revision: https://reviews.freebsd.org/D32141

view details

Alan Somers

commit sha 7124d2bc3a3bd58f6d3803a0579f2e0fa853b56d

fusefs: implement FUSE_NO_OPEN_SUPPORT and FUSE_NO_OPENDIR_SUPPORT For file systems that allow it, fusefs will skip FUSE_OPEN, FUSE_RELEASE, FUSE_OPENDIR, and FUSE_RELEASEDIR operations, a minor optimization. MFC after: 2 weeks Reviewed by: pfg Differential Revision: https://reviews.freebsd.org/D32141

view details

Piotr Pawel Stefaniak

commit sha 260f26f035af2095a1b55c04439f479c49e4056c

mount: make libxo support more locale-aware "special", "node", and "mounter" are not guaranteed to be encoded with UTF-8. Use the appropriate modifier. Reported by: eugen@

view details

Wojciech Macek

commit sha c27214f0afa526b9545dc7509e409e81978bf873

ipsec: fix typo in comment

view details

Wojciech Macek

commit sha 8deba29c0a63e812c8a30249ea4a004dc85cdd3f

ipsec: fix typo part2

view details

push time in 16 days

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 4e03be8f435962acf6bd544b16062a865c799b93

Fix up diff for llvm/lib/Passes/PassBuilder.cpp.

view details

Dimitry Andric

commit sha e65adde4dae5fe05e13b5cdfadc4e5c4fd5b6572

Fix up diffs for lang/include/clang/AST/{DeclBase,Type}.h.

view details

Dimitry Andric

commit sha 592316e809c3bc633b5ec589f59556aa6a13ce55

Fix up diff for clang/lib/Format/UnwrappedLineParser.cpp.

view details

Dimitry Andric

commit sha b24c34ee98acdd21eaf1c6cb2eebe8f90e65c43c

Fix up diff for lld/COFF/Writer.cpp.

view details

Dimitry Andric

commit sha f6d01775b87115c9f637b67a77e679b8cc250e5f

Fix up diff for llvm/lib/Analysis/DemandedBits.cpp.

view details

Dimitry Andric

commit sha 6fafc69ef93c5a20cd3603fc0e6f1982266a421d

Fix up diff for llvm/lib/IR/ConstantFold.cpp.

view details

Dimitry Andric

commit sha c5a1a70133470cb85a4a084ddfb2fcb94cb43bf4

Fix up diff for llvm/lib/Transforms/Scalar/ADCE.cpp.

view details

push time in 21 days

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 59519dde9da8ae035f50451fa404aac168da4188

Update VCSVersion files for llvmorg-13.0.0-0-gd7b669b3a303.

view details

push time in 21 days

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 5ff7be0edd679898ac181b478a96a461f4d11ede

Stop clang 13 from defining conflicting macros on PowerPC Merge commit c9539f957f57 from llvm git (by Nemanja Ivanovic): [PowerPC] Define XL-compatible macros only for AIX and Linux Since XLC only ever shipped on PowerPC AIX and Linux, it is not reasonable to provide the compatibility macros on any target other than those two. This patch restricts those macros to AIX/Linux. Differential revision: https://reviews.llvm.org/D110213 PR: 258209

view details

push time in 21 days

pull request commentruby/ruby

Fix clang 12 -Wcompound-token-split-by-macro warning in ruby.h

@DimitryAndric Are you aware of any work arounds for end users here? I'm blocked by being unable to install the Thrift gem

Well, the easiest workaround is to manipulate your CFLAGS so that -Wno-compound-token-split-by-macro is added to them. If I understand the docs well enough, possibly something like:

gem install thrift -- --with-cflags="-Wno-compound-token-split-by-macro"

should work? Although I'm unsure if that will append to, or completely replace, the CFLAGS passed to the compiler.

DimitryAndric

comment created time in 25 days

issue commentrandombit/botan

MacOS: botan built with Xcode-13 fails SHA-3 tests

The problem disappears with -mno-sse4.1, and manifests otherwise.

On Linux, Clang-12 appears to not set -msse4.1 on by default, so the reproducer compiles and runs fine.

Note that the original poster of this bug used -march=native. Most likely, this was run on a machine capable of SSE4.1, so that was why it got enabled by default. If you don't specify any particular -march= option, clang will target a 'generic' x86_64 CPU which will have SSE2 but not anything higher.

mouse07410

comment created time in a month

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 3f25e997d96a3150a192777c3c389c258c5cf7ee

Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc4-0-gd7b669b3a303.

view details

Dimitry Andric

commit sha ba214180794dc37433d74166debff9625abad1b3

Merge commit '3f25e997d96a3150a192777c3c389c258c5cf7ee' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/release-13.x Which merges: * Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc4-0-gd7b669b3a303.

view details

Dimitry Andric

commit sha 387a85700f6b5c0a4e7c9373f2117c9f97a24109

Update VCSVersion files for llvmorg-13.0.0-rc4-0-gd7b669b3a303.

view details

push time in a month

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 8c15a9ce53da6dc05ba440aeb9b3e5c209ecad24

Spell cloudabi correctly in ObsoleteFiles.inc Fixes: cf0ee8738e31 Drop cloudabi

view details

Dimitry Andric

commit sha 5cee69682523057776106e0e80aee5d538eb5b90

Merge commit '344a3780b2e33f6ca763666c380202b18aab72a3' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/main Which merges: Vendor import of llvm-project main 88e66fa60ae5, the last commit before the upstream release/13.x branch was created.

view details

Dimitry Andric

commit sha e83121cf055b76203c94cea7d88b2e8696847297

Bump llvm/clang version numbers from 12.0.1 to 13.0.0.

view details

Dimitry Andric

commit sha 2488575d9bf9986ae654621ab2b39cf8df19a294

Bump FREEBSD_CC_VERSION for good measure.

view details

Dimitry Andric

commit sha f54902516ef3e071a21b062d685dff595038ea08

Fix up diff for clang/lib/CodeGen/CGCUDANV.cpp.

view details

Dimitry Andric

commit sha 65255a3077cdb93d9fb4e9f01a3be68918ed70c6

Update build glue to build a minimal clang executable.

view details

Dimitry Andric

commit sha 5e3088bed67d39d36ce7ec3deff9a83d219e0d77

Update lib/clang/headers and corresponding OptionalObsoleteFiles.

view details

Dimitry Andric

commit sha a8a813337eaedd6410899f668e3327a2d64d5bbb

Update build glue to build clang with MK_CLANG_FULL=yes.

view details

Dimitry Andric

commit sha bad95fa70cf15d6b2c32276f3fbd9c618780f3b3

Update build glue to clang without TOOLS_PREFIX set.

view details

Dimitry Andric

commit sha 70a90d4dbdaa28b50b2149bcff483472cb78116e

Update build glue to build clang with MK_CLANG_EXTRAS=yes.

view details

Dimitry Andric

commit sha 989ccf889d5df38b5cd01833881f40ecc5cf6584

Update build glue to build clang with MK_LLD=yes.

view details

Dimitry Andric

commit sha 89846a2e3c63838b16ac9e440bed3db6b58dd4c9

Regenerate lib/clang/liblldb/LLDBWrapLua.cpp.

view details

Dimitry Andric

commit sha 12783b04c2362ab9cb76da7de454179e351f6523

Update build glue to build clang with MK_LLDB=yes.

view details

Dimitry Andric

commit sha 6895f730ec84ece8c04b30aa3180007ff4df053f

Merge commit 'd545c2ce5ad1891282e8818b47ffe557c76a86b4' into llvm-13-update Result of: git subtree merge -P contrib/llvm-project vendor/llvm-project/release-13.x Which merges: * Vendor import of llvm-project branch release/13.x llvmorg-13.0.0-rc1-97-g23ba3732246a.

view details

Dimitry Andric

commit sha 22823323719f5ad29d331b74106f49acd25da12d

Update VCSVersion and generated config files for llvmorg-13.0.0-rc1-97-g23ba3732246a.

view details

Dimitry Andric

commit sha 67661d844b177af3f31fc7372669d561bcdfd195

Update build glue for libc++.

view details

Dimitry Andric

commit sha f1d57ed4801470a2eceebc2d9307edeae80d4f6f

Update libc++ BSD.include.dist entries, and remove tr1 symlinks.

view details

Dimitry Andric

commit sha cd3c2747a2cecf716e0788ebfd47ebb7ac49b6f6

Update libc++ entries in (Optional)?ObsoleteFiles.inc.

view details

Dimitry Andric

commit sha b25b917f2b149dfbd199469832fba232d9007fb1

Ensure libc++experimental can find __config_site.

view details

Dimitry Andric

commit sha 587367aaf60dec860447353676af38398fb4d8b1

Update build glue for libomp.

view details

push time in a month

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha 8c15a9ce53da6dc05ba440aeb9b3e5c209ecad24

Spell cloudabi correctly in ObsoleteFiles.inc Fixes: cf0ee8738e31 Drop cloudabi

view details

push time in a month

push eventDimitryAndric/freebsd-src

Michael Tuexen

commit sha e19d93b19dce276bdf178bb6a449728238d1c6f8

sctp: fix FCFS stream scheduler Reported by: syzbot+c6793f0f0ce698bce230@syzkaller.appspotmail.com MFC after: 1 week

view details

Piotr Pawel Stefaniak

commit sha b8ff849cbddfee3404d6550cf98f53d6bb617707

sh: improve command completion When multiple matches are found, we keep the provided string on the input line and print unique matches as suggestions. But the multiple matches might be the same command found in different directories, so we should deduplicate the matches first and then decide whether to autocomplete the command or not, based on the number of unique matches.

view details

Piotr Pawel Stefaniak

commit sha da0c0e0121574a1d82f417cc7e245ecd5506325c

fstyp: bump WARNS to default and work around warnings Differential Revision: https://reviews.freebsd.org/D31588

view details

Cameron Katri

commit sha 97c31821eb0b1180778ad2da660a1778c2cb4b62

ls(1): Allow LSCOLORS to specify an underline Allows capitalizing the background color character to enable an underline instead of bold, capitalizing the foreground color char will still do bold. Differential Revision: https://reviews.freebsd.org/D30547

view details

Mark Johnston

commit sha 4bda16ff184bfca5ee4bf9709a06323d9cf5945b

freebsd32: Provide an ANSI definition for freebsd32_recvmsg() Fix style in the freebsd32_sendmsg() definition. MFC after: 1 week Sponsored by: The FreeBSD Foundation

view details

Mark Johnston

commit sha fea1a98ead918b39280b586773a923e76194400b

freebsd32: Fix a double copyin in sendmsg() and recvmsg() freebsd32_sendmsg() and freebsd32_recvmsg() both copyin the message header twice, once directly and once in freebsd32_copyinmsghdr(). The iovec length from the former is used when copying in msg_iov, but the rest of the kernel uses the iovec length from the latter. When kern_sendit() and kern_recvit() iterate over the iovec to compute the residual for I/O, they can therefore end up walking past the end of the copied in iovec, either resulting in a system call error, userspace memory corruption from uiomove() with invalid iovecs, or a kernel page fault if the copied-in iovec is followed by an unmapped KVA region. Reported by: syzbot+7cc64cd0c49605acd421@syzkaller.appspotmail.com Reviewed by: kib, emaste MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32010

view details

Alexander Motin

commit sha e8144a13e075ff13c1f162690c7f14dd3f0a4862

ciss(4): Properly handle data underrun. For SCSI data underrun is a part of normal life. It should not be reported as error. This fixes MODE SENSE used by modern CAM. MFC after: 1 month

view details

Alexander Motin

commit sha 5f8cb13cfb0c91a4ec1a9648a3ae245b1dff36f6

ciss(4): Fix typo.

view details

Konstantin Belousov

commit sha bd3a668087efb02e8e84315f7cc29d3813270dff

vm_page_startup: correct calculation of the starting page Also avoid unneded calculations when phys segment end is the phys_avail[] start. Submitted by: alc Reviewed by: markj MFC after: 1 week Fixes: 181bfb42fd01bfa9f46 Differential revision: https://reviews.freebsd.org/D32009

view details

Colin Percival

commit sha 5a01dea7e8c9640605e5731a9fc7f600c07ace61

style: Fix leading whitespace in bcache.c MFC after: 2 weeks X-MFC-with: Further bcache changes to come

view details

Marko Zec

commit sha 2ac039f7be620f692a3a086f35a51f1a0b6b03d2

[fib_algo][dxr] Merge adjacent empty range table chunks. MFC after: 3 days

view details

Xin LI

commit sha 6f62e3a719bdaba2a1ccdafe4e3a810217aea817

The linux rc.d script mounts several filesystems related to Linux ABI compatibility layer. When /compat is located on a ZFS other than /, mount would fail because they were not mounted. Solve this by moving `linux` to depend on `zfs` which mounts all ZFS filesystems. Differential Revision: https://reviews.freebsd.org/D31848 MFC after: 2 weeks

view details

Xin LI

commit sha 7ba7bf48d5bd6ca89f4e81579456b74ee7aa9e4f

Update leap-seconds to leap-seconds.3676924800. Obtained from: ftp://ftp.nist.gov/pub/time/leap-seconds.3676924800. MFC after: 3 days

view details

Peter Holm

commit sha 9ac518adf03e371aa3e8499f84d995663bd4e0c1

stress2: Update test to ensure propper cleanup of fifo files

view details

Hubert Mazur

commit sha b831f9ce7079b040b5f319b9c0f60daba4c6151a

if_mvneta: Build the driver as a kernel module Fix device detach and attach routine. Add required Makefile to build as a module. Remove entry from GENERIC, since now it can be loaded automatically. Tested on EspressoBin. Obtained from: Semihalf Reviewed by: manu Differential revision: https://reviews.freebsd.org/D31581

view details

Andrew Turner

commit sha b94d360e4aa66d626ad5a0acde683ae9a9c71729

Add ELF macros found in the aaelf64 spec The arm64 aaelf64 spec [0] has DT_AARCH64_ that could be used with dynamic linking. It also adds GNU_PROPERTY_AARCH64_FEATURE_1_AND used to tell the kernel which CPU features the binary is compatible with, but does not require to execute correctly. Add these values so the kernel and elf tools can make use of them. [0] https://github.com/ARM-software/abi-aa/blob/2021Q1/aaelf64/aaelf64.rst Sponsored by: The FreeBSD Foundation

view details

Michael Tuexen

commit sha 34b1efcea19dd4324eecd19d2de313d039fd9656

sctp: use a valid outstream when adding it to the scheduler Without holding the stcb send lock, the outstreams might get reallocated if the number of streams are increased. Reported by: syzbot+4a5431d7caa666f2c19c@syzkaller.appspotmail.com Reported by: syzbot+aa2e3b013a48870e193d@syzkaller.appspotmail.com Reported by: syzbot+e4368c3bde07cd2fb29f@syzkaller.appspotmail.com Reported by: syzbot+fe2f110e34811ea91690@syzkaller.appspotmail.com Reported by: syzbot+ed6e8de942351d0309f4@syzkaller.appspotmail.com MFC after: 1 week

view details

Bartlomiej Grzesik

commit sha b91fc6c43a81d3b760fb570c8439a922e536d7e6

acpica: add ACPI_GET_PROPERTY to access Device Specific Data (DSD) Add lazy acquiring of DSD package, which allows accessing Device Specific Data. Reviewed by: manu, mw Sponsored by: Semihalf Differential revision: https://reviews.freebsd.org/D31596

view details

Bartlomiej Grzesik

commit sha 3f9a00e3b577dcca57e331842e0baf2dbdf9325f

device: add device_get_property and device_has_property Generialize bus specific property accessors. Those functions allow driver code to access device specific information. Currently there is only support for FDT and ACPI buses. Reviewed by: manu, mw Sponsored by: Semihalf Differential revision: https://reviews.freebsd.org/D31597

view details

Bartlomiej Grzesik

commit sha 8a8166e5bcfb50e2b7280581b600d098fa6c9fc7

mmc: switch mmc_helper to device_ api Add generic mmc_helper which uses newly introduced device_*_property api. Thanks to this change the sd/mmc drivers will be capable of parsing both DT and ACPI description. Ensure backward compatibility for all mmc_fdt_helper users. Reviewed by: manu, mw Sponsored by: Semihalf Differential revision: https://reviews.freebsd.org/D31598

view details

push time in a month

push eventDimitryAndric/freebsd-src

Michael Tuexen

commit sha e19d93b19dce276bdf178bb6a449728238d1c6f8

sctp: fix FCFS stream scheduler Reported by: syzbot+c6793f0f0ce698bce230@syzkaller.appspotmail.com MFC after: 1 week

view details

Piotr Pawel Stefaniak

commit sha b8ff849cbddfee3404d6550cf98f53d6bb617707

sh: improve command completion When multiple matches are found, we keep the provided string on the input line and print unique matches as suggestions. But the multiple matches might be the same command found in different directories, so we should deduplicate the matches first and then decide whether to autocomplete the command or not, based on the number of unique matches.

view details

Piotr Pawel Stefaniak

commit sha da0c0e0121574a1d82f417cc7e245ecd5506325c

fstyp: bump WARNS to default and work around warnings Differential Revision: https://reviews.freebsd.org/D31588

view details

Cameron Katri

commit sha 97c31821eb0b1180778ad2da660a1778c2cb4b62

ls(1): Allow LSCOLORS to specify an underline Allows capitalizing the background color character to enable an underline instead of bold, capitalizing the foreground color char will still do bold. Differential Revision: https://reviews.freebsd.org/D30547

view details

Mark Johnston

commit sha 4bda16ff184bfca5ee4bf9709a06323d9cf5945b

freebsd32: Provide an ANSI definition for freebsd32_recvmsg() Fix style in the freebsd32_sendmsg() definition. MFC after: 1 week Sponsored by: The FreeBSD Foundation

view details

Mark Johnston

commit sha fea1a98ead918b39280b586773a923e76194400b

freebsd32: Fix a double copyin in sendmsg() and recvmsg() freebsd32_sendmsg() and freebsd32_recvmsg() both copyin the message header twice, once directly and once in freebsd32_copyinmsghdr(). The iovec length from the former is used when copying in msg_iov, but the rest of the kernel uses the iovec length from the latter. When kern_sendit() and kern_recvit() iterate over the iovec to compute the residual for I/O, they can therefore end up walking past the end of the copied in iovec, either resulting in a system call error, userspace memory corruption from uiomove() with invalid iovecs, or a kernel page fault if the copied-in iovec is followed by an unmapped KVA region. Reported by: syzbot+7cc64cd0c49605acd421@syzkaller.appspotmail.com Reviewed by: kib, emaste MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32010

view details

Alexander Motin

commit sha e8144a13e075ff13c1f162690c7f14dd3f0a4862

ciss(4): Properly handle data underrun. For SCSI data underrun is a part of normal life. It should not be reported as error. This fixes MODE SENSE used by modern CAM. MFC after: 1 month

view details

Alexander Motin

commit sha 5f8cb13cfb0c91a4ec1a9648a3ae245b1dff36f6

ciss(4): Fix typo.

view details

Konstantin Belousov

commit sha bd3a668087efb02e8e84315f7cc29d3813270dff

vm_page_startup: correct calculation of the starting page Also avoid unneded calculations when phys segment end is the phys_avail[] start. Submitted by: alc Reviewed by: markj MFC after: 1 week Fixes: 181bfb42fd01bfa9f46 Differential revision: https://reviews.freebsd.org/D32009

view details

Colin Percival

commit sha 5a01dea7e8c9640605e5731a9fc7f600c07ace61

style: Fix leading whitespace in bcache.c MFC after: 2 weeks X-MFC-with: Further bcache changes to come

view details

Marko Zec

commit sha 2ac039f7be620f692a3a086f35a51f1a0b6b03d2

[fib_algo][dxr] Merge adjacent empty range table chunks. MFC after: 3 days

view details

Xin LI

commit sha 6f62e3a719bdaba2a1ccdafe4e3a810217aea817

The linux rc.d script mounts several filesystems related to Linux ABI compatibility layer. When /compat is located on a ZFS other than /, mount would fail because they were not mounted. Solve this by moving `linux` to depend on `zfs` which mounts all ZFS filesystems. Differential Revision: https://reviews.freebsd.org/D31848 MFC after: 2 weeks

view details

Xin LI

commit sha 7ba7bf48d5bd6ca89f4e81579456b74ee7aa9e4f

Update leap-seconds to leap-seconds.3676924800. Obtained from: ftp://ftp.nist.gov/pub/time/leap-seconds.3676924800. MFC after: 3 days

view details

Peter Holm

commit sha 9ac518adf03e371aa3e8499f84d995663bd4e0c1

stress2: Update test to ensure propper cleanup of fifo files

view details

Hubert Mazur

commit sha b831f9ce7079b040b5f319b9c0f60daba4c6151a

if_mvneta: Build the driver as a kernel module Fix device detach and attach routine. Add required Makefile to build as a module. Remove entry from GENERIC, since now it can be loaded automatically. Tested on EspressoBin. Obtained from: Semihalf Reviewed by: manu Differential revision: https://reviews.freebsd.org/D31581

view details

Andrew Turner

commit sha b94d360e4aa66d626ad5a0acde683ae9a9c71729

Add ELF macros found in the aaelf64 spec The arm64 aaelf64 spec [0] has DT_AARCH64_ that could be used with dynamic linking. It also adds GNU_PROPERTY_AARCH64_FEATURE_1_AND used to tell the kernel which CPU features the binary is compatible with, but does not require to execute correctly. Add these values so the kernel and elf tools can make use of them. [0] https://github.com/ARM-software/abi-aa/blob/2021Q1/aaelf64/aaelf64.rst Sponsored by: The FreeBSD Foundation

view details

Michael Tuexen

commit sha 34b1efcea19dd4324eecd19d2de313d039fd9656

sctp: use a valid outstream when adding it to the scheduler Without holding the stcb send lock, the outstreams might get reallocated if the number of streams are increased. Reported by: syzbot+4a5431d7caa666f2c19c@syzkaller.appspotmail.com Reported by: syzbot+aa2e3b013a48870e193d@syzkaller.appspotmail.com Reported by: syzbot+e4368c3bde07cd2fb29f@syzkaller.appspotmail.com Reported by: syzbot+fe2f110e34811ea91690@syzkaller.appspotmail.com Reported by: syzbot+ed6e8de942351d0309f4@syzkaller.appspotmail.com MFC after: 1 week

view details

Bartlomiej Grzesik

commit sha b91fc6c43a81d3b760fb570c8439a922e536d7e6

acpica: add ACPI_GET_PROPERTY to access Device Specific Data (DSD) Add lazy acquiring of DSD package, which allows accessing Device Specific Data. Reviewed by: manu, mw Sponsored by: Semihalf Differential revision: https://reviews.freebsd.org/D31596

view details

Bartlomiej Grzesik

commit sha 3f9a00e3b577dcca57e331842e0baf2dbdf9325f

device: add device_get_property and device_has_property Generialize bus specific property accessors. Those functions allow driver code to access device specific information. Currently there is only support for FDT and ACPI buses. Reviewed by: manu, mw Sponsored by: Semihalf Differential revision: https://reviews.freebsd.org/D31597

view details

Bartlomiej Grzesik

commit sha 8a8166e5bcfb50e2b7280581b600d098fa6c9fc7

mmc: switch mmc_helper to device_ api Add generic mmc_helper which uses newly introduced device_*_property api. Thanks to this change the sd/mmc drivers will be capable of parsing both DT and ACPI description. Ensure backward compatibility for all mmc_fdt_helper users. Reviewed by: manu, mw Sponsored by: Semihalf Differential revision: https://reviews.freebsd.org/D31598

view details

push time in a month

issue commentrandombit/botan

MacOS: botan built with Xcode-13 fails SHA-3 tests

Did I mention that the problem was bisected to the SLP Vectorizer in LLVM?

Yes, but I'm not aware of any particular LLVM commit that caused it; there isn't any further information in https://bugs.llvm.org/show_bug.cgi?id=51957, maybe you got that via other channels?

The main thing is whether this is an Apple specific change that broke something, or whether it is also reproducible in vanilla LLVM, if you specify e.g. -target-cpu skylake-avx512 like you showed.

mouse07410

comment created time in a month

issue commentrandombit/botan

MacOS: botan built with Xcode-13 fails SHA-3 tests

I suspect it's the combination of the "right" compiler and CPU (see below).

Ah yes, I failed to mention that I was compiling this on a M1 Mac, so targeting arm64. As a data point, that works correctly in any case, both for the minimized test case, and when I do a full configure/make/make check.

The problem obviously is (also?) CPU-related, because "downgrading" CPU arch to, e.g., core2 lets the reproducer pass:

$ CXXFLAGS="" CFLAGS="" CPPFLAGS="" clang++ -march=core2 -std=gnu++17 -o s -O3 sha3-reproducer.cxx 
$ ./s
$ CXXFLAGS="" CFLAGS="" CPPFLAGS="" clang++ -march=native -std=gnu++17 -o s -O3 sha3-reproducer.cxx 
$ ./s
Assertion failed: (T[0] == 16394434931424703552u), function main, file sha3-reproducer.cxx, line 103.
Abort trap: 6

Right, so what is interesting is which CPU it detects natively, and therefore which CPU extensions it enables. Can you run these same clang commands with -v added? Then it should all its intermediate options, one of which is -target-cpu xxx, identifying the detected CPU. I think I'm now suspecting you are running into some sort of SSE or AVX specific bug.

mouse07410

comment created time in a month

issue commentrandombit/botan

MacOS: botan built with Xcode-13 fails SHA-3 tests

Here's a minimal example (that doesn't depend on Botan), reproducing the discrepancy.

With -O1 (and apple clang 13) it works fine and the assertions at the end check out; for -O2 and above they don't. 🤡

Interesting, I cannot reproduce this with Apple clang version 13.0.0 (clang-1300.0.29.3), nor with FreeBSD clang 13.0.0-rc3-8-g08642a395f23. I.e., none of the assertions trigger. (Note that Apple's versions don't exactly correspond to upstream LLVM versions.)

Do you know of any non-Mac clang version that miscompiles the test case, and what exact compile flags are being used?

mouse07410

comment created time in a month

push eventDimitryAndric/freebsd-src

Dimitry Andric

commit sha e68c92f0d8ee9e01a0b719f3da8d3fe0cdc76c7e

Fix clang 13 assertion when building math/frobby Merge commit d9308aa39b23 from llvm git (by Matheus Izvekov): [clang] don't mark as Elidable CXXConstruct expressions used in NRVO See PR51862. The consumers of the Elidable flag in CXXConstructExpr assume that an elidable construction just goes through a single copy/move construction, so that the source object is immediately passed as an argument and is the same type as the parameter itself. With the implementation of P2266 and after some adjustments to the implementation of P1825, we started (correctly, as per standard) allowing more cases where the copy initialization goes through user defined conversions. With this patch we stop using this flag in NRVO contexts, to preserve code that relies on that assumption. This causes no known functional changes, we just stop firing some asserts in a cople of included test cases. Reviewed By: rsmith Differential Revision: https://reviews.llvm.org/D109800 PR: 258209

view details

push time in a month

push eventDimitryAndric/freebsd-src

Jorgen Lundman

commit sha 3e8d5e4ff3a67fd3eb4d5d8af9370a5133e7dc4e

Add zpool_disable_datasets_os() / zfs_unmount_os() zpool_disable_datasets_os(): macOS needs to do a bunch of work to kick everything off zvols. zfs_unmount_os(): This allows us to unmount any zvols that may be mounted. Like with zfs destroy foo/vol Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #12436

view details

Ryan Moeller

commit sha c27c124a88b2a42e0d7b3bedd12197608122702b

ZTS: Remove exceptions for flaky zhack on FreeBSD Issue #11854 has been resolved, so we can remove the exceptions for it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #12527

view details

Jorgen Lundman

commit sha 157a4d05bd732bdeb6f23158331dd683d89305cb

autoconf: allow Release to contain hyphen To avoid clashing with tags and releases, we'll use "zfs-macOS". Meta: 1 Name: zfs-macOS Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #12437

view details

George Melikov

commit sha a9655fc2bd1f83f1b305ff7ed16f698b87834e73

Check for libabigail version We need to use 1.8.0+ version, older versions may segfault and give inconsistent results. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #12529

view details

George Melikov

commit sha d510924520dd23d43511e2594183d59e20fffc2b

CI: use fresh libabigail via docker image Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #12529

view details

George Melikov

commit sha 1aaebea2f58743b8d4b1bd7ec4b3b41d52cec30b

Libabigail: make .abi files more consistent Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #12529

view details

George Melikov

commit sha 6ea058da16cc1ddaea44d8d74afa8a8966677662

Update ABI files via new libabigail version Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #12529

view details

George Melikov

commit sha 3eb3e4d14cf008045b79afbbe9d24812d56917be

CI: don't install abigail-tools We use docker image instead. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: George Melikov <mail@gmelikov.ru> Closes #12529

view details

Don Brady

commit sha ab15b1fc0e713e3fe91cc5e1eaf414b377b8108e

Detect iSCSI in the zpool cmd vdev media script Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Don Brady <don.brady@delphix.com> Closes #12206

view details

Brian Behlendorf

commit sha f6166058219707ca379064a4529ae4ce87e4e64f

Linux 5.15 compat: block device readahead The 5.15 kernel moved the backing_dev_info structure out of the request queue structure which causes a build failure. Rather than look in the new location for the BDI we instead detect this upstream refactoring by the existance of either the blk_queue_update_readahead() or disk_update_readahead() functions. In either case, there's no longer any reason to manually set the ra_pages value since it will be overridden with a reasonable default (2x the block size) when blk_queue_io_opt() is called. Therefore, we update the compatibility wrapper to do nothing for 5.9 and newer kernels. While it's tempting to do the same for older kernels we want to keep the compatibility code to preserve the existing behavior. Removing it would effectively increase the default readahead to 128k. Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12532

view details

Alexander

commit sha a3588c68f7026c49291a7ec92a78c69b22e15df1

Linux 5.15 compat: standalone <linux/stdarg.h> Kernel commits 39f75da7bcc8 ("isystem: trim/fixup stdarg.h and other headers") c0891ac15f04 ("isystem: ship and use stdarg.h") 564f963eabd1 ("isystem: delete global -isystem compile option") (for now can be found in linux-next.git tree, will land into the Linus' tree during the ongoing 5.15 cycle with one of akpm merges) removed the -isystem flag and disallowed the inclusion of any compiler header files. They also introduced a minimal <linux/stdarg.h> as a replacement for <stdarg.h>. include/os/linux/spl/sys/cmn_err.h in the ZFS source tree includes <stdarg.h> unconditionally. Introduce a test for <linux/stdarg.h> and include it instead of the compiler's one to prevent module build breakage. Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alexander Lobakin <alobakin@pm.me> Closes #12531

view details

Paul Dagnelie

commit sha c634320e51df32095bb0ed7b2a74089e24a850c7

Compressed receive with different ashift can result in incorrect PSIZE on disk We round up the psize to the nearest multiple of the asize or to the lsize, whichever is smaller. Once that's done, we allocate a new buffer of the appropriate size, zero the tail, and copy the data into it. This adds a small performance cost to these kinds of writes, but fixes the bookkeeping problems. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Co-authored-by: Matthew Ahrens <matthew.ahrens@delphix.com> Signed-off-by: Paul Dagnelie <pcd@delphix.com> Closes #12522 Closes #8462

view details

Jorgen Lundman

commit sha 49d8a99a4d6579a61b04c4b05f732fab26b09d30

Upstream: zdb inode mapping Unfortunately macOS reserves inode ID numbers 0-15, and we can not used them. In macOS port we simply map them really high IDs. Normally this is hidden inside the _os implementation, but this is the one place in the common source files. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #12530

view details

Rich Ercolani

commit sha 7676ffc51f5e4963c7e7f9971561f483dcd65976

arc: Drop an incorrect assert Unfortunately, there was an overzealous assertion that was (in pretty specific circumstances) false, causing failure. This assertion was added in error, so we're removing it. Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: George Wilson <gwilson@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes #9897 Closes #12020 Closes #12246

view details

Allan Jude

commit sha a68e4b5919dc5e7f53762d37adcc711174e1e936

Allow sending corrupt snapshots even if metadata is corrupted When zfs_send_corrupt_data is set, use the TRAVERSE_HARD flag, so traverse_visitbp() will not fail with ECKSUM if a blockpointer cannot be read, but rather will continue and send the objects it can. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Signed-off-by: Allan Jude <allan@klarasystems.com> Sponsored-By: Klara Inc. Sponsored-By: WHC Online Solutions Inc. Closes #12541

view details

Brian Behlendorf

commit sha 2079111f42a90b123f484337b43a549b7c5e50ba

Linux 5.15 compat: get_acl() Kernel commits 332f606b32b6 ovl: enable RCU'd ->get_acl() 0cad6246621b vfs: add rcu argument to ->get_acl() callback Added compatibility code to detect the new ->get_acl() interface and correctly handle the case where the new rcu argument is set. Reviewed-by: Coleman Kane <ckane@colemankane.org> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12548

view details

Jorgen Lundman

commit sha 5a54a4e0517959dd917c0f78d692f7364e597a68

Upstream: Add snapshot and zvol events For kernel to send snapshot mount/unmount events to zed. For kernel to send symlink creates/removes on zvol plumbing. (/dev/run/dsk/zvol/$pool/$zvol -> /dev/diskX) If zed misses the ENODEV, all errors after are EINVAL. Treat any error as kernel module failure. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #12416

view details

Brian Behlendorf

commit sha b9ec4a15e5ab40e6c32dd445ecebcd3a3fed1ef9

Verify embedded blkptr's in arc_read() The block pointer verification check in arc_read() should also cover embedded block pointers. While highly unlikely, accessing a damaged block pointer can result in panic. To further harden the code extend the existing check to include embedded block pointers and add a comment explaining the rational for this sanity check. Lastly, correct a flaw in zfs_blkptr_verify() so the error count is checked even when checking a untrusted config to verify the non-pool-specific portions of a block pointer. Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #12535

view details

Konstantin Belousov

commit sha e99255c8a6cae324aeede7f5013d080a2d361e3f

amd64: do not touch low memory in acpi_wakeup_ap() if booted by UEFI Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D31916

view details

Konstantin Belousov

commit sha ceca8ac1ce47e1f87ba09463aa84eb1c879c37d9

x86 acpi_install_wakeup_handler(): style Do not use tab between type and variable name in local declarations. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D31916

view details

push time in a month