profile
viewpoint
Davide Principi DavidePrincipi @Nethesis Pesaro, Italy http://community.nethserver.org/users/davidep Working hard on @NethServer since 2011

issue closedNethServer/dev

Rspamd: whitelist/blacklist enhancement

The whitelist/blacklist of rspamd is designed to work with the second domain level, eg domain.org, so you blacklist or whitelist the domain and all subdomains: email:domain:tld

https://rspamd.com/doc/modules/multimap.html#from-rcpt-and-header-filters

However when you try to blacklist/whitelist a subdomain, it won't work because rspamd extracts only the second level of the domain name

Proposed solution

  1. In rules evaluation, try to match both the eSLD (effective second level domain - rspamd :tld filter) and the whole domain suffix against the email address of the sender/recipient.

  2. Whitelist rules are always processed before the blacklist, thus allowing a subdomain (e.g. myhost.domain.com) to be whitelisted if a more generic rule wants to blacklist the entire domain (e.g. domain.com).

Docs changes

  • [ ] document the new behavior: clarify what happens by writing a top level domain or a subdomain record

Alternative solutions

as an alternative we could make a validator and refuse subdomain, asking or top level domain

See also

https://community.nethserver.org/t/whitelist-in-mail-server-not-working/13911/


thank jfernandez

closed time in 13 hours

stephdl

issue commentNethServer/dev

Rspamd: whitelist/blacklist enhancement

TODO: PR for admin's manual

stephdl

comment created time in 13 hours

PR opened NethServer/nethserver-cockpit

Reviewers
Validate access to application

New validate implementation. Check if the current user is either root or an admin, or is delegated to use a specific Cockpit application.

Fix proposal for NethServer/dev#5976

+13 -5

0 comment

1 changed file

pr created time in 13 hours

push eventDavidePrincipi/nethserver-cockpit

Davide Principi

commit sha 37929f00cb63211564605f4d3e1eb0f87a0fdec7

Validate access to application

view details

push time in 13 hours

create barnchDavidePrincipi/nethserver-cockpit

branch : b5976

created branch time in 13 hours

PR closed NethServer/nethserver-mail

Multimap domains map must match first

https://github.com/NethServer/dev/issues/5940

Multimap map must match first, the https://github.com/NethServer/nethserver-mail/pull/172 is reverted by this change

This is due because you cannot declare the same symbol with two multimap rules (check https://github.com/NethServer/dev/issues/5940#issuecomment-563280135)

so when email:domain:tld matches first the domain.org, then the sub.domain.org is bl/wl with the good symbol ( FROM_DOMAINS_*). The multimap rules takes an order priority, first match, first win

+40 -40

2 comments

2 changed files

stephdl

pr closed time in 14 hours

pull request commentNethServer/nethserver-mail

Multimap domains map must match first

Closed as #174 was merged instead.

stephdl

comment created time in 14 hours

delete branch DavidePrincipi/nethserver-mail

delete branch : bugfixes

delete time in 14 hours

delete branch DavidePrincipi/nethserver-mail

delete branch : fix-multimap-regression2

delete time in 14 hours

push eventNethServer/nethserver-mail

Davide Principi

commit sha 86cb056a594ae5dd01479ad5b8f378ff7ff18a7d

Release 2.10.0

view details

push time in 14 hours

created tagNethServer/nethserver-mail

tag2.10.0

Configuration for Postfix, Dovecot, Rspamd, OpenDKIM

created time in 14 hours

push eventNethServer/nethserver-makerpms

Stephane de Labrusse

commit sha e58f0a10d5fec0277dc23f16255e041a2a6c92b5

Developer name environment variable (#7) If a DIST variable is not set in the environment, fall back to ".nsX", where X can be 6 or 7, as set in NSVER variable. [skip ci]

view details

push time in 14 hours

PR merged NethServer/nethserver-makerpms

Reviewers
Developer name environment variable
  • Display the developer name in the rpm : nethserver-makerpms-1.1.0-1.ns7.sdl.noarch.rpm
  • Display a usage if !=$1
+21 -5

0 comment

1 changed file

stephdl

pr closed time in 14 hours

push eventstephdl/nethserver-makerpms

Davide Principi

commit sha 55bc490dd9d9da6afb04dd9f9aebca31a524f4a8

Override DIST from environment If a DIST variable is not set in the environment, fall back to ".nsX", where X can be 6 or 7, as set in NSVER variable. [skip ci]

view details

push time in 15 hours

delete branch NethServer/nethserver-mail

delete branch : revert-172-Fix5940

delete time in 15 hours

push eventNethServer/nethserver-mail

Stephane de Labrusse

commit sha 9198bf5cbc0e1eec251943bd6009f100c6bf4308

Revert "Same symbol for domain|sub.domain WL|BL"

view details

push time in 15 hours

PR merged NethServer/nethserver-mail

Revert "Same symbol for domain|sub.domain WL|BL"

NethServer/dev#5940

Alternative to #173

+4 -4

0 comment

2 changed files

DavidePrincipi

pr closed time in 15 hours

push eventNethServer/nethserver-makerpms

Stephane de Labrusse

commit sha 56bf2d137a0c98bf2fee91cd88f138ca23c4ce8e

Fix conflict file issue-refs with nethserver-mock (#8)

view details

push time in 17 hours

PR merged NethServer/nethserver-makerpms

Fix conflict file issue-refs with nethserver-mock
Erreur : Transaction test error:
  le fichier /usr/bin/issue-refs de l'installation de nethserver-makerpms-1.1.0-1.ns7.noarch entre en conflit avec le fichier du paquet nethserver-mock-1.6.0-1.ns7.noarch

to avoid this conflict

+2 -2

0 comment

3 changed files

stephdl

pr closed time in 17 hours

delete branch DavidePrincipi/nethserver-cockpit

delete branch : b5977

delete time in 20 hours

Pull request review commentNethServer/nethserver-cockpit

Avoid certificate update event cut off

     "add_domain": "Add domain",     "renew_days": "Renew days",     "request": "Request",+    "cockpit_reload_warning_title": "Notice.",+    "cockpit_reload_warning_message": "The new certificate is applied to the Cockpit Server Manager 90 seconds after the last user is disconnected.",

Fixed after merge

DavidePrincipi

comment created time in 20 hours

PR merged NethServer/nethserver-cockpit

Avoid certificate update event cut off

The nethserver-cockpit-conf action forcibly restart cockpit-ws causing the user session to be disconnected.

The disconnection occurs

  • during nethserver-cockpit RPM updates (from the Applications page, or yum-cron and other YUM update runs)
  • during the certificate-update event, causing the complete event to fail

https://github.com/NethServer/dev/issues/5977

+63 -4

1 comment

3 changed files

DavidePrincipi

pr closed time in 20 hours

push eventNethServer/nethserver-cockpit

Davide Principi

commit sha c0fea43d546b205a61d5d194b5ebb96287b785e7

Avoid forced cockpit-ws restarts The cockpit-ws process does not really need to be restarted unless a new TLS certificate must be loaded immediately. Avoiding restarts prevents the disconnection of active user sessions and possibly the certificate-update event cut off.

view details

Davide Principi

commit sha ee375e7681f115c445781f317d81b98ada69fe99

Add link to certificates online manual

view details

Davide Principi

commit sha 94eba42d3c21b70204b488dc5cb809e3617ce60a

Display a notice about Cockpit certificate reload

view details

Davide Principi

commit sha 6e1dcd902fd1587af7f5beffb4881d151e2d9887

Add "set default certificate" modal dialog

view details

Davide Principi

commit sha 90ee12dc324d9fe23afecdcab67f4f0e57802954

Fix warning message

view details

Davide Principi

commit sha 484893f59f35e6e7b87d5c4ba728ad1d2aaa8f23

Merge branch 'b5977' Avoid certificate update event cut off NethServer/dev#5977

view details

push time in 20 hours

issue commentNethServer/dev

Rspamd: whitelist/blacklist enhancement

Test case 4

Check the /var/log/maillog contains the following symbols:

  • FROM_BLACKLIST
  • FROM_DOMAINS_BLACKLIST
  • TO_WHITELIST
  • TO_DOMAINS_WHITELIST
  • FROM_WHITELIST
  • FROM_DOMAINS_WHITELIST

The maillog must not match any of SUBDOMAINS_ variants.

stephdl

comment created time in 5 days

PR opened NethServer/nethserver-cockpit

Reviewers
Avoid certificate update event cut off

The nethserver-cockpit-conf action forcibly restart cockpit-ws causing the user session to be disconnected.

The disconnection occurs

  • during nethserver-cockpit RPM updates (from the Applications page, or yum-cron and other YUM update runs)
  • during the certificate-update event, causing the complete event to fail

https://github.com/NethServer/dev/issues/5977

+63 -4

0 comment

3 changed files

pr created time in 5 days

push eventDavidePrincipi/nethserver-cockpit

Davide Principi

commit sha ee375e7681f115c445781f317d81b98ada69fe99

Add link to certificates online manual

view details

Davide Principi

commit sha 94eba42d3c21b70204b488dc5cb809e3617ce60a

Display a notice about Cockpit certificate reload

view details

Davide Principi

commit sha 6e1dcd902fd1587af7f5beffb4881d151e2d9887

Add "set default certificate" modal dialog

view details

push time in 5 days

issue commentNethServer/dev

Certificate update event cut off by Cockpit UI

This is what happens if the certificate changes but the login screen page wasn't reloaded.

image

DavidePrincipi

comment created time in 5 days

issue commentNethServer/dev

Rspamd: whitelist/blacklist enhancement

Test case 0 - sender blacklist

  • Add a complete address to the sender blacklist, and check the message is rejected (e.g. user@complete.example.com)
  • Add a third level domain like my.example.com to the sender black list, and check the message is rejected if the sender is in that domain
  • Add a second level domain like example.com to the sender black list, and check the message is rejected if the sender is in that domain

Test case 1 - sender whitelist vs sender blacklist

With the blacklist from test case 0:

  • Add the same complete sender address user@complete.example.com to the whitelist and check it wins over the blacklist rule. Message must be accepted
  • Add other.example.com to the sender whitelist and check that a sender from that domain is always accepted
  • Check a sender from example.com is still rejected

Test case 2 - recipient whitelist vs sender blacklist

Check that by setting a recipient whitelist rule it always win against the blacklist sender rule.

Test case 3 - IP whitelist vs sender blacklist

Check that by setting an IP client whitelist in Relay > Configuration > Allow relay from IP addresses, the IP whitelist always wins over the sender blacklist

stephdl

comment created time in 5 days

delete branch DavidePrincipi/nethserver-mail

delete branch : fix-multimap-regression3

delete time in 5 days

push eventNethServer/nethserver-mail

Davide Principi

commit sha 39b0e9077aed58c5662fb3870236d2b1cf9ad808

Evaluate sender blacklist later in filter stage

view details

Davide Principi

commit sha 257c3a6f2a67df104fdfa99b8a4c43ac0e709f10

Eval domain matches with and without :tld filter This ensures that for a given address, its domain suffix is tested two times, the first one as full domain string and the second one considering only its "effective second level domain (eTLD)" suffix.

view details

Davide Principi

commit sha 45012460ecbf6fa2f546af1913c2d12d8fb38915

Code refactor and comment fixes

view details

Stephane de Labrusse

commit sha 25c8efdecb562219308913697c8665bb90e2e14e

Use force_actions to reject emails in blacklist

view details

Davide Principi

commit sha 883ce182c72ad3bc5cf0a3a5111b46ea123d33d4

Use a more specific rule name This might help for code searches, or log traces (?) [skip ci]

view details

Stephane de Labrusse

commit sha 732292f5ca52c2ef9502d0418051dac540fae3a7

Autolearn is a range of values

view details

Davide Principi

commit sha e23a329e9a4064fabb9a111f5e2544e8227277da

Merge pull request #171 from DavidePrincipi/fix-multimap-regression3 Avoid rule evaluation order conflicts - Evaluate sender blacklist later in filter stage - Eval domain matches with and without :tld filter - Start Bayes autolearn only if the score is out of the static range [-5,25], to avoid spam training with a good message just hitting FROM_BLACKLIST NethServer/dev#5940

view details

push time in 5 days

PR merged NethServer/nethserver-mail

Avoid rule evaluation order conflicts
  1. Evaluate sender blacklist later in filter stage
  2. Eval domain matches with and without :tld filter
  3. Start Bayes autolearn only if the score is out of the static range [-5,25], to avoid spam training with a good message just hitting FROM_BLACKLIST

https://github.com/NethServer/dev/issues/5940

+45 -158

6 comments

13 changed files

DavidePrincipi

pr closed time in 5 days

create barnchDavidePrincipi/nethserver-cockpit

branch : b5977

created branch time in 5 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha 883ce182c72ad3bc5cf0a3a5111b46ea123d33d4

Use a more specific rule name This might help for code searches, or log traces (?) [skip ci]

view details

push time in 5 days

PR closed NethServer/nethserver-mail

Fix white/black list rules eval order

Use a regexp match table for a backward-compatible implementation of subdomain matching rules.

Based on #155

+190 -347

2 comments

28 changed files

DavidePrincipi

pr closed time in 5 days

pull request commentNethServer/nethserver-mail

Fix white/black list rules eval order

Regexp are not good to match tld domains like co.uk...

DavidePrincipi

comment created time in 5 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha 45012460ecbf6fa2f546af1913c2d12d8fb38915

Code refactor and comment fixes

view details

push time in 6 days

PR opened NethServer/nethserver-mail

Avoid rule evaluation order conflicts
  1. Evaluate sender blacklist later in filter stage
  2. Eval domain matches with and without :tld filter
+27 -133

0 comment

9 changed files

pr created time in 6 days

create barnchDavidePrincipi/nethserver-mail

branch : fix-multimap-regression3

created branch time in 6 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha 27c323e64f8891d76dff7dfe98e1b3ca6c565e10

Delete old expanded templates

view details

Davide Principi

commit sha 673c46e620d5636a2395b97dfecf3ecfda06f73b

White/black lists with regexp tables

view details

Davide Principi

commit sha efaf386ac837696775bf76a6f1d751e2a87939cd

Evaluate whitelist rules before blacklist

view details

Davide Principi

commit sha 47476a561dcb2447b771abca8db9cbc2094a24f8

White space change [skip ci]

view details

push time in 6 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha db2883bbadf0d3a792b325182ac715d591756c1b

White space change [skip ci]

view details

push time in 6 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha c3742a2f4fb2333e1161ddec03a8e4b6caf6cf8a

filter. Fix white/black list rules eval order Use a regexp match table for a backward-compatible implementation of subdomain matching rules.

view details

Davide Principi

commit sha 51faf657408e4806a71d7ae2e5f61a2c9fa0aa89

Delete old expanded templates

view details

Davide Principi

commit sha e2012d4310108e4d82ccb3367f9db1891ec5fd30

Whitespace fix

view details

Davide Principi

commit sha 70653c1ff87ae5bb090238850da731cee7154d6e

White/black lists with regexp tables

view details

Davide Principi

commit sha 86eb379593e6ea0563c1abcc0b7d9c1d2a083e26

Evaluate whitelist rules before blacklist

view details

push time in 6 days

issue commentNethServer/dev

Delegation regression in Cockpit pinned apps

The bug origin was already found and a fix is planned for the coming days. Could you help to test it?

DavidePrincipi

comment created time in 7 days

issue openedNethServer/dev

Certificate update event cut off by Cockpit UI

Changing the certificate from the Cockpit UI leads to an incomplete certificate-update event execution. The event is signaled and cut off after a moment.

Steps to reproduce

  • Log in on Cockpit UI
  • Go to System > Certificates > Edit self-signed certificate
  • Click the Save button

Expected behavior

The new certificate is generated and dependent services are configured/restarted.

Actual behavior

The new certificate is generated but not applied.

In /var/log/messages, after certificate-update templates expansion:

Dec  4 12:44:49 vm5 esmith::event[13661]: Action: /etc/e-smith/events/certificate-update/S20nethserver-cockpit-conf SUCCESS [0.129599]
Dec  4 12:44:49 vm5 systemd-logind: Removed session 9.

Evidence of the "killed" root session that was running the event.

Components

nethserver-cockpit-1.3.6-1.ns7.noarch

See also

https://community.nethserver.org/t/cockpit-ssl-tls-certificate-update-is-not-complete-no-problem-with-nethgui/14049


Thanks to Neustradamus for raising the issue

created time in 7 days

issue openedNethServer/dev

Delegation regression in Cockpit pinned apps

Pinned apps are the same for any user accessing the Cockpit UI. Since the delegation refactor #5805 the redirect behavior does not work any more.

Steps to reproduce

  • Pin the Web Server app in the left menu
  • Access Cockpit with as a user which has no privileges on Web Server
  • Click the left menu "Web Server" shortcut

Expected behavior

The Dashboard page is shown instead of Web Server app

Actual behavior

The Web Server app is displayed, though information is missing.

Components

nethserver-cockpit-1.3.6-1.ns7.noarch


Thanks to @edospadoni

created time in 7 days

CommitCommentEvent

delete branch DavidePrincipi/nethserver-mail

delete branch : fix-multimap-regression

delete time in 7 days

PR closed NethServer/nethserver-mail

Fix white/black list rules eval order

Use combined white/black lists domain rules to retain the same rules order of 1.9.x and implement the subdomain exact match list.

Based on PR #155

+171 -264

2 comments

27 changed files

DavidePrincipi

pr closed time in 7 days

pull request commentNethServer/nethserver-mail

Fix white/black list rules eval order

I tried also with different selector=".."; values as suggested by the combined rules docs. It only worked with selector="from:domain";. Appending :tld didn't work as expected.

DavidePrincipi

comment created time in 7 days

PR opened NethServer/nethserver-mail

Fix white/black list rules eval order

Use a regexp match table for a backward-compatible implementation of subdomain matching rules.

Based on #155

+224 -480

0 comment

49 changed files

pr created time in 8 days

create barnchDavidePrincipi/nethserver-mail

branch : fix-multimap-regression2

created branch time in 8 days

delete branch DavidePrincipi/nethserver-mail

delete branch : b5843

delete time in 8 days

PR opened NethServer/nethserver-mail

Fix white/black list rules eval order

Use combined white/black lists domain rules to retain the same rules order of 1.9.x and implement the subdomain exact match list.

Based on PR #155

+171 -264

0 comment

27 changed files

pr created time in 8 days

create barnchDavidePrincipi/nethserver-mail

branch : fix-multimap-regression

created branch time in 8 days

push eventNethServer/nethserver-mail

Davide Principi

commit sha 2c180c5936f5391061ff6b8a4944bafd48b8fba2

filter. Fix olefy service restart

view details

Davide Principi

commit sha e955d7901f9f75414f4819c62bf3d576d3b90c16

Release 2.9.2-2

view details

push time in 8 days

push eventNethServer/nethserver-mail

Davide Principi

commit sha 2c180c5936f5391061ff6b8a4944bafd48b8fba2

filter. Fix olefy service restart

view details

Davide Principi

commit sha e955d7901f9f75414f4819c62bf3d576d3b90c16

Release 2.9.2-2

view details

Davide Principi

commit sha 2cb6fe59a17d993c9bbc354069d74e2ea335c00b

Merge branch 'bugfixes'

view details

push time in 9 days

created tagDavidePrincipi/nethserver-mail

tag2.9.2

Configuration for Postfix, Dovecot, Rspamd, OpenDKIM

created time in 9 days

create barnchDavidePrincipi/nethserver-mail

branch : bugfixes

created branch time in 9 days

created tagNethServer/olefy

tag1.0.1

NethServer RPM for olefy/oletools

created time in 9 days

push eventNethServer/olefy

Davide Principi

commit sha b11aa29f8e6e87210df41aab570539e12853a200

Release 1.0.1

view details

push time in 9 days

issue closedNethServer/dev

Rspamd: deleting a rule always delete latest

Steps to reproduce

  • Login into Cockpit interface
  • Go to Email > Filters page
  • Add 4 rules
  • Try to delete one rules (not last in the list)

Expected behavior

  • Rules is deleted

Actual behavior

  • The deleted rules is the last in the list

Components

nethserver-mail
nethserver-cockpit

closed time in 9 days

federicoballarini

issue closedNethServer/dev

Olefy TCP port 10050 conflict

The olefy service listens on port 10050 and conflicts with the (reserved) Zabbix agent port.

Expected behavior

Olefy must be assigned to a free IANA TCP port

Actual behavior

We have a port conflict.

Components

  • nethserver-mail-filter-2.9.1-1.ns7.noarch
  • olefy-1.0.0-1.ns7.x86_64

See also

Issue #5891


@syntaxerrormmm

closed time in 9 days

DavidePrincipi

issue closedNethServer/dev

Getmail: differences between NethGUI and Cockpit

Steps to reproduce

  • Modify/add a connector from NethGUI with "Scan with filters" check
  • Save and Login into Cockpit
  • Click on Edit Pop3 Connector

Expected behavior

Scan with filter check is checked

Actual behavior

Scan with filter check is not checked

Components

nethserver-mail
nethserver-cockpit

See also

https://community.nethserver.org/t/new-cockpit-pop3-connector-scan-messages-with-email-filter-checkbox-status

closed time in 9 days

federicoballarini

push eventNethServer/nethserver-mail

Federico Ballarini

commit sha d9eed24228a369cbe64a6962c82802d305df953c

ui. fix rules removal problem (#165) NethServer/dev#5951

view details

Federico Ballarini

commit sha db9bad27a62075ea30812309d2dd55e3eca267fc

ui. filtercheck is not shown properly (#166) https://github.com/NethServer/dev/issues/5952

view details

Davide Principi

commit sha 19548f19b1da95b055f2ca5f7f1f752d3bc667d4

Upgrade default Olefy listen port (#167) NethServer/dev#5963

view details

Davide Principi

commit sha 84a01e23716f3e21c0077b453fb482f85f080623

Release 2.9.2

view details

Davide Principi

commit sha e2cf5cbca984a9cf414e4ace168cd6f16ed40922

Merge branch 'bugfixes'

view details

Davide Principi

commit sha e6de16878da31981c6bb31e71f4a47e9df42bba9

travis.yml cleanup

view details

push time in 9 days

created tagNethServer/nethserver-mail

tag2.9.2

Configuration for Postfix, Dovecot, Rspamd, OpenDKIM

created time in 9 days

create barnchNethServer/nethserver-mail

branch : bugfixes

created branch time in 9 days

issue commentNethServer/dev

Upgrade to Rspamd 2.x

Added rspamd-2.2-1.x86_64.rpm to testing repository.

stephdl

comment created time in 9 days

push eventNethServer/docker-demo

Davide Principi

commit sha f2bfcc613c3314b8fc67ed4825dab5b427969bf8

Fix bad build against 8 version

view details

push time in 9 days

issue closedNethServer/dev

Cockpit: improve httpd module view

We need to change some things into httpd module:

  • change delete on Virtual hosts and Reverse proxy pages icon with fa fa-times instead of fa pficon-delete
  • move others icon to fa class (according to other NethServer page)
  • add Enter key press event on Virtual hosts and Reverse proxy

closed time in 9 days

federicoballarini

issue closedNethServer/dev

Change PHP-FPM version in Web server app

We could make an option to change the php version with php-fpm in the cockpit UI

Proposed solution Make an UI able to install the needed php version and create the pool automatically. As a NFR we could add some phpadmin directive to adjust the php setting of the vhost, no matter what php version is used

See also

  • https://community.nethserver.org/t/cannot-find-php-scl-on-cockpit/13852
  • https://community.nethserver.org/t/official-support-of-php-fpm-inside-web-server-app/13991

thank @DavidePrincipi for the support

closed time in 9 days

stephdl

push eventNethServer/nethserver-httpd

Davide Principi

commit sha 2e6b2adfc8cfea40c7b73e7fe870c98d130960f5

Release 3.7.0

view details

push time in 9 days

created tagNethServer/nethserver-httpd

tag3.7.0

Ibays and virtual hosts configuration for Apache/Httpd

created time in 9 days

issue commentNethServer/dev

Update to Nextcloud 17

Test case 1

  • installed nextcloud from testing, then :smiling_imp:
  • configured local AD accounts provider

OK

th3-r00st3r

comment created time in 12 days

push eventNethServer/nethserver-cockpit

Davide Principi

commit sha d6581fab808d74de0b1bebd319d2ec7cff83f5fc

Fix DC creation label typo

view details

push time in 12 days

issue commentNethServer/dev

Update to Nextcloud 17

I installed the package from testing with nethserver-httpd, to check PHP-FPM integration. No accounts provider at all.

NextCloud admin's login works correctly

th3-r00st3r

comment created time in 12 days

issue commentNethServer/dev

Change PHP-FPM version in Web server app

Test case 0

Web root popover ok

Test case 1

/etc/php.d/nethserver.ini has max_file_uploads = 20, ok

Test case 2

The error is now displayed, though we should improve it, in nethserver.js. ok.

Test case 3

Test method

  1. Upload with FTP a PHP script:
<?php

phpinfo();
error_log('max_execution_time ' . ini_get('max_execution_time'));
  1. Dump the phpinfo output in a publicly accessible URL

    curl -H 'Host: vhost1.tld' http://$(hostname)/phpinfo.php > /var/www/html/vhost1.html

  2. Read the dump by pointing my browser: http://$(hostname)/vhost1.html

  3. Change the settings and inspect the error_log file

Results:

  • Successful install of PHP version 7.1 and 7.2, ok
  • Custom parameters override, ok
  • vhost-specific log files, ok
  • settings expanded to /etc/opt/rh/rh-php7{1,2}/php-fpm.d/000-virtualhost.conf or /etc/httpd/conf.d/virtualhosts.conf (depending on the selected PHP version)

Test case 4

note: the config-backup does not ship vhost dir. Web root directories must be restored from data backup.

Configuration restored correctly, ok

Test case 5

virtual hosts configuration has been cleaned up from Apache and PHP-FPM pools, ok

Additional test

installed with NextCloud, using PHP-FPM 7.2, pool www:

29981 ?        Ss     0:00 php-fpm: master process (/etc/opt/rh/rh-php72/php-fpm.conf)
30041 ?        S      0:00  \_ php-fpm: pool c4bd93b8cf8d383
30042 ?        S      0:00  \_ php-fpm: pool c4bd93b8cf8d383
30045 ?        S      0:00  \_ php-fpm: pool c4bd93b8cf8d383
30046 ?        S      0:00  \_ php-fpm: pool c4bd93b8cf8d383
30047 ?        S      0:00  \_ php-fpm: pool c4bd93b8cf8d383
30048 ?        S      0:00  \_ php-fpm: pool www
30049 ?        S      0:00  \_ php-fpm: pool www
30050 ?        S      0:00  \_ php-fpm: pool www
30051 ?        S      0:00  \_ php-fpm: pool www
30052 ?        S      0:00  \_ php-fpm: pool www
32299 ?        S      0:00  \_ php-fpm: pool www

no conflicts, ok

Set VERIFIED label!

stephdl

comment created time in 12 days

issue commentNethServer/dev

Olefy TCP port 10050 conflict

Test case

After updating to the testing packages, the olefy service must listen on port 10632

DavidePrincipi

comment created time in 12 days

delete branch DavidePrincipi/nethserver-mail

delete branch : fix-olefy-port

delete time in 12 days

push eventNethServer/nethserver-mail

Davide Principi

commit sha 03fb9fa5797b6feb3c9d8d4071878c4664acd6df

Upgrade default Olefy listen port (#167) NethServer/dev#5963

view details

push time in 12 days

PR merged NethServer/nethserver-mail

Upgrade default Olefy listen port

The new Olefy 1.0.1 package fixes a TCP port conflict. The port 10632 is the new (unassigned) port number.

NethServer/dev#5963

+29 -1

3 comments

3 changed files

DavidePrincipi

pr closed time in 12 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha 831455ed4230e8d854fb06f5b31213ef8161ee97

.spec: revert olefy version requirement As the .conf file is now a template we do not need a new olefy package version.

view details

push time in 13 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha 1a7b0d46dcf30ad259a93d25bc7b139cd11f819a

Whitespace change [skip ci]

view details

push time in 13 days

push eventDavidePrincipi/nethserver-mail

Davide Principi

commit sha fef4e0fb3b86e06a0a8af6a34b7b27a954d8802d

Apply new olefy port settings The olefy package marks its config file as noreplace. We need to make a template of it.

view details

push time in 13 days

PR opened NethServer/nethserver-mail

Reviewers
Upgrade default Olefy listen port

The new Olefy 1.0.1 package fixes a TCP port conflict. The port 10632 is the new (unassigned) port number.

NethServer/dev#5963

+2 -2

0 comment

2 changed files

pr created time in 13 days

created tagDavidePrincipi/nethserver-mail

tag2.9.0

Configuration for Postfix, Dovecot, Rspamd, OpenDKIM

created time in 13 days

create barnchDavidePrincipi/nethserver-mail

branch : fix-olefy-port

created branch time in 13 days

created tagDavidePrincipi/nethserver-mail

tag2.9.1

Configuration for Postfix, Dovecot, Rspamd, OpenDKIM

created time in 13 days

created tagDavidePrincipi/nethserver-mail

tag2.8.3

Configuration for Postfix, Dovecot, Rspamd, OpenDKIM

created time in 13 days

push eventNethServer/olefy

Davide Principi

commit sha 98f42575cba706bb56683c6cbe65ee0b0ca77780

Fix TCP port conflict The port number 10050 is reserved to Zabbix agent Ref: https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt New assigned port: 10632 NethServer/dev#5963

view details

push time in 13 days

issue openedNethServer/dev

Olefy TCP port 10050 conflict

The olefy service listens on port 10050 and conflicts with the (reserved) Zabbix agent port.

Expected behavior

Olefy must be assigned to a free IANA TCP port

Actual behavior

We have a port conflict.

Components

  • nethserver-mail-filter-2.9.1-1.ns7.noarch
  • olefy-1.0.0-1.ns7.x86_64

@syntaxerrormmm

created time in 13 days

delete branch DavidePrincipi/nethserver-httpd

delete branch : fpm-install-subtask

delete time in 13 days

push eventNethServer/nethserver-httpd

Davide Principi

commit sha 656c2181bdabb80abe37b8314347b30173a06d89

Clean up unused translations

view details

Davide Principi

commit sha c7e47c1ed171c8b84ccdffe3fa0a788a7c2b68d9

Separate PHP-FPM "install" button

view details

Davide Principi

commit sha 10df0d97181ec7ad0e303b1ce206f3dc906cf31a

Fix popover positioning The popover on "top" slips under the left nav menu in a narrow screen. The fix sets the default position, "right": it seems to work around the narrow screen issue.

view details

Edoardo Spadoni

commit sha 03f8a2e669cc1a9d370612d260b1f3814d27388c

Suppress VueJS warning [Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "advanced"

view details

Davide Principi

commit sha bb47bf9dcf117484df6a8ba89a413c7009b2e9c1

Fix Edit dialog submit button state The Edit button does not reflect the selected PHP-FPM install status.

view details

Davide Principi

commit sha 8efd798beacbf875ecb447aaab11c30c01c443c9

Merge pull request #60 from DavidePrincipi/fpm-install-subtask Separate PHP-FPM "install" button NethServer/dev#5912

view details

push time in 13 days

PR merged NethServer/nethserver-httpd

Separate PHP-FPM "install" button

https://github.com/NethServer/dev/issues/5912

+68 -36

4 comments

3 changed files

DavidePrincipi

pr closed time in 13 days

push eventDavidePrincipi/nethserver-httpd

Davide Principi

commit sha bb47bf9dcf117484df6a8ba89a413c7009b2e9c1

Fix Edit dialog submit button state The Edit button does not reflect the selected PHP-FPM install status.

view details

push time in 13 days

push eventDavidePrincipi/nethserver-httpd

Edoardo Spadoni

commit sha 03f8a2e669cc1a9d370612d260b1f3814d27388c

Suppress VueJS warning [Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "advanced"

view details

push time in 13 days

PR closed NethServer/nethserver-lang

For a nice ejabberd package :)

For a nice ejabberd package :)

+205 -194

1 comment

64 changed files

Neustradamus

pr closed time in 13 days

pull request commentNethServer/nethserver-lang

For a nice ejabberd package :)

A similar PR was already rejected

Neustradamus

comment created time in 13 days

PR closed NethServer/comps

ejabberd XMPP server

ejabberd XMPP server

+32 -32

1 comment

19 changed files

Neustradamus

pr closed time in 13 days

pull request commentNethServer/comps

ejabberd XMPP server

We will decide how to change the software center module name (in a consistent way) for the next minor release.

Closing by now

Neustradamus

comment created time in 13 days

PR closed NethServer/docs

ejabberd changes and improvements

ejabberd changes and improvements

+93 -97

1 comment

6 changed files

Neustradamus

pr closed time in 13 days

more