profile
viewpoint
David Kutugata DavidKutu Microsoft Redmond, Washington

DavidKutu/VHDL_compiler 1

A compiler made with flex and bison for an original code based on VHDL

microsoft/vscode-gather 1

Gather for the Python Extension

DavidKutu/algorists 0

Repository for sharing slides and code for the Algorists team

DavidKutu/MIPS_procesor 0

A MPIS processor described in VHDL

DavidKutu/online_judges 0

various coding problems from online judges

DavidKutu/piano_robot 0

The code and description for a custom made robot hand that could play the piano

DavidKutu/sample_compiler 0

A simple compiler made with flex and bison

DavidKutu/search_rescue_robot 0

A competition robot, for details see "ESPECIFICACIONES"

DavidKutu/vscode-docs 0

Public documentation for Visual Studio Code

PR opened microsoft/vscode-python

Fix perf yaml skip news
  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+5 -5

0 comment

1 changed file

pr created time in 6 minutes

push eventmicrosoft/vscode-python

DavidKutu

commit sha 88b98cbf870e322cdc7b6d16fa98a72c651c9d19

another fix

view details

push time in an hour

create barnchmicrosoft/vscode-python

branch : david/fixPerf

created branch time in 2 hours

issue commentmicrosoft/vscode-python

In a notebook (.ipynb file) paste double pastes.

I was never able to repro this on Windows or Ubuntu, as far as I know it only happens on Mac.

ddouglas87

comment created time in 3 hours

push eventmicrosoft/vscode-python

David Kutugata

commit sha c2cda3ddeb752867e28edb58c3194783860b232c

Remove gather from the Python Extension (#12607) * removed gather and ppa * remove ppa types * fixed functional tests removed unit tests (those will be in the gather extension) update name of the gather extension * updated the comments on scritps/notebooks generated by gather * removed enableGather setting and all mention of python program analysis * create the extension pack * fix the functional tests * remove extension pack in case the gather ext is not published yet * hide gather button if the extension is not installed * add IGatherProvider itnerface added localization and telemetry * fix tests

view details

push time in 3 hours

delete branch microsoft/vscode-python

delete branch : david/removeGather

delete time in 3 hours

PR merged microsoft/vscode-python

Reviewers
Remove gather from the Python Extension skip news

For #12494, #12496, #12497

  • remove all mention of ppa

  • remove the setting 'enableGather'

  • removed gather.ts and replace it with the gather extension

  • updated the comments on the gathered scripts/notebooks

  • hides the gather button if the extension is not installed

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).

  • [x] Title summarizes what is changing.

  • [ ] Has a news entry file (remember to thank yourself!).

  • [ ] Appropriate comments and documentation strings in the code.

  • [ ] Has sufficient logging.

  • [ ] Has telemetry for enhancements.

  • [x] Unit tests & system/integration tests are added/updated.

  • [ ] Test plan is updated as appropriate.

  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

  • [ ] The wiki is updated with any design decisions/details.

+59 -1268

1 comment

38 changed files

DavidKutu

pr closed time in 3 hours

PR merged microsoft/vscode-python

Reviewers
check JUPYTER_PATH on kernel finder

For #12694

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+47 -3

1 comment

3 changed files

DavidKutu

pr closed time in 3 hours

push eventmicrosoft/vscode-python

David Kutugata

commit sha 90628a7e5875328352c6f033add3c37334052562

check JUPYTER_PATH on kernel finder (#12768) * Include the JUPYTER_PATH environment variable when searching the disk for kernels. * fix unit tests * check if paths are real on windows added a function to get the env var separator * use path.delimeter * update unit tests

view details

push time in 3 hours

delete branch microsoft/vscode-python

delete branch : david/checkJUPYTER_PATH

delete time in 3 hours

push eventmicrosoft/vscode-python

DavidKutu

commit sha c0f4e09776841278c7e56bea9626455c6be73e83

update unit tests

view details

push time in 4 hours

push eventmicrosoft/vscode-python

DavidKutu

commit sha 733277230471af6f551256c2c1dcff90d77e4386

fix tests

view details

push time in a day

push eventmicrosoft/vscode-python

DavidKutu

commit sha 241e8310eb98ac5e14577ab18e5105fd4e5a938d

add IGatherProvider itnerface added localization and telemetry

view details

push time in a day

push eventmicrosoft/vscode-python

DavidKutu

commit sha 6cba27e615aa88119fc4f4f727a140e6812a6bbc

use path.delimeter

view details

push time in a day

Pull request review commentmicrosoft/vscode-python

Remove gather from the Python Extension

 export interface INotebookExecutionLogger extends IDisposable {     preHandleIOPub?(msg: KernelMessage.IIOPubMessage): KernelMessage.IIOPubMessage; } -export const IGatherProvider = Symbol('IGatherProvider');-export interface IGatherProvider {

To hide it and avoid other people knowing how it works.

DavidKutu

comment created time in a day

Pull request review commentmicrosoft/vscode-python

check JUPYTER_PATH on kernel finder

 export class KernelFinder implements IKernelFinder {             if (process.env.ALLUSERSPROFILE) {                 paths.push(path.join(process.env.ALLUSERSPROFILE, 'jupyter', 'kernels'));             }++            if (jupyterPathVar !== '') {+                const jupyterPaths = jupyterPathVar.split(';');

I added a function that checks OS

DavidKutu

comment created time in a day

push eventmicrosoft/vscode-python

Mikhail Arkhipov

commit sha 7d2d03654595f1935a2ab7586647254ab7c47d3c

Remove language server survey (#12677) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Remove LS surver * More removal * One more * Typo * Remove unused

view details

Joyce Er

commit sha a067a95315aae8fa862dc602529f06c4293e6307

Add link to python.dataScience.alwaysTrustNotebooks setting (#12702)

view details

Rich Chiodo

commit sha 09625065242c9e4865c9b7c84feabfe11ea34145

Special case failure for windows (#12714)

view details

Don Jayamanne

commit sha 08a0538e450dfcd5a9f1e7b95cd3f7fad2afd09a

Add some logging to a flaky test (#12711) For #12690 Added some logging to see whats causing the tests to fail.

view details

Brett Cannon

commit sha 9c338d4a81ff2c5a0bdcb1c84a1a21b107d88e5e

Drop Developer Tools from the bug issue template

view details

Kartik Raj

commit sha e76070ea2187c73c566b9d3d654f4609dcaf5e78

Increase timeout for flaky tests & hooks (#12721)

view details

Kartik Raj

commit sha 7de0f0f448f00819bc46e00b5cd642d1f0101b0d

Add telemetry for 'Select Interpreter' command (#12723) * Add telemetry for 'Select Interpreter' command * Apply suggestions from code review Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com> * Code reviews Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

view details

Rich Chiodo

commit sha 9c582aa56be97c3a3f297cfbbbea9e2a2aa9427f

Better way to determine the 'real' path for a file than assuming it's in a certain location (#12734)

view details

Don Jayamanne

commit sha 27dfd87f19569451e237760aff2945628d076d3c

Process iopub messages synchronously (#12733) For #12588 At least in VS Code Notebooks, the improvement is fairly significant. Down from 3minutes to 5 seconds. Note: This doesn't completely resolve the slow times experienced in the existing Notebook Editor. We have delays due to UI updates there (however that too is down from 3minutes to ~15 seconds). That might probably need to be addressed separately. Either way its a significantly improvement.

view details

Joyce Er

commit sha f2c229e01505cf6b21381b0c18f3749b6cbc01d0

Put trusted notebooks behind an experiment (#12712)

view details

Joyce Er

commit sha 84a99ee59546ce22772d964b7726329c647fb9d4

Disable trust message button if notebook is trusted (#12755)

view details

DavidKutu

commit sha b1d4b42d24053e5b3e8771b6bfe802c4fdfced75

Merge branch 'master' into david/removeGather

view details

DavidKutu

commit sha a738941962b18fb2e8cdcfb9e7d9633be9581b83

remove extension pack in case the gather ext is not published yet

view details

DavidKutu

commit sha 21057629d0a568e24d7fa8c18868a12bf1ed347e

hide gather button if the extension is not installed

view details

push time in a day

PR merged microsoft/vscode-python

vscode-python//GreggJuanEduardoPH:master

For #

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [x] Appropriate comments and documentation strings in the code.
  • [x] Has sufficient logging.
  • [x] Has telemetry for enhancements.
  • [x] Unit tests & system/integration tests are added/updated.
  • [x] Test plan is updated as appropriate.
  • [x] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [x] The wiki is updated with any design decisions/details.
+177 -536

0 comment

42 changed files

GreggJuanEduardoPH

pr closed time in a day

PR merged microsoft/vscode-python

vscode-python//The-Peso-G:master

For #

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [x] Appropriate comments and documentation strings in the code.
  • [x] Has sufficient logging.
  • [x] Has telemetry for enhancements.
  • [x] Unit tests & system/integration tests are added/updated.
  • [x] Test plan is updated as appropriate.
  • [x] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [x] The wiki is updated with any design decisions/details.
+177 -536

0 comment

42 changed files

GreggJuanEduardoPH

pr closed time in a day

push eventmicrosoft/vscode-python

DavidKutu

commit sha 155cec69e8c5be54d8542fc328f9cdc4a18d7cbf

check if paths are real on windows added a function to get the env var separator

view details

push time in a day

Pull request review commentmicrosoft/vscode-python

check JUPYTER_PATH on kernel finder

 export class KernelFinder implements IKernelFinder {                 path.join('usr', 'local', 'share', 'jupyter', 'kernels'),                 path.join(this.pathUtils.home, secondPart)             ];++            if (jupyterPathVar !== '') {+                const jupyterPaths = jupyterPathVar.split(':');

; is the separator for windows and : for Unix

DavidKutu

comment created time in a day

Pull request review commentmicrosoft/vscode-python

check JUPYTER_PATH on kernel finder

 export class KernelFinder implements IKernelFinder {             if (process.env.ALLUSERSPROFILE) {                 paths.push(path.join(process.env.ALLUSERSPROFILE, 'jupyter', 'kernels'));             }++            if (jupyterPathVar !== '') {+                const jupyterPaths = jupyterPathVar.split(';');+                paths.push(...jupyterPaths);

Environment variables have variables in them?

DavidKutu

comment created time in a day

push eventmicrosoft/vscode-python

DavidKutu

commit sha bd66d6aef15ce9e96a1d96aa054124a68085949e

fix unit tests

view details

push time in a day

Pull request review commentmicrosoft/vscode-python

check JUPYTER_PATH on kernel finder

 export class KernelFinder implements IKernelFinder {             if (process.env.ALLUSERSPROFILE) {                 paths.push(path.join(process.env.ALLUSERSPROFILE, 'jupyter', 'kernels'));             }++            if (jupyterPathVar !== '') {+                const jupyterPaths = jupyterPathVar.split(';');

Should ';' not be hardcoded? Its supposed to be called 'os.pathsep' but I couldn't find it in the project.

DavidKutu

comment created time in a day

PR opened microsoft/vscode-python

check JUPYTER_PATH on kernel finder

For #12694

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+16 -1

0 comment

2 changed files

pr created time in a day

create barnchmicrosoft/vscode-python

branch : david/checkJUPYTER_PATH

created branch time in a day

Pull request review commentmicrosoft/vscode-python

Disable trust message button if notebook is trusted

 export class JupyterInfo extends React.Component<IJupyterInfoProps> {                 ? getLocString('DataScience.notebookIsTrusted', 'Trusted')                 : getLocString('DataScience.notebookIsNotTrusted', 'Not Trusted');             const textSize = text.length;-            const dynamicFont: React.CSSProperties = {-                fontSize: 'var(--vscode-font-size)', // Use the same font and size as the menu-                fontFamily: 'var(--vscode-font-family)',-                maxWidth: this.getMaxWidth(textSize + 5), // plus 5 for the line and margins,-                color: this.props.isNotebookTrusted ? undefined : 'var(--vscode-editorError-foreground)'+            const maxWidth: React.CSSProperties = {+                maxWidth: this.getMaxWidth(textSize + 5) // plus 5 for the line and margins,             };-            const trustTextWidth: React.CSSProperties = {-                maxWidth: this.getMaxWidth(textSize)+            const dynamicStyle: React.CSSProperties = {+                maxWidth: this.getMaxWidth(textSize),+                color: this.props.isNotebookTrusted ? undefined : 'var(--vscode-editorError-foreground)',+                cursor: this.props.isNotebookTrusted ? undefined : 'pointer'             };              return (-                <div className="kernel-status" style={dynamicFont}>

Forget that, I saw the styles.

joyceerhl

comment created time in a day

Pull request review commentmicrosoft/vscode-python

Disable trust message button if notebook is trusted

 export class JupyterInfo extends React.Component<IJupyterInfoProps> {                 ? getLocString('DataScience.notebookIsTrusted', 'Trusted')                 : getLocString('DataScience.notebookIsNotTrusted', 'Not Trusted');             const textSize = text.length;-            const dynamicFont: React.CSSProperties = {-                fontSize: 'var(--vscode-font-size)', // Use the same font and size as the menu-                fontFamily: 'var(--vscode-font-family)',-                maxWidth: this.getMaxWidth(textSize + 5), // plus 5 for the line and margins,-                color: this.props.isNotebookTrusted ? undefined : 'var(--vscode-editorError-foreground)'+            const maxWidth: React.CSSProperties = {+                maxWidth: this.getMaxWidth(textSize + 5) // plus 5 for the line and margins,             };-            const trustTextWidth: React.CSSProperties = {-                maxWidth: this.getMaxWidth(textSize)+            const dynamicStyle: React.CSSProperties = {+                maxWidth: this.getMaxWidth(textSize),+                color: this.props.isNotebookTrusted ? undefined : 'var(--vscode-editorError-foreground)',+                cursor: this.props.isNotebookTrusted ? undefined : 'pointer'             };              return (-                <div className="kernel-status" style={dynamicFont}>

If you remove the dynamic font, does it still become bigger or smaller if you change the font size in VS Code? That's important for accesibility.

joyceerhl

comment created time in a day

Pull request review commentmicrosoft/vscode-gather

Some suggestions...

 # Gather for the Python extension -A [Visual Studio Code](https://code.visualstudio.com/) [extension](https://marketplace.visualstudio.com/VSCode) that adds the gather feature to the [Python extension](https://github.com/microsoft/vscode-python). Gather adds first-class support for refactoring code out of notebooks and into either a script, or another simplified notebook. It will give you only the necessary code you need to execute to reach your selected output.+A [Visual Studio Code](https://code.visualstudio.com/) [extension](https://marketplace.visualstudio.com/VSCode) that adds the experimental Gather feature to the [Python extension](https://github.com/microsoft/vscode-python). With one button click on any notebook or Interactive Window cell, Gather uses a static analysis technique to find and then copy all of the dependent code that was used to generate that cell's result into a new notebook or script. 

Do we want to call it experimental?

greazer

comment created time in 5 days

push eventmicrosoft/vscode-gather

DavidKutu

commit sha 2341ffeb5e8c77dd089657fae9c38855acd096d2

added icon

view details

DavidKutu

commit sha 336b2371796a81d0932c154cf3b36a0c3936fe04

updated author

view details

DavidKutu

commit sha 27b7e3f6e3d6934574fbdcc0f2fe6ba45cacf4c9

add unit tests

view details

DavidKutu

commit sha 664850d4b77ef306820d7d32599facf125f24fa7

added readme and some images

view details

David Kutugata

commit sha 08050598aba6c437d617eaae34d42a871e508b2d

Merge pull request #2 from microsoft/david/readMe Add README, icon and tests

view details

push time in 5 days

delete branch microsoft/vscode-gather

delete branch : david/readMe

delete time in 5 days

PR merged microsoft/vscode-gather

Reviewers
Add README, icon and tests
+147 -67

0 comment

10 changed files

DavidKutu

pr closed time in 5 days

PR opened microsoft/vscode-gather

Add README, icon and tests
+147 -67

0 comment

10 changed files

pr created time in 5 days

push eventmicrosoft/vscode-gather

DavidKutu

commit sha 664850d4b77ef306820d7d32599facf125f24fa7

added readme and some images

view details

push time in 5 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha b450b0365beef882de0c86fe3ee06e48905ad9b4

fix the functional tests

view details

push time in 6 days

push eventmicrosoft/vscode-python

Rich Chiodo

commit sha 744cb928d258a494f9797075fcb6baee0801ce01

Fix export from the interactive window (#12704) * Fix export from the interactive window * Make sure to reset flag at beginning of every test. * Potential fix for linxu

view details

Karthik Nadig

commit sha f8a31a3cea8721eaa4abb5bc9bed317a7b0b701f

Merge back release into master (#12701)

view details

Don Jayamanne

commit sha ea4026367449aca9a0e966514ac4c4801fbfa074

Tests for opening multiple notebooks and toggling (#12703)

view details

Pavel Minaev

commit sha 306885efdae1d316e28e6c69e34a7afd893f247b

Fix #12705: Tests broken due to Prospector / Python 2.7 incompatibility (#12707) Pin prospector to 1.2.0 in test-requirements.txt.

view details

DavidKutu

commit sha 7f23a4ef003f56cb6114d27c5248cabff01b0d72

Merge branch 'master' into david/removeGather

view details

DavidKutu

commit sha 7db01267dabd2afd7fa45a7aab3e9bb0a926e15e

updated the comments on scritps/notebooks generated by gather

view details

DavidKutu

commit sha a4f29de1bd80aceb44810605831c208ac6631ef5

removed enableGather setting and all mention of python program analysis

view details

DavidKutu

commit sha ab776ade17f6af907460a324ebeaf549bd97c73c

create the extension pack

view details

push time in 6 days

delete branch microsoft/vscode-gather

delete branch : david/addWebpack

delete time in 6 days

create barnchmicrosoft/vscode-gather

branch : david/readMe

created branch time in 6 days

push eventmicrosoft/vscode-python

Ian Huff

commit sha 46e01e58e86fac1216492eac2c30c035a65b9ca3

pull type from type file (#12605) Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha 782690d042291e61470bdb8e7f357d1f7070f58a

Fix IW kernel selection style (#12608) * Merge KernelSelection and TrustMessage * Rename KernelSelection to JupyterInfo

view details

Ian Huff

commit sha 08b8e5c8a2cb55fe77ccf9b0975aa123f618949c

Cache full ZMQ check promise, not just the result of the import (#12610) * save ZMQ support check in a promise to prevent race condition * remove old comment Co-authored-by: Ian Huff <ianhuff@BE-ADINAB-SB2.europe.corp.microsoft.com>

view details

Joyce Er

commit sha bbca2fd6f8c892b5bdf5f7046480944a580fb8aa

DS: Allow user to override checking notebook trust (#12612)

view details

Kartik Raj

commit sha d214e0114304efff6628adedae9ef2197d396c59

Skip more flaky tests (#12635) * Skip more flaky tests * Add issue link comment

view details

Don Jayamanne

commit sha a42b02662e585b6defcca02f8718e92e641b10c0

Simplify INotebookModel when using VSCode Notebooks (#12604) * Two INotebookModels, one for existing Notebook and one for VS Code Notebooks * VS Code Notebooks will not need a lot of the API in INotebookModel class (such as updates to cells, undo/redo, etc). * VSC Notebooks will use INotebookModel as a mere mirror (readonly view) of the actual VSC NotebookDocument. This PR just refactors stuff (moving stuff to accommodate the two new INotebook classes).

view details

Kartik Raj

commit sha 9891723c1e471c04f404fa4bb48e3a36de0fc827

Changed public API for execution to return an object and provide a callback which is called when interpreter setting changes (#12597) * Modified the API * Fix gulp errors * Code reviews

view details

Don Jayamanne

commit sha 538d9130ff2e25904306c84a3ac5782f0a4da0cd

Model is in charge of updates to model & cells (#12640) For #10496 Part 2 of #12604 Move code related to updates to INotebookModel into the corresponding INotebookModel class.

view details

Luciana Abud

commit sha 096c601ecbfd39816cff06896cdd8a22aec8896d

Remove ** from activation rule in package.json for workspaces with mspythonconfig.json (#12636) * Removing ** from activation rule on presence of mspythoncofing.json file * Add news entry

view details

David Kutugata

commit sha 03e8ad5a9f64df4a8dff5a5a6e983340a6550561

More start page telemetry (#12647) * add telemetry for the start page * add news file

view details

Don Jayamanne

commit sha 2960baff6d992e957830238307903c3d6d29d631

Fix flaky Daemon and MimeType tracker tests (#12646) For #12567, #12637 Use a better package for a fake clock. Added more comments in one of the damon pool tests.

view details

Joyce Er

commit sha 2a1c244fb1797b4082ea8fd1120b2356fc727c31

DS: Open untrusted notebooks as readonly (#12579)

view details

Mikhail Arkhipov

commit sha e0b80243727c598583a073c981c17958328711eb

Language server name (#12653)

view details

Don Jayamanne

commit sha 5a4954ad4e10448902c53f782574ca030d8ba5d3

Fix unit test issues when using ts-node on GHA (#12670) For #12669

view details

Don Jayamanne

commit sha ee929acb9492172b035079b1b1cd20a29d7a3104

Fixes to opening VSCode Notebook (#12671) For #10496 Not sure how, but some changes seem to have gone amiss.

view details

Don Jayamanne

commit sha 2cabccc37d5a94824da3c3570a9b07b8e4c59c3d

Download & install renderer extension when opening a VSC Notebook (#12652) Disabled, until the Renderers Extension can be shipped.

view details

Joyce Er

commit sha 14acf9837ffa10082884c8a768d37126d8785f1f

DS: Hide commands for interacting with notebooks when active notebook is untrusted (#12657)

view details

Ian Huff

commit sha 2e4709397db658965ce9a8008b10579e8a6b8ca6

Fix linux tests to report correctly, get rid of stream destroyed messages on raw kernel shutdown (#12643)

view details

Rich Chiodo

commit sha 929195d4ebce66be21c9d3dcfe6c01a5a3d559d1

Add extensibility point to allow custom authorization (#12651) * Working idea? * Working prototype * Abstract out concept of the URI into a handle so can ask for it when appropriate. * Get azure ml compute to work without token in url * Add new extension * Refactor to have other extension supply test compute provider * Get to build * Fix test extension to build with webpack * Extract out user specific entries * Add unit tests * Fixup nbformat changes * Add news entry * Add directions for using to readme * Update styling * Fix failing tests * More functional test failures * Fix sonar error * Use IExtensions instead of vscode directly. * Some refactoring of the example extension * Preliminary api change * Fix up quick picker to go away * Update unit tests * Remove need for unnecessary 'as any' * Can call on second reopen with loading other extensions * Fix error message on reopen without checking extensions * Fix id to be readonly and add test for when no picker call made * Change package json to supply id as well Change uri provider registration to verify uniqueness of ids

view details

Don Jayamanne

commit sha b071d1752a1eaaebc7ec275051805f3fc98f5bb5

Ensure we can open VSCode Notebook with old editor (#12676) If we setup old editor to always open ipynb files, then opening with VSC Notebook doesn't work.

view details

push time in 6 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha 6932dad59a55eb830d27a8ecbe8b2b8289c15713

fixed functional tests removed unit tests (those will be in the gather extension) update name of the gather extension

view details

push time in 6 days

push eventmicrosoft/vscode-gather

DavidKutu

commit sha 7c471a64298d1b560775abad9ab6d359bb4a78d6

add some stuff to the package.json

view details

DavidKutu

commit sha 17e020d157777346d8c0909885e498f65ac1f39b

added webpack made the python extension a dependency

view details

David Kutugata

commit sha aeccfa1715dcc147c07970fa5bf43feaa26f8819

Merge pull request #1 from microsoft/david/addWebpack Add webpack and make the python ext a dependency

view details

push time in 7 days

create barnchmicrosoft/vscode-gather

branch : david/addWebpack

created branch time in 7 days

issue commentmicrosoft/vscode-python

Conda/Jupyter issue error: "StdErr from ShellExec, 'Analysis'..."

@BiancaAU1, please try to add VS Code to the System Variables

BiancaAU1

comment created time in 7 days

issue commentmicrosoft/vscode-python

Conda/Jupyter issue error: "StdErr from ShellExec, 'Analysis'..."

I see, that's very strange that it doesn't work. Is code recognized on PowerShell or cmd.exe? Also, can you show me the content of ...\Microsoft VS Code\bin?

BiancaAU1

comment created time in 8 days

issue commentmicrosoft/vscode-python

Conda/Jupyter issue error: "StdErr from ShellExec, 'Analysis'..."

You need to add VS Code to your path for code . to work. To do that you can follow these instructions:

  • Press the Windows logo on the task bar.
  • Type 'path'
  • Click on 'Edit the system environment variables'
  • On the bottom right, click Environment Variables
  • On the top section, where it says 'User variables for <Your User>' look for 'Path' and highlight it.
  • Press Edit
  • Add the path to the VS Code executable (it should be in C:\Program Files\Microsoft VS Code\bin or C:\Program Files (x86)\Microsoft VS Code\bin if you downloaded it to the default folder)
  • Click 'OK' to finish

Now close your current Anaconda Prompt and open a new one, code . should work.

BiancaAU1

comment created time in 8 days

issue commentmicrosoft/vscode-python

Conda/Jupyter issue error: "StdErr from ShellExec, 'Analysis'..."

I see, in the image you shared, your server has not started. Conda sometimes has issues activating outside of its prompt. Please try this:

  • close VS Code
  • open the Anaconda Prompt (not cmd.exe nor PowerShell)
  • in the Anaconda Prompt, go to your project folder C:\Users\bianc\Desktop\itp\itp_spring_2020
  • activate your environment: conda activate itp_2020
  • run VS Code: code .
  • try to run a cell

Please let me know if that works for you.

BiancaAU1

comment created time in 8 days

issue commentmicrosoft/vscode-python

Jupyter server sets incorrect session path, type and notebook name

Thanks for reporting the issue @kassi. I can only get it to repro on Ubuntu, it looks like notebookapp.list_running_servers() doesn't work on windows. We'll discuss this in our next triage.

kassi

comment created time in 8 days

PR opened microsoft/vscode-python

Port start page telemetry skip news

For #12603

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+18 -3

0 comment

5 changed files

pr created time in 8 days

create barnchmicrosoft/vscode-python

branch : david/portStartPageTelemetry

created branch time in 8 days

push eventmicrosoft/vscode-python

David Kutugata

commit sha 03e8ad5a9f64df4a8dff5a5a6e983340a6550561

More start page telemetry (#12647) * add telemetry for the start page * add news file

view details

push time in 8 days

delete branch microsoft/vscode-python

delete branch : david/moreStartPageTelemetry

delete time in 8 days

PR merged microsoft/vscode-python

Reviewers
More start page telemetry

For #12603

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+17 -3

1 comment

5 changed files

DavidKutu

pr closed time in 8 days

PR opened microsoft/vscode-python

More start page telemetry

For #12603

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+17 -3

0 comment

5 changed files

pr created time in 8 days

create barnchmicrosoft/vscode-python

branch : david/moreStartPageTelemetry

created branch time in 8 days

issue commentmicrosoft/vscode-python

Multhithreading doesn't wotk in python interactive mode but works in jupiter notebook.

Thanks for reporting your issue @MislavSag, could you please share a code example? That'll help a lot in finding the issue.

MislavSag

comment created time in 8 days

issue commentmicrosoft/vscode-python

Conda/Jupyter issue error: "StdErr from ShellExec, 'Analysis'..."

Thanks for letting us know @BiancaAU1. Could you try to activate your environment from an Anaconda Prompt, and then run vscode from that same prompt?

BiancaAU1

comment created time in 8 days

issue commentmicrosoft/vscode-python

Cannot open nbformat 2 or 3 notebooks

@kynan, thanks for bringing it back up. We'll discuss it in our next triage.

kynan

comment created time in 8 days

startedmicrosoft/vscode-python

started time in 11 days

startedmicrosoft/gather-for-the-python-extension

started time in 11 days

push eventmicrosoft/gather-for-the-python-extension

DavidKutu

commit sha db0647c2255235cd597fa80f3e57268aae1dca79

removed unused constants

view details

push time in 11 days

Pull request review commentmicrosoft/vscode-python

Fix IW kernel selection style

 ${buildSettingsCss(this.props.settings)}`}</style>         ) {             if (this.props.settings.showKernelSelectionOnInteractiveWindow) {                 return (-                    <KernelSelection-                        baseTheme={this.props.baseTheme}-                        font={this.props.font}-                        kernel={this.props.kernel}-                        selectServer={this.props.selectServer}-                        selectKernel={this.props.selectKernel}-                    />+                    <div className={'jupyter-info-container'}>

Sounds good in theory, but we are not showing the kernel selection on some cases (Ideally only on the interactive window when using a local server, there's going to be an experiment for it on the August release). We just have to keep that in mind.

joyceerhl

comment created time in 11 days

push eventmicrosoft/gather-for-the-python-extension

DavidKutu

commit sha 72fdb3054ca64efe8899b3005538d44d5a87d4ef

first commit

view details

DavidKutu

commit sha d132aeaf49382113f44d3484842018627b5e9515

Add npm package

view details

DavidKutu

commit sha bbfe00163644221adcfcebdf9bed7695fa8cddbc

add and expose gather code

view details

DavidKutu

commit sha 129ff84509eb15d0b2674290ef4648bef0bf4503

Merge branch 'master' of https://github.com/microsoft/gather-for-the-python-extension

view details

push time in 11 days

created repositorymicrosoft/gather-for-the-python-extension

Gather for the Python Extension

created time in 11 days

PR opened microsoft/vscode-python

Remove gather from the Python Extension

For #12494, #12496, #12497

  • [ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [ ] Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+43 -1119

0 comment

25 changed files

pr created time in 11 days

create barnchmicrosoft/vscode-python

branch : david/removeGather

created branch time in 11 days

Pull request review commentmicrosoft/vscode-python

DS: Open untrusted notebooks as readonly

 export class KernelSelection extends React.Component<IKernelSelectionProps> {                     style={displayNameTextWidth}                     onClick={this.selectKernel}                     role="button"+                    aria-disabled={!!this.props.isNotebookTrusted}

double negative?

joyceerhl

comment created time in 12 days

issue openedmicrosoft/vscode-python

Add webpack to the gather extension

Also use terser or something to protect it.

created time in 13 days

push eventmicrosoft/vscode-python

David Kutugata

commit sha 88f3b432bbe93474cc29e413b6a831050a056beb

Remove kernel change on the Interactive Window (#12439) * add 'select kernel' handle message on the interactive window * remove kernel toolbar from the interactive window if th user uses a local jupyter server * add setting to enable it back * add news file * oops * Add the experiment, as well as IExperimentService on everything that extends WebViewHost * removed setting * add setting back

view details

push time in 14 days

delete branch microsoft/vscode-python

delete branch : david/IntWinRemoveKernelChange

delete time in 14 days

PR merged microsoft/vscode-python

Reviewers
Remove kernel change on the Interactive Window

For #11347, #11090

Its removed when the Jupyter server is local, it appears as normal if the server is remote. And there is a new setting to make appear as always.

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+89 -19

6 comments

16 changed files

DavidKutu

pr closed time in 14 days

issue openedmicrosoft/vscode-python

Remove the 'showKernelSelectionOnInteractiveWindow' setting before the August release

Remove the setting and see if we undo the changes of #12439 depending on its use.

created time in 14 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha e8524596bb9936438738b10247591c675b12276e

add setting back

view details

push time in 14 days

pull request commentmicrosoft/vscode-python

Remove kernel change on the Interactive Window

@DonJayamanne and @rchiodo, I talked with @claudiaregio and @jmew. We decided to add the setting for a month and track it with telemetry. If enough people use the setting to revert (50% of the experiment, though it might change), we remove the setting and revert the changes. If less than that don't use the setting, we remove the setting and the change stays.

DavidKutu

comment created time in 14 days

push eventmicrosoft/vscode-python

David Kutugata

commit sha 1bec89bee8730ad42ce9a0d0d319915e3a299778

discard changes when the user clicks don't save (#12492)

view details

push time in 15 days

delete branch microsoft/vscode-python

delete branch : david/changesNotDiscarded

delete time in 15 days

PR merged microsoft/vscode-python

Reviewers
Discard notebook changes when the user clicks don't save

For #12180

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+5 -0

1 comment

2 changed files

DavidKutu

pr closed time in 15 days

issue openedmicrosoft/vscode-python

Connect the gather extension with the python extension

  1. Make the gather extension callable from the python extension

created time in 15 days

issue openedmicrosoft/vscode-python

Offer to download the extension when the gather button is clicked

  1. Create class that downloads the gather extension
  2. Call it when the gather button is pressed

created time in 15 days

issue closedmicrosoft/vscode-python

Gather Extension

closed time in 15 days

DavidKutu

issue openedmicrosoft/vscode-python

Create the Gather Extension

  1. Put everything external needed to get gather to work on a separate extension
  2. Create a private repo for it

created time in 15 days

issue openedmicrosoft/vscode-python

Gather Extension

created time in 15 days

PR opened microsoft/vscode-python

discard changes when the user clicks don't save

For #12180

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • [x] Title summarizes what is changing.
  • [x] Has a news entry file (remember to thank yourself!).
  • [ ] Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.
+5 -0

0 comment

2 changed files

pr created time in 15 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha 0ca2b4bc0cea898b4d25d3a78ff45a5549201b9e

discard changes when the user clicks don't save

view details

push time in 15 days

create barnchmicrosoft/vscode-python

branch : david/changesNotDiscarded

created branch time in 15 days

pull request commentmicrosoft/vscode-python

Remove kernel change on the Interactive Window

@DonJayamanne and I were chatting and thought its redundant to have a setting and an experiment. The experiment by itself will tell us if people don't like it.

DavidKutu

comment created time in 15 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha 08a8f970a3f9ea05ad6d47b390cc6b4225f1c5cf

removed setting

view details

push time in 15 days

Pull request review commentmicrosoft/vscode-python

Display 'Trusted' / 'Not Trusted' on notebook load

+import * as React from 'react';+import { IFont } from './mainState';++interface ITrustMessageProps {+    isNotebookTrusted: boolean;+    font: IFont;+}++export class TrustMessage extends React.PureComponent<ITrustMessageProps> {+    public render() {+        const text = this.props.isNotebookTrusted ? 'Trusted' : 'Not Trusted';+        const textSize = text.length;+        const dynamicFont: React.CSSProperties = {+            fontSize: 'var(--vscode-font-size)', // Use the same font and size as the menu+            fontFamily: 'var(--vscode-font-family)',+            maxWidth: this.getMaxWidth(textSize + 5), // plus 5 for the line and margins,+            color: this.props.isNotebookTrusted ? undefined : 'red'

I suggest using --vscode-editorError-foreground

joyceerhl

comment created time in 15 days

issue commentmicrosoft/vscode-python

Cell content out of sync

This seems to only happen on mac

atomAltera

comment created time in 18 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha a5965d6fd2e9f571c0b55570ae4b7ba2d7860f52

Add the experiment, as well as IExperimentService on everything that extends WebViewHost

view details

push time in 18 days

issue commentmicrosoft/vscode-python

Expansion of cell output windows

Before we turn our attention to this enhancement, I wanted to give everyone an option to look at big cells without scrolling with our settings:

  • Set 'Python › Data Science: Enable Scrolling For Cell Outputs' to false. This setting makes the box be the size of the cell output.

  • Another option is to have that setting enabled, and change 'Python › Data Science: Max Output Size'. That setting changes the maximum output size for all cells, it goes from 0 to 9999 pixels. That could also get rid of most of your scrollbars.

bpops

comment created time in 18 days

Pull request review commentmicrosoft/vscode-python

Remove kernel change on the Interactive Window

                     "description": "Automatically scroll the interactive window to show the output of the last statement executed. If false, the interactive window will only automatically scroll if the bottom of the prior cell is visible.",                     "scope": "resource"                 },+                "python.dataScience.showKernelSelectionOnInteractiveWindow": {+                    "type": "boolean",+                    "default": false,+                    "description": "Set to true to be able to change the kernel on the Interactive Window with the top toolbar when using a local Jupyter Server. You can also change the kernel on the status bar.",

I'll put it in an experiment then. The numbers are 23K change their kernel out of 155K who use the interactive window

DavidKutu

comment created time in 19 days

Pull request review commentmicrosoft/vscode-python

Remove kernel change on the Interactive Window

                     "description": "Automatically scroll the interactive window to show the output of the last statement executed. If false, the interactive window will only automatically scroll if the bottom of the prior cell is visible.",                     "scope": "resource"                 },+                "python.dataScience.showKernelSelectionOnInteractiveWindow": {+                    "type": "boolean",+                    "default": false,+                    "description": "Set to true to be able to change the kernel on the Interactive Window with the top toolbar when using a local Jupyter Server. You can also change the kernel on the status bar.",

Yes, the setting doesn't do anything in the remote case.

DavidKutu

comment created time in 19 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha 815d3b91418b4ad5ed5e59ce919f5e26f9fc5c03

oops

view details

push time in 19 days

Pull request review commentmicrosoft/vscode-python

Remove kernel change on the Interactive Window

 export class KernelSelection extends React.Component<IKernelSelectionProps> {     }      private selectKernel() {-        if (this.isKernelSelectionAllowed) {-            this.props.selectKernel();-        }+        this.props.selectKernel();

I removed the if because it is redundant.

DavidKutu

comment created time in 19 days

Pull request review commentmicrosoft/vscode-python

Remove kernel change on the Interactive Window

 export class InteractiveWindow extends InteractiveBase implements IInteractiveWi                 this.handleMessage(message, payload, this.handleModelChange);                 break; +            case InteractiveWindowMessages.SelectKernel:+                this.handleMessage(message, payload, this.SelectKernel);+                break;+             default:                 break;         }++        super.onMessage(message, payload);+    }++    public async SelectKernel() {

Oh that's bad, that is something else. I'll remove it.

DavidKutu

comment created time in 19 days

push eventmicrosoft/vscode-python

DavidKutu

commit sha eb3456c6c6e12a6302115afce5ecbf3da219ffb5

add news file

view details

push time in 19 days

more