profile
viewpoint
Dan Albert DanAlbert Google Mountain View, CA

android/ndk 976

The Android Native Development Kit

DanAlbert/cryptrd 4

Encrypting RAM disk driver for Linux

DanAlbert/dotfiles 1

A template for structuring dotfiles (using Dotbot as an installer)

DanAlbert/dynamic-cast-repro 1

Repro case for https://github.com/android-ndk/ndk/issues/533

DanAlbert/.emacs.d 0

My emacs directory

DanAlbert/apollo 0

Apollo 2D Rendering Engine

DanAlbert/arma3-headless-client-docker 0

Docker image for Arma 3 headless clients.

DanAlbert/arma3-sync-docker 0

Docker container for running ArmA3Sync.

push eventDanAlbert/dcs_liberation

Dan Albert

commit sha ff083942e8ef94b65abcbbb6752bbe2c0b5588dd

Replace mission planning UI. Mission planning has been completely redone. Missions are now planned by right clicking the target area and choosing "New package". A package can include multiple flights for the same objective. Right now the automatic flight planner is only fragging single-flight packages in the same manner that it used to, but that can be improved now. The air tasking order (ATO) is now the left bar of the main UI. This shows every fragged package, and the flights in the selected package. The info bar that was previously on the left is now a smaller bar at the bottom of the screen. The old "Mission Planning" button is now just the "Take Off" button. The flight plan display no longer shows enemy flight plans. That could be re-added if needed, probably with a difficulty/cheat option. Aircraft inventories have been disassociated from the Planner class. Aircraft inventories are now stored globally in the Game object. Save games made prior to this update will not be compatible do to the changes in how aircraft inventories and planned flights are stored.

view details

Dan Albert

commit sha 8a4a81a008292b63f24c4a3ee35ac4501e2ad661

Remove unused frontline code.

view details

Dan Albert

commit sha 0e1dfb8ccbe81819ce8411c6cf11400240598f42

Implement CAP and CAS for front lines.

view details

Dan Albert

commit sha a3c06ce6e0d81435e4acd41a2a704a8b9867702e

Limit task type combo box to valid mission types.

view details

push time in 9 minutes

issue commentKhopa/dcs_liberation

Invalid frequency - mission cannot be saved

https://github.com/Khopa/dcs_liberation/pull/151

Prof-hilactic

comment created time in 11 hours

PR opened Khopa/dcs_liberation

Fix None dereference.
+4 -1

0 comment

1 changed file

pr created time in 21 hours

create barnchDanAlbert/dcs_liberation

branch : fix-none

created branch time in 21 hours

PullRequestReviewEvent

pull request commentKhopa/dcs_liberation

UHF Intraflight Frequency for Player and Clients A-10C

I meant a code comment :)

davidp57

comment created time in 2 days

pull request commentKhopa/dcs_liberation

UHF Intraflight Frequency for Player and Clients A-10C

Gotcha. Yeah, we should merge this then :) That's up to @Khopa though, I don't have such powers.

Could you add a comment with a link to the forum post?

davidp57

comment created time in 2 days

pull request commentKhopa/dcs_liberation

UHF Intraflight Frequency for Player and Clients A-10C

What's the symptom of the error? Admittedly I haven't used the A-10 much after these changes. My understanding is that that value only decides what channel the AI broadcasts on, so it shouldn't matter if it shows an error so long as the mission editor isn't "correcting" it on you.

If it's a problem this LGTM though. The A-10 has much less need to talk to AWACS, so the overlapping radio assignment isn't a big deal.

davidp57

comment created time in 2 days

pull request commentKhopa/dcs_liberation

Replace mission planning UI.

And another to filter the mission type combo box by types relevant to the target.

That should be it for this PR :)

DanAlbert

comment created time in 3 days

push eventDanAlbert/dcs_liberation

Dan Albert

commit sha 4f26afa75acbd0ade89e0c73fd6e033d9167d457

Limit task type combo box to valid mission types.

view details

push time in 3 days

pull request commentKhopa/dcs_liberation

Replace mission planning UI.

Added another couple commits fixing the regression in mission planning for front lines. I think that was the only regression, so this should now be a strict improvement over the current UI.

DanAlbert

comment created time in 3 days

push eventDanAlbert/dcs_liberation

Dan Albert

commit sha ad34b2ee06d218c19bd27938d97f01e99b25ed42

Remove unused frontline code.

view details

Dan Albert

commit sha ba930d411c4ec30db9a6bca515223ae63bb38b6d

Implement CAP and CAS for front lines.

view details

push time in 3 days

issue commentKhopa/dcs_liberation

Seperate Flight and AWACs comm channels

No problem, glad to hear it's working :)

Have to track down why

What frequency did your flight get allocated? I pulled the valid range from the Chuck's guide, so it should be somewhere between 108.000 MHz and 173.975 MHz, although I see the BMS manual says it should only go to ~152 MHz (the DCS manual says nothing on the subject).

spectre7512

comment created time in 3 days

issue commentKhopa/dcs_liberation

Seperate Flight and AWACs comm channels

Comm info all moved to the kneeboard because channel assignments vary per-flight. The AWACS/tanker/JTAC frequencies could be put back in the briefing if that helps, but the kneeboard seems strictly more useful?

spectre7512

comment created time in 3 days

issue commentKhopa/dcs_liberation

Seperate Flight and AWACs comm channels

Your flight and AWACS shouldn't be on the same radio as of the current release. AWACS should be on UHF and your flight should be on VHF.

spectre7512

comment created time in 3 days

issue commentandroid/ndk

[BUG] windows python prebuilt no longer has datetime module, breaking shaderc

I'm still (again?) seeing this.

DanAlbert

comment created time in 3 days

IssuesEvent

issue commentKhopa/dcs_liberation

Seperate Flight and AWACs comm channels

What aircraft is this a problem for?

spectre7512

comment created time in 3 days

PR opened Khopa/dcs_liberation

Replace mission planning UI.

Mission planning has been completely redone. Missions are now planned by right clicking the target area and choosing "New package".

A package can include multiple flights for the same objective. Right now the automatic flight planner is only fragging single-flight packages in the same manner that it used to, but that can be improved now.

The air tasking order (ATO) is now the left bar of the main UI. This shows every fragged package, and the flights in the selected package. The info bar that was previously on the left is now a smaller bar at the bottom of the screen. The old "Mission Planning" button is now just the "Take Off" button.

The flight plan display no longer shows enemy flight plans. That could be re-added if needed, probably with a difficulty/cheat option.

Aircraft inventories have been disassociated from the Planner class. Aircraft inventories are now stored globally in the Game object.

Save games made prior to this update will not be compatible do to the changes in how aircraft inventories and planned flights are stored.

+1966 -823

0 comment

38 changed files

pr created time in 3 days

create barnchDanAlbert/dcs_liberation

branch : ato

created branch time in 3 days

issue commentandroid/ndk

C++ exceptions are aborting the process, even if caught

Your repro case isn't using a valid STL. After fixing the repro script and converting it to bash:

./make_jni.sh
+ ANDROID_HOME=/usr/local/google/home/danalbert/Android/Sdk
+ ANDROID_NDK=/work/src/android-ndk-r21d
+ cd swig
+ swig -c++ -java -package com.test -outdir ./ -I../include SampleInterface_Classes.i
+ cd ..
+ javac -g -d ./class ./swig/Coder.java ./swig/test.java ./swig/testJNI.java -classpath /usr/local/google/home/danalbert/Android/Sdk/platforms/android-19/android.jar
+ jar -cf ./lib/test.jar -C ./class com/test
+ /work/src/android-ndk-r21d/ndk-build
/work/src/android-ndk-r21d/build/core/add-application.mk:178: *** Android NDK: APP_STL gnustl_static is no longer supported. Please switch to either c++_static or c++_shared. See https://developer.android.com/ndk/guides/cpp-support.html for more information.    .  Stop.

If I fix that, Studio gives:

/work/src/SwigEx_wrap_crash/MyApp/app/src/main/java/com/example/myapplication/MainActivity.java:14: error: cannot access Coder
import com.test.Coder;
               ^
  bad class file: /usr/local/google/home/danalbert/.gradle/caches/transforms-2/files-2.1/f918ea8ed6187165dd3bcd6ccb1f8249/jetified-test.jar(com/test/Coder.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

If you can provide a working sample I'll look more. I strongly recommend migrating your build to https://developer.android.com/studio/projects/gradle-external-native-builds. Using that will cut down on a lot of the "works on my machine" issues.

borrrden

comment created time in 6 days

issue commentgoogle/prefab

[BUG] Issue when importing more than one library generated with prefabPublishing

That will work around the bug, yes. I still think it's an AGP bug that you can't do this though.

Consti10

comment created time in 6 days

PR opened Khopa/dcs_liberation

Update pydcs.

This fixes the issue where delayed AI flights would not start if the mission was not first saved via the DCS mission editor.

+1 -1

0 comment

1 changed file

pr created time in 7 days

create barnchDanAlbert/dcs_liberation

branch : update-pydcs

created branch time in 7 days

issue closedandroid/ndk

[BUG]See sensitive information save in native-lib resource

Note: Bugs against Android Studio or Gradle should be filed at http://b.android.com, not here.

I am using Cmake 3.4.1 save sensitive information but when attacker can decompile key in project

  • NDK Version: 3.4.1

closed time in 9 days

duonghv97

issue commentandroid/ndk

[BUG]See sensitive information save in native-lib resource

The NDK offers no mechanisms for concealing app secrets that Java does not. Java is probably better, in fact, since I don't think any of the keystore APIs are availy to the NDK.

duonghv97

comment created time in 9 days

issue openedKhopa/dcs_liberation

set up airfield inventories

In a multiplayer game players can respawn in aircraft that the player's faction doesn't actually have.

created time in 9 days

issue openedKhopa/dcs_liberation

limit aircraft stationed to an airfield by the number of parking space

Can avoid issues with planned ground starts becoming in-air starts by ensuring that we can't assign more aircraft to an airfield than it has room for. Also puts an upper bound on the number of aircraft that can be deployed, one that is sufficiently high enough that it won't be annoying for the player but will cap the AI going nuts.

Carriers might need to be a bit different, since not all of their parking space is modeled, but maybe they already have sufficient parking spaces such that we don't need to worry about it?

created time in 9 days

PR opened pydcs/dcs

Reduce differences between DCS and pydcs mission files.

DCS Liberation currently has an issue where generated missions need to be opened in the mission editor and saved before delayed flights behave properly. I'm not completely sure that either of these changes fixes that issue (I can't reproduce it myself), but these seem to be the only two behavioral differences in the mission file before and after saving with the mission editor. They do seem to be incorrect, although it's possible these are working due to some default behavior for each function.

+92 -81

0 comment

1 changed file

pr created time in 10 days

push eventDanAlbert/dcs

Rene Peinthor

commit sha e694fef48a6eca97f7814bcd8d05aed6a2d687d8

prepare release 0.10.0

view details

Dan Albert

commit sha 1489dca6e79392a6b13fe5500262014b52c5bfb8

Fix triggers for actions with a "text" attribute. For actions like `DoScript`, the action itself invokes the script by retrieving the script contents via `getValueDictByKey`, but we were never setting the dict key. It's not clear if this is a symptomatic issue or if the triggers use the text as a fallback if the key is not set, but this does at least cut down on differences between what pydcs produces and what the mission editor produces, which makes debugging easier. The changes to `DoScript` and `MarkTo*` were determined by diffing a mission file before and after re-saving the mission from the editor. The changes to other action types are an assumption.

view details

Dan Albert

commit sha ab590bfe636d019132db91585f9921470fa3f831

Add missing AI task arguments.

view details

push time in 10 days

issue openedKhopa/dcs_liberation

set up bullseye waypoint for appropriate aircraft

Some aircraft (like the hornet) can give bullseye coordinates if they have a waypoint matching the bullseye. Right now I don't think we don't create such a waypoint. Would be nice to have.

created time in 10 days

issue commentandroid/ndk

[BUG]See sensitive information save in native-lib resource

I'm not sure what your question is, but this doesn't appear to be NDK related?

duonghv97

comment created time in 10 days

release google/prefab

v1.1.1

released time in 10 days

issue commentgoogle/prefab

[FR]prefabPublishing multiple header directories for one library

Yeah, that's expected. Everything gets filed at the top level and goes through a common triage process.

I've moved it into the correct component and assigned it to myself since I'll probably be the one that fixes it.

Consti10

comment created time in 10 days

pull request commentandroid/ndk-samples

Improve ndk-samples / prefab

I agree that's what most users will use, but the way the package is generated doesn't affect how it is used, so I'm confused as to what this shows the user that wasn't already shown.

Consti10

comment created time in 10 days

pull request commentandroid/ndk-samples

Improve ndk-samples / prefab

What would that demonstrate that the two existing samples don't?

Consti10

comment created time in 10 days

issue commentandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

Our tests don't generate that file because they don't use the make generator, but it does not make a similar error for ninja. Our toolchain file does configure AR. If CMake isn't honoring that option when using the mingw makefile generator that's a CMake bug and there's nothing that we can do about it.

wkunice

comment created time in 10 days

delete branch DanAlbert/prefab

delete branch : bump-version

delete time in 11 days

push eventgoogle/prefab

Dan Albert

commit sha 66fd15164a68bd7b4bba9f9547d49e1fd512a188

Bump next version to 1.2.0. Forgot to upload the similar change for 1.1.0. All the snapshot builds after 1.1.0 (which was actually only one build) were 1.0.0-SNAPSHOT instead of 1.1.0-SNAPSHOT.

view details

push time in 11 days

PR merged google/prefab

Bump next version to 1.2.0.

Forgot to upload the similar change for 1.1.0. All the snapshot builds after 1.1.0 (which was actually only one build) were 1.0.0-SNAPSHOT instead of 1.1.0-SNAPSHOT.

+1 -1

1 comment

1 changed file

DanAlbert

pr closed time in 11 days

issue commentandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

As I said, we have tests that already do that. It's a CMake script that builds a static library and then links it into a shared library. There's something deeper going on, so we need your help to investigate further.

The most likely explanation is that there is no bug and that something in your project is passing those flags explicitly. grepping for fno-exceptions might answer your question.

wkunice

comment created time in 11 days

push eventDanAlbert/dcs

Dan Albert

commit sha 28d28a8ae6e18db471b7e7085325e4bf84fad088

Add missing `a_ai_task` arguments.

view details

push time in 11 days

create barnchDanAlbert/dcs

branch : fix-text-actions

created branch time in 11 days

pull request commentgoogle/prefab

Bump next version to 1.2.0.

explain where 1.1.0 went?

Done. Make sense?

DanAlbert

comment created time in 11 days

push eventDanAlbert/prefab

Dan Albert

commit sha a447b85bfb1b285dd6d9a9a518d139183f813573

Bump next version to 1.2.0. Forgot to upload the similar change for 1.1.0. All the snapshot builds after 1.1.0 (which was actually only one build) were 1.0.0-SNAPSHOT instead of 1.1.0-SNAPSHOT.

view details

push time in 11 days

issue commentandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

I'm not sure I understand the question? We're happy to help if we can, but we don't have the info needed to do so.

wkunice

comment created time in 11 days

PR opened google/prefab

Reviewers
Bump next version to 1.2.0.
+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchDanAlbert/prefab

branch : bump-version

created branch time in 11 days

created taggoogle/prefab

tagv1.1.1

Prefab is a tool for generating build system integrations for prebuilt C/C++ libraries.

created time in 11 days

issue commentandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

I guess maybe something to try would be not using make? We never test that, we use ninja. Any difference between those two is probably a CMake bug though.

wkunice

comment created time in 11 days

issue commentandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

No idea. We don't generate that. CMake does.

wkunice

comment created time in 11 days

issue closedandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

I am cross compiling C, C++ code using the NDK. I am using 'cmake' files that first build small static libraries and then links them together to build a single large shared library. I am using the android.toolchain.cmake file for the CMAKE_TOOLCHAIN_FILE.

When it tries to build the shared library I get errors: bin/ld: error: no archive symbol table (run ranlib)

I dig down to the build directory and the 'link.txt' file has "gcc-ar ....." that generates the library from the .o's.

it should be generating the link.txt file with the cross compiler <....-ar> and <....-ranlib> programs to generate the library.

When I change the 'link.txt file to have: arm-...-ar library arm...-ranlib library.a

the shared library link works.

  • NDK Version: 21.3
  • Build system: cmake
  • Host OS: Linux
  • ABI:
  • NDK API level:
  • Device API level:

closed time in 11 days

wkunice

issue commentandroid/ndk

[BUG] 'link.txt' has wrong linker for cross-compile

We have tests that show linking .a files into shared libraries works fine. There's nothing we can investigate with the information given. Closing, but will reopen if you can provide information that makes it possible for us to help.

I'm not sure what advice to offer, since you already seem to know what the problem is (using the wrong ar). Without more information I don't have any guesses as to why that's happening :(

wkunice

comment created time in 11 days

issue closedandroid/ndk

[question]Can not enable rtti exception for MinGW

Hello, I hava been trying to cross-compile my lib using CMake 3.18 + MinGW64 + NDK r21b for Android. I hava tried ANDROID_CPP_FEATURES=rtti exception and ANDROID_STL_FORCE_FEATURES to enable rtti and exceptions, but still show error error: cannot use 'try' with exceptions disabled

In flags.make file generated by CMake i found-frtti -fexceptionsflags were overwrited CXX_FLAGS = -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -march=armv7-a -mthumb -Wformat -Werror=format-security -frtti -fexceptions -fPIC -fno-rtti -fno-exceptions -std=c++14 I removed -fno-rtti -fexceptions and compile successed. How can i enable the rtti and exceptions using option or variable of cmake.

Environment:

  • NDK Version: NDK r21b
  • Build system: CMake with android.toolchain
  • Host: Win 10

closed time in 11 days

ShyJ

issue commentandroid/ndk

[question]Can not enable rtti exception for MinGW

It looks like one of your CMake files is adding those flags. I just checked and we certainly don't unless you specifically request them. All the RTTI/exceptions flags would be added together if it was us: https://cs.android.com/android/platform/superproject/+/master-ndk:ndk/build/cmake/android.toolchain.cmake;l=534;drc=46aa31c5003c17f4e170bf091d4cfa09128583ec

The fact -fPIC comes between the -fexceptions and -fno-exceptions to me indicates that this is something in your code and not ours. Also, we have tests that show this isn't a problem for the trivial case. We need a repro case to dig any further, but like I said I'm pretty sure these flags are just being added by some code in the project you're building. If you can make a repro case we're happy to reopen.

ShyJ

comment created time in 11 days

issue commentandroid/ndk

[question]Can not enable rtti exception for MinGW

I don't understand what you're trying to do. The NDK uses Clang. Mingw targets windows. RTTI and exceptions are enabled by default in our toolchain.

https://developer.android.com/studio/projects/install-ndk explains how to use CMake with the NDK.

ShyJ

comment created time in 12 days

delete branch DanAlbert/prefab

delete branch : skip-bogus-files

delete time in 13 days

push eventgoogle/prefab

Dan Albert

commit sha 6b0eefb70cee0fd066b3caadf94f4b69e67c4ff7

Fix handling of packages with unexpected files. Some file browsers helpfully create extra hidden files in any directory they view. It may have been better to just ignore anything without a module.json, but https://github.com/google/prefab/pull/106 made module.json optional, so technically any directory is a valid module now and we need a new schema revision to change that behavior. We could alternatively add an explicit module list to prefab.json, but that would also require a new schema revision. For now, just ignore all files (fixes the .DS_Store case) and any hidden directories (just in case).

view details

push time in 13 days

PR merged google/prefab

Fix handling of packages with unexpected files.

Some file browsers helpfully create extra hidden files in any directory they view. It may have been better to just ignore anything without a module.json, but https://github.com/google/prefab/pull/106 made module.json optional, so technically any directory is a valid module now and we need a new schema revision to change that behavior. We could alternatively add an explicit module list to prefab.json, but that would also require a new schema revision.

For now, just ignore all files (fixes the .DS_Store case) and any hidden directories (just in case).

+62 -1

0 comment

12 changed files

DanAlbert

pr closed time in 13 days

PullRequestReviewEvent

issue closedgoogle/prefab

[BUG] Issue when importing more than one library generated with prefabPublishing

Describe the bug I have issues importing more than one library generated with prefabPublishing enabled. When I only add library a or b to the project it builds fine. When I both add library a and b to the project it throws the error message 2 files found with path 'lib/armeabi-v7a/libc++_shared.so'. If you are using jniLibs and CMake IMPORTED targets, see https://developer.android.com/r/tools/jniLibs-vs-imported-targets

To Reproduce I have created 3 commits to a basic example project that show the issue. Commit 1 adds library a and works fine. Commit 2 adds library b and works fine. Commit 3 adds both library a and b and throws the error from above:

Here is the github repository

And here are the 3 commits: https://github.com/Consti10/ndk-samples/commit/f776f647756221218a80f3bbaf82d27509670c5f https://github.com/Consti10/ndk-samples/commit/4f5d73767a2c4218bb8f3595000fc0caa9c22391 https://github.com/Consti10/ndk-samples/commit/8fb426ebfab6cecf6d05162036329d63c290df17

closed time in 13 days

Consti10

issue commentgoogle/prefab

[BUG] Issue when importing more than one library generated with prefabPublishing

This isn't related to prefab. You'll need to file an AGP bug. For future reference, everything related to gradle probably belongs there, not here. This is just for the prefab command line tool, whose only job is creating the cmake/ndk-build scripts from a prefab directory such as is in an AAR; and the prefab package format. None of the integration with AGP lives here.

When you file that bug, the problem is that adding the dependency is causing the libraries in the jni directory of the AAR to be included even though they are not used. The error is correct that there is a duplicate in what is trying to be installed to the APK, but afaik there is no way to depend on an AAR without depending on all of an AAR.

Consti10

comment created time in 13 days

issue commentgoogle/prefab

[DOC] Add example that uses the native library provided by ndk-samples/prefab/prefab-publishing

Sorry about the missing portion of the docs! I've just sent the fix for that.

Consti10

comment created time in 13 days

GollumEvent

issue commentandroid/ndk

[question] Is find_library still needed for ndk libraries

It's idiomatic for CMake (I guess; that's what the samples did and that's where I learned it from), but it's not required. CMake will -l link things that aren't find_library-esque, and the Android sysroot is available to the linker.

Consti10

comment created time in 13 days

issue commentandroid/ndk

[BUG]use of undeclared identifier 'catopen'

Assuming you figured this out, but those APIs aren't available until several releases after KitKat.

vintonliu

comment created time in 13 days

issue commentandroid/ndk

[question] Header include paths and undefined `size_t`

File a new bug with repro instructions if you're having issues. The command line given above is incorrect, and that's why the problem exists. Follow the docs and file bugs if you have issues.

kakyoism

comment created time in 13 days

issue commentandroid/ndk

[BUG] gdbserver x86_64

Pretty sure I have a bug open reminding me to update the sysroot again before r22, so yes.

alex-curiou

comment created time in 13 days

issue closedandroid/ndk

[question] Is find_library still needed for ndk libraries

I am wondering if the following code inside CMake files is still needed with the android ndk Example for the android ndk 'log library'

find_library( log-lib
              log )

Since all my projects seem to build fine when directly linking with the android 'log' library for example. Example code that shows the old way of linking to android libraries:

find_library( log-lib
             log )
target_link_libraries(TelemetryReceiver
        ${log-lib} )

Example code without find_library:

target_link_libraries(TelemetryReceiver
        log )

closed time in 13 days

Consti10

issue commentandroid/ndk

[question] Is find_library still needed for ndk libraries

It has never been needed.

Consti10

comment created time in 13 days

issue closedgoogle/prefab

[FR]prefabPublishing multiple header directories for one library

It would be great if you could specify multiple header directories for one prefab library. Example:

prefab {
        TelemetryReceiver {
            headers "src/main/cpp/TelemetryReceiver"
            headers "src/main/cpp/SharedCppC"
        }
}

closed time in 13 days

Consti10

issue commentgoogle/prefab

[FR]prefabPublishing multiple header directories for one library

That's an Android Gradle feature. Please file the big against the Android Gradle Plugin.

Consti10

comment created time in 13 days

delete branch DanAlbert/dcs_liberation

delete branch : more-aircraft-radios

delete time in 15 days

create barnchDanAlbert/dcs_liberation

branch : radio-naming

created branch time in 15 days

PR opened Khopa/dcs_liberation

Ensure that allocated channels are reserved.

This was previously mostly working because the allocator itself was moving forward, but since each radio has its own allocator, aircraft with different radios would often get overlapping intra-flight frequencies.

+1 -0

0 comment

1 changed file

pr created time in 15 days

push eventDanAlbert/dcs_liberation

Dan Albert

commit sha 7d444aadce066ceb001c7f3f9f527c631b86d17d

Name radios appropriately for each aircraft.

view details

push time in 15 days

create barnchDanAlbert/dcs_liberation

branch : fix-radio-reservation

created branch time in 15 days

PR opened Khopa/dcs_liberation

Add radio information for more aircraft.

Adds the following:

  • AJS37
  • AV-8B
  • JF-17

This does move the preset channel allocation logic into its own class, since we need to customize that behavior for the AJS37 since it has a rather unique preset channel layout (see the comments in ViggenRadioChannelAllocator for details).

+249 -156

0 comment

6 changed files

pr created time in 16 days

create barnchDanAlbert/dcs_liberation

branch : more-aircraft-radios

created branch time in 16 days

PR opened Khopa/dcs_liberation

Handle callsigns for flights.

We don't configure the callsigns that pydcs uses, so instead read those from pydcs and use them where appropriate instead of just guessing.

Fixes https://github.com/Khopa/dcs_liberation/issues/113.

+86 -58

0 comment

7 changed files

pr created time in 17 days

create barnchDanAlbert/dcs_liberation

branch : callsigns

created branch time in 17 days

delete branch DanAlbert/dcs

delete branch : callsign-retrieval

delete time in 17 days

issue commentKhopa/dcs_liberation

assign callsigns to flights

Sent https://github.com/pydcs/dcs/pull/72, and I have the liberation-side of this patch ready for when that's submitted. It won't let you set your own callsign, but it will report the callsigns that pydcs assigns. Setting custom callsigns might be worth it eventually, but that requires a much more complicated pydcs API.

DanAlbert

comment created time in 17 days

create barnchDanAlbert/dcs_liberation

branch : fix-kneeboard-tacan

created branch time in 17 days

PR opened pydcs/dcs

Add FlyingUnit APIs for callsign retrieval.
+30 -0

0 comment

1 changed file

pr created time in 17 days

create barnchDanAlbert/dcs

branch : callsign-retrieval

created branch time in 17 days

create barnchDanAlbert/dcs_liberation

branch : coalesce-target-points

created branch time in 18 days

PR opened Khopa/dcs_liberation

Add first waypoint to FlightData.

The first waypoint is automatically added by pydcs, so it's not actually in our waypoint list from the flight planner. Import is from the group so it shows up in the kneeboard.

+34 -3

0 comment

3 changed files

pr created time in 19 days

PR opened Khopa/dcs_liberation

Add map data for Syria.
+290 -10

0 comment

2 changed files

pr created time in 19 days

PR closed Khopa/dcs_liberation

Add map data for Syria.
+5302 -245

1 comment

41 changed files

DanAlbert

pr closed time in 19 days

pull request commentKhopa/dcs_liberation

Add map data for Syria.

Oops, wrong base branch.

DanAlbert

comment created time in 19 days

PR opened Khopa/dcs_liberation

Add map data for Syria.
+5302 -245

0 comment

41 changed files

pr created time in 19 days

delete branch DanAlbert/dcs_liberation

delete branch : fix-radios

delete time in 19 days

create barnchDanAlbert/dcs_liberation

branch : syria-map-data

created branch time in 19 days

create barnchDanAlbert/dcs_liberation

branch : first-waypoint

created branch time in 19 days

PR opened Khopa/dcs_liberation

Fix radio information.

Not every aircraft has a pydcs radio index, so we can't use that to index into a list. Any mission with an A-10C crashes, since it would try to use None - 1 to index into the list of radios to find the intra-flight radio.

Also fix the radio ranges for the newly added radios. The current implementation can't model gaps, so extending the radio ranges across those gaps means that we might allocate channels that aren't tunable by those radios. Additionally, the end frequency is exclusive rather than inclusive, so fix the ranges to include that last tunable frequency.

+24 -20

0 comment

2 changed files

pr created time in 21 days

create barnchDanAlbert/dcs_liberation

branch : fix-radios

created branch time in 21 days

more