profile
viewpoint

push eventDLu/roscompile_test_data

David V. Lu

commit sha f8b3111cebe279a1dce85039952c473b69eeb880

Insertion order tests

view details

push time in 17 hours

push eventDLu/roscompile

David V. Lu

commit sha 1508f9542dcd22f01e8febc8a872d0c68a5ca8cb

Safe load, catch file type exception and additional command

view details

push time in 18 hours

PR closed ros-planning/navigation

Add runtime reload map feature blocked map_server

subscribed topic: ~/reload (std_msgs/String) Provides a non-action interface to map_server for reloading the map information while map_server is running. Message data is a string with the file name. If message data is empty, map_server reloads the map from the last specified file.

+220 -154

1 comment

1 changed file

wiseware-ros

pr closed time in 2 days

PR opened ros-planning/navigation

Change_map service to map_server [Rebase/Noetic]

This is a redo of #461 for noetic, integrating changes that have been made in the last 4 years since the original PR. :roll_eyes:

The CI will fail until the changes from https://github.com/ros/common_msgs/pull/152 are released, see https://github.com/ros/common_msgs/issues/167

The return codes from the service are not ideal (in that it only returns success or failure, not the more nuanced failure codes described in the service) but I was trying to keep close to @sloretz's original PR structure.

+270 -118

0 comment

8 changed files

pr created time in 2 days

push eventros-planning/navigation

Shane Loretz

commit sha 12654f7959332c0d64df2166731341956e2484a5

Refactored map loading from constructor to three methods Added MapServer::loadMapFromYaml() MapServer::loadMapFromParams() MapServer::loadMapFromValues()

view details

Shane Loretz

commit sha 9f37778420c1a7e4e903a8c4b0498aeac901617a

Changed map loading methods to return true/false instead of causing the map_server_node to exit Changed methods MapServer::loadMapFromValues() MapServer::loadMapFromParams() MapServer::loadMapFromYaml()

view details

Shane Loretz

commit sha 53c3cc3cbc0e1b3c773e68aa1fefdf8f9aa3f162

Added change_map service using LoadMap.srv Added second test map and test constants Added rostest for change_map service

view details

push time in 2 days

create barnchros-planning/navigation

branch : redo461

created branch time in 2 days

issue openedros/common_msgs

New Releases

Requesting a new release of at least noetic that includes #164

created time in 2 days

push eventros-planning/navigation

Christian Clauss

commit sha 3c16b37504dc178c3075345ed88d681a6f83cc2e

Use print() function in both Python 2 and Python 3 in basic_localization.py (#1011)

view details

push time in 3 days

PR merged ros-planning/navigation

Use print() function in both Python 2 and Python 3

Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

Python 2 died on 1/1/2020.

+13 -11

5 comments

1 changed file

cclauss

pr closed time in 3 days

pull request commentros-planning/navigation

Throttle spammy line

Given that the information printed each time is theoretically different, it seems like it would make more sense to hide the printing behind a flag, rather than throttle it.

nickvaras

comment created time in 3 days

issue closedros-planning/navigation_tutorials

let robot auto explores its surrounding and mapping without manually giving a goal

Dear navigation_tutorials friends,

As far as we know, the navigation stack requires a given goal in order to start a navigation. We were wondering if the stack allows robot automatically explore its surrounding and mapping. (such as greedy frontier exploration).

Since we are new on ros-planning/navigation pkgs, hope to hear your expertise on the issue.

Thanks, -- Luke

closed time in 3 days

lukelu0520

issue commentros-planning/navigation_tutorials

let robot auto explores its surrounding and mapping without manually giving a goal

Hi Luke!

In general, answers.ros.org is probably a better starting place for this type of question. A quick search for ros robot exploration turned up this

lukelu0520

comment created time in 3 days

delete branch ros-planning/navigation

delete branch : fix1026_noetic

delete time in 3 days

push eventros-planning/navigation

David V. Lu!!

commit sha 503dd6065770ab5ad91ffe98ff59f8f042e67325

Fixes #1026 (#1028)

view details

push time in 3 days

push eventros-planning/navigation

David V. Lu!!

commit sha bfda75e7b5966a5c064a44ae3c442f8893857f39

Fixes #1026 (#1028)

view details

push time in 3 days

push eventros-planning/navigation

David V. Lu!!

commit sha c0e4a8175082b2b81f62c0332d5235aea7a04d54

Fixes #1026 (#1028)

view details

push time in 3 days

issue closedros-planning/navigation

[melodic][global_planner] Raw-pointers of class GlobalPlanner never initialized to null in default constructor

The raw pointers p_calc_, planner_, path_maker_, orientation_filter_ of class GlobalPlanner are never initialized to nullptr during default construction, causing the check in the destructor to fail (and consequently causing a seg fault) if the planner was never initialized.

closed time in 3 days

sfocke

PR merged ros-planning/navigation

Fixes #1026
+5 -3

0 comment

2 changed files

DLu

pr closed time in 3 days

Pull request review commentros-planning/navigation

Fixes #1026

 class GlobalPlanner : public nav_core::BaseGlobalPlanner {         int publish_scale_;          void outlineMap(unsigned char* costarr, int nx, int ny, unsigned char value);-        unsigned char* cost_array_;

This is unused in the package.

DLu

comment created time in 3 days

PullRequestReviewEvent

PR opened ros-planning/navigation

Fixes #1026
+5 -3

0 comment

2 changed files

pr created time in 3 days

create barnchros-planning/navigation

branch : fix1026_noetic

created branch time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentros/rosbag_snapshot

Feature/all topics

 struct ROSBAG_DECL SnapshotterOptions                     ros::Duration status_period = ros::Duration(1));    // Add a new topic to the configuration-  void addTopic(std::string const& topic,+  bool addTopic(std::string const& topic,

Can you add a note here what the bool represents?

Timple

comment created time in 3 days

Pull request review commentros/rosbag_snapshot

Feature/all topics

 void appendParamOptions(ros::NodeHandle& nh, SnapshotterOptions& opts)     opts.default_memory_limit_ = static_cast<int>(MB_TO_BYTES * tmp);   if (nh.getParam("default_duration_limit", tmp))     opts.default_duration_limit_ = ros::Duration(tmp);+  nh.param("all", opts.all_topics_, opts.all_topics_);

Would you be open to changing the parameter string to "record_all_topics"

Timple

comment created time in 3 days

Pull request review commentros/rosbag_snapshot

Feature/all topics

 void Snapshotter::publishStatus(ros::TimerEvent const& e)   status_pub_.publish(msg); } +void Snapshotter::pollTopics(ros::TimerEvent const& e, rosbag_snapshot::SnapshotterOptions *options)+{+  (void)e;+  ros::master::V_TopicInfo topics;+  if (ros::master::getTopics(topics))+  {+    for (ros::master::TopicInfo const& t : topics)+    {+      std::string topic = t.name;+      if (options->addTopic(topic))+      {+        SnapshotterTopicOptions topic_options;+        fixTopicOptions(topic_options);+        shared_ptr<MessageQueue> queue;+        queue.reset(new MessageQueue(topic_options));+        std::pair<buffers_t::iterator, bool> res = buffers_.insert(buffers_t::value_type(topic, queue));+        ROS_ASSERT_MSG(res.second, "failed to add %s to topics. Perhaps it is a duplicate?", topic.c_str());+        subscribe(topic, queue);+      }+    }+  }

Maybe a throttled warning message if this fails?

Timple

comment created time in 3 days

pull request commentros/rosbag_snapshot

Feature/all topics

Can you please rebase these changes?

Timple

comment created time in 3 days

push eventros/rosbag_snapshot

Tim Clephas

commit sha 3a5702ba8971b5fac6fd5c115f376686b7fdebb4

Empty topic counts as empty list (#7) tab-complete on the commandline always inserts a list with an empty string

view details

push time in 3 days

PR merged ros/rosbag_snapshot

Empty topic counts as empty list

tab-complete on the commandline always inserts a list with an empty string.

I had to inspect the code to see why my simple launch file was not working when calling the trigger service from the commandline. Since empty topics cannot be recorded anyway I see no downsides to this.

I don't have a strong opinion about it though, if one thinks it clutters the code too much feel free to leave it out.

+1 -1

1 comment

1 changed file

Timple

pr closed time in 3 days

delete branch ros/rosbag_snapshot

delete branch : fix_noetic_test

delete time in 3 days

push eventros/rosbag_snapshot

David V. Lu!!

commit sha 2d4df663c907d168ee2b424781a60e0cd708799c

Fix Noetic Python3 Test (#9) * Fix Noetic Python3 Test * More noetic fixes * One more fix * Bump Cmake Version

view details

push time in 3 days

PR merged ros/rosbag_snapshot

Fix Noetic Python3 Test
+7 -5

0 comment

4 changed files

DLu

pr closed time in 3 days

push eventros/rosbag_snapshot

David V. Lu

commit sha 0fecd408f3239d6401035b9d64ac331a07d1b909

Bump Cmake Version

view details

push time in 3 days

push eventros/rosbag_snapshot

David V. Lu

commit sha bb767efd5494ca52ed868a768de894401679ab88

One more fix

view details

push time in 3 days

push eventros/rosbag_snapshot

David V. Lu

commit sha de4a67293997e9ad269e8e6088d6d01176470957

More noetic fixes

view details

push time in 3 days

pull request commentros/rosbag_snapshot

Empty topic counts as empty list

Hey @Timple! Thanks for the contribution, and my apologies for the delay in responding.

Note: The problem is tab complete for rosservice call.

Timple

comment created time in 3 days

issue closedwg-perception/people

Noetic release

We don't use this package ourselves, but it's a dependency of jsk_rviz_plugins

So could this be released for Noetic? :)

closed time in 3 days

Timple

issue commentwg-perception/people

Noetic release

https://github.com/ros/rosdistro/pull/26639

Note, the current noetic release only contains people_msgs and people_velocity_tracker. Additional work is needed to get the other packages to work.

Timple

comment created time in 3 days

create barnchDLu/rosdistro

branch : bloom-people-3

created branch time in 3 days

PR opened ros/rosdistro

Reviewers
people: 1.2.2-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository people to 1.2.2-1:

  • upstream repository: https://github.com/wg-perception/people.git
  • release repository: https://github.com/OSUrobotics/people-release.git
  • distro file: noetic/distribution.yaml
  • bloom version: 0.9.8
  • previous version for package: null
+20 -0

0 comment

1 changed file

pr created time in 3 days

PR opened ros/rosbag_snapshot

Fix Noetic Python3 Test
+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchros/rosbag_snapshot

branch : fix_noetic_test

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/debian/noetic/focal/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/debian/noetic/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/debian/noetic/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/rpm/noetic/32/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : rpm/noetic/32/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/release/noetic/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : debian/noetic/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : debian/noetic/focal/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : rpm/noetic/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/rpm/noetic/people_msgs

created branch time in 3 days

push eventOSUrobotics/people-release

David V. Lu

commit sha 73554081e59e3203c17666629cd708575b2087ac

Imported upstream version '1.2.2' of 'upstream'

view details

push time in 3 days

create barnchOSUrobotics/people-release

branch : debian/noetic/focal/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : debian/noetic/buster/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : rpm/noetic/people_velocity_tracker

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/rpm/noetic/32/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : rpm/noetic/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : debian/noetic/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : release/noetic/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/release/noetic/people_msgs

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : release/noetic/people

created branch time in 3 days

push eventOSUrobotics/people-release

David V. Lu

commit sha 188f1a032cf8274093ea4a997c593b199cdd9db9

Modified tracks.yaml

view details

David V. Lu

commit sha 3e66fcaa26c596aa16222189eb6f916b84d2cba9

Modified tracks.yaml

view details

David V. Lu

commit sha 6c0f07138e95da278ac37a008466f64850a314e8

Updating release inc to: 1

view details

David V. Lu

commit sha ea298797a86bdb79799b34c770b6ae0951f43a84

Updating README.md

view details

push time in 3 days

create barnchOSUrobotics/people-release

branch : debian/noetic/buster/people

created branch time in 3 days

create barnchOSUrobotics/people-release

branch : patches/rpm/noetic/people

created branch time in 3 days

created tagwg-perception/people

tag1.2.2

created time in 3 days

push eventwg-perception/people

David V. Lu

commit sha 32bfd37fbf54dec941b5c1d5e7b8ec341abb8b2c

Remove Leg Detector Dep

view details

David V. Lu

commit sha d1b53ab8b5b2134cbec7780df7757309dc717ca1

1.2.2

view details

push time in 3 days

push eventros-planning/navigation

mechatheo

commit sha 2952e94b8cac0416d718331a0bf563665c57e304

correctly delete previously allocated array (#1025) Co-authored-by: Fedor Vlasov <fedor.vlasov@de.kaercher.com>

view details

push time in 6 days

push eventros-planning/navigation

mechatheo

commit sha e52745c240095b31d02c601a41857d479117777f

correctly delete previously allocated array (#1025) Co-authored-by: Fedor Vlasov <fedor.vlasov@de.kaercher.com>

view details

push time in 6 days

issue commentwg-perception/people

Noetic release

Ready to go, pending https://github.com/ros/rosdistro/pull/26602

Timple

comment created time in 6 days

created tagwg-perception/people

tag1.2.1

created time in 6 days

push eventwg-perception/people

David V. Lu

commit sha 498a61833fa850d0b65dc84e92f826d76d863b1e

1.2.1

view details

push time in 6 days

delete branch wg-perception/people

delete branch : noetic_fixes

delete time in 6 days

delete branch DLu/people

delete branch : noetic

delete time in 6 days

delete branch DLu/people

delete branch : noetic_plus_up

delete time in 6 days

push eventwg-perception/people

David V. Lu!!

commit sha b03402a56d1a77d13a4d5a34ed687be362c6add0

Noetic plus up (#85) * Initial noetic * Move most packages to NOBUILD * Cleanup PeopleVelocityTracker

view details

push time in 6 days

PR merged wg-perception/people

Noetic plus up

Aids with #83

  • Noetic migration
  • Move most packages to NOBUILD for the sake of downstream dependencies of people_msgs
  • Clean up people_velocity_tracker
+38 -30

0 comment

14 changed files

DLu

pr closed time in 6 days

PR opened wg-perception/people

Noetic plus up

Aids with #83

  • Noetic migration
  • Move most packages to NOBUILD for the sake of downstream dependencies of people_msgs
  • Clean up people_velocity_tracker
+38 -30

0 comment

14 changed files

pr created time in 6 days

push eventwg-perception/people

push time in 6 days

push eventwg-perception/people

David V. Lu!!

commit sha f06a31354a41162d30b525538a5ae36e6ce49c63

Noetic plus up (#84) * Initial noetic * Move most packages to NOBUILD * Cleanup PeopleVelocityTracker

view details

push time in 6 days

PR merged wg-perception/people

Noetic plus up
  • Noetic migration
  • Move most packages to NOBUILD for the sake of downstream dependencies of people_msgs
  • Clean up people_velocity_tracker
+38 -30

1 comment

14 changed files

DLu

pr closed time in 6 days

pull request commentwg-perception/people

Noetic plus up

CC: #83

DLu

comment created time in 6 days

PR opened wg-perception/people

Noetic plus up
  • Noetic migration
  • Move most packages to NOBUILD for the sake of downstream dependencies of people_msgs
  • Clean up people_velocity_tracker
+38 -30

0 comment

14 changed files

pr created time in 6 days

create barnchDLu/people

branch : noetic_plus_up

created branch time in 6 days

create barnchwg-perception/people

branch : noetic_fixes

created branch time in 6 days

more