profile
viewpoint

numist/Diffing-Explorations 9

A playground for diffing experiments along with the algorithms and data structures needed to support them

Catfish-Man/swift 0

The Swift Programming Language

startedWebKit/webkit

started time in a month

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

Love it when squashing working commits makes them stop working. Presumably just needs a rerun

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please test

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please test

Catfish-Man

comment created time in 2 months

push eventCatfish-Man/swift

David Smith

commit sha 217c7a042eee84230e982bed2d6a08a60e26a4eb

Try using AnyObject dispatch instead of bitcasting to shadow protocols

view details

push time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please test

Catfish-Man

comment created time in 2 months

push eventCatfish-Man/swift

David Smith

commit sha d6d3796f69e9f99c4aba2e94fba27c096e96ce4d

Tweaks

view details

push time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please smoke benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please test

Catfish-Man

comment created time in 2 months

push eventCatfish-Man/swift

David Smith

commit sha c429a4249a21b610cc7cee4a11b57050ecd40b6b

Build fix harder

view details

push time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please test

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

push eventCatfish-Man/swift

David Smith

commit sha 221682442cbc5bd5689dc1b933ed03da4fbb74af

Build fix

view details

push time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please test

Catfish-Man

comment created time in 2 months

pull request commentapple/swift

Try using AnyObject dispatch instead of bitcasting to shadow protocols

@swift-ci please benchmark

Catfish-Man

comment created time in 2 months

create barnchCatfish-Man/swift

branch : shadows-into-light

created branch time in 2 months

push eventCatfish-Man/swift

Andrew Trick

commit sha 6ecbeefd5024efb7834ed1608f25dcece4ed63b6

Add AccessedStorage::Tail access kind and remove more checks. Distinguish ref_tail_addr storage from the other storage classes. We didn't have this originally because be don't expect a begin_access to directly operate on tail storage. It could occur after inlining, at least with static access markers. More importantly it helps ditinguish regular formal accesses from other unidentified access, so we probably should have always had this. At any rate, it's particularly important when AccessedStorage is generalized to arbitrary memory access. The immediate motivation is to add an AccessPath utility, which will need to distinguish tail storage. In the process, rewrite AccessedStorage::isDistinct. This could have a large positive impact on exclusivity performance.

view details

Rintaro Ishizaki

commit sha 15796734cdee1d9d0e49103b80b5552baaf6d177

[Sema] Descriptor for argument of PreCheckFunctionBuilderRequest

view details

Michael Gottesman

commit sha 54779a1a385b97ae140c06f5ad0d74b09ca02dfa

[opt-remark] If we have a SIL remark streamer, always emit remarks.

view details

Hamish Knight

commit sha 32443e22f8ffa5b882edf216ba91840b78e334cf

Merge pull request #33011 from hamishknight/type-safety [AST] Assert dereferencing null Type or GenericSignature

view details

Ben Langmuir

commit sha 01b5cf7c6f3378eb3a1394dd34eaddda247beca3

[sourcekitd] Fix annotation range-shifting after edit When performing an insertion (replacement length = 0) inside an existing annotation, we were forming a closed range instead of a half-open range, causing us to shift the effected token instead of throwing it out. There were also no tests for this functionality, so add a bunch of annotations tests. One area thing that is not tested is what if there have been multiple edits since the tokens were created. This is difficult to engineer, because right now making an edit immediately removes the semantic tokens and returns them. It could happen if the AST build takes longer than the edits, but there is no way to guarantee that in the current API. rdar://65748892

view details

Hamish Knight

commit sha 3437ec92d71a2a6abb17afce98226d69e7362f8a

Merge pull request #33005 from hamishknight/connect-four-builder

view details

tbkka

commit sha a6aa7a5f3f3ab674721c70f739648c5602c418d0

Minor python3 lint fixes (#33009)

view details

Slava Pestov

commit sha 506aa1dfa77b5b0af0842c1d90197ca9450da9a3

Merge pull request #32930 from slavapestov/simplify-legacy-type-info IRGen: Simplify logic for locating the legacy type info YAML file

view details

swift-ci

commit sha c120ff8b79d2574af0b795eefde5622ca7c27b87

Merge pull request #33018 from gottesmm/pr-93832232fe166e23af62cbbf0c4414c6aed910bd

view details

Rintaro Ishizaki

commit sha 994edab26cba66dcf7b7ee96f967403f4001ee27

Merge pull request #33013 from rintaro/sema-precheckfunctionbuilder-descriptor [Sema] Descriptor for argument of PreCheckFunctionBuilderRequest

view details

Michael Gottesman

commit sha 9a828bc78fbada6b6f7b91e1ba89808e8dc47683

[opt-remark] Teach opt-remarks how to emit notes. I did this by adding a kind to Arguments and making it so we have a kind that emits as a separate NOTE when we emit diagnostics, but is emitted as a normal argument when emitting to the bitstream.

view details

Michael Gottesman

commit sha aea6d7df802c958fc843534bcbba5c88ba222ebe

[opt-remark] Teach opt-remark how to emit "NOTE" arguments that use the loc of the original remark instead of the args own. This is useful if one wants to emit a note explanation (in my case that we couldn't find any values) but do not have any other source loc but the original remark.

view details

Michael Gottesman

commit sha 2c9a34fa018661900407934086e5bed200a3fedc

[opt-remark] Teach opt-remark how to emit notes that point to the value being retained/released. This is just an initial implementation and doesn't handle all cases. This works by grabbing the rc-identity root of a retain/release operation and then seeing: 1. If it is an argument, we use the ValueDecl of the argument. 2. If it is an instruction result, we try to infer the ValueDecl by looking for debug_value uses. 3. In the future, we should add support for globals and looking at addresses. I may do 3 since it is important to have support for that due to inout objects.

view details

Luciano Almeida

commit sha 81afffee72fd91741fd6420bfb8ef563de157526

[CSSimplify] Handle generic argument for unsatisfied generic requirement bind constraint in repairFailures

view details

Luciano Almeida

commit sha 82d95ecebc361e2e5d7555070ef9c0d8adf63f47

[tests] Adding regression tests for SR-13226

view details

Andrew Trick

commit sha 4b6641f15f2cd4d33e4b64bdf68539c1accd12db

Merge pull request #32860 from buttaface/skip-build [build] Fix --skip-build-llvm so that its minimal targets, like tblgen, are still built

view details

Slava Pestov

commit sha 4a4719033524f74e01965cf9aefb68610476b588

AST: Allow @_fixed_layout protocols A @_fixed_layout protocol exposes its witness table layout to clients, which prevents re-ordering of requirements or adding new requiremenst with a default. When library evolution is enabled, we still emit method descriptors even for @_fixed_layout protocols; this allows a previously-resilient protocol to become @_fixed_layout as long as the published layout matches the resilient layout in all previously-shipped versions of the library.

view details

Michael Gottesman

commit sha 356bfee961b0ef98d170b27db2817ff6a41157b6

Merge pull request #33023 from gottesmm/pr-c7a2ff52b8850a874dcf6dc84616594e4cbcfaf4 [opt-remark] Teach opt-remark how to emit back notes to retain/released variables in simple cases.

view details

Saleem Abdulrasool

commit sha c6a5e01c20359e4d235780511b8ce1f599c5e43a

gyb: force I/O in UTF-8 We would rely on the system encoding, which if unspecified would fall back to `C` treating the encoding as ASCII. This fails with unicode data in Python3. Thanks to @tbkka for the brilliant idea of forcing the encoding when reading the file. This improves the test pass rate on Linux with Python 3.

view details

Saleem Abdulrasool

commit sha 3d755b4a5dd6ba75fb9da35a01f0dcb7d6d44086

test: force line-directive to UTF-8 Treat the I/O data as UTF-8 rather than the system encoding, which can fallback to `C`, treating unicode data as ASCII. This improves the test coverage on Linux with Python 3.

view details

push time in 2 months

more