profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/CasVissers-360ERP/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Cas Vissers CasVissers-360ERP 360 ERP Netherlands https://www.360erp.nl

CasVissers-360ERP/account-invoicing 0

Odoo Invoicing Extension Addons

CasVissers-360ERP/credit-control 0

Odoo modules for the customer credit control

issue commentOCA/social

[12.0][mail_activity_done] - CRM Pipeline Progress Bar issue

I think there is no way of fixing this without Odoo providing a hook to allow us to alter the domain.

kurtbinspired

comment created time in a day

issue commentOCA/server-tools

[10.0] Module not completely uninstalled. Left a non-working menu in Task Management

I also faced the same issue in v13 ir.actions.act_window are not removed when uninstalling the module which results in this traceback. Can be tricky.

arafatx

comment created time in 6 days

Pull request review commentodoo/odoo

[FIX] account move: Due date not updated when invoice_date changed

 def _onchange_invoice_date(self):             if accounting_date != self.date:                 self.date = accounting_date                 self._onchange_currency()+            self._onchange_recompute_dynamic_lines()

Could we move forward with this PR? We have a customer affected by this.

nmarotte

comment created time in 7 days

PullRequestReviewEvent

issue commentodoo/odoo

[13] Emails send in multi-website/comapny enviroment are using wrong domain/company

@Gumaa Did you find a solution for the base_url issue?

This commit doesn't seem to help: https://github.com/odoo/odoo/commit/13ff118da832a339d9cb43d74bf0b5dd0cf3c036#diff-e46e2629963b0ad64aed7a7b02f49caea5bfacd952b77abcb2954f2437c9222a This one for v15 might but we can't use it in v14. https://github.com/odoo/odoo/commit/1b9dd118cb0f305ed38b6326fa814336cbf16252#diff-e46e2629963b0ad64aed7a7b02f49caea5bfacd952b77abcb2954f2437c9222a

Gumaa

comment created time in 8 days

PR closed OCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

In some cases partner_bank_id might be set already, i.e. UBL or other imports.

In addition when no payment mode is set this method will remove the bank account, since payment mode is not mandatory this makes no sense to me.

@pedrobaeza

+1 -1

9 comments

1 changed file

CasVissers-360ERP

pr closed time in 10 days

pull request commentOCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

Well I will close the PR since we won't agree on this it seems.

For me the use-case is simple and logical. Account payment partner is a dependency oftenly needed for i.e. the UBL modules. It might be that the module is even installed without account_payment_order in the same system. Currently account_payment_partner breaks the base behaviour of Odoo since it removes the bank account from a supplier invoice if no payment mode is set. In my example UBL invoices only need a payment mode to be set on customer invoices (even if not set there it will just use a default one). Thus we are forced to use payment modes, else base Odoo will start acting differently.

CasVissers-360ERP

comment created time in 10 days

pull request commentOCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

This still doesn't explain why we should not set it if no payment mode is selected?

CasVissers-360ERP

comment created time in 10 days

pull request commentOCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

Just found out that I applied the fix to the wrong method in this commit. Fixed that now.

If you pre-set it, you are losing flexibility, as it's fixed forever. There are cases where the bank account changes across times and invoices with a long due date points to the incorrect bank account, as it was fixed some time ago. So better to always leave it empty.

If the user choses from i.e. a list of 5 bank accounts to use one, we never want to overwrite that? Simply selecting the first bank in the list (like this method does) might possible reset the bank account without even notifying the user.

To be honest, it just makes no sense to me to not set a bank account if available and overwriting it when a different payment mode is selected. Seems error-prone to me.

CasVissers-360ERP

comment created time in 10 days

push event360ERP/bank-payment

Cas Vissers

commit sha 70248c328ceb74a34969df0e90732674550a18c4

[FIX] Move fix to correct method

view details

push time in 10 days

pull request commentOCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

we don't want such bank account, as it's incorrect according bank-payment suite

I don't understand why it's incorrect, if we don't set a payment mode on a supplier invoice we want to use Odoo's base method to pay the invoice? In that case we should let Odoo base decide what to do? If we want to use the OCA bank-payment suite we set a payment mode?

CasVissers-360ERP

comment created time in 10 days

pull request commentOCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

What I want to achieve: Base Odoo fills the bank account on a supplier invoice. With this module installed and no payment mode set on a supplier the bank account is (incorrectly) removed: https://drive.google.com/file/d/1Y_RxADwgOeEOTgOhjC91BNhzjOvXrSeB/view

CasVissers-360ERP

comment created time in 10 days

PR opened OCA/bank-payment

[14.0][FIX] account_payment_partner - Only update partner bank if not set

In some cases partner_bank_id might be set already, i.e. UBL or other imports.

In addition when no payment mode is set this method will remove the bank account, since payment mode is not mandatory this makes no sense to me.

@pedrobaeza

+1 -1

0 comment

1 changed file

pr created time in 13 days

push event360ERP/bank-payment

Cas Vissers

commit sha da8b9bcdfa2f5152e0ce2ea2cf097dae6897153f

[FIX] Only update partner bank if not set

view details

push time in 13 days

pull request commentOCA/knowledge

[WIP] [14.0] [MIG] document_url

@DavidBForgeFlow Tried it on runbot but not working, WIP? https://drive.google.com/file/d/1KG2F5Veaqok3EwoHBGGJavGzq6F2rlz0/view

DavidBForgeFlow

comment created time in 13 days

pull request commentOCA/social

[14.0][MIG]mail_activity_done

@manuelregidor See #750 Maybe not doable to fix this in a clean way without asking Odoo for an option to inherit this method.

manuelregidor

comment created time in 16 days

PullRequestReviewEvent

Pull request review commentOCA/social

[14.0][MIG]mail_activity_done

 class MailActivity(models.Model):      active = fields.Boolean(default=True)     done = fields.Boolean(default=False)-    state = fields.Selection(selection_add=[("done", "Done")], compute="_compute_state")-    date_done = fields.Date(-        "Completed Date",-        index=True,-        readonly=True,+    state = fields.Selection(+        selection_add=[("done", "Done")], compute="_compute_state", store=True

Why did you make the field stored?

manuelregidor

comment created time in 16 days

issue commentOCA/social

[12.0][mail_activity_done] - CRM Pipeline Progress Bar issue

I can confirm this issue for v13 as well.

kurtbinspired

comment created time in 16 days

issue commentOCA/odoo-pim

Maintain variant specific PIM attributes

We are facing a similar issue, it's also a bit confusing that attribute_set_id is available on the product.product form view and when setting it the page product_attributes becomes visible without any attributes.

Would be nice to also trigger the onchanges from product.product. I think this is not what @JordiBForgeFlow is suggesting. But maybe the solution could be to set the attributes on product.product level, if there is 1-1 relation between product.template and product.product the attributes should be ok?

JordiBForgeFlow

comment created time in 16 days

issue commentOCA/server-ux

[13.0] barcode_action: android browser unavailable

We tried the widget="barcode_handler", same result, this is the one you mean right? We will try 12.0 after the runbot build has finished.

snowtianyou

comment created time in a month

issue commentOCA/server-ux

[13.0] barcode_action: android browser unavailable

@etobella Do you maybe have an idea in what direction we could search?

@AdriaGForgeFlow @fshah-initos You both migrated the module. Any ideas?

snowtianyou

comment created time in a month

issue commentOCA/server-ux

android browser unavailable

barcode_action :)

snowtianyou

comment created time in a month

issue commentOCA/server-ux

android browser unavailable

I think I can actually confirm this issue, on our Zebra barcode scanner running Android the barcode scan is not used as input in the wizard. The barcode scan doesn't seem to trigger anything.

snowtianyou

comment created time in a month

PullRequestReviewEvent

pull request commentOCA/timesheet

[FIX] Do not try to remove invoiced lines

@dreispt What I can do to fix this PR?

CasVissers-360ERP

comment created time in a month

PullRequestReviewEvent

PR closed OCA/l10n-netherlands

[13.0][FIX] XAF Ignore section/note account move lines

Section/note move lines should not be included in the export. Will forward port to v14 when approved.

+3 -2

1 comment

2 changed files

CasVissers-360ERP

pr closed time in 2 months

push event360ERP/l10n-netherlands

Cas Vissers

commit sha 84087d3a051371f486e7b788a97ac8b59e61d5e1

[FIX] Ignore section/note query

view details

push time in 2 months

PR opened OCA/l10n-netherlands

[13.0][FIX] XAF Ignore section/note account move lines

Section/note move lines should not be included in the export. Will forward port to v14 when approved.

+3 -2

0 comment

2 changed files

pr created time in 2 months