profile
viewpoint
Fabian Sauter COM8 Technical University of Munich Germany https://uwpx.org

whoshuu/cpr 3158

C++ Requests: Curl for People, a spiritual port of Python Requests

UWPX/UWPX-Client 51

A WIP secure XMPP client for UWP (Windows 10) devices.

COM8/UWP-Onewheel 6

A simple UWP Onewheel companion App for all Windows 10 UWP devices

TUM-Dev/eat-api 6

Simple static API for some (student) food places in Munich.

COM8/TUM_Campus_App_UWP 5

A companion app for all UWP devices for the Technical University of Munich.

COM8/esp32-jura 4

ESP32 powered Jura coffee maker.

COM8/esp32-xmpp-iot 4

ESP32 meets XMPP for IoT

COM8/Crystallogy 3

Minecraft Mod

COM8/Onewheel-Doc 1

Documentation for the Onewheel from Future Motion.

push eventls1intum/Artemis

Fabian Sauter

commit sha d8ff875ae54ad26253f360529a962f4ab3dcf3ec

ReadLine Fix

view details

push time in 2 days

PR opened ls1intum/Artemis

[BugFix] C template random test fix and updated the C-tester to 1.27

<!-- Thanks for contributing to Artemis! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> <!-- If your pull request is not ready for review yet, create a draft pull request! -->

Checklist

  • [ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

Motivation and Context

Sometimes random test cases fail in the C-template. This is being caused by the tester not receiving input from the program since it terminated after sending the last line.

Description

  • Potential fix for not receiving the last line of output sometimes.
  • Updated the GBS-Tester from 1.24 to 1.27. This update includes some fixes for potential security vulnerabilities.

Steps for Testing

  1. Log in to Artemis
  2. Create a new C-Programming exercise
  3. Run the solution template a couple of times -> Tests won't fail any more

Test Coverage

<!-- Please add the test coverage for all changes files here. You can see this when executing the tests locally (see build.gradle and package.json) or when looking into the corresponding Bamboo build plan -->

  • ExerciseService.java: 85%
  • programming-exercise.component.ts 95%
+102 -20

0 comment

5 changed files

pr created time in 2 days

issue commentUWPX/UWPX-Client

App Crash when deleting account

Ok. Thanks 👍🏻. A fix will be included in next weeks release.

o---

comment created time in 3 days

push eventls1intum/Artemis

Fabian Sauter

commit sha dbee76d0bf8acae2b1c2045d269df22cb458b59d

Added the latest rotX test to the readme

view details

push time in 5 days

push eventls1intum/Artemis

Fabian Sauter

commit sha d59dae15861fa484f76a727b6d8da647dfeae898

Added the latest rotX test to the readme

view details

push time in 5 days

PR opened ls1intum/Artemis

Reviewers
Bugfix/programming exercise/c template rotx

<!-- Thanks for contributing to Artemis! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> <!-- If your pull request is not ready for review yet, create a draft pull request! -->

Checklist

  • [x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fixes the C-Template rotX exercise.

Description

<!-- Describe your changes in detail -->

  • Fixed printing null characters in some random cases for the rotX solution.
  • Fixed __progTerminatedUnexpectedly() -> _progTerminatedUnexpectedly() since we internally switched to AbstractProgramTest as base class.

Steps for Testing

<!-- Please describe in detail how the reviewer can test your changes. -->

  1. Log in to Artemis
  2. Create a new C-Programming exercise
  3. Run the solution template a couple of times -> Tests won't fail any more

Test Coverage

<!-- Please add the test coverage for all changes files here. You can see this when executing the tests locally (see build.gradle and package.json) or when looking into the corresponding Bamboo build plan -->

  • ExerciseService.java: 85%
  • programming-exercise.component.ts 95%
+12 -10

0 comment

3 changed files

pr created time in 5 days

push eventls1intum/Artemis

Fabian Sauter

commit sha 5881246764a67768b6df5f3163c399d0cde611ef

Fixed tester makefileLocation

view details

push time in 5 days

create barnchls1intum/Artemis

branch : bugfix/programming-exercise/c-template-rotx

created branch time in 5 days

pull request commentwhoshuu/cpr

add guards for curl version

Great additions. Thanks. Is this PR from your side ready to be merged?

xloem

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentwhoshuu/cpr

add guards for curl version

 void Session::Impl::SetSslOptions(const SslOptions& opts) { #endif     curl_easy_setopt(curl_->handle, CURLOPT_SSL_VERIFYPEER, opts.verify_peer ? ON : OFF);     curl_easy_setopt(curl_->handle, CURLOPT_SSL_VERIFYHOST, opts.verify_host ? 2L : 0L);+#if LIBCURL_VERSION_NUM >= 0x074100
#if LIBCURL_VERSION_NUM >= 0x072900

Available since 7.41.0 -> 0x07, 0x29, 0x00 Curl uses hex numbers here ;)

https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYSTATUS.html

https://curl.haxx.se/docs/versions.html

xloem

comment created time in 9 days

Pull request review commentwhoshuu/cpr

add guards for curl version

 Response::Response(std::shared_ptr<CurlHolder> curl, std::string&& p_text,     char* url_string{nullptr};     curl_easy_getinfo(curl_->handle, CURLINFO_EFFECTIVE_URL, &url_string);     url = Url(url_string);+#if LUBCURL_VERSION_NUM < 0x075500
#if LUBCURL_VERSION_NUM < 0x070401

Based on the docs for CURLINFO_SIZE_DOWNLOAD and CURLINFO_SIZE_UPLOAD, shouldn't this be 0x070401, since it's available since 7.4.1.

https://curl.haxx.se/libcurl/c/CURLINFO_SIZE_DOWNLOAD.html

xloem

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentwhoshuu/cpr

Supporting Tor And Socks5

What version of cpr are you using?

s1nisteR

comment created time in 9 days

issue commentwhoshuu/cpr

Supporting Tor And Socks5

OK. Then I do not know how to fix this. Is there an easy to use sock5 proxy setup or server out there, you know about? So I can try to reproduce this issue.

s1nisteR

comment created time in 9 days

issue commentwhoshuu/cpr

Supporting Tor And Socks5

Reference: https://curl.haxx.se/libcurl/c/CURLOPT_PROXY.html

s1nisteR

comment created time in 9 days

issue commentwhoshuu/cpr

Supporting Tor And Socks5

What happens if you add a socks5:// in front of your IP (=> socks5://127.0.0.1:9050)?

s1nisteR

comment created time in 9 days

push eventls1intum/artemis-c-docker

Fabian Sauter

commit sha 32c65e56fc5852c7d82bf5581f52d401a2761dd3

Added python3-devel

view details

push time in 9 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha cbf369adcb3c06bc3044f9bc4096fcbb6177c629

Fixed updating IoT slider values

view details

push time in 10 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha ae1aa2c4a7c065f5881862d5ef1ecc79fcfd4e9b

Fixed IoT slider not updating the value

view details

push time in 10 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha e39b2fafda3217c01e99768dd3df1fef4d539cc5

IoT slider tick values

view details

Fabian Sauter

commit sha fe948204d8a9b805c8e3982525d533b664e1d88c

IoT chat details margin added

view details

Fabian Sauter

commit sha 7ef3075f83bf7ee64ec2f1eea382b70183453f20

Fixed DataForm instructions

view details

Fabian Sauter

commit sha 524f967fcfb93e300ac86e5d40f1cddb40b0eb31

Loading sensor and actuator values during init

view details

push time in 10 days

push eventCOM8/esp32-jura

Fabian Sauter

commit sha 1a66cb5bca83e04cfa0cc4abdcea15ce277c60c5

Further optimisations for brewing coffee

view details

Fabian Sauter

commit sha 07541277d31ba06d6fe4579bd0b2fb04b60d5c9b

Fixed slider nodes

view details

push time in 10 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha 88610629771ec95393c752481b45003aa1592df4

Added support for parsing DiscoRequestMessages

view details

push time in 10 days

push eventCOM8/esp32-jura

Fabian Sauter

commit sha 819747a0501cabeac32b6720dcfed7eaaf8bf6a7

Even further improved the coffee maker brewing routine

view details

push time in 10 days

push eventwhoshuu/cpr

Luca Schlecker

commit sha f5d9ef4a1d73ab6167f69838c1f642eac1f111c8

Fixed typo Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>

view details

push time in 10 days

PR merged whoshuu/cpr

Fix a small typo in util.cpp

Signed-off-by: Luca Schlecker luca.schlecker@hotmail.com

+1 -1

1 comment

1 changed file

luca-schlecker

pr closed time in 10 days

pull request commentwhoshuu/cpr

Fix a small typo in util.cpp

Thanks.

luca-schlecker

comment created time in 10 days

PullRequestReviewEvent

push eventwhoshuu/cpr

Luca Schlecker

commit sha 18648af142d83a90b13719464df7072410b156a4

Added urlDecode(std::string) for url decoding Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>

view details

Luca Schlecker

commit sha 48b6f335fbbce4092efd513904e44f8f03b7398c

Update cpr/util.cpp Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>

view details

push time in 10 days

PR merged whoshuu/cpr

Implement Url Decoding

I found myself needing to decode text. This function does the opposite of cpr::util::urlEncode(const std::string& s) using curl_easy_unescape.

Signed-off-by: Luca Schlecker luca.schlecker@hotmail.com

+46 -0

0 comment

5 changed files

luca-schlecker

pr closed time in 10 days

PullRequestReviewEvent

Pull request review commentwhoshuu/cpr

Implement Url Decoding

 std::string urlEncode(const std::string& s) {     return holder.urlEncode(s); } +/**+ * Creates a temporary CurlHolder object and uses it to unescape the given string.+ * If you plan to use this methode on a regular basis think about creating CurlHolder
 * If you plan to use this methode on a regular basis think about creating a CurlHolder
luca-schlecker

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha d295592d694b9a0612c5bd75dd914c22611b7182

Fixed the MS Store badge

view details

push time in 11 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha 970a39af5553d8b35dc850d9e8c1e2b770fc22bc

Breaking the debugger on an unhandled exception

view details

Fabian Sauter

commit sha d302896ea5ad82b051d8b9d4bb21f9c078aba8cb

Fixed #140

view details

push time in 11 days

issue closedUWPX/UWPX-Client

App Crash when deleting account

<!-- PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION. ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION. -->

Bevor you create a new issue:

<!-- Check the following checkboxes with an "x" ([ x ] <= checked, [ ] <= unchecked) -->

- [X] I searched for similar issues and did not find one
- [X] I'm using the latest version available in the [Windows Store](https://www.microsoft.com/store/apps/9NW16X9JB5WV)

I'm submitting a...:

<!-- Please uncomment one or more that apply to this issue -->

  • Regression (a behavior that used to work and stopped working in a new release) <!-- - Bug report (I searched for similar issues and did not find one) -->
    <!-- - Feature request (UserVoice request: ) --> <!-- - Documentation issue or request --> <!-- - Question of Support request -->

Current behavior:

Application crashes when trying to delete an account. There is nothing in the log.

Following info can be found in the event log:

Name of the app: UWPX_UI.exe, version: 1.0.0.0, timestamp: 0x5f759893 Name of the missing module: Windows.UI.Xaml.dll, version: 10.0.18362.1139, timestamp: 0x97b8f732 Exception code: 0xc000027b Error: 0x00000000001a0372 Identification of missing process: 0x3e18 Execution time: 0x01d6a4c69db8625e Path to application: C:\Program Files\WindowsApps\790FabianSauter.UWPXAlpha_0.28.0.0_x64__s1c5dt7qckd0e\UWPX_UI.exe Path to missing module: C:\Windows\System32\Windows.UI.Xaml.dll Full name of missing package: 790FabianSauter.UWPXAlpha_0.28.0.0_x64__s1c5dt7qckd0e Identification of missing application related to the package: App

Expected behavior:

Account can be deleted.

Minimal reproduction of the problem with instructions:

  1. Deactivate account
  2. Delete account

Environment:

<!-- Check the following checkboxes with an "x" ([ x ] <= checked, [ ] <= unchecked) -->

App Version(s): 
v.0.28.0.0 <!-- Which version of the App are you using (e.g. v.0.2.0) -->

Windows 10 Version Number: <!-- https://en.wikipedia.org/wiki/Windows_10_version_history -->
- [X] 1909
- [ ] 1809
- [ ] 1803
- [ ] 1709
- [ ] 1703
- [ ] 1607
- [ ] 1511
- [ ] 1507
- [ ] Insider Build (build number: )
- [ ] Misc:

Device form factor:
- [X] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub

Where did you got the APP from?
- [X] [Windows Store](https://www.microsoft.com/store/apps/9NW16X9JB5WV)
- [ ] Self-build, using a provided release source
- [ ] Self-build, repo cloned at [dd.mm.yyy] <!-- When did you clone the repo! -->
- [ ] Misc, got it from... <!-- Please tell us your source! -->

<!-- THANKS FOR YOUR HELP :heart: -->

closed time in 11 days

o---

push eventCOM8/vcpkg

Fabian Sauter

commit sha c7e6e4e5193cd80520fa0f581605f28148a7ded0

Updated the cpr SHA512

view details

push time in 11 days

issue closedwhoshuu/cpr

Post request doesn't work well

Hello there, I try to work with Post (with Body) but it seems fail, (similar command using curl work well with my web api)

curl -XPOST -H "Content-Type: application/json" -d "{'GUID':'1', 'comm':'ElectricFan' , 'json':'29.80' }" http://localhost:8866/api/Agents/send_command

auto r = cpr::Post (cpr::Url{ "http://localhost:8866/api/Agents/send_command" }, cpr::Body { R"({'GUID':'1','comm':'test','json':'14'})" }, cpr::Header{ { "Content-Type", "application/json" } }); std::cout << "Returned Status:" << r.status_code << std::endl;

I setup a Fiddle proxy to see what is sending and see that content length is SO LONG Host: localhost:8866 User-Agent: curl/7.73.0-DEV Accept: / Accept-Encoding: deflate, gzip Content-Type: text/plain Content-Length: 76533568435650626

Please help! Thank and regards

closed time in 11 days

hung1024

issue commentwhoshuu/cpr

Post request doesn't work well

https://github.com/microsoft/vcpkg/pull/14131

hung1024

comment created time in 11 days

PR opened microsoft/vcpkg

Updated cpr to 1.5.2

Describe the pull request Updates cpr to version 1.5.2.

+3 -3

0 comment

2 changed files

pr created time in 11 days

push eventCOM8/vcpkg

Fabian Sauter

commit sha c3b2bee096b1985bdd91bfbf7aa379380a8bedfa

Updated cpr to 1.5.2

view details

push time in 11 days

fork COM8/vcpkg

C++ Library Manager for Windows, Linux, and MacOS

fork in 11 days

issue commentwhoshuu/cpr

Post request doesn't work well

https://github.com/whoshuu/cpr/releases/tag/1.5.2

hung1024

comment created time in 11 days

created tagwhoshuu/cpr

tag1.5.2

C++ Requests: Curl for People, a spiritual port of Python Requests

created time in 11 days

release whoshuu/cpr

1.5.2

released time in 11 days

create barnchwhoshuu/cpr

branch : v1.5.2_pre

created branch time in 11 days

push eventUWPX/unicode.net

Fabian Sauter

commit sha 2c610c6ab9d56a5d674d2803f45f7496e4b31cd5

Updated to the latest version of Unicode 13.0

view details

Fabian Sauter

commit sha db9bd17ee940d7c78ea867a7bf8f6aa6c059d62e

Merged

view details

push time in 11 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha 3f1da1d8d837ef351c25280d9efa45ca3e3e0946

Updated to the latest version of Unicode 13.0

view details

Fabian Sauter

commit sha 86ad182f48372eef99e1c020acae34835fadba63

Merge branch 'master' of https://github.com/UWPX/UWPX-Client

view details

push time in 11 days

issue commentwhoshuu/cpr

Post request doesn't work well

Arg, ok. Then I guess it's time for a 1.5.2 release since this is a critical bug. I will try to create a new tag today and start creating a PR on vcpkg.

hung1024

comment created time in 11 days

issue commentwhoshuu/cpr

Post request doesn't work well

OK. This issue has been fixed in #450 but there is no new version of cpr in vcpkg available until now. As a workaround I suggest basing your implementation on the latest master with cmake and fetch content. Is this workaround viable for your project?

hung1024

comment created time in 11 days

issue closedwhoshuu/cpr

Memory leak in session?

Valgrind seem to find a memory leak in session.cpp

Here is the diff of the fix: diff --git a/lib/cpr/cpr/session.cpp b/lib/cpr/cpr/session.cpp index 485be10..8467006 100755 --- a/lib/cpr/cpr/session.cpp +++ b/lib/cpr/cpr/session.cpp @@ -90,6 +90,7 @@ void Session::Impl::freeHolder(CurlHolder* holder) { CurlHolder* Session::Impl::newHolder() { CurlHolder* holder = new CurlHolder(); holder->handle = curl_easy_init();

  • holder->chunk = NULL; return holder; }

@@ -108,6 +109,10 @@ void Session::Impl::SetParameters(Parameters&& parameters) { void Session::Impl::SetHeader(const Header& header) { auto curl = curl_->handle; if (curl) {

  •    if (curl_->chunk) {
    
  •        curl_slist_free_all(curl_->chunk);
    
  •        curl_->chunk = NULL;
    
  •    }
     struct curl_slist\* chunk = NULL;
     for (auto item = header.cbegin(); item != header.cend(); ++item) {
         auto header_string = std::string{item->first};
    

closed time in 11 days

lurker99

issue commentwhoshuu/cpr

Post request doesn't work well

What version of cpr are you using? This looks to me like an issue that has been fixed in #450 .

hung1024

comment created time in 11 days

issue commentUWPX/UWPX-Client

App Crash when deleting account

Thanks for submitting. I will have a look at it. Does this happen all the time, or only when the account is trying to connect?

o---

comment created time in 11 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha 3f72d49b1da80dce1b81cb0eaabfb31ae0490cc4

Updated latest version in README

view details

push time in 11 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha 681062ee13bd9ab7639ea7c936f2c876838224ec

Fixed VALUE not found

view details

push time in 11 days

PR opened ls1intum/artemis-c-docker

Create docker-image.yml enhancement

An initial version of the docker image CI. The following needs to be done:

  • [ ] Replace secrets.ReplaceWithDockerHubPassword with the password for the docker hub account
  • [ ] Replace secrets.ReplaceWithDockerHubUserName with the username for the docker hub account
  • [ ] Optional: Replace com8/artemis-gbs with the correct docker hub repository

Create Encrypted Secrets for GitHub Actions

https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets

+18 -0

0 comment

1 changed file

pr created time in 12 days

create barnchls1intum/artemis-c-docker

branch : Docker-image-CI

created branch time in 12 days

pull request commentls1intum/Artemis

Updated and fixed the C template

Ready to be reviewed. I also updated the c-docker-file over at: https://github.com/ls1intum/artemis-c-docker/commit/e9c09a1f0f1f07c20a71cf0be853ff78c4b04a09

What is the name of the docker image I updated over at: https://github.com/ls1intum/artemis-c-docker ?

COM8

comment created time in 12 days

push eventls1intum/Artemis

Stephan Krusche

commit sha 03416a93e84b730a06aa88c95b522577b3aef5ea

bump version to 4.6.2

view details

Stephan Krusche

commit sha 0949e556fc83e6b4d93d6ad1503bc9cd94a2c285

Improvements to BambooService (#2199)

view details

Stefan Klöss-Schuster

commit sha dc6b71cd98a4a714c9c39324a8d819918fe51acd

Update docker image for Java exercises (#2204)

view details

Simon Leiß

commit sha 86e4c28b41579b21bd0e90ed87388bafb877754a

Add docu for disabling XSRF checks. (#2208)

view details

Tiffany Cauthen

commit sha 27ca8c7388f2b8134ef9eca4a9482c9c1dda7ddf

Bugfix: instructor dashboard button naming (#2195) Co-authored-by: Stephan Krusche <krusche@in.tum.de> Co-authored-by: Jan Philip Bernius <janphilip.bernius@tum.de>

view details

Lukas Franke

commit sha f87329fbd101afc0f553d0acaa02a5fd7ed6986e

Add documentation for disabling the external user management (#2209) Co-authored-by: Jan Philip Bernius <janphilip.bernius@tum.de>

view details

Lukas Franke

commit sha 96a41ad729838b3d1da93dd67cdd86e003392ee7

Fix the online courses column name (#2210)

view details

Christian Femers

commit sha ceaef1c26469b339414ee22621010bd26eccbc4c

Improve Quiz Scheduling Robustness (#2212)

view details

Filip Gregurevic

commit sha 70912ee1bb0c7540725142110116c3f401cd62ea

Improve security & add auto approve answers by instructors (#2156)

view details

Stephan Krusche

commit sha 3f8a395f7d79d4518ae2b0361454766963e0bc88

update dependencies and test settings

view details

Andi Turdiu

commit sha 09c023974816652c010e72e59e0603cf2cbe37b2

Feature Overview for Exam Mode (#2167)

view details

Philipp Bauch

commit sha 58f54cbac6c46df2d3fc9bd3ddf7509f0bc64105

Add missing plagiarism tests (#2189)

view details

Stephan Krusche

commit sha 092aad85a7368b191d2fd8ec74c18b12521957d3

try to fix issues with jest tests remove workaround for AlertService add new test for alert component update client dependencies

view details

Stephan Krusche

commit sha 7b49d448abc9d8c42595bc1c45895b8e5c815188

bump version to 4.6.3

view details

Stefan Klöss-Schuster

commit sha 8f39d0d7b0b0906d334e81515234db81fcf5a23a

[Doc] GitLab/Jenkins setup on Windows (#2214)

view details

Jan Philip Bernius

commit sha 43a9971edee021a27f4c4aa502538c83038a8304

Documenting the Documentation (#2219)

view details

Lukas Franke

commit sha 0f62d1c6c159a6c8c8ab728e16d320f0b26a00bf

Fix rst documentation compilation errors and warnings (#2220)

view details

Stephan Krusche

commit sha 67dcd41fa289bf308919b73f6275da293679c914

fix flaky test and improve caching behavior of application links for concurrent operations also fix warning

view details

Fabian Sauter

commit sha 9d0a1e932304ee64ef5507517fb3603dd5cff262

Merge branch 'develop' into feature/programming-exercise/c-template

view details

push time in 12 days

push eventls1intum/artemis-c-docker

Fabian Sauter

commit sha e9c09a1f0f1f07c20a71cf0be853ff78c4b04a09

Updated the dockerfile to the latest tester

view details

push time in 12 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha d1c3f6fe3f5a98ed42514c121346f418ff3e5120

Added additional IoT controls

view details

push time in 15 days

push eventCOM8/esp32-jura

Fabian Sauter

commit sha 54cac06409a2e0bda83d72f3949c3f64091dc957

Added slider nodes

view details

Fabian Sauter

commit sha fcb2d605ab19de7481dba92f9300fb6a04c71e06

Increased the default grind time to 3.5 seconds

view details

push time in 15 days

push eventCOM8/esp32-jura

Fabian Sauter

commit sha 91ef53c2082cd3336c3fa9bc3eaf6369c8fa90a9

Fixed resource binding

view details

Fabian Sauter

commit sha 3cccbb9899f7df727ea731a9572255c1ce62c661

Fixed not publishing nodes

view details

Fabian Sauter

commit sha 3997bde3c7ab0fb4c8a3fa23095533ba19cb7d8d

Fixed publishing coffee maker nodes

view details

Fabian Sauter

commit sha 2bfc32a6e669322d112968154302c97160bb98a3

const std::string&& -> std::string&&

view details

push time in 15 days

issue commentwhoshuu/cpr

Feature request: Expose version information via preprocessor macros

But all in all, I think exposed version macros are a good idea.

mikedld

comment created time in 15 days

issue commentwhoshuu/cpr

Feature request: Expose version information via preprocessor macros

Well, the existing API should stay the same. Even when adding features like #288, this should not change the API. The plan for all the upcoming C++17/20 features is to make them optional (at least for the near future). You can read more about this here.

mikedld

comment created time in 15 days

push eventls1intum/Artemis

Fabian Sauter

commit sha d723bf108b562d8a9046e70ef8dc849773c37b0d

Further rotX fixes

view details

push time in 16 days

push eventls1intum/Artemis

Fabian Sauter

commit sha 0fda5c5b49a82d77cc7542744d34d834b8425f99

Updated the C-template to the latest tester

view details

push time in 16 days

push eventls1intum/Artemis

Fabian Sauter

commit sha 1873e6098dd7495e6d6b424a35dc5f396b98aa09

Updated the C template description

view details

push time in 16 days

issue closedls1intum/Artemis

Creating C and Haskell Programming Exercises fails

Describe the bug

To Reproduce

<!-- Steps to reproduce the behavior: -->

  1. Create a new programming exercise on 4.6.2.
  2. Try to select the C or Haskell template.
  3. Selection won't apply and you can not select python or java as template for the exercise.

Expected behavior

<!-- A clear and concise description of what you expected to happen. --> It should be possible to select the C and Haskell template in programming exercises.

Environment

<!-- Please complete the following information: --> <details><pre>

  • OS: Windows 10 (20180.1000)
  • Browser Edge Canary
  • Version 87.0.666.0 </pre></details>

Additional context

This issue only occurs on the develop branch aka 4.6.2. You can try this on TS1 (https://artemistest.ase.in.tum.de/).

Output in Web Console

<!-- If applicable, copy output from the Web Console --> <details><pre> {"type":"https://www.jhipster.tech/problem/problem-with-message","title":"Unauthorized","status":401,"detail":"Full authentication is required to access this resource","path":"/api/account","message":"error.http.401"} </pre></details>

closed time in 16 days

COM8

issue commentls1intum/Artemis

Creating C and Haskell Programming Exercises fails

This issue is only reproducible on Edge Canary (87.0.666.0). Updating to 88.0.671.0 fixes it. Other browsers like Firefox and Chrome are not affected. Closing this.

COM8

comment created time in 16 days

issue openedls1intum/Artemis

Creating C and Haskell Programming Exercises fails

Describe the bug

To Reproduce

<!-- Steps to reproduce the behavior: -->

  1. Create a new programming exercise on 4.6.2.
  2. Try to select the C or Haskell template.
  3. Selection won't apply and you can not select python or java as template for the exercise.

Expected behavior

<!-- A clear and concise description of what you expected to happen. --> It should be possible to select the C and Haskell template in programming exercises.

Environment

<!-- Please complete the following information: --> <details><pre>

  • OS: Windows 10 (20180.1000)
  • Browser Edge Canary
  • Version 87.0.666.0 </pre></details>

Additional context

This issue only occurs on the develop branch aka 4.6.2. You can try this on TS1 (https://artemistest.ase.in.tum.de/).

Output in Web Console

<!-- If applicable, copy output from the Web Console --> <details><pre> {"type":"https://www.jhipster.tech/problem/problem-with-message","title":"Unauthorized","status":401,"detail":"Full authentication is required to access this resource","path":"/api/account","message":"error.http.401"} </pre></details>

created time in 16 days

pull request commentls1intum/Artemis

Updated and fixed the C template

I think, I will set up a new one so once both diverge it is easier to maintain both.

should we then also create this in out ls1intum GitHub account? We could give you write access, then you could also maintain it here.

Yes, this would be a good idea. Yesterday we switched our docker image to fedora with a couple other minor changes. Then I could maintain it.

COM8

comment created time in 16 days

push eventls1intum/Artemis

Alexander von Trostorff

commit sha fec05b806b1d220b0f86a2e031e28fac3c289257

Fix typo in documentation (#2200)

view details

Filip Gregurevic

commit sha 1c0c938995bebe4c21e2d005e7b57bef93001454

Overview for students' questions (#2127)

view details

Stephan Krusche

commit sha f6cf7da8bd34692850406eecc87e8e0c199a3110

Improve course registration and add more customization options (#2174)

view details

Fabian Sauter

commit sha a463fa844dee829814adb917d454937f502ea523

Merge branch 'develop' into feature/programming-exercise/c-template

view details

push time in 16 days

push eventCOM8/esp32-jura

Fabian Sauter

commit sha 7b127d9473efc07fe3be005aa1dd8848949436e8

Improved the coffee brewing sequence

view details

Fabian Sauter

commit sha dcd6cb9b0f2808c4cc5f9d8be2b3f821bd417a04

Waiting for a "ok:\r\n" response after pressing a button

view details

Fabian Sauter

commit sha c2caab7b5c46291ff6aab23acad902a0b39eae84

XMPP IoT node cleanup and refactoring

view details

Fabian Sauter

commit sha f1978d9a49303f153c89b2fdb9a98fd941dbcd39

Updated the basic node definition

view details

Fabian Sauter

commit sha ce075f450c4d0df28e95b6a6883d652098cfabe9

Started adding the XMPP message architecture

view details

push time in 17 days

pull request commentls1intum/Artemis

Updated and fixed the C template

I think, I will set up a new one so once both diverge it is easier to maintain both.

COM8

comment created time in 17 days

push eventls1intum/Artemis

Tobias Priesching

commit sha 736461004b73ecbd49bf3356f5f08dc436901cd3

Update apollon version to version 2.2.5 (#2168)

view details

dependabot[bot]

commit sha 607dfd7d2e706925963bc1fbb499faa5cbf8e424

Bump junit in /src/main/resources/templates/java/test/projectTemplate (#2196)

view details

Stefan Klöss-Schuster

commit sha 453f1a81c37d40f0ab964956697f9e8648d28064

Bump versions of dependencies in Java programming exercises pom.xml (#2190)

view details

Stefan Klöss-Schuster

commit sha 68e37c4c10d9eb604711e530202b4699239203ac

Truncate build logs (#2184)

view details

Lukas Franke

commit sha 0a9fce9cbdd45116cd4efad69bf581e3a8ca3577

Fix end of line warnings of prettier during client building (#2194)

view details

Stephan Krusche

commit sha a1260b329eea16ef3c2b88a90b9b1bf9f9cfce09

fix warning

view details

Christian Femers

commit sha e2f3c1e5f354f86c9cc574c8d2c1e2de0f787ce1

Support Petri Nets and Syntax Trees (#2179)

view details

Alexander von Trostorff

commit sha 24ceb1b3ec17b2d85f790c71b7cd5c949016c59a

Correct formatting in registration docs (#2198)

view details

Christian Femers

commit sha 5f74de05781efa86b15d28bb89bf02cf0b854bf6

Add Edit, Participations and Grading Buttons to Exercise Details Page (#2185)

view details

Fabian Sauter

commit sha 7231718d37ae1e90f9a1209fc3995b655ae6ee61

Merge branch 'develop' into feature/programming-exercise/c-template

view details

push time in 17 days

push eventls1intum/Artemis

Andi Turdiu

commit sha dc3640ea84d79bd00ed1e66e39b4612db82b5407

Implement same fix to flaky test as in #2166 (#2173)

view details

Stephan Krusche

commit sha e2e7a03f74e70e57a5f42f82b63f406acb376f9c

bump version

view details

Stephan Krusche

commit sha 48a81367f107824e04ba674aa6527c17f9723c21

improve code documentation of BitbucketBambooUpdateService

view details

Stefan Waldhauser

commit sha bff354e7d1430d47df8536522dd537a6600ea50b

Fix for problem of not being able to put line breaks into problem statement (#2181)

view details

Steffen Becker

commit sha bcff8f709d0f66f3bd93e9f03b987f0111f864dd

Fixed gradle docker target (#2183)

view details

René Lalla

commit sha 72a79dfcaa482c992ac7b05e232ef62ce933f0d3

Improve test coverage BambooService (#2187)

view details

Kilian Schulte

commit sha 188e83b7933fac1ba68be5570712922f05af7528

Improve Client Test Coverage (#2081)

view details

Stefan Klöss-Schuster

commit sha 31fec8f56fcea75844a0ab0718781e91f5d62aca

Document Bamboo token usage (#2182)

view details

Jonas Petry

commit sha c36391acdb76b6faf1fc380052ee6b1897402f33

Add rating to file upload exercise (#2186)

view details

Christian Femers

commit sha 9dc0d4fca55c39d2c5da47d212736f44eb23aa4b

Use Text Blocks in Test Code (#2122)

view details

Fabian Sauter

commit sha 9696c0829e172b18873c816fafd17a37102728b7

Merge branch 'develop' into feature/programming-exercise/c-template

view details

push time in 18 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha e6079be01f4e3d26a0d697bf86c4a9aaf4f4fe43

Updated NuGet Packages

view details

Fabian Sauter

commit sha 393c8958e65ec7b16933816c5b8b4ea317019c60

Fixed IconButtonControl background

view details

Fabian Sauter

commit sha 9ad10fbffc3a74005eb1177230e1d8db427e67b1

Fixed account presence not loading from DB #139

view details

Fabian Sauter

commit sha 2d76bac0d1aeeaccdbb53c7704ebbc8ea48b9f6f

Added XEP-0359: Unique and Stable Stanza IDs support * As a first part for adding MAM support #139

view details

Fabian Sauter

commit sha 13ee5d67c76b4c29d3d4077c350014f54426df8f

Basic XEP-0313: Message Archive Management support #139

view details

push time in 22 days

issue commentwhoshuu/cpr

cpr-config.cmake for find_package

OK. Perhaps @KingKili has some time later this month to sort this out. If not, I will try to read in it a fix it.

yairBAR-caja

comment created time in 22 days

push eventls1intum/Artemis

Fabian Sauter

commit sha 802351944e67ddad5a68672529050e9035da1212

Fixed shadow variables

view details

push time in 23 days

push eventls1intum/Artemis

Fabian Sauter

commit sha 0e90da958f2d88f69332305bb7233c492ac8976a

Updated to the latest readScriptTasksFromTemplate signature

view details

push time in 23 days

push eventls1intum/Artemis

Stephan Krusche

commit sha ac2b13b834e8a680d348e30682a7a59944fa26a9

fix an edge case for a logic issue with test case changed that also led to a flaky test

view details

Stephan Krusche

commit sha 6d923d9c414acd4f0caee2fcbcf064605547c599

imnprove logging in case reporting a new result to LTI consumer fails

view details

Stephan Krusche

commit sha 0a5be3532df12c334941578ecdb2d821daf0419b

small code improvements

view details

Stephan Krusche

commit sha 4741cb5616ef0731adaeb138af04e49915217db2

update required node version to 14.0.0

view details

Lukas Franke

commit sha dfe1e75216af63ad77720ac27c5819deeb1d8abf

Trim solutions and answers when correcting a Short Answer Quiz (#2149)

view details

Christian Femers

commit sha 1a170878e8035a043b61ef473ee558af541f3d8a

Replace Adding Empty Strings by String.valueOf (#2161)

view details

Tobias Priesching

commit sha d1c97e17ffb4f5c7b7fc975b91abd09cc8c011f2

bugfixes modeling editor + quiz exercises (#2151)

view details

Stefan Waldhauser

commit sha 0d4bdc4de2118e8d3545b85bfa8398d36495cf6a

Change Instruction Component for File Upload Exercises (#2144)

view details

Christian Femers

commit sha 096066d12b9ddd004db89f93ddad199b1c2f0bc7

Add Dynamic Tests for the Artemis Domain Classes (#2155)

view details

Stephan Krusche

commit sha 46faf824d1645ac34d9df19216b4cdad9f7c8da0

improve LTI documenation in Artemis user interface

view details

Jonas Petry

commit sha d43b95f5e290e4ba3ad94d46137154be9cb4caea

Instructor rating dashboard (#2066)

view details

Philipp Bauch

commit sha dbab86468df588426a62c1d78bf9108eca229657

Use JPlag for text exercises plagiarism detection (#2159)

view details

Wenjie HOU

commit sha 3a0415ceef22d991a6eaf81985d9d39bf243df7f

Allow instructors to set bonus points for exercises (#2069)

view details

Simon Leiß

commit sha af313339277555b964f5d5cdddad1c1f6fad75e9

Sync feature toggle using Hazelcast map. (#2109)

view details

Andi Turdiu

commit sha 803086fa8ee16667be1e6dc55303004cd0da09e1

Fix flaky test DeleteTestRunAsTutor (#2166)

view details

Kilian Schulte

commit sha b70cffe8c5f0114f190a6d644ba5b68e590b9f73

Grading with Static Code Analysis (#2107)

view details

Francisco De las Casas Young

commit sha f8f19039c3204b59d5298659082769fadbd79030

Properly use assessment due date for programming exercises (#2137)

view details

Stephan Krusche

commit sha 97dee1efcf698092472844c17deb6b3a726b81cb

fix translation Max Score -> Points

view details

Stephan Krusche

commit sha 0492b31d53f4ace0248487404f53965a275703e7

bump version for next release

view details

Alexander von Trostorff

commit sha 12f0bbce1a17f7b2d59864e01eb911954df4a386

Update jenkins-gitlab.rst (#2154)

view details

push time in 23 days

push eventls1intum/Artemis

Fabian Sauter

commit sha 229ca54f0365242bc11d584ea5ff0273a3d0c422

Fixed C-Test assignment path

view details

push time in 23 days

issue commentUWPX/UWPX-Client

Problems using the client with own ejabberd server

Ah, this might be the issue for that. I have a look at it shortly.

dasbenjo

comment created time in 23 days

issue commentwhoshuu/cpr

cpr-config.cmake

If so, would you like to create a PR with your changes for the find_package() configuration?

yairBAR-caja

comment created time in 23 days

issue commentwhoshuu/cpr

cpr-config.cmake

fetch_content() should be way to go.

The situation with find_package() is complicated right now. I don't think it's working right now. @KingKili was playing around with it a bit but like I remember it never actually worked. Also there was a PR aiming to introduce this to CPR but it stalled (#374).

Do you know more about the inner workings of find_package() and how to configure it correctly?

yairBAR-caja

comment created time in 23 days

push eventCOM8/esp32-jura

Fabian Sauter

commit sha 0b978da05ba0f7a4462fc9e6674515c2a82f28f8

Added a snooping resutl for keep alive messages

view details

Fabian Sauter

commit sha 2a17cd8cb60da9827e153b4d59409b2e4cd15f41

Refined the coffee brewing sequence

view details

Fabian Sauter

commit sha f774051091d1c8df56dd65476bfad93848b724ff

Support for making custom coffee

view details

push time in 24 days

push eventUWPX/UWPX-Client

Fabian Sauter

commit sha 808ba946f02432d345ee51583ee61d7871c020d2

Added Windows for IoT as target * https://docs.microsoft.com/en-us/windows/iot-core/develop-your-app/buildingappsforiotcore * https://docs.microsoft.com/en-us/windows/iot-core/develop-your-app/appdeployment

view details

push time in 25 days

pull request commentls1intum/Artemis

Updated and fixed the C template

@krusche Yes, thanks!

COM8

comment created time in a month

issue commentwhoshuu/cpr

SSL certificate problem

Ok. Thanks for testing. I guess I cant get around to setting up a pure Arch VM :)

xiao-huangren

comment created time in a month

push eventls1intum/Artemis

Philipp Bauch

commit sha 983eb2d128940875c7c28cb72280a6e2330088b9

Fix split.js linting issue (#2153)

view details

Christian Femers

commit sha 44a27afa7a715f1d835546f1ef39e5d924f5c26d

Fix the Quiz Exercise Re-evaluate Integration Test (#2152) Also remove lots of duplicated Java server Code in domain classes

view details

Stephan Krusche

commit sha c305fd4e444840861b4ef54fca492e176d84b32b

prevent issues in StudentExamIntegrationTest due to delete call in after each that might fail

view details

Stephan Krusche

commit sha 052ff97b20f2689feb4434a1062dbb3fe5a03f53

increase test coverage of domain classes and remove unused code

view details

Fabian Sauter

commit sha 27755331a84a6aad8879a3b7ab76ab117a522870

Merge branch 'develop' into feature/programming-exercise/c-template

view details

push time in a month

pull request commentls1intum/Artemis

Updated and fixed the C template

Looks like I do not have permissions to see why the Java tests fail.

COM8

comment created time in a month

pull request commentls1intum/Artemis

[WIP] Updated and fixed the C template

Closed in favour of #2150.

COM8

comment created time in a month

PR opened ls1intum/Artemis

Updated and fixed the C template

<!-- Thanks for contributing to Artemis! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> <!-- If your pull request is not ready for review yet, create a draft pull request! -->

Checklist

  • [ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
  • [ ] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
  • [ ] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
  • [ ] Server: I implemented the changes with a good performance and prevented too many database calls
  • [ ] Server: I documented the Java code using JavaDoc style.
  • [ ] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
  • [ ] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
  • [ ] Client: I documented the TypeScript code using JSDoc style.
  • [ ] Client: I added multiple screenshots/screencasts of my UI changes
  • [ ] Client: I translated all the newly inserted strings into German and English

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> The C template was using a quite outdated version of the tester and had some flaws related to potential vulnerabilities.

Description

<!-- Describe your changes in detail --> I've updated the C template to fix those vulnerabilities and fixed those tests.

One thing I need feedback about: I changed the docker image to our internal one. Perhaps there should be an internal c docker image besides the python one. https://github.com/ls1intum/Artemis/blob/25ff88d5c909baafcbe91fb1df2c24e99fab7944/src/main/java/de/tum/in/www1/artemis/service/connectors/bamboo/BambooBuildPlanService.java#L179

Steps for Testing

<!-- Please describe in detail how the reviewer can test your changes. -->

  1. Create a new C exercises
  2. The solution should build successfully
+82 -47

0 comment

12 changed files

pr created time in a month

create barnchls1intum/Artemis

branch : feature/programming-exercise/c-template

created branch time in a month

PR closed ls1intum/Artemis

Reviewers
[WIP] Updated and fixed the C template server

<!-- Thanks for contributing to Artemis! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> <!-- If your pull request is not ready for review yet, create a draft pull request! -->

Checklist

  • [ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
  • [ ] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
  • [ ] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
  • [ ] Server: I implemented the changes with a good performance and prevented too many database calls
  • [ ] Server: I documented the Java code using JavaDoc style.
  • [ ] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
  • [ ] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
  • [ ] Client: I documented the TypeScript code using JSDoc style.
  • [ ] Client: I added multiple screenshots/screencasts of my UI changes
  • [ ] Client: I translated all the newly inserted strings into German and English

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> The C template was using a quite outdated version of the tester and had some flaws related to potential vulnerabilities.

Description

<!-- Describe your changes in detail --> I've updated the C template to fix those vulnerabilities and fixed those tests.

Steps for Testing

<!-- Please describe in detail how the reviewer can test your changes. -->

  1. Create a new C exercises
  2. The solution should build successfully
+82 -47

5 comments

12 changed files

COM8

pr closed time in a month

more