profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/BuoyantIO/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Buoyant BuoyantIO San Francisco, CA, USA https://buoyant.io Creators of @Linkerd

BuoyantIO/slow_cooker 280

A load tester focused on lifecycle issues and long-running tests

BuoyantIO/emojivoto 120

Example application to help demonstrate the Linkerd service mesh

BuoyantIO/strest-grpc 78

A load tester for stress testing grpc intermediaries.

BuoyantIO/bb 20

A tool to simulate many of the typical scenarios of cloud-native microservices.

BuoyantIO/finagle 12

A fault tolerant, protocol-agnostic RPC system

BuoyantIO/booksapp 11

Sample distributed Ruby app using Sinatra, ActiveRecord, and ActiveResource.

BuoyantIO/http-max-rps 9

A tool for finding the max RPS of an HTTP server or intermediary.

BuoyantIO/flossy 6

a tool for testing standard compliance of HTTP proxies

BuoyantIO/kubectl 5

Kubectl in a scratch Docker image.

BuoyantIO/linkerd-buoyant 5

Linkerd Buoyant extension

pull request commentBuoyantIO/emojivoto

Pin protoc to recent version

I get the same warnings that @olix0r mentioned on both macOS and linux (PopOS). In addition make test fails with these messages

go test ./...
cmd/server.go:8:2: found packages proto (Emoji.pb.go) and _ (Emoji_grpc.pb.go) in /home/pineapple/projects/buoyant/emojivoto/emojivoto-web/gen/proto
cmd/server.go:8:2: found packages proto (Emoji.pb.go) and _ (Emoji_grpc.pb.go) in /home/pineapple/projects/buoyant/emojivoto/emojivoto-web/gen/proto

I suspect that there is something in my go env that is different, any thoughts on what I should look for?

adleong

comment created time in 4 days

pull request commentBuoyantIO/emojivoto

Pin protoc to recent version

Weird, I don't get those warnings when I run make build or when running protoc directly:

 > ../bin/protoc --version && ../bin/protoc -I .. ../proto/*.proto --go_out=gen --go-grpc_out=gen
libprotoc 3.18.0
adleong

comment created time in 4 days

push eventBuoyantIO/emojivoto

Alex Leong

commit sha b51ac25f36ffce2798c2ce3bc9dd02399cefb69b

Allow protoc command to be overriden Signed-off-by: Alex Leong <alex@buoyant.io>

view details

push time in 4 days

issue commentBuoyantIO/emojivoto

"404" page is actually a 500

Yes, I think that makes sense.

wmorgan

comment created time in 4 days

pull request commentBuoyantIO/emojivoto

Pin protoc to recent version

@adleong I get several warnings running make build:

/nix/store/kwx008ysylw3mkskk8218p9g7rfgpcad-protobuf-3.18.0/bin/protoc -I .. ../proto/*.proto --go_out=gen --go-grpc_out=gen
2021/10/20 19:30:59 WARNING: Malformed 'go_package' option in "proto/Emoji.proto", please specify:
        option go_package = "proto/;_";
A future release of protoc-gen-go will reject this.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

2021/10/20 19:30:59 WARNING: Malformed 'go_package' option in "proto/Voting.proto", please specify:
        option go_package = "proto/;_";
A future release of protoc-gen-go will reject this.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

2021/10/20 19:30:59 WARNING: Malformed 'go_package' option in "proto/Emoji.proto", please specify:
        option go_package = "proto/;_";
A future release of protoc-gen-go will reject this.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

2021/10/20 19:30:59 WARNING: Malformed 'go_package' option in "proto/Voting.proto", please specify:
        option go_package = "proto/;_";
A future release of protoc-gen-go will reject this.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

2021/10/20 19:30:59 WARNING: Malformed 'go_package' option in "proto/Emoji.proto", please specify:
        option go_package = "proto/;_";
A future release of protoc-gen-go will reject this.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

2021/10/20 19:30:59 WARNING: Malformed 'go_package' option in "proto/Voting.proto", please specify:
        option go_package = "proto/;_";
A future release of protoc-gen-go will reject this.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

Also, I'd still like to get an option to override the protoc binary https://github.com/BuoyantIO/emojivoto/pull/119#discussion_r725157536

adleong

comment created time in 5 days

issue commentBuoyantIO/emojivoto

"404" page is actually a 500

Presumably this is because linkerd only counts 5xx as failures. Should we just remove the 404 text to say "an error has occurred"?

wmorgan

comment created time in 5 days

issue openedBuoyantIO/emojivoto

"404" page is actually a 500

The failure page (e.g. when donut is clicked) has the text "404" in it, but this is actually a 500 response.

created time in 5 days

delete branch BuoyantIO/linkerd-buoyant

delete branch : siggy/slack-link

delete time in 5 days

push eventBuoyantIO/linkerd-buoyant

Andrew Seigner

commit sha 555dea8a78ee32773de4f19d6142bb7b93e0864c

Provide a link to the #buoyant-cloud Slack (#36) On `linkerd-buoyant install`, print a message to stderr pointing the user to the #buoyant-cloud Slack channel. ``` linkerd-buoyant install ... Agent manifest available at: https://buoyant.cloud/agent/buoyant-cloud-k8s-foo.yml Need help? Message us in the #buoyant-cloud Slack channel: https://linkerd.slack.com/archives/C01QSTM20BY ``` Signed-off-by: Andrew Seigner <siggy@buoyant.io>

view details

push time in 5 days

PR merged BuoyantIO/linkerd-buoyant

Provide a link to the #buoyant-cloud Slack

On linkerd-buoyant install, print a message to stderr pointing the user to the #buoyant-cloud Slack channel.

linkerd-buoyant install
...
Agent manifest available at:
https://buoyant.cloud/agent/buoyant-cloud-k8s-foo.yml

Need help? Message us in the #buoyant-cloud Slack channel:
https://linkerd.slack.com/archives/C01QSTM20BY

Signed-off-by: Andrew Seigner siggy@buoyant.io

+2 -0

0 comment

1 changed file

siggy

pr closed time in 5 days

PullRequestReviewEvent

Pull request review commentBuoyantIO/linkerd-buoyant

Provide a link to the #buoyant-cloud Slack

 func install(ctx context.Context, cfg *config, client k8s.Client, openURL openUR  	fmt.Fprintf(cfg.stderr, "Agent manifest available at:\n%s\n\n", agentURL) +	fmt.Fprint(cfg.stderr, "Need help? Message us in the #buoyant-cloud Slack channel:\nhttps://linkerd.slack.com/archives/C01QSTM20BY\n\n")

We use stdout to output the agent manifest, for doing linkerd buoyant install | kubectl apply -f -, everything else needs to go in stderr.

siggy

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentBuoyantIO/linkerd-buoyant

Provide a link to the #buoyant-cloud Slack

 func install(ctx context.Context, cfg *config, client k8s.Client, openURL openUR  	fmt.Fprintf(cfg.stderr, "Agent manifest available at:\n%s\n\n", agentURL) +	fmt.Fprint(cfg.stderr, "Need help? Message us in the #buoyant-cloud Slack channel:\nhttps://linkerd.slack.com/archives/C01QSTM20BY\n\n")

Just wondering, what is the reason to print to stderr instead of stdout

siggy

comment created time in 5 days

PullRequestReviewEvent

PR opened BuoyantIO/linkerd-buoyant

Reviewers
Provide a link to the #buoyant-cloud Slack

On linkerd-buoyant install, print a message to stderr pointing the user to the #buoyant-cloud Slack channel.

linkerd-buoyant install
...
Agent manifest available at:
https://buoyant.cloud/agent/buoyant-cloud-k8s-foo.yml

Need help? Message us in the #buoyant-cloud Slack channel:
https://linkerd.slack.com/archives/C01QSTM20BY

Signed-off-by: Andrew Seigner siggy@buoyant.io

+2 -0

0 comment

1 changed file

pr created time in 5 days

push eventBuoyantIO/linkerd-buoyant

Andrew Seigner

commit sha 8ff0af1d6d6fabc3f1739c20def52aff44fb98b0

Provide a link to the #buoyant-cloud Slack On `linkerd-buoyant install`, print a message to stderr pointing the user to the #buoyant-cloud Slack channel. ``` linkerd-buoyant install ... Agent manifest available at: https://buoyant.cloud/agent/buoyant-cloud-k8s-foo.yml Need help? Message us in the #buoyant-cloud Slack channel: https://linkerd.slack.com/archives/C01QSTM20BY ``` Signed-off-by: Andrew Seigner <siggy@buoyant.io>

view details

push time in 5 days

create barnchBuoyantIO/linkerd-buoyant

branch : siggy/slack-link

created branch time in 5 days

push eventBuoyantIO/emojivoto

Alex Leong

commit sha 2fe894f5942eb1d9a09a5edc91035567104e9443

Require protoc-gen-go v1.27.1 Signed-off-by: Alex Leong <alex@buoyant.io>

view details

push time in 5 days

fork felipecruz91/emojivoto

Example application to help demonstrate the Linkerd service mesh

fork in 7 days

startedBuoyantIO/emojivoto

started time in 8 days

PR closed BuoyantIO/emojivoto

Datadog logging
+190 -32

0 comment

12 changed files

Ri-go

pr closed time in 13 days

PR opened BuoyantIO/emojivoto

Datadog logging
+190 -32

0 comment

12 changed files

pr created time in 13 days

fork Ri-go/emojivoto

Example application to help demonstrate the Linkerd service mesh

fork in 13 days

pull request commentBuoyantIO/emojivoto

Pin protoc to recent version

:; protoc-gen-go --version
protoc-gen-go v1.27.1
adleong

comment created time in 17 days

pull request commentBuoyantIO/emojivoto

Pin protoc to recent version

I get the following error:

:; protoc --version && make build
libprotoc 3.18.0
make -C emojivoto-web
make[1]: Entering directory '/home/ver/b/emojivoto/emojivoto-web'
rm -rf gen
rm -rf target
mkdir -p target
mkdir -p gen
/nix/store/xz364k6ybkxa3aparji50dnhxcrg4s03-protobuf-3.18.0/bin/protoc -I .. ../proto/*.proto --go_out=plugins=grpc:gen
--go_out: protoc-gen-go: plugins are not supported; use 'protoc --go-grpc_out=...' to generate gRPC

See https://grpc.io/docs/languages/go/quickstart/#regenerate-grpc-code for more information.
make[1]: *** [../common.mk:16: protoc] Error 1
make[1]: Leaving directory '/home/ver/b/emojivoto/emojivoto-web'
make: *** [Makefile:11: web] Error 2
adleong

comment created time in 17 days

PullRequestReviewEvent

Pull request review commentBuoyantIO/emojivoto

Pin protoc to recent version

 clean: 	mkdir -p gen  protoc:-	protoc -I .. ../proto/*.proto --go_out=plugins=grpc:gen+	../bin/protoc -I .. ../proto/*.proto --go_out=plugins=grpc:gen

Can we update this to support an override like:

+PROTOC ?= ../bin/protoc
+
 protoc:
-       ../bin/protoc -I .. ../proto/*.proto --go_out=plugins=grpc:gen
+       $(PROTOC) -I .. ../proto/*.proto --go_out=plugins=grpc:gen

(on my weird Linux system I can't use a dynamically linked binary without patching it...)

adleong

comment created time in 17 days

startedBuoyantIO/emojivoto

started time in 17 days

startedBuoyantIO/emojivoto

started time in 20 days