profile
viewpoint
Bart van der Schoor Bartvaderkin Maykin Media Amsterdam

Bartvaderkin/django-csp-reports 0

Django app for handling browser reports from Content Security Policy violations

Bartvaderkin/gemma-zaaktypecatalogus 0

Referentie implementatie van een Zaaktypecatalogus (ZTC)

Bartvaderkin/open-zaak 0

Open Zaak is a modern, open-source data- and services-layer to enable zaakgericht werken, a Dutch approach to case management.

maykinmedia/django-sitetree 0

Reusable application for Django introducing site tree, menu and breadcrumbs navigation elements.

issue commentopen-formulieren/open-forms

Toevoegen bijlage werkt niet meer (in Chrome)

  • [ ] Taiga 126 (original breakage) fixed (1-3)
  • [ ] Taiga 216 (copy of original breakage) fixed (1-3)
  • [ ] Taiga 215 (file type filter) fixed (FIX 1)
  • [ ] Taiga 232 (i.map JS error) (FIX 3)
  • [ ] Taiga 192 (file size)
alextreme

comment created time in 6 days

create barnchopen-formulieren/open-forms-sdk

branch : fix/1174-numberlocalise

created branch time in 6 days

PR opened open-formulieren/open-forms

[#750, #1174] Fixed ordering of FormStep/components in Form.iter_components

Also relates to Submission.get_printable_data() etc.

+40 -6

0 comment

2 changed files

pr created time in 6 days

create barnchopen-formulieren/open-forms

branch : fix/750-1174-component-ordering

created branch time in 6 days

create barnchopen-formulieren/open-forms

branch : fix/1174-number-localisation

created branch time in 7 days

push eventopen-formulieren/open-forms

Bart van der Schoor

commit sha 190c09c065852ddd02a2862d0768dba302dba118

[#1174] Fixed Submission.render_confirmation_page() to not sanitize URLs

view details

push time in 7 days

create barnchopen-formulieren/open-forms

branch : fix/1174-demo-fixes

created branch time in 7 days

create barnchopen-formulieren/open-forms-sdk

branch : fix/1018-wcag

created branch time in 7 days

create barnchopen-formulieren/open-forms

branch : fix/1018-wcag

created branch time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventopen-formulieren/open-forms-sdk

Bart van der Schoor

commit sha efb892ff781b910863b79bc2e03b7afe27c56b11

[open-formulieren/open-forms#877] Fixed 'i.map is not a function' JS error in summary display of file uploads

view details

push time in 7 days

push eventopen-formulieren/open-forms

Bart van der Schoor

commit sha 80bcd57c13c2b60d42b7de9dc915ea73f6709268

[#1126] Added optional payment update email recipients to email registration backend

view details

Bart van der Schoor

commit sha 2eed0dc7ce8d1481d2757112091ca27943c8c5b6

[#1126] Modified email registration backend to send full registration content in payment update

view details

Sergei Maertens

commit sha a67440c76ddbc7756534fecd19739dc99d9dbe69

:alembic: Fix debug page

view details

Sergei Maertens

commit sha e06ab7ba46dfadc0ea9e3b03f8c24638a898d762

:sparkles: [#326] -- define interpolate as possible variable source Specific case, in the future this will probably be replaced with a generic json-logic expression source type.

view details

Sergei Maertens

commit sha 85ee12d4eccd751019996387ab5c7fffb9d3ce07

:globe_with_meridians: [#326] -- update translations

view details

Sergei Maertens

commit sha d71c2bdf9ff01d6b63d57921fe7b55bce37abeea

:sparkles: [#326] -- implement interpolation source in the backend

view details

Joeri Bekker

commit sha bf0ff2982d1e96f29fafc284d543fdbe5f6db306

:memo: Added template examples.

view details

Bart van der Schoor

commit sha 2a679f4a43cc9e52c6ecf31a97f464bcf9eaf82c

[#1080] Enabled links and matched settings in TinyMCE widgets of React and Django

view details

Bart van der Schoor

commit sha c39aced08f941d1e4977f34f2ad52237e8d22325

[#1080] Created URLSanitationValidator to validate template URLs

view details

Bart van der Schoor

commit sha 886438e16abd1c720fea608a6d66c9d8eaf8247f

[#1080] Applied URLSanitationValidator to ConfirmationEmailTemplate and GlobalConfiguration

view details

Bart van der Schoor

commit sha 1da690c1fe863404ed15af1aa80ae93fa05a02d8

[#1080] Added missing DjangoTemplateValidator template-tag configuration to GlobalConfiguration.confirmation_email_content

view details

Bart van der Schoor

commit sha 9ea0b6edaf26f7582937d81fa0a5d9e653c0dc21

[#1080] Share TinyMCE configuration between React and Django

view details

Bart van der Schoor

commit sha efdca5d83b2a4e458364b350bdb9a8292b8213d9

[#1080] Modified React TinyMCE to dynamically set language

view details

Bart van der Schoor

commit sha 0e74a95b03342898603386d64dfb9fe011231bd1

[#1080] Create missing migrations for validators (and tuned validator)

view details

Bart van der Schoor

commit sha b444ea278fb8c1f5bd2f3a4854bbe26eddc635b2

[#936] Added 'exception-demo' registration plugin that raises an Exception (instead of RegistrationFailed like 'failing-demo')

view details

Sergei Maertens

commit sha dd1daa3411481a59fed3a5f0e7326557352c0129

:sparkles: [#1155] -- expose session expiry in response header

view details

Sergei Maertens

commit sha ea0f0eca2b3a03d749b0084591bfb19577db4dbf

:pencil: [#1155] -- set up schema post-processor for middleware headers The post-processor ensures that every defined response in the schema includes the headers set on the response by middleware.

view details

Sergei Maertens

commit sha ca18e6c8a101dc86246bd29527116ea64ce740bd

:wrench: [#1155] -- ensure the X-Session-Expires-In is exposed to CORS requests The SDK (in embedded formmust be able to read this response header.

view details

Sergei Maertens

commit sha df36701bf71ee0511955d30fa1c940c090c41cc5

:white_check_mark: Add test for schema generation with custom hooks

view details

Sergei Maertens

commit sha 8cfd3a2e28cf88727e8b0b0df27dfa74ae88e187

Merge pull request #1157 from open-formulieren/docs/template-example Added template examples.

view details

push time in 7 days

PullRequestReviewEvent

Pull request review commentopen-formulieren/open-forms

[#877] Moved custom component properties into 'of' namespace, added comments

+# Generated by Django 2.2.26 on 2022-01-12 09:30++from django.db import migrations+++def forwards_func(apps, schema_editor):+    FormDefinition = apps.get_model("forms", "FormDefinition")+    for fd in FormDefinition.objects.all():+        changed = recursive_fix(fd.configuration)+        if changed:+            fd.save()+            print(f"updated of.image for {fd}")+++def recursive_fix(component):+    changed = False+    if component.get("type") == "file":+        image = component.get("image")+        of_ns = component.get("of")+        if not of_ns and isinstance(image, dict):+            # we move the 'image' dict a level deeper into 'of' prefix+            component["of"] = {"image": image}+            # set the original 'image' property+            component["image"] = False+            changed = True++    components = component.get("components", [])+    for component in components:+        changed = recursive_fix(component) or changed++    columns = component.get("columns", [])+    for column in columns:+        components = column.get("components", [])+        for component in components:+            changed = recursive_fix(component) or changed

Cool, I updated the PR with iter_components()

Bartvaderkin

comment created time in 7 days

push eventopen-formulieren/open-forms

Bart van der Schoor

commit sha 28a7a22f374f421e6263352116e38a5dc5c02360

[#877] Added data migration to move file/image component properties into 'of' namespace

view details

push time in 7 days

push eventopen-formulieren/open-forms

Bart van der Schoor

commit sha 25da553144660bfd7540f47f67262481d10c4250

[#877] Added data migration to move file/image component properties into 'of' namespace

view details

push time in 7 days

pull request commentopen-formulieren/open-forms

[#877] Moved custom component properties into 'of' namespace, added comments

  • [ ] After we discussed some issues and still pursue this we still need to add a migration for existing forms.
Bartvaderkin

comment created time in 12 days

issue commentopen-formulieren/open-forms

BSN field only validates when 9 numbers are entered

I implemented the fix but note this will now start invalidating as soon as you type the first digit.

joeribekker

comment created time in 12 days

pull request commentopen-formulieren/open-forms-sdk

[#1162] Fixed BSN field validator validating everything not 9 chars long

Note this will now start invalidating as soon as you type the first digit.

Bartvaderkin

comment created time in 12 days

create barnchopen-formulieren/open-forms-sdk

branch : fix/#1162-bsn-validate-9-chars

created branch time in 12 days

PR opened open-formulieren/open-forms

[#1163] Swapped e-herkenning auth logo for (more) square format

The previous logo was very wide and made a mess of the button row.

+1 -31

0 comment

3 changed files

pr created time in 12 days

more