profile
viewpoint
Maximilian Wilhelm BarbarossaTM Paderborn, Germany https://blog.sdn.clinic

BarbarossaTM/icinga2-plugins 9

Icinga2 plugins and command definitions

BarbarossaTM/nacl 5

Netbox Automation and Caching Layer (for FFHO Salt)

BarbarossaTM/netbox-scripts 2

Netbox Scripts

BarbarossaTM/alff 1

A Linux Firewall Framework (with cats)

BarbarossaTM/anycast_healthchecker 1

A healthchecker for Anycasted services

BarbarossaTM/edi 1

Hackerspace automation construction kit

BarbarossaTM/ffho-salt-public 1

Salt-Orchestrated OpenSource based Software-Defined-Freifunk-Infrastructre-Network configuration :)

startedekanite/ekanite

started time in 2 hours

startednetmap-unipi/netmap

started time in 2 days

startedluigirizzo/netmap

started time in 2 days

push eventCumulusNetworks/ifupdown2

Markus Hauschild

commit sha 1d9a8d4f6b8be80db45a97f35bd2f790a3485f2f

addons: batman_adv: cleanup according to PEP8 Signed-off-by: Markus Hauschild <markus@moepman.eu>

view details

Markus Hauschild

commit sha 9436b6cb7a1bc1bde4dba67294261f39d8b5de1b

addons: batman_adv: fix unresolved reference Signed-off-by: Markus Hauschild <markus@moepman.eu>

view details

Markus Hauschild

commit sha 1dc2c4a7c284ccf7545f9d6be8392aaf7e81e399

addons: batman_adv: improve readability Signed-off-by: Markus Hauschild <markus@moepman.eu>

view details

Markus Hauschild

commit sha 344a97e31d01deb07b5c7ef08e6132b3fc9d62e7

addons: batman_adv: fix netlink call as suggested by @julienfortin in PR comment Signed-off-by: Markus Hauschild <markus@moepman.eu>

view details

Markus Hauschild

commit sha 7db69c5b3cd7d9fac1601b9f56167e6356f7cf5e

addons: batman_adv: drop unnecessary exception clause The exception could have never come from read_file_oneline, also value was an undefined variable, so it would have thrown an exception while handling an exception thus being useless anyway. Signed-off-by: Markus Hauschild <markus@moepman.eu>

view details

Julien Fortin

commit sha 0305c4125feb02c36c7c165222f36f943a98bca6

Merge pull request #185 from moepman/cleanup-batman-adv Cleanup batman adv

view details

push time in 2 days

PR merged CumulusNetworks/ifupdown2

Reviewers
Cleanup batman adv

Trying to cleanup batman_adv:

  • Reformatting code according to PEP8 - it overflows with superfuous whitespace and indentation that is not a multiple of four
  • Fixed unresolved reference netlink
+105 -112

1 comment

1 changed file

moepman

pr closed time in 2 days

startedytdl-org/youtube-dl

started time in 3 days

pull request commentCumulusNetworks/ifupdown2

addons: vxlan: add vxlan-local-tunnelip6

What sadly seems to now work is the following: vxlan-local-tunnelip6 fe80::31%wg-test

Not sure if that is a problem with IPv6 LL addresses in general, or this PR but I tried escaping it in different ways - always tries to interpret as mako.

moepman

comment created time in 3 days

pull request commentCumulusNetworks/ifupdown2

Cleanup batman adv

@julienfortin did you have a look at the new version?

moepman

comment created time in 3 days

startedjuribeparada/Pi-Star_Binaries_sbin

started time in 3 days

startedjjgrinwis/nso-services

started time in 4 days

startedqemu/qemu-web

started time in 5 days

startedmajek/openonload

started time in 5 days

startediovisor/bpf-docs

started time in 5 days

startedNetTLP/simple-nic

started time in 5 days

startedNetTLP/adapter

started time in 5 days

startedKonradIT/gopro-linux

started time in 5 days

push eventCumulusNetworks/ifupdown2

Alexander Petrovskiy

commit sha 1b845b1babc7775e414b7cba41b7ae47f3965d84

addons: bridge: add support for "bridge_always_up_dummy_brport" policy User may want to have persistent name of dummy port if "bridge-always-up" option is enabled. Now the name can be defined in "bridge_always_up_dummy_brport" policy for bridge module. Signed-off-by: Alexander Petrovskiy <alexpe@nvidia.com>

view details

Julien Fortin

commit sha cd67f88f8ffefcfe8e7b44f7d85521f2bf0f4f3a

Merge pull request #186 from kvadrage/switchdev-fixes addons: bridge: add support for "bridge_always_up_dummy_brport" policy

view details

push time in 5 days

PR merged CumulusNetworks/ifupdown2

addons: bridge: add support for "bridge_always_up_dummy_brport" policy

User may want to have persistent name of dummy port if "bridge-always-up" option is enabled. Now the name can be defined in "bridge_always_up_dummy_brport" policy for bridge module.

Signed-off-by: Alexander Petrovskiy alexpe@nvidia.com

+10 -1

0 comment

1 changed file

kvadrage

pr closed time in 5 days

PR opened CumulusNetworks/ifupdown2

addons: bridge: add support for "bridge_always_up_dummy_brport" policy

User may want to have persistent name of dummy port if "bridge-always-up" option is enabled. Now the name can be defined in "bridge_always_up_dummy_brport" policy for bridge module.

Signed-off-by: Alexander Petrovskiy alexpe@nvidia.com

+10 -1

0 comment

1 changed file

pr created time in 6 days

startedpacket-transactions/domino-compiler

started time in 6 days

issue openedifupdown-ng/ifupdown-ng

Further / more precise documentation needed

To write effective and correct tooling around the ifupdown-ng system, more precise documentation about how it interprets the interfaces file is needed.

Some of the behaviours that are undocumented right now include:

  • What happens when netmask isn't specified and a CIDR isn't given in an address? Right now per the source, it seems to just assign /24. Is this a temporary workaround, a compatibility shim that should be ignored, or an intended behaviour? That is, in an ideal state with a new deployment, should an address without a CIDR be considered an error, or should it be considered a /24?

  • Are keys case-sensitive? In Debian ifupdown and ifupdown2, keys appear to be case-sensitive and must be specified in all lowercase. However, when I asked the team on IRC, I received two different answers. This should be formally documented somewhere.

  • How are duplicate keys handled? What happens if you specify multiple netmask? point-to-point? link-type? etc.

These are just a few of the many questions that can be easily answered and solved with adequate documentation.

I would be willing to assist in writing this documentation, if that would help. I have experience writing this type of documentation in many formats (reStructuredText, DocBook, Markdown).

created time in 6 days

startedkovidgoyal/kitty

started time in 6 days

startedsoundcloud/ipmi_exporter

started time in 6 days

push eventifupdown-ng/ifupdown-ng

Ariadne Conill

commit sha 46bb0565fa787e526dec49746eefae0a09ea1b75

multicall: do not call getopt_long() inside the stub applet

view details

Ariadne Conill

commit sha 7911944633560de0f68203d6e9ed3bb45ad33c55

tests: add getopt regression test for multicall stub

view details

Ariadne Conill

commit sha 6730db546881180fcff044909d440eadbaaf269d

Merge pull request #127 from ifupdown-ng/bugfix/multicall-getopt multicall: fix inappropriate use of getopt in the multicall stub

view details

push time in 7 days

issue closedifupdown-ng/ifupdown-ng

Multicall binary doesn't work with program-specific options

awilcox on gwyn [pts/11 Wed 18 14:01] ifupdown-ng: ./ifupdown ifparse -F yaml-raw 
./ifupdown: unrecognized option: F
-F: applet not found
usage: ifupdown <applet> [options]

Built-in applets:
        ifctrstat, ifdown, ifparse, ifquery, ifup, ifupdown
awilcox on gwyn [pts/11 Wed 18 14:01] ifupdown-ng: ./ifupdown ifparse -AF yaml-raw
./ifupdown: unrecognized option: A
ifparse - redisplay interface configuration

Usage:
  ifparse [options] <interfaces>
  ifparse [options] --all

Global options:
  -h, --help                          this help
  -V, --version                       show this program's version

Matching interfaces:
  -a, --auto                          only match against interfaces hinted as 'auto'
  -I, --include PATTERN               only match against interfaces matching PATTERN
  -X, --exclude PATTERN               never match against interfaces matching PATTERN

Execution:
  -f, --force                         force (de)configuration
  -i, --interfaces FILE               use FILE for interface definitions
  -l, --no-lock                       do not use a lockfile to serialize state changes
  -n, --no-act                        do not actually run any commands
  -v, --verbose                       show what commands are being run
  -E, --executor-path PATH            use PATH for executor directory
  -S, --state-file FILE               use FILE for state

Program-specific options:
  -F, --format                        output format to use
  -A, --all                           show all interfaces
  -U, --allow-undefined               allow querying undefined (virtual) interfaces

For more information: man 8 ifparse

It appears that something is reordering argv incorrectly:

This GDB was configured as "powerpc64-foxkit-linux-musl".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ifupdown...
(gdb) set args ifparse -F yaml-raw
(gdb) break main
Breakpoint 1 at 0x408c: file cmd/multicall.c, line 79.
(gdb) break multicall_main
Breakpoint 2 at 0x41e0: file cmd/multicall.c, line 103.
(gdb) run
Starting program: /home/awilcox/Code/ifupdown-ng/ifupdown ifparse -F yaml-raw

Breakpoint 1, main (argc=4, argv=0x3ffffffff3a8) at cmd/multicall.c:79
79              argv0 = basename(argv[0]);
(gdb) p *(argv)
$1 = 0x3ffffffff6ee "/home/awilcox/Code/ifupdown-ng/ifupdown"
(gdb) p *(argv+1)
$2 = 0x3ffffffff716 "ifparse"
(gdb) p *(argv+2)
$3 = 0x3ffffffff71e "-F"
(gdb) p *(argv+3)
$4 = 0x3ffffffff721 "yaml-raw"
(gdb) c
Continuing.
/home/awilcox/Code/ifupdown-ng/ifupdown: unrecognized option: F

Breakpoint 2, multicall_main (argc=4, argv=0x3ffffffff3a8) at cmd/multicall.c:103
103             if (argc < 2)
(gdb) p *(argv)
$5 = 0x3ffffffff6ee "/home/awilcox/Code/ifupdown-ng/ifupdown"
(gdb) p *(argv+1)
$6 = 0x3ffffffff71e "-F"
(gdb) p *(argv+2)
$7 = 0x3ffffffff716 "ifparse"
(gdb) p *(argv+3)
$8 = 0x3ffffffff721 "yaml-raw"

This occurred on ppc64 and x86_64 based Adélie Linux with:

musl-1.2.0-r1 ppc64 {musl} (MIT) [installed]
zsh-5.8-r0 ppc64 {zsh} (Zsh AND BSD-3-Clause AND GPL-2.0+ AND GPL-2.0-only AND Artistic-1.0-Perl AND MIT AND GPL-1.0+) [installed]

closed time in 7 days

awilfox

push eventifupdown-ng/ifupdown-ng

Ariadne Conill

commit sha 7911944633560de0f68203d6e9ed3bb45ad33c55

tests: add getopt regression test for multicall stub

view details

push time in 7 days

create barnchifupdown-ng/ifupdown-ng

branch : bugfix/multicall-getopt

created branch time in 7 days

pull request commentlibrenms-plugins/Weathermap

Added some changes from Rob Collins and make the thing more happy with php 7.4

Seems like after the latest PHP dependency update for LibreNMS, the weathemap plugin is not working anymore. I get "PHP Deprecated: The each() function is deprecated" when cron tries to create the output files using the php command.

I see the merge contains some fixes that should fix this issues I'm having also.

Is it possible to merge them?

xbeaudouin

comment created time in 7 days

more