profile
viewpoint

Aurelius333/grades2 1

Grade calculator: What grade do I need to get on this assignment?

Aurelius333/kotlin-differentiation 0

Symbolic differentiation in Kotlin

Aurelius333/Kotlin-Matrix-Math 0

Matrix Lib with Symbolics and Complex data types

Aurelius333/making-a-pull-request 0

Making a Pull Request on GitHub with GitHub Desktop

Aurelius333/NewtonMethod 0

Estimating derivatives and definite integrals, and using Newton's Method to find zeroes

push eventWalnutProgramming/making-a-pull-request

Aurelius333

commit sha 9747dd5a0426d7b1dc88a498ee0cb69f6d8babfb

Update README.md

view details

push time in 12 hours

issue commentvuejs/docs-next

VuePress build failing (locally or on Netlify)

For me, it works locally with Node 13, but not with Node 14 or Node 12.

My best guess about why it doesn't work in Node 14 was that node-sass 4.13 doesn't support Node 14, but that doesn't explain why it fails in Node 12.

https://github.com/vuejs/docs-next/blob/f6430c07272db705f61d39c584e3307697a3d931/yarn.lock#L5398-L5399

ErickPetru

comment created time in 8 days

push eventAurelius333/vue-docs-next

ajycc20

commit sha 5bbf81d5dad0f69ce3c1a8ccdd2874fca50050b3

fix: fix the `onMounted` hooks (#475) * fix: fix the `onMounted` hooks * fix: remove the first backticks

view details

NataliaTepluhina

commit sha 96499101c150c0e13ecb7d2fb10aedb885bc81a2

fix: fixed slashes on headings

view details

NataliaTepluhina

commit sha 492e356fb6dcaaacff761655e6b24e4e9800bd8b

Merge branch 'master' of github.com:vuejs/docs-next

view details

Joseph Xia

commit sha 6607d8bf43ebb397d425ff43c3825f21ecddf01d

fix: fix instance-methods title miss (#477)

view details

Ben Hong

commit sha 032c9d5a3eeab8f89648f96b23cc3d7ee93c7407

chore: remove beta banner from docs (#474)

view details

Aurelius333

commit sha 31c7d047909dd859545dd18cc98a9ee855d1f737

Migration guide section on key attribute changes (#481) * feat: add migration guide section about "key" attribute changes Fix #379 * undo formatting changes in config.js

view details

awkj

commit sha 91abcd22414463a0699f572bfad1faf6a6d92edc

change document version from char to npm svg file, keep be consistent with vue-next repo (#480)

view details

push time in 12 days

PR opened vuejs/docs-next

Migration guide section on key attribute changes

Description of Problem

This is my attempt to fix #379 (a couple of undocumented breaking changes in Vue 3 related to the key attribute).

Proposed Solution

I think this is technically two separate breaking changes:

  • If you manually provide keys on v-if branches, then each branch must use a unique key.
  • <template v-for> key should be placed on the <template> tag (rather than on its children).

However, I think it's probably best to keep them on the same page because they're related and often appear at the same time. For example, they appear together in this relatively common situation:

<!-- Vue 2.x -->
<template v-for="item in list">
 <div v-if="item.isVisible" :key="item.id">...</div>
 <span v-else :key="item.id">...</span>
</template>

<!-- Vue 3.x -->
<template v-for="item in list" :key="item.id">
 <div v-if="item.isVisible">...</div>
 <span v-else>...</span>
</template>

Additional Information

In my opinion, keys are one of the more confusing parts of Vue. That's why I included a "Background" section near the top that explains what the key attribute is. I'm not really sure whether this section should be there or not, so I'm totally fine with removing the "Background" if people think it's unnecessary.

+93 -0

0 comment

3 changed files

pr created time in 12 days

push eventAurelius333/vue-docs-next

22969541+Aurelius333@users.noreply.github.com

commit sha 655ab2a7055f300a734a2c3d5f1e0c664de9157b

undo formatting changes in config.js

view details

push time in 12 days

create barnchAurelius333/vue-docs-next

branch : migration-guide-key-attribute

created branch time in 12 days

push eventAurelius333/vue-docs-next

NataliaTepluhina

commit sha 8abb7eebd90bd9f4c60132cb0ac34306265b8a1c

fix: removed v-for for refs, close #400

view details

push time in 14 days

push eventAurelius333/vue-docs-next

Stanislav Lashmanov

commit sha dd449209b6a896605be0c12f7f7ca08c99ecc755

Fix an outdated link to Application Config (#284)

view details

Stanislav Lashmanov

commit sha 8d6f16f3328deef8b24db280353f6a2e8e9554a2

Adjust migration section grouping title to better reflect its contents (#286) **Motivation** * Pages under this section group reflect changes that happened only between Vue 2 and Vue 3. It does not help if you're migrating from Vue 1 for example. * Since it is already a Vue 3 documentation calling migration section `Migration to Vue 3` is a bit of a tautology. * This grouping does not reflect migration from other frameworks like React or Svelte.

view details

Ben Hong

commit sha a5495cd3da36a5fb45eb78865ddd614ca095b499

config: update pr template warning (#316) * config: update pr template warning * config: use h2 for additional emphasis

view details

ryo

commit sha 7333805dedaccc7e19c97ffd696479d7ceb6c32f

fix: remove duplicated guide (#319)

view details

NataliaTepluhina

commit sha 885750220b837c738e2cfbab386e669d6012a2f8

fix: fixed globals whitelist

view details

NataliaTepluhina

commit sha 636ff8450acc88bc24f11968d52c831cea5ff045

Merge branch 'master' of github.com:vuejs/docs-next

view details

NataliaTepluhina

commit sha fe5e1eb12006f38975b93624d39f4fc626ddd9d6

fix: fixed async component link, close #325

view details

heyuxin

commit sha ee9957100e15dbe5eb0c73da244b37f43797f02b

fix:remove extra brackets (#327)

view details

Radicia

commit sha f8a861201a6b8919e19b88ca8ffe96d3cd0ae3b6

Update global-api.md (#331) Just a quick fix with a double 'a'

view details

Yusuf Kandemir

commit sha dd5ab8698b07da3a2092f1dcac2bff1e039c2e55

feat: Add `watch` changes (#314) * feat(guide/migration): Added string parameter changes of 'watch' * fix(api/instance-methods): Updated the behavior with a string parameter * feat(api/instance-methods): Added an example for watching deep paths * feat(api/instance-methods): Increased the clarity of the example * feat(api/instance-methods): Clarified some terms It was clashing with 'complex expression' in the example * feat(api/instance-methods): Improve the clarity Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com> * feat(api/instance-methods): Removed redundant comments Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com> * feat(api/instance-methods): Clarified a term Increased the harmony by using an already introduced term Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>

view details

NataliaTepluhina

commit sha c8f41824fbfc73c54b4b7015e21cdcaa39848dc1

fix: fixed example for v-model

view details

NataliaTepluhina

commit sha 25aa51b504411d45f112d57d03b4e2580ee5e016

Merge branch 'master' of github.com:vuejs/docs-next

view details

NataliaTepluhina

commit sha f75db8e53d399d55fbc11f9d404db3b34e8ab5d7

fix: fixed renderTriggered example

view details

Adrià Fontcuberta

commit sha 058386ad5585a140b98a32e269c40a131826d588

Reword preference of Vue Testing Library over Vue Test Utils (#330) * Update testing.md * Update testing.md

view details

NataliaTepluhina

commit sha 0f1838e8ad27cfb239ecd4676a941188f773fda7

feat: updated Vue CLI info on installation section

view details

NataliaTepluhina

commit sha fcdcf73b0ba0a24a3d2e6c027f753e534e5eab8f

Merge branch 'master' of github.com:vuejs/docs-next

view details

Marina Mosti

commit sha 31732199f14a3387f7d0e6568f529adba3b5c0c0

Feat/support vue page (#313) * add menu dropdown * create entry point with frontmatter * add view and insert into layout * create coins subview * add coins and main style sheet * fix frontmatter variable * add paypal image * wrap up content into a section tag * add coins section style * create supportimagelink component * normalize hash links * add sponsor loops and styles * add dcloud and inkoop imgs * fix ssr for clients * relocate components and prep for MD * remove supportvue page refs * migrate to MD * fix coins css * add missing scoped tag

view details

wujieZ

commit sha 4ec0cf08e0bf7d354b7d54dd34948ece81af9ab1

here should have property .value (#336)

view details

Ross Bratton

commit sha 8f856a6c70b5aeb91b53ce5d37cde0e791252a4f

fix: broken link in api/composition-api (#341)

view details

Damian Stasik

commit sha c44d36f9a229bd6b9b8d83b9ab588e5027333dd1

fix: use Vue component instead of `input` in v-model section (#304) * fix: use Vue component instead of `input` in v-model section * fix: use correct event name

view details

push time in 14 days

issue commentvuejs/docs-next

Migration guide section about v-if key

@NataliaTepluhina I'd be happy to create a pull request.

Aurelius333

comment created time in 14 days

issue commentvuejs/docs-next

Migration guide section about v-if key

In case it's helpful, here's my understanding of how it works as of the latest release.

As of v3.0.0-rc.6, it seems like it’s okay to provide explicit keys on v-if/v-else/v-else-if nodes, as long as the keys are always different in different branches. So "Example A" above is no longer a problem and doesn't need to be changed when upgrading to Vue 3.

It seems like there are two breaking changes involved here. These could be two different sections in the migration guide, or maybe they could be combined into one section about changes to key usage. My "Example B" in the issue description is a combination of both of these breaking changes.

Change 1: v-if/v-else/v-else-if branches must use unique keys if keys are provided (but these key aren't necessary)

<div v-if="cond" :key="3">Yes</div>
<div v-else :key="3">No</div>

We can probably just recommend removing the keys in this case, since the compiler can now generate them for you.

Change 2: <template v-for> key should be placed on the <template> tag.

Vue 2:

<template v-for="thing in list">
  <div :key="thing.id">...</div>
</template>

Vue 3:

<template v-for="thing in list" :key="thing.id">
  <div>...</div>
</template>
Aurelius333

comment created time in a month

PR opened vuejs/vue-next

types(runtime-core): make `this` void in prop validators and default factories

Same reasoning as #1842, except for validators and default factories in props. The typing currently doesn't reflect the fact that this isn't available in these functions.

+22 -1

0 comment

2 changed files

pr created time in a month

create barnchAurelius333/vue-next

branch : typing-props-no-this

created branch time in a month

push eventAurelius333/vue-next

HcySunYang

commit sha 3991ff03ceea89bbc149e864f754196d20c81f90

fix(runtime-core): separate null vs. non-null ref value updates (#1835) fix #1789, fix #1834

view details

underfin

commit sha bc6f252c4abc72bee29aa4766fc6c5ed0a81d7cd

fix(runtime-core): should correctly call `beforeEnter` inside `Suspense` (#1805) fix #1795

view details

Evan You

commit sha 611437a3fe5e50a5a6f79e2f8a0ed59e74539626

fix(runtime-core/scheduler): allow component render functions to trigger itself fix #1801

view details

Evan You

commit sha ac81dcf0cc7f5fc722a0c14d1cc92ece5cc0db07

fix(reactivity): effect should still check sync self-trigger

view details

dependabot-preview[bot]

commit sha 9aa4d2fbf3bbf69be3f71cb18376d2693de7b1bf

build(deps-dev): bump lodash from 4.17.19 to 4.17.20 (#1855)

view details

dependabot-preview[bot]

commit sha 3fa5c9fdab9b662eddb981084f575412ce70115d

build(deps-dev): bump rollup from 2.23.1 to 2.25.0 (#1856)

view details

HcySunYang

commit sha caccec3f78414ae294f1a813ffd16791d56da3a6

fix(runtime-core/scheduler): sort postFlushCbs to ensure refs are set before lifecycle hooks (#1854) fix #1852

view details

Evan You

commit sha 86a4f2a6b3c5f96d74e92f1cddab8a20674c6ed0

chore: remove unnecessary wrap

view details

edison

commit sha 2a1b0fc6d7ede05828e9b57b4426de33c6835e35

chore: use `value` instead of `n.value` (#1770)

view details

Necmettin Karakaya

commit sha 86187ca90722efc13f787a1cbb34a90810c09c60

chore: typos (#1670)

view details

dependabot-preview[bot]

commit sha 1bd5653ce6e46e1857b151fe5c28fedf75c3429c

build(deps): bump @babel/types from 7.10.5 to 7.11.0 (#1749) Bumps [@babel/types](https://github.com/babel/babel/tree/HEAD/packages/babel-types) from 7.10.5 to 7.11.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.0/packages/babel-types) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha dcb29496ba62a1d5921cc0d26490a246b28966af

build(deps): bump @babel/parser from 7.10.5 to 7.11.3 (#1820) Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.10.5 to 7.11.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.3/packages/babel-parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 1b87946552ba6274cec42ed6c058abc55e463893

build(deps-dev): bump @typescript-eslint/parser from 3.8.0 to 3.9.0 (#1831) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v3.9.0/packages/parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha cef97a162f29156a7f1de24c6b73bb1aa411d07e

build(deps-dev): bump jest from 26.3.0 to 26.4.0 (#1845) Bumps [jest](https://github.com/facebook/jest) from 26.3.0 to 26.4.0. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/compare/v26.3.0...v26.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Evan You

commit sha 9fb84187f03c2cc5ae15a2cd8cd9577ea798a4e1

chore: bump markdown e2e test wait period

view details

zhangzhonghe

commit sha 517c2b8bdb9ffa53717c10d604ff6db84d50d4f2

fix(teleport): always inherit root DOM nodes on patch (#1836) fix #1813

view details

Evan You

commit sha 223f18052944c57f449cb29ec6ea7c8c796c6e3d

test(watch): add same value skipping trigger test

view details

Aurelius333

commit sha 5002ab53d6bf379da6ae4aadc89bbbed31318c6c

types(runtime-core): make `this` void in emits validator (#1842)

view details

Pick

commit sha 44448fdd223f53a73553f4197f4c4fabf6f9a27b

types(reactivity): add dts for proxyRefs & improve typings (#1786)

view details

susiwen8

commit sha a2c6f0c8c73a9d67374a5fc0bdd58ac30518ebb8

chore: remove unecessary 'export' (#1785)

view details

push time in a month

PR closed Aurelius333/hello-world

also
+2 -0

0 comment

1 changed file

Aurelius333

pr closed time in a month

PR opened vuejs/vue-next

types(runtime-core): make `this` void in emits validator

Right now, it seems like emits validators cannot access this (for example, to validate event arguments based on the value of a prop). However, the typing doesn't reflect the fact that this isn't available.

I came across this because I wasn't sure if I could access this in emits, but it didn't give me a type error, so I thought it would probably work.

+12 -1

0 comment

2 changed files

pr created time in a month

create barnchAurelius333/vue-next

branch : typing-emits-no-this

created branch time in a month

push eventAurelius333/vue-next

dependabot-preview[bot]

commit sha c8bb8386bf1a21ae15bb9192fbf32c84feaed32b

build(deps-dev): bump rollup-plugin-typescript2 from 0.27.1 to 0.27.2 (#1819)

view details

dependabot-preview[bot]

commit sha bd96ec488ef94f03b3fac722710d0d53cbde016d

build(deps-dev): bump rollup from 2.23.0 to 2.23.1 (#1821)

view details

dependabot-preview[bot]

commit sha d142b434bd44d359d04519a7a61cef7c1c228c7e

build(deps-dev): bump jest from 26.2.2 to 26.3.0 (#1832)

view details

dependabot-preview[bot]

commit sha c44fccc1d474924b50aeb272a294ce28e7e580db

build(deps-dev): bump ts-jest from 26.1.4 to 26.2.0 (#1833)

view details

dependabot-preview[bot]

commit sha 77a6286c1cbaecfe8dc9ba3ff7392b9c69fb374b

build(deps-dev): bump conventional-changelog-cli from 2.0.34 to 2.1.0 (#1838)

view details

dependabot-preview[bot]

commit sha a56b3bfa68a5908875d0df04cabc4f7370e79b1d

build(deps-dev): bump @microsoft/api-extractor from 7.9.2 to 7.9.4 (#1839)

view details

beary

commit sha b984d47ac43a0aae2db5556a138a256fb5533ced

fix(types/jsx): update innerHTML property in jsx typing (#1814)

view details

Jacob Smith

commit sha b14f4a505b343b12be846f2455d461027a51641c

fix(codeframe): Added Math.max to prevent RangeError (#1807) fix #1806

view details

push time in a month

issue openedvuejs/vue-router-next

$route and $router type declarations seem to be missing in distributed declaration file

Version

4.0.0-beta.6

Reproduction link

https://github.com/aurelius333/vue-router-next-typing-repro

Steps to reproduce

Open src/views/index.vue and look for typing errors.

What is expected?

Should be typed correctly

What is actually happening?

Error message:

Property '$route' does not exist on type 'ComponentPublicInstance<{}, {}, {}, { theRoutePath(): string; }, {}, Record<string, any>, Readonly<{}>, ComponentOptionsBase<{}, {}, {}, { theRoutePath(): string; }, {}, ComponentOptionsMixin, ComponentOptionsMixin, Record<...>, string>>'.

It looks like the types appear here: https://github.com/vuejs/vue-router-next/blob/7869764cb5fefcf1fe02521c252b3e1ee35d4180/src/index.ts#L65-L115

However, they don't seem to show up in the final distributed vue-router.d.ts: https://unpkg.com/browse/vue-router@4.0.0-beta.6/dist/vue-router.d.ts. (I just searched for "$route" in this file and it didn't show up.)

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 2 months

push eventAurelius333/vue-router-next-typing-repro

22969541+Aurelius333@users.noreply.github.com

commit sha 3437b5fb7fd4ad2878a5c5add32f4b76cd9a4f58

Change any type to string

view details

push time in 2 months

create barnchAurelius333/vue-router-next-typing-repro

branch : master

created branch time in 2 months

created repositoryAurelius333/vue-router-next-typing-repro

created time in 2 months

push eventAurelius333/vue-next

Evan You

commit sha 74a1265feacf62d4f18482f4439d2b487bfd634d

chore: remove debugger

view details

Evan You

commit sha 3692f2738f5b48c5f116d27e2e3b2b571d28a753

refactor(runtime-core/scheduler): dedicated preFlush queue properly fix #1763, #1777, #1781

view details

wujieZ

commit sha 2787c34cd436e3ec4656b6986d9d14d57911a7b5

fix(reactivity): use isExtensible instead of isFrozen (#1753) close #1784

view details

Eduardo San Martin Morote

commit sha 00683fce9a1c6856be23b35ff0226d8ac5c96791

fix(runtime-dom): patch `form` as an attribute (#1788) Close #1787

view details

zhangzhonghe

commit sha 233d191d0d33802cdf7e2996569372a6442e236a

fix(keep-alive): fix activated hook invocation on nested components (#1743) fix #1742

view details

Evan You

commit sha 791eff3dfbd6be9ba8d597ecf8d943cd197f9807

fix(runtime-core): avoid manual slot invocation in template expressions interfering with block tracking fix #1745

view details

Evan You

commit sha 48576e582c4177572c2fd1764fbca53a6a30abe2

fix(transition): transition should accept multiple handlers on same event fix #1746

view details

Evan You

commit sha ed4381020fcea0494f19f11bebabd9108f2dafd7

fix(reactivity): readonly+reactive collection should also expose readonly+reactive values fix #1772

view details

Evan You

commit sha 50adc014f59a7f385c836014abb059ec72c52239

refactor(reactivity): readonly collections should not track

view details

push time in 2 months

issue commentvuejs/vue-next

<teleport v-if> with form input

@posva Thanks for your response!

I tried it on all of these browsers, and it's not working on any of them:

  • Firefox 79.0; macOS 10.15.4
  • Chrome 84.0.4147.105 (Official Build) (64-bit); macOS 10.15.4
  • Safari 13.1; macOS 10.15.4
  • Firefox 79.0; Windows 10

I've been using the CodePen debug link: https://cdpn.io/Aurelius333/debug/VwaLvZR/bZrQWEzQVVVk

Did you type something into the input first? It only seems to error if you type something into the input first.

Aurelius333

comment created time in 2 months

issue openedvuejs/vue-next

<teleport v-if> with form input

Version

3.0.0-rc.5

Reproduction link

https://codepen.io/Aurelius333/pen/VwaLvZR

Steps to reproduce

  1. Wait for the page to fully load
  2. Type something into the input
  3. Press the "Cancel" button

What is expected?

The content should disappear because of the v-if.

What is actually happening?

The content does not disappear. Instead, I get this warning:

[Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/vue-next 
  at <App>

In Chrome, I get this error:

Uncaught (in promise) TypeError: Cannot read property 'parentNode' of null
    at remove (vue@next:7235)
    at performRemove (vue@next:5662)
    at remove (vue@next:5680)
    at Object.remove (vue@next:2317)
    at unmount (vue@next:5637)
    at patch (vue@next:4693)
    at componentEffect (vue@next:5248)
    at reactiveEffect (vue@next:391)
    at callWithErrorHandling (vue@next:1274)
    at flushJobs (vue@next:1427)

In Firefox, I get this error:

Uncaught (in promise) TypeError: child is null
    vue next:7235
    vue next:5662
    vue next:5680
    vue next:2317
    vue next:5637
    vue next:4693
    vue next:5248
    vue next:391
    vue next:1274
    vue next:1427
vue@next:7235:26

Doing any of the following seems to make this work and stop the error from happening:

  • Removing the wrapping <form> element
  • Removing the v-model on the <input>
  • Not typing anything into the input before pressing the "Cancel" button

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 2 months

startedJarnaChao09/Kotrix

started time in 2 months

push eventAurelius333/vue-next

dependabot-preview[bot]

commit sha b10bc2820a742859fc52fac3bd8e2ad41e3678ed

build(deps-dev): bump eslint from 7.5.0 to 7.6.0 (#1765)

view details

Evan You

commit sha d4c17fb48b7880a4e3db6d48f8ab76540a3f59a2

fix(watch): pre-flush watcher watching props should trigger before component update fix #1763

view details

Evan You

commit sha f6afe7000efb964355c439b7963087ab8e42d6b1

fix(runtome-core): do not cache property access in beforeCreate hook fix #1756

view details

Evan You

commit sha 0cd98c3040a64df4577d188b9f2221224549a132

fix(runtime-dom): style binding multi value support fix #1759

view details

Aurelius333

commit sha 86cdf6694dd25383cf6f9611e0a5d8650e684970

chore(compiler-core): improve X_V_IF_KEY error message (#1757)

view details

Yang Mingshan

commit sha b2a91429ede9ea49e4808de2748da19deeb7f335

fix(runtime-core/scheduler): prevent duplicate queue (#1767)

view details

Evan You

commit sha 1c967fc44b971686d5a0e2811deb2362ec84979f

fix(runtime-dom): fix v-on same computed handler on multiple elements fix #1747

view details

Evan You

commit sha 8d4abc381480ccc4356d2523d9fa35690ae1d76f

chore: unset removed invokers

view details

Evan You

commit sha 11ed2103919af46b5d9f573d3fad749ca7eb73f5

chore: fix tests

view details

dependabot-preview[bot]

commit sha c3f8c780e7814c3064619252c11ef15ea8eb44d4

build(deps-dev): bump @typescript-eslint/parser from 3.7.1 to 3.8.0 (#1776)

view details

Evan You

commit sha de0c8a7e3e8d2adfae4c4ef992cd5ac6262ca534

fix(compiler-core): v-if key error should only be checking same key on different branches

view details

Evan You

commit sha b0d01e9db9ffe5781cce5a2d62c8552db3d615b0

dx(compiler-core): warn on `<template v-for>` key misplacement Note: the behavior is different from Vue 2. `<template v-for>` are compiled into an array of Fragment vnodes so the key should be placed the `<template>` for v-for to use it for diffing.

view details

Eduardo San Martin Morote

commit sha b5f91ff570244436aa8f579ec3a6fec781d198a7

fix(watch): allow handler to be a string (#1775) fix #1774

view details

Evan You

commit sha a0e34cee4a09a14548bf1e78f4a82702e9d40717

fix(watch): exhaust pre-flush watchers + avoid duplicate render by pre-flush watchers close #1777

view details

push time in 2 months

issue openedvuejs/docs-next

Migration guide section about v-if key

I can't find anything about this in the migration guide, but it seems to be a breaking change.

Example A

Vue 2

In v2, it was common to use keys on v-if, v-else, and v-else-if. For example:

<h1 v-if="cond" key="a">A</h1>
<h2 v-else key="b">B</h2>

Vue 3

In v3, this produces an compiler error because keys are automatically generated on v-if, v-else, and v-else-if nodes. These keys can be removed:

<h1 v-if="cond">A</h1>
<h2 v-else>B</h2>

Example B

Vue 2

In v2, a <template> could not have a key, so when using a <template v-for> with a child v-if/v-else, you would place the key on both of the children:

<template v-for="thing in list">
  <h1 v-if="cond" :key="thing.id">A</h1>
  <h2 v-else :key="thing.id">B</h2>
</template>

Vue 3

In v3, the previous example causes the v-if to not work properly, and it produces an error message. Because of Fragments, we can now put the key on the <template> directly:

<template v-for="thing in list" :key="thing.id">
  <h1 v-if="cond">A</h1>
  <h2 v-else>B</h2>
</template>

Error message

This is the new error message for this problem in the master branch of vue-next. (This new message isn't released into a new version yet.)

v-if branches must use compiler generated keys. In many cases, you can simply remove this key. If this tag is inside of a <template v-for="...">, then you can move the key up to the parent <template>.

References

  • https://github.com/vuejs/vue-next/issues/1734#issuecomment-665745971
  • https://github.com/vuejs/vue-next/issues/1712#issuecomment-665206103

created time in 2 months

PR opened vuejs/vue-next

chore(compiler-core): improve X_V_IF_KEY error message

I'm not sure if my new error message is completely accurate, but I think this error message might benefit from more detail. When I saw this message, I wasn't sure what it meant, and I had to search through the GitHub issues to figure out what to do.

+4 -1

0 comment

1 changed file

pr created time in 2 months

push eventAurelius333/vue-next

22969541+Aurelius333@users.noreply.github.com

commit sha 07ee00bdb85e78818a2b524b0efde2bc126cfcf3

dx(compiler-core): reword X_V_IF_KEY error message

view details

push time in 2 months

create barnchAurelius333/vue-next

branch : better-error-message-x-v-if-key

created branch time in 2 months

push eventAurelius333/vue-next

likui

commit sha 9bddf3820e891de92d2fad2f1fa463c180631caf

types(runtime-core): improve types for transition hook fix #1000

view details

underfin

commit sha 63c8444d4a1b101502522d2c0f1fdf632dd638f8

Update packages/runtime-core/src/components/BaseTransition.ts Co-Authored-By: Carlos Rodrigues <david-181@hotmail.com>

view details

likui

commit sha 6b889e7c8a599c829f9a240fdcdce3299fbd0e6d

fix: run ci

view details

dependabot-preview[bot]

commit sha 30f570e8081ae0c7128095eca0c04f73fdc897a9

build(deps-dev): bump conventional-changelog-cli from 2.0.31 to 2.0.34 Bumps [conventional-changelog-cli](https://github.com/conventional-changelog/conventional-changelog) from 2.0.31 to 2.0.34. - [Release notes](https://github.com/conventional-changelog/conventional-changelog/releases) - [Commits](https://github.com/conventional-changelog/conventional-changelog/compare/conventional-changelog-cli@2.0.31...conventional-changelog-cli@2.0.34) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha eed9d7747380824675b676eec532caa8a55ef626

build(deps-dev): bump rollup from 2.8.2 to 2.9.1 Bumps [rollup](https://github.com/rollup/rollup) from 2.8.2 to 2.9.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.8.2...v2.9.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 903e8222be1815df646698dce6e5cf9227da8ceb

build(deps-dev): bump ts-jest from 25.4.0 to 25.5.1 Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 25.4.0 to 25.5.1. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md) - [Commits](https://github.com/kulshekhar/ts-jest/compare/v25.4.0...v25.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Aurelius333

commit sha 8e692c1ca000b629309bf217d93b4522c2cc2ccd

chore: fix broken link in CHANGELOG.md (#1142) [ci skip]

view details

Evan You

commit sha a165d8293dbd092828b14530577d45e2af40deda

feat(runtime-core): expose isVNode

view details

Evan You

commit sha 66c5a556dc5b27e9a72fa7176fbb45d8c4c515b7

fix(hmr): ensure static nodes inherit DOM element in hmr mode fix #1156

view details

Evan You

commit sha 9d111f534adfea77e106f7f5054a842b3c0b26de

test(transition): refactor DOM transition test

view details

underfin

commit sha 697de07e630c502db42e93e64ba556cc4599cbe4

fix(transition): should reset enter class after appear (#1152)

view details

Evan You

commit sha 5b8883a84689dd04dbbcd677bf177ffeda43489d

fix(runtime-core): should not take unmount children fast path for v-for fragments fix #1153

view details

Evan You

commit sha 1b946c85df3d213900faccfa0723d736fa0927a3

fix(hmr): always force full child component props update in HMR mode

view details

Evan You

commit sha 7887c54dfe32fb141cfe3e1f025bfe08ba3b7efa

release: v3.0.0-beta.11

view details

Evan You

commit sha aa1672a8bd5bad6bfb7522c779b2c6c36e9cb01d

test: fix hmr test id

view details

Evan You

commit sha 2bc6a8c1cf4f409eea0cefa8b8a7619aae1f3569

fix(hmr): static child traversal should only affect elements

view details

Evan You

commit sha 3c88299f6ac5e959f117af5d0a9af03588381581

release: v3.0.0-beta.12

view details

dependabot-preview[bot]

commit sha 74ed7d1d6bc259b60ffec6775fe64245db857519

build(deps-dev): bump @types/puppeteer from 2.0.1 to 2.1.0 Bumps [@types/puppeteer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/puppeteer) from 2.0.1 to 2.1.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/puppeteer) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 8159ae8b0d7e800f0b946a8ac06d1bc900888ff8

build(deps-dev): bump rollup from 2.9.1 to 2.10.0 Bumps [rollup](https://github.com/rollup/rollup) from 2.9.1 to 2.10.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.9.1...v2.10.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha a569067940f437d44ed5f3e64687906916ce4206

build(deps-dev): bump rollup-plugin-typescript2 from 0.27.0 to 0.27.1 Bumps [rollup-plugin-typescript2](https://github.com/ezolenko/rollup-plugin-typescript2) from 0.27.0 to 0.27.1. - [Release notes](https://github.com/ezolenko/rollup-plugin-typescript2/releases) - [Commits](https://github.com/ezolenko/rollup-plugin-typescript2/compare/0.27.0...0.27.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 2 months

PR closed OHIF/Viewers

Remove "module" field from every package.json

PR Checklist

See #1935 for explanation of why it seems to me that the "module" field can and should be removed. Feel free to close this if you don't think this is a good solution to that issue, or if you think this should be discussed in that issue first.

Should fix #1935

<!-- Links -->

<!-- prettier-ignore-start --> [blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/ [script]: https://github.com/jklukas/git-push-fork-to-upstream-branch <!-- prettier-ignore-end -->

+0 -13

1 comment

13 changed files

Aurelius333

pr closed time in 2 months

PR opened OHIF/Viewers

Remove "module" field from every package.json

PR Checklist

See #1935 for explanation of why it seems to me that the "module" field can and should be removed. Feel free to close this if you don't think this is a good solution to that issue, or if you think this should be discussed in that issue first.

Should fix #1935

<!-- Links -->

<!-- prettier-ignore-start --> [blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/ [script]: https://github.com/jklukas/git-push-fork-to-upstream-branch <!-- prettier-ignore-end -->

+0 -13

0 comment

13 changed files

pr created time in 2 months

issue openedOHIF/Viewers

package.json "module" fields point to nonexistent files

Before Creating an issue

  • Are you running the latest version? Yes
  • Are you reporting to the correct repository? Yes
  • Did you search existing issues? Yes

Bug Report

(I don't know much about this works; these are just my best guesses.)

Describe the Bug

The package.json of every package in this repository includes this line: https://github.com/OHIF/Viewers/blob/14da2473187a4728cdae915c1cd75802f768986c/platform/viewer/package.json#L9

However, they all also include these lines: https://github.com/OHIF/Viewers/blob/14da2473187a4728cdae915c1cd75802f768986c/platform/viewer/package.json#L41-L44

When installing these packages into node_modules, the src directory is not included, so the "module" field points to a file that doesn't exist. This doesn't seem to be a problem when using Webpack. (I'm guessing Webpack just moves on to "main" when the "module" field doesn't work.) However, I was trying to use Vite (a new dev tool / bundler that uses Rollup for bundling), which failed to load the "module" field.

Proposed solution

I think it might be best to simply remove the "module" field. It doesn't seem to me like this would break anything; anything that relies on the "module" field would already be broken because the file it points to isn't there in the npm distribution. Removing the "module" field doesn't seem to have any effect on Webpack, but it does make Vite work (because it seems like Vite will use the "main" field as long as the "module" field isn't present).

I would be happy to create a pull request for this.

Alternative solution

You could have the "module" field actually point to an ES Modules distribution. However, this might be more difficult than it's worth. I thought at first that you could just add the src directory to "files", but that doesn't seem to work because the files there aren't regular ESM because they include JSX. Webpack doesn't seem to natively support ESM as an output format, so if you wanted to generate ESM, I guess maybe you would want to just apply Babel on its own without Webpack.

What steps can we follow to reproduce the bug?

git clone https://github.com/Aurelius333/ohif-bug-repro.git
yarn
yarn build

Error message:

vite v1.0.0-rc.3
⠴ Building for production...
[vite] Build errored out.
Error: [vite]: Rollup failed to resolve import "@ohif/viewer" from "src/main.js".

But if you manually modify all of the @ohif/* packages in node_modules to remove the "module" fields, then it works.

created time in 2 months

create barnchAurelius333/ohif-bug-repro

branch : master

created branch time in 2 months

created repositoryAurelius333/ohif-bug-repro

created time in 2 months

create barnchAurelius333/Viewers

branch : remove-package-module

created branch time in 2 months

startedOHIF/Viewers

started time in 2 months

created repositoryAurelius333/vue-router-next-typing-repro

created time in 2 months

create barnchAurelius333/vue-router-next-typing-repro

branch : master

created branch time in 2 months

push eventAurelius333/vue-docs-next

Natalia Tepluhina

commit sha 33faa93550fa5adca4b94db5adea4ac5dc2adfd2

Add an explanation for Vue builds (#252) * feat: added CDN builds * fix: fixed devtools message disclaimer * feat: added vue-next plugin description * fix: joined fragments into one sentence

view details

Stanislav Lashmanov

commit sha 52578fd5f2ba845556aaef1340e21cdc8eab5f2b

Remove outdated section of keying siblings under v-if (#254) Vue 3 does keying automatically on a compiler level, so this section is outdated. Example of auto keying: https://vue-next-template-explorer.netlify.app/#%7B%22src%22%3A%22%3Cdiv%3E%5Cr%5Cn%20%20%3Cdiv%20v-if%3D%5C%22exp%5C%22%3E1%3C%2Fdiv%3E%5Cr%5Cn%20%20%3Cdiv%20v-else%3E2%3C%2Fdiv%3E%5Cr%5Cn%3C%2Fdiv%3E%22%2C%22options%22%3A%7B%22mode%22%3A%22module%22%2C%22prefixIdentifiers%22%3Afalse%2C%22optimizeImports%22%3Afalse%2C%22hoistStatic%22%3Afalse%2C%22cacheHandlers%22%3Afalse%2C%22scopeId%22%3Anull%2C%22ssrCssVars%22%3A%22%7B%20color%20%7D%22%2C%22optimizeBindings%22%3Afalse%7D%7D

view details

Phan An

commit sha be972f06e57ab665fe50f951a5753d8899226e68

chore: allow discarding beta banner (#251) * chore: allow discarding beta banner * fix: ensure localStorage only accessed at client

view details

Sarah Drasner

commit sha 11b9ee15c966ed7fe47b1ddf4259bc4cc4f5a01d

Next iteration Transitions (#256) * add in perf and ha * add in diagram * add in more easing information * Update src/guide/transitions-overview.md Co-authored-by: Phan An <me@phanan.net> * Update src/guide/transitions-overview.md Co-authored-by: Phan An <me@phanan.net> * Update src/guide/transitions-overview.md Co-authored-by: Phan An <me@phanan.net> * Put GreenSock link with the first mention Co-authored-by: Phan An <me@phanan.net>

view details

Stanislav Lashmanov

commit sha ca36f46afc8f9a30d8c348a9adf3ec07d13f3a9a

Update attribute coercion with respect to new behaviour (#261) * Update attribute coercion with respect to new behaviour Only `null` and `undefined` will result in no attribute in the final DOM, according to [RFC #24](https://github.com/vuejs/rfcs/blob/master/active-rfcs/0024-attribute-coercion-behavior.md#detailed-design) * Update src/guide/template-syntax.md Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com> Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>

view details

Phan An

commit sha 9ab14c5eefa4bb492dc5a0cee3eafab499972dbc

fix: link to Global API Treeshaking (#266)

view details

Stanislav Lashmanov

commit sha bb6ad736e218c4eb347f581e5c8322fb40d2ee7d

Link to Vue reactivity on Instance page (#264) This is the first mention of Reactivity in Vue Guide, so it might be worthwhile to link to the explanation page.

view details

Phan An

commit sha 1cc22f11254c7b3d1fa10291860f1722a57cf8b2

fix: sidebar's top value (#267)

view details

Phan An

commit sha 7c0d239cfe7e54e629e849891b0623d7d974375f

fix: sidebar's top padding on mobile devices (#268)

view details

Sarah Drasner

commit sha 983cb4a18faf8a0947b3502a1e81ac2bdc3901d5

State Transitions Page Revamp (#260) * update state examples, remove one * compose components * Update src/guide/transitions-state.md Co-authored-by: Ben Hong <ben@bencodezen.io> * Update src/guide/transitions-state.md Co-authored-by: Ben Hong <ben@bencodezen.io> Co-authored-by: Ben Hong <ben@bencodezen.io>

view details

Sarah Drasner

commit sha 862df959ab8c20039e6eec5c3b3629c85119dfae

Add in interpolation example (#262) * add the style interpolation example * make the pen public * fix highlighted line * Update src/guide/transitions-overview.md Co-authored-by: Ben Hong <ben@bencodezen.io> Co-authored-by: Ben Hong <ben@bencodezen.io>

view details

Marshall Thompson

commit sha 1ba104e315c1a6f9f0bc7e4259be1578e083587c

Small grammar fix in filters.md (#270)

view details

Marina Mosti

commit sha d3ad44182c75cd275337951840366e3fe1ca25bb

add resolveComponent, resolveDirective, createRenderer and withDirectives to global API (#255) * add resolveComponent, resolveDirective and withDirectives * fix setup to render * add createRenderer * fix indentation, add examples, fix args

view details

Sarah Drasner

commit sha e281ebdf43cfb5c41aeaf6c0b6650b262546e556

fix highlight color (#271)

view details

Sarah Drasner

commit sha e7619004813afbe877ddd1ec67d44ad15e7a02ae

Redo the Transition Modes Section (#269) * add in transition modes examples * add in click to load * fix another click to load * beef up transition modes explanation * finish up modes

view details

Sarah Drasner

commit sha bd4c9dbdcbbb5502e6ce86230ade7d14e6b2c3b2

Clarifying SFC and other Simplifications (#272) * move two way binding up * use shortcut

view details

vimvinter

commit sha 47dc553889c082c04a76d289c6b3d92a1d7a1832

fix: change directive inserted to mounted (#275)

view details

Phan An

commit sha 90a6b3d1a2b03d90d40d0a5ab83bdd8d99ccc2f0

fix: remove trailing ::: (#273)

view details

Phan An

commit sha 77c915d976116c31c1c4141149e930d675b5ab4f

fix: increase heading line-height to fix overlapping (#274)

view details

NataliaTepluhina

commit sha 836c0e013c26f8a9190e2832725186a8265046f9

chore: cleared up some todos

view details

push time in 2 months

issue commentvuejs/vue-next

Composition API in a functional component

If you don't care about having the name field, I think defineComponent already wraps a function into setup if you pass it a function directly: https://github.com/vuejs/vue-next/blob/d39c03771b7ae2eb6026c3463a5c0972767780ff/packages/runtime-core/src/apiDefineComponent.ts#L207-L209

So it seems like you could do this:

export default defineComponent(() => {
  const { counter, increment } = useCounter();

  return () => <button onClick={increment}>Counter: {counter.value}</button>;
})
baryla

comment created time in 2 months

issue commentvuejs/docs-next

First example in introduction doesn't demonstrate reactivity

Here's my possible solution: https://github.com/vuejs/docs-next/compare/master...Aurelius333:intro-reactivity-examples-without-codepen?expand=1. I created components for the first and third examples in src/.vuepress/components, and I added mounted hooks that attach this to window:

  mounted() {
    window.HelloVueVm = this
  }

In the example code on the page, I assigned the last line of the first example to HelloVueVm:

const HelloVueVm = Vue.createApp(HelloVueApp).mount('#hello-vue')

That way, in both the code example and on the actual page, you can do HelloVueVm.message = 'some other message'.

There are some disadvantages to this approach:

  1. Code duplication
  2. The code in the example isn't exactly the same as the code that's actually used on the page. (Though it seems to me like they have the same behavior.)
  3. As you said, it's probably bad practice to be attaching this to window.

I think it might be worth it to have the quick, easy example that you can run in the console, but I understand if it's not worth the tradeoff.

Aurelius333

comment created time in 2 months

issue openedvuejs/docs-next

First example in introduction doesn't demonstrate reactivity

In the very first example in the new introduction, it says:

The data and the DOM are now linked, and everything is now reactive. How do we know? Change the message property in the code snippet below to a different value and the rendered example will update accordingly:

However, I'm not sure that changing the code snippet in the CodePen really demonstrates reactivity, since that seems to just restart the CodePen with a different initial state.

Those first examples in the v2 docs were helpful for me in understanding what reactivity means in Vue, so I wonder if it's worth changing the first and third examples to run directly on the page like in the v2 docs so that the app can be exposed to the console. As a reminder, the v2 docs said:

The data and the DOM are now linked, and everything is now reactive. How do we know? Open your browser’s JavaScript console (right now, on this page) and set app.message to a different value. You should see the rendered example above update accordingly.

Thank you all for your hard work!

created time in 2 months

PR opened OHIF/Viewers

Fix README.md Quick Start Deployment instructions

Change window.OHIFStandaloneViewer to window.OHIFViewer, since the former is undefined.

PR Checklist

  • [ ] Brief description of changes
  • [ ] Links to any relevant issues
  • [ ] Required status checks are passing
  • [ ] User cases if changes impact the user's experience
  • [ ] @mention a maintainer to request a review

<!-- Links -->

<!-- prettier-ignore-start --> [blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/ [script]: https://github.com/jklukas/git-push-fork-to-upstream-branch <!-- prettier-ignore-end -->

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventAurelius333/Viewers

Aurelius333

commit sha da7007967526f65235ef246c095c2cda3af61b13

Fix README.md Quick Start Deployment instructions Change `window.OHIFStandaloneViewer` to `window.OHIFViewer`, since the former is undefined

view details

push time in 3 months

fork Aurelius333/Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages

https://docs.ohif.org/

fork in 3 months

more