profile
viewpoint

Ashniu123/python-kafka-IPL 2

Wordcloud using Twitter API and Apache Kafka

Ashniu123/stacklite-hadoop-mapreduce 1

Hadoop MapReduce on Stacklite dataset

AkshatShetty101/CereLabs_Event_Recognition 0

Internship related Event Recognition System

AkshatShetty101/Falcor-Songs 0

A songs manager using falcor

ashnehete/static-blogger 0

A static blog for your website.

Ashniu123/aicte-website-101 0

Our AICTE Website for Smart India Hackathon '17

Ashniu123/bat 0

A cat(1) clone with wings.

Ashniu123/BloggerRedux 0

Blogger in React / Redux connected to Firebase

Ashniu123/Cashier-Customer-Interface-C 0

This was my Sem2 Project

startedmyspaghetti/macos-virtualbox

started time in 12 hours

startedpshihn/rough-notation

started time in 2 days

startedsupabase/supabase

started time in 3 days

startedpikapkg/snowpack

started time in 3 days

startedLisaDziuba/Marketing-for-Engineers

started time in 6 days

startedmhinz/vim-galore

started time in 7 days

startedsindresorhus/awesome

started time in 7 days

issue commentmicrosoft/vscode-pull-request-github

Suggested description page styling tweaks

@rishab-pdx if your PR is ready then by all means... Go ahead! :D

RMacfarlane

comment created time in 8 days

startedetcd-io/etcd

started time in 9 days

push eventAshniu123/mattermost-plugin-todo

Nisheet Sinvhal

commit sha 27e5e435c1715ecedda6790ddf8d04a56c929463

add websocket reconnect handler

view details

push time in 11 days

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

Ok. I did not know what registerReconnectHandler does. Thanks for pointing it out in the docs.

Just solve one doubt of mine - when the app reconnects to the internet, is the "refresh" websocket event published? Which might suffice. If I do add a registerReconnectHandler, which will invoke refresh function (right?), then the same function will be executing twice one after the other leading to wastage.

@mickmister

Ashniu123

comment created time in 11 days

startedWorldBrain/Memex

started time in 12 days

pull request commentmattermost/mattermost-server

Pass query string params to interactive dialog request url

Must have happened due to the latest commit. It was working fine until then.

Please be careful about the changes @lieut-data

You added an extra '2' to "xyz" as depicted here

Ashniu123

comment created time in 12 days

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

image

The sidebar looks like this now without the refresh button.

Ashniu123

comment created time in 12 days

push eventAshniu123/mattermost-plugin-todo

Nisheet Sinvhal

commit sha f896de6c3861b347c6060940ab25c19f5ced18fe

remove refresh button

view details

push time in 12 days

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

@mickmister - I believe that there won't be a need for "reconnect handler" as such because the "Todo plugin" is internal. That is, it doesn't connect to an external API like Github's which required a "connected" action.

Github plugin's "connected" action.

Do correct me if I am wrong.

I shall just remove the refresh button for now.

Ashniu123

comment created time in 12 days

startedbradtraversy/design-resources-for-developers

started time in 12 days

pull request commentmattermost/mattermost-server

Pass query string params to interactive dialog request url

This PR has been idle on open for too long with no action. Can we get this done asap please?

Ashniu123

comment created time in 13 days

push eventAshniu123/thrift-graphql-demo

Nisheet Sinvhal

commit sha f57599adbe8b3e0daca551038869bdae772123b2

Insert blog link

view details

push time in 14 days

push eventAshniu123/thrift-graphql-demo

Nisheet Sinvhal

commit sha f57599adbe8b3e0daca551038869bdae772123b2

Insert blog link

view details

push time in 14 days

PublicEvent
PublicEvent

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

The websocket strategy sounds good. Will update this PR soon.

Ashniu123

comment created time in 14 days

startedonurakpolat/awesome-analytics

started time in 15 days

startedlouischatriot/nedb

started time in 15 days

startedalexkim205/Google-Drive-Desktop

started time in 15 days

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

I have another concern actually, it is regarding the UI - the "refresh" button.

Other plugins use a "refresh" button to update the data too right? If I had 2 plugins which show a refresh button on LHS - say github and todo. Isn't that a bad UX?

Ashniu123

comment created time in 17 days

startedin3rsha/sha256-animation

started time in 17 days

startedmingrammer/diagrams

started time in 18 days

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

This PR has been hanging on open for too long with no action. Can we get this done asap please?

Ashniu123

comment created time in 19 days

push eventAshniu123/mattermost-server

Nisheet Sinvhal

commit sha ae6b9fa257a24a9f3ae74afce2c46f6ecdc3ee86

Add test case to check query params received by plugin

view details

push time in 20 days

startedpi-hole/pi-hole

started time in 20 days

startedfacebookexperimental/rome

started time in 23 days

issue commentprisma-labs/graphql-yoga

Is this project still alive?

Probably could write a mail or join the slack channel and ask about the status of this project. Would be a shame to see this project die.

slaking

comment created time in 25 days

startedcanonical/multipass

started time in a month

startedubuntu/microk8s

started time in a month

startedcaddyserver/caddy

started time in a month

startedPostHog/posthog

started time in a month

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

Yeah Sure. Here it is...

image

Ashniu123

comment created time in a month

startedmichelhe/rustboyadvance-ng

started time in a month

startednats-io/nats-server

started time in a month

startedcri-o/cri-o

started time in a month

startedksindi/managers-playbook

started time in a month

startedliftbridge-io/liftbridge

started time in a month

startedmifi/editly

started time in a month

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

@larkox can you confirm the changes now? I believe the PR is ready to be merged.

Ashniu123

comment created time in a month

pull request commentmattermost/mattermost-server

Pass query string params to interactive dialog request url

I could but I will need some guidance. How do I mock the function and know what parameters are passed into it when the function is called? Could you give a reference example file in the codebase?

Ashniu123

comment created time in a month

pull request commentmattermost/mattermost-server

Pass query string params to interactive dialog request url

I do not know why the "MySQL test cases" are failing. I think my changes have nothing to do with that. @marianunez What do you think?

Ashniu123

comment created time in a month

push eventAshniu123/mattermost-plugin-todo

Nisheet Sinvhal

commit sha 75c281629f8206bcc0463ab716e93e474378e134

Remove the unnecessary componentDidUpdate function

view details

push time in a month

Pull request review commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.+// See LICENSE.txt for license information.++import React from 'react';+import {Tooltip, OverlayTrigger} from 'react-bootstrap';+import PropTypes from 'prop-types';+import {makeStyleFromTheme, changeOpacity} from 'mattermost-redux/utils/theme_utils';++import {RHSStates} from '../../constants';++export default class SidebarButtons extends React.PureComponent {+    static propTypes = {+        theme: PropTypes.object.isRequired,+        isTeamSidebar: PropTypes.bool,+        showRHSPlugin: PropTypes.func.isRequired,+        issues: PropTypes.arrayOf(PropTypes.object),+        inIssues: PropTypes.arrayOf(PropTypes.object),+        outIssues: PropTypes.arrayOf(PropTypes.object),+        actions: PropTypes.shape({+            list: PropTypes.func.isRequired,+            updateRhsState: PropTypes.func.isRequired,+        }).isRequired,+    };++    constructor(props) {+        super(props);++        this.state = {+            refreshing: false,+        };+    }++    componentDidUpdate(prevProps) {+        if (prevProps.issues !== this.props.issues || prevProps.inIssues !== this.props.inIssues || prevProps.outIssues !== this.props.outIssues) {+            this.getData();+        }+    }

Yeah. You are right. I saw this thing in the "reference" part of the issue pointing to the github plugin. I did have the same doubt but I thought it was some pattern you guys followed. I have removed it now. Thanks.

Ashniu123

comment created time in a month

starteddandavison/delta

started time in a month

startedOxygem/Kanmail

started time in a month

Pull request review commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

 function rhsPluginAction(state = null, action) {     } } +function rhsState(state = null, action) {+    switch (action.type) {+    case UPDATE_RHS_STATE:+        return action.state;+    default:+        return state;+    }+}+ export default combineReducers({     rootModalVisible,     postID,     issues,     inIssues,     outIssues,+    rhsState,

@larkox can you confirm if the changes I made are acceptable?

Ashniu123

comment created time in a month

PR opened mattermost/mattermost-server

Pass query string params to interactive dialog request url

Closes #14347 on Github Closes #24024 on Jira

<!-- Thank you for contributing a pull request! Here are a few tips to help you:

  1. If this is your first contribution, make sure you've read the Contribution Checklist https://developers.mattermost.com/contribute/getting-started/contribution-checklist/
  2. Read our blog post about "Submitting Great PRs" https://developers.mattermost.com/blog/2019-01-24-submitting-great-prs
  3. Take a look at other repository specific documentation at https://developers.mattermost.com/contribute -->

Summary

Query string parameters are now passed onto the interactive dialog request url

Ticket Link

Github issue: https://github.com/mattermost/mattermost-server/issues/14347 Jira: https://mattermost.atlassian.net/browse/MM-24024

+1 -0

0 comment

1 changed file

pr created time in a month

fork Ashniu123/mattermost-server

Open source Slack-alternative in Golang and React - Mattermost

https://mattermost.com

fork in a month

startedcontainers/buildah

started time in a month

startedcontainers/libpod

started time in a month

startedmattermost/mattermost-server

started time in a month

issue commentmattermost/mattermost-server

Query string parameters are omitted from interactive dialog request url

I would like to have a "go" at it. Please assign it to me.

mattermod

comment created time in a month

Pull request review commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

 function rhsPluginAction(state = null, action) {     } } +function rhsState(state = null, action) {+    switch (action.type) {+    case UPDATE_RHS_STATE:+        return action.state;+    default:+        return state;+    }+}+ export default combineReducers({     rootModalVisible,     postID,     issues,     inIssues,     outIssues,+    rhsState,

Nevermind, I have done it. On clicking Your Todos or Incoming Todos, you see the Todos tab On clicking Outgoing Todos, you see the Sent tab

Ashniu123

comment created time in a month

push eventAshniu123/mattermost-plugin-todo

Nisheet Sinvhal

commit sha 90a956429a2109182d6063b3ed6f352e17679251

Open correct RHS state on todo button click Change icons Fix bugs

view details

push time in a month

Pull request review commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

 function rhsPluginAction(state = null, action) {     } } +function rhsState(state = null, action) {+    switch (action.type) {+    case UPDATE_RHS_STATE:+        return action.state;+    default:+        return state;+    }+}+ export default combineReducers({     rootModalVisible,     postID,     issues,     inIssues,     outIssues,+    rhsState,

I intended to open the Sent part of RHS when I click on Todos Outgoing sidebar button. Do you require it or shall I remove it. It will require some more changes to state and will modify the RHS component to get data from redux.

Ashniu123

comment created time in a month

Pull request review commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.+// See LICENSE.txt for license information.++import React from 'react';+import {Tooltip, OverlayTrigger} from 'react-bootstrap';+import PropTypes from 'prop-types';+import {makeStyleFromTheme, changeOpacity} from 'mattermost-redux/utils/theme_utils';++import {RHSStates} from '../../constants';++export default class SidebarButtons extends React.PureComponent {+    static propTypes = {+        theme: PropTypes.object.isRequired,+        isTeamSidebar: PropTypes.bool,+        showRHSPlugin: PropTypes.func.isRequired,+        issues: PropTypes.arrayOf(PropTypes.object),+        inIssues: PropTypes.arrayOf(PropTypes.object),+        outIssues: PropTypes.arrayOf(PropTypes.object),+        actions: PropTypes.shape({+            list: PropTypes.func.isRequired,+            updateRhsState: PropTypes.func.isRequired,+        }).isRequired,+    };++    constructor(props) {+        super(props);++        this.state = {+            refreshing: false,+        };+    }++    componentDidUpdate() {+        this.getData();+    }

You're right! I will add check with prevProps and this.props to resolve this.

Ashniu123

comment created time in a month

startedmaxchehab/phelia

started time in a month

push eventAshniu123/mattermost-plugin-todo

Nisheet Sinvhal

commit sha 04137590e529483137cc036147125f55eef4b7d8

Fix lint errors

view details

push time in a month

pull request commentmattermost/mattermost-plugin-todo

Add todo button on team sidebar

image The sidebar looks like this, tell me if any changes are required

Ashniu123

comment created time in a month

PR opened mattermost/mattermost-plugin-todo

Reviewers
Add todo button on team sidebar

Resolves issue #24

<!-- Thank you for contributing a pull request! Here are a few tips to help you:

  1. If this is your first contribution, make sure you've read the Contribution Checklist https://developers.mattermost.com/contribute/getting-started/contribution-checklist/
  2. Read our blog post about "Submitting Great PRs" https://developers.mattermost.com/blog/2019-01-24-submitting-great-prs
  3. Take a look at other repository specific documentation at https://developers.mattermost.com/contribute -->

Summary

Add 4 buttons on team sidebar as per issue Buttons are - Your todos, requested todos, assigned todos, refresh

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-todo/issues/24

+260 -3

0 comment

9 changed files

pr created time in a month

create barnchAshniu123/mattermost-plugin-todo

branch : add-todo-button-with-count

created branch time in a month

fork Ashniu123/mattermost-plugin-todo

Mattermost plugin for tracking to do items

fork in a month

started30-seconds/30-seconds-of-code

started time in a month

startedGoogleContainerTools/kaniko

started time in a month

startedpublic-apis/public-apis

started time in 2 months

startedLeaflet/Leaflet

started time in 2 months

startedtannerlinsley/react-table

started time in 3 months

startededtr-io/edtr-io

started time in 3 months

more