profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/AmandaCameron/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

AmandaCameron/gobar 11

It's a panel-type thing in Go! YAY!

AmandaCameron/go.networkmanager 6

A NetworkManager dbus binding.

AmandaCameron/go-angularjs 2

GopherJS bindings to AngularJS

AmandaCameron/cc-glox 1

Graphical shell & program suite for ComputerCraft

AmandaCameron/cc-veek 1

Stuff for terminal GUIs in ComputerCraft

AmandaCameron/go-telegram 1

Telegram Bot API

AmandaCameron/android 0

IRCCloud Android App

AmandaCameron/appdash 0

Application tracing system for Go, based on Google's Dapper.

AmandaCameron/bazel-1793-example 0

An example workspace to show the bazel issue 1793.

AmandaCameron/cc-docset 0

A ComputerCraft docset for Dash.

PR opened PC-Logix/LanteaBot

Update RandomChoice.java

What could possibly go wrong keeping the ring choosing the thing?

+1 -0

0 comment

1 changed file

pr created time in a day

push eventAmandaCameron/LanteaBot

Amanda Cameron

commit sha 51d55f53d401d5f1343d87ab6c83afd185e811c5

Update RandomChoice.java What could possibly go wrong ~~keeping the ring~~ choosing the thing?

view details

push time in a day

PR opened NixOS/nixpkgs

nixos/greetd: Fix for nogroup removal.

<!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions -->

Motivation for this change

The NixOS greetd module was broken by the change in #133166

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.
+6 -1

0 comment

1 changed file

pr created time in 2 days

issue commentnushell/nushell

Nushell dealbreakers from twitter

re: direnv, I actually needed that as well, and managed to do it somewhat on my own with the following:

alias load-direnv = load-env (direnv export elvish | from json | pivot name value)

The main problem with it is it'll permentnatly "taint" the session, as AFAIK there's no inverse to load-env where we can remove the environment variables back out, so when I'm done with that directory's direnv-loaded, I just ctrl-d.

jntrnr

comment created time in 20 days

pull request commentfnuecke/oc2

build: Fix the oc2-sedna -> sedna rename

Apologies, a person in #oc said that forge isn't accepting the markdown manual version that they got from ci, so I assumed the last two commits were still relevant, sorry

AmandaCameron

comment created time in a month

pull request commentfnuecke/oc2

build: Fix the oc2-sedna -> sedna rename

Did a ping on discord as well, but the last two commits of this are also needed changes, otherwise forge gets confused and doesn't think the markdown_manual matches versions, because it expects one with a + on the end.

AmandaCameron

comment created time in a month

issue openedfnuecke/oc2

Converting ItemStacks to NBT then JSON causes some data loss in the case of some modded inventories.

StorageDrawers uses some sliglty-odd behaviour for the ItemStacks returned from it's inventory, namely, they may be larger than 64.

For instance, our storage drawers currently have 286 copper ingots, which SD is reporting back to OC2, then when OC2 turns that into NBT, it's getting wrapped around as a uint8 with a value of 30.

Another case is that we have 191 paper in another drawer, which OC2 is reporting as -65 which I suspect is the uint8 value of 191 being converted to a signed int8 in the NBT, but I'm not sure on the math of that.

One solution may be to manually change the Count field into a long which should work for everything. I believe that the ItemStack API doesn't return an byte for size, which may be the discrepency here?

created time in a month

PR opened fnuecke/oc2

a couple of Bus fixes

This fixes the server crash I reported in #59 as well as a client crash using the scrench to rename a bus interface. Note that while it's a seperate PR, you still need #58 to actually run the mod in the game, I just didn't think it would be wise to front-load #58 too much.

+2 -2

0 comment

2 changed files

pr created time in a month

create barnchAmandaCameron/oc2

branch : bus-fixes

created branch time in a month

issue openedfnuecke/oc2

li.cil.oc2.common.block.BusCableBlock.openBusInterfaceScreen is getting called on dedicated server.

This is getting called on a dedicated server when accessing the bus with a scrench. Guessing a .isRemote check is needed somewhere.

created time in a month

push eventAmandaCameron/oc2

Amanda Cameron

commit sha 5ecbb0a1ad772f8455f652297e8644ceef41704c

Add the + back in the build.gradle

view details

push time in a month

push eventAmandaCameron/oc2

Amanda Cameron

commit sha 5071d8fa8af074a0b3e1f77375b0a71123bbc77a

markdown_manual shouldn't have the + either, it seems.

view details

push time in a month

PR opened fnuecke/oc2

build: Fix the oc2-sedna -> sedna rename

The mod was broken by the oc2-sedna -> sedna rename, causing forge to throw a "Dependency not found" screen up on startup.

+4 -4

0 comment

3 changed files

pr created time in a month

push eventAmandaCameron/oc2

lucsoft

commit sha 807f2b543f68f9370ef5a9cf686371d951116483

Make Aritfacts public

view details

lucsoft

commit sha 2fc841132bf71f710b4929d63e46e78e4dc043d5

Added a nightly badge This needs to be enabled manual in github actions (i cant change this with a pr)

view details

lucsoft

commit sha 75f4ad42f3e2e1b67cd5f4b550c6d578366ecb02

Added Java 15 & Windows

view details

lucsoft

commit sha ce15d338ebe9884325f59ccc71f7a5087f1d49ed

Added a link to sedna builds https://github.com/fnuecke/oc2-sedna/pull/2 is required before this

view details

lucsoft

commit sha b18510b34231b84e786d4e2e8f2e360f5a59a4e7

Fixed copy and paste error

view details

Amanda Cameron

commit sha c2685fc97a27effa578ca89645a72ad33acbf617

filesystems: This makes it so that datapacks can be reloaded with /reload

view details

Florian Nücke

commit sha aeff6aba648bcd2905df262cfc12a37ebd678eab

Pulled out some common VM logic.

view details

lucsoft

commit sha fbe5a1036d7e9dac3bc2a4613ce4c826e1870138

Added sounds and subtitles from OC1 back

view details

Florian Nücke

commit sha 54bac6077c7e5829378fe652a75fe43bb9826d34

Started working on the robbit.

view details

Florian Nücke

commit sha efa43430b3d43667b43d4263287ef2bcd1072c96

Pulled out a bunch more common functionality from computers for re-use in robots.

view details

Florian Nücke

commit sha 3b2dc8cefac48b20d00ba8b3ff65158363949aa1

Robots bootable and movable.

view details

Florian Nücke

commit sha bf3a0da468dd2bd3195f49fd416ebffdf525ae52

Make AbstractVirtualMachineItemStackHandlers more flexible.

view details

Florian Nücke

commit sha 4087fd4bb6944031dfac94239a6de9be7eac9bd5

Allow querying action result.

view details

Florian Nücke

commit sha df15be2ab13a7a780ec67cf9d69ff317790f27f2

Break intersecting blocks. Robots do not move into blocks, so this is typically falling blocks or blocks that changed state (e.g. trapdoors).

view details

Florian Nücke

commit sha f3dcf40910216d8f260e7aacacd342a9e6f1c0b5

Ignore pistons for now.

view details

Florian Nücke

commit sha b26936d42cec649188eaf6ddb0fb89b79562c151

Allow pistons to shove robots.

view details

Florian Nücke

commit sha af0bd5fc606020cb9aa96fbb98547560a6ebf2a0

Item rendering for robot.

view details

Florian Nücke

commit sha 2e8cca3b0eda69caaa7df08a1c960dc866b74ec9

Make robots drop self and show configuration in tooltip.

view details

Florian Nücke

commit sha 80ed98119bd3968dbe65d05b47195b740702c844

Add tags. Use those for wrench detection.

view details

Florian Nücke

commit sha e97f3f408e26fd8a05012a80325f26a2818de8e6

Fix slot type in robot container.

view details

push time in a month

create barnchAmandaCameron/oc2

branch : fix-sedna-name

created branch time in a month

push eventAmandaCameron/PackUpdate

Amanda Cameron

commit sha 7b6b5593b330e49d1b04c11d5f8587a9e9f55182

packupdate-gen: Fix is_digit -> isdigit

view details

push time in 2 months

PR opened XDjackieXD/PackUpdate

Default `version` to the first 8 chars of the mod file's SHA256

Add an auto-generated value for version if it's not got one detected from the modinfo.json

+7 -2

0 comment

1 changed file

pr created time in 2 months

push eventAmandaCameron/PackUpdate

Amanda Cameron

commit sha f6abb5858cab3ec51da7eb0eff52e991291cd142

Update packupdate-gen.py Add an auto-generated value for `version` if it's not got one detected from the modinfo.json

view details

push time in 2 months

fork AmandaCameron/PackUpdate

Ever wanted MultiMC to automagically update your Modpacks? well there you go!

fork in 2 months

PR closed golang-migrate/migrate

pgx: Make it actually use pgx

This modifies the pgx driver to actually use pgx directly, and adds a WithPgxInstance function, which will let people who are using the pgx driver directly run migrations using the package as a library.

+62 -45

2 comments

2 changed files

AmandaCameron

pr closed time in 2 months

PullRequestReviewEvent

Pull request review commentgolang-migrate/migrate

pgx: Make it actually use pgx

 type Config struct { }  type Postgres struct {-	// Locking and unlocking need to use the same connection-	conn     *sql.Conn+	conn *pgx.Conn

Am I understanding correctly that you mean that we'll leave the driver as it, and not merge this? If so, I'm fine with the MR getting closed, since I realised sometime during this process that the driver doesn't even have to be in-tree, and I'm fine with maintaining my own seperate package with this MR's contents extracted out.

AmandaCameron

comment created time in 2 months

issue openedtulir/mautrix-telegram

Custom Keyboards from bots aren't sent over in any form it seems.

I've got a bot that uses custom keyboards for some better UX when operating it, and there's no indication whatsoever that the custom keyboard's been sent, or it's contents.

I recognise Matrix doesn't have anything like that, but even just a comment from the bot like: "Reply With: <keyboard options>" would be useful.

created time in 3 months

Pull request review commentgolang-migrate/migrate

pgx: Make it actually use pgx

 type Config struct { }  type Postgres struct {-	// Locking and unlocking need to use the same connection-	conn     *sql.Conn+	conn *pgx.Conn

The only way I could find to get a sql.Conn/DB in my program would be to open a separate connection using sql.Open instead of just passing in the pgx.Conn my program already created to do it's database operations, which just doesn't feel that clean to me.

AmandaCameron

comment created time in 3 months

PullRequestReviewEvent

Pull request review commentgolang-migrate/migrate

pgx: Make it actually use pgx

 type Config struct { }  type Postgres struct {-	// Locking and unlocking need to use the same connection-	conn     *sql.Conn+	conn *pgx.Conn

The benefit of using the pgx.Conn over sql.Conn is you can get a pgx.Conn from a sql.DB -- but you can't get a sql.DB from a pgx.Conn. This is the issue I was running into with a program of mine that uses pgx directly, for some speed benefits and some benefits around de/serialisation that can't be done through database/sql

That said, lib/pg's README states that it's in maintenance mode, and to use pgx instead, and I'm not aware of any other popular postgres go libraries.

AmandaCameron

comment created time in 3 months

PullRequestReviewEvent

push eventDarkDNA/migrate

Amanda Cameron

commit sha 9faafed4d1449805cd0f6a59ead7d58475926442

fix tests, use pgx for Postgres.Open as well.

view details

push time in 3 months

push eventDarkDNA/migrate

Amanda Cameron

commit sha f904d440bca66e42c0f27536a8dbbe41dd11c298

Address MR comments.

view details

push time in 3 months

Pull request review commentgolang-migrate/migrate

pgx: Make it actually use pgx

 func (p *Postgres) Open(url string) (database.Driver, error) { }  func (p *Postgres) Close() error {-	connErr := p.conn.Close()-	dbErr := p.db.Close()-	if connErr != nil || dbErr != nil {-		return fmt.Errorf("conn: %v, db: %v", connErr, dbErr)+	if p.stdlib != nil {

I'm under the impression that if we got it from AquireConn we're just "borowing" it from the sql.DB, so we shouldn't be closing it, but passing it back to the sql.DB instance with ReleaseConn, which is why I did it this way.

The docs for AcquireConn say:

AcquireConn acquires a *pgx.Conn from database/sql connection pool. It must be released with ReleaseConn.

AmandaCameron

comment created time in 3 months