profile
viewpoint
Alec Strong AlecStrong Square, Inc. Kitchener, Ontario https://twitter.com/Strongolopolis @CashApp

AlecStrong/kotlin-native-cocoapods 128

A Gradle plugin for configuring Kotlin/Native with Cocoapods

AlecStrong/pizzasort 78

Sort a given list of pizzas by tastiness

AlecStrong/sql-psi 62

An extendable parsing environment for sql which outputs PSI

AlecStrong/ResurgenceOfSQL 20

Sample data/queries for DroidconNYC2017 talk "The Resurgence of SQL"

AlecStrong/conway 7

Print statistics on module contribution

AlecStrong/projectDependencyGraph 6

A gradle task using Graphviz to display your projects dependency graph.

AlecStrong/Grammar-Kit-Composer 2

A Gradle Plugin which modifies IntelliJ grammar kit grammars to be composable

AlecStrong/sqlbrite 2

A lightweight wrapper around SQLiteOpenHelper which introduces reactive stream semantics to SQL operations.

AlecStrong/sqlite-bnf 2

Machine readable BNF form of the sqlite grammar and a script which generates it from published sqlite website

AlecStrong/alecstrong.com 1

https://alecstrong.com

push eventsqlite/sqlite

dan

commit sha 1c5b23f170836bdc4c329156741987a7bd772df2

Fix a case in the FTS5 integrity check where a corrupt database could cause a buffer overread. FossilOrigin-Name: a32b4f650d2d543bd2773cbc8655c1679a20b35ac9ec4d08c7754ddf6d972acb

view details

dan

commit sha 66efc393c56a9b6e2c8026762b7c4cc8da2e47af

Move an "if( rc==SQLITE_OK )" to outside a loop body in the fts5 bm25() code. FossilOrigin-Name: 14a4dcf3474566d072007a37d214c892397c21dd3b7f8b55ad0e5edfb7130dd6

view details

dan

commit sha 31817068955c5eeb1488a18daacf3addc818d623

Remove a redundant "if( rc==SQLITE_OK )" from the fts5 bm25() code. FossilOrigin-Name: d85f4f27f58adcc75fc7d59e63af95b2a338052d8748a11f22ec1e48d1aff4cc

view details

dan

commit sha 6d19bf9460e136b7cf21732359c63965ee48ce4d

Add missing cast to fts5 bm25() code. FossilOrigin-Name: 6ff9673847c0b4174d9435e93d19af0ee7406b1a12edeb6edec98697e1646824

view details

push time in an hour

push eventJetBrains/projector-server

Ivan Kupriyanov

commit sha 662e0a3db7b5ba9c7a9186c4b1a9667cb0660dc7

PRJ-125 Use DNS names everywhere

view details

Ivan Kupriyanov

commit sha 5dcf852a91066a7154e83487283c0ff360f74a8b

Fixes

view details

push time in 5 hours

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class ProjectorServer private constructor(          selectedOption = JOptionPane.showOptionDialog(           null,-          "Somebody ($ipString) wants to connect with $accessType access. Allow the connection?",+          "Somebody (${getHostName(remoteAddress)}) wants to connect with $accessType access. Allow the connection?",

Name of that PC.

IKupriyanov-HORIS

comment created time in 6 hours

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class ProjectorServer private constructor(          selectedOption = JOptionPane.showOptionDialog(           null,-          "Somebody ($ipString) wants to connect with $accessType access. Allow the connection?",+          "Somebody (${getHostName(remoteAddress)}) wants to connect with $accessType access. Allow the connection?",

There is no record in DNS for this IP. What name did you expect to see?

IKupriyanov-HORIS

comment created time in 6 hours

issue openedcashapp/sqldelight

java.lang.IllegalArgumentException in SqlDelightCompiler.kt:204

Error in SQL Delight IntelliJ Plugin

java.lang.IllegalArgumentException in SqlDelightCompiler.kt:204 Can't escape identifier spms-core.db because it contains illegal characters: .

View on Bugsnag

Stacktrace

SqlDelightCompiler.kt:204 - com.squareup.sqldelight.core.compiler.SqlDelightCompiler.writeToAndClose
SqlDelightCompiler.kt:117 - com.squareup.sqldelight.core.compiler.SqlDelightCompiler.writeQueryWrapperInterface
SqlDelightCompiler.kt:65 - com.squareup.sqldelight.core.compiler.SqlDelightCompiler.writeDatabaseInterface
ProjectService.kt:87 - com.squareup.sqldelight.intellij.ProjectService.generateDatabaseOnSync
ProjectService.kt:45 - com.squareup.sqldelight.intellij.ProjectService.access$generateDatabaseOnSync
ProjectService.kt:62 - com.squareup.sqldelight.intellij.ProjectService$1.after

View full stacktrace

Created automatically via Bugsnag

created time in 7 hours

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class ProjectorServer private constructor(          selectedOption = JOptionPane.showOptionDialog(           null,-          "Somebody ($ipString) wants to connect with $accessType access. Allow the connection?",+          "Somebody (${getHostName(remoteAddress)}) wants to connect with $accessType access. Allow the connection?",
servb@UNIT-1259:~$ nslookup 192.168.1.100
** server can't find 100.1.168.192.in-addr.arpa: NXDOMAIN
IKupriyanov-HORIS

comment created time in 8 hours

issue openedcashapp/sqldelight

java.lang.NullPointerException in SqlDelightFile.kt:16

Error in SQL Delight IntelliJ Plugin

java.lang.NullPointerException in SqlDelightFile.kt:16

View on Bugsnag

Stacktrace

SqlDelightFile.kt:16 - com.squareup.sqldelight.core.lang.SqlDelightFile.getModule
SqlDelightQueriesFile.kt:94 - com.squareup.sqldelight.core.lang.SqlDelightQueriesFile.iterateSqlFiles

View full stacktrace

Created automatically via Bugsnag

created time in 10 hours

startedhasura/graphql-engine

started time in 19 hours

created repositoryBink-Dog/conf-app-shared-data

Shared Kotlin Stuff

created time in 20 hours

push eventsqlite/sqlite

dan

commit sha ec8962869a095945fdb59bb443190bce98f54969

Update mkunicode.tcl to match the change erroneously made to machine generated file fts5_unicode2.c in [b7b7bde9]. FossilOrigin-Name: 326d579d777fdede6bc64f9525248767f4730de4e50260b0387e614a9d006416

view details

push time in 21 hours

push eventsqlite/sqlite

drh

commit sha 24c22753fc88cdba0d6d437977698ae192bc2c9d

Remove an unused #define from sqliteInt.h. FossilOrigin-Name: d5b254f94c1ce6f0f26024d0b9c80e610f7cc891360bc4c2cb116e9eda2874b3

view details

drh

commit sha 8c1fbe81d01e711f14130798fa8b11b79849aa77

Minor comment fixes. No changes to code. FossilOrigin-Name: 533aeb90085d989078073067172135db98e37e00be84f99757255858126196e4

view details

dan

commit sha 91faeec8d095f494852b15952a9835b740045ac8

Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. FossilOrigin-Name: 7dfb74c37e678dde347d9d85846672f82ad282e300e32676330b764be2e4d580

view details

drh

commit sha 4dfdb86c8d85b008dd74d9184e81bf3d206e9758

New test cases for the use of the ieee754 and decimal extensions in the CLI. FossilOrigin-Name: bc1590f32fc4e2696b4126bd0302cb6405031dd4f55b86f3f1611f7f39299f85

view details

drh

commit sha c08716a317ee00de91537da8d2f44092cd0896c0

Fix harmless USAN warnings from gcc9. FossilOrigin-Name: 72c4c69fea13f5e24df25645e6941ce3ff896f0a3c73cd63329f819cc907ab40

view details

drh

commit sha b6a74caf9302c0b4f25b461e552cd36df0b9b439

Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. FossilOrigin-Name: 41de742c5713ab1a0c0c15c44af3ffac40bbc527ae2dc11d829ba9773eb4c84a

view details

drh

commit sha a3e6495970590691f05c6fe0057637c1b2bfe6bb

Improvement on the previous fix. FossilOrigin-Name: f6cffa2d50bfebe5b025f412b7a49b7fdafb798aaf1ddc80e6656ccd1f012a7f

view details

dan

commit sha 96e337df6b87c1c731cdf0bad5e2611f93030cae

Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory. FossilOrigin-Name: b050976079ba4a22d4dfeadb81f40cf71da6588c95bf2b634d88b416de5accd7

view details

drh

commit sha ef215fbf3b581ef4e0273bb3932fa522af88fd7e

Version 3.33.0 FossilOrigin-Name: fca8dc8b578f215a969cd899336378966156154710873e68b3d9ac5881b0ff3f

view details

dan

commit sha e0404386f265f2af09777eefb21f97f9333b95bb

Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests. FossilOrigin-Name: 613fb5c2525be77e48bad0a74e8b7bf53489365060fb9c7713a0caddb1820c71

view details

drh

commit sha 5e6d90fe15e0c8be357008f9e5ff6afba0662c0b

Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks. FossilOrigin-Name: 2f7cb6ab39e54fd6eb3a280d3022c3d4f4ed92e83af7226e63e0199a96397a6b

view details

drh

commit sha 68c0c71065354a2c06e3283f0a2f1758afec5aba

For UPDATE and DELETE, use OP_DeferredSeek always. If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed. This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing. FossilOrigin-Name: a495f60d315e34b1a1bc5fb1336e05047add52c8fb2710b577c97b10a5e734f6

view details

drh

commit sha f8556d0106e57c1599a6e4171a9e5f3ed1e81822

Optimizations to the logic that converts main table accesses into equivalent index accesses. Code is now slightly smaller and faster than trunk. FossilOrigin-Name: 611b640442025e57b8e161f8ddac1f19bd3be9a3d5266f4cef287595c3ed9257

view details

drh

commit sha a3d6d6a93fc87eba1ccb52d6f72d79ab6b378f69

Update the version number to 3.34.0 for the next development cycle. FossilOrigin-Name: 70f34f3df5358d36c8578afbc05756450c46da36b8dce339ed87fc0b9d4057cb

view details

drh

commit sha 861889e4f8e63e5f9f7508419fe01fe5de8ccb49

When doing an UPDATE or DELETE using a multi-column index where only a few of the earlier columns of the index are useful for the index lookup, postpone doing the main table seek until after all WHERE clause constraints have been evaluated, in case those constraints can be covered by unused later terms of the index, thus avoiding unnecessary main table seeks. FossilOrigin-Name: 7fee0b1075d622835dc6828c061be516102da9e2809f52d9ab7c4bbef7dfb871

view details

drh

commit sha 398221e2ad4b553621df09d73b1d0931a52ff269

Omit the unnecessary not-NULL check on the upper bound of a forward index range scan. The subsequent OP_IdxGT will always catch the NULL. Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL. FossilOrigin-Name: e51ecadcbdef5ce6e41d68412aee70aa4a1416c850358a6fa7e9a1ab443e719d

view details

drh

commit sha f0b41745c5142a4c1c8ad311a4b15330284264c8

Avoid unnecessary calls to the sqlite3GetVdbe() routine. Add assert() statements to prove each call is unnecessary. FossilOrigin-Name: 86d3790caf92e9cb7a9aaaa110f309b4b6945ac30cfd53fc3e5aa1ec3075ada5

view details

drh

commit sha 289a0c849b7d0a2242089d4a06cfb5a16284a40d

Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s. FossilOrigin-Name: b7dc932197665f0ebde3ffb8f0785c22da07ce307cfd5f0eab69e86e4b38fcde

view details

drh

commit sha 45d827cb6aaf9c2ac4392a4781ca7010be1f69d2

Optimization of the sqlite3SrcListDelete() routine. FossilOrigin-Name: 1b4acd1ac4a8d24f8804c6d0770f5b0022f569d51742b6954b26e525f04d38ca

view details

drh

commit sha 1d8f892a31e750f3e7247c74e07acfd4cadba9e8

Optimization to sqlite3BeginWriteOperation(). FossilOrigin-Name: 2173d4c6e3addc75964508f2fc8e42755376b3bc285286fa90df4831a6fa280b

view details

push time in a day

push eventsqlite/sqlite

drh

commit sha 24c22753fc88cdba0d6d437977698ae192bc2c9d

Remove an unused #define from sqliteInt.h. FossilOrigin-Name: d5b254f94c1ce6f0f26024d0b9c80e610f7cc891360bc4c2cb116e9eda2874b3

view details

drh

commit sha 8c1fbe81d01e711f14130798fa8b11b79849aa77

Minor comment fixes. No changes to code. FossilOrigin-Name: 533aeb90085d989078073067172135db98e37e00be84f99757255858126196e4

view details

dan

commit sha 91faeec8d095f494852b15952a9835b740045ac8

Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. FossilOrigin-Name: 7dfb74c37e678dde347d9d85846672f82ad282e300e32676330b764be2e4d580

view details

drh

commit sha 4dfdb86c8d85b008dd74d9184e81bf3d206e9758

New test cases for the use of the ieee754 and decimal extensions in the CLI. FossilOrigin-Name: bc1590f32fc4e2696b4126bd0302cb6405031dd4f55b86f3f1611f7f39299f85

view details

drh

commit sha c08716a317ee00de91537da8d2f44092cd0896c0

Fix harmless USAN warnings from gcc9. FossilOrigin-Name: 72c4c69fea13f5e24df25645e6941ce3ff896f0a3c73cd63329f819cc907ab40

view details

drh

commit sha b6a74caf9302c0b4f25b461e552cd36df0b9b439

Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. FossilOrigin-Name: 41de742c5713ab1a0c0c15c44af3ffac40bbc527ae2dc11d829ba9773eb4c84a

view details

drh

commit sha a3e6495970590691f05c6fe0057637c1b2bfe6bb

Improvement on the previous fix. FossilOrigin-Name: f6cffa2d50bfebe5b025f412b7a49b7fdafb798aaf1ddc80e6656ccd1f012a7f

view details

dan

commit sha 96e337df6b87c1c731cdf0bad5e2611f93030cae

Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory. FossilOrigin-Name: b050976079ba4a22d4dfeadb81f40cf71da6588c95bf2b634d88b416de5accd7

view details

drh

commit sha ef215fbf3b581ef4e0273bb3932fa522af88fd7e

Version 3.33.0 FossilOrigin-Name: fca8dc8b578f215a969cd899336378966156154710873e68b3d9ac5881b0ff3f

view details

dan

commit sha e0404386f265f2af09777eefb21f97f9333b95bb

Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests. FossilOrigin-Name: 613fb5c2525be77e48bad0a74e8b7bf53489365060fb9c7713a0caddb1820c71

view details

drh

commit sha 5e6d90fe15e0c8be357008f9e5ff6afba0662c0b

Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks. FossilOrigin-Name: 2f7cb6ab39e54fd6eb3a280d3022c3d4f4ed92e83af7226e63e0199a96397a6b

view details

drh

commit sha 68c0c71065354a2c06e3283f0a2f1758afec5aba

For UPDATE and DELETE, use OP_DeferredSeek always. If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed. This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing. FossilOrigin-Name: a495f60d315e34b1a1bc5fb1336e05047add52c8fb2710b577c97b10a5e734f6

view details

drh

commit sha f8556d0106e57c1599a6e4171a9e5f3ed1e81822

Optimizations to the logic that converts main table accesses into equivalent index accesses. Code is now slightly smaller and faster than trunk. FossilOrigin-Name: 611b640442025e57b8e161f8ddac1f19bd3be9a3d5266f4cef287595c3ed9257

view details

drh

commit sha a3d6d6a93fc87eba1ccb52d6f72d79ab6b378f69

Update the version number to 3.34.0 for the next development cycle. FossilOrigin-Name: 70f34f3df5358d36c8578afbc05756450c46da36b8dce339ed87fc0b9d4057cb

view details

drh

commit sha 861889e4f8e63e5f9f7508419fe01fe5de8ccb49

When doing an UPDATE or DELETE using a multi-column index where only a few of the earlier columns of the index are useful for the index lookup, postpone doing the main table seek until after all WHERE clause constraints have been evaluated, in case those constraints can be covered by unused later terms of the index, thus avoiding unnecessary main table seeks. FossilOrigin-Name: 7fee0b1075d622835dc6828c061be516102da9e2809f52d9ab7c4bbef7dfb871

view details

drh

commit sha 398221e2ad4b553621df09d73b1d0931a52ff269

Omit the unnecessary not-NULL check on the upper bound of a forward index range scan. The subsequent OP_IdxGT will always catch the NULL. Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL. FossilOrigin-Name: e51ecadcbdef5ce6e41d68412aee70aa4a1416c850358a6fa7e9a1ab443e719d

view details

drh

commit sha f0b41745c5142a4c1c8ad311a4b15330284264c8

Avoid unnecessary calls to the sqlite3GetVdbe() routine. Add assert() statements to prove each call is unnecessary. FossilOrigin-Name: 86d3790caf92e9cb7a9aaaa110f309b4b6945ac30cfd53fc3e5aa1ec3075ada5

view details

drh

commit sha 289a0c849b7d0a2242089d4a06cfb5a16284a40d

Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s. FossilOrigin-Name: b7dc932197665f0ebde3ffb8f0785c22da07ce307cfd5f0eab69e86e4b38fcde

view details

drh

commit sha 45d827cb6aaf9c2ac4392a4781ca7010be1f69d2

Optimization of the sqlite3SrcListDelete() routine. FossilOrigin-Name: 1b4acd1ac4a8d24f8804c6d0770f5b0022f569d51742b6954b26e525f04d38ca

view details

drh

commit sha 1d8f892a31e750f3e7247c74e07acfd4cadba9e8

Optimization to sqlite3BeginWriteOperation(). FossilOrigin-Name: 2173d4c6e3addc75964508f2fc8e42755376b3bc285286fa90df4831a6fa280b

view details

push time in a day

push eventsqlite/sqlite

drh

commit sha 24c22753fc88cdba0d6d437977698ae192bc2c9d

Remove an unused #define from sqliteInt.h. FossilOrigin-Name: d5b254f94c1ce6f0f26024d0b9c80e610f7cc891360bc4c2cb116e9eda2874b3

view details

drh

commit sha 8c1fbe81d01e711f14130798fa8b11b79849aa77

Minor comment fixes. No changes to code. FossilOrigin-Name: 533aeb90085d989078073067172135db98e37e00be84f99757255858126196e4

view details

dan

commit sha 91faeec8d095f494852b15952a9835b740045ac8

Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. FossilOrigin-Name: 7dfb74c37e678dde347d9d85846672f82ad282e300e32676330b764be2e4d580

view details

drh

commit sha 4dfdb86c8d85b008dd74d9184e81bf3d206e9758

New test cases for the use of the ieee754 and decimal extensions in the CLI. FossilOrigin-Name: bc1590f32fc4e2696b4126bd0302cb6405031dd4f55b86f3f1611f7f39299f85

view details

drh

commit sha c08716a317ee00de91537da8d2f44092cd0896c0

Fix harmless USAN warnings from gcc9. FossilOrigin-Name: 72c4c69fea13f5e24df25645e6941ce3ff896f0a3c73cd63329f819cc907ab40

view details

drh

commit sha b6a74caf9302c0b4f25b461e552cd36df0b9b439

Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. FossilOrigin-Name: 41de742c5713ab1a0c0c15c44af3ffac40bbc527ae2dc11d829ba9773eb4c84a

view details

drh

commit sha a3e6495970590691f05c6fe0057637c1b2bfe6bb

Improvement on the previous fix. FossilOrigin-Name: f6cffa2d50bfebe5b025f412b7a49b7fdafb798aaf1ddc80e6656ccd1f012a7f

view details

dan

commit sha 96e337df6b87c1c731cdf0bad5e2611f93030cae

Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory. FossilOrigin-Name: b050976079ba4a22d4dfeadb81f40cf71da6588c95bf2b634d88b416de5accd7

view details

drh

commit sha ef215fbf3b581ef4e0273bb3932fa522af88fd7e

Version 3.33.0 FossilOrigin-Name: fca8dc8b578f215a969cd899336378966156154710873e68b3d9ac5881b0ff3f

view details

dan

commit sha e0404386f265f2af09777eefb21f97f9333b95bb

Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests. FossilOrigin-Name: 613fb5c2525be77e48bad0a74e8b7bf53489365060fb9c7713a0caddb1820c71

view details

drh

commit sha 5e6d90fe15e0c8be357008f9e5ff6afba0662c0b

Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks. FossilOrigin-Name: 2f7cb6ab39e54fd6eb3a280d3022c3d4f4ed92e83af7226e63e0199a96397a6b

view details

drh

commit sha 68c0c71065354a2c06e3283f0a2f1758afec5aba

For UPDATE and DELETE, use OP_DeferredSeek always. If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed. This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing. FossilOrigin-Name: a495f60d315e34b1a1bc5fb1336e05047add52c8fb2710b577c97b10a5e734f6

view details

drh

commit sha f8556d0106e57c1599a6e4171a9e5f3ed1e81822

Optimizations to the logic that converts main table accesses into equivalent index accesses. Code is now slightly smaller and faster than trunk. FossilOrigin-Name: 611b640442025e57b8e161f8ddac1f19bd3be9a3d5266f4cef287595c3ed9257

view details

drh

commit sha a3d6d6a93fc87eba1ccb52d6f72d79ab6b378f69

Update the version number to 3.34.0 for the next development cycle. FossilOrigin-Name: 70f34f3df5358d36c8578afbc05756450c46da36b8dce339ed87fc0b9d4057cb

view details

drh

commit sha 861889e4f8e63e5f9f7508419fe01fe5de8ccb49

When doing an UPDATE or DELETE using a multi-column index where only a few of the earlier columns of the index are useful for the index lookup, postpone doing the main table seek until after all WHERE clause constraints have been evaluated, in case those constraints can be covered by unused later terms of the index, thus avoiding unnecessary main table seeks. FossilOrigin-Name: 7fee0b1075d622835dc6828c061be516102da9e2809f52d9ab7c4bbef7dfb871

view details

drh

commit sha 398221e2ad4b553621df09d73b1d0931a52ff269

Omit the unnecessary not-NULL check on the upper bound of a forward index range scan. The subsequent OP_IdxGT will always catch the NULL. Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL. FossilOrigin-Name: e51ecadcbdef5ce6e41d68412aee70aa4a1416c850358a6fa7e9a1ab443e719d

view details

drh

commit sha f0b41745c5142a4c1c8ad311a4b15330284264c8

Avoid unnecessary calls to the sqlite3GetVdbe() routine. Add assert() statements to prove each call is unnecessary. FossilOrigin-Name: 86d3790caf92e9cb7a9aaaa110f309b4b6945ac30cfd53fc3e5aa1ec3075ada5

view details

drh

commit sha 289a0c849b7d0a2242089d4a06cfb5a16284a40d

Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s. FossilOrigin-Name: b7dc932197665f0ebde3ffb8f0785c22da07ce307cfd5f0eab69e86e4b38fcde

view details

drh

commit sha 45d827cb6aaf9c2ac4392a4781ca7010be1f69d2

Optimization of the sqlite3SrcListDelete() routine. FossilOrigin-Name: 1b4acd1ac4a8d24f8804c6d0770f5b0022f569d51742b6954b26e525f04d38ca

view details

drh

commit sha 1d8f892a31e750f3e7247c74e07acfd4cadba9e8

Optimization to sqlite3BeginWriteOperation(). FossilOrigin-Name: 2173d4c6e3addc75964508f2fc8e42755376b3bc285286fa90df4831a6fa280b

view details

push time in a day

push eventsqlite/sqlite

drh

commit sha 24c22753fc88cdba0d6d437977698ae192bc2c9d

Remove an unused #define from sqliteInt.h. FossilOrigin-Name: d5b254f94c1ce6f0f26024d0b9c80e610f7cc891360bc4c2cb116e9eda2874b3

view details

drh

commit sha 8c1fbe81d01e711f14130798fa8b11b79849aa77

Minor comment fixes. No changes to code. FossilOrigin-Name: 533aeb90085d989078073067172135db98e37e00be84f99757255858126196e4

view details

dan

commit sha 91faeec8d095f494852b15952a9835b740045ac8

Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. FossilOrigin-Name: 7dfb74c37e678dde347d9d85846672f82ad282e300e32676330b764be2e4d580

view details

drh

commit sha 4dfdb86c8d85b008dd74d9184e81bf3d206e9758

New test cases for the use of the ieee754 and decimal extensions in the CLI. FossilOrigin-Name: bc1590f32fc4e2696b4126bd0302cb6405031dd4f55b86f3f1611f7f39299f85

view details

drh

commit sha c08716a317ee00de91537da8d2f44092cd0896c0

Fix harmless USAN warnings from gcc9. FossilOrigin-Name: 72c4c69fea13f5e24df25645e6941ce3ff896f0a3c73cd63329f819cc907ab40

view details

drh

commit sha b6a74caf9302c0b4f25b461e552cd36df0b9b439

Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. FossilOrigin-Name: 41de742c5713ab1a0c0c15c44af3ffac40bbc527ae2dc11d829ba9773eb4c84a

view details

drh

commit sha a3e6495970590691f05c6fe0057637c1b2bfe6bb

Improvement on the previous fix. FossilOrigin-Name: f6cffa2d50bfebe5b025f412b7a49b7fdafb798aaf1ddc80e6656ccd1f012a7f

view details

dan

commit sha 96e337df6b87c1c731cdf0bad5e2611f93030cae

Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory. FossilOrigin-Name: b050976079ba4a22d4dfeadb81f40cf71da6588c95bf2b634d88b416de5accd7

view details

drh

commit sha ef215fbf3b581ef4e0273bb3932fa522af88fd7e

Version 3.33.0 FossilOrigin-Name: fca8dc8b578f215a969cd899336378966156154710873e68b3d9ac5881b0ff3f

view details

dan

commit sha e0404386f265f2af09777eefb21f97f9333b95bb

Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests. FossilOrigin-Name: 613fb5c2525be77e48bad0a74e8b7bf53489365060fb9c7713a0caddb1820c71

view details

drh

commit sha 5e6d90fe15e0c8be357008f9e5ff6afba0662c0b

Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks. FossilOrigin-Name: 2f7cb6ab39e54fd6eb3a280d3022c3d4f4ed92e83af7226e63e0199a96397a6b

view details

drh

commit sha 68c0c71065354a2c06e3283f0a2f1758afec5aba

For UPDATE and DELETE, use OP_DeferredSeek always. If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed. This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing. FossilOrigin-Name: a495f60d315e34b1a1bc5fb1336e05047add52c8fb2710b577c97b10a5e734f6

view details

drh

commit sha f8556d0106e57c1599a6e4171a9e5f3ed1e81822

Optimizations to the logic that converts main table accesses into equivalent index accesses. Code is now slightly smaller and faster than trunk. FossilOrigin-Name: 611b640442025e57b8e161f8ddac1f19bd3be9a3d5266f4cef287595c3ed9257

view details

drh

commit sha a3d6d6a93fc87eba1ccb52d6f72d79ab6b378f69

Update the version number to 3.34.0 for the next development cycle. FossilOrigin-Name: 70f34f3df5358d36c8578afbc05756450c46da36b8dce339ed87fc0b9d4057cb

view details

drh

commit sha 861889e4f8e63e5f9f7508419fe01fe5de8ccb49

When doing an UPDATE or DELETE using a multi-column index where only a few of the earlier columns of the index are useful for the index lookup, postpone doing the main table seek until after all WHERE clause constraints have been evaluated, in case those constraints can be covered by unused later terms of the index, thus avoiding unnecessary main table seeks. FossilOrigin-Name: 7fee0b1075d622835dc6828c061be516102da9e2809f52d9ab7c4bbef7dfb871

view details

drh

commit sha 398221e2ad4b553621df09d73b1d0931a52ff269

Omit the unnecessary not-NULL check on the upper bound of a forward index range scan. The subsequent OP_IdxGT will always catch the NULL. Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL. FossilOrigin-Name: e51ecadcbdef5ce6e41d68412aee70aa4a1416c850358a6fa7e9a1ab443e719d

view details

drh

commit sha f0b41745c5142a4c1c8ad311a4b15330284264c8

Avoid unnecessary calls to the sqlite3GetVdbe() routine. Add assert() statements to prove each call is unnecessary. FossilOrigin-Name: 86d3790caf92e9cb7a9aaaa110f309b4b6945ac30cfd53fc3e5aa1ec3075ada5

view details

drh

commit sha 289a0c849b7d0a2242089d4a06cfb5a16284a40d

Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s. FossilOrigin-Name: b7dc932197665f0ebde3ffb8f0785c22da07ce307cfd5f0eab69e86e4b38fcde

view details

drh

commit sha 45d827cb6aaf9c2ac4392a4781ca7010be1f69d2

Optimization of the sqlite3SrcListDelete() routine. FossilOrigin-Name: 1b4acd1ac4a8d24f8804c6d0770f5b0022f569d51742b6954b26e525f04d38ca

view details

drh

commit sha 1d8f892a31e750f3e7247c74e07acfd4cadba9e8

Optimization to sqlite3BeginWriteOperation(). FossilOrigin-Name: 2173d4c6e3addc75964508f2fc8e42755376b3bc285286fa90df4831a6fa280b

view details

push time in a day

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class ProjectorServer private constructor(          selectedOption = JOptionPane.showOptionDialog(           null,-          "Somebody ($ipString) wants to connect with $accessType access. Allow the connection?",+          "Somebody (${getHostName(remoteAddress)}) wants to connect with $accessType access. Allow the connection?",

How does look a result of nslookup for that IP? Please, run in terminal:

nslookup x.x.x.x

IKupriyanov-HORIS

comment created time in a day

push eventJetBrains/projector-server

Ivan Kupriyanov

commit sha cd432093f1b397525e23d1ef3d640a2f525c668c

Fixes

view details

push time in a day

issue openedAlecStrong/sql-psi

Serial id not working when used in IN_MEMORY tests

Dialect: PostgreSQL

When used against an actual postgres database everything seems to work correctly.. but when used in testing it does not work. I tried to simplify the example as much as possible:

OneEntity.sq:

CREATE TABLE IF NOT EXISTS oneEntity (
    id SERIAL PRIMARY KEY,
    name TEXT NOT NULL
);

insert:
INSERT INTO oneEntity(name)
VALUES (?);

selectAll:
SELECT * FROM oneEntity;

This would be the test:

@SpringBootTest(classes = [TestAppConfig::class], properties = ["spring.main.allow-bean-definition-overriding=true"])
@AutoConfigureMockMvc
class OneEntityTest : TestEnv() {

  init {
    test("Insert one entity") {
      database.run {
        oneEntityQueries.transaction {
          oneEntityQueries.insert("name1")
          oneEntityQueries.insert("name2")
          oneEntityQueries.insert("name3")
        }
        oneEntityQueries.selectAll().executeAsList().map {
          println(it)
        }
      }
    }
  }
}

TestEnv has the database:

  @Autowired
  lateinit var database: EntertainmentDb

And the configuration:

@TestConfiguration
class TestAppConfig : AppConfig() {

//  @Bean
//  override fun provideDataSource(): DataSource =
//    DataSourceBuilder.create()
//      .apply {
//        url("jdbc:sqlite:src/main/sqldelight/db/1.db")
////        url("jdbc:sqlite::memory:")
//        username("postgres")
//        password("postgres")
//      }.build()

  @Bean
  override fun provideDatabase(dataSource: DataSource, technologyKeywordAdapter: TechnologyEntity.Adapter): EntertainmentDb =
    EntertainmentDb(
      // driver = dataSource.asJdbcDriver()
      driver = JdbcSqliteDriver(JdbcSqliteDriver.IN_MEMORY)
        .apply {
          EntertainmentDb.Schema.create(this)
        },
      technologyEntityAdapter = technologyKeywordAdapter
    )
}

As you can see, I've tried using the IN_MEMORY database.. but also providing a dataSource 🙆🏻‍♂️

Should I look for an alternative for testing? Like h2 ? I would love some recommendations if above doesn't work.. 🙏

Let me know if you need more information in order to mimic the scenario, thanks in advance!

PS: As said, that works against a real database and I can see the sequence for the serial id is there

entertainmentdb=# \d
                   List of relations
 Schema |          Name           |   Type   |  Owner   
--------+-------------------------+----------+----------
 public | oneentity               | table    | postgres
 public | oneentity_id_seq        | sequence | postgres
 public | technologyentity        | table    | postgres
 public | technologyentity_id_seq | sequence | postgres
(4 rows)

created time in a day

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class SessionDialog(project: Project?) : DialogWrapper(project) {       NetworkInterface.getNetworkInterfaces()         .asSequence()         .filterNotNull()-        .filterNot { it.isLoopback }-        .filterNot {-          it.hardwareAddress != null-            &&-            it.hardwareAddress.sliceArray(0..1).contentEquals(dockerVendor)-        }+        .filterNot { it.isLoopback } // drop localhost+        .filterNot { it.hardwareAddress != null && it.hardwareAddress.sliceArray(0..1).contentEquals(dockerVendor) } // drop docker         .flatMap { it.interfaceAddresses?.asSequence()?.filterNotNull() ?: emptySequence() }-        .mapNotNull { (it.address as? Inet4Address)?.hostName }+        .mapNotNull { ProjectorServer.getHostName(it.address) }

Maybe we should do something like .toSet() additionally before adding items because now I have a list containing my hostname twice.

IKupriyanov-HORIS

comment created time in a day

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class ProjectorServer private constructor(          selectedOption = JOptionPane.showOptionDialog(           null,-          "Somebody ($ipString) wants to connect with $accessType access. Allow the connection?",+          "Somebody (${getHostName(remoteAddress)}) wants to connect with $accessType access. Allow the connection?",

I get IP here... Testing in my LAN. If you think something can be easily improved, let's do it in this PR.

IKupriyanov-HORIS

comment created time in a day

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 class ProjectorServer private constructor(       return     } -    val ipString = conn.remoteSocketAddress?.address?.hostAddress+    val remoteAddress = conn.remoteSocketAddress?.address+    check(remoteAddress != null) { "Remote address is null!" } // drop nullability

I think we should handle this situation better because now a user can't do anything if they receive this "Remote address is null!" exception. And it seems possible that address contains null – we have a similar report: https://youtrack.jetbrains.com/issue/PRJ-212 . With this change, PRJ-212 can fail here too.

So my proposal is to handle nullability: if it's null, we can output something like Somebody (can't determine the host's name or IP) wants to connect with $accessType access. Allow the connection?

IKupriyanov-HORIS

comment created time in a day

Pull request review commentJetBrains/projector-server

PRJ-125 Use DNS names everywhere

 dependencies {   implementation("com.github.JetBrains.projector-client:projector-server-core:$projectorClientVersion")   implementation("com.github.JetBrains.projector-client:projector-util-logging:$projectorClientVersion")   api project(":projector-awt")+  implementation("dnsjava:dnsjava:2.1.9")

Please move the version into gradle.properties.

IKupriyanov-HORIS

comment created time in a day

push eventsqlite/sqlite

drh

commit sha 24c22753fc88cdba0d6d437977698ae192bc2c9d

Remove an unused #define from sqliteInt.h. FossilOrigin-Name: d5b254f94c1ce6f0f26024d0b9c80e610f7cc891360bc4c2cb116e9eda2874b3

view details

drh

commit sha 8c1fbe81d01e711f14130798fa8b11b79849aa77

Minor comment fixes. No changes to code. FossilOrigin-Name: 533aeb90085d989078073067172135db98e37e00be84f99757255858126196e4

view details

dan

commit sha 91faeec8d095f494852b15952a9835b740045ac8

Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page. FossilOrigin-Name: 7dfb74c37e678dde347d9d85846672f82ad282e300e32676330b764be2e4d580

view details

drh

commit sha 4dfdb86c8d85b008dd74d9184e81bf3d206e9758

New test cases for the use of the ieee754 and decimal extensions in the CLI. FossilOrigin-Name: bc1590f32fc4e2696b4126bd0302cb6405031dd4f55b86f3f1611f7f39299f85

view details

drh

commit sha c08716a317ee00de91537da8d2f44092cd0896c0

Fix harmless USAN warnings from gcc9. FossilOrigin-Name: 72c4c69fea13f5e24df25645e6941ce3ff896f0a3c73cd63329f819cc907ab40

view details

drh

commit sha b6a74caf9302c0b4f25b461e552cd36df0b9b439

Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. FossilOrigin-Name: 41de742c5713ab1a0c0c15c44af3ffac40bbc527ae2dc11d829ba9773eb4c84a

view details

drh

commit sha a3e6495970590691f05c6fe0057637c1b2bfe6bb

Improvement on the previous fix. FossilOrigin-Name: f6cffa2d50bfebe5b025f412b7a49b7fdafb798aaf1ddc80e6656ccd1f012a7f

view details

dan

commit sha 96e337df6b87c1c731cdf0bad5e2611f93030cae

Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory. FossilOrigin-Name: b050976079ba4a22d4dfeadb81f40cf71da6588c95bf2b634d88b416de5accd7

view details

drh

commit sha ef215fbf3b581ef4e0273bb3932fa522af88fd7e

Version 3.33.0 FossilOrigin-Name: fca8dc8b578f215a969cd899336378966156154710873e68b3d9ac5881b0ff3f

view details

dan

commit sha e0404386f265f2af09777eefb21f97f9333b95bb

Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests. FossilOrigin-Name: 613fb5c2525be77e48bad0a74e8b7bf53489365060fb9c7713a0caddb1820c71

view details

drh

commit sha 5e6d90fe15e0c8be357008f9e5ff6afba0662c0b

Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks. FossilOrigin-Name: 2f7cb6ab39e54fd6eb3a280d3022c3d4f4ed92e83af7226e63e0199a96397a6b

view details

drh

commit sha 68c0c71065354a2c06e3283f0a2f1758afec5aba

For UPDATE and DELETE, use OP_DeferredSeek always. If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed. This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing. FossilOrigin-Name: a495f60d315e34b1a1bc5fb1336e05047add52c8fb2710b577c97b10a5e734f6

view details

drh

commit sha f8556d0106e57c1599a6e4171a9e5f3ed1e81822

Optimizations to the logic that converts main table accesses into equivalent index accesses. Code is now slightly smaller and faster than trunk. FossilOrigin-Name: 611b640442025e57b8e161f8ddac1f19bd3be9a3d5266f4cef287595c3ed9257

view details

drh

commit sha a3d6d6a93fc87eba1ccb52d6f72d79ab6b378f69

Update the version number to 3.34.0 for the next development cycle. FossilOrigin-Name: 70f34f3df5358d36c8578afbc05756450c46da36b8dce339ed87fc0b9d4057cb

view details

drh

commit sha 861889e4f8e63e5f9f7508419fe01fe5de8ccb49

When doing an UPDATE or DELETE using a multi-column index where only a few of the earlier columns of the index are useful for the index lookup, postpone doing the main table seek until after all WHERE clause constraints have been evaluated, in case those constraints can be covered by unused later terms of the index, thus avoiding unnecessary main table seeks. FossilOrigin-Name: 7fee0b1075d622835dc6828c061be516102da9e2809f52d9ab7c4bbef7dfb871

view details

drh

commit sha 398221e2ad4b553621df09d73b1d0931a52ff269

Omit the unnecessary not-NULL check on the upper bound of a forward index range scan. The subsequent OP_IdxGT will always catch the NULL. Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL. FossilOrigin-Name: e51ecadcbdef5ce6e41d68412aee70aa4a1416c850358a6fa7e9a1ab443e719d

view details

drh

commit sha f0b41745c5142a4c1c8ad311a4b15330284264c8

Avoid unnecessary calls to the sqlite3GetVdbe() routine. Add assert() statements to prove each call is unnecessary. FossilOrigin-Name: 86d3790caf92e9cb7a9aaaa110f309b4b6945ac30cfd53fc3e5aa1ec3075ada5

view details

drh

commit sha 289a0c849b7d0a2242089d4a06cfb5a16284a40d

Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s. FossilOrigin-Name: b7dc932197665f0ebde3ffb8f0785c22da07ce307cfd5f0eab69e86e4b38fcde

view details

drh

commit sha 45d827cb6aaf9c2ac4392a4781ca7010be1f69d2

Optimization of the sqlite3SrcListDelete() routine. FossilOrigin-Name: 1b4acd1ac4a8d24f8804c6d0770f5b0022f569d51742b6954b26e525f04d38ca

view details

drh

commit sha 1d8f892a31e750f3e7247c74e07acfd4cadba9e8

Optimization to sqlite3BeginWriteOperation(). FossilOrigin-Name: 2173d4c6e3addc75964508f2fc8e42755376b3bc285286fa90df4831a6fa280b

view details

push time in a day

issue commentcashapp/sqldelight

Flow extension is not working as expected

Hi. I managed to find the cause. When I injected sql delight database via DI I didn't mark it as singleton. The instance of database from which I made query of list was different from query of delete cmd.

rustamsmax

comment created time in a day

issue commentcashapp/sqldelight

Flow extension is not working as expected

Hi @JakeWharton Could you reproduce the bug?

rustamsmax

comment created time in a day

created repositoryjordansinger/welcome-screen-swiftui

created time in 2 days

created repositorythmsmlr/load-shedding

A demonstration of load shedding and how it can make your services more resilient in outages and come back online quicker

created time in 2 days

issue commentcashapp/sqldelight

No com.squareup.sqldelight.drivers.native.NativeSqliteDriver on iOS

The configuration in the kmm-networking-and-data-storage final works for me @chokokatana @sreexamus

...

    val iOSTarget: (String, KotlinNativeTarget.() -> Unit) -> KotlinNativeTarget =
        if (System.getenv("SDK_NAME")?.startsWith("iphoneos") == true)
            ::iosArm64
        else
            ::iosX64

    iOSTarget("ios") {
        binaries {
            framework {
                baseName = "shared"
            }
        }
    }

....

val packForXcode by tasks.creating(Sync::class) {
    group = "build"
    val mode = System.getenv("CONFIGURATION") ?: "DEBUG"
    val framework = kotlin.targets.getByName<KotlinNativeTarget>("ios").binaries.getFramework(mode)
    inputs.property("mode", mode)
    dependsOn(framework.linkTask)
    val targetDir = File(buildDir, "xcode-frameworks")
    from({ framework.outputDirectory })
    into(targetDir)
}
tasks.getByName("build").dependsOn(packForXcode)

sreexamus

comment created time in 2 days

issue openedcashapp/sqldelight

SqlDelightTask uses non-normalized paths and breaks Gradle build caching

Build Environment SQLDelight version: 1.4.4 OS: N/A Gradle version: 6.7 Kotlin version: N/A AGP Version (if applicable): N/A

Describe the bug After doing some simple local build caching tests with the same project in multiple locations, build scans revealed that SqlDelightTask is not up to date when it should be due to using non-normalized paths in its properties property

Namely - folder, outputDirectoryFile, and rootDirectory

Output from a simple snippet to print it

tasks.withType<SqlDelightTask>().configureEach {
  doFirst { println(properties) }
}
SqlDelight Properties for generateMainTelemetryDatabaseInterface
SqlDelightDatabasePropertiesImpl(packageName=slack.telemetry.internal.persistence, compilationUnits=[SqlDelightCompilationUnitImpl(name=main, sourceFolders=[SqlDelightSourceFolderImpl(folder=/Users/zsweers/dev/slack/slack-android-ng/telemetry/telemetry-db/src/main/sqldelight, dependency=false)])], className=TelemetryDatabase, dependencies=[], dialectPresetName=SQLITE_3_18, deriveSchemaFromMigrations=false, outputDirectoryFile=/Users/zsweers/dev/slack/slack-android-ng/telemetry/telemetry-db/build/generated/sqldelight/code/TelemetryDatabase, rootDirectory=/Users/zsweers/dev/slack/slack-android-ng/telemetry/telemetry-db)

created time in 2 days

push eventsqlite/sqlite

drh

commit sha 786142a994c1bd35e62e2b9621b035716943719d

If an amalgamation is created using SQLITE_ENABLE_UPDATE_DELETE_LIMIT, ensure that it can still be compiled without that option by setting the SQLITE_UDL_CAPABLE_PARSER flag in the preamble. FossilOrigin-Name: 5b905d7d7714d1d2c433ff58f5d6917d6d27302d44ca347aa740e768f1354b16

view details

drh

commit sha 4fb8452875d6053fa55bbe18c0fcea8c13ba4f31

Fix typo in the documentation for the new sqlite3_txn_state() interface. FossilOrigin-Name: 23f7d01758cbcf22bd34e78fb8284c7af18f3059a03c4ff6ab3e556ca11fce19

view details

drh

commit sha 94acc2ef42e3e908dd0afb9ae2309a7236f4ecff

Try again to fix the typo in the sqlite3_txn_state() documentation. FossilOrigin-Name: 6d1ab0403c2855b595f5d294305f41f56a7a93503f2a58d1b1d12431d480704e

view details

dan

commit sha 86f477edaa17767b39c7bae5b67cac8580f7a8c1

Catch fts5 index corruption caused by issuing 'delete' commands with incorrect data earlier in some cases. Also fix a couple of test script problems. FossilOrigin-Name: b79f19edfd33c2a75f936c352668e14e81f35acf4f07edc27a21f941a7304b38

view details

drh

commit sha ddcfe9210522ca4c5550b18b209df38c49a698f5

Do not invoke usleep() for more than 999999 microseconds. FossilOrigin-Name: 1f5ed852f25515bbc0a7aaf236fdef40fa7e31805eee1249277fde4e68f95130

view details

dan

commit sha b5a69238b42fff179af63a3d88ec8f3bf135543b

Fix a buffer overread found by OSSFuzz that could occur if a WITHOUT ROWID table with many columns was NATURAL JOINed against itself. FossilOrigin-Name: 3d35fa0be866213274fc09250225b345f6b08a9b4ec373d53d95e627e24512be

view details

drh

commit sha 18ef40e563e12e58402f87e5e5710001005da0d8

Fix harmless compiler warnings in Lemon. FossilOrigin-Name: 6c94ba4b1c16b676978808dcb24f63c2f22915af5dcfe9f635c037011affcf4b

view details

drh

commit sha d96e3821e4a14a0b41c32667d1642fcd7228c9fa

Fix a pair of assert()s in "PRAGMA foreign_key_check" that might have given a false-positive following an OOM. FossilOrigin-Name: 9ea3039b538ffd0f348c8fbc9452af1fbf899a1f668af9a2404bdd0f8dd21351

view details

drh

commit sha f1ea42556073c45dc07c31631f4cd12938761889

DISTINCT may not be ignored inside a UNION ALL common table expression. Fix for ticket [c51489c3b8f919c5] FossilOrigin-Name: 7d2b590d3abd66a7e6ae9046198eb669e0fd2f223f7691281e9ad795a12b8903

view details

drh

commit sha bc2e95140b7ff79b26a9ff78cd089e63df7d0fef

Prevent use-after-free of the u.vtab.idxStr string following an OOM while generating the OP_VFilter opcode. FossilOrigin-Name: 751fe4edb2d4602e652523c2759de3f4fffd29d5c66cae68caf45b30fd8b750a

view details

drh

commit sha f2fa084cf1104e9ec96d2dfc063952baafaf1883

Earlier detection of corruption in the rtreecheck() SQL function to prevent a (harmless) read of an uninitialized value. FossilOrigin-Name: e2074b24788149562b15022ccd2784d6649f08ebc41410e3bfb2401baf0892e2

view details

dan

commit sha 3acd3fb9d8bfe867c6e4015720569b23bffaf4fb

Fix a "jump depends on unitialized value" valgrind/asan error in fts5. FossilOrigin-Name: 66f94d623c16b4527e42f0519e32ec78eaf9ee6fd61ee7d0eb657cc59a8f7d68

view details

dan

commit sha f2e151aeab6944f057a6a96a3d59cbcc85dc6f50

Fix a problem in fts5 causing the in-memory hash table to be flushed more often than necessary. FossilOrigin-Name: 9a55601d072bcd1ac0f6f1633216c7c8b3ff3e037451e2cfd285cbe19b60b9fc

view details

dan

commit sha 39c7125a97bedcfa152aef8451dd2e6d258b6508

Fix a problem in sqlite-expert causing it to ignore equality constraints on the second or subsequent columns of a multi-column PRIMARY KEY. FossilOrigin-Name: c666c85a433fbc83edef4dbfb0399672e570f5d7979ab61cb39ff5488595d822

view details

dan

commit sha 68cffa65fba2f59d91e1da582e2a0b0fa7a4211a

Fix a typo in the documentation comment for sqlite3_preupdate_hook(). FossilOrigin-Name: 4542d194e2fef5e21e1c3679914bd9e21fab31cfb111cf640524fb3514a8afa3

view details

drh

commit sha 79d9af960b39c02be348b68b14f4a8736137a0e3

Attempt to silence harmless static analyzer warnings in Lemon and in the Lemon-generated parser. FossilOrigin-Name: de8ce22a46c90afa5475cd24c28b7a82b26410dc72d662af2f9d9e5e528e0eec

view details

drh

commit sha 9ca41fbfa93abb7f1e19790010cd270b0aa3870c

Remove a new assert() that the compiler finds is always true at compile-time, to avoid a compiler warning. FossilOrigin-Name: 8bbaee238593741da107b92b254cb5f0cf8b6bcc760bf2b25d20e46c8edee2a9

view details

dan

commit sha 7548ab20e631e4b6585e6016a79cd5abbb938d7e

In fts5 integrity checks, do not compare the contents of the index against an external content table unless specifically requested. FossilOrigin-Name: 782163693f37aeb65209bebbaeb6659a36881b8c4b4bec778b366658488bf966

view details

mistachkin

commit sha 273ee151217b04c640c1af148e36c518678c89fa

Fix harmless compiler warning seen with MSVC. FossilOrigin-Name: 4591ee03d7a1ef3f0f6ad0629493fdb7a1c0ddb3277a9e87aa244cb0ca770593

view details

drh

commit sha f573b4fb94e5f40143916b72f1a42c1b1f3a72ee

Avoid the possibility of integer overflow on the --pagecache option to the CLI. See [forum:10a2892377|forum post 10a2892377] FossilOrigin-Name: d3d13df31a97648f952beb2e1a783f947a80ec843227985ad9ebd14452d2f654

view details

push time in 2 days

more