profile
viewpoint

Abstraktikus/BlueWallet 0

Bitcoin thin client for iOS & Android. Built with React Native

pull request commentBlueWallet/BlueWallet

Translate '/loc/en.json' in 'sl_SI'

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/yb1qgq1krjzfkwjjn0hvndjakr

download apk

transifex-integration[bot]

comment created time in a month

pull request commentBlueWallet/BlueWallet

Translate '/loc/en.json' in 'fa_IR'

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/d4u0c91kh1b04w53jhrnw505br

download apk

transifex-integration[bot]

comment created time in a month

pull request commentBlueWallet/BlueWallet

REF: Removing Extra Spaces

Probably, but I don’t think that makes any difference on a technical level. Style-wise, the correct approach is to remove the spaces. Let’s see what Nuno thinks.

mcsaeid

comment created time in a month

pull request commentBlueWallet/BlueWallet

Capitalization – Part One

Thank you for the tip.

What do you think now?

mcsaeid

comment created time in a month

pull request commentBlueWallet/BlueWallet

REF: Removing Extra Spaces

not sure, someone put those spaces there, probably on purpose. @ncoelho thoughts?

mcsaeid

comment created time in a month

PR closed BlueWallet/BlueWallet

REF: Correcting “Input transaction hash”

Hash must be corrected to hex.

Since this is a title and not a phrase or sentence, all words must be capitalized, thus “Insert Transaction Hex.”

+1 -1

4 comments

1 changed file

mcsaeid

pr closed time in a month

pull request commentBlueWallet/BlueWallet

REF: Correcting “Input transaction hash”

no, it literally says Insert Input

mcsaeid

comment created time in a month

pull request commentBlueWallet/BlueWallet

Scanlndhook

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/reqmbd189bkf91qmpae1tc0a48

download apk

marcosrdz

comment created time in a month

PR opened BlueWallet/BlueWallet

Translate '/loc/en.json' in 'sl_SI'

The translations for the following file are now complete:

Parameter Value
Source file '/loc/en.json'
Translation file 'loc/sl_SI.json'
Language code 'sl_SI'
Transifex project slug bluewallet
Transifex resource slug loc-en-json--master
Transifex event review_completed
+6 -0

0 comment

1 changed file

pr created time in a month

push eventBlueWallet/BlueWallet

transifex-integration[bot]

commit sha e3f98b1ddd942cffba25e94e7f74734506c40954

Translate /loc/en.json in sl_SI review completed for the source file '/loc/en.json' on the 'sl_SI' language.

view details

push time in a month

create barnchBlueWallet/BlueWallet

branch : translations_loc-en-json--master_sl_SI

created branch time in a month

push eventBlueWallet/BlueWallet

transifex-integration[bot]

commit sha 767bc4bd2539e12aa2ec371a2a1ea5d4081d06b9

Translate /loc/en.json in fa_IR review completed for the source file '/loc/en.json' on the 'fa_IR' language.

view details

push time in a month

PR opened BlueWallet/BlueWallet

Translate '/loc/en.json' in 'fa_IR'

The translations for the following file are now complete:

Parameter Value
Source file '/loc/en.json'
Translation file 'loc/fa.json'
Language code 'fa_IR'
Transifex project slug bluewallet
Transifex resource slug loc-en-json--master
Transifex event review_completed
+55 -49

0 comment

1 changed file

pr created time in a month

create barnchBlueWallet/BlueWallet

branch : translations_loc-en-json--master_fa_IR

created branch time in a month

PR opened BlueWallet/BlueWallet

REF: Removing Extra Spaces

No spaces precede or follow slashes.

+2 -2

0 comment

1 changed file

pr created time in a month

pull request commentBlueWallet/BlueWallet

REF: Correcting “Input transaction hash”

Yes. “Insert Transaction Hex” is correct.

mcsaeid

comment created time in a month

PR opened BlueWallet/BlueWallet

Capitalization – Part Two

For more information on capitalization, please refer to “Capitalization – Part One.”

+61 -61

0 comment

1 changed file

pr created time in a month

PR opened BlueWallet/BlueWallet

Capitalization – Part One

Please note that these changes are not specific to one English style guide. These are what all style guides agree upon. Most of these words or phrases are titles. Let me know which one does not make sense for you, and I will provide links that you can read and make an informed decision. The rest will be changed in part two.

+34 -34

0 comment

1 changed file

pr created time in a month

pull request commentBlueWallet/BlueWallet

FIX: txs disappear and re-fetch if opened wallet too fast

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

Overtorment

comment created time in a month

push eventBlueWallet/BlueWallet

Overtorment

commit sha e38f0c41f9b4a2029321188c3f70d930f693e077

FIX: txs disappear and re-fetch if opened wallet too fast

view details

GLaDOS

commit sha 0473fbfe4cf6785fa43dd95ce0407031761ab659

Merge pull request #2284 from BlueWallet/fix-tx-disappear FIX: txs disappear and re-fetch if opened wallet too fast

view details

push time in a month

delete branch BlueWallet/BlueWallet

delete branch : fix-tx-disappear

delete time in a month

PR merged BlueWallet/BlueWallet

FIX: txs disappear and re-fetch if opened wallet too fast

curious side-effect of contextifying everything. fetchTransactions for single-addresses started with cleaning up internal variable, and BW would remove them from screen if you open single-address wallet too fast after launch

cc @limpbrains @marcosrdz

+4 -3

1 comment

1 changed file

Overtorment

pr closed time in a month

PR opened BlueWallet/BlueWallet

REF: Correcting Punctuation Marks

Periods, commas, dashes (hyphens and em dashes).

Notable Issues

  1. No comma is required after “please.”
  2. A period is required to end a sentence. A full sentence must have a full stop at the end.
  3. Incorrect use of the exclamation mark. Here is a quick read: grammarly.com/blog/exclamation-mark.
  4. When a sentence is followed by a dependent phrase, such as the one below, an em dash (—) is recommended instead of a comma: Example: This is your transaction's hex—signed and ready to be broadcasted to the network. (A dependent phrases such as “signed and ready to be broadcasted to the network” cannot stand on its own as a full sentence because it is not.)
  5. Extra space between the last word of the sentence and period, namely: “…has been saved in your Downloads folder .” The extra space must be omitted.

There is a reason for each specific change that I made, thus making all of the necessary. I would be happy to provide sources if necessary.

+55 -55

0 comment

1 changed file

pr created time in a month

push eventBlueWallet/BlueWallet

marcosrdz

commit sha 810795db64dfacf1f23baaceef81b5f601a237ef

ADD: Update UI if wallets context changes

view details

GLaDOS

commit sha cee135a183e3e55d0f24e7e16392f0025ba718a2

Merge pull request #2282 from BlueWallet/updateui ADD: Update UI if wallets context changes

view details

Ziya-Sadr

commit sha 985264609c83642b549c758bd9f3db21412039b7

Update broadcast.js

view details

marcosrdz

commit sha fe9945d4adf3050c291cc2fe19debe0f2a8d0771

Merge branch 'master' into scanlndhook

view details

push time in a month

pull request commentBlueWallet/BlueWallet

Update broadcast.js

thanks

Ziya-Sadr

comment created time in a month

push eventBlueWallet/BlueWallet

Ziya-Sadr

commit sha 985264609c83642b549c758bd9f3db21412039b7

Update broadcast.js

view details

push time in a month

PR merged BlueWallet/BlueWallet

Update broadcast.js

hash seems to be incorrect for this field. I changed it to Hex. I'm not a developer. so if I messed up sth, I'd like you to tell me how to change it correctly :)

+1 -1

0 comment

1 changed file

Ziya-Sadr

pr closed time in a month

pull request commentBlueWallet/BlueWallet

REF: Correcting “Input transaction hash”

probably typo

mcsaeid

comment created time in a month

pull request commentBlueWallet/BlueWallet

REF: Correcting “Input transaction hash”

"Insert Input Transaction Hex" ?

mcsaeid

comment created time in a month

pull request commentBlueWallet/BlueWallet

FIX: scan multisig cosigner in formats: plain Zpub, wallet descriptor

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/yn4c96tjpwb2228pd5xzwabmt0

download apk

Overtorment

comment created time in a month

more