profile
viewpoint
Fawad Ali 9inpachi Islamabad, Pakistan fawadali.works A full stack developer trying to support the world of open source with his little efforts.

9inpachi/krit 8

A configurable personal website template for minimalists.

9inpachi/frit 2

Frit is a simple local search application which searches files and folders in a given directory.

9inpachi/notes 2

Notes for different things I learn

9inpachi/raw-united 2

RAW United is a web application and a review system which allows users to review items or add their own for review.

9inpachi/9inpachi.github.io 1

Personal website generated with https://github.com/9inpachi/krit

9inpachi/application-meeting 1

Meeting Application

9inpachi/application-recruitment 1

Recruitment Application

9inpachi/application-scripting-documentation 1

Application that dynamically discover script bindings and provide links to their reference documentation

9inpachi/cpp-video-library 1

A video library made in C++ using file handling. Features include playing videos, adding videos, and deleting videos.

9inpachi/developerFolio 1

Software Developer Folio that help you showcase your work and skills as a software developer ⚡️

push eventxwiki-contrib/api-rights

arcilli

commit sha d507fcdff840e9ec520e748b5bba332e4c53b316

RIGHTSAPI-1: Scaffolding of the rights API * added method for creating a BaseObject (XWikiRights) from a ReadableRule

view details

push time in 11 hours

push eventxwiki-contrib/api-rights

arcilli

commit sha 3c0daaaeb4a15d54ed82ed25fb38fe35b17301b2

RIGHTSAPI-1: Scaffolding of the rights API * initialized members in constructor

view details

push time in 2 days

push eventxwiki-contrib/api-rights

arcilli

commit sha 0e1aa68044df45e98810b619b4df39a0149db9ed

[MISC] Applied codestyle.

view details

push time in 2 days

push eventxwiki-contrib/api-rights

arcilli

commit sha 8a9fe26a251dec993fcb3981fbb0234f48ad4d4d

RIGHTSAPI-1: Scaffolding of the rights API * added default implementation for WritableSecurityRule * implemented methods from AbstractRightsWriter

view details

push time in 2 days

push eventxwiki-contrib/api-rights

arcilli

commit sha 7947e325e5ba1d0bb18f3028c01e6ef1382c4d24

Changed developerId.

view details

arcilli

commit sha 4176aae3aad45580198b261de3489e716ebd9bf9

[MISC] Applied codestyle

view details

arcilli

commit sha 85c0efd5115aed9f3cca2c9d1e1eed7c8f877929

[MISC] Applied codestyle.

view details

arcilli

commit sha 71f07a756591cc4d001940d837f1951025f3df4d

[MISC] Applied codestyle

view details

arcilli

commit sha 8f0a712e281d22395e5b8bd0a56cd6d5da82beb2

RIGHTSAPI-1: Scaffolding of the rights API * implemented methods from DefaultRightsReader

view details

arcilli

commit sha 5e1109f8512755266e77ab0850f610eaccaf5b79

[MISC] Added comment.

view details

push time in 5 days

issue closedHSF/phoenix

Visualise vertices

We need to visualise "vertices" (primary, secondary etc)

(I will expand on this - I just wanted to add it not to forget!)

closed time in 7 days

EdwardMoyse

issue commentHSF/phoenix

Visualise vertices

Done.

EdwardMoyse

comment created time in 7 days

issue openedHSF/phoenix

Colour tracks by the vertex to which they are associated.

Vertices know the tracks which were involved in their reconstruction. It should be possible to colour these tracks the same colour as the vertex.

(This is low priority, but just to put it out as an option).

created time in 7 days

issue openedHSF/phoenix

Tracks hide vertices when we zoom in

When we zoom in, the tracks are rendered as cylinders of fixed size and so they obscure the vertex (in the attached picture, there is a primary vertex from which most of the tracks are coming).

I think we should add an option for how to render tracks e.g.

  • Auto : use THREE.LOD to determine how to render, but with line for close and cylinder for far away. The issue here will be that LOD is presumably calculated from the centre of the object, which might well not work well with long tracks.
  • Line : force line only
  • Cylinder : force cylinder always

We could add the option first, and then Auto after, since then we could play with rendering options more easily.

image

created time in 7 days

issue openedHSF/phoenix

Optionally extend all tracks to a radius

I'm not quite sure how to implement this best, but I just wanted to make note of the problem.

In the ATLAS example, the CombinedInDetTracks have some measurements, and so are not propagated. But they do not reach out to the calorimeter (in turquoise). However the InDetTrackParticles_xAOD have no measurements and so they ARE propagated all the way out. It would be good to be able to optionally extend the first set of tracks too (i.e. make it an option on the collection).

image

created time in 7 days

push eventHSF/phoenix

Edward Moyse

commit sha 04dc545b3a65d990215ea0980b93ec01d8347a7c

feat(event-display): add ability to add parametrised geometry Adds two new functions: - buildGeometryFromParameters to EventDisplay - addGeometryFromParameters to ThreeManager This used to be in the original versions of Phoenix, but was dropped in the move to Angular.

view details

Edward Moyse

commit sha 8f91dbd16dcb3648fd66db20051a911d4abf0835

feat(app): Get GeometryDemo working again Use the new buildGeometryFromParameters function in EventDisplay Added some WIP instructions (which don't currently work).

view details

Fawad Ali

commit sha 4ffbd9b0af6fb5d2500ee2b1612a723677221079

fix(app): fix geometry demo code

view details

Edward Moyse

commit sha 6b3abcec3b9cf9268d4a609645d4f136ab1851c0

docs(event-display): add doc to addGeometryFromParameters

view details

EdwardMoyse

commit sha a03f49830bcc8317dbd61afaeb91d0afc469b201

Merge pull request #175 from HSF/fix-geometry-demo Fix geometry demo

view details

push time in 7 days

PR merged HSF/phoenix

Fix geometry demo

Get the geometry demo working properly again.

The problem was the code to draw parametrised geometry was lost in the move to angular. So I re-implemented this, and added two new functions:

  • buildGeometryFromParameters to EventDisplay
  • addGeometryFromParameters to ThreeManager

Thanks to @9inpachi for the help!

+106 -2

0 comment

5 changed files

EdwardMoyse

pr closed time in 7 days

Pull request review commentHSF/phoenix

Fix geometry demo

 export class ThreeManager {   public getObjectByName(objectName: string): Object3D {     return this.getSceneManager().getScene().getObjectByName(objectName);   }++  public addGeometryFromParameters(parameters: any): void {

Good point! Thanks!

I actually want to change any to specify the required parameters... but the main thing was to get this working before the presentation next week.

EdwardMoyse

comment created time in 7 days

push eventHSF/phoenix

Edward Moyse

commit sha 6b3abcec3b9cf9268d4a609645d4f136ab1851c0

docs(event-display): add doc to addGeometryFromParameters

view details

push time in 7 days

Pull request review commentHSF/phoenix

Fix geometry demo

 export class ThreeManager {   public getObjectByName(objectName: string): Object3D {     return this.getSceneManager().getScene().getObjectByName(objectName);   }++  public addGeometryFromParameters(parameters: any): void {

TODO: clean this interface up.

EdwardMoyse

comment created time in 7 days

push eventHSF/phoenix

Fawad Ali

commit sha 70f139fd23f5430b95aeb4741ff03b040cd40358

feat(app): enter fullscreen in screenshot mode

view details

Fawad Ali

commit sha 30b0383664419581a76457ab11189aa559fd911b

feat(event-display): ability to add geometry to a menu folder

view details

Fawad Ali

commit sha 6234655c3a5030088991787e91ddb67d9201bcf8

fix(app): use optional chaining for fullscreen in SS mode

view details

EdwardMoyse

commit sha 16b995eafcc7c5880c5c693eb58e8e904d80dc45

Merge pull request #173 from 9inpachi/feat-geometry-to-folder Ability to add geometry to a folder

view details

Edward Moyse

commit sha 640a6e3dea0029b5d484f1b1570018d1b2ef4108

fix(app): fix TrackML geometry Not rendered correctly due to incoherent normals

view details

Edward Moyse

commit sha dcf6cec2556c4fb880682ac1a3559bfd44050822

fix(event-display): make it possible to flat shade Set this to be the default.

view details

Edward Moyse

commit sha 40165643555f7789c825c6ba1c9bc1aaf9afb6f4

fix(app): renable trackML

view details

EdwardMoyse

commit sha ff7eacdfd7c6120a340693069a954589811c410d

Merge pull request #174 from EdwardMoyse/re-enable-TrackML Re enable track ml

view details

Edward Moyse

commit sha 04dc545b3a65d990215ea0980b93ec01d8347a7c

feat(event-display): add ability to add parametrised geometry Adds two new functions: - buildGeometryFromParameters to EventDisplay - addGeometryFromParameters to ThreeManager This used to be in the original versions of Phoenix, but was dropped in the move to Angular.

view details

Edward Moyse

commit sha 8f91dbd16dcb3648fd66db20051a911d4abf0835

feat(app): Get GeometryDemo working again Use the new buildGeometryFromParameters function in EventDisplay Added some WIP instructions (which don't currently work).

view details

Fawad Ali

commit sha 4ffbd9b0af6fb5d2500ee2b1612a723677221079

fix(app): fix geometry demo code

view details

push time in 7 days

PR opened HSF/phoenix

Fix geometry demo

Get the geometry demo working properly again

Thanks to @9inpachi for the help!

+103 -2

0 comment

5 changed files

pr created time in 8 days

issue commentHSF/phoenix

Antialiasing issues

I think in general we should probably aim to have some more options/toggles, but this sounds like a good solution for now.

9inpachi

comment created time in 8 days

issue commentHSF/phoenix

Antialiasing issues

Are you proposing that antialiasing would automatically disable itself if a user selects the pick icon? That could be worth a try ...

9inpachi

comment created time in 8 days

push eventHSF/phoenix

Edward Moyse

commit sha 640a6e3dea0029b5d484f1b1570018d1b2ef4108

fix(app): fix TrackML geometry Not rendered correctly due to incoherent normals

view details

Edward Moyse

commit sha dcf6cec2556c4fb880682ac1a3559bfd44050822

fix(event-display): make it possible to flat shade Set this to be the default.

view details

Edward Moyse

commit sha 40165643555f7789c825c6ba1c9bc1aaf9afb6f4

fix(app): renable trackML

view details

EdwardMoyse

commit sha ff7eacdfd7c6120a340693069a954589811c410d

Merge pull request #174 from EdwardMoyse/re-enable-TrackML Re enable track ml

view details

push time in 8 days

PR merged HSF/phoenix

Re enable track ml

There's no real reason to have this disabled, now that I fixed the geometry (it wasn't showing because the normals weren't correct - I cleaned them up in MeshLab).

Performance isn't great - I tried moving to MeshLambertMaterial etc but this doesn't help (and looks bad)

I noticed that setFlat wasn't being propagated down, and so I fixed this. I think the geometry loaders could still do with a bit of a cleanup though!

+582081 -388643

0 comment

9 changed files

EdwardMoyse

pr closed time in 8 days

PR opened HSF/phoenix

Re enable track ml

There's no real reason to have this disabled.

Performance isn't great - I tried moving to MeshLambertMaterial etc but this doesn't help (and looks bad)

I noticed that setFlat wasn't being propagated down, and so I fixed this. I think the geometry loaders could still do with a bit of a cleanup though!

+582081 -388643

0 comment

9 changed files

pr created time in 8 days

CommitCommentEvent

create barnchHSF/phoenix

branch : fix-geometry-demo

created branch time in 8 days

push eventHSF/phoenix

Fawad Ali

commit sha 70f139fd23f5430b95aeb4741ff03b040cd40358

feat(app): enter fullscreen in screenshot mode

view details

Fawad Ali

commit sha 30b0383664419581a76457ab11189aa559fd911b

feat(event-display): ability to add geometry to a menu folder

view details

Fawad Ali

commit sha 6234655c3a5030088991787e91ddb67d9201bcf8

fix(app): use optional chaining for fullscreen in SS mode

view details

EdwardMoyse

commit sha 16b995eafcc7c5880c5c693eb58e8e904d80dc45

Merge pull request #173 from 9inpachi/feat-geometry-to-folder Ability to add geometry to a folder

view details

push time in 9 days

PR merged HSF/phoenix

Ability to add geometry to a folder

Closes #171

Hi,

Description

This adds support to add geometries to a folder / node in Phoenix menu. The geometries can also be added in multi level node hierarchies.

Added

  • Ability to add geometry to a menu folder
  • Ability to specify the folder hierarchy to add the geometry to multilevel Phoenix menu folder.

Misc

  • Full screen in screenshot mode

Usage

For example, if we want to add an OBJ geometry to the "Inner Detector" folder inside the "Detector" folder of Phoenix menu.

EventDisplay.loadOBJGeometry('path/to/object.obj', 'Geometry', 0xffffff, 'Inner Detector');

And if we want to add an OBJ geometry to the "Pixel" folder inside the "Inner Detector" folder which will be inside the "Detector" folder of Phoenix menu. The > works as a separator for specifying the hierarchy.

EventDisplay.loadOBJGeometry('path/to/object.obj', 'Geometry', 0xffffff, 'Inner Detector > Pixel');

Screenshot

this.eventDisplay.loadGLTFGeometry('assets/geometry/LHCb/lhcb.gltf', 'LHCb detector', 'Folder > Sub Folder');

image

+78 -32

1 comment

7 changed files

9inpachi

pr closed time in 9 days

issue closedHSF/phoenix

Make it possible to add geometry to a folder

For example, I would like to be able to do:

    this.eventDisplay.loadGLTFGeometry('ITK.gltf', 'Beam', "Inner Detector",1000);
    this.eventDisplay.loadGLTFGeometry('TRT.gltf', 'Beam', "Inner Detector",1000);

And have both of these appear under an Inner Detector sub-folder.

closed time in 9 days

EdwardMoyse

pull request commentHSF/phoenix

Ability to add geometry to a folder

Looks great!

9inpachi

comment created time in 9 days

issue commentHSF/phoenix

Make it possible to add geometry to a folder

Sorry I think I misread your initial message and actually we agree!

Just to check, taking Pixels as a concrete example, as a user the top level menu item you see is Geometry and then you would open Inner Detector and the finally click on Pixels to visualise them.

So, since Geometry is implied, this would become:

    this.eventDisplay.loadGLTFGeometry('Pixels.gltf', 'Inner Detector>Pixels',,1000);

And if we had more details to visualise it could be e.g.

    this.eventDisplay.loadGLTFGeometry('Pixels_Layer1.gltf', 'Inner Detector>Pixels>Pixel Layer 1',,1000);
EdwardMoyse

comment created time in 9 days

issue commentHSF/phoenix

Make it possible to add geometry to a folder

That’s a good idea! I think > is fine (as are the others!)

We could presumably make more than one sub-menu this way too ... but then it would probably make more sense to reverse the order i.e.

SubMenuLevel1 > SubMenuLevel2 > MenuItem

?

On Sat, 14 Nov 2020 at 12:01, Fawad Ali notifications@github.com wrote:

So I am thinking of a separator if we want to insert our geometry into a multilevel hierarchy. For example, "Inner Detector>More Inner Detector" will put the geometry inside the "More Inner Detector" folder which will be inside "Inner Detector" folder and the separator is >. Is this separator good? We can also use . or : as a separator. Not sure which will work better.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HSF/phoenix/issues/171#issuecomment-727188618, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTTQSN5N56PSTTP5ESKYYLSPZPSHANCNFSM4TUULVRA .

EdwardMoyse

comment created time in 11 days

more