profile
viewpoint

PR opened denoland/deno

Fix multiple error messages for a missing file

Deno prints the error message twice if it can't find the script to run. This patch fixes it.

+6 -4

0 comment

3 changed files

pr created time in 4 hours

push event95th/deno

Gurwinder Singh

commit sha 5deaca060e065a2b2b2480a2d4a7e2c42fe2653b

Fix multiple error messages for a missing file

view details

push time in 5 hours

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 5 hours

startedBurntSushi/ripgrep

started time in 5 hours

PR opened denoland/deno

Minor tweaks:
  1. Separate Snapshot and Script StartupData functions based on cfg "no-snapshot-init"
  2. Replace deprecated Once::ONCE_INIT with Once::new (https://github.com/rust-lang/rust/pull/61757)
  3. Elide lifetime
  4. Fix typos

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+60 -55

0 comment

2 changed files

pr created time in 4 days

push event95th/deno

95th

commit sha b12437645630ca8f4322836cfc73c1a3f346eb0c

Minor tweaks: 1. Separate Snapshot and Script StartupData functions based on cfg "no-snapshot-init" 2. Replace deprecated Once::ONCE_INIT with Once::new (https://github.com/rust-lang/rust/pull/61757) 3. Elide lifetime 4. Fix typos

view details

push time in 4 days

push event95th/deno

95th

commit sha 0ce2cd831eca47386db905848048d08b9ebb39fe

1. Separate Snapshot and Script StartupData functions based on cfg "no-snapshot-init" 2. Replace deprecated Once::ONCE_INIT with Once::new (https://github.com/rust-lang/rust/pull/61757) 3. Elide lifetime 4. Fix typos

view details

push time in 4 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 4 days

pull request commentrust-lang/rust

Fix Into trait docs links

@lzutao I've made the suggested changes

95th

comment created time in 7 days

push event95th/rust

Gurwinder Singh

commit sha 34188fb6367f8583560d353aae32f097ed0af51f

Fix Into trait links

view details

push time in 7 days

Pull request review commentrust-lang/rust

Fix docs display

 pub trait AsMut<T: ?Sized> { /// } /// ``` ///-/// It is important to understand that `Into` does not provide a [`From`] implementation-/// (as [`From`] does with `Into`). Therefore, you should always try to implement [`From`]-/// and then fall back to `Into` if [`From`] can't be implemented.+/// It is important to understand that [`Into`] does not provide a [`From`] implementation+/// (as [`From`] does with [`Into`]). Therefore, you should always try to implement [`From`]+/// and then fall back to [`Into`] if [`From`] can't be implemented. ///-/// Prefer using `Into` over [`From`] when specifying trait bounds on a generic function-/// to ensure that types that only implement `Into` can be used as well.+/// Prefer using [`Into`] over [`From`] when specifying trait bounds on a generic function+/// to ensure that types that only implement [`Into`] can be used as well. /// /// # Examples ///-/// [`String`] implements `Into<Vec<u8>>`:+/// [`String`] implements [`Into<Vec<u8>>`]:

I've removed the link from this one and update the one on Line 257.

95th

comment created time in 7 days

push event95th/rust

Gurwinder Singh

commit sha 5731eb805d74661a338ac24067eebe87b0fd3997

Update links

view details

push time in 7 days

issue openeddenoland/deno

Data race in deno_buf/SharedQueue

deno_buf should have a lifetime parameter, so that rust can do static checking of validity of the contained pointer (using PhantomData similar to deno_snapshot).

Because this is missing, we are able to do the following pointer leak in core/shared_queue.rs :

  pub fn as_deno_buf(&self) -> deno_buf {
    let ptr = self.bytes.as_ptr();
    let len = self.bytes.len();
    unsafe { deno_buf::from_raw_parts(ptr, len) }
  }

Also, in core/libdeno.rs:

/// deno_buf can not clone, and there is no interior mutability. /// This type satisfies Send bound.

I think there is. The SharedQueue side can modify the internals without any locking and since deno_buf has that leaked pointer, the reader of deno_buf can see data in inconsistent state.

created time in 7 days

issue commentdenoland/deno

Build failing on Visual Studio 2019: duplicate symbol

Glad to hear 2019 works

2019 does not work. 2017 does.

95th

comment created time in 8 days

pull request commentrust-lang/rust

Fix docs display

r? @GuillaumeGomez

95th

comment created time in 8 days

Pull request review commentrust-lang/rust

Fix docs display

 pub trait AsMut<T: ?Sized> { /// } /// ``` ///-/// It is important to understand that `Into` does not provide a [`From`] implementation-/// (as [`From`] does with `Into`). Therefore, you should always try to implement [`From`]-/// and then fall back to `Into` if [`From`] can't be implemented.+/// It is important to understand that [`Into`] does not provide a [`From`] implementation+/// (as [`From`] does with [`Into`]). Therefore, you should always try to implement [`From`]+/// and then fall back to [`Into`] if [`From`] can't be implemented. ///-/// Prefer using `Into` over [`From`] when specifying trait bounds on a generic function-/// to ensure that types that only implement `Into` can be used as well.+/// Prefer using [`Into`] over [`From`] when specifying trait bounds on a generic function+/// to ensure that types that only implement [`Into`] can be used as well. /// /// # Examples ///-/// [`String`] implements `Into<Vec<u8>>`:+/// [`String`] implements [`Into<Vec<u8>>`]:

@GuillaumeGomez Please let me know if this is ok

95th

comment created time in 8 days

issue closedrust-lang/rust

AsRef + Into bound not working in Nightly (2019-06-17)

Below code compiles on Rust 1.35.0 stable:

Code A:

fn foo(>) {
    let s = "hello world".to_string();
    bar(s.as_ref());
}

fn bar<T: AsRef<str> + Into<String>>(s: T) {
    println!("{}", s.into());
}

and following doesn't work on Rust 1.35.0 stable: Code B:

fn foo() {
    let s = "hello world".to_string();
    bar(&s);
}

fn bar<T: AsRef<str> + Into<String>>(s: T) {
    println!("{}", s.into());
}

But on nightly (2019-06-17) rust, Code B compiles while Code A doesn't.

closed time in 8 days

95th

issue commentrust-lang/rust

AsRef + Into bound not working in Nightly (2019-06-17)

Hm.. that explains the breaking behavior.. Thanks .

95th

comment created time in 8 days

Pull request review commentrust-lang/rust

Fix docs display

 pub trait AsMut<T: ?Sized> { /// ``` /// /// It is important to understand that `Into` does not provide a [`From`] implementation

Done

95th

comment created time in 9 days

Pull request review commentrust-lang/rust

Fix docs display

 pub trait AsMut<T: ?Sized> { /// A value-to-value conversion that consumes the input value. The /// opposite of [`From`]. ///-/// One should only implement `Into` if a conversion to a type outside the current crate is+/// One should only implement [`Into`] if a conversion to a type outside the current crate is /// required. Otherwise one should always prefer implementing [`From`] over `Into` because

Done

95th

comment created time in 9 days

push event95th/rust

Gurwinder Singh

commit sha 8debdabae7f56c61180d5441796feccc7a439b6a

Add more links

view details

push time in 9 days

pull request commentrust-lang/rust

Fix docs display

@GuillaumeGomez Do I need to create a separate link for Into<T> or the one for Into will work?

95th

comment created time in 9 days

pull request commentdenoland/deno

Add dyn to areas of core.

@kitsonk Nothing wrong. Just that the cloned instance is discarded in the method. I guess clone is fine here because it works without much noise.

kitsonk

comment created time in 9 days

Pull request review commentrust-lang/rust

Fix docs display

 pub trait AsMut<T: ?Sized> { /// # Generic Implementations /// /// - [`From`]`<T> for U` implies `Into<U> for T`-/// - `Into` is reflexive, which means that `Into<T> for T` is implemented+/// - [`Into`] is reflexive, which means that `Into<T> for T` is implemented

Thanks. PTAL

95th

comment created time in 9 days

push event95th/rust

Gurwinder Singh

commit sha 89e3f0786b6e73272f97f5c96bc190dd244ed6c2

Remove unused link

view details

push time in 9 days

push event95th/rust

Gurwinder Singh

commit sha 4e4d921767cbbc42fc46f0fe15a1d646b8631991

Add links

view details

push time in 9 days

PR opened rust-lang/rust

Fix docs display

https://doc.rust-lang.org/std/convert/trait.Into.html

+1 -1

0 comment

1 changed file

pr created time in 9 days

push event95th/rust

Gurwinder Singh

commit sha 9bca91c2f857acf6b383d594613acf8d97e59941

Fix docs display https://doc.rust-lang.org/std/convert/trait.Into.html

view details

push time in 9 days

fork 95th/rust

Empowering everyone to build reliable and efficient software.

https://www.rust-lang.org

fork in 9 days

pull request commentdenoland/deno

Add dyn to areas of core.

For now, we can use verbose turbofish, which works on both:

self.editor.add_history_entry(AsRef::<str>::as_ref(&line))
kitsonk

comment created time in 9 days

issue openedrust-lang/rust

AsRef + Into bound not working in Nightly (2019-06-17)

Below code compiles on Rust 1.35.0 stable:

Code A:

fn foo(>) {
    let s = "hello world".to_string();
    bar(s.as_ref());
}

fn bar<T: AsRef<str> + Into<String>>(s: T) {
    println!("{}", s.into());
}

and following doesn't work on Rust 1.35.0 stable: Code B:

fn foo() {
    let s = "hello world".to_string();
    bar(&s);
}

fn bar<T: AsRef<str> + Into<String>>(s: T) {
    println!("{}", s.into());
}

But on nightly (2019-06-17) rust, Code B compiles while Code A doesn't.

created time in 9 days

pull request commentdenoland/deno

Add dyn to areas of core.

@kitsonk &line doesn't work in current stable and as_ref doesn't in nightly. Looks like a bug in Rust.

kitsonk

comment created time in 9 days

pull request commentdenoland/deno

Add dyn to areas of core.

I think cloning is not required because if you look at the rustline's History implementation, it calls line.into which creates a new instance from the passed reference anyways.

kitsonk

comment created time in 9 days

pull request commentdenoland/deno

Add dyn to areas of core.

One more error on Nightly (2019-06-17):

error[E0283]: type annotations required: cannot resolve `std::string::String: std::convert::AsRef<_>`
  --> ../../cli\repl.rs:97:44
   |
97 |         self.editor.add_history_entry(line.as_ref());
   |                                            ^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.
ninja: build stopped: subcommand failed.

Fix:

self.editor.add_history_entry(&line);
kitsonk

comment created time in 9 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 9 days

issue commentdenoland/deno

Build failing: duplicate symbol

I tried again today with VS 2017 toolchain.. build works. That means we don't support VS 2019 at the moment (at least not for me).

95th

comment created time in 9 days

issue commentdenoland/deno

Build failing: duplicate symbol

Hi @ry. Any luck? Chromium actually prefers VS 2019. But deno seem to have stopped building with it. I think it may be an issue in the build scripts

95th

comment created time in 10 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 12 days

issue commentdenoland/deno

Building failing: duplicate symbol

I tried reverting only the v8 upgrade done on June 10th.

third_party -> git revert 92159ba506cf2fb87f4779bebeb07fd3463d0063
deno -> git revert 523ab6a929dacf4cdd692c1319173a1a49c642de

Build is working now. cc @piscisaureus

95th

comment created time in 12 days

issue commentdenoland/deno

Building failing: duplicate symbol

I am using Visual Studio 2019 (GYP_MSVS_VERSION=2019). It used to build with it before Jun 10. Today I tried checking out at an older commit.

PS C:\denodev\deno> git log -1
commit e0436975211202afadb1a8ccd7d5154694162f38 (HEAD -> master)
Author: Ryan Dahl <ry@tinyclouds.org>
Date:   Mon Jun 10 15:27:34 2019 -0400

    Expose dynamic import in core (#2472)

Submodules at:

PS C:\denodev\deno> git submodule status
 7b594236fbba04ee23d32ba3adf5ea68611cf2e7 build (remotes/origin/20190428_win_clang_depfile)
 68faf32f721d2a95c7b1c75661713c8118c077c7 js/deps/https/deno.land/std (20190520)
 72a4202a0341516115a92aa18951eb3010fb75fa third_party (remotes/origin/20190601_ts351-1-g72a4202a0)

Now it is building. So, something happened after this. One of change is v8 but I am not sure if that is the cause but chromium support VS 2019.

95th

comment created time in 12 days

issue commentdenoland/deno

Building failing: duplicate symbol

Sorry.. still the same error..

95th

comment created time in 14 days

issue commentdenoland/deno

Building failing: duplicate symbol

Yes. It worked yesterday. Now it doesn't seem to work at even at that commit.. Not sure why.

95th

comment created time in 14 days

issue commentdenoland/deno

Building failing: duplicate symbol

I am on Rust 1.35.0 only. I deleted the whole checkout and took a fresh one. Still got the same error

95th

comment created time in 14 days

issue openeddenoland/deno

Building failing: duplicate symbol

Build failing with:

ninja: Entering directory `C:\denodev\deno\target\debug'
[43/633] LINK flatc.exe flatc.exe.pdb
FAILED: flatc.exe flatc.exe.pdb
ninja -t msvc -e environment.x64 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./flatc.exe /PDB:./flatc.exe.pdb @./flatc.exe.rsp
lld-link: error: duplicate symbol: bool const std::_Is_integral<bool> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<char> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<signed char> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<unsigned char> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<wchar_t> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<char16_t> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<char32_t> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<short> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<unsigned short> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<int> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<unsigned int> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<long> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<unsigned long> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<__int64> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_integral<unsigned __int64> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_floating_point<float> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_floating_point<double> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::_Is_floating_point<long double> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::is_void_v<void> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: duplicate symbol: bool const std::is_void_v<void const> in obj/build_extra/flatbuffers/flatc/flatc_main.obj and in obj/build_extra/flatbuffers/compiler_files/cpp_generator.obj
lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see all errors)
[48/633] CC obj/build_extra/rust/ring-core/cpu-intel.obj
ninja: build stopped: subcommand failed.

created time in 14 days

fork 95th/synapse

Synapse BitTorrent Daemon

https://synapse-bt.org

fork in 15 days

PR opened denoland/deno

Removed unused method and update docs
+2 -13

0 comment

2 changed files

pr created time in 15 days

push event95th/deno

Gurwinder S

commit sha 47c267934c1d0cc4c37f3315c0736c1348f18add

Remove unused method Left out while resolving merge conflicts in #2476

view details

push time in 15 days

push event95th/deno

Gurwinder S

commit sha 88e3c34af7eb40cde7f77c76d6b14846dcbefd3e

Remove unused method Left out while resolving merge conflicts in #2476

view details

push time in 15 days

push event95th/deno

Gurwinder S

commit sha e2c29a5bf3c2a8355d06e7d15e6bf44dfd8df61d

Update docs

view details

push time in 15 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 15 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 16 days

push event95th/deno

迷渡

commit sha 3d67b9be642ad0ba7a2e1af2ecf5236d535e7b89

check `URLSearchParams.constructor`'s params (#2488)

view details

Neil Richter

commit sha 2e5210b462bf9e7d51690353c1a8de2cf9c71833

typo (#2489)

view details

Yoshiya Hinosawa

commit sha fb1fec0c9e431885a32ad729dc2c26e39e06540b

website: use pre-wrap (#2486)

view details

Ryan Dahl

commit sha 21cd33696f596e746d889c84bf90a6ea6465f6b2

Expose dynamic import in core (#2472)

view details

Ryan Dahl

commit sha 25c12d1cf59c2562e2e2c666d46de022fef4458e

Upgrade V8 to 7.7.37 (#2492)

view details

迷渡

commit sha a57eed8e258b9cb54527c4a34833cfb52d20d4d2

fix bug in URL (#2495)

view details

push time in 16 days

PR merged 95th/deno

Merge latest changes

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+351 -23

0 comment

15 changed files

95th

pr closed time in 16 days

PR opened 95th/deno

Merge latest changes

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+351 -23

0 comment

15 changed files

pr created time in 16 days

issue commentdenoland/deno

Major features necessary for 1.0

"deno fmt" is slow on the first run. It download a couple of large prettier bundles.

deno fmt right now combines "installation" by loading prettier bundles + formatting.

We can follow Rust's example for this. Rust's cargofmt is optional but you can download it using rustup component add cargofmt.

We can do something like deno install fmt (using denoland/deno_std#471) which would download the prettier bundles and compile them into cache. Only after this, user should be able to call deno fmt.

ry

comment created time in 16 days

issue openedLuminarys/synapse

Windows support

Is there a plan for supporting Windows platform?

Thanks

created time in 17 days

startedLuminarys/synapse

started time in 17 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 17 days

pull request commentdenoland/deno

Reuse RT for blocking tasks

@ry I am not sure why tests fail in CI. In particular, two tests test_compile_sync and test_bundle_sync get stuck. All tests run fine on my system (win 10). Thoughts?

Also, is the change in right direction? I was hoping the reduce block_on dependency to none but it is tightly coupled at some places.

95th

comment created time in 18 days

PR closed denoland/deno

Reuse RT for blocking tasks

Improves tokio_util::block_on to lazily create a separate runtime and submit the "synchronous" futures to it.

Previously each call to block_on creates:

  1. One spawning thread to create a new runtime
  2. N Runtime threads (N = number of logical CPU cores)

Now the runtime is created once lazily. Once the submitted future resolves, it send the response via channel to the waiting caller thread.

Note that this still does not prevent blocking of the caller thread.

+13 -10

1 comment

1 changed file

95th

pr closed time in 18 days

pull request commentdenoland/deno

Reuse RT for blocking tasks

Tests are passing in local but failed in CI.. closing this for now..

95th

comment created time in 18 days

PR opened denoland/deno

Reuse RT for blocking tasks

Improves tokio_util::block_on to lazily create a separate runtime and submit the "synchronous" futures to it.

Previously each call to block_on creates:

  1. One spawning thread to create a new runtime
  2. N Runtime threads (N = number of logical CPU cores)

Now the runtime is created once lazily. Once the submitted future resolves, it send the response via channel to the waiting caller thread.

Note that this still does not prevent blocking of the caller thread.

+13 -10

0 comment

1 changed file

pr created time in 18 days

push event95th/deno

95th

commit sha ce322f5351d094556d0e5828be84f0768634d801

Reduce threads by reusing RT for blocking tasks

view details

push time in 18 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 18 days

PR opened Luminarys/synapse

Use provided buffer in read to prevent creating array on each byte read

Small enhancement to prevent array creation on each byte read

+9 -9

0 comment

1 changed file

pr created time in 18 days

push event95th/synapse

95th

commit sha 02fde06f4d5a5c2408c9d3d35017b36fdf6c970f

Use provided buffer in read to prevent creating array on each byte read

view details

push time in 18 days

push event95th/synapse

Gurwinder S

commit sha 4c84e71c141f3baa27393402dd98d1100faaddfc

Update lib.rs

view details

push time in 18 days

push event95th/synapse

Gurwinder S

commit sha 553cacda77e61b02a255eb573b781858e0858b94

Provide buffer to read method Provide buffer parameter to the read method to reuse buffer instead of creating one at each byte read.

view details

push time in 18 days

fork 95th/synapse

Synapse BitTorrent Daemon

https://synapse-bt.org

fork in 18 days

pull request commentdenoland/deno

Reduce dependency on tokio_util::block_on and clean up

LGTM - thanks!

The real problematic block_on usage is here: https://github.com/denoland/deno/blob/5960e398ecab914effec821cc6da5f3a091fdb50/cli/ops.rs#L530-L533

Yes.. about that I couldn't understand why we had to block on fut when we're just returning a Future. Might as well returned Box::new(fut). Is there a reason for that?

95th

comment created time in 18 days

pull request commentdenoland/deno

Reduce dependency on tokio_util::block_on and clean up

@kitsonk I've made the update. Could you please review?

95th

comment created time in 18 days

push event95th/deno

Vincent LE GOFF

commit sha 0b50c698ad898cd8fbdd1dc21956d584887fd87a

Add special hit cfix #1898 (#2455)

view details

Bartek Iwańczuk

commit sha 6fa4d2e7597e2b581a95b6c503cb4c0859f1cefa

feat: bring back deno <script> (#2451)

view details

Ryan Dahl

commit sha e152dae006c941abd614cc31820981c629410d7c

RecursiveLoad shouldn't own the Isolate (#2453) This patch makes it so that RecursiveLoad doesn't own the Isolate, so Worker::execute_mod_async does not consume itself. Previously Worker implemented Loader, but now ThreadSafeState does. This is necessary preparation work for dynamic import (#1789) and import maps (#1921)

view details

Kurt Mackey

commit sha 341150266eef10b005388db4210571554bb4b931

add http proxy benchmark (#2462)

view details

Ryan Dahl

commit sha cbcb78f1884c675268cbce700e7d43bfd1b78481

libdeno: expose dynamic import (#2461)

view details

Kitson Kelly

commit sha e3b2205eba2851380a9a149071cb4fb7e8218b13

Cleanup compiler API (#2466)

view details

Michał Sabiniarz

commit sha 9bea576f3ea224ec72f371f6f0bc582171ca7890

Deno.core.evalContext & Deno.core.print fix (#2465)

view details

Kurt Mackey

commit sha 9a6cfd653d74ab23d9415e6ce67da22badb8101e

add tcp proxy benchmarks + split out website section for proxy req/s (#2464)

view details

Kurt Mackey

commit sha 4ea2df6759abf3a99e07fe720987805075c8a18b

http benchmarks with unique ports (#2471)

view details

Andy Hayden

commit sha 5960e398ecab914effec821cc6da5f3a091fdb50

make tests quieter (#2468) Don't mix every http request in with the tests output. Don't print that the file servers are starting unless -vv flag is passed. Capture the output of run with run_output which returns stdout, stderr and exit_code. Test against this rather than relying on sys.exit.

view details

gurv-s

commit sha 8e6db3c1ec570cb5a61072200938047c86fa6e65

Use static dispatch

view details

gurv-s

commit sha 0f7d585b07deb933b6c5135cc0cc754a08139f77

make op_create_worker async internally

view details

gurv-s

commit sha 4f632eb194ac072fdbf28769c9469d53725e68b7

Make print_file_info async

view details

gurv-s

commit sha 89693ffbc152582081c77bc8a0251796791e85ae

Remove tokio_util::block_on dep in compile_async and other cleanup

view details

push time in 18 days

pull request commentdenoland/deno

Reduce dependency on tokio_util::block_on and clean up

There are a lot of conflicts with master too, feels like you need to rebase at least.

I'll rebase and apply your suggestions.

95th

comment created time in 19 days

Pull request review commentdenoland/deno

Reduce dependency on tokio_util::block_on and clean up

 use deno::Op; use deno::PinnedBuf; use flatbuffers::FlatBufferBuilder; use futures;-use futures::Async;-use futures::Poll;-use futures::Sink;-use futures::Stream;+use futures::{future, Async, Poll, Sink, Stream};

I'll fix this

95th

comment created time in 19 days

Pull request review commentdenoland/deno

Reduce dependency on tokio_util::block_on and clean up

 where   } } -// TODO(ry) Move this to main.rs

The method is already in main.rs

95th

comment created time in 19 days

Pull request review commentdenoland/deno

Reduce dependency on tokio_util::block_on and clean up

 use crate::worker::Worker; use deno::v8_set_flags; use flags::DenoFlags; use flags::DenoSubcommand;-use futures::lazy;-use futures::Future;+use futures::{future, lazy, Future};

Thanks. I'll fix this

95th

comment created time in 19 days

PR opened denoland/deno

Reduce dependency on tokio_util::block_on and clean up

Reduce block_on dependencies and some clean up

  1. Use static dispatch for SourceMapGetter by making methods generic.
  2. execute_mod is no longer used except 3 tests. Its usage in ops.rs has been replaced with execute_mod_async
  3. fetch_module_meta_data_and_maybe_compile has been removed and its usage in main.rs has been replaced with fetch_module_meta_data_and_maybe_compile_async

Also, Isolate's terminate_execution test seems flaky.. It failed once or twice for me but passed in the next runs.

+115 -116

0 comment

5 changed files

pr created time in 19 days

push event95th/deno

gurv-s

commit sha acdace847b157bd671b500596422c86b5bd9c4a1

Remove tokio_util::block_on dep in compile_async

view details

push time in 19 days

push event95th/deno

gurv-s

commit sha 213c3c6fdc6f82efd462cad73682eac2f8719adc

Make print_file_info async

view details

push time in 19 days

push event95th/deno

gurv-s

commit sha d8aec2e3fd286adf82baaad9fe619d4a5dcde600

make op_create_worker async internally

view details

push time in 19 days

push event95th/deno

gurv-s

commit sha eda7ffd2aabdf3043040b652e07d4ba09fe810f1

Use static dispatch

view details

push time in 19 days

issue commentdenoland/deno

[Windows] Compiling from sources issue

The issue occurred for me as well on windows 10. It occurs because the symlinks such as build_overrides, buildtools, node_modules etc. are checked out as text files instead of actual links.

I resolved it by following zekth's suggestion to run following in with admin privileges:

git clone -c core.symlinks=true --recurse-submodules https://github.com/zekth/deno.git

Perhaps this should be mentioned in the "build from source" manual.

zekth

comment created time in 22 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 22 days

push event95th/deno

Kitson Kelly

commit sha a71305b4febc3d8db95d3d144ae3a64c023718f0

Handle compiler diagnostics in Rust (#2445)

view details

Gurwinder S

commit sha c5f04f15cedc6902cf177395ea21509f0c938bf5

Merge pull request #1 from denoland/master Handle compiler diagnostics in Rust (#2445)

view details

push time in 22 days

PR merged 95th/deno

Handle compiler diagnostics in Rust (#2445)

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+1045 -88

0 comment

16 changed files

95th

pr closed time in 22 days

PR opened 95th/deno

Handle compiler diagnostics in Rust (#2445)

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+1045 -88

0 comment

16 changed files

pr created time in 22 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 23 days

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

PR opened denoland/deno

Fix a small doc typo

Fixes a small typo in tokio_util.rs docs

+1 -1

0 comment

1 changed file

pr created time in 25 days

push event95th/deno

Gurwinder S

commit sha 34db38d2edb834a21ec8cf429e7d798fd204f98f

Fix a small doc typo

view details

push time in 25 days

fork 95th/deno

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

https://deno.land/

fork in 25 days

delete branch vehls/strutl

delete branch : revert-3-test

delete time in 2 months

push eventvehls/strutl

vehls

commit sha 2071287a02ab4202246c7bc20568e94ee2ed5aea

Revert "Update README.md"

view details

vehls

commit sha e7be01b9def634b7a3b1c7246fa05c8f05af3f95

Merge pull request #4 from vehls/revert-3-test Revert "Update README.md"

view details

push time in 2 months

PR merged vehls/strutl

Revert "Update README.md"

Reverts vehls/strutl#3

+0 -1

0 comment

1 changed file

vehls

pr closed time in 2 months

PR opened vehls/strutl

Revert "Update README.md"

Reverts vehls/strutl#3

+0 -1

0 comment

1 changed file

pr created time in 2 months

create barnchvehls/strutl

branch : revert-3-test

created branch time in 2 months

push eventvehls/strutl

Sandeep Saroha

commit sha 995bd047cafb3a57e0910946cc008ecf81e28801

Update README.md d

view details

vehls

commit sha 431d9e1737177c57ff190432f84b7164f407c878

Merge pull request #3 from sandysaroha/test Update README.md

view details

push time in 2 months

more