profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/0x80/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Thijs Koerselman 0x80 Vauxlab Utrecht, Netherlands http://www.vauxlab.com Freelance software engineer, music technologist, synth lover.

gatsbyjs/gatsby 50992

Build blazing fast, modern apps and websites with React

0x80/yurnalist 90

An elegant console reporter, borrowed from Yarn

0x80/firestore-mobx 4

Observable Firestore documents and collections using MobX

theodi/colleen 3

data art commission 2014

theodi/vending-machine 1

connection script for Vending Machine

0x80/diff-json 0

A javascript object diff tool

0x80/fire-command 0

A generic command response pattern for Firebase

0x80/gatsby-reasonml-site 0

A personal playground for learning ReasonML

0x80/nextjs-esm-example-2021 0

An example of how to use ESM with Next.js

startedmodulz/stitches

started time in 13 days

PullRequestReviewEvent

Pull request review commentminvws/nl-covid19-data-dashboard

A11y descriptions

 function AgeDemographicChartWithGenerics<T extends AgeDemographicDefaultValue>({    const { formatPercentage } = useIntl(); +  const { label, description, describedById } =+    useAccessibilityOptions(accessibility);

I don't agree that props == options. Props I think are like function arguments. Options are a special type of function argument that is optional and has properties that are all optional.

The use hook names normally have their name refer to what they return, and not what you pass in. So that's why I think useAccessiblityOptions is not a good choice because you pass in the options and return non-optional elements.

Whether we use a shorthand a11y or not, I don't mind much.

VWSCoronaDashboard4

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue commentTypeStrong/ts-node

ESM support: soliciting feedback

I am trying to execute a script as which lives inside a TS repo that can't have its package.json set to type module, so I've placed an extra package.json file with just type module next to the script file.

The script contains the code below, which seems to generate an error, but I have no idea why that would be.

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

$ node --loader ts-node/esm --experimental-specifier-resolution=node src/scripts/generate-sitemap.ts (node:47971) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time (Use node --trace-warnings ... to show where the warning was created)

/Users/me/Development/myproject/node_modules/ts-node/dist-raw/node-esm-resolve-implementation.js:771 throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base)); ^ Error: ERR_MODULE_NOT_FOUND ~ /Users/me/Development/myproject/packages/app/src/scripts/generate-sitemap.ts

I can't seem to find other relevant resources about this so I hope this is the right place to ask...

cspotcode

comment created time in a month

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha 18064c260c5c70f4ffa2410d8a0fce360c85f96c

Clean up

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha 5a044f2d720737c311bf297adf967cec49ed2feb

Clean up

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha 6c550d8be98380915165ef1bc053fd5157397e15

Disable incremental builds

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha db4af040cdecca14cb7e358e118a4fa4feb59435

Extend and clean up typescript configuration

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha 12d382b660c2f7f31545b00b300a92acf50eca81

Update readme

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha e633db0bc303226505da00071ff814eb0c1cbbf2

Make it all work with Typescript

view details

Thijs Koerselman

commit sha e295d328383bd918c2c0893d7b60725b96b3a9f0

Update readme

view details

push time in 2 months

create barnch0x80/nextjs-esm-example-2021

branch : topic/use-typescript

created branch time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha ec59a0d4aef6bf5a4b790988bb925c12e6ba56f2

Move server.mjs out of src dir

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha bacc74c360c8438d5c2b30f6f3550a8a271c1bd9

Use src dir and add eslint config for nextjs 11

view details

push time in 2 months

push event0x80/nextjs-esm-example-2021

Thijs Koerselman

commit sha ac37d18b615ad65878487620eb435eeefe42c9a1

Upgrade deps

view details

Thijs Koerselman

commit sha d086828fe6f46811b2e0d46d4e5db828d687757f

Improve readme

view details

push time in 2 months

create barnch0x80/nextjs-esm-example-2021

branch : master

created branch time in 2 months

created repository0x80/nextjs-esm-example-2021

An example of how to use ESM with Next.js

created time in 2 months

PullRequestReviewEvent

Pull request review commentminvws/nl-covid19-data-dashboard

Add situations data coverage choropleth

+import {+  SafetyRegionProperties,+  VrCollectionSituations,+} from '@corona-dashboard/common';+import css from '@styled-system/css';+import Check from '~/assets/check.svg';+import Cross from '~/assets/cross.svg';+import { Box } from '~/components/base';+import { SafetyRegionChoropleth } from '~/components/choropleth/safety-region-choropleth';+import { FullscreenChartTile } from '~/components/fullscreen-chart-tile';+import { Markdown } from '~/components/markdown';+import { Heading, Text } from '~/components/typography';+import { useIntl } from '~/intl';+import { replaceVariablesInText } from '~/utils/replace-variables-in-text';+import { useReverseRouter } from '~/utils/use-reverse-router';+import { LegendIcon } from './components/legend-icon';+import { SituationsDataCoverageTooltip } from './components/situations-data-coverage-tooltip';++interface SituationsDataCoverageChoroplethTileProps {+  data: {+    vr: {+      situations: VrCollectionSituations[];+    };+  };+}++export function SituationsDataCoverageChoroplethTile({+  data,+}: SituationsDataCoverageChoroplethTileProps) {+  const { siteText, formatDateSpan } = useIntl();+  const reverseRouter = useReverseRouter();++  const text = siteText.brononderzoek;+  const singleValue = data.vr.situations[0];++  const [date_from, date_to] = formatDateSpan(+    { seconds: singleValue.date_start_unix },+    { seconds: singleValue.date_end_unix }+  );++  return (+    <FullscreenChartTile+      metadata={{+        date: [singleValue.date_start_unix, singleValue.date_end_unix],

nit-nit-v2 same for these singleValue ones.

VWSCoronaDashboard1

comment created time in 2 months

Pull request review commentminvws/nl-covid19-data-dashboard

Add situations data coverage choropleth

+import {+  SafetyRegionProperties,+  VrCollectionSituations,+} from '@corona-dashboard/common';+import css from '@styled-system/css';+import Check from '~/assets/check.svg';+import Cross from '~/assets/cross.svg';+import { Box } from '~/components/base';+import { TooltipContent } from '~/components/choropleth/tooltips/tooltip-content';+import { InlineText } from '~/components/typography';+import { useIntl } from '~/intl';+import { useReverseRouter } from '~/utils/use-reverse-router';+import { LegendIcon } from './legend-icon';++export function SituationsDataCoverageTooltip({+  context,+}: {+  context: SafetyRegionProperties & VrCollectionSituations;+}) {+  const { siteText } = useIntl();+  const text = siteText.brononderzoek;+  const reverseRouter = useReverseRouter();++  const Icon = context.has_sufficient_data ? Check : Cross;+  const color = context.has_sufficient_data ? 'data.primary' : 'gray';+  const label = context.has_sufficient_data

nit-nit; I'd destructure the variables from contexts to avoid this repetition.

VWSCoronaDashboard1

comment created time in 2 months

Pull request review commentminvws/nl-covid19-data-dashboard

Add situations data coverage choropleth

+import {+  SafetyRegionProperties,+  VrCollectionSituations,+} from '@corona-dashboard/common';+import css from '@styled-system/css';+import Check from '~/assets/check.svg';+import Cross from '~/assets/cross.svg';+import { Box } from '~/components/base';+import { TooltipContent } from '~/components/choropleth/tooltips/tooltip-content';+import { InlineText } from '~/components/typography';+import { useIntl } from '~/intl';+import { useReverseRouter } from '~/utils/use-reverse-router';+import { LegendIcon } from './legend-icon';++export function SituationsDataCoverageTooltip({+  context,+}: {+  context: SafetyRegionProperties & VrCollectionSituations;+}) {+  const { siteText } = useIntl();+  const text = siteText.brononderzoek;+  const reverseRouter = useReverseRouter();++  const Icon = context.has_sufficient_data ? Check : Cross;+  const color = context.has_sufficient_data ? 'data.primary' : 'gray';+  const label = context.has_sufficient_data+    ? text.situaties_kaarten_uitkomsten.tooltip.voldoende_data+    : text.situaties_kaarten_uitkomsten.tooltip.onvoldoende_data;++  return (+    context && (

Context can be undefined? Doesn't look like it from the props.

VWSCoronaDashboard1

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

startedant-design/ant-design

started time in 3 months

PullRequestReviewEvent